[00:01:34] dr0ptp4kt: is Grameenphone still set for Opera proxy? [00:01:51] dfoy: yes [00:02:07] dr0ptp4kt: ok thx [00:04:10] dbrant, you now haz accessz [00:04:28] MaxSem: yay! thx [00:36:25] (03PS1) 10MaxSem: Fix mobileview parameter description [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132325 (https://bugzilla.wikimedia.org/65035) [00:37:07] (03CR) 10jenkins-bot: [V: 04-1] Fix mobileview parameter description [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132325 (https://bugzilla.wikimedia.org/65035) (owner: 10MaxSem) [00:38:20] (03PS2) 10MaxSem: Fix mobileview parameter description [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132325 (https://bugzilla.wikimedia.org/65035) [08:10:58] (03PS12) 10Jdlrobson: DO NOT MERGE: Create script for checking css rule duplication [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129032 (https://bugzilla.wikimedia.org/64217) [08:11:00] (03PS1) 10Jdlrobson: Hygiene: Use truncated text class in overlay headers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132344 [08:11:02] (03PS1) 10Jdlrobson: Hygiene: Cleanup edit switcher css [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132345 (https://bugzilla.wikimedia.org/64968) [08:11:04] (03PS1) 10Jdlrobson: Hygiene: Cleanup main menu css border/background [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132346 [08:11:20] (03PS2) 10Jdlrobson: Hygiene: Use truncated text class in overlay headers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132344 [08:11:24] (03PS2) 10Jdlrobson: Hygiene: Cleanup edit switcher css [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132345 (https://bugzilla.wikimedia.org/64968) [08:11:30] (03PS3) 10Jdlrobson: Hygiene: Cleanup edit switcher css [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132345 (https://bugzilla.wikimedia.org/64968) [08:11:36] (03PS2) 10Jdlrobson: Hygiene: Cleanup main menu css border/background [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132346 [08:11:58] (03CR) 10jenkins-bot: [V: 04-1] DO NOT MERGE: Create script for checking css rule duplication [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/129032 (https://bugzilla.wikimedia.org/64217) (owner: 10Jdlrobson) [08:12:47] (03CR) 10Jdlrobson: "Please add some kind of tests.. please... pleaseeeee" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132130 (https://bugzilla.wikimedia.org/64867) (owner: 10MaxSem) [08:52:43] (03PS1) 10JGonera: Remove unused image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132354 [08:53:37] (03PS1) 10JGonera: Prevent horizontal scrollbar after menu closing animation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132356 [09:10:12] 3MobileFrontend / 3General/Unknown: mobile response: Error, edit not saved - 10https://bugzilla.wikimedia.org/64416#c8 (10Jon) 5PAT>3ASS Marking as assigned, let's check in a week to see if this reduces edit token errors. I'll personally verify this later. [09:30:13] 3Wikipedia App / 3Generic: Introduce MediaWiki:App.css or something in Extension:MobileApp - 10https://bugzilla.wikimedia.org/65037 (10Sam Reed (reedy)) [09:46:54] (03PS1) 10Jdlrobson: Hide uploads and nearby to non-JS users [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132368 [09:59:30] (03PS1) 10Jdlrobson: Regression: Don't show talk link on talk pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132371 [10:00:47] (03PS1) 10Jdlrobson: QA: Update the browser test article page for continue link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132373 [15:36:00] 3MobileFrontend / 3stable: Allow feedback for mobile beta features like Desktop - 10https://bugzilla.wikimedia.org/65078 (10Jon) 3NEW p:3Unprio s:3normal a:3None We should link to a talk/Flow page so people can provide feedback for our features. This seems to work very well on desktop and it's a sham... [15:36:12] 3MobileFrontend / 3Feature requests: Allow feedback for mobile beta features like Desktop - 10https://bugzilla.wikimedia.org/65078 (10Jon) [15:40:00] 3MobileFrontend / 3General/Unknown: Show what features are included in Beta and Experimental on mobile. - 10https://bugzilla.wikimedia.org/65079 (10Jared Zimmerman (WMF)) 3NEW p:3Unprio s:3normal a:3None Mobile users can't quickly see what features they are enabling when they turn on mobile beta or m... [15:40:08] (03PS2) 10Yuvipanda: Better scrolling when editing sections. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132197 (owner: 10Dbrant) [15:40:13] 3MobileFrontend / 3Feature requests: Allow feedback for mobile beta features like Desktop - 10https://bugzilla.wikimedia.org/65078 (10Jared Zimmerman (WMF)) [15:40:14] 3MobileFrontend / 3General/Unknown: Show what features are included in Beta and Experimental on mobile. - 10https://bugzilla.wikimedia.org/65079 (10Jared Zimmerman (WMF)) [15:40:28] 3MobileFrontend / 3General/Unknown: Show what features are included in Beta and Experimental on mobile. - 10https://bugzilla.wikimedia.org/65079#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/2e1pvTC8 [15:40:28] 3MobileFrontend / 3Feature requests: Allow feedback for mobile beta features like Desktop - 10https://bugzilla.wikimedia.org/65078#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/ylzNpAzW [15:41:27] 3MobileFrontend / 3Feature requests: Allow feedback for mobile beta features like Desktop - 10https://bugzilla.wikimedia.org/65078#c2 (10Jared Zimmerman (WMF)) are you planning on doing this per feature? or altogether, either way, please flow enable the talk page from day one…and see https://bugzilla.wikimed... [15:53:46] (03CR) 10Yuvipanda: [C: 032] Better scrolling when editing sections. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132197 (owner: 10Dbrant) [15:55:24] (03Merged) 10jenkins-bot: Better scrolling when editing sections. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132197 (owner: 10Dbrant) [15:58:24] (03PS2) 10Yuvipanda: Display "last updated" time correctly. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132203 (https://bugzilla.wikimedia.org/64136) (owner: 10Dbrant) [15:58:36] (03CR) 10Yuvipanda: [C: 032] Display "last updated" time correctly. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132203 (https://bugzilla.wikimedia.org/64136) (owner: 10Dbrant) [15:58:57] (03Merged) 10jenkins-bot: Display "last updated" time correctly. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132203 (https://bugzilla.wikimedia.org/64136) (owner: 10Dbrant) [16:05:17] (03PS3) 10Yuvipanda: Fixed clicking on links that have inner tags. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131994 (owner: 10Dbrant) [16:06:37] (03CR) 10Yuvipanda: [C: 032] Fixed clicking on links that have inner tags. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131994 (owner: 10Dbrant) [16:06:51] YuviPanda|zz: \o/ [16:06:52] (03Merged) 10jenkins-bot: Fixed clicking on links that have inner tags. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131994 (owner: 10Dbrant) [16:10:17] (03PS1) 10Yuvipanda: Version bump to 2.0-alpha-2014-05-09 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132450 [16:10:47] (03CR) 10Yuvipanda: [C: 032] Version bump to 2.0-alpha-2014-05-09 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132450 (owner: 10Yuvipanda) [16:11:07] (03Merged) 10jenkins-bot: Version bump to 2.0-alpha-2014-05-09 [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/132450 (owner: 10Yuvipanda) [16:15:36] hey dbrant|lunch! [16:15:47] will be out in a short while :( made a release though [16:15:51] * yuvipanda waves at Deskana  [16:16:02] Hey yuvipanda. [16:16:14] Deskana: I met Mr. Garry Sir's girlfriend here, I think [16:16:25] She said she saw you. :) [16:16:47] Deskana: :) [16:17:20] yuvipanda: awesome! thx [16:19:18] jdlrobson: hey? [16:19:29] upstairs! [16:20:51] (03CR) 10Cmcmahon: [C: 032] QA: Update the browser test article page for continue link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132373 (owner: 10Jdlrobson) [16:21:35] (03Merged) 10jenkins-bot: QA: Update the browser test article page for continue link [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132373 (owner: 10Jdlrobson) [17:10:43] MaxSem, ping [17:10:54] what was the issue with vagrant? [17:11:04] pong [17:11:09] I'll reply in gerrit [17:11:22] oki, but let me know, lets try to debug rather than remove [17:12:04] but basically it's that checking 600+ extensions is slow [17:13:12] true, but a) this is fairly rare, right? So we could have some optional setting to avoid it b) provisioning is extremelly rare occurance, and c) how long does it take without that patch? [17:13:26] no, this is for every provision [17:13:35] i understand that [17:13:36] so basically too slow for a no-op [17:14:00] i am saying that provising is a rare command (you wouldn't do it for most devs [17:14:11] and also - having 600 ext is very rare [17:14:34] plus, please check that it is much faster without my patch [17:14:40] this is something every regular dev should have [17:14:55] otherwise you will now know the impact of your core changes [17:15:14] we should encourage people to do this, not make it harder [17:15:21] 600? [17:15:25] I've over 700 [17:15:29] :) [17:15:31] whatever [17:15:40] GET IT RIGHT MAXSEM [17:17:40] dbrant: my ears are burning [17:18:03] dbrant: lemme know which patchsets, if any, are ready and you want me to review :) [17:18:43] dr0ptp4kt: Yuvi’s got ‘em all! [17:18:53] dbrant: cool [17:19:17] MaxSem, hold on, but why is my patch executing for all of your git repos? they should only execute while provisioning for the repos that are listed in roles [17:23:41] Deskana: https://releases.wikimedia.org/mobile/android/ [17:23:43] dbrant: --^ [17:27:16] dr0ptp4kt: heya! [17:27:24] mhurd yo [17:28:40] 1 sec, will take another look at it shortly [17:28:46] currently deep in CR [17:39:10] Deskana: i split off remaining ios event log story here: https://trello.com/c/Afq8I3Ly/110-complete-implementation-of-event-logging-calls [17:39:48] Deskana: did you want me to archive the old story? [17:42:29] mhurd: So new card = old card - bits that are done? [17:43:06] Deskana: more or less [17:43:18] mhurd: Sure, let's archive the old one then. [17:43:25] Deskana: k [17:43:57] Deskana: backlog the new one? [18:00:37] mhurd: Yep. [18:00:49] mhurd: We've got redesign work to focus on for the next sprint. Big priority! [18:01:01] Deskana: yay! :) [18:01:10] mhurd: I've moved it to the backlog. [18:01:24] Deskana: just saw it wink out of existence [18:02:52] The magical powers of the product manager... [18:03:43] Rarely observed, he protects his engineers from afar, hiding away irrelevancies and bringing the most important issues to the surface. [18:07:46] Product is life. [18:07:48] Product is happiness. [18:07:50] Product is almighty. [18:08:37] Product's tears heal cancer. Too bad product never cries. [18:11:39] Deskana: MaxSem hahaha [18:16:03] (03CR) 10Kaldari: [C: 032] Remove unused image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132354 (owner: 10JGonera) [18:16:42] (03CR) 10jenkins-bot: [V: 04-1] Remove unused image [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132354 (owner: 10JGonera) [18:33:23] MaxSem, yei! :D [18:33:36] sigh :P [19:01:05] (03CR) 10Dr0ptp4kt: "Anybody able to review this?" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/131246 (owner: 10Dr0ptp4kt) [19:01:16] dbrant: mind doing a first pass on ^ ? [19:02:48] dr0ptp4kt: sure, but I'm not familiar with the background of this... what would constitute a successful test? [19:05:14] I haven't yet begun to play around with any Zero-related functionality. [19:08:16] dbrant, good question. running a debug session on a real phone, you'd want to check that mccMnc is null when anything other than an active cellular connection is active. So after https://gerrit.wikimedia.org/r/#/c/131246/3/wikipedia/src/main/java/org/wikipedia/WikipediaApp.java in the assignment String mccMnc = Utils.getMccMnc; you would probably want to step through with a debugger to see how it behaves. The goal is to enrich the return [19:08:16] API object once so that the invoking code will add the X-MCCMNC header, but only if appropriate. The link in the commit message is a good place to get some backstory, too (you may want to go back and forward in the mail archives for wikimedia-l / mobile-l / wikitech-l, although there isn't tons of toher stuff) [19:09:38] dbrant: i did tests on the four major american cell networks with sims in and out, wifi on and off, vpn on and off, and so on. it seems to work pretty well. for your sake, you'd probably just want to test with a device that only has the cellular data turned on (no wifi, or known wifi ap out of reach) [19:10:15] dr0ptp4kt: aha, I see; I will try it [19:10:52] dr0ptp4kt: speaking of which, how do I go about "simulating" Zero being enabled? [19:10:56] dbrant: thanks. no rush, of course. figured if you could do a little poking then yp/bv could look at it further [19:11:39] dbrant: if you have an internet facing source ip address that you're pretty sure is allocated to your connection, you can pm or email it to me, and i can add it quickly to a config so that you can feel the love [19:13:43] dbrant: what i do to simulate hopping around on networks is toggle wifi/mobile data and also use different wifi APs and mobile networks for good measure. tinfoil also helps. as you may notice in the zero-related code, state change onXYZ events and the broadcast receiver listener try to avoid unnecessary network calls. would have been easier to make more network calls, but we wanted to avoid that sort of thing; granted, we're firing lots [19:13:43] EventLogging hits at this point, but i think the design on the zero side of things is still pretty much sufficient; that is, no need to make lots of extra network calls now that our finite state machine of sorts is working [19:14:44] dbrant: and i add/remove exit ips in our configuration store... [19:15:17] dr0ptp4kt: excellent; good to know! [19:17:44] dbrant, heading to lunch. ttyl. handle namedrop me if need anything and i'll see it on irc unless netsplits make client go boom like some fridays! :) [19:17:58] dr0ptp4kt: alright; thanks! [19:32:38] * Deskana just realised who dr0ptp4kt is. [19:32:52] dr0ptp4kt: I thought you were just a very eager volunteer developer! [19:33:01] ! [19:33:34] Or, to be more precise, I thought the person who used the dr0ptp4kt name was a volunteer. I knew who you were. :P [19:33:55] (03PS3) 10Yurik: Ignore $wgMobileUrlTemplate when host is an IP address [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/131736 [19:34:22] dbrant: That reminds me, I had something to ask you! [19:34:37] by all means! [19:34:49] dbrant: Next Wednesday I'm flying to Ohio. I'll be there for two weeks. [19:34:53] dbrant: We should meet for lunch one day! [19:35:31] Deskana: Brilliant! I would love it [19:35:33] dbrant: I'll be Ashland, around an hour's drive from Cleveland, so we could meet in Cleveland. [19:36:20] Deskana: I'll be happy to make the drive... but I think the food scene is better in Cleveland [19:36:41] dbrant: Yeah, that's fine. We have easy access to a car there so it's no problem. [19:37:01] dbrant: Tuesday 20th May would probably be the best day for me, but I'll let you know a bit closer to the time. [19:37:38] Deskana: well alright! that'll be great [19:38:15] Woot! [19:39:27] 32 PHP Fatal error: Call to a member function isAnon() on a non-object in /usr/local/apache/common-local/php-1.24wmf3/extensions/MobileFrontend/includes/specials/SpecialUploads.php on line 19 [19:48:15] Deskana: :) [19:51:32] MaxSem, just for you :) https://gerrit.wikimedia.org/r/#/c/131736/ [19:52:57] 3MobileFrontend / 3General/Unknown: PHP Fatal error: Call to a member function isAnon() on a non-object in SpecialUploads.php on line 19 - 10https://bugzilla.wikimedia.org/65094 (10Rainer Rillke @commons.wikimedia) [19:55:27] 3MobileFrontend / 3General/Unknown: PHP Fatal error: Call to a member function isAnon() on a non-object in SpecialUploads.php on line 19 - 10https://bugzilla.wikimedia.org/65094#c1 (10Bingle) Prioritization and scheduling of this bug is tracked on Trello card https://trello.com/c/rNcNjUEt [21:05:38] kaity|away: you around? [21:06:05] kaity|away: I need to get assets for the VE citation stuff [21:06:24] moizsyed: you know if kaity is around today? [21:06:33] hmm [21:06:43] she must be working from home [21:09:39] moizsyed: How are things going for the iOS app redesign? :) [21:09:52] \o/ give us pretty menus! [21:09:53] well [21:09:58] im at the hackathon [21:10:01] so nothing yet [21:10:04] hehe [21:10:15] that’s no excuse, i got a random patch committed and i’m here [21:10:17] hows work coming at sf? Deskana [21:10:47] *crickets* [21:11:06] moizsyed: The sprint begins on Monday. Do you think you'll have the assets ready by then? [21:11:15] yeah we'll have it ready [21:11:25] moizsyed: Very... quietly. Most people are working from home today because nobody's around. [21:11:36] moizsyed: That's great. Thanks. :) [21:12:11] do you have list of assets i need to give? [21:12:27] “it’s too loud in the office, i’m working from home!” [21:12:33] “it’s too quiet in the office, i’m working from home!” [21:12:39] * brion says the king of working from home [21:13:12] moizsyed: So basically it's a version of this where you're happy to say "Yeah, implement it this way!": https://trello.com/c/rwpQuBAF/81-new-new-design [21:14:30] alright [21:14:33] i'll get this ready [21:14:43] moizsyed: \o/ [21:15:04] moizsyed: Thanks! Sorry I left it so late to prod you about it... still getting used to the Apps way of doing things. [21:15:14] nah its all good [21:15:18] dont worry, will get it done [21:16:23] brion: I personally don't get distracted by noise and busyness. Having people around is why I come into the office. :) [21:16:36] :) [21:16:48] pssssh people persons [21:16:58] Plus my job is to work with people rather than to program, so that's the other aspect. [21:18:22] I often found the office a distraction in my previous job, particularly when I was working on implementing a solution to a particularly tricky problem. [21:22:15] 3Wikipedia App / 3Generic: iOS App: Saved pages were cleared in upgrade from beta #14 -> #15 - 10https://bugzilla.wikimedia.org/65106 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None Not sure if it was intentional or not, but my saved pages (I had 2 of them) were cleared when I upgraded fro... [21:22:27] 3Wikipedia App / 3Generic: iOS App: Saved pages were cleared in upgrade from beta #14 -> #15 - 10https://bugzilla.wikimedia.org/65106 (10Kunal Mehta (Legoktm)) [21:27:14] 3Wikipedia App / 3Generic: iOS App: If a page is saved, "Save foo for offline reading" menu item is still visible - 10https://bugzilla.wikimedia.org/65107 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None I saved a page, but when I go to the menu, I'm still given the option to save it for of... [21:28:57] 3Wikipedia App / 3Generic: Edit link loads the wrong section in some cases - 10https://bugzilla.wikimedia.org/63874#c2 (10Dmitry Brant) So, after some intense investigating, here are some of my findings: - In the article linked above, the first section is built from a template (not transcluded from a differ... [21:31:15] MaxSem: don't forget about https://gerrit.wikimedia.org/r/#/c/120696/ [21:41:06] (03PS1) 10MaxSem: Fix username handling on Special:Uploads [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132518 (https://bugzilla.wikimedia.org/65094) [21:49:27] 3Wikipedia App / 3Generic: iOS App: Make sure that app updates don't wipe saved pages. - 10https://bugzilla.wikimedia.org/65106#c1 (10Dan Garry) (In reply to Kunal Mehta (Legoktm) from comment #0) > Not sure if it was intentional or not, but my saved pages (I had 2 of them) > were cleared when I upgraded fro... [21:52:27] 3Wikipedia App / 3Generic: iOS App: Make sure that app updates don't wipe saved pages. - 10https://bugzilla.wikimedia.org/65106#c2 (10Brion Vibber) There was also a bump in internal versioning in the iOS betas, which we didn't include an upgrade for as it was a funky transition in the data model. We should... [21:59:14] 3Wikipedia App / 3Generic: iOS App: Links to sections don't work, and anchor shows up in title - 10https://bugzilla.wikimedia.org/65108 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3None Created attachment 15331 --> https://bugzilla.wikimedia.org/attachment.cgi?id=15331&action=edit screensh... [22:45:36] (03PS1) 10Jjanes: Fix watchlist query to work with PostgreSQL [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/132586 (https://bugzilla.wikimedia.org/46745) [22:49:24] (03PS1) 10Mhurd: Anonymous editing killswitch. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/132587 [22:52:36] brion: dr0ptp4kt: anyone up for some cr? :) (see above) [22:52:56] mhurd: i can be in about 30 minutes [22:52:57] \o/ [22:52:58] sure [22:53:06] brion, if you got it, lemme know [22:53:16] it’s 1am here but i’m well caffeinated :D [22:53:21] hehe [22:54:00] nice making the sync generic so we can reuse it for css :D [22:54:24] brion: yes! that’s what i was hoping :) [22:54:27] heh isRefreshNeededForBundledJsonFile [22:54:30] obj-c :D [22:54:32] brion: lol [22:55:27] hmm, should the interface return a mutable or an immutable dictionary by default? i guess it doesn’t make much difference for an internal api like this [22:55:28] brion: yeah, can more properly “objectify” in future pass, then such silliness would be redundant for a proper “bundledJson” obj [22:55:35] it’s easier with languages that only have a single array type ;) [22:55:39] “jsut use an array" [22:55:48] brion: hmm lemme see… [22:58:06] brion: just switched them to not mutable… seems to compile. testing… [22:58:26] hmm does NSJSONSerialization JSONObjectWithData return an NSArray on [foo]? or do we have to call a separate one, i forget …. [22:58:31] my head is filled with java ;) [22:58:49] ok just one method, good [22:59:01] brion: it returns one of those weird objects that can cast to either [22:59:07] yeah [22:59:07] core foundation obj [22:59:17] so glad we don’t have to (NSMutableObject *)everything [22:59:26] automagic casting! [22:59:29] hehe yeah [23:00:56] brion: oh, to test the kill switch flag on simulator you can browse to the simulator file system folder, and do “show package contents” on the “wikipedia.app” file, the open the /config/ios.json and change the flag [23:01:04] ah nice [23:01:07] simulator <3 [23:02:23] brion: i’ve bookmarked the simlulator folder in finder: “~Library/Application Support/iPhone Simulator“ iirc [23:02:36] heh [23:03:08] i like the .h files sort before .m files in the code review order [23:03:18] would drive me nuts with .c and .h :D [23:05:10] brion: hehe yeah [23:05:18] brion: ok seems to work fine immutable [23:05:20] amending [23:05:22] mhurd: wait, is this updating the file in the bundle, or saving a copy in writable dir? [23:05:34] suddenly i’m not sure if we have write permissions inside the app bundle [23:05:53] * brion is paranoid [23:06:02] brion: lemme check... [23:06:12] might be one of those simulator/device gotchas [23:07:22] brion: oh good point - checking on device [23:07:31] (03CR) 10Brion VIBBER: Anonymous editing killswitch. (031 comment) [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/132587 (owner: 10Mhurd) [23:07:45] other than that just noticed one possible minor push/pop imbalance [23:07:50] in the network spinner [23:07:55] lemme find my iphone and fire it up too [23:08:29] Can anyone do code review on this? [23:08:31] https://gerrit.wikimedia.org/r/#/c/132584/ [23:08:43] It's a bug that affects user login in general, including Web and Apps. [23:09:23] eek [23:10:01] heh [23:11:19] brion: i think you’re right about bundle writes - amending [23:11:22] Deskana: looks good lemme test [23:14:44] Deskana: +2’d [23:17:54] (03CR) 10Brion VIBBER: "Adding a note from IRC discussion: we're not sure we can actually edit the bundle files on device, may need to store a copy." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/132587 (owner: 10Mhurd) [23:37:12] brion: i almost have the folder moved to the writable documents dir [23:37:32] woo [23:49:33] brion: Thanks a lot! :D [23:49:38] \o/