[00:05:24] chrismcmahon: the quotes are on purpose - i think they should be a convention [00:05:30] in long sentences it can get confusing [00:05:46] chrismcmahon: maybe something for the QA mailing list? [00:17:06] kenanwang_: are you going to be able to post the january engineering report today? [00:18:36] (03PS6) 10Kaldari: Story 1643: Improve typography for overlays [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111374 [00:22:49] kenanwang_: Did you see my ping from earlier? [00:23:10] hey can you send to me again? [00:23:16] kaldari^ [00:23:29] kenanwang_: just need your reply at https://bugzilla.wikimedia.org/show_bug.cgi?id=60103 [00:24:12] kenanwang_: basically just need to know if you are only seeing weird selecting bevavoir on articles with images or all articles. [00:24:39] kenanwang_: So I can narrow down what the bug is [00:26:13] kaldari I responded [00:26:21] thanks!!!11 [00:26:33] it might not just be images does it also happen with info boxes? [00:26:54] also you said you didn't reproduce it on an iphone but shouldn't VE not work on iphones/ [00:26:55] ? [00:29:26] one sec... [00:32:34] vbamba: "Georgia + Arial combination" are we ditching Helvetica for now? [00:35:09] kaldari: no I just want to see what it looks like [00:35:19] ah, ok [00:35:23] kaldari: if a user doesnt have Helvetica as base font [00:35:35] We only tested this a long time ago for mobile web [00:35:35] good idea [00:55:33] kaldari: is I23dbeca08084beadb21ea2f323cc43aa80f0db78 live on enwiki [01:05:17] (03Abandoned) 10Jdlrobson: Experiment: Special:MobileWebApp and manifests for offline FF & Chrome, FFOS + CWS. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/100919 (owner: 10Jdlrobson) [01:05:39] (03PS4) 10Jdlrobson: Special:MobileWebApp and Special:Manifests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111394 [01:05:45] (03PS4) 10Jdlrobson: SpecialMobileWebApp: Make styles and startup scripts cache [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111485 [01:11:48] awjr: you about? [01:11:53] tfinc: yep [01:12:01] what's up? [01:12:10] not seeing bugello do any work [01:12:13] o_O [01:12:15] it should be dropping work into https://trello.com/b/dERUPQeW/mobile-app-sprint-24-login-editing [01:12:19] and its user name is on the board [01:12:32] tfinc will investigate as soon as i finish posting the mobile web eng report [01:12:37] thank [01:12:49] s [01:14:05] (03PS1) 10Dr0ptp4kt: Add basic Wikipedia Zero alerts for iOS. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/111689 [01:16:06] (03PS2) 10Dr0ptp4kt: Add basic Wikipedia Zero alerts for iOS. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/111689 [01:17:17] tfinc your list names have changed [01:17:29] i think that's probably the problem [01:17:35] bugello looks for a list called 'Ready for Dev' [01:17:44] which i don't see on the latest board [01:18:19] last time bugello apparently successfully ran was 12/10 [01:18:44] tfinc should i tell bugello to drop bugs into 'To Do'? [01:18:48] (03CR) 10Dr0ptp4kt: "Monte, I believe this was the basic thing you wanted to see first." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/111689 (owner: 10Dr0ptp4kt) [01:20:28] huh looks like it once used 'To Do' but got switched to 'Ready for Dev' at some point [01:22:26] tfinc i went ahead and updated the boar name in bugello config and ran it, looks like it backfilled open bugs from 12/10 til now [01:22:34] should run OK [01:28:33] thanks! [01:33:05] (03CR) 10Kaldari: [C: 04-1] "page list on watchlist needs a top border now. Otherwise, I think it's good." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94435 (owner: 10Jdlrobson) [01:38:12] jgonera: kaldari is jon gone for the day? [01:38:18] looks like i just missed him [08:16:49] MaxSem, hi. [08:16:58] yo [08:17:39] MaxSem, I was referred to you to ask what you think of using the 'main page hack' -- the one of not showing edit button and only showing content whose id starts with 'mf-' -- at pages other than main page, such as pages whose content is a part of a wizard :) [08:18:27] * MaxSem thinks nothing good of it [08:18:38] Ah. Anything bad? [08:19:24] whaddaya want?;) [08:19:49] To make a simplified article wizard for a mobile. WP:WIZ is unreadable there. [08:20:32] we're moving away from DOM transformations [08:20:49] new instances of it shouldn't be introduced [08:29:26] what are you moving to? [08:31:45] to not doing it [08:34:40] regexes [08:34:41] :P [08:36:15] * MaxSem runs to woods for twigs for yuvipanda's auto da fe [08:36:30] what's an auto da fe [08:36:40] sinners [08:36:47] burnt at stake [08:43:26] That's not really helpful to one who wants to write a mobile wizard or some like. [08:44:10] write mobile-friendly HTML [08:44:44] and not hope that software will magically fix everything for you [08:47:27] OK. I'll ignore the edit button then and assume it'll always be there. [08:47:47] You're right, the mobile users should be able to edit it like desktop ones... [09:01:44] MaxSem: think you can take a look at https://gerrit.wikimedia.org/r/#/c/111738/ [09:05:30] looks reasonable [09:05:46] MaxSem: thoughts on using revtagging vs special:log? [09:06:11] eh [09:06:20] for this particular thing [13:09:47] Hi . I am an android developer . I just came across your projects . As i am new to gsoc , please guide me how to choose a project and how to start coding in it ? [15:02:31] nateshr, have you checked out https://www.mediawiki.org/wiki/Mobile ? [15:02:52] it's up to you to find a project and an idea that interests you. [15:03:06] Checking out and playing with the code beforehand is helpful, of course. [15:03:16] https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker [15:28:39] did someone say mobile?:) [15:59:46] mobilemobilemobilemobilemobilemobilemobile [16:03:04] nateshr, you asked something? [16:04:42] I want to know how can i start to code in your projects ? [16:05:11] and i have interest in the wiki news app which is under the raw projects [16:05:15] so how can i start ? [16:06:29] so you want to contribute to apps? yuvipanda should know more [16:07:29] he didn't reply yet .! [16:49:48] (03CR) 10Greg Grossmeier: "Hey, this was merged on Saturday, a little late for it to go out today as a BF (we agreed on about a week on the BetaCluster without issue" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/102866 (owner: 10Jdlrobson) [16:52:00] oh, good, it did show up in here [16:52:07] all, see my comment above ^^^ :) [17:08:49] MaxSem: ^^^ since you're around [17:10:44] is there a way to disable a beta feature via config? [17:10:58] you need a featureflag I guess [17:11:27] MaxSem: do you have +2 on mediawiki-config? :D for a betalabs commit that hashar was completely okay with [17:11:40] he just had terrible internet and couldn't hit merge [17:11:51] yep, but not merging while outage is in progress [17:12:06] MaxSem: oh, there's an outage? [17:12:28] Y U NO READ #-ops?:P [17:14:21] MaxSem: I was in r/outside! [17:15:47] MaxSem: this one, fwiw https://gerrit.wikimedia.org/r/#/c/111765/ [17:28:41] MaxSem: feature flag, as yuvi said. [17:56:38] awjr: just pointing out https://gerrit.wikimedia.org/r/102866 [17:56:42] (my last comment) [17:56:47] * greg-g goes to a coffee shop or something back in a bit [18:01:00] yuvipanda: joining us? [18:01:05] awjr: yup! [18:01:08] :D [18:03:30] hmm greg-g, Sat - Thur is almost a week, no?:P [18:09:23] awjr: there was also the deal with AbuseFilter and Editing :) [18:26:13] awjr: saw that email. Replying now, sorry this took me so long. [18:33:44] rmoen|away: check your email - VE broke again :( [18:34:12] i hope broken VE is not going to end up on the deployment train :( [18:47:47] damn, I missed kaldari [18:58:25] andre__: thanks! [18:58:44] thanks for setting it up, awjr [18:59:05] kaldari: https://www.dropbox.com/s/ez3x8lliew37f2a/Screenshot%202014-02-06%2023.12.29.png wikilove now :) [18:59:08] (with unmerged patches) [18:59:16] I still need to fix the form though [18:59:22] yuvipanda: Woo. [18:59:26] James_F: :D [18:59:47] James_F: I've some RTL fixes that I need to do, but I should be able to get them done today :) [18:59:49] yuvipanda: You need before and after screenshots for the Tech/News newsletter. :-) [19:00:01] James_F: before: https://www.dropbox.com/s/mdx7frtablxebiy/Screenshot%202014-02-06%2023.12.45.png [19:00:24] yuvipanda: :D thanks for being willing to help out - i think this is really exciting :) [19:00:31] awjr: +1 :) [19:00:44] yuvipanda: yeah the rtl support for Wikilove was a pain in the ass to get right :P [19:01:14] kaldari: heh, yeah. I got rid of all the button specific stuff there. At least two designers (May and prateek) wanted to redo the defualt icons as well :) [19:01:23] kaldari: the CSS is also partly LESS now [19:01:28] yay [19:01:56] the designers don't like my kitty?? [19:01:56] kaldari: James_F zz_prtksxna also did a lot of the CSS / Design work. [19:02:05] kaldari: apparently it isn't flat enough? :P [19:02:18] No! don't smoosh the kitty! [19:02:21] hehe :D [19:02:28] well, first you smoosh the burger... [19:02:44] kaldari: either way, https://gerrit.wikimedia.org/r/#/c/111825/ and https://gerrit.wikimedia.org/r/#/c/111771/ [19:07:56] jdlrobson: Shahyar apparently [19:23:16] greg-g, Sat - Thur is almost a week, no?:P [19:23:53] MaxSem: almost only counts in hand grenades and... what's the other? [19:24:19] (03PS3) 10Dr0ptp4kt: Add basic Wikipedia Zero alerts for iOS. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/111689 [19:25:24] dr0ptp4kt: looking at the code now [19:25:33] yuvipanda, thanks! [19:25:37] dr0ptp4kt: :) [19:26:08] dr0ptp4kt: two patches? https://gerrit.wikimedia.org/r/#/c/107992/10 and https://gerrit.wikimedia.org/r/#/c/110665/ [19:26:09] ? [19:26:16] just those, right? [19:26:24] yuvipanda: yep [19:26:30] dr0ptp4kt: ok, looking now [19:26:47] i shouldn't have forked from the initial patch, i should have just stayed on it [19:27:02] 'tis ok :) [19:28:30] (03PS1) 10Jdlrobson: Regression: Style nearby/language button correctly in alpha [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111836 [19:29:23] yuvipanda: yo [19:29:28] tfinc: hey! [19:29:54] yuvipanda: can you take a triage pass on https://trello.com/b/dERUPQeW/mobile-app-sprint-24-login-editing to do column to filter bugs that have already been fixe don Android? [19:30:10] tfinc: looking [19:30:15] awjr got bugello running again [19:30:23] :D [19:30:33] yuvipanda: just do a triage pass and then kenanwang_ can prioritize [19:30:39] tfinc: should I archive the fixed ones? [19:30:42] yes [19:31:13] tfinc: ok [19:31:28] brion: do help out yuvi in the pass [19:31:38] brion: yuvipanda have you guys seen monte today? [19:32:11] will do [19:32:13] not on irc no [19:34:07] tfinc: done [19:34:24] tfinc: closed out a couple, recategorized one, and one I am not sure if it is iOS or Android [19:34:31] thanks [19:34:43] brion: can you do an iOS pass on the list and archive and resolve what isn't valid anymore ? [19:34:44] tfinc: yw [19:35:00] ok [19:36:25] dr0ptp4kt: is there any way at all for me to test https://gerrit.wikimedia.org/r/#/c/107992/10 [19:36:57] tfinc: as far as i know all the bugs reported in the last couple days are still valid, i don't remember any changes that would change them yet [19:37:04] brion: thanks [19:37:12] i'll get kenan to do a triage pass [19:37:17] spiff [19:37:23] some of those look like easy fixes [19:38:02] brion: did you see https://www.dropbox.com/s/ez3x8lliew37f2a/Screenshot%202014-02-06%2023.12.29.png? :) Used to look like https://www.dropbox.com/s/mdx7frtablxebiy/Screenshot%202014-02-06%2023.12.45.png [19:38:26] * brion head desk. just spent 5 minutes looking for my iPhone, it was in my pocket [19:38:32] hehe [19:38:37] brion: ETOOMANYPHONES [19:38:42] :) [19:38:58] yuvipanda: nice [19:48:32] dr0ptp4kt: ping? any way for me to test it? I am okay merging it on your word that it 'works', but just wanted to know [20:06:28] yuvipanda: probably the easiest way for that one is to set a breakpoint at the following line in ConnectionChangeReceiver: Log.d("Wikipedia", "Wikipedia Zero Eligibility Status: " + result); [20:06:54] dr0ptp4kt: but I guess it will return false for me? :) [20:07:10] yuvipanda: then toggle the result as you see fit. you will want to toggle between wifi networks, wifi + cell, just cell, etc. [20:07:18] hmm [20:07:29] yuvipanda: it will return false for you, correct. [20:08:48] yuvipanda: of course 107992/10 is overly aggressive with checking the service, hence it's dependent patch scaling it back so much (per our chat) [20:08:55] right [20:08:56] t [20:08:57] s/it's/its/ [20:09:34] anyone familiar with cucumber? https://gist.github.com/MaxSem/74dd67828e2c22cf0610 [20:10:22] dr0ptp4kt: primary comment on the next patch is the naming convention for IDs. [20:10:36] dr0ptp4kt: always prefix them! All ids are gloabl in Android (sucks, I know), so we need to prefix them [20:10:53] navbar should be search_navbar or somesuch (see what is the prefix for other things in that res file) [20:11:54] yuvipanda: cool, makes sense. alright, lemme know once i should take another look. argh, looks like there will be more rebase fun [20:12:04] dr0ptp4kt: shouldn't be too much, I think [20:13:00] yuvipanda: good :) [20:13:13] dr0ptp4kt: :) [20:23:11] (03PS4) 10Dr0ptp4kt: Add basic Wikipedia Zero alerts for iOS. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/111689 [20:31:53] dr0ptp4kt: ok, gonna merge now [20:32:10] yuvipanda: thx [20:32:17] (03CR) 10Yuvipanda: [C: 032 V: 032] "The message is a bit SHOUTY, but we can fix that later." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107992 (owner: 10Dr0ptp4kt) [20:32:31] dr0ptp4kt: what, it tells me it needs rebase *now* :| [20:32:35] it didn't tell me it a while ago [20:32:40] dr0ptp4kt: let me rebase [20:33:37] jgonera, any ideas what's causing this>>> https://gist.github.com/MaxSem/74dd67828e2c22cf0610 ? [20:33:43] dr0ptp4kt: rebased :) [20:33:45] (03PS11) 10Yuvipanda: Add basic Wikipedia Zero detection. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107992 (owner: 10Dr0ptp4kt) [20:33:48] dr0ptp4kt: let me merge [20:34:07] (03CR) 10Yuvipanda: [C: 032 V: 032] "(Last PS just a trivial rebase)" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/107992 (owner: 10Dr0ptp4kt) [20:34:23] MaxSem will check in a moment [20:35:13] dr0ptp4kt: I am going to head to sleep. will check on the second patch tomorrow. The naming fix is the one that jumps out to me atm. [20:35:30] yuvipanda: cool man. get your rest, be healthy. [20:35:36] dr0ptp4kt: will try :) [20:35:38] dr0ptp4kt: thanks for the patch! [20:36:12] yuvipanda: NO, thank YOU (SHOUTING!) [20:36:19] dr0ptp4kt: heh :D [20:38:35] lunch & errands, back in a bit [20:57:03] hey violetto [21:01:53] yuvipanda: hey! [21:02:27] hey violetto [21:02:39] violetto: I emailed the design list about WikiLove :) [21:03:07] yuvipanda: i also added that we're using agora styling too [21:07:01] violetto: vibha responded as well, but forgot to use reply-all. I'll add that back [21:07:30] vbamba: you forgot to reply that to the list :) [21:07:55] ohno did I just hit Reply? [21:08:08] vbamba: yup :) [21:09:25] kaldari: any idea why the chrome has reverted to the old one on enwiki? [21:12:14] mmm according to mobile when i click edit it tells me i'm blocked [21:12:40] MaxSem, can you send me this gist again? [21:12:52] mw.config.get( 'wgMFIsUserBlocked' ) > resolves to true [21:13:00] jgonera, https://gist.github.com/MaxSem/74dd67828e2c22cf0610 [21:13:38] MaxSem, do you use rvm? [21:14:00] nope, I'm trying to make the vagrant role work [21:14:50] hm, can't say much about that... which role? [21:15:05] browsertests [21:15:44] then if that role is not using rvm, it's pretty much broken, browsertests require ruby 2.0.0 or even 2.1.0 which is definitely not bundled with Ubuntu [21:15:51] who wrote that role? who maintains it? [21:17:48] Ori and Zeljko [21:19:44] kenanwang_: you about ? [21:23:26] jgonera: kaldari https://bugzilla.wikimedia.org/show_bug.cgi?id=60993 [21:29:34] jdlrobson, maybe office IP is blocked? [21:29:41] MaxSem: does it work for you? [21:29:45] yep [21:29:51] MaxSem: more worringly effects non-logged in users.. :/ [21:30:45] jdlrobson: returns 'false' for me both logged out and in [21:31:09] MaxSem: isn't there an 'autoblock' that prevents IPs from editing even if they are logged in? [21:32:54] yuvipanda, depending on the block [21:33:03] MaxSem: right. [21:33:17] jdlrobson, can you edit while logged off on desktop? [21:34:02] Tfinc I was at lunch [21:34:24] MaxSem: yup [21:34:26] https://en.wikipedia.org/wiki/User:Jdlrobson/Sandbox [21:34:45] that's logged in;) [21:36:02] ahaha [21:36:02] 'wgMFIsUserBlocked' => $user->isBlocked(), [21:36:03] (03PS1) 10Jdlrobson: Limit blocked test to logged in users. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111899 [21:36:31] ^ MaxSem that's probably a good idea [21:37:00] this change pretends that anons can't be blocked [21:37:57] MaxSem: I know but I added a FIXME [21:38:09] since this is now stuck in cache [21:38:23] i have no idea why though it is showing for logged in people in the office [21:38:33] I'd prefer to not set this var for anons at all to avoid giving an unfounded hope:) [21:38:38] why would $user->isBlocked() return true for a non logged in user [21:38:44] MaxSem: yeh that would make sense too [21:38:55] still not quite to the bottom of this matter though [21:39:07] because of IP blocks or autoblocks. then it gets cached [21:39:15] bang! [21:42:26] (03PS17) 10Jdlrobson: Story 1589: Use the same chrome on special pages as article pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94435 [21:43:16] MaxSem: so $user->isBlocked() returns true if an IP is blocked but not the username? THat seems broken.. [21:44:17] no it's not - it returns true if there are currently blocks affecting the user [21:44:36] the origin of these blocks is irrelevant in this case [21:48:43] jdlrobson: you guys still trying to figure out that block issue? [21:48:54] MaxSem: ok so really it means isUserMarkedInSomewayAsBlocked [21:48:56] brion: yup [21:49:10] fun [21:49:13] semantics [21:49:30] MaxSem: so what you are saying is user->isBlocked does not necessarily mean ! user->canEdit [21:49:48] That's real nasty and a bug in my opinion [21:50:06] of course. most non-blocked users can'r edit protected pages, for example:) [21:50:16] well, user is blocked from what, is the question :) [21:51:13] do you get an actual error trying to edit anything? [21:51:51] so far nothing confirmed, just shotgun debugging [21:51:58] one problem already found though [21:53:09] is it a mobile issue or a minerva skin issue? [21:54:17] i don't seem to have any problems with being blocked here... [21:55:40] hmm, can't force minerva skin on desktop? darn [21:57:20] just to confirm -- you get the same on any non-admin account? do you get the same on local wifi and on mobile networks? it's definitely not related tot he IP you're coming from? [21:59:03] i am able to edit from a non-admin account via mobile [21:59:12] brion: jdlrobson kaldari jgonera ^ [21:59:37] is it possible that someone iprangeblocked the office? [21:59:48] i cannot edit while anon from the office. [21:59:57] sounds plausible, but i would expect that would block non-mobile edits too [22:00:19] i am allowed to do so when logged in. [22:00:24] but that account is +staff [22:01:11] i am not allowed to edit when logged into my non-staff account. [22:01:20] so clearly +sysop or +staff overrides it. [22:01:31] and seems to only affect the office [22:01:33] I can edit anonymously on en.wiki on desktop [22:01:45] yeah, this is a mobile skin/gateway problem [22:02:09] did this just happena fter today's deployment? [22:02:40] desktop seems completely unaffected, all tests being equal. [22:02:47] I believe so, although the deployment was rolled-back apparenty (which usually causes weird problems) [22:02:52] opening my notifications tab hangs, though. [22:03:47] kaldari: what do you see at https://en.wikipedia.org/w/index.php?title=Tariqul_Hassan&useformat=mobile vs https://en.m.wikipedia.org/w/index.php?title=Tariqul_Hassan&useformat=mobile ? do they both say blocked? [22:04:33] just want to confirm that there's not something like the load balancers are blocked :) [22:04:37] anybody cmoing to the prioritization meeting? [22:04:48] jgonera: kenanwang_ kaity ? [22:04:53] brion: I can edit the first, but not the 2nd [22:04:55] (03PS2) 10Jdlrobson: Limit blocked test to logged in users. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111899 [22:05:05] (03PS1) 10Jdlrobson: Fix the header buttons on watchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111908 [22:05:23] kaldari: ok that's very interesting. that makes me think it *is* IP-related, and something in the load balancer/cache chain is incorrectly marked as blocked somehow [22:05:25] coming. someone was using elder [22:05:53] brion: that sounds like a good theory [22:06:09] awjr: sorry were here [22:06:42] is there any way to pull up the desktop view on the en.m.wikipedia.org domain? [22:06:54] that would allow using the regular edit interface which should show you the reason you are blocked [22:07:03] which should help us track it down [22:07:54] kaldari: try https://en.m.wikipedia.org/w/index.php?title=Tariqul_Hassan&useformat=desktop&action=edit [22:08:13] "You are currently unable to edit pages on Wikipedia due to an autoblock affecting your IP address." [22:08:21] \o/ ok that helps [22:08:27] i don't suppose we know which auto block it is :D [22:09:23] kaldari, what's the office IP? [22:09:33] check ipv6 too [22:09:52] if it's the office ip though it really should be applying to both [22:10:11] ok, I fixed it [22:10:33] should be able to edit now [22:10:43] ! \o/ [22:11:02] Looks like it was related to the block of User:Astrainternationalbmw [22:11:33] we've got us spammers in the office? [22:13:52] ok so the question is, what IP got autoblocked? [22:14:08] and why was it something that only turned up in the en.m.wikipedia.org path? [22:14:13] but not in the en.wikipedia.org path? [22:14:19] brion: hey! [22:14:25] yo [22:14:53] brion: would you have few minutes to review the nav bar refactor? [22:14:53] so does en.m have it's own loadbalancing or something? [22:15:24] kaldari: *.m.* goes to mobile-lb.(datacenter).wikimedia.org [22:15:33] others go to text-lb.(datacenter).wikimedia.org [22:15:41] they have, or had, separate caching [22:15:44] i assume still do [22:16:36] (03PS1) 10Mhurd: Top nav bar controls can now easier to customize. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/111909 [22:16:48] mhurd: moment [22:16:56] brion: ^ hehe i should have proof read that a bit [22:17:20] i wonder whether we're missing something from https://noc.wikimedia.org/conf/highlight.php?file=squid.php proxy lists [22:17:42] (03PS3) 10Jdlrobson: Limit blocked test to logged in users. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111899 [22:17:53] ^ kaldari MaxSem good idea to merge that to avoid caching issues [22:18:15] (03PS2) 10Mhurd: Top nav bar controls now easier to customize. [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/111909 [22:18:32] i updated the commit msg [22:19:28] (03CR) 10MaxSem: [C: 031] Limit blocked test to logged in users. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111899 (owner: 10Jdlrobson) [22:22:10] (03CR) 10Mhurd: "I still need to make the other View Controller listen for new "NavItemTapped" msg for consistency." [apps/ios/wikipedia] - 10https://gerrit.wikimedia.org/r/111909 (owner: 10Mhurd) [22:22:39] thanks MaxSem [22:24:50] brion: is anyone going to get upset if I look up the user's IP address? [22:25:04] actually, maybe you should do it :) [22:25:45] kaldari, nobody's gonna know if you use direct SQL access:P [22:26:26] since I investigated this problem before, can do it again [22:26:40] I assume you can just search cu_changes for Astrainternationalbmw [22:26:41] i'm not sure if i have check user anymore i haven't done that in years :D [22:27:39] MaxSem: that would be great [22:28:48] The action you have requested is limited to users in the group: Checkusers. [22:28:50] meh [22:31:01] awjr, is the backlog we're interested in the Q3 backlog? [22:32:10] MaxSem: Probably best to check the database directly anyway. Otherwise the checkusers are going to wonder why we're checkusering, since it will show up in the checkuser logs. [22:32:48] there's summary for that [22:32:54] brion: i made a note in gerrit about the nav bar refactor patch. would it be ok to address that in future patch? [22:33:16] jgonera: aye [22:33:38] mhurd: that should be fine yeah :) [22:33:39] MaxSem: chip unplugged the secondary mic/speaker and plugged it back in - that made the echo go away [22:34:01] fuuuuuu... [22:34:04] (03CR) 10Jdlrobson: [C: 04-1] "The story doesn't say anything about changing stable and normal mobile experience. I think you overlooked this and applied these changes e" (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111374 (owner: 10Kaldari) [22:35:37] jdlrobson: Moiz said he specifically wanted all of these chages on stable [22:36:08] originally I was going to do them mostly in beta [22:36:09] kaldari: well let's talk about that - but that wasn't clear at all in the story [22:36:16] another case of bad acceptance criteria! [22:36:28] yeah, the acceptance criteria is ambiguous on that [22:37:53] wtf? [22:38:18] the varnishes are all registered, but XFF contains an LVS IP [22:38:36] lolol [22:38:40] o_O [22:40:58] whaaaaaaaa [22:41:02] how does that even happen? [22:42:43] awjr: can you open a new bug for this blocking issue [22:42:53] ? [22:42:58] it's somewhat different [22:43:11] jdlrobson: sorry i dont follow [22:43:23] oh are you talking about the bug i reopened? [22:43:28] there is no longer a "Your account is blocked from editing." message [22:43:29] yup https://bugzilla.wikimedia.org/show_bug.cgi?id=60993 [22:43:54] it's the same issue; it's jsut temporarily resolved [22:44:13] i mean, the specific manifestation in the OP is resolved but the issue itself isn't [22:44:22] This sounds like a bug outside MobileFrontend though no? [22:44:32] likely [22:44:52] that is a fair point - can we leave it open until we get more info from MaxSem's digging? [22:45:09] so it shouldn't be on the MobileFrontend product any more which makes me think it is a different bug :-) anyway not too bothered - was just worrying it might confuse someone reading it as from the first message it is a bug about UI and then it switches to be about something else [22:45:30] i'll leave that to you to though to decide [22:46:10] i think we'll have more information shortly at which point we can more thoughtfully figure out what to do next - let's wait a bit [22:49:39] MaxSem, a hypothetical question: if the upcoming iteration was also not very heavy on stories, would you have some things you'd like to work, something from your personal backlog you've been postponing? [22:50:09] jgonera, certainly [22:50:36] MaxSem, ok, good [22:51:53] MaxSem: you need any help with the language HTML zero stuff? [22:52:12] jdlrobson, waiting for zero ppl [22:52:31] MaxSem: ok if you need any help e.g. want me to beat dr0ptp4kt with a stick to help i can do that. [22:52:39] :P [22:56:29] MaxSem, brion: I tried running a query against db1050, but the cu_changes table is so huge I didn't get any results after 60 seconds, so I just killed it. Is there a better way to get the IPs? [22:57:39] Do we know any people with CheckUser rights? [22:57:54] i'm sure there's a place we can ask [22:58:15] and....n o i don't have such rights :) [22:58:20] true, I'll follow-up onwiki [22:58:32] kaldari: yeah probably have to search on the indexed fields but you gotta do some transforms, i forget how to do it manually in the db [23:00:55] kaldari, use indexes;) [23:01:14] as I already said I already know the offending IP [23:01:33] ah yeah, looks like user ID is indexed, but not user name... [23:01:35] kenanwang_: https://www.mediawiki.org/wiki/Wikipedia_article_creation#Project_scope [23:01:40] see the TBD [23:01:42] we should talk [23:01:47] (not today, but soon) [23:02:04] MaxSem: Oh, if you already know it, nevermind :) [23:06:08] kenanwang_: ygm [23:06:25] lemme know if that looks ok and i'll send it out [23:13:10] can someone in SF make 1 edit on desktop and 1 on mobile? [23:15:42] jdlrobson, ^^ [23:15:56] (03PS4) 10Jdlrobson: Add unique route for VisualEditor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111348 [23:19:34] ***** can someone in SF make 1 edit on desktop and 1 on mobile? ****** [23:20:04] (03PS12) 10Jdlrobson: Story 1628: Put toolbar in header of VE overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110064 [23:20:34] MaxSem: hey MaxSem anon or logged in? [23:20:41] (03CR) 10Jdlrobson: [C: 04-2] "Please review all my dependencies first I'm in dependency hell :-(" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111367 (owner: 10Jdlrobson) [23:20:48] jdlrobson, logged in so I could CU you:) [23:21:05] MaxSem: ok testing now [23:21:53] MaxSem: done [23:21:58] https://en.wikipedia.org/w/index.php?title=User:Jdlrobson/sandbox&action=history [23:22:01] thanks, looking [23:23:24] rawwr, only mobile is affected [23:23:40] kaldari: can you take a look at https://gerrit.wikimedia.org/r/#/c/111348/2 [23:23:51] keen to get this merged asap - it's essential for the switcher stroy [23:23:56] sure [23:24:05] and it will lead to inevitable merge conflicts if not taken care of :) [23:28:30] luckily, this wasn't happening too long [23:28:40] will deploy a fix shortly [23:29:57] (03PS1) 10Jdlrobson: Deal with long words [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111932 [23:30:24] thanks MaxSem [23:31:43] (03CR) 10Jdlrobson: "Please someone decide on something. Unless we wrap this up before the end of Friday I will abandon this patchset or leave someone else to " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111146 (owner: 10Jdlrobson) [23:34:19] (03PS1) 10MaxSem: At Greg's request, hide Minerva on desktop behind a feature flag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111933 [23:35:41] (03PS1) 10JGonera: Story 1626: VE section editing scrolls to section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111934 [23:36:20] (03CR) 10Kaldari: [C: 04-1] Add unique route for VisualEditor (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111348 (owner: 10Jdlrobson) [23:39:22] jdlrobson: looks like kaity updated card 1521 [23:39:40] awjr too late for me probably :-) thanks for letting me know though [23:39:56] awjr: jdlrobson sorry still working on it [23:40:16] I think its ending up being bigger than I originally thought [23:40:26] kk [23:42:15] (03CR) 10Kaldari: [C: 031] "I'll ping Juliusz and see if he wants to review or not..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/94435 (owner: 10Jdlrobson) [23:42:29] (03PS5) 10Jdlrobson: Add unique route for VisualEditor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111348 [23:43:02] jgonera: I +1ed https://gerrit.wikimedia.org/r/#/c/94435/, let me know if you want to review it as well, otherwise, I'll +2 it. [23:45:42] (03CR) 10Kaldari: [C: 032] Deal with long words [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111932 (owner: 10Jdlrobson) [23:46:17] (03PS11) 10Jdlrobson: QA: Tests for story 1628 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/109807 [23:46:26] (03Merged) 10jenkins-bot: Deal with long words [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111932 (owner: 10Jdlrobson) [23:47:28] (03PS13) 10Jdlrobson: Story 1628: Put toolbar in header of VE overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/110064 [23:49:56] So kaldari without https://gerrit.wikimedia.org/r/110064 the toolbar is in a weird state [23:50:03] no icons and badly styled :) [23:52:42] (03CR) 10Kaldari: [C: 032] Add unique route for VisualEditor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111348 (owner: 10Jdlrobson) [23:53:25] (03Merged) 10jenkins-bot: Add unique route for VisualEditor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/111348 (owner: 10Jdlrobson)