[00:06:48] <paladox>	 qchris__ only problem im having with converting is, will making String authSignatureInput = Long.toString(authToken) + certificate; String authSignatureInput = Long.toString(authToken) + token; work?
[00:07:02] <paladox>	 String authSignatureInput = Long.toString(authToken) + certificate; -> String authSignatureInput = Long.toString(authToken) + token;
[00:07:30] <paladox>	 i guess sha1 is 32 long?
[00:07:44] <paladox>	 since it is doing something below that code for sha1.
[00:10:06] <qchris__>	 paladox: I do not think I understand what you are trying to say... Can you re-phrase it?
[00:10:45] <paladox>	 Ok, well here String authSignatureInput = Long.toString(authToken) + certificate; you need to use a certificate. But as im replacing it with tokens.
[00:10:49] <paladox>	 would doing this
[00:10:52] <paladox>	 String authSignatureInput = Long.toString(authToken) + token;
[00:10:54] <paladox>	 work?
[00:11:08] <qchris__>	 :-) No clue.
[00:11:18] <paladox>	 since i see below it does
[00:11:19] <paladox>	     MessageDigest sha1;
[00:11:20] <paladox>	     try {
[00:11:21] <paladox>	       sha1 = MessageDigest.getInstance("SHA-1");
[00:11:22] <paladox>	     } catch (NoSuchAlgorithmException e) {
[00:11:23] <paladox>	       throw new ConduitException("Failed to compute authSignature, as no "
[00:11:24] <paladox>	           + "SHA-1 algorithm implementation was found", e);
[00:11:25] <paladox>	     }
[00:11:26] <paladox>	     byte[] authSignatureRaw;
[00:11:27] <paladox>	     try {
[00:11:28] <paladox>	       authSignatureRaw = sha1.digest(authSignatureInput.getBytes("UTF-8"));
[00:11:29] <paladox>	     } catch (UnsupportedEncodingException e) {
[00:11:30] <paladox>	 oh
[00:11:46] <qchris__>	 The code I used what was needed back then.
[00:11:59] <qchris__>	 I did not follow Phab's development, so I do not know what they use now.
[00:12:03] <paladox>	 yep
[00:12:07] <qchris__>	 But the auth part is still working, right?
[00:12:21] <qchris__>	 You're doing that to switch to a new way of authentication?
[00:12:27] <qchris__>	 Right?
[00:12:43] <paladox>	 Yep
[00:13:18] <paladox>	 it still has certificates but nothing i am doing is working in retriving the cert.
[00:13:18] <qchris__>	 Back then, I had to reverse what Phab was doing to make authentication work. It was not hard, but documentation was lacking.
[00:13:33] <qchris__>	 So you could do the same thing here.
[00:13:43] <qchris__>	 Look at the phab PHP code and see what it expects.
[00:13:56] <qchris__>	 Then provide that on the its-phabricator side.
[00:14:10] <paladox>	 ok
[00:15:10] <qchris__>	 (May be that documentation is better now and explains what needs to be done. So be sure to double-check the Phab documentation)
[00:15:20] <paladox>	 qchris__ the token from https://phabricator.wikimedia.org/conduit/token/ look like fmw6uu6zbhowiycgfbmxq6olmbuwnzevdgzipijq
[00:15:33] <qchris__>	 (If in doubt, you could also ask the Phabricator devs)
[00:15:39] <paladox>	 ok
[00:17:00] <qchris__>	 But ... mhmm. "arc install-certificate" ... you want to move away from certificates but then the arc command would be "[...]-certificate"?
[00:17:56] <paladox>	 it's still arc install-certificate
[00:18:04] <paladox>	 but you provide it the cli-* token
[00:18:54] <qchris__>	 Ok. Since you want the switch, and I am not involved in either side of software, I'll leave that for you to find out :-)
[00:19:44] <paladox>	 Ok
[00:32:58] <paladox>	 qchris__ ah
[00:33:17] <paladox>	 we can use the web conduit get certificate thingy
[00:33:25] <paladox>	 docs needs updating :)
[00:34:00] <wikibugs_>	 10Phabricator, 10Gerrit, 06Release-Engineering-Team: Update its-phabricator gerrit plugin to use  tokens instead of certificates - https://phabricator.wikimedia.org/T159060#3055637 (10Paladox) 05Open>03declined Actually the certs are needed. The docs need updating on how to retrieve the certs.
[00:37:20] <qchris__>	 I feel a bit deja-vu-ed :-)
[00:38:00] <qchris__>	 By "docs need updating", you mean the its-phabricator docs?
[00:38:17] <qchris__>	 The way described there still seems to work, doesn't it?
[00:39:03] <qchris__>	 (I know there are many ways to skin the cat and obtain the certificate.)
[00:40:30] <paladox>	 qchris__ actually to retrive the cert you have to go to <phab_install>/conduit/token to pick up the token.
[00:40:47] <paladox>	 then you go to <phab_install>/api/conduit.getcertificate
[00:40:59] <paladox>	 and fill out the host and token field
[00:41:00] <qchris__>	 Did you try running arc install-certificate http://my.phabricator.instance.example.org?
[00:41:04] <paladox>	 yep
[00:41:18] <paladox>	 that installs the cli- token
[00:49:53] <paladox>	 [2017-02-26 00:48:47,454] [HTTP-78] ERROR com.googlesource.gerrit.plugins.its.base.workflow.ActionExecutor : Error while executing action add-velocity-comment PatchSetCreated
[00:49:53] <paladox>	 java.io.IOException: Could not update message for task 20
[00:50:00] <paladox>	 hmm, i get that error
[00:51:26] <paladox>	 qchris__ ^^
[00:52:56] <paladox>	 its probly the change i did is failing.
[00:56:37] <qchris__>	 paladox: About the doc updates ... I just tried the "arc install-certificate" and I get a good, valid cert.
[00:56:49] <qchris__>	 You did read the docs to the end, right?
[00:57:18] <paladox>	 Yep i read to the end. How do you manage to get a valid cert?
[00:57:23] <paladox>	 i did arc install-certificate https://phab-01.wflabs.org/
[00:57:34] <paladox>	 and got ~/.arcrc
[00:57:45] <paladox>	 with a host and token in there.
[00:58:01] <qchris__>	 Mhmm. Weird.
[00:58:37] <qchris__>	 At any rate, if you know a better way to get a cert, please send a fix upstream. I am sure the maintainers of the plugins will gladly accept it.
[00:58:55] <qchris__>	 IIRC, there was once a contuit page where to easily get the cert.
[00:58:56] <paladox>	 Yep, i will. I am trying to replace all the deprecated parts :)
[00:59:01] <paladox>	 oh
[00:59:35] <qchris__>	 About the add-velocity-comment error. The full stack trace will likely guide you to the place where the effective error is.
[01:00:57] <paladox>	 Yep it's maniphest_update
[01:01:18] <paladox>	 public ManiphestUpdate maniphestUpdate
[01:02:14] <paladox>	 https://gerrit-review.googlesource.com/#/c/98576/edit/src/main/java/com/googlesource/gerrit/plugins/its/phabricator/conduit/Conduit.java
[01:07:51] <paladox>	 qchris__ maybe it's objectIdentifier as i get this error Monogram "T159003" does not identify a valid object. when doing it through phab
[01:07:52] <stashbot>	 T159003: Test1234 - https://phabricator.wikimedia.org/T159003
[01:12:40] <qchris__>	 Hey, paladox :-)
[01:12:46] <paladox>	 hi
[01:12:50] <qchris__>	 I've told you that I'll have a look at your code.
[01:12:58] <paladox>	 ok
[01:13:06] <qchris__>	 We've clarified that things are not urgent.
[01:13:18] <paladox>	 yep
[01:13:26] <qchris__>	 And after some back and forth, I've told you that I am busy working on other things.
[01:13:32] <qchris__>	 I am a volunteer just as you.
[01:13:52] <qchris__>	 Yet you pinged me ... 8 (?) times in the past two hours since then.
[01:14:01] <qchris__>	 I've told you repeatedly that I do not like that.
[01:14:16] <qchris__>	 And I've asked you repeatedly to please stop that.
[01:14:29] <qchris__>	 So ... I know you are well meaning.
[01:14:36] <qchris__>	 But it's really disruptive for me.
[01:15:04] <paladox>	 oh sorry
[01:15:06] <qchris__>	 And since the past requests to stop it did not show fruits, I'll have to pull the break on my end.
[01:15:12] <qchris__>	 I'll put you onto my ignore list.
[01:15:23] <qchris__>	 Sorry for that. But it no longer works for me otherwise.
[01:15:40] <qchris__>	 I'll gladly discuss code with you through Gerrit.
[01:15:48] <paladox>	 ok
[01:15:54] <qchris__>	 But the IRC part between the two of us is not working for me.
[01:16:01] <qchris__>	 See you on Gerrit :-)
[01:16:08] <paladox>	 ok
[01:17:17] <paladox>	 Im not sure what you mean by "And since the past requests to stop it did not show fruits, I'll have to pull the break on my end."?
[01:17:45] <paladox>	 as you only told me that you had to do other things. You never said i could you ping you for help just that you were busy doing other things.
[01:17:56] <paladox>	 this is the first time you told me to stop pinging you.
[01:18:56] <Reedy>	 It's just general IRC etiquette
[11:48:49] <TabbyCat>	 Task Daemon Not Running	Use bin/phd start to start daemons. See Managing Daemons with phd. <-- andre__ ?
[11:54:06] <TabbyCat>	 (resolved)
[12:38:31] <paladox>	 TabbyCat hi, yeh it does that.
[12:38:41] <paladox>	 Known problem + i think it's intentional.
[12:39:00] <TabbyCat>	 ah, okay
[12:39:00] <paladox>	 twentyafterfour ^^
[12:39:07] <paladox>	 yep
[13:06:59] <andre__>	 TabbyCat: No need to ping me specifically. As I could not change that anyway. :)
[13:07:13] <andre__>	 paladox: No need to ping specific people.
[13:07:24] <paladox>	 ok
[13:07:34] <TabbyCat>	 andre__: sorry, [you're the know-all-from-Phab-guy for me, sorry again]
[13:08:11] <TabbyCat>	 hope you don't mind I added a comment on your talk @ wikitech
[13:08:15] <TabbyCat>	 feel free to remove it if you wish
[15:27:10] <paladox>	 qchris__ sorry for the ping, but yay i got it working with comments.
[15:27:15] <paladox>	 http://phab-01.wmflabs.org/T20
[16:02:45] <PORNpornPornPORN>	 !ops
[16:16:34] <wikibugs_>	 10Phabricator, 10Gerrit, 06Release-Engineering-Team, 07Technical-Debt: Replace deprecated phabricator conduit api calls in gerrit's its-phabricator plugin - https://phabricator.wikimedia.org/T159041#3056055 (10Paladox) I've managed to write this in java for maniphest.edit :)  https://gerrit-review.googleso...
[16:17:42] <paladox>	 I got projects working too now :)
[16:56:50] <wikibugs_>	 10Phabricator: Allow project.search to make name a list in constraints - https://phabricator.wikimedia.org/T159073#3056094 (10Paladox)
[18:20:13] <wikibugs_>	 10Phabricator: Allow project.search to make name a list in constraints - https://phabricator.wikimedia.org/T159073#3056225 (10Aklapper) I do not think "we" (did you mean upstream?) need to support list, because as a workaround you can project.search for the id of each name in a loop, and then construct the array...
[18:24:43] <wikibugs_>	 10Phabricator, 10Gerrit, 06Release-Engineering-Team, 07Technical-Debt: Replace deprecated phabricator conduit api calls in gerrit's its-phabricator plugin - https://phabricator.wikimedia.org/T159041#3056230 (10Paladox) I have created this https://gerrit-review.googlesource.com/#/c/98611/ patch for replacin...
[18:26:14] <wikibugs_>	 10Phabricator, 10Gerrit, 06Release-Engineering-Team, 07Technical-Debt: Replace deprecated phabricator conduit api calls in gerrit's its-phabricator plugin - https://phabricator.wikimedia.org/T159041#3056233 (10Paladox) I get this error  [2017-02-26 17:29:46,494] [HTTP-75] WARN  com.google.gerrit.server.ext...
[18:33:02] <wikibugs_>	 10Phabricator: Allow project.search to make name a list in constraints - https://phabricator.wikimedia.org/T159073#3056249 (10Paladox) Oh, i guess doing      params2.put("name", name);      params.put("constraints", params2);  will work for now.
[20:03:48] <wikibugs_>	 10Phabricator, 10Gerrit, 06Release-Engineering-Team, 07Technical-Debt: Replace deprecated phabricator conduit api calls in gerrit's its-phabricator plugin - https://phabricator.wikimedia.org/T159041#3056340 (10Aklapper) @Paladox: You posted at 18:24 that you wrote a patch. Two minutes later you posted anot...
[22:19:55] <wikibugs_>	 10Phabricator, 10GerritBot: make gerritbot remove the "patch-for-review" tag once a patch is merged (or abandoned) - https://phabricator.wikimedia.org/T95309#3056585 (10Paladox) I've added this support here https://gerrit-review.googlesource.com/#/c/98613/
[22:20:24] <wikibugs_>	 10Phabricator, 10GerritBot: make gerritbot remove the "patch-for-review" tag once a patch is merged (or abandoned) - https://phabricator.wikimedia.org/T95309#3056587 (10Paladox) p:05Lowest>03Normal
[22:31:39] <wikibugs_>	 10Phabricator: Calendar text overlap - https://phabricator.wikimedia.org/T159092#3056602 (10Reedy)