[00:54:34] 10Phabricator, 06Release-Engineering-Team: Phab Advanced Search no longer showing typical results - https://phabricator.wikimedia.org/T146789#2671208 (10mmodell) @paladox done: {T146843} [00:59:03] 10Phabricator, 06Discovery, 06Discovery-Search, 10Elasticsearch: Re-evaluate how we implement phabricator's search engine - https://phabricator.wikimedia.org/T146843#2672665 (10mmodell) [01:07:15] 10Phabricator, 06Release-Engineering-Team: Phab Advanced Search no longer showing typical results - https://phabricator.wikimedia.org/T146789#2672705 (10mmodell) I'm actually not sure what to make of this issue. The abovementioned projects show up in the global search autocomplete dropdown. That would seem to... [04:37:40] 10Phabricator, 06Discovery, 06Discovery-Search, 10Elasticsearch: Re-evaluate how we implement phabricator's search engine - https://phabricator.wikimedia.org/T146843#2673167 (10MZMcBride) Do we have a list of test cases? I think that would be invaluable here. [05:05:23] 10Phabricator, 06Discovery, 06Discovery-Search, 10Elasticsearch: Re-evaluate how we implement phabricator's search engine - https://phabricator.wikimedia.org/T146843#2673180 (10mmodell) @MZMcBride: That's a great idea. I'm sure those linked tasks have some, I will see what I can dig up. [05:07:00] 10Phabricator, 06Discovery-Search, 10Elasticsearch: Fix provided search results in Wikimedia Phabricator - https://phabricator.wikimedia.org/T75854#2673186 (10mmodell) [05:07:02] 10Phabricator: Use ElasticSearch backend for Maniphest to get stemming feature - https://phabricator.wikimedia.org/T95#2673187 (10mmodell) [05:07:04] 10Phabricator, 06Discovery, 06Discovery-Search, 10Elasticsearch: Re-evaluate how we implement phabricator's search engine - https://phabricator.wikimedia.org/T146843#2673183 (10mmodell) [05:22:37] 10Phabricator, 06Discovery, 06Discovery-Search, 10Elasticsearch: Re-evaluate how we implement phabricator's search engine - https://phabricator.wikimedia.org/T146843#2673198 (10mmodell) Upstream is considering dropping elasticsearch, sadly: https://secure.phabricator.com/T9893 [06:46:19] Wow, someone seems to like green. https://phabricator.wikimedia.org/tag/dumps-rewrite/ :) [07:11:16] 10Phabricator, 06Community-Liaisons: Include relevant updates to our Phabricator installation in community communication - https://phabricator.wikimedia.org/T139593#2673259 (10Qgil) @Johan, any thoughts? [08:10:52] 10Phabricator, 06Release-Engineering-Team: Phab Advanced Search no longer showing typical results - https://phabricator.wikimedia.org/T146789#2671208 (10hashar) I have tried all three examples mentioned and they know yield the appropriate result. I guess it is all related to the search index still being reinde... [08:14:29] 10Phabricator, 06Release-Engineering-Team: Phab Advanced Search no longer showing typical results - https://phabricator.wikimedia.org/T146789#2673397 (10mmodell) 05Open>03Resolved a:03mmodell Ok I had to reindex projects using the --force argument, e.g: ```lang=s twentyafterfour@iridium:/srv/phab/phabri... [08:16:03] 10Phabricator, 06Release-Engineering-Team: Phab Advanced Search no longer showing typical results - https://phabricator.wikimedia.org/T146789#2673401 (10mmodell) @hashar: The database reindex didn't actually fix it until I specifically reindexed projects with --force [08:18:07] 10Phabricator, 06Release-Engineering-Team, 07Wikimedia-Incident: Contention on search phabricator database creating full phabricator outages - https://phabricator.wikimedia.org/T146673#2673403 (10mmodell) >>! In T146673#2671505, @Paladox wrote: > Oh, but In innodb depending on what MySQL or mariadb version y... [08:41:00] 10Phabricator, 06Release-Engineering-Team: Phab Advanced Search no longer showing typical results - https://phabricator.wikimedia.org/T146789#2673453 (10Tgr) Search quality for multiple terms is still extremely poor. E.g. for the query [[https://phabricator.wikimedia.org/search/query/q4v1FMKd4p4Y/#R|phabricato... [10:23:03] 10Phabricator, 06Release-Engineering-Team: Phab Advanced Search no longer showing typical results - https://phabricator.wikimedia.org/T146789#2673719 (10Paladox) Maybe we will want to also do --force for manifest tasks to per ^^ [10:25:53] 10Phabricator, 06Release-Engineering-Team: Phab Advanced Search no longer showing typical results - https://phabricator.wikimedia.org/T146789#2673721 (10Paladox) Thanks. [10:28:21] 10Phabricator, 06Discovery, 06Discovery-Search, 10Elasticsearch: Re-evaluate how we implement phabricator's search engine - https://phabricator.wikimedia.org/T146843#2673740 (10Paladox) If upstream do drop the support, we could always backport the patches to our phabricator and maintain it if we do decide... [15:00:50] 10Phabricator, 06Discovery, 06Discovery-Search, 10Elasticsearch: Re-evaluate how we implement phabricator's search engine - https://phabricator.wikimedia.org/T146843#2672665 (10EBernhardson) Correct mediawiki is using elasticsearch 2.3.5. Ideally if we are going to add more elasticsearch clusters they shou... [15:53:18] 10Phabricator, 06Release-Engineering-Team, 07Wikimedia-Incident: Contention on search phabricator database creating full phabricator outages - https://phabricator.wikimedia.org/T146673#2674445 (10jcrespo) Here is the things I would like to be done to close this ticket (all ongoing issues solved): * Check th... [15:53:46] 10Phabricator, 06Release-Engineering-Team, 07Wikimedia-Incident: Contention on search phabricator database creating full phabricator outages - https://phabricator.wikimedia.org/T146673#2674446 (10jcrespo) [16:01:28] 10Phabricator, 06Release-Engineering-Team, 07Wikimedia-Incident: Contention on search phabricator database creating full phabricator outages - https://phabricator.wikimedia.org/T146673#2674457 (10jcrespo) I would add one extra bullet point to the TODO: evaluate other potentially problematic Aria/MyISAM table... [16:01:43] 10Phabricator, 10DBA: Convert all phabricator tables to innodb from myisam - https://phabricator.wikimedia.org/T146910#2674459 (10Paladox) [16:02:37] 10Phabricator, 06Release-Engineering-Team, 07Wikimedia-Incident: Contention on search phabricator database creating full phabricator outages - https://phabricator.wikimedia.org/T146673#2674476 (10Paladox) >>! In T146673#2674457, @jcrespo wrote: > I would add one extra bullet point to the TODO: evaluate other... [16:08:47] 10Phabricator, 06Discovery, 06Discovery-Search, 10Elasticsearch: Re-evaluate how we implement phabricator's search engine - https://phabricator.wikimedia.org/T146843#2674530 (10greg) >>! In T146843#2673740, @Paladox wrote: > If upstream do drop the support, we could always backport the patches to our phabr... [16:08:49] 10Phabricator, 10DBA: Convert all phabricator tables to innodb from myisam - https://phabricator.wikimedia.org/T146910#2674459 (10Reedy) What MW does is irrelevant; but the Phab docs suggest same as MW, innodb mostly, except myisam for search things https://secure.phabricator.com/book/phabcontrib/article/data... [16:09:51] 10Phabricator, 10DBA: Convert all phabricator tables to innodb from myisam - https://phabricator.wikimedia.org/T146910#2674543 (10Paladox) Yes mw is irrelevant but still if mw recommends innodb over myisam we should follow the same with phabricator. [16:10:20] 10Phabricator, 10DBA: Convert all phabricator tables to innodb from myisam - https://phabricator.wikimedia.org/T146910#2674558 (10Reedy) >>! In T146910#2674543, @Paladox wrote: > Yes mw is irrelevant but still if mw recommends innodb over myisam we should follow the same with phabricator. Why? That doesn't ma... [16:12:13] 10Phabricator, 10DBA: Convert all phabricator tables to innodb from myisam - https://phabricator.wikimedia.org/T146910#2674561 (10Paladox) Well because mw is mostly what Wikimedia uses for it's websites, why should we ignore what mw says since that is what Wikimedia maintains? Now if the phab docs said it does... [16:12:54] 10Phabricator, 06Discovery, 06Discovery-Search, 10Elasticsearch: Re-evaluate how we implement phabricator's search engine - https://phabricator.wikimedia.org/T146843#2674564 (10Paladox) @EBernhardson Hi, we could always manually fix elasticsearch 2 support in phabricator core, but that will require us main... [16:13:24] 10Phabricator, 06Discovery, 06Discovery-Search, 10Elasticsearch: Re-evaluate how we implement phabricator's search engine - https://phabricator.wikimedia.org/T146843#2674565 (10Paladox) >>! In T146843#2674530, @greg wrote: >>>! In T146843#2673740, @Paladox wrote: >> If upstream do drop the support, we coul... [16:16:11] 10Phabricator, 10DBA: Convert all phabricator tables to innodb from myisam - https://phabricator.wikimedia.org/T146910#2674575 (10jcrespo) 05Open>03declined Please do not use tickets as a forum. The DBAs are aware of the issue, and in touch with the service owners to fix it in the best way possible. We wil... [17:45:32] 10Phabricator, 06Release-Engineering-Team, 07Wikimedia-Incident: Contention on search phabricator database creating full phabricator outages - https://phabricator.wikimedia.org/T146673#2674853 (10mmodell) @jcrespo: Are there other myisam tables? I was under the impression that this was the only one but I wil... [17:51:44] 10Phabricator, 06Release-Engineering-Team, 07Wikimedia-Incident: Contention on search phabricator database creating full phabricator outages - https://phabricator.wikimedia.org/T146673#2674872 (10Paladox) @mmodell yep, there are other myisam tables. [17:57:13] 10Phabricator, 06Release-Engineering-Team, 07Wikimedia-Incident: Contention on search phabricator database creating full phabricator outages - https://phabricator.wikimedia.org/T146673#2674879 (10mmodell) ```lang=sql SELECT TABLE_SCHEMA, TABLE_NAME FROM information_schema.TABLES WHERE Engine = 'MyISAM'; `... [17:58:39] 10Phabricator, 06Release-Engineering-Team, 07Wikimedia-Incident: Contention on search phabricator database creating full phabricator outages - https://phabricator.wikimedia.org/T146673#2674880 (10mmodell) @jcrespo: Those two tables ^ appear to be all that remain on myisam. I can't see any reason why we shoul... [18:24:30] 10Phabricator, 10iOS-app-feature-Accessibility, 10iOS-app-feature-Multilingual, 10iOS-app-feature-WP0, 06Wikipedia-iOS-App-Backlog (Administrative): Herald rule requests for iOS - https://phabricator.wikimedia.org/T146701#2674981 (10DFoy) I would like the feature-WP0 to be autotagged for Zero. Thanks! [18:29:32] 10Phabricator, 06Release-Engineering-Team: Phab Advanced Search no longer showing typical results - https://phabricator.wikimedia.org/T146789#2675015 (10mmodell) @tgr: Hopefully {T146843} will address the quality of results. I don't think innodb is doing a very good job. @paladox: That would take several days... [18:34:17] hello [18:34:48] i meet a small problem: i can't install that parsoid from ssh [18:34:57] because it's on read mode only [18:35:05] it's for visual editro [18:35:08] editor* [18:35:33] twentyafterfour: are you here? [18:36:33] nevermind, it wasn't for me... [18:36:35] bye [18:53:03] 10Phabricator, 06Release-Engineering-Team, 07Wikimedia-Incident: Contention on search phabricator database creating full phabricator outages - https://phabricator.wikimedia.org/T146673#2675083 (10mmodell) @jcrespo: So I think what remains for this task is as follows: 1. Reduce `innodb_ft_min_token_size` fr... [18:53:31] :-/ [18:59:32] twentyafterfour: why'd they ping you? [19:02:07] 10Phabricator, 06Release-Engineering-Team, 07Wikimedia-Incident: Contention on search phabricator database creating full phabricator outages - https://phabricator.wikimedia.org/T146673#2675099 (10Paladox) "1. Reduce innodb_ft_min_token_size from 3 to 2" Done here https://gerrit.wikimedia.org/r/#/c/313235/ [19:03:18] greg-g it must have been when a user asked something phabricator specific, i said to ask in here and twentyafterfour would be able to explain the difference, but they could not be bovered top, but another user probaly saw that but didn't realise that twentyafterfour dosen't work on visualeditor [19:03:20] or parsoid [19:03:35] They wrote the phabricator specific question in #mediawiki [19:04:05] and they asked about phabricator blocking tasks since they coulden find it since it was renamed to parent / subtask [19:08:10] 10Phabricator, 06Release-Engineering-Team, 07Wikimedia-Incident: Contention on search phabricator database creating full phabricator outages - https://phabricator.wikimedia.org/T146673#2675121 (10Paladox) "2. Import stopwords from https://github.com/phacility/phabricator/blob/master/resources/sql/stopwords.t... [19:45:56] 10Phabricator, 06Developer-Relations, 06Release-Engineering-Team, 10Wikimedia-Blog-Content: blog.wikimedia.org post on Phabricator improvements - https://phabricator.wikimedia.org/T141457#2675211 (10EdErhart-WMF) Great! Mel's comments above then are perfect. I think you'll want to use a framework that demo... [20:03:57] 10Phabricator, 06Developer-Relations: Tech Talk: up-to-date version of Phabricator tech talk - https://phabricator.wikimedia.org/T142881#2675270 (10Qgil) 4,861 views today. Since the first version is still "selling" so well, do we really need to run a second one? I would rather focus on producing small tutoria... [22:51:11] 10Phabricator, 06Release-Engineering-Team, 13Patch-For-Review, 07Wikimedia-Incident: Contention on search phabricator database creating full phabricator outages - https://phabricator.wikimedia.org/T146673#2675939 (10mmodell)