[01:00:36] 10Phabricator: Herald_rule_for_iOS - https://phabricator.wikimedia.org/T143948#2613443 (10mmodell) @mbinder_wmf: {H187} [09:26:01] 10Differential: Editing files and contributing changes via web - https://phabricator.wikimedia.org/T409#2614022 (10Qgil) [09:36:52] 10Differential, 10Phabricator (Upstream), 07Upstream: Editing files and contributing changes via web - https://phabricator.wikimedia.org/T409#2614051 (10Paladox) [09:37:09] 10Differential, 10Phabricator (Upstream), 07Upstream: Editing files and contributing changes via web - https://phabricator.wikimedia.org/T409#2614054 (10Paladox) Adding phabricator upstream tag since it was filled upstream. [09:39:30] 10Differential, 10Phabricator (Upstream), 07Upstream: Editing files and contributing changes via web - https://phabricator.wikimedia.org/T409#2614055 (10Paladox) But I wonder how we can get https://secure.phabricator.com/T6008 moving along? Since we updated gerrit to use the new inline edit, it made things a... [09:59:28] paladox: Hmm, could you explain how comments like https://phabricator.wikimedia.org/T409#2614055 are helpful? [10:00:42] Generally speaking, "we" don't need to get everything "moving along". And we all now that Gerrit has a "new inline edit" anyway. [10:00:46] So I wonder where's the substance. [10:43:09] andre__ Hi, yes i know we all know that it has inline edit in gerrit, but it seems we are going to move to differential without completing any of the missing gerrit features, it would be a downgrade if we moved to gerrit now [11:27:16] paladox: how is that related to your comment? [11:27:32] Nobody expects or plans to have feature parity. [11:27:59] And my actual question was how that comment was helpful :) [11:28:52] So I don't see a reason to "move along", only if you expect feature parity. (Which is now clearer after your comment here on IRC, thanks, but still doesn't seem relevant to me.) [14:48:20] andre__ that addresses your comment, Since the way i addressed it looks like i am just spamming tasks, but it isen't, I would like to see that feature implemented before we move to differential. Sorry if it dosent look like i addressed your comment the way you like to. [15:51:59] Hmm. Was there a Phab upgrade last night? The Deployments page says there wasn't a window, but Phab is now missing task graphs for me. [15:54:53] I was just looking at a task graph [15:55:02] which task was this on? [15:57:54] 10Phabricator, 10Striker, 13Patch-For-Review: Unable to mirror repository from git.legoktm.com into diffusion - https://phabricator.wikimedia.org/T143969#2615229 (10bd808) >>! In T143969#2596494, @bd808 wrote: > @dpatrick and @faidon: do you have strong feelings about allowing Phabricator to directly replica... [15:57:56] James_F: could be a highly connected one? [15:58:28] yes at some point it becomes large enough that it is excluded iirc James_F [15:58:50] Ah, no, it was my browser blocking content from 'wmfusercontent.org'. [15:58:59] Sorry, fixed now. :-) [15:58:59] yep, even if you only see 2 or 3 tasks listed, those 2 or 3 are highly connected (themselves have 40 subtasks or so) [15:59:03] heh [15:59:12] I was seeing it on https://phabricator.wikimedia.org/T144871 hence my confusion. :-) [15:59:19] "did you try in a clean browser profile?" [15:59:34] Yeah yeah. [15:59:35] you should reboot your computer definitely [15:59:38] can't be too careful :) [15:59:40] :-P [16:04:16] Nope [16:04:22] there was no phab update last night [16:04:27] but there might be one today [16:04:45] and that should fix the issue, since there will now be a little search button on all task graphs [16:05:27] so if it hits 50+ tasks in task graphs it will now not show instead you will now have to click on the search button which should show the parent and sub tasks [16:05:40] see https://phab-01.wmflabs.org/ please [16:05:52] James_F greg-g chasemp ^^ [16:57:17] 10Phabricator: Herald_rule_for_iOS - https://phabricator.wikimedia.org/T143948#2615463 (10MBinder_WMF) @mmodell Thanks. I think it also needs #ios-app-v5.2.1- . Any verdict on whether or not I could have permissions to update this going forward? //I// don't mind pinging when it needs updating, but //you// might. :) [17:00:32] 10Phabricator: Herald_rule_for_iOS - https://phabricator.wikimedia.org/T143948#2615469 (10mmodell) @MBinder_WMF you should be able to edit now, can you try adding #ios-app-v5.2.1- and let me know whether it lets you? [17:10:51] 10Differential, 10Phabricator (Upstream), 07Upstream: Editing files and contributing changes via web - https://phabricator.wikimedia.org/T409#2615495 (10greg) >>! In T409#2614055, @Paladox wrote: > But I wonder how we can get https://secure.phabricator.com/T6008 moving along? Since we updated gerrit to use t... [17:41:20] paladox: Hi, could you explain why you're doing edits like https://phabricator.wikimedia.org/T144872#2615612 ? [17:41:53] andre__ since the task was marked as resolved [17:42:19] paladox, I know the task was resolved. My question was why you're performing such edits. [17:42:55] It's not that resolving a task *requires* removing Gerritbot and #Patch-For-Review. Hence it's not really answer to my question :) [17:43:08] Because for one, patch-for-review is unneeded [17:43:16] paladox, yeah, but why do you care? [17:43:27] I doint. [17:43:35] But there was no harm in doing it [17:43:39] paladox, if you don't care then why do you perform such edits? [17:43:49] The harm is creating more notifications. [17:43:59] I'd just like to understand your use case. [17:44:30] Do you query for resolved tasks with #patch-for-review to identify those that are incorrectly closed and really still have unmerged patches? [17:45:07] Do you for reasons I don't know like to take a look at the list of Subscribers of resolved tasks and having Gerritbot in there somehow disturbs you? [17:45:19] That's what I'd like to understand. [17:45:33] "because the task is resolved" itself isn't really a reason to me :) [17:45:54] Oh, ok, well there is this task https://phabricator.wikimedia.org/T95309 [17:46:21] But why do you want to know why i removed the patch tag? [17:46:23] Indeed. So why do you personally care about that task? :) [17:46:27] I doint [17:46:44] paladox, if you don't care then why do you remove the patch tag from resolved tasks? [17:47:12] Well there is no rule just because i doint care dosent mean a person can do it [17:47:13] why i want to know? see four minutes ago: "The harm is creating more notifications." [17:47:49] paladox, I don't understand why you perform actions that you do not care about. Because if I don't care about $something then I don't put efforts or do $something. [17:47:54] Ok, but wont adding that tag by the gerritbot cause notifications too [17:48:18] Ok [17:48:23] paladox, yes it does. But I see at least a good reason: Being aware that some progress has been made on that task, as someone created a patch. [17:49:03] paladox, while I don't understand your reason and how it is helpful to remove GerritBot and #Patch-For-Review. Hence I am asking what is your intention behind such edits. [17:49:22] I sometimes want to understand why people are doing things, hence I ask :P [17:49:27] Ok, i just see other people [17:49:28] do it [17:49:35] so i thought i should [17:49:58] Yeah, I'd also like to understand why other people do that... :P [17:50:02] Ok [17:50:13] but so far I haven't really received answers in T95309 that convince me :D [17:50:14] T95309: make gerritbot remove the "patch-for-review" tag once a patch is merged (or abandoned) - https://phabricator.wikimedia.org/T95309 [17:50:38] Ok [17:50:41] so I thought I ask another person performing such edits. And that was you :D [17:50:59] Ok [18:14:25] 10Phabricator: Herald_rule_for_iOS - https://phabricator.wikimedia.org/T143948#2616116 (10MBinder_WMF) Works, thx [18:20:14] !log tools.lolrrit-wm Cherry picking https://gerrit.wikimedia.org/r/#/c/308949/ [18:20:15] Not expecting to hear !log here [18:20:24] Woop [18:20:29] woops wrong place [19:29:28] lllcfdadgrrrrr [19:29:30] j'prêt mon tel à un gars [19:29:36] il s'en va à cinquante mètres [19:29:38] puis revient [19:29:39] puis repart [19:29:41] puis revient [19:43:13] wrong windows, sorry, had an issue with mosh and a outgoing / coming back tethering [19:44:26] Oh tethering as in mobile hotspot? [19:44:34] Dereckson ^^ [19:57:16] legoktm hi, im wondering have you done the patch [19:57:19] for svg logos [19:57:21] please? [22:19:05] twentyafterfour: https://phabricator.wikimedia.org/T11532#2617386 BTW. [22:21:20] It's made quite a mess. :-( [22:21:39] 66 tasks marked as "Fixed T…". [22:22:03] I'm not going to revert each of them; can you? [22:27:37] James_F: sorry, I'll take care of it [22:27:58] Thanks. [22:28:20] (Also, Phacility are now up to using task numbers to which I'm subscribed. Whee!) [22:28:36] when did gerrit decide to include the submodule commit messages in it's autocommits. that's annoying [22:32:41] maybe gerrit 2.23 [22:32:45] 2.12 [22:32:45] :) [23:20:51] all fixed up I think [23:21:01] freakin pain in the ass, that. [23:36:44] :/