[00:53:24] 3Phabricator: "Security" values no longer updates visibility/editability policies when changed on existing bugs? - https://phabricator.wikimedia.org/T88681#1029652 (10mmodell) p:5Unbreak!>3Normal [01:14:00] 3Phabricator: Fatal error (30 seconds timeout) for some maniphest search queries - https://phabricator.wikimedia.org/T87739#1029677 (10mmodell) Here's my analysis of what's happening with this particular search query: 1. Because of some sillyness in phabricator's elasticsearch indexing logic, almost every task... [01:15:51] 3Phabricator: Fatal error (30 seconds timeout) for some maniphest search queries - https://phabricator.wikimedia.org/T87739#1029678 (10mmodell) a:5mmodell>3None [01:37:26] 3Phabricator: Fatal error (30 seconds timeout) for some maniphest search queries - https://phabricator.wikimedia.org/T87739#1029706 (10chasemp) Thanks for the input man. I think this may be another indicator that without a concerted effort on our behalf to support ES we are better off with the stock mysql search. [01:43:28] 3Phabricator, Phabricator.org: Fatal error (30 seconds timeout) for some maniphest search queries - https://phabricator.wikimedia.org/T87739#1029708 (10Tgr) Searching for #phabricator OR #phabricator.org, it returns 7 results in 500ms. If I add "workboard" to the freetext field, it takes 20s to return the same 7... [01:43:57] 3Phabricator: Fatal error (30 seconds timeout) for some maniphest search queries - https://phabricator.wikimedia.org/T87739#1029710 (10Tgr) [01:45:51] 3Phabricator: Fatal error (30 seconds timeout) for some maniphest search queries - https://phabricator.wikimedia.org/T87739#997861 (10Tgr) Also, is there a theoretical problem with doing pagination and sorting in ES, is that just something that's not implmeneted in the ES adapter in Phabricator? It sounds exactl... [01:53:54] 3Release-Engineering, Engineering-Community, Wikibugs: Only use -devtools irc channel for phab-related ticket announcements - https://phabricator.wikimedia.org/T89153#1029727 (10Aklapper) [01:54:03] 3Release-Engineering, Engineering-Community, Wikibugs: Only use -devtools irc channel for phab-related ticket announcements - https://phabricator.wikimedia.org/T89153#1028550 (10Aklapper) sounds good to me [01:59:07] 3Phabricator: "Security" values no longer updates visibility/editability policies when changed on existing bugs? - https://phabricator.wikimedia.org/T88681#1029747 (10chasemp) Are we saying that there was no hard set to public/all users on setting the drop down to none? That AFAIK never happened at any point --... [01:59:41] 3Release-Engineering, Engineering-Community, Wikibugs: Only use -devtools irc channel for phab-related ticket announcements - https://phabricator.wikimedia.org/T89153#1029759 (10Legoktm) Why wasn't -devtools merged into -releng? > Now: The signal/noise ratio is too low in -releng and I think we can decide to ke... [03:55:27] 3Release-Engineering, Engineering-Community, Wikibugs: Only use -devtools irc channel for phab-related ticket announcements - https://phabricator.wikimedia.org/T89153#1029868 (10greg) >>! In T89153#1029759, @Legoktm wrote: > Why wasn't -devtools merged into -releng? Because it was good to have a dedicated chann... [04:08:08] 3Release-Engineering, Engineering-Community, Wikibugs: Only use -devtools irc channel for phab-related ticket announcements - https://phabricator.wikimedia.org/T89153#1029877 (10Dzahn) >>! In T89153#1029868, @greg wrote: > Because it was good to have a dedicated channel for the bugzilla->phab migration I think... [04:54:24] 3Phabricator: Adapting Gadget-BugStatusUpdate.js to Phabricator - https://phabricator.wikimedia.org/T539#1029915 (10Ricordisamoa) [05:08:41] 3Release-Engineering, Engineering-Community, Wikibugs: Only use -devtools irc channel for phab-related ticket announcements - https://phabricator.wikimedia.org/T89153#1029923 (10MZMcBride) >>! In T89153#1029868, @greg wrote: >>>! In T89153#1029759, @Legoktm wrote: >> Why wasn't -devtools merged into -releng? >... [05:11:24] 3Phabricator: Fatal error (30 seconds timeout) for some maniphest search queries - https://phabricator.wikimedia.org/T87739#1029924 (10mmodell) ok on further investigation, I think that keyword search is simply broken. The search term isn't being passed on to elasticsearch so es is returning everything it's got.... [05:51:41] 3Phabricator: Adapting Gadget-BugStatusUpdate.js to Phabricator - https://phabricator.wikimedia.org/T539#1029945 (10Ricordisamoa) >>! In T539#1028871, @Mattflaschen wrote: I've made a canonical version at https://www.mediawiki.org/wiki/Extension:Gadgets/Scripts/BugStatusUpdate.js , linked from https://www.mediaw... [05:54:06] 3Phabricator: Project search issue - https://phabricator.wikimedia.org/T89209#1029946 (10Bugreporter) 3NEW [05:58:11] 3Phabricator: Unregistered users should be able to see subscribers of a task - https://phabricator.wikimedia.org/T89210#1029954 (10Bugreporter) 3NEW [06:06:29] 3Phabricator: Project search issue - https://phabricator.wikimedia.org/T89209#1029975 (10Krinkle) [06:06:32] 3Phabricator.org: Exact matches should always win when suggesting/auto-completing - https://phabricator.wikimedia.org/T76732#1029976 (10Krinkle) [08:34:28] 3Phabricator: Process to request a private project - https://phabricator.wikimedia.org/T823#1030131 (10Qgil) Seeing the discussion at T88762 and also knowing that other teams are considering Phabricator if the problem of private tasks can be solved (Zero, some non-tech WMF teams, and even the [[ https://meta.wik... [08:40:24] 3Phabricator.org: Exact matches should always win when suggesting/auto-completing - https://phabricator.wikimedia.org/T76732#1030138 (10Krinkle) [08:53:41] 3operations, Project-Creators, Phabricator: Create projects for Ops goals - https://phabricator.wikimedia.org/T87262#1030149 (10Nemo_bis) Please don't add this discussion to #HTTPS-by-default. I watch that project to read about HTTPS by default, not about Phabricator processes, and there is no ignore flag in Pha... [08:56:09] 3Phabricator: Project removal fails without warning - https://phabricator.wikimedia.org/T89221#1030158 (10Nemo_bis) 3NEW [09:18:24] 3Phabricator: "Security" values no longer updates visibility/editability policies when changed on existing bugs? - https://phabricator.wikimedia.org/T88681#1030177 (10matmarex) 5Open>3Invalid a:3matmarex Uh, that's the behavior I would expect... l keep discovering that the security setting are more messed... [09:29:48] 3Phabricator: Project removal fails without warning - https://phabricator.wikimedia.org/T89221#1030217 (10Qgil) This happens because "#https-by-default" is mentioned in the task description. Upstream is discussing about changing this behavior. [09:30:03] 3Phabricator.org: Project removal fails without warning - https://phabricator.wikimedia.org/T89221#1030221 (10Qgil) p:5Triage>3Volunteer? [09:30:47] 3operations, Project-Creators, Phabricator: Create projects for Ops goals - https://phabricator.wikimedia.org/T87262#1030225 (10Qgil) [09:31:03] 3operations, Project-Creators, Phabricator: Create projects for Ops goals - https://phabricator.wikimedia.org/T87262#987167 (10Qgil) [09:31:20] 3Phabricator, Phabricator.org: Switching back and forth between image in lightbox is slow (redirects, no cache) - https://phabricator.wikimedia.org/T89225#1030229 (10Krinkle) 3NEW [09:32:04] 3Phabricator: Adapting Gadget-BugStatusUpdate.js to Phabricator - https://phabricator.wikimedia.org/T539#1030241 (10Edokter) >>! In T539#1029945, @Ricordisamoa wrote: > ...and enwiki should load it dynamically. Please define 'dynamically'. If you mean load it raw from MediaWiki, I think that is a bad idea. How... [09:38:15] 3operations, Project-Creators, Phabricator: Create projects for Ops goals - https://phabricator.wikimedia.org/T87262#1030264 (10Qgil) >>! In T87262#1028378, @Krenair wrote: > This broke the policy at https://www.mediawiki.org/wiki/Phabricator/Creating_and_renaming_projects#New_projects that all project creations... [09:46:17] qgil: Guten tag. I am confused by Phabricator security option :-/ [09:46:35] I don't get the difference between "Security or Sensitive bug" and "Private" :\ [09:46:50] hi, one sec [09:48:09] hashar, same here, and this is why I filed/pushed https://phabricator.wikimedia.org/T76564 [09:48:50] The first one is for the security team, the second one is for ops hashar [09:48:57] so I guess I will use Private so. Thx qgil! [10:05:20] 3Phabricator: Unregistered users should be able to see subscribers of a task - https://phabricator.wikimedia.org/T89210#1030359 (10Qgil) ? As anonymous user, I can see the subscribers of this task: Subscribers Aklapper, Bugreporter Please share URLs where the problem you are reporting can be reproduced. [10:05:32] 3Phabricator.org: Unregistered users should be able to see subscribers of a task - https://phabricator.wikimedia.org/T89210#1030360 (10Qgil) [10:10:54] 3Phabricator: Fatal error (30 seconds timeout) for some maniphest search queries - https://phabricator.wikimedia.org/T87739#1030370 (10Qgil) [10:10:57] 3Phabricator: Fix provided search results in Wikimedia Phabricator - https://phabricator.wikimedia.org/T75854#1030369 (10Qgil) [10:18:09] 3Phabricator: Please remove the two-factor authentication from my Phabricator account - https://phabricator.wikimedia.org/T87495#1030414 (10zhaofengli) @Aklapper Thanks, it's on P280. [10:28:53] 3Phabricator.org: Unregistered users should be able to see subscribers of a task - https://phabricator.wikimedia.org/T89210#1030444 (10Bugreporter) If there're a lot of subscribers you will see "and XX others". When you click "XX others" Phabricator ask you to login. [10:39:25] 3operations, Project-Creators, Phabricator: Create projects for Ops goals - https://phabricator.wikimedia.org/T87262#1030470 (10faidon) >>! In T87262#1030264, @Qgil wrote: > Theoretically it is possible to have private projects, but there should be a reason for that. In this case, no reason has been presented so... [10:48:03] 3operations, Project-Creators, Phabricator: Create projects for Ops goals - https://phabricator.wikimedia.org/T87262#1030497 (10Krenair) >>! In T87262#1030470, @faidon wrote: >>>! In T87262#1030264, @Qgil wrote: >> Theoretically it is possible to have private projects, but there should be a reason for that. In t... [10:55:02] 3Phabricator: Adapting Gadget-BugStatusUpdate.js to Phabricator - https://phabricator.wikimedia.org/T539#1030505 (10Krenair) >>! In T539#1030241, @Edokter wrote: >>>! In T539#1029945, @Ricordisamoa wrote: >> ...and enwiki should load it dynamically. > > Please define 'dynamically'. If you mean load it raw from... [10:55:51] 3Phabricator: Fatal error (30 seconds timeout) for some maniphest search queries - https://phabricator.wikimedia.org/T87739#1030509 (10Tgr) Still doesn't explain why adding a keyword search actually makes the query slower, though. Does it trigger something expensive on the SQL side? Is the ES query different in... [11:06:49] 3Phabricator: Adapting Gadget-BugStatusUpdate.js to Phabricator - https://phabricator.wikimedia.org/T539#1030532 (10He7d3r) >>! In T539#1029945, @Ricordisamoa wrote: > It should be in the MediaWiki namespace, to avoid edits by untrusted people, +1, for many other reasons too (see e.g. {T86904}). > and enwiki sh... [11:08:41] 3operations, Project-Creators, Phabricator: Create projects for Ops goals - https://phabricator.wikimedia.org/T87262#1030535 (10Qgil) [11:16:57] 3Phabricator: Adapting Gadget-BugStatusUpdate.js to Phabricator - https://phabricator.wikimedia.org/T539#1030543 (10Arkanosis) >>! In T539#1030505, @Krenair wrote: >>>! In T539#1030241, @Edokter wrote: >>>>! In T539#1029945, @Ricordisamoa wrote: >>> ...and enwiki should load it dynamically. >> >> Please define... [11:17:30] 3operations, Project-Creators, Phabricator: Create projects for Ops goals - https://phabricator.wikimedia.org/T87262#1030544 (10faidon) [11:24:14] 3Engineering-Community, Code-Review, Phabricator, Wikimedia-Git-or-Gerrit: Migrate Gerrit project ownership request system (+2 rights) to Phabricator - https://phabricator.wikimedia.org/T86639#1030550 (10Qgil) If someone is watching regularly, then probably on-wiki and on-task are probably very similar. However,... [11:58:27] 3Phabricator: Adapting Gadget-BugStatusUpdate.js to Phabricator - https://phabricator.wikimedia.org/T539#1030572 (10Ricordisamoa) >>! In T539#1030241, @Edokter wrote: >>>! In T539#1029945, @Ricordisamoa wrote: >> ...and enwiki should load it dynamically. > > Please define 'dynamically'. If you mean load it raw... [12:24:24] 3Phabricator: Fatal error (30 seconds timeout) for some maniphest search queries - https://phabricator.wikimedia.org/T87739#1030621 (10Aklapper) Thanks a lot Mukunda for analyzing what's happening! >>! In T87739#1029677, @mmodell wrote: > Here's my analysis of what's happening with this particular search query:... [12:24:45] 3Phabricator: Fatal error (30 seconds timeout) for some maniphest search queries (with ElasticSearch backend) - https://phabricator.wikimedia.org/T87739#1030627 (10Aklapper) [12:25:43] 3Phabricator: Adapting Gadget-BugStatusUpdate.js to Phabricator - https://phabricator.wikimedia.org/T539#1030632 (10Ricordisamoa) >>! In T539#1030543, @Arkanosis wrote: >>>! In T539#1030505, @Krenair wrote: >>>>! In T539#1030241, @Edokter wrote: >>>>>! In T539#1029945, @Ricordisamoa wrote: >>>> ...and enwiki sho... [12:27:10] 3Phabricator.org: Unregistered users should be able to see all subscribers of a task (requires login for "and X others") - https://phabricator.wikimedia.org/T89210#1030641 (10Aklapper) p:5Triage>3Volunteer? [12:29:30] 3Phabricator, Phabricator.org: Switching back and forth between image in lightbox is slow (redirects, no cache) - https://phabricator.wikimedia.org/T89225#1030646 (10Aklapper) p:5Triage>3Low [12:30:20] 3Phabricator.org: Project removal fails without warning when project is mentioned in task description - https://phabricator.wikimedia.org/T89221#1030649 (10Aklapper) [12:41:32] 3Phabricator.org: Make Phabricator more open for anonymous users - https://phabricator.wikimedia.org/T89236#1030669 (10Bugreporter) 3NEW [12:41:47] 3Phabricator.org: Unregistered users should be able to see all subscribers of a task (requires login for "and X others") - https://phabricator.wikimedia.org/T89210#1030677 (10Bugreporter) [12:41:48] 3Phabricator.org: Make Phabricator more open for anonymous users - https://phabricator.wikimedia.org/T89236#1030676 (10Bugreporter) [13:00:24] 3Phabricator.org: Make Phabricator more open for anonymous users - https://phabricator.wikimedia.org/T89236#1030732 (10Aklapper) p:5Triage>3Volunteer? Personally I don't see any good purpose for having a neverending tracking bug "making Phab more open for anonymous users" (what does "open" mean actually?), e... [13:01:13] 3Phabricator.org: Make Phabricator more open for anonymous users - https://phabricator.wikimedia.org/T89236#1030739 (10Aklapper) Proposing to close this ticket and track the specific tasks that you are interested in instead. e.g. T972 is one that comes to my mind. [13:06:51] 3Phabricator.org: No way to list Pholios by project - https://phabricator.wikimedia.org/T89181#1030762 (10Aklapper) p:5Triage>3Volunteer? [13:07:00] 3Phabricator.org: Provide a way to list Pholios by project - https://phabricator.wikimedia.org/T89181#1030763 (10Aklapper) [13:17:37] 3Phabricator.org: Unregistered users should be able to see all subscribers of a task (requires login for "and X others") - https://phabricator.wikimedia.org/T89210#1030786 (10Qgil) This is related to {T639}. So far upstream has been fixing these inconsistencies when we have reported them. [13:23:21] 3Phabricator.org: Drag-and-drop of text while editing the description of a task does not work - https://phabricator.wikimedia.org/T88990#1030802 (10Nnemo) >>! In T88990#1026707, @Aklapper wrote: > [Please associate a project when creating tasks. Thanks!] [The first time, I was going to choose a project, so I lo... [14:08:19] 3Phabricator: Sending email to create tasks doesn't work for me - https://phabricator.wikimedia.org/T1077#1030966 (10MarkAHershberger) chasemp writes: > chasemp added a comment. > > In https://phabricator.wikimedia.org/T1077#940279, @Qgil wrote: > >> In https://phabricator.wikimedia.org/T85156 you created a tas... [14:09:21] 3Phabricator.org: Drag-and-drop of text while editing the description of a task does not work - https://phabricator.wikimedia.org/T88990#1030968 (10Aklapper) >>! In T88990#1030802, @Nnemo wrote: > Now, I don't even know how I did find the list of projects. See https://www.mediawiki.org/wiki/Phabricator/Help#Sel... [14:15:34] 3Phabricator: Sending email to create tasks doesn't work for me - https://phabricator.wikimedia.org/T1077#1030986 (10MarkAHershberger) 5Open>3Resolved a:3MarkAHershberger Appears to be working. T89241. Thanks for all your help! (One more reason never to leave emacs added.) [14:52:29] 3Phabricator: "Security" values no longer updates visibility/editability policies when changed on existing bugs? - https://phabricator.wikimedia.org/T88681#1031118 (10chasemp) >>! In T88681#1030177, @matmarex wrote: > Uh, that's the behavior I would expect... l keep discovering that the security setting are more... [15:00:35] 3Phabricator: Fix provided search results in Wikimedia Phabricator - https://phabricator.wikimedia.org/T75854#1031138 (10chasemp) [15:25:06] 3Code-Review: GitHub->Phabricator import system - https://phabricator.wikimedia.org/T715#1031233 (10Ricordisamoa) Even the [[ //tools.wmflabs.org/gerrit-patch-uploader/ | Gerrit Patch Uploader ]] by @valhallasw is hosted on GitHub... [15:55:40] 3Phabricator: Fatal error (30 seconds timeout) for some maniphest search queries (with ElasticSearch backend) - https://phabricator.wikimedia.org/T87739#1031322 (10chasemp) 5Open>3Resolved a:3chasemp takes a minute but finishes successfully now for me logged in and out [15:55:42] 3Phabricator: Fix provided search results in Wikimedia Phabricator - https://phabricator.wikimedia.org/T75854#1031325 (10chasemp) [16:00:47] 3Phabricator: Fix provided search results in Wikimedia Phabricator - https://phabricator.wikimedia.org/T75854#1031345 (10chasemp) >>! In T75854#1024713, @chasemp wrote: > Very sick today but in general I can do this, probably wed as it will > create an unknown period of search outage. I wanted to give @springle... [16:05:54] 3Phabricator: Fix provided search results in Wikimedia Phabricator - https://phabricator.wikimedia.org/T75854#1031380 (10chasemp) [16:05:55] 3Phabricator, Phabricator.org: Improve default search to prefer tasks over changesets - https://phabricator.wikimedia.org/T76273#1031377 (10chasemp) 5Open>3declined a:3chasemp There is an implicit behavior that I think can solve this for individual users if they desire (wish is already noted somewhat above... [16:06:14] 3Phabricator.org: Default search should be limited to open tasks. - https://phabricator.wikimedia.org/T88533#1031381 (10chasemp) [16:06:15] 3Phabricator, Phabricator.org: Improve default search to prefer tasks over changesets - https://phabricator.wikimedia.org/T76273#1031382 (10chasemp) [16:07:43] 3Phabricator: Searchable "Reference" custom field - https://phabricator.wikimedia.org/T991#1031384 (10chasemp) This has been sitting for awhile now. Is anyone going to take this on? [16:10:00] 3Phabricator, Phabricator.org: Can't search an exact phrase in Phabricator - https://phabricator.wikimedia.org/T75743#1031388 (10chasemp) 5Open>3Resolved >>! In T75743#978756, @Qgil wrote: > Unless there is some indexing to be done or some special syntax to be used other than quotes, searching for "whole blo... [16:10:02] 3Phabricator: Fix provided search results in Wikimedia Phabricator - https://phabricator.wikimedia.org/T75854#1031390 (10chasemp) [16:11:08] 3Phabricator: Fix provided search results in Wikimedia Phabricator - https://phabricator.wikimedia.org/T75854#783695 (10chasemp) [16:11:11] 3Phabricator, Phabricator.org: Phabricator search does not reliably match assigned projects - https://phabricator.wikimedia.org/T78219#1031392 (10chasemp) 5Open>3Resolved a:3chasemp Unless I'm mistaken the expected results are now there: https://phabricator.wikimedia.org/search/query/x.ZdhI1NTHPD/#R [16:12:00] 3Phabricator: Searchable "Reference" custom field - https://phabricator.wikimedia.org/T991#1031396 (10chasemp) >>! In T991#1031384, @chasemp wrote: > This has been sitting for awhile now. Is anyone going to take this on? Better question, is this a necessary feature at this point? [16:12:47] 3Phabricator: Fix provided search results in Wikimedia Phabricator - https://phabricator.wikimedia.org/T75854#1031399 (10mmodell) [16:12:49] 3Phabricator: Fatal error (30 seconds timeout) for some maniphest search queries (with ElasticSearch backend) - https://phabricator.wikimedia.org/T87739#1031397 (10mmodell) 5Resolved>3Open >>! In T87739#1031322, @chasemp wrote: > takes a minute but finishes successfully now for me logged in and out The sear... [16:13:00] 3Phabricator: Fatal error (30 seconds timeout) for some maniphest search queries (with ElasticSearch backend) - https://phabricator.wikimedia.org/T87739#1031401 (10mmodell) a:5chasemp>3mmodell [16:17:30] 3Phabricator: Fatal error (30 seconds timeout) for some maniphest search queries (with ElasticSearch backend) - https://phabricator.wikimedia.org/T87739#1031406 (10chasemp) >>! In T87739#1031397, @mmodell wrote: >>>! In T87739#1031322, @chasemp wrote: >> takes a minute but finishes successfully now for me logged... [16:22:54] 3Phabricator: Lots of unrelated results when searching for specific string - https://phabricator.wikimedia.org/T86805#1031412 (10chasemp) I'm pretty sure this is a 'special characters' and 'mysql full text search' issue. How exactly to resolve that I am not sure. @springle any wisdom on this or what we could f... [16:25:24] 3Phabricator: Maniphest advanced search broken when keyword field is provided. - https://phabricator.wikimedia.org/T87739#1031421 (10mmodell) [16:27:26] 3Phabricator, Phabricator.org: Maniphest advanced search broken when keyword field is provided. - https://phabricator.wikimedia.org/T87739#1031423 (10mmodell) Elasticsearch backend is still broken completely, we need to at least upstream the bug. [16:35:55] 3Phabricator: Fix provided search results in Wikimedia Phabricator - https://phabricator.wikimedia.org/T75854#1031440 (10chasemp) [17:18:03] 3Phabricator: Task creation by email is unclear - https://phabricator.wikimedia.org/T865#1031600 (10valhallasw) 5Open>3Resolved a:3valhallasw [17:31:21] twentyafterfour: yoyo? [17:31:44] chasemp: hey [17:31:59] why teh change here for the subtask from admin to 'phab' https://gerrit.wikimedia.org/r/#/c/186533/2/src/policy/WMFSecurityPolicy.php [17:32:00] ? [17:32:13] I think will not be cool https://phabricator.wikimedia.org/p/phab/ [17:32:16] unless I'm not getting it [17:33:09] sorry, phab is the default admin user [17:33:19] is admin the name we use in production? [17:33:27] to test I had to change it to phab [17:33:29] yes [17:33:32] gotcha [17:34:08] oversight. I hate differences between production and testing. that should be made into a config variable somehow [17:34:56] yes someday let's make a real preseed for this [17:35:01] so it's all nice and neat [17:42:16] 3operations, Phabricator: The options of the Security dropdown in Phabricator need to be clear and documented - https://phabricator.wikimedia.org/T76564#1031747 (10chasemp) [17:45:58] 3operations, Phabricator: The options of the Security dropdown in Phabricator need to be clear and documented - https://phabricator.wikimedia.org/T76564#1031766 (10faidon) So, where do e.g. Parsoid security bugs should be filled under? How about e.g. Heartbleed-type of issues? This "MediaWiki security bug" makes... [17:50:55] 3operations, Phabricator: The options of the Security dropdown in Phabricator need to be clear and documented - https://phabricator.wikimedia.org/T76564#1031780 (10Parent5446) I believe the security drop-down is an indication of the severity of the bug, not the project with which it is associated. So any bug tha... [17:51:39] 3operations, Phabricator: The options of the Security dropdown in Phabricator need to be clear and documented - https://phabricator.wikimedia.org/T76564#1031785 (10chasemp) Updated the text and https://www.mediawiki.org/wiki/Phabricator/Security can someone verify and see if more is required here? [18:14:46] 3Phabricator: Prevent private information being leaked via Herald notifications - https://phabricator.wikimedia.org/T493#1031912 (10chasemp) >>! In T493#1025120, @scfc wrote: > What's stalling this? @scfc AFAIK it is essentially https://phabricator.wikimedia.org/T76564 [] Prevents users from CCing themselves... [18:25:52] 3Phabricator: Show correct external IP addresses (XFF support) in activity log - https://phabricator.wikimedia.org/T840#1031930 (10chasemp) 5Open>3stalled Does not work as of now: https://secure.phabricator.com/T7114 [18:29:45] 3Release-Engineering, Engineering-Community, Wikibugs: Only use -devtools irc channel for phab-related ticket announcements - https://phabricator.wikimedia.org/T89153#1031940 (10greg) 5Open>3Resolved >>! In T89153#1031745, @gerritbot wrote: > Change 189901 merged by jenkins-bot: Thanks @legoktm. And your st... [18:29:57] 3Release-Engineering, Engineering-Community, Wikibugs: Only use -devtools irc channel for phab-related ticket announcements - https://phabricator.wikimedia.org/T89153#1031943 (10greg) p:5Triage>3Normal [18:44:39] 3operations, Phabricator: Mysql search issues flagged by Phabricator setup - https://phabricator.wikimedia.org/T89274#1031992 (10chasemp) 3NEW [18:47:48] 3operations, Phabricator: Mysql search issues flagged by Phabricator setup - https://phabricator.wikimedia.org/T89274#1031999 (10chasemp) p:5Triage>3High [18:52:42] 3operations, Phabricator: The options of the Security dropdown in Phabricator need to be clear and documented - https://phabricator.wikimedia.org/T76564#1032022 (10JanZerebecki) >>! In T76564#950388, @Qgil wrote: > I have changed "MediaWiki security bug" for "Software security bug" because in addition to MediaWi... [19:11:45] 3Phabricator, Phabricator.org: Improve default search to prefer tasks over changesets - https://phabricator.wikimedia.org/T76273#1032064 (10scfc) https://secure.phabricator.com/T6905, "On design/product philosophy": "Phabricator itself is a productivity tool first, and specifically built for people who spend lar... [19:25:03] 3Phabricator: Fix provided search results in Wikimedia Phabricator - https://phabricator.wikimedia.org/T75854#1032104 (10awight) wOOT! Thanks for all the great work, search results look exceptionally healthy today. [19:29:08] 3Phabricator, Wikimedia-Bugzilla: Create a static HTML version of Bugzilla - https://phabricator.wikimedia.org/T85140#1032129 (10Dzahn) [19:53:33] 3Phabricator: Lots of unrelated results when searching for specific string - https://phabricator.wikimedia.org/T86805#1032288 (10Qgil) Searching for "/event.gif?" (including the quotes) provides better results, apparently. The slash and the question mark are kind of ignored, but the results offered do contain al... [19:54:50] <^d> chasemp: Do we have puppet patches in for those config problems? [19:54:59] which? [19:55:07] mysql? [19:55:11] <^d> yeah [19:55:24] haven't had time / wanted to verify w/ springle before merge at least [19:55:32] so no :D [19:55:45] what do you think on min length for index [19:55:54] will doing 3 characters make it go bonkers? [19:56:03] <^d> That's a good question for spingle. [19:56:04] missing our on "web" or "api" could kinda suck [19:56:08] yeah :) [19:56:12] <^d> The other 2 things are "sure let's do it imho" [19:56:16] riiight [19:56:19] <^d> stop words for sure [19:56:51] been sick so kinda buried under catchup stuff with a morning full of search fun atm [19:58:29] 3Engineering-Community, Code-Review: How to prioritize code review of patches submitted by volunteers - https://phabricator.wikimedia.org/T78768#1032314 (10Qgil) Now http://korma.wmflabs.org/browser/code_contrib_new_gone.html shows current data. The page might take a bit of time to load, but it loads. I find thi... [19:59:28] ^d: https://phabricator.wikimedia.org/T89274 [20:01:34] 3operations, Phabricator: Mysql search issues flagged by Phabricator setup - https://phabricator.wikimedia.org/T89274#1032330 (10Chad) * +1 to changing the boolean syntax to AND instead of OR. Nobody expects OR by default. * +1 to lowering min word length to 3, as long as it doesn't have insane performance impli... [20:03:50] 3Phabricator: Prevent private information being leaked via Herald notifications - https://phabricator.wikimedia.org/T493#1032333 (10scfc) I know the problem, but what is stalling fixing it? Herald was proposed as a solution for Bugzilla functionality missing in Phabricator, and watching the #Phabricator project... [20:08:24] 3Phabricator: Prevent private information being leaked via Herald notifications - https://phabricator.wikimedia.org/T493#1032344 (10chasemp) >>! In T493#1032333, @scfc wrote: > I know the problem, but what is stalling fixing it? Herald was proposed as a solution for Bugzilla functionality missing in Phabricator... [20:27:42] 3Phabricator, Phabricator.org: Phabricator search does not reliably match assigned projects - https://phabricator.wikimedia.org/T78219#1032429 (10Qgil) I'm not sure this is fixed. T76883 now appears in the results, but this might be just because on Dec 29 and later "restbase" was mentioned in the comments. Befor... [21:47:16] 3Phabricator: Process to request a private project - https://phabricator.wikimedia.org/T823#1032703 (10chasemp) >>! In T823#1030131, @Qgil wrote: > Seeing the discussion at T88762 and also knowing that other teams are considering Phabricator if the problem of private tasks can be solved (Zero, some non-tech WMF... [22:12:16] 3Phabricator: Process to request a private project - https://phabricator.wikimedia.org/T823#1032784 (10Slaporte) >>! In T823#1030131, @Qgil wrote: > Seeing the discussion at T88762 and also knowing that other teams are considering Phabricator if the problem of private tasks can be solved (Zero, some non-tech WMF... [23:06:28] who sees why this is a syntax error ? [23:06:38] https://gerrit.wikimedia.org/r/#/c/189140/1/manifests/role/phabricator.pp [23:06:47] Syntax error at 'Domains'; expected '}' [23:07:02] i just dont see it.. it's ending in , like before and the example is also like that [23:08:04] it would be one thing if it doesn't work but that it's already disliked by jenkins puppet-pplint-HEAD .. i dont get [23:09:51] I stared at it now for a few minutes with no luck :) [23:10:03] seems like the use of a caps in a hash key? [23:10:05] only guess [23:10:09] mutante: ^ [23:13:37] chasemp: caps is a good idea, at least something to try, i wonder if it would match in lower case, since the tag in phab is capitalized [23:13:49] lemme see first if that's actually it [23:17:34] chasemp: you were right. that's it, thanks [23:17:47] now i kindof just want to rename it in phab [23:18:02] I'm not sure why that's flagged as a lint error? [23:18:59] it's the "pplint" not the "puppetlint" hmm [23:19:15] wth is pplint [23:19:27] not sure :p [23:19:46] operations-puppet-pplint-HEAD [23:20:29] https://integration.wikimedia.org/ci/job/operations-puppet-pplint-HEAD/ [23:20:58] uh? and there it has "puppet" in the name again [23:21:33] https://www.youtube.com/watch?v=XVSRm80WzZk [23:21:35] because there it's the repo name [23:22:20] :) we should play that as background music on the error pages [23:22:29] re: nicer error pages :p [23:30:57] it's an actual puppet syntax error as opposed to a lint error (or it thinks it is), i may poke hashar [23:31:28] I have no idea why that would be [23:32:26] what if i just "edit project" and change the name [23:33:22] they are not case sensitive in phab [23:33:28] so should be fine either way I think [23:33:36] i.e. you can't have domains and Domains [23:33:43] that would just make life hard [23:33:50] i'll do that, i like lower case slightly better anyways [23:34:32] yea, it's like Mediawiki, makes sense:) [23:34:54] even though MW can be set to be sensitive, i should say like MW user names [23:35:00] thanks [23:35:25] done. so i guess we could just try if the mail stuff works [23:35:43] by merging and asking Doneva to send a mail [23:36:07] sure, we really need to fix the formatting done for inbound emails tho [23:36:19] I notice that since ppl don't expect (and even when they do) remarkup syntax [23:36:29] they don't account for it soy ou get like leading spaces quoting things oddly [23:36:32] it's uggly [23:36:40] shouldn't be too hard tho [23:37:18] ok, cool [23:38:14] heh, and that made me look at T89286 :) [23:38:35] DHL fail [23:39:10] it seems odd that it's from like a private gmail [23:40:16] thats why I wasn't sure if it was legit or? [23:40:18] seems super weird [23:42:00] i declined it now [23:42:33] rob also commented.. and yeah, maybe malware then behind the download link