[04:45:56] 3Wikimedia-General-or-Unknown, Code-Review: Implement a sane code-review process for MediaWiki JS/CSS pages on Wikimedia sites - https://phabricator.wikimedia.org/T71445#958792 (10MZMcBride) >>! In T71445#956103, @Nemo_bis wrote: > I feel this report is //un cane che si morde la coda//. Unless someone summarises... [04:50:34] 3Phabricator, Phabricator.org: Can't quote old Phabricator comments - https://phabricator.wikimedia.org/T85982#958794 (10MZMcBride) 3NEW [04:51:13] 3Phabricator: Rename unofficial apps projects to remove "or" - https://phabricator.wikimedia.org/T85983#958800 (10TTO) 3NEW a:3Aklapper [04:51:44] 3Phabricator.org: Disable Phabricator comment hiding/collapsing - https://phabricator.wikimedia.org/T912#958809 (10MZMcBride) {T85982} seems related. [07:39:00] 3Phabricator: High level overview of Phabricator projects - https://phabricator.wikimedia.org/T833#958891 (10Qgil) We have scheduled this task for #ECT-January-2015 but it has no owner. Based on lessons learned, we should either get an owner for it or remove it from the sprint. [07:39:57] 3Phabricator: Clearer instructions in the Phabricator login page - https://phabricator.wikimedia.org/T545#958892 (10Qgil) a:3Qgil [08:10:37] 3Phabricator, Engineering-Community: Engineering Community team quarterly review Jan 2015 - https://phabricator.wikimedia.org/T85986#958901 (10Qgil) 3NEW a:3Qgil [08:10:48] 3Phabricator, Engineering-Community: Engineering Community team quarterly review Jan 2015 - https://phabricator.wikimedia.org/T85986#958901 (10Qgil) p:5Triage>3High [08:32:34] 3Phabricator, Phabricator.org: getting PhabricatorDataNotAttachedException error - https://phabricator.wikimedia.org/T85950#958912 (10Qgil) Trying to test this problem. Yesterday was the first day I accessed M15 and today the comments still don't appear collapsed. Seeing the full list of comments, all links seem... [08:39:49] 3Phabricator, Phabricator.org: Can't quote old Phabricator comments - https://phabricator.wikimedia.org/T85982#958922 (10Qgil) [08:42:08] 3Phabricator, Phabricator.org: Can't quote old Phabricator comments - https://phabricator.wikimedia.org/T85982#958926 (10Qgil) p:5Triage>3Normal This problem was reported by @Krenair directly upstream https://secure.phabricator.com/T6736, and it turned out to be a duplicate of https://secure.phabricator.com/... [08:42:23] 3Phabricator, Phabricator.org: Can't quote old Phabricator comments - https://phabricator.wikimedia.org/T85982#958929 (10Qgil) 5Open>3Resolved a:3Qgil [08:42:50] 3Phabricator, Phabricator.org: Can't quote old Phabricator comments - https://phabricator.wikimedia.org/T85982#958794 (10Qgil) [08:48:17] 3Phabricator: Next Phabricator upgrade on YYYY-MM-DD (to be defined) - https://phabricator.wikimedia.org/T78243#958938 (10Qgil) Is this upgrade in fact blocked by {T85123} and the fact that @mmodell and @christopher's large patches on the Security and Sprint extensions need to be in sync? @modell also mentioned... [10:34:36] 3Phabricator.org: HTTPFutureHTTPResponseStatus when searching for unindexed document types - https://phabricator.wikimedia.org/T85505#959080 (10Krenair) Merged upstream, is this to be closed now? [10:34:56] 3Phabricator, Phabricator.org: Phabricator search does not search substrings - https://phabricator.wikimedia.org/T679#959081 (10Krenair) Should this be closed now? [10:35:07] 3Phabricator, Phabricator.org: Can't search an exact phrase in Phabricator - https://phabricator.wikimedia.org/T75743#959083 (10Krenair) Close? [10:41:51] 3Phabricator: Fix search in Wikimedia Phabricator - https://phabricator.wikimedia.org/T75854#959096 (10Qgil) [10:41:54] 3Phabricator, Phabricator.org: Can't search an exact phrase in Phabricator - https://phabricator.wikimedia.org/T75743#959095 (10Qgil) 5Open>3Resolved [10:42:20] 3Phabricator.org: HTTPFutureHTTPResponseStatus when searching for unindexed document types - https://phabricator.wikimedia.org/T85505#959097 (10Qgil) 5Open>3Resolved [10:42:35] 3Phabricator, Phabricator.org: Phabricator search does not search substrings - https://phabricator.wikimedia.org/T679#959099 (10Qgil) 5Open>3Resolved [10:42:37] 3Phabricator: Fix search in Wikimedia Phabricator - https://phabricator.wikimedia.org/T75854#783695 (10Qgil) [10:43:42] 3Phabricator.org: "Ignore" notification level setting has no effect on web notifications - https://phabricator.wikimedia.org/T76098#959101 (10Qgil) 5Open>3Resolved a:3Qgil [10:44:09] 3Phabricator.org: Notifications about events in restricted applications can't be marked read - https://phabricator.wikimedia.org/T78246#959105 (10Qgil) [10:44:11] 3Phabricator, Phabricator.org: Do not send emails when importing changes to Diffusion - https://phabricator.wikimedia.org/T78154#959103 (10Qgil) 5Open>3Resolved a:3Qgil [11:01:59] 3Phabricator.org: Logging when a task has been marked as a blocker - https://phabricator.wikimedia.org/T76556#959131 (10Qgil) [11:05:26] How did you guys add the MW.org login for Phabricator? It uses OAuth but I can't find any code to see how you implemented that on the Phabricator side... [11:13:59] is there a project for SMW? [11:14:01] !hss [12:22:30] Lcawte: it's in a patchset on secure.phabricator.org [12:22:49] Lcawte: and probably also in the wmf clone of the phab repo [12:23:22] Lcawte: https://github.com/wikimedia/phabricator-phabricator/tree/oauth [12:23:52] Lcawte: I think https://github.com/wikimedia/phabricator-phabricator/tree/arcpatch-D9203 si what is currently deployed [12:36:38] Hm, I seem to be running a later version of Phabricator than that. [12:36:48] Thanks valhallasw`cloud :) [12:38:44] Oh hang on... that gH link has the newer version :) [12:43:39] 3Phabricator: Rename unofficial apps projects to remove "or" - https://phabricator.wikimedia.org/T85983#959218 (10Aklapper) a:5Aklapper>3None [12:45:56] 3Phabricator: Rename unofficial apps projects to remove "or" - https://phabricator.wikimedia.org/T85983#959220 (10Aklapper) 5Open>3Resolved a:3Aklapper That was still on my to-do list (though rather low). Done now, thanks! [12:47:19] 3Phabricator, Phabricator.org: Can't quote old Phabricator comments - https://phabricator.wikimedia.org/T85982#959225 (10Aklapper) [12:47:20] 3Phabricator: "Quote"/"View Raw" comment dropdown options not available in yet-to-define circumstances - https://phabricator.wikimedia.org/T85537#959224 (10Aklapper) [12:51:41] 3Phabricator: High level overview of Phabricator projects - https://phabricator.wikimedia.org/T833#959230 (10Aklapper) I'm going to remove ECT 01/2015 from this. It's a nice to have but I don't think I'll have time to work on this in January [12:51:50] 3Phabricator: High level overview of Phabricator projects - https://phabricator.wikimedia.org/T833#959231 (10Aklapper) [13:03:09] 3Phabricator, Fundraising-Backlog: Create project for Fundraising - https://phabricator.wikimedia.org/T682#959239 (10Aklapper) @atgo: If I can help with cleaning up the now 17 tasks under [[ https://phabricator.wikimedia.org/maniphest/query/bSyzmb9u7iGe/#R | Wikimedia-Fundraising ]] (and archive that project aft... [13:12:22] 3Phabricator: Phabricator project names and hashtags inconsistently use spaces, hyphens, and underscores - https://phabricator.wikimedia.org/T75994#959252 (10Aklapper) [13:12:24] 3Phabricator.org: Projects with spaces are being displayed on two lines - https://phabricator.wikimedia.org/T78140#959253 (10Aklapper) [13:17:25] 3Phabricator: Decide on "Needs Volunteer" Priority field value in Phabricator - https://phabricator.wikimedia.org/T78617#959262 (10Aklapper) p:5Normal>3High No comments on renaming back from "Needs Volunteer" to "Wishlist" so I assume that people either agree with "Wishlist" or don't care. To avoid further... [14:06:59] 3Phabricator: Phabricator project names and hashtags inconsistently use spaces, hyphens, and underscores - https://phabricator.wikimedia.org/T75994#959323 (10Qgil) 5Open>3Resolved a:3Qgil I believed this is fixed now. [14:07:00] 3Phabricator.org: Projects with spaces are being displayed on two lines - https://phabricator.wikimedia.org/T78140#959326 (10Qgil) [14:11:57] 3Phabricator.org: getting PhabricatorDataNotAttachedException error - https://phabricator.wikimedia.org/T85950#959339 (10Qgil) p:5Unbreak!>3High [15:04:06] 3Phabricator.org: Notifications about events in restricted applications can't be marked read - https://phabricator.wikimedia.org/T78246#959454 (10Chad) [15:04:09] 3Phabricator, Phabricator.org: Do not send emails when importing changes to Diffusion - https://phabricator.wikimedia.org/T78154#959452 (10Chad) 5Resolved>3Open This isn't fixed. [15:09:31] 3Phabricator.org: RSS/Atom feeds - https://phabricator.wikimedia.org/T67#959466 (10Aklapper) [15:15:54] 3Phabricator: Existing Phabricator user waiting 1 month for bugzilla activity to be assigned - https://phabricator.wikimedia.org/T85137#959480 (10Aklapper) 5Open>3stalled [15:39:38] 3Phabricator: 503 when batch-editing tasks in Phab - https://phabricator.wikimedia.org/T76152#959705 (10Aklapper) I just triggered this after 85 out of 131 tasks so it's not about the number but about the time. [15:41:10] andre__: would it be possible to avoid updating bugs that have been closed years ago ? :} [15:41:25] how? [15:41:27] andre__: https://phabricator.wikimedia.org/T2373 was closed 9 years ago and got tagged Documentation [15:41:32] I am not sure it is worth it [15:41:54] well, do we want consistent and complete lists of tickets when querying or not? I don't know. :) [15:42:11] I was thinking of only updating open tickets. But I don't know - search results would not be complete anymore then. [15:42:11] maybe :] [15:42:32] I can easily delete the mail notifications anyway, so not much of an issue [15:52:06] 3Phabricator, operations: Create #site-incident tag and use it for incident reports - https://phabricator.wikimedia.org/T85889#959802 (10Aklapper) See previous discussion in T929. Might want to close this as a dup and argument there instead, to have discussion in one place? [15:58:11] 3Phabricator, MediaWiki-General-or-Unknown, Project-Creators, MediaWiki-Core-Team: Allow to search tasks about MediaWiki core and core only (create MediaWiki umbrella project?) - https://phabricator.wikimedia.org/T76942#959825 (10Aklapper) p:5Normal>3High [16:35:43] 3Phabricator.org: Phabricator tags should be listed as tags, not projects - https://phabricator.wikimedia.org/T75961#959929 (10Qgil) >>! In T75961#958312, @Nemo_bis wrote: > Someone please update the image. [[ https://www.mediawiki.org/wiki/Phabricator/Creating_and_renaming_projects#Type_of_project | Done ]].... [16:51:56] andre__: Is there a bug in Phab with disabling notifications about tokens, or is that supposed to be possible. I've disabled all notifications using "Ignore" except for comments. Still getting notifications for token rewards. [16:53:23] probably a bug then, that should be silenced I would think in that case [16:55:07] I don't know all bugs of Phabricator. [16:55:21] but if your "Everything else" setting does not cover that, it sounds like a bug. [16:55:56] andre__: why don't you know all bugs in phabricator? slacker [16:56:21] ^ [17:42:49] andre__: Indeed. I've got "Everything else" ignored as well. [18:22:50] 3Phabricator: Enable notification server (real-time pop-up notifications) in Phabricator - https://phabricator.wikimedia.org/T765#960191 (10csteipp) [18:22:53] 3Phabricator, Security-Reviews, MediaWiki-Core-Team: Aphlict security review - https://phabricator.wikimedia.org/T1286#960189 (10csteipp) 5Open>3stalled >>! In T1286#957936, @Qgil wrote: > There is ongoing work to get rid of Flash and use WebSockets. Should we resolve this task as Stalled in the meantime? >... [19:06:44] 3Phabricator: Next Phabricator upgrade on YYYY-MM-DD (to be defined) - https://phabricator.wikimedia.org/T78243#960429 (10chasemp) >>! In T78243#958938, @Qgil wrote: > Is this upgrade in fact blocked by {T85123} and the fact that @mmodell and @christopher's large patches on the Security and Sprint extensions nee... [19:11:10] 3Phabricator, Phabricator.org: Do not send emails when importing changes to Diffusion - https://phabricator.wikimedia.org/T78154#960467 (10chasemp) >>! In T78154#959452, @Chad wrote: > This isn't fixed. Is there an upstream for the non-access-denied email-being-sent-inappropriately part of this bug? [19:12:11] 3Phabricator, Phabricator.org: Do not send emails when importing changes to Diffusion - https://phabricator.wikimedia.org/T78154#960474 (10Chad) >>! In T78154#960467, @chasemp wrote: >>>! In T78154#959452, @Chad wrote: >> This isn't fixed. > > Is there an upstream for the non-access-denied email-being-sent-inap... [19:13:16] 3Phabricator, Phabricator.org: Do not send emails when importing changes to Diffusion - https://phabricator.wikimedia.org/T78154#960478 (10chasemp) Can you outline here the deal and how to reproduce and I will try to catch upstream on this? [19:15:11] 3Phabricator, Phabricator.org: Do not send emails when importing changes to Diffusion - https://phabricator.wikimedia.org/T78154#960491 (10Chad) It's easy. # Create repo via conduit with heraldEnabled: false ** Can also create via web (initially disabled), turn off herald, then enable # Let repo begin importing... [19:19:12] ^d: about? [19:19:17] what's interesting is...we didn't get them for puppet repo [19:19:17] <^d> yo yo [19:19:23] can you name a specific repo they happened for [19:19:27] maybe it's something weird [19:19:31] but it can't be all of them [19:19:34] <^d> No, because I've never gotten them either. [19:19:35] I don't think [19:19:38] well crap [19:19:41] <^d> People just keep bitching to me :) [19:19:48] any repo it was reported for specifically? [19:20:02] as is this is a hard thing to upstream as I haven't seen it [19:20:05] and I don't know where to point them [19:21:02] I have a commit in mw prime :D but saw no email and ops repo neither [19:21:04] so idk [19:21:16] <^d> Digging my IRC logs, sec. [19:21:19] and ops we did like 5 times so it would have been noticed :) [19:21:22] thanks [19:25:10] <^d> I can't find any specific repo names. [19:25:20] <^d> Just people talking about piles of e-mails [19:26:17] can we ping them or something, as is this is an unreproducable ghost issue [19:26:23] and we almost have to wait for it to happen again [19:26:53] <^d> Ah, got it [19:26:56] <^d> #wikimedia-devtools/2014-12-04_freenode (znc).txt:121:11:33 Lcawte: ... why'd I just get a bunch of emails from Phabricator about some repo I haven't edited in like, three years? [19:26:56] <^d> #wikimedia-devtools/2014-12-04_freenode (znc).txt:126:11:35 ^d: Lcawte: What repos, btw? [19:26:56] <^d> #wikimedia-devtools/2014-12-04_freenode (znc).txt:127:11:36 Lcawte: ^d: Userinfo [19:27:13] <^d> USERINFO repo confirmed as having sent e-mails. [19:27:22] https://phabricator.wikimedia.org/diffusion/UINF/ [19:27:23] ? [19:27:25] <^d> yep [19:27:27] k [19:28:27] what email would Lcawte have gotten updates too? [19:28:31] mabye it's specific people ven [19:28:32] even [19:29:06] <^d> That I don't know. [19:31:29] what's teh profile setting that seems to make it not send? [19:32:04] ^d: ^ [19:32:11] didn't see it in the issue and I can't remember [19:33:22] <^d> https://phabricator.wikimedia.org/settings/panel/emailpreferences/ -> Audit -> "A commit is created" -> Ignore [19:33:32] <^d> ok lunchtime [19:33:35] thanks man [19:33:41] I"ll file it and we'll see [19:47:09] ^d: yes you killed my inbox on the 10th of December with the EVED import [20:03:26] chasemp: are you going to join for 10min or not? if not that's fine :) [20:03:35] (I don't think it's really needed) [20:13:31] alright, that's an answer :P [20:23:33] 3Phabricator: Next Phabricator upgrade on YYYY-MM-DD (to be defined) - https://phabricator.wikimedia.org/T78243#960662 (10Aklapper) Upstream had bigger changes so for our next upgrade / pull we'll have to take Phab down for a bit longer (max 2h, to be on the safe side?). [20:24:32] 3Phabricator.org, Phabricator: Phabricator search does not search substrings - https://phabricator.wikimedia.org/T679#960666 (10Nemo_bis) > https://phabricator.wikimedia.org/search/query/dHeGWXS5BCJU/#R doesn't find anything Still true (as expected until the upgrade). [20:38:45] 3ยง Phabricator-Sprint-Extension, Release-Engineering, Phabricator: Create a continuous integration plan for Wikimedia Phabricator patches - https://phabricator.wikimedia.org/T85123#960700 (10Aklapper) p:5Normal>3High Thanks Hashar for creating that Jenkins job! As described earlier, development processes di... [20:58:03] <^demon|lunch> Krenair: Thx for another data point :) [20:58:05] <^demon|lunch> cc chasemp [21:57:51] 3Phabricator, Project-Creators: New project: "Wikimedia Incident Response" - https://phabricator.wikimedia.org/T929#961021 (10GWicke) A follow-up proposal to move all of the incident response to phab is at T85889. Please chime in. [21:58:32] 3Phabricator, operations: Create #site-incident tag and use it for incident reports - https://phabricator.wikimedia.org/T85889#956687 (10GWicke) @aklapper, lets use this issue to discuss the new proposal. I added a pointer in T929. [22:22:50] https://phabricator.wikimedia.org/T71804 - we have restricted projects? [22:31:20] 3Phabricator: Should be easy to create new cards on a workboard - https://phabricator.wikimedia.org/T86076#961080 (10Jdlrobson) 3NEW [22:35:23] <^d> Ugh, why can't I even view that as an admin? [22:35:31] <^d> Or NDA, or any of the other magic powers I have. [22:36:23] <^d> Seems wrong. [22:36:54] Ironholds can see it. [22:37:10] ^d: Admins are not omnipotent, apparently. [22:37:23] I have to wonder how legal feels about this. [22:37:31] <^d> I know that. I'm just curious why someone would setup a project with seemingly /overly/ restrictive permissions. [22:38:00] I can guess. [22:38:06] But let's ask ironholds [22:41:10] <^d> Follow along in #-research btw. [22:41:36] #$1-research ERRR $1 not defined. [22:42:17] <^d> Krenair: {{fixed}} [22:42:41] I saw [22:42:54] Halfak is responsible. [22:46:01] qgil, if admins can't see everything, who can? [22:47:46] Krenair: No-one, though admins also have shell access. [22:48:18] Okay, I think that's an issue. [22:49:17] And the ability to set a project's visibility should be highly restricted [22:49:29] Krenair, https://www.mediawiki.org/wiki/Phabricator/Permissions#Administrators [22:51:42] Krenair, about Analytics R&D being restricted, https://phabricator.wikimedia.org/T826#946979 [22:52:44] qgil, so... admins can access everything? [22:52:53] do they have to use shell access to get to it? [22:53:40] ah, I see that https://phabricator.wikimedia.org/tag/research-and-data/ is visible now [22:54:28] Yes, but it shouldn't be possible for that to happen again [22:54:35] Krenair, as documented. I don't see the big problem. [22:54:45] The problem with having invisible projects? [22:55:12] The problem is with users setting invisible projects, or with policies allowing to do that. [22:55:52] so by "as documented. I don't see the big problem." you were referring to admin access via shell? [22:56:11] yes, about admins not having superpowers in general [22:56:41] okay, I thought you were talking about the visibility thing [22:56:54] I'll make a ticket about project visibility then? [22:57:27] We have a guideline about project policy, I think that is enough [22:58:24] Krenair, https://www.mediawiki.org/wiki/Phabricator/Creating_and_renaming_projects#Policy is enough, don't you think? [22:58:44] Obviously not. [22:59:00] why not? Assume good faith, etc. [22:59:17] Because someone ignored it. [22:59:38] We ave created hundreds of projects, all of them are public. There were a few exceptions, and their owners opened them after requesting [23:00:18] Krenai: I think the question is, where is the harm? it hasn't caused anyone extreme pain and suffering has it? [23:00:21] People restricting the visibility of projects don't even know what they are doing, I dare to say. They probably think they are restricting the visibility of the related tasks. [23:00:42] When they realize this is not the case, and/or when they realize there is a guideline, they rectify [23:01:35] twentyafterfour, transparency. all phabricator projects must be visible to all [23:01:47] Krenair, aren't they? [23:02:01] what do you mean "aren't they"? [23:02:11] is there any project that is not public now? [23:02:24] You can find that out, I can't. Why are you asking me? [23:02:42] because I think all of them are public, but you seem to think otherwise [23:02:53] habeas corpus, etc :) [23:02:55] I don't know whether they're all public at the moment. [23:03:07] But I do know that someone managed to make one non-public. Which should not be allowed. [23:03:18] Yes, it was later fixed. Still should not be possible. [23:03:48] Well, I have shared my opinion. :) [23:05:43] That it should be allowed, until someone notices, and then you have to ask that it be fixed? [23:06:01] That's not a solution. [23:08:09] Krenair, I was there, see https://secure.phabricator.com/T6567#84951 :) [23:09:02] you were where? [23:09:29] click the link, it's a discussion upstream about this topic [23:12:01] So you're saying it's not currently possible to prevent people setting project visibility, but you asked upstream for it and they said no? [23:12:34] Guess it's one more item on the list of things justifying keeping a fork [23:13:08] They said no with an argument that I think it is good enough. [23:13:29] Krenair, I'd rather focus on problems, and I don't think that is a problem. [23:13:42] Maintaining a fork is a real problem [23:16:29] Alright, well past Cinderella time in ECT. Time for me to zzzz. [23:46:03] https://phabricator.wikimedia.org/T78765#852757 - what [23:46:16] Unknown Object (Commit)... [23:46:37] repo that was imported and then deleted, or something? I don't know [23:57:27] 3Phabricator.org: Should be easy to create new cards on a workboard - https://phabricator.wikimedia.org/T86076#961244 (10Aklapper) p:5Triage>3Volunteer?