[00:40:02] [17:39:06] Chad added a comment to P9 vagrant 'splosion. [00:40:07] no link? :( [13:09:13] Hi everyone [13:10:07] I'm joining to Phabricator and the help and top line say "You can use your unified Wikimedia account or your Labs/LDAP user to login.", but the fields just say "Login or Register with LDAP" [13:10:20] This is absolutely confusing... [13:10:34] jem: there's a 'log in with mediawiki' button below it [13:10:55] But MediaWiki is not Wikimedia unified SUL [13:11:12] Or not the first related thing I'll think of [13:11:45] It should say "Log in with Wikimedia SUL/global account", I think [13:14:34] And anyway, both options should be offered at least with the same importance (and probably Wikimedia first, as I think just 0,1% or less of the Wikimedia users have the LDAP account) [13:16:23] (But just trying to do constructive critics) :) [13:22:34] https://phabricator.wikimedia.org/T623 [13:22:34] hm, no, that's not the right one [13:23:09] jem: https://phabricator.wikimedia.org/T543 [13:23:21] and https://phabricator.wikimedia.org/T545 [14:34:27] valhallasw`cloud: I see :) [14:34:47] Ok then [18:32:09] valhallasw`cloud: bahh, there are 3 bots again [18:34:06] legoktm: yeah, I know. [18:34:14] working on stracing them [18:37:07] legoktm: it's some weird interaction between SGE and bash/php/phab [18:37:21] :/ [18:37:26] because the bot works fine if I just run it directly [18:37:31] tbh, I really prefer the output by wikibugs [18:37:32] hence strace [18:37:42] why? [18:37:47] it has way more info [18:37:53] ahh, sure [18:37:58] but the output will be changed :-) [18:38:11] ok :P [18:40:26] maybe even a jstart vs jsub issue, now that I think of it [18:48:01] legoktm: okay this is super weird. Using jstart I get three jobs, using jsub it just crashes [18:51:30] whaa [18:57:54] legoktm: /var/spool/gridengine/execd/tools-exec-10/job_scripts/4718501: line 4: 21701 User defined signal 1 /data/project/wikibugs/phabricator/run_phab_irc_bot.sh [18:58:07] ^ I get two of those, which suggests they correspond to three jobs :-p [19:00:58] what does the $@ mean in bash? [19:01:58] all parameters passed to the script [19:02:16] bash script.sh -something ---> $@ = -something [19:02:47] ah [19:03:26] legoktm: okay, with jsub I get only a single job, but it is backgrounded [20:09:43] legoktm: pfff. I can't figure out what the heck is going on, not even with strace :( [20:09:58] pywikibugs ;) [20:10:04] ohh. [20:10:06] OHH. [20:10:16] okay, the original job is killed with SIGUSR1 [20:11:17] but why... [20:15:11] legoktm: okay, I think this is what's happening. The normal supervisor and job use SIGUSR* to communicate -- but we're not running stuff under the normal supervisor [20:16:14] if (!posix_isatty(STDOUT)) { [20:16:14] posix_kill(posix_getppid(), SIGUSR1); [20:16:14] } [20:16:16] there we go [20:20:46] AAAAAARRRRRRRRRGGGGGGGHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH [20:20:52] rm strace * instead of rm strace.* [20:20:58] * valhallasw`cloud sobs [20:27:21] nooooo [20:38:15] okay, restored my mental backup [20:40:20] * valhallasw`cloud waves at phawikibugs [20:40:36] * valhallasw`cloud looks angrily at phawikibugs [20:40:56] okay, so why does this process not die when it's parent is killed... [20:42:50] it's not owned by the parent? [20:43:16] I suppose. Ugh, I hate this phabricator daemon magic [20:43:18] when you fork a process it's possible to decouple the parent from the child with e.g. disown [20:43:46] what's the issue? I have never had problems with phd [20:44:58] I'll be glad to help though [20:44:59] twentyafterfour: I'm trying to run the irc bot under SGE [20:45:14] twentyafterfour: which basically means I need to have it as foreground process [20:45:37] what's sge? [20:45:42] sorry. Sun Grid Engine [20:46:09] it's the scheduling system used on Tool Labs, where most community WMF tools run [20:46:10] why not run it in wmflabs? [20:46:14] oh [20:46:30] I didn't realize we used such a thing. [20:47:02] you should launch it with phd debug [20:47:08] that puts it in a foreground process [20:47:33] Tried that. Doesn't work -- probably because of the signalling between processes. [20:47:39] Hmm, maybe it does work now that I catch SIGUSR1 [20:47:44] worth the try [20:47:58] debug doesn't just launch it as a foreground process? hmm [20:48:03] well, it does [20:48:18] but the daemonized processes send SIGUSR1 to phd as 'hey, we're still alive' signal [20:48:26] but only if STDOUT is not a tty [20:48:38] (how fun that was to debug) [20:50:47] I see [20:50:47] sorry I should have read further up in the backlog [20:52:51] aaaan phd is gone [20:53:04] I'm just going to fake a tty [20:53:17] wow [20:53:18] I'm seriously done with this nonsense [20:53:27] might be worth asking in #phabricator [20:53:43] Tried that. [20:53:44] 14:09 <@epriestley> valhallasw`cloud: foregrounding is not supported [20:54:04] lame [20:55:05] we could just run the daemon on the phabricator box couldn't we? as a regular phd daemon? we have other daemons required by phabricator to run [20:55:29] but that means you need someone from ops to approve any changes to config or formatting [20:55:45] yeah ... [20:55:54] or we could run it on the phabs lab instance [20:56:04] phab labs instance [21:04:57] Yes. And all because Phab daemons are an unmanageable mess :-( [21:12:40] the main thing that surprises me is that SGE lets this happen [21:13:05] yeah it seems weird [21:20:05] GRRRRR [21:27:34] Qgil updated subscribers of T643: conduit api method for creating comments. https://phabricator.wikimedia.org/T643 [21:28:20] wat. [21:28:29] ... :-( [21:39:56] chasemp: untested patch for maniphest.update api: https://gerrit.wikimedia.org/r/#/c/166259/ [22:02:29] YESSSSSS [22:02:59] Success? [22:04:38] Yes. Coren changed the grid config to first send SIGINT and only SIGKILL later [22:05:02] so now I have a wrapper script that runs 'phd stop' when it receives SIGINT [22:06:17] valhallasw updated subscribers of T573: Get phawikibugs to run on tools.wmflabs. https://phabricator.wikimedia.org/T573 [22:06:42] *look of disapproval* [22:07:03] The reporting certainly needs some work - I added a comment. Which also added a CC, but that's definitely not the most relevant part :-p [22:07:23] * bd808 hopes that cc only changes would be ignored [22:07:35] valhallasw closed T573: Get phawikibugs to run on tools.wmflabs as "Resolved". https://phabricator.wikimedia.org/T573 [22:07:35] valhallasw closed T573: Get phawikibugs to run on tools.wmflabs, a task blocking T131: IRC bot to report Phabricator activity exactly like Wikibugs does with Bugzilla, as "Resolved". https://phabricator.wikimedia.org/T131 [22:07:50] bd808: {{to be done}} [22:07:56] :) [22:15:49] Qgil edited the description of T618: Send two email notifications to active Bugzilla users asking them to join Phabricator. https://phabricator.wikimedia.org/T618 [22:16:31] Qgil moved T618: Send two email notifications to active Bugzilla users asking them to join Phabricator to Doing on the Bugzilla-Migration workboard. https://phabricator.wikimedia.org/T618 [22:22:52] qgil, could we maybe have a phawikibugs project? Would be good for smaller tasks [22:25:47] mmodell added a comment to T643: conduit api method for creating comments. https://phabricator.wikimedia.org/T643 [22:26:23] Qgil updated subscribers of T618: Send two email notifications to active Bugzilla users asking them to join Phabricator. https://phabricator.wikimedia.org/T618 [22:28:15] Qgil added a comment to T390: Inform users that their Bugzilla tag entries and votes will not be transfered to Phab. https://phabricator.wikimedia.org/T390 [22:29:58] Qgil awarded T573: Get phawikibugs to run on tools.wmflabs a Yellow Medal token. https://phabricator.wikimedia.org/T573 [22:30:23] Qgil removed a project from T573: Get phawikibugs to run on tools.wmflabs: Phabricator. https://phabricator.wikimedia.org/T573 [22:31:00] does this phabot have task lookup turned on? [22:31:12] T643 [22:32:12] valhallasw`cloud: can you enable task lookup? that is, turn on PhabricatorBotObjectNameHandler [22:32:54] ideally only for this channel [22:34:23] twentyafterfour: I don't think I can set it up just for this channel [22:34:37] also, I'm a bit afraid of what would happen if two phawikibugs' enter at the same time :-p [22:34:43] valhallasw`cloud: we might need to modify it so that is configurable [22:34:49] yes [22:35:13] I'm planning to import the entire bot to a seperate repository, and work there [22:36:35] good idea... when you do that send me a link, I'd like to help out when I have time [22:37:31] twentyafterfour: sure. Do you have a tool labs account? [22:37:52] yeah ... I'm 20after4 on labs [22:38:18] mmh, but not a member of tool labs, it seems [22:38:49] twentyafterfour: could you fill in https://wikitech.wikimedia.org/wiki/Special:FormEdit/Tools_Access_Request ? [22:40:35] done [22:41:35] Qgil raised the priority of T618: Send two email notifications to active Bugzilla users asking them to join Phabricator from "Normal" to "High". https://phabricator.wikimedia.org/T618 [22:42:52] I wonder if we should filter out updates tot he priority and workboard position of tasks... mostly I would think that new tasks and status changes would be all that need mentioning in irc [22:44:10] IMO all changes to bugs should be reported, except for adding to CC [22:44:42] valhallasw`cloud, re phawikibugs projects, you sure deserve it! [22:45:48] legoktm: I'm thinking maybe a per-channel setting so each group can choose what they want to know about. for a 'feed' type channel it makes sense to publish everything but it could get pretty noisy in channels used for regular discussions [22:46:13] well, the task is replicating the exact output of wikibugs, so it really should do that [22:48:09] Qgil added a project to T573: Get phawikibugs to run on tools.wmflabs: phawikibugs. https://phabricator.wikimedia.org/T573 [22:48:22] Qgil added a project to T131: IRC bot to report Phabricator activity exactly like Wikibugs does with Bugzilla: phawikibugs. https://phabricator.wikimedia.org/T131 [22:48:30] hehe [22:48:47] phawikibugs was faster than me reporting the news valhallasw`cloud :) [22:48:48] (my workflow is very dependent on an IRC feed, I'd be totally lost without it) [22:48:54] I think 'exact' might be a bit of overkill [22:49:39] right, not actually exact, but the same information [22:49:54] valhallasw`cloud, legoktm https://phabricator.wikimedia.org/tag/phawikibugs/ [22:50:09] thanks qgil [22:50:43] I just noticed "Text is available under the Creative Commons Attribution-ShareAlike License" <-- doesn't specify which license? [22:50:49] 3.0 or 4.0? [22:52:15] Qgil added a project to T571: Make wikibugs parse phab emails & send messages: phawikibugs. https://phabricator.wikimedia.org/T571 [22:53:01] Qgil edited projects for T323: Make phabot use colors!, added: phawikibugs; removed Phabricator. https://phabricator.wikimedia.org/T323 [22:54:44] legoktm, assuming https://en.wikipedia.org/wiki/Wikipedia:Text_of_Creative_Commons_Attribution-ShareAlike_3.0_Unported_License (but that Phabricator footer doesn't allow links afaik) [22:54:53] ok, it should specify 3.0 then [22:55:42] recently we did a mass cleanup on Commons/OTRS where people said cc-by-sa 3.0, but someone just added a {{cc-by-sa}} template, which redirected to 1.0 [22:59:27] Qgil created T644: Mention to CreativeCommons license in footer should specify 3.0 or link to it. https://phabricator.wikimedia.org/T644 [23:00:47] thanks [23:00:50] > Qgil changed Security from none to none. [23:00:57] seems a bit silly? [23:01:07] Why are we trying to replicate en.wikipedia? [23:01:25] well, it's the license footer on all public WMF projects. [23:02:06] Qgil updated subscribers of T479: "changed Security from none to none.". https://phabricator.wikimedia.org/T479 [23:02:31] I see a link to https://creativecommons.org/licenses/by-sa/3.0/ instead... not enwiki [23:03:02] qgil: :P [23:03:05] :) [23:03:32] are tokens the equivalent of bz's voting? [23:03:40] Krenair, feel free to comment in a task, I'm not a lawyer (tm) etc :) [23:03:44] in the [23:03:53] qgil, where did you get the enwiki link from? [23:04:43] Krenair, https://en.wikipedia.org/wiki/Main_Page [23:05:00] legoktm: yes they are approximately equivalent to voting [23:05:26] "This text is available under the Creative Commons Attribution-ShareAlike Licence" links to https://creativecommons.org/licenses/by-sa/3.0/ not https://en.wikipedia.org/wiki/Wikipedia:Text_of_Creative_Commons_Attribution-ShareAlike_3.0_Unported_License [23:06:06] Krenair, what can I say, I'm just copying the link I get [23:07:12] legoktm, people use tokens in many ways, I like them. For instance, I just gave "a medal" to valhallasw`cloud for fixing phawikibugs https://phabricator.wikimedia.org/token/ [23:08:10] interesting [23:08:40] Oh, stupid enwiki customises it for en, but not en-gb. [23:08:53] The proper text is "This text is available under the Creative Commons Attribution-ShareAlike Licence; additional terms may apply. See Terms of Use for details." [23:09:16] Their customisation is "Text is available under the Creative Commons Attribution-ShareAlike License; additional terms may apply. By using this site, you agree to the Terms of Use and Privacy Policy. Wikipedia� is a registered trademark of the Wikimedia Foundation, Inc., a non-profit organization.", with the enwiki link, and also a hidden CC link [23:09:47] heh [23:09:48] * qgil wonders whether https://phabricator.wikimedia.org/token/leaders/ shows only open tasks -- that would be interesting [23:10:52] Krenair: https://en.wikipedia.org/w/index.php?title=MediaWiki:Wikimedia-copyright&action=history [23:10:54] Krenair updated subscribers of T644: Mention to CreativeCommons license in footer should specify 3.0 or link to it. https://phabricator.wikimedia.org/T644 [23:11:41] yeah, the "updated subscribers" is too much [23:12:10] he also left a comment though [23:12:26] ah ok [23:13:15] anyway, seeing phawikibugs running here is great news. /me goes to be with a smile :) [23:13:23] bedddd [23:14:05] Qgil edited the description of T644: Mention to CreativeCommons license in footer should specify 3.0 or link to it. https://phabricator.wikimedia.org/T644 [23:15:07] Qgil added a comment to T644: Mention to CreativeCommons license in footer should specify 3.0 or link to it. https://phabricator.wikimedia.org/T644