[00:00:00] (03PS2) 10Jdlrobson: Update nvm version for release branch [extensions/MobileFrontend] (REL1_36) - 10https://gerrit.wikimedia.org/r/690782 [00:01:12] (03CR) 10Jdlrobson: [C: 03+2] Remove mw-body-content from indicators [skins/Modern] - 10https://gerrit.wikimedia.org/r/684509 (https://phabricator.wikimedia.org/T279388) (owner: 10Jdlrobson) [00:01:54] (03PS8) 10Jdlrobson: Remove mw-body-content from HTML that is not the article body [skins/Vector] - 10https://gerrit.wikimedia.org/r/682774 (https://phabricator.wikimedia.org/T279388) [00:01:59] (03CR) 10Jdlrobson: [C: 03+2] Remove mw-body-content from HTML that is not the article body [skins/Vector] - 10https://gerrit.wikimedia.org/r/682774 (https://phabricator.wikimedia.org/T279388) (owner: 10Jdlrobson) [00:02:04] (03PS1) 10Ppchelko: LogEventsList: always define $pageName [core] - 10https://gerrit.wikimedia.org/r/690784 (https://phabricator.wikimedia.org/T282834) [00:02:24] (03PS4) 10Jdlrobson: Remove the redundant clear:both on #footer for CologneBlue [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/682266 (https://phabricator.wikimedia.org/T278470) (owner: 10Anjali041) [00:02:32] (03CR) 10Jdlrobson: [C: 03+2] Remove the redundant clear:both on #footer for CologneBlue [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/682266 (https://phabricator.wikimedia.org/T278470) (owner: 10Anjali041) [00:02:48] (03Merged) 10jenkins-bot: Using RevisionListBase::getPage instead of calling $title directly [core] - 10https://gerrit.wikimedia.org/r/690696 (https://phabricator.wikimedia.org/T282825) (owner: 10Zabe) [00:04:19] (03CR) 10Nray: [C: 03+2] Make `mw-content-body` universal to all skins [core] - 10https://gerrit.wikimedia.org/r/682773 (https://phabricator.wikimedia.org/T279388) (owner: 10Jdlrobson) [00:07:37] (03PS1) 10Zabe: Test [core] - 10https://gerrit.wikimedia.org/r/690785 [00:09:44] (03CR) 10jerkins-bot: [V: 04-1] Use localStorage for expandSections boolean [extensions/MobileFrontend] (REL1_36) - 10https://gerrit.wikimedia.org/r/690720 (https://phabricator.wikimedia.org/T281296) (owner: 10Martineznovo) [00:12:21] (03Merged) 10jenkins-bot: build: Switch node version to 10.24.0 now CI is on buster [extensions/MobileFrontend] (REL1_36) - 10https://gerrit.wikimedia.org/r/690780 (owner: 10Jforrester) [00:13:51] 10function-evaluator, 10Abstract Wikipedia team (Phase ε): Create Execution Environments for Supported Languages - https://phabricator.wikimedia.org/T273515 (10Jdforrester-WMF) [00:13:53] 10function-evaluator, 10Abstract Wikipedia team (Phase ε), 10Patch-For-Review: Create Execution Environment for JavaScript - https://phabricator.wikimedia.org/T275944 (10Jdforrester-WMF) 05Open→03Resolved [00:14:32] (03PS2) 10Jdlrobson: Merge content-media and content-thumbnails [core] - 10https://gerrit.wikimedia.org/r/690769 (https://phabricator.wikimedia.org/T278560) [00:14:37] 10function-evaluator, 10Abstract Wikipedia team (Phase ε): Create Execution Environments for Supported Languages - https://phabricator.wikimedia.org/T273515 (10Jdforrester-WMF) 05Open→03Resolved a:03cmassaro [00:14:39] 10function-evaluator, 10Abstract Wikipedia team (Phase ε), 10Epic: Create initial Function Evaluator service - https://phabricator.wikimedia.org/T271762 (10Jdforrester-WMF) [00:14:41] (03CR) 10Jdlrobson: [C: 03+2] Update nvm version for release branch [extensions/MobileFrontend] (REL1_36) - 10https://gerrit.wikimedia.org/r/690782 (owner: 10Jdlrobson) [00:14:53] 10Discovery-Search (Current work), 10Patch-For-Review: WDQS hosts low on /srv disk space - https://phabricator.wikimedia.org/T280382 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['wdqs1003.eqiad.wmnet'] ` Of which those **FAILED**: ` ['wdqs1003.eqiad.wmnet'] ` [00:15:00] 10Add-Link, 10Growth-Team (Current Sprint): [mobile] suggested add link inspector - reloading page workflows - https://phabricator.wikimedia.org/T282290 (10mewoph) The reason the warning shows up when "X" is clicked is that `onBeforeExit` in MobileFrontEnd is called. For browser back button, the warning is inv... [00:15:16] 10function-evaluator, 10Abstract Wikipedia team (Phase ε), 10Epic: Create initial Function Evaluator service - https://phabricator.wikimedia.org/T271762 (10Jdforrester-WMF) We'll want to do some parts of {T278651} here too. [00:16:18] (03PS3) 10Jforrester: Update nvm version for release branch [extensions/MobileFrontend] (REL1_36) - 10https://gerrit.wikimedia.org/r/690782 (owner: 10Jdlrobson) [00:16:28] 10Discovery-Search (Current work), 10Patch-For-Review: WDQS hosts low on /srv disk space - https://phabricator.wikimedia.org/T280382 (10ops-monitoring-bot) Completed auto-reimage of hosts: ` ['wdqs2003.codfw.wmnet'] ` Of which those **FAILED**: ` ['wdqs2003.codfw.wmnet'] ` [00:16:57] (03CR) 10Jforrester: "This is a no-op (dupe of 826fdba297061c6e71b67a0a68a1abd5331ac476)." [extensions/MobileFrontend] (REL1_36) - 10https://gerrit.wikimedia.org/r/690782 (owner: 10Jdlrobson) [00:17:19] (03Abandoned) 10Jdlrobson: Update nvm version for release branch [extensions/MobileFrontend] (REL1_36) - 10https://gerrit.wikimedia.org/r/690782 (owner: 10Jdlrobson) [00:19:20] (03PS2) 10Ppchelko: Remove Title param typehints from jobs [core] - 10https://gerrit.wikimedia.org/r/690781 [00:19:37] (03PS3) 10Jdlrobson: Use localStorage for expandSections boolean [extensions/MobileFrontend] (REL1_36) - 10https://gerrit.wikimedia.org/r/690720 (https://phabricator.wikimedia.org/T281296) (owner: 10Martineznovo) [00:19:57] (03CR) 10Jdlrobson: [C: 03+2] "Rebuilt locally - assets in PS1 look like the right ones. It was just the version that was a problem." [extensions/MobileFrontend] (REL1_36) - 10https://gerrit.wikimedia.org/r/690720 (https://phabricator.wikimedia.org/T281296) (owner: 10Martineznovo) [00:20:37] 10Abstract Wikipedia team, 10function-evaluator, 10function-orchestrator: Hook up orchestrator to the evaluator and pass through appropriately-dereferenced Z7 calls - https://phabricator.wikimedia.org/T282843 (10Jdforrester-WMF) [00:21:37] 10MediaWiki-extensions-OAuth, 10Wikidata, 10Wikimedia-Hackathon-2021: Wikidata tool request: Users can enter an ISBN to see if a Wikidata item exists, if not it makes a new one based on the data available (works like 'Cite' tool on Wikipedia) - https://phabricator.wikimedia.org/T282719 (10John_Cummings) [00:23:11] (03PS4) 10Jforrester: Use localStorage for expandSections boolean [extensions/MobileFrontend] (REL1_36) - 10https://gerrit.wikimedia.org/r/690720 (https://phabricator.wikimedia.org/T281296) (owner: 10Martineznovo) [00:23:56] (03CR) 10jerkins-bot: [V: 04-1] Remove mw-body-content from HTML that is not the article body [skins/Vector] - 10https://gerrit.wikimedia.org/r/682774 (https://phabricator.wikimedia.org/T279388) (owner: 10Jdlrobson) [00:25:08] (03CR) 10Jforrester: "> Patch Set 3: Code-Review+2" [extensions/MobileFrontend] (REL1_36) - 10https://gerrit.wikimedia.org/r/690720 (https://phabricator.wikimedia.org/T281296) (owner: 10Martineznovo) [00:27:42] (03Merged) 10jenkins-bot: purgeParserCache.php: Remove carriage return printer, minor cleanup [core] - 10https://gerrit.wikimedia.org/r/685878 (https://phabricator.wikimedia.org/T280605) (owner: 10Krinkle) [00:27:46] (03Merged) 10jenkins-bot: Drop mw-body-content class from Monobook in preparation for glorious future [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/684512 (https://phabricator.wikimedia.org/T279388) (owner: 10Jdlrobson) [00:27:49] (03CR) 10jerkins-bot: [V: 04-1] Article: Use correct timestamp for OutputPage::setRevisionTimestamp [core] - 10https://gerrit.wikimedia.org/r/689852 (https://phabricator.wikimedia.org/T282648) (owner: 10Hoo man) [00:27:52] (03CR) 10jerkins-bot: [V: 04-1] ArticleViewTest: Make timestamp tests deterministic [core] - 10https://gerrit.wikimedia.org/r/689855 (https://phabricator.wikimedia.org/T282648) (owner: 10Hoo man) [00:29:14] 10DiscussionTools, 10Product-Analytics, 10Editing-team (FY2020-21 Kanban Board): [SPIKE] Determine what – if any – new instrumentation is needed for notifications - https://phabricator.wikimedia.org/T277349 (10ppelberg) A provisional answer to question `1.` from T277349#7064137, below. **Next step** - [ ]... [00:30:37] (03Merged) 10jenkins-bot: Remove mw-body-content from indicators [skins/Modern] - 10https://gerrit.wikimedia.org/r/684509 (https://phabricator.wikimedia.org/T279388) (owner: 10Jdlrobson) [00:35:20] 10MediaWiki-Docker, 10mwcli, 10Patch-For-Review: Set up CI for mwcli - https://phabricator.wikimedia.org/T248779 (10Krinkle) I shaved off about 10 minutes by adding the relevant Debian packages to the preset and preloading the used docker image layers. ([docs](https://www.mediawiki.org/wiki/Continuous_integr... [00:36:21] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/MobileFrontend] (REL1_36) - 10https://gerrit.wikimedia.org/r/690720 (https://phabricator.wikimedia.org/T281296) (owner: 10Martineznovo) [00:37:01] (03CR) 10jerkins-bot: [V: 04-1] Merge content-media and content-thumbnails [core] - 10https://gerrit.wikimedia.org/r/690769 (https://phabricator.wikimedia.org/T278560) (owner: 10Jdlrobson) [00:39:18] (03CR) 10Jdlrobson: [C: 03+2] "Unrelated Wikibase test failure. Trying again." [skins/Vector] - 10https://gerrit.wikimedia.org/r/682774 (https://phabricator.wikimedia.org/T279388) (owner: 10Jdlrobson) [00:39:35] 10Discovery-Search (Current work), 10Patch-For-Review: WDQS hosts low on /srv disk space - https://phabricator.wikimedia.org/T280382 (10ops-monitoring-bot) Script wmf-auto-reimage was launched by ryankemper on cumin2001.codfw.wmnet for hosts: ` wdqs2003.codfw.wmnet ` The log can be found in `/var/log/wmf-auto-... [00:40:02] (03CR) 10BryanDavis: UI for audit logs filtering (035 comments) [wikimedia/toolhub] - 10https://gerrit.wikimedia.org/r/685635 (https://phabricator.wikimedia.org/T280854) (owner: 10Srishakatux) [00:46:45] (03Merged) 10jenkins-bot: Use localStorage for expandSections boolean [extensions/MobileFrontend] (REL1_36) - 10https://gerrit.wikimedia.org/r/690720 (https://phabricator.wikimedia.org/T281296) (owner: 10Martineznovo) [00:47:50] (03PS1) 10Jforrester: build: Switch node version to 10.24.0 now CI is on buster [extensions/MobileFrontend] (REL1_35) - 10https://gerrit.wikimedia.org/r/690083 [00:48:29] (03CR) 10Tim Starling: [C: 03+2] "Selenium... that ItemPage.editButton.isExisting() test fails about 20% of the time now. I was looking at the build history yesterday, it's" [core] - 10https://gerrit.wikimedia.org/r/689852 (https://phabricator.wikimedia.org/T282648) (owner: 10Hoo man) [00:50:08] (03PS8) 10Jeena Huneidi: WIP DNM test modifications debugging [tools/cli] - 10https://gerrit.wikimedia.org/r/690012 (owner: 10Addshore) [00:50:50] (03PS1) 10Jforrester: Using RevisionListBase::getPage instead of calling $title directly [core] (wmf/1.37.0-wmf.5) - 10https://gerrit.wikimedia.org/r/690084 (https://phabricator.wikimedia.org/T282825) [00:50:54] (03Merged) 10jenkins-bot: Remove the redundant clear:both on #footer for CologneBlue [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/682266 (https://phabricator.wikimedia.org/T278470) (owner: 10Anjali041) [00:52:17] 10Desktop Improvements, 10MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), 10Readers-Web-Backlog (Kanbanana-FY-2020-21): Add parameter that allows language button to be seen across all wikis - https://phabricator.wikimedia.org/T282543 (10nray) [00:53:02] (03PS1) 10Ppchelko: Convert MergeHistory to PageIdentity [core] - 10https://gerrit.wikimedia.org/r/690790 [00:53:16] (03CR) 10Jforrester: [C: 03+2] LogEventsList: always define $pageName [core] - 10https://gerrit.wikimedia.org/r/690784 (https://phabricator.wikimedia.org/T282834) (owner: 10Ppchelko) [00:55:10] (03CR) 10Jdlrobson: [C: 03+2] Make `mw-content-body` universal to all skins [core] - 10https://gerrit.wikimedia.org/r/682773 (https://phabricator.wikimedia.org/T279388) (owner: 10Jdlrobson) [00:55:29] (03CR) 10Jdlrobson: [C: 03+2] "Wikibase test is failing because https://gerrit.wikimedia.org/r/c/mediawiki/core/+/682773 hasn't merged yet..." [skins/Vector] - 10https://gerrit.wikimedia.org/r/682774 (https://phabricator.wikimedia.org/T279388) (owner: 10Jdlrobson) [00:55:46] 10MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), 10SDAW-MediaSearch (MediaSearch-Beta), 10Structured-Data-Backlog (Current Work): [Epic] Use the latest MediaWiki audio/video player tools for multimedia playback in MediaSearch QuickView - https://phabricator.wikimedia.org/T257637 (10Etonkovidova) [00:55:52] 10Browser-Support-Apple-Safari, 10MW-1.37-notes (1.37.0-wmf.5; 2021-05-11), 10SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), 10Structured-Data-Backlog (Current Work): Add ogv.js shim to enable Safari support for OGG and WEBP videos (in quickview) - https://phabricator.wikimedia.org/T266842 (10Etonkovidov... [00:55:54] (03PS6) 10Jdlrobson: Use content-body skin feature [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/682974 (https://phabricator.wikimedia.org/T281228) (owner: 10Mainframe98) [00:56:05] 10MediaWiki-Page-deletion, 10MediaWiki-Page-history, 10Regression: Special:DeletedContributions shows no or almost no edits. - https://phabricator.wikimedia.org/T282844 (10AntiCompositeNumber) [00:56:12] (03CR) 10Jdlrobson: [C: 03+2] Use content-body skin feature [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/682974 (https://phabricator.wikimedia.org/T281228) (owner: 10Mainframe98) [00:56:27] 10MediaWiki-Page-deletion, 10MediaWiki-Page-history, 10Regression: Special:DeletedContributions shows no or almost no edits. - https://phabricator.wikimedia.org/T282844 (10AntiCompositeNumber) [00:56:39] (03CR) 10Jdlrobson: [C: 03+2] Remove mw-body-content from indicators [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/684508 (https://phabricator.wikimedia.org/T279388) (owner: 10Jdlrobson) [00:56:52] 10MediaWiki-Page-deletion, 10MediaWiki-Page-history, 10Regression: Special:DeletedContributions shows no or almost no edits. - https://phabricator.wikimedia.org/T282844 (10AntiCompositeNumber) p:05Triage→03Unbreak! [01:00:20] 10Timeless, 10MW-1.36-release, 10Patch-For-Review: Timeless thumbnails do not appear as they used to - https://phabricator.wikimedia.org/T280292 (10Jdforrester-WMF) @Jdlrobson says this should block the 1.36 release. [01:01:57] 10MediaWiki-Page-deletion, 10MediaWiki-Page-history, 10Platform Engineering, 10Regression: Special:DeletedContributions shows no or almost no edits. - https://phabricator.wikimedia.org/T282844 (10Krinkle) This sounds very similar to {T282183} (ref T278917). If so, presumbly would have regressed in [chang... [01:02:36] 10CologneBlue, 10MonoBook, 10MW-1.37-notes (1.37.0-wmf.6; 2021-05-18), 10Patch-For-Review, 10patch-welcome: Skins no longer have to clear user generated content and have redundant styling rules. - https://phabricator.wikimedia.org/T278470 (10Jdlrobson) [01:04:48] 10Abstract Wikipedia team: Python execution engine should expect full `def`, not just statement setting return value - https://phabricator.wikimedia.org/T282821 (10Bugreporter) Should we also allow lambda? [01:05:37] 10MediaWiki-Core-Skin-Architecture, 10Modern, 10Timeless, 10Regression: Table of contents post-legacy styles split font size is smaller and in Timeless has centered heading - https://phabricator.wikimedia.org/T280285 (10Jdlrobson) [01:05:48] (03CR) 10Jforrester: [C: 03+2] Legacy feature should not load thumbnail style rules (only layout) [core] - 10https://gerrit.wikimedia.org/r/685614 (https://phabricator.wikimedia.org/T280292) (owner: 10Jdlrobson) [01:06:47] 10MediaWiki-extensions-MapSources, 10Wikimedia-production-error: MapSourcesPage.php: PHP Notice: Undefined offset: 13 - https://phabricator.wikimedia.org/T282833 (10Jdforrester-WMF) Also happening in wmf.4. Config issue? [01:08:18] (03PS1) 10Ppchelko: Drop RollbackPageFactoryTest [core] - 10https://gerrit.wikimedia.org/r/690791 [01:08:22] (03Merged) 10jenkins-bot: Make `mw-content-body` universal to all skins [core] - 10https://gerrit.wikimedia.org/r/682773 (https://phabricator.wikimedia.org/T279388) (owner: 10Jdlrobson) [01:08:25] (03Merged) 10jenkins-bot: Drop mw-body-content class from #bodyContent [skins/Timeless] - 10https://gerrit.wikimedia.org/r/684511 (https://phabricator.wikimedia.org/T279388) (owner: 10Jdlrobson) [01:08:27] (03CR) 10jerkins-bot: [V: 04-1] Use content-body skin feature [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/682974 (https://phabricator.wikimedia.org/T281228) (owner: 10Mainframe98) [01:08:58] (03PS2) 10Ppchelko: Convert MergeHistory to PageIdentity [core] - 10https://gerrit.wikimedia.org/r/690790 [01:09:39] (03CR) 10Ppchelko: "recheck" [core] - 10https://gerrit.wikimedia.org/r/690583 (https://phabricator.wikimedia.org/T275067) (owner: 10Ppchelko) [01:09:44] (03CR) 10Ppchelko: "recheck" [core] - 10https://gerrit.wikimedia.org/r/689393 (owner: 10Ppchelko) [01:09:54] (03CR) 10Ppchelko: "recheck" [core] - 10https://gerrit.wikimedia.org/r/690690 (owner: 10Ppchelko) [01:10:11] 10MediaWiki-Core-Skin-Architecture, 10Modern, 10Timeless, 10Regression: Table of contents post-legacy styles split font size is smaller and in Timeless has centered heading - https://phabricator.wikimedia.org/T280285 (10Jdlrobson) So the issue here was that in https://gerrit.wikimedia.org/r/c/mediawiki/cor... [01:11:13] (03PS9) 10Jeena Huneidi: WIP DNM test modifications debugging [tools/cli] - 10https://gerrit.wikimedia.org/r/690012 (owner: 10Addshore) [01:12:39] (03PS10) 10Jeena Huneidi: WIP DNM test modifications debugging [tools/cli] - 10https://gerrit.wikimedia.org/r/690012 (owner: 10Addshore) [01:12:42] (03CR) 10Jdlrobson: [C: 03+2] Remove mw-body-content from HTML that is not the article body [skins/Vector] - 10https://gerrit.wikimedia.org/r/682774 (https://phabricator.wikimedia.org/T279388) (owner: 10Jdlrobson) [01:13:04] (03CR) 10Krinkle: resourceloader: Simplify 'features' processing in SkinModule constructor (031 comment) [core] - 10https://gerrit.wikimedia.org/r/673309 (https://phabricator.wikimedia.org/T277728) (owner: 10Krinkle) [01:13:45] 10Abstract Wikipedia team: Python execution engine should expect full `def`, not just statement setting return value - https://phabricator.wikimedia.org/T282821 (10cmassaro) Yes, I think any of the below is fine: ` def Z1000(Z1000K1): return thing(Z1000K1) ` ` Z1000 = lambda Z1000K1: thing(Z1000K1) ` ` cl... [01:15:40] (03CR) 10Krinkle: resourceloader: Simplify 'features' processing in SkinModule constructor (031 comment) [core] - 10https://gerrit.wikimedia.org/r/673309 (https://phabricator.wikimedia.org/T277728) (owner: 10Krinkle) [01:16:13] (03CR) 10Jdlrobson: [C: 03+1] resourceloader: Simplify 'features' processing in SkinModule constructor (031 comment) [core] - 10https://gerrit.wikimedia.org/r/673309 (https://phabricator.wikimedia.org/T277728) (owner: 10Krinkle) [01:17:59] (03PS1) 10Ppchelko: Check array boundaries before accessing array [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/690792 [01:18:18] (03PS2) 10Ppchelko: Check array boundaries before accessing array [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/690792 (https://phabricator.wikimedia.org/T282833) [01:18:40] 10MediaWiki-Page-deletion, 10MediaWiki-Page-history, 10Platform Engineering, 10Regression: Special:DeletedContributions shows no or almost no edits. - https://phabricator.wikimedia.org/T282844 (10tstarling) It's hitting the "could not be formatted" case: `