[00:00:43] (03PS3) 10Reedy: Minor code cleanup [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/675321 [00:00:51] (03PS1) 10SLF bot: Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/675322 [00:02:09] (03CR) 10Reedy: [C: 03+2] Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/675322 (owner: 10SLF bot) [00:06:55] (03Merged) 10jenkins-bot: Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/675322 (owner: 10SLF bot) [00:09:21] (03PS4) 10Reedy: FirejailWrapper: Actually allow current dir [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/675320 (https://phabricator.wikimedia.org/T277981) [00:31:42] (03CR) 10DannyS712: [C: 03+1] Minor code cleanup [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/675321 (owner: 10Reedy) [00:33:37] (03CR) 10Nardog: "Ed g2s has recreated the demo on my behalf. You should be able to test it here now:" [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/674164 (https://phabricator.wikimedia.org/T102486) (owner: 10Gerrit Patch Uploader) [00:49:08] 10MediaWiki-extensions-UserMerge: Auto-remove never used dormant user accounts - https://phabricator.wikimedia.org/T278620 (10robkam) So far the wiki farm admin have been reluctant to delete these spurious users. It makes an unnecessary mess of the wiki stats. [00:54:46] (03CR) 10D3r1ck01: [V: 03+2 C: 03+2] "This change is ready for review." [gadgets/WADP] - 10https://gerrit.wikimedia.org/r/675317 (owner: 10D3r1ck01) [01:15:08] (03CR) 10Jforrester: [C: 03+2] Use foreach to loop a database result set [extensions/Flow] - 10https://gerrit.wikimedia.org/r/675262 (owner: 10Umherirrender) [01:16:20] (03CR) 10Jforrester: [C: 03+2] Remove deprecated SpoofUser::getError [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/666196 (owner: 10Umherirrender) [01:18:32] (03CR) 10Jforrester: [C: 03+2] Inject services into SpecialCiteThisPage [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/671250 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [01:20:49] (03CR) 10Jforrester: [C: 03+2] Inject services into SpecialTemplateSandbox [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/671281 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [01:24:21] (03CR) 10Jforrester: [C: 03+2] Avoid using User::getBoolOption() [core] - 10https://gerrit.wikimedia.org/r/672827 (https://phabricator.wikimedia.org/T277600) (owner: 10Zabe) [01:26:17] (03CR) 10Jforrester: [C: 03+2] Drop two unused Perl scripts [core] - 10https://gerrit.wikimedia.org/r/675282 (https://phabricator.wikimedia.org/T258876) (owner: 10Ammarpad) [01:30:10] (03CR) 10Jforrester: [C: 03+2] mediawiki.skinning: Change 'elements' file to LESS and remove obsolete property [core] - 10https://gerrit.wikimedia.org/r/675130 (https://phabricator.wikimedia.org/T277803) (owner: 10VolkerE) [01:31:02] 10MediaWiki-Page-editing, 10Patch-Needs-Improvement, 10good first task: Adjust order of Special characters useful for Korean in editor toolbar; add brackets - https://phabricator.wikimedia.org/T272573 (10ellif) So I think now is the time for trying to submit it to Gerrit directly. [01:32:05] (03CR) 10Jforrester: [C: 03+2] Fix annoying E_NOTICE about undefined 'alt' index in Skin#makeFooterIcon. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/637063 (owner: 10Jack Phoenix) [01:34:06] (03CR) 10Jforrester: [C: 03+2] Drop DatabaseUpdater::doActiveUsersInit [core] - 10https://gerrit.wikimedia.org/r/675280 (https://phabricator.wikimedia.org/T272199) (owner: 10Ladsgroup) [01:35:32] (03CR) 10Jforrester: [C: 03+2] resetUserEmail.php: Treat empty string as valid email [core] - 10https://gerrit.wikimedia.org/r/675227 (owner: 10Urbanecm) [01:44:32] (03Merged) 10jenkins-bot: Use foreach to loop a database result set [extensions/Flow] - 10https://gerrit.wikimedia.org/r/675262 (owner: 10Umherirrender) [01:44:37] (03Merged) 10jenkins-bot: Remove deprecated SpoofUser::getError [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/666196 (owner: 10Umherirrender) [01:44:39] (03Merged) 10jenkins-bot: Inject services into SpecialCiteThisPage [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/671250 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [01:44:41] (03Merged) 10jenkins-bot: Inject services into SpecialTemplateSandbox [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/671281 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [01:44:51] (03CR) 10Jforrester: [C: 03+1] Drop doWatchlistUpdate from MysqlUpdater [core] - 10https://gerrit.wikimedia.org/r/675279 (https://phabricator.wikimedia.org/T272199) (owner: 10Ladsgroup) [01:45:24] (03CR) 10Jforrester: [C: 03+1] "Will merge in a week if no-one objects." [core] - 10https://gerrit.wikimedia.org/r/675279 (https://phabricator.wikimedia.org/T272199) (owner: 10Ladsgroup) [01:46:18] (03CR) 10Jforrester: [C: 03+2] Add shorthands for inapplicable and unknown taintedness [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/674346 (owner: 10Daimona Eaytoy) [01:46:48] (03CR) 10jerkins-bot: [V: 04-1] Avoid using User::getBoolOption() [core] - 10https://gerrit.wikimedia.org/r/672827 (https://phabricator.wikimedia.org/T277600) (owner: 10Zabe) [01:51:10] (03CR) 10Jforrester: [C: 03+2] "…" [core] - 10https://gerrit.wikimedia.org/r/672827 (https://phabricator.wikimedia.org/T277600) (owner: 10Zabe) [01:51:27] (03Merged) 10jenkins-bot: Add shorthands for inapplicable and unknown taintedness [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/674346 (owner: 10Daimona Eaytoy) [01:52:40] (03CR) 10Jforrester: [C: 03+2] Performance improvements [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/675179 (https://phabricator.wikimedia.org/T203651) (owner: 10Daimona Eaytoy) [01:54:54] (03CR) 10Jforrester: [C: 03+2] Fix bug with PRESERVE_TAINT [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/674089 (owner: 10Daimona Eaytoy) [01:56:27] (03CR) 10Jforrester: [C: 03+2] Add tests for shaped dependencies [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/674401 (owner: 10Daimona Eaytoy) [01:59:11] (03PS2) 10Jforrester: Follow-up 335fabf5f: Don't misuse qc_value in DeadendPages [core] - 10https://gerrit.wikimedia.org/r/675120 (https://phabricator.wikimedia.org/T181658) (owner: 10TK-999) [02:00:43] (03CR) 10Jforrester: [C: 03+1] Follow-up 335fabf5f: Don't misuse qc_value in DeadendPages [core] - 10https://gerrit.wikimedia.org/r/675120 (https://phabricator.wikimedia.org/T181658) (owner: 10TK-999) [02:01:50] (03CR) 10Jforrester: [C: 03+1] "Reedy, would you like to do a final review?" [core] - 10https://gerrit.wikimedia.org/r/675120 (https://phabricator.wikimedia.org/T181658) (owner: 10TK-999) [02:02:16] (03Merged) 10jenkins-bot: Performance improvements [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/675179 (https://phabricator.wikimedia.org/T203651) (owner: 10Daimona Eaytoy) [02:02:42] (03Merged) 10jenkins-bot: Fix bug with PRESERVE_TAINT [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/674089 (owner: 10Daimona Eaytoy) [02:04:21] (03Merged) 10jenkins-bot: Add tests for shaped dependencies [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/674401 (owner: 10Daimona Eaytoy) [02:04:47] (03CR) 10Jforrester: [C: 03+1] "This'll make settings-related backports really unfun. Oh well." [core] - 10https://gerrit.wikimedia.org/r/674743 (owner: 10Tim Starling) [02:05:27] (03CR) 10Jforrester: [C: 03+2] "Two weeks is long enough." [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/671248 (owner: 10Umherirrender) [02:16:23] (03CR) 10Jforrester: [C: 03+2] Use HookHandlers for core hook (031 comment) [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/669352 (owner: 10Umherirrender) [02:17:37] (03Merged) 10jenkins-bot: Drop two unused Perl scripts [core] - 10https://gerrit.wikimedia.org/r/675282 (https://phabricator.wikimedia.org/T258876) (owner: 10Ammarpad) [02:17:46] (03Merged) 10jenkins-bot: mediawiki.skinning: Change 'elements' file to LESS and remove obsolete property [core] - 10https://gerrit.wikimedia.org/r/675130 (https://phabricator.wikimedia.org/T277803) (owner: 10VolkerE) [02:17:57] (03Merged) 10jenkins-bot: Fix annoying E_NOTICE about undefined 'alt' index in Skin#makeFooterIcon. [core] - 10https://gerrit.wikimedia.org/r/637063 (owner: 10Jack Phoenix) [02:18:07] (03Merged) 10jenkins-bot: Drop DatabaseUpdater::doActiveUsersInit [core] - 10https://gerrit.wikimedia.org/r/675280 (https://phabricator.wikimedia.org/T272199) (owner: 10Ladsgroup) [02:18:16] (03Merged) 10jenkins-bot: resetUserEmail.php: Treat empty string as valid email [core] - 10https://gerrit.wikimedia.org/r/675227 (owner: 10Urbanecm) [02:18:23] (03Merged) 10jenkins-bot: Avoid using User::getBoolOption() [core] - 10https://gerrit.wikimedia.org/r/672827 (https://phabricator.wikimedia.org/T277600) (owner: 10Zabe) [02:18:27] (03Merged) 10jenkins-bot: Remove RELEASE-NOTES file [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/671248 (owner: 10Umherirrender) [02:20:50] (03Merged) 10jenkins-bot: Use HookHandlers for core hook [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/669352 (owner: 10Umherirrender) [05:33:23] 04(no projects): Add extra fallbacks for Special:MyLanguage - https://phabricator.wikimedia.org/T278639 (10Func) [06:03:44] (03CR) 10Func: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/675291 (https://phabricator.wikimedia.org/T278639) (owner: 10Func) [06:51:30] 10I18n, 10Patch-For-Review: Add extra fallbacks for Special:MyLanguage - https://phabricator.wikimedia.org/T278639 (10Peachey88) [07:18:40] 10MediaWiki-extensions-Scribunto, 10Wiktionary, 10Performance Issue: "Lua error: not enough memory" on certain en.wiktionary pages - https://phabricator.wikimedia.org/T165935 (10Aklapper) We do not need more "happens also on page..." test cases. We welcome test cases though that illustrate that it's actually... [08:06:22] 10MediaWiki-extensions-WikimediaIncubator, 10Discovery, 10Wikimedia-Portals: Fix & restore the "Find a language" search box on www.wikipedia.org portal - API bug? - https://phabricator.wikimedia.org/T130077 (10Helix17) @Ebe123 I have created a [[ https://gerrit.wikimedia.org/r/c/wikimedia/portals/+/675200 |... [08:43:23] (03PS1) 10Brian Wolff: Add core functionality [extensions/Sofa] - 10https://gerrit.wikimedia.org/r/675323 [08:44:19] (03CR) 10Brian Wolff: [V: 03+2 C: 03+2] Add core functionality [extensions/Sofa] - 10https://gerrit.wikimedia.org/r/675323 (owner: 10Brian Wolff) [08:46:55] (03CR) 10jerkins-bot: [V: 04-1] Add core functionality [extensions/Sofa] - 10https://gerrit.wikimedia.org/r/675323 (owner: 10Brian Wolff) [08:51:21] (03PS2) 10Brian Wolff: Add core functionality [extensions/Sofa] - 10https://gerrit.wikimedia.org/r/675323 [08:54:59] (03CR) 10jerkins-bot: [V: 04-1] Add core functionality [extensions/Sofa] - 10https://gerrit.wikimedia.org/r/675323 (owner: 10Brian Wolff) [08:55:42] (03PS4) 10Ammarpad: Prepare for migrating `user` to abstract schema [core] - 10https://gerrit.wikimedia.org/r/675281 (https://phabricator.wikimedia.org/T230428) [09:08:11] (03PS3) 10Brian Wolff: Add core functionality [extensions/Sofa] - 10https://gerrit.wikimedia.org/r/675323 [09:08:31] 10MediaWiki-Parser, 10Performance Issue: Expensive functions ($wgExpensiveParserFunctionLimit, severe inconsistencies) - https://phabricator.wikimedia.org/T278629 (10Aklapper) [09:12:08] (03CR) 10jerkins-bot: [V: 04-1] Add core functionality [extensions/Sofa] - 10https://gerrit.wikimedia.org/r/675323 (owner: 10Brian Wolff) [09:15:12] (03PS4) 10Ammarpad: Document methods that may return StubUserLang instead of Language [core] - 10https://gerrit.wikimedia.org/r/674969 (https://phabricator.wikimedia.org/T278429) [09:18:46] 10MediaWiki-Internationalization, 10I18n, 10Patch-For-Review: Add extra fallbacks for Special:MyLanguage - https://phabricator.wikimedia.org/T278639 (10Aklapper) [09:19:50] 10MediaWiki-extensions-UserMerge: Auto-remove never used dormant user accounts - https://phabricator.wikimedia.org/T278620 (10Aklapper) Which specific wiki stats where are you looking at? [09:20:38] (03CR) 10Ammarpad: Prepare for migrating `user` to abstract schema (031 comment) [core] - 10https://gerrit.wikimedia.org/r/675281 (https://phabricator.wikimedia.org/T230428) (owner: 10Ammarpad) [09:24:38] (03PS4) 10Brian Wolff: Add core functionality [extensions/Sofa] - 10https://gerrit.wikimedia.org/r/675323 [09:30:09] (03CR) 10Brian Wolff: [C: 03+2] Add core functionality [extensions/Sofa] - 10https://gerrit.wikimedia.org/r/675323 (owner: 10Brian Wolff) [09:35:09] (03Merged) 10jenkins-bot: Add core functionality [extensions/Sofa] - 10https://gerrit.wikimedia.org/r/675323 (owner: 10Brian Wolff) [09:38:00] (03CR) 10Ammarpad: "check postgres" [core] - 10https://gerrit.wikimedia.org/r/675281 (https://phabricator.wikimedia.org/T230428) (owner: 10Ammarpad) [09:44:51] (03CR) 10Ammarpad: "The immediate cause of T278429 has been reverted and so is no longer an issue of priority. I updated this patch to document the status quo" [core] - 10https://gerrit.wikimedia.org/r/674969 (https://phabricator.wikimedia.org/T278429) (owner: 10Ammarpad) [09:46:21] 10MediaWiki-General, 10Platform Team Initiatives (Decoupling (CDP2)), 10Technical-Debt: Replace StubUserLang with a better lazy loading mechanism - https://phabricator.wikimedia.org/T244383 (10Ammarpad) [10:04:10] (03CR) 10Ladsgroup: [C: 03+2] Prepare for migrating `user` to abstract schema [core] - 10https://gerrit.wikimedia.org/r/675281 (https://phabricator.wikimedia.org/T230428) (owner: 10Ammarpad) [10:06:01] 10MediaWiki-extensions-UserMerge: Auto-remove never used dormant user accounts - https://phabricator.wikimedia.org/T278620 (10robkam) Special:Statistics and Special:ListUsers [10:06:11] 10MediaWiki-General, 10MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), 10PostgreSQL: Future of mediawiki_mysql2postgres.pl and compare_schemas.pl - https://phabricator.wikimedia.org/T258876 (10Ladsgroup) 05Open→03Resolved a:03Ammarpad This is deleted. Someone should update https://www.mediawiki.org/wiki/Man... [10:06:51] 10MediaWiki-extensions-MsUpload: Several errors when using multiple file upload - https://phabricator.wikimedia.org/T276199 (10HarroKremer) Today the problem reappeared after trying to upload 7 files at once using drag and drop. Restarting the website fails with the following info (for 2 processes) Mar 28 09:58:... [10:08:09] 10MediaWiki-Installer, 10Wikimedia-Rdbms, 10MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), 10Patch-For-Review: Drop unsupported upgrade patch files and logic - https://phabricator.wikimedia.org/T272199 (10Ladsgroup) [10:15:10] (03PS1) 10Yash9265: Preview pagelist button on non-dialogue portion should not be active when closing the dialogue [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/675324 (https://phabricator.wikimedia.org/T278607) [10:19:54] 10MediaWiki-extensions-UserMerge: Auto-remove never used dormant user accounts - https://phabricator.wikimedia.org/T278620 (10Ammarpad) There's a script that does something like that https://www.mediawiki.org/wiki/Manual:RemoveUnusedAccounts.php. You need to check the limitations and what it considers 'unused' [10:31:05] (03Merged) 10jenkins-bot: Prepare for migrating `user` to abstract schema [core] - 10https://gerrit.wikimedia.org/r/675281 (https://phabricator.wikimedia.org/T230428) (owner: 10Ammarpad) [10:38:11] 10MediaWiki-User-management, 10MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), 10Patch-For-Review, 10Technical-Debt (Deprecation process), 10User-Zabe: Prepare User option methods for hard deprecation - https://phabricator.wikimedia.org/T277600 (10Zabe) [10:38:29] 10MediaWiki-User-management, 10MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), 10Patch-For-Review, 10Technical-Debt (Deprecation process), 10User-Zabe: Prepare User option methods for hard deprecation - https://phabricator.wikimedia.org/T277600 (10Zabe) [10:53:34] 10MediaWiki-Parser, 10Performance Issue: Expensive functions ($wgExpensiveParserFunctionLimit, severe inconsistencies) - https://phabricator.wikimedia.org/T278629 (10Taylor) [10:57:02] 10MobileFrontend, 10SectionTranslation: Section translate is making mobile view really bad - https://phabricator.wikimedia.org/T278643 (10Ladsgroup) [10:57:13] 10MobileFrontend, 10SectionTranslation: Section translate is making mobile view really bad - https://phabricator.wikimedia.org/T278643 (10Ladsgroup) p:05Triage→03Unbreak! [11:00:13] 10MobileFrontend, 10SectionTranslation: Section translate is making mobile view really bad - https://phabricator.wikimedia.org/T278643 (10Amire80) Hmm, I don't see it, but I'll pass it on. [11:01:49] 10MobileFrontend, 10SectionTranslation: Section translate is making mobile view really bad - https://phabricator.wikimedia.org/T278643 (10Ladsgroup) It was reported to me. You need to enable CX in enwiki. [11:21:52] 10MobileFrontend, 10SectionTranslation: Section translate is making mobile view really bad - https://phabricator.wikimedia.org/T278643 (10KartikMistry) p:05Unbreak!→03Triage I can't reproduce this either on Desktop (Mobile view) or Mobile device. Screenshots attached. We need more details here before it is... [11:35:55] 10MobileFrontend, 10SectionTranslation, 10User-Ladsgroup: Section translate is making mobile view really bad - https://phabricator.wikimedia.org/T278643 (10Ladsgroup) 05Open→03Resolved a:03Ladsgroup Found the problem, it's something mimicking section translation. Sorry for false alarm, because I could... [11:40:09] 10MobileFrontend, 10SectionTranslation, 10User-Ladsgroup: Section translate is making mobile view really bad - https://phabricator.wikimedia.org/T278643 (10Amire80) >>! In T278643#6951800, @Ladsgroup wrote: > Found the problem, it's something mimicking section translation. Sorry for false alarm, because I co... [11:41:57] 10MobileFrontend, 10SectionTranslation, 10User-Ladsgroup: Section translate is making mobile view really bad - https://phabricator.wikimedia.org/T278643 (10Ladsgroup) Here you are: https://fa.wikipedia.org/w/index.php?title=%D9%85%D8%AF%DB%8C%D8%A7%D9%88%DB%8C%DA%A9%DB%8C:Tofawiki.js&diff=31601150&oldid=3159... [11:42:22] (03PS1) 10Zabe: Avoid using User::getBoolOption() (part 2) [core] - 10https://gerrit.wikimedia.org/r/675326 (https://phabricator.wikimedia.org/T277600) [11:54:38] 10MediaWiki-Core-Skin-Architecture: Consider `background-repeat: no-repeat` as star selector rule for MediaWiki core - https://phabricator.wikimedia.org/T278624 (10Esanders) I think we should avoid unscoped `*` selectors whenever possible. Introducing one is a breaking change, and they can cause problems with th... [12:12:34] (03PS1) 10Zabe: Avoid using User::getOptionKinds() [core] - 10https://gerrit.wikimedia.org/r/675327 (https://phabricator.wikimedia.org/T277600) [12:13:56] 10DiscussionTools, 10Editing QA, 10Editing-team (FY2020-21 Kanban Board): Reply links appear for users who can't edit the page - https://phabricator.wikimedia.org/T276393 (10Tacsipacsi) I logged in as Mallory, and https://patchdemo.wmflabs.org/wikis/a8da9c890a/w/index.php?title=Talk:Normal_board&action=edit... [12:33:42] (03PS1) 10Zabe: Avoid using User::getOptionKinds() [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/675328 (https://phabricator.wikimedia.org/T277600) [12:40:13] (03Abandoned) 10Zabe: Avoid using User::getOptionKinds() [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/675328 (https://phabricator.wikimedia.org/T277600) (owner: 10Zabe) [12:44:36] 10MinervaNeue, 10Readers-Web-Backlog (Design): Indicators (protected icon, featured icon) are not shown in Minerva - https://phabricator.wikimedia.org/T75299 (10Tacsipacsi) I don’t think relying on Wikidata is a great idea. The local templates and the Wikidata information should say the same, but nothing enfor... [13:07:55] (03PS4) 10Mainframe98: Move legacy link styles to other skin features [core] - 10https://gerrit.wikimedia.org/r/675210 (https://phabricator.wikimedia.org/T278575) [13:26:05] 10MediaWiki-extensions-Translate: “Preview page with this template” broken with translatable templates - https://phabricator.wikimedia.org/T278644 (10Pols12) [13:42:57] 10MediaWiki-ResourceLoader, 10Performance-Team, 10affects-Kiwix-and-openZIM: API does not list ResourceLoader Mathjax module when needed - https://phabricator.wikimedia.org/T278061 (10Kelson) @Krinkle I have mailed someone at Proofwiki and it was given to me the following link (seems to be and older Version... [13:50:23] 10Reading-Web-Local-Wiki-Issues, 10Mobile, 10MobileFrontend (Tracking), 10Readers-Web-Backlog (Tracking): Show Navbox templates in mobile skins - https://phabricator.wikimedia.org/T124168 (10Tacsipacsi) Because it builds on the same basic visual styles (colors, spacing etc., even the rule that collapses ho... [13:56:14] (03PS1) 10Ostrzyciel: Introduce UserIdentity where possible [extensions/MediaUploader] - 10https://gerrit.wikimedia.org/r/675329 [14:01:41] (03CR) 10jerkins-bot: [V: 04-1] Introduce UserIdentity where possible [extensions/MediaUploader] - 10https://gerrit.wikimedia.org/r/675329 (owner: 10Ostrzyciel) [14:02:06] 10Reading-Web-Local-Wiki-Issues, 10Mobile, 10MobileFrontend (Tracking), 10Readers-Web-Backlog (Tracking): Show Navbox templates in mobile skins - https://phabricator.wikimedia.org/T124168 (10XanonymusX) Lovely. That’s the issue with mixing structural global semantics and local decoration (as already critic... [14:12:02] 10MinervaNeue, 10Readers-Web-Backlog (Design): Indicators (protected icon, featured icon) are not shown in Minerva - https://phabricator.wikimedia.org/T75299 (10XanonymusX) If there was a workable proposal for generally showing indicators in Minerva, sure; but since 2014 there hasn’t been any, as far as I can... [14:13:58] (03PS2) 10Ostrzyciel: Introduce UserIdentity where possible [extensions/MediaUploader] - 10https://gerrit.wikimedia.org/r/675329 [14:23:44] 10MobileFrontend, 10SectionTranslation, 10User-Ladsgroup: Section translate is making mobile view really bad - https://phabricator.wikimedia.org/T278643 (10Majavah) 05Resolved→03Invalid a:05Ladsgroup→03None [14:24:59] 10MediaUploader: Introduce YAML to campaign configs - https://phabricator.wikimedia.org/T278647 (10Ostrzyciel) [14:25:37] 10MediaUploader: Introduce YAML to campaign configs - https://phabricator.wikimedia.org/T278647 (10Ostrzyciel) [14:25:39] 10MediaUploader: Make an abstract JSON validation interface and service - https://phabricator.wikimedia.org/T277535 (10Ostrzyciel) [14:25:57] 10MediaUploader: Introduce YAML to campaign configs - https://phabricator.wikimedia.org/T278647 (10Ostrzyciel) p:05Triage→03Medium [14:32:24] 10MediaUploader: Rewrite campaign JSON Schema validation - https://phabricator.wikimedia.org/T277535 (10Ostrzyciel) [14:32:52] 10MediaUploader: Remove dependency on EventLogging - https://phabricator.wikimedia.org/T275157 (10Ostrzyciel) [14:32:58] 10MediaWiki-extensions-CollaborationKit, 10Analytics-EventLogging, 10Analytics-Radar: Decide on JSON validation library - https://phabricator.wikimedia.org/T147137 (10Ostrzyciel) [14:34:25] (03CR) 10Ostrzyciel: [C: 03+2] Introduce UserIdentity where possible [extensions/MediaUploader] - 10https://gerrit.wikimedia.org/r/675329 (owner: 10Ostrzyciel) [14:39:59] (03Merged) 10jenkins-bot: Introduce UserIdentity where possible [extensions/MediaUploader] - 10https://gerrit.wikimedia.org/r/675329 (owner: 10Ostrzyciel) [14:47:03] 10MediaWiki-extensions-WikimediaIncubator, 10Discovery, 10Wikimedia-Portals: Fix & restore the "Find a language" search box on www.wikipedia.org portal - API bug? - https://phabricator.wikimedia.org/T130077 (10Aklapper) @Helix17: Thanks a lot! Please see and follow https://www.mediawiki.org/wiki/Gerrit/Commi... [15:01:31] 10Wikimedia-Site-requests, 10Patch-For-Review: Add deleterevision right to botadmin group on fawiki - https://phabricator.wikimedia.org/T277358 (10Urbanecm) >>! In T277358#6938310, @Huji wrote: >[...] > On the web interface, the same user has access to the filearchive information. Is that true? Here is a scre... [15:04:30] (03PS1) 10VolkerE: mediawiki.skinning: Combine color rules of all code elements [core] - 10https://gerrit.wikimedia.org/r/675331 [15:17:20] (03CR) 10DannyS712: [C: 04-1] Add extra fallbacks for Special:MyLanguage (031 comment) [core] - 10https://gerrit.wikimedia.org/r/675291 (https://phabricator.wikimedia.org/T278639) (owner: 10Func) [15:20:39] 10Humaniki: Shut down whgi - https://phabricator.wikimedia.org/T278649 (10notconfusing) [15:22:55] (03PS4) 10DannyS712: Api: inject AbuseFilterPermissionManager where needed [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/674679 (https://phabricator.wikimedia.org/T259960) [15:22:59] (03PS5) 10DannyS712: Api: inject AbuseFilterPermissionManager where needed [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/674679 (https://phabricator.wikimedia.org/T259960) [15:25:18] (03PS1) 10Ammarpad: PostgresUpdater: Correct wrong table name [core] - 10https://gerrit.wikimedia.org/r/675332 [15:26:17] (03CR) 10Ammarpad: Prepare for migrating `user` to abstract schema (031 comment) [core] - 10https://gerrit.wikimedia.org/r/675281 (https://phabricator.wikimedia.org/T230428) (owner: 10Ammarpad) [15:31:25] (03CR) 10Ladsgroup: Prepare for migrating `user` to abstract schema (031 comment) [core] - 10https://gerrit.wikimedia.org/r/675281 (https://phabricator.wikimedia.org/T230428) (owner: 10Ammarpad) [15:37:48] (03PS3) 10Func: Add extra fallbacks for Special:MyLanguage [core] - 10https://gerrit.wikimedia.org/r/675291 (https://phabricator.wikimedia.org/T278639) [15:38:14] (03CR) 10Func: Add extra fallbacks for Special:MyLanguage (031 comment) [core] - 10https://gerrit.wikimedia.org/r/675291 (https://phabricator.wikimedia.org/T278639) (owner: 10Func) [15:38:41] (03CR) 10Ammarpad: "I was wondering why the CI job didn't catch this. It's probably because the function queries PG's internal system table and only uses this" [core] - 10https://gerrit.wikimedia.org/r/675281 (https://phabricator.wikimedia.org/T230428) (owner: 10Ammarpad) [15:40:59] 10MediaWiki-User-preferences, 10Performance Issue: Saving options is taking too long on Commons - https://phabricator.wikimedia.org/T278650 (10Jack_who_built_the_house) [15:41:23] (03CR) 10Ammarpad: Prepare for migrating `user` to abstract schema (031 comment) [core] - 10https://gerrit.wikimedia.org/r/675281 (https://phabricator.wikimedia.org/T230428) (owner: 10Ammarpad) [15:41:55] 10MediaWiki-User-preferences, 10Performance Issue: Saving options is taking too long on Commons - https://phabricator.wikimedia.org/T278650 (10Jack_who_built_the_house) [15:42:31] (03CR) 10DannyS712: [C: 03+1] PostgresUpdater: Correct wrong table name [core] - 10https://gerrit.wikimedia.org/r/675332 (owner: 10Ammarpad) [15:42:37] 10MediaWiki-User-preferences, 10Performance Issue: Saving options using API is taking too long on Commons - https://phabricator.wikimedia.org/T278650 (10Jack_who_built_the_house) [15:44:26] 10MediaWiki-User-preferences, 10Performance Issue: Saving options using API is taking too long on Commons - https://phabricator.wikimedia.org/T278650 (10Jack_who_built_the_house) Hm, I think the same issue appears when I try to save user preferences using the standard interface at https://commons.wikimedia.org... [15:45:03] 10MediaWiki-User-preferences, 10Performance Issue: Saving options is taking too long on Commons - https://phabricator.wikimedia.org/T278650 (10Jack_who_built_the_house) [15:45:48] (03CR) 10DannyS712: QueryPage: Don't try to swallow DBErrors (031 comment) [core] - 10https://gerrit.wikimedia.org/r/675122 (https://phabricator.wikimedia.org/T278543) (owner: 10TK-999) [15:49:30] 10DiscussionTools: Let me switch to my normal wikitext editor when I start a new section - https://phabricator.wikimedia.org/T278466 (10Tacsipacsi) [15:54:02] 10MediaWiki-User-preferences, 10Commons, 10Performance Issue: Saving options is taking too long on Commons - https://phabricator.wikimedia.org/T278650 (10Jack_who_built_the_house) [15:57:14] (03CR) 10Ammarpad: "I'd suggest `mediawiki.actionS.styles` for all 'actions' that don't have their own dedicated modules" [core] - 10https://gerrit.wikimedia.org/r/675145 (https://phabricator.wikimedia.org/T278504) (owner: 10Mainframe98) [16:00:20] (03CR) 10VolkerE: [C: 04-1] Create mediawiki.action.other.styles module for misc action styles (031 comment) [core] - 10https://gerrit.wikimedia.org/r/675145 (https://phabricator.wikimedia.org/T278504) (owner: 10Mainframe98) [16:02:55] (03CR) 10DannyS712: [C: 04-1] "-1 for the missing dependency, plus a suggestion" (032 comments) [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/675082 (https://phabricator.wikimedia.org/T274485) (owner: 10Sebastian Berlin (WMSE)) [16:03:47] (03CR) 10DannyS712: [C: 03+1] FirejailWrapper: Actually allow current dir [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/675320 (https://phabricator.wikimedia.org/T277981) (owner: 10Reedy) [16:08:51] (03CR) 10Ladsgroup: "I think update.php just ignores schema changes on non-existent tables and this is just not working, nothing crazy. I can try it locally. I" [core] - 10https://gerrit.wikimedia.org/r/675281 (https://phabricator.wikimedia.org/T230428) (owner: 10Ammarpad) [16:13:01] 10MediaWiki-extensions-TemplateSandbox, 10MediaWiki-extensions-Translate: “Preview page with this template” broken with translatable templates - https://phabricator.wikimedia.org/T278644 (10Pppery) [16:16:34] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Use tabs instead of spaces for indentation in the sql files [extensions/WSOAuth] - 10https://gerrit.wikimedia.org/r/675263 (owner: 10Zoranzoki21) [16:17:40] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Fix MediaWiki.Files.ClassMatchesFilename.NotMatch [extensions/BaseHooks] - 10https://gerrit.wikimedia.org/r/671247 (owner: 10Zoranzoki21) [16:21:11] (03Merged) 10jenkins-bot: Use tabs instead of spaces for indentation in the sql files [extensions/WSOAuth] - 10https://gerrit.wikimedia.org/r/675263 (owner: 10Zoranzoki21) [16:23:02] (03Merged) 10jenkins-bot: Fix MediaWiki.Files.ClassMatchesFilename.NotMatch [extensions/BaseHooks] - 10https://gerrit.wikimedia.org/r/671247 (owner: 10Zoranzoki21) [16:26:17] 10WikiLambda, 10Abstract Wikipedia team (Phase δ): Prohibit certain kinds of ZTypes from being instantiated as top-level wiki pages (Z2s) - https://phabricator.wikimedia.org/T278175 (10Bugreporter) A Z16/Code may define more than one functions so it may be useful to create isolated code object. Moreover some c... [16:28:15] (03CR) 10DannyS712: "recheck" [core] - 10https://gerrit.wikimedia.org/r/675291 (https://phabricator.wikimedia.org/T278639) (owner: 10Func) [16:29:01] 10MediaWiki-extensions-CodeMirror, 10Community-Tech: Syntax highlighting clashes with certain Mac keyboard layouts in Firefox - https://phabricator.wikimedia.org/T260992 (10Srdjan) [16:29:30] 10Abstract Wikipedia team: Add rate limit for evaluating functions - https://phabricator.wikimedia.org/T278651 (10Bugreporter) [16:30:57] (03CR) 10DannyS712: "This change is ready for review." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/675294 (owner: 10DannyS712) [16:36:37] (03CR) 10jerkins-bot: [V: 04-1] FlaggedRevsApiHooks should not extend ApiQueryBase [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/675294 (owner: 10DannyS712) [16:36:53] (03PS1) 10Zoranzoki21: Fix all PHPCS excludes [extensions/Sofa] - 10https://gerrit.wikimedia.org/r/675333 [16:40:59] (03CR) 10jerkins-bot: [V: 04-1] Fix all PHPCS excludes [extensions/Sofa] - 10https://gerrit.wikimedia.org/r/675333 (owner: 10Zoranzoki21) [16:43:04] 10Library-Card-Platform: Wikipedia Library Server Error - https://phabricator.wikimedia.org/T278652 (10Pcoombe) [16:44:21] 10MediaWiki-Codesniffer, 10Release, 10User-DannyS712: Release mediawiki-codesniffer v36.0.0 - https://phabricator.wikimedia.org/T278653 (10DannyS712) [16:50:11] (03CR) 10DannyS712: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/675293 (owner: 10DannyS712) [16:55:25] (03CR) 10jerkins-bot: [V: 04-1] Add extra fallbacks for Special:MyLanguage [core] - 10https://gerrit.wikimedia.org/r/675291 (https://phabricator.wikimedia.org/T278639) (owner: 10Func) [17:01:37] (03PS15) 10DannyS712: Factor out a backend from EditPage [core] - 10https://gerrit.wikimedia.org/r/649916 (https://phabricator.wikimedia.org/T157658) [17:03:12] (03PS16) 10DannyS712: Factor out a backend from EditPage [core] - 10https://gerrit.wikimedia.org/r/649916 (https://phabricator.wikimedia.org/T157658) [17:07:00] 10Platform Team Workboards: Test ticket - https://phabricator.wikimedia.org/T278173 (10Aklapper) 05Open→03Invalid [17:27:11] (03CR) 10DannyS712: "This change is ready for review." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/675295 (https://phabricator.wikimedia.org/T269952) (owner: 10DannyS712) [17:43:59] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2021-January-March), 10Patch-For-Review, 10User-Urbanecm, and 2 others: Argument 1 passed to MediaWiki\Extension\Translate\PageTranslation\ParserOutput::sourcePageTextForRendering() must be an instance of ... - https://phabricator.wikimedia.org/T278429 [17:45:04] 10Image-Recommendations, 10MW-1.36-notes (1.36.0-wmf.36; 2021-03-23), 10Patch-For-Review, 10Structured-Data-Backlog (Current Work): [L] Create edit tags to measure multimedia edits to Wikipedia articles - https://phabricator.wikimedia.org/T266067 (10Urbanecm) Note that the core patch was reverted, as it ca... [17:46:16] 10MediaViewer: Double HTML escaping in MultimediaViewer - https://phabricator.wikimedia.org/T278256 (10Aklapper) Hi @Roland_Illig, thanks for taking the time to report this and welcome to Wikimedia Phabricator! I can confirm this. [17:46:51] 10MediaViewer: Double HTML escaping of attribution HTML code to copy (mw-widget-copyTextLayout field value of multimediaviewer-attr-html) - https://phabricator.wikimedia.org/T278256 (10Aklapper) [17:48:44] (03CR) 10DannyS712: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/675296 (owner: 10DannyS712) [17:52:36] (03PS3) 10DannyS712: Convert DiffHistoryBlobTest to pure unit test [core] - 10https://gerrit.wikimedia.org/r/675296 [18:03:53] (03PS4) 10DannyS712: Delete ObjectFactoryMakeContentHandlerWithSpecsToTest [core] - 10https://gerrit.wikimedia.org/r/672112 [18:04:06] (03CR) 10DannyS712: "PS4 is a manual rebase" [core] - 10https://gerrit.wikimedia.org/r/672112 (owner: 10DannyS712) [18:07:46] 10Inuka-Team, 10KaiOS-Wikipedia-app, 10Wikimedia-General-or-Unknown, 10I18n: [[Wikimedia:Wikipedia-kaios-tip-search-header/nb]] translation issue - https://phabricator.wikimedia.org/T278654 (10jhsoby) [18:08:33] 10MinervaNeue, 10Readers-Web-Backlog (Design): Indicators (protected icon, featured icon) are not shown in Minerva - https://phabricator.wikimedia.org/T75299 (10Tacsipacsi) As far as I see, the main issue causing this not to be fixed for more than six years now is UI design, not the underlying technology. UI d... [18:12:37] (03CR) 10DannyS712: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/675297 (owner: 10DannyS712) [18:22:15] 10MediaWiki-extensions-TemplateSandbox, 10MediaWiki-extensions-Translate: “Preview page with this template” broken with translatable templates - https://phabricator.wikimedia.org/T278644 (10Tacsipacsi) As far as I know, this preview has never worked with translatable pages, neither with the legacy `{{#switch:<... [18:29:31] (03PS7) 10DannyS712: Tests: use an empty hook container where possible [core] - 10https://gerrit.wikimedia.org/r/671245 [18:30:00] (03CR) 10DannyS712: "Rebased to fix merge conflict in MergeHistoryTest. @Daimona would you be willing to take another look?" [core] - 10https://gerrit.wikimedia.org/r/671245 (owner: 10DannyS712) [18:34:40] (03PS1) 10Ostrzyciel: WIP: Switch campaign configs to YAML [extensions/MediaUploader] - 10https://gerrit.wikimedia.org/r/675334 (https://phabricator.wikimedia.org/T278647) [18:43:01] (03CR) 10jerkins-bot: [V: 04-1] WIP: Switch campaign configs to YAML [extensions/MediaUploader] - 10https://gerrit.wikimedia.org/r/675334 (https://phabricator.wikimedia.org/T278647) (owner: 10Ostrzyciel) [18:45:03] 10MinervaNeue, 10Readers-Web-Backlog (Design): Indicators (protected icon, featured icon) are not shown in Minerva - https://phabricator.wikimedia.org/T75299 (10XanonymusX) Well, high time to track these discrepancies then! ;) Yes, I would like to hear from the Design department (is there such a thing? I’m c... [18:52:40] (03CR) 10DannyS712: [C: 04-1] Avoid using User::getOptionKinds() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/675327 (https://phabricator.wikimedia.org/T277600) (owner: 10Zabe) [18:55:35] (03PS3) 10Umherirrender: Use WebRequestUpload in UploadHandler [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/654341 [18:56:00] (03CR) 10Umherirrender: "Rebased" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/654341 (owner: 10Umherirrender) [19:04:34] (03CR) 10DannyS712: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/675298 (owner: 10DannyS712) [19:06:50] 10MediaWiki-Uploading: This SVG file contains an illegal namespace "http://www.w3.org/2000/02/svg/testsuite/description/". - https://phabricator.wikimedia.org/T278044 (10JoKalliauer) Generally I would just remove the description, however it is a testsuite and should be kept unmodified, for more infos check: http... [19:17:31] 10Developer-Advocacy (Apr-Jun 2021): Post-TechCom Gerrit privilege handout workflow - https://phabricator.wikimedia.org/T273164 (10Aklapper) [19:17:51] 10Developer-Advocacy (Apr-Jun 2021), 10PM: Attend WMF's "EMs: Community of Practice" meeting in April 2021 to discuss Phab PM topics - https://phabricator.wikimedia.org/T271911 (10Aklapper) [19:18:22] 10Phabricator, 10Developer-Advocacy, 10Epic: (Semi)automatically close Phabricator tickets with status "stalled" after a while - https://phabricator.wikimedia.org/T252522 (10Aklapper) [19:18:28] 10Phabricator, 10Developer-Advocacy (Apr-Jun 2021): Review the default options in Phab's Favorites menu; offer dedicated forms for bug reports vs feature requests? - https://phabricator.wikimedia.org/T253744 (10Aklapper) [19:19:09] 10Indic-MediaWiki-Developers, 10Developer-Advocacy (Jan-Mar 2021): Conduct a bot development workshop for the South Asian communities - https://phabricator.wikimedia.org/T273318 (10Aklapper) a:03Jhernandez [19:26:01] (03CR) 10DannyS712: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/675300 (owner: 10DannyS712) [19:26:09] (03CR) 10DannyS712: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/675299 (owner: 10DannyS712) [19:34:15] (03PS4) 10DannyS712: Add extra fallbacks for Special:MyLanguage [core] - 10https://gerrit.wikimedia.org/r/675291 (https://phabricator.wikimedia.org/T278639) (owner: 10Func) [19:49:26] (03CR) 10DannyS712: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/675301 (owner: 10DannyS712) [19:50:45] (03CR) 10DannyS712: [C: 04-1] WIP: Convert WatchlistManager to use Authority and PageIdentity (031 comment) [core] - 10https://gerrit.wikimedia.org/r/675233 (owner: 10Cicalese) [19:52:28] (03CR) 10DannyS712: [C: 04-1] "Needs addition to release notes" [core] - 10https://gerrit.wikimedia.org/r/665546 (https://phabricator.wikimedia.org/T274179) (owner: 10Daniel Kinzler) [19:52:32] (03CR) 10DannyS712: Construct UserIdentityValue without actorId (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/675102 (owner: 10Daniel Kinzler) [19:53:55] (03CR) 10DannyS712: [C: 04-1] Avoid using User::getBoolOption() (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/675318 (https://phabricator.wikimedia.org/T277600) (owner: 10Zabe) [19:55:46] (03CR) 10DannyS712: [C: 03+1] MergeHistory: Avoid potential DB query for trivial message variation [core] - 10https://gerrit.wikimedia.org/r/674520 (https://phabricator.wikimedia.org/T278295) (owner: 10Ammarpad) [19:56:18] (03CR) 10DannyS712: [C: 03+1] SpecialMergeHistory: Use prefixed title text in message [core] - 10https://gerrit.wikimedia.org/r/674521 (https://phabricator.wikimedia.org/T278293) (owner: 10Ammarpad) [19:58:24] (03CR) 10DannyS712: Convert PageEditStash to PageIdentity/UserIdentity (031 comment) [core] - 10https://gerrit.wikimedia.org/r/672563 (owner: 10Ppchelko) [20:08:23] (03PS3) 10Zabe: Avoid using User::getBoolOption() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/675318 (https://phabricator.wikimedia.org/T277600) [20:09:23] (03PS4) 10Zabe: Avoid using User::getBoolOption() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/675318 (https://phabricator.wikimedia.org/T277600) [20:11:47] (03PS5) 10Zabe: Avoid using User::getBoolOption() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/675318 (https://phabricator.wikimedia.org/T277600) [20:13:34] (03PS2) 10Umherirrender: Pass user object to Language::formatExpiry [core] - 10https://gerrit.wikimedia.org/r/667266 [20:16:54] (03CR) 10jerkins-bot: [V: 04-1] Avoid using User::getBoolOption() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/675318 (https://phabricator.wikimedia.org/T277600) (owner: 10Zabe) [20:33:34] (03PS6) 10Zabe: Avoid using User::getBoolOption() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/675318 (https://phabricator.wikimedia.org/T277600) [20:40:20] 10Toolhub: "Empty" facet values? - https://phabricator.wikimedia.org/T277231 (10bd808) This looks to be a "fun with Django" problem. Our toolhub.apps.toolinfo.models.Tool model contains multiple text/char fields which are marked with both `blank=True` meaning the the value is optional and `null=True` meaning tha... [20:40:54] (03PS1) 10BryanDavis: api: return `origin` with toolinfo [wikimedia/toolhub] - 10https://gerrit.wikimedia.org/r/675336 (https://phabricator.wikimedia.org/T278258) [20:40:56] (03PS1) 10BryanDavis: search: add 'origin' facet [wikimedia/toolhub] - 10https://gerrit.wikimedia.org/r/675337 (https://phabricator.wikimedia.org/T278258) [20:44:29] (03CR) 10jerkins-bot: [V: 04-1] search: add 'origin' facet [wikimedia/toolhub] - 10https://gerrit.wikimedia.org/r/675337 (https://phabricator.wikimedia.org/T278258) (owner: 10BryanDavis) [20:56:07] (03PS7) 10Zabe: Avoid using User::getOptionKinds() [core] - 10https://gerrit.wikimedia.org/r/675327 (https://phabricator.wikimedia.org/T277600) [20:56:22] (03PS4) 10Chris Rishel: Adds metric for number of pages created, adds ContributionScores::getMetricValue() helper function to externally retrieve metric values. [extensions/ContributionScores] - 10https://gerrit.wikimedia.org/r/668519 [20:58:12] (03CR) 10Legoktm: Add core functionality (034 comments) [extensions/Sofa] - 10https://gerrit.wikimedia.org/r/675323 (owner: 10Brian Wolff) [21:05:45] 10MediaWiki-Core-Skin-Architecture: Update SVGO to v2.x including new JS based configuration - https://phabricator.wikimedia.org/T278656 (10Volker_E) [21:07:37] 10MediaWiki-extensions-FlaggedRevs, 10Mobile, 10Readers-Web-Backlog (Tracking): On smaller screen width, pages with pending review do not show version history tab - https://phabricator.wikimedia.org/T265875 (10Tacsipacsi) There should be a //Weitere ▼// dropdown just left to the search field. If it isn’t the... [21:08:58] (03CR) 10Zoranzoki21: "check perf" [extensions/ContributionScores] - 10https://gerrit.wikimedia.org/r/668519 (owner: 10Chris Rishel) [21:09:03] (03CR) 10Zoranzoki21: "recheck" [extensions/ContributionScores] - 10https://gerrit.wikimedia.org/r/668519 (owner: 10Chris Rishel) [21:15:55] 10Toolhub: Editing inserts "empty" values for blank collections - https://phabricator.wikimedia.org/T278657 (10bd808) [21:17:23] (03PS8) 10Zabe: Avoid using User::getOptionKinds() [core] - 10https://gerrit.wikimedia.org/r/675327 (https://phabricator.wikimedia.org/T277600) [21:19:14] (03PS2) 10Krinkle: rdbms: Fix property type documentations [core] - 10https://gerrit.wikimedia.org/r/675274 (owner: 10Ammarpad) [21:19:20] (03CR) 10Krinkle: [C: 03+2] "Thanks!" [core] - 10https://gerrit.wikimedia.org/r/675274 (owner: 10Ammarpad) [21:19:50] (03PS1) 10BryanDavis: db: Add support for forcing empty strings to be saved as null [wikimedia/toolhub] - 10https://gerrit.wikimedia.org/r/675339 (https://phabricator.wikimedia.org/T277231) [21:20:51] (03PS5) 10Krinkle: Document methods that may return StubUserLang instead of Language [core] - 10https://gerrit.wikimedia.org/r/674969 (https://phabricator.wikimedia.org/T278429) (owner: 10Ammarpad) [21:20:53] (03CR) 10jerkins-bot: [V: 04-1] db: Add support for forcing empty strings to be saved as null [wikimedia/toolhub] - 10https://gerrit.wikimedia.org/r/675339 (https://phabricator.wikimedia.org/T277231) (owner: 10BryanDavis) [21:22:24] 10MediaWiki-extensions-DisableAccount, 10Patch-For-Review, 10Technical-Debt, 10good first task: [DisableAccount] Convert to using FormSpecialPage - https://phabricator.wikimedia.org/T61639 (10Kizule) a:05Kizule→03None Out of free time for doing this. [21:26:38] 10MediaWiki-General, 10Platform Team Initiatives (Decoupling (CDP2)), 10Technical-Debt: Replace StubUserLang with a better lazy loading mechanism - https://phabricator.wikimedia.org/T244383 (10Krinkle) [21:26:43] 10MediaWiki-General, 10Platform Team Initiatives (Decoupling (CDP2)), 10Technical-Debt: Replace StubUserLang with a better lazy loading mechanism - https://phabricator.wikimedia.org/T244383 (10Krinkle) 05Open→03Declined Declining as-written, because we don't need a better mechanism. We can trivially get... [21:26:57] 10MediaWiki-General, 10MW-1.36-notes (1.36.0-wmf.37; 2021-03-30), 10Performance-Team (Radar), 10Technical-Debt (Deprecation process), and 2 others: Deprecate $wgLang - https://phabricator.wikimedia.org/T160814 (10Krinkle) [21:29:22] (03CR) 10Krinkle: [C: 03+2] FileDeleteForm: reduce use of global context [core] - 10https://gerrit.wikimedia.org/r/675287 (owner: 10DannyS712) [21:31:52] (03PS3) 10Krinkle: auth: Convert AbstractSecondaryAuthenticationProviderTest to pure unit test [core] - 10https://gerrit.wikimedia.org/r/675299 (owner: 10DannyS712) [21:31:58] (03CR) 10Krinkle: [C: 03+2] auth: Convert AbstractSecondaryAuthenticationProviderTest to pure unit test [core] - 10https://gerrit.wikimedia.org/r/675299 (owner: 10DannyS712) [21:32:22] (03PS3) 10Krinkle: auth: Convert AbstractAuthenticationProviderTest to a pure unit test [core] - 10https://gerrit.wikimedia.org/r/675300 (owner: 10DannyS712) [21:33:01] (03CR) 10Krinkle: [C: 03+2] auth: Convert AbstractAuthenticationProviderTest to a pure unit test [core] - 10https://gerrit.wikimedia.org/r/675300 (owner: 10DannyS712) [21:36:14] (03PS1) 10Zoranzoki21: Fix MediaWiki.Files.ClassMatchesFilename.NotMatch and order of excludes in .phpcs.xml [extensions/BatchUserRights] - 10https://gerrit.wikimedia.org/r/675341 [21:37:58] 10MinervaNeue, 10Readers-Web-Backlog (Design): Indicators (protected icon, featured icon) are not shown in Minerva - https://phabricator.wikimedia.org/T75299 (10Tacsipacsi) DeltaBot is ought to fix the discrepancies, but it [[https://www.wikidata.org/wiki/Topic:W61niacesvaoxfo1|seems not to work]]. 🙁 We agree... [21:38:09] (03CR) 10Krinkle: "recheck" [core] - 10https://gerrit.wikimedia.org/r/674751 (https://phabricator.wikimedia.org/T277516) (owner: 10Krinkle) [21:44:27] (03Merged) 10jenkins-bot: rdbms: Fix property type documentations [core] - 10https://gerrit.wikimedia.org/r/675274 (owner: 10Ammarpad) [21:44:31] (03CR) 10jerkins-bot: [V: 04-1] FileDeleteForm: reduce use of global context [core] - 10https://gerrit.wikimedia.org/r/675287 (owner: 10DannyS712) [21:50:07] (03PS1) 10Zoranzoki21: Fix all PHPCS excluded errors [extensions/TopTenPages] - 10https://gerrit.wikimedia.org/r/675342 [21:50:15] (03CR) 10jerkins-bot: [V: 04-1] Avoid using User::getOptionKinds() [core] - 10https://gerrit.wikimedia.org/r/675327 (https://phabricator.wikimedia.org/T277600) (owner: 10Zabe) [21:55:08] (03CR) 10jerkins-bot: [V: 04-1] Fix all PHPCS excluded errors [extensions/TopTenPages] - 10https://gerrit.wikimedia.org/r/675342 (owner: 10Zoranzoki21) [21:58:37] (03Merged) 10jenkins-bot: auth: Convert AbstractSecondaryAuthenticationProviderTest to pure unit test [core] - 10https://gerrit.wikimedia.org/r/675299 (owner: 10DannyS712) [21:58:42] (03Merged) 10jenkins-bot: auth: Convert AbstractAuthenticationProviderTest to a pure unit test [core] - 10https://gerrit.wikimedia.org/r/675300 (owner: 10DannyS712) [22:07:36] 10MediaWiki-extensions-TemplateSandbox, 10MediaWiki-extensions-Translate: “Preview page with this template” broken with translatable templates - https://phabricator.wikimedia.org/T278644 (10Pols12) Right, page must be marked for translation, my bad. So, not a regression. However, there is currently no way to... [22:08:30] (03PS5) 10DannyS712: FileDeleteForm: reduce use of global context [core] - 10https://gerrit.wikimedia.org/r/675287 [22:09:02] (03PS6) 10DannyS712: FileDeleteForm: reduce use of global context [core] - 10https://gerrit.wikimedia.org/r/675287 [22:09:24] (03CR) 10DannyS712: [C: 03+2] "+2 following manual rebase" [core] - 10https://gerrit.wikimedia.org/r/675287 (owner: 10DannyS712) [22:11:11] 10MinervaNeue, 10Readers-Web-Backlog (Design): Indicators (protected icon, featured icon) are not shown in Minerva - https://phabricator.wikimedia.org/T75299 (10XanonymusX) Yeah, the latter point I thought about as well. So, I would summarise our “common” ideas: • Add a //class// or //type// attribute to the... [22:34:00] (03Merged) 10jenkins-bot: FileDeleteForm: reduce use of global context [core] - 10https://gerrit.wikimedia.org/r/675287 (owner: 10DannyS712) [22:49:15] (03CR) 10Brian Wolff: Add core functionality (034 comments) [extensions/Sofa] - 10https://gerrit.wikimedia.org/r/675323 (owner: 10Brian Wolff) [22:52:55] 10MediaWiki-extensions-Translate, 10MediaWiki Language Extension Bundle, 10Documentation: Update https://www.mediawiki.org/wiki/Help:Extension:Translate/Hooks - https://phabricator.wikimedia.org/T257328 (10Aklapper) [22:52:59] 10MediaWiki Language Extension Bundle, 10Language-Team (Language-2020-Focus-Sprint), 10MW-1.36-notes (1.36.0-wmf.2; 2020-07-28), 10Patch-For-Review: Release MLEB 2020.07 - https://phabricator.wikimedia.org/T257286 (10Aklapper) [22:53:36] 10MediaWiki-Core-Hooks, 10Documentation, 10Platform Team Initiatives (New Hook System): Update individual hook manuals on MediaWiki - https://phabricator.wikimedia.org/T250757 (10Aklapper) [22:53:39] 10MediaWiki-Core-Hooks, 10Documentation, 10Platform Team Initiatives (New Hook System): Update dependency injection docs in MediaWiki Core for the new hooks system - https://phabricator.wikimedia.org/T255784 (10Aklapper) [22:54:10] 10MediaWiki-Core-Hooks, 10Dependency injection, 10Documentation, 10Platform Team Initiatives (New Hook System): Update dependency injection docs in MediaWiki Core for the new hooks system - https://phabricator.wikimedia.org/T255784 (10Aklapper) [22:54:20] 10MediaWiki-Core-Hooks, 10Documentation, 10Platform Team Initiatives (New Hook System): Update Hooks Manual on MediaWiki - https://phabricator.wikimedia.org/T250754 (10Aklapper) [23:07:49] (03PS1) 10Jack Phoenix: Remove some unnecessary bool retvals from hooked functions + tweak docs a bit [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/675343 [23:10:00] (03CR) 10jerkins-bot: [V: 04-1] Remove some unnecessary bool retvals from hooked functions + tweak docs a bit [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/675343 (owner: 10Jack Phoenix) [23:13:32] (03PS5) 10DannyS712: Convert some authentication tests to pure unit tests [core] - 10https://gerrit.wikimedia.org/r/675301 [23:17:40] (03CR) 10DannyS712: [C: 04-1] Avoid using User::getBoolOption() (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/675318 (https://phabricator.wikimedia.org/T277600) (owner: 10Zabe) [23:20:09] (03PS1) 10Brian Wolff: Follow-up CR 21b1c781. Use $this directly, Namespace Special title hack. [extensions/Sofa] - 10https://gerrit.wikimedia.org/r/675344 [23:23:46] (03CR) 10DannyS712: [C: 03+1] Document methods that may return StubUserLang instead of Language [core] - 10https://gerrit.wikimedia.org/r/674969 (https://phabricator.wikimedia.org/T278429) (owner: 10Ammarpad) [23:25:18] (03CR) 10DannyS712: [C: 03+2] "Poke Jenkins" [skins/BlueSpiceCalumma] (REL1_35) - 10https://gerrit.wikimedia.org/r/675093 (owner: 10Dvogel hallowelt) [23:29:30] (03CR) 10Brian Wolff: [C: 03+2] Follow-up CR 21b1c781. Use $this directly, Namespace Special title hack. [extensions/Sofa] - 10https://gerrit.wikimedia.org/r/675344 (owner: 10Brian Wolff) [23:31:23] (03Merged) 10jenkins-bot: Info banner is touching the navbar and fix banner color [skins/BlueSpiceCalumma] (REL1_35) - 10https://gerrit.wikimedia.org/r/675093 (owner: 10Dvogel hallowelt) [23:33:47] (03Merged) 10jenkins-bot: Follow-up CR 21b1c781. Use $this directly, Namespace Special title hack. [extensions/Sofa] - 10https://gerrit.wikimedia.org/r/675344 (owner: 10Brian Wolff) [23:45:59] 10MediaWiki-Codesniffer, 10Release, 10User-DannyS712: Release mediawiki-codesniffer v36.0.0 - https://phabricator.wikimedia.org/T278653 (10DannyS712) [23:53:40] 10Patch-For-Review, 10good first task: Improve filename regex in cli/recover-dump - https://phabricator.wikimedia.org/T277754 (10h.krishna) Hi everyone. Based on review comments left by jcrespo in both of your patches - I believe improving the regex is a short-term solution and I believe regex may not necessar... [23:55:35] 10MinervaNeue, 10Readers-Web-Backlog (Design): Indicators (protected icon, featured icon) are not shown in Minerva - https://phabricator.wikimedia.org/T75299 (10Tacsipacsi) >>! In T75299#6952177, @XanonymusX wrote: > • Indicators not using a supported type/class value will not be displayed at all. I think that... [23:55:46] 10MediaWiki-extensions-Gadgets: Parser function for loading gadgets - https://phabricator.wikimedia.org/T241524 (10Tacsipacsi) I don’t see my point about sandboxes (especially sandboxes edited by non-IAs) answered. Also, >>! In T241524#6932961, @PerfektesChaos wrote: > * The proposal is also creating a risk of... [23:56:01] 10MediaWiki-General, 10WorkType-NewFunctionality: Per book, category and/or template CSS and JavaScript - https://phabricator.wikimedia.org/T17075 (10Tacsipacsi) >>! In T17075#6932966, @PerfektesChaos wrote: You was the one who started the C&P… But let’s forget this, and continue exclusively there.