[00:00:55] (03CR) 10DannyS712: "> Patch Set 3:" [core] - 10https://gerrit.wikimedia.org/r/655155 (owner: 10DannyS712) [00:03:25] (03CR) 10Ppchelko: [C: 03+2] "> Patch Set 3:" [core] - 10https://gerrit.wikimedia.org/r/655155 (owner: 10DannyS712) [00:03:35] (03PS9) 10Nray: Sync Vector styling with latest changes in WVUI [skins/Vector] - 10https://gerrit.wikimedia.org/r/651613 (https://phabricator.wikimedia.org/T270202) [00:03:41] 10Desktop Improvements, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-FY-2020-21), 10Vue.js: Design fixes for new vue.js search experience - https://phabricator.wikimedia.org/T270202 (10PatchDemoBot) Test wiki created on [[ http://patchdemo.wmflabs.org... [00:04:47] (03PS17) 10Jdlrobson: Vector should support lower 500px resolution [skins/Vector] - 10https://gerrit.wikimedia.org/r/631552 (https://phabricator.wikimedia.org/T264218) [00:05:58] (03CR) 10Jdlrobson: Vector should support lower 500px resolution (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/631552 (https://phabricator.wikimedia.org/T264218) (owner: 10Jdlrobson) [00:06:18] (03Merged) 10jenkins-bot: Remove right-stopforumspam remnants [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/655517 (https://phabricator.wikimedia.org/T212528) (owner: 10Reedy) [00:06:20] (03PS4) 10DannyS712: Make WatchedItemUnitTest a pure unit test [core] - 10https://gerrit.wikimedia.org/r/655154 [00:06:22] (03Merged) 10jenkins-bot: Swap AutoloadClasses for AutoloadNamespaces [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/655521 (owner: 10Reedy) [00:06:24] (03CR) 10DannyS712: Make WatchedItemUnitTest a pure unit test (032 comments) [core] - 10https://gerrit.wikimedia.org/r/655154 (owner: 10DannyS712) [00:06:36] (03PS4) 10Jdlrobson: Change font and line height Pagelist description [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/652395 (https://phabricator.wikimedia.org/T232229) (owner: 10Prernaswarna) [00:08:19] (03CR) 10Nray: [C: 03+2] "Self +2'ing after I pushed a commit message update and subsequently reverted (for patchdemo purposes) at the same time as @Jdrewniak +2ing" [skins/Vector] - 10https://gerrit.wikimedia.org/r/651613 (https://phabricator.wikimedia.org/T270202) (owner: 10Nray) [00:10:21] (03CR) 10Jdlrobson: "> Patch Set 3: Code-Review+1" [core] - 10https://gerrit.wikimedia.org/r/655131 (https://phabricator.wikimedia.org/T269618) (owner: 10Jdlrobson) [00:16:34] (03Restored) 10Nray: [DNM] Throwaway patch for patchdemo purposes only [core] - 10https://gerrit.wikimedia.org/r/655529 (owner: 10Nray) [00:16:44] (03PS3) 10Nray: [DNM] Throwaway patch for patchdemo purposes only [core] - 10https://gerrit.wikimedia.org/r/655529 [00:16:52] (03Abandoned) 10Nray: [DNM] Throwaway patch for patchdemo purposes only [core] - 10https://gerrit.wikimedia.org/r/655529 (owner: 10Nray) [00:17:55] 10GrowthExperiments-Homepage, 10UniversalLanguageSelector, 10Growth-Team (Current Sprint): Welcome survey: ULS displays redundant lang variants that cannot be selected - https://phabricator.wikimedia.org/T260298 (10Etonkovidova) >>! In T260298#6643859, @MMiller_WMF wrote: > @Etonkovidova -- does this only af... [00:21:20] (03CR) 10DannyS712: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/655399 (https://phabricator.wikimedia.org/T271715) (owner: 10DannyS712) [00:29:00] (03Merged) 10jenkins-bot: WatchedItemStore: use UserFactory [core] - 10https://gerrit.wikimedia.org/r/655155 (owner: 10DannyS712) [00:31:46] (03Merged) 10jenkins-bot: Sync Vector styling with latest changes in WVUI [skins/Vector] - 10https://gerrit.wikimedia.org/r/651613 (https://phabricator.wikimedia.org/T270202) (owner: 10Nray) [00:36:24] (03PS3) 10DannyS712: Only run live updates while the tab is visible [extensions/GlobalWatchlist] - 10https://gerrit.wikimedia.org/r/643157 (https://phabricator.wikimedia.org/T268266) [00:36:41] (03CR) 10DannyS712: "> Patch Set 2:" [extensions/GlobalWatchlist] - 10https://gerrit.wikimedia.org/r/643157 (https://phabricator.wikimedia.org/T268266) (owner: 10DannyS712) [00:36:53] 04(no projects): Error running Selenium tests in fresh-node - https://phabricator.wikimedia.org/T271772 (10jaredblumer) [00:37:13] 04(no projects): Error running Selenium tests in fresh-node in mediawiki core - https://phabricator.wikimedia.org/T271772 (10jaredblumer) [00:37:19] (03PS4) 10DannyS712: Only run live updates while the tab is visible [extensions/GlobalWatchlist] - 10https://gerrit.wikimedia.org/r/643157 (https://phabricator.wikimedia.org/T268266) [00:37:41] 04(no projects): Error running Selenium tests in fresh-node in mediawiki core - https://phabricator.wikimedia.org/T271772 (10jaredblumer) [00:39:24] (03CR) 10jerkins-bot: [V: 04-1] Make WatchedItemUnitTest a pure unit test [core] - 10https://gerrit.wikimedia.org/r/655154 (owner: 10DannyS712) [00:39:40] (03PS5) 10DannyS712: Make WatchedItemUnitTest a pure unit test [core] - 10https://gerrit.wikimedia.org/r/655154 [00:39:42] (03CR) 10DannyS712: Make WatchedItemUnitTest a pure unit test (031 comment) [core] - 10https://gerrit.wikimedia.org/r/655154 (owner: 10DannyS712) [00:40:09] (03PS6) 10DannyS712: Make WatchedItemUnitTest a pure unit test [core] - 10https://gerrit.wikimedia.org/r/655154 [00:41:01] 04(no projects): Error running Selenium tests in fresh-node in mediawiki core - https://phabricator.wikimedia.org/T271772 (10jaredblumer) [00:48:05] 10MediaWiki-extensions-FlaggedRevs: Show age of articles on Special:Unreviewed Pages - https://phabricator.wikimedia.org/T21308 (10DannyS712) ^ unrelated [00:48:52] 10MediaWiki-General, 10Equivset, 10RemexHtml, 10Shellbox, and 3 others: Test, pass, release, and upgrade all home-grown PHP libraries for MediaWiki on PHP 8.0 - https://phabricator.wikimedia.org/T271575 (10DannyS712) [00:49:14] 10DiscussionTools: Consider the tab order for the Reply tool - https://phabricator.wikimedia.org/T271773 (10Whatamidoing-WMF) [00:52:41] (03CR) 10Jdlrobson: [C: 03+2] Change font and line height Pagelist description [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/652395 (https://phabricator.wikimedia.org/T232229) (owner: 10Prernaswarna) [00:52:57] (03CR) 10DannyS712: [C: 04-1] "Doesn't work. Testing on patchdemo at https://patchdemo.wmflabs.org/wikis/e800bccc9bf6ef35832f8da3fd6b6140/w/index.php/Main_Page shows tha" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/655417 (https://phabricator.wikimedia.org/T271667) (owner: 10Daimona Eaytoy) [00:56:54] 10NewcomerTasks 1.2, 10Growth-Team (Current Sprint), 10Product-Analytics (Kanban): Newcomer tasks: reporting notebook after schema changes - https://phabricator.wikimedia.org/T255517 (10nettrom_WMF) I've resolved all the issues we had with the earlier draft of the notebook and handed it back to Marshall for... [00:57:10] 10DiscussionTools: Investigate stray tags inserted by the Reply tool - https://phabricator.wikimedia.org/T271774 (10Whatamidoing-WMF) [01:03:22] 10MediaWiki-General, 10Equivset, 10RemexHtml, 10Shellbox, and 3 others: Test, pass, release, and upgrade all home-grown PHP libraries for MediaWiki on PHP 8.0 - https://phabricator.wikimedia.org/T271575 (10Jdforrester-WMF) Notes on skipped libraries: * Alea's last release, 0.9.2, was from April 2020. Altho... [01:03:41] 10MediaWiki-extensions-Gadgets, 10EventStreams, 10Instrument-ClientError: Strategy for avoiding or excluding client side errors from gadgets and user scripts - https://phabricator.wikimedia.org/T262493 (10Jdlrobson) Today: {F33996196} [01:03:43] 10DiscussionTools, 10Editing-team (Tracking): Create notebook showing number of people using DiscussionTools - https://phabricator.wikimedia.org/T268094 (10Whatamidoing-WMF) For anyone who's interested, the all-time total is about 3,500 accounts right now. Many of these were new editors who have only used it... [01:07:15] 10Wikilink-Tool, 10The-Wikipedia-Library (Kanban): Wikilink graphs shouldn't skip any months - https://phabricator.wikimedia.org/T271409 (10Scardenasmolinar) a:03Scardenasmolinar [01:15:31] (03Merged) 10jenkins-bot: Change font and line height Pagelist description [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/652395 (https://phabricator.wikimedia.org/T232229) (owner: 10Prernaswarna) [01:16:45] (03CR) 10Nray: [C: 04-1] Vector should support lower 500px resolution (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/631552 (https://phabricator.wikimedia.org/T264218) (owner: 10Jdlrobson) [01:16:56] (03CR) 10Jforrester: [C: 03+1] Make WatchedItemUnitTest a pure unit test [core] - 10https://gerrit.wikimedia.org/r/655154 (owner: 10DannyS712) [01:18:24] 10Desktop Improvements, 10CSS, 10RTL, 10Readers-Web-Backlog (Kanbanana-FY-2020-21): "More" tab dropdown options go off-screen in RTL when there are no margins - https://phabricator.wikimedia.org/T267325 (10Jdrewniak) This happens because on legacy Vector, the search box provides enough space for the more m... [01:24:57] 10Security-Team, 10Security: Repeated multiple failed attempts to log into user accounts (leading to email notifications) - https://phabricator.wikimedia.org/T271624 (10sbassett) [01:33:03] (03PS1) 10Jforrester: Release 2.2.1 [libs/RemexHtml] - 10https://gerrit.wikimedia.org/r/655535 (https://phabricator.wikimedia.org/T271575) [01:33:23] (03PS6) 10Brennen Bearnes: DNM: [docker] split php-fpm and apache containers [core] - 10https://gerrit.wikimedia.org/r/630988 (https://phabricator.wikimedia.org/T245444) [01:41:38] (03Abandoned) 10Legoktm: Guard against name-less templateInfo [extensions/Linter] - 10https://gerrit.wikimedia.org/r/393429 (https://phabricator.wikimedia.org/T166101) (owner: 10Legoktm) [01:42:31] 10Desktop Improvements, 10CSS, 10RTL, 10Readers-Web-Backlog (Kanbanana-FY-2020-21): "More" tab dropdown options go off-screen in RTL when there are no margins - https://phabricator.wikimedia.org/T267325 (10Jdrewniak) I tried the approach of right-aligning the menu, but then I realized it affects legacy Vec... [01:50:58] 10Discovery-Search, 10PHP 8.0 support, 10Upstream: Bump rufin/elastica (and related libraries) to versions that support PHP 8.0, when they exist - https://phabricator.wikimedia.org/T271777 (10Jdforrester-WMF) [01:51:21] 10CirrusSearch, 10Discovery-Search, 10PHP 8.0 support, 10Upstream: Bump rufin/elastica (and related libraries) to versions that support PHP 8.0, when they exist - https://phabricator.wikimedia.org/T271777 (10Jdforrester-WMF) [01:51:32] 10CirrusSearch, 10Discovery-Search, 10PHP 8.0 support, 10Upstream: Bump rufin/elastica (and related libraries) to versions that support PHP 8.0, when they exist - https://phabricator.wikimedia.org/T271777 (10Jdforrester-WMF) [01:51:34] 10Discovery-Search, 10Epic: [EPIC] Upgrade Elasticsearch to version 7.x - https://phabricator.wikimedia.org/T263142 (10Jdforrester-WMF) [01:55:53] 10DiscussionTools, 10Editing Design, 10Editing-team (FY2020-21 Kanban Board), 10OWC2020 (New Discussion 1.0): Introduce feature notice for the New Discussion Tool - https://phabricator.wikimedia.org/T270788 (10ppelberg) @Dyolf77_WMF, @Patriccck, @Samat and @Urbanecm_WMF: we have two questions for each of y... [01:57:04] 10Desktop Improvements, 10CSS, 10RTL, 10Readers-Web-Backlog (Kanbanana-FY-2020-21): "More" tab dropdown options go off-screen in RTL when there are no margins - https://phabricator.wikimedia.org/T267325 (10Jdlrobson) It's possible I might have fixed this accidentally in https://gerrit.wikimedia.org/r/c/med... [01:57:11] (03CR) 10Tim Starling: "I've tagged 1.0.0 now." [vendor] - 10https://gerrit.wikimedia.org/r/654693 (owner: 10Legoktm) [01:58:09] (03PS7) 10Krinkle: fresh-node10: Add support for Podman [fresh] - 10https://gerrit.wikimedia.org/r/654349 (https://phabricator.wikimedia.org/T259974) [01:58:11] (03PS1) 10Jforrester: Upgrade wikimedia/equivset from 1.4.0 to 1.4.1 [vendor] - 10https://gerrit.wikimedia.org/r/655536 (https://phabricator.wikimedia.org/T271575) [01:58:13] (03CR) 10Krinkle: [C: 03+1] fresh-node10: Add support for Podman [fresh] - 10https://gerrit.wikimedia.org/r/654349 (https://phabricator.wikimedia.org/T259974) (owner: 10Krinkle) [01:58:29] (03PS8) 10Krinkle: fresh-node10: Add support for Podman [fresh] - 10https://gerrit.wikimedia.org/r/654349 (https://phabricator.wikimedia.org/T259974) [01:58:40] 10MediaWiki-General, 10Equivset, 10RemexHtml, 10Shellbox, and 3 others: Test, pass, release, and upgrade all home-grown PHP libraries for MediaWiki on PHP 8.0 - https://phabricator.wikimedia.org/T271575 (10Jdforrester-WMF) [01:58:56] 10MediaWiki-Codesniffer, 10User-DannyS712: Remove tabs in function signature - https://phabricator.wikimedia.org/T241520 (10DannyS712) 05Open→03Resolved [02:00:04] (03CR) 10Legoktm: [C: 03+2] fresh-node10: Add support for Podman [fresh] - 10https://gerrit.wikimedia.org/r/654349 (https://phabricator.wikimedia.org/T259974) (owner: 10Krinkle) [02:00:32] (03PS18) 10Jdlrobson: Vector should support lower 500px resolution [skins/Vector] - 10https://gerrit.wikimedia.org/r/631552 (https://phabricator.wikimedia.org/T264218) [02:00:57] (03CR) 10Jdlrobson: Vector should support lower 500px resolution (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/631552 (https://phabricator.wikimedia.org/T264218) (owner: 10Jdlrobson) [02:02:05] (03PS3) 10Ebernhardson: implement link recommendations imports [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/647762 (https://phabricator.wikimedia.org/T262226) [02:02:07] (03PS3) 10Ebernhardson: Simplify populating integration env tables [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/648318 [02:02:09] (03CR) 10Ebernhardson: Simplify populating integration env tables (031 comment) [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/648318 (owner: 10Ebernhardson) [02:02:11] (03PS3) 10Ebernhardson: [WIP] Move some elasticsearch transfers to hourly schedule [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/648319 [02:02:13] (03CR) 10Ebernhardson: [WIP] Move some elasticsearch transfers to hourly schedule (032 comments) [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/648319 (owner: 10Ebernhardson) [02:02:15] 10MediaWiki-Codesniffer, 10Release, 10User-DannyS712: Release mediawiki-codesniffer v35.0.0 - https://phabricator.wikimedia.org/T271392 (10DannyS712) [02:05:15] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Move some elasticsearch transfers to hourly schedule [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/648319 (owner: 10Ebernhardson) [02:06:12] (03CR) 10jerkins-bot: [V: 04-1] Simplify populating integration env tables [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/648318 (owner: 10Ebernhardson) [02:07:10] (03PS1) 10TrainBranchBot: Branch commit for wmf/1.36.0-wmf.26 [core] (wmf/1.36.0-wmf.26) - 10https://gerrit.wikimedia.org/r/655537 [02:07:31] (03PS2) 10Jforrester: Branch commit for wmf/1.36.0-wmf.26 [core] (wmf/1.36.0-wmf.26) - 10https://gerrit.wikimedia.org/r/655537 (https://phabricator.wikimedia.org/T267419) (owner: 10TrainBranchBot) [02:07:45] 04(no projects): The Chrome team says Wikipedia needs a proper media player for better navigation - https://phabricator.wikimedia.org/T271764 (10Tgr) 05Open→03Invalid Actually they aren't saying that, what they are saying is that you shouldn't make Chrome bug reports about the contents of Wikipedia web page... [02:13:04] (03PS5) 10Aaron Schulz: rdbms: split out LoadBalancer::hasBitfield to reduce code duplication [core] - 10https://gerrit.wikimedia.org/r/641842 [02:13:06] 10MediaWiki-Page-deletion, 10Commons, 10Wikimedia-production-error: Fatal exception undeleting a file on Commons: rev_page field must not be 0! - https://phabricator.wikimedia.org/T271644 (10Krenair) [02:33:03] (03Merged) 10jenkins-bot: fresh-node10: Add support for Podman [fresh] - 10https://gerrit.wikimedia.org/r/654349 (https://phabricator.wikimedia.org/T259974) (owner: 10Krinkle) [02:35:01] 10UI-Standardization, 10MinervaNeue, 10Readers-Web-Backlog (Kanbanana-FY-2020-21), 10good first task, 10patch-welcome: PageList descriptions too small font and line height - https://phabricator.wikimedia.org/T232229 (10Jdlrobson) a:05Prernaswarna→03alexhollender [02:35:39] (03CR) 10Jforrester: "check experimental" [vendor] - 10https://gerrit.wikimedia.org/r/655536 (https://phabricator.wikimedia.org/T271575) (owner: 10Jforrester) [02:40:21] (03PS8) 10Jforrester: Updating monolog/monolog (2.0.2 => 2.1.1) [vendor] - 10https://gerrit.wikimedia.org/r/621953 (https://phabricator.wikimedia.org/T242751) (owner: 10Reedy) [02:40:29] (03PS3) 10Jforrester: Updating monolog/monolog (2.0.2 => 2.1.1) [core] - 10https://gerrit.wikimedia.org/r/644834 (https://phabricator.wikimedia.org/T242751) (owner: 10Reedy) [02:40:35] (03CR) 10Jforrester: [C: 03+2] Updating monolog/monolog (2.0.2 => 2.1.1) [core] - 10https://gerrit.wikimedia.org/r/644834 (https://phabricator.wikimedia.org/T242751) (owner: 10Reedy) [02:40:40] (03CR) 10Jforrester: [C: 03+2] Updating monolog/monolog (2.0.2 => 2.1.1) [vendor] - 10https://gerrit.wikimedia.org/r/621953 (https://phabricator.wikimedia.org/T242751) (owner: 10Reedy) [02:44:24] (03CR) 10Jforrester: "Needs rebasing / re-doing (and then asking Platform to review)." [core] - 10https://gerrit.wikimedia.org/r/579682 (https://phabricator.wikimedia.org/T247675) (owner: 10Reedy) [02:45:01] (03CR) 10Jforrester: [C: 03+2] "check experimental" [vendor] - 10https://gerrit.wikimedia.org/r/621953 (https://phabricator.wikimedia.org/T242751) (owner: 10Reedy) [02:45:33] (03CR) 10SBassett: [C: 03+2] DenyListUpdate: Cast values from CSV input before using them [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/655526 (https://phabricator.wikimedia.org/T271757) (owner: 10Reedy) [02:52:30] 10MediaWiki-extensions-StopForumSpam, 10Patch-For-Review, 10user-sbassett: Fix issues with StopForumSpam's doUpdate function - https://phabricator.wikimedia.org/T271757 (10sbassett) @Reedy - Thanks for having a look. My next best guess for the culprit is that maybe some of the WanCache `get`s should instead... [02:52:43] (03Merged) 10jenkins-bot: DenyListUpdate: Cast values from CSV input before using them [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/655526 (https://phabricator.wikimedia.org/T271757) (owner: 10Reedy) [02:53:51] 10MediaWiki-extensions-StopForumSpam, 10user-sbassett: Address various issues around exception-handling within StopForumSpam - https://phabricator.wikimedia.org/T271756 (10sbassett) [02:55:05] (03PS14) 10Aaron Schulz: parser: convert Preprocessor to WANCache and inject dependencies [core] - 10https://gerrit.wikimedia.org/r/587494 (https://phabricator.wikimedia.org/T254608) [02:57:08] (03CR) 10Jforrester: [C: 03+2] "check experimental" [core] - 10https://gerrit.wikimedia.org/r/644834 (https://phabricator.wikimedia.org/T242751) (owner: 10Reedy) [02:59:15] 10Trust-and-Safety: Two-factor authentication reset for CentralAuth account Titoxd - https://phabricator.wikimedia.org/T271779 (10Titoxd) [02:59:26] (03CR) 10Jforrester: [C: 03+2] Output number of IPs [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/655527 (owner: 10Reedy) [03:04:50] (03Merged) 10jenkins-bot: Output number of IPs [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/655527 (owner: 10Reedy) [03:16:33] (03CR) 10Ppchelko: [C: 04-1] Allow injecting configuration values (036 comments) [libs/ObjectFactory] - 10https://gerrit.wikimedia.org/r/642445 (https://phabricator.wikimedia.org/T246377) (owner: 10DannyS712) [03:23:25] (03CR) 10jerkins-bot: [V: 04-1] parser: convert Preprocessor to WANCache and inject dependencies [core] - 10https://gerrit.wikimedia.org/r/587494 (https://phabricator.wikimedia.org/T254608) (owner: 10Aaron Schulz) [03:41:08] (03CR) 10Tim Starling: [C: 03+2] "Tested manually, seems to work." [core] - 10https://gerrit.wikimedia.org/r/587494 (https://phabricator.wikimedia.org/T254608) (owner: 10Aaron Schulz) [03:41:40] (03CR) 10Tim Starling: "OK, V-1 so no CR+2 for now..." [core] - 10https://gerrit.wikimedia.org/r/587494 (https://phabricator.wikimedia.org/T254608) (owner: 10Aaron Schulz) [03:48:36] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Curate topic-grouped article suggestions for KaiOS app homepage experiment - https://phabricator.wikimedia.org/T271315 (10SGautam_WMF) @SBisson Thanks for sharing these. I had a quick look, and most of the articles under these topics look good, except some, e.g., u... [03:54:41] (03PS6) 10Aaron Schulz: rdbms: split out LoadBalancer::fieldHasBit to reduce code duplication [core] - 10https://gerrit.wikimedia.org/r/641842 [04:07:46] (03CR) 10Krinkle: rdbms: minor documentation tweaks to IDatabase/ILoadBalancer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/643344 (owner: 10Aaron Schulz) [04:09:52] (03CR) 10jerkins-bot: [V: 04-1] parser: convert Preprocessor to WANCache and inject dependencies [core] - 10https://gerrit.wikimedia.org/r/587494 (https://phabricator.wikimedia.org/T254608) (owner: 10Aaron Schulz) [04:10:40] (03PS1) 10Tim Starling: Add "debug" flag to ObjectCache configuration [core] - 10https://gerrit.wikimedia.org/r/655543 [04:16:42] 10Add-Link, 10Growth-Structured-Tasks, 10Growth-Team (Current Sprint), 10Patch-For-Review: Add Link engineering: Provide a mechanism for storing data about which link recommendations were rejected by the user - https://phabricator.wikimedia.org/T266446 (10Tgr) The probability of no three users ever getting... [04:19:30] 10MediaWiki-ResourceLoader, 10MobileFrontend, 10MinervaNeue, 10Reading-Web-Third-Party-Support, and 3 others: Mobile.js/Mobile.css not loading after upgrading to MediaWiki 1.35 - https://phabricator.wikimedia.org/T270845 (10Universal_Omega) >>! In T270845#6737377, @Krinkle wrote: > Assumed duplicate of T27... [04:19:58] 10IP Info, 10Anti-Harassment (The Letter Song), 10Patch-For-Review: Prevent jump on log and history pages when IPInfo popup button loads - https://phabricator.wikimedia.org/T271486 (10Prtksxna) Thanks @Tchanders! Yep, I think its an alright trade-off to have a jump on IP ranges. There'll be no ranges on his... [04:21:20] (03PS15) 10Aaron Schulz: parser: convert Preprocessor to WANCache and inject dependencies [core] - 10https://gerrit.wikimedia.org/r/587494 (https://phabricator.wikimedia.org/T254608) [04:24:57] (03CR) 10Aaron Schulz: [C: 03+2] WikiPage: Add process cache for content model [core] - 10https://gerrit.wikimedia.org/r/654230 (owner: 10TK-999) [04:25:30] 10Design, 10Anti-Harassment, 10IP Info: Create loading states for the IP info box, popup and fields - https://phabricator.wikimedia.org/T271675 (10Prtksxna) [04:26:17] (03CR) 10Subramanya Sastry: "This broke Parsoid CI." [core] - 10https://gerrit.wikimedia.org/r/654931 (https://phabricator.wikimedia.org/T254537) (owner: 10Ppchelko) [04:28:13] 10Fresh: Add support for non-rooted container runtime - https://phabricator.wikimedia.org/T259974 (10Krinkle) 05Open→03Resolved a:03Legoktm [04:28:48] (03CR) 10Subramanya Sastry: "Unless something else is triggering these failures on Parsoid patches." [core] - 10https://gerrit.wikimedia.org/r/654931 (https://phabricator.wikimedia.org/T254537) (owner: 10Ppchelko) [04:29:47] (03PS1) 10Greg Grossmeier: greg: update key expiration dates [pgp-public-keys] - 10https://gerrit.wikimedia.org/r/655544 [04:31:28] 10MediaWiki-Blocks, 10GlobalBlocking: Add global blocks into CompositeBlocks rather than treating them separately - https://phabricator.wikimedia.org/T257701 (10TheVoidwalker) Hmm, I've been looking into this, and I have a fairly functional method by which to do this (need to make some updates still to the Glo... [04:33:10] 10Design, 10Anti-Harassment, 10IP Info: Create loading states for the IP info box, popup and fields - https://phabricator.wikimedia.org/T271675 (10Prtksxna) [04:33:47] 10Trust-and-Safety: Two-factor authentication reset for CentralAuth account Titoxd - https://phabricator.wikimedia.org/T271779 (10Nahid) a:03Nahid Hello @Titoxd, Please email Trust and Safety at ca{{@}}wikimedia.org from the email address that is attached to User:Titoxd. Thanks. [04:34:02] 10Design, 10Anti-Harassment, 10IP Info: Create loading states for the IP info box, popup and fields - https://phabricator.wikimedia.org/T271675 (10Prtksxna) [04:34:33] 10Design, 10Anti-Harassment, 10IP Info: Figure out what the IP info box should show when some information is not available - https://phabricator.wikimedia.org/T271670 (10Prtksxna) [04:35:31] (03CR) 10Tim Starling: [C: 03+2] parser: convert Preprocessor to WANCache and inject dependencies [core] - 10https://gerrit.wikimedia.org/r/587494 (https://phabricator.wikimedia.org/T254608) (owner: 10Aaron Schulz) [04:38:06] (03PS5) 10Aaron Schulz: rdbms: minor documentation tweaks to IDatabase/ILoadBalancer [core] - 10https://gerrit.wikimedia.org/r/643344 [04:44:31] (03CR) 10Aaron Schulz: Add "debug" flag to ObjectCache configuration (031 comment) [core] - 10https://gerrit.wikimedia.org/r/655543 (owner: 10Tim Starling) [04:48:52] (03PS1) 10Ppchelko: Revert "Enhance GroupPermissionsLookup and use it." [core] - 10https://gerrit.wikimedia.org/r/655400 [04:49:51] (03CR) 10Krinkle: [C: 03+2] rdbms: split out LoadBalancer::fieldHasBit to reduce code duplication [core] - 10https://gerrit.wikimedia.org/r/641842 (owner: 10Aaron Schulz) [04:49:58] (03CR) 10Ppchelko: "> Patch Set 5:" [core] - 10https://gerrit.wikimedia.org/r/654931 (https://phabricator.wikimedia.org/T254537) (owner: 10Ppchelko) [04:50:33] (03PS6) 10Krinkle: rdbms: minor documentation tweaks to IDatabase/ILoadBalancer [core] - 10https://gerrit.wikimedia.org/r/643344 (owner: 10Aaron Schulz) [04:50:36] (03CR) 10Krinkle: [C: 03+2] rdbms: minor documentation tweaks to IDatabase/ILoadBalancer [core] - 10https://gerrit.wikimedia.org/r/643344 (owner: 10Aaron Schulz) [04:53:12] (03PS6) 10Krinkle: rdbms: clean up handling of CONN_SILENCE_ERRORS in get(Lazy|Maintenance|)ConnectionRef() [core] - 10https://gerrit.wikimedia.org/r/641843 (owner: 10Aaron Schulz) [04:54:08] (03Merged) 10jenkins-bot: WikiPage: Add process cache for content model [core] - 10https://gerrit.wikimedia.org/r/654230 (owner: 10TK-999) [04:58:57] (03CR) 10Krinkle: [C: 04-1] rdbms: clean up handling of CONN_SILENCE_ERRORS in get(Lazy|Maintenance|)ConnectionRef() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/641843 (owner: 10Aaron Schulz) [04:58:59] (03CR) 10jerkins-bot: [V: 04-1] rdbms: clean up handling of CONN_SILENCE_ERRORS in get(Lazy|Maintenance|)ConnectionRef() [core] - 10https://gerrit.wikimedia.org/r/641843 (owner: 10Aaron Schulz) [04:59:58] (03CR) 10Krinkle: [C: 04-1] "OK, but that doesn't answer my question :)" [core] - 10https://gerrit.wikimedia.org/r/641836 (owner: 10Aaron Schulz) [05:02:08] (03CR) 10Krinkle: [C: 04-2] "If I understand correctly, you and Tim decided to focus on T269326 first and then use that here. Setting -2 to reflect that and to clear i" [core] - 10https://gerrit.wikimedia.org/r/644636 (https://phabricator.wikimedia.org/T193565) (owner: 10Aaron Schulz) [05:04:25] 10Design, 10Anti-Harassment, 10IP Info: Add info text icons and text where required in IP Info - https://phabricator.wikimedia.org/T271672 (10Prtksxna) [05:04:50] (03Merged) 10jenkins-bot: parser: convert Preprocessor to WANCache and inject dependencies [core] - 10https://gerrit.wikimedia.org/r/587494 (https://phabricator.wikimedia.org/T254608) (owner: 10Aaron Schulz) [05:14:46] 10Technical-blog-posts: Story Idea for Blog: Automated detection of wikipedia censorship events - https://phabricator.wikimedia.org/T269256 (10Nuria) Ping @srodlund [05:16:28] (03CR) 10Cicalese: [C: 03+2] Revert "Enhance GroupPermissionsLookup and use it." [core] - 10https://gerrit.wikimedia.org/r/655400 (owner: 10Ppchelko) [05:16:42] 10Design, 10Anti-Harassment, 10IP Info: Fix padding and typography issues in the IP info box - https://phabricator.wikimedia.org/T271673 (10Prtksxna) [05:18:38] (03PS1) 10STran: [WIP] Log when admins access voter data [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/655545 (https://phabricator.wikimedia.org/T271276) [05:19:32] (03CR) 10STran: [C: 04-1] "Based on the db proposed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SecurePoll/+/655133 and subject to change" [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/655545 (https://phabricator.wikimedia.org/T271276) (owner: 10STran) [05:22:51] (03Merged) 10jenkins-bot: rdbms: split out LoadBalancer::fieldHasBit to reduce code duplication [core] - 10https://gerrit.wikimedia.org/r/641842 (owner: 10Aaron Schulz) [05:23:10] (03Merged) 10jenkins-bot: rdbms: minor documentation tweaks to IDatabase/ILoadBalancer [core] - 10https://gerrit.wikimedia.org/r/643344 (owner: 10Aaron Schulz) [05:30:24] (03CR) 10DannyS712: "is there no change to code?" [vendor] - 10https://gerrit.wikimedia.org/r/655536 (https://phabricator.wikimedia.org/T271575) (owner: 10Jforrester) [05:31:18] 10TemplateStyles: [447d23fdf3137a6a3e9de025] /wiki/File:Subtitle.jpg TypeError from line 113 of /srv/mediawiki/w/extensions/TemplateStyles/includes/TemplateStylesHooks.php: Argument 2 passed to TemplateStylesHooks::{closure}() must be an instance of Wikimedia\CSS\Gramm... - https://phabricator.wikimedia.org/T271781 [05:31:44] 10TemplateStyles: [447d23fdf3137a6a3e9de025] /wiki/File:Subtitle.jpg TypeError from line 113 of /srv/mediawiki/w/extensions/TemplateStyles/includes/TemplateStylesHooks.php: Argument 2 passed to TemplateStylesHooks::{closure}() must be an instance of Wikimedia\CSS\Gramm... - https://phabricator.wikimedia.org/T271781 [05:36:24] 10TemplateStyles: must be an instance of Wikimedia\CSS\Grammar\GrammarMatch, instance of Wikimedia\CSS\Grammar\Match given - https://phabricator.wikimedia.org/T271781 (10Universal_Omega) [05:37:02] 10TemplateStyles: must be an instance of Wikimedia\CSS\Grammar\GrammarMatch, instance of Wikimedia\CSS\Grammar\Match given - https://phabricator.wikimedia.org/T271781 (10JJMC89) [05:39:17] (03Merged) 10jenkins-bot: Revert "Enhance GroupPermissionsLookup and use it." [core] - 10https://gerrit.wikimedia.org/r/655400 (owner: 10Ppchelko) [05:44:08] (03CR) 10Jdlrobson: [C: 03+2] Don't blindly overwrite contentnavigation [skins/Vector] - 10https://gerrit.wikimedia.org/r/655287 (owner: 10Mainframe98) [05:46:53] (03PS5) 10DannyS712: Allow injecting configuration values [libs/ObjectFactory] - 10https://gerrit.wikimedia.org/r/642445 (https://phabricator.wikimedia.org/T246377) [05:46:58] (03CR) 10DannyS712: Allow injecting configuration values (036 comments) [libs/ObjectFactory] - 10https://gerrit.wikimedia.org/r/642445 (https://phabricator.wikimedia.org/T246377) (owner: 10DannyS712) [05:48:58] 10TemplateStyles: must be an instance of Wikimedia\CSS\Grammar\GrammarMatch, instance of Wikimedia\CSS\Grammar\Match given - https://phabricator.wikimedia.org/T271781 (10DannyS712) @Universal_Omega where are you seeing this? [05:55:59] 10TemplateStyles: must be an instance of Wikimedia\CSS\Grammar\GrammarMatch, instance of Wikimedia\CSS\Grammar\Match given - https://phabricator.wikimedia.org/T271781 (10Universal_Omega) >>! In T271781#6738530, @DannyS712 wrote: > @Universal_Omega where are you seeing this? It should have been fixed by {T271594}... [06:02:31] 10TemplateStyles: must be an instance of Wikimedia\CSS\Grammar\GrammarMatch, instance of Wikimedia\CSS\Grammar\Match given - https://phabricator.wikimedia.org/T271781 (10DannyS712) >>! In T271781#6738533, @Universal_Omega wrote: >>>! In T271781#6738530, @DannyS712 wrote: >> @Universal_Omega where are you seeing... [06:03:01] 04(no projects): How to use MediaWiki 1.35 in security inforced server setup with path - https://phabricator.wikimedia.org/T271783 (10Seppl2013) [06:03:03] 10TemplateStyles: must be an instance of Wikimedia\CSS\Grammar\GrammarMatch, instance of Wikimedia\CSS\Grammar\Match given - https://phabricator.wikimedia.org/T271781 (10DannyS712) [06:04:00] 10TemplateStyles: must be an instance of Wikimedia\CSS\Grammar\GrammarMatch, instance of Wikimedia\CSS\Grammar\Match given - https://phabricator.wikimedia.org/T271781 (10DannyS712) p:05High→03Low >>! In T271781#6738512, @Universal_Omega wrote: > Triaging as high since this is unusable until it's fixed. Not... [06:05:51] 10TemplateStyles: must be an instance of Wikimedia\CSS\Grammar\GrammarMatch, instance of Wikimedia\CSS\Grammar\Match given - https://phabricator.wikimedia.org/T271781 (10Tgr) Most likely, either your update process failed to update Composer dependencies or (if you are using the mediawiki/vendor repo) your timing... [06:08:11] 10TemplateStyles: must be an instance of Wikimedia\CSS\Grammar\GrammarMatch, instance of Wikimedia\CSS\Grammar\Match given - https://phabricator.wikimedia.org/T271781 (10Universal_Omega) >>! In T271781#6738535, @DannyS712 wrote: >>>! In T271781#6738533, @Universal_Omega wrote: >>>>! In T271781#6738530, @DannyS71... [06:09:22] (03CR) 10Ppchelko: Allow injecting configuration values (034 comments) [libs/ObjectFactory] - 10https://gerrit.wikimedia.org/r/642445 (https://phabricator.wikimedia.org/T246377) (owner: 10DannyS712) [06:09:54] (03PS1) 10Gergő Tisza: Make instance_occurence plaintext-based [research/mwaddlink] (main) - 10https://gerrit.wikimedia.org/r/655547 (https://phabricator.wikimedia.org/T271604) [06:10:46] (03CR) 10jerkins-bot: [V: 04-1] Make instance_occurence plaintext-based [research/mwaddlink] (main) - 10https://gerrit.wikimedia.org/r/655547 (https://phabricator.wikimedia.org/T271604) (owner: 10Gergő Tisza) [06:11:55] (03CR) 10DannyS712: Introduce an EditRevUpdater service (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/654416 (owner: 10Daimona Eaytoy) [06:15:32] (03Merged) 10jenkins-bot: Don't blindly overwrite contentnavigation [skins/Vector] - 10https://gerrit.wikimedia.org/r/655287 (owner: 10Mainframe98) [06:18:38] (03PS6) 10DannyS712: Allow injecting configuration values [libs/ObjectFactory] - 10https://gerrit.wikimedia.org/r/642445 (https://phabricator.wikimedia.org/T246377) [06:19:56] (03PS2) 10Gergő Tisza: Make instance_occurence plaintext-based [research/mwaddlink] (main) - 10https://gerrit.wikimedia.org/r/655547 (https://phabricator.wikimedia.org/T271604) [06:20:14] 10MediaWiki-User-preferences, 10MediaWiki-Watchlist, 10Growth-Team, 10Patch-For-Review: Allow to exclude bots from watchlist notifications - https://phabricator.wikimedia.org/T262750 (10Jidanni) All I know is I am still getting notifications caused by https://zh.wikipedia.org/wiki/User:Jimmy-bot . [06:20:40] (03CR) 10jerkins-bot: [V: 04-1] Make instance_occurence plaintext-based [research/mwaddlink] (main) - 10https://gerrit.wikimedia.org/r/655547 (https://phabricator.wikimedia.org/T271604) (owner: 10Gergő Tisza) [06:20:49] (03CR) 10DannyS712: Allow injecting configuration values (032 comments) [libs/ObjectFactory] - 10https://gerrit.wikimedia.org/r/642445 (https://phabricator.wikimedia.org/T246377) (owner: 10DannyS712) [06:23:33] 10TemplateStyles: must be an instance of Wikimedia\CSS\Grammar\GrammarMatch, instance of Wikimedia\CSS\Grammar\Match given - https://phabricator.wikimedia.org/T271781 (10Majavah) mediawiki/vendor does not have css-sanitizer on REL1_35 (master only for some reason), instead [[ https://www.mediawiki.org/wiki/Exten... [06:24:47] 10Add-Link, 10Growth-Structured-Tasks, 10Growth-Team (Current Sprint), 10Patch-For-Review: Add a link: instance_occurrence should be based on plaintext, not wikitext - https://phabricator.wikimedia.org/T271604 (10Tgr) Patch is up; I have no idea how to test it though. It takes the somewhat lazy approach of... [06:34:56] (03PS1) 10DLynch: Give new-section a specific init_type to distinguish it [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/655548 [06:35:44] (03CR) 10DLynch: "Feel free to squash this into 623117 if that makes things easier." [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/655548 (owner: 10DLynch) [06:37:02] (03PS2) 10DLynch: Give new-section a specific init_type to distinguish it [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/655548 (https://phabricator.wikimedia.org/T265099) [06:42:13] (03CR) 10jerkins-bot: [V: 04-1] Give new-section a specific init_type to distinguish it [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/655548 (https://phabricator.wikimedia.org/T265099) (owner: 10DLynch) [06:43:46] (03PS3) 10DLynch: Give new-section a specific init_type to distinguish it [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/655548 (https://phabricator.wikimedia.org/T265099) [06:48:57] (03PS2) 10Abijeet Patro: Replace deprecated `mw-infobox` with Html::warningBox [extensions/TranslationNotifications] - 10https://gerrit.wikimedia.org/r/651853 (https://phabricator.wikimedia.org/T268194) (owner: 10VolkerE) [06:50:32] (03CR) 10Abijeet Patro: Replace deprecated `mw-infobox` with Html::warningBox (031 comment) [extensions/TranslationNotifications] - 10https://gerrit.wikimedia.org/r/651853 (https://phabricator.wikimedia.org/T268194) (owner: 10VolkerE) [06:52:55] 10Wikisource Export, 10Community-Tech (Kanban-2020-21-Q2): Add flag to turn off caching - https://phabricator.wikimedia.org/T271771 (10Samwilson) [06:53:24] 10Trust-and-Safety: Two-factor authentication reset for CentralAuth account Titoxd - https://phabricator.wikimedia.org/T271779 (10Titoxd) >>! In T271779#6738474, @Nahid wrote: > Hello @Titoxd, Please email Trust and Safety at ca{{@}}wikimedia.org from the email address that is attached to User:Titoxd. Thanks. H... [06:53:30] 10Wikisource Export, 10Community-Tech (Kanban-2020-21-Q2): Add flag to turn off caching - https://phabricator.wikimedia.org/T271771 (10Samwilson) PR: https://github.com/wsexport/tool/pull/308 [06:54:11] (03PS3) 10Abijeet Patro: Replace deprecated `mw-infobox` with Html::warningBox [extensions/TranslationNotifications] - 10https://gerrit.wikimedia.org/r/651853 (https://phabricator.wikimedia.org/T268194) (owner: 10VolkerE) [07:04:30] 10WMSE-Organisational-Development-2021: ☂Move to more digital flows - https://phabricator.wikimedia.org/T256965 (10Jopparn) [07:08:00] 10WMSE-Organisational-Development-2021: Add Scrive to on-/offboarding checklists - https://phabricator.wikimedia.org/T257021 (10Jopparn) [07:11:13] (03PS1) 10Srishakatux: User interface to register, authorize, view, and revoke Toolhub OAuth grants. [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/655550 (https://phabricator.wikimedia.org/T264967) [07:11:59] (03CR) 10Gergő Tisza: [C: 03+1] training pipeline: Export MySQL dumps and publish on web (031 comment) [research/mwaddlink] (main) - 10https://gerrit.wikimedia.org/r/654930 (https://phabricator.wikimedia.org/T266826) (owner: 10Kosta Harlan) [07:14:51] (03CR) 10Reedy: [C: 03+2] "No. https://github.com/wikimedia/Equivset/compare/1.4.0...1.4.1" [vendor] - 10https://gerrit.wikimedia.org/r/655536 (https://phabricator.wikimedia.org/T271575) (owner: 10Jforrester) [07:20:08] 04(no projects): How to use MediaWiki 1.35 in security inforced server setup with path - https://phabricator.wikimedia.org/T271783 (10Seppl2013) The workaround is ` # make sure we don't use "pretty urls" $wgUsePathInfo=false; ` The question is now how to avoid this [07:21:49] (03PS1) 10Reedy: Remove erroneous trailing } [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/655551 [07:22:58] 10WMSE-Organisational-Development-2021, 10WMSE-Tools-for-Partnerships-2020: Evaluate need for shared storage space - https://phabricator.wikimedia.org/T234595 (10Jopparn) [07:23:04] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Remove erroneous trailing } [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/655551 (owner: 10Reedy) [07:23:21] 10MediaWiki-extensions-StopForumSpam, 10MW-1.36-notes (1.36.0-wmf.27; 2021-01-19), 10user-sbassett: Fix issues with StopForumSpam's doUpdate function - https://phabricator.wikimedia.org/T271757 (10Reedy) ` vagrant@mediawiki-vagrant:/vagrant/mediawiki/extensions/StopForumSpam$ git diff diff --git a/includes/D... [07:23:32] 10Trust-and-Safety: Two-factor authentication reset for CentralAuth account Titoxd - https://phabricator.wikimedia.org/T271779 (10Nahid) 05Open→03Resolved 2FA removed from User:Titoxd. Thanks. [07:26:18] 10Discovery-Search (Current work), 10Structured-Data-Backlog (Current Work): Include gsrprop & gsrsinfo data in search api generator response - https://phabricator.wikimedia.org/T270381 (10matthiasmullie) Will search platform or structured data implement this? I'm ok with either, just want to make sure we don'... [07:26:45] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "I won't have much time actually reviewing this, but since I got added as a reviewer: Patch set 1 simply replaces the