[00:00:57] (03PS4) 10Aaron Schulz: rdbms: minor documentation tweaks to IDatabase/ILoadBalancer [core] - 10https://gerrit.wikimedia.org/r/643344 [00:00:59] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10OWC2020 (New Discussion 1.0): Ensure the New Discussion Tool defaults to the correct text input mode - https://phabricator.wikimedia.org/T270685 (10ppelberg) [00:02:06] (03CR) 10Tim Starling: "The test failure is another example of the kind of thing I'm trying to fix." [core] - 10https://gerrit.wikimedia.org/r/654966 (owner: 10Tim Starling) [00:02:46] (03CR) 10Jeena Huneidi: [C: 03+2] "LGTM" [tools/cli] - 10https://gerrit.wikimedia.org/r/653806 (owner: 10Addshore) [00:03:24] (03Merged) 10jenkins-bot: Move spinner to HandlerOptions [tools/cli] - 10https://gerrit.wikimedia.org/r/653806 (owner: 10Addshore) [00:04:02] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10OWC2020 (New Discussion 1.0): Ensure the New Discussion Tool defaults to the correct text input mode - https://phabricator.wikimedia.org/T270685 (10ppelberg) [00:04:24] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10OWC2020 (New Discussion 1.0): Ensure the New Discussion Tool defaults to the correct text input mode - https://phabricator.wikimedia.org/T270685 (10ppelberg) **META** I am closing this task as a duplicate of T250523 considering: - T250523 implemen... [00:04:28] (03CR) 10Ppchelko: Use GroupPermissionsLookup in various places (036 comments) [core] - 10https://gerrit.wikimedia.org/r/654931 (https://phabricator.wikimedia.org/T254537) (owner: 10Ppchelko) [00:04:31] (03PS4) 10Ppchelko: Enhance GroupPermissionsLookup and use it. [core] - 10https://gerrit.wikimedia.org/r/654931 (https://phabricator.wikimedia.org/T254537) [00:06:01] (03CR) 10jerkins-bot: [V: 04-1] rdbms: clean up handling of CONN_SILENCE_ERRORS in get(Lazy|Maintenance|)ConnectionRef() [core] - 10https://gerrit.wikimedia.org/r/641843 (owner: 10Aaron Schulz) [00:09:09] (03PS13) 10Paladox: Fix fetching ipblock-exempt within BlockManager#getUserBlock [core] - 10https://gerrit.wikimedia.org/r/655148 (https://phabricator.wikimedia.org/T271551) [00:14:39] (03CR) 10Reedy: [C: 03+2] Update use of css-sanitizer classes for PHP 8.0 compat [extensions/TemplateStyles] (REL1_35) - 10https://gerrit.wikimedia.org/r/655149 (https://phabricator.wikimedia.org/T268862) (owner: 10Reedy) [00:18:02] (03CR) 10Aaron Schulz: [C: 03+2] rdbms: Use PSR-3 for ChronologyProtector shutdown debug message [core] - 10https://gerrit.wikimedia.org/r/649765 (https://phabricator.wikimedia.org/T254634) (owner: 10Krinkle) [00:19:55] (03Merged) 10jenkins-bot: Update use of css-sanitizer classes for PHP 8.0 compat [extensions/TemplateStyles] (REL1_35) - 10https://gerrit.wikimedia.org/r/655149 (https://phabricator.wikimedia.org/T268862) (owner: 10Reedy) [00:23:05] (03CR) 10Aaron Schulz: parser: convert Preprocessor to WANCache and inject dependencies (031 comment) [core] - 10https://gerrit.wikimedia.org/r/587494 (https://phabricator.wikimedia.org/T254608) (owner: 10Aaron Schulz) [00:24:41] (03CR) 10Jeena Huneidi: [C: 03+2] "LGTM" [tools/cli] - 10https://gerrit.wikimedia.org/r/653810 (owner: 10Addshore) [00:25:15] (03Merged) 10jenkins-bot: Move MediaWiki related code to internal/mediawiki [tools/cli] - 10https://gerrit.wikimedia.org/r/653810 (owner: 10Addshore) [00:25:57] 10MediaWiki-User-login-and-signup, 10MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), 10Platform Team Workboards (External Code Reviews), 10Security, 10good first task: MediaWiki user and password fields should have the proper autocomplete value - https://phabricator.wikimedia.org/T263927 (10Tgr) I'd like to t... [00:26:01] (03CR) 10Aaron Schulz: [C: 04-1] Stop setting CURLMOPT_PIPELINING on curl >= 7.62.0 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/644640 (https://phabricator.wikimedia.org/T264735) (owner: 10Reedy) [00:31:20] 10MediaWiki-extensions-OAuth, 10API-Portal: Add owner-only flag to list clients endpoint - https://phabricator.wikimedia.org/T271597 (10apaskulin) [00:34:34] 10TemplateStyles, 10css-sanitizer: Allow use of scroll-margin-top in TemplateStyles - https://phabricator.wikimedia.org/T271598 (10Krinkle) [00:37:53] (03CR) 10jerkins-bot: [V: 04-1] Fix fetching ipblock-exempt within BlockManager#getUserBlock [core] - 10https://gerrit.wikimedia.org/r/655148 (https://phabricator.wikimedia.org/T271551) (owner: 10Paladox) [00:38:02] 10DiscussionTools, 10TemplateStyles: Add .mw-parser-output as a potential selector - https://phabricator.wikimedia.org/T271588 (10Tgr) Yeah, TemplateStyles forces selecting something inside the parser output, not the parser output wrapper itself. Changing that doesn't seem dangerous (although custom user page... [00:41:55] (03Merged) 10jenkins-bot: rdbms: Use PSR-3 for ChronologyProtector shutdown debug message [core] - 10https://gerrit.wikimedia.org/r/649765 (https://phabricator.wikimedia.org/T254634) (owner: 10Krinkle) [00:48:38] 10TemplateStyles, 10css-sanitizer: Allow use of scroll-margin-top in TemplateStyles - https://phabricator.wikimedia.org/T271598 (10Tgr) [00:48:40] 10TemplateStyles, 10css-sanitizer, 10Tracking-Neverending: Support more CSS properties / rules in css-sanitizer - https://phabricator.wikimedia.org/T269044 (10Tgr) [00:50:35] 10MediaWiki-Watchlist, 10Expiring-Watchlist-Items, 10Growth-Team, 10Community-Tech (Kanban-2020-21-Q2), and 5 others: Problem with creating a page in the Meta: ExpiryDef: Invalid expiry value - https://phabricator.wikimedia.org/T267611 (10ifried) 05Open→03Resolved This change has been on production for... [00:51:39] 04(no projects): data request: For FastCo - https://phabricator.wikimedia.org/T271600 (10Cdesoto705) [00:51:49] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10MW-1.36-notes (1.36.0-wmf.26; 2021-01-12): Comment lost when attempting to publish to a closed conversation - https://phabricator.wikimedia.org/T268069 (10ppelberg) >>! In T268069#6729370, @matmarex wrote: > I've changed the proposed error message... [00:52:06] 04(no projects): data request: For FastCo - https://phabricator.wikimedia.org/T271600 (10SNowick_WMF) a:03SNowick_WMF [00:53:21] 10Wikisource Export, 10Community-Tech (Kanban-2020-21-Q2): Unable to create Mobi of plwikisource:Dziady część III/Scena V - https://phabricator.wikimedia.org/T268005 (10ifried) 05Open→03Resolved I have also tested http://wsexport.wmflabs.org/tool/book.php?format=mobi&lang=pl&page=Dziady%20cz%C4%99%C5%9B%C4... [00:53:55] 04(no projects): Axios data request: 2001-2021 - https://phabricator.wikimedia.org/T271601 (10Cdesoto705) [00:58:16] 10Growth-Structured-Tasks, 10Growth-Team (Current Sprint): Add a link engineering: update search index on page edit - https://phabricator.wikimedia.org/T261409 (10Tgr) [00:58:47] 10Growth-Structured-Tasks, 10Growth-Team (Current Sprint): Add a link engineering: update search index on page edit - https://phabricator.wikimedia.org/T261409 (10Tgr) This is blocked on Search work, but that is very nearly done now, I think. [00:59:46] (03PS1) 10Alex Paskulin: rest: Add owner-only flag to list clients endpoint [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/655180 (https://phabricator.wikimedia.org/T271597) [01:01:47] (03PS14) 10Paladox: Fix fetching ipblock-exempt within BlockManager#getUserBlock [core] - 10https://gerrit.wikimedia.org/r/655148 (https://phabricator.wikimedia.org/T271551) [01:02:40] (03PS15) 10Paladox: Fix fetching ipblock-exempt within BlockManager#getUserBlock [core] - 10https://gerrit.wikimedia.org/r/655148 (https://phabricator.wikimedia.org/T271551) [01:03:51] 10MediaWiki-extensions-GlobalWatchlist, 10Wikimedia-Extension-setup, 10User-DannyS712, 10User-notice, 10Wikimedia-extension-review-queue: Deploy GlobalWatchlist extension to production (Meta only) - https://phabricator.wikimedia.org/T260862 (10DannyS712) [01:05:16] 10Growth-Structured-Tasks, 10Growth-Team (Current Sprint), 10MW-1.36-notes (1.36.0-wmf.26; 2021-01-12): Add a link engineering: Maintenance script for retrieving, caching, and updating search index - https://phabricator.wikimedia.org/T261408 (10Tgr) The main work is done. We'll need to create a cronjob for t... [01:05:59] (03PS16) 10Paladox: Fix fetching ipblock-exempt within BlockManager#getUserBlock [core] - 10https://gerrit.wikimedia.org/r/655148 (https://phabricator.wikimedia.org/T271551) [01:08:19] 10MediaWiki-Codesniffer, 10Release, 10User-DannyS712: Release mediawiki-codesniffer v35.0.0 - https://phabricator.wikimedia.org/T271392 (10DannyS712) [01:09:36] (03PS17) 10Paladox: Fix fetching ipblock-exempt within BlockManager#getUserBlock [core] - 10https://gerrit.wikimedia.org/r/655148 (https://phabricator.wikimedia.org/T271551) [01:09:37] 10MediaWiki-Codesniffer, 10Release, 10User-DannyS712: Release mediawiki-codesniffer v35.0.0 - https://phabricator.wikimedia.org/T271392 (10DannyS712) [01:09:46] 10MediaWiki-Codesniffer, 10Release, 10User-DannyS712: Release mediawiki-codesniffer v35.0.0 - https://phabricator.wikimedia.org/T271392 (10DannyS712) [01:12:36] 10MediaWiki-Codesniffer, 10Release, 10User-DannyS712: Release mediawiki-codesniffer v35.0.0 - https://phabricator.wikimedia.org/T271392 (10DannyS712) >>! In T271392#6729157, @Jdforrester-WMF wrote: > Seems reasonable to me. I'd like to also get in: > * https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesni... [01:14:38] 10MediaWiki-Codesniffer, 10Release, 10User-DannyS712: Release mediawiki-codesniffer v35.0.0 - https://phabricator.wikimedia.org/T271392 (10DannyS712) [01:15:21] 10MediaWiki-Codesniffer, 10Release, 10User-DannyS712: Release mediawiki-codesniffer v35.0.0 - https://phabricator.wikimedia.org/T271392 (10DannyS712) [01:15:49] 10MediaWiki-Codesniffer: phpcs ObjectTypeHintParam is incorrect. - https://phabricator.wikimedia.org/T269332 (10DannyS712) 05Open→03Resolved a:03thiemowmde [01:23:01] (03PS3) 10DannyS712: Revert "Fix infinite recursion with wgAutopromote when using getBlock within checkCondition" [core] - 10https://gerrit.wikimedia.org/r/654865 (https://phabricator.wikimedia.org/T270145) [01:23:20] (03PS4) 10DannyS712: Revert "Fix infinite recursion with wgAutopromote when using getBlock within checkCondition" [core] - 10https://gerrit.wikimedia.org/r/654865 (https://phabricator.wikimedia.org/T270145) [01:31:15] 10Growth-Team (Current Sprint), 10MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), 10Regression: [wmf.22-regression] Welcome survey lang question not displayed - https://phabricator.wikimedia.org/T270519 (10Etonkovidova) The fix works in betalabs. [01:32:39] (03CR) 10Paladox: Fix fetching ipblock-exempt within BlockManager#getUserBlock (031 comment) [core] - 10https://gerrit.wikimedia.org/r/655148 (https://phabricator.wikimedia.org/T271551) (owner: 10Paladox) [01:32:42] (03CR) 10DannyS712: "> Patch Set 2:" [core] - 10https://gerrit.wikimedia.org/r/654865 (https://phabricator.wikimedia.org/T270145) (owner: 10DannyS712) [01:44:46] (03PS18) 10Paladox: Fix fetching ipblock-exempt within BlockManager#getUserBlock [core] - 10https://gerrit.wikimedia.org/r/655148 (https://phabricator.wikimedia.org/T271551) [01:45:35] (03PS19) 10Paladox: Fix fetching ipblock-exempt within BlockManager#getUserBlock [core] - 10https://gerrit.wikimedia.org/r/655148 (https://phabricator.wikimedia.org/T271551) [01:46:00] (03PS20) 10Paladox: Fix fetching ipblock-exempt within BlockManager#getUserBlock [core] - 10https://gerrit.wikimedia.org/r/655148 (https://phabricator.wikimedia.org/T271551) [01:46:45] (03CR) 10jerkins-bot: [V: 04-1] Revert "Fix infinite recursion with wgAutopromote when using getBlock within checkCondition" [core] - 10https://gerrit.wikimedia.org/r/654865 (https://phabricator.wikimedia.org/T270145) (owner: 10DannyS712) [01:59:10] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Airline Passenger Experience, 10MW-1.36-notes (1.36.0-wmf.26; 2021-01-12), 10Patch-For-Review: Code review, fix major and minor issues, follow up on new requirements, write tests an... - https://phabricator.wikimedia.org/T268646 [01:59:47] (03CR) 10Paladox: "Seems like the tests fails exactly the same on my change. So looks like we cannot use this test (needs fixing)." [core] - 10https://gerrit.wikimedia.org/r/654865 (https://phabricator.wikimedia.org/T270145) (owner: 10DannyS712) [02:00:06] (03CR) 10Paladox: "Seems like the tests fails exactly the same on my change. So looks like we cannot use this test (needs fixing)." [core] - 10https://gerrit.wikimedia.org/r/655147 (https://phabricator.wikimedia.org/T271551) (owner: 10DannyS712) [02:02:27] 10SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), 10Structured-Data-Backlog (Current Work): [XS] Media Search: Update border color on video tab - https://phabricator.wikimedia.org/T260729 (10Etonkovidova) 05Open→03Resolved [02:02:32] (03PS41) 10Cicalese: Code clean up. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/652576 [02:02:33] 10DiscussionTools, 10TemplateStyles: Add .mw-parser-output as a potential selector - https://phabricator.wikimedia.org/T271588 (10Izno) >>! In T271588#6733143, @Tgr wrote: > Yeah, TemplateStyles forces selecting something inside the parser output, not the parser output wrapper itself. Changing that doesn't see... [02:07:39] 10Timeless: Table moves downwards on viewport size changes - https://phabricator.wikimedia.org/T271501 (10Izno) 05duplicate→03Open Never mind little ol me then [02:08:58] (03CR) 10jerkins-bot: [V: 04-1] Fix fetching ipblock-exempt within BlockManager#getUserBlock [core] - 10https://gerrit.wikimedia.org/r/655148 (https://phabricator.wikimedia.org/T271551) (owner: 10Paladox) [02:09:41] 10DiscussionTools, 10Editing-team (Tracking): Add support for voting-style discussions - https://phabricator.wikimedia.org/T259865 (10ppelberg) The comments people are posting at en.wiki [i] about the potential of reinstating the `{{Support}}` and `{{Oppose}}` templates will likely be helpful to consider when... [02:10:00] 10DiscussionTools, 10Editing-team (Tracking): Add support for voting-style discussions - https://phabricator.wikimedia.org/T259865 (10ppelberg) [02:37:19] 10DiscussionTools, 10TemplateStyles, 10good first task: Add .mw-parser-output as a potential selector - https://phabricator.wikimedia.org/T271588 (10Tgr) The relevant code is [[https://github.com/wikimedia/css-sanitizer/blob/d0ab9c908490fae4a5f8f12009c077d6ce157bac/src/Sanitizer/StyleRuleSanitizer.php#L94-L1... [02:37:51] 10DiscussionTools, 10TemplateStyles, 10css-sanitizer, 10good first task: Add .mw-parser-output as a potential selector - https://phabricator.wikimedia.org/T271588 (10Tgr) [02:40:04] 10SDAW-MediaSearch (MediaSearch-ReleaseCandidate), 10Structured-Data-Backlog (Current Work): Support search filters in no-JS search results page - https://phabricator.wikimedia.org/T266150 (10Etonkovidova) Moving to @mwilliams for Design review (1) URL parameters work fine - JS-users and no-JS users with links... [02:50:45] (03CR) 10Samwilson: "I know this isn't going to be useful to Wikimedia wikis any more, but should we just merge this anyway as a starting point?" [extensions/Discourse] - 10https://gerrit.wikimedia.org/r/534905 (https://phabricator.wikimedia.org/T215053) (owner: 10Samwilson) [02:55:37] (03CR) 10Alex Paskulin: "This change is ready for review." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/655180 (https://phabricator.wikimedia.org/T271597) (owner: 10Alex Paskulin) [03:22:22] (03CR) 10TerraCodes: "Based on Volker's review/comment, should I change the IDs into classes? Also should I add this to the changelog or is it too minor? (or do" [core] - 10https://gerrit.wikimedia.org/r/603941 (https://phabricator.wikimedia.org/T248441) (owner: 10TerraCodes) [03:30:22] 10Add-Link, 10Growth-Structured-Tasks, 10Growth-Team (Current Sprint): Add a link: instance_occurrence should be based on plaintext, not wikitext - https://phabricator.wikimedia.org/T271604 (10Tgr) [03:31:42] (03CR) 10Jeena Huneidi: [C: 04-1] "I'm a bit confused about some things, mainly regarding the organization of code (see comments)." (035 comments) [tools/cli] - 10https://gerrit.wikimedia.org/r/653842 (owner: 10Addshore) [03:31:57] 10Add-Link, 10Growth-Structured-Tasks, 10Growth-Team (Current Sprint): Add a link: instance_occurrence should be based on plaintext, not wikitext - https://phabricator.wikimedia.org/T271604 (10Tgr) [03:32:38] (03CR) 10DannyS712: "I had some nitpicks, but they will get autofixed by LibUp and shouldn't delay the patch from being merged. LGTM but completely untested" [extensions/Discourse] - 10https://gerrit.wikimedia.org/r/534905 (https://phabricator.wikimedia.org/T215053) (owner: 10Samwilson) [03:33:25] 10MediaWiki-extensions-WikimediaApiPortalOAuth, 10API-Portal: Add content if user has no existing clients - https://phabricator.wikimedia.org/T266360 (10apaskulin) [03:37:49] (03PS6) 10DannyS712: Add a test for ipblock-exempt granted via hook [core] - 10https://gerrit.wikimedia.org/r/655147 (https://phabricator.wikimedia.org/T271551) [03:38:45] (03PS5) 10DannyS712: Revert "Fix infinite recursion with wgAutopromote when using getBlock within checkCondition" [core] - 10https://gerrit.wikimedia.org/r/654865 (https://phabricator.wikimedia.org/T270145) [03:38:54] (03PS6) 10DannyS712: Revert "Fix infinite recursion with wgAutopromote when using getBlock within checkCondition" [core] - 10https://gerrit.wikimedia.org/r/654865 (https://phabricator.wikimedia.org/T270145) [03:39:13] (03PS7) 10DannyS712: Revert "Fix infinite recursion with wgAutopromote when using getBlock within checkCondition" [core] - 10https://gerrit.wikimedia.org/r/654865 (https://phabricator.wikimedia.org/T270145) [03:39:18] 10MediaWiki-extensions-WikimediaApiPortalOAuth, 10API-Portal: Move "Create key" above client list - https://phabricator.wikimedia.org/T271605 (10apaskulin) [03:39:52] 10MediaWiki-extensions-WikimediaApiPortalOAuth, 10API-Portal: Move "Create key" above client list - https://phabricator.wikimedia.org/T271605 (10apaskulin) p:05Triage→03Medium [03:48:02] (03CR) 10Jforrester: [C: 03+1] Allow specifying `true` and `false` rather than `boolean` [libs/Assert] - 10https://gerrit.wikimedia.org/r/654864 (owner: 10DannyS712) [03:50:00] 10API-Portal: Create a proposal for organizing OAuth docs between Meta, mediawiki.org, and the API Portal - https://phabricator.wikimedia.org/T271606 (10apaskulin) [03:51:08] 10API-Portal: Clarify behavior of secret reset - https://phabricator.wikimedia.org/T271607 (10apaskulin) [03:52:39] 10MediaWiki-extensions-OAuth, 10Platform Team Initiatives (OAuth 2.0), 10good first task: Parse wikilinks in logentry-mwoauthconsumer-* - https://phabricator.wikimedia.org/T265848 (10Tgr) Searching for `ManualLogEntry` is usually a good bet. In this case it's `ConsumerSubmitControl::makeLogEntry`. See https:... [04:01:07] (03PS42) 10Cicalese: Code clean up. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/652576 [04:07:35] (03PS2) 10Jforrester: build: Upgrade phpunit to ^8.5 || ^9.5 for PHP 8.0 compatibility [libs/RemexHtml] - 10https://gerrit.wikimedia.org/r/655125 (https://phabricator.wikimedia.org/T271575) (owner: 10MaxSem) [04:07:53] (03PS7) 10DannyS712: Add a test for ipblock-exempt granted via hook [core] - 10https://gerrit.wikimedia.org/r/655147 (https://phabricator.wikimedia.org/T271551) [04:08:22] (03PS8) 10DannyS712: Revert "Fix infinite recursion with wgAutopromote when using getBlock within checkCondition" [core] - 10https://gerrit.wikimedia.org/r/654865 (https://phabricator.wikimedia.org/T270145) [04:08:25] (03PS9) 10DannyS712: Revert "Fix infinite recursion with wgAutopromote when using getBlock within checkCondition" [core] - 10https://gerrit.wikimedia.org/r/654865 (https://phabricator.wikimedia.org/T270145) [04:09:20] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phpunit to ^8.5 || ^9.5 for PHP 8.0 compatibility [libs/RemexHtml] - 10https://gerrit.wikimedia.org/r/655125 (https://phabricator.wikimedia.org/T271575) (owner: 10MaxSem) [04:10:36] 10MediaWiki-extensions-WikimediaApiPortalOAuth, 10API-Portal: Organize Special:AppManagement by client type - https://phabricator.wikimedia.org/T271608 (10apaskulin) [04:10:41] (03CR) 10Jforrester: "check experimental" [libs/RemexHtml] - 10https://gerrit.wikimedia.org/r/655125 (https://phabricator.wikimedia.org/T271575) (owner: 10MaxSem) [04:11:03] 10MediaWiki-extensions-WikimediaApiPortalOAuth, 10API-Portal: Organize Special:AppManagement by client type - https://phabricator.wikimedia.org/T271608 (10apaskulin) 05Open→03Stalled Blocked by T271597 [04:13:28] (03CR) 10Jforrester: "Of course the method exists in 9.5 so instead the clearance gets a PhanUndeclaredMethod. Oy." [libs/RemexHtml] - 10https://gerrit.wikimedia.org/r/655125 (https://phabricator.wikimedia.org/T271575) (owner: 10MaxSem) [04:14:29] 10API-Portal: Clarify behavior of secret reset - https://phabricator.wikimedia.org/T271607 (10apaskulin) p:05Triage→03High [04:14:46] 10API-Portal: Create a proposal for organizing OAuth docs between Meta, mediawiki.org, and the API Portal - https://phabricator.wikimedia.org/T271606 (10apaskulin) p:05Triage→03Medium [04:18:08] (03PS3) 10Jforrester: build: Upgrade phpunit to ^8.5 || ^9.5 for PHP 8.0 compatibility [libs/RemexHtml] - 10https://gerrit.wikimedia.org/r/655125 (https://phabricator.wikimedia.org/T271575) (owner: 10MaxSem) [04:24:35] (03CR) 10Jforrester: "check experimental" [libs/RemexHtml] - 10https://gerrit.wikimedia.org/r/655125 (https://phabricator.wikimedia.org/T271575) (owner: 10MaxSem) [04:27:05] (03CR) 10Jforrester: [C: 03+2] build: Upgrade phpunit to ^8.5 || ^9.5 for PHP 8.0 compatibility [libs/RemexHtml] - 10https://gerrit.wikimedia.org/r/655125 (https://phabricator.wikimedia.org/T271575) (owner: 10MaxSem) [04:28:52] (03Merged) 10jenkins-bot: build: Upgrade phpunit to ^8.5 || ^9.5 for PHP 8.0 compatibility [libs/RemexHtml] - 10https://gerrit.wikimedia.org/r/655125 (https://phabricator.wikimedia.org/T271575) (owner: 10MaxSem) [04:29:27] 10MediaWiki-General, 10Equivset, 10RemexHtml, 10Shellbox, and 2 others: Test (and pass) all home-grown PHP libraries for MediaWiki on PHP 8.0 - https://phabricator.wikimedia.org/T271575 (10Jdforrester-WMF) [04:30:18] (03CR) 10Jforrester: [C: 03+2] Release notes for a new version [HtmlFormatter] - 10https://gerrit.wikimedia.org/r/652002 (owner: 10MaxSem) [04:31:31] (03CR) 10Gergő Tisza: [C: 03+2] EventBus: Disable sending events during PHPUnit tests [vagrant] - 10https://gerrit.wikimedia.org/r/655124 (https://phabricator.wikimedia.org/T270801) (owner: 10Mholloway) [04:31:33] 10MediaWiki-Core-Testing, 10Analytics, 10Event-Platform, 10Patch-For-Review: Integration tests die with "HTTP requests to blocked. Use MockHttpTrait." when EventBus extension is installed - https://phabricator.wikimedia.org/T270801 (10Tgr) >>! In T270801#6711308, @Krinkle wrote: > Does this fail in C... [04:31:35] (03Merged) 10jenkins-bot: Release notes for a new version [HtmlFormatter] - 10https://gerrit.wikimedia.org/r/652002 (owner: 10MaxSem) [04:32:38] (03CR) 10jerkins-bot: [V: 04-1] Revert "Fix infinite recursion with wgAutopromote when using getBlock within checkCondition" [core] - 10https://gerrit.wikimedia.org/r/654865 (https://phabricator.wikimedia.org/T270145) (owner: 10DannyS712) [04:32:46] (03Merged) 10jenkins-bot: EventBus: Disable sending events during PHPUnit tests [vagrant] - 10https://gerrit.wikimedia.org/r/655124 (https://phabricator.wikimedia.org/T270801) (owner: 10Mholloway) [04:35:17] (03CR) 10jerkins-bot: [V: 04-1] Add a test for ipblock-exempt granted via hook [core] - 10https://gerrit.wikimedia.org/r/655147 (https://phabricator.wikimedia.org/T271551) (owner: 10DannyS712) [04:36:26] 10Timeless: Table moves downwards on viewport size changes - https://phabricator.wikimedia.org/T271501 (10Isarra) Well, I'm not sure yet... [04:38:23] 10MediaWiki-Core-Testing, 10Analytics, 10Event-Platform, 10Patch-For-Review: Integration tests die with "HTTP requests to blocked. Use MockHttpTrait." when EventBus extension is installed - https://phabricator.wikimedia.org/T270801 (10Tgr) The EventLogging extension also has the same problem, althoug... [04:42:19] 10MediaWiki-Core-Testing, 10Analytics, 10Event-Platform, 10Patch-For-Review: Integration tests die with "HTTP requests to blocked. Use MockHttpTrait." when EventBus extension is installed - https://phabricator.wikimedia.org/T270801 (10Tgr) Looking at the EventLogging Vagrant config, it doesn't look l... [04:48:28] (03PS8) 10DannyS712: Add a test for ipblock-exempt granted via hook [core] - 10https://gerrit.wikimedia.org/r/655147 (https://phabricator.wikimedia.org/T271551) [04:48:40] (03PS10) 10DannyS712: Revert "Fix infinite recursion with wgAutopromote when using getBlock within checkCondition" [core] - 10https://gerrit.wikimedia.org/r/654865 (https://phabricator.wikimedia.org/T270145) [05:01:50] 10Library-Card-Platform, 10good first task: Reword text on Mark as Sent page for access codes - https://phabricator.wikimedia.org/T271192 (10Bharatkhatri351) {F33991353} please help during docker-compose build i am getting this error again again. I tried 2 to 3 times to build but always getting this error and... [05:15:30] (03CR) 10Jack Phoenix: [C: 03+2] migrate wft_closed to wft_closed_timestamp and fix datatype [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/651713 (https://phabricator.wikimedia.org/T270815) (owner: 10Universal Omega) [05:17:27] (03CR) 10Jack Phoenix: [C: 03+2] "Awesome, thank you! 😊" [skins/Gamepress] - 10https://gerrit.wikimedia.org/r/639884 (https://phabricator.wikimedia.org/T266735) (owner: 10Jdlrobson) [05:20:10] (03CR) 10Jack Phoenix: [C: 03+2] "Being '''bold''' here and self+2'ing this." [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/640072 (https://phabricator.wikimedia.org/T266864) (owner: 10Jack Phoenix) [05:27:22] 10MediaWiki-Search, 10Discovery-Search: Searches with hyphens yield a database query error - https://phabricator.wikimedia.org/T221560 (10Universal_Omega) a:05Universal_Omega→03None Can't seem to figure it out. Hopefully someone else can. [05:29:28] (03Merged) 10jenkins-bot: migrate wft_closed to wft_closed_timestamp and fix datatype [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/651713 (https://phabricator.wikimedia.org/T270815) (owner: 10Universal Omega) [05:29:30] (03Merged) 10jenkins-bot: Upgrade SkinGamepress to take advantage of new skin capabilities [skins/Gamepress] - 10https://gerrit.wikimedia.org/r/639884 (https://phabricator.wikimedia.org/T266735) (owner: 10Jdlrobson) [05:29:32] (03Merged) 10jenkins-bot: Ensure that we output valid UTF-8 instead of mojibake [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/640072 (https://phabricator.wikimedia.org/T266864) (owner: 10Jack Phoenix) [05:30:44] 10MediaWiki-extensions-RandomImage, 10User-RhinosF1: randomimage does not output the same characters it reads - https://phabricator.wikimedia.org/T266864 (10ashley) 05Open→03Resolved a:03ashley [05:30:47] 10MediaWiki-extensions-RandomImage, 10User-RhinosF1: Broken encoding of non-ASCII characters - https://phabricator.wikimedia.org/T266382 (10ashley) [05:31:55] (03PS43) 10Cicalese: Code clean up. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/652576 [05:37:16] 10MediaWiki-extensions-MediaWikiAuth: Imports aren't working (mwa-authfail error message shown without further debug info) - https://phabricator.wikimedia.org/T271258 (10Dinoguy1000) >>! In T271258#6725008, @Aklapper wrote: > 1.33 is an old unsupported insecure version. > https://yugipedia.com/wiki/Special:Versi... [05:43:31] 10ContentTranslation, 10Timeless: No gray referral link to Content translation in "Timeless" skin - https://phabricator.wikimedia.org/T271611 (10YFdyh000) [06:14:18] 10MediaWiki-Core-Skin-Architecture, 10MediaWiki-Interface, 10MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), 10Patch-For-Review: Split the `legacy` feature on ResourceLoaderSkinModule into non-legacy manageable and reusable parts - https://phabricator.wikimedia.org/T89981 (10Isarra) I'm... confused. As far as... [06:23:00] 10MediaWiki-extensions-OAuth, 10Platform Team Initiatives (OAuth 2.0), 10good first task: Parse wikilinks in logentry-mwoauthconsumer-* - https://phabricator.wikimedia.org/T265848 (10Shubham656jain) So, I have to make a new function called `makePageLink` in `ConsumerSubmitControl` class like it's done in the... [06:27:00] 10Chinese-Sites: New namespace for WikiProject on zh.wikipedia - https://phabricator.wikimedia.org/T271612 (10A2569875) [06:31:09] 10Wikimedia-Site-requests, 10Chinese-Sites: New namespace for WikiProject on zh.wikipedia - https://phabricator.wikimedia.org/T271612 (10A2569875) [06:33:12] (03PS44) 10Cicalese: Code clean up. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/652576 [06:48:54] 10MediaWiki-extensions-OAuth, 10Platform Team Initiatives (OAuth 2.0), 10good first task: Parse wikilinks in logentry-mwoauthconsumer-* - https://phabricator.wikimedia.org/T265848 (10Tgr) No, you'd have to make a custom LogFormatter subclass like TranslateLogFormatter does, and configure the extension to use... [07:17:49] 10Desktop Improvements, 10MonoBook, 10Regression: Normalize styles in Monobook are coming after the main Monobook styles (
is being hidden [and then shown sometimes]) - https://phabricator.wikimedia.org/T271482 (10Ammarpad) > For some reason,
, the wikitext four-bar line, seems to being hidden in Jav... [07:18:34] (03CR) 10Ammarpad: [C: 03+1] "There's still a noticeable flash which happens only on MonoBook if one refreshes the page, I don't think it's caused by this though. T2714" [core] - 10https://gerrit.wikimedia.org/r/655131 (https://phabricator.wikimedia.org/T269618) (owner: 10Jdlrobson) [08:40:17] (03CR) 10Addshore: "Thanks for the comments, I'm going to go and change a few things." (035 comments) [tools/cli] - 10https://gerrit.wikimedia.org/r/653842 (owner: 10Addshore) [08:45:40] (03CR) 10Addshore: Refactor internal mediawiki code to a type (031 comment) [tools/cli] - 10https://gerrit.wikimedia.org/r/653842 (owner: 10Addshore) [08:49:35] (03PS7) 10Addshore: Refactor internal mediawiki code to a type [tools/cli] - 10https://gerrit.wikimedia.org/r/653842 [08:51:10] 10SyntaxHighlight: Code gets copied double-spaced on new syntax-highlighted pages on Firefox - https://phabricator.wikimedia.org/T271614 (10Nardog) [08:52:58] (03PS4) 10Ammarpad: Use index remapping instead of full query for in-progress index rename [core] - 10https://gerrit.wikimedia.org/r/654976 (https://phabricator.wikimedia.org/T271506) [09:03:11] (03PS3) 10Addshore: Name cmd files and var with some consistency [tools/cli] - 10https://gerrit.wikimedia.org/r/654935 [09:06:32] (03PS3) 10Addshore: Move Verbose mode vars to root.go as they are "global" [tools/cli] - 10https://gerrit.wikimedia.org/r/654936 [09:06:34] (03PS3) 10Addshore: Refactor docker env to allow use by other commands [tools/cli] - 10https://gerrit.wikimedia.org/r/654938 [09:41:36] 10Dependency injection, 10Platform Team Workboards (MW Expedition): Replace specific PermissionManager calls with GroupPermissionsLookup calls in all deployed extensions - https://phabricator.wikimedia.org/T271593 (10daniel) Note that we are about to go full circle pn User::isAllowed with T231930 [09:52:05] 10MediaWiki-extensions-DoubleWiki, 10CSS, 10good first task: Replace inline CSS style attributes with a proper CSS module in DoubleWiki - https://phabricator.wikimedia.org/T252524 (10Prernaswarna) I appreciate that. Thank you! [09:56:55] (03CR) 10Daniel Kinzler: [C: 03+1] "Quite a can of nasty little worms you found there!" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/654966 (owner: 10Tim Starling) [09:58:18] 10Dumps-Generation, 10Pageviews-Anomaly, 10Wikimedia-production-error: Hourly pageviews stop working after the last pageviews-20210106-140000.gz - https://phabricator.wikimedia.org/T271521 (10ArielGlenn) See T271362 most likely. [10:09:55] 10Dumps-Generation, 10Pageviews-Anomaly, 10Wikimedia-production-error: Hourly pageviews stop working after the last pageviews-20210106-140000.gz - https://phabricator.wikimedia.org/T271521 (10elukey) Hi @Mascia.mauro, thanks a lot for reporting, the issue should be fixed. Can you recheck? [10:30:13] 10MediaWiki-extensions-DrawioEditor: Tag support for DrawIO Extension should support the Extension Tag - https://phabricator.wikimedia.org/T271615 (10Lucienmp) [10:30:53] 10MediaWiki-extensions-DrawioEditor: DrawIO Extension should support the Extension Tag - https://phabricator.wikimedia.org/T271615 (10Lucienmp) [10:36:45] 10Product-Analytics: data request: For FastCo - https://phabricator.wikimedia.org/T271600 (10Aklapper) Assuming this is about #Product-Analytics, thus adding projcet tag. This will allow others to get notified, or see this task when searching via projects. [10:36:56] 10Product-Analytics: Axios data request: 2001-2021 - https://phabricator.wikimedia.org/T271601 (10Aklapper) Assuming this is about #Product-Analytics, thus adding projcet tag. This will allow others to get notified, or see this task when searching via projects. [11:03:48] (03PS1) 10Umherirrender: Improve some function documentation in tests [core] - 10https://gerrit.wikimedia.org/r/655189 [11:04:56] (03PS2) 10Umherirrender: Improve some function documentation in tests [core] - 10https://gerrit.wikimedia.org/r/655189 [11:21:24] (03PS2) 10Prernaswarna: Change font and line height Pagelist description [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/652395 (https://phabricator.wikimedia.org/T232229) [11:26:29] (03PS6) 10Daimona Eaytoy: Refactor VariableGenerator and LazyVariableComputer tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/655107 [11:34:21] 10MediaWiki-extensions-DrawioEditor: DrawIO Extension should support the Extension Tag - https://phabricator.wikimedia.org/T271615 (10Lucienmp) I have a patch, I am just working out how to submit it as this is my first time working with Phabricator / Gerrit [11:53:17] (03CR) 10DannyS712: Enhance GroupPermissionsLookup and use it. (033 comments) [core] - 10https://gerrit.wikimedia.org/r/654931 (https://phabricator.wikimedia.org/T254537) (owner: 10Ppchelko) [12:10:58] 04(no projects): Viewing Vincent Crawford article on English wikipedia returns internal error - https://phabricator.wikimedia.org/T271618 (10Caius_G) [12:14:57] 10MediaWiki-Logevents, 10MediaWiki-Revision-deletion, 10AbuseFilter, 10Patch-For-Review: Don't allow revdel/suppression on Special:Log/abusefilterprivatedetails - https://phabricator.wikimedia.org/T187865 (10MarcoAurelio) I assume this is blocked on https://gerrit.wikimedia.org/r/c/mediawiki/core/+/445999.... [12:31:43] 10Timeless: Table moves downwards on viewport size changes - https://phabricator.wikimedia.org/T271501 (101997kB) I think it's more clearly visible at https://meta.wikimedia.org/wiki/Discord [12:34:28] (03PS1) 10Shirayuki: DefaultSettings: Improve custom folding and grouping [core] - 10https://gerrit.wikimedia.org/r/655192 (https://phabricator.wikimedia.org/T271365) [12:40:22] (03PS2) 10Shirayuki: DefaultSettings: Improve custom folding and grouping [core] - 10https://gerrit.wikimedia.org/r/655192 (https://phabricator.wikimedia.org/T271365) [13:00:09] (03PS1) 10Lucien Murray-Pitts: Amaing patch that allows time travel [sandbox] - 10https://gerrit.wikimedia.org/r/655194 [13:28:23] (03CR) 10Matěj Suchánek: [C: 03+2] Add pure unit tests for FilterRunner [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/654634 (owner: 10Daimona Eaytoy) [13:30:38] 10Indic-TechCom, 10Wikimedia-Site-requests: Add User Groups to mrwikisource, enable admins to add/remove these groups. - https://phabricator.wikimedia.org/T269067 (10Sureshkhole) a:05Jay-A2K→03None [13:31:00] 10MediaWiki-Core-Hooks, 10MediaWiki-Core-Testing, 10Platform Team Initiatives (New Hook System): Make HookRunnerTest usable in extension tests - https://phabricator.wikimedia.org/T271620 (10Daimona) [13:31:11] 10MediaWiki-Core-Hooks, 10MediaWiki-Core-Testing, 10Platform Engineering, 10Platform Team Initiatives (New Hook System): Make HookRunnerTest usable in extension tests - https://phabricator.wikimedia.org/T271620 (10Daimona) [13:35:11] 10MediaWiki-Core-Hooks, 10MediaWiki-Core-Testing, 10Platform Engineering, 10Platform Team Initiatives (New Hook System): Make HookRunnerTest usable in extension tests - https://phabricator.wikimedia.org/T271620 (10Daimona) FTR, the other important things to do are: - Marking the new abstract class as @sta... [13:41:18] (03PS1) 10Daimona Eaytoy: Improve coverage for hooks [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/655196 [13:41:59] (03CR) 10Ladsgroup: "I'm not sure about the purpose of this patch. Yes, having one less query is better but this is temporary and it haven't caused issues. I d" [core] - 10https://gerrit.wikimedia.org/r/654976 (https://phabricator.wikimedia.org/T271506) (owner: 10Ammarpad) [13:43:01] (03CR) 10Ladsgroup: [C: 04-1] "check postgres" [core] - 10https://gerrit.wikimedia.org/r/651680 (https://phabricator.wikimedia.org/T230428) (owner: 10Ladsgroup) [13:52:11] (03PS1) 10Daimona Eaytoy: Add HookRunnerTestBase for use by extensions [core] - 10https://gerrit.wikimedia.org/r/655197 (https://phabricator.wikimedia.org/T271620) [13:52:26] 10MediaWiki-Core-Hooks, 10MediaWiki-Core-Testing, 10Platform Engineering, 10Patch-For-Review, 10Platform Team Initiatives (New Hook System): Make HookRunnerTest usable in extension tests - https://phabricator.wikimedia.org/T271620 (10Daimona) a:03Daimona [13:53:10] (03PS2) 10Daimona Eaytoy: Add HookRunnerTestBase for use by extensions [core] - 10https://gerrit.wikimedia.org/r/655197 (https://phabricator.wikimedia.org/T271620) [13:53:58] (03PS2) 10Daimona Eaytoy: Improve coverage for hooks [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/655196 [13:55:02] 10AbuseFilter: Split FilterRunner - https://phabricator.wikimedia.org/T271520 (10Daimona) @matej_suchanek Have you already written some code, or may I write and push a POC on gerrit? [13:56:25] (03Merged) 10jenkins-bot: Add pure unit tests for FilterRunner [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/654634 (owner: 10Daimona Eaytoy) [13:58:18] (03PS3) 10Daimona Eaytoy: Add HookRunnerTestBase for use by extensions [core] - 10https://gerrit.wikimedia.org/r/655197 (https://phabricator.wikimedia.org/T271620) [14:03:37] (03PS1) 10Ladsgroup: Add missing PG indexes of ipblocks [core] - 10https://gerrit.wikimedia.org/r/655198 (https://phabricator.wikimedia.org/T230428) [14:05:26] (03PS4) 10Daimona Eaytoy: Add HookRunnerTestBase for use by extensions [core] - 10https://gerrit.wikimedia.org/r/655197 (https://phabricator.wikimedia.org/T271620) [14:06:02] (03CR) 10Ladsgroup: "check postgres" [core] - 10https://gerrit.wikimedia.org/r/655198 (https://phabricator.wikimedia.org/T230428) (owner: 10Ladsgroup) [14:07:51] 10WMIT-Infrastructure: Release the Wikimedia Italy website theme! - https://phabricator.wikimedia.org/T271622 (10Ferdi2005) [14:10:26] 10WMIT-Infrastructure: Release the Wikimedia Italy website theme! - https://phabricator.wikimedia.org/T271622 (10valerio.bozzolan) [14:27:13] (03PS5) 10Ladsgroup: Migrate text table to abstract schema [core] - 10https://gerrit.wikimedia.org/r/651680 (https://phabricator.wikimedia.org/T230428) [14:29:20] (03PS6) 10Ladsgroup: Migrate text table to abstract schema [core] - 10https://gerrit.wikimedia.org/r/651680 (https://phabricator.wikimedia.org/T230428) [14:34:11] 10AbuseFilter: Split FilterRunner - https://phabricator.wikimedia.org/T271520 (10matej_suchanek) Well, I had some dirty untested stuff before I created the task, but don't have time to rebase it now. Feel free to go ahead. [14:34:49] (03CR) 10Ladsgroup: "check postgres" [core] - 10https://gerrit.wikimedia.org/r/651680 (https://phabricator.wikimedia.org/T230428) (owner: 10Ladsgroup) [14:54:06] 10MediaWiki-Logevents, 10Platform Engineering, 10Dependency injection, 10Patch-For-Review, 10User-DannyS712: Add a factory service for `ManualLogEntry` objects - https://phabricator.wikimedia.org/T253717 (10Daimona) >>! In T253717#6174972, @Pchelolo wrote: > Actually, after a bit of more thinking, I wond... [15:00:28] 10MediaWiki-Core-Testing, 10MediaWiki-extensions-General: Make HookRunnerTest accessible for extensions - https://phabricator.wikimedia.org/T271042 (10Mainframe98) [15:01:05] 10MediaWiki-Core-Hooks, 10MediaWiki-Core-Testing, 10Platform Engineering, 10Patch-For-Review, 10Platform Team Initiatives (New Hook System): Make HookRunnerTest usable in extension tests - https://phabricator.wikimedia.org/T271620 (10Mainframe98) [15:01:22] 10MediaWiki-Blocks, 10Anti-Harassment: Use UserIdentity rather than User in block-related classes - https://phabricator.wikimedia.org/T266409 (10Daimona) [15:01:47] 10MediaWiki-Blocks, 10Anti-Harassment: Use UserIdentity rather than User in block-related classes - https://phabricator.wikimedia.org/T266409 (10Daimona) [15:01:49] 10MediaWiki-Blocks: Move block-related methods on User to the BlockManager - https://phabricator.wikimedia.org/T221067 (10Daimona) [15:04:14] 10MediaWiki-Core-Testing, 10MediaWiki-extensions-General: Make HookRunnerTest accessible for extensions - https://phabricator.wikimedia.org/T271042 (10Daimona) (Sorry, I didn't check if a task already existed) [15:04:16] 10MediaWiki-extensions-General, 10Platform Engineering, 10Epic, 10Platform Team Initiatives (New Hook System), 10User-DannyS712: [EPIC] Update extensions that run hooks to use the new HookContainer/HookRunner system - https://phabricator.wikimedia.org/T254670 (10Daimona) [15:04:18] 10MediaWiki-Core-Hooks, 10MediaWiki-Core-Testing, 10Platform Engineering, 10Patch-For-Review, 10Platform Team Initiatives (New Hook System): Make HookRunnerTest usable in extension tests - https://phabricator.wikimedia.org/T271620 (10Daimona) [15:04:22] (03PS7) 10Ladsgroup: Migrate text table to abstract schema [core] - 10https://gerrit.wikimedia.org/r/651680 (https://phabricator.wikimedia.org/T230428) [15:06:00] (03CR) 10Ladsgroup: "check postgres" [core] - 10https://gerrit.wikimedia.org/r/651680 (https://phabricator.wikimedia.org/T230428) (owner: 10Ladsgroup) [15:08:09] (03PS8) 10Ladsgroup: Migrate text table to abstract schema [core] - 10https://gerrit.wikimedia.org/r/651680 (https://phabricator.wikimedia.org/T230428) [15:09:53] (03CR) 10Ladsgroup: "check postgres" [core] - 10https://gerrit.wikimedia.org/r/651680 (https://phabricator.wikimedia.org/T230428) (owner: 10Ladsgroup) [15:31:59] (03CR) 10Daimona Eaytoy: Introduce DatabaseBlockFactory for getting blocks (032 comments) [core] - 10https://gerrit.wikimedia.org/r/605614 (https://phabricator.wikimedia.org/T255433) (owner: 10Tchanders) [15:33:30] (03PS3) 10Ladsgroup: Fail update if hitcounter exists [core] - 10https://gerrit.wikimedia.org/r/648576 (https://phabricator.wikimedia.org/T259771) [15:33:38] (03CR) 10Ladsgroup: [C: 04-2] "> Patch Set 2:" [core] - 10https://gerrit.wikimedia.org/r/648576 (https://phabricator.wikimedia.org/T259771) (owner: 10Ladsgroup) [15:34:12] (03CR) 10Bartosz Dziewoński: [C: 03+2] Load site config data in CommentFormatter tests [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/655138 (owner: 10Esanders) [15:38:58] (03PS45) 10Cicalese: Code clean up. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/652576 [15:39:52] (03Merged) 10jenkins-bot: Load site config data in CommentFormatter tests [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/655138 (owner: 10Esanders) [15:41:47] 10Product-Analytics: Help develop user retention framework - https://phabricator.wikimedia.org/T235327 (10nshahquinn-wmf) Maybe? 😆 [15:42:34] (03CR) 10jerkins-bot: [V: 04-1] Code clean up. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/652576 (owner: 10Cicalese) [15:42:42] 10Product-Analytics: Develop a framework for measuring user retention - https://phabricator.wikimedia.org/T201501 (10nshahquinn-wmf) We //may// be picking this us again soon-ish. [15:44:41] 10DiscussionTools, 10Editing QA, 10Browser-Support-Firefox, 10Editing-team (FY2020-21 Kanban Board), 10MW-1.36-notes (1.36.0-wmf.26; 2021-01-12): The reply tool source mode jumps back and forth in Firefox 82.0.2 - https://phabricator.wikimedia.org/T267609 (10matmarex) [15:50:46] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10MW-1.36-notes (1.36.0-wmf.26; 2021-01-12): Comment lost when attempting to publish to a closed conversation - https://phabricator.wikimedia.org/T268069 (10matmarex) They might lose their drafted comment, because the reply widget will probably refu... [15:53:41] (03PS21) 10Paladox: Fix fetching ipblock-exempt within BlockManager#getUserBlock [core] - 10https://gerrit.wikimedia.org/r/655148 (https://phabricator.wikimedia.org/T271551) [15:53:45] (03PS22) 10Paladox: Fix fetching ipblock-exempt within BlockManager#getUserBlock [core] - 10https://gerrit.wikimedia.org/r/655148 (https://phabricator.wikimedia.org/T271551) [15:54:04] (03PS23) 10Paladox: Fix fetching ipblock-exempt within BlockManager#getUserBlock [core] - 10https://gerrit.wikimedia.org/r/655148 (https://phabricator.wikimedia.org/T271551) [15:54:21] 10CX-analytics, 10CX-boost, 10Language-analytics, 10Product-Analytics: Transform finalized Content Translation schema into Event Platform format - https://phabricator.wikimedia.org/T254891 (10nshahquinn-wmf) It seems like the engineering review (T269144) will take some more time, and in any case the schema... [15:54:33] 10MediaWiki-Interwiki, 10Wikidata, 10Wikidata-Campsite, 10Wikisource: Interwiki links to/from Multilingual Wikisource - https://phabricator.wikimedia.org/T138332 (10Lydia_Pintscher) [15:55:10] 10MediaWiki-Interwiki, 10Wikidata, 10Wikidata-Campsite, 10Wikisource: Interwiki links to/from Multilingual Wikisource - https://phabricator.wikimedia.org/T138332 (10Lydia_Pintscher) Ok let's go for this then. [15:58:37] 10MediaWiki-Core-Skin-Architecture, 10MediaWiki-ResourceLoader, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), 10Patch-For-Review, and 2 others: Order of ResourceLoaderSkinModule should be consistent across skins - https://phabricator.wikimedia.org/T269618 (10Marc) The invisible hr element is also [reported]... [16:13:02] 10DiscussionTools, 10TemplateStyles, 10css-sanitizer, 10good first task: Add .mw-parser-output as a potential selector - https://phabricator.wikimedia.org/T271588 (10matmarex) From DiscussionTools' perspective, the problem isn't the unclosed
, but rather the fact that it comes from a transcluded page,... [16:18:00] (03PS46) 10Cicalese: Code clean up. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/652576 [16:22:14] (03CR) 10jerkins-bot: [V: 04-1] Code clean up. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/652576 (owner: 10Cicalese) [16:31:59] (03PS47) 10Cicalese: Code clean up. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/652576 [16:34:41] (03PS24) 10Paladox: Fix fetching ipblock-exempt within BlockManager#getUserBlock [core] - 10https://gerrit.wikimedia.org/r/655148 (https://phabricator.wikimedia.org/T271551) [16:36:47] (03PS1) 10Umherirrender: Avoid assignment in conditions [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/655201 [16:41:22] (03PS1) 10Umherirrender: Use foreach to loop a database result set [extensions/ChangeAuthor] - 10https://gerrit.wikimedia.org/r/655202 [16:56:43] 10CommRel-Specialists-Support (Oct-Dec-2020), 10affects-Kiwix-and-openZIM: Communicate transition of Graph/Graphoid to client-side only JavaScript feature - https://phabricator.wikimedia.org/T236892 (10Jseddon) 05Open→03Resolved [16:57:33] (03CR) 10jerkins-bot: [V: 04-1] Fix fetching ipblock-exempt within BlockManager#getUserBlock [core] - 10https://gerrit.wikimedia.org/r/655148 (https://phabricator.wikimedia.org/T271551) (owner: 10Paladox) [16:58:44] (03PS25) 10Paladox: Fix fetching ipblock-exempt within BlockManager#getUserBlock [core] - 10https://gerrit.wikimedia.org/r/655148 (https://phabricator.wikimedia.org/T271551) [17:08:58] (03PS1) 10Umherirrender: Use foreach to loop a database result set [extensions/ContributionsList] - 10https://gerrit.wikimedia.org/r/655204 [17:15:42] 10MediaWiki-extensions-DrawioEditor: Javascript exception occurs when saving drawio but image folder is inaccessible - https://phabricator.wikimedia.org/T271623 (10Lucienmp) [17:16:55] (03PS1) 10Umherirrender: Use foreach to loop a database result set [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/655205 [17:24:23] (03PS1) 10Umherirrender: Use foreach to loop a database result set [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/655206 [17:25:53] (03PS1) 10Umherirrender: Avoid assignment in conditions [extensions/GlobalContribs] - 10https://gerrit.wikimedia.org/r/655207 [17:27:41] (03PS1) 10Lucien Murray-Pitts: fix possible typo, expand incoming data object to get error message [extensions/DrawioEditor] - 10https://gerrit.wikimedia.org/r/655208 [17:30:52] (03PS1) 10Umherirrender: Use IDatabase::selectField to get single value [extensions/HitCounters] - 10https://gerrit.wikimedia.org/r/655209 [17:32:05] (03PS2) 10Lucien Murray-Pitts: fix possible typo, expand incoming data object to get error message [extensions/DrawioEditor] - 10https://gerrit.wikimedia.org/r/655208 (https://phabricator.wikimedia.org/T271623) [17:34:55] (03PS1) 10Umherirrender: Avoid assignment in conditions [extensions/MediaFunctions] - 10https://gerrit.wikimedia.org/r/655210 [17:35:11] (03PS3) 10Lucien Murray-Pitts: fix possible typo, expand incoming data object to get error message [extensions/DrawioEditor] - 10https://gerrit.wikimedia.org/r/655208 (https://phabricator.wikimedia.org/T271623) [17:36:19] 10MediaWiki-extensions-DrawioEditor: Javascript exception occurs when saving drawio but image folder is inaccessible - https://phabricator.wikimedia.org/T271623 (10Lucienmp) Probably messed up the git review by not including the message body; patch here [[ https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Dr... [17:37:04] (03PS1) 10Umherirrender: Use foreach to loop a database result set [extensions/PluggableSSO] - 10https://gerrit.wikimedia.org/r/655211 [17:37:19] 10MediaWiki-Interwiki, 10Wikidata, 10Wikidata-Campsite, 10Wikisource: Interwiki links to/from Multilingual Wikisource - https://phabricator.wikimedia.org/T138332 (10AlexisJazz) >>! In T138332#6733731, @Lydia_Pintscher wrote: > Ok let's go for this then. I'd like that. >>! In T138332#6633418, @Billinghurst... [17:37:33] 10MediaWiki-extensions-DrawioEditor: DrawIO Extension should support the Extension Tag - https://phabricator.wikimedia.org/T271615 (10Lucienmp) Ran into an issue during creating the patch for submission, resolved the issue and submitted T271623. [17:40:14] 10Phabricator: Understand which Phab forms are used how often (by analyzing referer logs?) - https://phabricator.wikimedia.org/T268886 (10Aklapper) Alright... basically https://wikitech.wikimedia.org/wiki/Analytics/Data_Lake/Traffic/Webrequest : Log into Hive on `stat1007`, then `use wmf` DB. Tasks that must ha... [17:40:19] (03CR) 10Pppery: fix possible typo, expand incoming data object to get error message (031 comment) [extensions/DrawioEditor] - 10https://gerrit.wikimedia.org/r/655208 (https://phabricator.wikimedia.org/T271623) (owner: 10Lucien Murray-Pitts) [17:40:50] (03PS1) 10Umherirrender: Use foreach to loop a database result set [extensions/Poll] - 10https://gerrit.wikimedia.org/r/655212 [17:42:01] 10Dumps-Generation, 10Pageviews-Anomaly, 10Wikimedia-production-error: Hourly pageviews stop working after the last pageviews-20210106-140000.gz - https://phabricator.wikimedia.org/T271521 (10Xaosflux) [17:43:05] 10Dumps-Generation, 10Pageviews-Anomaly, 10Wikimedia-production-error: Hourly pageviews stop working after the last pageviews-20210106-140000.gz - https://phabricator.wikimedia.org/T271521 (10Xaosflux) [17:47:03] 10Dumps-Generation, 10Pageviews-Anomaly, 10Wikimedia-production-error: Hourly pageviews stop working after the last pageviews-20210106-140000.gz - https://phabricator.wikimedia.org/T271521 (10elukey) 05Open→03Resolved a:03elukey Closing the task since it should be solved by now, please re-open if neces... [17:50:51] (03PS1) 10Mainframe98: Switch to using HookRunnerTestBase [skins/Mirage] - 10https://gerrit.wikimedia.org/r/655213 [17:56:53] (03CR) 10Mainframe98: [C: 03+1] "Works with I969e1d381c6cb4dc421c11da457903caeb104a4d :)" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/655197 (https://phabricator.wikimedia.org/T271620) (owner: 10Daimona Eaytoy) [18:12:10] (03CR) 10Daimona Eaytoy: Add HookRunnerTestBase for use by extensions (032 comments) [core] - 10https://gerrit.wikimedia.org/r/655197 (https://phabricator.wikimedia.org/T271620) (owner: 10Daimona Eaytoy) [18:12:25] (03PS5) 10Daimona Eaytoy: Add HookRunnerTestBase for use by extensions [core] - 10https://gerrit.wikimedia.org/r/655197 (https://phabricator.wikimedia.org/T271620) [18:18:08] (03PS48) 10Cicalese: Code refactoring. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/652576 [18:37:07] (03CR) 10Jforrester: [C: 03+2] Migrate text table to abstract schema [core] - 10https://gerrit.wikimedia.org/r/651680 (https://phabricator.wikimedia.org/T230428) (owner: 10Ladsgroup) [18:37:32] (03CR) 10Jforrester: [C: 03+2] Add missing PG indexes of ipblocks [core] - 10https://gerrit.wikimedia.org/r/655198 (https://phabricator.wikimedia.org/T230428) (owner: 10Ladsgroup) [18:43:26] 10MediaWiki-General, 10Equivset, 10RemexHtml, 10Shellbox, and 2 others: Test, pass, release, and upgrade all home-grown PHP libraries for MediaWiki on PHP 8.0 - https://phabricator.wikimedia.org/T271575 (10Jdforrester-WMF) [19:01:10] (03Merged) 10jenkins-bot: Add missing PG indexes of ipblocks [core] - 10https://gerrit.wikimedia.org/r/655198 (https://phabricator.wikimedia.org/T230428) (owner: 10Ladsgroup) [19:05:41] (03PS26) 10Paladox: Fix fetching ipblock-exempt within BlockManager#getUserBlock [core] - 10https://gerrit.wikimedia.org/r/655148 (https://phabricator.wikimedia.org/T271551) [19:06:50] (03Merged) 10jenkins-bot: Migrate text table to abstract schema [core] - 10https://gerrit.wikimedia.org/r/651680 (https://phabricator.wikimedia.org/T230428) (owner: 10Ladsgroup) [19:08:46] 10MediaWiki-Installer, 10MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), 10Patch-For-Review, and 3 others: Migrate tables.sql to abstract schema - https://phabricator.wikimedia.org/T230428 (10Jdforrester-WMF) [19:10:01] (03CR) 10Paladox: "> Patch Set 4:" [core] - 10https://gerrit.wikimedia.org/r/654865 (https://phabricator.wikimedia.org/T270145) (owner: 10DannyS712) [19:15:23] +/14 [19:18:51] (03PS1) 10Lucien Murray-Pitts: Adds Extension Tag for drawio [extensions/DrawioEditor] - 10https://gerrit.wikimedia.org/r/655214 [19:19:45] (03PS27) 10Paladox: Fix fetching ipblock-exempt within BlockManager#getUserBlock [core] - 10https://gerrit.wikimedia.org/r/655148 (https://phabricator.wikimedia.org/T271551) [19:26:14] 10MediaWiki-extensions-DrawioEditor: DrawIO Extension should support the Extension Tag - https://phabricator.wikimedia.org/T271615 (10Lucienmp) Again the gerritbot didnt mention my fix here, not sure why again but added here [[ https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DrawioEditor/+/655214 | patch]] [19:26:41] (03PS2) 10Lucien Murray-Pitts: Adds Extension Tag for drawio [extensions/DrawioEditor] - 10https://gerrit.wikimedia.org/r/655214 [19:31:26] (03CR) 10Reedy: [C: 04-1] Adds Extension Tag for drawio (031 comment) [extensions/DrawioEditor] - 10https://gerrit.wikimedia.org/r/655214 (owner: 10Lucien Murray-Pitts) [19:42:25] (03PS4) 10Lucien Murray-Pitts: fix possible typo, expand incoming data object to get error message [extensions/DrawioEditor] - 10https://gerrit.wikimedia.org/r/655208 (https://phabricator.wikimedia.org/T271623) [19:45:02] (03PS3) 10Lucien Murray-Pitts: Adds Extension Tag for drawio [extensions/DrawioEditor] - 10https://gerrit.wikimedia.org/r/655214 [19:45:30] (03PS4) 10Lucien Murray-Pitts: Adds Extension Tag for drawio [extensions/DrawioEditor] - 10https://gerrit.wikimedia.org/r/655214 (https://phabricator.wikimedia.org/T271615) [19:49:05] (03PS1) 10Umherirrender: Avoid assignment in conditions [extensions/ProtectSite] - 10https://gerrit.wikimedia.org/r/655217 [19:49:21] (03CR) 10Daimona Eaytoy: "FTR:" [extensions/LDAPProvider] - 10https://gerrit.wikimedia.org/r/654525 (owner: 10MarkAHershberger) [19:50:19] (03CR) 10Daimona Eaytoy: "(Same as I4a03b7488ec57923eaccb7e1c55870c19716a0cd)" [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652192 (owner: 10MarkAHershberger) [19:52:46] (03PS1) 10Umherirrender: Use foreach to loop a database result set [extensions/RandomPages] - 10https://gerrit.wikimedia.org/r/655218 [19:56:46] (03CR) 10Mainframe98: [C: 03+1] Add HookRunnerTestBase for use by extensions [core] - 10https://gerrit.wikimedia.org/r/655197 (https://phabricator.wikimedia.org/T271620) (owner: 10Daimona Eaytoy) [19:56:53] (03CR) 10Mainframe98: [C: 03+2] Switch to using HookRunnerTestBase [skins/Mirage] - 10https://gerrit.wikimedia.org/r/655213 (owner: 10Mainframe98) [19:58:23] (03PS1) 10Umherirrender: Use foreach to loop a database result set [extensions/SelectTag] - 10https://gerrit.wikimedia.org/r/655219 [20:00:33] (03PS1) 10Umherirrender: Use foreach to loop a database result set [extensions/UserExport] - 10https://gerrit.wikimedia.org/r/655220 [20:07:10] (03CR) 10MaxSem: [C: 03+2] build: Remove version from composer.json [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/654542 (owner: 10Legoktm) [20:07:24] (03CR) 10MaxSem: [C: 03+2] build: Add more files to .gitattributes as export-ignore [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/654550 (owner: 10Legoktm) [20:07:32] (03PS1) 10Umherirrender: Use foreach to loop a database result set [extensions/Video] - 10https://gerrit.wikimedia.org/r/655221 [20:11:41] (03Merged) 10jenkins-bot: build: Remove version from composer.json [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/654542 (owner: 10Legoktm) [20:11:43] (03Merged) 10jenkins-bot: build: Add more files to .gitattributes as export-ignore [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/654550 (owner: 10Legoktm) [20:12:33] (03PS3) 10Universal Omega: Fix threads continually closing [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/655151 [20:13:17] 10MediaWiki-extensions-DrawioEditor: DrawioEditor undefined property $img_timestamp - https://phabricator.wikimedia.org/T271469 (10Lucienmp) I see the issue and can recreate it, I had not quite realized the cause with my previous fix. MediaWiki Test Page Should be like follows; ` Copy 1: {{drawio:ChartName5|t... [20:13:26] (03PS1) 10Umherirrender: Use foreach to loop a database result set [extensions/Wigo3] - 10https://gerrit.wikimedia.org/r/655222 [20:19:08] (03PS1) 10Umherirrender: Use foreach to loop a database result set [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/655223 [20:21:50] (03PS1) 10Lucien Murray-Pitts: Fixes img_timestamp exception for same charts [extensions/DrawioEditor] - 10https://gerrit.wikimedia.org/r/655224 (https://phabricator.wikimedia.org/T271469) [20:29:45] (03CR) 10Jack Phoenix: [C: 03+2] Fix threads continually closing [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/655151 (owner: 10Universal Omega) [20:33:38] (03Merged) 10jenkins-bot: Fix threads continually closing [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/655151 (owner: 10Universal Omega) [20:47:34] (03PS1) 10Umherirrender: Avoid assignment in conditions [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/655225 [21:15:15] 10MediaWiki-extensions-Page_Forms: Autoedit parser function drops dates - https://phabricator.wikimedia.org/T271224 (10Revansx) My own attempt at a local hack of PageForms/libs/PF_autoedit.js here: https://github.com/revansx/mediawiki-extensions-PageForms/commit/ed8898df9377f390cdf31db05ec851194946f9ea#diff-4f... [21:17:13] 10Timeless: Table moves downwards on viewport size changes - https://phabricator.wikimedia.org/T271501 (10Isarra) Okay, confirmed, different presentation of same bug (or cause of bug), but that this was reported too actually ensured we get the //right// fix, maybe... [21:17:54] 10Timeless: Table moves downwards on viewport size changes - https://phabricator.wikimedia.org/T271501 (10Isarra) I love you guys. [21:18:00] (03PS2) 10Isarra: Make giant table sticky captions css only affect giant tables [skins/Timeless] - 10https://gerrit.wikimedia.org/r/655115 (https://phabricator.wikimedia.org/T271473) [21:18:36] (03PS3) 10Isarra: Make giant table sticky captions js only affect giant tables [skins/Timeless] - 10https://gerrit.wikimedia.org/r/655115 (https://phabricator.wikimedia.org/T271473) [21:33:09] (03PS1) 10Umherirrender: Avoid assignment in conditions [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/655226 [21:33:12] (03CR) 10Jack Phoenix: [C: 03+2] "Tested and approved!" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/655115 (https://phabricator.wikimedia.org/T271473) (owner: 10Isarra) [21:38:55] (03Merged) 10jenkins-bot: Make giant table sticky captions js only affect giant tables [skins/Timeless] - 10https://gerrit.wikimedia.org/r/655115 (https://phabricator.wikimedia.org/T271473) (owner: 10Isarra) [21:40:36] (03PS2) 10Umherirrender: Avoid assignment in conditions [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/655226 [21:48:26] (03CR) 10Zoranzoki21: [C: 03+2] "Thanks!" [extensions/RandomPages] - 10https://gerrit.wikimedia.org/r/655218 (owner: 10Umherirrender) [21:52:15] (03Merged) 10jenkins-bot: Use foreach to loop a database result set [extensions/RandomPages] - 10https://gerrit.wikimedia.org/r/655218 (owner: 10Umherirrender) [22:05:11] (03CR) 10MarkAHershberger: "> CI is not running phan. It needs to happen via the extension-phan job" [extensions/LDAPProvider] - 10https://gerrit.wikimedia.org/r/654525 (owner: 10MarkAHershberger) [22:58:15] (03CR) 10Daimona Eaytoy: "> Patch Set 1:" [extensions/LDAPProvider] - 10https://gerrit.wikimedia.org/r/654525 (owner: 10MarkAHershberger) [23:06:28] 10NearbyPages: Suggested Additional Functionality for Special:Nearby - https://phabricator.wikimedia.org/T271626 (10DocFreeman24) [23:07:21] 10NearbyPages: Suggested Additional Functionality for Special:Nearby - https://phabricator.wikimedia.org/T271626 (10DocFreeman24) [23:08:30] 10NearbyPages: Suggested Additional Functionality for Special:Nearby - https://phabricator.wikimedia.org/T271626 (10Aklapper) 05Open→03Invalid Hi @DocFreeman24, thanks for taking the time to report this and welcome to Wikimedia Phabricator! Could you please check https://www.mediawiki.org/wiki/How_to_report_... [23:19:31] 04(no projects): Problem center disabled Wikitable Minerva - https://phabricator.wikimedia.org/T270856 (10Aklapper) 05Stalled→03Invalid Unfortunately closing this Phabricator task as no further information has been provided. @Menthe: After you have provided the information asked for and if this still happe... [23:27:06] (03PS1) 10Daimona Eaytoy: Improve coverage around consequences [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/655227 [23:38:49] (03CR) 10DannyS712: [C: 04-1] Fix fetching ipblock-exempt within BlockManager#getUserBlock (032 comments) [core] - 10https://gerrit.wikimedia.org/r/655148 (https://phabricator.wikimedia.org/T271551) (owner: 10Paladox) [23:48:03] (03PS28) 10Paladox: Fix fetching ipblock-exempt within BlockManager::getUserBlock [core] - 10https://gerrit.wikimedia.org/r/655148 (https://phabricator.wikimedia.org/T271551) [23:48:27] 10MediaWiki-Logevents, 10Platform Engineering, 10Dependency injection, 10Patch-For-Review, 10User-DannyS712: Add a factory service for `ManualLogEntry` objects - https://phabricator.wikimedia.org/T253717 (10DannyS712) a:05DannyS712→03None [23:48:31] (03CR) 10Paladox: Fix fetching ipblock-exempt within BlockManager::getUserBlock (032 comments) [core] - 10https://gerrit.wikimedia.org/r/655148 (https://phabricator.wikimedia.org/T271551) (owner: 10Paladox) [23:48:36] (03Abandoned) 10DannyS712: Add a new LogEntryFactory for constructing ManualLogEntry objects [core] - 10https://gerrit.wikimedia.org/r/601340 (https://phabricator.wikimedia.org/T253717) (owner: 10DannyS712) [23:48:51] 10MediaWiki-Logevents, 10Platform Engineering, 10Dependency injection, 10User-DannyS712: Add a factory service for `ManualLogEntry` objects - https://phabricator.wikimedia.org/T253717 (10DannyS712) [23:48:55] (03CR) 10jerkins-bot: [V: 04-1] Improve coverage around consequences [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/655227 (owner: 10Daimona Eaytoy) [23:53:34] (03CR) 10DannyS712: Fix fetching ipblock-exempt within BlockManager::getUserBlock (031 comment) [core] - 10https://gerrit.wikimedia.org/r/655148 (https://phabricator.wikimedia.org/T271551) (owner: 10Paladox) [23:54:53] (03CR) 10Paladox: Fix fetching ipblock-exempt within BlockManager::getUserBlock (031 comment) [core] - 10https://gerrit.wikimedia.org/r/655148 (https://phabricator.wikimedia.org/T271551) (owner: 10Paladox) [23:55:07] (03CR) 10Paladox: Fix fetching ipblock-exempt within BlockManager::getUserBlock (031 comment) [core] - 10https://gerrit.wikimedia.org/r/655148 (https://phabricator.wikimedia.org/T271551) (owner: 10Paladox)