[00:01:47] (03CR) 10DannyS712: [C: 03+2] build: Explict exclude object type hint inline [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/652444 (owner: 10Umherirrender) [00:03:24] (03CR) 10DannyS712: [C: 03+2] Fix documentation about array as object type [extensions/BlueSpiceSocialBlog] - 10https://gerrit.wikimedia.org/r/652440 (owner: 10Umherirrender) [00:03:30] (03CR) 10DannyS712: [C: 03+2] Fix documentation about array as object type [extensions/BlueSpiceSocialWikiPage] - 10https://gerrit.wikimedia.org/r/652441 (owner: 10Umherirrender) [00:03:36] (03CR) 10DannyS712: [C: 03+2] Fix documentation about array as object type [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/652439 (owner: 10Umherirrender) [00:04:43] (03CR) 10DannyS712: [C: 03+2] Use real types instead of object type in documentation [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/652434 (owner: 10Umherirrender) [00:05:54] (03Merged) 10jenkins-bot: build: Explict exclude object type hint inline [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/652444 (owner: 10Umherirrender) [00:07:26] (03CR) 10DannyS712: [C: 03+1] Fix documentation about array as object type [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/652429 (owner: 10Umherirrender) [00:08:53] (03CR) 10DannyS712: [C: 03+2] Fix documentation about stdClass as object type [extensions/UnusedRedirects] - 10https://gerrit.wikimedia.org/r/652431 (owner: 10Umherirrender) [00:09:06] (03CR) 10DannyS712: [C: 03+2] Fix documentation about array as object type [extensions/DebugTemplates] - 10https://gerrit.wikimedia.org/r/652422 (owner: 10Umherirrender) [00:09:08] (03CR) 10DannyS712: [C: 03+2] Fix documentation about stdClass as object type [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/652421 (owner: 10Umherirrender) [00:09:27] (03Merged) 10jenkins-bot: Fix documentation about array as object type [extensions/BlueSpiceSocialBlog] - 10https://gerrit.wikimedia.org/r/652440 (owner: 10Umherirrender) [00:09:29] (03Merged) 10jenkins-bot: Fix documentation about array as object type [extensions/BlueSpiceSocialWikiPage] - 10https://gerrit.wikimedia.org/r/652441 (owner: 10Umherirrender) [00:09:31] (03Merged) 10jenkins-bot: Fix documentation about array as object type [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/652439 (owner: 10Umherirrender) [00:09:33] (03Merged) 10jenkins-bot: Use real types instead of object type in documentation [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/652434 (owner: 10Umherirrender) [00:13:03] (03Merged) 10jenkins-bot: Fix documentation about stdClass as object type [extensions/UnusedRedirects] - 10https://gerrit.wikimedia.org/r/652431 (owner: 10Umherirrender) [00:13:10] (03CR) 10DannyS712: TableDiffFormatter: Build HTML using utility class (033 comments) [core] - 10https://gerrit.wikimedia.org/r/652191 (owner: 10Esanders) [00:13:25] (03Merged) 10jenkins-bot: Fix documentation about array as object type [extensions/DebugTemplates] - 10https://gerrit.wikimedia.org/r/652422 (owner: 10Umherirrender) [00:13:54] (03Merged) 10jenkins-bot: Fix documentation about stdClass as object type [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/652421 (owner: 10Umherirrender) [00:17:45] (03CR) 10DannyS712: Improve and add documentation to import/export related classes (032 comments) [core] - 10https://gerrit.wikimedia.org/r/642598 (owner: 10Umherirrender) [00:38:32] (03PS2) 10David Kamholz: Support single-page file formats [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/652408 (https://phabricator.wikimedia.org/T270924) [00:38:44] (03CR) 10David Kamholz: "recheck" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/652408 (https://phabricator.wikimedia.org/T270924) (owner: 10David Kamholz) [01:03:22] (03PS1) 10Seb35: Inject ExtensionRegistry in tests when possible [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/652455 [01:03:37] (03CR) 10DannyS712: [C: 03+1] Soft deprecate wfIncrStats() [core] - 10https://gerrit.wikimedia.org/r/652404 (https://phabricator.wikimedia.org/T250316) (owner: 10Majavah) [01:04:41] (03CR) 10DannyS712: [C: 03+2] Use MovePageFactory [extensions/Flow] - 10https://gerrit.wikimedia.org/r/652398 (https://phabricator.wikimedia.org/T252934) (owner: 10Majavah) [01:06:26] (03CR) 10jerkins-bot: [V: 04-1] Inject ExtensionRegistry in tests when possible [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/652455 (owner: 10Seb35) [01:07:31] (03CR) 10Seb35: [V: 03+2 C: 03+2] Inject ExtensionRegistry in tests when possible [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/652455 (owner: 10Seb35) [01:29:50] 04(no projects): QA Floating menu - M Lg - https://phabricator.wikimedia.org/T270932 (10jbolorinos-ctr) [01:31:00] 04(no projects): QA Floating menu - M Lg - https://phabricator.wikimedia.org/T270932 (10jbolorinos-ctr) Screenshot Test Results - Mobile: https://app.crossbrowsertesting.com/public/i15b74a2dc92badb/screenshots/z33f9f0df08a0bbc731e [01:33:40] (03Merged) 10jenkins-bot: Use MovePageFactory [extensions/Flow] - 10https://gerrit.wikimedia.org/r/652398 (https://phabricator.wikimedia.org/T252934) (owner: 10Majavah) [01:44:39] 10Phabricator: Decide how to distribute phabricator badges - https://phabricator.wikimedia.org/T196390 (10Peachey88) >>! In T196390#6707927, @DannyS712 wrote: > It seems like everything but the trust and safety badge (https://phabricator.wikimedia.org/badges/view/13/) is restricted - can I suggest restricting th... [01:54:43] 10Phabricator: Decide how to distribute phabricator badges - https://phabricator.wikimedia.org/T196390 (10DannyS712) >>! In T196390#6714250, @Peachey88 wrote: >>>! In T196390#6707927, @DannyS712 wrote: >> It seems like everything but the trust and safety badge (https://phabricator.wikimedia.org/badges/view/13/)... [01:54:49] (03CR) 10DannyS712: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/652256 (owner: 10DannyS712) [01:58:00] (03PS6) 10Umherirrender: Improve and add documentation to import/export related classes [core] - 10https://gerrit.wikimedia.org/r/642598 [01:58:10] (03CR) 10Umherirrender: Improve and add documentation to import/export related classes (032 comments) [core] - 10https://gerrit.wikimedia.org/r/642598 (owner: 10Umherirrender) [02:29:39] (03CR) 10DannyS712: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/652257 (owner: 10DannyS712) [02:36:53] 10MediaWiki-extensions-GWToolset, 10Commons, 10GLAM, 10Wikimedia-Site-requests, and 2 others: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Slowking4) >>! In T270911#6713999, @Reedy wrote: > Is there much work to migrate from GWToolset to Pattypan? > > It... [02:47:42] 10Library-Card-Platform: Send instructions duplicated in /admin - https://phabricator.wikimedia.org/T270935 (10Nikkimaria) [02:47:44] 10MediaWiki-extensions-DoubleWiki, 10CSS, 10good first task: Replace inline CSS style attributes with a proper CSS module in DoubleWiki - https://phabricator.wikimedia.org/T252524 (10Prernaswarna) a:03Prernaswarna Hi All, I would like to work on this task [02:52:45] (03PS1) 10Ammarpad: stylelintrc.json: Remove unused pattern [core] - 10https://gerrit.wikimedia.org/r/652457 [02:53:08] 10MediaWiki-extensions-GWToolset, 10Commons, 10GLAM, 10Wikimedia-Site-requests, and 2 others: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Wittylama) >>! In T270911#6714253, @Slowking4 wrote: > a tool that was developed by WMUK It was developed by Europe... [03:03:32] (03CR) 10DannyS712: "This change is ready for review." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/652260 (owner: 10DannyS712) [03:12:02] (03CR) 10DannyS712: "Rather than doing a bunch of cleanup in the same patch, I'm splitting it to one patch per file" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/652259 (owner: 10DannyS712) [03:12:18] (03CR) 10DannyS712: "This change is ready for review." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/652258 (owner: 10DannyS712) [03:29:13] (03CR) 10DannyS712: Minor PHP tweaks (031 comment) [extensions/GlobalWatchlist] - 10https://gerrit.wikimedia.org/r/652189 (owner: 10Reedy) [03:38:18] (03CR) 10DannyS712: [C: 03+1] stylelintrc.json: Remove unused pattern [core] - 10https://gerrit.wikimedia.org/r/652457 (owner: 10Ammarpad) [03:38:43] (03PS1) 10Umherirrender: build: Remove maxWarnings: 0 from eslint configuration [tools/api-testing] - 10https://gerrit.wikimedia.org/r/652466 (https://phabricator.wikimedia.org/T263922) [04:06:31] 10Toolhub: Replace language-name-map with wikimedia/language-data - https://phabricator.wikimedia.org/T270937 (10bd808) [04:40:18] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [libs/alea] - 10https://gerrit.wikimedia.org/r/652470 [04:42:23] (03CR) 10BryanDavis: [C: 03+2] i18n: Add @intlify/eslint-plugin-vue-i18n linter [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/652218 (owner: 10BryanDavis) [04:42:46] (03CR) 10BryanDavis: [C: 03+2] i18n: Document parameters & plurals; tense change [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/652267 (https://phabricator.wikimedia.org/T270809) (owner: 10BryanDavis) [04:44:11] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [libs/Zest] - 10https://gerrit.wikimedia.org/r/652472 [04:45:13] (03Merged) 10jenkins-bot: i18n: Add @intlify/eslint-plugin-vue-i18n linter [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/652218 (owner: 10BryanDavis) [04:45:47] (03Merged) 10jenkins-bot: i18n: Document parameters & plurals; tense change [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/652267 (https://phabricator.wikimedia.org/T270809) (owner: 10BryanDavis) [04:57:43] (03CR) 10Umherirrender: build: Upgrade mediawiki-phan-config from 0.10.4 to 0.10.6 (032 comments) [libs/RemexHtml] - 10https://gerrit.wikimedia.org/r/650850 (owner: 10Jforrester) [04:58:32] (03CR) 10Umherirrender: [C: 03+2] build: Upgrade mediawiki-phan-config from 0.10.4 to 0.10.6 [libs/Zest] - 10https://gerrit.wikimedia.org/r/650796 (owner: 10Jforrester) [04:58:44] (03Abandoned) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [libs/Zest] - 10https://gerrit.wikimedia.org/r/652472 (owner: 10Umherirrender) [04:59:50] (03Merged) 10jenkins-bot: build: Upgrade mediawiki-phan-config from 0.10.4 to 0.10.6 [libs/Zest] - 10https://gerrit.wikimedia.org/r/650796 (owner: 10Jforrester) [05:10:02] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [css-sanitizer] - 10https://gerrit.wikimedia.org/r/652473 [05:16:46] (03PS1) 10MarkAHershberger: Change how config object is called so we don't have to pass it. [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652474 [05:17:55] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/652475 [05:18:27] (03CR) 10jerkins-bot: [V: 04-1] Change how config object is called so we don't have to pass it. [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652474 (owner: 10MarkAHershberger) [05:20:13] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/Popups] - 10https://gerrit.wikimedia.org/r/652476 [05:20:51] (03PS6) 10MarkAHershberger: Refactor individual local/ldap checking bits into protected methods [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652190 (https://phabricator.wikimedia.org/T270885) [05:20:53] (03PS6) 10MarkAHershberger: Introduce phan checking and fix problems it found [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652192 [05:22:19] (03Abandoned) 10MarkAHershberger: Change how config object is called so we don't have to pass it. [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652474 (owner: 10MarkAHershberger) [05:23:05] (03CR) 10jerkins-bot: [V: 04-1] Introduce phan checking and fix problems it found [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652192 (owner: 10MarkAHershberger) [05:23:34] (03CR) 10jerkins-bot: [V: 04-1] Refactor individual local/ldap checking bits into protected methods [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652190 (https://phabricator.wikimedia.org/T270885) (owner: 10MarkAHershberger) [06:07:16] 10MediaWiki-Documentation, 10Documentation, 10User-DannyS712: Move Help:Preferences from Meta to Mediawiki.org, update it and mark it for translation - https://phabricator.wikimedia.org/T181379 (10DannyS712) a:05DannyS712→03None unlicking [06:08:12] 10MediaWiki-API, 10Platform Engineering, 10ProofreadPage, 10Wikisource: Proofread Page extension needs an API module to set or change page status - https://phabricator.wikimedia.org/T30894 (10DannyS712) a:05DannyS712→03None unlicking [06:08:47] 10MediaWiki-Page-deletion, 10MediaWiki-Page-rename, 10MediaWiki-Redirects, 10MediaWiki-User-management, and 4 others: Add user right to delete single revision redirects, regardless of target, during page moves - https://phabricator.wikimedia.org/T239277 (10DannyS712) 05Open→03Resolved [06:48:04] 10WMIT-Infrastructure: Avoid third party resources from wikimedia.it - https://phabricator.wikimedia.org/T266998 (10valerio.bozzolan) [07:11:47] (03CR) 10Pwirth: [C: 03+2] Improve some docs [extensions/BlueSpiceBookshelf] - 10https://gerrit.wikimedia.org/r/652420 (owner: 10Umherirrender) [07:13:22] (03CR) 10DannyS712: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/652475 (owner: 10Umherirrender) [07:13:36] (03CR) 10DannyS712: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/Popups] - 10https://gerrit.wikimedia.org/r/652476 (owner: 10Umherirrender) [07:14:15] (03PS2) 10DannyS712: build: Updating ini to 1.3.8 [extensions/LDAPSyncAll] - 10https://gerrit.wikimedia.org/r/652479 (owner: 10Libraryupgrader) [07:14:32] (03CR) 10Pwirth: [C: 03+2] Use real types instead of object type in documentation [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/652436 (owner: 10Umherirrender) [07:14:45] (03Abandoned) 10DannyS712: build: Updating ini to 1.3.8 [extensions/LDAPSyncAll] - 10https://gerrit.wikimedia.org/r/652479 (owner: 10Libraryupgrader) [07:14:58] (03CR) 10DannyS712: [C: 03+1] build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [libs/alea] - 10https://gerrit.wikimedia.org/r/652470 (owner: 10Umherirrender) [07:17:38] (03Merged) 10jenkins-bot: Improve some docs [extensions/BlueSpiceBookshelf] - 10https://gerrit.wikimedia.org/r/652420 (owner: 10Umherirrender) [07:19:17] (03CR) 10Pwirth: [C: 03+2] Fix documentation about stdClass as object type [extensions/BlueSpicePageTemplates] - 10https://gerrit.wikimedia.org/r/652437 (owner: 10Umherirrender) [07:19:41] (03CR) 10Pwirth: [C: 03+2] Fix documentation about stdClass as object type [extensions/BlueSpiceUEModuleBookPDF] - 10https://gerrit.wikimedia.org/r/652442 (owner: 10Umherirrender) [07:20:18] (03CR) 10Pwirth: [C: 03+2] Fix documentation about stdClass as object type [extensions/BlueSpiceWikiExplorer] - 10https://gerrit.wikimedia.org/r/652443 (owner: 10Umherirrender) [07:20:45] (03CR) 10Pwirth: [C: 03+2] Fix documentation about stdClass as object type [extensions/BlueSpiceRSSFeeder] - 10https://gerrit.wikimedia.org/r/652438 (owner: 10Umherirrender) [07:21:23] (03CR) 10Pwirth: [C: 03+2] Use real types instead of object type in documentation [extensions/BlueSpiceNSFileRepoConnector] - 10https://gerrit.wikimedia.org/r/652435 (owner: 10Umherirrender) [07:25:48] (03PS1) 10Pwirth: Syntax fix [extensions/BlueSpicePageAssignments] (REL1_35) - 10https://gerrit.wikimedia.org/r/652261 [07:26:00] (03PS1) 10Pwirth: Syntax fix [extensions/BlueSpicePageAssignments] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/652262 [07:26:10] (03PS1) 10Pwirth: Syntax fix [extensions/BlueSpicePageAssignments] (REL1_31) - 10https://gerrit.wikimedia.org/r/652263 [07:26:18] (03CR) 10Pwirth: [C: 03+2] Syntax fix [extensions/BlueSpicePageAssignments] (REL1_31) - 10https://gerrit.wikimedia.org/r/652263 (owner: 10Pwirth) [07:26:25] (03CR) 10Pwirth: [V: 03+2 C: 03+2] Syntax fix [extensions/BlueSpicePageAssignments] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/652262 (owner: 10Pwirth) [07:26:34] (03CR) 10Pwirth: [C: 03+2] Syntax fix [extensions/BlueSpicePageAssignments] (REL1_35) - 10https://gerrit.wikimedia.org/r/652261 (owner: 10Pwirth) [07:30:20] (03Merged) 10jenkins-bot: Syntax fix [extensions/BlueSpicePageAssignments] (REL1_31) - 10https://gerrit.wikimedia.org/r/652263 (owner: 10Pwirth) [07:31:17] (03Merged) 10jenkins-bot: Syntax fix [extensions/BlueSpicePageAssignments] (REL1_35) - 10https://gerrit.wikimedia.org/r/652261 (owner: 10Pwirth) [07:36:08] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/652290 (owner: 10L10n-bot) [07:41:12] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/652475 (owner: 10Umherirrender) [07:41:14] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/Popups] - 10https://gerrit.wikimedia.org/r/652476 (owner: 10Umherirrender) [07:41:17] (03Merged) 10jenkins-bot: Use real types instead of object type in documentation [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/652436 (owner: 10Umherirrender) [07:41:19] (03Merged) 10jenkins-bot: Fix documentation about stdClass as object type [extensions/BlueSpicePageTemplates] - 10https://gerrit.wikimedia.org/r/652437 (owner: 10Umherirrender) [07:41:21] (03Merged) 10jenkins-bot: Fix documentation about stdClass as object type [extensions/BlueSpiceUEModuleBookPDF] - 10https://gerrit.wikimedia.org/r/652442 (owner: 10Umherirrender) [07:41:23] (03Merged) 10jenkins-bot: Fix documentation about stdClass as object type [extensions/BlueSpiceWikiExplorer] - 10https://gerrit.wikimedia.org/r/652443 (owner: 10Umherirrender) [07:41:25] (03Merged) 10jenkins-bot: Fix documentation about stdClass as object type [extensions/BlueSpiceRSSFeeder] - 10https://gerrit.wikimedia.org/r/652438 (owner: 10Umherirrender) [07:42:47] (03Merged) 10jenkins-bot: Use real types instead of object type in documentation [extensions/BlueSpiceNSFileRepoConnector] - 10https://gerrit.wikimedia.org/r/652435 (owner: 10Umherirrender) [07:46:06] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [wikimedia-cz/web-theme] - 10https://gerrit.wikimedia.org/r/652301 (owner: 10L10n-bot) [08:26:32] (03CR) 10DannyS712: [C: 03+2] "hmm, try again?" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/652476 (owner: 10Umherirrender) [08:32:15] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/Popups] - 10https://gerrit.wikimedia.org/r/652476 (owner: 10Umherirrender) [08:34:31] (03PS5) 10Majavah: Update SpecialRenameuser to inject services [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/652179 [08:34:51] (03CR) 10Majavah: Update SpecialRenameuser to inject services (034 comments) [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/652179 (owner: 10Majavah) [08:37:06] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] Minor cleanup to FlaggedRevsXML (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/652259 (owner: 10DannyS712) [08:37:46] 10MediaWiki-Page-rename, 10MediaWiki-extensions-CentralAuth, 10MediaWiki-extensions-Renameuser, 10MediaWiki-extensions-Translate, and 12 others: Hard deprecate manually constructing MovePage objects - https://phabricator.wikimedia.org/T252934 (10Majavah) [08:38:45] (03CR) 10jerkins-bot: [V: 04-1] Update SpecialRenameuser to inject services [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/652179 (owner: 10Majavah) [08:54:36] (03CR) 10Thiemo Kreuz (WMDE): Added bracket matching (031 comment) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/647320 (https://phabricator.wikimedia.org/T261857) (owner: 10Svantje Lilienthal) [08:55:49] (03PS1) 10Majavah: Inject and use MovePageFactory in ApiMove [core] - 10https://gerrit.wikimedia.org/r/652488 (https://phabricator.wikimedia.org/T252934) [09:00:00] 10MediaWiki-Page-rename, 10MediaWiki-extensions-CentralAuth, 10MediaWiki-extensions-Renameuser, 10MediaWiki-extensions-Translate, and 12 others: Hard deprecate manually constructing MovePage objects - https://phabricator.wikimedia.org/T252934 (10Majavah) Moving back to code review needed for https://gerrit... [09:22:48] (03CR) 10Ostrzyciel: [C: 03+2] Fix documentation stdClass array as object type [extensions/THICC] - 10https://gerrit.wikimedia.org/r/652430 (owner: 10Umherirrender) [09:25:23] (03CR) 10Reedy: Update SpecialRenameuser to inject services (036 comments) [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/652179 (owner: 10Majavah) [09:26:25] (03Merged) 10jenkins-bot: Fix documentation stdClass array as object type [extensions/THICC] - 10https://gerrit.wikimedia.org/r/652430 (owner: 10Umherirrender) [09:38:55] (03PS6) 10Majavah: Update SpecialRenameuser to inject services [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/652179 [09:42:12] (03CR) 10Majavah: Update SpecialRenameuser to inject services (036 comments) [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/652179 (owner: 10Majavah) [09:50:45] (03PS1) 10Reedy: Title::convertByteClassToUnicodeClass(): Cleanup [core] - 10https://gerrit.wikimedia.org/r/652544 [10:13:39] (03PS1) 10Majavah: Add override for centralauth-groupname [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/652545 (https://phabricator.wikimedia.org/T86741) [10:14:31] (03PS1) 10Majavah: Replace Wikimedia specific messages with neutral ones [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/652546 (https://phabricator.wikimedia.org/T86741) [10:15:03] (03CR) 10Reedy: [C: 04-1] "Needs a QQQ entry" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/652545 (https://phabricator.wikimedia.org/T86741) (owner: 10Majavah) [10:16:11] 10MediaWiki-extensions-CentralAuth, 10translatewiki.net, 10Patch-For-Review, 10good first task: CentralAuth has several Wikimedia specific messages - https://phabricator.wikimedia.org/T86741 (10Majavah) Hi #translatewiki.net! Could you please move translations for `centralauth-groupname` to `wikimedia-cent... [10:17:07] (03PS2) 10Majavah: Replace Wikimedia specific messages with neutral ones [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/652546 (https://phabricator.wikimedia.org/T86741) [10:17:38] (03PS2) 10Majavah: Add override for centralauth-groupname [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/652545 (https://phabricator.wikimedia.org/T86741) [10:17:54] (03CR) 10Majavah: "> Patch Set 1: Code-Review-1" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/652545 (https://phabricator.wikimedia.org/T86741) (owner: 10Majavah) [10:18:16] (03CR) 10Reedy: Title::convertByteClassToUnicodeClass(): Cleanup (031 comment) [core] - 10https://gerrit.wikimedia.org/r/652544 (owner: 10Reedy) [10:19:42] (03CR) 10Seb35: "I will commit this soon to create a v2.x with PHP7+ MW1.27+, although I intend to continue maintaining a v1.x with PHP5.2+ MW1.3+ – I like" [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/545255 (owner: 10Daimona Eaytoy) [10:21:49] * Reedy has to wonder, honestly, "why" [10:26:01] (03CR) 10Reedy: "I really have to wonder why you'd waste the time supporting MW 1.3. It's from 2004. Over 16 years old." [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/545255 (owner: 10Daimona Eaytoy) [10:26:02] 10WMIT-Infrastructure: Deploy a Matomo instance in matomo.wikimedia.it - https://phabricator.wikimedia.org/T270746 (10valerio.bozzolan) [10:30:30] Reedy: MW 1.3 is older than me... [10:30:41] heh [10:31:18] I've presumably nearly been Wikipedia-ing for about as long as you've been alive :) [10:42:12] (03CR) 10DannyS712: Minor cleanup to FlaggedRevsXML (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/652259 (owner: 10DannyS712) [10:42:54] (03CR) 10DannyS712: [C: 03+1] "too tired to merge anything at the moment, will probably +2 tomorrow" [core] - 10https://gerrit.wikimedia.org/r/652488 (https://phabricator.wikimedia.org/T252934) (owner: 10Majavah) [10:43:28] 10WMIT-Infrastructure: Deploy a Matomo instance in matomo.wikimedia.it - https://phabricator.wikimedia.org/T270746 (10valerio.bozzolan) Now this is online. Anyway before marking this as resolved I would like to wait for T269782#6710708 in order to being able to publish the related configuration files. [11:12:40] 10MediaWiki-Core-Testing, 10Continuous-Integration-Infrastructure: Coverage report wrongly marks some lines of a multi-line function call as uncovered - https://phabricator.wikimedia.org/T205812 (10Seb35) The specific issues decribed are fixed nowadays (it is now Xdebug 2.7.0). There are still (very) few issue... [11:45:26] (03PS1) 10VolkerE: [build] Update 'wikimedia-ui-base' to latest [wvui] - 10https://gerrit.wikimedia.org/r/652548 [12:04:06] 10Accessibility, 10DiscussionTools, 10Editing QA, 10Growth-Team, and 5 others: User can't tab out VisualEditor surfaces, e.g. comment input widgets, media dialog - https://phabricator.wikimedia.org/T172694 (10Esanders) >>! In T172694#6700094, @ppelberg wrote: > @Esanders, do we maintain documentation for t... [12:07:39] 10MediaWiki-API, 10Growth-Team, 10Notifications, 10Patch-For-Review: EchoApi.markAllRead( 'local', 'all' ) has no effect - https://phabricator.wikimedia.org/T270879 (10Lens0021) [12:07:43] (03Abandoned) 10Umherirrender: Suppress wanted double escape of html on SpecialExpandTemplates [core] - 10https://gerrit.wikimedia.org/r/648374 (owner: 10Umherirrender) [12:07:58] (03Abandoned) 10Umherirrender: Suppress taint-check issues in Parser [core] - 10https://gerrit.wikimedia.org/r/644019 (https://phabricator.wikimedia.org/T216348) (owner: 10Umherirrender) [12:08:11] (03Abandoned) 10Umherirrender: Suppress taint-check issues related to Linker functions [core] - 10https://gerrit.wikimedia.org/r/648379 (https://phabricator.wikimedia.org/T216348) (owner: 10Umherirrender) [12:08:29] (03Abandoned) 10Umherirrender: Annotate File::getDescriptionText to return safe html for taint-check [core] - 10https://gerrit.wikimedia.org/r/644017 (https://phabricator.wikimedia.org/T216348) (owner: 10Umherirrender) [12:12:26] (03CR) 10Daimona Eaytoy: [C: 03+1] build: Updating mediawiki/mediawiki-phan-config to 0.10.6 (031 comment) [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/650869 (owner: 10Libraryupgrader) [12:13:50] (03CR) 10Daimona Eaytoy: [C: 03+1] "I think the issues can be acknowledged by suppressing them, like the current patch set does. After all, TitleBlacklist is all about using " [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/650932 (owner: 10Libraryupgrader) [12:14:54] (03CR) 10Daimona Eaytoy: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/650719 (owner: 10Libraryupgrader) [12:16:12] (03CR) 10Daimona Eaytoy: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/650833 (owner: 10Libraryupgrader) [12:27:42] (03CR) 10Daimona Eaytoy: [C: 03+2] Replace compact() with real array [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/652418 (owner: 10Umherirrender) [12:27:45] (03CR) 10Daimona Eaytoy: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/650831 (owner: 10Libraryupgrader) [12:28:12] (03CR) 10Daimona Eaytoy: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/650893 (owner: 10Libraryupgrader) [12:30:44] (03PS6) 10Esanders: Create diff markers with CSS [core] - 10https://gerrit.wikimedia.org/r/651809 (https://phabricator.wikimedia.org/T192526) [12:33:22] (03CR) 10Daimona Eaytoy: [C: 03+1] "Alternatively, what about" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/650897 (owner: 10Libraryupgrader) [12:34:21] 10MediaWiki-Page-diffs, 10MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), 10Patch-For-Review, 10good first task, 10patch-welcome: Diff-view: indicators should not be copied on copy-and-paste - https://phabricator.wikimedia.org/T192526 (10Esanders) 05Resolved→03Open I don’t think the `user-select` approach... [12:45:36] (03CR) 10Esanders: TableDiffFormatter: Build HTML using utility class (032 comments) [core] - 10https://gerrit.wikimedia.org/r/652191 (owner: 10Esanders) [12:48:02] (03CR) 10Daimona Eaytoy: [C: 03+2] Replace compact() with real array [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/652417 (owner: 10Umherirrender) [12:52:45] (03PS7) 10Esanders: Create diff markers with CSS [core] - 10https://gerrit.wikimedia.org/r/651809 (https://phabricator.wikimedia.org/T192526) [12:53:43] (03CR) 10Daimona Eaytoy: [C: 03+2] "Code should be regenerated anyway (aka copied from taint-check)" [tools/phan/Utils] - 10https://gerrit.wikimedia.org/r/651239 (owner: 10Jforrester) [12:53:58] (03CR) 10Daimona Eaytoy: [V: 03+2 C: 03+2] build: Upgrade phan from ^2.6.1 to 3.2.6, like other phan repos [tools/phan/Utils] - 10https://gerrit.wikimedia.org/r/651239 (owner: 10Jforrester) [12:56:08] (03Merged) 10jenkins-bot: Replace compact() with real array [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/652418 (owner: 10Umherirrender) [12:58:08] (03CR) 10Daimona Eaytoy: [V: 03+2 C: 03+2] "Passing locally" [tools/phan/Utils] - 10https://gerrit.wikimedia.org/r/651239 (owner: 10Jforrester) [12:59:02] (03PS2) 10Daimona Eaytoy: build: Upgrade phan from ^2.6.1 to 3.2.6, like other phan repos [tools/phan/PerfCheckPlugin] - 10https://gerrit.wikimedia.org/r/651248 (owner: 10Jforrester) [13:00:40] 10AbuseFilter, 10Platform Team Initiatives (New Hook System): Dashes in AbuseFilter hook names cause issues with interfaces - https://phabricator.wikimedia.org/T270852 (10Daimona) >>! In T270852#6712641, @Reedy wrote: > `lang=php > $funcName = 'on' . str_replace( ':', '_', ucfirst( $hook ) ); > ` > > I imagi... [13:00:45] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan from ^2.6.1 to 3.2.6, like other phan repos [tools/phan/PerfCheckPlugin] - 10https://gerrit.wikimedia.org/r/651248 (owner: 10Jforrester) [13:00:46] 10AbuseFilter, 10Platform Engineering, 10Platform Team Initiatives (New Hook System): Dashes in AbuseFilter hook names cause issues with interfaces - https://phabricator.wikimedia.org/T270852 (10Daimona) [13:00:53] 10Wikimedia-Site-requests: Create Rollbackers usergroup on Marathi Wikipedia - https://phabricator.wikimedia.org/T270864 (10Tiven2240) When shall we get resolution? [13:01:46] 10AbuseFilter, 10Platform Engineering, 10Platform Team Initiatives (New Hook System): Dashes in AbuseFilter hook names cause issues with interfaces - https://phabricator.wikimedia.org/T270852 (10Majavah) >>! In T270852#6714491, @Daimona wrote: >>>! In T270852#6712641, @Reedy wrote: >> `lang=php >> $funcName... [13:03:24] (03PS1) 10Amire80: Update the autonym of language shi [core] - 10https://gerrit.wikimedia.org/r/652549 [13:03:28] 10AbuseFilter, 10Platform Engineering, 10Platform Team Initiatives (New Hook System): Dashes in AbuseFilter hook names cause issues with interfaces - https://phabricator.wikimedia.org/T270852 (10Daimona) >>! In T270852#6714494, @Majavah wrote: > Wouldn't that create `onAbuseFilter_builder()` instead of the w... [13:03:56] 10Wikimedia-Site-requests: Create Rollbackers usergroup on Marathi Wikipedia - https://phabricator.wikimedia.org/T270864 (10Majavah) All code and configuration deployments are currently paused until next week due to the holidays. [13:05:02] (03PS3) 10Daimona Eaytoy: build: Upgrade phan from ^2.6.1 to 3.2.6, like other phan repos [tools/phan/PerfCheckPlugin] - 10https://gerrit.wikimedia.org/r/651248 (owner: 10Jforrester) [13:08:54] (03CR) 10Daimona Eaytoy: [C: 03+2] build: Upgrade phan from ^2.6.1 to 3.2.6, like other phan repos [tools/phan/PerfCheckPlugin] - 10https://gerrit.wikimedia.org/r/651248 (owner: 10Jforrester) [13:09:47] (03CR) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 (031 comment) [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/650869 (owner: 10Libraryupgrader) [13:10:04] (03Merged) 10jenkins-bot: Replace compact() with real array [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/652417 (owner: 10Umherirrender) [13:10:45] (03Merged) 10jenkins-bot: build: Upgrade phan from ^2.6.1 to 3.2.6, like other phan repos [tools/phan/PerfCheckPlugin] - 10https://gerrit.wikimedia.org/r/651248 (owner: 10Jforrester) [13:15:15] (03CR) 10Daimona Eaytoy: [C: 03+1] build: Updating mediawiki/mediawiki-phan-config to 0.10.6 (031 comment) [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/650869 (owner: 10Libraryupgrader) [13:23:27] (03PS6) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/650897 (owner: 10Libraryupgrader) [13:23:34] (03CR) 10Umherirrender: "> Patch Set 5: Code-Review+1" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/650897 (owner: 10Libraryupgrader) [13:27:31] (03CR) 10Umherirrender: "Not sure why this happen" [extensions/LDAPSyncAll] - 10https://gerrit.wikimedia.org/r/652479 (owner: 10Libraryupgrader) [13:29:56] (03PS1) 10Umherirrender: build: Enable phan-taint-check-plugin and suppress issues [core] - 10https://gerrit.wikimedia.org/r/652553 (https://phabricator.wikimedia.org/T231311) [13:31:10] (03CR) 10Umherirrender: "The final" [core] - 10https://gerrit.wikimedia.org/r/652553 (https://phabricator.wikimedia.org/T231311) (owner: 10Umherirrender) [13:37:34] (03PS4) 10Majavah: Update GlobalBlocking to use the new HookContainer/HookRunner system [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/652184 (https://phabricator.wikimedia.org/T270871) [13:38:10] (03PS2) 10Umherirrender: Avoid $wgLang, $wgRequest and $wgOut in special page, pager and hook [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/650827 [13:42:33] (03Abandoned) 10Umherirrender: Inject PermissionManager into abstract SpecialPage class [core] - 10https://gerrit.wikimedia.org/r/643573 (https://phabricator.wikimedia.org/T266978) (owner: 10Umherirrender) [13:43:00] (03Abandoned) 10Umherirrender: Inject services into abstract ChangesListSpecialPage [core] - 10https://gerrit.wikimedia.org/r/635625 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [13:44:59] (03Abandoned) 10Umherirrender: Static option in ChangesListSpecialPage::checkStructuredFilterUiEnabled [core] - 10https://gerrit.wikimedia.org/r/638068 (owner: 10Umherirrender) [13:45:54] 10MediaWiki-Special-pages, 10Dependency injection: Research how to inject PermissionManager into abstract SpecialPage - https://phabricator.wikimedia.org/T266978 (10Umherirrender) [13:53:30] 10MediaWiki-extensions-CentralAuth, 10translatewiki.net, 10Patch-For-Review, 10good first task: CentralAuth has several Wikimedia specific messages - https://phabricator.wikimedia.org/T86741 (10Nikerabbit) CC @Raymond. [13:53:43] (03Abandoned) 10Umherirrender: Inject the needed dependencies into ApiBlock [core] - 10https://gerrit.wikimedia.org/r/618781 (https://phabricator.wikimedia.org/T259960) (owner: 10Dbarratt) [13:54:16] 10MediaWiki-API, 10MediaWiki-Special-pages, 10Dependency injection, 10MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), 10User-DannyS712: Inject services into API modules and special pages - https://phabricator.wikimedia.org/T259960 (10Umherirrender) a:05daniel→03None [13:56:51] (03Abandoned) 10Umherirrender: Improve doc on SpecialRecentChanges::makeOptionsLink for taint-check [core] - 10https://gerrit.wikimedia.org/r/648373 (owner: 10Umherirrender) [13:58:35] (03PS1) 10Jeroen Steggink: Elasticsearch 7.10.0 support [search/highlighter] - 10https://gerrit.wikimedia.org/r/652555 [13:58:37] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [search/highlighter] - 10https://gerrit.wikimedia.org/r/652555 (owner: 10Jeroen Steggink) [13:58:53] 10MediaWiki-General, 10Technical-Debt (Deprecation process): Deprecate $wgConf - https://phabricator.wikimedia.org/T212739 (10Majavah) See also: T113034 [14:01:55] (03CR) 10Daimona Eaytoy: "This change is ready for review." [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609803 (https://phabricator.wikimedia.org/T270942) (owner: 10Daimona Eaytoy) [14:02:08] (03PS1) 10Umherirrender: Add metadata to i18n files to pass banana [extensions/LDAPSyncAll] (REL1_35) - 10https://gerrit.wikimedia.org/r/652264 [14:02:17] (03CR) 10Umherirrender: [V: 03+2 C: 03+2] Add metadata to i18n files to pass banana [extensions/LDAPSyncAll] (REL1_35) - 10https://gerrit.wikimedia.org/r/652264 (owner: 10Umherirrender) [14:02:30] (03CR) 10Daimona Eaytoy: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/650897 (owner: 10Libraryupgrader) [14:04:08] (03CR) 10jerkins-bot: [V: 04-1] Handle array shape mutations in PHP functions calls [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609803 (https://phabricator.wikimedia.org/T270942) (owner: 10Daimona Eaytoy) [14:05:43] (03PS8) 10Esanders: POC Re-arrange diff into a grid layout [core] - 10https://gerrit.wikimedia.org/r/651830 (https://phabricator.wikimedia.org/T270775) [14:08:58] (03PS1) 10Majavah: Add sitematrix{,-others,-project} overrides [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/652557 (https://phabricator.wikimedia.org/T140941) [14:09:44] (03PS1) 10Majavah: Replace Wikimedia specific messages with generic ones [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/652558 (https://phabricator.wikimedia.org/T140941) [14:35:09] 10WMIT-Infrastructure: Deploy a Matomo instance in matomo.wikimedia.it - https://phabricator.wikimedia.org/T270746 (10valerio.bozzolan) [14:35:11] 10WMIT-Infrastructure: Avoid third party resources from wikimedia.it - https://phabricator.wikimedia.org/T266998 (10valerio.bozzolan) [15:03:24] 10MediaWiki-General, 10MediaWiki-Installer, 10CSS, 10Patch-For-Review: Message boxes classes should carry `mw-` - https://phabricator.wikimedia.org/T270796 (10Tacsipacsi) Actually most of these uses are much older than the introduction of `.messagebox` in e15e45b38670 in September 2019, and just clash with... [15:37:51] (03PS1) 10Esanders: Convert pygments.wrapper.css to LESS [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/652559 [15:37:53] (03PS1) 10Esanders: Fix classname lineno->linenos [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/652560 [15:37:55] (03PS1) 10Esanders: Add small gap between line numbers and code [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/652561 [15:37:57] (03PS1) 10Esanders: Display line numbers as generated CSS content [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/652562 (https://phabricator.wikimedia.org/T32773) [15:37:59] (03PS1) 10Esanders: Enable line numbers on code content pages [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/652563 (https://phabricator.wikimedia.org/T32773) [15:38:52] 10MediaWiki-skins-WikimediaApiPortal, 10Platform Team Workboards (S&F Workboard): Unread notification count is not updated after marking notification read - https://phabricator.wikimedia.org/T265920 (10Vlad.shapik) I researched the working of notifications’ functionality. Notifications’ count updates in the “U... [15:39:23] (03PS13) 10Daimona Eaytoy: Handle array shape mutations in PHP functions calls [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609803 (https://phabricator.wikimedia.org/T270942) [15:41:22] (03CR) 10jerkins-bot: [V: 04-1] Handle array shape mutations in PHP functions calls [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609803 (https://phabricator.wikimedia.org/T270942) (owner: 10Daimona Eaytoy) [15:44:07] (03CR) 10Reedy: [C: 03+1] "Mostly LGTM. Some possible tweaks." (033 comments) [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/652558 (https://phabricator.wikimedia.org/T140941) (owner: 10Majavah) [15:44:39] (03CR) 10Reedy: [C: 03+1] "Leaving for Raimond to +2 and deal with renaming" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/652557 (https://phabricator.wikimedia.org/T140941) (owner: 10Majavah) [15:47:12] (03CR) 10Reedy: [C: 03+2] "Barely used anywhere, only seemingly in ApiParsoidBatch" [core] - 10https://gerrit.wikimedia.org/r/652404 (https://phabricator.wikimedia.org/T250316) (owner: 10Majavah) [15:48:48] (03PS2) 10Majavah: Replace Wikimedia specific messages with generic ones [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/652558 (https://phabricator.wikimedia.org/T140941) [15:49:47] (03CR) 10Majavah: Replace Wikimedia specific messages with generic ones (033 comments) [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/652558 (https://phabricator.wikimedia.org/T140941) (owner: 10Majavah) [15:50:23] (03CR) 10Reedy: [C: 03+1] Replace Wikimedia specific messages with neutral ones [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/652546 (https://phabricator.wikimedia.org/T86741) (owner: 10Majavah) [15:54:22] (03CR) 10Reedy: Replace Wikimedia specific messages with generic ones (031 comment) [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/652558 (https://phabricator.wikimedia.org/T140941) (owner: 10Majavah) [15:54:25] 10WMIT-Infrastructure: Adopt Matomo in Wikimedia Italia websites - https://phabricator.wikimedia.org/T270944 (10valerio.bozzolan) [15:54:35] 10WMIT-Infrastructure: Deploy a Matomo instance in matomo.wikimedia.it - https://phabricator.wikimedia.org/T270746 (10valerio.bozzolan) [15:54:37] 10WMIT-Infrastructure: Adopt Matomo in Wikimedia Italia websites - https://phabricator.wikimedia.org/T270944 (10valerio.bozzolan) [15:55:10] 10WMIT-Infrastructure: Adopt Matomo in Wikimedia Italia websites - https://phabricator.wikimedia.org/T270944 (10valerio.bozzolan) [15:56:49] (03PS1) 10Majavah: Improve wording in message "sitematrix-other-projects" [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/652564 [15:57:45] 10WMIT-Infrastructure: Adopt Matomo in Wikimedia Italia websites - https://phabricator.wikimedia.org/T270944 (10valerio.bozzolan) Just to note that we are waiting for an answer from the service provider of `www.wikimedia.it` that is the only one who can currently install a Matomo plugin. [16:08:42] 04(no projects): Other languages selector in แม่แบบ:Coord on thwiki doesn't links to enwiki properly - https://phabricator.wikimedia.org/T270945 (10PatsagornY) [16:09:34] 04(no projects): Other languages selector in แม่แบบ:Coord on thwiki doesn't links to enwiki properly - https://phabricator.wikimedia.org/T270945 (10PatsagornY) [16:15:48] (03Merged) 10jenkins-bot: Soft deprecate wfIncrStats() [core] - 10https://gerrit.wikimedia.org/r/652404 (https://phabricator.wikimedia.org/T250316) (owner: 10Majavah) [16:24:46] (03PS1) 10Daimona Eaytoy: Improve handling of offsets [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/652566 [16:25:08] (03PS14) 10Daimona Eaytoy: Handle array shape mutations in PHP functions calls [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609803 (https://phabricator.wikimedia.org/T270942) [16:26:30] (03CR) 10jerkins-bot: [V: 04-1] Improve handling of offsets [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/652566 (owner: 10Daimona Eaytoy) [16:26:55] (03CR) 10jerkins-bot: [V: 04-1] Handle array shape mutations in PHP functions calls [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609803 (https://phabricator.wikimedia.org/T270942) (owner: 10Daimona Eaytoy) [16:28:04] (03CR) 10Reedy: [C: 03+2] Improve wording in message "sitematrix-other-projects" [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/652564 (owner: 10Majavah) [16:32:35] (03CR) 10Reedy: [C: 04-1] "Rebase this and put it ontop of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SiteMatrix/+/652558" [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/652564 (owner: 10Majavah) [16:32:54] (03PS15) 10Daimona Eaytoy: Handle array shape mutations in PHP functions calls [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609803 (https://phabricator.wikimedia.org/T270942) [16:33:22] (03PS2) 10Daimona Eaytoy: Improve handling of offsets [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/652566 [16:33:27] (03PS16) 10Daimona Eaytoy: Handle array shape mutations in PHP functions calls [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609803 (https://phabricator.wikimedia.org/T270942) [16:34:41] (03CR) 10jerkins-bot: [V: 04-1] Handle array shape mutations in PHP functions calls [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609803 (https://phabricator.wikimedia.org/T270942) (owner: 10Daimona Eaytoy) [16:36:08] (03CR) 10Tpt: [C: 04-1] "Thank you for this change!" (031 comment) [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/652408 (https://phabricator.wikimedia.org/T270924) (owner: 10David Kamholz) [16:37:50] (03CR) 10Tpt: [C: 04-1] "> I would be also in favor of using "Page:Thumb.png" instead of "Page:Thumb.png/1" for "single-page" formats. It's the naming scheme that " [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/652408 (https://phabricator.wikimedia.org/T270924) (owner: 10David Kamholz) [16:37:56] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Language codes: Add monolingual language code nan-hani, cdo-hani, hak-hans, hak-hant - https://phabricator.wikimedia.org/T180771 (10Nikki) >>! In T180771#6051407, @Amire80 wrote: > I'm not hearing any objections from the Language Committee, so I'm prob... [17:10:33] (03PS1) 10Umherirrender: build: Normalize ext-SimpleXML to lowercase [extensions/AutoCategoriseUploads] - 10https://gerrit.wikimedia.org/r/652569 [17:29:33] 04(no projects): Error after update from MW 1.34 to 1.35 using Postgres - https://phabricator.wikimedia.org/T270953 (10Renatoneto12) [17:32:32] 10MW-1.35-release, 10PostgreSQL: Error after update from MW 1.34 to 1.35 using Postgres - https://phabricator.wikimedia.org/T270953 (10Reedy) [17:32:49] 10MW-1.35-release, 10PostgreSQL: Error after update from MW 1.34 to 1.35 using Postgres - https://phabricator.wikimedia.org/T270953 (10Renatoneto12) [17:33:18] (03CR) 10Raimond Spekking: [C: 03+2] Replace Wikimedia specific messages with generic ones [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/652558 (https://phabricator.wikimedia.org/T140941) (owner: 10Majavah) [17:33:20] (03CR) 10Raimond Spekking: [C: 03+2] Add sitematrix{,-others,-project} overrides [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/652557 (https://phabricator.wikimedia.org/T140941) (owner: 10Majavah) [17:33:33] (03PS1) 10Aaron Schulz: objectcache: add statsd key metrics to BagOStuff classes [core] - 10https://gerrit.wikimedia.org/r/652572 (https://phabricator.wikimedia.org/T235705) [17:37:03] 10Abstract Wikipedia: [Abstract Wikipedia data science] Unification and code commentary - https://phabricator.wikimedia.org/T270826 (10LostEnchanter) [17:37:29] (03CR) 10Seb35: [V: 03+2 C: 03+2] Avoid deprecated curly brace syntax [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/582623 (owner: 10Legoktm) [17:39:39] (03PS1) 10Umherirrender: build: Upgrading grunt-banana-checker to 0.8.1 [extensions/BlueSpiceWikiExplorer] (REL1_31) - 10https://gerrit.wikimedia.org/r/652265 [17:40:29] (03PS2) 10Umherirrender: build: Add node_modules to .gitignore [extensions/BlueSpiceWikiExplorer] (REL1_31) - 10https://gerrit.wikimedia.org/r/652265 [17:45:43] (03CR) 10Daimona Eaytoy: "I've reviewed half of this and agreed with everything so far. I have a proposal though: what about suppressing DoubleEscaped in the config" [core] - 10https://gerrit.wikimedia.org/r/652553 (https://phabricator.wikimedia.org/T231311) (owner: 10Umherirrender) [17:46:37] (03PS2) 10Reedy: Improve wording in message "sitematrix-other-projects" [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/652564 (owner: 10Majavah) [17:47:20] (03CR) 10Reedy: [C: 03+2] "Rebased ontop, +2 so it lands after the parent" [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/652564 (owner: 10Majavah) [17:49:43] (03CR) 10Umherirrender: "> Patch Set 1:" [core] - 10https://gerrit.wikimedia.org/r/652553 (https://phabricator.wikimedia.org/T231311) (owner: 10Umherirrender) [17:57:04] (03Merged) 10jenkins-bot: Replace Wikimedia specific messages with generic ones [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/652558 (https://phabricator.wikimedia.org/T140941) (owner: 10Majavah) [17:57:42] (03CR) 10Reedy: "Well, it would, if I rebased it correctly" [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/652564 (owner: 10Majavah) [17:58:02] (03PS3) 10Reedy: Improve wording in message "sitematrix-other-projects" [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/652564 (owner: 10Majavah) [17:58:11] (03CR) 10Reedy: [C: 03+2] Improve wording in message "sitematrix-other-projects" [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/652564 (owner: 10Majavah) [17:58:25] (03PS1) 10Umherirrender: Add metadata to i18n files to pass banana [extensions/LDAPSyncAll] (REL1_31) - 10https://gerrit.wikimedia.org/r/652586 [17:58:33] (03CR) 10Umherirrender: [V: 03+2 C: 03+2] Add metadata to i18n files to pass banana [extensions/LDAPSyncAll] (REL1_31) - 10https://gerrit.wikimedia.org/r/652586 (owner: 10Umherirrender) [18:00:56] (03Merged) 10jenkins-bot: Add sitematrix{,-others,-project} overrides [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/652557 (https://phabricator.wikimedia.org/T140941) (owner: 10Majavah) [18:01:04] (03CR) 10jerkins-bot: [V: 04-1] Avoid deprecated curly brace syntax [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/582623 (owner: 10Legoktm) [18:01:30] (03PS3) 10Reedy: Add override for centralauth-groupname [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/652545 (https://phabricator.wikimedia.org/T86741) (owner: 10Majavah) [18:02:02] (03CR) 10Reedy: [C: 03+1] Add override for centralauth-groupname [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/652545 (https://phabricator.wikimedia.org/T86741) (owner: 10Majavah) [18:03:23] (03CR) 10Reedy: [C: 03+1] "(leaving for Raimond to +2 and handle)" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/652545 (https://phabricator.wikimedia.org/T86741) (owner: 10Majavah) [18:03:29] (03PS2) 10Umherirrender: build: Enable phan-taint-check-plugin and suppress issues [core] - 10https://gerrit.wikimedia.org/r/652553 (https://phabricator.wikimedia.org/T216348) [18:03:35] (03CR) 10Reedy: [C: 03+1] "(leaving for Raimond to +2 and handle)" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/652546 (https://phabricator.wikimedia.org/T86741) (owner: 10Majavah) [18:04:17] (03CR) 10Umherirrender: "> Patch Set 1:" [core] - 10https://gerrit.wikimedia.org/r/652553 (https://phabricator.wikimedia.org/T216348) (owner: 10Umherirrender) [18:04:23] (03CR) 10Reedy: "Needs rebasing... ontop of 652546 I guess" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/584760 (owner: 10Examknow) [18:06:03] (03PS1) 10Umherirrender: build: Updating npm dependencies for security issues [extensions/LDAPGroups] (REL1_31) - 10https://gerrit.wikimedia.org/r/652587 [18:06:25] (03PS1) 10Umherirrender: build: Add node_modules to gitignore [extensions/LDAPProvider] (REL1_31) - 10https://gerrit.wikimedia.org/r/652588 [18:07:27] (03PS2) 10Umherirrender: build: Add node_modules to .gitignore [extensions/LDAPGroups] (REL1_31) - 10https://gerrit.wikimedia.org/r/652587 [18:08:22] (03CR) 10Umherirrender: [C: 03+2] build: Add node_modules to .gitignore [extensions/BlueSpiceWikiExplorer] (REL1_31) - 10https://gerrit.wikimedia.org/r/652265 (owner: 10Umherirrender) [18:08:40] (03CR) 10Umherirrender: [C: 03+2] build: Add node_modules to gitignore [extensions/LDAPProvider] (REL1_31) - 10https://gerrit.wikimedia.org/r/652588 (owner: 10Umherirrender) [18:08:55] (03CR) 10Umherirrender: [C: 03+2] build: Add node_modules to .gitignore [extensions/LDAPGroups] (REL1_31) - 10https://gerrit.wikimedia.org/r/652587 (owner: 10Umherirrender) [18:11:52] (03Merged) 10jenkins-bot: build: Add node_modules to .gitignore [extensions/BlueSpiceWikiExplorer] (REL1_31) - 10https://gerrit.wikimedia.org/r/652265 (owner: 10Umherirrender) [18:12:13] (03Merged) 10jenkins-bot: build: Add node_modules to gitignore [extensions/LDAPProvider] (REL1_31) - 10https://gerrit.wikimedia.org/r/652588 (owner: 10Umherirrender) [18:12:19] (03PS1) 10Daimona Eaytoy: [WIP] SuspiciousNull [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/652573 [18:12:32] (03Merged) 10jenkins-bot: build: Add node_modules to .gitignore [extensions/LDAPGroups] (REL1_31) - 10https://gerrit.wikimedia.org/r/652587 (owner: 10Umherirrender) [18:14:14] (03CR) 10jerkins-bot: [V: 04-1] [WIP] SuspiciousNull [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/652573 (owner: 10Daimona Eaytoy) [18:28:05] (03Merged) 10jenkins-bot: Improve wording in message "sitematrix-other-projects" [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/652564 (owner: 10Majavah) [18:28:14] (03CR) 10Daimona Eaytoy: [C: 03+1] "LGTM overall, another pair of reviewer's eyes wouldn't hurt." (035 comments) [core] - 10https://gerrit.wikimedia.org/r/652553 (https://phabricator.wikimedia.org/T216348) (owner: 10Umherirrender) [18:28:38] I am new please help me to start to contribute [18:29:00] 10MediaWiki-extensions-CentralAuth, 10Stewards-and-global-tools: Special:Multilock should recognize underscores as a blank space - https://phabricator.wikimedia.org/T270954 (10Tks4Fish) [18:30:28] !start shaurya0806 [18:30:28] https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker [18:32:26] (03CR) 10Daimona Eaytoy: "This issue can also be seen without taint-check, if load() and main() are swapped. Taint-check triggers an early analysis of load(), which" [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/652573 (owner: 10Daimona Eaytoy) [18:32:34] (03Abandoned) 10Daimona Eaytoy: [WIP] SuspiciousNull [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/652573 (owner: 10Daimona Eaytoy) [18:36:22] 10Humaniki: dob view cleanup - https://phabricator.wikimedia.org/T269534 (10TheEugeniaKim) [18:36:40] 10Humaniki: dob view cleanup - https://phabricator.wikimedia.org/T269534 (10TheEugeniaKim) [18:38:05] (03CR) 10Umherirrender: "> Patch Set 2: Code-Review+1" (035 comments) [core] - 10https://gerrit.wikimedia.org/r/652553 (https://phabricator.wikimedia.org/T216348) (owner: 10Umherirrender) [18:38:20] 10MediaWiki-extensions-Pluggable-Auth: PluggableAuth: Add hook when users are created - https://phabricator.wikimedia.org/T270918 (10MarkAHershberger) [18:39:05] (03PS3) 10David Kamholz: Support single-page file formats [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/652408 (https://phabricator.wikimedia.org/T270924) [18:39:37] (03CR) 10David Kamholz: "recheck" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/652408 (https://phabricator.wikimedia.org/T270924) (owner: 10David Kamholz) [18:39:41] (03PS1) 10Umherirrender: build: Enable SecurityCheck-DoubleEscaped and suppress issues [core] - 10https://gerrit.wikimedia.org/r/652574 (https://phabricator.wikimedia.org/T231311) [18:40:55] (03PS4) 10David Kamholz: Support single-page file formats [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/652408 (https://phabricator.wikimedia.org/T270924) [18:41:45] (03CR) 10David Kamholz: "> Patch Set 2: Code-Review-1" (031 comment) [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/652408 (https://phabricator.wikimedia.org/T270924) (owner: 10David Kamholz) [18:46:48] (03CR) 10jerkins-bot: [V: 04-1] Support single-page file formats [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/652408 (https://phabricator.wikimedia.org/T270924) (owner: 10David Kamholz) [18:54:32] (03PS5) 10David Kamholz: Support single-page file formats [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/652408 (https://phabricator.wikimedia.org/T270924) [18:54:43] (03CR) 10David Kamholz: "recheck" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/652408 (https://phabricator.wikimedia.org/T270924) (owner: 10David Kamholz) [19:00:58] (03CR) 10Legoktm: [C: 03+2] build: Normalize ext-SimpleXML to lowercase [extensions/AutoCategoriseUploads] - 10https://gerrit.wikimedia.org/r/652569 (owner: 10Umherirrender) [19:01:26] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [libs/alea] - 10https://gerrit.wikimedia.org/r/652470 (owner: 10Umherirrender) [19:02:07] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [css-sanitizer] - 10https://gerrit.wikimedia.org/r/652473 (owner: 10Umherirrender) [19:02:55] (03PS1) 10Cicalese: Code clean up. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/652576 [19:02:57] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [libs/alea] - 10https://gerrit.wikimedia.org/r/652470 (owner: 10Umherirrender) [19:03:16] (03CR) 10Legoktm: [C: 03+2] build: Remove maxWarnings: 0 from eslint configuration [tools/api-testing] - 10https://gerrit.wikimedia.org/r/652466 (https://phabricator.wikimedia.org/T263922) (owner: 10Umherirrender) [19:03:58] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [css-sanitizer] - 10https://gerrit.wikimedia.org/r/652473 (owner: 10Umherirrender) [19:06:36] (03Merged) 10jenkins-bot: build: Remove maxWarnings: 0 from eslint configuration [tools/api-testing] - 10https://gerrit.wikimedia.org/r/652466 (https://phabricator.wikimedia.org/T263922) (owner: 10Umherirrender) [19:06:40] (03CR) 10jerkins-bot: [V: 04-1] Code clean up. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/652576 (owner: 10Cicalese) [19:07:30] (03CR) 10MarkAHershberger: Ensure that $id is populated for all existing users (031 comment) [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652220 (https://phabricator.wikimedia.org/T270056) (owner: 10MarkAHershberger) [19:14:48] (03PS2) 10Cicalese: Code clean up. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/652576 [19:21:33] (03Merged) 10jenkins-bot: build: Normalize ext-SimpleXML to lowercase [extensions/AutoCategoriseUploads] - 10https://gerrit.wikimedia.org/r/652569 (owner: 10Umherirrender) [19:22:02] 10MediaWiki-extensions-Duplicator, 10User-Kizule: Duplicator extension throws error Call to a member function getId() on null - https://phabricator.wikimedia.org/T212813 (10Pppery) [19:23:07] (03PS3) 10Cicalese: Code clean up. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/652576 [19:37:03] (03PS2) 10MarkAHershberger: Ensure that $id is populated for all existing users [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652220 (https://phabricator.wikimedia.org/T270056) [19:37:05] (03PS4) 10MarkAHershberger: Reduce code duplication by creating a protected getAuthManager() [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652010 [19:37:07] (03PS7) 10MarkAHershberger: Refactor individual local/ldap checking bits into protected methods [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652190 (https://phabricator.wikimedia.org/T270885) [19:37:09] (03PS7) 10MarkAHershberger: Introduce phan checking and fix problems it found [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652192 [19:37:23] 10SyntaxHighlight: Line highlight with line numbers is broken - https://phabricator.wikimedia.org/T270957 (10Esanders) [19:38:32] 10MediaWiki-API, 10I18n, 10JavaScript: Expose language data through an API endpoint - https://phabricator.wikimedia.org/T270959 (10SD0001) [19:39:33] (03CR) 10jerkins-bot: [V: 04-1] Introduce phan checking and fix problems it found [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652192 (owner: 10MarkAHershberger) [19:39:35] (03CR) 10jerkins-bot: [V: 04-1] Ensure that $id is populated for all existing users [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652220 (https://phabricator.wikimedia.org/T270056) (owner: 10MarkAHershberger) [19:39:50] (03CR) 10jerkins-bot: [V: 04-1] Refactor individual local/ldap checking bits into protected methods [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652190 (https://phabricator.wikimedia.org/T270885) (owner: 10MarkAHershberger) [19:39:52] (03CR) 10jerkins-bot: [V: 04-1] Reduce code duplication by creating a protected getAuthManager() [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652010 (owner: 10MarkAHershberger) [19:40:31] (03CR) 10MarkAHershberger: Ensure that $id is populated for all existing users (031 comment) [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652220 (https://phabricator.wikimedia.org/T270056) (owner: 10MarkAHershberger) [19:42:21] (03PS2) 10Esanders: Fix classname lineno->linenos [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/652560 (https://phabricator.wikimedia.org/T270957) [19:42:23] (03PS2) 10Esanders: Add small gap between line numbers and code [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/652561 [19:42:25] (03PS2) 10Esanders: Display line numbers as generated CSS content [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/652562 (https://phabricator.wikimedia.org/T32773) [19:42:27] (03PS2) 10Esanders: Enable line numbers on code content pages [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/652563 (https://phabricator.wikimedia.org/T32773) [19:44:10] 10SyntaxHighlight, 10Patch-For-Review: Line highlight with line numbers is broken - https://phabricator.wikimedia.org/T270957 (10Esanders) [19:44:12] 10HtmlFormatter, 10SyntaxHighlight, 10Regression: The syntaxhighlight highlighting splits the line - https://phabricator.wikimedia.org/T270296 (10Esanders) [19:44:49] 10HtmlFormatter, 10SyntaxHighlight, 10Regression: The syntaxhighlight highlighting splits the line - https://phabricator.wikimedia.org/T270296 (10Esanders) [19:45:00] (03PS3) 10Esanders: Fix classname lineno->linenos [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/652560 (https://phabricator.wikimedia.org/T270296) [19:45:02] (03PS3) 10Esanders: Add small gap between line numbers and code [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/652561 [19:45:04] (03PS3) 10Esanders: Display line numbers as generated CSS content [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/652562 (https://phabricator.wikimedia.org/T32773) [19:45:06] (03PS3) 10Esanders: Enable line numbers on code content pages [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/652563 (https://phabricator.wikimedia.org/T32773) [19:45:10] 10HtmlFormatter, 10SyntaxHighlight, 10Patch-For-Review, 10Regression: The syntaxhighlight highlighting splits the line - https://phabricator.wikimedia.org/T270296 (10Esanders) Example at https://www.mediawiki.org/wiki/Extension:SyntaxHighlight#highlight Observed: {F33978713} Expected: {F33978715} [19:45:27] 10HtmlFormatter, 10SyntaxHighlight, 10Patch-For-Review, 10Regression: The syntaxhighlight highlighting splits the line - https://phabricator.wikimedia.org/T270296 (10Esanders) [19:46:18] 10Abstract Wikipedia: [Abstract Wikipedia data science] Unification and code commentary - https://phabricator.wikimedia.org/T270826 (10LostEnchanter) [20:00:42] 10MediaWiki-API, 10I18n, 10JavaScript: Expose language data through an API endpoint - https://phabricator.wikimedia.org/T270959 (10SD0001) [[ https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/refs/heads/master/includes/api/ApiQueryLanguageinfo.php | ApiQueryLanguageInfo ]] is related. Would it... [20:08:51] (03CR) 10Jeroen Steggink: "Hi David and Guillaume," [search/highlighter] - 10https://gerrit.wikimedia.org/r/652555 (owner: 10Jeroen Steggink) [20:08:56] (03CR) 10Tpt: [C: 03+2] "Thank you!" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/652408 (https://phabricator.wikimedia.org/T270924) (owner: 10David Kamholz) [20:14:18] (03Merged) 10jenkins-bot: Support single-page file formats [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/652408 (https://phabricator.wikimedia.org/T270924) (owner: 10David Kamholz) [20:18:38] (03CR) 10Legoktm: [C: 03+2] Replace compact() with real array [extensions/AddPersonalUrls] - 10https://gerrit.wikimedia.org/r/652416 (owner: 10Umherirrender) [20:23:00] (03Merged) 10jenkins-bot: Replace compact() with real array [extensions/AddPersonalUrls] - 10https://gerrit.wikimedia.org/r/652416 (owner: 10Umherirrender) [20:24:11] 10MediaWiki-API, 10I18n, 10JavaScript: Expose language data through an API endpoint - https://phabricator.wikimedia.org/T270959 (10Reedy) >Along with that, i18n tools such as mw.language and jquery.18n should give a choice between using wgUserLanguage or wgContentLanguage, rather than always using wgUserLang... [20:24:55] (03CR) 10DannyS712: "This change is ready for review." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/652589 (https://phabricator.wikimedia.org/T270954) (owner: 10DannyS712) [20:30:06] 10MediaWiki-API, 10I18n: Expose more language data through the API - https://phabricator.wikimedia.org/T270959 (10Reedy) [20:32:00] 10OOUI: Throw error if OO.ui.Element.static.unsafeInfuse is called on more than one node - https://phabricator.wikimedia.org/T270960 (10Tchanders) [20:34:46] (03CR) 10Umherirrender: [C: 03+2] SpecialMultiLock: convert underscore to spaces in usernames (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/652589 (https://phabricator.wikimedia.org/T270954) (owner: 10DannyS712) [20:34:52] (03CR) 10Umherirrender: [C: 03+1] SpecialMultiLock: convert underscore to spaces in usernames [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/652589 (https://phabricator.wikimedia.org/T270954) (owner: 10DannyS712) [20:36:39] (03CR) 10MusikAnimal: [C: 03+2] "> Changed from permission-only to User::isBot which includes group and permission check" [core] - 10https://gerrit.wikimedia.org/r/650784 (https://phabricator.wikimedia.org/T258108) (owner: 10Umherirrender) [20:37:59] 10MediaWiki-Watchlist, 10Growth-Team, 10Patch-For-Review, 10Platform Team Workboards (Clinic Duty Team), 10User-notice: Ignore auto-watchlist preferences for bots - https://phabricator.wikimedia.org/T258108 (10Majavah) [20:47:00] 10MediaWiki-HTMLForm: cloner.js should not pass multiple nodes to OO.ui.infuse - https://phabricator.wikimedia.org/T270961 (10Tchanders) [20:47:08] (03PS4) 10Esanders: Enable line numbers on code content pages [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/652563 (https://phabricator.wikimedia.org/T32773) [20:47:10] (03PS1) 10Esanders: Add correct classes to full page output [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/652584 [20:48:14] 10OOUI: Throw error if OO.ui.Element.static.unsafeInfuse is called on more than one node - https://phabricator.wikimedia.org/T270960 (10Tchanders) Most callers do only pass one node, so this should be safe to do: https://codesearch.wmcloud.org/deployed/?q=.infuse%5C(&i=nope&files=&repos= A counter-example (and... [20:49:24] (03PS8) 10MarkAHershberger: Refactor individual local/ldap checking bits into protected methods [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652190 (https://phabricator.wikimedia.org/T270885) [20:49:25] (03PS8) 10MarkAHershberger: Introduce phan checking and fix problems it found [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652192 [20:51:39] (03CR) 10jerkins-bot: [V: 04-1] Refactor individual local/ldap checking bits into protected methods [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652190 (https://phabricator.wikimedia.org/T270885) (owner: 10MarkAHershberger) [20:51:41] (03CR) 10jerkins-bot: [V: 04-1] Introduce phan checking and fix problems it found [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652192 (owner: 10MarkAHershberger) [20:59:07] (03PS9) 10MarkAHershberger: Refactor individual local/ldap checking bits into protected methods [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652190 (https://phabricator.wikimedia.org/T270885) [20:59:09] (03PS9) 10MarkAHershberger: Introduce phan checking and fix problems it found [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652192 [21:01:49] (03CR) 10jerkins-bot: [V: 04-1] Introduce phan checking and fix problems it found [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652192 (owner: 10MarkAHershberger) [21:01:51] (03CR) 10jerkins-bot: [V: 04-1] Refactor individual local/ldap checking bits into protected methods [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652190 (https://phabricator.wikimedia.org/T270885) (owner: 10MarkAHershberger) [21:02:44] (03Merged) 10jenkins-bot: [API] Ignore watchlist preferences for bot users [core] - 10https://gerrit.wikimedia.org/r/650784 (https://phabricator.wikimedia.org/T258108) (owner: 10Umherirrender) [21:04:45] (03PS5) 10Esanders: Enable line numbers on code content pages [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/652563 (https://phabricator.wikimedia.org/T32773) [21:04:47] (03PS1) 10Esanders: Improve appearance of line numbers [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/652607 [21:06:42] 10MediaWiki-extensions-Translate, 10I18n: [[MediaWiki:Tpt-old-pages/en]] grammar issue - https://phabricator.wikimedia.org/T270854 (10Aklapper) > I could perfectly translate this for example into German Great but I don't see how that is relevant here. You may want to try some Slavic languages instead. :) [21:09:21] 10SyntaxHighlight, 10Patch-For-Review: Enable line numbers for pages handled by SyntaxHighlight - https://phabricator.wikimedia.org/T32773 (10PatchDemoBot) Test wiki created on [[ http://patchdemo.wmflabs.org | Patch Demo ]] by ESanders (WMF) using patch(es) linked to this task: http://patchdemo.wmflabs.org/w... [21:09:48] (03CR) 10jerkins-bot: [V: 04-1] Enable line numbers on code content pages [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/652563 (https://phabricator.wikimedia.org/T32773) (owner: 10Esanders) [21:09:53] (03CR) 10jerkins-bot: [V: 04-1] Improve appearance of line numbers [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/652607 (owner: 10Esanders) [21:11:58] 10MediaWiki-HTMLForm: cloner.js should not pass multiple nodes to OO.ui.infuse - https://phabricator.wikimedia.org/T270961 (10Mainframe98) If this is related to the OOUI variant of HTMLFormFieldCloner, then {T206905} might worth fixing at the same time. [21:12:29] (03CR) 10Umherirrender: "It seems that in the past libup does not change only ^ in package.json as single update" [extensions/PopupAlerts] - 10https://gerrit.wikimedia.org/r/652608 (owner: 10Libraryupgrader) [21:16:06] 10SyntaxHighlight, 10Patch-For-Review: Enable line numbers for pages handled by SyntaxHighlight - https://phabricator.wikimedia.org/T32773 (10Esanders) >>! In T32773#1403933, @TheDJ wrote: > And wrapped lines break the line number sidebar, but there is little we can do to avoid that I think. We can absolutely... [21:16:35] 10MediaWiki-Watchlist, 10Growth-Team, 10Platform Team Workboards (Clinic Duty Team), 10User-notice: Ignore auto-watchlist preferences for bots - https://phabricator.wikimedia.org/T258108 (10JJMC89) 05Open→03Resolved a:03Umherirrender [21:22:10] 10Abstract Wikipedia: [Abstract Wikipedia data science] Unification and code commentary - https://phabricator.wikimedia.org/T270826 (10LostEnchanter) [21:22:20] (03PS4) 10Cicalese: Code clean up. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/652576 [21:25:28] (03CR) 10Seb35: [V: 03+2 C: 03+2] Add endpoint 'rest.php'. [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/606217 (owner: 10Seb35) [21:25:37] (03CR) 10jerkins-bot: [V: 04-1] Code clean up. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/652576 (owner: 10Cicalese) [21:28:52] (03CR) 10jerkins-bot: [V: 04-1] Add endpoint 'rest.php'. [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/606217 (owner: 10Seb35) [21:29:46] 10Accessibility, 10DiscussionTools, 10Editing QA, 10Growth-Team, and 5 others: User can't tab out VisualEditor surfaces, e.g. comment input widgets, media dialog - https://phabricator.wikimedia.org/T172694 (10Aklapper) > do we maintain documentation for the different keyboard layouts used throughout the wo... [21:34:03] 10MediaWiki-Watchlist, 10Growth-Team, 10Platform Team Workboards (Clinic Duty Team), 10User-notice: Ignore auto-watchlist preferences for bots - https://phabricator.wikimedia.org/T258108 (10Majavah) Should this change be added to RELEASE_NOTES to inform third-party users? [21:35:12] (03PS2) 10Esanders: Improve appearance of line numbers [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/652607 [21:35:14] (03PS6) 10Esanders: Enable line numbers on code content pages [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/652563 (https://phabricator.wikimedia.org/T32773) [21:35:17] 10MediaWiki-Logevents, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), 10User-DannyS712, 10User-notice: link-in-logs not redirecting properly for private logs - https://phabricator.wikimedia.org/T269761 (10JJMC89) 05Open→03Resolved a:03DannyS712 [21:39:21] 10MediaWiki-Watchlist, 10Growth-Team, 10Platform Team Workboards (Clinic Duty Team), 10User-notice: Ignore auto-watchlist preferences for bots - https://phabricator.wikimedia.org/T258108 (10MusikAnimal) Thanks again to Umherirrender for the patch! The solution to ignore the bot preference, rather than not... [21:45:48] (03PS1) 10Tchanders: cloner.js: Ensure only one create button is passed to OO.ui.infuse [core] - 10https://gerrit.wikimedia.org/r/652613 (https://phabricator.wikimedia.org/T270961) [21:59:38] (03PS1) 10Legoktm: Localisation updates from https://translatewiki.net. [extensions/ProofreadPage] (REL1_35) - 10https://gerrit.wikimedia.org/r/652590 [22:12:29] (03PS5) 10Cicalese: Code clean up. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/652576 [22:21:48] (03CR) 10Legoktm: [C: 03+2] "The qqq changes are needed to pass banana-checker on this branch." [extensions/ProofreadPage] (REL1_35) - 10https://gerrit.wikimedia.org/r/652590 (owner: 10Legoktm) [22:24:46] (03PS1) 10QChris: Add .gitreview [extensions/TemplateScripts] - 10https://gerrit.wikimedia.org/r/652620 [22:24:48] (03CR) 10QChris: [V: 03+2 C: 03+2] Add .gitreview [extensions/TemplateScripts] - 10https://gerrit.wikimedia.org/r/652620 (owner: 10QChris) [22:27:03] (03CR) 10jerkins-bot: [V: 04-1] Code clean up. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/652576 (owner: 10Cicalese) [22:27:29] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ProofreadPage] (REL1_35) - 10https://gerrit.wikimedia.org/r/652590 (owner: 10Legoktm) [22:27:44] (03PS1) 10QChris: Add .gitreview [skins/Mirage] - 10https://gerrit.wikimedia.org/r/652621 [22:27:46] (03CR) 10QChris: [V: 03+2 C: 03+2] Add .gitreview [skins/Mirage] - 10https://gerrit.wikimedia.org/r/652621 (owner: 10QChris) [22:29:40] (03PS6) 10Cicalese: Code clean up. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/652576 [22:30:38] (03PS7) 10Cicalese: Code clean up. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/652576 [22:34:20] (03CR) 10jerkins-bot: [V: 04-1] Code clean up. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/652576 (owner: 10Cicalese) [22:38:55] 10WMIT-Infrastructure: Adopt Matomo in Wikimedia Italia websites - https://phabricator.wikimedia.org/T270944 (10valerio.bozzolan) [22:39:18] 10WMIT-Infrastructure: Adopt Matomo in Wikimedia Italia websites - https://phabricator.wikimedia.org/T270944 (10valerio.bozzolan) >>! In T270944#6714609, @valerio.bozzolan wrote: > Just to note that we are waiting for an answer from the service provider of `www.wikimedia.it` that is the only one who can currentl... [22:39:42] 10WMIT-Infrastructure: Adopt Matomo in Wikimedia Italia websites - https://phabricator.wikimedia.org/T270944 (10valerio.bozzolan) p:05Triage→03Medium [22:53:25] (03PS8) 10Cicalese: Code clean up. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/652576 [22:57:05] 10WMIT-Infrastructure: Request a Wikimedia Gerrit repository for the Wikimedia Italia's infrastructure - https://phabricator.wikimedia.org/T269782 (10QChris) (Just for reference if others read this in future: valerio.bozzolan is currently owner of all repos underneath `wikimedia-it` in our gerrit. So this is not... [23:01:31] (03CR) 10Jforrester: [C: 03+1] composer.json: Add ext-libxml and ext-xmlreader to requires (031 comment) [core] - 10https://gerrit.wikimedia.org/r/651984 (owner: 10Reedy) [23:02:06] (03CR) 10Jforrester: [C: 03+2] XML related cleanup [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/651987 (https://phabricator.wikimedia.org/T268847) (owner: 10Reedy) [23:03:26] (03Merged) 10jenkins-bot: XML related cleanup [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/651987 (https://phabricator.wikimedia.org/T268847) (owner: 10Reedy) [23:04:46] (03CR) 10Jforrester: "> Patch Set 1:" [extensions/PopupAlerts] - 10https://gerrit.wikimedia.org/r/652608 (owner: 10Libraryupgrader) [23:06:18] (03PS1) 10MarkAHershberger: Document when PluggableAuthPopulatedGroups is called for new users [extensions/PluggableAuth] - 10https://gerrit.wikimedia.org/r/652624 (https://phabricator.wikimedia.org/T270918) [23:09:56] (03CR) 10Jforrester: [C: 03+2] cloner.js: Ensure only one create button is passed to OO.ui.infuse [core] - 10https://gerrit.wikimedia.org/r/652613 (https://phabricator.wikimedia.org/T270961) (owner: 10Tchanders) [23:25:16] 10WMIT-Infrastructure: Fix 404 on a legacy smssolidale.wikimedia.it - https://phabricator.wikimedia.org/T270964 (10valerio.bozzolan) [23:28:17] 10WMIT-Infrastructure: Request a Wikimedia Gerrit repository for the Wikimedia Italia's infrastructure - https://phabricator.wikimedia.org/T269782 (10valerio.bozzolan) >>! In T269782#6714988, @QChris wrote: > (Just for reference if others read this in future: valerio.bozzolan is currently owner of all repos unde... [23:29:52] (03CR) 10Jforrester: [C: 03+2] "Let's do this. Wonderful work, both of you (and others of course)." [core] - 10https://gerrit.wikimedia.org/r/652553 (https://phabricator.wikimedia.org/T216348) (owner: 10Umherirrender) [23:32:50] (03Merged) 10jenkins-bot: cloner.js: Ensure only one create button is passed to OO.ui.infuse [core] - 10https://gerrit.wikimedia.org/r/652613 (https://phabricator.wikimedia.org/T270961) (owner: 10Tchanders) [23:34:22] (03PS2) 10Jforrester: build: Enable SecurityCheck-DoubleEscaped and suppress issues [core] - 10https://gerrit.wikimedia.org/r/652574 (https://phabricator.wikimedia.org/T231311) (owner: 10Umherirrender) [23:34:49] (03CR) 10Jforrester: [C: 03+2] build: Enable SecurityCheck-DoubleEscaped and suppress issues [core] - 10https://gerrit.wikimedia.org/r/652574 (https://phabricator.wikimedia.org/T231311) (owner: 10Umherirrender) [23:43:23] 10Toolhub, 10Goal: [Toolhub Milestone 2] Initial API and UI; toolinfo crawler - https://phabricator.wikimedia.org/T195679 (10bd808) [23:51:00] (03PS3) 10BryanDavis: i18n: Fix the message "The language in which this toolinfo..." [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/651912 (owner: 10Amire80) [23:54:29] (03Merged) 10jenkins-bot: build: Enable phan-taint-check-plugin and suppress issues [core] - 10https://gerrit.wikimedia.org/r/652553 (https://phabricator.wikimedia.org/T216348) (owner: 10Umherirrender) [23:54:43] (03CR) 10BryanDavis: [C: 03+2] i18n: Fix the message "The language in which this toolinfo..." [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/651912 (owner: 10Amire80) [23:58:18] (03Merged) 10jenkins-bot: i18n: Fix the message "The language in which this toolinfo..." [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/651912 (owner: 10Amire80) [23:59:02] (03Merged) 10jenkins-bot: build: Enable SecurityCheck-DoubleEscaped and suppress issues [core] - 10https://gerrit.wikimedia.org/r/652574 (https://phabricator.wikimedia.org/T231311) (owner: 10Umherirrender)