[00:00:59] (03PS2) 10BryanDavis: i18n: Add @intlify/eslint-plugin-vue-i18n linter [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/652218 [00:08:13] 10Toolhub, 10I18n: [[Wikimedia:Toolhub-js-newtoolsfound/he]] translation issue - https://phabricator.wikimedia.org/T270810 (10bd808) Related to {T270787}. This is indeed the plural form used by [[https://kazupon.github.io/vue-i18n/|vue-i18n]]. [00:20:02] (03PS3) 10MarkAHershberger: Reduce code duplication by creating a protected getAuthManager() [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652010 [00:20:04] (03PS4) 10MarkAHershberger: Refactor individual local/ldap checking bits into protected methods [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652190 (https://phabricator.wikimedia.org/T270885) [00:20:06] (03PS4) 10MarkAHershberger: Introduce phan checking and fix problems it found [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652192 [00:20:08] (03PS1) 10MarkAHershberger: Ensure that $id is populated for all existing users [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652220 (https://phabricator.wikimedia.org/T270056) [00:22:58] (03CR) 10jerkins-bot: [V: 04-1] Ensure that $id is populated for all existing users [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652220 (https://phabricator.wikimedia.org/T270056) (owner: 10MarkAHershberger) [00:23:00] (03CR) 10jerkins-bot: [V: 04-1] Introduce phan checking and fix problems it found [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652192 (owner: 10MarkAHershberger) [00:23:13] (03CR) 10jerkins-bot: [V: 04-1] Reduce code duplication by creating a protected getAuthManager() [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652010 (owner: 10MarkAHershberger) [00:23:16] (03CR) 10jerkins-bot: [V: 04-1] Refactor individual local/ldap checking bits into protected methods [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652190 (https://phabricator.wikimedia.org/T270885) (owner: 10MarkAHershberger) [00:30:08] 10Structured-Data-Backlog, 10artificial-intelligence: Implement NSFW image classifier using Open NSFW - https://phabricator.wikimedia.org/T214201 (10APerson) True. I propose a rename to "Machine learning filter for shock image vandalism" or something like that. There are probably better terms than "shock image... [00:34:59] 10Toolhub, 10I18n: [[Wikimedia:Toolhub-js-auditlog-summary/he]] translation issue - https://phabricator.wikimedia.org/T270809 (10bd808) The [[https://kazupon.github.io/vue-i18n/|vue-i18n]] library currently being used in the Toolhub project allows `{keyword}` syntax for placeholders that will be replaced with... [00:42:47] (03PS5) 10MarkAHershberger: Refactor individual local/ldap checking bits into protected methods [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652190 (https://phabricator.wikimedia.org/T270885) [00:42:49] (03PS5) 10MarkAHershberger: Introduce phan checking and fix problems it found [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652192 [00:45:08] (03CR) 10jerkins-bot: [V: 04-1] Refactor individual local/ldap checking bits into protected methods [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652190 (https://phabricator.wikimedia.org/T270885) (owner: 10MarkAHershberger) [00:45:15] (03CR) 10jerkins-bot: [V: 04-1] Introduce phan checking and fix problems it found [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652192 (owner: 10MarkAHershberger) [00:54:04] 10Trust-and-Safety: Disable 2FA for SUL user `Kiran Gopi` - https://phabricator.wikimedia.org/T270881 (10DannyS712) [01:02:19] 10MediaWiki-extensions-Translate, 10I18n: [[MediaWiki:Tpt-old-pages/en]] grammar issue - https://phabricator.wikimedia.org/T270854 (10Tacsipacsi) >>! In T270854#6713153, @Aklapper wrote: > And I don't get what you mean. :) I explained what the problem is with translations; I don't know what makes you think tha... [01:21:06] (03PS1) 10BryanDavis: i18n: Document parameters & plurals; tense change [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/652267 (https://phabricator.wikimedia.org/T270809) [01:22:19] (03CR) 10BryanDavis: "Amir, are these helpful qqq updates?" [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/652267 (https://phabricator.wikimedia.org/T270809) (owner: 10BryanDavis) [01:40:34] (03PS1) 10Legoktm: build: Add .eslintignore [extensions/AddHTMLMetaAndTitle] - 10https://gerrit.wikimedia.org/r/652271 [02:07:17] (03PS1) 10TrainBranchBot: Branch commit for wmf/1.36.0-wmf.24 [core] (wmf/1.36.0-wmf.24) - 10https://gerrit.wikimedia.org/r/652274 [02:41:50] (03PS2) 10DannyS712: Branch commit for wmf/1.36.0-wmf.24 [core] (wmf/1.36.0-wmf.24) - 10https://gerrit.wikimedia.org/r/652274 (https://phabricator.wikimedia.org/T267417) (owner: 10TrainBranchBot) [02:41:57] (03Abandoned) 10DannyS712: Branch commit for wmf/1.36.0-wmf.24 [core] (wmf/1.36.0-wmf.24) - 10https://gerrit.wikimedia.org/r/652274 (https://phabricator.wikimedia.org/T267417) (owner: 10TrainBranchBot) [02:42:14] 10Release, 10Train Deployments: 1.36.0-wmf.24 deployment blockers - https://phabricator.wikimedia.org/T267417 (10DannyS712) [03:03:25] (03CR) 10DannyS712: "why is this needed for LibUp? It doesn't fail for the GlobalWatchlist extension, and that also doesn't have an eslintignore file" [extensions/AddHTMLMetaAndTitle] - 10https://gerrit.wikimedia.org/r/652271 (owner: 10Legoktm) [04:20:33] (03CR) 10Legoktm: "> Patch Set 1:" [extensions/AddHTMLMetaAndTitle] - 10https://gerrit.wikimedia.org/r/652271 (owner: 10Legoktm) [04:49:24] 04(no projects): API sandbox should support pasting timestamps - https://phabricator.wikimedia.org/T270901 (10Base) [04:56:18] (03CR) 10DannyS712: [C: 03+1] "> Patch Set 1:" [extensions/AddHTMLMetaAndTitle] - 10https://gerrit.wikimedia.org/r/652271 (owner: 10Legoktm) [04:58:42] 10Fresh: Document the security reasons for mounting .git as read-only - https://phabricator.wikimedia.org/T259977 (10Legoktm) In addition to writing to .git/hooks, you could also add malicious commits to a git repository that doesn't go through code review. [04:59:52] 10Fresh: Add support for non-rooted container runtime - https://phabricator.wikimedia.org/T259974 (10Legoktm) I'm back to doing development on Fedora, which generally works better with `podman`, so I thought I'd look into this. After doing `s/docker/podman/`, I had to remove the `consistency=` mount options, wh... [05:16:44] 10MediaWiki-extensions-CentralNotice, 10LibUp: libup does not commit proposed patch set to gerrit for repo CentralNotice - https://phabricator.wikimedia.org/T264234 (10Legoktm) 05Open→03Resolved a:03Legoktm I noticed this last night when debugging other stuff, the problem used to be that it would clone t... [05:18:46] 10UI-Standardization, 10LibUp: Auto re-configure stylelint to lint vue files too - https://phabricator.wikimedia.org/T264252 (10Legoktm) So is the proposal to have libup find stuff like https://codesearch.wmcloud.org/search/?q=%5C*%5C*%2F%5C*.%5C%7Bcss%2Cless%5C%7D&i=nope&files=&repos= and add `vue` unconditio... [05:57:13] (03PS1) 10Legoktm: build: Remove maxWarnings: 0 from eslint configuration [extensions/Popups] - 10https://gerrit.wikimedia.org/r/652278 (https://phabricator.wikimedia.org/T263922) [05:57:50] (03PS1) 10Legoktm: build: Remove maxWarnings: 0 from eslint configuration [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/652279 (https://phabricator.wikimedia.org/T263922) [06:24:09] (03CR) 10Pastakhov: "This change is ready for review." [extensions/LegalLogin] - 10https://gerrit.wikimedia.org/r/635890 (owner: 10Pastakhov) [06:25:53] (03CR) 10jerkins-bot: [V: 04-1] build: Remove maxWarnings: 0 from eslint configuration [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/652279 (https://phabricator.wikimedia.org/T263922) (owner: 10Legoktm) [06:26:55] (03PS2) 10Legoktm: build: Remove maxWarnings: 0 from eslint configuration [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/652279 (https://phabricator.wikimedia.org/T263922) [06:30:33] 10MediaWiki-General: API sandbox should support pasting timestamps - https://phabricator.wikimedia.org/T270901 (10Base) [07:00:51] 10MediaWiki-API: API sandbox should support pasting timestamps - https://phabricator.wikimedia.org/T270901 (10DannyS712) [07:01:32] 10MediaWiki-API: API sandbox should support pasting timestamps - https://phabricator.wikimedia.org/T270901 (10DannyS712) per instructions at #mediawiki-extensions-apisandbox "New tasks regarding API sandbox should go under the MediaWiki-API project." [07:45:12] 10Magnus Sälgö: Meeting SKBL dec 2020 - https://phabricator.wikimedia.org/T269498 (10Salgo60) [08:03:29] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] ParserPreloadTest: Remove unneeded unset calls [core] - 10https://gerrit.wikimedia.org/r/651725 (owner: 10DannyS712) [08:12:18] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/652290 (owner: 10L10n-bot) [08:17:36] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [wikimedia-cz/web-theme] - 10https://gerrit.wikimedia.org/r/652301 (owner: 10L10n-bot) [08:33:03] (03Merged) 10jenkins-bot: ParserPreloadTest: Remove unneeded unset calls [core] - 10https://gerrit.wikimedia.org/r/651725 (owner: 10DannyS712) [08:52:04] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/RSS] - 10https://gerrit.wikimedia.org/r/652370 (owner: 10L10n-bot) [08:52:23] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/TranslationNotifications] - 10https://gerrit.wikimedia.org/r/652377 (owner: 10L10n-bot) [08:54:24] 10CheckUser, 10Schema-change: Key 'page_time' doesn't exist in table 'logging' - https://phabricator.wikimedia.org/T270902 (10Nikerabbit) [08:56:05] 10CheckUser, 10Schema-change: Key 'page_time' doesn't exist in table 'logging' - https://phabricator.wikimedia.org/T270902 (10Nikerabbit) p:05Triage→03High #7 /srv/mediawiki/workdir/extensions/CheckUser/includes/specials/SpecialCheckUser.php(2033): Wikimedia\\Rdbms\\DBConnRef->selectField('logging', '1', A... [08:57:53] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive" [extensions/RSS] - 10https://gerrit.wikimedia.org/r/652370 (owner: 10L10n-bot) [08:58:50] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive" [extensions/TranslationNotifications] - 10https://gerrit.wikimedia.org/r/652377 (owner: 10L10n-bot) [09:17:50] (03PS8) 10Pastakhov: Initial commit [extensions/LegalLogin] - 10https://gerrit.wikimedia.org/r/635890 [09:25:41] (03PS1) 10Prernaswarna: Change font and line height Pagelist description [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/652395 (https://phabricator.wikimedia.org/T232229) [09:25:43] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/652395 (https://phabricator.wikimedia.org/T232229) (owner: 10Prernaswarna) [09:44:24] 10MediaWiki-extensions-Translate, 10I18n: [[MediaWiki:Tpt-old-pages/en]] grammar issue - https://phabricator.wikimedia.org/T270854 (10Aklapper) But proper translations are currently impossible. See what I wrote before here. (Please don't re-subscribe me - thanks a lot! :) [09:54:14] 10MediaWiki-File-management, 10Commons, 10I18n: In SVG files larger than 256kB with elements, the translations are not recognized - https://phabricator.wikimedia.org/T270889 (10Aklapper) [10:04:27] 10Release, 10Train Deployments: 1.36.0-wmf.25 deployment blockers - https://phabricator.wikimedia.org/T267418 (10DannyS712) [10:04:29] 10CheckUser, 10Schema-change: Key 'page_time' doesn't exist in table 'logging' - https://phabricator.wikimedia.org/T270902 (10DannyS712) [10:04:31] 10MediaWiki-General, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), 10Schema-change, 10affects-translatewiki.net: Wikimedia\Rdbms\DBQueryError: Error 1176: Key 'times' doesn't exist in table 'logging' - https://phabricator.wikimedia.org/T270769 (10DannyS712) [10:08:42] (03CR) 10DannyS712: "This change is ready for review." [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/652253 (https://phabricator.wikimedia.org/T270902) (owner: 10DannyS712) [10:27:27] (03CR) 10Ladsgroup: [C: 04-1] "This wouldn't work in production, the index is not yet renamed in all database and will cause issues. One way to move forward is to remove" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/652253 (https://phabricator.wikimedia.org/T270902) (owner: 10DannyS712) [10:37:55] (03CR) 10DannyS712: "> Patch Set 2: Code-Review-1" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/652253 (https://phabricator.wikimedia.org/T270902) (owner: 10DannyS712) [10:50:47] 10ContentTranslation: Fix bug in the content translator: unwanted scrolling up - https://phabricator.wikimedia.org/T270625 (10Amire80) [10:52:11] (03CR) 10Ladsgroup: [C: 04-1] "> Patch Set 2:" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/652253 (https://phabricator.wikimedia.org/T270902) (owner: 10DannyS712) [11:05:02] 10ContentTranslation: The Special:ContentTranslation sometimes a bug in automatic saving occurs - https://phabricator.wikimedia.org/T268070 (10Amire80) [11:15:28] 10ContentTranslation, 10Technical-Debt (Deprecation process): fix deprecation issues on cx - https://phabricator.wikimedia.org/T260374 (10Amire80) [11:16:54] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-Majavah: Create PHPCS/ESLint rule to disallow `if else` blocks with an unnamed block likely intended as `else` - https://phabricator.wikimedia.org/T186939 (10Majavah) a:03Majavah [11:21:08] 10MediaWiki-extensions-SendGrid: Always returns "Unknown error in PHP's mail() function" error - https://phabricator.wikimedia.org/T270905 (10lucamauri) [11:27:18] 10ContentTranslation: CX2 adds nowiki around tags for no reason - https://phabricator.wikimedia.org/T214770 (10Amire80) [11:31:53] 10Accessibility, 10Wikipedia-Android-App-Backlog: Change article toolbar icon and label color to color_group_63 - https://phabricator.wikimedia.org/T270906 (10schoenbaechler) [11:33:04] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.33x-R-Rosgulla): Usability test analysis and recommendations - https://phabricator.wikimedia.org/T266884 (10schoenbaechler) Thanks @Janw – this is legit feedback. I just verified the toolbar color and it wasn’t complying our accessibility standards in “Li... [11:52:45] 10MediaWiki-Watchlist, 10Growth-Team: Watchlist grouping mode miscalculates revisions diff - https://phabricator.wikimedia.org/T174567 (10matej_suchanek) [11:53:08] 10MediaWiki-Watchlist, 10Growth-Team: Watchlist grouping mode miscalculates revisions diff - https://phabricator.wikimedia.org/T174567 (10matej_suchanek) [11:53:10] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Growth-Team: Watchlist and recent changes edits in the same minute are sorted wrong. - https://phabricator.wikimedia.org/T149558 (10matej_suchanek) [11:53:44] 10MediaWiki-Watchlist, 10Growth-Team: Watchlist grouping mode miscalculates revisions diff - https://phabricator.wikimedia.org/T174567 (10matej_suchanek) [11:59:18] (03PS1) 10Majavah: Use MovePageFactory [extensions/Flow] - 10https://gerrit.wikimedia.org/r/652398 (https://phabricator.wikimedia.org/T252934) [11:59:48] 10Release, 10Train Deployments: 1.36.0-wmf.25 deployment blockers - https://phabricator.wikimedia.org/T267418 (10Majavah) [12:24:10] 10Abstract Wikipedia: [Abstract Wikipedia data science] Modify code to make it usable from both Toolforge and outside environment - https://phabricator.wikimedia.org/T270825 (10LostEnchanter) 05Open→03Resolved [12:24:12] 10Abstract Wikipedia: [Abstract Wikipedia data science] "Quality-of-life" project modifications - https://phabricator.wikimedia.org/T270824 (10LostEnchanter) [12:36:30] 10Abstract Wikipedia: [Abstract Wikipedia data science] Unification and code commentary - https://phabricator.wikimedia.org/T270826 (10LostEnchanter) [12:37:58] 10Abstract Wikipedia: [Abstract Wikipedia data science] Unification and code commentary - https://phabricator.wikimedia.org/T270826 (10LostEnchanter) a:03LostEnchanter [12:40:17] 10Abstract Wikipedia: [Abstract Wikipedia data science] Unification and code commentary - https://phabricator.wikimedia.org/T270826 (10LostEnchanter) [12:41:36] (03PS1) 10Majavah: Deprecate User::getGrantName in favor of MWGrants::grantName [core] - 10https://gerrit.wikimedia.org/r/652399 (https://phabricator.wikimedia.org/T245963) [12:42:27] 10MediaWiki-General, 10Patch-For-Review, 10Technical-Debt (Deprecation process), 10User-DannyS712, 10User-Majavah: Deprecate User::getGrantName in favor of MWGrants::grantName - https://phabricator.wikimedia.org/T245963 (10Majavah) a:03Majavah [12:54:48] (03PS1) 10Ammarpad: Handle Logging index that's being renamed [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/652400 (https://phabricator.wikimedia.org/T270902) [12:56:36] (03PS1) 10Ammarpad: Better handling for Logging index that's being renamed [core] - 10https://gerrit.wikimedia.org/r/652401 (https://phabricator.wikimedia.org/T270769) [13:03:52] 10WMIT-Infrastructure: Install PHP-FPM in Wikimedia Italia VPS centos01 (to coexist PHP 5.6 with 7.3) - https://phabricator.wikimedia.org/T270776 (10valerio.bozzolan) WARNING: I'm working on this now. [13:05:11] (03CR) 10Ammarpad: [C: 03+2] build: Remove maxWarnings: 0 from eslint configuration [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/652279 (https://phabricator.wikimedia.org/T263922) (owner: 10Legoktm) [13:16:09] 10MediaWiki-extensions-SendGrid: Always returns "Unknown error in PHP's mail() function" error - https://phabricator.wikimedia.org/T270905 (10Aklapper) Hmm, in theory https://www.mediawiki.org/wiki/Manual:How_to_debug#PHP_errors but not sure if `mail()` exposes any error codes... [13:19:24] 10MediaWiki-extensions-SendGrid: Always returns "Unknown error in PHP's mail() function" error - https://phabricator.wikimedia.org/T270905 (10Majavah) I don't think the extension is supposed to use `mail()` at all - looking at the code it uses SendGrid's HTTP api to send the messages [13:21:29] 04(no projects): test all templates in the kaios app - https://phabricator.wikimedia.org/T270907 (10Jpita) [13:22:00] (03CR) 10Ammarpad: [C: 03+2] Drop maintenance scripts for pre-Actor migration, now no-ops [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/605872 (owner: 10Jforrester) [13:22:25] (03CR) 10Ammarpad: [C: 03+2] Drop wgActorTableSchemaMigrationStage compatibility [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/605870 (owner: 10Jforrester) [13:22:44] 10Inuka-Team (Kanban): test all templates in the kaios app - https://phabricator.wikimedia.org/T270907 (10Jpita) [13:26:03] 10SyntaxHighlight, 10Upstream: syntaxhighlight doesn't highlight "VALUES" in SPARQL - https://phabricator.wikimedia.org/T264175 (10Aklapper) 05Stalled→03Open >>! In T264175#6670961, @LucasWerkmeister wrote: > updated Pygments recently ([I0be3c1c204](https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Syn... [13:32:15] 10Phabricator, 10phabricator maintenance bot: Share the @Phabricator_maintenance account credentials (password) with at least one Phabricator Admin - https://phabricator.wikimedia.org/T141641 (10Nintendofan885) [13:33:26] (03Merged) 10jenkins-bot: build: Remove maxWarnings: 0 from eslint configuration [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/652279 (https://phabricator.wikimedia.org/T263922) (owner: 10Legoktm) [13:33:28] (03Merged) 10jenkins-bot: Drop wgActorTableSchemaMigrationStage compatibility [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/605870 (owner: 10Jforrester) [13:33:30] (03Merged) 10jenkins-bot: Drop maintenance scripts for pre-Actor migration, now no-ops [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/605872 (owner: 10Jforrester) [13:34:55] (03CR) 10Ladsgroup: [C: 03+2] "Thanks." [core] - 10https://gerrit.wikimedia.org/r/652401 (https://phabricator.wikimedia.org/T270769) (owner: 10Ammarpad) [13:35:53] 10Phabricator, 10phabricator maintenance bot: Create special maintenance account - https://phabricator.wikimedia.org/T141638 (10Nintendofan885) [13:43:55] (03CR) 10Ammarpad: "recheck" [core] - 10https://gerrit.wikimedia.org/r/651506 (https://phabricator.wikimedia.org/T147908) (owner: 10Diwanshu885) [13:44:05] 10MediaWiki-API: API sandbox should support pasting timestamps - https://phabricator.wikimedia.org/T270901 (10Base) So it was quite hastily submitted, here is a better example: I need to restore a revision for a page: * I execute an action=query&prop=deletedrevisions query and get a a timestamp like `2020-12-29... [13:44:35] (03PS1) 10Majavah: Remove usage of hard deprecated function wfIsBadImage() [extensions/PhpTagsWidgets] - 10https://gerrit.wikimedia.org/r/652402 (https://phabricator.wikimedia.org/T249459) [13:44:37] (03PS4) 10Ammarpad: Prevent rcfilters menuselect widgets from winding up behind content on some skins [core] - 10https://gerrit.wikimedia.org/r/649982 (https://phabricator.wikimedia.org/T270351) (owner: 10Isarra) [13:45:23] 10WMIT-Infrastructure: Wikimedia Italia's Kanboard: try plugin-budget - https://phabricator.wikimedia.org/T270759 (10valerio.bozzolan) WARNING: I'm working on this now to celebrate my Christmas holidays 🎉 [13:46:54] 10WMIT-Infrastructure: Wikimedia Italia's Kanboard: try plugin-budget - https://phabricator.wikimedia.org/T270759 (10valerio.bozzolan) 05Open→03Resolved Done. The user documentation is here: https://github.com/kanboard/plugin-budget/find/master#documentation [13:49:54] 10MediaWiki-General, 10MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), 10Patch-For-Review, 10Technical-Debt (Deprecation process): Hard deprecate global function wfIsBadImage and remove a release later - https://phabricator.wikimedia.org/T249459 (10Majavah) I sent patches to mediawiki/extensions/PhpTagsWidgets... [13:52:52] (03PS1) 10Majavah: Remove hard deprecated wfIsBadImage() [core] - 10https://gerrit.wikimedia.org/r/652403 (https://phabricator.wikimedia.org/T249459) [13:53:43] 10MediaWiki-General, 10MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), 10Patch-For-Review, 10Technical-Debt (Deprecation process), 10User-Majavah: Hard deprecate global function wfIsBadImage and remove a release later - https://phabricator.wikimedia.org/T249459 (10Majavah) a:03Majavah [13:55:16] (03PS2) 10Majavah: Remove hard deprecated wfIsBadImage() [core] - 10https://gerrit.wikimedia.org/r/652403 (https://phabricator.wikimedia.org/T249459) [13:57:53] 10SyntaxHighlight, 10Upstream: syntaxhighlight doesn't highlight "VALUES" in SPARQL - https://phabricator.wikimedia.org/T264175 (10LucasWerkmeister) 05Open→03Resolved Verification doesn’t hurt: {F33977566} It works \o/ [13:59:10] (03CR) 10Ammarpad: [C: 03+2] build: Remove maxWarnings: 0 from eslint configuration [extensions/Popups] - 10https://gerrit.wikimedia.org/r/652278 (https://phabricator.wikimedia.org/T263922) (owner: 10Legoktm) [14:05:19] (03Merged) 10jenkins-bot: Better handling for Logging index that's being renamed [core] - 10https://gerrit.wikimedia.org/r/652401 (https://phabricator.wikimedia.org/T270769) (owner: 10Ammarpad) [14:05:57] (03Merged) 10jenkins-bot: build: Remove maxWarnings: 0 from eslint configuration [extensions/Popups] - 10https://gerrit.wikimedia.org/r/652278 (https://phabricator.wikimedia.org/T263922) (owner: 10Legoktm) [14:13:06] (03CR) 10Ammarpad: [C: 03+2] Add data attribute to the elements with class "history-size" [core] - 10https://gerrit.wikimedia.org/r/651506 (https://phabricator.wikimedia.org/T147908) (owner: 10Diwanshu885) [14:15:36] (03PS1) 10Majavah: Soft deprecate wfIncrStats() [core] - 10https://gerrit.wikimedia.org/r/652404 (https://phabricator.wikimedia.org/T250316) [14:15:54] 10MediaWiki-General, 10Patch-For-Review, 10Technical-Debt (Deprecation process): Deprecate global function wfIncrStats - https://phabricator.wikimedia.org/T250316 (10Majavah) The only remaining use is in [[ https://www.mediawiki.org/wiki/Extension:ParsoidBatchAPI | ParsoidBatchAPI ]] which may be archived so... [14:17:55] (03PS4) 10Reedy: Update TOTP Scrach Tokens to array [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/548481 (https://phabricator.wikimedia.org/T237303) [14:18:07] (03PS5) 10Reedy: Update TOTP Scratch Tokens to array [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/548481 (https://phabricator.wikimedia.org/T237303) [14:19:53] (03CR) 10jerkins-bot: [V: 04-1] Update TOTP Scratch Tokens to array [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/548481 (https://phabricator.wikimedia.org/T237303) (owner: 10Reedy) [14:20:56] (03PS9) 10Reedy: Make import.php call delete.php as it has the same functionality [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/479901 [14:21:54] 10MediaWiki-Cache, 10Performance-Team, 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), 10Technical-Debt (Deprecation process): Deprecate and remove SquidPurgeClient classes - https://phabricator.wikimedia.org/T250417 (10Majavah) 1.36 cycle is now on-going. What would be the next step? Those classes aren't `@n... [14:22:08] (03Abandoned) 10Reedy: Updating composer/semver (1.5.1 => 2.0.0) [core] - 10https://gerrit.wikimedia.org/r/600365 (owner: 10Reedy) [14:22:59] 10MediaWiki-Special-pages, 10Patch-For-Review, 10Platform Team Workboards (Clinic Duty Team), 10Technical-Debt (Deprecation process): Deprecate and remove CachedAction, SpecialCachedPage and CacheHelper after 1.35 is branched - https://phabricator.wikimedia.org/T249230 (10Majavah) 05Stalled→03Open Movi... [14:23:42] (03CR) 10Reedy: [C: 03+2] Leave comment about adding and removing users [wikimedia/security/tooling/peek] - 10https://gerrit.wikimedia.org/r/642920 (owner: 10Reedy) [14:24:10] (03Merged) 10jenkins-bot: Leave comment about adding and removing users [wikimedia/security/tooling/peek] - 10https://gerrit.wikimedia.org/r/642920 (owner: 10Reedy) [14:25:04] (03PS3) 10Reedy: Score: Use fluidsynth instead of timidity [vagrant] - 10https://gerrit.wikimedia.org/r/634716 [14:28:07] (03PS1) 10Majavah: Remove Revision::getParentLengths() [core] - 10https://gerrit.wikimedia.org/r/652405 (https://phabricator.wikimedia.org/T248036) [14:31:48] 10InternetArchiveBot: IABot job 6943 is not working - https://phabricator.wikimedia.org/T270831 (10Nintendofan885) [14:33:06] 10InternetArchiveBot: IABot job 6943 is not working - https://phabricator.wikimedia.org/T270831 (10Nintendofan885) This is do to T269831 [14:33:26] 10Magnus Sälgö: SOFI dialects - https://phabricator.wikimedia.org/T235738 (10Salgo60) [14:33:52] 10InternetArchiveBot: IABot job 6943 is not working - https://phabricator.wikimedia.org/T270831 (10Nintendofan885) [14:33:58] 10InternetArchiveBot: IABot job queue has been stuck for weeks again - https://phabricator.wikimedia.org/T269831 (10Nintendofan885) [14:35:06] 10Magnus Sälgö: New version "SOFI namnregister" for places - https://phabricator.wikimedia.org/T235814 (10Salgo60) [14:38:47] 10Structured Data Engineering, 10Structured-Data-Backlog, 10UploadWizard: Cannot choose "of" as qualifier from suggestion box in UploadWizard - https://phabricator.wikimedia.org/T269496 (10Aklapper) [14:40:08] 10MediaWiki-extensions-Other: WindowsAzureStorage Extension - extension need to use latest Azure storage blob sdk. - https://phabricator.wikimedia.org/T256492 (10Mglaser) @Tam-edwin-microsoft I merged your changes. If you have more stuff that needs to be merged, please feel free to ping me at glaser@hallowelt.co... [14:41:14] (03Merged) 10jenkins-bot: Add data attribute to the elements with class "history-size" [core] - 10https://gerrit.wikimedia.org/r/651506 (https://phabricator.wikimedia.org/T147908) (owner: 10Diwanshu885) [14:41:58] 10MediaWiki-Revision-backend, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove Revision::newFromRow - https://phabricator.wikimedia.org/T248504 (10Majavah) Code search is claiming this has some uses in [[ https://github.com/enterprisemediawiki/WatchAnalytics | enterprisemediawiki/WatchAnalyti... [14:43:56] 10MediaWiki-Revision-backend, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove Revision::getRevisionText - https://phabricator.wikimedia.org/T248549 (10Majavah) This has some uses in Translate, one of them has a comment saying `Should only happen with MW < 1.34.` [14:44:16] (03PS2) 10Majavah: Remove multiple unused deprecated Revision methods [core] - 10https://gerrit.wikimedia.org/r/652405 (https://phabricator.wikimedia.org/T248036) [15:05:17] 10MediaWiki-User-management, 10MediaWiki-extensions-CentralAuth, 10Platform Team Initiatives (Decoupling (CDP2)): Remove UserRightsProxy and replace it's usages with UserGroupManager - https://phabricator.wikimedia.org/T255309 (10Majavah) [15:11:58] (03CR) 10jerkins-bot: [V: 04-1] Remove multiple unused deprecated Revision methods [core] - 10https://gerrit.wikimedia.org/r/652405 (https://phabricator.wikimedia.org/T248036) (owner: 10Majavah) [15:13:59] (03PS3) 10Majavah: Remove multiple unused deprecated Revision methods [core] - 10https://gerrit.wikimedia.org/r/652405 (https://phabricator.wikimedia.org/T248036) [15:34:52] 10Phabricator: Create special maintenance account - https://phabricator.wikimedia.org/T141638 (10Nintendofan885) [15:36:03] 10Phabricator: Share the @Phabricator_maintenance account credentials (password) with at least one Phabricator Admin - https://phabricator.wikimedia.org/T141641 (10Nintendofan885) [15:42:18] 10MediaWiki-extensions-Score, 10Operations, 10Security-Team, 10Wikimedia-General-or-Unknown, and 2 others: Extension:Score / Lilypond is disabled on all wikis - https://phabricator.wikimedia.org/T257066 (10Ipatrol) tstarling, do you know why it currently works so long as the vorbis=1 parameter is removed?... [15:46:14] (03PS3) 10Majavah: Update GlobalBlocking to use the new HookContainer/HookRunner system [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/652184 (https://phabricator.wikimedia.org/T270871) [15:48:12] (03CR) 10Majavah: Update GlobalBlocking to use the new HookContainer/HookRunner system (033 comments) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/652184 (https://phabricator.wikimedia.org/T270871) (owner: 10Majavah) [15:50:19] 10MediaWiki-extensions-Score, 10Operations, 10Security-Team, 10Wikimedia-General-or-Unknown, and 2 others: Extension:Score / Lilypond is disabled on all wikis - https://phabricator.wikimedia.org/T257066 (10Ipatrol) Also, I need to know what "time" means here, because the above fact means that it's possible... [16:01:15] 10MediaWiki-extensions-Translate, 10I18n: [[MediaWiki:Tpt-old-pages/en]] grammar issue - https://phabricator.wikimedia.org/T270854 (10Tacsipacsi) I could perfectly translate this for example into German: ` {{PLURAL:$1|Die neuste Version dieser Seite ist|Die neusten Versionen dieser Seiten sind}} zur Übersetzun... [16:02:13] 10WMIT-Infrastructure: Deploy a Matomo instance in matomo.wikimedia.it - https://phabricator.wikimedia.org/T270746 (10valerio.bozzolan) Note that the new DNS record `matomo.wikimedia.it` is not available yet. ` $ nslookup matomo.wikimedia.it ** server can't find matomo.wikimedia.it: NXDOMAIN ` [16:10:05] 10Phabricator, 10Performance Issue: Herald rules causing delays to task edit saves - getting worse - https://phabricator.wikimedia.org/T108586 (10Aklapper) >>! In T108586#6711982, @Ladsgroup wrote: > @Aklapper Hey, is it fine if we move the group 4 herald rules to maintenance bot? Is there any general info av... [16:25:20] 10MediaWiki-extensions-General, 10MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), 10Patch-For-Review, 10Platform Team Workboards (External Code Reviews), and 2 others: Wikimedia deployed extensions need uses of global $wgOut removed - https://phabricator.wikimedia.org/T252978 (10Majavah) [16:40:10] 10MediaWiki-extensions-Score, 10Operations, 10Security-Team, 10Wikimedia-General-or-Unknown, and 2 others: Extension:Score / Lilypond is disabled on all wikis - https://phabricator.wikimedia.org/T257066 (10Reedy) You'll have to ask the people working on it. You probably won't get an answer till next week.... [17:01:59] (03PS1) 10Jack Phoenix: Fix Vector themes for MW 1.35, bump ext. version number + explicitly require MW 1.35(+) [extensions/Theme] - 10https://gerrit.wikimedia.org/r/652406 [17:05:00] 10MediaWiki-extensions-GWToolset, 10Commons, 10GLAM, 10Community-consensus-needed: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Multichill) [17:07:41] 10AbuseFilter, 10Wikimedia-Site-requests, 10Wikimedia-abusefilter-global-maintainers: Devise a strategy for optimal utilization of abusefilter-maintainers group - https://phabricator.wikimedia.org/T251051 (10Majavah) Does this task have anything actionable remaining or can it be closed? [17:11:26] 10MediaWiki-extensions-CodeMirror, 10Community-Tech: Syntax highlighting does not recognise slash in tag parameter string correctly - https://phabricator.wikimedia.org/T270880 (10Aklapper) [17:11:28] 10MediaWiki-extensions-Page_Forms: Add example to #arraymap function documentation - https://phabricator.wikimedia.org/T270869 (10Aklapper) [17:11:51] 10MediaWiki-extensions-GWToolset, 10Commons, 10GLAM, 10Community-consensus-needed: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Multichill) [17:11:53] 10MediaWiki-extensions-GWToolset, 10Commons, 10GLAM, 10Community-consensus-needed: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Fuzheado) I concur with this - for the GLAM community, we have not recommended GWToolset at all in the last two years, and have... [17:12:02] 10MediaWiki-File-management, 10SRE-swift-storage, 10Wikimedia-production-error: Cannot delete one image file on Thai Wikipedia: Error deleting file: An unknown error occurred in storage backend "local-multiwrite" - https://phabricator.wikimedia.org/T270811 (10Aklapper) Thanks for reporting this. For future r... [17:12:04] 10MediaWiki-File-management, 10SRE-swift-storage, 10Wikimedia-production-error: Cannot delete one image file on Thai Wikipedia: Error deleting file: An unknown error occurred in storage backend "local-multiwrite" - https://phabricator.wikimedia.org/T270811 (10Aklapper) [17:13:02] 10MediaWiki-Debug-Logger, 10MediaWiki-extensions-Other, 10Technical-Debt (Deprecation process), 10User-DannyS712: Consider removing wfIncrStats - https://phabricator.wikimedia.org/T264977 (10Majavah) [17:13:05] 10MediaWiki-General, 10Patch-For-Review, 10Technical-Debt (Deprecation process): Deprecate global function wfIncrStats - https://phabricator.wikimedia.org/T250316 (10Majavah) [17:49:32] 10MediaWiki-extensions-GWToolset, 10Commons, 10GLAM, 10Wikimedia-Site-requests, and 2 others: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Reedy) [17:51:58] 10MediaWiki-extensions-GWToolset, 10Commons, 10GLAM, 10Wikimedia-Site-requests, and 2 others: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Reedy) I support this generally. Do we know how widely it's actually used? Obviously that needs to be a factor, mak... [17:54:59] 10MediaWiki-extensions-GWToolset, 10Commons, 10GLAM, 10Wikimedia-Site-requests, and 2 others: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Wittylama) >>! In T270911#6713903, @Reedy wrote: > Do we know how widely it's actually used? It is rarely used, and... [17:57:08] 10MediaWiki-extensions-GWToolset, 10Commons, 10GLAM, 10Wikimedia-Site-requests, and 2 others: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Majavah) The [[ https://commons.wikimedia.org/wiki/Special:ListUsers/gwtoolset | user group ]] is currently granted... [17:57:51] 10MediaWiki-extensions-GWToolset, 10Commons, 10GLAM, 10Wikimedia-Site-requests, and 2 others: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Reedy) >>! In T270911#6713918, @Wittylama wrote: >>>! In T270911#6713903, @Reedy wrote: >> Do we know how widely it'... [18:05:53] 10Thumbor: Some SVG elements failed to convert into PNG image because they are refering another elements - https://phabricator.wikimedia.org/T270630 (10SiBr4) The same issue occurred on the Olympic flag files [[ https://commons.wikimedia.org/wiki/User_talk:SiBr4#File:Flag_of_the_Solomon_Islands.svg |... [18:07:06] 10MediaWiki-General: writeapi permission required for * group even if logged in for rest.php - https://phabricator.wikimedia.org/T270916 (10Paladox) [18:07:49] 10MediaWiki-General: writeapi permission required for * group even if logged in for rest.php - https://phabricator.wikimedia.org/T270916 (10Paladox) [18:10:27] 10MediaWiki-extensions-GWToolset, 10Commons, 10GLAM, 10Wikimedia-Site-requests, and 2 others: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Reedy) So since 2016, ~550K log entries: `lang=sql MariaDB [commonswiki]> select COUNT(ct_id) from change_tag where... [18:13:46] 10MediaWiki-extensions-GWToolset, 10Commons, 10GLAM, 10Wikimedia-Site-requests, and 2 others: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Multichill) Thanks Sam, can you do a per user per year breakdown? I expect a small number of users with a lot of upl... [18:16:51] 10Thumbor: Some SVG elements failed to convert into PNG image because they are refering another elements - https://phabricator.wikimedia.org/T270630 (10Great_Brightstar) [18:17:52] 10MediaWiki-extensions-GWToolset, 10Commons, 10GLAM, 10Wikimedia-Site-requests, and 2 others: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Reedy) And in a bit more of a graphical format `lang=csv, lines=10 2016-02, 7578 2016-03, 3907 2016-04, 4889 2016-0... [18:21:54] 10MediaWiki-extensions-GWToolset, 10Commons, 10GLAM, 10Wikimedia-Site-requests, and 2 others: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Reedy) Totals per year... `lang=sql MariaDB [commonswiki]> select YEAR(log_timestamp), count(ct_id) from change_tag... [18:24:57] 10MediaWiki-REST-API, 10Parsoid, 10VisualEditor: writeapi permission required for * group even if logged in for rest.php - https://phabricator.wikimedia.org/T270916 (10Reedy) [18:29:21] (03CR) 10Bartosz Dziewoński: [C: 03+2] Use LESS nesting in messageBoxes.less [core] - 10https://gerrit.wikimedia.org/r/651982 (owner: 10Esanders) [18:30:09] 10MediaWiki-extensions-GWToolset, 10Commons, 10GLAM, 10Wikimedia-Site-requests, and 2 others: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Reedy) >>! In T270911#6713923, @Majavah wrote: > The [[ https://commons.wikimedia.org/wiki/Special:ListUsers/gwtools... [18:43:00] 10MediaWiki-REST-API, 10Parsoid, 10VisualEditor: writeapi permission required for * group even if logged in for rest.php - https://phabricator.wikimedia.org/T270916 (10Paladox) Seems to affect Flow only, works with VE. [18:45:51] 10MediaWiki-REST-API, 10Parsoid, 10VisualEditor: writeapi permission required for * group even if logged in for rest.php - https://phabricator.wikimedia.org/T270916 (10Paladox) URL: "https://test2.miraheze.org/w/rest.php/test2.miraheze.org/v3/transform/wikitext/to/html/Topic%3AVz5uwxnb5dt80i8u" [18:50:24] (03CR) 10Reedy: [C: 04-1] Update SpecialRenameuser to inject services (031 comment) [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/652179 (owner: 10Majavah) [18:52:04] (03Merged) 10jenkins-bot: Use LESS nesting in messageBoxes.less [core] - 10https://gerrit.wikimedia.org/r/651982 (owner: 10Esanders) [18:56:59] 10MediaWiki-extensions-Pluggable-Auth: PluggableAuth: Add hook when users are created - https://phabricator.wikimedia.org/T270918 (10MarkAHershberger) [18:58:14] (03PS2) 10Majavah: Update SpecialRenameuser to inject services [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/652179 [19:07:25] 10ULS-CompactLinks, 10UniversalLanguageSelector: CLL - double entries for language selection - https://phabricator.wikimedia.org/T191272 (10Amire80) [19:08:35] (03CR) 10Reedy: [C: 04-1] Update SpecialRenameuser to inject services (037 comments) [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/652179 (owner: 10Majavah) [19:14:33] (03PS3) 10Majavah: Update SpecialRenameuser to inject services [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/652179 [19:14:38] (03CR) 10Majavah: Update SpecialRenameuser to inject services (037 comments) [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/652179 (owner: 10Majavah) [19:14:50] (03CR) 10Majavah: Update SpecialRenameuser to inject services (031 comment) [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/652179 (owner: 10Majavah) [19:22:39] 10MediaWiki-extensions-Pluggable-Auth: PluggableAuth: Add hook when users are created - https://phabricator.wikimedia.org/T270918 (10MarkAHershberger) I guess what I'm saying is; Should I just use the UserAuthorization hook? It looks like I should, so feel free to WONTFIX. Still, I'm leery of the possibility t... [19:26:12] 10MediaWiki-extensions-GWToolset, 10Commons, 10GLAM, 10Wikimedia-Site-requests, and 2 others: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Reedy) Is there much work to migrate from GWToolset to Pattypan? It feels like one of those if there's not, and no... [19:29:22] (03CR) 10Reedy: [C: 04-1] Update SpecialRenameuser to inject services (031 comment) [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/652179 (owner: 10Majavah) [19:31:14] (03PS4) 10Majavah: Update SpecialRenameuser to inject services [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/652179 [19:32:35] (03CR) 10Majavah: Update SpecialRenameuser to inject services (031 comment) [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/652179 (owner: 10Majavah) [19:39:15] 10MediaWiki-File-management, 10SRE-swift-storage, 10Wikimedia-production-error: Cannot delete one image file on Thai Wikipedia: Error deleting file: An unknown error occurred in storage backend "local-multiwrite" - https://phabricator.wikimedia.org/T270811 (10Timekeepertmk) Thank you for your suggestion and... [19:58:56] 10MediaWiki-extensions-GWToolset, 10Commons, 10GLAM, 10Wikimedia-Site-requests, and 2 others: Remove GWToolset extension from Wikimedia Commons - https://phabricator.wikimedia.org/T270911 (10Wittylama) >>! In T270911#6713999, @Reedy wrote: > Is there much work to migrate from GWToolset to Pattypan? What d... [19:59:29] 10MediaWiki-General, 10Technical-Debt (Deprecation process): Deprecate $wgConf - https://phabricator.wikimedia.org/T212739 (10Majavah) As far as I can see the SiteConfiguration class/$wgConf has two distinct purposes. First, it can configure MediaWiki based on the current wiki's database name and "wiki tags" w... [20:11:08] (03CR) 10Reedy: [C: 03+2] build: Add .eslintignore [extensions/AddHTMLMetaAndTitle] - 10https://gerrit.wikimedia.org/r/652271 (owner: 10Legoktm) [20:15:27] (03Merged) 10jenkins-bot: build: Add .eslintignore [extensions/AddHTMLMetaAndTitle] - 10https://gerrit.wikimedia.org/r/652271 (owner: 10Legoktm) [20:19:42] 10MediaWiki-General, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), 10Schema-change, 10affects-translatewiki.net: Wikimedia\Rdbms\DBQueryError: Error 1176: Key 'times' doesn't exist in table 'logging' - https://phabricator.wikimedia.org/T270769 (10Umherirrender) In the past there was some index alias support... [20:24:24] 10WMIT-Infrastructure: Install PHP-FPM in Wikimedia Italia VPS centos01 (to coexist PHP 5.6 with 7.3) - https://phabricator.wikimedia.org/T270776 (10valerio.bozzolan) 05Open→03Resolved Here the intervention interaction: ` $ sudo yum -y install centos-release-scl.noarch Loaded plugins: fastestmirror Loading... [20:24:26] 10WMIT-Infrastructure: Deploy a Matomo instance in matomo.wikimedia.it - https://phabricator.wikimedia.org/T270746 (10valerio.bozzolan) [20:27:55] 10MediaWiki-Codesniffer: phpcs should treat {@inheritDoc} like @inheritDoc - https://phabricator.wikimedia.org/T270830 (10Umherirrender) The extra {} are not used on mediawiki code style (at least on single tags) and therefor not detected as valid tag. [20:29:26] (03CR) 10DannyS712: [C: 04-1] "Per https://gerrit.wikimedia.org/r/c/mediawiki/core/+/614027/ we are waiting until 1.37 to remove the Revision stuff" [core] - 10https://gerrit.wikimedia.org/r/652405 (https://phabricator.wikimedia.org/T248036) (owner: 10Majavah) [20:30:10] (03PS1) 10David Kamholz: Support single-page file formats [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/652408 (https://phabricator.wikimedia.org/T270924) [20:30:30] 10MediaWiki-REST-API, 10Growth-Team, 10Parsoid, 10StructuredDiscussions: writeapi permission required for * group even if logged in for rest.php - https://phabricator.wikimedia.org/T270916 (10Universal_Omega) [20:34:22] (03CR) 10jerkins-bot: [V: 04-1] Support single-page file formats [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/652408 (https://phabricator.wikimedia.org/T270924) (owner: 10David Kamholz) [20:36:31] (03PS1) 10Amire80: Remove an unnecessary space in a message [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/652410 [20:37:59] 10Mathe für Nicht-Freaks: Epimorphismus: Satz zur Äquivalente Charakterisierung auch für nicht endlich erzeuge VR hinzufügen - https://phabricator.wikimedia.org/T270261 (10Mathewally) a:03Mathewally [20:38:23] 10Mathe für Nicht-Freaks: Epimorphismus: Satz zur Äquivalente Charakterisierung auch für nicht endlich erzeuge VR hinzufügen - https://phabricator.wikimedia.org/T270261 (10Mathewally) Satz ergänzt [20:38:44] 10MediaWiki-Codesniffer: phpcs ObjectTypeHintParam is incorrect. - https://phabricator.wikimedia.org/T269332 (10Umherirrender) Various extensions get fixed in the past weeks https://codesearch.wmcloud.org/search/?q=ObjectTypeHint&i=nope&files=&repos= Some libs are not fixable, because there are valid use cases... [20:40:26] 10MediaWiki-extensions-General, 10MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), 10MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), 10Patch-For-Review, and 2 others: WMF deployed extensions need uses of global $wgUser removed [tracking] - https://phabricator.wikimedia.org/T245959 (10DannyS712) [20:46:12] (03PS1) 10Reedy: Updating christian-riesen/base32 (1.3.2 => 1.4.0) [vendor] - 10https://gerrit.wikimedia.org/r/652411 [20:46:36] (03PS1) 10Reedy: Update christian-riesen/base32 (1.3.2 => 1.4.0 [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/652412 [20:48:50] (03CR) 10Majavah: "ah, I just read your comments that said "Cannot be removed until 1.36". I'll abandon if the whole class is going to be removed then anyway" [core] - 10https://gerrit.wikimedia.org/r/652405 (https://phabricator.wikimedia.org/T248036) (owner: 10Majavah) [20:49:17] (03Abandoned) 10Majavah: Remove multiple unused deprecated Revision methods [core] - 10https://gerrit.wikimedia.org/r/652405 (https://phabricator.wikimedia.org/T248036) (owner: 10Majavah) [20:56:16] (03CR) 10DannyS712: [C: 03+2] "hard deprecated in 1.35" [core] - 10https://gerrit.wikimedia.org/r/652403 (https://phabricator.wikimedia.org/T249459) (owner: 10Majavah) [20:57:05] (03CR) 10DannyS712: [C: 04-1] Remove usage of hard deprecated function wfIsBadImage() (031 comment) [extensions/PhpTagsWidgets] - 10https://gerrit.wikimedia.org/r/652402 (https://phabricator.wikimedia.org/T249459) (owner: 10Majavah) [20:59:34] (03Abandoned) 10Majavah: Remove usage of hard deprecated function wfIsBadImage() [extensions/PhpTagsWidgets] - 10https://gerrit.wikimedia.org/r/652402 (https://phabricator.wikimedia.org/T249459) (owner: 10Majavah) [21:00:43] 10MediaWiki-General, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove the Revision class [1.37] - https://phabricator.wikimedia.org/T247143 (10DannyS712) [21:00:51] 10MediaWiki-General, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove the Revision class [1.37] - https://phabricator.wikimedia.org/T247143 (10DannyS712) [21:01:09] 10MediaWiki-General, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove the Revision class [1.37] - https://phabricator.wikimedia.org/T247143 (10DannyS712) [21:01:13] 10MediaWiki-Revision-backend, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove Revision::newFromPageId - https://phabricator.wikimedia.org/T248424 (10DannyS712) 05Open→03Stalled Reflect decision to wait until 1.37 for Revision removals [21:01:14] (03PS1) 10Reedy: Remove & from parameters that are objects [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/652413 [21:01:16] 10MediaWiki-Revision-backend, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove Revision::getParentLengths - https://phabricator.wikimedia.org/T248036 (10DannyS712) 05Open→03Stalled Reflect decision to wait until 1.37 for Revision removals [21:01:18] 10MediaWiki-General, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove the Revision class [1.37] - https://phabricator.wikimedia.org/T247143 (10DannyS712) [21:01:20] 10MediaWiki-Revision-backend, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove Revision::getTimestampFromId - https://phabricator.wikimedia.org/T248423 (10DannyS712) 05Open→03Stalled Reflect decision to wait until 1.37 for Revision removals [21:01:33] 10MediaWiki-Revision-backend, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove Revision::userCanBitfield - https://phabricator.wikimedia.org/T246411 (10DannyS712) 05Open→03Stalled Reflect decision to wait until 1.37 for Revision removals [21:01:46] 10MediaWiki-General, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove the Revision class [1.37] - https://phabricator.wikimedia.org/T247143 (10DannyS712) [21:01:54] 10MediaWiki-Revision-backend, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove Revision::newFromRow - https://phabricator.wikimedia.org/T248504 (10DannyS712) 05Open→03Stalled Reflect decision to wait until 1.37 for Revision removals [21:01:56] 10MediaWiki-General, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove the Revision class [1.37] - https://phabricator.wikimedia.org/T247143 (10DannyS712) [21:01:58] 10MediaWiki-Revision-backend, 10MediaWiki-extensions-Duplicator, 10Patch-For-Review, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove Revision::newNullRevision - https://phabricator.wikimedia.org/T245703 (10DannyS712) 05Open→03Stalled Reflect decision to wait until 1.37 for Revision r... [21:02:00] 10MediaWiki-General, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove the Revision class [1.37] - https://phabricator.wikimedia.org/T247143 (10DannyS712) [21:02:02] 10MediaWiki-General, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove the Revision class [1.37] - https://phabricator.wikimedia.org/T247143 (10DannyS712) [21:02:13] 10MediaWiki-Revision-backend, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove Revision::newFromTitle - https://phabricator.wikimedia.org/T250705 (10DannyS712) 05Open→03Stalled Reflect decision to wait until 1.37 for Revision removals [21:02:14] 10MediaWiki-Revision-backend, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove Revision::getRevisionText - https://phabricator.wikimedia.org/T248549 (10DannyS712) 05Open→03Stalled Reflect decision to wait until 1.37 for Revision removals [21:02:17] 10MediaWiki-General, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove the Revision class [1.37] - https://phabricator.wikimedia.org/T247143 (10DannyS712) [21:02:21] 10MediaWiki-Revision-backend, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove Revision::newFromId - https://phabricator.wikimedia.org/T254704 (10DannyS712) 05Open→03Stalled Reflect decision to wait until 1.37 for Revision removals [21:04:16] 10MediaWiki-Revision-backend, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove Revision::getRevisionText - https://phabricator.wikimedia.org/T248549 (10DannyS712) >>! In T248549#6713735, @Majavah wrote: > This has some uses in Translate, one of them has a comment saying `Should only happen wi... [21:05:07] (03CR) 10jerkins-bot: [V: 04-1] Remove & from parameters that are objects [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/652413 (owner: 10Reedy) [21:05:36] 10MediaWiki-Codesniffer, 10Patch-For-Review: False positive MediaWiki.Commenting.PropertyDocumentation.NotPunctuationVarType - https://phabricator.wikimedia.org/T268087 (10Umherirrender) p:05Triage→03Medium a:03Umherirrender [21:05:51] (03PS2) 10Reedy: Remove & from parameters that are objects [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/652413 [21:08:56] 10MediaWiki-Codesniffer, 10PHP 8.0 support, 10User-DannyS712: Create sniff for `match` errors in PHP 8.0 - https://phabricator.wikimedia.org/T267689 (10Umherirrender) `php -l`/parallel-lint would fail when running with php8 - but the newer versions are not running as part of the normal pipeline and in the pa... [21:11:37] (03CR) 10Umherirrender: [V: 03+2] "no jenkins here" [extensions/LDAPSyncAll] - 10https://gerrit.wikimedia.org/r/652023 (owner: 10Libraryupgrader) [21:12:17] (03PS3) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/650719 (owner: 10Libraryupgrader) [21:13:41] (03CR) 10DannyS712: [C: 03+2] Remove & from parameters that are objects [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/652413 (owner: 10Reedy) [21:14:41] (03CR) 10DannyS712: [C: 03+2] Remove an unnecessary space in a message [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/652410 (owner: 10Amire80) [21:14:53] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/650869 (owner: 10Libraryupgrader) [21:16:48] 10MediaWiki-extensions-Score, 10Operations, 10Security-Team, 10Wikimedia-General-or-Unknown, and 2 others: Extension:Score / Lilypond is disabled on all wikis - https://phabricator.wikimedia.org/T257066 (10Nemo_bis) >>! In T257066#6713124, @Ipatrol wrote: > Assuming the problem is the CVE, Debian [[ https:... [21:17:24] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/650831 (owner: 10Libraryupgrader) [21:17:38] (03CR) 10DannyS712: [C: 04-1] Update SpecialRenameuser to inject services (034 comments) [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/652179 (owner: 10Majavah) [21:20:36] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/650932 (owner: 10Libraryupgrader) [21:22:19] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/650831 (owner: 10Libraryupgrader) [21:23:17] (03CR) 10Amire80: "> Patch Set 1:" [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/652267 (https://phabricator.wikimedia.org/T270809) (owner: 10BryanDavis) [21:24:03] (03PS3) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/650897 (owner: 10Libraryupgrader) [21:24:27] (03Merged) 10jenkins-bot: Remove hard deprecated wfIsBadImage() [core] - 10https://gerrit.wikimedia.org/r/652403 (https://phabricator.wikimedia.org/T249459) (owner: 10Majavah) [21:24:30] (03Merged) 10jenkins-bot: Remove & from parameters that are objects [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/652413 (owner: 10Reedy) [21:24:32] (03Merged) 10jenkins-bot: Remove an unnecessary space in a message [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/652410 (owner: 10Amire80) [21:26:10] (03CR) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 (032 comments) [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/650932 (owner: 10Libraryupgrader) [21:26:41] (03PS2) 10Amire80: Fix the message "The language in which this toolinfo..." [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/651912 [21:28:16] (03PS4) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/650897 (owner: 10Libraryupgrader) [21:33:03] (03CR) 10Esanders: Added bracket matching (031 comment) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/647320 (https://phabricator.wikimedia.org/T261857) (owner: 10Svantje Lilienthal) [21:33:15] (03PS3) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/650831 (owner: 10Libraryupgrader) [21:33:48] (03CR) 10Esanders: [C: 04-1] "This change is ready for review." [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/649593 (https://phabricator.wikimedia.org/T269094) (owner: 10Svantje Lilienthal) [21:34:07] (03PS4) 10Esanders: Integrated bracket matching for CodeMirror with VisualEditor [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/649593 (https://phabricator.wikimedia.org/T269094) (owner: 10Svantje Lilienthal) [21:34:15] (03CR) 10jerkins-bot: [V: 04-1] Integrated bracket matching for CodeMirror with VisualEditor [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/649593 (https://phabricator.wikimedia.org/T269094) (owner: 10Svantje Lilienthal) [21:34:22] (03PS5) 10Esanders: Integrated bracket matching for CodeMirror with VisualEditor [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/649593 (https://phabricator.wikimedia.org/T269094) (owner: 10Svantje Lilienthal) [21:36:40] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/650831 (owner: 10Libraryupgrader) [21:37:13] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/650893 (owner: 10Libraryupgrader) [21:41:47] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/650833 (owner: 10Libraryupgrader) [21:45:33] (03PS4) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/650831 (owner: 10Libraryupgrader) [21:49:41] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/650831 (owner: 10Libraryupgrader) [21:52:55] 10MediaWiki-extensions-CodeMirror, 10Community-Tech: Refine bracket matching styling - https://phabricator.wikimedia.org/T270926 (10Esanders) [21:53:13] (03PS5) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/650831 (owner: 10Libraryupgrader) [21:53:55] (03CR) 10Umherirrender: "[It seems taint-check cannot track the taintness of array keys when using compact()]" [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/650831 (owner: 10Libraryupgrader) [21:55:41] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/650897 (owner: 10Libraryupgrader) [21:57:11] 10MediaWiki-General, 10MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), 10Technical-Debt (Deprecation process), 10User-Majavah: Hard deprecate global function wfIsBadImage and remove a release later - https://phabricator.wikimedia.org/T249459 (10DannyS712) 05Open→03Resolved [21:58:32] (03PS1) 10Umherirrender: Replace compact() with real array [extensions/AddPersonalUrls] - 10https://gerrit.wikimedia.org/r/652416 [22:00:47] (03PS1) 10Umherirrender: Replace compact() with real array [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/652417 [22:02:11] (03PS1) 10Umherirrender: Replace compact() with real array [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/652418 [22:02:30] (03PS6) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/650831 (owner: 10Libraryupgrader) [22:02:47] (03CR) 10jerkins-bot: [V: 04-1] Replace compact() with real array [extensions/AddPersonalUrls] - 10https://gerrit.wikimedia.org/r/652416 (owner: 10Umherirrender) [22:03:03] (03PS7) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/650831 (owner: 10Libraryupgrader) [22:07:03] (03PS2) 10Umherirrender: Replace compact() with real array [extensions/AddPersonalUrls] - 10https://gerrit.wikimedia.org/r/652416 [22:09:28] 10MediaWiki-extensions-CodeMirror, 10Community-Tech: Refine bracket matching styling - https://phabricator.wikimedia.org/T270926 (10Esanders) Atom/Sublime style: {F33977965} `lang=less &.CodeMirror-matchingbracket { color: inherit; border-bottom: 1px solid #000; } ` Ace/VSCode style: {F33977963} `lang=less... [22:11:37] (03CR) 10jerkins-bot: [V: 04-1] Replace compact() with real array [extensions/AddPersonalUrls] - 10https://gerrit.wikimedia.org/r/652416 (owner: 10Umherirrender) [22:14:05] (03PS3) 10Umherirrender: Replace compact() with real array [extensions/AddPersonalUrls] - 10https://gerrit.wikimedia.org/r/652416 [22:14:56] (03CR) 10Esanders: Integrated bracket matching for CodeMirror with VisualEditor (031 comment) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/649593 (https://phabricator.wikimedia.org/T269094) (owner: 10Svantje Lilienthal) [22:17:20] (03PS5) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/650897 (owner: 10Libraryupgrader) [22:17:59] 04(no projects): Double slash bug for resource URLs on MW 1.36-alpha (f7cba78) with Vector (c5a6164) - https://phabricator.wikimedia.org/T269955 (10Aklapper) 05Stalled→03Declined Unfortunately closing this Phabricator task as no further information has been provided. @ishlo_je: After you have provided the... [22:18:14] 10MediaWiki-extensions-CodeMirror, 10Community-Tech: Refine bracket matching styling - https://phabricator.wikimedia.org/T270926 (10Esanders) [22:18:20] (03PS3) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.6 [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/650893 (owner: 10Libraryupgrader) [22:25:26] (03CR) 10Esanders: TableDiffFormatter: Build HTML using utility class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/652191 (owner: 10Esanders) [22:25:47] (03PS2) 10Esanders: TableDiffFormatter: Build HTML using utility class [core] - 10https://gerrit.wikimedia.org/r/652191 [22:25:49] (03PS5) 10Esanders: Create diff markers with CSS [core] - 10https://gerrit.wikimedia.org/r/651809 [22:25:51] (03PS7) 10Esanders: POC Re-arrange diff into a grid layout [core] - 10https://gerrit.wikimedia.org/r/651830 (https://phabricator.wikimedia.org/T270775) [22:26:32] (03PS1) 10Umherirrender: Fix object docs and remove return value from hook [extensions/ArticleIndex] - 10https://gerrit.wikimedia.org/r/652419 [22:31:11] (03PS1) 10Umherirrender: Improve some docs [extensions/BlueSpiceBookshelf] - 10https://gerrit.wikimedia.org/r/652420 [22:32:59] (03PS1) 10Umherirrender: Fix documentation about stdClass as object type [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/652421 [22:34:34] (03PS1) 10Umherirrender: Fix documentation about array as object type [extensions/DebugTemplates] - 10https://gerrit.wikimedia.org/r/652422 [22:38:29] (03PS1) 10Umherirrender: Improve some param docs [extensions/HitCounters] - 10https://gerrit.wikimedia.org/r/652423 [22:42:57] (03PS1) 10Umherirrender: Fix documentation about stdClass as object type [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/652424 [22:44:02] (03PS1) 10Umherirrender: Fix documentation about stdClass as object type [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/652425 [22:46:34] (03PS1) 10Umherirrender: Fix documentation about stdClass as object type [extensions/OdbcDatabase] - 10https://gerrit.wikimedia.org/r/652426 [22:47:25] (03PS3) 10BryanDavis: i18n: Add @intlify/eslint-plugin-vue-i18n linter [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/652218 [22:47:45] (03PS1) 10Umherirrender: Fix documentation about stdClass as object type [extensions/ProtectionIndicator] - 10https://gerrit.wikimedia.org/r/652427 [22:48:08] (03PS2) 10BryanDavis: i18n: Document parameters & plurals; tense change [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/652267 (https://phabricator.wikimedia.org/T270809) [22:58:12] (03PS1) 10Umherirrender: Fix documentation about array as object type [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/652429 [22:59:05] (03PS1) 10Umherirrender: Fix documentation stdClass array as object type [extensions/THICC] - 10https://gerrit.wikimedia.org/r/652430 [22:59:53] (03PS1) 10Umherirrender: Fix documentation about stdClass as object type [extensions/UnusedRedirects] - 10https://gerrit.wikimedia.org/r/652431 [23:02:21] (03CR) 10jerkins-bot: [V: 04-1] Fix documentation about stdClass as object type [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/652424 (owner: 10Umherirrender) [23:04:26] 10MediaWiki-extensions-Pluggable-Auth: PluggableAuth: Add hook when users are created - https://phabricator.wikimedia.org/T270918 (10cicalese) p:05Triage→03Low I think it would be best to use the UserAuthorization hook for now. I have plans to do some refactoring. I don't anticipate that hook changing place,... [23:04:44] (03PS1) 10Umherirrender: Use real types instead of object type in documentation [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/652433 [23:14:22] (03PS1) 10Umherirrender: Use real types instead of object type in documentation [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/652434 [23:15:54] (03PS1) 10Umherirrender: Use real types instead of object type in documentation [extensions/BlueSpiceNSFileRepoConnector] - 10https://gerrit.wikimedia.org/r/652435 [23:17:21] (03PS1) 10Umherirrender: Use real types instead of object type in documentation [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/652436 [23:18:13] (03PS1) 10Umherirrender: Fix documentation about stdClass as object type [extensions/BlueSpicePageTemplates] - 10https://gerrit.wikimedia.org/r/652437 [23:19:01] (03PS1) 10Umherirrender: Fix documentation about stdClass as object type [extensions/BlueSpiceRSSFeeder] - 10https://gerrit.wikimedia.org/r/652438 [23:19:05] (03CR) 10Cicalese: [C: 04-1] "-1 due to concerns about potentially overwriting the value of $id. Should it check to see if $id is set first?" (031 comment) [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652220 (https://phabricator.wikimedia.org/T270056) (owner: 10MarkAHershberger) [23:20:24] (03CR) 10Cicalese: [C: 03+1] Reduce code duplication by creating a protected getAuthManager() [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652010 (owner: 10MarkAHershberger) [23:21:29] (03PS1) 10Umherirrender: Fix documentation about array as object type [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/652439 [23:22:15] (03PS1) 10Umherirrender: Fix documentation about array as object type [extensions/BlueSpiceSocialBlog] - 10https://gerrit.wikimedia.org/r/652440 [23:23:00] (03PS1) 10Umherirrender: Fix documentation about array as object type [extensions/BlueSpiceSocialWikiPage] - 10https://gerrit.wikimedia.org/r/652441 [23:24:46] (03PS1) 10Umherirrender: Fix documentation about stdClass as object type [extensions/BlueSpiceUEModuleBookPDF] - 10https://gerrit.wikimedia.org/r/652442 [23:25:24] (03CR) 10Cicalese: [C: 03+1] Refactor individual local/ldap checking bits into protected methods [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/652190 (https://phabricator.wikimedia.org/T270885) (owner: 10MarkAHershberger) [23:26:22] (03PS1) 10Umherirrender: Fix documentation about stdClass as object type [extensions/BlueSpiceWikiExplorer] - 10https://gerrit.wikimedia.org/r/652443 [23:27:51] (03PS1) 10Umherirrender: build: Explict exclude object type hint inline [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/652444