[00:00:00] 10DiscussionTools, 10OWC2020, 10Editing-team (FY2020-21 Kanban Board): Publish A/B test rationale on mediawiki.org - https://phabricator.wikimedia.org/T267381 (10ppelberg) [00:01:48] 10Growth-Team (Current Sprint): Document deployment process for Growth features - https://phabricator.wikimedia.org/T270137 (10Urbanecm_WMF) >>! In T270137#6693750, @Tgr wrote: >>>! In T270137#6691888, @Urbanecm_WMF wrote: >> @Tgr Let's not backport i18n strings (_including_ .aliases.php) unless it's really real... [00:01:51] 10WMF-Legal, 10Wikimedia-Site-requests, 10Community-consensus-needed: Allow local file uploads on Ukrainian Wikisource - https://phabricator.wikimedia.org/T262193 (10Ahonc) @Aklapper @Arxivist @Base @NickK @Urbanecm I suggest to discuss this case in Commons' VP. If Arxivist will prove that pre-1969-author-de... [00:02:10] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.33x-R-Rosgulla): Optimize loading behavior of user contributions screen - https://phabricator.wikimedia.org/T269863 (10cooltey) [00:02:26] (03CR) 10DannyS712: "LGTM bar 1 suggestion" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/649964 (owner: 10Umherirrender) [00:04:49] (03CR) 10DannyS712: "LGTM bar 2 issues" (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/649960 (owner: 10Umherirrender) [00:05:03] (03CR) 10jerkins-bot: [V: 04-1] DWIM support in wvui [wvui] - 10https://gerrit.wikimedia.org/r/649991 (https://phabricator.wikimedia.org/T262566) (owner: 10Jdlrobson) [00:07:17] 10GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: URL parameter for suppressing Growth onboarding features - https://phabricator.wikimedia.org/T269786 (10nettrom_WMF) >>! In T269786#6693849, @Tgr wrote: > Not an ideal way, preferences are for things that can be changed and/or affect th... [00:11:27] (03Abandoned) 10Reedy: Allow parserTests to declare a dependency on a particular extension [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/649912 (owner: 10Reedy) [00:12:51] 10Wikipedia-Android-App-Backlog: [OTRS feature] Let password field autoprompt for password managers - https://phabricator.wikimedia.org/T269189 (10cooltey) a:03Dbrant [00:13:04] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.33x-R-Rosgulla): [OTRS feature] Let password field autoprompt for password managers - https://phabricator.wikimedia.org/T269189 (10cooltey) [00:15:30] (03CR) 10DannyS712: [C: 04-1] Separate out isAvailableForTitleAndUser from isAvailable (032 comments) [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/649905 (owner: 10Esanders) [00:19:33] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board): [SPIKE] What could be contributing to the drop-off in the Reply Tool comment funnels? - https://phabricator.wikimedia.org/T270346 (10matmarex) Wherever the `saveSuccess` event is missing, there should instead be a `saveFailure` event, which should con... [00:21:04] (03PS15) 10Paladox: Fix infinite recursion with wgAutopromote when using getBlock within checkCondition [core] - 10https://gerrit.wikimedia.org/r/649910 (https://phabricator.wikimedia.org/T270145) [00:21:26] (03CR) 10Paladox: Fix infinite recursion with wgAutopromote when using getBlock within checkCondition (032 comments) [core] - 10https://gerrit.wikimedia.org/r/649910 (https://phabricator.wikimedia.org/T270145) (owner: 10Paladox) [00:22:11] (03PS1) 10AlexPinchuk: Fix single dot regex issue [extensions/CognitiveProcessDesigner] (REL1_31) - 10https://gerrit.wikimedia.org/r/649997 [00:25:15] (03CR) 10jerkins-bot: [V: 04-1] ParserTestRunner: Fix skipping typo [core] - 10https://gerrit.wikimedia.org/r/649993 (owner: 10Reedy) [00:25:47] (03CR) 10DannyS712: [C: 03+2] "random 502 error - try again" [core] - 10https://gerrit.wikimedia.org/r/649993 (owner: 10Reedy) [00:27:04] (03PS1) 10Jforrester: build: Upgrade jasmine-node to 3.0.0 [wikipeg] - 10https://gerrit.wikimedia.org/r/649998 [00:33:00] (03CR) 10Reedy: Add test showing that getBlock can recurse if you use Autopromote (039 comments) [core] - 10https://gerrit.wikimedia.org/r/649696 (https://phabricator.wikimedia.org/T270145) (owner: 10Paladox) [00:35:06] (03CR) 10Reedy: Fix infinite recursion with wgAutopromote when using getBlock within checkCondition (031 comment) [core] - 10https://gerrit.wikimedia.org/r/649910 (https://phabricator.wikimedia.org/T270145) (owner: 10Paladox) [00:39:15] (03PS32) 10Paladox: Add test showing that getBlock can recurse if you use Autopromote and use APCOND_BLOCKED [core] - 10https://gerrit.wikimedia.org/r/649696 (https://phabricator.wikimedia.org/T270145) [00:39:18] (03CR) 10Paladox: Add test showing that getBlock can recurse if you use Autopromote and use APCOND_BLOCKED (039 comments) [core] - 10https://gerrit.wikimedia.org/r/649696 (https://phabricator.wikimedia.org/T270145) (owner: 10Paladox) [00:39:22] (03PS33) 10Paladox: Add test showing that getBlock can recurse if you use Autopromote and use APCOND_BLOCKED [core] - 10https://gerrit.wikimedia.org/r/649696 (https://phabricator.wikimedia.org/T270145) [00:41:05] (03PS34) 10Paladox: Add test showing that getBlock can recurse if you use Autopromote and use APCOND_BLOCKED [core] - 10https://gerrit.wikimedia.org/r/649696 (https://phabricator.wikimedia.org/T270145) [00:41:07] (03PS16) 10Paladox: Fix infinite recursion with wgAutopromote when using getBlock within checkCondition [core] - 10https://gerrit.wikimedia.org/r/649910 (https://phabricator.wikimedia.org/T270145) [00:42:01] (03PS17) 10Paladox: Fix infinite recursion with wgAutopromote when using getBlock within checkCondition [core] - 10https://gerrit.wikimedia.org/r/649910 (https://phabricator.wikimedia.org/T270145) [00:42:08] (03CR) 10jerkins-bot: [V: 04-1] Fix infinite recursion with wgAutopromote when using getBlock within checkCondition [core] - 10https://gerrit.wikimedia.org/r/649910 (https://phabricator.wikimedia.org/T270145) (owner: 10Paladox) [00:42:12] (03CR) 10Paladox: Fix infinite recursion with wgAutopromote when using getBlock within checkCondition (031 comment) [core] - 10https://gerrit.wikimedia.org/r/649910 (https://phabricator.wikimedia.org/T270145) (owner: 10Paladox) [00:46:38] (03PS35) 10Paladox: Add test showing that getBlock can recurse if you use Autopromote and use APCOND_BLOCKED [core] - 10https://gerrit.wikimedia.org/r/649696 (https://phabricator.wikimedia.org/T270145) [00:46:48] (03PS18) 10Paladox: Fix infinite recursion with wgAutopromote when using getBlock within checkCondition [core] - 10https://gerrit.wikimedia.org/r/649910 (https://phabricator.wikimedia.org/T270145) [00:47:00] (03PS19) 10Paladox: Fix infinite recursion with wgAutopromote when using getBlock within checkCondition [core] - 10https://gerrit.wikimedia.org/r/649910 (https://phabricator.wikimedia.org/T270145) [00:47:07] (03PS3) 10BryanDavis: User interface for audit logs [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/649816 (https://phabricator.wikimedia.org/T264968) (owner: 10Srishakatux) [00:48:48] 10MediaWiki-Language-converter, 10MediaWiki-Parser, 10Chinese-Sites, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), and 3 others: add parser tag - https://phabricator.wikimedia.org/T263082 (10Johan) Added to https://meta.wikimedia.org/wiki/Tech/News/2020/52 – please let me know if there are any... [00:49:06] (03CR) 10jerkins-bot: [V: 04-1] Fix infinite recursion with wgAutopromote when using getBlock within checkCondition [core] - 10https://gerrit.wikimedia.org/r/649910 (https://phabricator.wikimedia.org/T270145) (owner: 10Paladox) [00:50:30] (03Merged) 10jenkins-bot: ParserTestRunner: Fix skipping typo [core] - 10https://gerrit.wikimedia.org/r/649993 (owner: 10Reedy) [00:53:53] (03CR) 10jerkins-bot: [V: 04-1] User interface for audit logs [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/649816 (https://phabricator.wikimedia.org/T264968) (owner: 10Srishakatux) [00:54:25] 10Product-Analytics (Kanban): Updated number of editors across all wikipedias and all projects per month - https://phabricator.wikimedia.org/T269625 (10SNowick_WMF) Hi @ASvitak Editor count data spreadsheet is updated through 2020-11 [[ https://docs.google.com/spreadsheets/d/1o0TTvYsLL4Ef_DDAHrr-jkLXdTpd7sX_ZzFq... [00:58:57] (03PS1) 10Reedy: Updating wikimedia/parsoid (v0.12.0 => v0.12.1) [vendor] (REL1_35) - 10https://gerrit.wikimedia.org/r/650004 [01:00:55] (03PS1) 10Reedy: Updating wikimedia/parsoid (v0.12.0 => v0.12.1) [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650005 [01:05:17] (03PS1) 10Bartosz Dziewoński: [WIP] Support launching new discussion tool from custom links, with 'preload' etc. [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/650007 (https://phabricator.wikimedia.org/T269310) [01:06:37] 10GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: URL parameter for suppressing Growth onboarding features - https://phabricator.wikimedia.org/T269786 (10Tgr) >>! In T269786#6697349, @nettrom_WMF wrote: > I agree that we maybe shouldn't keep adding user preferences to track this. Can w... [01:10:33] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Support launching new discussion tool from custom links, with 'preload' etc. [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/650007 (https://phabricator.wikimedia.org/T269310) (owner: 10Bartosz Dziewoński) [01:10:46] 10Desktop Improvements, 10Readers-Web-Backlog (Kanbanana-FY-2020-21): [Language switcher] Language switcher button design - https://phabricator.wikimedia.org/T268514 (10Ladsgroup) Persian native speaker here. Regarding flag, highly seconding what Amir said, flags are nasty can of worms in matter of identity a... [01:12:48] (03PS4) 10BryanDavis: User interface for audit logs [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/649816 (https://phabricator.wikimedia.org/T264968) (owner: 10Srishakatux) [01:12:50] (03PS1) 10BryanDavis: ci: Ignore generated files when linting nodejs [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650009 [01:13:21] (03CR) 10BryanDavis: [C: 03+2] ci: Ignore generated files when linting nodejs [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650009 (owner: 10BryanDavis) [01:13:58] 10MediaWiki-API, 10Wikipedia-iOS-App-Backlog, 10Product-Infrastructure-Team-Backlog (Kanban): Commons API not returning image data for Dec. 14 2020 picture of the day (in English and German) - https://phabricator.wikimedia.org/T270139 (10MattCleinman) @Pchelolo Sounds like there was more cache invalidation w... [01:17:04] (03Merged) 10jenkins-bot: ci: Ignore generated files when linting nodejs [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650009 (owner: 10BryanDavis) [01:17:48] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10VisualEditor, 10Patch-For-Review, 10Wikimedia-production-error: VisualEditor Uri exception breaks display of CentralNotice banners - https://phabricator.wikimedia.org/T270331 (10AndyRussG) [01:19:12] 10Toolhub: Add a 'label' value to toolhub.apps.auditlog.serializers.TargetSerializer - https://phabricator.wikimedia.org/T270358 (10bd808) [01:21:15] (03CR) 10BryanDavis: User interface for audit logs (032 comments) [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/649816 (https://phabricator.wikimedia.org/T264968) (owner: 10Srishakatux) [01:21:36] 10DiscussionTools, 10Editing Design, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: Add support for preloaded text - https://phabricator.wikimedia.org/T269310 (10matmarex) Prototype demo: * Simple: ** (03CR) 10Jforrester: [C: 03+2] docs: Word-wrap the LICENSE file [fresh] - 10https://gerrit.wikimedia.org/r/649973 (owner: 10Krinkle) [01:23:19] (03CR) 10Jforrester: [C: 03+2] build: Remove redundant Travis CI config [fresh] - 10https://gerrit.wikimedia.org/r/649976 (owner: 10Krinkle) [01:23:34] (03CR) 10Jforrester: [C: 03+2] build: Remove outdated Travis CI config [libs/LangConv] - 10https://gerrit.wikimedia.org/r/649981 (owner: 10Krinkle) [01:25:19] (03Merged) 10jenkins-bot: build: Remove outdated Travis CI config [libs/LangConv] - 10https://gerrit.wikimedia.org/r/649981 (owner: 10Krinkle) [01:26:24] 10Phabricator, 10I18n, 10Patch-For-Review: incorrect display of dates in ISO 8601 format: non-sense displayed everywhere in Phabricator, missing years ! - https://phabricator.wikimedia.org/T269339 (10mmodell) I think this should be fixed now. @hashar or @Verdy_p can you confirm? [01:27:26] 10DiscussionTools, 10Editing Design, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: Add support for preloaded text - https://phabricator.wikimedia.org/T269310 (10matmarex) [01:27:27] (03CR) 10Reedy: [V: 03+2 C: 03+2] "Ship it" [vendor] (REL1_35) - 10https://gerrit.wikimedia.org/r/650004 (owner: 10Reedy) [01:27:48] 10MediaWiki-Codesniffer: Create sniff to suggest assertStringContainsString instead of assertTrue( strpos( ... - https://phabricator.wikimedia.org/T253618 (10DannyS712) I figured out how to replace the in_array and array_key_exists, but for `strpos` there is a third parameter, the offset, that if present wouldn'... [01:27:51] (03CR) 10Reedy: [C: 03+2] Updating wikimedia/parsoid (v0.12.0 => v0.12.1) [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650005 (owner: 10Reedy) [01:32:57] 10MediaWiki-extensions-SecurePoll, 10Platform Engineering, 10Anti-Harassment (The Letter Song): Investigate issues with Tally function in SecurePoll [8Hr] - https://phabricator.wikimedia.org/T269029 (10Niharika) >>! In T269029#6697233, @jrbs wrote: >>>! In T269029#6697212, @tstarling wrote: >> The original i... [01:35:38] 10Anti-Harassment, 10IP Info: Remove 'ipinfo' right from administrators, and give to checkusers instead - https://phabricator.wikimedia.org/T270347 (10Niharika) [01:39:46] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Create sniff to suggest assertStringContainsString instead of assertTrue( strpos( ... - https://phabricator.wikimedia.org/T253618 (10DannyS712) a:03DannyS712 [01:39:52] (03Merged) 10jenkins-bot: Updating wikimedia/parsoid (v0.12.0 => v0.12.1) [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650005 (owner: 10Reedy) [01:41:44] (03Merged) 10jenkins-bot: docs: Word-wrap the LICENSE file [fresh] - 10https://gerrit.wikimedia.org/r/649973 (owner: 10Krinkle) [01:43:11] (03CR) 10Ammarpad: Rename four logging indexes to have log_ prefix (031 comment) [core] - 10https://gerrit.wikimedia.org/r/648817 (owner: 10Ladsgroup) [01:49:14] 10wmf-sre-laptop: wmf-sre-laptop should use config-master.wikimedia.org to bootstrap SSH fingerprints - https://phabricator.wikimedia.org/T270359 (10Legoktm) [01:49:40] (03PS1) 10Samwilson: Fix version number and switch to AutoloadNamespaces [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/650011 [01:50:52] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Create sniff to suggest assertStringContainsString instead of assertTrue( strpos( ... - https://phabricator.wikimedia.org/T253618 (10DannyS712) Patch covers: * `assertTrue` and `assertFalse` with `array_key_exists` or `in_array` (for `in_array`,... [01:57:42] 10MediaWiki-Language-converter, 10MediaWiki-Parser, 10Chinese-Sites, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), and 3 others: add parser tag - https://phabricator.wikimedia.org/T263082 (10kamholz) >>! In T263082#6697435, @Johan wrote: > Added to https://meta.wikimedia.org/wiki/Tech/News/202... [01:59:44] (03Merged) 10jenkins-bot: build: Remove redundant Travis CI config [fresh] - 10https://gerrit.wikimedia.org/r/649976 (owner: 10Krinkle) [02:04:12] 10MediaWiki-Authentication-and-authorization, 10Platform Engineering, 10Patch-For-Review: Finish session storage to actually meet multi-DC requirements - https://phabricator.wikimedia.org/T270225 (10Krinkle) [02:04:39] 10MediaWiki-Authentication-and-authorization, 10Platform Engineering, 10Patch-For-Review: Finish session storage to actually meet multi-DC requirements - https://phabricator.wikimedia.org/T270225 (10Krinkle) [02:08:21] (03CR) 10Samwilson: [C: 03+2] Fix version number and switch to AutoloadNamespaces [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/650011 (owner: 10Samwilson) [02:11:57] (03Merged) 10jenkins-bot: Fix version number and switch to AutoloadNamespaces [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/650011 (owner: 10Samwilson) [02:27:13] 10DiscussionTools, 10Editing Design, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: Add support for preloaded text - https://phabricator.wikimedia.org/T269310 (10ppelberg) >>! In T269310#6697490, @matmarex wrote: > Prototype demo: > * Simple: ** 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.33x-R-Rosgulla): Build Watchlist diff view - https://phabricator.wikimedia.org/T269447 (10Sharvaniharan) @schoenbaechler could I please get the icon for contributions in the menu here : https://app.zeplin.io/project/57a120b91998d8977642a238/screen/5fc6558... [02:40:47] (03CR) 10Ammarpad: [C: 03+1] Content navigation links can provide their own IDs (031 comment) [core] - 10https://gerrit.wikimedia.org/r/648341 (owner: 10Jdlrobson) [02:42:33] 10DiscussionTools, 10Editing Design: Determine new discussion tool interface copy - https://phabricator.wikimedia.org/T264220 (10ppelberg) [02:54:24] (03CR) 10Ammarpad: "I didn't see your comment Jdlrobson till now, (too many notifications really)" [core] - 10https://gerrit.wikimedia.org/r/642610 (https://phabricator.wikimedia.org/T206954) (owner: 10Ammarpad) [02:54:51] (03PS1) 10Srishakatux: UI fixes for language selector [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650014 [03:01:03] (03CR) 10DannyS712: "This change is ready for review." [extensions/ORES] - 10https://gerrit.wikimedia.org/r/649914 (owner: 10DannyS712) [03:04:37] (03PS5) 10DannyS712: Merge PageTriageExternalDeletionTagsOptions into ExternalTagOptions [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/604843 (https://phabricator.wikimedia.org/T221269) [03:04:53] (03CR) 10DannyS712: "This change is ready for review." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/649915 (owner: 10DannyS712) [03:04:57] (03PS1) 10Srishakatux: Remove roundeness of buttons in the navbar [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650015 [03:05:08] (03PS3) 10DannyS712: Merge jquery.tipoff into ext.pageTriage.views.list [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/649915 [03:07:00] 10MediaWiki-extensions-OAuth, 10Platform Engineering, 10Wikimedia-production-error: PHP Warning: json_decode() expects parameter 1 to be string, array given - https://phabricator.wikimedia.org/T270332 (10Ammarpad) This seems to be a simple error where the values are supposed to be 'encoded' to json, but 'dec... [03:22:42] (03CR) 10TTO: [C: 04-1] Disregard expired user groups in ExitDeleteOwn.php (031 comment) [extensions/DeleteOwn] - 10https://gerrit.wikimedia.org/r/649838 (https://phabricator.wikimedia.org/T160021) (owner: 10Shubham656jain) [03:24:36] (03CR) 10DannyS712: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/649916 (https://phabricator.wikimedia.org/T157658) (owner: 10DannyS712) [03:25:21] 10MediaWiki-Page-editing, 10Platform Engineering, 10Platform Engineering Roadmap Decision Making, 10MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), and 3 others: Factor out a backend from EditPage - https://phabricator.wikimedia.org/T157658 (10DannyS712) [03:45:36] (03CR) 10Jdlrobson: Content navigation links can provide their own IDs (031 comment) [core] - 10https://gerrit.wikimedia.org/r/648341 (owner: 10Jdlrobson) [03:50:07] 10Wikilink-Tool, 10The-Wikipedia-Library (Kanban): Replace docker.io with quay.io for wikilink images - https://phabricator.wikimedia.org/T270082 (10Scardenasmolinar) I just created a PR for Wikilink and GitHub Actions fails because it couldn't log into quay.io. [03:53:25] (03PS1) 10Alexiscoutinho: makeCollapsible: Implement "smart" On-Off and Partial Custom Toggles [core] - 10https://gerrit.wikimedia.org/r/650016 [03:53:27] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [core] - 10https://gerrit.wikimedia.org/r/650016 (owner: 10Alexiscoutinho) [03:58:09] 10Image-Recommendations: Initial Task API Spec - https://phabricator.wikimedia.org/T270201 (10BPirkle) I'd hoped to reply today with some spec details, but as I continued reading various docs, I kept seeing additional things to consider. So instead, I'll post a random-ish collection of my current thoughts. Here... [04:11:57] 10MediaWiki-API, 10Wikipedia-iOS-App-Backlog, 10Product-Infrastructure-Team-Backlog (Kanban): Commons API not returning image data for Dec. 14 2020 picture of the day (in English and German) - https://phabricator.wikimedia.org/T270139 (10Pchelolo) I think it should return identical data for both of them, at... [04:15:47] 10Toolhub, 10Developer-Advocacy (Oct-Dec 2020), 10Patch-For-Review: User interface for viewing actions taken on Toolhub - https://phabricator.wikimedia.org/T264968 (10bd808) >>! In T264968#6696794, @srishakatux wrote: > @bd808 As far as the audit logs UI goes, I think what we have in the data looks good. A c... [04:20:08] (03CR) 10Alexiscoutinho: "Hello," [core] - 10https://gerrit.wikimedia.org/r/650016 (owner: 10Alexiscoutinho) [04:22:21] 10MediaWiki-Authentication-and-authorization, 10Analytics-Radar, 10Privacy Engineering, 10Performance-Team (Radar): Clear site data on MediaWiki log out - https://phabricator.wikimedia.org/T179752 (10Krinkle) [04:23:20] 10MediaWiki-Authentication-and-authorization, 10Analytics-Radar, 10Privacy Engineering, 10Performance-Team (Radar): Clear site data on MediaWiki log out - https://phabricator.wikimedia.org/T179752 (10Krinkle) Tagging Privacy-Engineering as FYI. This may be worth looking into and get into our planning. See... [04:24:29] 10MediaWiki-extensions-CategoryTree: categorytree with mode=pages is only expandable in preview - https://phabricator.wikimedia.org/T270360 (10DTLHS) [04:41:17] (03PS1) 10STran: [WIP] Stop cloner add/delete functions from triggering unexpectedly [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/650017 (https://phabricator.wikimedia.org/T270200) [04:42:20] (03CR) 10STran: [C: 04-1] "WIP bc still thinking if this is the right solution + tests are 💯 going to break" [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/650017 (https://phabricator.wikimedia.org/T270200) (owner: 10STran) [04:47:10] 10MediaWiki-extensions-SecurePoll, 10Anti-Harassment (The Letter Song), 10Patch-For-Review: Fix disappearing inputs in SecurePoll - https://phabricator.wikimedia.org/T270200 (10STran) Some more notes - I tested this with no js and the use of the submit button makes it so that non-js users can still add/delet... [04:49:49] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint): Instrument banner module on newcomer homepage - https://phabricator.wikimedia.org/T270309 (10Tgr) That reminds me, we need to add the module name to the HomepageModule schema for logging impressions. [04:50:07] (03CR) 10STran: [C: 04-1] "> Patch Set 1: Code-Review-1" [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/650017 (https://phabricator.wikimedia.org/T270200) (owner: 10STran) [04:50:25] 04(no projects): "Edit" link on old revisions of a page links to the latest revision instead of the revision being viewed - https://phabricator.wikimedia.org/T270361 (10ST47) [04:51:07] 10IP Info, 10Anti-Harassment (The Letter Song): Add informative text at the bottom of IP Info box to indicate data source - https://phabricator.wikimedia.org/T270306 (10STran) a:03STran [04:54:17] 10IP Info, 10Anti-Harassment (The Letter Song): Add informative text at the bottom of IP Info box to indicate data source - https://phabricator.wikimedia.org/T270306 (10STran) Given that we want to put different (first-party) information into the popup (thereby negating the need for the third-party disclaimer?... [05:01:30] (03PS3) 10Nik Gkountas: MW UI lib: Add ProgressBar component [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/647680 [05:01:32] (03PS1) 10Nik Gkountas: SX Pick a sentence: Add card for already translated segments [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/650018 (https://phabricator.wikimedia.org/T260128) [05:06:24] 10Magnus Sälgö: Riksdagens person-id P1214 changed to guid - https://phabricator.wikimedia.org/T235521 (10Salgo60) Did a check old id P1214 in Wikidata and check if GUID exist at Riksdagen {F33947786} {F33947788} * [[ https://editgroups.toolforge.org/b/OR/abb213774d2/ | uploaded changeset ]] [05:22:47] (03PS1) 10STran: Update info source text with a disclaimer [extensions/IPInfo] - 10https://gerrit.wikimedia.org/r/650019 (https://phabricator.wikimedia.org/T270306) [05:23:12] 10IP Info, 10Anti-Harassment (The Letter Song), 10Patch-For-Review: Add informative text at the bottom of IP Info box to indicate data source - https://phabricator.wikimedia.org/T270306 (10STran) Here's how it looks with my changes (based on the assumption that the popup and the infobox will continue to use... [05:23:35] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Yellow hornets of kindness and healing, 10Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (10AndyRussG) >>! In T268646#6689753, @DStrine wrote: > Ah @... [05:29:16] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Revisit the text size option to better communicate how to use it - https://phabricator.wikimedia.org/T267293 (10eamedina) Refactor PR is https://github.com/wikimedia/wikipedia-kaios/pull/300 [05:29:28] 10MediaWiki-extensions-SecurePoll, 10Anti-Harassment (The Letter Song), 10Spike: Investigate work involved in adding log for scrutiny of voter data [8 hours] - https://phabricator.wikimedia.org/T270342 (10STran) a:03STran [05:37:22] 10MediaWiki-Special-pages, 10MediaWiki-User-management, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), 10Platform Team Workboards (External Code Reviews): Enable wgRelevantUserName for IP ranges - https://phabricator.wikimedia.org/T206954 (10Ammarpad) 05Resolved→03Open a:05Jdlrobson→03None This is no... [05:41:40] 10Bengali-Sites, 10Growth-Team (Current Sprint), 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), 10Patch-For-Review: Deploy Growth experiments at Bangla Wikipedia - https://phabricator.wikimedia.org/T266020 (10ANKAN) [05:42:32] 04(no projects): "Edit" link on old revisions of a page links to the latest revision instead of the revision being viewed - https://phabricator.wikimedia.org/T270361 (10ST47) It's not just that really old page, the same issue happens on this test revision: * https://en.wikipedia.org/w/index.php?title=User:ST47/... [05:43:29] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Yellow hornets of kindness and healing, 10Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (10AndyRussG) [05:44:03] 10SectionTranslation, 10Language-Team (Language-2020-October-December): Highlighting of translated sentences should not be persistent - https://phabricator.wikimedia.org/T269415 (10ngkountas) a:03ngkountas [05:48:07] (03PS1) 10Nik Gkountas: SX Pick a sentence: Fix translated segments highlighting [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/650020 (https://phabricator.wikimedia.org/T269415) [05:49:52] 10MediaWiki-Special-pages, 10MediaWiki-User-management, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), 10Platform Team Workboards (External Code Reviews): Enable wgRelevantUserName for IP ranges - https://phabricator.wikimedia.org/T206954 (10DannyS712) >>! In T206954#6697629, @Ammarpad wrote: > This is not r... [05:50:35] (03CR) 10Legoktm: [C: 03+2] build: Upgrade jasmine-node to 3.0.0 [wikipeg] - 10https://gerrit.wikimedia.org/r/649998 (owner: 10Jforrester) [05:51:41] (03Merged) 10jenkins-bot: build: Upgrade jasmine-node to 3.0.0 [wikipeg] - 10https://gerrit.wikimedia.org/r/649998 (owner: 10Jforrester) [06:07:49] 10MediaWiki-Page-history: "Edit" link on old revisions of a page links to the latest revision instead of the revision being viewed - https://phabricator.wikimedia.org/T270361 (10Majavah) [06:18:02] 10DiscussionTools, 10Editing Design: Determine new discussion tool interface copy - https://phabricator.wikimedia.org/T264220 (10ppelberg) >>! In T264220#6686171, @iamjessklein wrote: > I've updated [[https://docs.google.com/spreadsheets/d/1-uLxMRul5UfQDGsUZN_daqLmdJsTyFdNXsH08A8GFW4/edit?usp=sharing | this sp... [06:21:11] (03CR) 10DannyS712: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/649918 (owner: 10DannyS712) [06:22:54] (03CR) 10DannyS712: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/649919 (owner: 10DannyS712) [06:31:01] (03PS1) 10Ammarpad: Fix Skin::getRelevantUser to handle IP ranges [core] - 10https://gerrit.wikimedia.org/r/650026 (https://phabricator.wikimedia.org/T206954) [06:31:18] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Yellow hornets of kindness and healing, 10Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (10AndyRussG) [06:38:23] (03PS1) 10Legoktm: Expose a swagger spec for service-checker [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/650027 [07:05:51] 10SRE-tools, 10Goal, 10Patch-For-Review: Spin off common Spicerack modules into a standalone Python library importable anywhere - https://phabricator.wikimedia.org/T257905 (10elukey) [07:11:22] (03CR) 10DannyS712: "Put them all together to speed things up. Testing on patchdemo, everything still works" [core] - 10https://gerrit.wikimedia.org/r/649917 (https://phabricator.wikimedia.org/T269952) (owner: 10DannyS712) [07:12:50] (03PS1) 10Gergő Tisza: analytics/legacy/homepagemodule: Add banner to module list [schemas/event/secondary] - 10https://gerrit.wikimedia.org/r/650031 (https://phabricator.wikimedia.org/T270309) [07:13:23] (03CR) 10jerkins-bot: [V: 04-1] analytics/legacy/homepagemodule: Add banner to module list [schemas/event/secondary] - 10https://gerrit.wikimedia.org/r/650031 (https://phabricator.wikimedia.org/T270309) (owner: 10Gergő Tisza) [07:20:47] 10MediaWiki-Core-Skin-Architecture: Improve test coverage of core skin code - https://phabricator.wikimedia.org/T270363 (10Ammarpad) [07:23:40] (03PS1) 10Ammarpad: Add test for Skin:BuildSidebar [core] - 10https://gerrit.wikimedia.org/r/650032 (https://phabricator.wikimedia.org/T270363) [07:24:09] (03PS2) 10Ammarpad: Add test for Skin:BuildSidebar [core] - 10https://gerrit.wikimedia.org/r/650032 (https://phabricator.wikimedia.org/T270363) [07:24:20] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] thumb.php - wfExtractThumbParams can return null [core] - 10https://gerrit.wikimedia.org/r/649919 (owner: 10DannyS712) [07:29:00] 10Magnus Sälgö: Riksdagens person-id P1214 changed to guid - https://phabricator.wikimedia.org/T235521 (10Salgo60) Added. section to fix when we have Property 8388 in WIkidata but miss Property 1214 see [[ https://github.com/salgo60/open-data-examples/blob/master/Riksdagen%20P1214.ipynb | Notebook version 2.2... [07:30:32] (03CR) 10Thiemo Kreuz (WMDE): whitespace cleanup in gruntfile.js (031 comment) [core] - 10https://gerrit.wikimedia.org/r/649918 (owner: 10DannyS712) [07:30:47] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Yellow hornets of kindness and healing, 10Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (10AndyRussG) Further note on translatable campaign types: C... [07:32:13] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Patch-For-Review: Instrument banner module on newcomer homepage - https://phabricator.wikimedia.org/T270309 (10Tgr) a:03Tgr [07:32:21] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Yellow hornets of kindness and healing, 10Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (10AndyRussG) [07:46:30] 10MediaWiki-Core-Skin-Architecture, 10Patch-For-Review, 10Test-Coverage: Improve test coverage of core skin code - https://phabricator.wikimedia.org/T270363 (10DannyS712) [07:47:37] 10MediaWiki-Special-pages, 10MediaWiki-User-management, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), 10Patch-For-Review, 10Platform Team Workboards (External Code Reviews): Enable wgRelevantUserName for IP ranges - https://phabricator.wikimedia.org/T206954 (10Ammarpad) >>! In T206954#6697642, @DannyS712... [07:49:12] 10CX-cxserver, 10Language-Team (Language-2020-October-December), 10Parsoid (Tracking): Update cxserver to handle Parsoid HTML change from to - https://phabricator.wikimedia.org/T268309 (10Nikerabbit) We have plenty of user reports of publishing failures and this matches those. Some of... [07:52:34] (03Merged) 10jenkins-bot: thumb.php - wfExtractThumbParams can return null [core] - 10https://gerrit.wikimedia.org/r/649919 (owner: 10DannyS712) [07:53:25] (03CR) 10Ammarpad: [C: 03+2] Add GENDER to two messages to avoid warnings in translatewiki [core] - 10https://gerrit.wikimedia.org/r/649837 (owner: 10Amire80) [07:59:04] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/650066 (owner: 10L10n-bot) [07:59:25] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/650074 (owner: 10L10n-bot) [08:00:21] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Yellow hornets of kindness and healing, 10Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (10AndyRussG) Of the issues and tasks just added in the desc... [08:04:01] 10MediaWiki-Page-history: "Edit" link on old revisions of a page links to the latest revision instead of the revision being viewed - https://phabricator.wikimedia.org/T270361 (10Ammarpad) I cannot reproduce this. The 'edit' link works correctly (at least for me). Can you reproduce it while logged out? [08:06:16] (03CR) 10Mainframe98: [C: 03+1] Fix the styling of the installer and deprecate its RL module [core] - 10https://gerrit.wikimedia.org/r/649409 (https://phabricator.wikimedia.org/T270027) (owner: 10Jdlrobson) [08:15:46] (03Merged) 10jenkins-bot: Add GENDER to two messages to avoid warnings in translatewiki [core] - 10https://gerrit.wikimedia.org/r/649837 (owner: 10Amire80) [08:19:04] 10SDAW-MediaSearch, 10Structured-Data-Backlog, 10Wikimedia-production-error: SparqlClient: 504 Gateway Timeout - https://phabricator.wikimedia.org/T270336 (10matthiasmullie) This specific request was one by me, and the timeout is expected (given certain circumstances) This code path is known to be unreliable... [08:19:52] 10SDAW-MediaSearch, 10Structured-Data-Backlog (Current Work), 10Wikimedia-production-error: SparqlClient: 504 Gateway Timeout - https://phabricator.wikimedia.org/T270336 (10matthiasmullie) a:03matthiasmullie [08:20:10] 10MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), 10SDAW-MediaSearch (MediaSearch-ReleaseCandidate), 10Structured-Data-Backlog (Current Work): [L] [SPIKE] Investigate traversing entities tree to include more entities with more detail - https://phabricator.wikimedia.org/T258055 (10matthiasmullie) [08:20:12] 10SDAW-MediaSearch, 10Structured-Data-Backlog (Current Work), 10Wikimedia-production-error: SparqlClient: 504 Gateway Timeout - https://phabricator.wikimedia.org/T270336 (10matthiasmullie) [08:21:36] 10CX-boost, 10CX-out-of-beta, 10Language-Team (Language-2020-October-December): Enable Content Translation in Tajik (tg) Wikipedia as a default tool - https://phabricator.wikimedia.org/T269113 (10Amire80) a:05Amire80→03KartikMistry [08:21:39] 10CX-boost, 10CX-out-of-beta, 10Language-Team (Language-2020-October-December): Enable Content Translation in Cebuano (ceb) Wikipedia as a default tool - https://phabricator.wikimedia.org/T269119 (10Amire80) a:05Amire80→03KartikMistry [08:21:49] 10CX-boost, 10CX-out-of-beta, 10Language-Team (Language-2020-October-December): Enable Content Translation in Yiddish (yi) Wikipedia as a default tool - https://phabricator.wikimedia.org/T269118 (10Amire80) a:05Amire80→03KartikMistry [08:21:51] 10CX-boost, 10CX-out-of-beta, 10Language-Team (Language-2020-October-December): Enable Content Translation in Khmer (km) Wikipedia as a default tool - https://phabricator.wikimedia.org/T269117 (10Amire80) a:05Amire80→03KartikMistry [08:22:01] 10CX-boost, 10CX-out-of-beta, 10Language-Team (Language-2020-October-December): Enable Content Translation in Malagasy (mg) Wikipedia as a default tool - https://phabricator.wikimedia.org/T269120 (10Amire80) a:05Amire80→03KartikMistry [08:28:00] 10MediaWiki-Page-history: "Edit" link on old revisions of a page links to the latest revision instead of the revision being viewed - https://phabricator.wikimedia.org/T270361 (10Ammarpad) > For certain revisions of certain pages Ok, I missed this clause. I reproduced it when I clicked the link for the second ti... [08:37:05] 10MediaWiki-Internationalization: Add Tyap (kcg) to Names.php - https://phabricator.wikimedia.org/T270365 (10Raymond) [08:38:09] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/650066 (owner: 10L10n-bot) [08:39:04] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/650074 (owner: 10L10n-bot) [08:41:59] (03PS1) 10Dvogel hallowelt: [WIP] Add store for templates [extensions/BlueSpiceFoundation] (REL1_31) - 10https://gerrit.wikimedia.org/r/650079 [08:44:36] 04(no projects): Timeless does not render HTMLDateTimeField widget properly - https://phabricator.wikimedia.org/T270366 (10Ammarpad) [08:45:14] 10Timeless: Timeless does not render HTMLDateTimeField widget properly - https://phabricator.wikimedia.org/T270366 (10Ammarpad) [08:45:37] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add store for templates [extensions/BlueSpiceFoundation] (REL1_31) - 10https://gerrit.wikimedia.org/r/650079 (owner: 10Dvogel hallowelt) [08:48:04] 10MediaWiki-Docker, 10Operations, 10serviceops, 10User-zeljkofilipin: docker pull from docker-registry fails with `ERROR: missing or empty Content-Length header` - https://phabricator.wikimedia.org/T270270 (10kostajh) The logs don't seem to show that much useful information. I set "debug: true" in the daem... [08:49:04] (03PS1) 10Amire80: Add Tyap to Names.php [core] - 10https://gerrit.wikimedia.org/r/650082 (https://phabricator.wikimedia.org/T270365) [08:50:39] (03PS2) 10Amire80: Add Tyap to Names.php [core] - 10https://gerrit.wikimedia.org/r/650082 (https://phabricator.wikimedia.org/T270365) [08:53:47] (03PS1) 10Amire80: Minor RELEASE-NOTES fixes [core] - 10https://gerrit.wikimedia.org/r/650083 [08:54:11] (03PS2) 10Amire80: Minor RELEASE-NOTES fixes [core] - 10https://gerrit.wikimedia.org/r/650083 [09:01:27] 10CX-boost, 10Language-Team (Language-2020-October-December): Improve MT support for Tsonga with OpusMT - https://phabricator.wikimedia.org/T262192 (10Pginer-WMF) p:05Medium→03High a:05Amire80→03KartikMistry [09:03:39] (03PS1) 10KartikMistry: config: Enable en->ts MT pair for OpusMT [services/cxserver] - 10https://gerrit.wikimedia.org/r/650084 (https://phabricator.wikimedia.org/T262192) [09:08:36] 10TechCom-RFC, 10Patch-For-Review, 10Platform Team Initiatives (Decoupling (CDP2)): RFC: Introduce PageIdentity to be used instead of WikiPage - https://phabricator.wikimedia.org/T208776 (10thiemowmde) Thanks, Krinkle! > […] we don't want to limit ourselves to the persistable aspect per-se […] in context of... [09:11:56] 10WMIT-Infrastructure: Transfer wikimediamoodle.it to moodle.wikimedia.it (or another sub-domain) - https://phabricator.wikimedia.org/T266282 (10Ferdi2005) I suggested this in July 2020, so I'm really glad that's happening. This change gives more authority to the domain as an official domain of our association a... [09:14:31] (03CR) 10Arturo Borrero Gonzalez: [C: 03+1] "LGTM!" [cloud/wmcs-ansible] - 10https://gerrit.wikimedia.org/r/647735 (owner: 10David Caro) [09:15:26] 10WMIT-Infrastructure: Transfer wikimediamoodle.it to moodle.wikimedia.it (or another sub-domain) - https://phabricator.wikimedia.org/T266282 (10valerio.bozzolan) a:03valerio.bozzolan [09:17:32] (03PS1) 10Ammarpad: Consider SpecialBadtitle as always known [core] - 10https://gerrit.wikimedia.org/r/650086 (https://phabricator.wikimedia.org/T262959) [09:20:49] (03PS2) 10Giuseppe Lavagetto: Add basic pipeline configuration [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/649651 (https://phabricator.wikimedia.org/T260330) [09:20:51] (03PS1) 10Giuseppe Lavagetto: Add docker-compose file for local development [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/650087 [09:21:29] (03CR) 10Arturo Borrero Gonzalez: [C: 03+1] First commit (031 comment) [cloud/wmcs-ansible] - 10https://gerrit.wikimedia.org/r/647735 (owner: 10David Caro) [09:24:25] 10MediaWiki-Docker, 10Operations, 10serviceops, 10User-zeljkofilipin: docker pull from docker-registry fails with `ERROR: missing or empty Content-Length header` - https://phabricator.wikimedia.org/T270270 (10JMeybohm) Unfortunately still unable to reproduce, even with docker & docker-engine 20.10.1 (on li... [09:26:17] (03CR) 10Abijeet Patro: "this seems to be working well, but I get deprecation notices:" [core] - 10https://gerrit.wikimedia.org/r/617294 (https://phabricator.wikimedia.org/T47096) (owner: 10C. Scott Ananian) [09:28:18] 10MediaWiki-extensions-Translate, 10Parsoid, 10Language-Team (Language-2020-October-December), 10Patch-For-Review, 10Platform Team Workboards (External Code Reviews): Add a way to transclude template or other page in the correct language - https://phabricator.wikimedia.org/T47096 (10abi_) Working with @c... [09:29:34] (03CR) 10Ammarpad: [C: 03+1] Don't override ooui z-index on rcfilters menuselect widgets [core] - 10https://gerrit.wikimedia.org/r/649982 (https://phabricator.wikimedia.org/T270351) (owner: 10Isarra) [09:37:21] 10MediaWiki-extensions-Translate, 10Technical-Debt: Convert Translate to PSR-4 - https://phabricator.wikimedia.org/T193166 (10abi_) [09:37:27] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2020-October-December), 10MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), 10Technical-Debt: Move insertables to the src/ folder. - https://phabricator.wikimedia.org/T267100 (10abi_) 05Open→03Resolved Tested on MediaWiki.org, insertables are appeari... [09:40:27] 10MediaWiki-Docker, 10Operations, 10serviceops, 10User-zeljkofilipin: docker pull from docker-registry fails with `ERROR: missing or empty Content-Length header` - https://phabricator.wikimedia.org/T270270 (10kostajh) I can reproduce on Debian unstable with `docker pull docker-registry.wikimedia.org/dev/st... [09:45:09] (03CR) 10jerkins-bot: [V: 04-1] Consider SpecialBadtitle as always known [core] - 10https://gerrit.wikimedia.org/r/650086 (https://phabricator.wikimedia.org/T262959) (owner: 10Ammarpad) [09:49:02] 10OCG-PDFRenderer, 10Chinese-Sites, 10I18n, 10Serbian-Sites: PDF should be rendered in the user's specified language converter variant, e.g. Serbian in Latin script (sr-el) - https://phabricator.wikimedia.org/T73815 (10Shizhao) User feedback: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZ... [09:54:00] (03PS4) 10Noam Rosenthal: Use CSS clip-path instead of SVG when supported. [extensions/Popups] - 10https://gerrit.wikimedia.org/r/647002 (https://phabricator.wikimedia.org/T269336) [10:00:20] (03PS2) 10Ammarpad: Consider SpecialBadtitle as always known [core] - 10https://gerrit.wikimedia.org/r/650086 (https://phabricator.wikimedia.org/T262959) [10:04:22] (03PS2) 10Shubham656jain: Disregard expired user groups in ExitDeleteOwn.php [extensions/DeleteOwn] - 10https://gerrit.wikimedia.org/r/649838 (https://phabricator.wikimedia.org/T160021) [10:04:56] (03CR) 10Shubham656jain: Disregard expired user groups in ExitDeleteOwn.php (031 comment) [extensions/DeleteOwn] - 10https://gerrit.wikimedia.org/r/649838 (https://phabricator.wikimedia.org/T160021) (owner: 10Shubham656jain) [10:09:28] 10React-i18n, 10VideoCutTool, 10I18n, 10good first task: Implement localisation and internationalisation in the tool - https://phabricator.wikimedia.org/T270263 (10Aklapper) [10:13:59] 10MediaWiki-API, 10Pywikibot, 10Wikidata, 10Platform Team Workboards (Clinic Duty Team), and 2 others: RecetChanges query API fails with timeout when asking for 5 RC redirects in on Wikidata - https://phabricator.wikimedia.org/T245989 (10daniel) [10:17:23] (03PS3) 10Awight: Add new action and user fields [schemas/event/secondary] - 10https://gerrit.wikimedia.org/r/649599 (https://phabricator.wikimedia.org/T262209) [10:17:57] (03CR) 10Thiemo Kreuz (WMDE): Disregard expired groups in GlobalUserGroups.php (031 comment) [extensions/GlobalUserGroups] - 10https://gerrit.wikimedia.org/r/649846 (https://phabricator.wikimedia.org/T160023) (owner: 10Shubham656jain) [10:17:59] (03CR) 10Abijeet Patro: [V: 03+1 C: 03+2] SXTranslationSelector: Increase specificity to apply background color [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/645366 (https://phabricator.wikimedia.org/T263146) (owner: 10Nik Gkountas) [10:20:13] (03CR) 10jerkins-bot: [V: 04-1] Consider SpecialBadtitle as always known [core] - 10https://gerrit.wikimedia.org/r/650086 (https://phabricator.wikimedia.org/T262959) (owner: 10Ammarpad) [10:27:51] (03CR) 10Hnowlan: [C: 03+1] Add test coverage reporting. [services/similar-users] (main) - 10https://gerrit.wikimedia.org/r/649952 (owner: 10Gmodena) [10:29:14] (03CR) 10Kosta Harlan: "Thanks for adding tests! If you make this a unit test (https://www.mediawiki.org/wiki/Manual:PHP_unit_testing) instead of an integration t" [core] - 10https://gerrit.wikimedia.org/r/650032 (https://phabricator.wikimedia.org/T270363) (owner: 10Ammarpad) [10:30:12] (03CR) 10Ammarpad: Fix the styling of the installer and deprecate its RL module (031 comment) [core] - 10https://gerrit.wikimedia.org/r/649409 (https://phabricator.wikimedia.org/T270027) (owner: 10Jdlrobson) [10:32:19] (03PS2) 10Thiemo Kreuz (WMDE): Add PHPDoc blocks to all public methods [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/649932 [10:35:16] 10MediaWiki-Docker, 10Operations, 10Traffic, 10serviceops, 10User-zeljkofilipin: docker pull from docker-registry fails with `ERROR: missing or empty Content-Length header` - https://phabricator.wikimedia.org/T270270 (10JMeybohm) I was able to reproduce as well now. Seems like we are missing the "content... [10:35:56] (03CR) 10Abijeet Patro: [V: 03+1 C: 03+2] "Looks good. Also did a quick check with the basic flow and did not notice any issues." [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/649378 (owner: 10Nik Gkountas) [10:43:14] (03Merged) 10jenkins-bot: SXTranslationSelector: Increase specificity to apply background color [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/645366 (https://phabricator.wikimedia.org/T263146) (owner: 10Nik Gkountas) [10:47:57] 10SectionTranslation, 10Language-Team (Language-2020-October-December): Create an API for MT modifications and warnings - https://phabricator.wikimedia.org/T269101 (10Pginer-WMF) >>! In T269101#6695764, @ngkountas wrote: > @Pginer-WMF I'm not sure we are going to use an api for MT abuse warnings at this point.... [10:51:21] 10MediaWiki-Docker, 10Operations, 10Traffic, 10serviceops, 10User-zeljkofilipin: docker pull from docker-registry fails with `ERROR: missing or empty Content-Length header` - https://phabricator.wikimedia.org/T270270 (10JMeybohm) p:05Low→03High Also rising priority as I guess this will affect more an... [11:04:28] (03PS3) 10Ammarpad: Consider SpecialBadtitle as always known [core] - 10https://gerrit.wikimedia.org/r/650086 (https://phabricator.wikimedia.org/T262959) [11:04:36] (03PS4) 10Ammarpad: Consider SpecialBadtitle as always known [core] - 10https://gerrit.wikimedia.org/r/650086 (https://phabricator.wikimedia.org/T262959) [11:07:36] 10Structured-Data-Backlog, 10Patch-For-Review: Commons search auto-suggest for "files depicting..." should filter out articles - https://phabricator.wikimedia.org/T265187 (10matthiasmullie) The code for this live here: https://github.com/wikimedia/mediawiki-extensions-WikibaseMediaInfo/tree/master/resources/se... [11:09:21] (03Merged) 10jenkins-bot: Vuex application module cleanup [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/649378 (owner: 10Nik Gkountas) [11:11:11] 10WMF-Legal, 10Wikimedia-Site-requests, 10Community-consensus-needed: Allow local file uploads on Ukrainian Wikisource - https://phabricator.wikimedia.org/T262193 (10Arxivist) >>! In T262193#6697192, @Aklapper wrote: > Please provide references for statements like judicial practice - thanks. At the moment... [11:15:33] (03CR) 10KartikMistry: [C: 03+2] config: Enable en->ts MT pair for OpusMT [services/cxserver] - 10https://gerrit.wikimedia.org/r/650084 (https://phabricator.wikimedia.org/T262192) (owner: 10KartikMistry) [11:17:16] 10CAS-SSO, 10Graphite: Cannot log into grafana-rw.wikimedia.org (Application Not Authorized to Use CAS) - https://phabricator.wikimedia.org/T270374 (10Lucas_Werkmeister_WMDE) [11:17:23] 10CX-deployments, 10Language-Team (Language-2020-October-December): Update apertium to 3.7 release - https://phabricator.wikimedia.org/T247585 (10KartikMistry) [11:17:44] (03CR) 10Abijeet Patro: [C: 03+2] SX: Use dependency injection for mw.cx.siteMapper [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/649379 (owner: 10Nik Gkountas) [11:18:13] (03Merged) 10jenkins-bot: config: Enable en->ts MT pair for OpusMT [services/cxserver] - 10https://gerrit.wikimedia.org/r/650084 (https://phabricator.wikimedia.org/T262192) (owner: 10KartikMistry) [11:18:24] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Saving identical references with different retrieval dates should be more difficult - https://phabricator.wikimedia.org/T270375 (10Epidosis) [11:18:52] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Saving identical references with different retrieval dates should be more difficult - https://phabricator.wikimedia.org/T270375 (10Epidosis) [11:24:30] (03PS1) 10Pwirth: Upgrade to BS3 architecture [extensions/BlueSpiceReminder] (REL1_35) - 10https://gerrit.wikimedia.org/r/650102 [11:26:23] 10Wikimedia Design Style Guide: Add Dialogs to DSG - https://phabricator.wikimedia.org/T266029 (10Sarai-WMDE) Thanks for the detailed explanation, Matthew! I think everything makes sense and agree on all the decisions made. Great job! [11:26:39] 10MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-FY-2020-21), 10Vue.js (Vue.js-Search): Feed Vue.js run time errors to error intake system - https://phabricator.wikimedia.org/T249826 (10phuedx) >>! In T249826#6697146, @Jdlrobson wrote: > I seem to be getting... [11:29:15] 10CAS-SSO, 10Graphite, 10Patch-For-Review: Cannot log into grafana-rw.wikimedia.org (Application Not Authorized to Use CAS) - https://phabricator.wikimedia.org/T270374 (10fgiunchedi) I fixed what I thought was the likely culprit (duplicated id in config) although I'm still getting application not authorized... [11:31:41] 10Phabricator, 10I18n, 10Patch-For-Review: incorrect display of dates in ISO 8601 format: non-sense displayed everywhere in Phabricator, missing years ! - https://phabricator.wikimedia.org/T269339 (10hashar) 05Open→03Resolved Yes that works! Thank you so much for deploying the fix @mmodell :] [11:39:31] (03Merged) 10jenkins-bot: SX: Use dependency injection for mw.cx.siteMapper [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/649379 (owner: 10Nik Gkountas) [11:39:54] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Search for every word in a query - https://phabricator.wikimedia.org/T268751 (10hueitan) [11:41:39] 10CAS-SSO, 10Graphite, 10Patch-For-Review: Cannot log into grafana-rw.wikimedia.org (Application Not Authorized to Use CAS) - https://phabricator.wikimedia.org/T270374 (10jbond) 05Open→03Resolved a:03jbond Sorry about this, should be fixed now >>! In T270374#6698043, @fgiunchedi wrote: > I fixed what... [11:48:54] 10Platform Engineering, 10TechCom-RFC, 10Discovery-Search (Current work), 10Structured-Data-Backlog (Current Work): RFC: Expand API title generator to support other generated data - https://phabricator.wikimedia.org/T263841 (10daniel) Per yesterday's TechCom meeting, this RFC enters the Last Call period. I... [11:48:58] 10OCG-PDFRenderer, 10Chinese-Sites, 10I18n, 10Serbian-Sites: PDF should be rendered in the user's specified language converter variant, e.g. Serbian in Latin script (sr-el) - https://phabricator.wikimedia.org/T73815 (10Aklapper) @Shizhao: That requires a login that not everybody has. Please summarize //rel... [11:51:36] 10MediaWiki-Stakeholders-Group, 10Platform Engineering, 10TechCom-RFC, 10Patch-For-Review: RFC: Drop support for older database upgrades - https://phabricator.wikimedia.org/T259771 (10daniel) There seems to be consensus that this is a good idea. Two LTS releases as originally proposed seem sufficient, give... [12:03:36] 10MediaWiki-extensions-Scribunto: os.date doesn't set TTL for cache entry correctly - https://phabricator.wikimedia.org/T270378 (10matej_suchanek) [12:04:42] (03PS3) 10Nik Gkountas: SX Article Selector: Rename and refactor existing translation banner [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/649380 [12:04:44] (03PS3) 10Nik Gkountas: SX Article Selector refactoring: Create existing article body [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/649381 [12:09:41] 10CX-deployments, 10Language-Team (Language-2020-October-December): Update apertium to 3.7 release - https://phabricator.wikimedia.org/T247585 (10KartikMistry) [12:10:12] (03PS4) 10Nik Gkountas: SX Publish Translation: Support publishing in sandbox [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/644789 (https://phabricator.wikimedia.org/T260130) [12:12:21] (03CR) 10Shubham656jain: Disregard expired groups in GlobalUserGroups.php (031 comment) [extensions/GlobalUserGroups] - 10https://gerrit.wikimedia.org/r/649846 (https://phabricator.wikimedia.org/T160023) (owner: 10Shubham656jain) [12:14:56] (03CR) 10Abijeet Patro: [V: 03+1 C: 03+1] "Tested, and this works well. Left a suggestion." (031 comment) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/650020 (https://phabricator.wikimedia.org/T269415) (owner: 10Nik Gkountas) [12:27:30] (03PS1) 10Shubham656jain: Add length attribute in TitleLibrary.php [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/650107 (https://phabricator.wikimedia.org/T209679) [12:33:41] (03CR) 10Ammarpad: "recheck" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/650107 (https://phabricator.wikimedia.org/T209679) (owner: 10Shubham656jain) [12:38:07] 10Discovery-Search, 10Structured-Data-Backlog (Current Work): Include gsrprop & gsrsinfo data in search api generator response - https://phabricator.wikimedia.org/T270381 (10matthiasmullie) [12:38:54] (03CR) 10Nikerabbit: [C: 03+1] "Letting Nik respond to the comment." [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/650020 (https://phabricator.wikimedia.org/T269415) (owner: 10Nik Gkountas) [12:39:31] 10CX-cxserver, 10Language-Team (Language-2020-October-December), 10Parsoid (Tracking): Update cxserver to handle Parsoid HTML change from to - https://phabricator.wikimedia.org/T268309 (10Jpita) I only get this error in cx2, not in prod. can you tell me how I get the request payload? y... [12:40:20] 10SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), 10Structured-Data-Backlog (Current Work): [S] Media Search: Surfacing the result count - https://phabricator.wikimedia.org/T269383 (10matthiasmullie) Blocked by T270381 (which is actual implementation as a result of resolving T263841) [12:41:12] 10SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), 10Structured-Data-Backlog (Current Work): [M] Add "did you mean" feature to Media Search - https://phabricator.wikimedia.org/T260292 (10matthiasmullie) Blocked by T270381 (which is actual implementation as a result of resolving T263841) [12:45:30] 10WPCleaner: CW#501: Allow bot runs on a limited set of regular expressions - https://phabricator.wikimedia.org/T270382 (10NicoV) [12:46:22] 10Structured Data Engineering, 10SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), 10Structured-Data-Backlog (Current Work): Add formatted page/file size - https://phabricator.wikimedia.org/T262992 (10matthiasmullie) IIRC, this was blocked on not having the word count and page size available from the search... [12:48:14] 10WPCleaner: CW#501: Allow bot runs on a limited set of regular expressions - https://phabricator.wikimedia.org/T270382 (10NicoV) [12:48:49] (03CR) 10Nikerabbit: [V: 03+1 C: 03+1] "I'd prefer to limit the exposure of namespaceOptions, but this works. Leaving for Abijeet to check." [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/644789 (https://phabricator.wikimedia.org/T260130) (owner: 10Nik Gkountas) [12:49:22] 10WPCleaner: CW#501: Allow bot runs on a limited set of regular expressions - https://phabricator.wikimedia.org/T270382 (10NicoV) [12:49:24] 10WPCleaner: CW#501 Disable some regular expressions for spelling - https://phabricator.wikimedia.org/T258889 (10NicoV) [12:50:05] 10WPCleaner: CW#501: Allow bot runs on a limited set of regular expressions - https://phabricator.wikimedia.org/T270382 (10NicoV) [12:50:06] 10WPCleaner: CW#501 Disable some regular expressions for spelling - https://phabricator.wikimedia.org/T258889 (10NicoV) [12:50:08] 10WPCleaner: CW#501 (spelling and typography) Restrict replacements in alt attribute of images - https://phabricator.wikimedia.org/T256578 (10NicoV) [12:50:19] 10MediaWiki-Gerrit-Group-Requests, 10Gerrit: Update members of wmde-mediawiki Gerrit group - https://phabricator.wikimedia.org/T270383 (10Tobi_WMDE_SW) [12:51:33] 10WMIT-Infrastructure: Upgrade wiki.wikimedia.it from 1.26.4 to latest LTS - https://phabricator.wikimedia.org/T268515 (10valerio.bozzolan) I forgot to mention that yesterday I made some progresses here playing with a private/dummy MediaWiki instance based on the Wikimedia Italia's production `LocalSettings.php`... [12:52:35] (03CR) 10Nikerabbit: [C: 03+2] Minor RELEASE-NOTES fixes [core] - 10https://gerrit.wikimedia.org/r/650083 (owner: 10Amire80) [13:01:31] 10UI-Standardization, 10Desktop Improvements, 10DiscussionTools, 10Editing-team, and 5 others: Update link colors in Vector for improved UX (and consistency) - https://phabricator.wikimedia.org/T213778 (10ovasileva) [13:02:25] 10UI-Standardization, 10Desktop Improvements, 10DiscussionTools, 10Editing-team, and 5 others: Update link colors in Vector for improved UX (and consistency) - https://phabricator.wikimedia.org/T213778 (10ovasileva) Updated description with T213778#6501778 to make things more clearer [13:03:00] 10MediaWiki-extensions-Translate, 10Timeless, 10Regression, 10affects-translatewiki.net: Special:ManageMessageGroups: Button "Submit changes for processing" out of content div in Timeless skin - https://phabricator.wikimedia.org/T270385 (10Raymond) [13:04:10] 10MassMessage, 10Language-Team (Language-2020-October-December), 10MW-1.36-notes (1.36.0-wmf.16; 2020-11-03): Support sending only the specified section of a translatable page using Special:MassMessage - https://phabricator.wikimedia.org/T254483 (10abi_) Marking this as resolved. [13:04:18] 10MassMessage, 10Language-Team (Language-2020-October-December), 10MW-1.36-notes (1.36.0-wmf.16; 2020-11-03): Support sending only the specified section of a translatable page using Special:MassMessage - https://phabricator.wikimedia.org/T254483 (10abi_) 05Open→03Resolved [13:04:20] 10MediaWiki-extensions-Translate, 10MassMessage, 10Epic, 10Language-Team (Language-2020-October-December): Support sending TechNews using Special:MassMessage - https://phabricator.wikimedia.org/T254481 (10abi_) [13:06:52] 10IP Info, 10Anti-Harassment (The Letter Song), 10Patch-For-Review: Deploy IP Info extension to beta cluster - https://phabricator.wikimedia.org/T260599 (10Tchanders) [13:14:56] 10ContentTranslation, 10Language-Team (Language-2020-October-December): Requesting campaign tag for Wikidocumentaries in Content Translation - https://phabricator.wikimedia.org/T269875 (10KartikMistry) @Susannaanas Can you test and let us know if this working fine? [13:15:46] 10Performance Issue, 10Platform Team Workboards (Clinic Duty Team), 10mariadb-optimizer-bug: Slow query on arwiki for ApiQueryUserContribs::execute - https://phabricator.wikimedia.org/T240418 (10ArielGlenn) 05Open→03Resolved a:03ArielGlenn A check of tendril for the last 96 hours shows none of these, s... [13:15:56] (03PS1) 10Daniel Kinzler: EXPERIMENT: add types for local PageIdentities [core] - 10https://gerrit.wikimedia.org/r/650112 [13:20:53] (03Merged) 10jenkins-bot: Minor RELEASE-NOTES fixes [core] - 10https://gerrit.wikimedia.org/r/650083 (owner: 10Amire80) [13:21:32] 10OCG-PDFRenderer, 10Chinese-Sites, 10I18n, 10Serbian-Sites: PDF should be rendered in the user's specified language converter variant, e.g. Serbian in Latin script (sr-el) - https://phabricator.wikimedia.org/T73815 (10Taiwania_Justo) >>! In T73815#6698084, @Aklapper wrote: > @Shizhao: That requires a logi... [13:23:04] (03PS1) 10Ppchelko: Article: view from old revision cache - set correct revId. [core] - 10https://gerrit.wikimedia.org/r/650114 (https://phabricator.wikimedia.org/T270361) [13:25:14] 10MediaWiki-extensions-Translate, 10UI-Standardization, 10MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), 10Patch-For-Review, and 2 others: Convert Extension:Translate to OOUI - https://phabricator.wikimedia.org/T192542 (10Nikerabbit) >>! In T192542#6695455, @Nikerabbit wrote: > QA: Fail on translatewiki.net: T... [13:29:50] (03CR) 10Daniel Kinzler: [C: 03+2] Article: view from old revision cache - set correct revId. [core] - 10https://gerrit.wikimedia.org/r/650114 (https://phabricator.wikimedia.org/T270361) (owner: 10Ppchelko) [13:30:23] (03CR) 10Phuedx: "> Patch Set 3:" [core] - 10https://gerrit.wikimedia.org/r/647727 (https://phabricator.wikimedia.org/T249826) (owner: 10Phuedx) [13:32:43] (03CR) 10Phuedx: vue: Log component errors (031 comment) [core] - 10https://gerrit.wikimedia.org/r/643361 (https://phabricator.wikimedia.org/T249826) (owner: 10Jdlrobson) [13:33:42] (03PS1) 10Phuedx: Revert "vue: Log component errors" [core] - 10https://gerrit.wikimedia.org/r/649922 [13:34:25] (03CR) 10Ppchelko: EXPERIMENT: add types for local PageIdentities (031 comment) [core] - 10https://gerrit.wikimedia.org/r/650112 (owner: 10Daniel Kinzler) [13:34:46] (03PS1) 10Ppchelko: Article: view from old revision cache - set correct revId. [core] (wmf/1.36.0-wmf.22) - 10https://gerrit.wikimedia.org/r/649923 (https://phabricator.wikimedia.org/T270361) [13:35:03] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.33x-R-Rosgulla): Build Watchlist diff view - https://phabricator.wikimedia.org/T269447 (10schoenbaechler) >>! In T269447#6697557, @Sharvaniharan wrote: > @schoenbaechler could I please get the icons for profile and contributions options in the menu here... [13:38:42] (03CR) 10Daniel Kinzler: EXPERIMENT: add types for local PageIdentities (031 comment) [core] - 10https://gerrit.wikimedia.org/r/650112 (owner: 10Daniel Kinzler) [13:40:30] (03CR) 10Ppchelko: EXPERIMENT: add types for local PageIdentities (031 comment) [core] - 10https://gerrit.wikimedia.org/r/650112 (owner: 10Daniel Kinzler) [13:44:31] (03CR) 10jerkins-bot: [V: 04-1] EXPERIMENT: add types for local PageIdentities [core] - 10https://gerrit.wikimedia.org/r/650112 (owner: 10Daniel Kinzler) [13:45:48] (03PS3) 10Amire80: Add Tyap to Names.php [core] - 10https://gerrit.wikimedia.org/r/650082 (https://phabricator.wikimedia.org/T270365) [13:57:50] 10VideoCutTool, 10I18n, 10good first task: Implement localisation and internationalisation in the tool - https://phabricator.wikimedia.org/T270263 (10dbarratt) This task doesn't seem related to #react-i18n, but I would highly recommend using it in your project. :) [13:58:42] (03Merged) 10jenkins-bot: Article: view from old revision cache - set correct revId. [core] - 10https://gerrit.wikimedia.org/r/650114 (https://phabricator.wikimedia.org/T270361) (owner: 10Ppchelko) [14:01:29] (03PS1) 10Sophivorus: Improve CSS [skins/Poncho] - 10https://gerrit.wikimedia.org/r/650119 [14:01:47] (03CR) 10Sophivorus: [C: 03+2] Improve CSS [skins/Poncho] - 10https://gerrit.wikimedia.org/r/650119 (owner: 10Sophivorus) [14:04:07] (03CR) 10jerkins-bot: [V: 04-1] Article: view from old revision cache - set correct revId. [core] (wmf/1.36.0-wmf.22) - 10https://gerrit.wikimedia.org/r/649923 (https://phabricator.wikimedia.org/T270361) (owner: 10Ppchelko) [14:04:16] 10MassMessage: Warn users about sending sections unmarked for translation - https://phabricator.wikimedia.org/T270386 (10abi_) [14:05:19] (03PS10) 10Cicalese: JS linting [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/644610 [14:05:48] 10MassMessage, 10Language-Team (Language-2020-October-December), 10MW-1.36-notes (1.36.0-wmf.16; 2020-11-03): Support sending only the specified section of a translatable page using Special:MassMessage - https://phabricator.wikimedia.org/T254483 (10abi_) Created {T270386} to track the unrelated issue. Reope... [14:05:50] (03CR) 10Daniel Kinzler: EXPERIMENT: add types for local PageIdentities (031 comment) [core] - 10https://gerrit.wikimedia.org/r/650112 (owner: 10Daniel Kinzler) [14:05:54] 10Abstract Wikipedia UX, 10Abstract Wikipedia (Phase β): Fix direct mutations of properties. - https://phabricator.wikimedia.org/T270290 (10gengh) a:03gengh [14:07:22] (03Merged) 10jenkins-bot: Improve CSS [skins/Poncho] - 10https://gerrit.wikimedia.org/r/650119 (owner: 10Sophivorus) [14:09:29] (03CR) 10Yaron Koren: [C: 03+2] Version 2.3 [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/649704 (owner: 10Yaron Koren) [14:11:00] (03PS19) 10Holger Knust: Add dumpWatchlist script to create partial SQL dump of watchlist table [core] - 10https://gerrit.wikimedia.org/r/623879 (https://phabricator.wikimedia.org/T51133) [14:11:11] (03PS1) 10Daimona Eaytoy: Create specialized variants of methods in Taintedness [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/650121 (https://phabricator.wikimedia.org/T270094) [14:11:45] (03PS3) 10Nikerabbit: Allow dynamic scaling of processes in runJobs.php [core] - 10https://gerrit.wikimedia.org/r/645534 (https://phabricator.wikimedia.org/T222144) [14:14:30] (03Merged) 10jenkins-bot: Version 2.3 [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/649704 (owner: 10Yaron Koren) [14:16:08] (03CR) 10Cicalese: "> Patch Set 9:" [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/644610 (owner: 10Cicalese) [14:16:47] 10Structured-Data-Backlog (Current Work): Use configured thumblimits rather than a hardcoded array of thumbnail widths - https://phabricator.wikimedia.org/T270388 (10matthiasmullie) [14:21:02] 10CX-deployments, 10Language-Team (Language-2020-October-December): Update cg3, lttoolbox, apertium-get, apertium-lex-tools. apertium-recursive, apertium-separable and apertium-anaphora packages - https://phabricator.wikimedia.org/T234182 (10KartikMistry) [14:23:04] 10CX-deployments, 10Language-Team (Language-2020-October-December): Update apertium to 3.7 release - https://phabricator.wikimedia.org/T247585 (10KartikMistry) [14:23:09] (03PS1) 10Daniel Kinzler: EXPERIMENT: assert wiki ID in getId(). [core] - 10https://gerrit.wikimedia.org/r/650126 [14:24:33] (03PS2) 10Daniel Kinzler: EXPERIMENT: add types for local PageIdentities [core] - 10https://gerrit.wikimedia.org/r/650112 [14:25:20] (03PS2) 10Daniel Kinzler: EXPERIMENT: assert wiki ID in getId(). [core] - 10https://gerrit.wikimedia.org/r/650126 [14:30:04] (03CR) 10Arturo Borrero Gonzalez: [C: 03+1] First commit (031 comment) [cloud/wmcs-ansible] - 10https://gerrit.wikimedia.org/r/647735 (owner: 10David Caro) [14:30:45] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/650128 (owner: 10L10n-bot) [14:30:58] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [wikimedia-cz/web-theme] - 10https://gerrit.wikimedia.org/r/650137 (owner: 10L10n-bot) [14:36:21] 10Structured-Data-Backlog (Current Work): Don't submit authentication requests prior to autocomplete search requests - https://phabricator.wikimedia.org/T270390 (10matthiasmullie) [14:36:45] (03CR) 10Nikerabbit: [C: 03+2] Localisation updates from https://translatewiki.net. [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/650128 (owner: 10L10n-bot) [14:36:57] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/650128 (owner: 10L10n-bot) [14:37:22] (03Abandoned) 10Nikerabbit: Localisation updates from https://translatewiki.net. [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/649339 (owner: 10L10n-bot) [14:37:28] (03Abandoned) 10Nikerabbit: Localisation updates from https://translatewiki.net. [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/647690 (owner: 10L10n-bot) [14:38:03] 10TechCom-RFC, 10Patch-For-Review, 10Platform Team Initiatives (Decoupling (CDP2)): RFC: Introduce PageIdentity to be used instead of WikiPage - https://phabricator.wikimedia.org/T208776 (10daniel) The last item of discussion besides naming seems to be how we avoid code that is not cross-wiki aware from gett... [14:38:32] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [wikimedia-cz/web-theme] - 10https://gerrit.wikimedia.org/r/650137 (owner: 10L10n-bot) [14:38:57] (03Abandoned) 10Nikerabbit: Localisation updates from https://translatewiki.net. [wikimedia-cz/web-theme] - 10https://gerrit.wikimedia.org/r/649350 (owner: 10L10n-bot) [14:39:03] 10Image-Recommendations: Initial Task API Spec - https://phabricator.wikimedia.org/T270201 (10sdkim) [14:39:44] 10DiscussionTools, 10Editing Design, 10OWC2020 (New Discussion 1.0): Make the affordance(s) for adding a new topic easier to identify and access - https://phabricator.wikimedia.org/T267444 (10iamjessklein) Thanks @ppelberg - adding a screenshot : {F33948165 width=800} [14:40:29] (03CR) 10jerkins-bot: [V: 04-1] Add dumpWatchlist script to create partial SQL dump of watchlist table [core] - 10https://gerrit.wikimedia.org/r/623879 (https://phabricator.wikimedia.org/T51133) (owner: 10Holger Knust) [14:41:20] (03CR) 10Clarakosi: [C: 03+2] WikiPage: add interim replacement for WikiPage::doEditContent() requiring $user [core] - 10https://gerrit.wikimedia.org/r/607073 (https://phabricator.wikimedia.org/T255507) (owner: 10Majavah) [14:44:03] (03PS2) 10DCausse: Add an utility class to validate an event against its schema [wikimedia-event-utilities] - 10https://gerrit.wikimedia.org/r/649896 (https://phabricator.wikimedia.org/T270371) [14:44:33] (03CR) 10DCausse: Add an utility class to validate an event against its schema (035 comments) [wikimedia-event-utilities] - 10https://gerrit.wikimedia.org/r/649896 (https://phabricator.wikimedia.org/T270371) (owner: 10DCausse) [14:45:34] 10TechCom-RFC, 10Patch-For-Review, 10Platform Team Initiatives (Decoupling (CDP2)): RFC: Introduce PageIdentity to be used instead of WikiPage - https://phabricator.wikimedia.org/T208776 (10ArielGlenn) Although I dislike having what is essentially the same assert method in three places in the first approach... [14:46:16] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Search for every word in a query - https://phabricator.wikimedia.org/T268751 (10SBisson) @hueitan the PR is still a draft but this task is in "code review". What's the status? [14:46:37] (03CR) 10Ppchelko: "recheck" [core] (wmf/1.36.0-wmf.22) - 10https://gerrit.wikimedia.org/r/649923 (https://phabricator.wikimedia.org/T270361) (owner: 10Ppchelko) [14:46:39] (03PS1) 10Genoveva Galarza: Fix mutation of properties in ZKey component [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/650143 [14:46:41] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/650143 (owner: 10Genoveva Galarza) [14:48:44] (03CR) 10jerkins-bot: [V: 04-1] EXPERIMENT: assert wiki ID in getId(). [core] - 10https://gerrit.wikimedia.org/r/650126 (owner: 10Daniel Kinzler) [14:50:25] (03CR) 10jerkins-bot: [V: 04-1] Fix mutation of properties in ZKey component [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/650143 (owner: 10Genoveva Galarza) [14:50:54] (03PS1) 10Pwirth: Make diff engienes extendable [extensions/BlueSpiceVisualDiff] (REL1_35) - 10https://gerrit.wikimedia.org/r/650146 [14:51:23] (03PS2) 10Pwirth: Make diff engines extendable [extensions/BlueSpiceVisualDiff] (REL1_35) - 10https://gerrit.wikimedia.org/r/650146 [14:52:30] 10WMF-Legal, 10Wikimedia-Site-requests, 10Community-consensus-needed: Allow local file uploads on Ukrainian Wikisource - https://phabricator.wikimedia.org/T262193 (10NickK) >>! In T262193#6698003, @Arxivist wrote: > >>>! In T262193#6697192, @Aklapper wrote: >> Please provide references for statements like j... [14:53:31] (03CR) 10jerkins-bot: [V: 04-1] EXPERIMENT: add types for local PageIdentities [core] - 10https://gerrit.wikimedia.org/r/650112 (owner: 10Daniel Kinzler) [14:55:19] (03PS3) 10Pwirth: Make diff engines extendable [extensions/BlueSpiceVisualDiff] (REL1_35) - 10https://gerrit.wikimedia.org/r/650146 [14:55:36] 10MediaWiki-API, 10Product-Infrastructure-Team-Backlog, 10Wikipedia-iOS-App-Backlog: Commons API not returning image data for Dec. 14 2020 picture of the day (in English and German) - https://phabricator.wikimedia.org/T270139 (10Jgiannelos) [14:56:44] (03CR) 10Lucas Werkmeister (WMDE): Create CentralAuthHeaderSessionProvider (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/643339 (https://phabricator.wikimedia.org/T268617) (owner: 10Daniel Kinzler) [15:01:08] (03PS20) 10Holger Knust: Add dumpWatchlist script to create partial SQL dump of watchlist table [core] - 10https://gerrit.wikimedia.org/r/623879 (https://phabricator.wikimedia.org/T51133) [15:01:45] (03PS1) 10Phuedx: Revert "vue: Log component errors" [core] (wmf/1.36.0-wmf.22) - 10https://gerrit.wikimedia.org/r/649924 [15:02:03] 10MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-FY-2020-21), 10Vue.js (Vue.js-Search): Feed Vue.js run time errors to error intake system - https://phabricator.wikimedia.org/T249826 (10phuedx) >>! In T249826#6698042, @phuedx wrote: > We'll need to revert th... [15:04:46] (03CR) 10Nikerabbit: [C: 03+2] Add Tyap to Names.php [core] - 10https://gerrit.wikimedia.org/r/650082 (https://phabricator.wikimedia.org/T270365) (owner: 10Amire80) [15:05:44] (03PS1) 10Genoveva Galarza: Remove event parameter from updateKey call [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/650147 [15:06:03] 10Structured-Data-Backlog (Current Work): Debounce autocomplete API requests - https://phabricator.wikimedia.org/T270394 (10matthiasmullie) [15:06:26] (03PS1) 10Jack Phoenix: Bump up the Echo icons in the personal tools area a tad bit [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/650148 [15:06:32] (03CR) 10Ppchelko: Create CentralAuthHeaderSessionProvider (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/643339 (https://phabricator.wikimedia.org/T268617) (owner: 10Daniel Kinzler) [15:07:35] 10Wikimedia-General-or-Unknown, 10Security: User authentication security issue (Oct 1, 2020) - https://phabricator.wikimedia.org/T264370 (10hashar) >>! In T264370#6696925, @AntiCompositeNumber wrote: > The task description states `Investigation is ongoing, details will be shared later.` > > I see nothing in h... [15:09:31] (03PS1) 10Genoveva Galarza: Fix eslint errors and warnings [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/650150 [15:11:02] (03Merged) 10jenkins-bot: WikiPage: add interim replacement for WikiPage::doEditContent() requiring $user [core] - 10https://gerrit.wikimedia.org/r/607073 (https://phabricator.wikimedia.org/T255507) (owner: 10Majavah) [15:11:07] (03CR) 10jerkins-bot: [V: 04-1] Remove event parameter from updateKey call [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/650147 (owner: 10Genoveva Galarza) [15:12:09] 10Wikilink-Tool, 10Spike, 10The-Wikipedia-Library (Kanban): [SPIKE] Investigate Django async views [2hrs] - https://phabricator.wikimedia.org/T259866 (10Samwalton9) 05Open→03Resolved [15:12:12] 10Wikilink-Tool: Pages shouldn't time out due to expensive database queries - https://phabricator.wikimedia.org/T240673 (10Samwalton9) [15:12:21] 10Library-Card-Platform, 10The-Wikipedia-Library (Kanban): Replace docker.io with quay.io for wikipedialibrary images - https://phabricator.wikimedia.org/T269784 (10Samwalton9) 05Open→03Resolved [15:12:38] (03CR) 10Jack Phoenix: [C: 03+1] "Tested this extensively yesterday with a bunch of skins, some FOSS, some not; some maintained in gerrit, some not. In general this was an " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/612954 (owner: 10Isarra) [15:13:32] 10Structured-Data-Backlog: Implement backward navigation when JS is not supported - https://phabricator.wikimedia.org/T270396 (10matthiasmullie) [15:13:34] 10Patch-For-Review, 10SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), 10Structured-Data-Backlog (Current Work): Debounce autocomplete API requests - https://phabricator.wikimedia.org/T270394 (10CBogen) [15:13:54] 10Library-Card-Platform, 10The-Wikipedia-Library (Kanban): Rework how recent edits are tracked for Library Bundle eligibility - https://phabricator.wikimedia.org/T265146 (10Samwalton9) Putting this (unresolved) in Done for monitoring. [15:15:25] 10SDAW-MediaSearch, 10Structured-Data-Backlog: Implement backward navigation when JS is not supported - https://phabricator.wikimedia.org/T270396 (10CBogen) [15:16:08] (03CR) 10Daimona Eaytoy: [C: 03+1] "> Patch Set 2:" (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/649672 (https://phabricator.wikimedia.org/T261067) (owner: 10Matěj Suchánek) [15:16:13] 10Patch-For-Review, 10SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), 10Structured-Data-Backlog (Current Work): Don't submit authentication requests prior to autocomplete search requests - https://phabricator.wikimedia.org/T270390 (10CBogen) [15:16:28] 10Image-Recommendations: Initial Task API Spec - https://phabricator.wikimedia.org/T270201 (10sdkim) [15:17:47] 10Patch-For-Review, 10SDAW-MediaSearch (MediaSearch-ReleaseCandidate2), 10Structured-Data-Backlog (Current Work): Use configured thumblimits rather than a hardcoded array of thumbnail widths - https://phabricator.wikimedia.org/T270388 (10CBogen) [15:19:01] (03CR) 10MGerlach: "Looks good. one open question about quotes. perhaps does not matter, but wanted to check before approving." (031 comment) [research/mwaddlink] (main) - 10https://gerrit.wikimedia.org/r/649452 (https://phabricator.wikimedia.org/T266826) (owner: 10Kosta Harlan) [15:19:36] (03CR) 10Abijeet Patro: [C: 04-1] SX Article Selector: Rename and refactor existing translation banner (031 comment) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/649380 (owner: 10Nik Gkountas) [15:20:29] 10CX-cxserver, 10Language-Team (Language-2020-October-December), 10Parsoid (Tracking): Update cxserver to handle Parsoid HTML change from to - https://phabricator.wikimedia.org/T268309 (10Nikerabbit) >>! In T268309#6698189, @Jpita wrote: > I only get this error in cx2, not in prod. > c... [15:25:27] 10Image-Recommendations: Initial Task API Spec - https://phabricator.wikimedia.org/T270201 (10sdkim) [15:25:39] 10MediaWiki-Parser, 10Platform Team Workboards (Green): Update grafana dashboards related to ParserCache/ParserOutputAccess - https://phabricator.wikimedia.org/T269604 (10Pchelolo) 05Open→03Resolved [15:26:21] (03CR) 10Ottomata: [C: 03+1] "One nit but +1 one either way." (031 comment) [wikimedia-event-utilities] - 10https://gerrit.wikimedia.org/r/649896 (https://phabricator.wikimedia.org/T270371) (owner: 10DCausse) [15:28:55] 10Image-Recommendations: Initial Task API Spec - https://phabricator.wikimedia.org/T270201 (10sdkim) [15:31:17] 10Anti-Harassment, 10IP Info, 10Security Readiness Reviews, 10secscrum: Security review of IP Info extension - https://phabricator.wikimedia.org/T260822 (10sbassett) **Update:** I've performed several automated security checks and scans against the code base and have not found anything concerning. I'd lik... [15:31:34] (03PS1) 10Jack Phoenix: Fix issue with UTF-8 characters in content action menus being garbled [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/650157 [15:32:24] (03CR) 10Jack Phoenix: [C: 03+2] Fix issue with UTF-8 characters in content action menus being garbled [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/650157 (owner: 10Jack Phoenix) [15:34:09] (03Merged) 10jenkins-bot: Add Tyap to Names.php [core] - 10https://gerrit.wikimedia.org/r/650082 (https://phabricator.wikimedia.org/T270365) (owner: 10Amire80) [15:36:34] 10MediaWiki-extensions-Graph, 10Product-Infrastructure-Team-Backlog, 10Mobile, 10Wikimedia-production-error, 10covid-19: Uncaught TypeError: Cannot read property 'items' of null / TypeError: null is not an object (evaluating 'view.model().scene().items') - https://phabricator.wikimedia.org/T269308 (10Jse... [15:36:38] 10MediaWiki-Codesniffer, 10phan: Consider replacing complex or non-style-related PHPCS sniffs with one or more phan plugins - https://phabricator.wikimedia.org/T270398 (10Daimona) [15:38:30] (03CR) 10Matěj Suchánek: Implement GetAutoPromoteGroupsHook (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/649672 (https://phabricator.wikimedia.org/T261067) (owner: 10Matěj Suchánek) [15:38:55] (03CR) 10Ottomata: "One inline comment but otherwise LGTM!" (032 comments) [schemas/event/secondary] - 10https://gerrit.wikimedia.org/r/649599 (https://phabricator.wikimedia.org/T262209) (owner: 10Awight) [15:41:27] (03CR) 10Daimona Eaytoy: [C: 03+1] Implement GetAutoPromoteGroupsHook (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/649672 (https://phabricator.wikimedia.org/T261067) (owner: 10Matěj Suchánek) [15:46:28] 10Product-Analytics (Kanban): Updated number of editors across all wikipedias and all projects per month - https://phabricator.wikimedia.org/T269625 (10nshahquinn-wmf) >>! In T269625#6697449, @SNowick_WMF wrote: > According to Wikistats (https://stats.wikimedia.org/#/all-projects/reading/total-page-views/normal|... [15:47:14] 10DiscussionTools, 10Editing Design, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: Add support for preloaded text - https://phabricator.wikimedia.org/T269310 (10Esanders) @matmarex We need a way to suppress the anon edit notice as we already have one built in to the widget. [15:52:55] 10MediaWiki-extensions-Graph, 10Product-Infrastructure-Team-Backlog, 10Mobile, 10Wikimedia-production-error, 10covid-19: Uncaught TypeError: Cannot read property 'items' of null / TypeError: null is not an object (evaluating 'view.model().scene().items') - https://phabricator.wikimedia.org/T269308 (10Jse... [15:53:24] (03PS1) 10Pwirth: Use hook handler base class for hook ArticleContentOnDiff [extensions/BlueSpiceVisualDiff] (REL1_35) - 10https://gerrit.wikimedia.org/r/650162 [15:54:30] 10Image-Recommendations: Initial Task API Spec - https://phabricator.wikimedia.org/T270201 (10sdkim) [15:56:47] (03PS1) 10Giuseppe Lavagetto: Allow 'make test' to properly run all tests [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/650163 [15:57:54] 10AbuseFilter: Allow AbuseFilter to check presence of location data in file uploads - https://phabricator.wikimedia.org/T270399 (10Heddy10) [16:01:33] (03PS1) 10Genoveva Galarza: Fix mutation of property in TypeSelector component [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/650164 [16:02:31] 10TimedMediaHandler-TimedText: Display available subtitles in thumbnail - https://phabricator.wikimedia.org/T270400 (10Ainali) [16:05:03] (03CR) 10Jason Linehan: "> Patch Set 3:" [core] - 10https://gerrit.wikimedia.org/r/647727 (https://phabricator.wikimedia.org/T249826) (owner: 10Phuedx) [16:06:05] 10MediaWiki-Parser, 10Parsoid, 10TemplateStyles: Unwanted non-breaking space added before a ':' in TemplateStyles rules - https://phabricator.wikimedia.org/T255007 (10Od1n) Despite the above patch, the problem is still present on frwiki… [16:07:06] 10Abstract Wikipedia UX, 10Abstract Wikipedia (Phase β): Fix direct mutations of properties. - https://phabricator.wikimedia.org/T270290 (10gengh) Submitted two patches fixing this (actually, four), hopefully I've done this alright: * For ZKey https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/... [16:07:44] 10AbuseFilter: Allow AbuseFilter to check presence of location data in file uploads - https://phabricator.wikimedia.org/T270399 (10Heddy10) [16:09:45] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Yellow hornets of kindness and healing, 10Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (10Ejegg) @AndyRussG That simplification for first release s... [16:10:14] 10IP Info, 10Anti-Harassment (The Letter Song), 10Patch-For-Review: Add informative text at the bottom of IP Info box to indicate data source - https://phabricator.wikimedia.org/T270306 (10Prtksxna) This is looking great @STran! Thanks for sharing the screenshots. I'll make follow-up tasks for the padding th... [16:13:45] (03CR) 10DCausse: Add an utility class to validate an event against its schema (031 comment) [wikimedia-event-utilities] - 10https://gerrit.wikimedia.org/r/649896 (https://phabricator.wikimedia.org/T270371) (owner: 10DCausse) [16:15:39] 10Image-Recommendations: Initial Task API Spec - https://phabricator.wikimedia.org/T270201 (10sdkim) > 1. the Task API will be a REST API exposed via api.wikimedia.org (it may or may not also be exposed in other ways, depending on implementation details) > 2. tasks will be project-specific (we'll display tasks f... [16:15:41] (03PS5) 10Esanders: Add "new topic" user preference [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/649930 (https://phabricator.wikimedia.org/T270119) [16:16:55] (03CR) 10Esanders: "I rewrote this to provide more control (disabling features completely) while still being backwards compatible with our existing configs." [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/649930 (https://phabricator.wikimedia.org/T270119) (owner: 10Esanders) [16:17:06] (03PS6) 10Esanders: Add "new topic" user preference [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/649930 (https://phabricator.wikimedia.org/T270119) [16:19:20] 10Wikisource Export, 10Community-Tech (Kanban-2020-21-Q2): Wikisource Export: Cache all API requests - https://phabricator.wikimedia.org/T265660 (10dom_walden) @Samwilson I am finding that, with caching enabled, images are not being included in ebooks (e.g. https://wsexport-test.wmflabs.org/?lang=en&page=Life+... [16:20:10] 10MediaWiki-Codesniffer, 10phan: Consider replacing complex or non-style-related PHPCS sniffs with one or more phan plugins - https://phabricator.wikimedia.org/T270398 (10Daimona) Here are some examples of sniffs that might be migrated. I might write a POC if I find some time in the next couple of days: - Unu... [16:22:02] 10CX-cxserver, 10Language-Team (Language-2020-October-December), 10Parsoid (Tracking): Update cxserver to handle Parsoid HTML change from to - https://phabricator.wikimedia.org/T268309 (10Jpita) sent over slack [16:22:42] 10MediaWiki-File-management, 10Commons, 10Structured Data Engineering, 10Structured-Data-Backlog, and 2 others: Develop maintenance script for enumerating Swift media files from MediaWiki (for backup processing) - https://phabricator.wikimedia.org/T267365 (10LSobanski) @ArielGlenn will look into whether UR... [16:26:15] (03CR) 10Tchanders: "When I comment out $this->markTestSkipped(), the test passes locally for me. Does it require more specific config to make it a failing tes" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/649696 (https://phabricator.wikimedia.org/T270145) (owner: 10Paladox) [16:26:41] (03CR) 10jerkins-bot: [V: 04-1] Add "new topic" user preference [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/649930 (https://phabricator.wikimedia.org/T270119) (owner: 10Esanders) [16:31:05] 10MediaWiki-Page-diffs, 10MediaWiki-Page-history, 10Editing QA, 10VisualEditor, and 5 others: Include section name in the revision history visual diff - https://phabricator.wikimedia.org/T268950 (10Esanders) [16:31:54] 10MediaWiki-Docker, 10Operations, 10Traffic, 10serviceops, and 2 others: docker pull from docker-registry fails with `ERROR: missing or empty Content-Length header` - https://phabricator.wikimedia.org/T270270 (10JMeybohm) 05Open→03Resolved a:03JMeybohm For the record: We where sending "Content-Type:... [16:31:59] 10MediaWiki-Docker, 10Operations, 10Traffic, 10serviceops, and 2 others: docker pull from docker-registry fails with `ERROR: missing or empty Content-Length header` - https://phabricator.wikimedia.org/T270270 (10ema) This should now be fixed by using https://gerrit.wikimedia.org/r/c/operations/puppet/+/650... [16:35:04] 10MediaWiki-Containers, 10Operations: Homepage for https://docker-registry.wikimedia.org - https://phabricator.wikimedia.org/T179696 (10dancy) Right now when you visit https://docker-registry.wikimedia.org/ you get a generic nginx welcome page. I propose having this URL redirect to https://dockerregistry.tool... [16:35:08] (03PS1) 10Gmodena: Fix ingestion on prod datatabse. [services/similar-users] (main) - 10https://gerrit.wikimedia.org/r/650172 [16:36:05] (03PS2) 10Gmodena: Fix ingestion on prod database. [services/similar-users] (main) - 10https://gerrit.wikimedia.org/r/650172 [16:38:06] 10MediaWiki-extensions-SecurePoll, 10Platform Engineering, 10Anti-Harassment (The Letter Song): Investigate issues with admins getting removed in poll settings - https://phabricator.wikimedia.org/T269030 (10Niharika) 05Open→03Resolved Follow-up work in {T270200}. [16:38:08] 10MediaWiki-extensions-SecurePoll, 10Anti-Harassment: Technical investigations into problems for SecurePoll - https://phabricator.wikimedia.org/T269023 (10Niharika) [16:39:31] 10MediaWiki-File-management, 10Commons, 10Structured Data Engineering, 10Structured-Data-Backlog, and 2 others: Develop maintenance script for enumerating Swift media files from MediaWiki (for backup processing) - https://phabricator.wikimedia.org/T267365 (10jcrespo) Urls exist on the database- that I can... [16:40:05] 10MediaWiki-Docker, 10Operations, 10Traffic, 10serviceops, and 2 others: docker pull from docker-registry fails with `ERROR: missing or empty Content-Length header` - https://phabricator.wikimedia.org/T270270 (10kostajh) 05Resolved→03Open >>! In T270270#6698851, @ema wrote: > This should now be fixed b... [16:41:39] 10MediaWiki-Docker, 10Operations, 10Traffic, 10serviceops, and 2 others: docker pull from docker-registry fails with `ERROR: missing or empty Content-Length header` - https://phabricator.wikimedia.org/T270270 (10JMeybohm) Maybe Mac sends a different user-agent? That would be fun... [16:43:09] 10MediaWiki-File-management, 10Commons, 10Structured Data Engineering, 10Structured-Data-Backlog, and 2 others: Develop maintenance script for enumerating Swift media files from MediaWiki (for backup processing) - https://phabricator.wikimedia.org/T267365 (10jcrespo) > Any plans for slicing it or otherwise... [16:43:25] 10Product-Analytics (Kanban): Check that KaiOS previews are being properly counted - https://phabricator.wikimedia.org/T269836 (10nshahquinn-wmf) 05Open→03Resolved Results posted in T244548; the counting is working fine with one minor issue that's not worth worrying about. [16:44:52] 10Product-Analytics (Kanban): Prepare an introduction to Oozie for the sharing meeting - https://phabricator.wikimedia.org/T234994 (10nshahquinn-wmf) a:03nshahquinn-wmf [16:45:43] (03CR) 10Jforrester: [C: 03+2] Fix mutation of property in TypeSelector component [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/650164 (owner: 10Genoveva Galarza) [16:49:11] (03PS1) 10Ottomata: Prepend an HTML warningbox if a schema has been disabled or migrated [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/650174 (https://phabricator.wikimedia.org/T270136) [16:49:33] 10MediaWiki-extensions-Graph, 10Product-Infrastructure-Team-Backlog, 10Mobile, 10Wikimedia-production-error, 10covid-19: Uncaught TypeError: Cannot read property 'items' of null / TypeError: null is not an object (evaluating 'view.model().scene().items') - https://phabricator.wikimedia.org/T269308 (10Jdl... [16:50:28] (03Merged) 10jenkins-bot: Fix mutation of property in TypeSelector component [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/650164 (owner: 10Genoveva Galarza) [16:50:30] (03CR) 10Ottomata: "I am not a web dev and also not a MW dev, so please hack away and fix my horrible attempts at HTML and CSS in MW. 😊" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/650174 (https://phabricator.wikimedia.org/T270136) (owner: 10Ottomata) [16:50:39] (03CR) 10Jdlrobson: [C: 03+2] "(Note I discovered this while doing some Vue local development)" [core] - 10https://gerrit.wikimedia.org/r/649922 (owner: 10Phuedx) [16:51:05] (03CR) 10Ottomata: "This allows us to set an entry in wgEventLoggingSchemas to false if we are going to not migrate it (disable it completely)." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/650174 (https://phabricator.wikimedia.org/T270136) (owner: 10Ottomata) [16:52:28] (03CR) 10Jdlrobson: [C: 04-1] "This needs unit tests." [core] - 10https://gerrit.wikimedia.org/r/650026 (https://phabricator.wikimedia.org/T206954) (owner: 10Ammarpad) [16:53:45] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: Inconsistent behaviour of mw.centralNotice.customHideBanner - https://phabricator.wikimedia.org/T270401 (10Pcoombe) [16:54:28] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.33x-R-Rosgulla): Build Watchlist main screen - https://phabricator.wikimedia.org/T269445 (10schoenbaechler) **Great work so far @Dbrant!** 👏 01) Don’t show the language when there’s only one app language. {F33948273} 02) Truncate at 4 lines {F33948275... [16:54:57] (03CR) 10Jdlrobson: "Neat! Kosta: how does one turn this into a unit test? Would it be a case of living in tests/phpunit/unit/includes/skins/SkinTest.php" [core] - 10https://gerrit.wikimedia.org/r/650032 (https://phabricator.wikimedia.org/T270363) (owner: 10Ammarpad) [16:55:57] 10MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-FY-2020-21), 10Vue.js (Vue.js-Search): Feed Vue.js run time errors to error intake system - https://phabricator.wikimedia.org/T249826 (10Jdlrobson) > I'm curious though, where are you seeing that error/those e... [16:56:05] 10Wikimedia-Site-requests: Allow admins and importers to import on mrwikibooks and set sources for the same. - https://phabricator.wikimedia.org/T270402 (10Sureshkhole) [16:56:28] (03PS5) 10Jdlrobson: Fix the styling of the installer and deprecate its RL module [core] - 10https://gerrit.wikimedia.org/r/649409 (https://phabricator.wikimedia.org/T270027) [16:56:34] 10MediaWiki-General, 10MediaWiki-Parser, 10WorkType-NewFunctionality: All parser functions and magic words should allow # preceding - https://phabricator.wikimedia.org/T18715 (10cscott) Agreed! [16:56:48] 10MediaWiki-Parser, 10Parsoid: Behavior switch/magic word uniformity - https://phabricator.wikimedia.org/T204370 (10cscott) [16:56:52] 10DiscussionTools, 10Editing Design, 10OWC2020 (New Discussion 1.0): Post call for New Discussion Tool prototype feedback on mediawiki.org - https://phabricator.wikimedia.org/T268702 (10iamjessklein) Has this been posted anywhere yet? [16:56:59] 10MediaWiki-General, 10MediaWiki-Parser, 10WorkType-NewFunctionality: All parser functions and magic words should allow # preceding - https://phabricator.wikimedia.org/T18715 (10cscott) [17:00:36] 10MediaWiki-Cache, 10MW-1.31-release, 10MW-1.35-notes, 10MW-1.35-release, and 2 others: MemcachedClient: PHP Warning: Resource ID#784 used as offset, casting to integer (784) - https://phabricator.wikimedia.org/T269178 (10Florian) >>! In T269178#6665304, @Reedy wrote: > No one has +2d the master patch thou... [17:00:55] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.33x-R-Rosgulla): Build Watchlist add/remove workflow from article - https://phabricator.wikimedia.org/T269446 (10cooltey) Hi @schoenbaechler Please download the APK to test it: https://github.com/wikimedia/apps-android-wikipedia/suites/1682541973/artifa... [17:01:47] (03CR) 10Florianschmidtwelzow: [C: 03+2] Avoid new StdClass() in favor of (object)[] [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/649293 (owner: 10Thiemo Kreuz (WMDE)) [17:02:53] (03CR) 10DannyS712: Add dumpWatchlist script to create partial SQL dump of watchlist table (032 comments) [core] - 10https://gerrit.wikimedia.org/r/623879 (https://phabricator.wikimedia.org/T51133) (owner: 10Holger Knust) [17:03:14] (03CR) 10Isarra: [C: 03+2] CologneBlue HTML should be consistent with other skins [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/648344 (owner: 10Jdlrobson) [17:03:26] (03CR) 10Ppchelko: WIP: Authority interface experiment (031 comment) [core] - 10https://gerrit.wikimedia.org/r/620112 (owner: 10Daniel Kinzler) [17:04:55] (03PS28) 10Phuedx: Simplify menu code [skins/Vector] - 10https://gerrit.wikimedia.org/r/624909 (https://phabricator.wikimedia.org/T268157) (owner: 10Jdlrobson) [17:06:17] 10MediaWiki-Special-pages, 10MediaWiki-User-management, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), 10Patch-For-Review, 10Platform Team Workboards (External Code Reviews): Enable wgRelevantUserName for IP ranges - https://phabricator.wikimedia.org/T206954 (10Jdlrobson) Not sure I understand what's broke... [17:06:42] (03PS29) 10Phuedx: Simplify menu code [skins/Vector] - 10https://gerrit.wikimedia.org/r/624909 (https://phabricator.wikimedia.org/T268157) (owner: 10Jdlrobson) [17:07:22] (03PS1) 10Nray: Remove suggestion link underline on hover and li bottom margin [skins/Vector] - 10https://gerrit.wikimedia.org/r/650180 (https://phabricator.wikimedia.org/T270202) [17:07:57] (03PS2) 10Isarra: Position Echo badges consistently with margins [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/649963 [17:08:25] 10TimedMediaHandler-TimedText: Display available subtitles in thumbnail - https://phabricator.wikimedia.org/T270400 (10Aklapper) [17:11:38] 10DiscussionTools, 10Editing Design, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: Add edit notice element to New Discussion Tool - https://phabricator.wikimedia.org/T269033 (10iamjessklein) Thanks for doing that research @matmarex I agree an wonder if we need it on the // message level //o... [17:12:31] (03PS23) 10Jdlrobson: CologneBlue implemented with SkinMustache [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/606798 (https://phabricator.wikimedia.org/T248751) [17:12:34] (03CR) 10Isarra: [C: 03+2] "I kind of want to complain that there's got to be a neater, more generic approach here, but given this exactly maintains current behaviour" [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/650148 (owner: 10Jack Phoenix) [17:12:58] (03CR) 10jerkins-bot: [V: 04-1] Prepend an HTML warningbox if a schema has been disabled or migrated [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/650174 (https://phabricator.wikimedia.org/T270136) (owner: 10Ottomata) [17:13:24] (03PS2) 10Isarra: Fix issue with UTF-8 characters in content action menus being garbled [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/650157 (owner: 10Jack Phoenix) [17:13:28] (03CR) 10Isarra: [V: 03+2] Fix issue with UTF-8 characters in content action menus being garbled [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/650157 (owner: 10Jack Phoenix) [17:13:40] 10Wikipedia-Android-App-Backlog: Remove shadow from app bar in articles - https://phabricator.wikimedia.org/T270168 (10LGoto) p:05Triage→03Low [17:13:41] (03CR) 10Isarra: [V: 03+2] "No reason to make this wait on the echo thing..." [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/650157 (owner: 10Jack Phoenix) [17:13:59] (03Abandoned) 10Jdlrobson: Content navigation links can provide their own IDs [core] - 10https://gerrit.wikimedia.org/r/648341 (owner: 10Jdlrobson) [17:14:04] (03CR) 10Ppchelko: WIP: Authority interface experiment (031 comment) [core] - 10https://gerrit.wikimedia.org/r/620112 (owner: 10Daniel Kinzler) [17:14:36] (03Merged) 10jenkins-bot: Revert "vue: Log component errors" [core] - 10https://gerrit.wikimedia.org/r/649922 (owner: 10Phuedx) [17:14:41] (03Merged) 10jenkins-bot: Avoid new StdClass() in favor of (object)[] [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/649293 (owner: 10Thiemo Kreuz (WMDE)) [17:14:43] (03Merged) 10jenkins-bot: CologneBlue HTML should be consistent with other skins [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/648344 (owner: 10Jdlrobson) [17:14:44] 10Wikipedia-Android-App-Backlog: [Bug] Internal link should scroll to section - https://phabricator.wikimedia.org/T269981 (10LGoto) p:05Triage→03Low [17:14:54] 10MediaWiki-extensions-Graph, 10Product-Infrastructure-Team-Backlog, 10Mobile, 10Wikimedia-production-error, 10covid-19: Uncaught TypeError: Cannot read property 'items' of null / TypeError: null is not an object (evaluating 'view.model().scene().items') - https://phabricator.wikimedia.org/T269308 (10Mil... [17:14:59] (03PS36) 10Paladox: Add test showing that getBlock can recurse if you use Autopromote and use APCOND_BLOCKED [core] - 10https://gerrit.wikimedia.org/r/649696 (https://phabricator.wikimedia.org/T270145) [17:15:07] (03PS20) 10Paladox: Fix infinite recursion with wgAutopromote when using getBlock within checkCondition [core] - 10https://gerrit.wikimedia.org/r/649910 (https://phabricator.wikimedia.org/T270145) [17:15:13] (03PS37) 10Paladox: Add test showing that getBlock can recurse if you use Autopromote and use APCOND_BLOCKED [core] - 10https://gerrit.wikimedia.org/r/649696 (https://phabricator.wikimedia.org/T270145) [17:15:20] (03PS21) 10Paladox: Fix infinite recursion with wgAutopromote when using getBlock within checkCondition [core] - 10https://gerrit.wikimedia.org/r/649910 (https://phabricator.wikimedia.org/T270145) [17:16:03] (03PS1) 10Jdlrobson: Rename CologneBlueTemplate to CologneBlueHooks [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/650181 [17:17:50] (03CR) 10jerkins-bot: [V: 04-1] Rename CologneBlueTemplate to CologneBlueHooks [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/650181 (owner: 10Jdlrobson) [17:18:07] (03CR) 10Isarra: "Hmm, maybe we should have done this. Maybe we should do this now?" [core] - 10https://gerrit.wikimedia.org/r/426840 (owner: 10Isarra) [17:20:00] (03PS1) 10Nray: [typeahead-search] Make footer suggestion background color on hover the same as other suggestions [wvui] - 10https://gerrit.wikimedia.org/r/650182 (https://phabricator.wikimedia.org/T270202) [17:20:03] (03PS1) 10Nray: [typeahead-search] Make search button appear as part of input box [wvui] - 10https://gerrit.wikimedia.org/r/650183 (https://phabricator.wikimedia.org/T270202) [17:21:53] (03PS38) 10Paladox: Add test showing that getBlock can recurse if you use Autopromote and use APCOND_BLOCKED [core] - 10https://gerrit.wikimedia.org/r/649696 (https://phabricator.wikimedia.org/T270145) [17:22:03] (03PS22) 10Paladox: Fix infinite recursion with wgAutopromote when using getBlock within checkCondition [core] - 10https://gerrit.wikimedia.org/r/649910 (https://phabricator.wikimedia.org/T270145) [17:22:15] 10Mathe für Nicht-Freaks: Unendlich-dimensionale lineare Unabhängigkeit - https://phabricator.wikimedia.org/T247534 (10ZornschesLemma) a:05SimonWeinzierl→03Mathewally [17:22:20] (03PS2) 10Jforrester: Fix mutation of properties in ZKey component [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/650143 (owner: 10Genoveva Galarza) [17:22:22] (03PS2) 10Jforrester: Remove event parameter from updateKey call [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/650147 (owner: 10Genoveva Galarza) [17:22:24] (03PS2) 10Jforrester: Fix eslint errors and warnings [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/650150 (owner: 10Genoveva Galarza) [17:22:27] 10Library-Card-Platform, 10The-Wikipedia-Library (Kanban): Fix Oxford University Press Law proxy URLs - https://phabricator.wikimedia.org/T269743 (10jsn.sherman) Change flagged for preprod. [17:22:43] 10MediaWiki-Special-pages, 10MediaWiki-User-management, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), 10Patch-For-Review, 10Platform Team Workboards (External Code Reviews): Enable wgRelevantUserName for IP ranges - https://phabricator.wikimedia.org/T206954 (10Ammarpad) >>! In T206954#6698974, @Jdlrobson... [17:22:48] (03CR) 10Paladox: "> Patch Set 35:" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/649696 (https://phabricator.wikimedia.org/T270145) (owner: 10Paladox) [17:22:55] (03PS1) 10Daimona Eaytoy: Add boilerplate for creating plugins and running PHPUnit tests [tools/phan] - 10https://gerrit.wikimedia.org/r/650184 [17:23:03] (03CR) 10Ppchelko: WIP: Authority interface experiment (031 comment) [core] - 10https://gerrit.wikimedia.org/r/620112 (owner: 10Daniel Kinzler) [17:24:17] (03CR) 10Reedy: "> Patch Set 35:" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/649696 (https://phabricator.wikimedia.org/T270145) (owner: 10Paladox) [17:24:22] (03CR) 10Daimona Eaytoy: [C: 04-2] "This should be rebased on Icc606d1838e93e9a0ff17d72be08e32d09012016, both because it syncs master with the 0.10 branch, and because the sa" [tools/phan] - 10https://gerrit.wikimedia.org/r/614025 (https://phabricator.wikimedia.org/T258227) (owner: 10Mainframe98) [17:24:42] 10MediaWiki-Core-Skin-Architecture, 10Patch-For-Review, 10Test-Coverage: Improve test coverage of core skin code - https://phabricator.wikimedia.org/T270363 (10Ammarpad) p:05Triage→03Medium [17:25:48] 10DiscussionTools, 10Editing Design, 10OWC2020 (New Discussion 1.0): Post call for New Discussion Tool prototype feedback on mediawiki.org - https://phabricator.wikimedia.org/T268702 (10ppelberg) >>! In T268702#6698934, @iamjessklein wrote: > Has this been posted anywhere yet? Not yet; we've been waiting o... [17:26:08] (03PS30) 10Phuedx: Simplify menu code [skins/Vector] - 10https://gerrit.wikimedia.org/r/624909 (https://phabricator.wikimedia.org/T268157) (owner: 10Jdlrobson) [17:26:30] 10Desktop Improvements, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-FY-2020-21), 10Vue.js: Design fixes for new vue.js search experience - https://phabricator.wikimedia.org/T270202 (10nray) [17:26:42] (03PS2) 10Esanders: Separate out isAvailableForTitleAndUser from isAvailable [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/649905 [17:26:45] (03PS2) 10Esanders: Make Hooks::$tags a constant [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/649926 [17:26:46] (03PS6) 10Esanders: Store reply links in the parser cache [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/641837 (https://phabricator.wikimedia.org/T267404) [17:27:28] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.33x-R-Rosgulla): Build Watchlist add/remove workflow from article - https://phabricator.wikimedia.org/T269446 (10schoenbaechler) Visually, this looks good to me! Just to confirm @cooltey → from a functional perspective it doesn’t work completely yet, righ... [17:27:31] 10MediaWiki-Installer, 10MediaWiki-extensions-OATHAuth, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), 10User-DannyS712: OATHAuth use of global defined in extension.json isn't available at install time - https://phabricator.wikimedia.org/T270147 (10matmarex) 05Open→03Resolved a:03Esanders Looks resolve... [17:27:55] 10MediaWiki-Docker, 10Operations, 10Traffic, 10serviceops, 10User-zeljkofilipin: docker pull from docker-registry fails with `ERROR: missing or empty Content-Length header` - https://phabricator.wikimedia.org/T270270 (10ema) >>! In T270270#6698866, @JMeybohm wrote: > Maybe Mac sends a different user-agen... [17:27:59] (03CR) 10jerkins-bot: [V: 04-1] Add boilerplate for creating plugins and running PHPUnit tests [tools/phan] - 10https://gerrit.wikimedia.org/r/650184 (owner: 10Daimona Eaytoy) [17:28:13] (03CR) 10Nray: "If anyone can think of a better way to do this, please let me know 😊" [wvui] - 10https://gerrit.wikimedia.org/r/650183 (https://phabricator.wikimedia.org/T270202) (owner: 10Nray) [17:30:41] (03CR) 10Jforrester: [C: 03+2] Fix mutation of properties in ZKey component [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/650143 (owner: 10Genoveva Galarza) [17:30:52] (03CR) 10Jforrester: [C: 03+2] Remove event parameter from updateKey call [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/650147 (owner: 10Genoveva Galarza) [17:30:55] (03PS2) 10Daimona Eaytoy: Add boilerplate for creating plugins and running PHPUnit tests [tools/phan] - 10https://gerrit.wikimedia.org/r/650184 [17:31:17] (03CR) 10Jforrester: "Mostly folded into the previous patches; should we abandon?" [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/650150 (owner: 10Genoveva Galarza) [17:33:31] (03PS3) 10Daimona Eaytoy: Add boilerplate for creating plugins and running PHPUnit tests [tools/phan] - 10https://gerrit.wikimedia.org/r/650184 [17:33:46] 10MediaWiki-Installer, 10MediaWiki-extensions-OATHAuth, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), 10User-DannyS712: OATHAuth use of global defined in extension.json isn't available at install time - https://phabricator.wikimedia.org/T270147 (10Reedy) Do we want to turn this into another bug for the MW i... [17:36:31] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.33x-R-Rosgulla): Build Watchlist add/remove workflow from article - https://phabricator.wikimedia.org/T269446 (10cooltey) >>! In T269446#6699044, @schoenbaechler wrote: > Visually, this looks good to me! Just to confirm @cooltey → from a functional perspe... [17:36:37] (03PS6) 10Isarra: Add new BaseTemplate::getFooterBlock function as replacement for getFooter for compatibility across all skins [core] - 10https://gerrit.wikimedia.org/r/426840 [17:37:15] (03PS24) 10Jdlrobson: CologneBlue implemented with SkinMustache [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/606798 (https://phabricator.wikimedia.org/T248751) [17:37:31] (03Abandoned) 10Isarra: Implement non-flat version of BaseTemplate::getFooter() [core] - 10https://gerrit.wikimedia.org/r/532770 (owner: 10Isarra) [17:37:35] (03CR) 10jerkins-bot: [V: 04-1] CologneBlue implemented with SkinMustache [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/606798 (https://phabricator.wikimedia.org/T248751) (owner: 10Jdlrobson) [17:39:29] 10Library-Card-Platform, 10The-Wikipedia-Library (Kanban): Fix Oxford University Press Law proxy URLs - https://phabricator.wikimedia.org/T269743 (10jsn.sherman) build failed, tweaked and reran. [17:40:55] (03PS25) 10Jdlrobson: CologneBlue implemented with SkinMustache [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/606798 (https://phabricator.wikimedia.org/T248751) [17:41:39] (03PS4) 10Daimona Eaytoy: Add boilerplate for creating plugins and running PHPUnit tests [tools/phan] - 10https://gerrit.wikimedia.org/r/650184 [17:41:48] (03CR) 10Isarra: [C: 04-1] "Hmmmmmm." [core] - 10https://gerrit.wikimedia.org/r/426844 (owner: 10Isarra) [17:42:30] (03CR) 10Isarra: [C: 04-1] "Suppose we just rename it, that might avoid conflicts... but what would be a good name?" [core] - 10https://gerrit.wikimedia.org/r/426844 (owner: 10Isarra) [17:42:59] 10Wikisource Export, 10Community-Tech (Kanban-2020-21-Q2): Wikisource: Reinstate OPDS export - https://phabricator.wikimedia.org/T268424 (10Inductiveload) [17:43:50] (03CR) 10Jforrester: [C: 03+2] Merge branch 'stable-0.10' [tools/phan] - 10https://gerrit.wikimedia.org/r/649366 (owner: 10Daimona Eaytoy) [17:44:22] (03CR) 10Jforrester: [C: 03+2] Preparation for 3.2.1 release [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/649301 (owner: 10Daimona Eaytoy) [17:45:31] (03Merged) 10jenkins-bot: Merge branch 'stable-0.10' [tools/phan] - 10https://gerrit.wikimedia.org/r/649366 (owner: 10Daimona Eaytoy) [17:46:02] (03CR) 10jerkins-bot: [V: 04-1] CologneBlue implemented with SkinMustache [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/606798 (https://phabricator.wikimedia.org/T248751) (owner: 10Jdlrobson) [17:46:38] (03CR) 10Isarra: "Or should this one be called... getDefaultFooter?!" [core] - 10https://gerrit.wikimedia.org/r/426840 (owner: 10Isarra) [17:48:17] 10VideoCutTool, 10CSS, 10good first task: Change some icons position to center (Top-down). - https://phabricator.wikimedia.org/T270403 (10Gopavasanth) [17:49:04] 10VideoCutTool, 10CSS, 10good first task: Change some icons position to center (Top-down). - https://phabricator.wikimedia.org/T270403 (10Gopavasanth) [17:49:21] (03Merged) 10jenkins-bot: Preparation for 3.2.1 release [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/649301 (owner: 10Daimona Eaytoy) [17:49:52] (03CR) 10Bartosz Dziewoński: [C: 04-1] "This causes the color dropdowns in the "Highlight results" mode to not appear (they end up underneath the menu). Removing this override lo" [core] - 10https://gerrit.wikimedia.org/r/649982 (https://phabricator.wikimedia.org/T270351) (owner: 10Isarra) [17:51:27] (03CR) 10Jforrester: "Tagged." [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/649301 (owner: 10Daimona Eaytoy) [17:51:58] 10MediaWiki-extensions-Graph, 10Product-Infrastructure-Team-Backlog, 10Wikimedia-production-error: Validate graph data or inputs and present feedback to the editor/reader rather than rely on production error logs - https://phabricator.wikimedia.org/T270404 (10Jseddon) [17:52:19] 10MediaWiki-extensions-Graph, 10Product-Infrastructure-Team-Backlog, 10Mobile, 10Wikimedia-production-error, 10covid-19: Uncaught TypeError: Cannot read property 'items' of null / TypeError: null is not an object (evaluating 'view.model().scene().items') - https://phabricator.wikimedia.org/T269308 (10Jse... [17:52:25] (03Merged) 10jenkins-bot: Fix mutation of properties in ZKey component [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/650143 (owner: 10Genoveva Galarza) [17:52:27] (03Merged) 10jenkins-bot: Remove event parameter from updateKey call [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/650147 (owner: 10Genoveva Galarza) [17:52:34] (03CR) 10Jforrester: "recheck" [tools/phan] - 10https://gerrit.wikimedia.org/r/649367 (owner: 10Daimona Eaytoy) [17:53:07] (03CR) 10jerkins-bot: [V: 04-1] Add new BaseTemplate::getFooterBlock function as replacement for getFooter for compatibility across all skins [core] - 10https://gerrit.wikimedia.org/r/426840 (owner: 10Isarra) [17:55:17] (03CR) 10Mholloway: [C: 04-1] "Looking over this now, just noting some initial things I've hit." (032 comments) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/650174 (https://phabricator.wikimedia.org/T270136) (owner: 10Ottomata) [17:56:20] 10Phabricator, 10User-zeljkofilipin: Phabricator does not send any e-mail notification when user is awarded a badge - https://phabricator.wikimedia.org/T270405 (10zeljkofilipin) [17:58:14] (03CR) 10Jforrester: "recheck" [tools/phan] - 10https://gerrit.wikimedia.org/r/649367 (owner: 10Daimona Eaytoy) [17:58:41] (03CR) 10Genoveva Galarza: "> Patch Set 2:" [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/650150 (owner: 10Genoveva Galarza) [17:59:26] 10DC-Ops: frdev1001 ILO inaccessible - https://phabricator.wikimedia.org/T267969 (10Jgreen) [17:59:46] 10Phabricator, 10User-zeljkofilipin: Phabricator does not send any e-mail notification when user is awarded a badge - https://phabricator.wikimedia.org/T270405 (10zeljkofilipin) @mmodell is enabling e-mail notifications easy, or hard? 😬 [17:59:54] 10Platform Team Workboards (Green): The data ingestion script should display progress information - https://phabricator.wikimedia.org/T270406 (10gmodena) [18:00:03] (03CR) 10Mholloway: [C: 04-1] Prepend an HTML warningbox if a schema has been disabled or migrated (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/650174 (https://phabricator.wikimedia.org/T270136) (owner: 10Ottomata) [18:01:09] 10Phabricator, 10User-zeljkofilipin: Phabricator does not send any e-mail notification when user is awarded a badge - https://phabricator.wikimedia.org/T270405 (10zeljkofilipin) [18:01:29] (03Abandoned) 10Jforrester: Fix eslint errors and warnings [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/650150 (owner: 10Genoveva Galarza) [18:02:03] (03CR) 10Jforrester: [C: 03+2] Bump taint-check and release 0.10.6 [tools/phan] - 10https://gerrit.wikimedia.org/r/649367 (owner: 10Daimona Eaytoy) [18:02:05] (03PS3) 10Gmodena: Fix ingestion on prod database. [services/similar-users] (main) - 10https://gerrit.wikimedia.org/r/650172 [18:03:07] (03Merged) 10jenkins-bot: Bump taint-check and release 0.10.6 [tools/phan] - 10https://gerrit.wikimedia.org/r/649367 (owner: 10Daimona Eaytoy) [18:03:16] (03CR) 10Ottomata: [C: 03+2] Add an utility class to validate an event against its schema (031 comment) [wikimedia-event-utilities] - 10https://gerrit.wikimedia.org/r/649896 (https://phabricator.wikimedia.org/T270371) (owner: 10DCausse) [18:03:42] (03CR) 10Ottomata: [C: 03+2] Add an utility class to validate an event against its schema (031 comment) [wikimedia-event-utilities] - 10https://gerrit.wikimedia.org/r/649896 (https://phabricator.wikimedia.org/T270371) (owner: 10DCausse) [18:03:44] (03CR) 10Ottomata: [V: 03+2 C: 03+2] Add an utility class to validate an event against its schema [wikimedia-event-utilities] - 10https://gerrit.wikimedia.org/r/649896 (https://phabricator.wikimedia.org/T270371) (owner: 10DCausse) [18:06:06] (03PS1) 10Umherirrender: Remove unused SpecialNotificationsMarkRead::$eventId [extensions/Echo] - 10https://gerrit.wikimedia.org/r/650208 [18:07:00] (03CR) 10Umherirrender: Add missing @var and improve documentation (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/649964 (owner: 10Umherirrender) [18:07:35] (03CR) 10Mholloway: [C: 04-1] "In the event that a schema is disabled or migrated but the Schema page hasn't yet been created, the warning will show anyway. Not sure if " [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/650174 (https://phabricator.wikimedia.org/T270136) (owner: 10Ottomata) [18:08:58] (03CR) 10Isarra: "> Patch Set 2: Code-Review-1" [core] - 10https://gerrit.wikimedia.org/r/649982 (https://phabricator.wikimedia.org/T270351) (owner: 10Isarra) [18:11:11] (03CR) 10Jforrester: "Tagged." [tools/phan] - 10https://gerrit.wikimedia.org/r/649367 (owner: 10Daimona Eaytoy) [18:14:09] 10Technical-blog-posts: Story idea for Blog: A blog post that covers the New Phab Tutorials - https://phabricator.wikimedia.org/T266358 (10srodlund) Working on it here: https://docs.google.com/document/d/1Xye3bqgLRN1bQAVSgRXNFi8IttPtOuA3uAgedE6E9JA/edit# [18:15:09] (03CR) 10Isarra: "Scratch that, I probably should not have been cross-comparing to monobook, as it appears the highlight results buttons don't really work t" [core] - 10https://gerrit.wikimedia.org/r/649982 (https://phabricator.wikimedia.org/T270351) (owner: 10Isarra) [18:15:13] (03CR) 10VolkerE: [C: 03+2] Remove suggestion link underline on hover and li bottom margin (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/650180 (https://phabricator.wikimedia.org/T270202) (owner: 10Nray) [18:15:27] (03PS31) 10Phuedx: Simplify menu code [skins/Vector] - 10https://gerrit.wikimedia.org/r/624909 (https://phabricator.wikimedia.org/T268157) (owner: 10Jdlrobson) [18:17:50] 10DiscussionTools, 10Editing Design, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: Add edit notice element to New Discussion Tool - https://phabricator.wikimedia.org/T269033 (10Esanders) We can search for overridden messages with global search tool: https://global-search.toolforge.org/?q=.&... [18:18:13] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.33x-R-Rosgulla): Explore vs Home A/B test - https://phabricator.wikimedia.org/T260332 (10SNowick_WMF) Looking at avg. session count and avg. session length between both groups shows no appreciable difference. Data for 30 day period: | |unique users| se... [18:18:22] (03PS3) 10Hnowlan: Make lang and project API arguments. [services/similar-users] (main) - 10https://gerrit.wikimedia.org/r/648298 [18:18:30] (03CR) 10Phuedx: "Sorry about the noise. PS28/29 updated the commit message based on an expected 72 character max-width." [skins/Vector] - 10https://gerrit.wikimedia.org/r/624909 (https://phabricator.wikimedia.org/T268157) (owner: 10Jdlrobson) [18:18:43] (03CR) 10BryanDavis: [C: 03+2] UI fixes for language selector [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650014 (owner: 10Srishakatux) [18:19:38] (03CR) 10Tchanders: [C: 03+1] "> It did fail on PS25... Causing an OOM..." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/649696 (https://phabricator.wikimedia.org/T270145) (owner: 10Paladox) [18:19:52] (03PS1) 10Arlolra: Sync up with Parsoid parserTests.txt [core] - 10https://gerrit.wikimedia.org/r/650211 [18:20:06] (03PS1) 10Jforrester: build: Upgrade mediawiki-phan-config from 0.10.5 to 0.10.6 [core] - 10https://gerrit.wikimedia.org/r/650212 [18:20:08] (03PS1) 10Jforrester: RELEASE-NOTES-1.36: Refresh list of updated libraries and alpha-sort [core] - 10https://gerrit.wikimedia.org/r/650213 [18:20:40] 10Library-Card-Platform, 10The-Wikipedia-Library (Kanban): Fix Oxford University Press Law proxy URLs - https://phabricator.wikimedia.org/T269743 (10jsn.sherman) iterating on staging. [18:21:03] (03CR) 10Mholloway: [C: 04-1] "I just checked codesearch, and the only other thing that relies on the JsonSchemaContent class is the JsonConfig extension (which supports" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/650174 (https://phabricator.wikimedia.org/T270136) (owner: 10Ottomata) [18:21:07] (03PS2) 10BryanDavis: Remove roundeness of buttons in the navbar [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650015 (owner: 10Srishakatux) [18:21:11] (03CR) 10BryanDavis: [C: 03+2] Remove roundeness of buttons in the navbar [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650015 (owner: 10Srishakatux) [18:22:34] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Yellow hornets of kindness and healing, 10Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (10AndyRussG) [18:23:13] 10UI-Standardization, 10MinervaNeue, 10MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), 10Readers-Web-Backlog (Kanbanana-FY-2020-21): Implement mediawiki.skin.variables for MinervaNeue - https://phabricator.wikimedia.org/T263270 (10Volker_E) [18:23:35] 10UI-Standardization, 10MinervaNeue, 10MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), 10Readers-Web-Backlog (Kanbanana-FY-2020-21): Implement mediawiki.skin.variables for MinervaNeue - https://phabricator.wikimedia.org/T263270 (10Volker_E) a:05Jdlrobson→03Volker_E [18:24:39] (03PS1) 10Gerrit maintenance bot: Add messages for Nias Wiktionary (niawiktionary) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/650216 (https://phabricator.wikimedia.org/T270409) [18:25:03] (03PS1) 10Gerrit maintenance bot: Add nia to languages [services/cxserver] - 10https://gerrit.wikimedia.org/r/650217 (https://phabricator.wikimedia.org/T270409) [18:25:33] (03PS1) 10Gerrit maintenance bot: Add messages for Nias Wikipedia (niawiki) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/650219 (https://phabricator.wikimedia.org/T270408) [18:25:42] (03Merged) 10jenkins-bot: UI fixes for language selector [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650014 (owner: 10Srishakatux) [18:25:48] (03PS1) 10Gerrit maintenance bot: Add nia to languages [services/cxserver] - 10https://gerrit.wikimedia.org/r/650220 (https://phabricator.wikimedia.org/T270408) [18:26:12] 10MediaWiki-Internationalization, 10Wikimedia-Language-setup: Prepare MessagesNia.php for Wikipedia and Wiktionary Nias - https://phabricator.wikimedia.org/T270418 (10MF-Warburg) [18:26:33] 10MediaWiki-Internationalization, 10Wikimedia-Language-setup: Prepare MessagesNia.php for Wikipedia and Wiktionary Nias - https://phabricator.wikimedia.org/T270418 (10MF-Warburg) [18:27:27] (03Merged) 10jenkins-bot: Remove roundeness of buttons in the navbar [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650015 (owner: 10Srishakatux) [18:27:48] (03PS1) 10Umherirrender: Use Maintenance::set/getBatchSize in maintenance scripts [extensions/Echo] - 10https://gerrit.wikimedia.org/r/650222 [18:28:10] (03PS2) 10Isarra: Add generic getNavigationBlock to BaseTemplate (getPortlet replacement) [core] - 10https://gerrit.wikimedia.org/r/426844 [18:29:54] (03CR) 10Ladsgroup: [C: 03+2] Add messages for Nias Wikipedia (niawiki) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/650219 (https://phabricator.wikimedia.org/T270408) (owner: 10Gerrit maintenance bot) [18:31:59] (03PS3) 10Umherirrender: Add missing @var and improve documentation [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/649960 [18:32:41] (03CR) 10Umherirrender: Add missing @var and improve documentation (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/649960 (owner: 10Umherirrender) [18:32:44] (03CR) 10Jforrester: [C: 03+2] Introduce ConsequencesExecutor [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/634648 (owner: 10Daimona Eaytoy) [18:34:45] (03CR) 10Jforrester: [C: 03+2] Create FilterRunnerFactory [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/643942 (owner: 10Daimona Eaytoy) [18:35:31] (03CR) 10Subramanya Sastry: [C: 03+2] Sync up with Parsoid parserTests.txt [core] - 10https://gerrit.wikimedia.org/r/650211 (owner: 10Arlolra) [18:37:35] (03CR) 10Paladox: Add test showing that getBlock can recurse if you use Autopromote and use APCOND_BLOCKED (031 comment) [core] - 10https://gerrit.wikimedia.org/r/649696 (https://phabricator.wikimedia.org/T270145) (owner: 10Paladox) [18:37:51] (03CR) 10DannyS712: [C: 03+2] Add missing @var and improve documentation [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/649960 (owner: 10Umherirrender) [18:38:44] (03CR) 10Daimona Eaytoy: "> Patch Set 1:" [tools/phan] - 10https://gerrit.wikimedia.org/r/649367 (owner: 10Daimona Eaytoy) [18:39:31] (03CR) 10VolkerE: [C: 03+2] [typeahead-search] Make footer suggestion background color on hover the same as other suggestions [wvui] - 10https://gerrit.wikimedia.org/r/650182 (https://phabricator.wikimedia.org/T270202) (owner: 10Nray) [18:40:58] (03Merged) 10jenkins-bot: Remove suggestion link underline on hover and li bottom margin [skins/Vector] - 10https://gerrit.wikimedia.org/r/650180 (https://phabricator.wikimedia.org/T270202) (owner: 10Nray) [18:41:47] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Yellow hornets of kindness and healing, 10Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (10AndyRussG) [18:43:52] (03CR) 10VolkerE: "This shouldn't be 'toc', but 'content.toc' following naming logic around." [core] - 10https://gerrit.wikimedia.org/r/647333 (https://phabricator.wikimedia.org/T269877) (owner: 10Jdlrobson) [18:44:37] (03PS1) 10Daimona Eaytoy: Remove MediaWikiIntegrationTestCase::assertType [core] - 10https://gerrit.wikimedia.org/r/650224 (https://phabricator.wikimedia.org/T192167) [18:45:22] (03Merged) 10jenkins-bot: [typeahead-search] Make footer suggestion background color on hover the same as other suggestions [wvui] - 10https://gerrit.wikimedia.org/r/650182 (https://phabricator.wikimedia.org/T270202) (owner: 10Nray) [18:45:46] (03CR) 10Daimona Eaytoy: [C: 03+2] build: Upgrade mediawiki-phan-config from 0.10.5 to 0.10.6 [core] - 10https://gerrit.wikimedia.org/r/650212 (owner: 10Jforrester) [18:46:55] 10MediaWiki-Core-Testing, 10Quality-and-Test-Engineering-Team (QTE), 10User-zeljkofilipin: Delete tests/selenium/selenium.sh - https://phabricator.wikimedia.org/T270419 (10zeljkofilipin) [18:47:08] 10UI-Standardization, 10Front-end-Standards-Group, 10Abstract Wikipedia (Phase γ): Create Wikimedia-wide Vue.js coding conventions - https://phabricator.wikimedia.org/T270329 (10Volker_E) Assuming that we will quite closely/mostly follow https://vuejs.org/v2/style-guide/ guidelines. [18:47:13] 10MediaWiki-Core-Testing, 10Quality-and-Test-Engineering-Team (QTE), 10User-zeljkofilipin: Delete tests/selenium/selenium.sh - https://phabricator.wikimedia.org/T270419 (10zeljkofilipin) p:05Triage→03Medium [18:47:28] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Yellow hornets of kindness and healing, 10Patch-For-Review: Code review and release management for CN campaign filtering - https://phabricator.wikimedia.org/T268646 (10AndyRussG) [18:48:27] (03PS32) 10Jforrester: [WIP] Complete the programatic definition of built-in types [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/627924 [18:48:55] 10MediaWiki-Core-Testing, 10Quality-and-Test-Engineering-Team (QTE), 10User-zeljkofilipin: Delete tests/selenium/selenium.sh - https://phabricator.wikimedia.org/T270419 (10zeljkofilipin) [18:52:20] (03PS1) 10Zfilipin: WIP Selenium: Delete tests/selenium/selenium.sh [core] - 10https://gerrit.wikimedia.org/r/650226 (https://phabricator.wikimedia.org/T270419) [18:53:05] (03PS1) 10Gmodena: Add progress status reporting. [services/similar-users] (main) - 10https://gerrit.wikimedia.org/r/650227 [18:53:34] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Complete the programatic definition of built-in types [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/627924 (owner: 10Jforrester) [18:53:46] (03CR) 10VolkerE: "Note to myself https://en.wikipedia.org/wiki/DWIM" [wvui] - 10https://gerrit.wikimedia.org/r/649991 (https://phabricator.wikimedia.org/T262566) (owner: 10Jdlrobson) [18:55:25] (03CR) 10jerkins-bot: [V: 04-1] Add generic getNavigationBlock to BaseTemplate (getPortlet replacement) [core] - 10https://gerrit.wikimedia.org/r/426844 (owner: 10Isarra) [18:56:44] (03CR) 10Tchanders: [C: 03+2] Add test showing that getBlock can recurse if you use Autopromote and use APCOND_BLOCKED [core] - 10https://gerrit.wikimedia.org/r/649696 (https://phabricator.wikimedia.org/T270145) (owner: 10Paladox) [18:56:54] (03CR) 10Tchanders: [C: 03+2] Fix infinite recursion with wgAutopromote when using getBlock within checkCondition [core] - 10https://gerrit.wikimedia.org/r/649910 (https://phabricator.wikimedia.org/T270145) (owner: 10Paladox) [18:57:21] (03CR) 10Tchanders: [C: 03+2] "Thanks for the fix Paladox" [core] - 10https://gerrit.wikimedia.org/r/649910 (https://phabricator.wikimedia.org/T270145) (owner: 10Paladox) [18:58:49] (03PS27) 10Bartosz Dziewoński: Ability to add new discussion sections [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/623117 (https://phabricator.wikimedia.org/T267595) [18:59:43] (03PS3) 10Bartosz Dziewoński: Show edit notices in the reply tool (and new discussion tool) [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/649944 (https://phabricator.wikimedia.org/T269033) [18:59:50] (03PS2) 10Bartosz Dziewoński: [WIP] Support launching new discussion tool from custom links, with 'preload' etc. [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/650007 (https://phabricator.wikimedia.org/T269310) [19:00:28] (03PS1) 10Umherirrender: Add missing @var and @param documentation [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/650228 [19:00:36] (03PS3) 10Bartosz Dziewoński: [WIP] Support launching new discussion tool from custom links, with 'preload' etc. [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/650007 (https://phabricator.wikimedia.org/T269310) [19:01:23] (03Merged) 10jenkins-bot: Add messages for Nias Wikipedia (niawiki) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/650219 (https://phabricator.wikimedia.org/T270408) (owner: 10Gerrit maintenance bot) [19:04:02] (03CR) 10Urbanecm: [C: 03+2] Article: view from old revision cache - set correct revId. [core] (wmf/1.36.0-wmf.22) - 10https://gerrit.wikimedia.org/r/649923 (https://phabricator.wikimedia.org/T270361) (owner: 10Ppchelko) [19:04:44] (03CR) 10Gmodena: [C: 03+1] Make lang and project API arguments. (031 comment) [services/similar-users] (main) - 10https://gerrit.wikimedia.org/r/648298 (owner: 10Hnowlan) [19:05:00] (03CR) 10Jdlrobson: "> Patch Set 17:" [core] - 10https://gerrit.wikimedia.org/r/647333 (https://phabricator.wikimedia.org/T269877) (owner: 10Jdlrobson) [19:05:27] (03PS2) 10Jdlrobson: "Do What I mean" support in wvui [wvui] - 10https://gerrit.wikimedia.org/r/649991 (https://phabricator.wikimedia.org/T262566) [19:05:43] (03CR) 10Gmodena: [C: 03+2] Add test coverage reporting. [services/similar-users] (main) - 10https://gerrit.wikimedia.org/r/649952 (owner: 10Gmodena) [19:06:45] (03Restored) 10Jdlrobson: Declare z-index of newly ordered DOM [skins/Vector] - 10https://gerrit.wikimedia.org/r/636736 (https://phabricator.wikimedia.org/T264379) (owner: 10Jdlrobson) [19:06:48] (03PS5) 10Srishakatux: User interface for audit logs [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/649816 (https://phabricator.wikimedia.org/T264968) [19:06:50] (03Merged) 10jenkins-bot: Introduce ConsequencesExecutor [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/634648 (owner: 10Daimona Eaytoy) [19:06:53] (03CR) 10jerkins-bot: [V: 04-1] Remove unused SpecialNotificationsMarkRead::$eventId [extensions/Echo] - 10https://gerrit.wikimedia.org/r/650208 (owner: 10Umherirrender) [19:06:54] 10MediaWiki-extensions-Graph, 10Product-Infrastructure-Team-Backlog, 10Mobile, 10Wikimedia-production-error, 10covid-19: Uncaught TypeError: Cannot read property 'items' of null / TypeError: null is not an object (evaluating 'view.model().scene().items') - https://phabricator.wikimedia.org/T269308 (10Jdl... [19:07:39] (03Merged) 10jenkins-bot: Add test coverage reporting. [services/similar-users] (main) - 10https://gerrit.wikimedia.org/r/649952 (owner: 10Gmodena) [19:07:41] (03PS1) 10BryanDavis: schema: Remove "tech" from wiki URL pattern [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650229 (https://phabricator.wikimedia.org/T269283) [19:07:43] (03PS1) 10Umherirrender: Add missing @var and improve documentation [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/650232 [19:07:45] (03PS1) 10BryanDavis: schema: Remove "wikimediafoundation" from wiki validation [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650230 [19:07:47] (03PS1) 10BryanDavis: api: Translate some wiki urls to names [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650231 (https://phabricator.wikimedia.org/T269283) [19:08:25] (03CR) 10Umherirrender: [C: 03+2] "Resubmit" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/650208 (owner: 10Umherirrender) [19:08:27] (03CR) 10Srishakatux: User interface for audit logs (031 comment) [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/649816 (https://phabricator.wikimedia.org/T264968) (owner: 10Srishakatux) [19:08:58] (03PS2) 10Jdlrobson: Declare z-index of newly ordered DOM [skins/Vector] - 10https://gerrit.wikimedia.org/r/636736 (https://phabricator.wikimedia.org/T264379) [19:09:11] (03CR) 10jerkins-bot: [V: 04-1] api: Translate some wiki urls to names [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650231 (https://phabricator.wikimedia.org/T269283) (owner: 10BryanDavis) [19:10:21] (03PS32) 10Jdlrobson: Simplify menu code [skins/Vector] - 10https://gerrit.wikimedia.org/r/624909 (https://phabricator.wikimedia.org/T268157) [19:10:48] 10MediaWiki-Codesniffer, 10User-DannyS712: Add sniff to disallow specific tags with no text after them - https://phabricator.wikimedia.org/T252914 (10DannyS712) 05Open→03Resolved [19:10:55] (03CR) 10jerkins-bot: [V: 04-1] "Do What I mean" support in wvui [wvui] - 10https://gerrit.wikimedia.org/r/649991 (https://phabricator.wikimedia.org/T262566) (owner: 10Jdlrobson) [19:11:06] (03PS26) 10Jdlrobson: CologneBlue implemented with SkinMustache [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/606798 (https://phabricator.wikimedia.org/T248751) [19:11:09] (03CR) 10Awight: Add new action and user fields (032 comments) [schemas/event/secondary] - 10https://gerrit.wikimedia.org/r/649599 (https://phabricator.wikimedia.org/T262209) (owner: 10Awight) [19:12:43] (03CR) 10Jdlrobson: Merge jquery.tipoff into ext.pageTriage.views.list (032 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/649915 (owner: 10DannyS712) [19:13:01] 10MediaWiki-Page-editing, 10MediaWiki-extensions-Translate, 10Epic: Make the Translate extension be based on DOM, not strings - https://phabricator.wikimedia.org/T143327 (10Esanders) [19:13:47] (03CR) 10jerkins-bot: [V: 04-1] schema: Remove "wikimediafoundation" from wiki validation [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650230 (owner: 10BryanDavis) [19:14:32] (03PS4) 10DannyS712: Merge jquery.tipoff into ext.pageTriage.views.list [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/649915 [19:14:35] (03CR) 10DannyS712: Merge jquery.tipoff into ext.pageTriage.views.list (032 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/649915 (owner: 10DannyS712) [19:14:57] (03PS3) 10Isarra: Prevent rcfilters menuselect widgets from winding up behind content on some skins [core] - 10https://gerrit.wikimedia.org/r/649982 (https://phabricator.wikimedia.org/T270351) [19:16:54] (03Merged) 10jenkins-bot: Create FilterRunnerFactory [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/643942 (owner: 10Daimona Eaytoy) [19:17:02] (03CR) 10Nray: [C: 03+1] Revert "vue: Log component errors" [core] (wmf/1.36.0-wmf.22) - 10https://gerrit.wikimedia.org/r/649924 (owner: 10Phuedx) [19:18:08] (03PS2) 10BryanDavis: schema: Remove "wikimediafoundation" from wiki validation [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650230 [19:18:10] (03PS2) 10BryanDavis: api: Translate some wiki urls to names [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650231 (https://phabricator.wikimedia.org/T269283) [19:18:49] (03PS4) 10Awight: Add new action and user fields [schemas/event/secondary] - 10https://gerrit.wikimedia.org/r/649599 (https://phabricator.wikimedia.org/T262209) [19:19:06] (03PS3) 10Isarra: Add generic getNavigationBlock to BaseTemplate (getPortlet replacement) [core] - 10https://gerrit.wikimedia.org/r/426844 [19:20:47] (03CR) 10Awight: Add new action and user fields (031 comment) [schemas/event/secondary] - 10https://gerrit.wikimedia.org/r/649599 (https://phabricator.wikimedia.org/T262209) (owner: 10Awight) [19:21:26] 10Wikimedia-Site-requests, 10Community-consensus-needed: Allow admins and importers to import on mrwikibooks and set sources for the same. - https://phabricator.wikimedia.org/T270402 (10Urbanecm) Let's wait for a week before proceeding with this one. [19:22:35] (03CR) 10Jdlrobson: [C: 03+2] Merge jquery.tipoff into ext.pageTriage.views.list [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/649915 (owner: 10DannyS712) [19:24:14] 10Wikimedia-Site-requests: Add User Groups to mrwikisource, enable admins to add/remove these groups. - https://phabricator.wikimedia.org/T269067 (10Urbanecm) Do you actually need all that groups? For small wikis like mrwikisource, it is //way better// if people just have the full admin pack. Note importer is q... [19:24:23] (03CR) 10Phuedx: [C: 03+1] "This looks good to me. Thanks for adding more detail to the commit message, Jdlrobson. I'll diff the output of some pages tomorrow." [skins/Vector] - 10https://gerrit.wikimedia.org/r/624909 (https://phabricator.wikimedia.org/T268157) (owner: 10Jdlrobson) [19:26:17] (03Merged) 10jenkins-bot: Sync up with Parsoid parserTests.txt [core] - 10https://gerrit.wikimedia.org/r/650211 (owner: 10Arlolra) [19:26:19] (03Merged) 10jenkins-bot: Add missing @var and improve documentation [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/649960 (owner: 10Umherirrender) [19:26:36] (03PS1) 10Umherirrender: Add missing @var and @param and improve documentation [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/650234 [19:27:39] (03Merged) 10jenkins-bot: build: Upgrade mediawiki-phan-config from 0.10.5 to 0.10.6 [core] - 10https://gerrit.wikimedia.org/r/650212 (owner: 10Jforrester) [19:27:55] (03PS1) 10Daimona Eaytoy: Add a plugin to whitelist issues in test context [tools/phan] - 10https://gerrit.wikimedia.org/r/650235 [19:29:14] (03PS1) 10Legoktm: build: Run phpunit as part of "composer test" [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/650236 [19:30:11] 10VideoCutTool: Newly generated video doesnt have timed text. - https://phabricator.wikimedia.org/T246148 (10Gopavasanth) Noting down here to extract the timed text using API: https://www.mediawiki.org/wiki/Extension:TimedMediaHandler/API [19:31:33] (03PS2) 10Daimona Eaytoy: Add a plugin to whitelist issues in test context [tools/phan] - 10https://gerrit.wikimedia.org/r/650235 [19:32:00] 10Wikilink-Tool, 10The-Wikipedia-Library (Kanban): LinkAggregate matching query does not exist. `DoesNotExist` error - https://phabricator.wikimedia.org/T270427 (10Scardenasmolinar) [19:32:13] (03CR) 10Daimona Eaytoy: [C: 04-2] "Per commit message" [tools/phan] - 10https://gerrit.wikimedia.org/r/650235 (owner: 10Daimona Eaytoy) [19:33:10] (03PS3) 10Daimona Eaytoy: Add a plugin to whitelist issues in test context [tools/phan] - 10https://gerrit.wikimedia.org/r/650235 [19:35:34] 10Developer-Advocacy, 10Epic, 10Google-Summer-of-Code (2021), 10Outreachy (Round 22): Coordinate Wikimedia's participation in Google Summer of Code 2021 and Outreachy Round 22 - https://phabricator.wikimedia.org/T270428 (10srishakatux) [19:35:40] (03PS1) 10Awight: Don't send user fields when not logged in [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/650237 (https://phabricator.wikimedia.org/T262209) [19:36:08] 10Desktop Improvements, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-FY-2020-21), 10Vue.js: Design fixes for new vue.js search experience - https://phabricator.wikimedia.org/T270202 (10Volker_E) [19:36:31] (03Merged) 10jenkins-bot: Article: view from old revision cache - set correct revId. [core] (wmf/1.36.0-wmf.22) - 10https://gerrit.wikimedia.org/r/649923 (https://phabricator.wikimedia.org/T270361) (owner: 10Ppchelko) [19:37:03] (03CR) 10Ppchelko: WIP: Authority interface experiment (032 comments) [core] - 10https://gerrit.wikimedia.org/r/620112 (owner: 10Daniel Kinzler) [19:38:27] 10MediaWiki-Page-history, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), 10Patch-For-Review, 10Platform Team Workboards (Green): "Edit" link on old revisions of a page links to the latest revision instead of the revision being viewed - https://phabricator.wikimedia.org/T270361 (10Pchelolo) 05Open→03Resolv... [19:39:46] (03CR) 10jerkins-bot: [V: 04-1] Don't send user fields when not logged in [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/650237 (https://phabricator.wikimedia.org/T262209) (owner: 10Awight) [19:39:57] 10Developer-Advocacy (Oct-Dec 2020), 10Epic, 10Google-Summer-of-Code (2021), 10Outreachy (Round 22): Recruit ideas for projects and mentors for Google Summer of Code 2021 and Outreachy Round 22 - https://phabricator.wikimedia.org/T270429 (10srishakatux) [19:42:04] (03CR) 10Jdlrobson: [C: 03+1] "Seems fine but I am not familiar with this codebase." [extensions/ORES] - 10https://gerrit.wikimedia.org/r/649914 (owner: 10DannyS712) [19:42:28] 10Product-Analytics (Kanban): Updated number of editors across all wikipedias and all projects per month - https://phabricator.wikimedia.org/T269625 (10SNowick_WMF) 2020 Monthly Wikipedia Pageviews: https://docs.google.com/spreadsheets/d/1g_oDXJbD4vpfEHWVBfG9PL9V0XjeN4fpW4AsvRKXicM/edit?usp=sharing Monthly Aver... [19:42:54] 10Timeless: Timeless does not render HTMLDateTimeField widget properly - https://phabricator.wikimedia.org/T270366 (10Isarra) 05Open→03Resolved a:03Isarra Confirmed; this was fixed the other day in https://gerrit.wikimedia.org/r/c/mediawiki/skins/Timeless/+/649110 which should actually be deployed in, uh..... [19:44:48] (03CR) 10jerkins-bot: [V: 04-1] Prevent rcfilters menuselect widgets from winding up behind content on some skins [core] - 10https://gerrit.wikimedia.org/r/649982 (https://phabricator.wikimedia.org/T270351) (owner: 10Isarra) [19:47:19] 10MediaWiki-Gerrit-Group-Requests, 10Gerrit: Update members of wmde-mediawiki Gerrit group - https://phabricator.wikimedia.org/T270383 (10Peachey88) [19:49:23] (03Merged) 10jenkins-bot: Add test showing that getBlock can recurse if you use Autopromote and use APCOND_BLOCKED [core] - 10https://gerrit.wikimedia.org/r/649696 (https://phabricator.wikimedia.org/T270145) (owner: 10Paladox) [19:49:28] (03CR) 10jerkins-bot: [V: 04-1] Fix infinite recursion with wgAutopromote when using getBlock within checkCondition [core] - 10https://gerrit.wikimedia.org/r/649910 (https://phabricator.wikimedia.org/T270145) (owner: 10Paladox) [19:50:31] 10WMF-Legal, 10Wikimedia-Site-requests, 10Community-consensus-needed: Allow local file uploads on Ukrainian Wikisource - https://phabricator.wikimedia.org/T262193 (10Arxivist) **1.** The specified decision as an example (of the monument to Lenin) is not a court dispute over copyright. I think this example is... [19:51:01] (03PS7) 10Mainframe98: Add a plugin to identify string to bool coercions in if statements [tools/phan] - 10https://gerrit.wikimedia.org/r/614025 (https://phabricator.wikimedia.org/T258227) [19:51:09] (03Merged) 10jenkins-bot: Remove unused SpecialNotificationsMarkRead::$eventId [extensions/Echo] - 10https://gerrit.wikimedia.org/r/650208 (owner: 10Umherirrender) [19:51:12] (03Merged) 10jenkins-bot: Merge jquery.tipoff into ext.pageTriage.views.list [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/649915 (owner: 10DannyS712) [19:52:01] (03CR) 10DannyS712: "This change is ready for review." [extensions/IPInfo] - 10https://gerrit.wikimedia.org/r/650190 (owner: 10DannyS712) [19:53:51] 10Desktop Improvements, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-FY-2020-21), 10Vue.js: Design fixes for new vue.js search experience - https://phabricator.wikimedia.org/T270202 (10nray) [19:54:25] 10MediaWiki-Gerrit-Group-Requests, 10Gerrit: Update members of wmde-mediawiki Gerrit group - https://phabricator.wikimedia.org/T270383 (10Legoktm) 05Open→03Resolved a:03Legoktm Done. [19:54:42] (03CR) 10jerkins-bot: [V: 04-1] Add missing @var and @param and improve documentation [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/650234 (owner: 10Umherirrender) [19:55:05] (03PS1) 10Umherirrender: Add missing @var and improve documentation [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/650240 [19:55:32] (03PS4) 10Jdlrobson: Avoid reflows when lazy loading images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/643543 (https://phabricator.wikimedia.org/T197188) [19:55:47] (03CR) 10Ottomata: "> It would be a bit cleaner to kick the warning generation stuff out to a dedicated private method, but I'll leave it up to you." (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/650174 (https://phabricator.wikimedia.org/T270136) (owner: 10Ottomata) [19:55:51] (03PS2) 10Umherirrender: Add missing @var and improve documentation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/649964 [19:56:06] (03CR) 10Umherirrender: "Rebased" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/649964 (owner: 10Umherirrender) [19:56:12] (03PS2) 10Awight: Don't send user fields when not logged in [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/650237 (https://phabricator.wikimedia.org/T262209) [19:56:49] 10Desktop Improvements, 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-FY-2020-21), 10Vue.js: Design fixes for new vue.js search experience - https://phabricator.wikimedia.org/T270202 (10Volker_E) [19:57:00] 10WMF-Legal, 10Wikimedia-Site-requests, 10Community-consensus-needed: Allow local file uploads on Ukrainian Wikisource - https://phabricator.wikimedia.org/T262193 (10Arxivist) >>! In T262193#6699571, @Arxivist wrote: > **1.** The specified decision as an example (of the monument to Lenin) is not a court disp... [19:57:05] (03PS2) 10Umherirrender: Add missing @var and @param and improve documentation [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/650234 [19:57:13] (03PS23) 10Paladox: Fix infinite recursion with wgAutopromote when using getBlock within checkCondition [core] - 10https://gerrit.wikimedia.org/r/649910 (https://phabricator.wikimedia.org/T270145) [19:58:45] (03PS3) 10Awight: Don't send user fields when not logged in [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/650237 (https://phabricator.wikimedia.org/T262209) [19:59:49] (03CR) 10Paladox: "test gate" [core] - 10https://gerrit.wikimedia.org/r/649910 (https://phabricator.wikimedia.org/T270145) (owner: 10Paladox) [19:59:59] (03CR) 10Paladox: "recheck gate" [core] - 10https://gerrit.wikimedia.org/r/649910 (https://phabricator.wikimedia.org/T270145) (owner: 10Paladox) [20:00:08] (03CR) 10Tchanders: [C: 03+2] Fix infinite recursion with wgAutopromote when using getBlock within checkCondition [core] - 10https://gerrit.wikimedia.org/r/649910 (https://phabricator.wikimedia.org/T270145) (owner: 10Paladox) [20:00:58] (03CR) 10jerkins-bot: [V: 04-1] Avoid reflows when lazy loading images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/643543 (https://phabricator.wikimedia.org/T197188) (owner: 10Jdlrobson) [20:02:48] 10MediaWiki-Codesniffer, 10phan, 10Patch-For-Review: Sniff or phan rule against use `?:` and `if` on returns that may be a string - https://phabricator.wikimedia.org/T258227 (10Mainframe98) >>! In T258227#6689092, @Daimona wrote: > Copying my comment from gerrit: > >> I am counting 346 issues for MW core,... [20:02:52] (03PS2) 10Nray: [typeahead-search] Make search button appear as part of input box [wvui] - 10https://gerrit.wikimedia.org/r/650183 (https://phabricator.wikimedia.org/T270202) [20:02:58] (03PS2) 10Ottomata: Prepend an HTML warningbox if a schema has been disabled or migrated [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/650174 (https://phabricator.wikimedia.org/T270136) [20:03:04] (03CR) 10Ottomata: Prepend an HTML warningbox if a schema has been disabled or migrated (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/650174 (https://phabricator.wikimedia.org/T270136) (owner: 10Ottomata) [20:03:41] (03CR) 10Mholloway: [C: 04-1] "> I'm not messing with JsonSchemaContent though, right? IIUC, the onBeforePageDisplay hook will be called anywhere the EventLogging exten" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/650174 (https://phabricator.wikimedia.org/T270136) (owner: 10Ottomata) [20:03:48] 10Developer-Advocacy (Oct-Dec 2020), 10Epic, 10Google-Summer-of-Code (2021), 10Outreachy (Round 22): Recruit ideas for projects and mentors for Google Summer of Code 2021 and Outreachy Round 22 - https://phabricator.wikimedia.org/T270429 (10srishakatux) [20:04:03] (03PS2) 10STran: Stop cloner add/delete functions from triggering unexpectedly [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/650017 (https://phabricator.wikimedia.org/T270200) [20:05:10] 10Developer-Advocacy (Oct-Dec 2020), 10Goal, 10Outreachy (Round 21): Design and plan Outreachy round 21 with a focus on data science and engineering projects - https://phabricator.wikimedia.org/T258524 (10srishakatux) [20:05:48] (03CR) 10Mholloway: Prepend an HTML warningbox if a schema has been disabled or migrated (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/650174 (https://phabricator.wikimedia.org/T270136) (owner: 10Ottomata) [20:06:02] 10Product-Analytics (Kanban): Updated number of editors across all wikipedias and all projects per month - https://phabricator.wikimedia.org/T269625 (10ASvitak) Thanks very much! I'll take a look at the spreadsheet now and follow up if we have additional questions. [20:07:04] 10MediaWiki-Blocks, 10Anti-Harassment, 10Product-Analytics (Kanban): Track improvements made to mobile block messages - https://phabricator.wikimedia.org/T264346 (10Niharika) 05Open→03Resolved We haven't seen the bug for missing data again. Closing this task for now. If we see this bug again, we should r... [20:07:11] (03PS1) 10Umherirrender: Add missing @param and improve documentation [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/650242 [20:07:13] (03PS3) 10Nray: [typeahead-search] Make search button appear as part of input box [wvui] - 10https://gerrit.wikimedia.org/r/650183 (https://phabricator.wikimedia.org/T270202) [20:11:32] 10WMF-Communications: Oversized Endowment logo on IE 11/Windows 8.1 - https://phabricator.wikimedia.org/T270340 (10jbolorinos-ctr) 05Open→03Resolved a:03jbolorinos-ctr Hey @Aklapper, This website was built by a vendor, and indeed they do not use phabricator for tracking this stuff. I simply reported it he... [20:11:49] 10MediaWiki-Codesniffer, 10phan, 10Patch-For-Review: Sniff or phan rule against use `?:` and `if` on returns that may be a string - https://phabricator.wikimedia.org/T258227 (10Daimona) >>! In T258227#6699590, @Mainframe98 wrote: > The original intention of the task has to do with preventing a check against... [20:12:31] (03PS21) 10Holger Knust: Add dumpWatchlist script to create partial SQL dump of watchlist table [core] - 10https://gerrit.wikimedia.org/r/623879 (https://phabricator.wikimedia.org/T51133) [20:13:48] 10MediaWiki-User-management, 10Epic, 10Platform Engineering Roadmap: Introduce ActorStore service - https://phabricator.wikimedia.org/T270430 (10daniel) [20:14:18] 10Bengali-Sites, 10Growth-Team (Current Sprint), 10MW-1.36-notes (1.36.0-wmf.25; 2021-01-05), 10Patch-For-Review: Deploy Growth experiments at Bangla Wikipedia - https://phabricator.wikimedia.org/T266020 (10Tgr) https://bn.wikipedia.beta.wmflabs.org/ is mostly set up (thanks @Urbanecm!) but suggested edits... [20:14:28] (03CR) 10Ottomata: Add new action and user fields (032 comments) [schemas/event/secondary] - 10https://gerrit.wikimedia.org/r/649599 (https://phabricator.wikimedia.org/T262209) (owner: 10Awight) [20:15:38] 10MediaWiki-General, 10MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), 10Patch-For-Review, 10Platform Engineering Roadmap, 10Platform Team Workboards (Initiatives): Complete WikiPage/Article split and deprecate Page interface - https://phabricator.wikimedia.org/T239975 (10daniel) [20:16:16] 10MediaWiki-Page-editing, 10MW-1.35-notes (1.35.0-wmf.40; 2020-07-07), 10Patch-For-Review, 10Platform Engineering Roadmap, and 3 others: EditPage.php needs rewrite: Separate DB and UI logic - https://phabricator.wikimedia.org/T20654 (10daniel) [20:16:41] 10MediaWiki-General, 10Epic, 10Platform Engineering Roadmap, 10Technical-Debt: Deprecate non-configuration globals - https://phabricator.wikimedia.org/T159283 (10daniel) [20:16:59] (03PS5) 10Jdlrobson: Avoid reflows when lazy loading images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/643543 (https://phabricator.wikimedia.org/T197188) [20:17:38] (03CR) 10Ottomata: "One more thought!" (031 comment) [schemas/event/secondary] - 10https://gerrit.wikimedia.org/r/649599 (https://phabricator.wikimedia.org/T262209) (owner: 10Awight) [20:17:40] (03CR) 10BryanDavis: [C: 03+2] schema: Remove "tech" from wiki URL pattern [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650229 (https://phabricator.wikimedia.org/T269283) (owner: 10BryanDavis) [20:17:46] (03CR) 10BryanDavis: [C: 03+2] schema: Remove "wikimediafoundation" from wiki validation [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650230 (owner: 10BryanDavis) [20:17:49] 10UploadWizard: UploadWizard FlickrChecker fails on Flickr 'favorites' pages - https://phabricator.wikimedia.org/T270432 (10agray) [20:18:13] (03CR) 10BryanDavis: [C: 03+2] api: Translate some wiki urls to names [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650231 (https://phabricator.wikimedia.org/T269283) (owner: 10BryanDavis) [20:18:27] (03CR) 10Ottomata: Add new action and user fields (031 comment) [schemas/event/secondary] - 10https://gerrit.wikimedia.org/r/649599 (https://phabricator.wikimedia.org/T262209) (owner: 10Awight) [20:18:34] 10UploadWizard: UploadWizard FlickrChecker fails on Flickr 'favorites' pages - https://phabricator.wikimedia.org/T270432 (10agray) [20:21:05] (03CR) 10jerkins-bot: [V: 04-1] Add missing @var and @param and improve documentation [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/650234 (owner: 10Umherirrender) [20:21:19] (03PS3) 10Ottomata: Prepend an HTML warningbox if a schema has been disabled or migrated [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/650174 (https://phabricator.wikimedia.org/T270136) [20:22:11] (03PS2) 10Gmodena: Add progress status reporting. [services/similar-users] (main) - 10https://gerrit.wikimedia.org/r/650227 [20:22:15] (03CR) 10jerkins-bot: [V: 04-1] Avoid reflows when lazy loading images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/643543 (https://phabricator.wikimedia.org/T197188) (owner: 10Jdlrobson) [20:22:21] (03CR) 10jerkins-bot: [V: 04-1] Add progress status reporting. [services/similar-users] (main) - 10https://gerrit.wikimedia.org/r/650227 (owner: 10Gmodena) [20:23:19] (03Merged) 10jenkins-bot: schema: Remove "tech" from wiki URL pattern [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650229 (https://phabricator.wikimedia.org/T269283) (owner: 10BryanDavis) [20:23:21] (03Merged) 10jenkins-bot: schema: Remove "wikimediafoundation" from wiki validation [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650230 (owner: 10BryanDavis) [20:23:23] (03Merged) 10jenkins-bot: api: Translate some wiki urls to names [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650231 (https://phabricator.wikimedia.org/T269283) (owner: 10BryanDavis) [20:24:26] (03PS6) 10BryanDavis: User interface for audit logs [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/649816 (https://phabricator.wikimedia.org/T264968) (owner: 10Srishakatux) [20:26:00] (03PS4) 10Gmodena: Fix ingestion on prod database. [services/similar-users] (main) - 10https://gerrit.wikimedia.org/r/650172 [20:26:02] (03PS3) 10Gmodena: Add progress status reporting. [services/similar-users] (main) - 10https://gerrit.wikimedia.org/r/650227 [20:26:26] 10Accessibility, 10Wikipedia-iOS-App-Backlog, 10iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower: Investigate: can reproduce voice over problem on iOS 14? - https://phabricator.wikimedia.org/T269641 (10MattCleinman) a:05ABorbaWMF→03Dmantena [20:26:47] 10Accessibility, 10Wikipedia-iOS-App-Backlog, 10iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower: Investigate: can reproduce voice over problem on iOS 14? - https://phabricator.wikimedia.org/T269641 (10MattCleinman) Per meeting today, @Dmantena to follow up w/ user. [20:26:56] 10iOS-app-Bugs: Appearance panel in sepia is white instead of themed - https://phabricator.wikimedia.org/T222390 (10cmadeo) [20:27:31] (03PS1) 10Awight: [WIP] Migrate to ResourceLoader packageFiles [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/650244 [20:27:35] (03CR) 10Mholloway: "> What about my choice of HTML css and style elements? Not sure if I did the right thing there, I just poked around and guessed." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/650174 (https://phabricator.wikimedia.org/T270136) (owner: 10Ottomata) [20:30:28] (03Merged) 10jenkins-bot: Fix infinite recursion with wgAutopromote when using getBlock within checkCondition [core] - 10https://gerrit.wikimedia.org/r/649910 (https://phabricator.wikimedia.org/T270145) (owner: 10Paladox) [20:30:38] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Migrate to ResourceLoader packageFiles [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/650244 (owner: 10Awight) [20:31:02] 10WMCH-Infrastructure: Migrate Wikimini into WMCH infrastructure - https://phabricator.wikimedia.org/T268292 (10valerio.bozzolan) I've migrated everything with this dummy script: {P13597} With this script I'm able to import everything on the fly. Then I've deployed some versioned configurations: ` cd /etc/ap... [20:31:53] 10MediaWiki-Docker, 10Operations, 10Traffic, 10serviceops, 10User-zeljkofilipin: docker pull from docker-registry fails with `ERROR: missing or empty Content-Length header` - https://phabricator.wikimedia.org/T270270 (10ema) The current theory is that the problem boils down to the following HEAD request... [20:32:10] (03PS1) 10Paladox: Add test showing that getBlock can recurse if you use Autopromote and use APCOND_BLOCKED [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650245 (https://phabricator.wikimedia.org/T270145) [20:32:12] (03PS1) 10Paladox: Fix infinite recursion with wgAutopromote when using getBlock within checkCondition [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650246 (https://phabricator.wikimedia.org/T270145) [20:32:40] (03PS1) 10Milan Ludma: mlu gerrit test [sandbox] - 10https://gerrit.wikimedia.org/r/650247 [20:32:42] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [sandbox] - 10https://gerrit.wikimedia.org/r/650247 (owner: 10Milan Ludma) [20:34:12] (03CR) 10Awight: Add new action and user fields (033 comments) [schemas/event/secondary] - 10https://gerrit.wikimedia.org/r/649599 (https://phabricator.wikimedia.org/T262209) (owner: 10Awight) [20:34:31] (03CR) 10Mholloway: "I think if you move the new enum value to the end of the list, it'll make CI happy." [schemas/event/secondary] - 10https://gerrit.wikimedia.org/r/650031 (https://phabricator.wikimedia.org/T270309) (owner: 10Gergő Tisza) [20:35:09] (03CR) 10Jforrester: "check experimental" [wikipeg] - 10https://gerrit.wikimedia.org/r/649967 (https://phabricator.wikimedia.org/T269720) (owner: 10Legoktm) [20:35:21] (03CR) 10Jforrester: [C: 03+2] build: Run phpunit as part of "composer test" [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/650236 (owner: 10Legoktm) [20:35:29] (03PS1) 10Umherirrender: Add missing @var and improve documentation [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/650249 [20:36:36] (03CR) 10Jforrester: [C: 03+1] "Oh hah, this is a partial dupe of Id5a8fa425dc." [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/650236 (owner: 10Legoktm) [20:36:42] (03PS5) 10Awight: Add new action and user fields [schemas/event/secondary] - 10https://gerrit.wikimedia.org/r/649599 (https://phabricator.wikimedia.org/T262209) [20:39:25] (03PS1) 10Isarra: Use transparent svg checker image on filepages and lose the background colour [core] - 10https://gerrit.wikimedia.org/r/650251 [20:39:42] (03CR) 10Awight: [C: 04-1] "This became incompatible with the 1.1.0 schema, we need to introduce the "performer" property. Should be squashed with the next patch." [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/649600 (https://phabricator.wikimedia.org/T262209) (owner: 10Awight) [20:41:59] 10UploadWizard: UploadWizard FlickrChecker fails on Flickr 'favorites' pages - https://phabricator.wikimedia.org/T270432 (10agray) Looking into this a bit more, it seems to be down to a bug on line 79 of mw.FlickrChecker.js. This currently has: userFavoritesMatches = flickrInputUrl.match( /flickr\.com\/(?:x\... [20:44:03] (03CR) 10Jforrester: "Seems to work — passes CI, at least. Shall we merge?" [wikipeg] - 10https://gerrit.wikimedia.org/r/649967 (https://phabricator.wikimedia.org/T269720) (owner: 10Legoktm) [20:44:33] (03CR) 10jerkins-bot: [V: 04-1] Prepend an HTML warningbox if a schema has been disabled or migrated [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/650174 (https://phabricator.wikimedia.org/T270136) (owner: 10Ottomata) [20:44:58] James_F: I wanted to configure php lint first, let me do that now [20:45:20] (03PS4) 10Awight: New event semantics for performer fields [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/650237 (https://phabricator.wikimedia.org/T262209) [20:45:44] (03Abandoned) 10Awight: Update event schema [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/649600 (https://phabricator.wikimedia.org/T262209) (owner: 10Awight) [20:46:30] 10CommRel-Specialists-Support: Tech News directly using Mass Message - https://phabricator.wikimedia.org/T270435 (10Rileych) [20:46:59] (03PS1) 10Umherirrender: Fix doc about IDatabase [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/650254 [20:51:17] (03PS3) 10Jforrester: Allow installing on PHP 8.0 [wikipeg] - 10https://gerrit.wikimedia.org/r/649967 (https://phabricator.wikimedia.org/T269720) (owner: 10Legoktm) [20:51:22] (03PS2) 10Isarra: Use transparent svg checker image on filepages and lose the background colour [core] - 10https://gerrit.wikimedia.org/r/650251 [20:51:24] (03CR) 10Jforrester: [C: 03+1] Allow installing on PHP 8.0 [wikipeg] - 10https://gerrit.wikimedia.org/r/649967 (https://phabricator.wikimedia.org/T269720) (owner: 10Legoktm) [20:51:59] 10DiscussionTools, 10Editing Design, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: Add support for preloaded text - https://phabricator.wikimedia.org/T269310 (10matmarex) >>! In T269310#6697554, @ppelberg wrote: >> * I think we should only enable this on pages that "opt-in" somehow, at least... [20:52:16] (03PS4) 10Legoktm: Allow installing on PHP 8.0 [wikipeg] - 10https://gerrit.wikimedia.org/r/649967 (https://phabricator.wikimedia.org/T269720) [20:52:25] legoktm: Ack. [20:53:28] James_F: I think we should also run the composer-package-* tests like OOUI, because that verifies it works as a standalone composer package and can be published to packagist (metadata, etc.) [20:53:33] (03PS1) 10Umherirrender: Add missing @var and improve documentation [extensions/Math] - 10https://gerrit.wikimedia.org/r/650255 [20:53:44] legoktm: WFM. Give me a sec. [20:53:50] (03CR) 10Bartosz Dziewoński: "Test failure (ParserOutputAccessTest::testOldRevisionCacheSplit) looks unrelated." [core] - 10https://gerrit.wikimedia.org/r/649982 (https://phabricator.wikimedia.org/T270351) (owner: 10Isarra) [20:54:30] also https://integration.wikimedia.org/ci/job/wikipeg-special-node10-plus-php80-composer-docker/3/console doesn't seem to run composer test, it runs the other thing (which is good too!) [20:55:01] Yeah, it uses the npm entry point which runs that set of stuff. [20:55:11] The composer entry point was never run before, because it didn't exist. [20:56:18] 10WoOgLeShades: Ensure proper distinctions between links of various types and states - https://phabricator.wikimedia.org/T270436 (10Isarra) [20:56:20] 10WoOgLeShades: Ensure proper distinctions between links of various types and states - https://phabricator.wikimedia.org/T270436 (10Isarra) [20:56:34] (03PS3) 10Umherirrender: Add missing @var and @param and improve documentation [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/650234 [20:59:18] (03CR) 10Bartosz Dziewoński: [C: 03+1] "This looks good, but I want to click on every button in the interface to test it before I do, since the entire thing feels very fiddly." [core] - 10https://gerrit.wikimedia.org/r/649982 (https://phabricator.wikimedia.org/T270351) (owner: 10Isarra) [20:59:44] 10MediaWiki-Docker: Cannot access the database: Unknown error (localhost) after installing Mediawiki-Docker - https://phabricator.wikimedia.org/T270437 (10Yash4357) [21:00:35] legoktm: Deployed. [21:00:55] (03CR) 10Jforrester: "recheck" [wikipeg] - 10https://gerrit.wikimedia.org/r/649967 (https://phabricator.wikimedia.org/T269720) (owner: 10Legoktm) [21:01:01] (03PS1) 10Gmodena: Reformat endpoint documentation. [services/similar-users] (main) - 10https://gerrit.wikimedia.org/r/650258 [21:05:21] (03CR) 10Jforrester: "recheck" [wikipeg] - 10https://gerrit.wikimedia.org/r/649967 (https://phabricator.wikimedia.org/T269720) (owner: 10Legoktm) [21:08:06] James_F: ty, lgtm! [21:08:25] (03CR) 10Jforrester: [C: 03+2] Allow installing on PHP 8.0 [wikipeg] - 10https://gerrit.wikimedia.org/r/649967 (https://phabricator.wikimedia.org/T269720) (owner: 10Legoktm) [21:08:51] legoktm: Next up, tagging a release and getting it into Parsoid? [21:09:05] 10MediaWiki-Docker, 10Operations, 10Traffic, 10serviceops, and 2 others: docker pull from docker-registry fails with `ERROR: missing or empty Content-Length header` - https://phabricator.wikimedia.org/T270270 (10ema) >>! In T270270#6699691, @ema wrote: > That being said, I suspect that our VCL trying to do... [21:09:23] 10MediaWiki-Docker: Cannot access the database: Unknown error (localhost) after installing Mediawiki-Docker - https://phabricator.wikimedia.org/T270437 (10kostajh) @Yash4357 most likely permissions issues on the SQLite database. Can you copy/paste your `.env` and `docker-compose.override.yml` files here please? [21:09:36] (03PS1) 10Legoktm: Release 2.0.5 [wikipeg] - 10https://gerrit.wikimedia.org/r/650260 [21:09:38] (03Merged) 10jenkins-bot: Allow installing on PHP 8.0 [wikipeg] - 10https://gerrit.wikimedia.org/r/649967 (https://phabricator.wikimedia.org/T269720) (owner: 10Legoktm) [21:09:45] (03CR) 10jerkins-bot: [V: 04-1] Release 2.0.5 [wikipeg] - 10https://gerrit.wikimedia.org/r/650260 (owner: 10Legoktm) [21:09:57] 10Wikisource Export, 10Community-Tech (Kanban-2020-21-Q2): Wikisource Export: Investigate mockup ideas related to improved UX [8HR] - https://phabricator.wikimedia.org/T266262 (10HMonroy) - Investigate if & how we can implement the general idea shared by the auto-download example -- Investigate if and how... [21:10:24] legoktm: 2.0.5 not 2.0.4? [21:10:32] 10MediaWiki-Docker, 10Operations, 10Traffic, 10serviceops, and 2 others: docker pull from docker-registry fails with `ERROR: missing or empty Content-Length header` - https://phabricator.wikimedia.org/T270270 (10kostajh) >>! In T270270#6699794, @ema wrote: >>>! In T270270#6699761, @gerritbot wrote: >> Chan... [21:10:47] there's already a 2.0.4 tag, just package.json wasn't updated [21:11:02] Ah. [21:11:26] (03PS2) 10Legoktm: Release 2.0.5 [wikipeg] - 10https://gerrit.wikimedia.org/r/650260 [21:12:13] (03PS3) 10Jforrester: Release wikipeg 2.0.5 [wikipeg] - 10https://gerrit.wikimedia.org/r/650260 (owner: 10Legoktm) [21:12:23] (03CR) 10Jforrester: [C: 03+2] Release wikipeg 2.0.5 [wikipeg] - 10https://gerrit.wikimedia.org/r/650260 (owner: 10Legoktm) [21:12:53] ty :D [21:13:04] (03CR) 10Bartosz Dziewoński: "I want to split off the newsectionlink change to a separate patch, I think it deserves to be called out, since it changes the behavior sli" [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/649905 (owner: 10Esanders) [21:13:41] (03Merged) 10jenkins-bot: Release wikipeg 2.0.5 [wikipeg] - 10https://gerrit.wikimedia.org/r/650260 (owner: 10Legoktm) [21:14:00] (03PS2) 10Jforrester: chore: remove dead code and update .gitignore [wikipeg] - 10https://gerrit.wikimedia.org/r/516455 (owner: 10Dan1wang) [21:14:23] (03CR) 10Jforrester: [C: 03+1] "PS2: Manual rebase." [wikipeg] - 10https://gerrit.wikimedia.org/r/516455 (owner: 10Dan1wang) [21:15:27] 10MediaWiki-Docker: Cannot access the database: Unknown error (localhost) after installing Mediawiki-Docker - https://phabricator.wikimedia.org/T270437 (10Yash4357) **.env**: MW_DOCKER_PORT=8080 MW_SCRIPT_PATH=/w MW_SERVER=http://localhost:8080 MEDIAWIKI_USER=Admin MEDIAWIKI_PASSWORD=dockerpass XDEBUG_CONFIG=''... [21:16:29] 10MediaWiki-Docker, 10Operations, 10Traffic, 10serviceops, and 2 others: docker pull from docker-registry fails with `ERROR: missing or empty Content-Length header` - https://phabricator.wikimedia.org/T270270 (10ema) >>! In T270270#6699806, @gerritbot wrote: > Change 650191 had a related patch set uploaded... [21:16:39] James_F: pushed the tag, gonna grab food now, I'll send a patch to update parsoid if you haven't done it by the time I'm back :) [21:16:54] legoktm: I'm looking at the old patches in the wikipeg repo for now. :-) [21:17:04] (03PS3) 10Bartosz Dziewoński: Separate out isAvailableForTitleAndUser from isAvailable [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/649905 (owner: 10Esanders) [21:17:06] (03PS1) 10Bartosz Dziewoński: Use PageProps for fetching newsectionlink flag [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/650261 [21:17:21] (03CR) 10Bartosz Dziewoński: "Split off from https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/649905" [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/650261 (owner: 10Bartosz Dziewoński) [21:17:24] (03PS2) 10Bartosz Dziewoński: Use PageProps for fetching newsectionlink flag [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/650261 [21:17:29] (03CR) 10Bartosz Dziewoński: [C: 03+2] Use PageProps for fetching newsectionlink flag [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/650261 (owner: 10Bartosz Dziewoński) [21:17:45] (03PS4) 10Bartosz Dziewoński: Separate out isAvailableForTitleAndUser from isAvailable [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/649905 (owner: 10Esanders) [21:17:51] (03CR) 10Bartosz Dziewoński: [C: 03+2] Separate out isAvailableForTitleAndUser from isAvailable [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/649905 (owner: 10Esanders) [21:17:58] (03PS3) 10Bartosz Dziewoński: Make Hooks::$tags a constant [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/649926 (owner: 10Esanders) [21:18:01] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.33x-R-Rosgulla): Analytics for adding image tags from Commons filepage - https://phabricator.wikimedia.org/T258081 (10SNowick_WMF) 05Open→03Resolved [21:18:03] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.32x-Q-Qurabiya): Support adding image tags from Commons filepage - https://phabricator.wikimedia.org/T254142 (10SNowick_WMF) [21:20:04] 10MediaWiki-General, 10Anti-Harassment, 10Cloud-VPS, 10Performance-Team, and 4 others: MediaWiki::outputResponsePayload seemingly causes net::ERR_HTTP2_PROTOCOL_ERROR 200 and compression issues in 1.35 - https://phabricator.wikimedia.org/T235554 (10Porplemontage) I had a user who couldn't access a MediaWik... [21:20:26] (03PS6) 10Jdlrobson: Avoid reflows when lazy loading images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/643543 (https://phabricator.wikimedia.org/T197188) [21:22:18] (03CR) 10Daniel Kinzler: WIP: Authority interface experiment (031 comment) [core] - 10https://gerrit.wikimedia.org/r/620112 (owner: 10Daniel Kinzler) [21:23:01] 10MediaWiki-Docker: Cannot access the database: Unknown error (localhost) after installing Mediawiki-Docker - https://phabricator.wikimedia.org/T270437 (10kostajh) Thanks. So, no docker-compose.override.yml file, is that right? And what version of Docker for Windows are you using? [21:23:07] 10DiscussionTools, 10OWC2020, 10Editing-team (FY2020-21 Kanban Board): Inform candidate wikis of A/B test - https://phabricator.wikimedia.org/T267382 (10ppelberg) [21:23:35] (03Merged) 10jenkins-bot: Use PageProps for fetching newsectionlink flag [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/650261 (owner: 10Bartosz Dziewoński) [21:23:52] (03Merged) 10jenkins-bot: Separate out isAvailableForTitleAndUser from isAvailable [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/649905 (owner: 10Esanders) [21:25:37] (03CR) 10jerkins-bot: [V: 04-1] Avoid reflows when lazy loading images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/643543 (https://phabricator.wikimedia.org/T197188) (owner: 10Jdlrobson) [21:25:42] 10MediaWiki-Docker: Cannot access the database: Unknown error (localhost) after installing Mediawiki-Docker - https://phabricator.wikimedia.org/T270437 (10Yash4357) Yes, there is no docker-compose.override.yml file, And I am using docker version:19.03.13 [21:26:32] 10DiscussionTools, 10Editing-team (Tracking), 10OWC2020 (New Discussion 1.0): Identify New Discussion Tool "partner wikis" - https://phabricator.wikimedia.org/T265953 (10ppelberg) 05Open→03Resolved a:03ppelberg >>! In T265953#6575718, @ppelberg wrote: > **Next steps** > - [x] @Whatamidoing-WMF: share t... [21:26:34] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10OWC2020 (New Discussion 1.0): [Epic] Affordance: Start a new discussion - https://phabricator.wikimedia.org/T233446 (10ppelberg) [21:26:46] (03PS2) 10Jforrester: a-b benchmark tests [wikipeg] - 10https://gerrit.wikimedia.org/r/516457 (owner: 10Dan1wang) [21:27:22] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I think the buttons should go under the warning text, so "flex-wrap: wrap;" instead of "flex-wrap: wrap-reverse;". The interface in this p" [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/649885 (https://phabricator.wikimedia.org/T259320) (owner: 10Esanders) [21:27:30] (03CR) 10jerkins-bot: [V: 04-1] a-b benchmark tests [wikipeg] - 10https://gerrit.wikimedia.org/r/516457 (owner: 10Dan1wang) [21:27:33] 10MediaWiki-Docker: Cannot access the database: Unknown error (localhost) after installing Mediawiki-Docker - https://phabricator.wikimedia.org/T270437 (10kostajh) How did you install Docker? Can you check the file permissions on the `cache` directory and make sure it's readable by your user? [21:27:35] 10DiscussionTools, 10Editing-team (Tracking), 10OWC2020 (New Discussion 1.0): Identify New Discussion Tool "partner wikis" - https://phabricator.wikimedia.org/T265953 (10ppelberg) [21:27:47] (03PS7) 10BryanDavis: User interface for audit logs [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/649816 (https://phabricator.wikimedia.org/T264968) (owner: 10Srishakatux) [21:27:49] (03PS1) 10BryanDavis: api: Add "label" attribute to auditlog targets [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650263 (https://phabricator.wikimedia.org/T270358) [21:27:51] (03CR) 10Jforrester: "PS2: Manually rebased." [wikipeg] - 10https://gerrit.wikimedia.org/r/516457 (owner: 10Dan1wang) [21:28:17] (03PS3) 10Jforrester: WikiPEG character class optimization [wikipeg] - 10https://gerrit.wikimedia.org/r/510070 (https://phabricator.wikimedia.org/T222964) (owner: 10Dan1wang) [21:30:29] (03PS6) 10Jforrester: @ ("picked") operator [wikipeg] - 10https://gerrit.wikimedia.org/r/511637 (https://phabricator.wikimedia.org/T223957) (owner: 10Dan1wang) [21:30:41] (03CR) 10Holger Knust: Add dumpWatchlist script to create partial SQL dump of watchlist table (032 comments) [core] - 10https://gerrit.wikimedia.org/r/623879 (https://phabricator.wikimedia.org/T51133) (owner: 10Holger Knust) [21:30:43] (03PS1) 10Isarra: Fix box shadows for safari, and other small CSS changes [skins/WoOgLeShades] - 10https://gerrit.wikimedia.org/r/650264 (https://phabricator.wikimedia.org/T259289) [21:31:27] (03CR) 10jerkins-bot: [V: 04-1] @ ("picked") operator [wikipeg] - 10https://gerrit.wikimedia.org/r/511637 (https://phabricator.wikimedia.org/T223957) (owner: 10Dan1wang) [21:33:11] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), 10Verified: [betalabs] Uncaught TypeError: Cannot read property 'nextSibling' of null - when Reply to WikiLove - https://phabricator.wikimedia.org/T266288 (10Ryasmeen) [21:34:07] 10MediaWiki-Docker: Cannot access the database: Unknown error (localhost) after installing Mediawiki-Docker - https://phabricator.wikimedia.org/T270437 (10Yash4357) Do I have to check cache directory of mediawiki? [21:34:33] (03CR) 10BryanDavis: [C: 03+2] api: Add "label" attribute to auditlog targets [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650263 (https://phabricator.wikimedia.org/T270358) (owner: 10BryanDavis) [21:35:16] 10MediaWiki-REST-API, 10VisualEditor, 10Editing-team (Tracking), 10MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), and 2 others: Implement /revision/{id}/html endpoint in core - https://phabricator.wikimedia.org/T267981 (10Pchelolo) 05Open→03Resolved [21:35:28] (03PS2) 10Isarra: Fix box shadows for safari, and other small CSS changes [skins/WoOgLeShades] - 10https://gerrit.wikimedia.org/r/650264 (https://phabricator.wikimedia.org/T259289) [21:35:30] 10MediaWiki-REST-API, 10VisualEditor, 10Editing-team (Tracking), 10MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), and 2 others: Implement /revision/{id}/html endpoint in core - https://phabricator.wikimedia.org/T267981 (10Pchelolo) 05Resolved→03Open [21:35:52] 10MediaWiki-Docker: Cannot access the database: Unknown error (localhost) after installing Mediawiki-Docker - https://phabricator.wikimedia.org/T270437 (10Yash4357) I have install docker-desktop [21:36:01] 10MediaWiki-Parser, 10MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), 10Platform Team Workboards (Green): ParserCache should use CachedBagOStuff - https://phabricator.wikimedia.org/T269593 (10Pchelolo) 05Open→03Resolved [21:36:44] (03CR) 10BryanDavis: [C: 03+2] User interface for audit logs (031 comment) [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/649816 (https://phabricator.wikimedia.org/T264968) (owner: 10Srishakatux) [21:38:41] (03CR) 10MGerlach: "almost done. 2 more changes to wiki_id and a question." (033 comments) [research/mwaddlink] (main) - 10https://gerrit.wikimedia.org/r/649450 (owner: 10Kosta Harlan) [21:39:24] (03Merged) 10jenkins-bot: api: Add "label" attribute to auditlog targets [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650263 (https://phabricator.wikimedia.org/T270358) (owner: 10BryanDavis) [21:40:15] 10MediaWiki-Vendor, 10WikiPEG, 10MW-1.35-release, 10PHP 8.0 support: Include version of WikiPEG that supports PHP 8.0 into Parsoid in REL1_35 - https://phabricator.wikimedia.org/T269719 (10Jdforrester-WMF) [21:40:36] 10WikiPEG, 10PHP 8.0 support, 10Patch-For-Review: Add PHP 8.0 support to WikiPEG - https://phabricator.wikimedia.org/T269720 (10Jdforrester-WMF) 05Open→03Resolved a:03Legoktm [21:41:25] (03Merged) 10jenkins-bot: User interface for audit logs [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/649816 (https://phabricator.wikimedia.org/T264968) (owner: 10Srishakatux) [21:45:32] (03PS1) 10Umherirrender: Add missing @var and improve documentation [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/650267 [21:48:02] 10Toolhub, 10Developer-Advocacy (Oct-Dec 2020), 10Patch-For-Review: User interface for viewing actions taken on Toolhub - https://phabricator.wikimedia.org/T264968 (10srishakatux) 05Open→03Resolved [21:48:20] 10Small-Wiki-Toolkits, 10Developer-Advocacy (Oct-Dec 2020), 10Goal: Initiate relationship building with communities to assess feasibility of conducting new technical programs - https://phabricator.wikimedia.org/T264972 (10srishakatux) 05Open→03Resolved [21:50:57] (03PS7) 10Jdlrobson: Avoid reflows when lazy loading images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/643543 (https://phabricator.wikimedia.org/T197188) [21:51:16] 10Developer-Advocacy, 10Small-Wiki-Toolkits: Experimental idea: technical certification program for small wiki contributors - https://phabricator.wikimedia.org/T261035 (10srishakatux) 05Open→03Stalled (doesn't seem like this will happen any time soon, it depends on the workshops planned and whether or not... [21:52:54] (03CR) 10Ottomata: "That is very helpful, thank you!" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/650174 (https://phabricator.wikimedia.org/T270136) (owner: 10Ottomata) [21:53:33] (03CR) 10MGerlach: [C: 03+2] "> Patch Set 4:" (031 comment) [research/mwaddlink] (main) - 10https://gerrit.wikimedia.org/r/649452 (https://phabricator.wikimedia.org/T266826) (owner: 10Kosta Harlan) [21:53:58] (03PS4) 10Ottomata: Prepend an HTML warningbox if a schema has been disabled or migrated [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/650174 (https://phabricator.wikimedia.org/T270136) [21:56:31] (03CR) 10Umherirrender: "Should respect $wgUnwatchedPageThreshold if set" [core] - 10https://gerrit.wikimedia.org/r/623879 (https://phabricator.wikimedia.org/T51133) (owner: 10Holger Knust) [21:58:53] 10Accessibility, 10DiscussionTools, 10Editing QA, 10Growth-Team, and 5 others: User can't tab out VisualEditor surfaces, e.g. comment input widgets, media dialog - https://phabricator.wikimedia.org/T172694 (10ppelberg) [21:59:37] 10MediaWiki-Interwiki, 10MediaWiki-Site-system, 10MediaWiki-extensions-InterwikiExtracts, 10Parsoid, 10SiteMatrix: Parsoid needs a bidirectional interwiki map (and hooks) - https://phabricator.wikimedia.org/T270444 (10cscott) [22:00:41] 10MediaWiki-extensions-Translate, 10MW-1.36-notes (1.36.0-wmf.22; 2020-12-15), 10Patch-For-Review, 10Wikimedia-production-error: Importing an invalid gettext file causes "Fatal exception of type MWException" - https://phabricator.wikimedia.org/T59964 (10Mholloway) 05Open→03Resolved a:03Mholloway Veri... [22:00:44] (03CR) 10Reedy: [C: 03+2] Add test showing that getBlock can recurse if you use Autopromote and use APCOND_BLOCKED [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650245 (https://phabricator.wikimedia.org/T270145) (owner: 10Paladox) [22:00:46] (03CR) 10Reedy: [C: 03+2] Fix infinite recursion with wgAutopromote when using getBlock within checkCondition [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650246 (https://phabricator.wikimedia.org/T270145) (owner: 10Paladox) [22:00:57] 10MediaWiki-Interwiki, 10MediaWiki-Site-system, 10MediaWiki-extensions-Interwiki, 10Platform Engineering, and 6 others: RFC: Overhaul Interwiki map, unify with Sites and WikiMap - https://phabricator.wikimedia.org/T113034 (10cscott) Any chance this is going to be taken up again? For Parsoid purposes, the... [22:01:56] 10MediaWiki-extensions-SecurePoll, 10Platform Engineering, 10Anti-Harassment (The Letter Song): Investigate issues with Tally function in SecurePoll [8Hr] - https://phabricator.wikimedia.org/T269029 (10tstarling) My threat model was Board elections, specifically the risk of capture of the whole organisation,... [22:02:21] 10MediaWiki-General, 10I18n: Recursive interwiki link handling should be possible - https://phabricator.wikimedia.org/T41199 (10cscott) See {T270444} -- this mapping would have to be bidirectional to support Parsoid. [22:03:09] 10Wikipedia-Android-App-Backlog: Remove shadow from app bar in articles - https://phabricator.wikimedia.org/T270168 (10cooltey) a:03cooltey [22:09:59] 10HasSomeColours: make VE work - https://phabricator.wikimedia.org/T193743 (10Isarra) 05Open→03Resolved a:03Isarra Fixed by Pastakhov in https://gerrit.wikimedia.org/r/c/mediawiki/skins/HasSomeColours/+/622403 [22:10:08] (03PS1) 10Umherirrender: Add missing @var and improve documentation [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/650273 [22:12:58] (03Merged) 10jenkins-bot: Add test showing that getBlock can recurse if you use Autopromote and use APCOND_BLOCKED [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650245 (https://phabricator.wikimedia.org/T270145) (owner: 10Paladox) [22:13:05] (03Merged) 10jenkins-bot: Fix infinite recursion with wgAutopromote when using getBlock within checkCondition [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650246 (https://phabricator.wikimedia.org/T270145) (owner: 10Paladox) [22:16:58] (03PS1) 10Isarra: Use updated everything [skins/HasSomeColours] - 10https://gerrit.wikimedia.org/r/650274 (https://phabricator.wikimedia.org/T269626) [22:17:58] (03CR) 10jerkins-bot: [V: 04-1] Avoid reflows when lazy loading images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/643543 (https://phabricator.wikimedia.org/T197188) (owner: 10Jdlrobson) [22:18:02] (03CR) 10jerkins-bot: [V: 04-1] Use updated everything [skins/HasSomeColours] - 10https://gerrit.wikimedia.org/r/650274 (https://phabricator.wikimedia.org/T269626) (owner: 10Isarra) [22:19:04] 10Product-Analytics (Kanban): Updated number of editors across all wikipedias and all projects per month - https://phabricator.wikimedia.org/T269625 (10SNowick_WMF) 05Open→03Resolved [22:20:04] 10Android-app-feature-Description-Editing, 10Product-Analytics (Kanban), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.33x-R-Rosgulla): Analytics for Reward Interstitials - https://phabricator.wikimedia.org/T249970 (10SNowick_WMF) [22:20:13] 10Android-app-feature-Description-Editing, 10Product-Analytics (Kanban), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.33x-R-Rosgulla): Analytics for Reward Interstitials - https://phabricator.wikimedia.org/T249970 (10SNowick_WMF) p:05Low→03Medium [22:21:04] (03CR) 10Ottomata: Add new action and user fields (031 comment) [schemas/event/secondary] - 10https://gerrit.wikimedia.org/r/649599 (https://phabricator.wikimedia.org/T262209) (owner: 10Awight) [22:24:26] (03PS2) 10Esanders: Follow-up I6f6a869: Apply flex wrapping of actions in anon mode as well [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/649885 (https://phabricator.wikimedia.org/T259320) [22:27:11] (03PS2) 10Isarra: Use updated everything [skins/HasSomeColours] - 10https://gerrit.wikimedia.org/r/650274 (https://phabricator.wikimedia.org/T269626) [22:29:09] (03PS1) 10Jack Phoenix: Define the skin's displayname to ensure it shows up as "Mask" (with an uppercase M) in Special:Preferences [skins/Mask] - 10https://gerrit.wikimedia.org/r/650276 [22:30:31] (03CR) 10DannyS712: [C: 03+2] "poke" [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/649926 (owner: 10Esanders) [22:31:44] (03PS8) 10Jdlrobson: Avoid reflows when lazy loading images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/643543 (https://phabricator.wikimedia.org/T197188) [22:33:46] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.33x-R-Rosgulla): Remove shadow from app bar in articles - https://phabricator.wikimedia.org/T270168 (10cooltey) [22:34:24] (03CR) 10Isarra: [C: 03+2] Define the skin's displayname to ensure it shows up as "Mask" (with an uppercase M) in Special:Preferences [skins/Mask] - 10https://gerrit.wikimedia.org/r/650276 (owner: 10Jack Phoenix) [22:34:45] (03CR) 10Bartosz Dziewoński: [C: 03+2] Follow-up I6f6a869: Apply flex wrapping of actions in anon mode as well [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/649885 (https://phabricator.wikimedia.org/T259320) (owner: 10Esanders) [22:35:40] (03Merged) 10jenkins-bot: Make Hooks::$tags a constant [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/649926 (owner: 10Esanders) [22:36:32] (03CR) 10Jack Phoenix: [C: 03+2] Use updated everything [skins/HasSomeColours] - 10https://gerrit.wikimedia.org/r/650274 (https://phabricator.wikimedia.org/T269626) (owner: 10Isarra) [22:36:48] (03CR) 10Jdlrobson: [C: 03+1] "neat" [skins/HasSomeColours] - 10https://gerrit.wikimedia.org/r/650274 (https://phabricator.wikimedia.org/T269626) (owner: 10Isarra) [22:37:18] 10GrowthExperiments-Homepage, 10Gender-Support, 10Growth-Team (Current Sprint), 10MW-1.36-notes (1.36.0-wmf.22; 2020-12-15): The user's gender is not taken into account when creating a tab to the user's page - https://phabricator.wikimedia.org/T268888 (10Etonkovidova) 05Open→03Resolved Checked `ruwiki`... [22:37:30] 10MediaWiki-Core-Skin-Architecture: Allow extensions to programmatically define sidebar portlet IDs - https://phabricator.wikimedia.org/T270447 (10ashley) [22:40:53] 10Accessibility, 10DiscussionTools, 10Editing QA, 10Growth-Team, and 5 others: User can't tab out VisualEditor surfaces, e.g. comment input widgets, media dialog - https://phabricator.wikimedia.org/T172694 (10ppelberg) >>! In T172694#6330965, @Esanders wrote: > The only issue is if this works on other keyb... [22:42:07] 10observability: ELK: uniquely identify network syslog - https://phabricator.wikimedia.org/T268806 (10colewhite) 05Open→03Resolved a:03colewhite Network syslog now is `type => "netdev"` in Logstash. [22:48:18] (03CR) 10DannyS712: Prepend an HTML warningbox if a schema has been disabled or migrated (032 comments) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/650174 (https://phabricator.wikimedia.org/T270136) (owner: 10Ottomata) [22:49:12] (03CR) 10DannyS712: [C: 03+2] Add missing @var and improve documentation [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/650273 (owner: 10Umherirrender) [22:49:42] (03CR) 10DannyS712: [C: 03+2] Fix doc about IDatabase [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/650254 (owner: 10Umherirrender) [22:54:28] (03CR) 10Reedy: [C: 03+2] Fix two `@since 1.36` [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650192 (owner: 10Reedy) [22:54:47] (03PS10) 10Arlolra: Use figure and figcaption HTML5 elements for media [core] - 10https://gerrit.wikimedia.org/r/507512 (https://phabricator.wikimedia.org/T51097) [22:54:49] (03PS6) 10Arlolra: Update tests for $wgUseNewMediaStructure [core] - 10https://gerrit.wikimedia.org/r/647318 (https://phabricator.wikimedia.org/T51097) [22:55:54] (03CR) 10Ori.livneh: "In MediaWiki, when you edit-protect a page (lock it down so only admins can edit it), you can provide an explanation. This gets shown to u" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/650174 (https://phabricator.wikimedia.org/T270136) (owner: 10Ottomata) [22:56:20] (03CR) 10DannyS712: "LGTM bar the issues identified" (035 comments) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/650267 (owner: 10Umherirrender) [22:56:43] (03CR) 10Holger Knust: "> Patch Set 21:" [core] - 10https://gerrit.wikimedia.org/r/623879 (https://phabricator.wikimedia.org/T51133) (owner: 10Holger Knust) [22:56:48] 10MediaWiki-User-management, 10Technical-Debt: User::isLoggedIn() is confusing - https://phabricator.wikimedia.org/T270450 (10Reedy) [22:57:21] 10MediaWiki-User-management, 10Technical-Debt: User::isLoggedIn() is confusing - https://phabricator.wikimedia.org/T270450 (10Jdforrester-WMF) Let's burn it from reality. [22:58:37] (03CR) 10DannyS712: [C: 03+1] Add missing @var and improve documentation [extensions/Math] - 10https://gerrit.wikimedia.org/r/650255 (owner: 10Umherirrender) [22:59:18] (03Merged) 10jenkins-bot: Define the skin's displayname to ensure it shows up as "Mask" (with an uppercase M) in Special:Preferences [skins/Mask] - 10https://gerrit.wikimedia.org/r/650276 (owner: 10Jack Phoenix) [22:59:20] (03Merged) 10jenkins-bot: Follow-up I6f6a869: Apply flex wrapping of actions in anon mode as well [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/649885 (https://phabricator.wikimedia.org/T259320) (owner: 10Esanders) [22:59:22] (03Merged) 10jenkins-bot: Use updated everything [skins/HasSomeColours] - 10https://gerrit.wikimedia.org/r/650274 (https://phabricator.wikimedia.org/T269626) (owner: 10Isarra) [22:59:25] (03Merged) 10jenkins-bot: Add missing @var and improve documentation [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/650273 (owner: 10Umherirrender) [22:59:27] (03Merged) 10jenkins-bot: Fix doc about IDatabase [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/650254 (owner: 10Umherirrender) [22:59:54] (03CR) 10DannyS712: [C: 03+2] Add missing @var and improve documentation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/649964 (owner: 10Umherirrender) [23:00:16] 10HasSomeColours, 10Patch-For-Review: Showing Other navigation and ⧼global-links-menu⧽ in using HasSomeColours skin. - https://phabricator.wikimedia.org/T267386 (10Isarra) Okay, this should now be fixed, but the linked change requires mw 1.36 because I'm a dumbarse and forgot to separate the changes. That bein... [23:00:24] (03CR) 10Reedy: [V: 03+2 C: 03+2] "Forcing because CI is going to say no due to gerrit giving a 502. Not got time for this" [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650192 (owner: 10Reedy) [23:01:17] 10HasSomeColours, 10Patch-For-Review: Make global-links and global-links-menu render from default language if no specific language strings exist (like sidebar) - https://phabricator.wikimedia.org/T194202 (10Isarra) 05Open→03Resolved a:03Isarra [23:01:33] 10MediaWiki-Core-Skin-Architecture, 10MediaWiki-extensions-CreateRedirect, 10MediaWiki-extensions-LanguageSelector, 10MediaWiki-skins-Erudite, and 16 others: Remove SkinTemplateToolboxEnd hook - https://phabricator.wikimedia.org/T256511 (10Isarra) [23:01:38] 10Multi-Content-Revisions (New Features), 10Platform Team Initiatives (MCR): Factor PageStore and PageRecord out of WikiPage - https://phabricator.wikimedia.org/T195069 (10daniel) [23:01:43] 10MediaWiki-General, 10Platform Engineering, 10Performance Issue, 10Performance-Team (Radar), 10good first task: MediaWiki needlessly queries page data twice on page views - https://phabricator.wikimedia.org/T206498 (10daniel) [23:02:06] 10MediaWiki-User-management, 10Technical-Debt: User::isLoggedIn() is confusing - https://phabricator.wikimedia.org/T270450 (10Jdforrester-WMF) The code for `isLoggedIn()` dates from 388d95d7b8a; the replacement, `isRegistered()`, was added in f7201e3b9b8 in 1.34, but the original was not marked as deprecated.... [23:02:15] 10MediaWiki-Core-Skin-Architecture, 10MediaWiki-skins-Amethyst, 10MediaWiki-skins-Erudite, 10MediaWiki-skins-Strapping, and 15 others: Fix or archive skin using deprecated Skin::setupSkinUserCss() method - https://phabricator.wikimedia.org/T266735 (10Isarra) [23:02:19] 10MediaWiki-General, 10Dependency injection, 10Patch-For-Review, 10Platform Team Initiatives (Decoupling (CDP2)), 10Platform Team Workboards (External Code Reviews): Complete TitleFactory to be a real factory service - https://phabricator.wikimedia.org/T247190 (10daniel) See also {T270430} [23:02:20] (03PS2) 10Umherirrender: Add missing @var and improve documentation [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/650267 [23:02:22] (03CR) 10jerkins-bot: [V: 04-1] Avoid reflows when lazy loading images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/643543 (https://phabricator.wikimedia.org/T197188) (owner: 10Jdlrobson) [23:02:56] 10MediaWiki-General, 10Platform Engineering, 10Performance Issue, 10Performance-Team (Radar), 10good first task: MediaWiki needlessly queries page data twice on page views - https://phabricator.wikimedia.org/T206498 (10daniel) I think the solution here will be to centralized caching in a future PageStore... [23:02:58] 10HasSomeColours, 10Splash, 10Patch-For-Review: Port Splash global nav fixes to all the other skins with the same menu - https://phabricator.wikimedia.org/T266891 (10Isarra) 05Open→03Resolved a:03Isarra [23:03:02] (03CR) 10Umherirrender: Add missing @var and improve documentation (035 comments) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/650267 (owner: 10Umherirrender) [23:03:14] 10HasSomeColours, 10Patch-For-Review: Showing Other navigation and ⧼global-links-menu⧽ in using HasSomeColours skin. - https://phabricator.wikimedia.org/T267386 (10Isarra) 05Stalled→03Resolved a:03Isarra [23:03:28] 10MediaWiki-Core-Skin-Architecture, 10MediaWiki-skins-Amethyst, 10Anisa, 10Bouquet, and 9 others: mediawiki.skinning.content.externallinks is deprecated - https://phabricator.wikimedia.org/T269626 (10Isarra) [23:03:58] 10WoOgLeShades: Make global links menu appear in all languages based on wiki language default (if not set in others) - https://phabricator.wikimedia.org/T257939 (10Isarra) 05Open→03Resolved a:03Isarra Confirmed fixed. [23:06:30] (03PS1) 10Jforrester: User: Deprecate confusingly-named isLoggedIn() method [core] - 10https://gerrit.wikimedia.org/r/650283 (https://phabricator.wikimedia.org/T270450) [23:06:40] 10MediaWiki-Interwiki, 10MediaWiki-Site-system, 10MediaWiki-extensions-InterwikiExtracts, 10Parsoid, 10SiteMatrix: Parsoid needs a bidirectional interwiki map (and hooks) - https://phabricator.wikimedia.org/T270444 (10cscott) [23:07:15] (03CR) 10DannyS712: "LGTM bar 2 issues" (032 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/650249 (owner: 10Umherirrender) [23:08:20] (03CR) 10Reedy: [C: 03+2] User: Deprecate confusingly-named isLoggedIn() method [core] - 10https://gerrit.wikimedia.org/r/650283 (https://phabricator.wikimedia.org/T270450) (owner: 10Jforrester) [23:08:30] (03CR) 10DannyS712: [C: 03+2] Add missing @var and improve documentation [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/650267 (owner: 10Umherirrender) [23:09:36] (03PS2) 10Umherirrender: Add missing @var and improve documentation [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/650249 [23:09:47] (03CR) 10Umherirrender: Add missing @var and improve documentation (032 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/650249 (owner: 10Umherirrender) [23:10:08] (03CR) 10DannyS712: "mostly LGTM, 1 issue" (031 comment) [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/650242 (owner: 10Umherirrender) [23:10:17] (03PS9) 10Jdlrobson: Avoid reflows when lazy loading images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/643543 (https://phabricator.wikimedia.org/T197188) [23:10:44] (03PS1) 10Jforrester: Swap out uses of User->isLoggedIn() with ->isRegistered() [core] - 10https://gerrit.wikimedia.org/r/650284 (https://phabricator.wikimedia.org/T270450) [23:11:03] (03CR) 10Jdlrobson: "Some initial thoughts." (0310 comments) [core] - 10https://gerrit.wikimedia.org/r/426840 (owner: 10Isarra) [23:11:38] (03CR) 10DannyS712: [C: 04-1] User: Deprecate confusingly-named isLoggedIn() method (031 comment) [core] - 10https://gerrit.wikimedia.org/r/650283 (https://phabricator.wikimedia.org/T270450) (owner: 10Jforrester) [23:12:10] (03CR) 10Reedy: [C: 04-1] "Yay!" [core] - 10https://gerrit.wikimedia.org/r/650284 (https://phabricator.wikimedia.org/T270450) (owner: 10Jforrester) [23:13:41] (03CR) 10DannyS712: [C: 03+2] Add missing @var and improve documentation [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/650240 (owner: 10Umherirrender) [23:14:37] (03PS2) 10Umherirrender: Add missing @param and improve documentation [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/650242 [23:14:50] (03CR) 10Umherirrender: Add missing @param and improve documentation (031 comment) [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/650242 (owner: 10Umherirrender) [23:15:29] (03CR) 10DannyS712: "mostly LGTM, 1 issue" (031 comment) [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/650232 (owner: 10Umherirrender) [23:15:49] (03CR) 10DannyS712: [C: 03+2] Add missing @param and improve documentation [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/650242 (owner: 10Umherirrender) [23:16:11] (03PS1) 10BryanDavis: l10n: Add translatable labels to all serializers [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650286 [23:16:15] (03CR) 10DannyS712: [C: 03+2] Add missing @var and improve documentation [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/650249 (owner: 10Umherirrender) [23:18:21] (03PS1) 10Reedy: SECURITY: Act like users don't exist if hidden from viewer [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/650287 (https://phabricator.wikimedia.org/T120883) [23:18:23] (03PS1) 10Reedy: SECURITY: Set a dummy title for Action buttons on Special:Log [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/650288 (https://phabricator.wikimedia.org/T205908) [23:18:25] (03PS1) 10Reedy: SECURITY: Act like users don't exist if hidden from viewer [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/650289 (https://phabricator.wikimedia.org/T120883) [23:18:27] (03PS1) 10Reedy: Prep 1.31.11 [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/650290 [23:18:29] (03PS1) 10Reedy: Start 1.31.12 [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/650291 [23:19:17] (03PS1) 10Reedy: Revert "Define Skin RelevantUser for IP ranges" [core] - 10https://gerrit.wikimedia.org/r/650193 [23:19:25] (03CR) 10Reedy: [C: 03+2] Revert "Define Skin RelevantUser for IP ranges" [core] - 10https://gerrit.wikimedia.org/r/650193 (owner: 10Reedy) [23:19:33] (03PS2) 10Reedy: Revert "Define Skin RelevantUser for IP ranges" [core] - 10https://gerrit.wikimedia.org/r/650193 [23:19:37] (03CR) 10Reedy: [C: 03+2] Revert "Define Skin RelevantUser for IP ranges" [core] - 10https://gerrit.wikimedia.org/r/650193 (owner: 10Reedy) [23:19:50] (03PS1) 10Reedy: SECURITY: Set a dummy title for Action buttons on Special:Log [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650292 (https://phabricator.wikimedia.org/T205908) [23:19:52] (03PS1) 10Reedy: SECURITY: Act like users don't exist if hidden from viewer [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650293 (https://phabricator.wikimedia.org/T120883) [23:19:54] (03PS1) 10Reedy: SECURITY: Act like users don't exist if hidden from viewer [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650294 (https://phabricator.wikimedia.org/T120883) [23:19:56] (03PS1) 10Reedy: Prep 1.35.1 [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650295 [23:19:58] (03PS1) 10Reedy: Start 1.35.2 [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650296 [23:20:12] 10wmf-sre-laptop: wmf-sre-laptop should use config-master.wikimedia.org to bootstrap SSH fingerprints - https://phabricator.wikimedia.org/T270359 (10Legoktm) For reference, this is what I went with: ` systemctl --user cat wmf-fingerprints # /home/km/.config/systemd/user/wmf-fingerprints.service [Unit] Descriptio... [23:21:51] (03PS2) 10Umherirrender: Add missing @var and improve documentation [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/650232 [23:21:57] 10MediaWiki-Core-Skin-Architecture: Allow extensions to programmatically define sidebar portlet IDs - https://phabricator.wikimedia.org/T270447 (10Jdlrobson) I'm unable to replicate this. When I add the following portlet, I always get the id 'p-sunday' and the h3 has the message sunday translated on Monobook and... [23:21:58] (03CR) 10jerkins-bot: [V: 04-1] SECURITY: Act like users don't exist if hidden from viewer [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/650289 (https://phabricator.wikimedia.org/T120883) (owner: 10Reedy) [23:22:16] (03PS1) 10BryanDavis: grammar: Use "a URL", not "an URL" [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650297 [23:22:25] oh ffs :D [23:22:32] (03CR) 10Umherirrender: Add missing @var and improve documentation (031 comment) [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/650232 (owner: 10Umherirrender) [23:22:50] (03CR) 10BryanDavis: [C: 03+2] l10n: Add translatable labels to all serializers [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650286 (owner: 10BryanDavis) [23:23:26] (03CR) 10jerkins-bot: [V: 04-1] Prep 1.31.11 [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/650290 (owner: 10Reedy) [23:23:33] 10MediaWiki-Recent-changes, 10Growth-Team, 10Patch-For-Review: z-index:auto on rcfilters multiselect widgets results in them appearing behind content on most skins - https://phabricator.wikimedia.org/T270351 (10Jdlrobson) [23:23:45] (03CR) 10jerkins-bot: [V: 04-1] Start 1.31.12 [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/650291 (owner: 10Reedy) [23:24:05] (03CR) 10BryanDavis: [C: 03+2] grammar: Use "a URL", not "an URL" [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650297 (owner: 10BryanDavis) [23:25:40] (03Merged) 10jenkins-bot: Add missing @var and improve documentation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/649964 (owner: 10Umherirrender) [23:25:58] (03CR) 10Umherirrender: "stderr: 'fatal: unable to access 'https://gerrit.wikimedia.org/r/mediawiki/core/': The requested URL returned error: 502'" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/650249 (owner: 10Umherirrender) [23:26:51] woohoo! [23:26:58] (03Merged) 10jenkins-bot: l10n: Add translatable labels to all serializers [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650286 (owner: 10BryanDavis) [23:27:05] (03CR) 10Jforrester: User: Deprecate confusingly-named isLoggedIn() method (031 comment) [core] - 10https://gerrit.wikimedia.org/r/650283 (https://phabricator.wikimedia.org/T270450) (owner: 10Jforrester) [23:28:11] (03CR) 10DannyS712: [C: 03+1] SECURITY: Act like users don't exist if hidden from viewer [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/650287 (https://phabricator.wikimedia.org/T120883) (owner: 10Reedy) [23:28:13] (03Merged) 10jenkins-bot: grammar: Use "a URL", not "an URL" [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/650297 (owner: 10BryanDavis) [23:28:21] (03CR) 10DannyS712: [C: 03+1] SECURITY: Set a dummy title for Action buttons on Special:Log [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/650288 (https://phabricator.wikimedia.org/T205908) (owner: 10Reedy) [23:28:36] (03PS2) 10Umherirrender: Use Maintenance::set/getBatchSize in maintenance scripts [extensions/Echo] - 10https://gerrit.wikimedia.org/r/650222 [23:29:13] (03CR) 10DannyS712: SECURITY: Act like users don't exist if hidden from viewer (031 comment) [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/650289 (https://phabricator.wikimedia.org/T120883) (owner: 10Reedy) [23:29:38] (03CR) 10DannyS712: [C: 03+1] Prep 1.31.11 [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/650290 (owner: 10Reedy) [23:29:46] (03CR) 10DannyS712: [C: 03+1] Start 1.31.12 [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/650291 (owner: 10Reedy) [23:30:08] (03CR) 10DannyS712: [C: 03+1] SECURITY: Set a dummy title for Action buttons on Special:Log [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650292 (https://phabricator.wikimedia.org/T205908) (owner: 10Reedy) [23:30:44] (03PS1) 10Isarra: Ensure sitesubtitle shows up when enabled regardless of display language [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/650299 [23:30:58] (03CR) 10DannyS712: [C: 03+1] SECURITY: Act like users don't exist if hidden from viewer [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650293 (https://phabricator.wikimedia.org/T120883) (owner: 10Reedy) [23:31:56] (03CR) 10Reedy: [C: 03+2] SECURITY: Act like users don't exist if hidden from viewer [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/650287 (https://phabricator.wikimedia.org/T120883) (owner: 10Reedy) [23:31:59] (03CR) 10Reedy: [C: 03+2] SECURITY: Set a dummy title for Action buttons on Special:Log [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/650288 (https://phabricator.wikimedia.org/T205908) (owner: 10Reedy) [23:32:21] (03CR) 10DannyS712: [C: 03+1] SECURITY: Act like users don't exist if hidden from viewer [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650294 (https://phabricator.wikimedia.org/T120883) (owner: 10Reedy) [23:34:08] (03CR) 10jerkins-bot: [V: 04-1] Start 1.35.2 [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650296 (owner: 10Reedy) [23:34:21] (03CR) 10jerkins-bot: [V: 04-1] SECURITY: Act like users don't exist if hidden from viewer [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650293 (https://phabricator.wikimedia.org/T120883) (owner: 10Reedy) [23:34:42] (03CR) 10DannyS712: [C: 03+1] Prep 1.35.1 [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650295 (owner: 10Reedy) [23:34:54] (03CR) 10DannyS712: [C: 03+1] Start 1.35.2 [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650296 (owner: 10Reedy) [23:34:58] (03CR) 10jerkins-bot: [V: 04-1] SECURITY: Act like users don't exist if hidden from viewer [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650294 (https://phabricator.wikimedia.org/T120883) (owner: 10Reedy) [23:35:23] (03CR) 10jerkins-bot: [V: 04-1] Prep 1.35.1 [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650295 (owner: 10Reedy) [23:35:40] (03CR) 10DannyS712: SECURITY: Act like users don't exist if hidden from viewer (032 comments) [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650293 (https://phabricator.wikimedia.org/T120883) (owner: 10Reedy) [23:36:50] (03CR) 10jerkins-bot: [V: 04-1] Swap out uses of User->isLoggedIn() with ->isRegistered() [core] - 10https://gerrit.wikimedia.org/r/650284 (https://phabricator.wikimedia.org/T270450) (owner: 10Jforrester) [23:39:06] (03CR) 10Reedy: [C: 03+2] SECURITY: Set a dummy title for Action buttons on Special:Log [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650292 (https://phabricator.wikimedia.org/T205908) (owner: 10Reedy) [23:39:25] (03Merged) 10jenkins-bot: SECURITY: Act like users don't exist if hidden from viewer [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/650287 (https://phabricator.wikimedia.org/T120883) (owner: 10Reedy) [23:39:41] (03Merged) 10jenkins-bot: SECURITY: Set a dummy title for Action buttons on Special:Log [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/650288 (https://phabricator.wikimedia.org/T205908) (owner: 10Reedy) [23:41:05] (03CR) 10DannyS712: "breaking change, should be added to release notes" [core] - 10https://gerrit.wikimedia.org/r/650224 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [23:44:06] (03Merged) 10jenkins-bot: User: Deprecate confusingly-named isLoggedIn() method [core] - 10https://gerrit.wikimedia.org/r/650283 (https://phabricator.wikimedia.org/T270450) (owner: 10Jforrester) [23:44:08] (03PS1) 10Gabrielchihonglee: Extract hardcoded labels in FullZObject to constants file [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/650300 (https://phabricator.wikimedia.org/T270288) [23:44:10] (03Merged) 10jenkins-bot: Add missing @var and improve documentation [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/650267 (owner: 10Umherirrender) [23:44:12] (03Merged) 10jenkins-bot: Add missing @var and improve documentation [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/650240 (owner: 10Umherirrender) [23:44:14] (03Merged) 10jenkins-bot: Add missing @param and improve documentation [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/650242 (owner: 10Umherirrender) [23:45:02] (03CR) 10DannyS712: "mostly LGTM" (032 comments) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/650228 (owner: 10Umherirrender) [23:46:21] (03CR) 10jerkins-bot: [V: 04-1] Add missing @var and improve documentation [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/650249 (owner: 10Umherirrender) [23:46:53] (03CR) 10DannyS712: [C: 03+2] "try again" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/650249 (owner: 10Umherirrender) [23:46:59] 10Wikimedia-Site-requests, 10Patch-For-Review: Complete Wiktionary in French content namespace ($wgContentNamespaces) by adding "Thésaurus:" - https://phabricator.wikimedia.org/T97228 (10Lepticed7) [23:48:22] (03CR) 10jerkins-bot: [V: 04-1] Extract hardcoded labels in FullZObject to constants file [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/650300 (https://phabricator.wikimedia.org/T270288) (owner: 10Gabrielchihonglee) [23:49:12] (03PS1) 10Nray: Sync location/other styles of #mw-searchButton with #searchButton [skins/Vector] - 10https://gerrit.wikimedia.org/r/650302 (https://phabricator.wikimedia.org/T270202) [23:49:28] (03PS2) 10Reedy: SECURITY: Act like users don't exist if hidden from viewer [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/650289 (https://phabricator.wikimedia.org/T120883) [23:49:30] (03PS2) 10Reedy: Prep 1.31.11 [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/650290 [23:49:32] (03PS2) 10Reedy: Start 1.31.12 [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/650291 [23:49:47] (03PS2) 10Umherirrender: Add missing @var and @param documentation [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/650228 [23:49:57] (03CR) 10Umherirrender: Add missing @var and @param documentation (032 comments) [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/650228 (owner: 10Umherirrender) [23:50:33] (03CR) 10Legoktm: [C: 03+2] RELEASE-NOTES-1.36: Refresh list of updated libraries and alpha-sort [core] - 10https://gerrit.wikimedia.org/r/650213 (owner: 10Jforrester) [23:51:28] (03PS2) 10Gabrielchihonglee: Extract hardcoded labels in FullZObject to constants file [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/650300 (https://phabricator.wikimedia.org/T270288) [23:51:41] (03Merged) 10jenkins-bot: SECURITY: Set a dummy title for Action buttons on Special:Log [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650292 (https://phabricator.wikimedia.org/T205908) (owner: 10Reedy) [23:51:49] 10MediaWiki-Releasing, 10Security: Write and send release announcements for MediaWiki 1.31.11/1.35.1 - https://phabricator.wikimedia.org/T263805 (10Reedy) 05Open→03Resolved p:05Triage→03Medium a:03Reedy [23:51:51] 10MediaWiki-Releasing, 10Security: Write and send release announcements for MediaWiki 1.31.11/1.35.1 - https://phabricator.wikimedia.org/T263805 (10Reedy) [23:52:13] (03PS2) 10Reedy: SECURITY: Act like users don't exist if hidden from viewer [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650293 (https://phabricator.wikimedia.org/T120883) [23:52:15] (03PS2) 10Reedy: SECURITY: Act like users don't exist if hidden from viewer [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650294 (https://phabricator.wikimedia.org/T120883) [23:52:17] (03PS2) 10Reedy: Prep 1.35.1 [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650295 [23:52:19] (03PS2) 10Reedy: Start 1.35.2 [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/650296 [23:55:02] (03CR) 10jerkins-bot: [V: 04-1] SECURITY: Act like users don't exist if hidden from viewer [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/650289 (https://phabricator.wikimedia.org/T120883) (owner: 10Reedy) [23:55:33] (03CR) 10Reedy: [V: 03+2 C: 03+2] "Failure is a line too long. Will fix later" [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/650289 (https://phabricator.wikimedia.org/T120883) (owner: 10Reedy) [23:56:12] (03CR) 10DannyS712: [C: 03+2] Add missing @var and @param documentation [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/650228 (owner: 10Umherirrender) [23:56:17] (03CR) 10Reedy: [C: 03+2] Prep 1.31.11 [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/650290 (owner: 10Reedy) [23:58:23] (03PS3) 10Umherirrender: Improve docs from parser objects PPNode/PPFrame [core] - 10https://gerrit.wikimedia.org/r/644018 [23:59:21] (03PS3) 10Reedy: Start 1.31.12 [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/650291 [23:59:22] (03CR) 10Reedy: [C: 03+2] Start 1.31.12 [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/650291 (owner: 10Reedy) [23:59:26] (03CR) 10Jdlrobson: [C: 03+2] Sync location/other styles of #mw-searchButton with #searchButton [skins/Vector] - 10https://gerrit.wikimedia.org/r/650302 (https://phabricator.wikimedia.org/T270202) (owner: 10Nray) [23:59:53] (03CR) 10Jdlrobson: "Phuedx: one to look at in January along with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/625346" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/643543 (https://phabricator.wikimedia.org/T197188) (owner: 10Jdlrobson)