[00:00:35] 10DynamicPageList (third-party): Permanently move location of dplcache - https://phabricator.wikimedia.org/T268389 (10charitwo) [00:00:52] (03PS45) 10Daimona Eaytoy: Represent Consequences with command objects [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/633380 [00:01:19] (03PS1) 10SLF bot: Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/642692 [00:01:29] (03CR) 10DannyS712: "Will send a follow-up patch to address those issues after this merges" (034 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/633380 (owner: 10Daimona Eaytoy) [00:05:30] (03CR) 10DannyS712: Migrate slot_roles and content_models to abstract schema (032 comments) [core] - 10https://gerrit.wikimedia.org/r/619155 (https://phabricator.wikimedia.org/T230428) (owner: 10Ladsgroup) [00:09:48] (03CR) 10Reedy: [C: 03+2] Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/642692 (owner: 10SLF bot) [00:10:03] (03Merged) 10jenkins-bot: Add patch to set wl_notificationtimestamp BINARY(14) [core] - 10https://gerrit.wikimedia.org/r/642685 (https://phabricator.wikimedia.org/T230428) (owner: 10Ladsgroup) [00:16:33] (03Merged) 10jenkins-bot: Remove empty TitleRevisionAccess file [core] - 10https://gerrit.wikimedia.org/r/642436 (owner: 10DannyS712) [00:16:35] (03Merged) 10jenkins-bot: Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/642692 (owner: 10SLF bot) [00:19:22] (03CR) 10DannyS712: [C: 03+2] Hotfix: PHPDocs, identity can be set to null. [extensions/WikispeechSpeechDataCollector] - 10https://gerrit.wikimedia.org/r/642409 (owner: 10Karl Wettin (WMSE)) [00:22:22] (03CR) 10Ladsgroup: Migrate slot_roles and content_models to abstract schema (032 comments) [core] - 10https://gerrit.wikimedia.org/r/619155 (https://phabricator.wikimedia.org/T230428) (owner: 10Ladsgroup) [00:23:30] (03Merged) 10jenkins-bot: Hotfix: PHPDocs, identity can be set to null. [extensions/WikispeechSpeechDataCollector] - 10https://gerrit.wikimedia.org/r/642409 (owner: 10Karl Wettin (WMSE)) [00:26:10] (03CR) 10DannyS712: Introduce RecordingStore (0310 comments) [extensions/WikispeechSpeechDataCollector] - 10https://gerrit.wikimedia.org/r/642402 (https://phabricator.wikimedia.org/T267108) (owner: 10Karl Wettin (WMSE)) [00:34:07] (03CR) 10DannyS712: [C: 03+1] "did a bit of testing on patchdemo, lgtm, but would appreciate another set of eyes / another reviewer, so not merging" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/633380 (owner: 10Daimona Eaytoy) [01:10:41] (03CR) 10jerkins-bot: [V: 04-1] build: Updating npm dependencies [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/642700 (owner: 10Libraryupgrader) [01:13:35] (03CR) 10DannyS712: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/642439 (https://phabricator.wikimedia.org/T157658) (owner: 10DannyS712) [01:31:02] (03CR) 10DannyS712: [C: 04-2] "To avoid merge conflicts, haven't added the release notes yet. Will do once this is approved/ready to merge. To avoid it merging without t" [core] - 10https://gerrit.wikimedia.org/r/642440 (https://phabricator.wikimedia.org/T252907) (owner: 10DannyS712) [01:32:06] (03PS3) 10DannyS712: Make @internal EditPage variables private [core] - 10https://gerrit.wikimedia.org/r/642440 (https://phabricator.wikimedia.org/T252907) [01:48:22] 10MediaWiki-Parser: Parser should trim the text of internal links - https://phabricator.wikimedia.org/T268388 (10Niteshyadav585) I am new to use Phabricator. Can you please share the link to the source code of MediaWiki-Parser. [01:50:03] 10MediaWiki-extensions-GlobalWatchlist, 10User-DannyS712: Add a list or autocompletion for sites on Special:GlobalWatchlistSettings - https://phabricator.wikimedia.org/T268261 (10DannyS712) Note that this would also need to take into account {T268210} - only valid sites should be shown [01:50:53] (03PS5) 10DannyS712: ApiQueryWatchlist: Include log entry action text [core] - 10https://gerrit.wikimedia.org/r/619608 (https://phabricator.wikimedia.org/T260227) [01:57:24] (03CR) 10DannyS712: "This change is ready for review." [extensions/GlobalWatchlist] - 10https://gerrit.wikimedia.org/r/642442 (https://phabricator.wikimedia.org/T268265) (owner: 10DannyS712) [01:58:04] (03PS1) 10Paladox: Fix fatal typo in Special:ArticlesHome [extensions/BlogPage] (REL1_35) - 10https://gerrit.wikimedia.org/r/642443 (https://phabricator.wikimedia.org/T266156) [02:01:58] (03CR) 10jerkins-bot: [V: 04-1] Fix fatal typo in Special:ArticlesHome [extensions/BlogPage] (REL1_35) - 10https://gerrit.wikimedia.org/r/642443 (https://phabricator.wikimedia.org/T266156) (owner: 10Paladox) [02:03:31] (03PS1) 10Paladox: Forwards-compatibility fix to make CI happy [extensions/SocialProfile] (REL1_35) - 10https://gerrit.wikimedia.org/r/642444 [02:20:30] 10ContentTranslation: The Special:ContentTranslation sometimes a bug occurs - https://phabricator.wikimedia.org/T268070 (10Juan90264) @Aklapper : I ended up discovering what caused the problem said in the argument, when I saw "Salved", I had the impression that the translation made afterwards had already been sa... [02:26:41] 10ContentTranslation: The Special:ContentTranslation sometimes a bug occurs - https://phabricator.wikimedia.org/T268070 (10Juan90264) [02:28:55] 10ContentTranslation: The Special:ContentTranslation sometimes a bug occurs - https://phabricator.wikimedia.org/T268070 (10Juan90264) [02:30:17] 10Magnus Sälgö: Project "Stadens ansikte" - https://phabricator.wikimedia.org/T268374 (10Salgo60) [02:35:05] (03CR) 10DannyS712: [C: 03+2] "Failures are deprecated revision stuff, and an issue in upload avatar that I assume will be fixed by https://gerrit.wikimedia.org/r/c/medi" [extensions/BlogPage] (REL1_35) - 10https://gerrit.wikimedia.org/r/642443 (https://phabricator.wikimedia.org/T266156) (owner: 10Paladox) [02:35:45] (03CR) 10DannyS712: [V: 03+2 C: 03+2] "Failure is unrelated (use of SkinTemplateOutputPageBeforeExec hook)" [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/642700 (owner: 10Libraryupgrader) [02:36:02] (03CR) 10Paladox: "@DannyS712 could you merge https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SocialProfile/+/642444 please? 😊" [extensions/BlogPage] (REL1_35) - 10https://gerrit.wikimedia.org/r/642443 (https://phabricator.wikimedia.org/T266156) (owner: 10Paladox) [02:36:52] (03CR) 10DannyS712: [C: 03+2] Forwards-compatibility fix to make CI happy [extensions/SocialProfile] (REL1_35) - 10https://gerrit.wikimedia.org/r/642444 (owner: 10Paladox) [02:37:09] (03CR) 10DannyS712: [C: 03+1] Fix trailing ; in patch-sites-site_language-35.sql [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/642434 (owner: 10Reedy) [02:37:20] (03PS2) 10DannyS712: Fix trailing ; in patch-sites-site_language-35.sql [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/642434 (owner: 10Reedy) [02:39:34] (03CR) 10jerkins-bot: [V: 04-1] Fix fatal typo in Special:ArticlesHome [extensions/BlogPage] (REL1_35) - 10https://gerrit.wikimedia.org/r/642443 (https://phabricator.wikimedia.org/T266156) (owner: 10Paladox) [02:39:54] (03CR) 10DannyS712: [C: 04-1] Mention new required php extension intl (032 comments) [core] - 10https://gerrit.wikimedia.org/r/640474 (https://phabricator.wikimedia.org/T267669) (owner: 10Florianschmidtwelzow) [02:42:46] (03Merged) 10jenkins-bot: Forwards-compatibility fix to make CI happy [extensions/SocialProfile] (REL1_35) - 10https://gerrit.wikimedia.org/r/642444 (owner: 10Paladox) [02:43:08] (03CR) 10DannyS712: [C: 03+2] "try again" [extensions/BlogPage] (REL1_35) - 10https://gerrit.wikimedia.org/r/642443 (https://phabricator.wikimedia.org/T266156) (owner: 10Paladox) [02:43:49] (03CR) 10Paladox: "recheck" [extensions/BlogPage] (REL1_35) - 10https://gerrit.wikimedia.org/r/642443 (https://phabricator.wikimedia.org/T266156) (owner: 10Paladox) [02:44:32] (03CR) 10DannyS712: [C: 03+2] build: Updating npm dependencies [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/642703 (owner: 10Libraryupgrader) [02:44:37] (03CR) 10DannyS712: [C: 03+2] build: Updating npm dependencies [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/642701 (owner: 10Libraryupgrader) [02:47:05] (03CR) 10jerkins-bot: [V: 04-1] Fix fatal typo in Special:ArticlesHome [extensions/BlogPage] (REL1_35) - 10https://gerrit.wikimedia.org/r/642443 (https://phabricator.wikimedia.org/T266156) (owner: 10Paladox) [02:47:45] (03CR) 10DannyS712: [C: 03+2] Create a base interface for watchers [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/642012 (owner: 10Daimona Eaytoy) [02:48:24] (03CR) 10Paladox: "try again" [extensions/BlogPage] (REL1_35) - 10https://gerrit.wikimedia.org/r/642443 (https://phabricator.wikimedia.org/T266156) (owner: 10Paladox) [02:58:36] (03CR) 10DannyS712: The mediawiki.skinning.content.externallinks styles are moved into ResourceLoaderSkinModule (031 comment) [core] - 10https://gerrit.wikimedia.org/r/642493 (https://phabricator.wikimedia.org/T267577) (owner: 10Jdlrobson) [03:08:46] (03Merged) 10jenkins-bot: Create a base interface for watchers [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/642012 (owner: 10Daimona Eaytoy) [03:15:39] (03CR) 10DannyS712: [C: 03+2] StreamConfigs: Fix bad $logger->debug() call [extensions/EventStreamConfig] - 10https://gerrit.wikimedia.org/r/633329 (owner: 10Krinkle) [03:16:16] 10Magnus Sälgö: Project "Stadens ansikte" - https://phabricator.wikimedia.org/T268374 (10Salgo60) [03:23:26] (03CR) 10DannyS712: [C: 03+2] "poke" [extensions/BlogPage] (REL1_35) - 10https://gerrit.wikimedia.org/r/642443 (https://phabricator.wikimedia.org/T266156) (owner: 10Paladox) [03:27:25] (03CR) 10DannyS712: Add ConsequencesLookup (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/634694 (owner: 10Daimona Eaytoy) [03:27:33] (03CR) 10jerkins-bot: [V: 04-1] Fix fatal typo in Special:ArticlesHome [extensions/BlogPage] (REL1_35) - 10https://gerrit.wikimedia.org/r/642443 (https://phabricator.wikimedia.org/T266156) (owner: 10Paladox) [03:28:26] (03CR) 10DannyS712: [C: 03+1] "Failures: "invalidjson: No valid JSON response"" [extensions/BlogPage] (REL1_35) - 10https://gerrit.wikimedia.org/r/642443 (https://phabricator.wikimedia.org/T266156) (owner: 10Paladox) [03:41:19] (03Merged) 10jenkins-bot: StreamConfigs: Fix bad $logger->debug() call [extensions/EventStreamConfig] - 10https://gerrit.wikimedia.org/r/633329 (owner: 10Krinkle) [03:43:21] (03CR) 10DannyS712: "This change is ready for review." [libs/ObjectFactory] - 10https://gerrit.wikimedia.org/r/642445 (https://phabricator.wikimedia.org/T246377) (owner: 10DannyS712) [03:43:45] 10MediaWiki-libs-ServiceContainer, 10ObjectFactory, 10Platform Engineering, 10Patch-For-Review, and 2 others: ObjectFactory needs a way to inject configuration settings into objects. - https://phabricator.wikimedia.org/T246377 (10DannyS712) [03:44:08] (03PS3) 10DannyS712: Allow injecting configuration values [libs/ObjectFactory] - 10https://gerrit.wikimedia.org/r/642445 (https://phabricator.wikimedia.org/T246377) [03:44:10] (03CR) 10jerkins-bot: [V: 04-1] Allow injecting configuration values [libs/ObjectFactory] - 10https://gerrit.wikimedia.org/r/642445 (https://phabricator.wikimedia.org/T246377) (owner: 10DannyS712) [03:55:47] (03CR) 10jerkins-bot: [V: 04-1] build: Updating npm dependencies [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/642727 (owner: 10Libraryupgrader) [04:00:10] 10DynamicPageList (third-party): Permanently move location of dplcache - https://phabricator.wikimedia.org/T268389 (10Peachey88) [04:06:24] 10MediaWiki-Core-Skin-Architecture, 10MediaWiki-Interface, 10MonoBook, 10Timeless, and 2 others: Hard deprecate BaseTemplate::getFooterIcons - https://phabricator.wikimedia.org/T267447 (10Isarra) >>! In T267447#6638443, @Jdlrobson wrote: > BaseTemplate::getFooterIcons is being hard deprecated NOT SkinTemp... [04:13:23] 10MediaWiki-Installer, 10MW-1.35-release: Revisions created while MW 1.35 maintenance/update.php is running risk becoming inaccessible without explanation, rendering articles uneditable - https://phabricator.wikimedia.org/T268387 (10Peachey88) >>! In T268387#6638495, @RhinosF1 wrote: > Doesn't the update guide... [04:17:59] (03PS1) 10Ammarpad: Check extension is loaded before attemptting to get its config value. [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/642734 [04:25:02] (03CR) 10DannyS712: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/642747 (owner: 10DannyS712) [04:26:47] 10MediaWiki-skins-Daddio, 10Diffusion-Repository-Administrators, 10Projects-Cleanup, 10Release-Engineering-Team, and 4 others: Sunset/Archive Daddio skin - https://phabricator.wikimedia.org/T267455 (10Peachey88) [04:27:51] 10MediaWiki-skins-Daddio, 10Diffusion-Repository-Administrators, 10Projects-Cleanup, 10Release-Engineering-Team, and 4 others: Sunset/Archive Daddio skin - https://phabricator.wikimedia.org/T267455 (10Peachey88) I have added the started cleanup/archive checklist to ensure steps aren't missed. [04:31:52] (03CR) 10DannyS712: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/642748 (owner: 10DannyS712) [04:33:39] (03PS4) 10DannyS712: Convert TrackingCategories to a service with DI [core] - 10https://gerrit.wikimedia.org/r/634090 (https://phabricator.wikimedia.org/T247194) [04:35:16] (03PS5) 10DannyS712: Convert TrackingCategories to a service with DI [core] - 10https://gerrit.wikimedia.org/r/634090 (https://phabricator.wikimedia.org/T247194) [04:38:29] (03PS3) 10Universal Omega: Fix article count method Fixes article count method to use SiteStats::articles() instead of pagesInNs(0) [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/642749 [04:42:27] (03CR) 10Ammarpad: [C: 03+2] ApiQueryWatchlist: Include log entry action text [core] - 10https://gerrit.wikimedia.org/r/619608 (https://phabricator.wikimedia.org/T260227) (owner: 10DannyS712) [04:50:06] 10MediaWiki-General, 10Platform Engineering, 10Dependency injection, 10User-DannyS712: Create ActionFactory, add dependency injection to actions - https://phabricator.wikimedia.org/T253078 (10DannyS712) [04:51:17] 10MediaWiki-General, 10Platform Engineering, 10Dependency injection, 10User-DannyS712: Create ActionFactory, add dependency injection to actions - https://phabricator.wikimedia.org/T253078 (10DannyS712) >>! In T253078#6568524, @DannyS712 wrote: > @eprodromou is it okay to move forward with this using Objec... [04:53:41] (03CR) 10DannyS712: "This change is ready for review." [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/642746 (owner: 10DannyS712) [05:07:09] (03PS3) 10Universal Omega: Fix styling bugs This fixes 3 known styling bugs: [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/642750 [05:07:47] (03CR) 10DannyS712: "This change is ready for review." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/642751 (owner: 10DannyS712) [05:09:18] (03PS4) 10Universal Omega: Fix styling bugs [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/642750 [05:09:23] (03Merged) 10jenkins-bot: ApiQueryWatchlist: Include log entry action text [core] - 10https://gerrit.wikimedia.org/r/619608 (https://phabricator.wikimedia.org/T260227) (owner: 10DannyS712) [05:09:54] (03PS5) 10Universal Omega: Fix styling bugs [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/642750 [05:10:21] (03PS6) 10Universal Omega: Fix styling bugs [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/642750 [05:21:16] (03PS7) 10Universal Omega: Fix styling bugs [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/642750 [05:22:05] (03PS8) 10Universal Omega: Fix styling bugs [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/642750 [05:25:00] 10MediaWiki-extensions-GlobalWatchlist, 10I18n, 10User-DannyS712: Use proper messages for log entries - https://phabricator.wikimedia.org/T260220 (10DannyS712) [05:25:02] 10MediaWiki-API, 10Platform Engineering, 10User-DannyS712: Watchlist api: Include log entry action text - https://phabricator.wikimedia.org/T260227 (10DannyS712) 05Open→03Resolved a:03DannyS712 [05:25:25] 10MediaWiki-extensions-GlobalWatchlist, 10I18n, 10User-DannyS712: Use proper messages for log entries - https://phabricator.wikimedia.org/T260220 (10DannyS712) 05Stalled→03Open Ready to go once extension requires 1.36+ [05:25:41] (03PS9) 10Universal Omega: Fix styling bugs [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/642750 [05:30:43] 10Magnus Sälgö: Project "Stadens ansikte" - https://phabricator.wikimedia.org/T268374 (10Salgo60) [05:32:50] 10MediaWiki-Parser: Parser should trim the text of internal links - https://phabricator.wikimedia.org/T268388 (10Nirmos) @Niteshyadav585 https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/parser/Parser.php [05:54:05] (03CR) 10Ammarpad: "There are some minor formatting issues in the json which does not affect the schema, and can be fixed later. Otherwise looks good to me." [core] - 10https://gerrit.wikimedia.org/r/619155 (https://phabricator.wikimedia.org/T230428) (owner: 10Ladsgroup) [05:54:19] (03CR) 10Ammarpad: [C: 03+2] Migrate slot_roles and content_models to abstract schema [core] - 10https://gerrit.wikimedia.org/r/619155 (https://phabricator.wikimedia.org/T230428) (owner: 10Ladsgroup) [05:55:00] (03CR) 10Ammarpad: [C: 04-1] Fix some easy phpcs errors (035 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/642746 (owner: 10DannyS712) [06:11:10] (03CR) 10Ammarpad: [C: 03+2] Improve error messages on Special:Contact [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/621883 (https://phabricator.wikimedia.org/T268360) (owner: 10Umherirrender) [06:16:25] (03Merged) 10jenkins-bot: Migrate slot_roles and content_models to abstract schema [core] - 10https://gerrit.wikimedia.org/r/619155 (https://phabricator.wikimedia.org/T230428) (owner: 10Ladsgroup) [06:20:09] (03Merged) 10jenkins-bot: Improve error messages on Special:Contact [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/621883 (https://phabricator.wikimedia.org/T268360) (owner: 10Umherirrender) [06:29:39] 10MediaWiki-Parser: Parser should trim the text of internal links - https://phabricator.wikimedia.org/T268388 (10Niteshyadav585) @Nirmos Thank you. The code is not modularized enough. 6000+ lines of code in a single Parser.php file. [06:51:46] (03CR) 10DannyS712: Fix some easy phpcs errors (033 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/642746 (owner: 10DannyS712) [06:52:21] (03PS1) 10Ammarpad: Fix formmatting in json of abstract schema [core] - 10https://gerrit.wikimedia.org/r/642772 [06:53:34] (03PS2) 10DannyS712: build: Updating stylelint-config-wikimedia to 0.10.3 [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/642770 (owner: 10Libraryupgrader) [06:53:50] (03CR) 10DannyS712: [C: 04-1] "hmm, lets see what the failures are first" [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/642770 (owner: 10Libraryupgrader) [06:57:27] (03PS3) 10DannyS712: build: Updating stylelint-config-wikimedia to 0.10.3 [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/642770 (owner: 10Libraryupgrader) [06:57:33] 10MediaWiki-Parser: Parser should trim the text of internal links - https://phabricator.wikimedia.org/T268388 (10Aklapper) @Niteshyadav585: Hi and welcome, and thanks for your interest! That might be correct, however we'd [recommend](https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker) general high-l... [06:57:46] (03CR) 10DannyS712: [C: 03+2] "Bot tried to disable a bunch of rules that didn't need to be disabled..." [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/642770 (owner: 10Libraryupgrader) [06:58:24] (03CR) 10DannyS712: [C: 03+1] "switch to +1 given huge changes to package-lock that I'm not sure about" [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/642770 (owner: 10Libraryupgrader) [06:58:31] (03PS2) 10Ammarpad: Fix formatting in json of abstract schema [core] - 10https://gerrit.wikimedia.org/r/642772 [06:59:26] (03CR) 10DannyS712: "LGTM, but actual changes aren't just formatting" [core] - 10https://gerrit.wikimedia.org/r/642772 (owner: 10Ammarpad) [07:03:44] (03PS3) 10Ammarpad: Fix formatting issues and grammar fix in json of abstract schema [core] - 10https://gerrit.wikimedia.org/r/642772 [07:07:31] (03CR) 10Ammarpad: "> Patch Set 2:" [core] - 10https://gerrit.wikimedia.org/r/642772 (owner: 10Ammarpad) [07:07:54] (03PS4) 10Ammarpad: Fix formatting issues and grammar in json of abstract schema [core] - 10https://gerrit.wikimedia.org/r/642772 [07:15:03] (03CR) 10jerkins-bot: [V: 04-1] build: Updating npm dependencies [extensions/OnlineStatusBar] - 10https://gerrit.wikimedia.org/r/642777 (owner: 10Libraryupgrader) [07:15:36] 10Magnus Sälgö: Arkitekter verksamma i Sverige (Arkitektur- och designcentrum) - https://phabricator.wikimedia.org/T268375 (10Salgo60) * [[ https://gist.github.com/salgo60/4aafb7f5d8cf47ff85536d8d3d0c7d32 | GIST ]] hitta arkitekter med kulturnav men utan katalog * batch [[ https://quickstatements.toolforge.or... [07:23:45] 10ContentTranslation: The Special:ContentTranslation sometimes a bug occurs - https://phabricator.wikimedia.org/T268070 (10Aklapper) @Juan90264: How to "Get out quickly"? Can you be moer specific please and cover step by step, click by click, as a list? Which web browser is used and which version? Thanks! [07:35:52] (03CR) 10DannyS712: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/642752 (owner: 10DannyS712) [07:42:40] 10Diff-blog, 10Wikimedia-GitHub: Create public repo on Github for Interconnection WordPress theme - https://phabricator.wikimedia.org/T267612 (10Aklapper) [07:48:01] (03CR) 10DannyS712: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/642753 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [07:58:52] (03CR) 10DannyS712: [C: 03+2] Fix formatting issues and grammar in json of abstract schema [core] - 10https://gerrit.wikimedia.org/r/642772 (owner: 10Ammarpad) [08:02:07] (03CR) 10jerkins-bot: [V: 04-1] ResourceLoaderSkinModule: minor readability cleanup [core] - 10https://gerrit.wikimedia.org/r/642752 (owner: 10DannyS712) [08:10:22] (03PS3) 10DannyS712: ResourceLoaderSkinModule: minor readability cleanup [core] - 10https://gerrit.wikimedia.org/r/642752 [08:12:46] (03PS17) 10DannyS712: Add redirects for modules [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/574086 (https://phabricator.wikimedia.org/T120794) [08:25:35] (03CR) 10DannyS712: "This change is ready for review." [extensions/GlobalWatchlist] - 10https://gerrit.wikimedia.org/r/642754 (https://phabricator.wikimedia.org/T259098) (owner: 10DannyS712) [08:27:10] (03Merged) 10jenkins-bot: Fix formatting issues and grammar in json of abstract schema [core] - 10https://gerrit.wikimedia.org/r/642772 (owner: 10Ammarpad) [08:27:13] (03CR) 10jerkins-bot: [V: 04-1] build: Updating npm dependencies [extensions/PreferencesList] - 10https://gerrit.wikimedia.org/r/642786 (owner: 10Libraryupgrader) [08:33:35] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Fix a typo: parametrized -> parameterized [core] - 10https://gerrit.wikimedia.org/r/642753 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [08:36:13] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "I like it! Just one typo." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/642752 (owner: 10DannyS712) [08:38:41] (03PS3) 10Thiemo Kreuz (WMDE): PrevNextNavigationRenderer: readability cleanup [core] - 10https://gerrit.wikimedia.org/r/642747 (owner: 10DannyS712) [08:41:28] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "As far as I know the formatting" [core] - 10https://gerrit.wikimedia.org/r/642747 (owner: 10DannyS712) [09:00:17] (03Merged) 10jenkins-bot: Fix a typo: parametrized -> parameterized [core] - 10https://gerrit.wikimedia.org/r/642753 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [09:06:01] (03CR) 10Meno25: "One line change. Won't take time to review. Thanks in advance" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/642755 (owner: 10Meno25) [09:14:50] (03CR) 10jerkins-bot: [V: 04-1] build: Updating npm dependencies [extensions/RandomGameUnit] - 10https://gerrit.wikimedia.org/r/642794 (owner: 10Libraryupgrader) [09:33:52] 10Magnus Sälgö-Riksarkivet-NAD: Feature request: URL to the archive with NAD number as argument that always work - https://phabricator.wikimedia.org/T200046 (10Salgo60) Dubletter * SE/ULA/12894 * [[ https://sok.riksarkivet.se/agent/PCP8fGYTX42Z06olsAuNI3 | Gyllenborg, Carl David (greve, kommerseråd) (1734 – 1... [09:52:45] (03CR) 10Jack Phoenix: [C: 03+2] "Unrelated CI failure is unrelated, it's got to do with the upload special pages (in PollNY/PictureGame/QuizGame) being broken under 1.36+ " [extensions/RandomGameUnit] - 10https://gerrit.wikimedia.org/r/642794 (owner: 10Libraryupgrader) [09:52:57] (03CR) 10Jack Phoenix: [V: 03+2 C: 03+2] build: Updating npm dependencies [extensions/RandomGameUnit] - 10https://gerrit.wikimedia.org/r/642794 (owner: 10Libraryupgrader) [09:57:15] 10AbuseFilter: AbuseFilter doesn't highlight the match cases at abuse log - https://phabricator.wikimedia.org/T72152 (10matej_suchanek) > Some kind of mechanism for allowing variables in filter messages Something like T174554? [10:00:27] (03CR) 10Jack Phoenix: "LGTM, one potential improvement suggestion/question inline; but I'm happy to +2 this as-is, too." (031 comment) [extensions/GlobalWatchlist] - 10https://gerrit.wikimedia.org/r/642754 (https://phabricator.wikimedia.org/T259098) (owner: 10DannyS712) [10:21:33] 10Wikibase Release Strategy: Define the process of documenting significant changes in Wikibase and related software to be published with the release - https://phabricator.wikimedia.org/T267734 (10WMDE-leszek) [10:21:35] 10Wikibase Release Strategy (Sprint 1): Investigate how to generate release notes - https://phabricator.wikimedia.org/T268026 (10WMDE-leszek) [10:25:46] 10Dumps-Generation: New dump run paused; Wikidata xml/sql dump page meta history dumps incomplete - https://phabricator.wikimedia.org/T268333 (10ArielGlenn) The 7z file is still being written. If all goes well it should finish up today. [10:28:00] (03PS2) 10Jack Phoenix: Drop unused copy-paste method LinkPage::setContent(), which uses many deprecated Article methods. [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/640966 (owner: 10Cicalese) [11:20:40] (03PS1) 10Daimona Eaytoy: [DNM] Test taint-check [tools/phan] (stable-0.10) - 10https://gerrit.wikimedia.org/r/642815 [11:24:10] (03PS46) 10Daimona Eaytoy: Represent Consequences with command objects [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/633380 [11:26:19] (03CR) 10Daimona Eaytoy: [V: 03+2 C: 03+2] "Master is known to be broken, but phan is passing here." [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/642341 (owner: 10Libraryupgrader) [11:26:52] (03PS2) 10Daimona Eaytoy: build: Updating mediawiki/mediawiki-phan-config to 0.10.4 [extensions/SkinPerPage] - 10https://gerrit.wikimedia.org/r/642490 (owner: 10Libraryupgrader) [11:27:48] (03CR) 10Daimona Eaytoy: "Will need a manual merge anyway, master is broken..." [extensions/SkinPerPage] - 10https://gerrit.wikimedia.org/r/642490 (owner: 10Libraryupgrader) [11:28:47] (03PS10) 10Daimona Eaytoy: Add ConsequencesLookup [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/634694 [11:32:50] (03PS11) 10Daimona Eaytoy: Add ConsequencesLookup [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/634694 [11:33:30] (03PS12) 10Daimona Eaytoy: Add ConsequencesLookup [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/634694 [11:33:34] (03CR) 10Daimona Eaytoy: Add ConsequencesLookup (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/634694 (owner: 10Daimona Eaytoy) [11:36:56] 10Wikibase Release Strategy (Sprint 1): Investigate how to generate release notes - https://phabricator.wikimedia.org/T268026 (10WMDE-leszek) I note this ticket is related to T267734, which was not included in the sprint. Added it as a parent task. I admit not knowing all the context and thoughts that lead to t... [11:44:29] 10Wikibase Release Strategy (Sprint 1): Determine the set of tests that ensure correct functionality of the Wikibase and related software that is to be released - https://phabricator.wikimedia.org/T267743 (10WMDE-leszek) what's the subject to review? Is the list of those tests somewhere on github? I couldn't fin... [11:45:18] (03PS1) 10Amire80: Add Hebrew special page alias [extensions/GlobalWatchlist] - 10https://gerrit.wikimedia.org/r/642820 [11:51:11] (03Abandoned) 10Daimona Eaytoy: [DNM] Test taint-check [tools/phan] (stable-0.10) - 10https://gerrit.wikimedia.org/r/642815 (owner: 10Daimona Eaytoy) [11:54:27] (03PS1) 10Daimona Eaytoy: Do not require the composer autoload file manually [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/642822 [11:59:09] 10Wikibase Release Strategy: ["EPIC"] Create a "release pipeline" for Wikibase and releated software - https://phabricator.wikimedia.org/T267710 (10WMDE-leszek) [11:59:37] 10Wikibase Release Strategy: ["EPIC"] Create a "release pipeline" for Wikibase and releated software - https://phabricator.wikimedia.org/T267710 (10WMDE-leszek) [11:59:39] 10Wikibase Release Strategy (Sprint 1): Add SPARQL Query Service and related software to Wikibase "release pipeline" - https://phabricator.wikimedia.org/T267713 (10WMDE-leszek) [11:59:56] 10Wikibase Release Strategy: Add ElasticSearch (for Wikibase search) and related software to Wikibase "release pipeline" - https://phabricator.wikimedia.org/T267711 (10WMDE-leszek) [11:59:58] 10Wikibase Release Strategy: ["EPIC"] Create a "release pipeline" for Wikibase and releated software - https://phabricator.wikimedia.org/T267710 (10WMDE-leszek) [12:12:12] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.10.4 [extensions/SkinPerPage] - 10https://gerrit.wikimedia.org/r/642490 (owner: 10Libraryupgrader) [12:17:51] (03PS1) 10Raimond Spekking: Fix missing bracket [extensions/cldr] - 10https://gerrit.wikimedia.org/r/642827 (https://phabricator.wikimedia.org/T267265) [12:27:32] 10Wikibase Release Strategy: Decide on the infrastructure related to Wikibase Release process - https://phabricator.wikimedia.org/T268401 (10WMDE-leszek) [12:28:00] 10Wikibase Release Strategy: Decide on the infrastructure related to Wikibase Release process - https://phabricator.wikimedia.org/T268401 (10WMDE-leszek) [12:28:02] 10Wikibase Release Strategy (Sprint 1): Investigate where we should host the finally built tarballs - https://phabricator.wikimedia.org/T268024 (10WMDE-leszek) [12:28:04] 10Wikibase Release Strategy (Sprint 1): Investigate which docker repositories we should publish images to - https://phabricator.wikimedia.org/T268023 (10WMDE-leszek) [12:30:21] (03PS9) 10Daimona Eaytoy: Improve and simplify nodeIs* methods [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/607079 [12:31:25] (03PS18) 10Daimona Eaytoy: Improve handling of binary ops, extract method [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/607042 [12:31:38] (03PS2) 10Daimona Eaytoy: Upgrade phan to 3.2.4 [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/642684 (https://phabricator.wikimedia.org/T250170) [12:31:50] (03CR) 10Daimona Eaytoy: "Created a single relation chain" [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/642684 (https://phabricator.wikimedia.org/T250170) (owner: 10Daimona Eaytoy) [12:34:10] (03PS3) 10Daimona Eaytoy: Add some important changes to the changelog [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/642646 [12:37:29] (03PS4) 10Daimona Eaytoy: Preparation for the 3.1.0 release [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/642646 [12:37:48] (03Abandoned) 10Daimona Eaytoy: Upgrade phan to 3.2.4 [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/642684 (https://phabricator.wikimedia.org/T250170) (owner: 10Daimona Eaytoy) [12:38:13] (03PS5) 10Daimona Eaytoy: Preparation for the 3.1.0 release [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/642646 (https://phabricator.wikimedia.org/T250170) [12:53:08] 10Wikibase Release Strategy: Decide on what infrastructure to run the initial Wikibase release pipeline - https://phabricator.wikimedia.org/T268402 (10WMDE-leszek) [12:53:31] 10Wikibase Release Strategy: Decide on what infrastructure to run the initial Wikibase release pipeline - https://phabricator.wikimedia.org/T268402 (10WMDE-leszek) [12:53:33] 10Wikibase Release Strategy: Decide on the infrastructure related to Wikibase Release process - https://phabricator.wikimedia.org/T268401 (10WMDE-leszek) [12:54:55] 10importbots: Privacy | History of edits | Wikipedia | Suggestion for all languages - https://phabricator.wikimedia.org/T268403 (10WikiBook10) [12:57:49] 10The-Wikipedia-Library: Suggestion for adding more commands in README - https://phabricator.wikimedia.org/T268404 (10lalit97) [12:58:41] 10importbots: Privacy | History of edits | Wikipedia | Suggestion for all languages - https://phabricator.wikimedia.org/T268403 (10WikiBook10) {F33922067} [13:00:12] 04(no projects): Privacy | History of edits | Wikipedia | Suggestion for all languages - https://phabricator.wikimedia.org/T268403 (10Aklapper) 05Open→03Stalled Hi @WikiBook10, thanks for taking the time to report this and welcome to Wikimedia Phabricator! This looks unrelated to #importbots. Unfortunately... [13:00:15] 10MediaWiki-Uploading, 10User-RhinosF1: gpx file format missing from MimeMap - https://phabricator.wikimedia.org/T268405 (10RhinosF1) [13:00:40] 10MediaWiki-Uploading, 10User-RhinosF1: gpx file format missing from MimeMap - https://phabricator.wikimedia.org/T268405 (10RhinosF1) I might end up doing this later but anyone feel free to [13:01:56] 04(no projects): Privacy | History of edits | Wikipedia | Suggestion for all languages - https://phabricator.wikimedia.org/T268403 (10Aklapper) 05Stalled→03Declined Ah, I think I understand now. Privacy is not increased by obscurity so I'm boldly declining this. I don't understand what the problem is to se... [13:02:48] 10MediaWiki-Uploading, 10User-RhinosF1: Add GPS Exchange Format (gpx) file format to the MimeMap - https://phabricator.wikimedia.org/T268405 (10Peachey88) [13:02:55] 04(no projects): Privacy | History of edits | Wikipedia | Suggestion for all languages - https://phabricator.wikimedia.org/T268403 (10Aklapper) >>! In T268403#6638859, @WikiBook10 wrote: > {F33922067} It explains how long an article has not been edited. Let's not remove that history box without any good reason... [13:07:33] 04(no projects): Privacy | History of edits | Wikipedia | Suggestion for all languages - https://phabricator.wikimedia.org/T268403 (10WikiBook10) For privacy of who edit [13:07:57] 10MediaWiki-File-management, 10MediaWiki-Uploading, 10Commons: Add support for AVIF: allow uploading AVIF files in MediaWiki by default - https://phabricator.wikimedia.org/T257718 (10Peachey88) [13:09:02] 04(no projects): Privacy | History of edits | Wikipedia | Suggestion for all languages - https://phabricator.wikimedia.org/T268403 (10WikiBook10) Please leave it registered in the system for future acceptances. Thanks! [13:10:15] 10MediaWiki-Uploading, 10User-RhinosF1: Add GPS Exchange Format (gpx) file format to the MimeMap - https://phabricator.wikimedia.org/T268405 (10Peachey88) [13:10:49] 10MediaWiki-Uploading: Support for GPS eXchange Format (GPX) - https://phabricator.wikimedia.org/T55023 (10Peachey88) [13:10:57] 10MediaWiki-Uploading: Support for GPS eXchange Format (GPX) - https://phabricator.wikimedia.org/T55023 (10Peachey88) [13:12:48] (03CR) 10jerkins-bot: [V: 04-1] build: Updating npm dependencies [extensions/WikEdDiff] - 10https://gerrit.wikimedia.org/r/642835 (owner: 10Libraryupgrader) [13:18:42] 10MediaWiki-extensions-Other, 10ci-test-error: [PreferencesList] Broken code in includes/specials/SpecialPreferencesList.php - https://phabricator.wikimedia.org/T224937 (10Kizule) Yes, this is still happening. ` 2020-11-22 13:14:25 fw-cpanel01.fyfeweb.com kizuletk_wiki2-mw: [b4dec446c963b266700916f6] /index.ph... [13:37:26] 10The-Wikipedia-Library: Suggestion for adding more commands in README - https://phabricator.wikimedia.org/T268404 (10Yash4357) Can I work on this issue? [13:42:22] (03CR) 10Jack Phoenix: [C: 03+2] Drop unused copy-paste method LinkPage::setContent(), which uses many deprecated Article methods. [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/640966 (owner: 10Cicalese) [13:44:52] (03CR) 10Florianschmidtwelzow: Mention new required php extension intl (032 comments) [core] - 10https://gerrit.wikimedia.org/r/640474 (https://phabricator.wikimedia.org/T267669) (owner: 10Florianschmidtwelzow) [13:45:19] (03PS5) 10Florianschmidtwelzow: Mention new required php extension intl [core] - 10https://gerrit.wikimedia.org/r/640474 (https://phabricator.wikimedia.org/T267669) [13:45:56] (03Merged) 10jenkins-bot: Drop unused copy-paste method LinkPage::setContent(), which uses many deprecated Article methods. [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/640966 (owner: 10Cicalese) [13:47:58] (03PS1) 10Raimond Spekking: Add German translation [extensions/cldr] - 10https://gerrit.wikimedia.org/r/642842 [13:49:28] (03CR) 10jerkins-bot: [V: 04-1] Mention new required php extension intl [core] - 10https://gerrit.wikimedia.org/r/640474 (https://phabricator.wikimedia.org/T267669) (owner: 10Florianschmidtwelzow) [13:53:05] (03CR) 10RhinosF1: [C: 03+1] Include MIME support for .gpx filetype [core] - 10https://gerrit.wikimedia.org/r/642756 (https://phabricator.wikimedia.org/T55023) (owner: 10Reception123) [13:57:23] (03CR) 10Thiemo Kreuz (WMDE): "1. The discussion about "null" is, as far as I can see, correct. Personally I would add the `…|null`." (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/642746 (owner: 10DannyS712) [13:59:01] (03PS5) 10DannyS712: Fix some easy phpcs errors [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/642746 [14:00:43] (03CR) 10DannyS712: WikibaseHandler: localize parentheses (031 comment) [extensions/GlobalWatchlist] - 10https://gerrit.wikimedia.org/r/642754 (https://phabricator.wikimedia.org/T259098) (owner: 10DannyS712) [14:01:20] (03CR) 10DannyS712: [C: 03+2] Add Hebrew special page alias [extensions/GlobalWatchlist] - 10https://gerrit.wikimedia.org/r/642820 (owner: 10Amire80) [14:01:25] (03CR) 10Thiemo Kreuz (WMDE): WikibaseHandler: localize parentheses (031 comment) [extensions/GlobalWatchlist] - 10https://gerrit.wikimedia.org/r/642754 (https://phabricator.wikimedia.org/T259098) (owner: 10DannyS712) [14:02:57] (03CR) 10jerkins-bot: [V: 04-1] Include MIME support for .gpx filetype [core] - 10https://gerrit.wikimedia.org/r/642756 (https://phabricator.wikimedia.org/T55023) (owner: 10Reception123) [14:03:13] (03CR) 10DannyS712: "> Patch Set 3: Code-Review+1" [core] - 10https://gerrit.wikimedia.org/r/642747 (owner: 10DannyS712) [14:03:16] (03PS4) 10DannyS712: PrevNextNavigationRenderer: readability cleanup [core] - 10https://gerrit.wikimedia.org/r/642747 [14:03:19] (03CR) 10DannyS712: [C: 03+2] PrevNextNavigationRenderer: readability cleanup [core] - 10https://gerrit.wikimedia.org/r/642747 (owner: 10DannyS712) [14:04:42] (03PS4) 10DannyS712: ResourceLoaderSkinModule: minor readability cleanup [core] - 10https://gerrit.wikimedia.org/r/642752 [14:04:44] (03CR) 10DannyS712: ResourceLoaderSkinModule: minor readability cleanup (031 comment) [core] - 10https://gerrit.wikimedia.org/r/642752 (owner: 10DannyS712) [14:07:33] 10Phabricator: Document account requirements to edit Phabricator projects (maybe that's #Trusted-Contributors now? Or also #WMF-NDA?) - https://phabricator.wikimedia.org/T268001 (10Aklapper) [14:11:26] (03CR) 10DannyS712: [C: 03+2] build: Updating npm dependencies [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/642818 (owner: 10Libraryupgrader) [14:12:19] (03Merged) 10jenkins-bot: Add Hebrew special page alias [extensions/GlobalWatchlist] - 10https://gerrit.wikimedia.org/r/642820 (owner: 10Amire80) [14:12:49] (03PS2) 10DannyS712: build: Updating npm dependencies [extensions/TextScroller] - 10https://gerrit.wikimedia.org/r/642813 (owner: 10Libraryupgrader) [14:12:52] (03CR) 10DannyS712: [C: 03+2] build: Updating npm dependencies [extensions/TextScroller] - 10https://gerrit.wikimedia.org/r/642813 (owner: 10Libraryupgrader) [14:12:54] (03PS3) 10Reception123: Include MIME support for .gpx filetype [core] - 10https://gerrit.wikimedia.org/r/642756 (https://phabricator.wikimedia.org/T55023) [14:13:06] (03PS2) 10DannyS712: build: Updating npm dependencies [extensions/PagesList] - 10https://gerrit.wikimedia.org/r/642781 (owner: 10Libraryupgrader) [14:13:09] (03CR) 10DannyS712: [C: 03+2] build: Updating npm dependencies [extensions/PagesList] - 10https://gerrit.wikimedia.org/r/642781 (owner: 10Libraryupgrader) [14:18:09] (03CR) 10Florianschmidtwelzow: "I kind of don't like the breaking change, that one would need to enable SiteNotices in Minerva with a config, in order to get the CookieWa" (032 comments) [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/631814 (https://phabricator.wikimedia.org/T254302) (owner: 10Paladox) [14:18:12] (03CR) 10DannyS712: "This change is ready for review." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/642761 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [14:18:41] (03CR) 10DannyS712: "This change is ready for review." [extensions/EtherpadLite] - 10https://gerrit.wikimedia.org/r/642762 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [14:22:39] (03CR) 10DannyS712: "This change is ready for review." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/642764 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [14:23:12] (03CR) 10DannyS712: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/642765 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [14:26:41] (03Merged) 10jenkins-bot: PrevNextNavigationRenderer: readability cleanup [core] - 10https://gerrit.wikimedia.org/r/642747 (owner: 10DannyS712) [14:30:58] (03CR) 10DannyS712: [C: 03+1] "restore +1" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/633380 (owner: 10Daimona Eaytoy) [14:32:38] (03CR) 10DannyS712: [C: 03+1] Add ConsequencesLookup [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/634694 (owner: 10Daimona Eaytoy) [14:34:55] 10DiscussionTools: Never insert a reply in the middle of a line - https://phabricator.wikimedia.org/T268407 (10Alsee) [14:36:16] (03PS18) 10Florianschmidtwelzow: Replace deprecated hook [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/631814 (https://phabricator.wikimedia.org/T254302) (owner: 10Paladox) [14:39:30] (03PS19) 10Florianschmidtwelzow: Replace deprecated hook [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/631814 (https://phabricator.wikimedia.org/T254302) (owner: 10Paladox) [14:40:45] (03CR) 10DannyS712: SaveSpinner: Initial commit with basic functionalities (0312 comments) [extensions/SaveSpinner] - 10https://gerrit.wikimedia.org/r/492396 (owner: 10Tosfos) [14:42:09] (03CR) 10Florianschmidtwelzow: "> Patch Set 17:" [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/631814 (https://phabricator.wikimedia.org/T254302) (owner: 10Paladox) [14:44:37] 10MediaWiki-extensions-CookieWarning: Cookie Warning does not appear in MediaWiki 1.35 and Vector skin - https://phabricator.wikimedia.org/T267436 (10Florian) Yep, this is a duplicate of {T254302}. [14:44:57] 10MediaWiki-extensions-CookieWarning: Cookie Warning does not appear in MediaWiki 1.35 and Vector skin - https://phabricator.wikimedia.org/T267436 (10Florian) [14:45:06] 10MediaWiki-extensions-CookieWarning, 10Patch-For-Review: Update CookieWarning so it doesn't use the SkinTemplateOutputPageBeforeExec hook - https://phabricator.wikimedia.org/T254302 (10Florian) [14:46:57] 10MediaWiki-extensions-CookieWarning, 10MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), 10Technical-Debt: Don't use internal FallbackTemplate inside code - https://phabricator.wikimedia.org/T254525 (10Florian) 05Open→03Resolved a:03Florian CookieWarning doesn't use FallbackTemplate from what I can see. [14:46:59] 10MediaWiki-Core-Skin-Architecture, 10MW-1.35-notes (1.35.0-wmf.37; 2020-06-16): Render the FallbackSkin and SkinApi with a simplistic SkinMustache class - https://phabricator.wikimedia.org/T254048 (10Florian) [14:48:27] (03CR) 10jerkins-bot: [V: 04-1] Replace deprecated hook [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/631814 (https://phabricator.wikimedia.org/T254302) (owner: 10Paladox) [14:53:06] (03CR) 10DannyS712: Refine taintedness based on real type of variables (031 comment) [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/606816 (https://phabricator.wikimedia.org/T255935) (owner: 10Daimona Eaytoy) [15:03:55] (03PS9) 10D3r1ck01: API modules support [extensions/GroupWhitelist] - 10https://gerrit.wikimedia.org/r/587582 (owner: 10Vedmaka Wakalaka) [15:04:20] (03CR) 10D3r1ck01: API modules support (031 comment) [extensions/GroupWhitelist] - 10https://gerrit.wikimedia.org/r/587582 (owner: 10Vedmaka Wakalaka) [15:04:40] (03PS10) 10D3r1ck01: API modules support [extensions/GroupWhitelist] - 10https://gerrit.wikimedia.org/r/587582 (owner: 10Vedmaka Wakalaka) [15:13:10] (03CR) 10Daimona Eaytoy: Refine taintedness based on real type of variables (031 comment) [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/606816 (https://phabricator.wikimedia.org/T255935) (owner: 10Daimona Eaytoy) [15:13:26] (03PS26) 10Daimona Eaytoy: Refine taintedness based on real type of variables [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/606816 (https://phabricator.wikimedia.org/T255935) [15:14:06] (03CR) 10DannyS712: Refine taintedness based on real type of variables (031 comment) [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/606816 (https://phabricator.wikimedia.org/T255935) (owner: 10Daimona Eaytoy) [15:22:22] (03CR) 10Jack Phoenix: [C: 03+2] Fix a typo: emtpy -> empty [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/642761 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [15:23:11] (03CR) 10Jack Phoenix: [C: 03+2] "Looks like the extension could use quite a bit of love in general...but this patch is just fine and does exactly what it says on the tin." [extensions/EtherpadLite] - 10https://gerrit.wikimedia.org/r/642762 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [15:27:07] (03CR) 10Jack Phoenix: [C: 03+2] Fix a typo: emtpy -> empty [core] - 10https://gerrit.wikimedia.org/r/642765 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [15:27:17] (03CR) 10Jack Phoenix: [C: 03+2] Fix a typo: emtpy -> empty [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/642764 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [15:27:33] (03PS1) 10Jack Phoenix: Fix a typo: emtpy -> empty [extensions/ExtJSBase] - 10https://gerrit.wikimedia.org/r/642873 (https://phabricator.wikimedia.org/T201491) [15:29:45] (03CR) 10DannyS712: [C: 03+2] Fix a typo: emtpy -> empty [extensions/ExtJSBase] - 10https://gerrit.wikimedia.org/r/642873 (https://phabricator.wikimedia.org/T201491) (owner: 10Jack Phoenix) [15:30:29] (03PS6) 10Florianschmidtwelzow: Mention new required php extension intl [core] - 10https://gerrit.wikimedia.org/r/640474 (https://phabricator.wikimedia.org/T267669) [15:35:12] (03PS1) 10Jack Phoenix: JS fix: don't submit the form if submitLink() threw an error to the user [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/642874 [15:35:57] 10DiscussionTools: Never insert a reply in the middle of a line - https://phabricator.wikimedia.org/T268407 (10DannyS712) [15:40:54] (03CR) 10Jack Phoenix: "The change itself is obviously fine, but note that as per https://www.mediawiki.org/wiki/Social_tools/MediaWiki_compatibility the release " [extensions/BlogPage] (REL1_35) - 10https://gerrit.wikimedia.org/r/642443 (https://phabricator.wikimedia.org/T266156) (owner: 10Paladox) [15:42:16] (03Merged) 10jenkins-bot: Fix a typo: emtpy -> empty [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/642761 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [15:42:18] (03Merged) 10jenkins-bot: Fix a typo: emtpy -> empty [extensions/EtherpadLite] - 10https://gerrit.wikimedia.org/r/642762 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [15:45:12] (03CR) 10DannyS712: Replace a bunch of global objects with RequestContext (kinda anyway) (032 comments) [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/641205 (https://phabricator.wikimedia.org/T247793) (owner: 10Jack Phoenix) [15:48:56] (03PS20) 10Paladox: Replace deprecated hook [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/631814 (https://phabricator.wikimedia.org/T254302) [15:48:59] (03PS21) 10Paladox: Replace deprecated hook [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/631814 (https://phabricator.wikimedia.org/T254302) [15:49:05] (03PS54) 10Paladox: Add support for using geoip2 [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/435689 (https://phabricator.wikimedia.org/T195695) [15:49:37] (03PS2) 10Jack Phoenix: Replace a bunch of global objects with RequestContext (kinda anyway) [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/641205 (https://phabricator.wikimedia.org/T247793) [15:52:02] (03CR) 10Jack Phoenix: "@DannyS712: Nice lil' perf catch! Fixed in PS2. (and re:camelCase renames -- I agree, but I remembered about that after pushing this patch" [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/641205 (https://phabricator.wikimedia.org/T247793) (owner: 10Jack Phoenix) [15:52:32] (03CR) 10jerkins-bot: [V: 04-1] Mention new required php extension intl [core] - 10https://gerrit.wikimedia.org/r/640474 (https://phabricator.wikimedia.org/T267669) (owner: 10Florianschmidtwelzow) [15:56:13] (03Merged) 10jenkins-bot: Fix a typo: emtpy -> empty [core] - 10https://gerrit.wikimedia.org/r/642765 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [15:56:41] (03Merged) 10jenkins-bot: Fix a typo: emtpy -> empty [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/642764 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [15:56:43] (03Merged) 10jenkins-bot: Fix a typo: emtpy -> empty [extensions/ExtJSBase] - 10https://gerrit.wikimedia.org/r/642873 (https://phabricator.wikimedia.org/T201491) (owner: 10Jack Phoenix) [15:57:04] 10MediaWiki-Installer, 10MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), 10MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), 10Patch-For-Review, and 3 others: Migrate tables.sql to abstract schema - https://phabricator.wikimedia.org/T230428 (10Ladsgroup) [15:59:00] (03CR) 10Jack Phoenix: "Noting down some things from yesterday's debugging session with Ostrzyciel..." [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/640072 (https://phabricator.wikimedia.org/T266864) (owner: 10Jack Phoenix) [16:04:29] (03CR) 10Esanders: "Does it matter? We are using an identical check in the same execution cycle (onPageRenderingHash is called from the parser), so we will al" [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/641837 (https://phabricator.wikimedia.org/T267404) (owner: 10Esanders) [16:09:51] 10MediaWiki-extensions-Other, 10ci-test-error: [PreferencesList] Broken code in includes/specials/SpecialPreferencesList.php - https://phabricator.wikimedia.org/T224937 (10tosfos) a:03Pastakhov [16:10:11] 10MediaWiki-extensions-Other, 10ci-test-error: [PreferencesList] Broken code in includes/specials/SpecialPreferencesList.php - https://phabricator.wikimedia.org/T224937 (10tosfos) We're going to give this a rewrite. [16:13:05] (03CR) 10Esanders: Store reply links in the parser cache (031 comment) [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/641837 (https://phabricator.wikimedia.org/T267404) (owner: 10Esanders) [16:13:33] (03CR) 10Paladox: [C: 03+1] "Works for me." [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/631814 (https://phabricator.wikimedia.org/T254302) (owner: 10Paladox) [16:14:15] 10MediaWiki-Parser, 10Parsoid: Parser should trim the text of internal links - https://phabricator.wikimedia.org/T268388 (10ssastry) [16:17:56] 10MediaWiki-extensions-Page_Forms: PageForms - https://phabricator.wikimedia.org/T268409 (10Platinops) [16:25:19] 10MediaWiki-extensions-Page_Forms: PageForms - https://phabricator.wikimedia.org/T268409 (10Aklapper) @Platinops: Thanks for taking a look at the code! You are very welcome to use [[ https://www.mediawiki.org/wiki/Developer_access | developer access ]] to submit the proposed code changes as a [[ https://www.me... [16:40:54] 10MediaWiki-Interface: Disabling logo should not generate 404 requests - https://phabricator.wikimedia.org/T5677 (10Nikerabbit) I think it would be nice for the users to be able to disable the logo rather than watch the ugly default logo if there just isn't any real logo available. [16:42:23] (03CR) 10Reedy: [C: 03+2] Fix trailing ; in patch-sites-site_language-35.sql [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/642434 (owner: 10Reedy) [16:45:03] 10TimedMediaHandler-Transcode: Add support for AV1 as an ingestion and transcoding target format - https://phabricator.wikimedia.org/T209440 (10Aklapper) 05Stalled→03Open [AV1 exists](https://en.wikipedia.org/wiki/AV1#Adoption), hence resetting task status. [16:45:05] 10TimedMediaHandler-Transcode: Migrate primary Wikimedia video format from VP9 to AV1 - https://phabricator.wikimedia.org/T209437 (10Aklapper) [16:50:10] (03CR) 10Reedy: [C: 04-1] "Can't bump the PHP version due to WMF prod. REL1_35 has 7.3 purposely." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/640474 (https://phabricator.wikimedia.org/T267669) (owner: 10Florianschmidtwelzow) [16:51:15] (03CR) 10Jforrester: [C: 03+2] build: Updating stylelint-config-wikimedia to 0.10.3 [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/642770 (owner: 10Libraryupgrader) [16:51:38] (03PS2) 10Jforrester: build: Updating npm dependencies [extensions/Tabber] - 10https://gerrit.wikimedia.org/r/642808 (owner: 10Libraryupgrader) [16:51:47] (03CR) 10Jforrester: [C: 03+2] build: Updating npm dependencies [extensions/Tabber] - 10https://gerrit.wikimedia.org/r/642808 (owner: 10Libraryupgrader) [16:52:21] (03CR) 10Jforrester: [C: 03+2] build: Updating npm dependencies [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/642699 (owner: 10Libraryupgrader) [16:52:49] (03PS2) 10Jforrester: build: Updating npm dependencies [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/642875 (owner: 10Libraryupgrader) [16:52:57] (03CR) 10Jforrester: [C: 03+2] build: Updating npm dependencies [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/642875 (owner: 10Libraryupgrader) [16:53:05] (03Merged) 10jenkins-bot: Fix trailing ; in patch-sites-site_language-35.sql [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/642434 (owner: 10Reedy) [16:54:46] 10MediaWiki-Uploading: Allow to add categories from a dropdown in Special:Upload - https://phabricator.wikimedia.org/T7234 (10Bertvandepoel) It seems that some of the details for this feature request have changed. Currently, this option is already available for the UploadDialog in both the classic wikieditor and... [16:54:58] (03PS2) 10Jforrester: build: Updating npm dependencies [extensions/examples] - 10https://gerrit.wikimedia.org/r/642879 (owner: 10Libraryupgrader) [16:55:17] (03CR) 10Jforrester: [C: 03+2] build: Updating npm dependencies [extensions/examples] - 10https://gerrit.wikimedia.org/r/642879 (owner: 10Libraryupgrader) [16:55:51] (03PS2) 10Jforrester: build: Updating npm dependencies [skins/Amethyst] - 10https://gerrit.wikimedia.org/r/642882 (owner: 10Libraryupgrader) [16:55:57] (03CR) 10Jforrester: [C: 03+2] build: Updating npm dependencies [skins/Amethyst] - 10https://gerrit.wikimedia.org/r/642882 (owner: 10Libraryupgrader) [16:57:07] (03PS2) 10Jforrester: build: Updating npm dependencies [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/642884 (owner: 10Libraryupgrader) [16:57:19] (03CR) 10Jforrester: [C: 03+2] build: Updating npm dependencies [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/642884 (owner: 10Libraryupgrader) [16:57:44] 10Wikibase Release Strategy: Decide on the infrastructure related to Wikibase Release process - https://phabricator.wikimedia.org/T268401 (10WMDE-leszek) [16:57:45] (03PS2) 10Jforrester: build: Updating npm dependencies [skins/DeskMessMirrored] - 10https://gerrit.wikimedia.org/r/642885 (owner: 10Libraryupgrader) [16:57:49] (03CR) 10Jforrester: [C: 03+2] build: Updating npm dependencies [skins/DeskMessMirrored] - 10https://gerrit.wikimedia.org/r/642885 (owner: 10Libraryupgrader) [17:09:39] (03PS1) 10Gerrit maintenance bot: Add messages for Saraiki Wikipedia (skrwiki) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/642892 (https://phabricator.wikimedia.org/T268410) [17:09:54] (03PS1) 10Gerrit maintenance bot: Add skr to languages [services/cxserver] - 10https://gerrit.wikimedia.org/r/642893 (https://phabricator.wikimedia.org/T268410) [17:11:00] (03CR) 10Ladsgroup: [C: 03+2] Add messages for Saraiki Wikipedia (skrwiki) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/642892 (https://phabricator.wikimedia.org/T268410) (owner: 10Gerrit maintenance bot) [17:31:55] (03Merged) 10jenkins-bot: Add messages for Saraiki Wikipedia (skrwiki) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/642892 (https://phabricator.wikimedia.org/T268410) (owner: 10Gerrit maintenance bot) [17:39:52] (03PS2) 10Jforrester: build: Updating stylelint-config-wikimedia to 0.10.3 [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/642899 (owner: 10Libraryupgrader) [17:41:37] (03CR) 10Jforrester: [C: 03+2] build: Updating stylelint-config-wikimedia to 0.10.3 [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/642899 (owner: 10Libraryupgrader) [17:43:34] (03CR) 10jerkins-bot: [V: 04-1] build: Updating stylelint-config-wikimedia to 0.10.3 [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/642899 (owner: 10Libraryupgrader) [17:44:55] (03PS3) 10Jforrester: build: Updating stylelint-config-wikimedia to 0.10.3 [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/642899 (owner: 10Libraryupgrader) [17:45:00] (03CR) 10Jforrester: [C: 03+2] build: Updating stylelint-config-wikimedia to 0.10.3 [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/642899 (owner: 10Libraryupgrader) [18:03:57] 10Dumps-Generation: Need tool to split up large xml bz2 file into smaller ones - https://phabricator.wikimedia.org/T268416 (10ArielGlenn) p:05Triage→03High [18:08:59] (03CR) 10Jforrester: [C: 03+2] Fix some easy phpcs errors [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/642746 (owner: 10DannyS712) [18:09:44] (03CR) 10Jforrester: Fix missing bracket (031 comment) [extensions/cldr] - 10https://gerrit.wikimedia.org/r/642827 (https://phabricator.wikimedia.org/T267265) (owner: 10Raimond Spekking) [18:10:10] (03CR) 10Jforrester: [C: 03+2] Add German translation [extensions/cldr] - 10https://gerrit.wikimedia.org/r/642842 (owner: 10Raimond Spekking) [18:22:47] (03CR) 10Raimond Spekking: Fix missing bracket (031 comment) [extensions/cldr] - 10https://gerrit.wikimedia.org/r/642827 (https://phabricator.wikimedia.org/T267265) (owner: 10Raimond Spekking) [18:34:57] (03Merged) 10jenkins-bot: Fix some easy phpcs errors [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/642746 (owner: 10DannyS712) [18:34:59] (03Merged) 10jenkins-bot: Add German translation [extensions/cldr] - 10https://gerrit.wikimedia.org/r/642842 (owner: 10Raimond Spekking) [18:55:04] 10Design, 10MediaWiki-General: [RFC] MediaWiki rebranding - https://phabricator.wikimedia.org/T256989 (10Iniquity) >>! In T256989#6633518, @Volker_E wrote: > @Iniquity For completion's sake, would you link to further information on “MediaWiki logo is a failed proposal for a Wikipedia logo that never had any me... [18:55:29] (03PS3) 10Meno25: Update Arabic (ar) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/642755 [18:55:57] 10Design, 10MediaWiki-General: [RFC] MediaWiki rebranding - https://phabricator.wikimedia.org/T256989 (10Iniquity) [18:58:52] 10Dumps-Generation: Need tool to append blocks onto the end of an xml dump bz2 file - https://phabricator.wikimedia.org/T268417 (10ArielGlenn) p:05Triage→03High [18:59:04] (03PS2) 10Umherirrender: Use const for ForeignAPIRepo::$imageInfoProps [core] - 10https://gerrit.wikimedia.org/r/642593 [18:59:16] (03CR) 10Umherirrender: Use const for ForeignAPIRepo::$imageInfoProps (031 comment) [core] - 10https://gerrit.wikimedia.org/r/642593 (owner: 10Umherirrender) [19:10:44] (03PS3) 10Umherirrender: Improve and add documentation to diff related classes [core] - 10https://gerrit.wikimedia.org/r/642589 [19:10:57] (03CR) 10Umherirrender: Improve and add documentation to diff related classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/642589 (owner: 10Umherirrender) [19:11:07] (03PS3) 10Umherirrender: Use consts in ApiMain and ApiQuery class [core] - 10https://gerrit.wikimedia.org/r/642573 [19:11:17] (03CR) 10Umherirrender: Use consts in ApiMain and ApiQuery class (032 comments) [core] - 10https://gerrit.wikimedia.org/r/642573 (owner: 10Umherirrender) [19:12:38] 10MediaWiki-extensions-Translate: Enable translating from any already translated language in Extension:Translate - https://phabricator.wikimedia.org/T268274 (10AlexisJazz) [19:13:02] 10MediaWiki-extensions-Translate: Enable translating from any already translated language in Extension:Translate - https://phabricator.wikimedia.org/T268274 (10AlexisJazz) 05Invalid→03Open >>! In T268274#6635954, @Amire80 wrote: > I'm not sure I understand the problem. When translating you can choose both th... [19:13:49] (03CR) 10Umherirrender: [V: 03+2] build: Updating npm dependencies [extensions/PreferencesList] - 10https://gerrit.wikimedia.org/r/642786 (owner: 10Libraryupgrader) [19:15:00] (03PS2) 10Umherirrender: build: Updating npm dependencies [extensions/OnlineStatusBar] - 10https://gerrit.wikimedia.org/r/642777 (owner: 10Libraryupgrader) [19:16:07] (03CR) 10Umherirrender: [V: 03+2 C: 03+2] "PHP Notice: Inaccessible property via __set(): spp_skin in /workspace/src/includes/parser/ParserOutput.php on line 1845" [extensions/SkinPerPage] - 10https://gerrit.wikimedia.org/r/642490 (owner: 10Libraryupgrader) [19:16:53] (03PS2) 10Umherirrender: build: Updating npm dependencies [extensions/WikEdDiff] - 10https://gerrit.wikimedia.org/r/642835 (owner: 10Libraryupgrader) [19:17:39] (03CR) 10Umherirrender: [V: 03+2] "Config variables must be mocked, they cannot be accessed directly in tests which extend MediaWikiUnitTestCase" [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/642727 (owner: 10Libraryupgrader) [19:20:46] (03CR) 10jerkins-bot: [V: 04-1] build: Updating npm dependencies [extensions/WikEdDiff] - 10https://gerrit.wikimedia.org/r/642835 (owner: 10Libraryupgrader) [19:20:48] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.4 [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/642626 (owner: 10Libraryupgrader) [19:21:03] 10MediaWiki-extensions-Page_Forms: PageForms - https://phabricator.wikimedia.org/T268409 (10Peachey88) [19:25:11] (03PS3) 10Umherirrender: Improve and add documentation to import/export related classes [core] - 10https://gerrit.wikimedia.org/r/642598 [19:25:26] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.10.4 [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/642626 (owner: 10Libraryupgrader) [19:25:31] (03CR) 10Umherirrender: [V: 03+2 C: 03+2] build: Updating npm dependencies [extensions/WikEdDiff] - 10https://gerrit.wikimedia.org/r/642835 (owner: 10Libraryupgrader) [19:25:52] (03CR) 10Umherirrender: Improve and add documentation to import/export related classes (034 comments) [core] - 10https://gerrit.wikimedia.org/r/642598 (owner: 10Umherirrender) [19:32:37] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.4 [skins/Vector] - 10https://gerrit.wikimedia.org/r/642909 [19:36:32] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.10.4 [css-sanitizer] - 10https://gerrit.wikimedia.org/r/642910 [19:42:39] (03CR) 10DannyS712: [C: 03+2] Use consts in ApiMain and ApiQuery class [core] - 10https://gerrit.wikimedia.org/r/642573 (owner: 10Umherirrender) [19:43:12] (03CR) 10DannyS712: [C: 03+2] Improve and add documentation to diff related classes [core] - 10https://gerrit.wikimedia.org/r/642589 (owner: 10Umherirrender) [19:43:25] (03CR) 10DannyS712: [C: 03+2] Use const for ForeignAPIRepo::$imageInfoProps [core] - 10https://gerrit.wikimedia.org/r/642593 (owner: 10Umherirrender) [19:57:01] (03CR) 10DannyS712: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.10.4 [skins/Vector] - 10https://gerrit.wikimedia.org/r/642909 (owner: 10Umherirrender) [20:02:21] (03PS3) 10DannyS712: build: Updating npm dependencies [extensions/OnlineStatusBar] - 10https://gerrit.wikimedia.org/r/642777 (owner: 10Libraryupgrader) [20:02:32] (03CR) 10DannyS712: [C: 03+2] build: Updating npm dependencies [extensions/OnlineStatusBar] - 10https://gerrit.wikimedia.org/r/642777 (owner: 10Libraryupgrader) [20:05:34] (03PS4) 10Ammarpad: Improve DBQueryError exception message [core] - 10https://gerrit.wikimedia.org/r/641055 [20:07:33] (03Merged) 10jenkins-bot: Use consts in ApiMain and ApiQuery class [core] - 10https://gerrit.wikimedia.org/r/642573 (owner: 10Umherirrender) [20:13:25] (03Merged) 10jenkins-bot: Improve and add documentation to diff related classes [core] - 10https://gerrit.wikimedia.org/r/642589 (owner: 10Umherirrender) [20:13:30] (03Merged) 10jenkins-bot: Use const for ForeignAPIRepo::$imageInfoProps [core] - 10https://gerrit.wikimedia.org/r/642593 (owner: 10Umherirrender) [20:13:51] 10Dumps-Generation: New dump run paused; Wikidata xml/sql dump page meta history dumps incomplete - https://phabricator.wikimedia.org/T268333 (10ArielGlenn) It finished up and the md5 and sha1 hashes are being generated now. [20:15:06] 10MediaWiki-General, 10VisualEditor: GlobalIdGenerator assumes tmp path is unique - https://phabricator.wikimedia.org/T268420 (10DanielsThomas) [20:18:35] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-phan-config to 0.10.4 [skins/Vector] - 10https://gerrit.wikimedia.org/r/642909 (owner: 10Umherirrender) [20:31:36] 10MediaWiki-extensions-Translate: Enable translating from any already translated language in Extension:Translate - https://phabricator.wikimedia.org/T268274 (10Amire80) Ah, this is clearer. This is actually possible, too, in two ways. The first is to enable assistant languages in the preferences. If a message... [20:33:50] 10Reading-Web-Local-Wiki-Issues, 10Mobile, 10MobileFrontend (Tracking), 10Readers-Web-Backlog (Tracking): Show Navbox templates in mobile skins - https://phabricator.wikimedia.org/T124168 (10XanonymusX) Just wanted to add: for dewiki (where navboxes have always been visible on mobile, but we certainly use... [20:41:34] (03CR) 10Jforrester: [C: 03+2] Fix missing bracket (031 comment) [extensions/cldr] - 10https://gerrit.wikimedia.org/r/642827 (https://phabricator.wikimedia.org/T267265) (owner: 10Raimond Spekking) [20:48:58] (03PS13) 10Ammarpad: Don't show action links for IP ranges outside block limit [core] - 10https://gerrit.wikimedia.org/r/589659 (https://phabricator.wikimedia.org/T211910) [20:49:45] (03PS14) 10Ammarpad: Don't show action links for IP ranges outside block limit [core] - 10https://gerrit.wikimedia.org/r/589659 (https://phabricator.wikimedia.org/T211910) [20:51:22] 10Dumps-Generation: New dump run paused; Wikidata xml/sql dump page meta history dumps incomplete - https://phabricator.wikimedia.org/T268333 (10ArielGlenn) The hashes are done. I have edited dumpruninfo.txt for the run and set the status for the meta history jobs to 'done', adding appropriate time stamps accord... [20:52:36] 10MediaWiki-General: MediaWiki:Moveddeleted-notice indicates a page has been deleted - https://phabricator.wikimedia.org/T268421 (10Luke081515) [20:52:42] 10MediaWiki-General, 10User-Luke081515: MediaWiki:Moveddeleted-notice indicates a page has been deleted - https://phabricator.wikimedia.org/T268421 (10Luke081515) a:03Luke081515 [21:02:11] 10MediaWiki-General, 10User-Luke081515: MediaWiki:Moveddeleted-notice indicates a page has been deleted - https://phabricator.wikimedia.org/T268421 (10DannyS712) @Luke081515 can you provide a link to reproduce this issue? [21:02:15] (03Merged) 10jenkins-bot: Fix missing bracket [extensions/cldr] - 10https://gerrit.wikimedia.org/r/642827 (https://phabricator.wikimedia.org/T267265) (owner: 10Raimond Spekking) [21:03:27] 10MediaWiki-extensions-CLDR, 10I18n, 10Patch-For-Review, 10Upstream: Language missing bracket in its name - https://phabricator.wikimedia.org/T267265 (10Raymond) 05Open→03Resolved a:03Raymond [21:11:30] 10MediaWiki-General, 10User-Luke081515: MediaWiki:Moveddeleted-notice indicates a page has been deleted - https://phabricator.wikimedia.org/T268421 (10Luke081515) @DannyS712 In dewiki we had this example: https://de.wikipedia.org/wiki/Benutzer:Kingkomma?uselang=en As described above, the message says that the... [21:15:01] (03CR) 10DannyS712: "recheck" [services/cxserver] - 10https://gerrit.wikimedia.org/r/642893 (https://phabricator.wikimedia.org/T268410) (owner: 10Gerrit maintenance bot) [21:16:14] (03CR) 10jerkins-bot: [V: 04-1] Don't show action links for IP ranges outside block limit [core] - 10https://gerrit.wikimedia.org/r/589659 (https://phabricator.wikimedia.org/T211910) (owner: 10Ammarpad) [21:17:44] (03CR) 10DannyS712: [C: 03+1] Inject SpecialPageFactory into SpecialPage and use it [core] - 10https://gerrit.wikimedia.org/r/635876 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [21:20:48] (03CR) 10Krinkle: [C: 04-1] ResourceLoaderSkinModule: minor readability cleanup (032 comments) [core] - 10https://gerrit.wikimedia.org/r/642752 (owner: 10DannyS712) [21:22:57] (03PS15) 10Ammarpad: Don't show action links for IP ranges outside block limit [core] - 10https://gerrit.wikimedia.org/r/589659 (https://phabricator.wikimedia.org/T211910) [21:27:27] (03CR) 10Ammarpad: Fix some easy phpcs errors (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/642746 (owner: 10DannyS712) [21:28:16] (03PS5) 10DannyS712: ResourceLoaderSkinModule: minor readability cleanup [core] - 10https://gerrit.wikimedia.org/r/642752 [21:28:21] (03CR) 10DannyS712: ResourceLoaderSkinModule: minor readability cleanup (031 comment) [core] - 10https://gerrit.wikimedia.org/r/642752 (owner: 10DannyS712) [21:28:28] (03PS6) 10DannyS712: ResourceLoaderSkinModule: minor readability cleanup [core] - 10https://gerrit.wikimedia.org/r/642752 [21:32:17] 10MediaWiki-extensions-FlaggedRevs, 10Code-Stewardship-Reviews, 10Release-Engineering-Team (Code Health): Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10DannyS712) >>! In T185664#6222722, @akosiaris wrote: >>>! In T185664#6221695, @DannyS712 wrote: >> Is there a default r... [21:35:58] 10MediaWiki-General, 10VisualEditor: GlobalIdGenerator assumes tmp path is unique - https://phabricator.wikimedia.org/T268420 (10Bertvandepoel) I can confirm that indeed these files are created globally in /tmp , which is problematic whenever more than a single wiki is used. This could even be problematic for... [21:41:13] (03CR) 10DannyS712: [C: 03+1] Represent Consequences with command objects (034 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/633380 (owner: 10Daimona Eaytoy) [21:43:14] (03PS1) 10Esanders: MediaResourceProvider: Use MediaSearch API when available [core] - 10https://gerrit.wikimedia.org/r/642914 (https://phabricator.wikimedia.org/T264779) [21:48:00] (03PS2) 10Esanders: De-indent multi line comments when fetching comment bodies [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/642193 [21:48:02] (03PS2) 10Esanders: Add method to strip trailing hyphens from comment bodies [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/642529 [21:48:04] (03PS11) 10Esanders: [WIP] Special:ViewDiscussions [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/635120 (owner: 10Bartosz Dziewoński) [21:48:06] (03PS8) 10Esanders: Experimenting with styling of Special:ViewDisucssions [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/635307 [21:49:16] (03PS3) 10Esanders: De-indent multi line comments when fetching comment bodies [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/642193 [21:49:18] (03PS3) 10Esanders: Add method to strip trailing hyphens from comment bodies [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/642529 [21:49:20] (03PS12) 10Esanders: [WIP] Special:ViewDiscussions [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/635120 (owner: 10Bartosz Dziewoński) [21:49:22] (03PS9) 10Esanders: Experimenting with styling of Special:ViewDisucssions [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/635307 [21:49:46] 10Dumps-Generation: New dump run paused; Wikidata xml/sql dump page meta history dumps incomplete - https://phabricator.wikimedia.org/T268333 (10ArielGlenn) 05Open→03Resolved No-op is done, and the files are on the web server, the cloud nfs server, and the dumpsdata fallback server. Closing this task. [21:54:26] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Special:ViewDiscussions [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/635120 (owner: 10Bartosz Dziewoński) [21:55:09] (03CR) 10jerkins-bot: [V: 04-1] Experimenting with styling of Special:ViewDisucssions [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/635307 (owner: 10Esanders) [22:01:39] 10MediaWiki-Page-Diffs, 10MediaWiki-Page-History, 10Community-Tech, 10Community-Wishlist-Survey-2015, and 2 others: [Epic] Add feature annotate/blame command, to indicate who last changed each line / word - https://phabricator.wikimedia.org/T2639 (10Mathglot) T2639 mentioned at [[https://meta.wikimedia.org... [22:05:44] (03PS1) 10Esanders: Show keyboard shortcuts in button tooltips [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/642915 (https://phabricator.wikimedia.org/T264913) [22:06:16] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: Show keyboard shortcuts for Reply/Cancel in tooltips - https://phabricator.wikimedia.org/T264913 (10Esanders) a:03Esanders [22:12:53] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review, 10Performance Issue, 10Technical-Debt: Add reply links to the parser cache - https://phabricator.wikimedia.org/T267404 (10Esanders) a:03Esanders [22:13:25] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: Do not show "self" in username suggestion list - https://phabricator.wikimedia.org/T267680 (10Esanders) a:03Esanders [22:15:14] (03PS7) 10Krinkle: resourceloader: minor readability cleanup in ResourceLoaderSkinModule [core] - 10https://gerrit.wikimedia.org/r/642752 (owner: 10DannyS712) [22:15:19] (03CR) 10Krinkle: [C: 03+2] resourceloader: minor readability cleanup in ResourceLoaderSkinModule [core] - 10https://gerrit.wikimedia.org/r/642752 (owner: 10DannyS712) [22:16:54] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: Comment lost when attempting to publish to a closed conversation - https://phabricator.wikimedia.org/T268069 (10Esanders) a:03matmarex [22:27:14] (03CR) 10Esanders: [C: 04-1] "Why doesn't the API return an ID not found error? I feel like the API should be returning some error code in this situation..." [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/641818 (https://phabricator.wikimedia.org/T268069) (owner: 10Bartosz Dziewoński) [22:34:06] (03CR) 10Esanders: [C: 03+2] Fix client-side IDs for indistinguishable comments [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/641810 (https://phabricator.wikimedia.org/T268093) (owner: 10Bartosz Dziewoński) [22:34:53] (03PS7) 10Florianschmidtwelzow: Mention new required php extension intl [core] - 10https://gerrit.wikimedia.org/r/640474 (https://phabricator.wikimedia.org/T267669) [22:35:28] (03CR) 10Florianschmidtwelzow: "arghh, that's a pity, it looks kind of confusing to have these different min php versions. But hey, this was a tiny addition of this chang" [core] - 10https://gerrit.wikimedia.org/r/640474 (https://phabricator.wikimedia.org/T267669) (owner: 10Florianschmidtwelzow) [22:35:34] (03PS8) 10Florianschmidtwelzow: Mention new required php extension intl [core] - 10https://gerrit.wikimedia.org/r/640474 (https://phabricator.wikimedia.org/T267669) [22:37:49] (03Merged) 10jenkins-bot: resourceloader: minor readability cleanup in ResourceLoaderSkinModule [core] - 10https://gerrit.wikimedia.org/r/642752 (owner: 10DannyS712) [22:38:57] (03Merged) 10jenkins-bot: Fix client-side IDs for indistinguishable comments [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/641810 (https://phabricator.wikimedia.org/T268093) (owner: 10Bartosz Dziewoński) [22:41:44] (03CR) 10Esanders: [C: 03+2] Fix displaying reply links after posting a reply with dtenable=1 [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/641807 (https://phabricator.wikimedia.org/T267847) (owner: 10Bartosz Dziewoński) [22:43:00] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: Reply buttons disappear after using them once, when using with dtenable or user script hack - https://phabricator.wikimedia.org/T267847 (10Esanders) [22:43:39] (03PS8) 10Umherirrender: Check for Title::canHaveTalkPage in User::addWatch [core] - 10https://gerrit.wikimedia.org/r/614793 [22:58:50] (03PS1) 10Jdrewniak: [POC] Isomorphic Vue.js rendering via Mustache templates. [skins/Vector] - 10https://gerrit.wikimedia.org/r/642916 (https://phabricator.wikimedia.org/T264355) [23:02:21] (03Merged) 10jenkins-bot: Fix displaying reply links after posting a reply with dtenable=1 [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/641807 (https://phabricator.wikimedia.org/T267847) (owner: 10Bartosz Dziewoński) [23:07:30] (03PS1) 10Tim Starling: Revert "Deprecate Skin::setupSkinUserCss" [core] - 10https://gerrit.wikimedia.org/r/642847 (https://phabricator.wikimedia.org/T257990) [23:13:09] 10MediaWiki-General, 10Platform Engineering, 10Patch-For-Review, 10Technical-Debt (Deprecation process): Helper for deprecating method overrides - https://phabricator.wikimedia.org/T267080 (10tstarling) I don't think hard deprecation should be necessary prior to removal, if the thing being removed is not a... [23:15:34] (03CR) 10jerkins-bot: [V: 04-1] [POC] Isomorphic Vue.js rendering via Mustache templates. [skins/Vector] - 10https://gerrit.wikimedia.org/r/642916 (https://phabricator.wikimedia.org/T264355) (owner: 10Jdrewniak) [23:23:32] (03PS2) 10Tim Starling: Require Guzzle and update the version to match MW [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/642250 [23:25:05] (03CR) 10jerkins-bot: [V: 04-1] Require Guzzle and update the version to match MW [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/642250 (owner: 10Tim Starling) [23:28:54] (03PS3) 10Tim Starling: Require Guzzle and update the version to match MW [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/642250 [23:28:58] (03PS4) 10Karl Wettin (WMSE): Introduce ad-hoc Persistent JSON-serialization [extensions/WikispeechSpeechDataCollector] - 10https://gerrit.wikimedia.org/r/638619 (https://phabricator.wikimedia.org/T267117) [23:33:21] 10MediaWiki-Core-Skin-Architecture, 10Modern, 10MonoBook, 10Timeless, and 2 others: Hard deprecate Skin::setupSkinUserCss - https://phabricator.wikimedia.org/T257990 (10Reedy) 05Resolved→03Open [23:46:50] 10MediaWiki-General, 10User-Luke081515: MediaWiki:Moveddeleted-notice indicates a page has been deleted - https://phabricator.wikimedia.org/T268421 (10Base) Successfully reproduced at https://test.wikipedia.org/wiki/T268421 [23:46:59] (03CR) 10Jdlrobson: "The core call has" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/642847 (https://phabricator.wikimedia.org/T257990) (owner: 10Tim Starling) [23:54:29] 10Wikimedia Design Style Guide: Design icons and add sections on site for blog and research - https://phabricator.wikimedia.org/T268423 (10iamjessklein) [23:58:07] (03CR) 10DannyS712: [C: 04-1] Introduce ad-hoc Persistent JSON-serialization (0312 comments) [extensions/WikispeechSpeechDataCollector] - 10https://gerrit.wikimedia.org/r/638619 (https://phabricator.wikimedia.org/T267117) (owner: 10Karl Wettin (WMSE))