[00:00:05] 10WMCH-Infrastructure: Migrate Wikimini into WMCH infrastructure - https://phabricator.wikimedia.org/T268292 (10valerio.bozzolan) p:05Triage→03Medium a:03valerio.bozzolan [00:03:06] 10WMCH-Infrastructure: Incident report for WMCH server "members2" (2020-11-20) - https://phabricator.wikimedia.org/T268371 (10valerio.bozzolan) [00:09:07] 10WMCH-Infrastructure: Incident report for WMCH server "members2" (2020-11-20) - https://phabricator.wikimedia.org/T268371 (10valerio.bozzolan) [00:09:45] 10WMCH-Infrastructure: Incident report for WMCH server "members2" (2020-11-20) - https://phabricator.wikimedia.org/T268371 (10valerio.bozzolan) [00:14:55] (03PS2) 10Daimona Eaytoy: build: Updating mediawiki/mediawiki-phan-config to 0.10.4 [extensions/WikiSEO] - 10https://gerrit.wikimedia.org/r/642571 (owner: 10Libraryupgrader) [00:15:21] (03CR) 10Daimona Eaytoy: "Needs Ibd66acea7d7a466faae8e326852e2a32edc7ba50 to be deployed, although CI seems to be optional in this repo..." [extensions/WikiSEO] - 10https://gerrit.wikimedia.org/r/642571 (owner: 10Libraryupgrader) [00:16:38] (03CR) 10Ammarpad: Migrate job to abstract schema (031 comment) [core] - 10https://gerrit.wikimedia.org/r/641701 (https://phabricator.wikimedia.org/T230428) (owner: 10Ammarpad) [00:18:23] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.10.4 [extensions/WikiSEO] - 10https://gerrit.wikimedia.org/r/642571 (owner: 10Libraryupgrader) [00:19:27] 10MediaWiki-File-management, 10Commons, 10TechCom-RFC, 10Wikimedia-SVG-rendering: RFC: Re-evaluate librsvg as SVG renderer on Wikimedia wikis - https://phabricator.wikimedia.org/T40010 (10RazrFalcon) @Glrx Hi. As the author of [[ https://github.com/RazrFalcon/resvg | resvg ]], I would like to point out som... [00:21:20] 10Research (FY2020-21-Research-October-December): Develop automatic evaluation protocol with existing links to avoid manual evaluation and evaluate link recommendation on 4 or more languages - https://phabricator.wikimedia.org/T265745 (10MGerlach) update week 2020-11-16: - this week met with Djellel to discuss p... [00:22:24] (03CR) 10Reedy: "If we're relying on functionality in new MW... We should probably bump the MW requires in extension.json. It's currently >= 1.29.0 so is p" [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/621883 (https://phabricator.wikimedia.org/T268360) (owner: 10Umherirrender) [00:25:08] 10WMCH-Infrastructure: Incident report for WMCH server "members2" (2020-11-20) - https://phabricator.wikimedia.org/T268371 (10valerio.bozzolan) [00:26:07] (03PS2) 10Ammarpad: Migrate job to abstract schema [core] - 10https://gerrit.wikimedia.org/r/641701 (https://phabricator.wikimedia.org/T230428) [00:33:08] (03PS1) 10Umherirrender: Improve and add documentation to cache related classes [core] - 10https://gerrit.wikimedia.org/r/642582 [00:35:46] 10DiscussionTools: Make it easy to "outdent" by changing the colons/list level - https://phabricator.wikimedia.org/T265750 (10ppelberg) [00:36:30] (03PS1) 10Ammarpad: Deprecate Html::infobox [core] - 10https://gerrit.wikimedia.org/r/642583 (https://phabricator.wikimedia.org/T268078) [00:37:31] (03PS1) 10Umherirrender: Use const for ChangeTags::$definedSoftwareTags [core] - 10https://gerrit.wikimedia.org/r/642584 [00:39:26] 10MediaWiki-Core-Skin-Architecture, 10MediaWiki-Interface, 10MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), 10Patch-For-Review: Hard deprecate Html::infoBox - https://phabricator.wikimedia.org/T268078 (10Ammarpad) a:03Ammarpad [00:42:27] (03PS1) 10Umherirrender: Use consts in IcuCollation class [core] - 10https://gerrit.wikimedia.org/r/642585 [01:00:24] 10MediaWiki-Watchlist, 10Growth-Team: Increase max number of edits in watchlist - https://phabricator.wikimedia.org/T213265 (10Tgr) [01:00:45] 10MediaWiki-Watchlist, 10Growth-Team: Investigate: Increasing wllimit values - https://phabricator.wikimedia.org/T151165 (10Tgr) [01:01:00] (03PS17) 10Daimona Eaytoy: Track taintedness of single array elements [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609500 (https://phabricator.wikimedia.org/T253875) [01:01:59] 10MediaWiki-Watchlist, 10Growth-Team: Increase the number of entries shown on the watchlist (wllimit) - https://phabricator.wikimedia.org/T151165 (10Tgr) [01:02:08] (03CR) 10jerkins-bot: [V: 04-1] Track taintedness of single array elements [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609500 (https://phabricator.wikimedia.org/T253875) (owner: 10Daimona Eaytoy) [01:07:56] 10MediaWiki-API, 10MediaWiki-extensions-FlaggedRevs, 10Platform Engineering: logevents letype=stable returns poorly formatted expiry - https://phabricator.wikimedia.org/T267922 (10Amorymeltzer) [01:09:38] (03PS18) 10Daimona Eaytoy: Track taintedness of single array elements [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609500 (https://phabricator.wikimedia.org/T253875) [01:10:59] (03CR) 10jerkins-bot: [V: 04-1] Track taintedness of single array elements [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609500 (https://phabricator.wikimedia.org/T253875) (owner: 10Daimona Eaytoy) [01:12:22] (03PS1) 10Umherirrender: Improve and add documentation to diff related classes [core] - 10https://gerrit.wikimedia.org/r/642589 [01:13:18] (03PS1) 10Gergő Tisza: Update https role [vagrant] - 10https://gerrit.wikimedia.org/r/642590 [01:13:55] (03PS2) 10Gergő Tisza: Update https role [vagrant] - 10https://gerrit.wikimedia.org/r/642590 [01:14:09] (03PS1) 10STran: Normalize IP addresses returned from GeoIP2 [extensions/IPInfo] - 10https://gerrit.wikimedia.org/r/642591 (https://phabricator.wikimedia.org/T267015) [01:16:59] (03PS2) 10Umherirrender: Improve and add documentation to diff related classes [core] - 10https://gerrit.wikimedia.org/r/642589 [01:18:51] (03CR) 10jerkins-bot: [V: 04-1] Normalize IP addresses returned from GeoIP2 [extensions/IPInfo] - 10https://gerrit.wikimedia.org/r/642591 (https://phabricator.wikimedia.org/T267015) (owner: 10STran) [01:20:53] (03PS1) 10Umherirrender: Use const for ForeignAPIRepo::$imageInfoProps [core] - 10https://gerrit.wikimedia.org/r/642593 [01:32:48] 10MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), 10Patch-For-Review, 10SDAW-MediaSearch (MediaSearch-Beta), 10Structured-Data-Backlog (Current Work): [M] Categories and Pages tab for Media Search - https://phabricator.wikimedia.org/T257700 (10Etonkovidova) Two notes (1) @matthiasmullie File talk NS is also e... [01:45:09] (03PS1) 10Umherirrender: Improve and add documentation to import/export related classes [core] - 10https://gerrit.wikimedia.org/r/642598 [01:59:29] 10ParserFunctions, 10Community-Wishlist-Survey-2015: ifexist function uses pagelinks table in lieu of better options - https://phabricator.wikimedia.org/T14019 (10Huji) I like your thought, but I don't completely agree. Even though ParserFunction is a non-core function, I think the root cause of this problem *... [02:02:34] (03CR) 10Ammarpad: Migrate job to abstract schema (031 comment) [core] - 10https://gerrit.wikimedia.org/r/641701 (https://phabricator.wikimedia.org/T230428) (owner: 10Ammarpad) [02:05:38] (03PS3) 10Ammarpad: Migrate job to abstract schema [core] - 10https://gerrit.wikimedia.org/r/641701 (https://phabricator.wikimedia.org/T230428) [02:07:22] (03CR) 10DannyS712: [C: 03+2] Use const for BlockRestrictionStore::$types [core] - 10https://gerrit.wikimedia.org/r/642578 (owner: 10Umherirrender) [02:09:14] (03PS1) 10BryanDavis: make: add format-code target [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/642602 [02:09:16] (03PS1) 10BryanDavis: l10n: Set Django session locale when changing Vue locale [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/642603 (https://phabricator.wikimedia.org/T268357) [02:10:06] (03CR) 10BryanDavis: [C: 03+2] make: add format-code target [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/642602 (owner: 10BryanDavis) [02:10:16] (03CR) 10DannyS712: "> Patch Set 4:" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/636527 (https://phabricator.wikimedia.org/T253760) (owner: 10DannyS712) [02:11:32] (03CR) 10Jdlrobson: [C: 03+2] "hurrah!" [core] - 10https://gerrit.wikimedia.org/r/642583 (https://phabricator.wikimedia.org/T268078) (owner: 10Ammarpad) [02:12:17] (03CR) 10DannyS712: "> Patch Set 2:" [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/642487 (owner: 10Huji) [02:12:19] (03CR) 10BryanDavis: l10n: Set Django session locale when changing Vue locale (031 comment) [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/642603 (https://phabricator.wikimedia.org/T268357) (owner: 10BryanDavis) [02:15:45] (03Merged) 10jenkins-bot: make: add format-code target [wikimedia/toolhub] (main) - 10https://gerrit.wikimedia.org/r/642602 (owner: 10BryanDavis) [02:30:26] (03Merged) 10jenkins-bot: Use const for BlockRestrictionStore::$types [core] - 10https://gerrit.wikimedia.org/r/642578 (owner: 10Umherirrender) [02:34:43] (03Merged) 10jenkins-bot: Deprecate Html::infobox [core] - 10https://gerrit.wikimedia.org/r/642583 (https://phabricator.wikimedia.org/T268078) (owner: 10Ammarpad) [02:34:47] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.10.4 [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/642605 (owner: 10Libraryupgrader) [02:47:24] (03PS1) 10Ammarpad: Define Skin RelevantUser for IP ranges [core] - 10https://gerrit.wikimedia.org/r/642610 (https://phabricator.wikimedia.org/T206954) [02:57:08] 10MediaWiki-extensions-OAuth, 10Platform Team Initiatives (API Gateway), 10Platform Team Workboards (S&F Workboard): OAuth 2.0 access tokens have effectively infinite expiration date - https://phabricator.wikimedia.org/T265075 (10apaskulin) @BPirkle, The [documentation for $wgOAuth2GrantExpirationInterval ](... [03:01:28] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10Skipped QA, 10Technical-Debt: Test output changes slightly between PHP versions - https://phabricator.wikimedia.org/T266317 (10ppelberg) 05Open→03Resolved a:03ppelberg [03:01:47] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), 10Skipped QA: DiscussionTools removes parser profiling HTML comments from the page source when adding reply links - https://phabricator.wikimedia.org/T267973 (10ppelberg) 05Open→03Resolved a:03ppel... [03:11:31] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10MW-1.36-notes (1.36.0-wmf.18; 2020-11-17), 10Serbian-Sites: The reply tool uses language-converted section title in the edit summary - https://phabricator.wikimedia.org/T266725 (10ppelberg) 05Open→03Resolved >>! In T266725#6608765, @Tacsipac... [03:29:00] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.10.4 [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/642618 (owner: 10Libraryupgrader) [03:33:30] (03CR) 10Gergő Tisza: "Have not tested this, but the change is fairly trivial." [vagrant] - 10https://gerrit.wikimedia.org/r/642590 (owner: 10Gergő Tisza) [03:58:55] 10MediaWiki-Core-Skin-Architecture, 10MediaWiki-Interface, 10MonoBook, 10Timeless, and 2 others: Hard deprecate BaseTemplate::getFooterIcons - https://phabricator.wikimedia.org/T267447 (10Isarra) What about all the other skins that use it? Namely, er, nearly all of them? [04:02:47] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.10.4 [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/642626 (owner: 10Libraryupgrader) [04:11:30] (03PS3) 10Jeena Huneidi: Add 'exec' feature [tools/cli] - 10https://gerrit.wikimedia.org/r/640291 (https://phabricator.wikimedia.org/T262370) [04:12:19] (03CR) 10Ammarpad: "> Patch Set 4:" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/636527 (https://phabricator.wikimedia.org/T253760) (owner: 10DannyS712) [04:18:36] (03CR) 10Jeena Huneidi: Add 'exec' feature (031 comment) [tools/cli] - 10https://gerrit.wikimedia.org/r/640291 (https://phabricator.wikimedia.org/T262370) (owner: 10Jeena Huneidi) [04:19:52] (03CR) 10Ammarpad: "check postgres" [core] - 10https://gerrit.wikimedia.org/r/641701 (https://phabricator.wikimedia.org/T230428) (owner: 10Ammarpad) [04:24:50] (03PS4) 10Jeena Huneidi: Add 'exec' feature [tools/cli] - 10https://gerrit.wikimedia.org/r/640291 (https://phabricator.wikimedia.org/T262370) [04:25:21] (03CR) 10Ammarpad: [C: 04-1] "The only thing that would force TimelineRowFormatter to not not alter the signature is if it either implements or is extending a class tha" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/636527 (https://phabricator.wikimedia.org/T253760) (owner: 10DannyS712) [04:30:12] (03CR) 10Ammarpad: "Can be tested at https://patchdemo.wmflabs.org/wikis/29b24248afdfe4b90efc34e9017ebba7/w/index.php?target=24.237.208.166%2F30&namespace=all" [core] - 10https://gerrit.wikimedia.org/r/642610 (https://phabricator.wikimedia.org/T206954) (owner: 10Ammarpad) [04:42:54] 10Shell: id.wikipedia - https://phabricator.wikimedia.org/T22666 (10Wiki.account.id) a:05RobH→03None [04:43:42] 10Shell: id.wikipedia - https://phabricator.wikimedia.org/T22666 (10Wiki.account.id) [04:44:38] 10Shell: id.wikipedia - https://phabricator.wikimedia.org/T22666 (10Wiki.account.id) [04:45:21] (03CR) 10Ammarpad: Migrate job to abstract schema (031 comment) [core] - 10https://gerrit.wikimedia.org/r/641701 (https://phabricator.wikimedia.org/T230428) (owner: 10Ammarpad) [04:47:03] 04(no projects): idn.wikipedia.org - https://phabricator.wikimedia.org/T22666 (10Wiki.account.id) [04:49:58] 04(no projects): x.wikipedia - https://phabricator.wikimedia.org/T22666 (10Wiki.account.id) [04:55:10] 04(no projects): x.wikipedia - https://phabricator.wikimedia.org/T22666 (10Peachey88) @Wiki.account.id This phabricator instance is not for testing and disruptive edits, please use https://phab.wmflabs.org/. If you continue your account will be disabled. [04:58:27] 10Wikimedia-Site-requests: Remove new page creation rights for anons on id.wikipedia - https://phabricator.wikimedia.org/T22666 (10Peachey88) a:03RobH [05:11:40] 10MinervaNeue, 10MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), 10Readers-Web-Backlog (Kanbanana-FY-2020-21): AMC: MinervaNeue shows external link icon on the last edited bar - https://phabricator.wikimedia.org/T267464 (10Edtadros) === Test Result - Beta **Status:** ✅ PASS **Environment:** beta **OS:** macOS Ca... [05:14:40] (03Abandoned) 10DannyS712: TimelineRowFormatter::msg implement MessageLocalizer [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/636527 (https://phabricator.wikimedia.org/T253760) (owner: 10DannyS712) [05:14:59] 10Anti-Harassment, 10CheckUser, 10Technical-Debt: TimelineRowFormatter uses a custom signature for the msg method - https://phabricator.wikimedia.org/T253760 (10DannyS712) [05:23:47] 10Desktop Improvements, 10UniversalLanguageSelector, 10MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-FY-2020-21): The module ext.uls.compactlinks and its associated beta feature should be disabled on new Vector - https://phabricator.wikimedia.org/T264824 (... [05:24:23] 10Desktop Improvements, 10UniversalLanguageSelector, 10MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-FY-2020-21): The module ext.uls.compactlinks and its associated beta feature should be disabled on new Vector - https://phabricator.wikimedia.org/T264824 (... [05:25:14] 10MinervaNeue, 10MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), 10Readers-Web-Backlog (Kanbanana-FY-2020-21): AMC: MinervaNeue shows external link icon on the last edited bar - https://phabricator.wikimedia.org/T267464 (10Edtadros) [05:46:39] 10MediaWiki-Watchlist, 10Growth-Team: Increase the number of entries shown on the watchlist (wllimit) - https://phabricator.wikimedia.org/T151165 (10C.Suthorn) I am a bit surprised by the merge of tasks. I was under the impression (from comments by "(WMF)"-Accounts), that by now the watchlist size should alre... [05:46:56] 10Advanced Mobile Contributions: Page history link in Minerva AMC has class "external" - https://phabricator.wikimedia.org/T268373 (10Hello903hello) [05:54:31] (03PS1) 10Gergő Tisza: [WIP] Make PHP version configurable [vagrant] - 10https://gerrit.wikimedia.org/r/642641 (https://phabricator.wikimedia.org/T268338) [05:55:08] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Make PHP version configurable [vagrant] - 10https://gerrit.wikimedia.org/r/642641 (https://phabricator.wikimedia.org/T268338) (owner: 10Gergő Tisza) [06:00:50] 10MediaWiki-extensions-OAuth, 10Platform Team Initiatives (API Gateway), 10Platform Team Workboards (S&F Workboard): OAuth 2.0 access tokens have effectively infinite expiration date - https://phabricator.wikimedia.org/T265075 (10BPirkle) Oh, awesome. Guess I should have read that. :-) Given that, we just n... [06:41:38] 10MediaWiki-Vagrant, 10MW-1.35-release, 10Patch-For-Review: Cannot run MW 1.35 on MediaWiki-Vagrant - https://phabricator.wikimedia.org/T268338 (10Tgr) I can't seem to get the version pinning right. ` vagrant@test:~$ cat /etc/apt/preferences.d/sury-override.pref Package: libpcre2-* php-apcu php-igbinary php... [06:41:41] (03CR) 10Jack Phoenix: [C: 03+2] Don't load AdSense JS from Google's servers unless an AdSense publisher ID has been configured [extensions/ShoutWikiAds] - 10https://gerrit.wikimedia.org/r/641741 (owner: 10Jack Phoenix) [06:45:23] (03Merged) 10jenkins-bot: Don't load AdSense JS from Google's servers unless an AdSense publisher ID has been configured [extensions/ShoutWikiAds] - 10https://gerrit.wikimedia.org/r/641741 (owner: 10Jack Phoenix) [06:47:54] (03CR) 10Jack Phoenix: [C: 03+2] No-JS support for the category tag cloud on Special:CreateBlogPost [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/641794 (https://phabricator.wikimedia.org/T248390) (owner: 10Jack Phoenix) [06:50:00] (03CR) 10Jack Phoenix: [V: 03+2 C: 03+2] "Wikia finally upgraded? Well that's certainly...surprising." [tools/grabbers] - 10https://gerrit.wikimedia.org/r/641020 (owner: 10Martineznovo) [06:52:01] (03Merged) 10jenkins-bot: No-JS support for the category tag cloud on Special:CreateBlogPost [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/641794 (https://phabricator.wikimedia.org/T248390) (owner: 10Jack Phoenix) [06:52:08] 10MediaWiki-Watchlist, 10Growth-Team: Increase the number of entries shown on the watchlist (wllimit) - https://phabricator.wikimedia.org/T151165 (10Aklapper) >>! In T151165#6638039, @C.Suthorn wrote: > I was under the impression that by now the watchlist size should already have been increased to 2000. @C.S... [07:01:25] (03PS1) 10Jack Phoenix: Allow anons to view the list of (registered) users currently editing the article [extensions/AjaxShowEditors] - 10https://gerrit.wikimedia.org/r/642642 [07:02:32] (03CR) 10Jack Phoenix: "@DannyS712: Wanna sanity check this? I feel like there's something I'm overlooking here, but I'm not sure what it is...thanks in advance!" [extensions/AjaxShowEditors] - 10https://gerrit.wikimedia.org/r/642642 (owner: 10Jack Phoenix) [07:05:01] 10Magnus Sälgö: Project "Stadens ansikte" - https://phabricator.wikimedia.org/T268374 (10Salgo60) [07:06:45] (03CR) 10Jack Phoenix: "> LGTM, can I ask why though?" [extensions/OpenGraphMeta] - 10https://gerrit.wikimedia.org/r/617269 (owner: 10Jack Phoenix) [07:07:36] 10Magnus Sälgö: Project "Stadens ansikte" - https://phabricator.wikimedia.org/T268374 (10Salgo60) [07:23:19] (03PS1) 10Gergő Tisza: NamespaceDefTest: fix namespaces [core] - 10https://gerrit.wikimedia.org/r/642643 [07:24:41] 10Magnus Sälgö: Arkitekter verksamma i Sverige (Arkitektur- och designcentrum) - https://phabricator.wikimedia.org/T268375 (10Salgo60) [07:25:13] (03CR) 10Ostrzyciel: [C: 03+1] When an anon accesses Special:Drafts, redirect them to Special:UserLogin instead of showing a potentially incorrect error message [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/638995 (https://phabricator.wikimedia.org/T57394) (owner: 10Jack Phoenix) [07:39:29] 10Magnus Sälgö: Arkitekter verksamma i Sverige (Arkitektur- och designcentrum) - https://phabricator.wikimedia.org/T268375 (10Salgo60) [07:42:12] 10Magnus Sälgö: Arkitekter verksamma i Sverige (Arkitektur- och designcentrum) - https://phabricator.wikimedia.org/T268375 (10Salgo60) [07:42:44] 10Magnus Sälgö: Arkitekter verksamma i Sverige (Arkitektur- och designcentrum) - https://phabricator.wikimedia.org/T268375 (10Salgo60) [07:47:25] (03CR) 10Ostrzyciel: [C: 03+1] Ensure that we output valid UTF-8 instead of mojibake [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/640072 (https://phabricator.wikimedia.org/T266864) (owner: 10Jack Phoenix) [07:52:14] 10Magnus Sälgö: Project "Stadens ansikte" - https://phabricator.wikimedia.org/T268374 (10Salgo60) [07:53:53] 10Magnus Sälgö: Project "Stadens ansikte" - https://phabricator.wikimedia.org/T268374 (10Salgo60) [07:55:17] 10Magnus Sälgö: Arkitekter verksamma i Sverige (Arkitektur- och designcentrum) - https://phabricator.wikimedia.org/T268375 (10Salgo60) [07:55:59] 10Magnus Sälgö: Arkitekter verksamma i Sverige (Arkitektur- och designcentrum) - https://phabricator.wikimedia.org/T268375 (10Salgo60) [08:05:40] 10Magnus Sälgö: Arkitekter verksamma i Sverige (Arkitektur- och designcentrum) - https://phabricator.wikimedia.org/T268375 (10Salgo60) [08:14:21] 10Magnus Sälgö: Arkitekter verksamma i Sverige (Arkitektur- och designcentrum) - https://phabricator.wikimedia.org/T268375 (10Salgo60) [08:23:22] (03CR) 10Jack Phoenix: "Hi Cindy and Daniel, thanks for the patch & for cc'ing me, I appreciate it! LinkFilter, like all the other extensions in the social tools " [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/640966 (owner: 10Cicalese) [08:43:42] 10Dumps-Generation, 10Patch-For-Review: Be more efficient about generating page ranges for breaking up page content jobs into smaller ones - https://phabricator.wikimedia.org/T263319 (10ArielGlenn) The above patch has been deployed everywhere and manually copied into the directory for the run already underway.... [08:57:16] (03CR) 10DannyS712: [C: 03+2] Require MediaWiki 1.34+ [extensions/OpenGraphMeta] - 10https://gerrit.wikimedia.org/r/617269 (owner: 10Jack Phoenix) [09:01:53] (03Merged) 10jenkins-bot: Require MediaWiki 1.34+ [extensions/OpenGraphMeta] - 10https://gerrit.wikimedia.org/r/617269 (owner: 10Jack Phoenix) [09:12:32] (03CR) 10ArielGlenn: Improve and add documentation to import/export related classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/642598 (owner: 10Umherirrender) [09:26:57] (03PS1) 10Ammarpad: Use generator in SpecialPageFatalTest [core] - 10https://gerrit.wikimedia.org/r/642644 [09:48:12] (03Abandoned) 10Aklapper: Correcting [extensions/VisualChat] - 10https://gerrit.wikimedia.org/r/135049 (owner: 10Miguel2706) [10:16:57] 10MediaWiki-Cache, 10CirrusSearch, 10Discovery-Search, 10MW-1.35-release, 10affects-translatewiki.net: LogicException: Process cache for 'en' should be set by now - https://phabricator.wikimedia.org/T258860 (10Seppl2013) same on my main wiki - showed up after some 3 weeks of migration to 1.35 LTS - it is... [10:32:52] 04(no projects): Harrassment and micro agression notification - https://phabricator.wikimedia.org/T268366 (10Aklapper) Hi @Nattes, thanks for taking the time to report this. #Trust-and-Safety does not do any code development (as far as I know). Removing tag; see https://phabricator.wikimedia.org/project/profile... [10:33:05] 04(no projects): Harrassment and micro agression notification - https://phabricator.wikimedia.org/T268366 (10Aklapper) [10:33:16] 10Anti-Harassment: Epic⚡️ : User reporting system - https://phabricator.wikimedia.org/T166812 (10Aklapper) [10:38:35] 04(no projects): Harrassment and micro agression notification - https://phabricator.wikimedia.org/T268366 (10Nattes) I dont really agree to close this ticket, Cant we move it instead? I inserted it in the community wishlist. This is not a task for Trust and Safety nor a WMF driven task, It is a community wish.... [10:42:03] 04(no projects): Harrassment and micro agression notification - https://phabricator.wikimedia.org/T268366 (10Nattes) 05duplicate→03Open I am reopening. The actual trust and Safety procedures do not allow moderation of micro aggression on each project. We need to adress the problem by a community driven init... [10:42:31] 10MediaWiki-File-management, 10Commons, 10TechCom-RFC, 10Wikimedia-SVG-rendering: RFC: Re-evaluate librsvg as SVG renderer on Wikimedia wikis - https://phabricator.wikimedia.org/T40010 (10Aklapper) >>! In T40010#6637120, @JoKalliauer wrote: > Is it possible to try resvg and/or inkscape at https://commons.w... [10:42:59] 04(no projects): Harrassment and micro agression notification - https://phabricator.wikimedia.org/T268366 (10Aklapper) @Nantes: Please explain how this task is different from T166812. [10:43:52] (03PS2) 10Daimona Eaytoy: build: Updating mediawiki/mediawiki-phan-config to 0.10.4 [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/642618 (owner: 10Libraryupgrader) [10:44:32] 10Anti-Harassment: Harrassment and micro agression notification - https://phabricator.wikimedia.org/T268366 (10Aklapper) 05Open→03Stalled [10:44:57] (03PS2) 10Daimona Eaytoy: build: Updating mediawiki/mediawiki-phan-config to 0.10.4 [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/642605 (owner: 10Libraryupgrader) [10:49:32] 10AbuseFilter: Avoid dangerous AbuseFilter edits - https://phabricator.wikimedia.org/T264768 (10Billinghurst) Some comments as a global abuse filter writer. 1. While I can write a global abuse filter it is not readily able to be checked against past edits in the meta log of global hits. I know that I have writ... [10:51:47] 10MediaWiki-Core-Testing, 10MediaWiki-General: @mixins annotation is rejected by eslint - https://phabricator.wikimedia.org/T268378 (10Daimona) [11:12:50] 10WPCleaner: Create builders - https://phabricator.wikimedia.org/T257141 (10NicoV) [11:16:54] (03PS19) 10Daimona Eaytoy: Track taintedness of single array elements [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609500 (https://phabricator.wikimedia.org/T253875) [11:18:48] (03PS6) 10Daimona Eaytoy: Improve and simplify nodeIs* methods [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/607079 [11:19:03] (03PS10) 10Daimona Eaytoy: Improve handling of binary ops, extract method [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/607042 [11:23:59] 10Anti-Harassment: Harrassment and micro agression notification - https://phabricator.wikimedia.org/T268366 (10Aklapper) [11:24:02] 10Anti-Harassment: Epic⚡️ : User reporting system - https://phabricator.wikimedia.org/T166812 (10Aklapper) [11:28:28] (03PS5) 10Daimona Eaytoy: Use string templates to build issue messages [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609769 (https://phabricator.wikimedia.org/T256664) [11:28:48] 10WPCleaner: Create builders - https://phabricator.wikimedia.org/T257141 (10NicoV) [11:29:36] (03CR) 10jerkins-bot: [V: 04-1] Use string templates to build issue messages [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609769 (https://phabricator.wikimedia.org/T256664) (owner: 10Daimona Eaytoy) [11:30:20] 10Anti-Harassment: Epic⚡️ : User reporting system - https://phabricator.wikimedia.org/T166812 (10Nattes) Does this task include the creation of a micro agression data base for research to be done on the topic later? Without documentation. it is difficult to adress problems. And we should also be able to notify t... [11:39:26] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: skipped item IDs - https://phabricator.wikimedia.org/T44362 (10MisterSynergy) Reminder that this is still a thing: I maintain a weekly updated page that is tracking the number of skipped item IDs (among other things) at https://www.wikidata.org/wiki/User:... [11:41:57] (03PS20) 10Daimona Eaytoy: Add annotation to print taintedness of a variable [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/602736 (https://phabricator.wikimedia.org/T252261) [11:46:48] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Campsite: skipped item IDs - https://phabricator.wikimedia.org/T44362 (10Lydia_Pintscher) Urgh. Yeah, this is not good. I thought we make major headway on this issue with T232620 but apparently, that's not enough. Skipping over three quarters... [11:53:20] 10wikimedia.biterg.io, 10Developer-Advocacy (Oct-Dec 2020), 10Upstream: Provide equivalent of "SCR: Oldest open Gerrit changesets without code review" in Kibana - https://phabricator.wikimedia.org/T151560 (10Aklapper) 05Open→03Resolved a:03Aklapper [C_Gerrit_Open_Changesets](https://wikimedia.biterg.io... [11:53:38] 10wikimedia.biterg.io, 10Developer-Advocacy (Oct-Dec 2020), 10Upstream: Provide equivalent of "SCR: Oldest open Gerrit changesets without code review" in Kibana - https://phabricator.wikimedia.org/T151560 (10Aklapper) A separate, different task would be making the `C_Gerrit_Open_CR+1` and `C_Gerrit_Open_CR-1... [11:56:46] (03PS14) 10Aklapper: Add referer and origin check to edit token checking [core] - 10https://gerrit.wikimedia.org/r/65418 (https://phabricator.wikimedia.org/T40417) (owner: 10Parent5446) [11:57:32] 10MediaWiki-Authentication-and-authorization, 10TechCom-RFC, 10Patch-Needs-Improvement, 10Security: MediaWiki's anonymous edit token leaves wiki installations (incl. Wikipedia) open to mass anonymous spam we can't block - https://phabricator.wikimedia.org/T40417 (10Aklapper) [11:57:43] (03CR) 10jerkins-bot: [V: 04-1] Add referer and origin check to edit token checking [core] - 10https://gerrit.wikimedia.org/r/65418 (https://phabricator.wikimedia.org/T40417) (owner: 10Parent5446) [11:59:33] 10Anti-Harassment, 10CheckUser, 10I18n: CU 2.0: Investigate/Timeline: Logs displayed in wiki content language, not in investigator's user-configured language in preferences - https://phabricator.wikimedia.org/T268379 (10MarcoAurelio) [12:05:20] (03PS7) 10Daimona Eaytoy: Stringify taint values in SecuritCheckMulti issue messages [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/605269 [12:11:14] 10Anti-Harassment, 10CheckUser, 10Stewards-and-global-tools, 10I18n: CU 2.0: Special:CheckUser link on top of Special:Investigate cannot be translated - https://phabricator.wikimedia.org/T268380 (10MarcoAurelio) [12:11:22] (03PS3) 10Daimona Eaytoy: Do a better job in stringifying arguments when reporting issues [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609741 (https://phabricator.wikimedia.org/T256662) [12:11:43] 10Anti-Harassment, 10CheckUser, 10Stewards-and-global-tools, 10I18n: CU 2.0: Investigate/Timeline: Logs displayed in wiki content language, not in investigator's user-configured language in preferences - https://phabricator.wikimedia.org/T268379 (10MarcoAurelio) [12:12:15] (03CR) 10jerkins-bot: [V: 04-1] Do a better job in stringifying arguments when reporting issues [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609741 (https://phabricator.wikimedia.org/T256662) (owner: 10Daimona Eaytoy) [12:12:40] (03PS4) 10Daimona Eaytoy: Do a better job in stringifying arguments when reporting issues [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609741 (https://phabricator.wikimedia.org/T256662) [12:14:07] (03CR) 10jerkins-bot: [V: 04-1] Do a better job in stringifying arguments when reporting issues [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609741 (https://phabricator.wikimedia.org/T256662) (owner: 10Daimona Eaytoy) [12:21:42] (03PS5) 10Daimona Eaytoy: Do a better job in stringifying arguments when reporting issues [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609741 (https://phabricator.wikimedia.org/T256662) [12:22:08] 10Magnus Sälgö: Project "Stadens ansikte" - https://phabricator.wikimedia.org/T268374 (10Salgo60) [12:23:08] (03CR) 10jerkins-bot: [V: 04-1] Do a better job in stringifying arguments when reporting issues [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609741 (https://phabricator.wikimedia.org/T256662) (owner: 10Daimona Eaytoy) [12:24:21] 10Magnus Sälgö: Project "Stadens ansikte" - https://phabricator.wikimedia.org/T268374 (10Salgo60) [12:27:44] 10Magnus Sälgö: Project "Stadens ansikte" - https://phabricator.wikimedia.org/T268374 (10Salgo60) [12:29:56] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Campsite: skipped item IDs - https://phabricator.wikimedia.org/T44362 (10Bugreporter) Another idea is to allow user to reclaim Qids that are never used. Don't know how bad it is. [12:37:56] 10Magnus Sälgö: Project "Stadens ansikte" - https://phabricator.wikimedia.org/T268374 (10Salgo60) [12:39:00] (03PS6) 10Daimona Eaytoy: Use string templates to build issue messages [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609769 (https://phabricator.wikimedia.org/T256664) [12:39:32] (03PS7) 10Daimona Eaytoy: Use string templates to build issue messages [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609769 (https://phabricator.wikimedia.org/T256664) [12:40:43] (03PS6) 10Daimona Eaytoy: Do a better job in stringifying arguments when reporting issues [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609741 (https://phabricator.wikimedia.org/T256662) [12:41:43] (03PS7) 10Daimona Eaytoy: Do a better job in stringifying arguments when reporting issues [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609741 (https://phabricator.wikimedia.org/T256662) [12:43:04] (03CR) 10jerkins-bot: [V: 04-1] Do a better job in stringifying arguments when reporting issues [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609741 (https://phabricator.wikimedia.org/T256662) (owner: 10Daimona Eaytoy) [12:48:42] 10Magnus Sälgö: Evighetsrunor - https://phabricator.wikimedia.org/T268381 (10Salgo60) [12:51:04] (03PS1) 10Daimona Eaytoy: Add some important changes to the changelog [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/642646 [12:52:26] (03PS29) 10Daimona Eaytoy: Store taintedness in a value object [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609128 [12:52:35] (03PS15) 10Daimona Eaytoy: Introduce a value object for function taintedness [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609218 [12:53:16] (03PS16) 10Daimona Eaytoy: Introduce a value object for function taintedness [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609218 [12:53:27] (03PS20) 10Daimona Eaytoy: Track taintedness of single array elements [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609500 (https://phabricator.wikimedia.org/T253875) [12:54:43] 10MediaWiki-File-management, 10Beta-Cluster-Infrastructure, 10Commons, 10Wikimedia-SVG-rendering: Test resvg on Beta Cluster - https://phabricator.wikimedia.org/T243893 (10JoKalliauer) >>! In T243893#5874557, @Krinkle wrote: > Note that if we're mainly interested in comparing SVG renderings, it might be ea... [12:55:09] 10Magnus Sälgö: Evighetsrunor - https://phabricator.wikimedia.org/T268381 (10Salgo60) Try to explain why we dont want to use kulturnav Tackar för svar..... lite synpunkter. Vi vill ha något som löser behovet att peka på en runa hos Evighetsrunor och undvika alla dom problem vi har med ksamsök Som jag skriver n... [12:55:54] (03PS7) 10Daimona Eaytoy: Improve and simplify nodeIs* methods [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/607079 [12:56:01] (03PS11) 10Daimona Eaytoy: Improve handling of binary ops, extract method [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/607042 [12:56:48] (03PS8) 10Daimona Eaytoy: Use string templates to build issue messages [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609769 (https://phabricator.wikimedia.org/T256664) [12:57:19] (03PS8) 10Daimona Eaytoy: Do a better job in stringifying arguments when reporting issues [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609741 (https://phabricator.wikimedia.org/T256662) [12:58:39] (03CR) 10jerkins-bot: [V: 04-1] Do a better job in stringifying arguments when reporting issues [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609741 (https://phabricator.wikimedia.org/T256662) (owner: 10Daimona Eaytoy) [12:58:57] (03PS9) 10Daimona Eaytoy: Do a better job in stringifying arguments when reporting issues [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609741 (https://phabricator.wikimedia.org/T256662) [12:59:47] (03PS10) 10Daimona Eaytoy: Do a better job in stringifying arguments when reporting issues [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609741 (https://phabricator.wikimedia.org/T256662) [13:04:54] (03PS12) 10Daimona Eaytoy: Improve handling of binary ops, extract method [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/607042 [13:06:00] (03CR) 10jerkins-bot: [V: 04-1] Improve handling of binary ops, extract method [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/607042 (owner: 10Daimona Eaytoy) [13:11:19] 10ContentTranslation, 10Mobile: Problems while using Content Translation on mobile devices - https://phabricator.wikimedia.org/T268197 (10Aklapper) [13:11:21] 10ContentTranslation, 10Language-strategy, 10Epic, 10Mobile: [Epic] Mobile stategy for ContentTranslation - https://phabricator.wikimedia.org/T105190 (10Aklapper) [13:32:28] (03PS2) 10Florianschmidtwelzow: Mention new required php extension intl [core] - 10https://gerrit.wikimedia.org/r/640474 (https://phabricator.wikimedia.org/T267669) [13:32:50] (03CR) 10Florianschmidtwelzow: "> Patch Set 1: Code-Review-1" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/640474 (https://phabricator.wikimedia.org/T267669) (owner: 10Florianschmidtwelzow) [13:32:54] (03CR) 10jerkins-bot: [V: 04-1] Mention new required php extension intl [core] - 10https://gerrit.wikimedia.org/r/640474 (https://phabricator.wikimedia.org/T267669) (owner: 10Florianschmidtwelzow) [13:33:36] (03PS3) 10Florianschmidtwelzow: Mention new required php extension intl [core] - 10https://gerrit.wikimedia.org/r/640474 (https://phabricator.wikimedia.org/T267669) [13:33:49] (03CR) 10Florianschmidtwelzow: "PS3 is a rebase only." [core] - 10https://gerrit.wikimedia.org/r/640474 (https://phabricator.wikimedia.org/T267669) (owner: 10Florianschmidtwelzow) [13:34:53] (03CR) 10Reedy: [C: 04-1] "be" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/640474 (https://phabricator.wikimedia.org/T267669) (owner: 10Florianschmidtwelzow) [13:36:51] (03CR) 10jerkins-bot: [V: 04-1] Mention new required php extension intl [core] - 10https://gerrit.wikimedia.org/r/640474 (https://phabricator.wikimedia.org/T267669) (owner: 10Florianschmidtwelzow) [13:37:41] 10MinervaNeue, 10MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), 10Readers-Web-Backlog (Kanbanana-FY-2020-21): AMC: MinervaNeue shows external link icon on the last edited bar - https://phabricator.wikimedia.org/T267464 (10RodneyAraujo) I'm having also the issue, see screenshots: == Spanish Wikipedia == {F33921... [13:40:41] (03PS1) 10Daimona Eaytoy: (MW) Avoid crash when Hooks::run has no arguments array [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/642647 [13:42:01] (03PS2) 10Daimona Eaytoy: (MW) Avoid crash when Hooks::run has no arguments array [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/642647 [13:48:34] (03PS4) 10Florianschmidtwelzow: Mention new required php extension intl [core] - 10https://gerrit.wikimedia.org/r/640474 (https://phabricator.wikimedia.org/T267669) [13:49:30] (03CR) 10Florianschmidtwelzow: Mention new required php extension intl (031 comment) [core] - 10https://gerrit.wikimedia.org/r/640474 (https://phabricator.wikimedia.org/T267669) (owner: 10Florianschmidtwelzow) [13:54:27] 10MediaWiki-Core-Testing, 10Security-Team, 10phan-taint-check-plugin, 10MW-1.35-notes (1.35.0-wmf.32; 2020-05-12), 10Patch-For-Review: Suppress or fix non-double escape phan-taint-check warnings for MW core - https://phabricator.wikimedia.org/T216348 (10Daimona) With mw-phan 0.10.4 we have 157 errors, 10... [13:57:48] (03PS13) 10Daimona Eaytoy: Improve handling of binary ops, extract method [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/607042 [13:59:06] (03CR) 10jerkins-bot: [V: 04-1] Improve handling of binary ops, extract method [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/607042 (owner: 10Daimona Eaytoy) [14:07:53] 10ContentTranslation, 10Mobile: Problems while using Content Translation on mobile devices - https://phabricator.wikimedia.org/T268197 (10RodneyAraujo) I've made drawings of the mobile design of ContentTranslation, specially, the Content Translation Mobile editor: {F33921312} And the publish mobile message:... [14:08:56] (03PS14) 10Daimona Eaytoy: Improve handling of binary ops, extract method [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/607042 [14:32:26] 10Magnus Sälgö: Evighetsrunor - https://phabricator.wikimedia.org/T268381 (10Salgo60) [14:36:15] 10MediaWiki-Language-converter: Completely remove Kazakh language converter - https://phabricator.wikimedia.org/T268143 (10Arystanbek) @Amire80 who can solve these problems? @MuratKaribay also found some critical problems. We receive complaints from users every day but we don't have permission to remove this use... [14:47:23] (03CR) 10Cicalese: "> Patch Set 1:" [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/640966 (owner: 10Cicalese) [15:10:20] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2020-October-December): Create development and testing environment for translation memory - https://phabricator.wikimedia.org/T267030 (10abi_) Ran `setup-03-launch-mediawiki-docker.sh` from the docker scripts. ## Notes 1. Was able to deploy the scri... [15:13:29] 10MediaWiki-Watchlist, 10Growth-Team: Increase the number of entries shown on the watchlist (wllimit) - https://phabricator.wikimedia.org/T151165 (10C.Suthorn) I have spent a quarter of an hour trying to find the comment, but could not locate it. it is on a page on meta or on commons probably in the commons na... [15:57:24] 10MediaViewer: Image not loading - https://phabricator.wikimedia.org/T268383 (10Ebirah766) [16:24:40] 10MediaViewer: Image not loading - https://phabricator.wikimedia.org/T268383 (10Aklapper) 05Open→03Invalid @Ebirah766: Thanks for reporting this, however Wikimedia cannot do anything about problems on other websites. Please report problems on that website to the maintainers of that website, so they can fix t... [16:58:25] 10Design, 10MediaWiki-General: Rolling out the new logo of MediaWiki - https://phabricator.wikimedia.org/T268230 (10Ladsgroup) [17:08:49] 10Design, 10MediaWiki-General: Rolling out the new logo of MediaWiki - https://phabricator.wikimedia.org/T268230 (10Ladsgroup) [17:14:32] (03PS1) 10Daniel Kinzler: WIP: extract helper classes from PageHTMLHandler [core] - 10https://gerrit.wikimedia.org/r/642652 (https://phabricator.wikimedia.org/T267981) [17:36:21] (03CR) 10jerkins-bot: [V: 04-1] WIP: extract helper classes from PageHTMLHandler [core] - 10https://gerrit.wikimedia.org/r/642652 (https://phabricator.wikimedia.org/T267981) (owner: 10Daniel Kinzler) [18:02:26] 10TimedMediaHandler, 10I18n: Some string need a variable to easy localize in TimedMediaHandler interface - https://phabricator.wikimedia.org/T61181 (10Aklapper) 05Open→03Stalled It's unclear to me what this task is asking for nowadays, when it comes to language formatting on numbers. :( @YFdyh000: Could y... [18:03:32] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Story: [Story] API module to list sitegroups usable for sitelinks - https://phabricator.wikimedia.org/T60200 (10Aklapper) [18:03:46] (03PS21) 10Daimona Eaytoy: Track taintedness of single array elements [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609500 (https://phabricator.wikimedia.org/T253875) [18:05:07] (03CR) 10jerkins-bot: [V: 04-1] Track taintedness of single array elements [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609500 (https://phabricator.wikimedia.org/T253875) (owner: 10Daimona Eaytoy) [18:06:10] 10MediaWiki-Page-editing, 10User-notice: Allow posting new sections to top of page on a per-page basis - https://phabricator.wikimedia.org/T33919 (10Aklapper) Removing #easy; see review in now (abandoned) https://gerrit.wikimedia.org/r/c/mediawiki/core/+/209853/ [18:07:03] 10Stewards-and-global-tools, 10Wikimedia-General-or-Unknown, 10Graphite: Create grafana dashboard for stewards showing number of blocks per wiki - https://phabricator.wikimedia.org/T116878 (10Aklapper) Removing #easy per T116878#3440288 [18:08:27] 10MediaWiki-extension-requests: Add edit history graph(s) to MediaWiki's info action - https://phabricator.wikimedia.org/T43329 (10Aklapper) Writing an extension from scratch does not sound like #easy. [18:12:34] 10ULS-CompactLinks, 10UniversalLanguageSelector, 10good first task: The caret color needs adjustment in different instances of ULS - https://phabricator.wikimedia.org/T184688 (10Aklapper) 05Open→03Resolved Not here on en.wikipedia.org with standard Vector {F33921445} [18:13:21] 10TimedMediaHandler, 10I18n: Untranslatable timestamps in timedmedia-in-job-queue, timedmedia-started-transcode - https://phabricator.wikimedia.org/T69960 (10Aklapper) Zero docs. Hence removing #easy. [18:19:15] 10CX-deployments, 10WorkType-NewFunctionality: Provide engine information in TMX dumps - https://phabricator.wikimedia.org/T146885 (10Aklapper) A #good_first_task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor. G... [18:24:21] (03CR) 10DannyS712: [C: 04-1] Use generator in SpecialPageFatalTest (031 comment) [core] - 10https://gerrit.wikimedia.org/r/642644 (owner: 10Ammarpad) [18:25:51] 10OOUI, 10Documentation: Find alternative solution to connect OOUI documentation and implemented widgets - https://phabricator.wikimedia.org/T164339 (10Aklapper) I don't see why this is tagged as #easy (see its description). Which exact pages is this about ( https://www.mediawiki.org/wiki/OOUI has no images )... [18:28:23] (03CR) 10Jforrester: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.10.4 [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/642618 (owner: 10Libraryupgrader) [18:28:33] (03CR) 10Jforrester: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.10.4 [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/642605 (owner: 10Libraryupgrader) [18:28:48] (03PS22) 10Daimona Eaytoy: Track taintedness of single array elements [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609500 (https://phabricator.wikimedia.org/T253875) [18:29:49] 10MediaWiki-Interface, 10I18n, 10Tracking-Neverending: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - https://phabricator.wikimedia.org/T40638 (10Aklapper) [18:35:11] 10MediaWiki-Core-Testing, 10MediaWiki-General: @mixins annotation is rejected by eslint - https://phabricator.wikimedia.org/T268378 (10Jdforrester-WMF) If you're using jsduck still, use the `wikimedia/jsduck` profile, which accepts `@mixins`. Default is for jsdoc compatibility, with requires `@mixes` tags inst... [18:37:19] 10MediaWiki-Core-Testing, 10MediaWiki-General: @mixins annotation is rejected by eslint - https://phabricator.wikimedia.org/T268378 (10Jdforrester-WMF) Also, the venue for this is either https://www.mediawiki.org/wiki/Manual_talk:Coding_conventions/JavaScript for "what should the CI policy be" or https://githu... [18:39:06] 10MediaWiki-Core-Testing, 10MediaWiki-General: @mixins annotation is rejected by eslint - https://phabricator.wikimedia.org/T268378 (10DannyS712) >>! In T268378#6638360, @Jdforrester-WMF wrote: > Also, the venue for this is either https://www.mediawiki.org/wiki/Manual_talk:Coding_conventions/JavaScript for "wh... [18:39:50] 10MediaWiki-Core-Testing, 10MediaWiki-General: @mixins annotation is rejected by eslint - https://phabricator.wikimedia.org/T268378 (10Jdforrester-WMF) >>! In T268378#6638361, @DannyS712 wrote: >>>! In T268378#6638360, @Jdforrester-WMF wrote: >> Also, the venue for this is either https://www.mediawiki.org/wiki... [18:45:56] 10Mobile, 10Readers-Web-Backlog (Tracking), 10Vector (Responsive-Vector): On smaller screen width, pages with pending review do not show version history tab - https://phabricator.wikimedia.org/T265875 (10Aklapper) p:05Triage→03Lowest [18:46:18] (03PS2) 10Ammarpad: Use generator in SpecialPageFatalTest [core] - 10https://gerrit.wikimedia.org/r/642644 [18:46:23] 10netbox: Restrict CreateManagementInterface to certain statuses and device types - https://phabricator.wikimedia.org/T250287 (10Aklapper) @crusnov: Can this task be resolved, or is there more to do? [18:47:45] 10MediaWiki-Logevents, 10Patch-Needs-Improvement, 10Platform Engineering (Icebox), 10good first task: Add a hook to modify $wgLogTypes / LogPage::validTypes() at runtime - https://phabricator.wikimedia.org/T200385 (10Aklapper) a:05AdhamKhatean→03None @AdhamKhatean: I am resetting the assignee of this t... [18:49:23] 10Technical-blog-posts: Story idea for Blog: What's new in MediaWiki 1.35 series - https://phabricator.wikimedia.org/T258257 (10Aklapper) 05Resolved→03Declined a:05srodlund→03None @srodlund: No reply, assuming this unfortunately did not happen as I don't see anything in https://techblog.wikimedia.org/tag... [18:51:14] (03CR) 10DannyS712: [C: 03+2] Use generator in SpecialPageFatalTest [core] - 10https://gerrit.wikimedia.org/r/642644 (owner: 10Ammarpad) [18:54:04] 10TimedMediaHandler, 10I18n: Some string need a variable to easy localize in TimedMediaHandler interface - https://phabricator.wikimedia.org/T61181 (10YFdyh000) >>! In T61181#6638334, @Aklapper wrote: > It's unclear to me what this task is asking for nowadays, when it comes to language formatting on numbers. :... [18:57:59] (03CR) 10Jforrester: [C: 03+2] Store taintedness in a value object [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609128 (owner: 10Daimona Eaytoy) [18:59:27] (03Merged) 10jenkins-bot: Store taintedness in a value object [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609128 (owner: 10Daimona Eaytoy) [19:01:09] (03CR) 10Jforrester: [C: 03+2] Introduce a value object for function taintedness [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609218 (owner: 10Daimona Eaytoy) [19:02:17] (03Merged) 10jenkins-bot: Introduce a value object for function taintedness [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609218 (owner: 10Daimona Eaytoy) [19:05:25] (03CR) 10Jforrester: [C: 03+2] Track taintedness of single array elements [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609500 (https://phabricator.wikimedia.org/T253875) (owner: 10Daimona Eaytoy) [19:06:31] (03Merged) 10jenkins-bot: Track taintedness of single array elements [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609500 (https://phabricator.wikimedia.org/T253875) (owner: 10Daimona Eaytoy) [19:08:32] 10Design, 10MediaWiki-General: Rolling out the new logo of MediaWiki - https://phabricator.wikimedia.org/T268230 (10Ladsgroup) Monobook and Timeless: {F33921458} {F33921460} [19:11:11] (03CR) 10Jforrester: [C: 03+2] (MW) Avoid crash when Hooks::run has no arguments array [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/642647 (owner: 10Daimona Eaytoy) [19:12:10] (03Merged) 10jenkins-bot: (MW) Avoid crash when Hooks::run has no arguments array [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/642647 (owner: 10Daimona Eaytoy) [19:14:37] 10TimedMediaHandler, 10I18n: Some string need a variable to easy localize in TimedMediaHandler interface - https://phabricator.wikimedia.org/T61181 (10Aklapper) @YFdyh000: Let me help with a `Special:TimedMediaHandler` screenshot then. :) https://translatewiki.net/wiki/MediaWiki:Timedmedia-webm-videos/zh-hans... [19:16:59] 10MediaWiki-Page-deletion, 10Wikidata: Provide a list instead of "Warning: Other pages link to or transclude the page you are about to delete." - https://phabricator.wikimedia.org/T254434 (10DannyS712) p:05Triage→03Medium [19:17:57] 10MediaWiki-General, 10Technical-Debt: TODO: remove B/C hack in 1.32! - https://phabricator.wikimedia.org/T254397 (10DannyS712) Still there in 1.36 https://codesearch.wmcloud.org/core/?q=remove%20B%5C%2FC&i=nope&files=&repos= * https://gerrit.wikimedia.org/g/mediawiki/core/+/a638c0dce0b5a71c3c42ddf7e38e11e7bcd... [19:18:03] (03Merged) 10jenkins-bot: Use generator in SpecialPageFatalTest [core] - 10https://gerrit.wikimedia.org/r/642644 (owner: 10Ammarpad) [19:19:21] (03PS8) 10Daimona Eaytoy: Improve and simplify nodeIs* methods [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/607079 [19:20:30] 10MediaWiki-extensions-CentralNotice, 10MediaWiki-extensions-OAuth, 10CirrusSearch, 10Discovery-Search, and 15 others: Clean up PSR12.Properties.ConstantVisibility.NotFound phpcs exclusion in WMF Prod - https://phabricator.wikimedia.org/T253169 (10DannyS712) Not about mediawiki core [19:21:15] (03PS2) 10Daimona Eaytoy: Add some important changes to the changelog [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/642646 [19:26:19] (03PS9) 10Daimona Eaytoy: Use string templates to build issue messages [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609769 (https://phabricator.wikimedia.org/T256664) [19:26:32] (03PS11) 10Daimona Eaytoy: Do a better job in stringifying arguments when reporting issues [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609741 (https://phabricator.wikimedia.org/T256662) [19:27:18] 10TimedMediaHandler, 10I18n: Some string need a variable to easy localize in TimedMediaHandler interface - https://phabricator.wikimedia.org/T61181 (10YFdyh000) >>! In T61181#6638384, @Aklapper wrote: > @YFdyh000: Let me help with a `Special:TimedMediaHandler` screenshot then. :) > https://translatewiki.net/wi... [19:27:33] (03PS21) 10Daimona Eaytoy: Add annotation to print taintedness of a variable [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/602736 (https://phabricator.wikimedia.org/T252261) [19:27:44] (03CR) 10jerkins-bot: [V: 04-1] Do a better job in stringifying arguments when reporting issues [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609741 (https://phabricator.wikimedia.org/T256662) (owner: 10Daimona Eaytoy) [19:28:32] (03CR) 10jerkins-bot: [V: 04-1] Add annotation to print taintedness of a variable [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/602736 (https://phabricator.wikimedia.org/T252261) (owner: 10Daimona Eaytoy) [19:28:40] 10TimedMediaHandler, 10I18n: Some string need a variable to easy localize in TimedMediaHandler interface - https://phabricator.wikimedia.org/T61181 (10Aklapper) ...but is it a problem in code (so this Phab task is still valid), or can the issue be fixed by editing existing Chinese translations on twn (which wo... [19:29:47] (03PS8) 10Daimona Eaytoy: Stringify taint values in SecuritCheckMulti issue messages [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/605269 [19:31:51] 10TimedMediaHandler, 10I18n: Some string need a variable to easy localize in TimedMediaHandler interface - https://phabricator.wikimedia.org/T61181 (10YFdyh000) >>! In T61181#6638395, @Aklapper wrote: > ...but is it a problem in code (so this Phab task is still valid), or can the issue be fixed by editing exis... [19:34:13] 10TimedMediaHandler, 10I18n: Some string need a variable to easy localize in TimedMediaHandler interface - https://phabricator.wikimedia.org/T61181 (10Aklapper) 05Stalled→03Open [19:34:19] (03PS15) 10Daimona Eaytoy: Improve handling of binary ops, extract method [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/607042 [19:35:02] 10TimedMediaHandler, 10I18n: Allow language formatting / localization on some number strings in the TimedMediaHandler interface - https://phabricator.wikimedia.org/T61181 (10Aklapper) [19:35:20] (03CR) 10jerkins-bot: [V: 04-1] Improve handling of binary ops, extract method [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/607042 (owner: 10Daimona Eaytoy) [19:36:36] 10MediaWiki-General, 10Platform Engineering, 10Dependency injection: ExtensionRegistry is difficult to use as a singleton - https://phabricator.wikimedia.org/T257586 (10DannyS712) [19:37:06] (03PS22) 10Daimona Eaytoy: Add annotation to print taintedness of a variable [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/602736 (https://phabricator.wikimedia.org/T252261) [19:38:07] (03CR) 10jerkins-bot: [V: 04-1] Add annotation to print taintedness of a variable [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/602736 (https://phabricator.wikimedia.org/T252261) (owner: 10Daimona Eaytoy) [19:38:09] (03PS16) 10Daimona Eaytoy: Improve handling of binary ops, extract method [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/607042 [19:38:47] (03PS23) 10Daimona Eaytoy: Add annotation to print taintedness of a variable [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/602736 (https://phabricator.wikimedia.org/T252261) [19:39:11] (03CR) 10jerkins-bot: [V: 04-1] Improve handling of binary ops, extract method [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/607042 (owner: 10Daimona Eaytoy) [19:40:04] (03CR) 10jerkins-bot: [V: 04-1] Add annotation to print taintedness of a variable [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/602736 (https://phabricator.wikimedia.org/T252261) (owner: 10Daimona Eaytoy) [19:41:47] (03PS22) 10Daimona Eaytoy: Refine taintedness based on real type of variables [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/606816 (https://phabricator.wikimedia.org/T255935) [19:43:05] (03PS24) 10Daimona Eaytoy: Add annotation to print taintedness of a variable [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/602736 (https://phabricator.wikimedia.org/T252261) [19:43:09] (03CR) 10jerkins-bot: [V: 04-1] Refine taintedness based on real type of variables [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/606816 (https://phabricator.wikimedia.org/T255935) (owner: 10Daimona Eaytoy) [19:43:21] (03PS2) 10Jforrester: build: Updating npm dependencies [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/642657 (owner: 10Libraryupgrader) [19:43:29] (03CR) 10Jforrester: [C: 03+2] build: Updating npm dependencies [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/642657 (owner: 10Libraryupgrader) [19:58:59] (03PS23) 10Daimona Eaytoy: Refine taintedness based on real type of variables [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/606816 (https://phabricator.wikimedia.org/T255935) [20:00:06] (03CR) 10jerkins-bot: [V: 04-1] Refine taintedness based on real type of variables [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/606816 (https://phabricator.wikimedia.org/T255935) (owner: 10Daimona Eaytoy) [20:26:29] 10MediaWiki-extensions-Translate: Translate tags appear when transcluding a translatable page - https://phabricator.wikimedia.org/T268362 (10Nikerabbit) You might want to subscribe to {T47096}. [20:35:47] 10CopyPatrol, 10Community-Tech (Kanban-2020-21-Q2), 10Turkish-Sites: Add Turkish Wikipedia support for CopyPatrol tool - https://phabricator.wikimedia.org/T266696 (10Evolutionoftheuniverse) @MusikAnimal , is it possible to add WikiProjects column? trwiki has PageAssesments extension. [20:40:28] 10Thumbor, 10Wikimedia-SVG-rendering, 10Upstream: Incorrect text positioning in SVG with tspan element and text-anchor attribute - https://phabricator.wikimedia.org/T97233 (10Aklapper) I upstreamed as https://gitlab.gnome.org/GNOME/librsvg/-/issues/651 [20:40:46] 10Thumbor, 10Wikimedia-SVG-rendering, 10Upstream: Incorrect text positioning in SVG with tspan element and text-anchor attribute - https://phabricator.wikimedia.org/T97233 (10Aklapper) [20:42:46] 10MediaWiki-Core-Skin-Architecture, 10MediaWiki-Interface, 10MonoBook, 10Timeless, and 2 others: Hard deprecate BaseTemplate::getFooterIcons - https://phabricator.wikimedia.org/T267447 (10Jdlrobson) BaseTemplate::getFooterIcons is being hard deprecated NOT SkinTemplate::getFooterIcons, which is the pr Ope... [20:43:48] 10MediaWiki-Core-Skin-Architecture, 10MediaWiki-Interface, 10MW-1.36-notes (1.36.0-wmf.20; 2020-12-01): Hard deprecate Html::infoBox - https://phabricator.wikimedia.org/T268078 (10Jdlrobson) 05Open→03Resolved [20:43:52] 10MediaWiki-Installer, 10UI-Standardization, 10MW-1.35-notes, 10MW-1.36-notes (1.36.0-wmf.3; 2020-08-04), and 4 others: Standardise `.mw-infobox` by relying on `.warningbox` - https://phabricator.wikimedia.org/T232903 (10Jdlrobson) [20:44:52] 10ParserFunctions, 10Community-Wishlist-Survey-2015: ifexist function uses pagelinks table in lieu of better options - https://phabricator.wikimedia.org/T14019 (10Umherirrender) Such a feature would also be helpful for core and should be usable by the extensions. The feature needs to take an database table to... [20:47:24] (03CR) 10Umherirrender: "> Patch Set 3:" [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/621883 (https://phabricator.wikimedia.org/T268360) (owner: 10Umherirrender) [20:49:38] (03PS2) 10Umherirrender: Improve and add documentation to import/export related classes [core] - 10https://gerrit.wikimedia.org/r/642598 [20:50:04] (03CR) 10Umherirrender: Improve and add documentation to import/export related classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/642598 (owner: 10Umherirrender) [20:50:48] 10Design, 10MediaWiki-General, 10Epic: Reimplement MediaWiki's info action (tracking) - https://phabricator.wikimedia.org/T40450 (10Aklapper) p:05Medium→03Low [20:55:53] 10InternetArchiveBot: SQL error message on submitting job - https://phabricator.wikimedia.org/T265840 (10Weblars) I've search the source code for the frase //`externallinks_user` WHERE `user_link_id` IN// which appears in the error message. I found it in the function loadLogUsers of the file [[ https://github.c... [21:03:15] 10MediaWiki-extensions-OpenID-Connect: Authentication failure due to Jumbojett\OpenIDConnectClientException: Unable to determine state - https://phabricator.wikimedia.org/T268249 (10DaLynX) Thank you for pointing me to the cache. I installed Memcache and switched MainCache and SessionCache (and a couple others)... [21:03:57] 10MediaWiki-extensions-OpenID-Connect: Authentication failure due to Jumbojett\OpenIDConnectClientException: Unable to determine state - https://phabricator.wikimedia.org/T268249 (10DaLynX) 05Open→03Resolved a:03DaLynX [21:18:25] (03PS4) 10Ladsgroup: Migrate job to abstract schema [core] - 10https://gerrit.wikimedia.org/r/641701 (https://phabricator.wikimedia.org/T230428) (owner: 10Ammarpad) [21:18:32] (03CR) 10Ladsgroup: "check postgres" [core] - 10https://gerrit.wikimedia.org/r/641701 (https://phabricator.wikimedia.org/T230428) (owner: 10Ammarpad) [21:19:03] (03CR) 10Ladsgroup: Migrate job to abstract schema (031 comment) [core] - 10https://gerrit.wikimedia.org/r/641701 (https://phabricator.wikimedia.org/T230428) (owner: 10Ammarpad) [21:31:53] 10MediaWiki-General: Retain section anchor in URL when clicking "Permanent link" link in the sidebar - https://phabricator.wikimedia.org/T228728 (10DannyS712) Coming back to this: Per https://stackoverflow.com/questions/2317508/get-fragment-value-after-hash-from-a-url-in-php this doesn't seem possible in php In... [21:34:35] 10MonoBook, 10TestMe: Responsive monobook personal tools icon randomly on left - https://phabricator.wikimedia.org/T230592 (10Aklapper) 05Open→03Stalled Setting to stalled per previous comment. Cannot reproduce either in FF83: {F33921629} [21:36:23] 10InternetArchiveBot: SQL error message on submitting job - https://phabricator.wikimedia.org/T265840 (10Nintendofan885) @Weblars I've created a pull request [[https://github.com/internetarchive/internetarchivebot/pull/12|here]] [21:39:37] 10MediaWiki-Installer, 10MW-1.35-release: Revisions created while MW 1.35 maintenance/update.php is running risk becoming inaccessible without explanation, rendering articles uneditable - https://phabricator.wikimedia.org/T268387 (10Carlb) [21:40:38] 10MediaWiki-extensions-OpenID-Connect: Authentication failure due to Jumbojett\OpenIDConnectClientException: Unable to determine state - https://phabricator.wikimedia.org/T268249 (10cicalese) Great! I'm glad to hear that it is now working. [21:42:26] (03PS5) 10Ladsgroup: Migrate job to abstract schema [core] - 10https://gerrit.wikimedia.org/r/641701 (https://phabricator.wikimedia.org/T230428) (owner: 10Ammarpad) [21:46:34] (03PS6) 10Ladsgroup: Migrate job to abstract schema [core] - 10https://gerrit.wikimedia.org/r/641701 (https://phabricator.wikimedia.org/T230428) (owner: 10Ammarpad) [21:49:10] (03CR) 10Ladsgroup: "check postgres" [core] - 10https://gerrit.wikimedia.org/r/641701 (https://phabricator.wikimedia.org/T230428) (owner: 10Ammarpad) [21:58:53] (03CR) 10Ladsgroup: Migrate new_talk to abstract schema (031 comment) [core] - 10https://gerrit.wikimedia.org/r/635908 (owner: 10Ammarpad) [22:00:30] 10MediaWiki-extensions-OpenID-Connect: Authentication failure due to Jumbojett\OpenIDConnectClientException: Unable to determine state (due to using CACHE_ACCEL) - https://phabricator.wikimedia.org/T268249 (10Aklapper) 05Resolved→03Invalid a:05DaLynX→03None [22:06:45] (03PS1) 10Ladsgroup: Fix un_user_ip index columns [core] - 10https://gerrit.wikimedia.org/r/642680 (https://phabricator.wikimedia.org/T230428) [22:07:01] (03PS2) 10Ladsgroup: Fix un_user_ip index column [core] - 10https://gerrit.wikimedia.org/r/642680 (https://phabricator.wikimedia.org/T230428) [22:07:35] (03CR) 10DannyS712: [C: 03+2] build: Updating npm dependencies [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/642671 (owner: 10Libraryupgrader) [22:07:48] (03PS3) 10Ladsgroup: Fix un_user_ip index column [core] - 10https://gerrit.wikimedia.org/r/642680 (https://phabricator.wikimedia.org/T230428) [22:12:44] (03CR) 10DannyS712: [C: 03+1] Add some important changes to the changelog [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/642646 (owner: 10Daimona Eaytoy) [22:14:17] (03CR) 10Reedy: [C: 03+2] Fix un_user_ip index column [core] - 10https://gerrit.wikimedia.org/r/642680 (https://phabricator.wikimedia.org/T230428) (owner: 10Ladsgroup) [22:15:10] (03CR) 10DannyS712: [C: 04-1] Use const for ForeignAPIRepo::$imageInfoProps (031 comment) [core] - 10https://gerrit.wikimedia.org/r/642593 (owner: 10Umherirrender) [22:15:44] (03CR) 10DannyS712: [C: 03+2] Use consts in IcuCollation class [core] - 10https://gerrit.wikimedia.org/r/642585 (owner: 10Umherirrender) [22:16:01] (03CR) 10DannyS712: [C: 03+2] Use const for ChangeTags::$definedSoftwareTags [core] - 10https://gerrit.wikimedia.org/r/642584 (owner: 10Umherirrender) [22:17:32] (03CR) 10DannyS712: [C: 04-1] Use consts in ApiMain class (032 comments) [core] - 10https://gerrit.wikimedia.org/r/642573 (owner: 10Umherirrender) [22:17:41] (03CR) 10DannyS712: [C: 03+2] build: Updating npm dependencies [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/642679 (owner: 10Libraryupgrader) [22:18:25] (03CR) 10Ladsgroup: Migrate watchlist table to Abstract schema (031 comment) [core] - 10https://gerrit.wikimedia.org/r/634943 (https://phabricator.wikimedia.org/T230428) (owner: 10Ammarpad) [22:24:26] (03PS24) 10Daimona Eaytoy: Refine taintedness based on real type of variables [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/606816 (https://phabricator.wikimedia.org/T255935) [22:25:36] (03CR) 10jerkins-bot: [V: 04-1] Refine taintedness based on real type of variables [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/606816 (https://phabricator.wikimedia.org/T255935) (owner: 10Daimona Eaytoy) [22:27:20] (03PS25) 10Daimona Eaytoy: Refine taintedness based on real type of variables [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/606816 (https://phabricator.wikimedia.org/T255935) [22:30:58] (03PS25) 10Daimona Eaytoy: Add annotation to print taintedness of a variable [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/602736 (https://phabricator.wikimedia.org/T252261) [22:31:02] (03PS1) 10Reedy: Fix trailing ; in patch-sites-site_language-35.sql [core] - 10https://gerrit.wikimedia.org/r/642683 [22:31:36] (03PS1) 10Reedy: Fix trailing ; in patch-sites-site_language-35.sql [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/642434 [22:31:42] (03PS9) 10Daimona Eaytoy: Stringify taint values in SecuritCheckMulti issue messages [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/605269 [22:31:51] (03CR) 10Ladsgroup: [C: 03+2] "LMAO" [core] - 10https://gerrit.wikimedia.org/r/642683 (owner: 10Reedy) [22:31:53] (03CR) 10DannyS712: [C: 04-1] "I started with giving a +2 on each thing I checked, since I didn't think I could get through it all at once, but I did, so +2 to everythin" (0319 comments) [core] - 10https://gerrit.wikimedia.org/r/642589 (owner: 10Umherirrender) [22:32:40] (03CR) 10DannyS712: "Isn't the issue that its missing, not that it is trailing?" [core] - 10https://gerrit.wikimedia.org/r/642683 (owner: 10Reedy) [22:33:25] (03CR) 10Reedy: ""Fix trailing ;" is one way of saying adding it" [core] - 10https://gerrit.wikimedia.org/r/642683 (owner: 10Reedy) [22:38:16] (03PS17) 10Daimona Eaytoy: Improve handling of binary ops, extract method [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/607042 [22:38:47] (03PS7) 10Ladsgroup: Migrate job to abstract schema [core] - 10https://gerrit.wikimedia.org/r/641701 (https://phabricator.wikimedia.org/T230428) (owner: 10Ammarpad) [22:39:43] (03CR) 10Ladsgroup: Migrate job to abstract schema (031 comment) [core] - 10https://gerrit.wikimedia.org/r/641701 (https://phabricator.wikimedia.org/T230428) (owner: 10Ammarpad) [22:40:17] (03Merged) 10jenkins-bot: Fix un_user_ip index column [core] - 10https://gerrit.wikimedia.org/r/642680 (https://phabricator.wikimedia.org/T230428) (owner: 10Ladsgroup) [22:40:23] (03Merged) 10jenkins-bot: Use consts in IcuCollation class [core] - 10https://gerrit.wikimedia.org/r/642585 (owner: 10Umherirrender) [22:40:25] (03CR) 10DannyS712: [C: 04-1] Improve and add documentation to import/export related classes (034 comments) [core] - 10https://gerrit.wikimedia.org/r/642598 (owner: 10Umherirrender) [22:40:29] (03Merged) 10jenkins-bot: Use const for ChangeTags::$definedSoftwareTags [core] - 10https://gerrit.wikimedia.org/r/642584 (owner: 10Umherirrender) [22:40:32] (03CR) 10Ladsgroup: [C: 03+2] "Tested locally, checked everything, fixed some stuff here and there." [core] - 10https://gerrit.wikimedia.org/r/641701 (https://phabricator.wikimedia.org/T230428) (owner: 10Ammarpad) [22:41:43] (03PS12) 10Daimona Eaytoy: Do a better job in stringifying arguments when reporting issues [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/609741 (https://phabricator.wikimedia.org/T256662) [22:42:09] 10MediaWiki-Installer, 10MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), 10MW-1.36-notes (1.36.0-wmf.20; 2020-12-01), 10Patch-For-Review, and 3 others: Migrate tables.sql to abstract schema - https://phabricator.wikimedia.org/T230428 (10Ladsgroup) [22:44:06] (03PS1) 10Daimona Eaytoy: Upgrade phan to 3.2.4 [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/642684 (https://phabricator.wikimedia.org/T250170) [22:44:08] (03CR) 10DannyS712: "Broke AdvancedSearch tests, see https://gerrit.wikimedia.org/r/c/mediawiki/extensions/AdvancedSearch/+/642660" [core] - 10https://gerrit.wikimedia.org/r/635579 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [22:44:47] (03CR) 10Daimona Eaytoy: [C: 04-2] "I'd like to have I2f5d894b97315a889a74225d8384243ac9a304b9 merged first" [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/642684 (https://phabricator.wikimedia.org/T250170) (owner: 10Daimona Eaytoy) [22:50:22] (03PS1) 10Ladsgroup: Add patch to set wl_notificationtimestamp BINARY(14) [core] - 10https://gerrit.wikimedia.org/r/642685 (https://phabricator.wikimedia.org/T230428) [22:51:48] (03CR) 10DannyS712: NamespaceDefTest: fix namespaces (032 comments) [core] - 10https://gerrit.wikimedia.org/r/642643 (owner: 10Gergő Tisza) [22:54:22] 10MediaWiki-Installer, 10MW-1.35-release: Revisions created while MW 1.35 maintenance/update.php is running risk becoming inaccessible without explanation, rendering articles uneditable - https://phabricator.wikimedia.org/T268387 (10RhinosF1) Doesn't the update guide advise making the wiki read only while upda... [22:55:30] (03Merged) 10jenkins-bot: Fix trailing ; in patch-sites-site_language-35.sql [core] - 10https://gerrit.wikimedia.org/r/642683 (owner: 10Reedy) [23:02:46] (03Merged) 10jenkins-bot: Migrate job to abstract schema [core] - 10https://gerrit.wikimedia.org/r/641701 (https://phabricator.wikimedia.org/T230428) (owner: 10Ammarpad) [23:17:44] (03CR) 10DannyS712: [C: 04-1] Represent Consequences with command objects (0311 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/633380 (owner: 10Daimona Eaytoy) [23:19:17] 10MediaWiki-Parser: Parser should trim the text of internal links - https://phabricator.wikimedia.org/T268388 (10Huji) [23:25:19] (03PS5) 10Ladsgroup: Migrate slot_roles and content_models to abstract schema [core] - 10https://gerrit.wikimedia.org/r/619155 (https://phabricator.wikimedia.org/T230428) [23:27:38] 10ParserFunctions, 10Community-Wishlist-Survey-2015: ifexist function uses pagelinks table in lieu of better options - https://phabricator.wikimedia.org/T14019 (10Huji) Indeed, [[T221795]] may also benefit from it. Category counts have at times become inaccurate (see [[T224321]]) and the blame has been put on... [23:29:14] 10ParserFunctions, 10Community-Wishlist-Survey-2015: ifexist function uses pagelinks table in lieu of better options - https://phabricator.wikimedia.org/T14019 (10Huji) I am starting to wonder if we should create a new task of the #epic kind, maybe titled as "Refactor the page dependency and cache invalidation... [23:30:40] (03CR) 10DannyS712: REST: /page/{title}/{bare,html,with_html} endpoints backed by RESTBase. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/565408 (https://phabricator.wikimedia.org/T234377) (owner: 10Ppchelko) [23:30:52] (03CR) 10DannyS712: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/642436 (owner: 10DannyS712) [23:32:05] (03CR) 10Paladox: "This change is ready for review." [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/642435 (owner: 10Paladox) [23:34:22] (03CR) 10Ladsgroup: "check postgres" [core] - 10https://gerrit.wikimedia.org/r/619155 (https://phabricator.wikimedia.org/T230428) (owner: 10Ladsgroup) [23:34:38] 10MediaWiki-Installer, 10MW-1.35-release: Revisions created while MW 1.35 maintenance/update.php is running risk becoming inaccessible without explanation, rendering articles uneditable - https://phabricator.wikimedia.org/T268387 (10Carlb) As a footnote: one last step, if changing page.page_latest to point to... [23:36:04] (03CR) 10DannyS712: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/642437 (owner: 10DannyS712) [23:36:24] (03CR) 10DannyS712: [C: 03+2] build: Updating npm dependencies [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/642690 (owner: 10Libraryupgrader) [23:39:42] (03CR) 10Ladsgroup: "This is good to go please 😆" [core] - 10https://gerrit.wikimedia.org/r/619155 (https://phabricator.wikimedia.org/T230428) (owner: 10Ladsgroup) [23:42:51] (03CR) 10DannyS712: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/642438 (owner: 10DannyS712) [23:46:39] (03CR) 10Jforrester: [C: 03+2] LocalCacheUpdateJob: Migrate purgeSquid to non-deprecated function [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/642435 (owner: 10Paladox) [23:47:36] (03CR) 10Jforrester: [C: 03+2] Add patch to set wl_notificationtimestamp BINARY(14) [core] - 10https://gerrit.wikimedia.org/r/642685 (https://phabricator.wikimedia.org/T230428) (owner: 10Ladsgroup) [23:51:27] (03PS3) 10DannyS712: Inject TitleFactory into rest handlers [core] - 10https://gerrit.wikimedia.org/r/642438 [23:53:01] (03CR) 10Jforrester: [C: 03+2] "Dates from a136005a35b74ac629684171ec3e3451788d197e." [core] - 10https://gerrit.wikimedia.org/r/642436 (owner: 10DannyS712) [23:53:04] (03PS3) 10DannyS712: Remove ActionModuleBasedHandler::overrideActionModule [core] - 10https://gerrit.wikimedia.org/r/642437 [23:53:06] (03Merged) 10jenkins-bot: LocalCacheUpdateJob: Migrate purgeSquid to non-deprecated function [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/642435 (owner: 10Paladox) [23:53:43] (03PS4) 10DannyS712: Inject TitleFactory into rest handlers [core] - 10https://gerrit.wikimedia.org/r/642438 [23:56:06] (03CR) 10DannyS712: [C: 03+1] "Restore +1" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628537 (owner: 10Daimona Eaytoy) [23:58:50] (03PS5) 10DannyS712: Inject TitleFactory into rest handlers [core] - 10https://gerrit.wikimedia.org/r/642438 [23:59:35] (03CR) 10Daimona Eaytoy: Represent Consequences with command objects (036 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/633380 (owner: 10Daimona Eaytoy)