[00:29:39] (03CR) 10SamanthaNguyen: [C: 04-1] "Seems fine, some minor things, will C+2 after" (034 comments) [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/633762 (https://phabricator.wikimedia.org/T264907) (owner: 10Universal Omega) [00:30:56] (03CR) 10SamanthaNguyen: [C: 04-1] Convert to ConfigRegistry (031 comment) [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/633762 (https://phabricator.wikimedia.org/T264907) (owner: 10Universal Omega) [00:34:23] (03CR) 10Jason Linehan: "Assuming you have +2 on the primary repo schemas." [schemas/event/primary] - 10https://gerrit.wikimedia.org/r/634124 (https://phabricator.wikimedia.org/T256173) (owner: 10Jason Linehan) [00:56:56] (03PS11) 10Universal Omega: Convert to ConfigRegistry [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/633762 (https://phabricator.wikimedia.org/T264907) [00:57:40] (03CR) 10DannyS712: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/634090 (https://phabricator.wikimedia.org/T247194) (owner: 10DannyS712) [00:58:25] (03CR) 10Reedy: "Shouldn't have been merged. Two usages in CheckUser still; caused T265552" [core] - 10https://gerrit.wikimedia.org/r/633233 (https://phabricator.wikimedia.org/T189073) (owner: 10Urbanecm) [01:01:54] (03CR) 10Universal Omega: Convert to ConfigRegistry (035 comments) [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/633762 (https://phabricator.wikimedia.org/T264907) (owner: 10Universal Omega) [01:01:56] (03CR) 10SamanthaNguyen: [C: 03+2] Convert to ConfigRegistry [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/633762 (https://phabricator.wikimedia.org/T264907) (owner: 10Universal Omega) [01:06:54] (03PS12) 10Universal Omega: Convert to ConfigRegistry [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/633762 (https://phabricator.wikimedia.org/T264907) [01:10:29] (03CR) 10SamanthaNguyen: [C: 03+2] "recheck" [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/633762 (https://phabricator.wikimedia.org/T264907) (owner: 10Universal Omega) [01:14:12] (03Merged) 10jenkins-bot: Convert to ConfigRegistry [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/633762 (https://phabricator.wikimedia.org/T264907) (owner: 10Universal Omega) [01:19:24] (03PS3) 10SamanthaNguyen: Basic code cleanup in Cosmos\ResourceLoaderLessModule [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/633376 (https://phabricator.wikimedia.org/T264907) [01:25:28] (03CR) 10Universal Omega: [C: 03+2] Basic code cleanup in Cosmos\ResourceLoaderLessModule [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/633376 (https://phabricator.wikimedia.org/T264907) (owner: 10SamanthaNguyen) [01:30:33] (03Merged) 10jenkins-bot: Basic code cleanup in Cosmos\ResourceLoaderLessModule [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/633376 (https://phabricator.wikimedia.org/T264907) (owner: 10SamanthaNguyen) [01:36:29] (03Abandoned) 10SamanthaNguyen: ResourceLoaderLessModule: Make code more readable, match convention [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/633377 (https://phabricator.wikimedia.org/T264907) (owner: 10SamanthaNguyen) [01:49:39] (03PS1) 10SamanthaNguyen: ResourceLoaderLessModule: Don't do everything in one function [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/634136 [01:50:49] (03CR) 10jerkins-bot: [V: 04-1] ResourceLoaderLessModule: Don't do everything in one function [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/634136 (owner: 10SamanthaNguyen) [01:52:18] (03CR) 10SamanthaNguyen: "Trailing commas in function calls aren't accepted until PHP 7.3, fixed in patchset 2" [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/634136 (owner: 10SamanthaNguyen) [01:52:39] (03PS2) 10SamanthaNguyen: ResourceLoaderLessModule: Don't do everything in one function [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/634136 [01:59:43] (03CR) 10Universal Omega: [C: 03+2] ResourceLoaderLessModule: Don't do everything in one function [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/634136 (owner: 10SamanthaNguyen) [02:04:21] (03Merged) 10jenkins-bot: ResourceLoaderLessModule: Don't do everything in one function [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/634136 (owner: 10SamanthaNguyen) [02:10:21] (03PS3) 10SamanthaNguyen: Some basic code cleanup between CosmosNavigation & CosmosToolbar [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/633368 (https://phabricator.wikimedia.org/T265195) [02:20:14] (03CR) 10Universal Omega: [C: 03+2] Some basic code cleanup between CosmosNavigation & CosmosToolbar [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/633368 (https://phabricator.wikimedia.org/T265195) (owner: 10SamanthaNguyen) [02:24:10] (03Merged) 10jenkins-bot: Some basic code cleanup between CosmosNavigation & CosmosToolbar [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/633368 (https://phabricator.wikimedia.org/T265195) (owner: 10SamanthaNguyen) [02:49:22] (03PS1) 10SamanthaNguyen: Cleanup checks for checking contents of i18n messages [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/634140 (https://phabricator.wikimedia.org/T265110) [03:02:22] (03CR) 10SamanthaNguyen: [C: 04-1] Cleanup checks for checking contents of i18n messages [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/634140 (https://phabricator.wikimedia.org/T265110) (owner: 10SamanthaNguyen) [03:33:53] (03PS2) 10SamanthaNguyen: Cleanup checks for checking contents of i18n messages [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/634140 (https://phabricator.wikimedia.org/T265110) [03:58:59] (03CR) 10Krinkle: [C: 04-1] objectcache: fix WANCache getWithSetCallback() when TTL < "lowTTL" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/634116 (https://phabricator.wikimedia.org/T264787) (owner: 10Aaron Schulz) [04:05:13] (03CR) 10Krinkle: [C: 04-1] objectcache: fix WANCache getWithSetCallback() when TTL < "lowTTL" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/634116 (https://phabricator.wikimedia.org/T264787) (owner: 10Aaron Schulz) [04:59:38] (03PS1) 10SamanthaNguyen: CosmosTemplate: Don't pass string parameter by reference [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/634143 (https://phabricator.wikimedia.org/T265232) [05:02:20] (03CR) 10SamanthaNguyen: CosmosTemplate: Don't pass string parameter by reference (031 comment) [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/634143 (https://phabricator.wikimedia.org/T265232) (owner: 10SamanthaNguyen) [05:32:40] (03PS6) 10Santhosh: Add API for publishing section translations [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/632660 (https://phabricator.wikimedia.org/T264736) [05:40:19] (03CR) 10Santhosh: [C: 04-1] UI lib: Decouple spacing helper classes from grid (032 comments) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/634014 (owner: 10Nik Gkountas) [05:41:24] (03CR) 10Santhosh: [C: 03+2] Storybook config: Move addon-docs before addon-controls [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/634016 (owner: 10Nik Gkountas) [05:51:18] (03CR) 10jerkins-bot: [V: 04-1] Add API for publishing section translations [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/632660 (https://phabricator.wikimedia.org/T264736) (owner: 10Santhosh) [05:55:12] (03PS37) 10Tim Starling: Shellbox initial source files [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/622707 (https://phabricator.wikimedia.org/T260330) [05:55:54] (03CR) 10jerkins-bot: [V: 04-1] Shellbox initial source files [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/622707 (https://phabricator.wikimedia.org/T260330) (owner: 10Tim Starling) [05:57:20] (03CR) 10Tim Starling: "* If headers were sent prior to an exception, still log the exception" [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/622707 (https://phabricator.wikimedia.org/T260330) (owner: 10Tim Starling) [06:01:11] (03CR) 10Santhosh: [C: 03+2] Replace sass implementation: Use Dart Sass instead of Node-sass [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/634013 (owner: 10Nik Gkountas) [06:02:09] (03PS38) 10Tim Starling: Shellbox initial source files [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/622707 (https://phabricator.wikimedia.org/T260330) [06:07:48] (03CR) 10AlQaholic007: "The patch looks good to me. Just a note on how Gerrit works." [core] - 10https://gerrit.wikimedia.org/r/633348 (https://phabricator.wikimedia.org/T265011) (owner: 10Akanksha Bhattachan) [06:13:25] (03CR) 10AlQaholic007: "Please change the topic to the Phabricator task number. This way Gerrit knows which Phabricator task should it link this patch to" [core] - 10https://gerrit.wikimedia.org/r/633287 (https://phabricator.wikimedia.org/T265011) (owner: 10Hulya Karakaya) [06:14:41] (03PS7) 10Santhosh: Add API for publishing section translations [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/632660 (https://phabricator.wikimedia.org/T264736) [06:14:45] (03CR) 10AlQaholic007: "This is good Rukkykofi. I noticed there is a slight typo for the word "trivial" in the commit message. Can you ammend your commit message " [core] - 10https://gerrit.wikimedia.org/r/633220 (https://phabricator.wikimedia.org/T265011) (owner: 10Rukkykofi) [06:17:44] (03CR) 10AlQaholic007: "The patch looks good to me Harriet. The topic of the patch needs to be the Phabricator task number. Please change the topic to T265011" [core] - 10https://gerrit.wikimedia.org/r/633278 (https://phabricator.wikimedia.org/T265011) (owner: 10Harriet Ayugi) [06:18:24] (03CR) 10AlQaholic007: [C: 04-1] "Preventing accidental merge" [extensions/Math] - 10https://gerrit.wikimedia.org/r/634038 (https://phabricator.wikimedia.org/T265463) (owner: 10Js636f) [06:20:29] (03CR) 10AlQaholic007: "I like the thoughtfulness here. However as Urbanecm rightly mentioned, the inline comment does specify the right instructions. Nice work o" [core] - 10https://gerrit.wikimedia.org/r/633284 (https://phabricator.wikimedia.org/T265011) (owner: 10Sskenner) [06:20:59] (03Merged) 10jenkins-bot: Replace sass implementation: Use Dart Sass instead of Node-sass [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/634013 (owner: 10Nik Gkountas) [06:21:39] (03CR) 10AlQaholic007: "Make sure you add the topic to this patch. Topic should be the Phabricator task number. This way Gerrit knows to check for merge conflicts" [core] - 10https://gerrit.wikimedia.org/r/633284 (https://phabricator.wikimedia.org/T265011) (owner: 10Sskenner) [06:22:59] (03CR) 10AlQaholic007: "Nice work Alex. Make sure you change the topic to just "T256011". You can use the Gerrit UI" [core] - 10https://gerrit.wikimedia.org/r/633528 (https://phabricator.wikimedia.org/T265011) (owner: 10Js636f) [06:31:37] (03CR) 10DannyS712: Add phan annotations for better analysis (035 comments) [libs/ObjectFactory] - 10https://gerrit.wikimedia.org/r/632798 (https://phabricator.wikimedia.org/T264930) (owner: 10Daimona Eaytoy) [06:35:55] (03CR) 10Santhosh: [C: 03+2] UI Lib MWLayout: Fix MWCol and MWRow component names [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/634015 (owner: 10Nik Gkountas) [06:50:15] (03CR) 10Santhosh: [C: 04-1] UI lib MWButtomNavigation: Update styles to match requirements (035 comments) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/634055 (owner: 10Nik Gkountas) [06:51:27] (03PS2) 10Thiemo Kreuz (WMDE): Fix wrapper="…" failing for more complex selectors [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/627574 (https://phabricator.wikimedia.org/T258093) [06:53:13] (03CR) 10Thiemo Kreuz (WMDE): "Sure, thanks for the reminder. I added a test that fails before and succeeds after this patch." [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/627574 (https://phabricator.wikimedia.org/T258093) (owner: 10Thiemo Kreuz (WMDE)) [06:54:29] (03PS1) 10Thiemo Kreuz (WMDE): Fix remaining PHPCS warnings about missing PHPDocs [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/634180 [07:00:01] (03CR) 10DannyS712: [C: 03+1] "everything looks good to me. One suggestion, though if you want to do that separately happy to merge this as is" (031 comment) [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/634180 (owner: 10Thiemo Kreuz (WMDE)) [07:00:29] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Hotfix: missing $config parameter to SpeechoidConnector [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/634110 (owner: 10Karl Wettin (WMSE)) [07:04:13] (03Merged) 10jenkins-bot: Hotfix: missing $config parameter to SpeechoidConnector [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/634110 (owner: 10Karl Wettin (WMSE)) [07:10:20] (03CR) 10Thiemo Kreuz (WMDE): Fix remaining PHPCS warnings about missing PHPDocs (031 comment) [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/634180 (owner: 10Thiemo Kreuz (WMDE)) [07:10:28] (03PS1) 10Mglaser: Fix exception whenever revision is null after deletion [extensions/BlueSpiceSMWConnector] - 10https://gerrit.wikimedia.org/r/634092 [07:10:52] (03CR) 10DannyS712: [C: 03+2] Fix remaining PHPCS warnings about missing PHPDocs (031 comment) [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/634180 (owner: 10Thiemo Kreuz (WMDE)) [07:11:52] (03PS2) 10Legoktm: BaseTemplate: Guard against passing zero arg to array_merge() [core] - 10https://gerrit.wikimedia.org/r/633474 (https://phabricator.wikimedia.org/T265223) (owner: 10Ammarpad) [07:12:01] (03CR) 10Legoktm: [C: 03+1] BaseTemplate: Guard against passing zero arg to array_merge() [core] - 10https://gerrit.wikimedia.org/r/633474 (https://phabricator.wikimedia.org/T265223) (owner: 10Ammarpad) [07:14:51] (03CR) 10Mglaser: [C: 03+2] Fix exception whenever revision is null after deletion [extensions/BlueSpiceSMWConnector] - 10https://gerrit.wikimedia.org/r/634092 (owner: 10Mglaser) [07:14:55] (03CR) 10Mglaser: [C: 03+2] Fix exception whenever revision is null after deletion [extensions/BlueSpiceSMWConnector] (REL1_35) - 10https://gerrit.wikimedia.org/r/634049 (owner: 10Pwirth) [07:15:33] (03Merged) 10jenkins-bot: Fix exception whenever revision is null after deletion [extensions/BlueSpiceSMWConnector] (REL1_35) - 10https://gerrit.wikimedia.org/r/634049 (owner: 10Pwirth) [07:18:30] (03CR) 10Ammarpad: [C: 04-1] Reverted tag: do not mark null revisions as reverted (032 comments) [core] - 10https://gerrit.wikimedia.org/r/633701 (https://phabricator.wikimedia.org/T265312) (owner: 10Ostrzyciel) [07:22:59] (03CR) 10Akanksha Bhattachan: "> Patch Set 5:" [core] - 10https://gerrit.wikimedia.org/r/633348 (https://phabricator.wikimedia.org/T265011) (owner: 10Akanksha Bhattachan) [07:27:34] (03CR) 10Ladsgroup: "check postgres" [core] - 10https://gerrit.wikimedia.org/r/634035 (https://phabricator.wikimedia.org/T230428) (owner: 10Ammarpad) [07:30:55] (03CR) 10Ladsgroup: [C: 04-1] "Thank you for doing this." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/634035 (https://phabricator.wikimedia.org/T230428) (owner: 10Ammarpad) [07:32:28] (03Merged) 10jenkins-bot: Fix remaining PHPCS warnings about missing PHPDocs [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/634180 (owner: 10Thiemo Kreuz (WMDE)) [07:32:30] (03Merged) 10jenkins-bot: Fix exception whenever revision is null after deletion [extensions/BlueSpiceSMWConnector] - 10https://gerrit.wikimedia.org/r/634092 (owner: 10Mglaser) [07:32:32] (03PS1) 10Ammarpad: Normally all these items are links (urls) and so client code iterating the array will always assume the 'href' and 'text' key are set for all of them. [core] - 10https://gerrit.wikimedia.org/r/634182 [07:38:50] (03CR) 10Ladsgroup: [C: 04-1] "And the default is not understandable as a valid timestamp for PG (while it's a valid timestamp in mysql...) This is going to be fun :/ I " [core] - 10https://gerrit.wikimedia.org/r/634035 (https://phabricator.wikimedia.org/T230428) (owner: 10Ammarpad) [07:40:38] (03PS2) 10Ammarpad: Set `href` key for all personal_urls items [core] - 10https://gerrit.wikimedia.org/r/634182 [07:49:07] (03PS1) 10Mglaser: Fix GroupManager integration after refactor [extensions/BlueSpicePermissionManager] (REL1_35) - 10https://gerrit.wikimedia.org/r/634183 [07:53:00] (03CR) 10jerkins-bot: [V: 04-1] Fix GroupManager integration after refactor [extensions/BlueSpicePermissionManager] (REL1_35) - 10https://gerrit.wikimedia.org/r/634183 (owner: 10Mglaser) [07:57:12] (03PS1) 10Prtksxna: feat: add offsite post [design/blog] - 10https://gerrit.wikimedia.org/r/634185 [07:58:11] (03CR) 10Prtksxna: [V: 03+2 C: 03+2] feat: add offsite post [design/blog] - 10https://gerrit.wikimedia.org/r/634185 (owner: 10Prtksxna) [08:00:22] (03PS1) 10Gergő Tisza: Add missing ResourceLoader dependency [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/634186 [08:00:24] (03PS1) 10Gergő Tisza: Suppress VisualEditor welcome dialog when tour is active [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/634187 (https://phabricator.wikimedia.org/T235812) [08:03:56] (03CR) 10jerkins-bot: [V: 04-1] Suppress VisualEditor welcome dialog when tour is active [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/634187 (https://phabricator.wikimedia.org/T235812) (owner: 10Gergő Tisza) [08:11:57] (03PS2) 10Nik Gkountas: UI lib: Decouple spacing helper classes from grid [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/634014 [08:12:10] (03CR) 10Nik Gkountas: UI lib: Decouple spacing helper classes from grid (032 comments) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/634014 (owner: 10Nik Gkountas) [08:14:42] (03CR) 10Gilles: [C: 03+2] Add client-side performance metrics for legacy search [core] - 10https://gerrit.wikimedia.org/r/624824 (https://phabricator.wikimedia.org/T251544) (owner: 10Nray) [08:14:50] (03CR) 10Gilles: [C: 03+2] Add client-side performance metrics for searchLoader [skins/Vector] - 10https://gerrit.wikimedia.org/r/624888 (https://phabricator.wikimedia.org/T251544) (owner: 10Nray) [08:27:16] (03PS2) 10Mglaser: Fix GroupManager integration after refactor [extensions/BlueSpicePermissionManager] (REL1_35) - 10https://gerrit.wikimedia.org/r/634183 [08:32:20] (03CR) 10jerkins-bot: [V: 04-1] Fix GroupManager integration after refactor [extensions/BlueSpicePermissionManager] (REL1_35) - 10https://gerrit.wikimedia.org/r/634183 (owner: 10Mglaser) [08:32:20] (03PS1) 10Mglaser: Fix exception whenever revision is null after deletion [extensions/BlueSpiceSMWConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/634095 [08:32:21] (03PS1) 10Mglaser: Fix exception whenever revision is null after deletion [extensions/BlueSpiceSMWConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/634096 [08:32:21] (03CR) 10jerkins-bot: [V: 04-1] Fix exception whenever revision is null after deletion [extensions/BlueSpiceSMWConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/634096 (owner: 10Mglaser) [08:32:21] (03CR) 10Js636f: "> Patch Set 2:" [core] - 10https://gerrit.wikimedia.org/r/633528 (https://phabricator.wikimedia.org/T265011) (owner: 10Js636f) [08:34:11] (03PS1) 10ItSpiderman: Fix GroupManager integration after refactor [extensions/BlueSpicePermissionManager] - 10https://gerrit.wikimedia.org/r/634097 [08:34:16] (03CR) 10ItSpiderman: [C: 03+2] Fix GroupManager integration after refactor [extensions/BlueSpicePermissionManager] - 10https://gerrit.wikimedia.org/r/634097 (owner: 10ItSpiderman) [08:34:23] (03CR) 10ItSpiderman: [V: 03+2 C: 03+2] Fix GroupManager integration after refactor [extensions/BlueSpicePermissionManager] (REL1_35) - 10https://gerrit.wikimedia.org/r/634183 (owner: 10Mglaser) [08:35:47] (03Abandoned) 10Mglaser: Fix exception whenever revision is null after deletion [extensions/BlueSpiceSMWConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/634096 (owner: 10Mglaser) [08:35:56] (03Abandoned) 10Mglaser: Fix exception whenever revision is null after deletion [extensions/BlueSpiceSMWConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/634095 (owner: 10Mglaser) [08:37:43] (03CR) 10jerkins-bot: [V: 04-1] Fix GroupManager integration after refactor [extensions/BlueSpicePermissionManager] - 10https://gerrit.wikimedia.org/r/634097 (owner: 10ItSpiderman) [08:44:04] (03CR) 10Santhosh: [C: 03+2] UI lib: Decouple spacing helper classes from grid [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/634014 (owner: 10Nik Gkountas) [08:44:25] (03PS1) 10Pwirth: Add deprecation waring to SkinTemplateOutputBeforeExec hook handler base class [extensions/BlueSpiceFoundation] (REL1_35) - 10https://gerrit.wikimedia.org/r/634189 (https://phabricator.wikimedia.org/T254300) [08:47:28] (03CR) 10Zfilipin: "> Patch Set 1: Code-Review-1" [extensions/Math] - 10https://gerrit.wikimedia.org/r/634038 (https://phabricator.wikimedia.org/T265463) (owner: 10Js636f) [08:48:12] (03Merged) 10jenkins-bot: Add client-side performance metrics for legacy search [core] - 10https://gerrit.wikimedia.org/r/624824 (https://phabricator.wikimedia.org/T251544) (owner: 10Nray) [08:48:14] (03Merged) 10jenkins-bot: Add client-side performance metrics for searchLoader [skins/Vector] - 10https://gerrit.wikimedia.org/r/624888 (https://phabricator.wikimedia.org/T251544) (owner: 10Nray) [08:53:06] (03CR) 10Mglaser: [V: 03+2 C: 03+2] Fix GroupManager integration after refactor [extensions/BlueSpicePermissionManager] - 10https://gerrit.wikimedia.org/r/634097 (owner: 10ItSpiderman) [08:53:27] (03CR) 10Zfilipin: "This is a good start! I've left a few comments on how to improve it." (033 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/634038 (https://phabricator.wikimedia.org/T265463) (owner: 10Js636f) [09:14:54] (03Merged) 10jenkins-bot: UI lib: Decouple spacing helper classes from grid [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/634014 (owner: 10Nik Gkountas) [09:20:49] (03PS5) 10Karl Wettin (WMSE): Introduce namespaces [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/633847 (https://phabricator.wikimedia.org/T265335) [09:21:47] (03PS2) 10Gergő Tisza: Suppress VisualEditor welcome dialog when tour is active [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/634187 (https://phabricator.wikimedia.org/T235812) [10:01:20] (03PS2) 10Nik Gkountas: UI lib MWButtomNavigation: Fix spacing and colors [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/634055 [10:01:41] (03CR) 10Nik Gkountas: UI lib MWButtomNavigation: Fix spacing and colors (036 comments) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/634055 (owner: 10Nik Gkountas) [10:02:00] (03PS2) 10Nik Gkountas: UI Lib MWLayout: Fix MWCol and MWRow component names [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/634015 [10:02:14] (03PS2) 10Nik Gkountas: Storybook config: Move addon-docs before addon-controls [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/634016 [10:02:16] (03CR) 10Ladsgroup: [C: 03+2] Make ContentHandler::latestRevision() available to subclasses (031 comment) [core] - 10https://gerrit.wikimedia.org/r/633169 (owner: 10Lucas Werkmeister (WMDE)) [10:02:24] (03PS4) 10Nik Gkountas: UI lib: Add MWRadioGroup and MWRadio components [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/633208 [10:20:47] (03PS3) 10Ammarpad: Provide native support to dismiss sitenotice in core (part 1). [core] - 10https://gerrit.wikimedia.org/r/631177 (https://phabricator.wikimedia.org/T262118) [10:21:00] (03CR) 10Santhosh: [C: 04-1] UI lib: Add MWRadioGroup and MWRadio components (037 comments) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/633208 (owner: 10Nik Gkountas) [10:21:20] (03PS1) 10Nik Gkountas: UI lib MWButton icons: Use spacing classes to support RTL [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/634200 [10:24:12] (03CR) 10Karl Wettin (WMSE): [V: 03+2 C: 03+2] "Merging now. Thanks all for the input! There are a few outstanding issues, such as renaming the User-class and investigating byref/byval u" [extensions/WikispeechSpeechDataCollector] - 10https://gerrit.wikimedia.org/r/609518 (https://phabricator.wikimedia.org/T257109) (owner: 10Karl Wettin (WMSE)) [10:25:14] (03PS3) 10Daimona Eaytoy: Use HTMLForm features instead of mSubmit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/631969 (https://phabricator.wikimedia.org/T263627) [10:35:01] (03PS33) 10Daimona Eaytoy: Add a FilterLookup service [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628579 [10:35:26] (03CR) 10jerkins-bot: [V: 04-1] Add a FilterLookup service [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628579 (owner: 10Daimona Eaytoy) [10:37:37] (03PS34) 10Daimona Eaytoy: Add a FilterLookup service [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628579 [10:39:58] (03Merged) 10jenkins-bot: Make ContentHandler::latestRevision() available to subclasses [core] - 10https://gerrit.wikimedia.org/r/633169 (owner: 10Lucas Werkmeister (WMDE)) [10:48:21] (03CR) 10Abijeet Patro: Add support for sending only the specified section of a page (032 comments) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/631176 (https://phabricator.wikimedia.org/T254483) (owner: 10Nikerabbit) [10:53:22] (03CR) 10Karl Wettin (WMSE): "This change is ready for review." [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/631719 (https://phabricator.wikimedia.org/T264403) (owner: 10Karl Wettin (WMSE)) [10:54:54] (03CR) 10Karl Wettin (WMSE): "Merged with changes from suggestions that was implemented in their own patches." (032 comments) [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/631719 (https://phabricator.wikimedia.org/T264403) (owner: 10Karl Wettin (WMSE)) [10:56:28] (03CR) 10Esanders: "Can you create a task on Phabricator? This will probably require consultation with the Parsing Team." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/633599 (owner: 10Pastakhov) [10:56:57] (03CR) 10jerkins-bot: [V: 04-1] Speechoid/Wikispeech benchmark maintenance script [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/631719 (https://phabricator.wikimedia.org/T264403) (owner: 10Karl Wettin (WMSE)) [10:58:07] (03PS11) 10Karl Wettin (WMSE): Speechoid/Wikispeech benchmark maintenance script [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/631719 (https://phabricator.wikimedia.org/T264403) [10:58:33] (03CR) 10Karl Wettin (WMSE): "Removed some artifacts left from merge :C" [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/631719 (https://phabricator.wikimedia.org/T264403) (owner: 10Karl Wettin (WMSE)) [11:01:27] (03CR) 10jerkins-bot: [V: 04-1] Speechoid/Wikispeech benchmark maintenance script [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/631719 (https://phabricator.wikimedia.org/T264403) (owner: 10Karl Wettin (WMSE)) [11:02:42] (03CR) 10Vedmaka Wakalaka: [C: 04-1] "It looks like Special:Push related code still requires some attention, I am going to handle it ;)" (035 comments) [extensions/Push] - 10https://gerrit.wikimedia.org/r/625988 (owner: 10Pastakhov) [11:09:11] (03CR) 10Esanders: [C: 03+1] "I guess we don't have test coverage for the data.php output?" [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/634073 (https://phabricator.wikimedia.org/T265500) (owner: 10Bartosz Dziewoński) [11:10:26] (03CR) 10Esanders: [C: 03+2] CommentParser: Avoid unnecessary reference in foreach() [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/633859 (owner: 10Bartosz Dziewoński) [11:11:04] (03CR) 10Ammarpad: Provide native support to dismiss sitenotice in core (part 1). (033 comments) [core] - 10https://gerrit.wikimedia.org/r/631177 (https://phabricator.wikimedia.org/T262118) (owner: 10Ammarpad) [11:23:43] (03PS4) 10Bartosz Dziewoński: ImmutableRange: Remove unused variable [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/633860 [11:23:57] (03CR) 10Bartosz Dziewoński: [C: 03+2] ImmutableRange: Remove unused variable [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/633860 (owner: 10Bartosz Dziewoński) [11:27:30] (03PS35) 10Daimona Eaytoy: Add a FilterLookup service [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628579 [11:28:07] (03Merged) 10jenkins-bot: ImmutableRange: Remove unused variable [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/633860 (owner: 10Bartosz Dziewoński) [11:32:48] (03CR) 10Bartosz Dziewoński: [C: 04-1] "No, but we should, I'll amend. IIRC I tried doing it before for every language, and found that constructing Language objects was super slo" [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/634073 (https://phabricator.wikimedia.org/T265500) (owner: 10Bartosz Dziewoński) [11:46:51] (03CR) 10Planetenxin: "Hi Mark, can you please have a look at this patch improving the style-ability for the "results in range" and "paging" elements in Special " [core] - 10https://gerrit.wikimedia.org/r/634027 (owner: 10Planetenxin) [11:48:47] (03PS1) 10Ammarpad: Unset anon userpage placeholder [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/634210 (https://phabricator.wikimedia.org/T265523) [11:49:59] (03PS2) 10Ammarpad: Unset anon userpage placeholder [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/634210 (https://phabricator.wikimedia.org/T265523) [11:59:28] (03PS3) 10Ammarpad: Set `href` key for all personal_urls items [core] - 10https://gerrit.wikimedia.org/r/634182 [12:00:04] (03PS5) 10Nik Gkountas: UI lib: Add MWRadioGroup and MWRadio components [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/633208 [12:00:20] (03CR) 10Nik Gkountas: UI lib: Add MWRadioGroup and MWRadio components (037 comments) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/633208 (owner: 10Nik Gkountas) [12:03:30] (03PS1) 10Kosta Harlan: Save sortby preference in a job [extensions/Flow] - 10https://gerrit.wikimedia.org/r/634212 (https://phabricator.wikimedia.org/T265592) [12:05:02] (03PS2) 10Bartosz Dziewoński: Correctly generate timezone abbreviations for parsing [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/634073 (https://phabricator.wikimedia.org/T265500) [12:05:33] (03CR) 10Bartosz Dziewoński: Correctly generate timezone abbreviations for parsing (031 comment) [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/634073 (https://phabricator.wikimedia.org/T265500) (owner: 10Bartosz Dziewoński) [12:06:31] (03PS1) 10Urbanecm: Revert "Hard deprecate SpecialBlock::canBlockEmail" [core] - 10https://gerrit.wikimedia.org/r/634100 (https://phabricator.wikimedia.org/T265552) [12:07:24] (03CR) 10Urbanecm: [C: 03+2] "Revert" [core] - 10https://gerrit.wikimedia.org/r/634100 (https://phabricator.wikimedia.org/T265552) (owner: 10Urbanecm) [12:10:36] (03CR) 10jerkins-bot: [V: 04-1] Correctly generate timezone abbreviations for parsing [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/634073 (https://phabricator.wikimedia.org/T265500) (owner: 10Bartosz Dziewoński) [12:11:00] (03PS2) 10Kosta Harlan: Save sortby preference client-side [extensions/Flow] - 10https://gerrit.wikimedia.org/r/634212 (https://phabricator.wikimedia.org/T265592) [12:11:15] (03PS3) 10Kosta Harlan: Save sortby preference client-side [extensions/Flow] - 10https://gerrit.wikimedia.org/r/634212 (https://phabricator.wikimedia.org/T265592) [12:11:32] (03PS3) 10Bartosz Dziewoński: Correctly generate timezone abbreviations for parsing [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/634073 (https://phabricator.wikimedia.org/T265500) [12:13:26] (03PS4) 10Kosta Harlan: Save sortby preference client-side [extensions/Flow] - 10https://gerrit.wikimedia.org/r/634212 (https://phabricator.wikimedia.org/T265592) [12:32:57] (03CR) 10jerkins-bot: [V: 04-1] Save sortby preference client-side [extensions/Flow] - 10https://gerrit.wikimedia.org/r/634212 (https://phabricator.wikimedia.org/T265592) (owner: 10Kosta Harlan) [12:38:48] (03PS5) 10Kosta Harlan: Save sortby preference client-side [extensions/Flow] - 10https://gerrit.wikimedia.org/r/634212 (https://phabricator.wikimedia.org/T265592) [12:44:05] (03CR) 10Nikerabbit: Add support for sending only the specified section of a page (032 comments) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/631176 (https://phabricator.wikimedia.org/T254483) (owner: 10Nikerabbit) [12:49:24] (03Merged) 10jenkins-bot: Revert "Hard deprecate SpecialBlock::canBlockEmail" [core] - 10https://gerrit.wikimedia.org/r/634100 (https://phabricator.wikimedia.org/T265552) (owner: 10Urbanecm) [12:49:42] (03PS12) 10Karl Wettin (WMSE): Speechoid/Wikispeech benchmark maintenance script [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/631719 (https://phabricator.wikimedia.org/T264403) [12:52:37] (03CR) 10jerkins-bot: [V: 04-1] Speechoid/Wikispeech benchmark maintenance script [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/631719 (https://phabricator.wikimedia.org/T264403) (owner: 10Karl Wettin (WMSE)) [12:57:13] (03CR) 10Labdajiwa: "> Patch Set 2: Code-Review-1" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/634101 (https://phabricator.wikimedia.org/T255747) (owner: 10Labdajiwa) [12:59:18] (03PS1) 10Karl Wettin (WMSE): Cleanup flushUtterancesByExpirationDateOnFile [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/634226 (https://phabricator.wikimedia.org/T265429) [13:02:10] (03CR) 10ItSpiderman: [C: 03+2] Add deprecation waring to SkinTemplateOutputBeforeExec hook handler base class [extensions/BlueSpiceFoundation] (REL1_35) - 10https://gerrit.wikimedia.org/r/634189 (https://phabricator.wikimedia.org/T254300) (owner: 10Pwirth) [13:02:15] (03PS1) 10ItSpiderman: Add deprecation waring to SkinTemplateOutputBeforeExec hook handler base class [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/634103 (https://phabricator.wikimedia.org/T254300) [13:02:20] (03CR) 10ItSpiderman: [C: 03+2] Add deprecation waring to SkinTemplateOutputBeforeExec hook handler base class [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/634103 (https://phabricator.wikimedia.org/T254300) (owner: 10ItSpiderman) [13:04:15] (03CR) 10Vedmaka Wakalaka: [C: 04-1] Make compatible with mw 1.35 (035 comments) [extensions/Push] - 10https://gerrit.wikimedia.org/r/625988 (owner: 10Pastakhov) [13:06:11] (03Merged) 10jenkins-bot: Add deprecation waring to SkinTemplateOutputBeforeExec hook handler base class [extensions/BlueSpiceFoundation] (REL1_35) - 10https://gerrit.wikimedia.org/r/634189 (https://phabricator.wikimedia.org/T254300) (owner: 10Pwirth) [13:07:00] (03PS2) 10Matěj Suchánek: Improve display of log entries when global filters are not enabled [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/633979 (https://phabricator.wikimedia.org/T174000) [13:07:02] (03CR) 10Matěj Suchánek: Improve display of log entries when global filters are not enabled (035 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/633979 (https://phabricator.wikimedia.org/T174000) (owner: 10Matěj Suchánek) [13:07:14] (03CR) 10Ottomata: "This should be a new version, right?" [schemas/event/primary] - 10https://gerrit.wikimedia.org/r/634124 (https://phabricator.wikimedia.org/T256173) (owner: 10Jason Linehan) [13:08:07] (03CR) 10Ottomata: mediawiki/client/error: Adds is_logged_in field (031 comment) [schemas/event/primary] - 10https://gerrit.wikimedia.org/r/634124 (https://phabricator.wikimedia.org/T256173) (owner: 10Jason Linehan) [13:08:18] (03PS1) 10Karl Wettin (WMSE): Output line breaks in flushUtterances.php [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/634227 [13:10:36] (03Merged) 10jenkins-bot: Add deprecation waring to SkinTemplateOutputBeforeExec hook handler base class [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/634103 (https://phabricator.wikimedia.org/T254300) (owner: 10ItSpiderman) [13:10:43] (03CR) 10jerkins-bot: [V: 04-1] Save sortby preference client-side [extensions/Flow] - 10https://gerrit.wikimedia.org/r/634212 (https://phabricator.wikimedia.org/T265592) (owner: 10Kosta Harlan) [13:12:21] (03PS4) 10Matěj Suchánek: Add ChangeTagsManager service [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/634032 [13:12:23] (03CR) 10Matěj Suchánek: Add ChangeTagsManager service (035 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/634032 (owner: 10Matěj Suchánek) [13:13:55] (03PS6) 10Kosta Harlan: Save sortby preference client-side [extensions/Flow] - 10https://gerrit.wikimedia.org/r/634212 (https://phabricator.wikimedia.org/T265592) [13:15:25] (03PS4) 10Matěj Suchánek: Migrate change tags hooks to DI [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/634033 (https://phabricator.wikimedia.org/T261067) [13:17:42] (03CR) 10Matěj Suchánek: Add ChangeTagsManager service (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/634032 (owner: 10Matěj Suchánek) [13:24:22] (03PS2) 10Js636f: Add `/tests/selenium/log/` folder to `.gitignore` file [extensions/Math] - 10https://gerrit.wikimedia.org/r/634038 (https://phabricator.wikimedia.org/T265463) [13:25:57] (03CR) 10Js636f: "> Patch Set 1:" (033 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/634038 (https://phabricator.wikimedia.org/T265463) (owner: 10Js636f) [13:29:04] (03Abandoned) 10LukBukkit: Use the newsletter special page as main page when not set [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/477122 (https://phabricator.wikimedia.org/T177064) (owner: 10LukBukkit) [13:30:06] (03PS1) 10Phuedx: SearchSatisfaction: Add isAnon field [schemas/event/secondary] - 10https://gerrit.wikimedia.org/r/634230 (https://phabricator.wikimedia.org/T259250) [13:32:41] (03CR) 10Vedmaka Wakalaka: [C: 04-1] Make compatible with mw 1.35 (031 comment) [extensions/Push] - 10https://gerrit.wikimedia.org/r/625988 (owner: 10Pastakhov) [13:41:25] (03PS7) 10Vedmaka Wakalaka: Make compatible with mw 1.35 [extensions/Push] - 10https://gerrit.wikimedia.org/r/625988 (owner: 10Pastakhov) [13:41:45] (03CR) 10jerkins-bot: [V: 04-1] Improve display of log entries when global filters are not enabled [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/633979 (https://phabricator.wikimedia.org/T174000) (owner: 10Matěj Suchánek) [13:43:24] (03PS13) 10Karl Wettin (WMSE): Speechoid/Wikispeech benchmark maintenance script [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/631719 (https://phabricator.wikimedia.org/T264403) [13:43:26] (03CR) 10Daimona Eaytoy: [C: 03+2] "Dear jerkins, could you please merge this at the first attempt without selenium failing? thx" (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/633979 (https://phabricator.wikimedia.org/T174000) (owner: 10Matěj Suchánek) [13:44:10] (03CR) 10Vedmaka Wakalaka: Make compatible with mw 1.35 (0311 comments) [extensions/Push] - 10https://gerrit.wikimedia.org/r/625988 (owner: 10Pastakhov) [13:44:33] (03CR) 10jerkins-bot: [V: 04-1] Make compatible with mw 1.35 [extensions/Push] - 10https://gerrit.wikimedia.org/r/625988 (owner: 10Pastakhov) [13:51:30] (03PS8) 10Vedmaka Wakalaka: Make compatible with mw 1.35 [extensions/Push] - 10https://gerrit.wikimedia.org/r/625988 (owner: 10Pastakhov) [13:55:08] (03CR) 10Daimona Eaytoy: "Looks good, aside from the naming thing, and I still have to test it." (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/634032 (owner: 10Matěj Suchánek) [13:58:01] (03CR) 10Vedmaka Wakalaka: [C: 03+1] Make compatible with mw 1.35 [extensions/Push] - 10https://gerrit.wikimedia.org/r/625988 (owner: 10Pastakhov) [14:01:18] (03PS2) 10Phuedx: SearchSatisfaction: Add isAnon field [schemas/event/secondary] - 10https://gerrit.wikimedia.org/r/634230 (https://phabricator.wikimedia.org/T259250) [14:11:38] (03Merged) 10jenkins-bot: Improve display of log entries when global filters are not enabled [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/633979 (https://phabricator.wikimedia.org/T174000) (owner: 10Matěj Suchánek) [14:13:00] (03CR) 10Harriet Ayugi: "> Patch Set 3:" [core] - 10https://gerrit.wikimedia.org/r/633278 (https://phabricator.wikimedia.org/T265011) (owner: 10Harriet Ayugi) [14:13:54] (03PS4) 10Aklapper: MessagesJv.php: Update specialpages and namespaces in Javanese [core] - 10https://gerrit.wikimedia.org/r/634101 (https://phabricator.wikimedia.org/T255747) (owner: 10Labdajiwa) [14:14:21] (03CR) 10Jdlrobson: [C: 04-1] "This converts "Not logged in" to a link (visually) and semantically. It is not a functional link so this is confusing." [core] - 10https://gerrit.wikimedia.org/r/634182 (owner: 10Ammarpad) [14:29:13] (03CR) 10SamanthaNguyen: [C: 04-1] "Calls to buildFooterLinks and buildFooterIcons need to be updated" [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/634143 (https://phabricator.wikimedia.org/T265232) (owner: 10SamanthaNguyen) [14:30:31] (03PS1) 10Noname1706: WIP Hide "Accept my changes" checkbox when saving page in Fluxergy(has connected commit) [extensions/BlueSpiceFoundation] (REL1_31) - 10https://gerrit.wikimedia.org/r/634234 [14:33:17] (03CR) 10Bartosz Dziewoński: [C: 03+1] "> @TheDJ is there any reason not to merge it? You wrote on the task that you "never finished" this patch and now I'm not sure whether it's" [core] - 10https://gerrit.wikimedia.org/r/597262 (https://phabricator.wikimedia.org/T91167) (owner: 10TheDJ) [14:33:26] (03PS5) 10Bartosz Dziewoński: LivePreview: Show parse warnings and preview header/warning [core] - 10https://gerrit.wikimedia.org/r/597262 (https://phabricator.wikimedia.org/T91167) (owner: 10TheDJ) [14:34:49] (03PS2) 10Robert Vogel: WIP Add new hook handler for `EditPageGetCheckboxesDefinition` [extensions/BlueSpiceFoundation] (REL1_31) - 10https://gerrit.wikimedia.org/r/634234 (owner: 10Noname1706) [14:35:07] (03CR) 10jerkins-bot: [V: 04-1] MessagesJv.php: Update specialpages and namespaces in Javanese [core] - 10https://gerrit.wikimedia.org/r/634101 (https://phabricator.wikimedia.org/T255747) (owner: 10Labdajiwa) [14:35:45] (03CR) 10Phuedx: [C: 04-1] "-1 for your attention only. Thanks for picking up the task." (032 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/634187 (https://phabricator.wikimedia.org/T235812) (owner: 10Gergő Tisza) [14:36:18] (03CR) 10Vidhi-Mody: "> Patch Set 3:" [core] - 10https://gerrit.wikimedia.org/r/633278 (https://phabricator.wikimedia.org/T265011) (owner: 10Harriet Ayugi) [14:36:36] (03PS1) 10Tpt: Revert "Fix escaping in PageContentBuilder::buildDefaultContentForPageTitle" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/634105 (https://phabricator.wikimedia.org/T265571) [14:36:45] (03CR) 10Phuedx: [C: 03+2] Add missing ResourceLoader dependency [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/634186 (owner: 10Gergő Tisza) [14:36:49] (03PS1) 10Bartosz Dziewoński: Add new OOUI messages to the module definition [core] - 10https://gerrit.wikimedia.org/r/634236 [14:36:51] (03PS1) 10Pwirth: Replace usage of deprecated \Revision [extensions/BlueSpiceSocial] (REL1_35) - 10https://gerrit.wikimedia.org/r/634237 [14:37:02] (03CR) 10jerkins-bot: [V: 04-1] WIP Add new hook handler for `EditPageGetCheckboxesDefinition` [extensions/BlueSpiceFoundation] (REL1_31) - 10https://gerrit.wikimedia.org/r/634234 (owner: 10Noname1706) [14:37:57] (03CR) 10Reedy: [C: 04-1] MessagesJv.php: Update specialpages and namespaces in Javanese (031 comment) [core] - 10https://gerrit.wikimedia.org/r/634101 (https://phabricator.wikimedia.org/T255747) (owner: 10Labdajiwa) [14:38:38] (03CR) 10SamanthaNguyen: [C: 04-1] CosmosTemplate: Don't pass string parameter by reference (032 comments) [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/634143 (https://phabricator.wikimedia.org/T265232) (owner: 10SamanthaNguyen) [14:38:42] (03PS1) 10Pwirth: Replace usage of deprecated \Revision [extensions/BlueSpiceUEModuleDOCX] (REL1_35) - 10https://gerrit.wikimedia.org/r/634239 [14:39:02] (03PS1) 10Pwirth: Replace usage of deprecated \Revision [extensions/BlueSpiceUEModuleHTML] (REL1_35) - 10https://gerrit.wikimedia.org/r/634240 [14:39:20] (03CR) 10Vidhi-Mody: [C: 03+1] "Looks good to me!" [extensions/Math] - 10https://gerrit.wikimedia.org/r/634038 (https://phabricator.wikimedia.org/T265463) (owner: 10Js636f) [14:39:22] (03PS1) 10Pwirth: Replace usage of deprecated \Revision [extensions/BlueSpiceUEModulePDF] (REL1_35) - 10https://gerrit.wikimedia.org/r/634241 [14:39:32] (03PS1) 10Akanksha Bhattachan: Outreachy Microtask: [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/634242 (https://phabricator.wikimedia.org/T265463) [14:42:23] (03CR) 10Tosfos: [C: 03+1] "Tested with 1.35" [extensions/Push] - 10https://gerrit.wikimedia.org/r/625988 (owner: 10Pastakhov) [14:42:35] (03PS1) 10Ebernhardson: spark: correctly parse non-partitioned partition spec [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/634243 [14:42:46] (03PS5) 10Labdajiwa: MessagesJv.php: Update specialpages and namespaces in Javanese [core] - 10https://gerrit.wikimedia.org/r/634101 (https://phabricator.wikimedia.org/T255747) [14:43:27] (03CR) 10Bartosz Dziewoński: [C: 03+2] HTMLTextField: support non-boolean autocomplete values in OOUI [core] - 10https://gerrit.wikimedia.org/r/630356 (https://phabricator.wikimedia.org/T150983) (owner: 10Gergő Tisza) [14:44:29] (03CR) 10jerkins-bot: [V: 04-1] Replace usage of deprecated \Revision [extensions/BlueSpiceSocial] (REL1_35) - 10https://gerrit.wikimedia.org/r/634237 (owner: 10Pwirth) [14:45:45] (03CR) 10Bartosz Dziewoński: [C: 03+1] Add autocomplete HTML attribute to common auth form fields [core] - 10https://gerrit.wikimedia.org/r/630357 (https://phabricator.wikimedia.org/T263927) (owner: 10Gergő Tisza) [14:49:01] (03PS1) 10SBassett: Revert "Validate username input before constructing subpage links" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/634246 [14:49:36] (03CR) 10Jason Linehan: "> Patch Set 2:" [schemas/event/primary] - 10https://gerrit.wikimedia.org/r/634124 (https://phabricator.wikimedia.org/T256173) (owner: 10Jason Linehan) [14:49:56] (03PS2) 10Urbanecm: Revert "Validate username input before constructing subpage links" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/634246 (https://phabricator.wikimedia.org/T265606) (owner: 10SBassett) [14:50:25] (03CR) 10Vidhi-Mody: "This is nice work. I have left a few inline comments. Let me know if you have any queries." (032 comments) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/634242 (https://phabricator.wikimedia.org/T265463) (owner: 10Akanksha Bhattachan) [14:51:02] (03CR) 10Jason Linehan: mediawiki/client/error: Adds is_logged_in field (031 comment) [schemas/event/primary] - 10https://gerrit.wikimedia.org/r/634124 (https://phabricator.wikimedia.org/T256173) (owner: 10Jason Linehan) [14:51:04] (03CR) 10Urbanecm: [C: 03+2] Revert "Validate username input before constructing subpage links" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/634246 (https://phabricator.wikimedia.org/T265606) (owner: 10SBassett) [14:51:18] (03CR) 10Vidhi-Mody: "Please add mentors as reviewers to any patch that you push in future." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/634242 (https://phabricator.wikimedia.org/T265463) (owner: 10Akanksha Bhattachan) [14:51:35] (03CR) 10Zfilipin: [C: 03+2] "Good work! Ship it! 🚢😉" [extensions/Math] - 10https://gerrit.wikimedia.org/r/634038 (https://phabricator.wikimedia.org/T265463) (owner: 10Js636f) [14:52:18] (03Merged) 10jenkins-bot: Add missing ResourceLoader dependency [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/634186 (owner: 10Gergő Tisza) [14:52:52] (03CR) 10Akanksha Bhattachan: "Hello," [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/634242 (https://phabricator.wikimedia.org/T265463) (owner: 10Akanksha Bhattachan) [14:54:36] (03CR) 10Akanksha Bhattachan: "> Patch Set 1:" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/634242 (https://phabricator.wikimedia.org/T265463) (owner: 10Akanksha Bhattachan) [14:54:54] (03CR) 10Akanksha Bhattachan: "> Patch Set 1:" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/634242 (https://phabricator.wikimedia.org/T265463) (owner: 10Akanksha Bhattachan) [14:55:39] (03CR) 10Bartosz Dziewoński: [C: 03+2] LivePreview: Show parse warnings and preview header/warning [core] - 10https://gerrit.wikimedia.org/r/597262 (https://phabricator.wikimedia.org/T91167) (owner: 10TheDJ) [14:59:26] (03CR) 10Ebernhardson: [C: 03+2] spark: correctly parse non-partitioned partition spec [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/634243 (owner: 10Ebernhardson) [14:59:58] (03CR) 10Universal Omega: [C: 03+2] Cleanup checks for checking contents of i18n messages [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/634140 (https://phabricator.wikimedia.org/T265110) (owner: 10SamanthaNguyen) [15:01:03] (03CR) 10Labdajiwa: "At first I also saw weird indents in the diff, but now it's with tab. Is there anything else I can do with failed build?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/634101 (https://phabricator.wikimedia.org/T255747) (owner: 10Labdajiwa) [15:01:31] (03Merged) 10jenkins-bot: spark: correctly parse non-partitioned partition spec [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/634243 (owner: 10Ebernhardson) [15:04:03] (03CR) 10jerkins-bot: [V: 04-1] Add `/tests/selenium/log/` folder to `.gitignore` file [extensions/Math] - 10https://gerrit.wikimedia.org/r/634038 (https://phabricator.wikimedia.org/T265463) (owner: 10Js636f) [15:04:26] (03Merged) 10jenkins-bot: HTMLTextField: support non-boolean autocomplete values in OOUI [core] - 10https://gerrit.wikimedia.org/r/630356 (https://phabricator.wikimedia.org/T150983) (owner: 10Gergő Tisza) [15:07:33] (03PS1) 10Akanksha Bhattachan: Added '/tests/selenium/log' in .gitignore [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/634267 (https://phabricator.wikimedia.org/T265463) [15:07:55] (03CR) 10jerkins-bot: [V: 04-1] Add new OOUI messages to the module definition [core] - 10https://gerrit.wikimedia.org/r/634236 (owner: 10Bartosz Dziewoński) [15:08:18] (03CR) 10Urbanecm: "recheck" [extensions/Math] - 10https://gerrit.wikimedia.org/r/632194 (owner: 10Thiemo Kreuz (WMDE)) [15:11:45] (03PS1) 10Pwirth: Fix double registration of dashboard portlets and configs [extensions/BlueSpiceRSSFeeder] (REL1_35) - 10https://gerrit.wikimedia.org/r/634268 [15:11:47] (03Merged) 10jenkins-bot: Revert "Validate username input before constructing subpage links" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/634246 (https://phabricator.wikimedia.org/T265606) (owner: 10SBassett) [15:13:21] (03PS2) 10Akanksha Bhattachan: Added '/tests/selenium/log' in .gitignore [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/634242 (https://phabricator.wikimedia.org/T265463) [15:15:31] (03Merged) 10jenkins-bot: LivePreview: Show parse warnings and preview header/warning [core] - 10https://gerrit.wikimedia.org/r/597262 (https://phabricator.wikimedia.org/T91167) (owner: 10TheDJ) [15:15:37] (03Merged) 10jenkins-bot: Cleanup checks for checking contents of i18n messages [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/634140 (https://phabricator.wikimedia.org/T265110) (owner: 10SamanthaNguyen) [15:17:35] (03PS1) 10Urbanecm: Validate username input before constructing subpage links [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/634269 (https://phabricator.wikimedia.org/T217713) [15:20:41] (03CR) 10Esanders: [C: 03+2] Correctly generate timezone abbreviations for parsing [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/634073 (https://phabricator.wikimedia.org/T265500) (owner: 10Bartosz Dziewoński) [15:24:15] (03Merged) 10jenkins-bot: Correctly generate timezone abbreviations for parsing [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/634073 (https://phabricator.wikimedia.org/T265500) (owner: 10Bartosz Dziewoński) [15:34:18] (03CR) 10jerkins-bot: [V: 04-1] Remove confusing doc from MathRestbaseInterface [extensions/Math] - 10https://gerrit.wikimedia.org/r/632194 (owner: 10Thiemo Kreuz (WMDE)) [15:36:10] (03CR) 10Vidhi-Mody: Add `/tests/selenium/log/` folder to `.gitignore` file [extensions/Math] - 10https://gerrit.wikimedia.org/r/634038 (https://phabricator.wikimedia.org/T265463) (owner: 10Js636f) [15:37:57] (03CR) 10Zfilipin: "There's a problem with CI. We can't merge this right now." [extensions/Math] - 10https://gerrit.wikimedia.org/r/634038 (https://phabricator.wikimedia.org/T265463) (owner: 10Js636f) [15:42:32] (03PS1) 10Pwirth: Fix missing label in user and admin dashboard [extensions/BlueSpiceRSSFeeder] (REL1_35) - 10https://gerrit.wikimedia.org/r/634273 [15:45:45] (03CR) 10Zfilipin: "Reported as T265628." [extensions/Math] - 10https://gerrit.wikimedia.org/r/634038 (https://phabricator.wikimedia.org/T265463) (owner: 10Js636f) [15:45:56] (03CR) 10Reedy: Implement #transliterate parser function (031 comment) [core] - 10https://gerrit.wikimedia.org/r/627938 (https://phabricator.wikimedia.org/T263082) (owner: 10David Kamholz) [15:46:01] (03PS4) 10MacFan4000: Remove SimpleSecurity [extensions] - 10https://gerrit.wikimedia.org/r/633265 (https://phabricator.wikimedia.org/T252722) [15:47:08] (03CR) 10Harriet Ayugi: "> Patch Set 3:" [core] - 10https://gerrit.wikimedia.org/r/633278 (https://phabricator.wikimedia.org/T265011) (owner: 10Harriet Ayugi) [15:50:54] (03PS1) 10Bartosz Dziewoński: Add preference to expand the "Advanced" menu when replying [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/634275 (https://phabricator.wikimedia.org/T261539) [15:51:26] (03CR) 10Nray: "Thank you for your help @Gilles, @Phedenskog, @Krinkle!" [core] - 10https://gerrit.wikimedia.org/r/624824 (https://phabricator.wikimedia.org/T251544) (owner: 10Nray) [15:54:14] (03PS12) 10David Kamholz: Implement #transliterate parser function [core] - 10https://gerrit.wikimedia.org/r/627938 (https://phabricator.wikimedia.org/T263082) [15:54:53] (03CR) 10Akanksha Bhattachan: "Hello ," (032 comments) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/634242 (https://phabricator.wikimedia.org/T265463) (owner: 10Akanksha Bhattachan) [15:55:48] (03CR) 10DannyS712: "> Patch Set 2: Code-Review+2" (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/633979 (https://phabricator.wikimedia.org/T174000) (owner: 10Matěj Suchánek) [15:59:07] (03PS4) 10Bartosz Dziewoński: CommentParser: Avoid unnecessary reference in foreach() [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/633859 [15:59:09] (03PS14) 10Bartosz Dziewoński: Allow headings to have IDs [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/631872 (https://phabricator.wikimedia.org/T264478) [15:59:11] (03PS13) 10Bartosz Dziewoński: Connect sub-threads to their parent threads [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/631873 (https://phabricator.wikimedia.org/T264478) [15:59:13] (03PS15) 10Bartosz Dziewoński: Disambiguate comments by parent ID, rather than sequential numbers [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/631874 (https://phabricator.wikimedia.org/T264478) [15:59:15] (03PS9) 10Bartosz Dziewoński: Add oldest timestamp in the thread to heading IDs [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/632750 (https://phabricator.wikimedia.org/T264478) [15:59:17] (03PS8) 10Bartosz Dziewoński: Fix some TODOs about test data [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/632753 [15:59:56] (03CR) 10Jdlrobson: [C: 03+1] "this seems like the right solution if content translation does not wish to display it" [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/634210 (https://phabricator.wikimedia.org/T265523) (owner: 10Ammarpad) [15:59:58] (03CR) 10Bartosz Dziewoński: "(rebased)" [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/633859 (owner: 10Bartosz Dziewoński) [16:00:01] (03CR) 10Bartosz Dziewoński: "(rebased)" [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/631872 (https://phabricator.wikimedia.org/T264478) (owner: 10Bartosz Dziewoński) [16:06:18] (03PS2) 10Jforrester: Add new OOUI messages to the module definition [core] - 10https://gerrit.wikimedia.org/r/634236 (owner: 10Bartosz Dziewoński) [16:06:33] (03CR) 10Jforrester: Add new OOUI messages to the module definition (031 comment) [core] - 10https://gerrit.wikimedia.org/r/634236 (owner: 10Bartosz Dziewoński) [16:09:39] (03PS5) 10Zoranzoki21: Convert QuizTabulate to use extension registration [extensions/QuizTabulate] - 10https://gerrit.wikimedia.org/r/481968 (https://phabricator.wikimedia.org/T206422) [16:10:43] (03CR) 10jerkins-bot: [V: 04-1] Convert QuizTabulate to use extension registration [extensions/QuizTabulate] - 10https://gerrit.wikimedia.org/r/481968 (https://phabricator.wikimedia.org/T206422) (owner: 10Zoranzoki21) [16:11:20] (03CR) 10Zoranzoki21: Convert QuizTabulate to use extension registration (032 comments) [extensions/QuizTabulate] - 10https://gerrit.wikimedia.org/r/481968 (https://phabricator.wikimedia.org/T206422) (owner: 10Zoranzoki21) [16:14:29] (03PS11) 10LukBukkit: Convert NetworkAuth to use extension registration [extensions/NetworkAuth] - 10https://gerrit.wikimedia.org/r/404169 (https://phabricator.wikimedia.org/T184876) [16:17:46] (03CR) 10LukBukkit: "> Patch Set 9: Code-Review-1" [extensions/NetworkAuth] - 10https://gerrit.wikimedia.org/r/404169 (https://phabricator.wikimedia.org/T184876) (owner: 10LukBukkit) [16:23:17] (03CR) 10Ottomata: "> It should but since logstash doesn't really care we haven't been bumping the version. Also since that would require an additional patch " [schemas/event/primary] - 10https://gerrit.wikimedia.org/r/634124 (https://phabricator.wikimedia.org/T256173) (owner: 10Jason Linehan) [16:26:35] (03CR) 10Daimona Eaytoy: "> Patch Set 2:" (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/633979 (https://phabricator.wikimedia.org/T174000) (owner: 10Matěj Suchánek) [16:29:38] (03CR) 10Jason Linehan: "> Patch Set 2:" [schemas/event/primary] - 10https://gerrit.wikimedia.org/r/634124 (https://phabricator.wikimedia.org/T256173) (owner: 10Jason Linehan) [16:30:59] (03CR) 10Bartosz Dziewoński: [C: 03+1] "Thanks, I copy-pasted it wrong…" [core] - 10https://gerrit.wikimedia.org/r/634236 (owner: 10Bartosz Dziewoński) [16:35:48] (03CR) 10Jforrester: [C: 03+2] Add new OOUI messages to the module definition [core] - 10https://gerrit.wikimedia.org/r/634236 (owner: 10Bartosz Dziewoński) [16:37:39] (03PS1) 10Nikki Nikkhoui: Blubber config [skins/Vector] (feat/search) - 10https://gerrit.wikimedia.org/r/634288 (https://phabricator.wikimedia.org/T257582) [16:41:49] (03PS6) 10Zoranzoki21: Convert QuizTabulate to use extension registration [extensions/QuizTabulate] - 10https://gerrit.wikimedia.org/r/481968 (https://phabricator.wikimedia.org/T206422) [16:45:22] (03CR) 10Clarakosi: [C: 03+1] "Tested locally and it works and as far as I can tell the difference engine would still check the user's permission before showing the diff" [core] - 10https://gerrit.wikimedia.org/r/588149 (https://phabricator.wikimedia.org/T213621) (owner: 10Ammarpad) [16:46:28] (03CR) 10Huji: Validate username input before constructing subpage links (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/634269 (https://phabricator.wikimedia.org/T217713) (owner: 10Urbanecm) [16:46:55] (03PS5) 10Phuedx: [component/typeahead-suggestion-title] Bold title after match [wvui] - 10https://gerrit.wikimedia.org/r/632949 (https://phabricator.wikimedia.org/T256043) [16:47:19] (03CR) 10Phuedx: "Recheck" [wvui] - 10https://gerrit.wikimedia.org/r/632949 (https://phabricator.wikimedia.org/T256043) (owner: 10Phuedx) [16:48:59] (03CR) 10Subramanya Sastry: Add basic docs for ParserCache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/631565 (owner: 10Ppchelko) [16:49:15] (03CR) 10Nray: [C: 03+2] [component/typeahead-suggestion-title] Bold title after match [wvui] - 10https://gerrit.wikimedia.org/r/632949 (https://phabricator.wikimedia.org/T256043) (owner: 10Phuedx) [16:51:25] (03Merged) 10jenkins-bot: [component/typeahead-suggestion-title] Bold title after match [wvui] - 10https://gerrit.wikimedia.org/r/632949 (https://phabricator.wikimedia.org/T256043) (owner: 10Phuedx) [16:52:21] (03PS1) 10VolkerE: Re-add Matomo analytics script [design/strategy] - 10https://gerrit.wikimedia.org/r/634291 (https://phabricator.wikimedia.org/T259322) [16:54:20] (03CR) 10Ppchelko: Add basic docs for ParserCache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/631565 (owner: 10Ppchelko) [16:55:53] (03Merged) 10jenkins-bot: Add new OOUI messages to the module definition [core] - 10https://gerrit.wikimedia.org/r/634236 (owner: 10Bartosz Dziewoński) [16:55:55] (03CR) 10Jforrester: [C: 03+2] "Thank you." [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/627574 (https://phabricator.wikimedia.org/T258093) (owner: 10Thiemo Kreuz (WMDE)) [16:57:26] (03PS1) 10Jdlrobson: Vertically align personal tools [skins/Vector] (wmf/1.36.0-wmf.13) - 10https://gerrit.wikimedia.org/r/634253 (https://phabricator.wikimedia.org/T264339) [16:57:33] (03PS1) 10Jdlrobson: Drop text indent in modern Vector [extensions/Echo] (wmf/1.36.0-wmf.13) - 10https://gerrit.wikimedia.org/r/634254 (https://phabricator.wikimedia.org/T264339) [16:57:35] (03CR) 10VolkerE: [V: 03+2 C: 03+2] Re-add Matomo analytics script [design/strategy] - 10https://gerrit.wikimedia.org/r/634291 (https://phabricator.wikimedia.org/T259322) (owner: 10VolkerE) [17:00:30] (03CR) 10Jason Linehan: "As there is a deploy window in 1 hr that we'd like to use to get the MW patch out, if I re-patch the producer code and bump the version he" [schemas/event/primary] - 10https://gerrit.wikimedia.org/r/634124 (https://phabricator.wikimedia.org/T256173) (owner: 10Jason Linehan) [17:01:07] (03CR) 10Subramanya Sastry: Add basic docs for ParserCache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/631565 (owner: 10Ppchelko) [17:02:00] (03CR) 10Clarakosi: [C: 03+2] Inject UserFactory into WatchedItemQueryService [core] - 10https://gerrit.wikimedia.org/r/633496 (https://phabricator.wikimedia.org/T265311) (owner: 10DannyS712) [17:03:03] (03Merged) 10jenkins-bot: Fix wrapper="…" failing for more complex selectors [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/627574 (https://phabricator.wikimedia.org/T258093) (owner: 10Thiemo Kreuz (WMDE)) [17:04:39] (03PS26) 10Phuedx: Add basic html, css and js. add network client [wvui] - 10https://gerrit.wikimedia.org/r/626478 (https://phabricator.wikimedia.org/T256041) (owner: 10Anribolon) [17:05:26] (03CR) 10jerkins-bot: [V: 04-1] Add basic html, css and js. add network client [wvui] - 10https://gerrit.wikimedia.org/r/626478 (https://phabricator.wikimedia.org/T256041) (owner: 10Anribolon) [17:06:04] (03CR) 10Daniel Kinzler: [C: 03+2] "Tested, works as intended." [core] - 10https://gerrit.wikimedia.org/r/633955 (https://phabricator.wikimedia.org/T243276) (owner: 10Kevin Bazira) [17:08:40] (03PS3) 10Ostrzyciel: Reverted tag: do not mark null revisions as reverted [core] - 10https://gerrit.wikimedia.org/r/633701 (https://phabricator.wikimedia.org/T265312) [17:08:52] (03CR) 10Ostrzyciel: Reverted tag: do not mark null revisions as reverted (032 comments) [core] - 10https://gerrit.wikimedia.org/r/633701 (https://phabricator.wikimedia.org/T265312) (owner: 10Ostrzyciel) [17:09:18] (03CR) 10Ppchelko: Add basic docs for ParserCache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/631565 (owner: 10Ppchelko) [17:09:56] (03CR) 10Ottomata: "Yus please!" [schemas/event/primary] - 10https://gerrit.wikimedia.org/r/634124 (https://phabricator.wikimedia.org/T256173) (owner: 10Jason Linehan) [17:10:32] (03PS1) 10Jason Linehan: mediawiki/client/error: Adds is_user_logged_in field [schemas/event/primary] - 10https://gerrit.wikimedia.org/r/634292 (https://phabricator.wikimedia.org/T256173) [17:10:42] (03Abandoned) 10Jason Linehan: mediawiki/client/error: Adds is_logged_in field [schemas/event/primary] - 10https://gerrit.wikimedia.org/r/634124 (https://phabricator.wikimedia.org/T256173) (owner: 10Jason Linehan) [17:13:28] (03CR) 10Subramanya Sastry: Add basic docs for ParserCache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/631565 (owner: 10Ppchelko) [17:15:13] (03PS27) 10Phuedx: Add basic html, css and js. add network client [wvui] - 10https://gerrit.wikimedia.org/r/626478 (https://phabricator.wikimedia.org/T256041) (owner: 10Anribolon) [17:16:10] (03CR) 10jerkins-bot: [V: 04-1] Add basic html, css and js. add network client [wvui] - 10https://gerrit.wikimedia.org/r/626478 (https://phabricator.wikimedia.org/T256041) (owner: 10Anribolon) [17:20:19] (03CR) 10Jason Linehan: "I forget, should this be 1.1.0 or 2.0.0?" [schemas/event/primary] - 10https://gerrit.wikimedia.org/r/634292 (https://phabricator.wikimedia.org/T256173) (owner: 10Jason Linehan) [17:21:11] (03CR) 10Daniel Kinzler: "Note entirely sure this is the right way to go..." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/634037 (https://phabricator.wikimedia.org/T263579) (owner: 10Ppchelko) [17:22:06] (03CR) 10Daniel Kinzler: Move serializability validation from ParserOutput to ParserCache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/634037 (https://phabricator.wikimedia.org/T263579) (owner: 10Ppchelko) [17:22:46] (03CR) 10DannyS712: [C: 03+2] Inject ReadOnlyMode service into AuthManager service [core] - 10https://gerrit.wikimedia.org/r/633330 (https://phabricator.wikimedia.org/T141495) (owner: 10Umherirrender) [17:23:26] (03PS1) 10Hulya Karakaya: add /tests/selenium/log to .gitignore file [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/634296 [17:25:55] (03CR) 10Hulya Karakaya: "I have checked the repository, and added `/tests/selenium/log` into `.gitignore` file for CircusSearch extension." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/634296 (owner: 10Hulya Karakaya) [17:27:08] (03Merged) 10jenkins-bot: Inject UserFactory into WatchedItemQueryService [core] - 10https://gerrit.wikimedia.org/r/633496 (https://phabricator.wikimedia.org/T265311) (owner: 10DannyS712) [17:28:43] (03CR) 10DannyS712: "will need a rebase due to merge conflict with https://gerrit.wikimedia.org/r/c/mediawiki/core/+/633330 with is merging now" [core] - 10https://gerrit.wikimedia.org/r/587575 (https://phabricator.wikimedia.org/T141495) (owner: 10Umherirrender) [17:33:02] (03PS1) 10Ebernhardson: wmf_spark: Fix failure to generate partition cond when empty [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/634299 [17:38:13] (03CR) 10DannyS712: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/634257 (https://phabricator.wikimedia.org/T265311) (owner: 10DannyS712) [17:38:41] (03PS1) 10Hulya Karakaya: add /tests/selenium/log to .gitignore file [extensions/Popups] - 10https://gerrit.wikimedia.org/r/634301 [17:39:29] (03PS3) 10Ppchelko: Add basic docs for ParserCache [core] - 10https://gerrit.wikimedia.org/r/631565 [17:39:36] (03CR) 10Hulya Karakaya: "Added `/tests/selenium/log` into `.gitignore` file for Popups extension" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/634301 (owner: 10Hulya Karakaya) [17:40:18] (03CR) 10Ppchelko: Add basic docs for ParserCache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/631565 (owner: 10Ppchelko) [17:41:07] (03CR) 10DannyS712: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/634258 (https://phabricator.wikimedia.org/T265311) (owner: 10DannyS712) [17:44:27] (03CR) 10Daimona Eaytoy: [C: 04-1] Simplify ViewEdit, last round (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/630379 (owner: 10Daimona Eaytoy) [17:46:41] (03PS1) 10Karl Wettin (WMSE): Use system logger [services/wikispeech/mishkal] - 10https://gerrit.wikimedia.org/r/634304 (https://phabricator.wikimedia.org/T252752) [17:49:18] (03PS1) 10Jforrester: MathCoverageTest: Skip all tests for now as HTTP requests are banned [extensions/Math] - 10https://gerrit.wikimedia.org/r/634305 (https://phabricator.wikimedia.org/T265628) [17:50:54] (03PS2) 10Jason Linehan: mediawiki/client/error: Adds is_user_logged_in and is_banner_shown. [schemas/event/primary] - 10https://gerrit.wikimedia.org/r/634292 (https://phabricator.wikimedia.org/T256173) [17:55:49] (03Merged) 10jenkins-bot: Inject ReadOnlyMode service into AuthManager service [core] - 10https://gerrit.wikimedia.org/r/633330 (https://phabricator.wikimedia.org/T141495) (owner: 10Umherirrender) [17:57:29] (03PS1) 10DCausse: Send enabled tests to the frontend [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/634308 (https://phabricator.wikimedia.org/T262845) [18:01:28] (03CR) 10Jdlrobson: [C: 03+2] "this wfm. Note there may be other places where elements are not collapsed due to implict loading however so we should bear this in mind if" [core] - 10https://gerrit.wikimedia.org/r/633826 (https://phabricator.wikimedia.org/T260642) (owner: 10Bartosz Dziewoński) [18:01:32] (03CR) 10Jdlrobson: [C: 03+2] Revert "Move activating of makeCollapsible out of 'mediawiki.page.ready'" [core] - 10https://gerrit.wikimedia.org/r/633759 (https://phabricator.wikimedia.org/T260642) (owner: 10Bartosz Dziewoński) [18:06:31] (03CR) 10Ppchelko: Move serializability validation from ParserOutput to ParserCache (032 comments) [core] - 10https://gerrit.wikimedia.org/r/634037 (https://phabricator.wikimedia.org/T263579) (owner: 10Ppchelko) [18:09:55] (03CR) 10Ottomata: "1.1.0" [schemas/event/primary] - 10https://gerrit.wikimedia.org/r/634292 (https://phabricator.wikimedia.org/T256173) (owner: 10Jason Linehan) [18:10:31] (03CR) 10Jdlrobson: [C: 03+2] add /tests/selenium/log to .gitignore file [extensions/Popups] - 10https://gerrit.wikimedia.org/r/634301 (owner: 10Hulya Karakaya) [18:11:29] (03CR) 10Ottomata: mediawiki/client/error: Adds is_user_logged_in and is_banner_shown. (031 comment) [schemas/event/primary] - 10https://gerrit.wikimedia.org/r/634292 (https://phabricator.wikimedia.org/T256173) (owner: 10Jason Linehan) [18:12:11] (03PS6) 10Umherirrender: Use UserNameUtils in AuthManager [core] - 10https://gerrit.wikimedia.org/r/587575 (https://phabricator.wikimedia.org/T141495) [18:12:23] (03CR) 10Umherirrender: "Rebased" [core] - 10https://gerrit.wikimedia.org/r/587575 (https://phabricator.wikimedia.org/T141495) (owner: 10Umherirrender) [18:14:37] (03CR) 10Jason Linehan: mediawiki/client/error: Adds is_user_logged_in and is_banner_shown. (031 comment) [schemas/event/primary] - 10https://gerrit.wikimedia.org/r/634292 (https://phabricator.wikimedia.org/T256173) (owner: 10Jason Linehan) [18:16:04] (03CR) 10DannyS712: [C: 03+1] "waiting for Jenkins before merging" [core] - 10https://gerrit.wikimedia.org/r/587575 (https://phabricator.wikimedia.org/T141495) (owner: 10Umherirrender) [18:16:32] (03PS4) 10Ppchelko: Add basic docs for ParserCache [core] - 10https://gerrit.wikimedia.org/r/631565 [18:16:46] (03CR) 10Ottomata: mediawiki/client/error: Adds is_user_logged_in and is_banner_shown. (031 comment) [schemas/event/primary] - 10https://gerrit.wikimedia.org/r/634292 (https://phabricator.wikimedia.org/T256173) (owner: 10Jason Linehan) [18:19:27] (03CR) 10Jason Linehan: mediawiki/client/error: Adds is_user_logged_in and is_banner_shown. (031 comment) [schemas/event/primary] - 10https://gerrit.wikimedia.org/r/634292 (https://phabricator.wikimedia.org/T256173) (owner: 10Jason Linehan) [18:20:41] (03CR) 10DannyS712: Output line breaks in flushUtterances.php (032 comments) [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/634227 (owner: 10Karl Wettin (WMSE)) [18:22:31] (03CR) 10Catrope: [C: 03+2] Vertically align personal tools [skins/Vector] (wmf/1.36.0-wmf.13) - 10https://gerrit.wikimedia.org/r/634253 (https://phabricator.wikimedia.org/T264339) (owner: 10Jdlrobson) [18:22:36] (03CR) 10Ppchelko: [C: 03+2] OAuth: Replace User::isAllowed calls with PermissionManager. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/575768 (https://phabricator.wikimedia.org/T246567) (owner: 10Ammarpad) [18:22:38] (03CR) 10jerkins-bot: [V: 04-1] MathCoverageTest: Skip all tests for now as HTTP requests are banned [extensions/Math] - 10https://gerrit.wikimedia.org/r/634305 (https://phabricator.wikimedia.org/T265628) (owner: 10Jforrester) [18:22:43] (03CR) 10Catrope: [C: 03+2] Drop text indent in modern Vector [extensions/Echo] (wmf/1.36.0-wmf.13) - 10https://gerrit.wikimedia.org/r/634254 (https://phabricator.wikimedia.org/T264339) (owner: 10Jdlrobson) [18:24:06] (03Merged) 10jenkins-bot: Revert "Move activating of makeCollapsible out of 'mediawiki.page.ready'" [core] - 10https://gerrit.wikimedia.org/r/633759 (https://phabricator.wikimedia.org/T260642) (owner: 10Bartosz Dziewoński) [18:24:49] (03CR) 10DannyS712: Add a FilterLookup service (038 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628579 (owner: 10Daimona Eaytoy) [18:26:19] (03PS1) 10Urbanecm: Add updatemediainfo.sh [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/634311 [18:26:21] (03CR) 10Urbanecm: [C: 03+2] Add updatemediainfo.sh [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/634311 (owner: 10Urbanecm) [18:26:43] (03Merged) 10jenkins-bot: Add updatemediainfo.sh [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/634311 (owner: 10Urbanecm) [18:28:00] (03PS1) 10Urbanecm: Update cron.txt [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/634312 [18:28:02] (03CR) 10Urbanecm: [C: 03+2] Update cron.txt [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/634312 (owner: 10Urbanecm) [18:28:04] (03PS1) 10Urbanecm: Add updatemediainfo.sh to cron, run daily [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/634313 [18:28:06] (03CR) 10Urbanecm: [C: 03+2] Add updatemediainfo.sh to cron, run daily [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/634313 (owner: 10Urbanecm) [18:28:09] (03CR) 10DannyS712: Add API for publishing section translations (033 comments) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/632660 (https://phabricator.wikimedia.org/T264736) (owner: 10Santhosh) [18:28:24] (03Merged) 10jenkins-bot: Update cron.txt [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/634312 (owner: 10Urbanecm) [18:31:17] (03Merged) 10jenkins-bot: Add updatemediainfo.sh to cron, run daily [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/634313 (owner: 10Urbanecm) [18:32:05] (03CR) 10Jdlrobson: [C: 03+1] SearchSatisfaction: Add isAnon field [schemas/event/secondary] - 10https://gerrit.wikimedia.org/r/634230 (https://phabricator.wikimedia.org/T259250) (owner: 10Phuedx) [18:35:37] (03CR) 10Vidhi-Mody: "This is a nice start. I have left a few inline comments." (033 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/634296 (owner: 10Hulya Karakaya) [18:37:59] (03CR) 10Subramanya Sastry: Add basic docs for ParserCache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/631565 (owner: 10Ppchelko) [18:42:02] (03Merged) 10jenkins-bot: Vertically align personal tools [skins/Vector] (wmf/1.36.0-wmf.13) - 10https://gerrit.wikimedia.org/r/634253 (https://phabricator.wikimedia.org/T264339) (owner: 10Jdlrobson) [18:43:12] (03Merged) 10jenkins-bot: mediawiki.htmlform: Ensure collapsible forms are enabled [core] - 10https://gerrit.wikimedia.org/r/633826 (https://phabricator.wikimedia.org/T260642) (owner: 10Bartosz Dziewoński) [18:43:23] (03Merged) 10jenkins-bot: add /tests/selenium/log to .gitignore file [extensions/Popups] - 10https://gerrit.wikimedia.org/r/634301 (owner: 10Hulya Karakaya) [18:43:25] (03Merged) 10jenkins-bot: OAuth: Replace User::isAllowed calls with PermissionManager. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/575768 (https://phabricator.wikimedia.org/T246567) (owner: 10Ammarpad) [18:43:27] (03CR) 10jerkins-bot: [V: 04-1] Add basic docs for ParserCache [core] - 10https://gerrit.wikimedia.org/r/631565 (owner: 10Ppchelko) [18:49:37] (03Merged) 10jenkins-bot: Drop text indent in modern Vector [extensions/Echo] (wmf/1.36.0-wmf.13) - 10https://gerrit.wikimedia.org/r/634254 (https://phabricator.wikimedia.org/T264339) (owner: 10Jdlrobson) [18:50:20] (03PS1) 10Bartosz Dziewoński: resourceloader: Set strictUnits to true for LESS compilation [core] - 10https://gerrit.wikimedia.org/r/634315 (https://phabricator.wikimedia.org/T265650) [18:54:59] (03CR) 10DannyS712: [C: 03+2] Use UserNameUtils in AuthManager [core] - 10https://gerrit.wikimedia.org/r/587575 (https://phabricator.wikimedia.org/T141495) (owner: 10Umherirrender) [18:55:47] (03CR) 10Bartosz Dziewoński: [C: 04-2] "Breaks things, see task" [core] - 10https://gerrit.wikimedia.org/r/634315 (https://phabricator.wikimedia.org/T265650) (owner: 10Bartosz Dziewoński) [18:55:51] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Set strictUnits to true for LESS compilation [core] - 10https://gerrit.wikimedia.org/r/634315 (https://phabricator.wikimedia.org/T265650) (owner: 10Bartosz Dziewoński) [18:56:16] (03CR) 10Umherirrender: [C: 03+2] Inject UserFactory into SpecialConfirmEmail [core] - 10https://gerrit.wikimedia.org/r/634257 (https://phabricator.wikimedia.org/T265311) (owner: 10DannyS712) [19:01:08] (03CR) 10Ppchelko: "recheck" [core] - 10https://gerrit.wikimedia.org/r/631565 (owner: 10Ppchelko) [19:03:13] (03CR) 10Umherirrender: [C: 04-1] Inject UserFactory into SpecialEmailInvalidate (031 comment) [core] - 10https://gerrit.wikimedia.org/r/634258 (https://phabricator.wikimedia.org/T265311) (owner: 10DannyS712) [19:03:33] (03PS2) 10SamanthaNguyen: CosmosTemplate: Don't pass string parameter by reference [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/634143 (https://phabricator.wikimedia.org/T265232) [19:06:58] (03PS3) 10SamanthaNguyen: CosmosTemplate: Don't pass string parameter by reference [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/634143 (https://phabricator.wikimedia.org/T265232) [19:09:28] (03CR) 10Urbanecm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/627938 (https://phabricator.wikimedia.org/T263082) (owner: 10David Kamholz) [19:13:00] (03CR) 10Urbanecm: Validate username input before constructing subpage links (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/634269 (https://phabricator.wikimedia.org/T217713) (owner: 10Urbanecm) [19:14:49] (03CR) 10Huji: Validate username input before constructing subpage links (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/634269 (https://phabricator.wikimedia.org/T217713) (owner: 10Urbanecm) [19:17:33] (03PS2) 10Urbanecm: Validate username input before constructing subpage links [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/634269 (https://phabricator.wikimedia.org/T217713) [19:18:14] (03CR) 10Urbanecm: Validate username input before constructing subpage links (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/634269 (https://phabricator.wikimedia.org/T217713) (owner: 10Urbanecm) [19:18:29] (03CR) 10Universal Omega: [C: 03+2] CosmosTemplate: Don't pass string parameter by reference [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/634143 (https://phabricator.wikimedia.org/T265232) (owner: 10SamanthaNguyen) [19:23:36] (03PS1) 10Umherirrender: Inject LinkBatchFactory into SpecialExpandTemplates [core] - 10https://gerrit.wikimedia.org/r/634319 (https://phabricator.wikimedia.org/T259960) [19:30:01] (03Merged) 10jenkins-bot: Use UserNameUtils in AuthManager [core] - 10https://gerrit.wikimedia.org/r/587575 (https://phabricator.wikimedia.org/T141495) (owner: 10Umherirrender) [19:30:52] (03CR) 10Pastakhov: Make compatible with mw 1.35 (031 comment) [extensions/Push] - 10https://gerrit.wikimedia.org/r/625988 (owner: 10Pastakhov) [19:30:57] (03Merged) 10jenkins-bot: Inject UserFactory into SpecialConfirmEmail [core] - 10https://gerrit.wikimedia.org/r/634257 (https://phabricator.wikimedia.org/T265311) (owner: 10DannyS712) [19:31:01] (03Merged) 10jenkins-bot: CosmosTemplate: Don't pass string parameter by reference [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/634143 (https://phabricator.wikimedia.org/T265232) (owner: 10SamanthaNguyen) [19:31:47] (03CR) 10jerkins-bot: [V: 04-1] Implement #transliterate parser function [core] - 10https://gerrit.wikimedia.org/r/627938 (https://phabricator.wikimedia.org/T263082) (owner: 10David Kamholz) [19:34:15] (03CR) 10Ebernhardson: [C: 03+2] wmf_spark: Fix failure to generate partition cond when empty [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/634299 (owner: 10Ebernhardson) [19:36:16] (03Merged) 10jenkins-bot: wmf_spark: Fix failure to generate partition cond when empty [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/634299 (owner: 10Ebernhardson) [19:41:33] (03PS1) 10Sskenner: Update README.md with new info [sandbox] - 10https://gerrit.wikimedia.org/r/634325 [19:42:11] (03PS2) 10Ppchelko: Move serializability validation from ParserOutput to ParserCache [core] - 10https://gerrit.wikimedia.org/r/634037 (https://phabricator.wikimedia.org/T263579) [19:42:36] (03PS2) 10Hulya Karakaya: Add /tests/selenium/log to .gitignore file [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/634296 (https://phabricator.wikimedia.org/T265463) [19:42:58] (03CR) 10Ppchelko: "> Patch Set 1:" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/634037 (https://phabricator.wikimedia.org/T263579) (owner: 10Ppchelko) [19:43:27] (03PS1) 10Umherirrender: Inject PermissionManager into SpecialTags [core] - 10https://gerrit.wikimedia.org/r/634326 (https://phabricator.wikimedia.org/T259960) [19:44:42] (03CR) 10jerkins-bot: [V: 04-1] Validate username input before constructing subpage links [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/634269 (https://phabricator.wikimedia.org/T217713) (owner: 10Urbanecm) [19:45:26] (03PS1) 10Nray: Apply static positioning to mw-footer-container [skins/Vector] - 10https://gerrit.wikimedia.org/r/634329 (https://phabricator.wikimedia.org/T264679) [19:45:46] (03CR) 10Urbanecm: "recheck" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/634269 (https://phabricator.wikimedia.org/T217713) (owner: 10Urbanecm) [19:46:57] (03CR) 10Nray: [C: 04-1] "This probably needs more discussion. Just positing this as one option" [skins/Vector] - 10https://gerrit.wikimedia.org/r/634329 (https://phabricator.wikimedia.org/T264679) (owner: 10Nray) [19:52:16] (03PS1) 10Umherirrender: Inject NamespaceInfo into SpecialStatistics [core] - 10https://gerrit.wikimedia.org/r/634330 (https://phabricator.wikimedia.org/T259960) [19:56:32] (03PS2) 10Sskenner: Update README.md with new info [sandbox] - 10https://gerrit.wikimedia.org/r/634325 [19:59:09] (03PS1) 10Ppchelko: Drop 'comment' and 'parsedcomment' fields from rev-visibility-change [schemas/event/primary] - 10https://gerrit.wikimedia.org/r/634331 (https://phabricator.wikimedia.org/T265658) [19:59:17] (03PS1) 10Umherirrender: Inject LinkBatchFactory into SpecialSpecialpages [core] - 10https://gerrit.wikimedia.org/r/634332 (https://phabricator.wikimedia.org/T259960) [19:59:57] (03CR) 10Ppchelko: "non b/c, thus major version bump." [schemas/event/primary] - 10https://gerrit.wikimedia.org/r/634331 (https://phabricator.wikimedia.org/T265658) (owner: 10Ppchelko) [20:00:42] (03PS2) 10Umherirrender: Inject SpecialPageFactory into SpecialSpecialpages [core] - 10https://gerrit.wikimedia.org/r/634332 (https://phabricator.wikimedia.org/T259960) [20:01:14] (03CR) 10Reedy: "recheck" [core] - 10https://gerrit.wikimedia.org/r/634101 (https://phabricator.wikimedia.org/T255747) (owner: 10Labdajiwa) [20:02:27] (03CR) 10Sskenner: "> Patch Set 5:" [core] - 10https://gerrit.wikimedia.org/r/633284 (https://phabricator.wikimedia.org/T265011) (owner: 10Sskenner) [20:02:50] (03CR) 10Sskenner: "> Patch Set 5:" [core] - 10https://gerrit.wikimedia.org/r/633284 (https://phabricator.wikimedia.org/T265011) (owner: 10Sskenner) [20:03:23] (03CR) 10Ottomata: "Perhaps just not setting them in EventBus is enough. We can leave them in the schema (perhaps with updated descriptions?)" [schemas/event/primary] - 10https://gerrit.wikimedia.org/r/634331 (https://phabricator.wikimedia.org/T265658) (owner: 10Ppchelko) [20:03:24] (03CR) 10Ppchelko: [C: 04-2] "Wait a moment." [schemas/event/primary] - 10https://gerrit.wikimedia.org/r/634331 (https://phabricator.wikimedia.org/T265658) (owner: 10Ppchelko) [20:08:33] (03CR) 10jerkins-bot: [V: 04-1] Move serializability validation from ParserOutput to ParserCache [core] - 10https://gerrit.wikimedia.org/r/634037 (https://phabricator.wikimedia.org/T263579) (owner: 10Ppchelko) [20:13:41] (03PS1) 10Ppchelko: Read Revision from master for visibility-change event. [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/634334 (https://phabricator.wikimedia.org/T265658) [20:13:53] (03Abandoned) 10Ppchelko: Drop 'comment' and 'parsedcomment' fields from rev-visibility-change [schemas/event/primary] - 10https://gerrit.wikimedia.org/r/634331 (https://phabricator.wikimedia.org/T265658) (owner: 10Ppchelko) [20:15:43] (03PS3) 10Ppchelko: Move serializability validation from ParserOutput to ParserCache [core] - 10https://gerrit.wikimedia.org/r/634037 (https://phabricator.wikimedia.org/T263579) [20:17:50] (03CR) 10jerkins-bot: [V: 04-1] Read Revision from master for visibility-change event. [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/634334 (https://phabricator.wikimedia.org/T265658) (owner: 10Ppchelko) [20:18:12] (03PS1) 10Cicalese: Handle extra user menu and sidebar special pages. [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/634335 (https://phabricator.wikimedia.org/T264246) [20:18:27] (03CR) 10DannyS712: Do not call SpecialBlock::canBlockEmail from CheckUser (032 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/628506 (https://phabricator.wikimedia.org/T263334) (owner: 10Urbanecm) [20:21:36] (03CR) 10jerkins-bot: [V: 04-1] Handle extra user menu and sidebar special pages. [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/634335 (https://phabricator.wikimedia.org/T264246) (owner: 10Cicalese) [20:22:53] (03PS3) 10DannyS712: Inject UserFactory into SpecialEmailInvalidate [core] - 10https://gerrit.wikimedia.org/r/634258 (https://phabricator.wikimedia.org/T265311) [20:22:55] (03CR) 10DannyS712: Inject UserFactory into SpecialEmailInvalidate (031 comment) [core] - 10https://gerrit.wikimedia.org/r/634258 (https://phabricator.wikimedia.org/T265311) (owner: 10DannyS712) [20:24:42] (03CR) 10Ottomata: Read Revision from master for visibility-change event. (031 comment) [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/634334 (https://phabricator.wikimedia.org/T265658) (owner: 10Ppchelko) [20:27:11] (03PS2) 10Cicalese: Handle extra user menu and sidebar special pages. [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/634335 (https://phabricator.wikimedia.org/T264246) [20:29:36] (03PS17) 10DannyS712: Add new SiteStatistics class to replace SiteStats [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) [20:33:33] (03CR) 10DannyS712: [C: 03+1] Inject PermissionManager into SpecialTags (031 comment) [core] - 10https://gerrit.wikimedia.org/r/634326 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [20:35:13] (03PS3) 10Cicalese: Handle extra user menu and sidebar special pages. [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/634335 (https://phabricator.wikimedia.org/T264246) [20:35:59] (03CR) 10DannyS712: [C: 03+2] Inject NamespaceInfo into SpecialStatistics [core] - 10https://gerrit.wikimedia.org/r/634330 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [20:37:28] (03CR) 10Jdlrobson: Preserve query parameters when redirecting to mobile diff (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/630389 (https://phabricator.wikimedia.org/T263937) (owner: 10Bartosz Dziewoński) [20:37:55] (03CR) 10DannyS712: [C: 03+2] Inject SpecialPageFactory into SpecialSpecialpages [core] - 10https://gerrit.wikimedia.org/r/634332 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [20:39:02] (03CR) 10Ppchelko: "The test failure is unrelated. Filed T265663 to fix it up." [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/634334 (https://phabricator.wikimedia.org/T265658) (owner: 10Ppchelko) [20:40:36] (03CR) 10Umherirrender: [C: 03+2] Inject UserFactory into SpecialEmailInvalidate [core] - 10https://gerrit.wikimedia.org/r/634258 (https://phabricator.wikimedia.org/T265311) (owner: 10DannyS712) [20:41:09] (03PS2) 10Umherirrender: Inject PermissionManager into SpecialTags [core] - 10https://gerrit.wikimedia.org/r/634326 (https://phabricator.wikimedia.org/T259960) [20:41:17] (03CR) 10Umherirrender: Inject PermissionManager into SpecialTags (031 comment) [core] - 10https://gerrit.wikimedia.org/r/634326 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [20:42:17] (03CR) 10DannyS712: [C: 03+2] Inject PermissionManager into SpecialTags [core] - 10https://gerrit.wikimedia.org/r/634326 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [20:43:38] (03PS5) 10Alex Paskulin: Add basic docs for ParserCache [core] - 10https://gerrit.wikimedia.org/r/631565 (owner: 10Ppchelko) [20:44:27] (03CR) 10Alex Paskulin: "Nice work! Made a few small edits, and left one question." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/631565 (owner: 10Ppchelko) [20:45:22] (03PS18) 10DannyS712: Add new SiteStatistics class to replace SiteStats [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) [20:46:01] (03CR) 10Umherirrender: "Test will fail:" [core] - 10https://gerrit.wikimedia.org/r/634330 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [20:47:41] (03CR) 10DannyS712: [C: 03+2] "> Patch Set 1:" [core] - 10https://gerrit.wikimedia.org/r/634330 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [20:48:17] (03PS1) 10Ottomata: Add analytics/legacy/contenttranslationabusefilter schema [schemas/event/secondary] - 10https://gerrit.wikimedia.org/r/634337 (https://phabricator.wikimedia.org/T259163) [20:49:44] (03PS1) 10Ppchelko: Include URLs when clocking HTTP requests. [core] - 10https://gerrit.wikimedia.org/r/634338 [20:50:59] (03CR) 10DannyS712: Handle extra user menu and sidebar special pages. (034 comments) [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/634335 (https://phabricator.wikimedia.org/T264246) (owner: 10Cicalese) [20:51:31] (03CR) 10Alex Paskulin: [C: 03+1] "Tested locally, and looks great!" [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/634335 (https://phabricator.wikimedia.org/T264246) (owner: 10Cicalese) [20:51:39] (03PS6) 10Ppchelko: Add basic docs for ParserCache [core] - 10https://gerrit.wikimedia.org/r/631565 [20:51:41] (03CR) 10Ppchelko: Add basic docs for ParserCache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/631565 (owner: 10Ppchelko) [20:52:30] (03PS2) 10Ppchelko: Include URLs when blocking HTTP requests. [core] - 10https://gerrit.wikimedia.org/r/634338 [20:53:50] (03CR) 10DannyS712: [C: 04-2] "Please do not make test changes to the public readme" [sandbox] - 10https://gerrit.wikimedia.org/r/634325 (owner: 10Sskenner) [20:55:39] (03CR) 10Sskenner: "> Patch Set 2: Code-Review-2" [sandbox] - 10https://gerrit.wikimedia.org/r/634325 (owner: 10Sskenner) [20:56:46] 10MediaWiki-skins-WikimediaApiPortal, 10Patch-For-Review: Resolve Dashboard menu item - https://phabricator.wikimedia.org/T264246 (10apaskulin) a:05apaskulin→03CCicalese_WMF [20:57:24] (03CR) 10jerkins-bot: [V: 04-1] Inject NamespaceInfo into SpecialStatistics [core] - 10https://gerrit.wikimedia.org/r/634330 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [20:58:37] (03Merged) 10jenkins-bot: Inject SpecialPageFactory into SpecialSpecialpages [core] - 10https://gerrit.wikimedia.org/r/634332 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [21:00:42] (03PS2) 10Ppchelko: Read Revision from master for visibility-change event. [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/634334 (https://phabricator.wikimedia.org/T265658) [21:00:44] (03PS1) 10Ppchelko: Do not send events to actual HTTP with default config [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/634340 (https://phabricator.wikimedia.org/T265663) [21:00:51] (03Merged) 10jenkins-bot: Inject UserFactory into SpecialEmailInvalidate [core] - 10https://gerrit.wikimedia.org/r/634258 (https://phabricator.wikimedia.org/T265311) (owner: 10DannyS712) [21:01:55] (03CR) 10Umherirrender: [C: 03+2] "Resubmit" [core] - 10https://gerrit.wikimedia.org/r/634330 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [21:02:26] (03PS1) 10MarkAHershberger: Use Title::getArticleID instead of Title::exists for internal check [core] - 10https://gerrit.wikimedia.org/r/634341 (https://phabricator.wikimedia.org/T265665) [21:02:35] 04(no projects): RGBA hexadecimal value is not supported in background-color - https://phabricator.wikimedia.org/T265675 (10krosylight) [21:06:53] 10TemplateStyles: RGBA hexadecimal value is not supported in background-color - https://phabricator.wikimedia.org/T265675 (10SamanthaNguyen) [21:07:13] (03Merged) 10jenkins-bot: Inject PermissionManager into SpecialTags [core] - 10https://gerrit.wikimedia.org/r/634326 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [21:08:20] (03PS1) 10Ebernhardson: cirrus namespace map: Align output columns with table [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/634342 [21:08:43] (03PS2) 10Umherirrender: Inject LinkBatchFactory into SpecialTrackingCategories [core] - 10https://gerrit.wikimedia.org/r/634319 (https://phabricator.wikimedia.org/T259960) [21:08:53] 10TemplateStyles: RGBA hexadecimal value is not supported in background-color (no support for transparency value) - https://phabricator.wikimedia.org/T265675 (10Aklapper) [21:09:04] (03PS1) 10Harriet Ayugi: Add /tests/selenium/log to .gitignore file [extensions/Echo] - 10https://gerrit.wikimedia.org/r/634343 (https://phabricator.wikimedia.org/T265463) [21:10:12] (03PS2) 10Umherirrender: Use UserNameUtils in UserInfo [core] - 10https://gerrit.wikimedia.org/r/618609 [21:12:02] (03Abandoned) 10Alex Paskulin: copy: Update dashboard in user menu [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/634081 (https://phabricator.wikimedia.org/T264246) (owner: 10Alex Paskulin) [21:12:11] 10DiscussionTools, 10Editing QA, 10OWC2020, 10Beta-Feature, 10Editing-team (FY2020-21 Kanban Board): Make config change to enable Reply Tool as Beta Feature at Phase 2 wikis - https://phabricator.wikimedia.org/T264693 (10Ryasmeen) Completed testing on the following wikis: Amharic, Assamese, Bhojpuri, *... [21:12:13] 10Vector (Vector (Tracking)): Add nvm to Vector - https://phabricator.wikimedia.org/T265682 (10nnikkhoui) [21:12:21] (03CR) 10Harriet Ayugi: "Modified .gitignore file. Awaits review!" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/634343 (https://phabricator.wikimedia.org/T265463) (owner: 10Harriet Ayugi) [21:13:11] (03CR) 10Alex Paskulin: [C: 03+2] "Looks great!" [core] - 10https://gerrit.wikimedia.org/r/631565 (owner: 10Ppchelko) [21:13:48] 10WMCH-Cronos: WMCH Documentation - https://phabricator.wikimedia.org/T265683 (10valerio.bozzolan) [21:14:00] 10WMCH-Cronos: WMCH Cronos Documentation - https://phabricator.wikimedia.org/T265683 (10valerio.bozzolan) p:05Triage→03Low a:03valerio.bozzolan [21:17:54] (03CR) 10jerkins-bot: [V: 04-1] Include URLs when blocking HTTP requests. [core] - 10https://gerrit.wikimedia.org/r/634338 (owner: 10Ppchelko) [21:18:48] 10itWikiCon-2020: Avviare la call per il programma - https://phabricator.wikimedia.org/T253886 (10valerio.bozzolan) [21:18:50] 10itWikiCon-2020: Invite some keynotes to host awesome talks - https://phabricator.wikimedia.org/T253906 (10valerio.bozzolan) 05Open→03Resolved Well, thanks Ilario for your awesome contribution on this part! [21:19:05] (03CR) 10Umherirrender: Simplify user page handling in SpecialRedirect (031 comment) [core] - 10https://gerrit.wikimedia.org/r/632783 (owner: 10Umherirrender) [21:19:24] (03PS3) 10Ppchelko: Include URLs when clocking HTTP requests. [core] - 10https://gerrit.wikimedia.org/r/634338 [21:19:50] 10itWikiCon-2020: Redigere il programma di itWikiCon 2020 - https://phabricator.wikimedia.org/T255340 (10valerio.bozzolan) 05Open→03Resolved a:03valerio.bozzolan Ladies and Gentleman, here we are since some days: https://meta.wikimedia.org/wiki/ItWikiCon/2020/Programma [21:20:23] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10Patch-For-Review: Make it easy for editors to customize the edit summary of each comment they post - https://phabricator.wikimedia.org/T261539 (10Tacsipacsi) I don’t like if such a simple action as clicking on a toggle changes something shown in m... [21:20:29] 10itWikiCon-2020: Richiedere un messaggio del presidente della Repubblica Italiana (o l’Alto patronato) - https://phabricator.wikimedia.org/T256174 (10valerio.bozzolan) [21:21:30] 10WVUI, 10Vue.js (Vue.js-Search): Publish WVUI: build products and NPM - https://phabricator.wikimedia.org/T264244 (10jeena) >>! In T264244#6548155, @nnikkhoui wrote: > Based on some trial and error, I don't believe checkbox 1 `Publish WVUI prerelease to NPM as part of Jenkins CI when a new patch is merged int... [21:22:02] (03Merged) 10jenkins-bot: Inject NamespaceInfo into SpecialStatistics [core] - 10https://gerrit.wikimedia.org/r/634330 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [21:22:33] (03PS1) 10Amire80: Change the autonym of the Altai language [core] - 10https://gerrit.wikimedia.org/r/634346 [21:22:39] (03Abandoned) 10Amire80: Hide interlanguage links using a CSS class [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/343834 (https://phabricator.wikimedia.org/T159619) (owner: 10Amire80) [21:22:52] (03Abandoned) 10Amire80: Bidi-isolate autonumber and free external links [core] - 10https://gerrit.wikimedia.org/r/286128 (owner: 10Amire80) [21:23:33] (03PS4) 10Legoktm: Initial commit of Python 3.7 builder [cloud/toolforge/buildpacks] - 10https://gerrit.wikimedia.org/r/633270 [21:23:35] (03PS5) 10Umherirrender: Inject services into SpecialNewpages [core] - 10https://gerrit.wikimedia.org/r/628444 (https://phabricator.wikimedia.org/T259960) [21:23:46] (03PS3) 10Umherirrender: Inject services into SpecialCategories [core] - 10https://gerrit.wikimedia.org/r/628485 (https://phabricator.wikimedia.org/T259960) [21:23:54] (03PS3) 10Umherirrender: Inject services into SpecialAllMessages [core] - 10https://gerrit.wikimedia.org/r/628528 (https://phabricator.wikimedia.org/T259960) [21:24:04] (03PS1) 10Harriet Ayugi: Add /tests/selenium/log to .gitignore file [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/634347 (https://phabricator.wikimedia.org/T265463) [21:24:07] (03PS6) 10Umherirrender: Inject services into SpecialNewFiles [core] - 10https://gerrit.wikimedia.org/r/628438 (https://phabricator.wikimedia.org/T259960) [21:24:21] 10MediaWiki-libs-HTTP, 10MW-on-K8s, 10Platform Team Workboards (Clinic Duty Team): Provide direct access to a Guzzle HTTP client - https://phabricator.wikimedia.org/T263816 (10tstarling) I should note that I haven't actually tested and confirmed correct streaming behaviour in Guzzle, but I'm pretty sure it w... [21:24:43] 10CX-boost, 10Language-Team (Language-2020-October-December): Enable Content Translation in Somali Wikipedia as a default tool - https://phabricator.wikimedia.org/T264740 (10Amire80) [[ https://so.wikipedia.org/w/index.php?title=Wikipedia:Safaarad&diff=prev&oldid=206464 | Notification ]]. [21:25:06] 10CX-boost, 10Language-Team (Language-2020-October-December): Enable Content Translation in Irish Wikipedia as a default tool - https://phabricator.wikimedia.org/T264739 (10Amire80) [[ https://ga.wikipedia.org/w/index.php?title=Vicip%C3%A9id:L%C3%A1rionad_comhphobail&diff=prev&oldid=977112 | Notification ]]. [21:25:37] 10CX-boost, 10Language-Team (Language-2020-October-December): Enable Content Translation in Esperanto Wikipedia as a default tool - https://phabricator.wikimedia.org/T264737 (10Amire80) [[ https://eo.wikipedia.org/w/index.php?title=Vikipedio:Diskutejo/Teknikejo&diff=prev&oldid=7043524 | Notification ]]. [21:26:08] 10CX-boost, 10Language-Team (Language-2020-October-December): Enable Content Translation in Belarusian Wikipedia as a default tool - https://phabricator.wikimedia.org/T264738 (10Amire80) [[ https://be.wikipedia.org/w/index.php?title=%D0%92%D1%96%D0%BA%D1%96%D0%BF%D0%B5%D0%B4%D1%8B%D1%8F:%D0%A4%D0%BE%D1%80%D1%8... [21:26:20] (03CR) 10Harriet Ayugi: "Added /tests/selenium/log to .gitignore file. Awaits review." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/634347 (https://phabricator.wikimedia.org/T265463) (owner: 10Harriet Ayugi) [21:26:41] 10CX-boost, 10Language-Team (Language-2020-October-December): Enable Content Translation in Oriya Wikipedia as a default tool - https://phabricator.wikimedia.org/T264741 (10Amire80) [[ https://or.wikipedia.org/wiki/%E0%AC%AC%E0%AC%BF%E0%AC%B7%E0%AD%9F:Vvu0vwem7eqg1i3r | Notification ]]. [21:29:16] (03PS4) 10Cicalese: Handle extra user menu and sidebar special pages. [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/634335 (https://phabricator.wikimedia.org/T264246) [21:30:02] (03CR) 10Cicalese: "Thank you for the review!" (034 comments) [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/634335 (https://phabricator.wikimedia.org/T264246) (owner: 10Cicalese) [21:32:40] (03Merged) 10jenkins-bot: Add basic docs for ParserCache [core] - 10https://gerrit.wikimedia.org/r/631565 (owner: 10Ppchelko) [21:35:11] (03CR) 10Tjones: [C: 03+1] "Marked comments as done, otherwise Gerrit complains later." (033 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/634296 (https://phabricator.wikimedia.org/T265463) (owner: 10Hulya Karakaya) [21:36:39] (03PS5) 10Legoktm: Initial commit of Python 3.7 builder [cloud/toolforge/buildpacks] - 10https://gerrit.wikimedia.org/r/633270 (https://phabricator.wikimedia.org/T265686) [21:37:46] (03PS1) 10SamanthaNguyen: Inject a MessageLocalizer into CosmosNavigation and CosmosToolbar [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/634352 (https://phabricator.wikimedia.org/T265195) [21:39:33] (03CR) 10Ebernhardson: [C: 03+2] Send enabled tests to the frontend [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/634308 (https://phabricator.wikimedia.org/T262845) (owner: 10DCausse) [21:41:00] (03PS2) 10SamanthaNguyen: Inject a MessageLocalizer into CosmosNavigation and CosmosToolbar [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/634352 (https://phabricator.wikimedia.org/T265195) [21:41:39] (03PS1) 10Nikki Nikkhoui: Add nvm to README [skins/Vector] - 10https://gerrit.wikimedia.org/r/634355 (https://phabricator.wikimedia.org/T265682) [21:42:32] (03CR) 10Daniel Kinzler: [C: 03+1] "Didn't test, but looks good!" [core] - 10https://gerrit.wikimedia.org/r/634338 (owner: 10Ppchelko) [21:46:11] (03PS6) 10Legoktm: Initial commit of Python 3.7 builder [cloud/toolforge/buildpacks] - 10https://gerrit.wikimedia.org/r/633270 (https://phabricator.wikimedia.org/T265686) [21:48:42] (03CR) 10Daniel Kinzler: [C: 03+1] "Maybe do the same in NullHttpRequestFactory::create, for simple requests?" [core] - 10https://gerrit.wikimedia.org/r/634338 (owner: 10Ppchelko) [21:49:45] 10Discovery-Search: Build integration test suite for search platform airflow + hadoop +spark integration - https://phabricator.wikimedia.org/T265641 (10EBernhardson) [21:49:54] (03CR) 10Jdlrobson: [C: 03+2] Add nvm to README [skins/Vector] - 10https://gerrit.wikimedia.org/r/634355 (https://phabricator.wikimedia.org/T265682) (owner: 10Nikki Nikkhoui) [21:51:11] (03CR) 10Urbanecm: Do not call SpecialBlock::canBlockEmail from CheckUser (032 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/628506 (https://phabricator.wikimedia.org/T263334) (owner: 10Urbanecm) [21:51:23] 10Patch-For-Review, 10Toolforge (Software install/update): Install neovim on toolforge - https://phabricator.wikimedia.org/T219501 (10Bstorm) The install went surprisingly badly, but I suspect it isn't *because* of this patch. ` Setting up nscd (2.24-11+deb9u1) ... Job for nscd.service failed because the cont... [21:51:54] 10Discovery-Search: Build integration test suite for search platform airflow + hadoop +spark integration - https://phabricator.wikimedia.org/T265641 (10EBernhardson) One option would be faking a prod setup with some docker images. Cloudera (our hadoop distribution) used to (may still) provide a docker image that... [21:52:22] 10Discovery-Search: Build integration test suite for search platform airflow + hadoop +spark integration - https://phabricator.wikimedia.org/T265641 (10EBernhardson) [21:55:28] (03PS2) 10Daniel Kinzler: WIP: introduce PageOutputAccess [core] - 10https://gerrit.wikimedia.org/r/631264 [21:55:54] (03CR) 10jerkins-bot: [V: 04-1] WIP: introduce PageOutputAccess [core] - 10https://gerrit.wikimedia.org/r/631264 (owner: 10Daniel Kinzler) [21:58:51] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.33x-R-Rosgulla): Update our list of languages and variants. - https://phabricator.wikimedia.org/T263471 (10cooltey) [21:58:54] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.33x-R-Rosgulla): Update our list of languages and variants. - https://phabricator.wikimedia.org/T263471 (10cooltey) a:05MSantos→03cooltey > Let's open a separate task for the proposed Page Content Service update. Sure! Thanks @Mholloway Hi @MSantos,... [21:59:00] (03Merged) 10jenkins-bot: Send enabled tests to the frontend [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/634308 (https://phabricator.wikimedia.org/T262845) (owner: 10DCausse) [22:02:11] 10MobileFrontend, 10Readers-Web-Backlog (Kanbanana-FY-2020-21), 10Regression: Accessing diff pages from the watchlist points to revision page rather than diff page as curid parameter is not unset - https://phabricator.wikimedia.org/T265654 (10matmarex) a:03matmarex Special:MobileDiff is just the worst :( [22:02:43] (03PS1) 10Daimona Eaytoy: Add an interface to export/import filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/634357 [22:03:51] (03CR) 10Urbanecm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/627938 (https://phabricator.wikimedia.org/T263082) (owner: 10David Kamholz) [22:04:28] 10MediaWiki-extensions-NavigationTiming, 10Performance-Team, 10JavaScript, 10MW-1.36-notes (1.36.0-wmf.13; 2020-10-12), 10Wikimedia-production-error: Uncaught TypeError: Cannot read property 'localName' of null in emitLayoutShift - https://phabricator.wikimedia.org/T263599 (10Jdlrobson) {F32386031} [22:05:01] 10Patch-For-Review, 10Toolforge (Software install/update): Install neovim on toolforge - https://phabricator.wikimedia.org/T219501 (10Bstorm) 05Open→03Resolved a:03Bstorm Well, that was bizarre. I fixed it, and it was definitely a totally unrelated failure :) [22:06:48] (03CR) 10Daimona Eaytoy: Add phan annotations for better analysis (035 comments) [libs/ObjectFactory] - 10https://gerrit.wikimedia.org/r/632798 (https://phabricator.wikimedia.org/T264930) (owner: 10Daimona Eaytoy) [22:07:37] (03CR) 10jerkins-bot: [V: 04-1] Add an interface to export/import filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/634357 (owner: 10Daimona Eaytoy) [22:09:32] (03CR) 10jerkins-bot: [V: 04-1] Add nvm to README [skins/Vector] - 10https://gerrit.wikimedia.org/r/634355 (https://phabricator.wikimedia.org/T265682) (owner: 10Nikki Nikkhoui) [22:10:39] (03PS1) 10Bartosz Dziewoński: Fix mobile diff redirect when 'curid' query parameter is present [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/634358 (https://phabricator.wikimedia.org/T265654) [22:11:04] 10Toolforge (Software install/update): Requesting adding rust-ripgrep and rust-fd-find on the gridengine nodes - https://phabricator.wikimedia.org/T265689 (10Bstorm) [22:12:13] (03CR) 10DannyS712: Inject services into SpecialNewpages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/628444 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [22:12:14] 10Patch-For-Review, 10Toolforge (Software install/update): Requesting adding rust-ripgrep and rust-fd-find on the gridengine nodes - https://phabricator.wikimedia.org/T265689 (10Bstorm) p:05Triage→03Low [22:13:47] 10MediaWiki-Watchlist, 10Growth-Team: Viewing pages in Watchlist with "Live updates" on doesn't remove bolding - https://phabricator.wikimedia.org/T265513 (10Etonkovidova) Thanks, @Michgrig for reporting. I did some additional testing and the issue is present without "Live updates" turned on. - When Watchl... [22:13:51] (03PS2) 10Daimona Eaytoy: Add phan annotations for better analysis [libs/ObjectFactory] - 10https://gerrit.wikimedia.org/r/632798 (https://phabricator.wikimedia.org/T264930) [22:15:39] (03CR) 10Jdlrobson: [C: 03+2] Fix mobile diff redirect when 'curid' query parameter is present [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/634358 (https://phabricator.wikimedia.org/T265654) (owner: 10Bartosz Dziewoński) [22:15:53] (03CR) 10Bartosz Dziewoński: "Hopefully this is the last fix… I don't think there are any other parameters like this. (I checked MediaWiki::parseTitle() and https://www" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/634358 (https://phabricator.wikimedia.org/T265654) (owner: 10Bartosz Dziewoński) [22:16:28] (03CR) 10Bartosz Dziewoński: "('search' also overrides the title, but it overrides diff/oldid as well)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/634358 (https://phabricator.wikimedia.org/T265654) (owner: 10Bartosz Dziewoński) [22:17:31] (03CR) 10Bartosz Dziewoński: Preserve query parameters when redirecting to mobile diff (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/630389 (https://phabricator.wikimedia.org/T263937) (owner: 10Bartosz Dziewoński) [22:21:09] (03CR) 10DannyS712: Add phan annotations for better analysis (035 comments) [libs/ObjectFactory] - 10https://gerrit.wikimedia.org/r/632798 (https://phabricator.wikimedia.org/T264930) (owner: 10Daimona Eaytoy) [22:21:40] 10netbox: Add switch interface and cable support to AssignIPs script - https://phabricator.wikimedia.org/T265339 (10wiki_willy) Hi @ayounsi, Papaul and I talked about this a little bit today, and I think there are some additional questions that we have to gain some context. Are you free for a 15-30min sync up s... [22:23:11] (03PS3) 10SamanthaNguyen: Replace most calls to the global wfMessage() function [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/634352 (https://phabricator.wikimedia.org/T265195) [22:30:21] 10DiscussionTools, 10Editing QA, 10OWC2020, 10Beta-Feature, 10Editing-team (FY2020-21 Kanban Board): Make config change to enable Reply Tool as Beta Feature at Phase 2 wikis - https://phabricator.wikimedia.org/T264693 (10ppelberg) >>! In T264693#6548561, @Ryasmeen wrote: > 1. For Spanish wiki, when a log... [22:33:24] (03CR) 10Dbarratt: Replace mock data with data from GeoLite2 database (034 comments) [extensions/IPInfo] - 10https://gerrit.wikimedia.org/r/634083 (https://phabricator.wikimedia.org/T264905) (owner: 10Tchanders) [22:34:39] (03Merged) 10jenkins-bot: Fix mobile diff redirect when 'curid' query parameter is present [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/634358 (https://phabricator.wikimedia.org/T265654) (owner: 10Bartosz Dziewoński) [22:34:45] (03CR) 10Samwilson: "recheck" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/634347 (https://phabricator.wikimedia.org/T265463) (owner: 10Harriet Ayugi) [22:35:20] (03PS18) 10Daimona Eaytoy: Simplify ViewEdit, last round [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/630379 [22:37:36] (03CR) 10Esanders: [C: 03+2] CommentParser: Avoid unnecessary reference in foreach() [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/633859 (owner: 10Bartosz Dziewoński) [22:38:53] (03CR) 10Daimona Eaytoy: Add phan annotations for better analysis (032 comments) [libs/ObjectFactory] - 10https://gerrit.wikimedia.org/r/632798 (https://phabricator.wikimedia.org/T264930) (owner: 10Daimona Eaytoy) [22:39:21] (03PS3) 10Daimona Eaytoy: Add phan annotations for better analysis [libs/ObjectFactory] - 10https://gerrit.wikimedia.org/r/632798 (https://phabricator.wikimedia.org/T264930) [22:39:44] (03PS11) 10Aaron Schulz: Attempt to add a query cache to DPL [extensions/intersection] - 10https://gerrit.wikimedia.org/r/626268 (https://phabricator.wikimedia.org/T262391) (owner: 10Brian Wolff) [22:40:12] (03CR) 10Universal Omega: [C: 03+2] Replace most calls to the global wfMessage() function [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/634352 (https://phabricator.wikimedia.org/T265195) (owner: 10SamanthaNguyen) [22:40:58] (03PS35) 10Daimona Eaytoy: Add value objects to represent filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628488 [22:42:32] (03Merged) 10jenkins-bot: CommentParser: Avoid unnecessary reference in foreach() [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/633859 (owner: 10Bartosz Dziewoński) [22:42:37] (03PS1) 10Ejegg: SmashPig library update [vendor] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/634365 [22:42:43] (03CR) 10Ejegg: [C: 03+2] SmashPig library update [vendor] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/634365 (owner: 10Ejegg) [22:43:07] (03CR) 10jerkins-bot: [V: 04-1] SmashPig library update [vendor] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/634365 (owner: 10Ejegg) [22:43:25] (03PS1) 10VolkerE: Add (temporary) link to Design Strategy landing page [design/landing-page] - 10https://gerrit.wikimedia.org/r/634366 [22:43:30] (03CR) 10DannyS712: Add phan annotations for better analysis (031 comment) [libs/ObjectFactory] - 10https://gerrit.wikimedia.org/r/632798 (https://phabricator.wikimedia.org/T264930) (owner: 10Daimona Eaytoy) [22:43:41] (03PS1) 10Ejegg: Update SmashPig library [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/634367 [22:44:36] (03Merged) 10jenkins-bot: Replace most calls to the global wfMessage() function [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/634352 (https://phabricator.wikimedia.org/T265195) (owner: 10SamanthaNguyen) [22:44:46] (03CR) 10Daimona Eaytoy: Add phan annotations for better analysis (031 comment) [libs/ObjectFactory] - 10https://gerrit.wikimedia.org/r/632798 (https://phabricator.wikimedia.org/T264930) (owner: 10Daimona Eaytoy) [22:44:58] (03PS2) 10VolkerE: Add (temporary) link to Design Strategy landing page [design/landing-page] - 10https://gerrit.wikimedia.org/r/634366 [22:45:32] (03CR) 10Ejegg: [C: 03+2] Update SmashPig library [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/634367 (owner: 10Ejegg) [22:45:41] (03CR) 10jerkins-bot: [V: 04-1] Update SmashPig library [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/634367 (owner: 10Ejegg) [22:45:49] (03CR) 10VolkerE: [V: 03+2 C: 03+2] "Self-merging as we need this link quickly with publish messages of the sub-site across the Internet." [design/landing-page] - 10https://gerrit.wikimedia.org/r/634366 (owner: 10VolkerE) [22:46:21] (03CR) 10VolkerE: [C: 03+2] "recheck" [design/landing-page] - 10https://gerrit.wikimedia.org/r/634366 (owner: 10VolkerE) [22:50:46] (03CR) 10Ejegg: [V: 03+2 C: 03+2] SmashPig library update [vendor] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/634365 (owner: 10Ejegg) [22:51:13] (03CR) 10jerkins-bot: [V: 04-1] SmashPig library update [vendor] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/634365 (owner: 10Ejegg) [22:58:16] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Update SmashPig library [core] (fundraising/REL1_35) - 10https://gerrit.wikimedia.org/r/634367 (owner: 10Ejegg) [23:00:46] (03PS1) 10Aaron Schulz: objectcache: convert WANCache TYPE_*/PURGE_VAL_PREFIX variables to constants [core] - 10https://gerrit.wikimedia.org/r/634372 [23:01:33] 10Cosmos: Cosmos skin: Replace calls to global function wfMessage() - https://phabricator.wikimedia.org/T265110 (10SamanthaNguyen) 05Open→03Resolved a:03SamanthaNguyen [23:01:36] 10Cosmos, 10Patch-For-Review: Cosmos skin: Refactor CosmosToolbar and CosmosNavigation - https://phabricator.wikimedia.org/T265195 (10SamanthaNguyen) [23:03:52] (03CR) 10Paladox: "This change is ready for review." [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/634263 (owner: 10Paladox) [23:04:01] 10MediaWiki-extensions-OATHAuth, 10User-DannyS712: `oathauth-disable-header` message is missing - https://phabricator.wikimedia.org/T265693 (10DannyS712) [23:04:42] (03CR) 10DannyS712: Add SpecialDisableOATHForUser (031 comment) [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/434197 (https://phabricator.wikimedia.org/T195207) (owner: 10Ladsgroup) [23:06:31] (03CR) 10jerkins-bot: [V: 04-1] Fix "update.php" script [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/634263 (owner: 10Paladox) [23:08:49] (03PS36) 10Daimona Eaytoy: Add value objects to represent filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628488 [23:09:33] (03PS1) 10Reedy: Fix namespacing in update.php [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/634375 [23:10:24] 10TimedMediaHandler, 10JavaScript, 10MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), 10Wikimedia-production-error: Uncaught TypeError: Cannot read property 'addClass' of undefined - https://phabricator.wikimedia.org/T262947 (10Jdlrobson) Still occurring. Patch didn't fix it. Possibly related to T261887 as that... [23:12:52] 10MediaWiki-extensions-GettingStarted, 10Growth-Team-Leftovers, 10Growth-Team (Current Sprint), 10Patch-For-Review: Make Getting Started temporarily suppress the VE dialog by adding "vehidebetadialog" to the query string - https://phabricator.wikimedia.org/T235812 (10Tgr) Testing instructions: * enable Vis... [23:13:15] (03PS37) 10Daimona Eaytoy: Add value objects to represent filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628488 [23:13:32] (03Abandoned) 10Paladox: Fix "update.php" script [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/634263 (owner: 10Paladox) [23:13:59] (03CR) 10Paladox: [C: 03+1] "Works!" [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/634375 (owner: 10Reedy) [23:14:09] (03CR) 10Gergő Tisza: Suppress VisualEditor welcome dialog when tour is active (032 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/634187 (https://phabricator.wikimedia.org/T235812) (owner: 10Gergő Tisza) [23:14:21] (03PS3) 10Gergő Tisza: Suppress VisualEditor welcome dialog when tour is active [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/634187 (https://phabricator.wikimedia.org/T235812) [23:14:42] (03PS1) 10AlexPinchuk: Source & target entities, header & footer for entities Export to PDF extracted diagram [extensions/CognitiveProcessDesigner] - 10https://gerrit.wikimedia.org/r/634378 [23:15:19] 10Cosmos, 10Goal: Cosmos skin: Fix styling issues for PHP, JS, and CSS/LESS code - https://phabricator.wikimedia.org/T265193 (10SamanthaNguyen) [23:15:21] 10Cosmos, 10Patch-For-Review: Cosmos skin: Fix all remaining PHPCS issues - https://phabricator.wikimedia.org/T265108 (10SamanthaNguyen) 05Open→03Stalled This is now stalled as this requires fixing `MediaWiki.ControlStructures.AssignmentInControlStructures.AssignmentInControlStructures`, which requires ref... [23:15:50] (03PS32) 10Daimona Eaytoy: Make AbuseFilterViewEdit work with Filter objects [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628593 [23:17:09] 10MediaWiki-Codesniffer: phpcs suggests $IP should be $wgIP - https://phabricator.wikimedia.org/T265694 (10Reedy) [23:24:53] (03PS2) 10Nikki Nikkhoui: Add nvm to README [skins/Vector] - 10https://gerrit.wikimedia.org/r/634355 (https://phabricator.wikimedia.org/T265682) [23:25:55] 10MobileFrontend, 10Advanced Mobile Contributions, 10Mobile, 10Regression: Diff links in mobile watchlist and recent changes go to page instead of diff - https://phabricator.wikimedia.org/T265402 (10Gomdoli4696) >>! In T265402#6547354, @Vito-Genovese wrote: > @Uncitoyen has reported that it also happens at... [23:27:38] (03CR) 10Aaron Schulz: "Would be nice to revive https://gerrit.wikimedia.org/r/c/mediawiki/core/+/532096" [core] - 10https://gerrit.wikimedia.org/r/632300 (owner: 10Umherirrender) [23:27:54] (03CR) 10jerkins-bot: [V: 04-1] Make AbuseFilterViewEdit work with Filter objects [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628593 (owner: 10Daimona Eaytoy) [23:28:50] 10MediaWiki-Codesniffer: phpcs suggests $IP should be $wgIP - https://phabricator.wikimedia.org/T265694 (10DannyS712) Hmm, but that extension's phpcs excludes `$IP` ` lang=xml 10MinervaNeue, 10JavaScript, 10MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), 10Readers-Web-Backlog (Kanbanana-FY-2020-21), 10Wikimedia-production-error: Uncaught TypeError: Cannot read property 'match' of undefined - https://phabricator.wikimedia.org/T263773 (10Jdlrobson) 05Open→03Resolve... [23:32:59] (03CR) 10Universal Omega: Remove unused ParseItem() function from the CosmosNavigation and CosmosToolbar classes (031 comment) [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/634264 (https://phabricator.wikimedia.org/T265195) (owner: 10Universal Omega) [23:34:46] (03CR) 10Aaron Schulz: Attempt to add a query cache to DPL (039 comments) [extensions/intersection] - 10https://gerrit.wikimedia.org/r/626268 (https://phabricator.wikimedia.org/T262391) (owner: 10Brian Wolff) [23:40:00] (03PS3) 10Universal Omega: Remove unused parseItem() function from the CosmosNavigation and CosmosToolbar classes [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/634264 (https://phabricator.wikimedia.org/T265195) [23:40:19] (03CR) 10SamanthaNguyen: [C: 03+2] Remove unused parseItem() function from the CosmosNavigation and CosmosToolbar classes [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/634264 (https://phabricator.wikimedia.org/T265195) (owner: 10Universal Omega) [23:42:52] (03CR) 10Aaron Schulz: Trim whitespace from $expiry in Database::decodeExpiry() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/631936 (https://phabricator.wikimedia.org/T42626) (owner: 10Ladsgroup) [23:44:22] 10MobileFrontend, 10Advanced Mobile Contributions, 10Mobile, 10Regression: Diff links in mobile watchlist and recent changes go to page instead of diff - https://phabricator.wikimedia.org/T265402 (10Vito-Genovese) >>! In T265402#6548933, @Gomdoli4696 wrote: > ` > https://tr.m.wikipedia.org/w/index.php?tit... [23:44:33] (03PS10) 10Aaron Schulz: objectcache: make BagOStuff key encoding more consistent [core] - 10https://gerrit.wikimedia.org/r/589465 (https://phabricator.wikimedia.org/T250239) [23:44:53] 10Structured-Data-Backlog: [wmf.13-regression] MediaSearch- delay in displaying Quickview - https://phabricator.wikimedia.org/T265696 (10Etonkovidova) [23:45:34] (03CR) 10DannyS712: "Adding as reviewers people who contributed to discussions at T202989" [core] - 10https://gerrit.wikimedia.org/r/634262 (https://phabricator.wikimedia.org/T202989) (owner: 10DannyS712) [23:46:16] (03Merged) 10jenkins-bot: Remove unused parseItem() function from the CosmosNavigation and CosmosToolbar classes [skins/Cosmos] - 10https://gerrit.wikimedia.org/r/634264 (https://phabricator.wikimedia.org/T265195) (owner: 10Universal Omega) [23:47:08] 10MobileFrontend, 10Advanced Mobile Contributions, 10Mobile, 10Regression: Diff links in mobile watchlist and recent changes go to page instead of diff - https://phabricator.wikimedia.org/T265402 (10Gomdoli4696) >>! In T265402#6548966, @Vito-Genovese wrote: >>>! In T265402#6548933, @Gomdoli4696 wrote: >> `... [23:47:10] 10donate.wikimedia.org: Donating to Wikipedia should end by landing on original article - https://phabricator.wikimedia.org/T265697 (10Alset) [23:51:09] (03Abandoned) 10Urbanecm: Fix CSS/JSON/JS deleted-view permissions [core] - 10https://gerrit.wikimedia.org/r/456140 (https://phabricator.wikimedia.org/T202989) (owner: 10Gergő Tisza) [23:52:22] (03CR) 10Urbanecm: PermissionManager: Allow sysops to view deleted config pages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/634262 (https://phabricator.wikimedia.org/T202989) (owner: 10DannyS712) [23:53:10] (03CR) 10Urbanecm: [C: 04-1] "also, this should probably have tests, or amend existing ones" [core] - 10https://gerrit.wikimedia.org/r/634262 (https://phabricator.wikimedia.org/T202989) (owner: 10DannyS712) [23:55:39] 10MW-1.36-notes (1.36.0-wmf.11; 2020-09-29), 10Patch-For-Review, 10SDAW-MediaSearch (MediaSearch-Beta), 10Structured-Data-Backlog (Current Work): [M] Improve mobile UX for MediaSearch UI - https://phabricator.wikimedia.org/T258615 (10Etonkovidova) 05Open→03Resolved Checked in `commons wmf.13`. [23:58:39] 10MW-1.36-notes (1.36.0-wmf.12; 2020-10-05; NEVER DEPLOYED), 10Patch-For-Review, 10SDAW-MediaSearch (MediaSearch-Beta), 10Structured-Data-Backlog (Current Work): Media Search: Adjust margin on image grid to line up - https://phabricator.wikimedia.org/T259846 (10Etonkovidova) 05Open→03Resolved [23:59:01] 10itWikiCon-2020: itWikiCon 2020 website - https://phabricator.wikimedia.org/T253921 (10valerio.bozzolan) (Psss... first alpha version!) {F32386085} [23:59:21] (03PS4) 10DannyS712: PermissionManager: Allow sysops to view deleted config pages [core] - 10https://gerrit.wikimedia.org/r/634262 (https://phabricator.wikimedia.org/T202989) [23:59:32] 10itWikiCon-2020: itWikiCon 2020 website - https://phabricator.wikimedia.org/T253921 (10valerio.bozzolan)