[00:03:38] 10MediaWiki-File-management, 10Commons, 10DBA, 10Schema-change, 10User-DannyS712: uploadstash.us_orig_path is not read - https://phabricator.wikimedia.org/T263307 (10DannyS712) [00:03:45] 10MediaWiki-File-management, 10DBA, 10Schema-change, 10User-DannyS712: uploadstash.us_orig_path is not read - https://phabricator.wikimedia.org/T263307 (10DannyS712) [00:06:46] 10MediaWiki-File-management, 10DBA, 10Schema-change, 10User-DannyS712: uploadstash has column that are never read - https://phabricator.wikimedia.org/T263307 (10DannyS712) [00:09:19] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.32x-Q-Qurabiya): Redesign on this day card - https://phabricator.wikimedia.org/T261673 (10Sharvaniharan) Yes @schoenbaechler . I put in the transition. Looks good: https://youtu.be/5KH5BffHJuk However the scroll doesn't lo... [00:11:10] (03Merged) 10jenkins-bot: [tests] SpecialBlockTest: Do not save an empty block in testProcessFormUserTalkEditFlag [core] - 10https://gerrit.wikimedia.org/r/628465 (https://phabricator.wikimedia.org/T189073) (owner: 10Urbanecm) [00:18:10] (03CR) 10Nray: "> Can you explain how mwVectorLegacySearchQuery* and mwVectorLegacySearchRender* will be used?" [core] - 10https://gerrit.wikimedia.org/r/624824 (https://phabricator.wikimedia.org/T251544) (owner: 10Nray) [00:21:47] (03CR) 10Niedzielski: [C: 04-1] Add blubber config and docker configs (035 comments) [wvui] - 10https://gerrit.wikimedia.org/r/624267 (https://phabricator.wikimedia.org/T254837) (owner: 10Nikki Nikkhoui) [00:22:33] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Cannot find the displayed On This Day article when navigating into On This Day and scrolling to the same date - https://phabricator.wikimedia.org/T263308 (10ABorbaWMF) [00:27:43] (03PS16) 10Nikki Nikkhoui: Add blubber config and docker configs [wvui] - 10https://gerrit.wikimedia.org/r/624267 (https://phabricator.wikimedia.org/T254837) [00:29:21] (03PS2) 10Ppchelko: Initial CI support [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/628454 (https://phabricator.wikimedia.org/T263295) [00:31:09] 10GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.36-notes (1.36.0-wmf.10; 2020-09-22): Variant C: onboarding - https://phabricator.wikimedia.org/T258016 (10Etonkovidova) [00:34:52] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), 10OWC2020 (Reply Tool Opt Out), 10Skipped QA: Create setting(s) for the Reply Tool within Special:Preferences - https://phabricator.wikimedia.org/T259943 (10ppelberg) a:05iamjessklein→03ppelberg [00:38:41] 10DiscussionTools, 10Editing-team (Tracking), 10OWC2020 (Reply Tool Opt Out): Announce Reply Tool opt-out deployment - https://phabricator.wikimedia.org/T262332 (10ppelberg) [00:40:45] (03CR) 10Krinkle: resources: Organize frontend files by module directory (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/627914 (https://phabricator.wikimedia.org/T193826) (owner: 10Krinkle) [00:43:23] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Feature Request: Do not overlap text and android controls (top of screen) - https://phabricator.wikimedia.org/T263309 (10ABorbaWMF) [00:43:56] 10GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.36-notes (1.36.0-wmf.10; 2020-09-22): Variant C: onboarding - https://phabricator.wikimedia.org/T258016 (10Etonkovidova) Checked in betalabs. (1) {icon exclamation-triangle color=red} They can dismiss the overlay by clicking away. - the spec is not... [00:46:17] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Feature Request: Match the image/video captions to the article language - https://phabricator.wikimedia.org/T263310 (10ABorbaWMF) [00:49:51] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Feature Request: Provide an option to hide pictures in articles to increase speed - https://phabricator.wikimedia.org/T263311 (10ABorbaWMF) [00:54:17] 10GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.36-notes (1.36.0-wmf.10; 2020-09-22): Variant C: onboarding - https://phabricator.wikimedia.org/T258016 (10Etonkovidova) The screenshots for review. **Desktop** |{F32355143}|{F32355145} //**Note:**// The size of the popup seems bigger than in the m... [00:56:47] 10GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.36-notes (1.36.0-wmf.10; 2020-09-22): Variant C: onboarding - https://phabricator.wikimedia.org/T258016 (10Etonkovidova) **Mobile** |{F32355154}|{F32355156} [01:24:22] 10GrowthExperiments-Homepage, 10Beta-Cluster-reproducible, 10Growth-Team (Current Sprint), 10Patch-For-Review: [betalabs] Homepage-variant A: Error: Module "ext.growthExperiments.SuggestedEditSession" is not loaded - https://phabricator.wikimedia.org/T263302 (10Tgr) [01:30:51] 10GrowthExperiments-Homepage, 10Beta-Cluster-reproducible, 10Growth-Team (Current Sprint), 10Patch-For-Review: [betalabs] Homepage-variant A: Error: Module "ext.growthExperiments.SuggestedEditSession" is not loaded - https://phabricator.wikimedia.org/T263302 (10Tgr) a:03Tgr [01:30:53] 10GrowthExperiments-Homepage, 10Beta-Cluster-reproducible, 10Growth-Team (Current Sprint), 10Patch-For-Review: [betalabs] Homepage-variant A: Error: Module "ext.growthExperiments.SuggestedEditSession" is not loaded - https://phabricator.wikimedia.org/T263302 (10Tgr) This was caused by {be3d31deafb943bebb02... [01:46:24] (03PS1) 10Ladsgroup: Improve TinyIntType [core] - 10https://gerrit.wikimedia.org/r/628469 (https://phabricator.wikimedia.org/T205094) [01:53:56] (03CR) 10Hashar: Initial CI support (033 comments) [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/628454 (https://phabricator.wikimedia.org/T263295) (owner: 10Ppchelko) [02:05:01] (03CR) 10jerkins-bot: [V: 04-1] Improve TinyIntType [core] - 10https://gerrit.wikimedia.org/r/628469 (https://phabricator.wikimedia.org/T205094) (owner: 10Ladsgroup) [02:06:57] (03PS2) 10Ladsgroup: Improve TinyIntType [core] - 10https://gerrit.wikimedia.org/r/628469 (https://phabricator.wikimedia.org/T205094) [02:16:49] (03CR) 10Ladsgroup: "> Patch Set 8:" [vendor] - 10https://gerrit.wikimedia.org/r/547872 (owner: 10Ladsgroup) [02:17:01] (03Abandoned) 10Ladsgroup: Add Doctrine DBAL 2.9.3 [vendor] - 10https://gerrit.wikimedia.org/r/547872 (owner: 10Ladsgroup) [02:29:38] 10MediaWiki-extensions-GuidedTour, 10Growth-Team: For guider.js positions like leftTop the arrow aligns poorly with the target - https://phabricator.wikimedia.org/T263312 (10Tgr) [02:32:19] (03CR) 10Ladsgroup: [C: 03+1] resourceloader: Use a local HookRunner [core] - 10https://gerrit.wikimedia.org/r/617166 (owner: 10Krinkle) [03:11:03] (03CR) 10Ppchelko: Initial CI support (031 comment) [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/628454 (https://phabricator.wikimedia.org/T263295) (owner: 10Ppchelko) [03:12:08] (03CR) 10DannyS712: "This change is ready for review." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/628375 (owner: 10DannyS712) [03:12:33] (03CR) 10Ppchelko: Initial CI support (031 comment) [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/628454 (https://phabricator.wikimedia.org/T263295) (owner: 10Ppchelko) [03:29:13] (03PS2) 10Ammarpad: Clarify documentation of SkinVector::__construct() [skins/Vector] - 10https://gerrit.wikimedia.org/r/628069 (https://phabricator.wikimedia.org/T262233) [03:33:43] (03PS3) 10Ammarpad: Clarify documentation of SkinVector::__construct() [skins/Vector] - 10https://gerrit.wikimedia.org/r/628069 (https://phabricator.wikimedia.org/T262233) [03:51:45] (03CR) 10jerkins-bot: [V: 04-1] Clarify documentation of SkinVector::__construct() [skins/Vector] - 10https://gerrit.wikimedia.org/r/628069 (https://phabricator.wikimedia.org/T262233) (owner: 10Ammarpad) [03:55:17] (03CR) 10Ammarpad: "> If this is a problem in Vector it could be an issue in other skins." [skins/Vector] - 10https://gerrit.wikimedia.org/r/628069 (https://phabricator.wikimedia.org/T262233) (owner: 10Ammarpad) [03:57:35] (03PS4) 10Ammarpad: Clarify documentation of SkinVector::__construct() [skins/Vector] - 10https://gerrit.wikimedia.org/r/628069 (https://phabricator.wikimedia.org/T262233) [03:59:16] (03CR) 10DannyS712: Introduce BlockUtils service (034 comments) [core] - 10https://gerrit.wikimedia.org/r/628427 (https://phabricator.wikimedia.org/T263189) (owner: 10Urbanecm) [04:13:47] (03PS5) 10Ammarpad: Clarify documentation of SkinVector::__construct() [skins/Vector] - 10https://gerrit.wikimedia.org/r/628069 (https://phabricator.wikimedia.org/T262233) [04:41:57] (03CR) 10Ammarpad: "The changes look good to me and there'd be no SkinVector exception now, thanks for understanding. I note some minor issues inline below." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/625775 (https://phabricator.wikimedia.org/T262233) (owner: 10Ammarpad) [04:47:48] (03CR) 10Ammarpad: [C: 03+2] Vector supports language variant logos [skins/Vector] - 10https://gerrit.wikimedia.org/r/628419 (https://phabricator.wikimedia.org/T261153) (owner: 10Jdlrobson) [05:02:56] (03CR) 10DannyS712: [C: 04-1] "I was bored and took another look at this. Tested it out with patch demo. There is a bug with the ApiBlock changes - see inline comment re" (0314 comments) [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) (owner: 10Urbanecm) [05:05:24] (03CR) 10Jdlrobson: Clarify documentation of SkinVector::__construct() (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/628069 (https://phabricator.wikimedia.org/T262233) (owner: 10Ammarpad) [05:09:07] (03CR) 10Ammarpad: [C: 04-1] "Please explain the use case or where this will be immediately used. I only see a single theoretical example in the task, no concrete idea " [core] - 10https://gerrit.wikimedia.org/r/551606 (https://phabricator.wikimedia.org/T232908) (owner: 10DannyS712) [05:10:19] (03Merged) 10jenkins-bot: Vector supports language variant logos [skins/Vector] - 10https://gerrit.wikimedia.org/r/628419 (https://phabricator.wikimedia.org/T261153) (owner: 10Jdlrobson) [05:15:54] 10MediaWiki-Page-protection: Add "protect" level for nonexistent pages - https://phabricator.wikimedia.org/T259562 (10Ammarpad) >>! In T259562#6475267, @Naleksuh wrote: > Finally this task is getting some attention I'd not advise you to wait for this to be added in core, if you truly need it. Because that could... [05:18:34] (03CR) 10Gergő Tisza: "Neat, thanks for tracking that bug down! Not sure what the two extra \n were there for, I traced them back to the initial commit and in no" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/572865 (https://phabricator.wikimedia.org/T166690) (owner: 10Ammarpad) [05:18:44] (03CR) 10Gergő Tisza: [C: 03+2] Show applicable grant when consumer has only basic rights [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/572865 (https://phabricator.wikimedia.org/T166690) (owner: 10Ammarpad) [05:22:41] (03Merged) 10jenkins-bot: Show applicable grant when consumer has only basic rights [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/572865 (https://phabricator.wikimedia.org/T166690) (owner: 10Ammarpad) [05:35:20] (03CR) 10Ammarpad: Clarify documentation of SkinVector::__construct() (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/628069 (https://phabricator.wikimedia.org/T262233) (owner: 10Ammarpad) [05:42:15] 10MediaWiki-Core-Skin-Architecture, 10Growth-Team, 10ProofreadPage, 10StructuredDiscussions, and 2 others: Deprecate SkinMinervaDefaultModules hook - https://phabricator.wikimedia.org/T256086 (10Ammarpad) > ProofReadPage extension uses this hook to disable the editor - this should be replaced by a configur... [05:48:05] 10Readers-Web-Backlog, 10Wiktionary, 10MinervaNeue (Tracking), 10patch-welcome: Disable auto-capitalization on mobile Wiktionary search bar - https://phabricator.wikimedia.org/T251664 (10Ammarpad) > Maybe this can be automatically done in any wiki that disabled $wgCapitalLinks? Shouldn't this be done by co... [05:48:43] 10DiscussionTools: Create an easy way to link to a talk page discussion within edit summary - https://phabricator.wikimedia.org/T263314 (10ppelberg) [06:08:31] (03PS1) 10Mbch331: Add monolingual language code ja-Hira, ja-Kana, ja-Hrkt, ja-Hani, ojp, ojp-Hira, ojp-Hani [extensions/cldr] - 10https://gerrit.wikimedia.org/r/628474 (https://phabricator.wikimedia.org/T195816) [06:11:43] 10UploadWizard, 10JavaScript, 10Wikimedia-production-error: UploadWizard should validate bad user input inputted for location (Invalid LatLng object) - https://phabricator.wikimedia.org/T262993 (10urvashi_g07) Hi, I would like to work on this issue [06:14:30] 10MediaWiki-Language-converter, 10Parsing-Team, 10Security-Team, 10Patch-For-Review, and 2 others: Language converter: unsafe attribute injection via glossary rules (CVE-2017-8815) - https://phabricator.wikimedia.org/T119158 (10VulpesVulpes825) [06:41:16] (03CR) 10Umherirrender: [C: 03+2] Fix typos: leve -> level [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/628375 (owner: 10DannyS712) [06:45:08] (03Merged) 10jenkins-bot: Fix typos: leve -> level [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/628375 (owner: 10DannyS712) [06:49:09] (03PS1) 10Sohom Datta: Fix warnings due to the newly introduced no-shadow rule (eslint) [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/628475 [06:49:34] (03CR) 10Umherirrender: [C: 03+1] Use DBAccessObjectUtils in some User methods. [core] - 10https://gerrit.wikimedia.org/r/626222 (owner: 10Ammarpad) [07:21:36] (03PS1) 10Umherirrender: Inject service into SpecialFewestRevisions/SpecialMostRevisions [core] - 10https://gerrit.wikimedia.org/r/628476 (https://phabricator.wikimedia.org/T259960) [07:24:28] (03CR) 10Ammarpad: "Hi Jdlrobson, I am not sure whether I am making sense here, or I am missing something. It's fine to ask other people to take a look too, s" [skins/Vector] - 10https://gerrit.wikimedia.org/r/628069 (https://phabricator.wikimedia.org/T262233) (owner: 10Ammarpad) [07:25:11] (03PS2) 10Umherirrender: Inject service into SpecialFewestRevisions/SpecialMostRevisions [core] - 10https://gerrit.wikimedia.org/r/628476 (https://phabricator.wikimedia.org/T259960) [07:36:59] (03Abandoned) 10Mainframe98: Inject services into special pages [core] - 10https://gerrit.wikimedia.org/r/535657 (https://phabricator.wikimedia.org/T232506) (owner: 10Mainframe98) [07:44:48] (03PS1) 10Umherirrender: Inject services into SpecialProtectedpages [core] - 10https://gerrit.wikimedia.org/r/628477 (https://phabricator.wikimedia.org/T259960) [07:49:14] (03PS1) 10Umherirrender: Use ::class to refer HTML form field classes [core] - 10https://gerrit.wikimedia.org/r/628478 [08:20:00] 10GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: Variant C/D: welcome popup on desktop - https://phabricator.wikimedia.org/T258009 (10kostajh) QA instructions from the patch: To test, switch to variant C or D, run the following snippet in the browser console, then visit the homepage:... [08:22:31] (03PS8) 10Matěj Suchánek: Let sysops see difflinks to deleted revisions on Special:AbuseLog [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/419117 (https://phabricator.wikimedia.org/T261630) [08:24:05] 10MobileFrontend, 10Readers-Web-Backlog (Design): Mobile form for forced password change (due to new password requirements) has no label for the "Retype password" field - https://phabricator.wikimedia.org/T218454 (10Ammarpad) >>! In T218454#5028768, @matmarex wrote: > Easiest solution for this IMO would be to... [08:51:41] 10UploadWizard, 10JavaScript, 10Wikimedia-production-error: UploadWizard should validate bad user input inputted for location (Invalid LatLng object) - https://phabricator.wikimedia.org/T262993 (10Aklapper) Hi @urvashi_g07, thanks for your interest and welcome to Wikimedia Phabricator! [Feel free to do so.](... [08:56:11] 10Mathe für Nicht-Freaks: Bilder für abstraktes Beispiel im Artikel "Faktorraum" - https://phabricator.wikimedia.org/T239157 (10GruenerBogen) 05Open→03Resolved [09:06:33] (03PS1) 10Umherirrender: Inject services into SpecialProtectedtitles [core] - 10https://gerrit.wikimedia.org/r/628479 (https://phabricator.wikimedia.org/T259960) [09:13:27] (03PS2) 10Umherirrender: Inject services into SpecialNewpages [core] - 10https://gerrit.wikimedia.org/r/628444 (https://phabricator.wikimedia.org/T259960) [09:25:07] (03CR) 10Raimond Spekking: [C: 03+2] Add monolingual language code ja-Hira, ja-Kana, ja-Hrkt, ja-Hani, ojp, ojp-Hira, ojp-Hani [extensions/cldr] - 10https://gerrit.wikimedia.org/r/628474 (https://phabricator.wikimedia.org/T195816) (owner: 10Mbch331) [09:30:16] (03CR) 10jerkins-bot: [V: 04-1] Inject services into SpecialProtectedtitles [core] - 10https://gerrit.wikimedia.org/r/628479 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [09:35:52] (03CR) 10jerkins-bot: [V: 04-1] Inject services into SpecialNewpages [core] - 10https://gerrit.wikimedia.org/r/628444 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [09:43:44] (03Merged) 10jenkins-bot: Add monolingual language code ja-Hira, ja-Kana, ja-Hrkt, ja-Hani, ojp, ojp-Hira, ojp-Hani [extensions/cldr] - 10https://gerrit.wikimedia.org/r/628474 (https://phabricator.wikimedia.org/T195816) (owner: 10Mbch331) [09:46:16] (03PS2) 10Umherirrender: Inject services into SpecialProtectedtitles [core] - 10https://gerrit.wikimedia.org/r/628479 (https://phabricator.wikimedia.org/T259960) [09:47:52] (03PS3) 10Umherirrender: Inject services into SpecialNewpages [core] - 10https://gerrit.wikimedia.org/r/628444 (https://phabricator.wikimedia.org/T259960) [09:48:29] (03PS1) 10Matěj Suchánek: [WIP] Introduce EmergencyWatcher service [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628480 [09:48:38] (03PS1) 10Umherirrender: Inject services into SpecialListUsers/SpecialActiveUsers [core] - 10https://gerrit.wikimedia.org/r/628481 (https://phabricator.wikimedia.org/T259960) [09:49:16] 10MediaWiki-Interface: Proposal: integrate "skip to top and bottom" functionality into the standard UI - https://phabricator.wikimedia.org/T263292 (10Aklapper) When would you have to jump to the bottom? What is the use case / underlying problem behind this request? [10:03:05] 10MediaWiki-Interface: Automatically redirect to/create sandbox (with appropriate notice) for attempts to edit certain protected pages (like templates.) - https://phabricator.wikimedia.org/T263316 (10ShakespeareFan00) [10:03:35] 10MediaWiki-Interface: Automatically redirect to/create sandbox (with appropriate notice) for attempts to edit certain protected pages (like templates.) - https://phabricator.wikimedia.org/T263316 (10ShakespeareFan00) [10:11:19] (03CR) 10jerkins-bot: [V: 04-1] Inject services into SpecialListUsers/SpecialActiveUsers [core] - 10https://gerrit.wikimedia.org/r/628481 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [10:13:45] 10MediaWiki-extensions-CentralAuth, 10GlobalRename, 10Wikimedia-Site-requests: Unblock stuck global rename of Davidfromtheworld - https://phabricator.wikimedia.org/T263317 (101997kB) [10:19:56] 10UploadWizard, 10JavaScript, 10Wikimedia-production-error: UploadWizard should validate bad user input inputted for location (Invalid LatLng object) - https://phabricator.wikimedia.org/T262993 (10Soda) The data being saved by the Upload Wizard is correct. It's just that the coordinates are not being normali... [10:20:08] (03CR) 10Jforrester: [C: 03+2] Updating lcobucci/jwt (3.3.2 => 3.3.3) [vendor] - 10https://gerrit.wikimedia.org/r/628450 (owner: 10Reedy) [10:27:02] (03CR) 10Jforrester: [C: 03+2] Updating league/uri (6.2.1 => 6.3.0) [vendor] - 10https://gerrit.wikimedia.org/r/628451 (owner: 10Reedy) [10:27:45] (03CR) 10Jforrester: [C: 03+2] Update spomky-labs/* [vendor] - 10https://gerrit.wikimedia.org/r/628452 (owner: 10Reedy) [10:30:46] (03PS6) 10Daimona Eaytoy: Always take into account custom actions [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/553362 (https://phabricator.wikimedia.org/T239348) [10:34:20] (03PS2) 10Jforrester: Alphasort hooks [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/621947 (owner: 10Reedy) [10:34:48] (03CR) 10Jforrester: [C: 03+2] "> Patch Set 1: Code-Review+1" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/621947 (owner: 10Reedy) [10:37:57] (03PS2) 10Umherirrender: Inject services into SpecialListUsers/SpecialActiveUsers [core] - 10https://gerrit.wikimedia.org/r/628481 (https://phabricator.wikimedia.org/T259960) [10:38:31] (03Merged) 10jenkins-bot: Updating lcobucci/jwt (3.3.2 => 3.3.3) [vendor] - 10https://gerrit.wikimedia.org/r/628450 (owner: 10Reedy) [10:40:12] (03CR) 10Jforrester: [C: 03+2] Convert Babel to use abstract schema [extensions/Babel] - 10https://gerrit.wikimedia.org/r/621915 (https://phabricator.wikimedia.org/T259374) (owner: 10Reedy) [10:40:17] (03CR) 10Jforrester: [C: 03+2] Update Babel sql path [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/621916 (owner: 10Reedy) [10:42:44] 10Discovery-Search (Current work), 10Patch-For-Review: Large, steady increase in unprocessed cloudelastic job.cirrusSearchElasticaWrite messages - https://phabricator.wikimedia.org/T263073 (10Joe) >>! In T263073#6468695, @EBernhardson wrote: > @Joe Is it possible for envoy to talk to `cloudelastic.wikimedia.or... [10:43:51] 10Discovery-Search (Current work), 10Patch-For-Review: Large, steady increase in unprocessed cloudelastic job.cirrusSearchElasticaWrite messages - https://phabricator.wikimedia.org/T263073 (10Joe) September 1st is when we switched over datacenter to codfw, so I think @EBernhardson is correct. [10:50:11] 10Discovery-Search (Current work), 10Patch-For-Review: Large, steady increase in unprocessed cloudelastic job.cirrusSearchElasticaWrite messages - https://phabricator.wikimedia.org/T263073 (10Joe) >>! In T263073#6473232, @RKemper wrote: > Dumping some stream-of-conscioussness / notes here: > > (Paths are rela... [10:50:49] (03Merged) 10jenkins-bot: Updating league/uri (6.2.1 => 6.3.0) [vendor] - 10https://gerrit.wikimedia.org/r/628451 (owner: 10Reedy) [10:50:51] (03Merged) 10jenkins-bot: Update spomky-labs/* [vendor] - 10https://gerrit.wikimedia.org/r/628452 (owner: 10Reedy) [10:50:53] (03Merged) 10jenkins-bot: Alphasort hooks [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/621947 (owner: 10Reedy) [10:53:07] 10Dumps-Generation: look into space issues on dumpsdata1001 - https://phabricator.wikimedia.org/T263318 (10ArielGlenn) p:05Triage→03Medium [10:57:38] (03CR) 10Jforrester: "I'd recommend upstreaming all the CSP-setting code into SimpleCaptcha and then just setting a protected empty array / getter for which dom" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/589841 (https://phabricator.wikimedia.org/T250544) (owner: 10Florianschmidtwelzow) [10:58:55] (03Merged) 10jenkins-bot: Convert Babel to use abstract schema [extensions/Babel] - 10https://gerrit.wikimedia.org/r/621915 (https://phabricator.wikimedia.org/T259374) (owner: 10Reedy) [10:58:57] (03Merged) 10jenkins-bot: Update Babel sql path [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/621916 (owner: 10Reedy) [11:08:53] (03CR) 10Daimona Eaytoy: "The code looks good, I've tested this locally and it works as expected; I've also checked how these queries perform, and they're all using" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/419117 (https://phabricator.wikimedia.org/T261630) (owner: 10Matěj Suchánek) [11:11:07] (03PS2) 10Jforrester: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/600077 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [11:11:12] (03PS3) 10Jforrester: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/600077 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [11:11:27] (03CR) 10Jforrester: [C: 03+2] Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/600077 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [11:13:45] (03PS2) 10Jforrester: Add Anonymous to $wgReservedUsernames [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/599391 (https://phabricator.wikimedia.org/T253895) (owner: 10Reedy) [11:14:40] (03CR) 10Jforrester: [C: 03+2] Automatically register 'Anonymous' as a reserved username [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/588388 (https://phabricator.wikimedia.org/T238632) (owner: 10Florianschmidtwelzow) [11:14:53] (03Abandoned) 10Jforrester: Add Anonymous to $wgReservedUsernames [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/599391 (https://phabricator.wikimedia.org/T253895) (owner: 10Reedy) [11:16:03] (03Merged) 10jenkins-bot: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/600077 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [11:17:45] (03CR) 10jerkins-bot: [V: 04-1] Automatically register 'Anonymous' as a reserved username [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/588388 (https://phabricator.wikimedia.org/T238632) (owner: 10Florianschmidtwelzow) [11:41:40] (03CR) 10Matěj Suchánek: "> However, one thing is unclear to me: what user right(s) should this be bound to? Similar paths use 'deletedhistory' (see e.g. Difference" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/419117 (https://phabricator.wikimedia.org/T261630) (owner: 10Matěj Suchánek) [11:55:25] 10Dumps-Generation: When maing guesses about page ranges for page content dumps, use page rangi info from a previous run, if available - https://phabricator.wikimedia.org/T263319 (10ArielGlenn) p:05Triage→03Medium [11:58:00] 10Dumps-Generation: Use multistream bz2 files for all page content output - https://phabricator.wikimedia.org/T263320 (10ArielGlenn) p:05Triage→03Medium [11:58:49] 10Dumps-Generation: Investigate use of bz2 decompression tools on multistream files - https://phabricator.wikimedia.org/T239866 (10ArielGlenn) At this point it looks like all current tools handle multistream files, so I will be moving ahead with implementing that. See T263320 to follow along. [12:00:40] 10MediaWiki-Interface: Automatically redirect to/create sandbox (with appropriate notice) for attempts to edit certain protected pages (like templates.) - https://phabricator.wikimedia.org/T263316 (10revi) It might be that: When newbies try to edit protected article, they will just see the "hey, this article is... [12:09:05] (03CR) 10Daimona Eaytoy: [C: 04-1] "I checked what SpecialUndelete requires, and it's not straightforward." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/419117 (https://phabricator.wikimedia.org/T261630) (owner: 10Matěj Suchánek) [12:10:27] (03CR) 10Daimona Eaytoy: [C: 04-1] "> Patch Set 8:" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/419117 (https://phabricator.wikimedia.org/T261630) (owner: 10Matěj Suchánek) [12:16:12] (03PS1) 10Umherirrender: Inject services into SpecialListUsers/SpecialActiveUsers [core] - 10https://gerrit.wikimedia.org/r/628484 (https://phabricator.wikimedia.org/T259960) [12:20:31] (03PS2) 10Umherirrender: Inject services into SpecialListFiles [core] - 10https://gerrit.wikimedia.org/r/628484 (https://phabricator.wikimedia.org/T259960) [12:33:56] (03CR) 10Jforrester: [C: 03+2] Inject service into SpecialFewestRevisions/SpecialMostRevisions [core] - 10https://gerrit.wikimedia.org/r/628476 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [12:36:08] 10MediaWiki-extensions-FlaggedRevs, 10Russian-Sites: FlaggedRevs disabled for NS "Wikisource", "MediaWiki" and "File" but it still requiring reviews for transcludes - https://phabricator.wikimedia.org/T226054 (10Vladis13) Yes {F32355746} {F32355748} https://ru.wikisource.org/wiki/%D0%9F%D0%BE%D1%85%D0%BE%D0%B... [12:37:07] (03PS2) 10Daimona Eaytoy: ViewTools: hide the result box when empty [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/621290 (https://phabricator.wikimedia.org/T253492) [12:37:34] (03CR) 10Jforrester: [C: 03+2] Use ::class to refer HTML form field classes [core] - 10https://gerrit.wikimedia.org/r/628478 (owner: 10Umherirrender) [12:39:07] (03Abandoned) 10Daimona Eaytoy: Change all variables to use lowerCamelCase instead of underscores [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/456094 (owner: 10Daimona Eaytoy) [12:42:12] (03CR) 10jerkins-bot: [V: 04-1] Inject services into SpecialListFiles [core] - 10https://gerrit.wikimedia.org/r/628484 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [12:42:15] (03PS4) 10Jforrester: Automatically register 'Anonymous' as a reserved username [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/588388 (https://phabricator.wikimedia.org/T238632) (owner: 10Florianschmidtwelzow) [12:45:33] (03CR) 10jerkins-bot: [V: 04-1] Automatically register 'Anonymous' as a reserved username [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/588388 (https://phabricator.wikimedia.org/T238632) (owner: 10Florianschmidtwelzow) [12:53:09] (03Merged) 10jenkins-bot: Inject service into SpecialFewestRevisions/SpecialMostRevisions [core] - 10https://gerrit.wikimedia.org/r/628476 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [12:54:53] (03CR) 10jerkins-bot: [V: 04-1] ViewTools: hide the result box when empty [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/621290 (https://phabricator.wikimedia.org/T253492) (owner: 10Daimona Eaytoy) [12:56:17] (03PS3) 10Umherirrender: Inject services into SpecialListFiles [core] - 10https://gerrit.wikimedia.org/r/628484 (https://phabricator.wikimedia.org/T259960) [12:56:43] (03Merged) 10jenkins-bot: Use ::class to refer HTML form field classes [core] - 10https://gerrit.wikimedia.org/r/628478 (owner: 10Umherirrender) [13:00:40] (03PS2) 10Umherirrender: Inject services into SpecialNewFiles [core] - 10https://gerrit.wikimedia.org/r/628438 (https://phabricator.wikimedia.org/T259960) [13:03:38] (03CR) 10Esanders: [C: 03+2] Add 'use strict' to javascript files [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/628413 (owner: 10Umherirrender) [13:04:28] (03PS1) 10Umherirrender: Inject services into SpecialCategories [core] - 10https://gerrit.wikimedia.org/r/628485 (https://phabricator.wikimedia.org/T259960) [13:04:50] (03CR) 10Esanders: [C: 04-1] build: Remove explicit eslint-plugin-es/eslint-plugin-vue (031 comment) [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/627356 (owner: 10Umherirrender) [13:14:00] (03PS2) 10Umherirrender: Inject service into SpecialMostCategories/SpecialMostInterwikis [core] - 10https://gerrit.wikimedia.org/r/628433 (https://phabricator.wikimedia.org/T259960) [13:17:21] (03PS5) 10Umherirrender: build: Remove explicit eslint-plugin-es/eslint-plugin-vue [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/627356 [13:17:35] (03CR) 10Umherirrender: build: Remove explicit eslint-plugin-es/eslint-plugin-vue (031 comment) [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/627356 (owner: 10Umherirrender) [13:18:03] 10ContentTranslation, 10Language-Team (Language-2020-July-September): "Publish" button remains greyed out: "TypeError: this.translationView.categoryUI is null" - https://phabricator.wikimedia.org/T244114 (10RodneyAraujo) a:03santhosh [13:20:51] (03CR) 10jerkins-bot: [V: 04-1] build: Remove explicit eslint-plugin-es/eslint-plugin-vue [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/627356 (owner: 10Umherirrender) [13:22:46] (03Merged) 10jenkins-bot: Add 'use strict' to javascript files [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/628413 (owner: 10Umherirrender) [13:24:06] 10MediaWiki-Internationalization, 10I18n: Creating Gujarati (Hindu) Calendar - https://phabricator.wikimedia.org/T101442 (10Aklapper) @Aniket: Hi, did the last comment help, or are you stuck at some step? Is there a public place where to take a look at your code? [13:24:38] 10ContentTranslation, 10Language-Team (Language-2020-July-September): "Publish" button remains greyed out: "TypeError: this.translationView.categoryUI is null" - https://phabricator.wikimedia.org/T244114 (10Aklapper) a:05santhosh→03None @RodneyAraujo: Please [do not assign tasks to people without their exp... [13:36:03] (03CR) 10Urbanecm: [C: 03+1] "> Patch Set 11: Code-Review-1" [core] - 10https://gerrit.wikimedia.org/r/551606 (https://phabricator.wikimedia.org/T232908) (owner: 10DannyS712) [13:40:09] (03PS1) 10Daimona Eaytoy: [WIP] Add a value object to represent filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628488 [13:41:48] (03CR) 10Daimona Eaytoy: "recheck" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/621290 (https://phabricator.wikimedia.org/T253492) (owner: 10Daimona Eaytoy) [13:56:54] 10Wikimedia-Site-requests: Request for settings about namespaces on ja.wikivoyage - https://phabricator.wikimedia.org/T262155 (10Atmark-chan) The pages in `トーク:プロジェクト:` was moved by @Mirinano with API. [13:57:34] 10Wikimedia-Site-requests: Request for settings about namespaces on ja.wikivoyage - https://phabricator.wikimedia.org/T262155 (10Atmark-chan) [13:57:59] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add a value object to represent filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628488 (owner: 10Daimona Eaytoy) [14:01:37] 10Phabricator, 10Developer-Advocacy (Jul-Sep 2020), 10Documentation: Review existing videos on Phabricator Help pages on mw.org - https://phabricator.wikimedia.org/T262217 (10Aklapper) [14:20:21] 10Phabricator, 10Developer-Advocacy (Jul-Sep 2020), 10Documentation: Review existing videos on Phabricator Help pages on mw.org - https://phabricator.wikimedia.org/T262217 (10Aklapper) 05Open→03Resolved Uhm. This turned out to become basically a "Remove everything". :'( The UI has changed so much in the... [14:21:12] 10Dumps-Generation: rebalance the pages per page-content output file for big/huge wikis - https://phabricator.wikimedia.org/T263322 (10ArielGlenn) p:05Triage→03Medium [14:22:44] (03PS2) 10Daimona Eaytoy: [WIP] Add a value object to represent filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628488 [14:28:11] (03PS1) 10Cicalese: Remove use of deprecated mediawiki.skinning.content. [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/628489 [14:29:59] (03PS3) 10Daimona Eaytoy: Add a value object to represent filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628488 [14:30:02] (03PS2) 10Cicalese: Remove use of deprecated mediawiki.skinning.content. [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/628489 [14:33:25] (03PS10) 10Urbanecm: Move SpecialBlock::canBlockEmail to BlockPermissionChecker [core] - 10https://gerrit.wikimedia.org/r/628432 (https://phabricator.wikimedia.org/T250737) [14:44:44] 10MobileFrontend, 10Mobile: MobileFrontend displays second paragraph as first paragraph on dewiki (Moving article lead is broken) - https://phabricator.wikimedia.org/T263306 (10Aklapper) [14:45:02] (03PS1) 10Umherirrender: Adjust width and height in tests [extensions/Math] - 10https://gerrit.wikimedia.org/r/628491 [14:47:19] (03PS1) 10Reedy: Updating brick/math (0.8.15 => 0.8.17) [vendor] - 10https://gerrit.wikimedia.org/r/628492 [14:48:23] 10MediaWiki-General, 10MediaWiki-extensions-General, 10MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), 10MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), and 4 others: Clean up PSR12.Properties.ConstantVisibility.NotFound phpcs exclusion in WMF Prod - https://phabricator.wikimedia.org/T253169 (10Reedy) [14:56:27] 10MediaWiki-General, 10MediaWiki-extensions-General, 10Wikidata, 10MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), and 5 others: Clean up PSR12.Properties.ConstantVisibility.NotFound phpcs exclusion in WMF Prod - https://phabricator.wikimedia.org/T253169 (10Reedy) ` reedy@deploy1001:/srv/mediawiki-staging/php-1... [14:57:12] 10MediaWiki-General, 10MediaWiki-extensions-General, 10Wikidata, 10MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), and 5 others: Clean up PSR12.Properties.ConstantVisibility.NotFound phpcs exclusion in WMF Prod - https://phabricator.wikimedia.org/T253169 (10Reedy) [15:01:09] (03CR) 10Mainframe98: "I feel like the whole Skin::__construct and derivates have become a bit of an inheritance mess." [skins/Vector] - 10https://gerrit.wikimedia.org/r/628069 (https://phabricator.wikimedia.org/T262233) (owner: 10Ammarpad) [15:04:07] 10Dumps-Generation: for xml/sql dumps, make the means of finding the next wiki to dump cheaper - https://phabricator.wikimedia.org/T263323 (10ArielGlenn) p:05Triage→03Medium [15:04:56] (03PS1) 10Umherirrender: Use global config on SpecialNearby [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/628493 [15:05:57] 10MediaWiki-General, 10MediaWiki-extensions-CentralAuth, 10MediaWiki-extensions-CentralNotice, 10MediaWiki-extensions-FlaggedRevs, and 29 others: Clean up PSR12.Properties.ConstantVisibility.NotFound phpcs exclusion in WMF Prod - https://phabricator.wikimedia.org/T253169 (10Reedy) [15:07:03] (03PS2) 10Umherirrender: Use global config on SpecialNearby [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/628493 [15:13:36] (03PS163) 10Urbanecm: Introduce backend class for blocking users [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) [15:14:42] (03CR) 10Urbanecm: Introduce backend class for blocking users (0313 comments) [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) (owner: 10Urbanecm) [15:16:31] (03PS1) 10Daimona Eaytoy: [WIP] Avoid depending on ContextSource in saveFilter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628494 [15:19:46] (03PS1) 10Reedy: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/628495 (https://phabricator.wikimedia.org/T253169) [15:21:39] (03PS164) 10Urbanecm: Introduce backend class for blocking users [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) [15:22:15] (03PS165) 10Urbanecm: Introduce backend class for blocking users [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) [15:22:47] (03CR) 10DannyS712: "Looks interesting" (033 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628488 (owner: 10Daimona Eaytoy) [15:25:31] (03CR) 10Daimona Eaytoy: Add a value object to represent filters (033 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628488 (owner: 10Daimona Eaytoy) [15:28:04] (03CR) 10Urbanecm: Introduce backend class for blocking users (033 comments) [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) (owner: 10Urbanecm) [15:28:12] (03PS166) 10Urbanecm: Introduce backend class for blocking users [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) [15:33:54] (03CR) 10DannyS712: [C: 03+1] "Untested" [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/628493 (owner: 10Umherirrender) [15:38:12] (03CR) 10Pastakhov: "This change is ready for review." [extensions/AccessControl] - 10https://gerrit.wikimedia.org/r/627603 (owner: 10Pastakhov) [15:39:38] (03CR) 10DannyS712: Introduce a KeywordsManager service (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/565052 (owner: 10Daimona Eaytoy) [15:47:01] (03CR) 10Mainframe98: [C: 03+1] "Works for me now, allowing me to use a mobile skin that has dependencies injected." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/625775 (https://phabricator.wikimedia.org/T262233) (owner: 10Ammarpad) [15:47:45] (03CR) 10jerkins-bot: [V: 04-1] Introduce backend class for blocking users [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) (owner: 10Urbanecm) [15:52:04] (03PS1) 10Jdlrobson: Drop jquery.ui.touchpunch [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/628496 (https://phabricator.wikimedia.org/T262947) [15:54:18] (03PS167) 10Urbanecm: Introduce backend class for blocking users [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) [15:54:28] (03CR) 10Urbanecm: Introduce backend class for blocking users (037 comments) [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) (owner: 10Urbanecm) [15:55:02] (03PS168) 10Urbanecm: Introduce backend class for blocking users [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) [15:59:18] 10MediaWiki-User-preferences, 10MediaWiki-Watchlist, 10Growth-Team: Allow to exclude bots from watchlist notifications - https://phabricator.wikimedia.org/T262750 (10Jidanni) https://commons.wikimedia.org/wiki/Commons:Help_desk#How_can_I_stop_receiving_bot_notification_by_email?? [16:00:54] (03PS169) 10Urbanecm: Introduce backend class for blocking users [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) [16:01:43] (03PS2) 10Daimona Eaytoy: Avoid depending on ContextSource in saveFilter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628494 [16:02:52] (03PS7) 10Urbanecm: Introduce BlockUtils service [core] - 10https://gerrit.wikimedia.org/r/628427 (https://phabricator.wikimedia.org/T263189) [16:02:57] (03CR) 10Urbanecm: Introduce BlockUtils service (034 comments) [core] - 10https://gerrit.wikimedia.org/r/628427 (https://phabricator.wikimedia.org/T263189) (owner: 10Urbanecm) [16:03:07] (03CR) 10Ppchelko: "A few nit comments inlined, by far didn't look at the whole thing yet." (039 comments) [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/622707 (https://phabricator.wikimedia.org/T260330) (owner: 10Tim Starling) [16:03:16] 10MediaWiki-User-preferences, 10MediaWiki-Watchlist, 10Growth-Team: Allow to exclude bots from watchlist notifications - https://phabricator.wikimedia.org/T262750 (10Jidanni) https://commons.wikimedia.org/wiki/Commons:Help_desk/Archive/2020/08#How_to_keep_an_eye_on_my_uploads_after_kind_of_spam_notifications%3F [16:03:23] (03CR) 10DannyS712: Drop jquery.ui.touchpunch (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/628496 (https://phabricator.wikimedia.org/T262947) (owner: 10Jdlrobson) [16:03:37] (03PS28) 10Daimona Eaytoy: Introduce a KeywordsManager service [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/565052 [16:03:45] (03CR) 10Daimona Eaytoy: Introduce a KeywordsManager service (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/565052 (owner: 10Daimona Eaytoy) [16:07:49] (03PS4) 10Daimona Eaytoy: Add a value object to represent filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628488 [16:11:40] (03PS170) 10Urbanecm: Introduce backend class for blocking users [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) [16:11:41] 10AbuseFilter, 10Schema-change: abuse_filter.af_comments and abuse_filter.af_public_comments should be NOT NULL - https://phabricator.wikimedia.org/T263324 (10Daimona) [16:13:38] (03PS5) 10Daimona Eaytoy: Add a value object to represent filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628488 [16:13:51] (03PS3) 10Daimona Eaytoy: Avoid depending on ContextSource in saveFilter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628494 [16:17:28] 10MediaWiki-Blocks, 10MediaWiki-Special-pages, 10Anti-Harassment (The Letter Song), 10MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), and 4 others: Refactor logic for creating and logging a block out of SpecialBlock so it can be easily reused elsewhere - https://phabricator.wikimedia.org/T189073 (10Urbanecm) [16:19:42] 10MediaWiki-Blocks, 10Patch-For-Review, 10Technical-Debt, 10User-Urbanecm: Special:Block should not play the role of a central blocking service/utility - https://phabricator.wikimedia.org/T250737 (10Urbanecm) [16:22:17] 10MediaWiki-Blocks, 10MediaWiki-Special-pages, 10Anti-Harassment, 10Platform Team Initiatives (Decoupling (CDP2)), 10Technical-Debt: Deprecate SpecialBlock::checkUnblockSelf - https://phabricator.wikimedia.org/T263326 (10Urbanecm) [16:22:33] (03PS3) 10Urbanecm: Deprecate SpecialBlock::checkUnblockSelf [core] - 10https://gerrit.wikimedia.org/r/628429 (https://phabricator.wikimedia.org/T263326) [16:24:15] (03PS4) 10Urbanecm: Deprecate SpecialBlock::checkUnblockSelf [core] - 10https://gerrit.wikimedia.org/r/628429 (https://phabricator.wikimedia.org/T263326) [16:24:47] (03CR) 10Urbanecm: Introduce backend class for blocking users (032 comments) [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) (owner: 10Urbanecm) [16:25:14] 10MediaWiki-Blocks, 10MediaWiki-Special-pages, 10Anti-Harassment, 10Patch-For-Review, and 3 others: Deprecate SpecialBlock::checkUnblockSelf - https://phabricator.wikimedia.org/T263326 (10Urbanecm) p:05Triage→03Low a:03Urbanecm [16:25:26] 10Dumps-Generation: for xml/sql dumps, make the means of finding the next wiki to dump cheaper - https://phabricator.wikimedia.org/T263323 (10ArielGlenn) This probably also applies to creating directories for each wiki for each run. [16:26:25] (03PS171) 10Urbanecm: Introduce backend class for blocking users [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) [16:27:59] 10MediaWiki-Blocks, 10MediaWiki-Special-pages, 10Platform Team Initiatives (Decoupling (CDP2)), 10Technical-Debt: Deprecate SpecialBlock::canBlockEmail and replace its usages - https://phabricator.wikimedia.org/T263327 (10Urbanecm) [16:28:07] (03PS11) 10Urbanecm: Move SpecialBlock::canBlockEmail to BlockPermissionChecker [core] - 10https://gerrit.wikimedia.org/r/628432 (https://phabricator.wikimedia.org/T263327) [16:30:43] (03PS5) 10Urbanecm: Deprecate SpecialBlock::checkUnblockSelf [core] - 10https://gerrit.wikimedia.org/r/628429 (https://phabricator.wikimedia.org/T263326) [16:31:30] 10MediaWiki-Blocks, 10MediaWiki-Special-pages, 10Patch-For-Review, 10Platform Team Initiatives (Decoupling (CDP2)), and 2 others: Deprecate SpecialBlock::canBlockEmail and replace its usages - https://phabricator.wikimedia.org/T263327 (10Urbanecm) p:05Triage→03Low a:03Urbanecm [16:32:48] 10MediaWiki-API, 10AbuseFilter, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Patch-For-Review, 10User-DannyS712: AbuseFilter should have an edit API - https://phabricator.wikimedia.org/T213037 (10Daimona) >>! In T213037#6475508, @DannyS712 wrote: > Not currently working on this, maybe @Daimona would be... [16:33:19] (03CR) 10Zoranzoki21: [C: 04-1] "See comment." (031 comment) [extensions/AccessControl] - 10https://gerrit.wikimedia.org/r/627603 (owner: 10Pastakhov) [16:33:58] (03PS4) 10Daimona Eaytoy: Avoid depending on ContextSource in saveFilter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628494 (https://phabricator.wikimedia.org/T213037) [16:34:01] (03PS6) 10Urbanecm: Deprecate SpecialBlock::checkUnblockSelf [core] - 10https://gerrit.wikimedia.org/r/628429 (https://phabricator.wikimedia.org/T263326) [16:36:24] 10Stewards-and-global-tools, 10Wikimedia-Site-requests, 10Community-consensus-needed: Unused local "stewards" group (finding situations that local stewards groups are used) - https://phabricator.wikimedia.org/T252814 (10AlexisJazz) >>! In T252814#6474886, @Urbanecm wrote: > I still think this should be WONTF... [16:37:20] 10Stewards-and-global-tools, 10Wikimedia-Site-requests, 10Community-consensus-needed: Unused local "stewards" group (finding situations that local stewards groups are used) - https://phabricator.wikimedia.org/T252814 (10Urbanecm) 05Stalled→03Declined [16:38:35] 10MediaWiki-extensions-CentralAuth, 10GlobalRename, 10Wikimedia-Site-requests: Unblock stuck global rename of Davidfromtheworld - https://phabricator.wikimedia.org/T263317 (10Kizule) @Urbanecm Can you unblock this one please? [16:42:19] (03PS12) 10Urbanecm: Move SpecialBlock::canBlockEmail to BlockPermissionChecker [core] - 10https://gerrit.wikimedia.org/r/628432 (https://phabricator.wikimedia.org/T263327) [16:43:19] (03PS6) 10Daimona Eaytoy: Add a value object to represent filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628488 [16:43:29] (03PS5) 10Daimona Eaytoy: Avoid depending on ContextSource in saveFilter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628494 (https://phabricator.wikimedia.org/T213037) [16:43:59] (03CR) 10Ammarpad: [C: 04-1] "> > Please explain the use case or where this will be immediately used. I only see a single theoretical example in the task, no concrete i" [core] - 10https://gerrit.wikimedia.org/r/551606 (https://phabricator.wikimedia.org/T232908) (owner: 10DannyS712) [16:48:47] 10MediaWiki-Blocks, 10AbuseFilter, 10Platform Engineering, 10Patch-For-Review, and 2 others: Admins blocked by User:Abuse filter cannot unblockself - https://phabricator.wikimedia.org/T232908 (10Ammarpad) Please someone should give real (non-theoretical) example of where this has caused a problem on Wikime... [16:51:41] 10MediaWiki-Blocks, 10AbuseFilter, 10Platform Engineering, 10Patch-For-Review, and 2 others: Admins blocked by User:Abuse filter cannot unblockself - https://phabricator.wikimedia.org/T232908 (10Pppery) https://meta.wikimedia.org/wiki/Steward_requests/Miscellaneous/2019-09#Unblock_DannyS712_on_mediawiki [16:55:19] (03PS1) 10Urbanecm: [tests] Increase test coverage for BlockPermissionChecker [core] - 10https://gerrit.wikimedia.org/r/628497 [16:56:34] (03CR) 10jerkins-bot: [V: 04-1] Deprecate SpecialBlock::checkUnblockSelf [core] - 10https://gerrit.wikimedia.org/r/628429 (https://phabricator.wikimedia.org/T263326) (owner: 10Urbanecm) [16:58:10] (03CR) 10DannyS712: "LGTM, 1 suggestion" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/628432 (https://phabricator.wikimedia.org/T263327) (owner: 10Urbanecm) [16:59:56] (03PS7) 10Urbanecm: Deprecate SpecialBlock::checkUnblockSelf [core] - 10https://gerrit.wikimedia.org/r/628429 (https://phabricator.wikimedia.org/T263326) [17:00:05] 10MediaWiki-Blocks, 10AbuseFilter, 10Platform Engineering, 10Patch-For-Review, and 2 others: Admins blocked by User:Abuse filter cannot unblockself - https://phabricator.wikimedia.org/T232908 (10Ammarpad) >>! In T232908#6476372, @Pppery wrote: > https://meta.wikimedia.org/wiki/Steward_requests/Miscellaneou... [17:00:56] (03PS13) 10Urbanecm: Move SpecialBlock::canBlockEmail to BlockPermissionChecker [core] - 10https://gerrit.wikimedia.org/r/628432 (https://phabricator.wikimedia.org/T263327) [17:02:36] (03PS1) 10Reedy: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/628498 (https://phabricator.wikimedia.org/T253169) [17:03:13] (03PS8) 10Urbanecm: Deprecate SpecialBlock::checkUnblockSelf [core] - 10https://gerrit.wikimedia.org/r/628429 (https://phabricator.wikimedia.org/T263326) [17:06:42] (03PS1) 10Reedy: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/Linter] - 10https://gerrit.wikimedia.org/r/628500 (https://phabricator.wikimedia.org/T253169) [17:07:42] (03PS2) 10Reedy: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/Linter] - 10https://gerrit.wikimedia.org/r/628500 (https://phabricator.wikimedia.org/T253169) [17:07:52] (03PS2) 10Urbanecm: [tests] Increase test coverage for BlockPermissionChecker [core] - 10https://gerrit.wikimedia.org/r/628497 [17:08:59] (03PS1) 10Reedy: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/628501 (https://phabricator.wikimedia.org/T253169) [17:09:19] 10MediaWiki-extensions-Translate, 10Parsoid, 10Language-Team (Language-2020-July-September): Make Translate extension compatible with Parsoid - https://phabricator.wikimedia.org/T261181 (10ssastry) [[ I think Open Question 3 is the key question to answer. This response about inline vs block assumes that the... [17:11:02] (03CR) 10Urbanecm: Move SpecialBlock::canBlockEmail to BlockPermissionChecker (031 comment) [core] - 10https://gerrit.wikimedia.org/r/628432 (https://phabricator.wikimedia.org/T263327) (owner: 10Urbanecm) [17:11:35] (03PS1) 10Reedy: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/628502 (https://phabricator.wikimedia.org/T253169) [17:12:46] (03CR) 10jerkins-bot: [V: 04-1] Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/628501 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [17:13:32] (03CR) 10DannyS712: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/628377 (https://phabricator.wikimedia.org/T189073) (owner: 10DannyS712) [17:13:52] 10MediaWiki-Blocks, 10MediaWiki-Special-pages, 10Anti-Harassment (The Letter Song), 10MW-1.36-notes (1.36.0-wmf.10; 2020-09-22), and 5 others: Refactor logic for creating and logging a block out of SpecialBlock so it can be easily reused elsewhere - https://phabricator.wikimedia.org/T189073 (10DannyS712) [17:14:14] 10MediaWiki-Page-deletion: Add "Restore associated talk page" option to special:undelete - https://phabricator.wikimedia.org/T263211 (10AlexisJazz) >>! In T263211#6473633, @Aklapper wrote: > Removing project team tag as it is up to teams to decide what they plan to work on. Sorry, did not notice @daniel who had... [17:20:40] (03CR) 10Reedy: "Failure filed at T263330" [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/628501 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [17:21:18] (03PS31) 10Dbarratt: Handle CORS preflight request and prevent anon users from unsafe methods [core] - 10https://gerrit.wikimedia.org/r/621900 (https://phabricator.wikimedia.org/T232176) [17:21:50] 10MediaWiki-extensions-UserMerge: Call to undeclared method WikiPage::doDeleteArticle - https://phabricator.wikimedia.org/T263330 (10Reedy) [17:21:51] (03CR) 10DannyS712: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/628378 (https://phabricator.wikimedia.org/T263327) (owner: 10DannyS712) [17:23:06] 04(no projects): RuntimeError: cannot join current thread after updating to new version/python3 - https://phabricator.wikimedia.org/T263331 (10Matthias_Buchmeier) [17:24:34] (03CR) 10Jforrester: [C: 03+2] Fix PSR12.Properties.ConstantVisibility.NotFound (031 comment) [extensions/Linter] - 10https://gerrit.wikimedia.org/r/628500 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [17:24:37] (03CR) 10DannyS712: [C: 03+2] Move SpecialBlock::canBlockEmail to BlockPermissionChecker [core] - 10https://gerrit.wikimedia.org/r/628432 (https://phabricator.wikimedia.org/T263327) (owner: 10Urbanecm) [17:25:04] (03PS3) 10Urbanecm: [tests] Increase test coverage for BlockPermissionChecker [core] - 10https://gerrit.wikimedia.org/r/628497 [17:25:46] (03CR) 10DannyS712: Deprecate SpecialBlock::checkUnblockSelf (031 comment) [core] - 10https://gerrit.wikimedia.org/r/628429 (https://phabricator.wikimedia.org/T263326) (owner: 10Urbanecm) [17:25:55] (03CR) 10Urbanecm: [C: 03+2] [docs] BlockPermissionChecker::$targetType can be null [core] - 10https://gerrit.wikimedia.org/r/628378 (https://phabricator.wikimedia.org/T263327) (owner: 10DannyS712) [17:27:58] (03PS9) 10Urbanecm: Deprecate SpecialBlock::checkUnblockSelf [core] - 10https://gerrit.wikimedia.org/r/628429 (https://phabricator.wikimedia.org/T263326) [17:28:01] (03CR) 10Urbanecm: Deprecate SpecialBlock::checkUnblockSelf (031 comment) [core] - 10https://gerrit.wikimedia.org/r/628429 (https://phabricator.wikimedia.org/T263326) (owner: 10Urbanecm) [17:28:31] (03Merged) 10jenkins-bot: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/Linter] - 10https://gerrit.wikimedia.org/r/628500 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [17:30:53] 10MediaWiki-extensions-Translate, 10Parsoid, 10Language-Team (Language-2020-July-September): Make Translate extension compatible with Parsoid - https://phabricator.wikimedia.org/T261181 (10ssastry) As for Open Question 3, that is a good question you ask. Translate wrappers are more in the nature of annotatio... [17:32:07] 10InternetArchiveBot: Deploy InternetArchiveBot on the Burmese Wikipedia (mywiki) - https://phabricator.wikimedia.org/T208701 (10Ninjastrikers) >>! In T208701#6455278, @Cyberpower678 wrote: > Approval request: https://my.wikipedia.org/wiki/%E1%80%9D%E1%80%AE%E1%80%80%E1%80%AE%E1%80%95%E1%80%AE%E1%80%B8%E1%80%92%... [17:35:13] (03CR) 10Urbanecm: [C: 03+2] Add tests for ApiBlock return values when blocking by userid [core] - 10https://gerrit.wikimedia.org/r/628377 (https://phabricator.wikimedia.org/T189073) (owner: 10DannyS712) [17:37:40] (03PS10) 10Urbanecm: Deprecate SpecialBlock::checkUnblockSelf [core] - 10https://gerrit.wikimedia.org/r/628429 (https://phabricator.wikimedia.org/T263326) [17:40:29] (03CR) 10DannyS712: Add a value object to represent filters (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628488 (owner: 10Daimona Eaytoy) [17:42:02] (03CR) 10jerkins-bot: [V: 04-1] Handle CORS preflight request and prevent anon users from unsafe methods [core] - 10https://gerrit.wikimedia.org/r/621900 (https://phabricator.wikimedia.org/T232176) (owner: 10Dbarratt) [17:45:59] (03Merged) 10jenkins-bot: Move SpecialBlock::canBlockEmail to BlockPermissionChecker [core] - 10https://gerrit.wikimedia.org/r/628432 (https://phabricator.wikimedia.org/T263327) (owner: 10Urbanecm) [17:46:43] (03Merged) 10jenkins-bot: [docs] BlockPermissionChecker::$targetType can be null [core] - 10https://gerrit.wikimedia.org/r/628378 (https://phabricator.wikimedia.org/T263327) (owner: 10DannyS712) [17:47:19] (03CR) 10Ammarpad: [C: 03+2] Use global config on SpecialNearby [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/628493 (owner: 10Umherirrender) [17:47:28] 10InternetArchiveBot: IABot reports blacklist link in article causes failure, but cannot find any - https://phabricator.wikimedia.org/T263332 (10NormalOp) [17:49:07] (03CR) 10jerkins-bot: [V: 04-1] [tests] Increase test coverage for BlockPermissionChecker [core] - 10https://gerrit.wikimedia.org/r/628497 (owner: 10Urbanecm) [17:51:58] (03PS4) 10Urbanecm: [tests] Increase test coverage for BlockPermissionChecker [core] - 10https://gerrit.wikimedia.org/r/628497 [17:52:17] (03PS32) 10Dbarratt: Handle CORS preflight request and prevent anon users from unsafe methods [core] - 10https://gerrit.wikimedia.org/r/621900 (https://phabricator.wikimedia.org/T232176) [17:52:32] (03PS172) 10Urbanecm: Introduce backend class for blocking users [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) [17:52:55] 10MediaWiki-Vendor, 10WaitConditionLoop, 10utfnormal, 10PHP 7.2 support, 10Performance-Team (Radar): Explicit const visibility in MediaWiki bundled libraries - https://phabricator.wikimedia.org/T253185 (10Reedy) [17:55:43] 10Anti-Harassment, 10CheckUser: Do not call SpecialBlock::canBlockEmail from CheckUser - https://phabricator.wikimedia.org/T263334 (10Urbanecm) [17:56:52] (03PS1) 10Reedy: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/628504 (https://phabricator.wikimedia.org/T253169) [17:57:28] (03CR) 10Physikerwelt: [C: 04-1] "looks good...however, the commit message should be updated to keep track of the reason for this problem" (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/628491 (owner: 10Umherirrender) [17:57:49] 10MediaWiki-extensions-UserMerge: Call to undeclared method WikiPage::doDeleteArticle - https://phabricator.wikimedia.org/T263330 (10DannyS712) No objections from me regarding changing the supported versions, I was just avoiding doing so where possible [17:59:54] (03Merged) 10jenkins-bot: Add tests for ApiBlock return values when blocking by userid [core] - 10https://gerrit.wikimedia.org/r/628377 (https://phabricator.wikimedia.org/T189073) (owner: 10DannyS712) [17:59:57] (03Merged) 10jenkins-bot: Use global config on SpecialNearby [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/628493 (owner: 10Umherirrender) [18:03:04] 10MediaWiki-Vendor, 10WaitConditionLoop, 10utfnormal, 10PHP 7.2 support, 10Performance-Team (Radar): Explicit const visibility in MediaWiki bundled libraries - https://phabricator.wikimedia.org/T253185 (10Reedy) [18:03:57] (03CR) 10Pastakhov: Refactor the source code v5.0 (031 comment) [extensions/AccessControl] - 10https://gerrit.wikimedia.org/r/627603 (owner: 10Pastakhov) [18:05:58] 10MediaWiki-Logevents, 10AbuseFilter, 10SpamBlacklist, 10TitleBlacklist: Special:Log should display all logs a user has the rights to see (instead of only public logs) - https://phabricator.wikimedia.org/T157218 (10DannyS712) This appears to have been the case at one point, but the behaviour was changed in... [18:06:00] 10MediaWiki-General, 10MediaWiki-extensions-General, 10PHP 7.2 support, 10Technical-Debt: Clean up PSR12.Properties.ConstantVisibility.NotFound phpcs exclusion - https://phabricator.wikimedia.org/T237840 (10Reedy) [18:06:38] 10MediaWiki-Logevents, 10AbuseFilter, 10Platform Engineering, 10SpamBlacklist, 10TitleBlacklist: Special:Log should display all logs a user has the rights to see (instead of only public logs) - https://phabricator.wikimedia.org/T157218 (10DannyS712) Tagging CPT as a feature request to review [18:06:54] (03PS1) 10Urbanecm: Do not call SpecialBlock::canBlockEmail in ApiBlock [core] - 10https://gerrit.wikimedia.org/r/628505 (https://phabricator.wikimedia.org/T263327) [18:09:23] (03CR) 10DannyS712: Do not call SpecialBlock::canBlockEmail in ApiBlock (033 comments) [core] - 10https://gerrit.wikimedia.org/r/628505 (https://phabricator.wikimedia.org/T263327) (owner: 10Urbanecm) [18:09:38] (03CR) 10Ppchelko: [C: 04-1] "some nitpicks" (0312 comments) [core] - 10https://gerrit.wikimedia.org/r/621900 (https://phabricator.wikimedia.org/T232176) (owner: 10Dbarratt) [18:12:23] 10MediaWiki-Vendor, 10WaitConditionLoop, 10utfnormal, 10PHP 7.2 support, 10Performance-Team (Radar): Explicit const visibility in MediaWiki bundled libraries - https://phabricator.wikimedia.org/T253185 (10Reedy) [18:12:38] (03PS2) 10Urbanecm: Do not call SpecialBlock::canBlockEmail in ApiBlock [core] - 10https://gerrit.wikimedia.org/r/628505 (https://phabricator.wikimedia.org/T263327) [18:14:36] (03PS6) 10Umherirrender: build: Remove explicit eslint-plugin-es/eslint-plugin-vue [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/627356 [18:16:06] (03PS173) 10DannyS712: Introduce backend class for blocking users [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) (owner: 10Urbanecm) [18:16:22] (03PS1) 10Urbanecm: Do not call SpecialBlock::canBlockEmail from CheckUser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/628506 (https://phabricator.wikimedia.org/T263334) [18:17:07] (03CR) 10Urbanecm: Do not call SpecialBlock::canBlockEmail in ApiBlock (033 comments) [core] - 10https://gerrit.wikimedia.org/r/628505 (https://phabricator.wikimedia.org/T263327) (owner: 10Urbanecm) [18:17:13] (03CR) 10jerkins-bot: [V: 04-1] [tests] Increase test coverage for BlockPermissionChecker [core] - 10https://gerrit.wikimedia.org/r/628497 (owner: 10Urbanecm) [18:17:45] 10MediaWiki-General, 10MediaWiki-extensions-CentralAuth, 10MediaWiki-extensions-CentralNotice, 10MediaWiki-extensions-FlaggedRevs, and 29 others: Clean up PSR12.Properties.ConstantVisibility.NotFound phpcs exclusion in WMF Prod - https://phabricator.wikimedia.org/T253169 (10Reedy) [18:18:07] (03PS2) 10Umherirrender: Fix mathoid test data for last changes to renderer [extensions/Math] - 10https://gerrit.wikimedia.org/r/628491 [18:18:33] (03CR) 10Umherirrender: Fix mathoid test data for last changes to renderer (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/628491 (owner: 10Umherirrender) [18:18:46] (03CR) 10DannyS712: Do not call SpecialBlock::canBlockEmail from CheckUser (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/628506 (https://phabricator.wikimedia.org/T263334) (owner: 10Urbanecm) [18:19:08] (03PS4) 10Umherirrender: Avoid shadowed variables in javascript [extensions/Math] - 10https://gerrit.wikimedia.org/r/628422 [18:21:15] (03PS2) 10Urbanecm: Do not call SpecialBlock::canBlockEmail from CheckUser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/628506 (https://phabricator.wikimedia.org/T263334) [18:21:30] (03CR) 10Urbanecm: Do not call SpecialBlock::canBlockEmail from CheckUser (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/628506 (https://phabricator.wikimedia.org/T263334) (owner: 10Urbanecm) [18:22:49] (03CR) 10DannyS712: [C: 04-1] "Need to bump version requirements or call conditionally based on version" (032 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/628506 (https://phabricator.wikimedia.org/T263334) (owner: 10Urbanecm) [18:22:58] 10MediaWiki-extensions-CentralNotice, 10Technical-Debt: Unused regex consts - https://phabricator.wikimedia.org/T263335 (10Reedy) [18:26:31] 10MediaWiki-extensions-CentralNotice, 10Technical-Debt: Unused regex consts - https://phabricator.wikimedia.org/T263335 (10Reedy) [18:26:36] (03CR) 10Jforrester: [C: 03+2] Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/628502 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [18:27:13] 10Wikimedia-Site-requests: Change the time for some wikis of the CWIRP - https://phabricator.wikimedia.org/T263123 (10Evrifaessa) p:05Triage→03Medium a:03Evrifaessa I'll claim this. [18:28:24] (03CR) 10Jforrester: [C: 03+2] Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/628504 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [18:29:45] (03CR) 10Jforrester: [C: 03+2] Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/628495 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [18:30:42] (03CR) 10Jforrester: [C: 03+2] Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/628498 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [18:32:02] (03CR) 10DannyS712: [C: 03+2] Deprecate SpecialBlock::checkUnblockSelf [core] - 10https://gerrit.wikimedia.org/r/628429 (https://phabricator.wikimedia.org/T263326) (owner: 10Urbanecm) [18:32:08] (03PS1) 10Physikerwelt: Add test pipeline [services/texvcjs] - 10https://gerrit.wikimedia.org/r/628508 [18:32:10] (03PS2) 10Jforrester: Drop jquery.ui.touchpunch [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/628496 (https://phabricator.wikimedia.org/T262947) (owner: 10Jdlrobson) [18:32:15] (03PS3) 10Jforrester: Drop jquery.ui.touchpunch [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/628496 (https://phabricator.wikimedia.org/T262947) (owner: 10Jdlrobson) [18:32:19] (03PS33) 10Dbarratt: Handle CORS preflight request and prevent anon users from unsafe methods [core] - 10https://gerrit.wikimedia.org/r/621900 (https://phabricator.wikimedia.org/T232176) [18:32:33] (03CR) 10Dbarratt: Handle CORS preflight request and prevent anon users from unsafe methods (0311 comments) [core] - 10https://gerrit.wikimedia.org/r/621900 (https://phabricator.wikimedia.org/T232176) (owner: 10Dbarratt) [18:33:16] (03CR) 10DannyS712: [C: 03+2] Do not call SpecialBlock::canBlockEmail in ApiBlock [core] - 10https://gerrit.wikimedia.org/r/628505 (https://phabricator.wikimedia.org/T263327) (owner: 10Urbanecm) [18:35:37] (03CR) 10Daimona Eaytoy: Add a value object to represent filters (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628488 (owner: 10Daimona Eaytoy) [18:36:01] (03CR) 10Jforrester: Drop jquery.ui.touchpunch (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/628496 (https://phabricator.wikimedia.org/T262947) (owner: 10Jdlrobson) [18:36:07] (03CR) 10DannyS712: Add a value object to represent filters (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628488 (owner: 10Daimona Eaytoy) [18:38:05] (03CR) 10jerkins-bot: [V: 04-1] Introduce backend class for blocking users [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) (owner: 10Urbanecm) [18:39:12] (03PS2) 10Ladsgroup: Migrate ipblocks_restrictions to abstract schema [core] - 10https://gerrit.wikimedia.org/r/628245 (https://phabricator.wikimedia.org/T230428) [18:39:14] (03PS1) 10Ladsgroup: Migrate ip_changes to abstract schema [core] - 10https://gerrit.wikimedia.org/r/628517 (https://phabricator.wikimedia.org/T230428) [18:39:25] 10MediaWiki-API, 10MediaWiki-extensions-FlaggedRevs, 10Community-Tech, 10Expiring-Watchlist-Items, 10Platform Engineering: Add watchlist expiry support to FlaggedRevs' stabilize API - https://phabricator.wikimedia.org/T263336 (10Amorymeltzer) [18:39:49] (03CR) 10DannyS712: "Yay, tests added in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/628377 demonstrate the bug in the ApiBlock changes" [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) (owner: 10Urbanecm) [18:40:15] 10MediaWiki-API, 10MediaWiki-extensions-FlaggedRevs, 10Community-Tech, 10Expiring-Watchlist-Items, 10Platform Engineering: Add watchlist expiry support to FlaggedRevs' stabilize API - https://phabricator.wikimedia.org/T263336 (10Amorymeltzer) [18:40:19] 10MediaWiki-API, 10Community-Tech, 10Expiring-Watchlist-Items: Add expiry support to remaining APIs that watch pages - https://phabricator.wikimedia.org/T248407 (10Amorymeltzer) [18:40:21] 10InternetArchiveBot: Deploy InternetArchiveBot on the Burmese Wikipedia (mywiki) - https://phabricator.wikimedia.org/T208701 (10Nintendofan885) 05Open→03Resolved a:03Cyberpower678 Now has a flag [18:41:25] (03CR) 10DannyS712: "will need rebase, 2 nitpicks and a minor issue" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/628427 (https://phabricator.wikimedia.org/T263189) (owner: 10Urbanecm) [18:41:59] (03CR) 10Ladsgroup: "check postgres" [core] - 10https://gerrit.wikimedia.org/r/628517 (https://phabricator.wikimedia.org/T230428) (owner: 10Ladsgroup) [18:46:03] 10MediaWiki-extensions-CentralNotice, 10Technical-Debt: Unused regex consts - https://phabricator.wikimedia.org/T263335 (10Reedy) [18:46:33] (03PS174) 10Urbanecm: Introduce backend class for blocking users [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) [18:48:11] (03CR) 10Urbanecm: Introduce backend class for blocking users (035 comments) [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) (owner: 10Urbanecm) [18:48:13] (03CR) 10Ladsgroup: [C: 04-1] Migrate ip_changes to abstract schema [core] - 10https://gerrit.wikimedia.org/r/628517 (https://phabricator.wikimedia.org/T230428) (owner: 10Ladsgroup) [18:48:26] (03PS1) 10Reedy: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/Collection] - 10https://gerrit.wikimedia.org/r/628518 (https://phabricator.wikimedia.org/T253169) [18:48:37] (03Merged) 10jenkins-bot: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/628502 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [18:48:39] (03Merged) 10jenkins-bot: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/628504 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [18:48:41] (03Merged) 10jenkins-bot: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/628495 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [18:55:37] (03PS1) 10Reedy: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/Echo] - 10https://gerrit.wikimedia.org/r/628520 (https://phabricator.wikimedia.org/T253169) [18:55:58] 10Dumps-Generation, 10Patch-For-Review: for xml/sql dumps, make the means of finding the next wiki to dump cheaper - https://phabricator.wikimedia.org/T263323 (10ArielGlenn) The above patch was extensively tested before pushing to gerrit. I'll merge it tonight and it will be in effect tomorrow, easing the pres... [18:58:09] (03CR) 10Ppchelko: [C: 03+1] Handle CORS preflight request and prevent anon users from unsafe methods [core] - 10https://gerrit.wikimedia.org/r/621900 (https://phabricator.wikimedia.org/T232176) (owner: 10Dbarratt) [18:59:49] (03CR) 10jerkins-bot: [V: 04-1] Migrate ip_changes to abstract schema [core] - 10https://gerrit.wikimedia.org/r/628517 (https://phabricator.wikimedia.org/T230428) (owner: 10Ladsgroup) [19:00:13] (03Merged) 10jenkins-bot: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/628498 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [19:00:18] (03Merged) 10jenkins-bot: Deprecate SpecialBlock::checkUnblockSelf [core] - 10https://gerrit.wikimedia.org/r/628429 (https://phabricator.wikimedia.org/T263326) (owner: 10Urbanecm) [19:00:24] (03Merged) 10jenkins-bot: Do not call SpecialBlock::canBlockEmail in ApiBlock [core] - 10https://gerrit.wikimedia.org/r/628505 (https://phabricator.wikimedia.org/T263327) (owner: 10Urbanecm) [19:00:41] 10MediaWiki-General, 10MediaWiki-extensions-CentralNotice, 10MediaWiki-extensions-Newsletter, 10MediaWiki-extensions-OAuth, and 25 others: Clean up PSR12.Properties.ConstantVisibility.NotFound phpcs exclusion in WMF Prod - https://phabricator.wikimedia.org/T253169 (10Reedy) [19:05:29] 10Wikimedia-Site-requests: Remove Wikipedia store link from enwiki - https://phabricator.wikimedia.org/T262329 (10Evrifaessa) p:05Triage→03Medium a:03Evrifaessa LGTM. I'll directly remove `'enwiki' => true` from `wmgUseWikimediaShopLink` since the default value is false. [19:05:57] (03CR) 10Jforrester: [C: 03+2] Fix PSR12.Properties.ConstantVisibility.NotFound [libs/WaitConditionLoop] - 10https://gerrit.wikimedia.org/r/628380 (https://phabricator.wikimedia.org/T253185) (owner: 10Reedy) [19:06:38] (03Merged) 10jenkins-bot: Fix PSR12.Properties.ConstantVisibility.NotFound [libs/WaitConditionLoop] - 10https://gerrit.wikimedia.org/r/628380 (https://phabricator.wikimedia.org/T253185) (owner: 10Reedy) [19:06:41] (03CR) 10Jforrester: [C: 03+2] Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/Collection] - 10https://gerrit.wikimedia.org/r/628518 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [19:07:08] (03CR) 10Jforrester: Fix PSR12.Properties.ConstantVisibility.NotFound (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/628520 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [19:07:48] (03CR) 10Jforrester: [C: 03+2] Updating brick/math (0.8.15 => 0.8.17) [vendor] - 10https://gerrit.wikimedia.org/r/628492 (owner: 10Reedy) [19:08:03] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Epic, 10Tracking-Neverending: [Epic] data quality and trust - https://phabricator.wikimedia.org/T76230 (10abian) [19:08:52] (03CR) 10jerkins-bot: [V: 04-1] Remove/fix phpcs exclusions [libs/WaitConditionLoop] - 10https://gerrit.wikimedia.org/r/628381 (owner: 10Reedy) [19:10:06] (03Merged) 10jenkins-bot: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/Collection] - 10https://gerrit.wikimedia.org/r/628518 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [19:10:30] (03PS4) 10Reedy: Remove/fix phpcs exclusions [libs/WaitConditionLoop] - 10https://gerrit.wikimedia.org/r/628381 [19:10:59] (03CR) 10jerkins-bot: [V: 04-1] Remove/fix phpcs exclusions [libs/WaitConditionLoop] - 10https://gerrit.wikimedia.org/r/628381 (owner: 10Reedy) [19:11:29] (03PS5) 10Reedy: Remove/fix phpcs exclusions [libs/WaitConditionLoop] - 10https://gerrit.wikimedia.org/r/628381 [19:11:56] (03CR) 10jerkins-bot: [V: 04-1] Remove/fix phpcs exclusions [libs/WaitConditionLoop] - 10https://gerrit.wikimedia.org/r/628381 (owner: 10Reedy) [19:15:29] (03PS175) 10Urbanecm: Introduce backend class for blocking users [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) [19:15:31] (03PS6) 10Reedy: Remove/fix phpcs exclusions [libs/WaitConditionLoop] - 10https://gerrit.wikimedia.org/r/628381 [19:16:15] (03CR) 10jerkins-bot: [V: 04-1] Remove/fix phpcs exclusions [libs/WaitConditionLoop] - 10https://gerrit.wikimedia.org/r/628381 (owner: 10Reedy) [19:17:14] (03PS7) 10Reedy: Remove/fix phpcs exclusions [libs/WaitConditionLoop] - 10https://gerrit.wikimedia.org/r/628381 [19:17:25] 10Wikimedia-Site-requests, 10Patch-For-Review: Remove Wikipedia store link from enwiki - https://phabricator.wikimedia.org/T262329 (10Evrifaessa) I uploaded the patch, but don't really know if this is the real solution. Default value is false, and trwiki is not explicitly stated as true, but it seems like it h... [19:17:45] 10InternetArchiveBot: IABot reports blacklist link in article causes failure, but cannot find any - https://phabricator.wikimedia.org/T263332 (10Cyberpower678) 05Open→03Invalid Sorry but this is not an issue I can fix. That message is produced by Wikipedia itself, so the tool doesn't know what URL is actual... [19:17:46] (03CR) 10jerkins-bot: [V: 04-1] Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/Echo] - 10https://gerrit.wikimedia.org/r/628520 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [19:17:49] (03CR) 10jerkins-bot: [V: 04-1] Remove/fix phpcs exclusions [libs/WaitConditionLoop] - 10https://gerrit.wikimedia.org/r/628381 (owner: 10Reedy) [19:20:20] (03PS3) 10Umherirrender: Avoid shadowed variables in javascript [extensions/Popups] - 10https://gerrit.wikimedia.org/r/628424 [19:20:23] 10InternetArchiveBot: IABot reports blacklist link in article causes failure, but cannot find any - https://phabricator.wikimedia.org/T263332 (10Cyberpower678) I went ahead and looked at your spam log and found this: 18:47, 18 September 2020 Normal Op talk contribs block caused a spam blacklist hit on Horse mea... [19:22:36] (03PS8) 10Reedy: Remove/fix phpcs exclusions [libs/WaitConditionLoop] - 10https://gerrit.wikimedia.org/r/628381 [19:23:04] (03CR) 10jerkins-bot: [V: 04-1] Remove/fix phpcs exclusions [libs/WaitConditionLoop] - 10https://gerrit.wikimedia.org/r/628381 (owner: 10Reedy) [19:25:35] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Epic, 10Tracking-Neverending: [Epic] data quality and trust - https://phabricator.wikimedia.org/T76230 (10abian) [19:25:39] (03CR) 10jerkins-bot: [V: 04-1] Avoid shadowed variables in javascript [extensions/Popups] - 10https://gerrit.wikimedia.org/r/628424 (owner: 10Umherirrender) [19:27:10] (03PS9) 10Reedy: Remove/fix phpcs exclusions [libs/WaitConditionLoop] - 10https://gerrit.wikimedia.org/r/628381 [19:28:28] 10MediaWiki-Recent-changes, 10Growth-Team, 10User-Urbanecm: IRCColourfulRCFeedFormatter ignores bot flag for log entries - https://phabricator.wikimedia.org/T251716 (10Urbanecm) 05Open→03Declined [19:31:07] (03Merged) 10jenkins-bot: Updating brick/math (0.8.15 => 0.8.17) [vendor] - 10https://gerrit.wikimedia.org/r/628492 (owner: 10Reedy) [19:34:55] (03CR) 10Physikerwelt: "check experimental" [services/texvcjs] - 10https://gerrit.wikimedia.org/r/628036 (owner: 10Physikerwelt) [19:36:17] (03PS34) 10Ppchelko: Handle CORS preflight request and prevent anon users from unsafe methods [core] - 10https://gerrit.wikimedia.org/r/621900 (https://phabricator.wikimedia.org/T232176) (owner: 10Dbarratt) [19:36:19] (03PS1) 10Ppchelko: Introduce CompoundAuthorizer to pass multiple authorizers [core] - 10https://gerrit.wikimedia.org/r/628524 [19:37:21] (03CR) 10Physikerwelt: "check experimental" [services/texvcjs] - 10https://gerrit.wikimedia.org/r/628036 (owner: 10Physikerwelt) [19:38:12] (03CR) 10jerkins-bot: [V: 04-1] Introduce backend class for blocking users [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) (owner: 10Urbanecm) [19:40:56] (03PS1) 10Umherirrender: Inject services into SpecialMergeHistory [core] - 10https://gerrit.wikimedia.org/r/628525 (https://phabricator.wikimedia.org/T259960) [19:42:26] (03CR) 10jerkins-bot: [V: 04-1] Remove/fix phpcs exclusions [CLDRPluralRuleParser] - 10https://gerrit.wikimedia.org/r/628383 (owner: 10Reedy) [19:42:28] 10Wikimedia-Site-requests: Allow for interwiki redirects from pl.wikimedia.org - https://phabricator.wikimedia.org/T261508 (10Evrifaessa) 05Open→03Declined This task hasn't received an answer in nearly 2 weeks. As per @Urbanecm, I'm closing this as not actionable. [19:44:17] (03CR) 10Physikerwelt: [C: 03+2] "thank you" [extensions/Math] - 10https://gerrit.wikimedia.org/r/628491 (owner: 10Umherirrender) [19:46:02] (03PS5) 10Reedy: Remove/fix phpcs exclusions [CLDRPluralRuleParser] - 10https://gerrit.wikimedia.org/r/628383 [19:46:35] (03CR) 10jerkins-bot: [V: 04-1] Remove/fix phpcs exclusions [CLDRPluralRuleParser] - 10https://gerrit.wikimedia.org/r/628383 (owner: 10Reedy) [19:46:37] (03PS6) 10Reedy: Remove/fix phpcs exclusions [CLDRPluralRuleParser] - 10https://gerrit.wikimedia.org/r/628383 [19:46:39] (03CR) 10Physikerwelt: [C: 03+2] Avoid shadowed variables in javascript [extensions/Math] - 10https://gerrit.wikimedia.org/r/628422 (owner: 10Umherirrender) [19:47:25] (03CR) 10jerkins-bot: [V: 04-1] Remove/fix phpcs exclusions [CLDRPluralRuleParser] - 10https://gerrit.wikimedia.org/r/628383 (owner: 10Reedy) [19:48:01] (03PS11) 10Pastakhov: Refactor the source code v5.0 [extensions/AccessControl] - 10https://gerrit.wikimedia.org/r/627603 [19:48:48] (03PS7) 10Reedy: Remove/fix phpcs exclusions [CLDRPluralRuleParser] - 10https://gerrit.wikimedia.org/r/628383 [19:49:25] (03CR) 10jerkins-bot: [V: 04-1] Remove/fix phpcs exclusions [CLDRPluralRuleParser] - 10https://gerrit.wikimedia.org/r/628383 (owner: 10Reedy) [19:49:39] (03CR) 10jerkins-bot: [V: 04-1] Refactor the source code v5.0 [extensions/AccessControl] - 10https://gerrit.wikimedia.org/r/627603 (owner: 10Pastakhov) [19:51:08] (03Abandoned) 10Urbanecm: Do not call SpecialBlock::canBlockEmail from CheckUser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/628506 (https://phabricator.wikimedia.org/T263334) (owner: 10Urbanecm) [19:51:38] (03PS12) 10Pastakhov: Refactor the source code v5.0 [extensions/AccessControl] - 10https://gerrit.wikimedia.org/r/627603 [19:54:27] (03PS8) 10Reedy: Remove/fix some phpcs exclusions [CLDRPluralRuleParser] - 10https://gerrit.wikimedia.org/r/628383 [19:55:21] (03PS176) 10Urbanecm: Introduce backend class for blocking users [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) [19:55:43] 10CX-mobile, 10SectionTranslation, 10Language-Team (Language-2020-July-September), 10MW-1.36-notes (1.36.0-wmf.10; 2020-09-22): Edit a sentence: Load the translation with Mobile VE - https://phabricator.wikimedia.org/T259506 (10Jpita) @ngkountas how do I arrive at that screen? the "Edit translation" button... [20:02:26] (03CR) 10jerkins-bot: [V: 04-1] Introduce CompoundAuthorizer to pass multiple authorizers [core] - 10https://gerrit.wikimedia.org/r/628524 (owner: 10Ppchelko) [20:03:16] (03Merged) 10jenkins-bot: Fix mathoid test data for last changes to renderer [extensions/Math] - 10https://gerrit.wikimedia.org/r/628491 (owner: 10Umherirrender) [20:05:10] (03Merged) 10jenkins-bot: Avoid shadowed variables in javascript [extensions/Math] - 10https://gerrit.wikimedia.org/r/628422 (owner: 10Umherirrender) [20:14:19] 10SectionTranslation, 10Language-Team (Language-2020-July-September), 10MW-1.36-notes (1.36.0-wmf.9; 2020-09-15), 10Patch-For-Review: Line height issues partially crop text in Section Translation workflow - https://phabricator.wikimedia.org/T259016 (10Jpita) why does (1) have the sections translated and (2... [20:20:03] (03PS1) 10Umherirrender: Inject services into SpecialAllMessages [core] - 10https://gerrit.wikimedia.org/r/628528 (https://phabricator.wikimedia.org/T259960) [20:20:05] 10MediaWiki-General: XMPReader PHPUnit warnings - https://phabricator.wikimedia.org/T263338 (10Reedy) [20:22:25] (03PS6) 10Reedy: Remove/fix phpcs exclusions [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/628385 [20:23:01] (03CR) 10jerkins-bot: [V: 04-1] Remove/fix phpcs exclusions [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/628385 (owner: 10Reedy) [20:24:33] 10XMPReader: XMPReader PHPUnit warnings - https://phabricator.wikimedia.org/T263338 (10Reedy) [20:25:29] 10MediaWiki-File-management, 10Commons, 10XMPReader, 10MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), and 2 others: XMPReader::parse exceptions - https://phabricator.wikimedia.org/T118799 (10Reedy) [20:25:36] 10XMPReader, 10Security: XMPReader::checkParseSafely requires allow_url_fopen to be set enabled - https://phabricator.wikimedia.org/T116701 (10Reedy) [20:26:51] (03PS1) 10Umherirrender: Do not create TitleValue when calling LinkBatch in CategoryPager [core] - 10https://gerrit.wikimedia.org/r/628529 [20:27:16] (03PS7) 10Reedy: Remove/fix phpcs exclusions [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/628385 [20:36:48] (03PS1) 10Umherirrender: Add missing indent in some special page pagers [core] - 10https://gerrit.wikimedia.org/r/628530 [20:40:29] (03CR) 10Amorymeltzer: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/628548 (owner: 10Amorymeltzer) [20:46:04] (03PS3) 10DannyS712: Fix typo 'Watchlst' in `apihelp-edit-param-watchlistexpiry` [core] - 10https://gerrit.wikimedia.org/r/628548 (https://phabricator.wikimedia.org/T201491) (owner: 10Amorymeltzer) [20:46:16] (03CR) 10DannyS712: [C: 03+2] Fix typo 'Watchlst' in `apihelp-edit-param-watchlistexpiry` [core] - 10https://gerrit.wikimedia.org/r/628548 (https://phabricator.wikimedia.org/T201491) (owner: 10Amorymeltzer) [20:47:29] (03CR) 10DannyS712: [C: 03+2] "@Amorymeltzer welcome and congrats on your first patch being merged" [core] - 10https://gerrit.wikimedia.org/r/628548 (https://phabricator.wikimedia.org/T201491) (owner: 10Amorymeltzer) [20:48:02] (03CR) 10DannyS712: [C: 03+1] Add missing indent in some special page pagers [core] - 10https://gerrit.wikimedia.org/r/628530 (owner: 10Umherirrender) [21:05:06] (03CR) 10jerkins-bot: [V: 04-1] Fix typo 'Watchlst' in `apihelp-edit-param-watchlistexpiry` [core] - 10https://gerrit.wikimedia.org/r/628548 (https://phabricator.wikimedia.org/T201491) (owner: 10Amorymeltzer) [21:06:36] (03PS2) 10Reedy: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/Echo] - 10https://gerrit.wikimedia.org/r/628520 (https://phabricator.wikimedia.org/T253169) [21:16:43] (03PS1) 10Umherirrender: Inject services into SpecialBlockList/SpecialAutoblockList [core] - 10https://gerrit.wikimedia.org/r/628533 (https://phabricator.wikimedia.org/T259960) [21:19:31] (03CR) 10jerkins-bot: [V: 04-1] Remove/fix some phpcs exclusions [utfnormal] - 10https://gerrit.wikimedia.org/r/628547 (owner: 10Reedy) [21:20:31] (03PS9) 10Reedy: Remove/fix some phpcs exclusions [utfnormal] - 10https://gerrit.wikimedia.org/r/628547 [21:21:24] (03PS6) 10Daimona Eaytoy: Reduce dependencies of AbuseFilter::saveFilter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628494 (https://phabricator.wikimedia.org/T213037) [21:21:34] (03CR) 10jerkins-bot: [V: 04-1] Remove/fix some phpcs exclusions [utfnormal] - 10https://gerrit.wikimedia.org/r/628547 (owner: 10Reedy) [21:21:48] (03PS7) 10Daimona Eaytoy: Reduce dependencies of AbuseFilter::saveFilter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628494 (https://phabricator.wikimedia.org/T213037) [21:22:55] (03PS10) 10Reedy: Remove/fix some phpcs exclusions [utfnormal] - 10https://gerrit.wikimedia.org/r/628547 [21:23:11] (03PS7) 10Daimona Eaytoy: Add a value object to represent filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628488 [21:24:44] (03CR) 10jerkins-bot: [V: 04-1] Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/Echo] - 10https://gerrit.wikimedia.org/r/628520 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [21:26:50] (03PS3) 10Reedy: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/Echo] - 10https://gerrit.wikimedia.org/r/628520 (https://phabricator.wikimedia.org/T253169) [21:30:09] 10SectionTranslation, 10Language-Team (Language-2020-July-September), 10MW-1.36-notes (1.36.0-wmf.9; 2020-09-15): Compare the contents: Show new section placeholder where the new section will be added - https://phabricator.wikimedia.org/T259492 (10Jpita) @ngkountas can you point me to where I can see this "n... [21:31:00] 10MediaWiki-General, 10MediaWiki-extensions-General, 10PHP 7.2 support, 10Technical-Debt: Clean up PSR12.Properties.ConstantVisibility.NotFound phpcs exclusion - https://phabricator.wikimedia.org/T237840 (10Reedy) [21:32:14] (03PS1) 10Reedy: Fix typo 'Watchlst' in `apihelp-edit-param-watchlistexpiry` [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/628551 (https://phabricator.wikimedia.org/T201491) [21:32:22] (03CR) 10Reedy: [C: 03+2] Fix typo 'Watchlst' in `apihelp-edit-param-watchlistexpiry` [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/628551 (https://phabricator.wikimedia.org/T201491) (owner: 10Reedy) [21:35:35] (03CR) 10jerkins-bot: [V: 04-1] Inject services into SpecialBlockList/SpecialAutoblockList [core] - 10https://gerrit.wikimedia.org/r/628533 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [21:38:08] 10MediaWiki-General, 10MediaWiki-extensions-CentralNotice, 10MediaWiki-extensions-Newsletter, 10MediaWiki-extensions-OAuth, and 23 others: Clean up PSR12.Properties.ConstantVisibility.NotFound phpcs exclusion in WMF Prod - https://phabricator.wikimedia.org/T253169 (10Reedy) [21:39:39] (03Merged) 10jenkins-bot: Fix typo 'Watchlst' in `apihelp-edit-param-watchlistexpiry` [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/628551 (https://phabricator.wikimedia.org/T201491) (owner: 10Reedy) [21:41:32] 10InternetArchiveBot: IABot reports blacklist link in article causes failure, but cannot find any - https://phabricator.wikimedia.org/T263332 (10NormalOp) Thank you. I removed that one citation (not mine; was there before) and it ran just fine! Thank you for directing me to my own spam blacklist logs; I didn't k... [21:41:35] (03PS2) 10Reedy: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/628501 (https://phabricator.wikimedia.org/T253169) [21:41:37] (03PS1) 10Reedy: Bump min MW version to 1.35.0 [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/628535 (https://phabricator.wikimedia.org/T263330) [21:41:39] (03PS1) 10Reedy: Remove/fix phpcs exclusions [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/628536 [21:42:11] (03CR) 10DannyS712: [C: 03+2] "flaky test: `WatchedItemStoreIntegrationTest::testDuplicateAllAssociatedEntries`" [core] - 10https://gerrit.wikimedia.org/r/628548 (https://phabricator.wikimedia.org/T201491) (owner: 10Amorymeltzer) [21:43:02] (03CR) 10jerkins-bot: [V: 04-1] Add a value object to represent filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628488 (owner: 10Daimona Eaytoy) [21:45:22] (03CR) 10DannyS712: Bump min MW version to 1.35.0 (031 comment) [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/628535 (https://phabricator.wikimedia.org/T263330) (owner: 10Reedy) [21:46:28] (03CR) 10jerkins-bot: [V: 04-1] Remove/fix phpcs exclusions [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/628536 (owner: 10Reedy) [21:49:05] (03PS2) 10Reedy: Remove/fix phpcs exclusions [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/628536 [21:51:31] (03PS3) 10Reedy: Remove/fix phpcs exclusions [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/628536 [21:51:36] (03CR) 10DannyS712: [C: 03+2] "No other uses found via codesearch" [CLDRPluralRuleParser] - 10https://gerrit.wikimedia.org/r/628382 (https://phabricator.wikimedia.org/T253185) (owner: 10Reedy) [21:51:49] 10Wikimedia-production-error: "Fatal Exception of Type InvalidArgumentException" when viewing pages with broken history caused by Special:MergeHistory - https://phabricator.wikimedia.org/T263340 (10Pppery) [21:52:17] (03Merged) 10jenkins-bot: Fix PSR12.Properties.ConstantVisibility.NotFound [CLDRPluralRuleParser] - 10https://gerrit.wikimedia.org/r/628382 (https://phabricator.wikimedia.org/T253185) (owner: 10Reedy) [21:53:30] (03CR) 10DannyS712: [C: 03+2] Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/628501 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [21:55:43] (03CR) 10DannyS712: [C: 03+1] "LGTM, 1 question" (031 comment) [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/628536 (owner: 10Reedy) [22:00:22] (03CR) 10DannyS712: "LGTM, 1 suggestion though" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/628520 (https://phabricator.wikimedia.org/T253169) (owner: 10Reedy) [22:02:57] (03Merged) 10jenkins-bot: Fix typo 'Watchlst' in `apihelp-edit-param-watchlistexpiry` [core] - 10https://gerrit.wikimedia.org/r/628548 (https://phabricator.wikimedia.org/T201491) (owner: 10Amorymeltzer) [22:03:15] (03CR) 10Reedy: Remove/fix phpcs exclusions (032 comments) [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/628536 (owner: 10Reedy) [22:10:55] (03CR) 10Daimona Eaytoy: "recheck" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628488 (owner: 10Daimona Eaytoy) [22:16:53] (03PS1) 10Daimona Eaytoy: [WIP] Introduce a service for saving filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628537 [22:25:11] 10CX-mobile, 10SectionTranslation, 10Language-Team (Language-2020-July-September), 10MW-1.36-notes (1.36.0-wmf.9; 2020-09-15): Pick a sentence: Card to display and apply MT - https://phabricator.wikimedia.org/T259502 (10Jpita) I can't reach this screen on mobile devices because I can't skip the tutorial sc... [22:32:00] (03PS1) 10Daimona Eaytoy: Move some misplaced AbuseFilterParser entry points [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628538 [22:38:55] (03PS2) 10Daimona Eaytoy: Move some misplaced AbuseFilterParser entry points [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628538 [22:40:11] (03CR) 10Daimona Eaytoy: "recheck" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628488 (owner: 10Daimona Eaytoy) [22:41:06] 10MediaWiki-Vendor, 10Performance-Team, 10WaitConditionLoop: Periodic MW Library releases (September 2020) - https://phabricator.wikimedia.org/T263341 (10Reedy) [22:44:33] 10MediaWiki-Revision-backend, 10Wikimedia-production-error: "Fatal Exception of Type InvalidArgumentException" when viewing pages with broken history caused by Special:MergeHistory - https://phabricator.wikimedia.org/T263340 (10Daimona) [22:44:47] (03PS1) 10Umherirrender: Inject services into SpecialContributions/SpecialDeletedContributions [core] - 10https://gerrit.wikimedia.org/r/628539 (https://phabricator.wikimedia.org/T259960) [22:48:24] 10MobileFrontend, 10Mobile: MobileFrontend displays second paragraph as first paragraph on dewiki (Moving article lead is broken) - https://phabricator.wikimedia.org/T263306 (10Chrisahn) A few more examples (in German): https://de.wikipedia.org/wiki/Wikipedia:Technik/Werkstatt#Mobile_Ansicht_vertauscht_Absätze... [22:49:19] (03PS2) 10Umherirrender: Inject services into SpecialBlockList/SpecialAutoblockList [core] - 10https://gerrit.wikimedia.org/r/628533 (https://phabricator.wikimedia.org/T259960) [22:53:14] 10MediaWiki-Vendor, 10Performance-Team, 10WaitConditionLoop, 10utfnormal: Periodic MW Library releases (September 2020) - https://phabricator.wikimedia.org/T263341 (10Reedy) [22:54:32] 10MediaWiki-Vendor, 10Performance-Team, 10WaitConditionLoop, 10utfnormal: Periodic MW Library releases (September 2020) - https://phabricator.wikimedia.org/T263341 (10Reedy) [22:57:01] (03CR) 10jerkins-bot: [V: 04-1] Move some misplaced AbuseFilterParser entry points [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628538 (owner: 10Daimona Eaytoy) [22:57:09] 10MediaWiki-Vendor, 10Performance-Team, 10WaitConditionLoop, 10utfnormal: Periodic MW Library releases (September 2020) - https://phabricator.wikimedia.org/T263341 (10Reedy) [23:00:00] (03CR) 10DannyS712: Inject services into SpecialContributions/SpecialDeletedContributions (036 comments) [core] - 10https://gerrit.wikimedia.org/r/628539 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [23:00:01] (03PS3) 10Umherirrender: Inject services into SpecialBlockList/SpecialAutoblockList [core] - 10https://gerrit.wikimedia.org/r/628533 (https://phabricator.wikimedia.org/T259960) [23:01:13] 10Inuka-Team (Kanban), 10KaiOS-Wikipedia-app (Language): Outline style broken in RTL language - https://phabricator.wikimedia.org/T260391 (10Jpita) This has broken the image selection: when selected, the image moves, sometimes to a different page. {F32356192} [23:01:30] (03PS2) 10Umherirrender: Inject services into SpecialContributions/SpecialDeletedContributions [core] - 10https://gerrit.wikimedia.org/r/628539 (https://phabricator.wikimedia.org/T259960) [23:05:05] (03PS8) 10Urbanecm: Introduce BlockUtils service [core] - 10https://gerrit.wikimedia.org/r/628427 (https://phabricator.wikimedia.org/T263189) [23:05:22] (03PS4) 10Umherirrender: Inject services into SpecialBlockList/SpecialAutoblockList [core] - 10https://gerrit.wikimedia.org/r/628533 (https://phabricator.wikimedia.org/T259960) [23:07:05] 10Timeless: Show short description for pages in search preview - https://phabricator.wikimedia.org/T263342 (10Motevets) [23:08:58] (03PS3) 10Daimona Eaytoy: Move some misplaced AbuseFilterParser entry points [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/628538 [23:12:37] (03CR) 10DannyS712: [C: 03+2] "Already included in release notes saying its deprecated. Per codesearch[1] no uses outside of core" [core] - 10https://gerrit.wikimedia.org/r/628126 (https://phabricator.wikimedia.org/T250020) (owner: 10Urbanecm) [23:13:52] (03CR) 10DannyS712: [C: 04-1] "This lowers code coverage for the class. Why do the uses need to be removed? Just use hideDeprecated" [core] - 10https://gerrit.wikimedia.org/r/628136 (https://phabricator.wikimedia.org/T250020) (owner: 10Urbanecm) [23:14:29] 10MobileFrontend, 10Mobile: MobileFrontend displays second paragraph as first paragraph on dewiki (Moving article lead is broken) - https://phabricator.wikimedia.org/T263306 (10Chrisahn) A similar problem on ruwiki was fixed in 2018: T188825 [23:17:26] (03PS8) 10Daimona Eaytoy: Introduce AbuseFilterParserFactory service [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/558112 [23:18:27] (03PS3) 10Umherirrender: Inject services into SpecialContributions/SpecialDeletedContributions [core] - 10https://gerrit.wikimedia.org/r/628539 (https://phabricator.wikimedia.org/T259960) [23:18:31] (03CR) 10Umherirrender: Inject services into SpecialContributions/SpecialDeletedContributions (036 comments) [core] - 10https://gerrit.wikimedia.org/r/628539 (https://phabricator.wikimedia.org/T259960) (owner: 10Umherirrender) [23:23:42] 10Toolforge (Software install/update): Add tr_TR.utf8 locale to ToolForge - https://phabricator.wikimedia.org/T263339 (10JJMC89) [23:29:59] (03PS4) 10Umherirrender: Inject services into SpecialContributions/SpecialDeletedContributions [core] - 10https://gerrit.wikimedia.org/r/628539 (https://phabricator.wikimedia.org/T259960) [23:35:29] (03PS4) 10Urbanecm: [tests] Remove SpecialUnblock::processUnblock calls in SpecialUnblockTest [core] - 10https://gerrit.wikimedia.org/r/628136 (https://phabricator.wikimedia.org/T250020) [23:36:50] (03CR) 10DannyS712: [tests] Remove SpecialUnblock::processUnblock calls in SpecialUnblockTest (031 comment) [core] - 10https://gerrit.wikimedia.org/r/628136 (https://phabricator.wikimedia.org/T250020) (owner: 10Urbanecm) [23:38:23] 10MediaWiki-Vendor, 10Project-Admins, 10User-DannyS712: Create component for `Assert` library - https://phabricator.wikimedia.org/T251076 (10DannyS712) >>! In T251076#6336855, @Aklapper wrote: > Makes sense to me; however wondering who are stewards of that extension (if existing) and what they think (as it t... [23:38:44] 10MediaWiki-General, 10MediaWiki-extensions-CentralNotice, 10MediaWiki-extensions-Newsletter, 10MediaWiki-extensions-OAuth, and 23 others: Clean up PSR12.Properties.ConstantVisibility.NotFound phpcs exclusion in WMF Prod - https://phabricator.wikimedia.org/T253169 (10Reedy) [23:39:43] 10MediaWiki-General, 10MediaWiki-extensions-CentralNotice, 10MediaWiki-extensions-Newsletter, 10MediaWiki-extensions-OAuth, and 22 others: Clean up PSR12.Properties.ConstantVisibility.NotFound phpcs exclusion in WMF Prod - https://phabricator.wikimedia.org/T253169 (10Reedy) [23:44:26] (03PS1) 10Reedy: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/ORES] - 10https://gerrit.wikimedia.org/r/628542 (https://phabricator.wikimedia.org/T253169) [23:49:05] (03PS1) 10Reedy: Fix PSR12.Properties.ConstantVisibility.NotFound [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/628543 (https://phabricator.wikimedia.org/T253169) [23:57:23] (03CR) 10DannyS712: [C: 03+1] "LGTM, not tested locally though (not set up with AF locally)" (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/558112 (owner: 10Daimona Eaytoy) [23:57:24] (03PS5) 10Urbanecm: [tests] Remove SpecialUnblock::processUnblock calls in SpecialUnblockTest [core] - 10https://gerrit.wikimedia.org/r/628136 (https://phabricator.wikimedia.org/T250020)