[00:02:58] (03CR) 10Krinkle: "Yep, already on it. Had to do https://gerrit.wikimedia.org/r/c/mediawiki/core/+/626436 first :)" [core] - 10https://gerrit.wikimedia.org/r/626497 (owner: 10Jdlrobson) [00:05:02] (03PS1) 10Tim Starling: Add NAME constant to all hook interfaces [core] - 10https://gerrit.wikimedia.org/r/626517 (https://phabricator.wikimedia.org/T258665) [00:06:29] (03CR) 10Krinkle: "Ah, Jon did so already at https://gerrit.wikimedia.org/r/c/mediawiki/core/+/626444 meanwhile." [core] - 10https://gerrit.wikimedia.org/r/626497 (owner: 10Jdlrobson) [00:07:43] (03CR) 10jerkins-bot: [V: 04-1] Add NAME constant to all hook interfaces [core] - 10https://gerrit.wikimedia.org/r/626517 (https://phabricator.wikimedia.org/T258665) (owner: 10Tim Starling) [00:11:06] 10InternetArchiveBot: Deploy InternetArchiveBot on the Dutch Wikinews (nlwikinews) - https://phabricator.wikimedia.org/T252354 (10Cyberpower678) Bot is ready for deployment. [00:13:07] (03CR) 10Dmaza: [C: 03+2] "Looks great. Thank you @Ammarpad" [core] - 10https://gerrit.wikimedia.org/r/624782 (https://phabricator.wikimedia.org/T262175) (owner: 10Ammarpad) [00:19:14] (03PS15) 10Tim Starling: Library for containerized shell execution (initial commit) [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/622707 (https://phabricator.wikimedia.org/T260330) [00:30:42] (03PS1) 10Tjones: Chip away at sonarQube complaints [search/glent] - 10https://gerrit.wikimedia.org/r/626522 [00:37:00] (03Merged) 10jenkins-bot: Remove requirement for ApiWatchlistTrait to be in ApiBase. [core] - 10https://gerrit.wikimedia.org/r/624782 (https://phabricator.wikimedia.org/T262175) (owner: 10Ammarpad) [00:44:50] 10InternetArchiveBot, 10Tamil-Sites: Adding Tamil wikipedia site into https://tools.wmflabs.org/iabot/index.php - https://phabricator.wikimedia.org/T227964 (10Cyberpower678) Bot is ready for deployment. Approval and bot flag required. [00:47:54] (03CR) 10MusikAnimal: [C: 03+2] Update ApiWatchlistTrait::getWatchlistValue() call to provide user [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/625574 (https://phabricator.wikimedia.org/T262175) (owner: 10Ammarpad) [00:48:39] 10Move-Files-To-Commons: FileImporter imports the file even when the target page is protected on Commons and the importer should not be able to create it - https://phabricator.wikimedia.org/T262628 (10Ahmad252) [00:49:24] 10GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: Variant C: onboarding - https://phabricator.wikimedia.org/T258016 (10Catrope) Some questions for @RHo from @kostajh's code review: - The mocks use two different images, a square one (128x128px) on desktop and a rectangular one (216x64)... [00:51:35] (03Merged) 10jenkins-bot: Update ApiWatchlistTrait::getWatchlistValue() call to provide user [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/625574 (https://phabricator.wikimedia.org/T262175) (owner: 10Ammarpad) [00:57:45] (03PS3) 10Huji: Support special character detection beyond PHP's built-in capabilty [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/625940 (https://phabricator.wikimedia.org/T262045) [00:57:48] (03PS4) 10Huji: Use triple equals in abuse filter parser tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/624785 (https://phabricator.wikimedia.org/T262063) [00:57:56] (03PS19) 10Huji: Let #time parser function accept absolute dates in localized form [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/614582 (https://phabricator.wikimedia.org/T21412) [00:58:04] (03PS8) 10Huji: Introduce searchFilters.php [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/626022 (https://phabricator.wikimedia.org/T262052) [01:02:36] 10InternetArchiveBot: Deploy InternetArchiveBot on the Danish Wikipedia (dawiki) - https://phabricator.wikimedia.org/T248260 (10Cyberpower678) Ready to deploy. Approval and bot flag required. [01:02:50] 10DiscussionTools, 10Editing-team (Tracking), 10OWC2020 (Reply Tool Opt Out): Announce Reply Tool opt-out deployment - https://phabricator.wikimedia.org/T262332 (10ppelberg) [01:03:06] 10InternetArchiveBot: Deploy InternetArchiveBot on the Azerbaijani Wikipedia (azwiki) - https://phabricator.wikimedia.org/T178817 (10Cyberpower678) Ready to deploy. Approval and bot flag required. [01:03:35] 10InternetArchiveBot: Deploy InternetArchiveBot on the Waray-Waray Wikipedia (warwiki) - https://phabricator.wikimedia.org/T169464 (10Cyberpower678) Ready to deploy. Approval and bot flag required. [01:04:07] 10InternetArchiveBot: Deploy InternetArchiveBot on the Polish Wikipedia (plwiki) - https://phabricator.wikimedia.org/T169465 (10Cyberpower678) Ready to deploy. Approval and bot flag required. [01:04:16] 10InternetArchiveBot: Deploy InternetArchiveBot on the Vietnamese Wikipedia (viwiki) - https://phabricator.wikimedia.org/T169466 (10Cyberpower678) Ready to deploy. Approval and bot flag required. [01:04:43] 10InternetArchiveBot: Deploy InternetArchiveBot on the Catalan Wikipedia (cawiki) - https://phabricator.wikimedia.org/T169469 (10Cyberpower678) Ready to deploy. Approval and bot flag required. [01:05:17] 10InternetArchiveBot: Deploy InternetArchiveBot on the Urdu Wikipedia (urwiki) - https://phabricator.wikimedia.org/T169477 (10Cyberpower678) Ready to deploy. Approval and bot flag required. [01:06:26] 10DiscussionTools, 10Editing QA, 10Editing-team (FY2020-21 Kanban Board), 10OWC2020 (Reply Tool Opt Out): Conduct Reply Tool pre-deployment QA - https://phabricator.wikimedia.org/T261477 (10ppelberg) [01:18:04] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10OWC2020 (Reply Tool Opt Out), 10Patch-For-Review: Create setting(s) for the Reply Tool within Special:Preferences - https://phabricator.wikimedia.org/T259943 (10ppelberg) >>! In T259943#6450465, @Esanders wrote: > I have tweaked this slightly.... [01:18:44] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10OWC2020 (Reply Tool Opt Out), 10Patch-For-Review: Create setting(s) for the Reply Tool within Special:Preferences - https://phabricator.wikimedia.org/T259943 (10ppelberg) [01:21:49] (03PS1) 10Reedy: RELEASE-NOTES-1.35: Remove empty sections [core] - 10https://gerrit.wikimedia.org/r/626525 (https://phabricator.wikimedia.org/T259349) [01:22:45] (03CR) 10Reedy: [C: 03+2] RELEASE-NOTES-1.35: Remove empty sections [core] - 10https://gerrit.wikimedia.org/r/626525 (https://phabricator.wikimedia.org/T259349) (owner: 10Reedy) [01:22:53] (03PS1) 10Reedy: RELEASE-NOTES-1.35: Remove empty sections [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/626445 (https://phabricator.wikimedia.org/T259349) [01:23:03] (03CR) 10Reedy: [C: 03+2] RELEASE-NOTES-1.35: Remove empty sections [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/626445 (https://phabricator.wikimedia.org/T259349) (owner: 10Reedy) [01:31:01] (03Merged) 10jenkins-bot: RELEASE-NOTES-1.35: Remove empty sections [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/626445 (https://phabricator.wikimedia.org/T259349) (owner: 10Reedy) [01:31:31] 10MediaWiki-General: Implement "smart" custom toggles which act based on their state (collapsed, partial or expanded) in the makeCollapsible plugin - https://phabricator.wikimedia.org/T262622 (10Reedy) [01:41:54] 10Reading-Web-Local-Wiki-Issues: Work with community to fix faulty gadgets triggering JS errors - https://phabricator.wikimedia.org/T259385 (10IKhitron) Well, I think you can find them using regular wikisearch. And yes, I did fix it once on #mediawiki-extensions-globalwatchlist. [01:42:24] (03Merged) 10jenkins-bot: RELEASE-NOTES-1.35: Remove empty sections [core] - 10https://gerrit.wikimedia.org/r/626525 (https://phabricator.wikimedia.org/T259349) (owner: 10Reedy) [01:51:47] 10Discovery-Search: ProductionServices.php has cloudelastic-{psi,omega}-eqiad ports mixed up - https://phabricator.wikimedia.org/T262630 (10EBernhardson) [01:56:01] (03PS16) 10Tim Starling: Library for containerized shell execution (initial commit) [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/622707 (https://phabricator.wikimedia.org/T260330) [01:58:07] (03CR) 10Tim Starling: "PS14/15:" [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/622707 (https://phabricator.wikimedia.org/T260330) (owner: 10Tim Starling) [02:13:03] (03CR) 10Ebernhardson: Modify M0 Scoring and Score Combination (031 comment) [search/glent] - 10https://gerrit.wikimedia.org/r/626225 (https://phabricator.wikimedia.org/T238151) (owner: 10Tjones) [02:15:07] (03CR) 10Ebernhardson: [C: 03+2] Add option to use ICU tokenization for query normalization [search/glent] - 10https://gerrit.wikimedia.org/r/626494 (https://phabricator.wikimedia.org/T238151) (owner: 10Tjones) [02:17:32] (03Merged) 10jenkins-bot: Add option to use ICU tokenization for query normalization [search/glent] - 10https://gerrit.wikimedia.org/r/626494 (https://phabricator.wikimedia.org/T238151) (owner: 10Tjones) [02:19:13] (03CR) 10Ebernhardson: [C: 03+2] Chip away at sonarQube complaints [search/glent] - 10https://gerrit.wikimedia.org/r/626522 (owner: 10Tjones) [02:20:55] (03Merged) 10jenkins-bot: Chip away at sonarQube complaints [search/glent] - 10https://gerrit.wikimedia.org/r/626522 (owner: 10Tjones) [02:47:48] 10InternetArchiveBot: Deploy InternetArchiveBot on the Dutch Wikinews (nlwikinews) - https://phabricator.wikimedia.org/T252354 (10Cyberpower678) 05Open→03Resolved [02:49:15] 10InternetArchiveBot: Deploy InternetArchiveBot on the Armenian Wikipedia (hywiki) - https://phabricator.wikimedia.org/T261808 (10Cyberpower678) 05Open→03Resolved a:03Cyberpower678 [02:49:18] 10Internet-Archive, 10Tracking-Neverending: Add IABot support for other wikis (tracking) - https://phabricator.wikimedia.org/T136130 (10Cyberpower678) [02:50:36] 10Internet-Archive, 10InternetArchiveBot: Deploy InternetArchiveBot on the Croatian Wikipedia (hrwiki) - https://phabricator.wikimedia.org/T234166 (10Cyberpower678) 05Open→03Resolved a:03Cyberpower678 [02:56:46] (03PS1) 10Dmaza: Remove requirement for ApiWatchlistTrait to be in ApiBase. [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/626526 (https://phabricator.wikimedia.org/T262175) [03:04:20] (03PS1) 10Samwilson: Add days left data to changes-lists' clock icons [core] - 10https://gerrit.wikimedia.org/r/626546 (https://phabricator.wikimedia.org/T261415) [03:05:57] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Campsite: Wikidata UI "Value" field is one character wide and covered by "Remove" button at certain screen resolutions - https://phabricator.wikimedia.org/T259183 (10PKM) This problem seems have disappeared... [03:11:14] 10DiscussionTools, 10Wikimedia-Site-requests, 10Editing-team (FY2020-21 Kanban Board): Enable DiscussionTools on jawiki - https://phabricator.wikimedia.org/T261654 (10patilise) [03:13:20] 10InternetArchiveBot: Deploy InternetArchiveBot on the Azerbaijani Wikipedia (azwiki) - https://phabricator.wikimedia.org/T178817 (10Cyberpower678) https://az.wikipedia.org/wiki/Vikipediya:Botlar#InternetArchiveBot Approval request [03:15:46] (03CR) 10MusikAnimal: [C: 03+2] Remove requirement for ApiWatchlistTrait to be in ApiBase. [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/626526 (https://phabricator.wikimedia.org/T262175) (owner: 10Dmaza) [03:17:55] (03CR) 10DVrandecic: [C: 03+2] tests: Split out ZObjectContentHandler test into own file [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/626347 (owner: 10Jforrester) [03:19:00] 10InternetArchiveBot: Deploy InternetArchiveBot on the Azerbaijani Wikipedia (azwiki) - https://phabricator.wikimedia.org/T178817 (10Cyberpower678) Approval request https://ca.wikipedia.org/wiki/Viquip%C3%A8dia:Petici%C3%B3_de_marca_de_bot#InternetArchiveBot [03:19:33] (03PS17) 10Tim Starling: Library for containerized shell execution (initial commit) [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/622707 (https://phabricator.wikimedia.org/T260330) [03:21:07] (03CR) 10Tim Starling: "PS16:" [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/622707 (https://phabricator.wikimedia.org/T260330) (owner: 10Tim Starling) [03:22:06] (03CR) 10DVrandecic: [C: 03+2] ZMultiLingualString: Get coverage up to 100% [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/625874 (owner: 10Jforrester) [03:22:29] (03Merged) 10jenkins-bot: Remove requirement for ApiWatchlistTrait to be in ApiBase. [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/626526 (https://phabricator.wikimedia.org/T262175) (owner: 10Dmaza) [03:26:18] (03CR) 10DVrandecic: [C: 03+2] Various fixes for basic ZPersistentObjects [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/626344 (owner: 10Jforrester) [03:29:58] (03Merged) 10jenkins-bot: Various fixes for basic ZPersistentObjects [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/626344 (owner: 10Jforrester) [03:30:09] (03PS1) 10Dmaza: Remove the loading background image for loading class [skins/Vector] (REL1_35) - 10https://gerrit.wikimedia.org/r/626529 (https://phabricator.wikimedia.org/T259053) [03:31:08] (03Merged) 10jenkins-bot: tests: Split out ZObjectContentHandler test into own file [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/626347 (owner: 10Jforrester) [03:31:10] (03Merged) 10jenkins-bot: ZMultiLingualString: Get coverage up to 100% [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/625874 (owner: 10Jforrester) [03:33:32] (03CR) 10DVrandecic: [C: 03+1] "Fine with this, seems to have a little bit of work still open, so +1'ing for now instead of merging." (032 comments) [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/625916 (https://phabricator.wikimedia.org/T260751) (owner: 10Jforrester) [03:36:32] (03PS1) 10Cicalese: Use OOUI for user menu and add icon to ULS menu item [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/626547 (https://phabricator.wikimedia.org/T260630) [03:37:42] (03CR) 10jerkins-bot: [V: 04-1] Use OOUI for user menu and add icon to ULS menu item [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/626547 (https://phabricator.wikimedia.org/T260630) (owner: 10Cicalese) [03:39:35] (03PS1) 10Tim Starling: [WIP] Use Shellbox for Shell::command() etc. [core] - 10https://gerrit.wikimedia.org/r/626548 (https://phabricator.wikimedia.org/T260330) [03:39:44] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Use Shellbox for Shell::command() etc. [core] - 10https://gerrit.wikimedia.org/r/626548 (https://phabricator.wikimedia.org/T260330) (owner: 10Tim Starling) [03:39:51] (03PS1) 10Samwilson: Add message to watchlist on clicking the clock icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/626549 (https://phabricator.wikimedia.org/T261415) [03:40:37] (03CR) 10MusikAnimal: [C: 03+2] Remove the loading background image for loading class [skins/Vector] (REL1_35) - 10https://gerrit.wikimedia.org/r/626529 (https://phabricator.wikimedia.org/T259053) (owner: 10Dmaza) [03:42:55] (03CR) 10Tim Starling: Library for containerized shell execution (initial commit) (031 comment) [libs/Shellbox] - 10https://gerrit.wikimedia.org/r/622707 (https://phabricator.wikimedia.org/T260330) (owner: 10Tim Starling) [03:43:00] (03PS1) 10Dmaza: Watchlist: Fix updateWatchLink removing css class when action=watch [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/626530 (https://phabricator.wikimedia.org/T259053) [03:44:05] (03Merged) 10jenkins-bot: Remove the loading background image for loading class [skins/Vector] (REL1_35) - 10https://gerrit.wikimedia.org/r/626529 (https://phabricator.wikimedia.org/T259053) (owner: 10Dmaza) [03:56:41] (03PS1) 10Dmaza: mediawiki.notification: Don't close notif when clicking element [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/626532 (https://phabricator.wikimedia.org/T261901) (owner: 10Dmaza) [05:05:55] (03CR) 10MusikAnimal: [C: 03+2] Watchlist: Fix updateWatchLink removing css class when action=watch [core] (REL1_35) - 10https://gerrit.wikimedia.org/r/626530 (https://phabricator.wikimedia.org/T259053) (owner: 10Dmaza) [05:12:29] (03Merged) 10jenkins-bot: mediawiki.notification: Don't close notif when clicking