[00:05:59] 10DiscussionTools, 10Editing-team (Tracking): [SPIKE] How many accounts have email addresses associated with them? - https://phabricator.wikimedia.org/T262104 (10ppelberg) [00:06:24] 10DiscussionTools: Prompt people to enter an email address as part of the replying and new discussion workflows - https://phabricator.wikimedia.org/T262103 (10ppelberg) [00:07:46] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt to 1.3.0 [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/624973 (owner: 10Libraryupgrader) [00:11:09] 10Wikimedia Chat: Bot to transfer messages between Wikimedia Chat and IRC - https://phabricator.wikimedia.org/T262034 (10Ladsgroup) What channels? Wikidata in chat to `#wikidata` in freenode? We need to have a central place maintained by the community to keep the configuration. [00:12:35] (03CR) 10Shirayuki: "This patch is for consistency with other extensions." [extensions/HAWelcome] - 10https://gerrit.wikimedia.org/r/617780 (owner: 10Shirayuki) [00:15:11] (03PS1) 10Dzahn: fix links and updates for gamepedias, opensuse [debs/wikistats] - 10https://gerrit.wikimedia.org/r/624980 (https://phabricator.wikimedia.org/T262064) [00:16:24] 10MobileFrontend, 10MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2020-21-Q1): Thumbnails inside tables, galleries and wrapping containers are not moved triggering log warnings - https://phabricator.wikimedia.org/T261993 (10Mhurd) @Jdlrobson Should I re-tes... [00:17:16] 10MobileFrontend, 10MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2020-21-Q1): Thumbnails inside tables, galleries and wrapping containers are not moved triggering log warnings - https://phabricator.wikimedia.org/T261993 (10Mhurd) a:05Edtadros→03Mhurd [00:18:05] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10OWC2020 (New Discussion 1.0), 10Patch-For-Review: Create a demo widget for starting new discussions - https://phabricator.wikimedia.org/T260335 (10ppelberg) 05Open→03Resolved [00:18:05] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board): New Discussion Tool V1.0: Engineering - https://phabricator.wikimedia.org/T259561 (10ppelberg) [00:20:07] (03PS1) 10Cicalese: Change direction on header shadow [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/624983 (https://phabricator.wikimedia.org/T260299) [00:22:06] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10OWC2020 (New Discussion 1.0): [SPIKE] How will the New Discussion Tool be made to support preloaded discussion templates - https://phabricator.wikimedia.org/T250768 (10ppelberg) [00:23:11] (03CR) 10DannyS712: [C: 03+2] build: Updating npm dependencies [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/624964 (owner: 10Libraryupgrader) [00:23:55] (03PS10) 10Dbarratt: Handle CORS preflight request and prevent anon users from unsafe methods [core] - 10https://gerrit.wikimedia.org/r/621900 (https://phabricator.wikimedia.org/T232176) [00:23:55] (03CR) 10jerkins-bot: [V: 04-1] Change direction on header shadow [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/624983 (https://phabricator.wikimedia.org/T260299) (owner: 10Cicalese) [00:23:56] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10OWC2020 (New Discussion 1.0): [SPIKE] How will the New Discussion Tool be made to support preloaded discussion templates - https://phabricator.wikimedia.org/T250768 (10ppelberg) [00:23:58] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board): New Discussion Tool V1.0: Engineering - https://phabricator.wikimedia.org/T259561 (10ppelberg) [00:24:00] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10OWC2020 (New Discussion 1.0): [Epic] Affordance: Start a new discussion - https://phabricator.wikimedia.org/T233446 (10ppelberg) [00:24:02] 10Wikimedia Chat: Implement login with global SUL account - https://phabricator.wikimedia.org/T261631 (10Ladsgroup) So I looked into this, Due to WMCS privacy policy, we can't use the WMF SUL directly, we can't use the wikitech LDAP either. The only option is OAuth (the button of "Login with your Github/Google/M... [00:28:04] (03CR) 10DannyS712: [C: 03+2] build: Updating npm dependencies [extensions/TEI] - 10https://gerrit.wikimedia.org/r/624952 (owner: 10Libraryupgrader) [00:28:10] (03PS11) 10Dbarratt: Handle CORS preflight request and prevent anon users from unsafe methods [core] - 10https://gerrit.wikimedia.org/r/621900 (https://phabricator.wikimedia.org/T232176) [00:31:38] (03CR) 10Dbarratt: Handle CORS preflight request and prevent anon users from unsafe methods (034 comments) [core] - 10https://gerrit.wikimedia.org/r/621900 (https://phabricator.wikimedia.org/T232176) (owner: 10Dbarratt) [00:31:51] (03PS2) 10Dzahn: fix links and updates for gamepedias, opensuse [debs/wikistats] - 10https://gerrit.wikimedia.org/r/624980 (https://phabricator.wikimedia.org/T262064) [00:32:27] (03CR) 10DannyS712: [C: 03+1] i18n: make action/right messages start with root form of a verb [extensions/HAWelcome] - 10https://gerrit.wikimedia.org/r/617780 (owner: 10Shirayuki) [00:34:51] (03CR) 10DannyS712: [C: 03+2] Add phpcs and make it pass [extensions/DebateTree] - 10https://gerrit.wikimedia.org/r/624887 (owner: 10Zoranzoki21) [00:35:19] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10I18n, 10MW-1.36-notes (1.36.0-wmf.6; 2020-08-25), 10Skipped QA: Can't reply to comments on wikis with digit transforms using new reply API (ckb.wp) - https://phabricator.wikimedia.org/T261706 (10ppelberg) 05Open→03Resolved [00:35:40] (03PS3) 10Dzahn: fix links and updates for gamepedias, opensuse [debs/wikistats] - 10https://gerrit.wikimedia.org/r/624980 (https://phabricator.wikimedia.org/T262064) [00:36:37] (03CR) 10Dzahn: [C: 03+2] fix links and updates for gamepedias, opensuse [debs/wikistats] - 10https://gerrit.wikimedia.org/r/624980 (https://phabricator.wikimedia.org/T262064) (owner: 10Dzahn) [00:39:51] (03CR) 10DannyS712: [V: 03+2 C: 03+2] "> Patch Set 1:" [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/624771 (owner: 10Libraryupgrader) [00:44:16] (03CR) 10DannyS712: [C: 03+2] Add phpcs and make it pass [extensions/Mailgun] - 10https://gerrit.wikimedia.org/r/624838 (owner: 10Zoranzoki21) [00:44:40] (03PS1) 10Dzahn: replace wikifur.org remnants with wikifur.com [debs/wikistats] - 10https://gerrit.wikimedia.org/r/624985 (https://phabricator.wikimedia.org/T262069) [00:45:08] (03CR) 10Dzahn: [C: 03+2] replace wikifur.org remnants with wikifur.com [debs/wikistats] - 10https://gerrit.wikimedia.org/r/624985 (https://phabricator.wikimedia.org/T262069) (owner: 10Dzahn) [00:48:23] (03CR) 10jerkins-bot: [V: 04-1] Handle CORS preflight request and prevent anon users from unsafe methods [core] - 10https://gerrit.wikimedia.org/r/621900 (https://phabricator.wikimedia.org/T232176) (owner: 10Dbarratt) [00:48:48] (03CR) 10DannyS712: Adds loading indicator for new search module (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/618282 (https://phabricator.wikimedia.org/T254695) (owner: 10Jdrewniak) [00:48:50] 10MediaWiki-Interface, 10I18n, 10Tracking-Neverending: Interface messages needing rewording or documentation and other issues with existing messages (tracking) - https://phabricator.wikimedia.org/T40638 (10ppelberg) [00:48:55] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10OWC2020 (Reply Tool Opt Out): Instrument Reply tool v2.0 - https://phabricator.wikimedia.org/T252931 (10ppelberg) [00:48:57] 10DiscussionTools, 10Editing-team (FY2020-21 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.36; 2020-06-09), 10OWC2020 (Reply Tool Opt Out), 10Product-Analytics (Kanban): Add additional events to VisualEditorFeatureUse - https://phabricator.wikimedia.org/T254291 (10ppelberg) 05Open→03Resolved [00:55:04] (03Merged) 10jenkins-bot: Add phpcs and make it pass [extensions/DebateTree] - 10https://gerrit.wikimedia.org/r/624887 (owner: 10Zoranzoki21) [00:55:06] (03Merged) 10jenkins-bot: Add phpcs and make it pass [extensions/Mailgun] - 10https://gerrit.wikimedia.org/r/624838 (owner: 10Zoranzoki21) [00:56:24] (03PS4) 10Dbarratt: Add protection against CSRF attacks to the REST API [core] - 10https://gerrit.wikimedia.org/r/623130 (https://phabricator.wikimedia.org/T261053) [00:57:08] (03CR) 10Krinkle: [C: 04-1] Initial implementation (034 comments) [extensions/WikimediaApiPortalOAuth] - 10https://gerrit.wikimedia.org/r/597553 (https://phabricator.wikimedia.org/T251283) (owner: 10ItSpiderman) [00:58:17] (03CR) 10DannyS712: [C: 03+2] Add note about access responsibility [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/623983 (https://phabricator.wikimedia.org/T246084) (owner: 10Lokal Profil) [01:01:57] (03Merged) 10jenkins-bot: Add note about access responsibility [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/623983 (https://phabricator.wikimedia.org/T246084) (owner: 10Lokal Profil) [01:02:46] (03CR) 10jerkins-bot: [V: 04-1] build: Updating npm dependencies [extensions/TranslationNotifications] - 10https://gerrit.wikimedia.org/r/624986 (owner: 10Libraryupgrader) [01:03:06] (03CR) 10Krinkle: [C: 04-1] Initial implementation (034 comments) [extensions/WikimediaApiPortalOAuth] - 10https://gerrit.wikimedia.org/r/597553 (https://phabricator.wikimedia.org/T251283) (owner: 10ItSpiderman) [01:06:58] (03CR) 10Krinkle: [C: 04-1] Initial implementation (033 comments) [extensions/WikimediaApiPortalOAuth] - 10https://gerrit.wikimedia.org/r/597553 (https://phabricator.wikimedia.org/T251283) (owner: 10ItSpiderman) [01:07:55] 10Wikilink-Tool, 10The-Wikipedia-Library (Kanban): Update the Wikilink production server to use Docker Swarm - https://phabricator.wikimedia.org/T258793 (10jsn.sherman) I realized that I forgot to gzip those images which would explain the log upload/download time. I updated the github action to take care of th... [01:09:03] 10DiscussionTools: Prompt people to enter an email address as part of the replying and new discussion workflows - https://phabricator.wikimedia.org/T262103 (10Reedy) Just crosslinking other tasks here with basically the same goal, but maybe from a slightly different workflow part... Which could potentially be ad... [01:10:19] (03CR) 10Krinkle: [C: 04-1] Initial implementation (031 comment) [extensions/WikimediaApiPortalOAuth] - 10https://gerrit.wikimedia.org/r/597553 (https://phabricator.wikimedia.org/T251283) (owner: 10ItSpiderman) [01:11:42] 10DiscussionTools: Prompt people to enter an email address as part of the replying and new discussion workflows - https://phabricator.wikimedia.org/T262103 (10ppelberg) >>! In T262103#6437629, @Reedy wrote: > Just crosslinking other tasks here with basically the same goal, but maybe from a slightly different wor... [01:12:25] 10DiscussionTools, 10Editing-team (Tracking): Prompt people to enter an email address as part of the replying and new discussion workflows - https://phabricator.wikimedia.org/T262103 (10ppelberg) [01:13:17] (03CR) 10Krinkle: [C: 04-1] Initial implementation (031 comment) [extensions/WikimediaApiPortalOAuth] - 10https://gerrit.wikimedia.org/r/597553 (https://phabricator.wikimedia.org/T251283) (owner: 10ItSpiderman) [01:14:16] (03CR) 10Krinkle: [C: 04-1] Initial implementation (031 comment) [extensions/WikimediaApiPortalOAuth] - 10https://gerrit.wikimedia.org/r/597553 (https://phabricator.wikimedia.org/T251283) (owner: 10ItSpiderman) [01:15:57] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt to 1.3.0 [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/624993 (owner: 10Libraryupgrader) [01:17:10] (03PS1) 10Dzahn: fix links in detail.php, especially opensuse and gamepedias [debs/wikistats] - 10https://gerrit.wikimedia.org/r/624997 (https://phabricator.wikimedia.org/T262068) [01:17:46] (03CR) 10Dzahn: [C: 03+2] fix links in detail.php, especially opensuse and gamepedias [debs/wikistats] - 10https://gerrit.wikimedia.org/r/624997 (https://phabricator.wikimedia.org/T262068) (owner: 10Dzahn) [01:18:14] 04(no projects): Continans Mountains Oceans corporation - https://phabricator.wikimedia.org/T261619 (10darkanglezhongshanti) p:05Low→03Unbreak! [01:21:08] (03CR) 10jerkins-bot: [V: 04-1] Add protection against CSRF attacks to the REST API [core] - 10https://gerrit.wikimedia.org/r/623130 (https://phabricator.wikimedia.org/T261053) (owner: 10Dbarratt) [01:21:21] 10Phabricator: Unhandled Exception trying to access Phabricator's "Sprint" application - https://phabricator.wikimedia.org/T261619 (10JJMC89) p:05Unbreak!→03Low [01:21:25] 10DiscussionTools, 10Editing-team (Tracking): Prompt people to enter an email address as part of the replying and new discussion workflows - https://phabricator.wikimedia.org/T262103 (10Reedy) >>! In T262103#6437637, @ppelberg wrote: >>>! In T262103#6437629, @Reedy wrote: >> Just crosslinking other tasks here... [01:25:41] (03PS1) 10Dzahn: fix links in details.php for wmspecials table [debs/wikistats] - 10https://gerrit.wikimedia.org/r/625003 (https://phabricator.wikimedia.org/T262068) [01:26:02] (03CR) 10Dzahn: [C: 03+2] fix links in details.php for wmspecials table [debs/wikistats] - 10https://gerrit.wikimedia.org/r/625003 (https://phabricator.wikimedia.org/T262068) (owner: 10Dzahn) [01:29:36] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt to 1.3.0 [extensions/UploadLogo] - 10https://gerrit.wikimedia.org/r/625004 (owner: 10Libraryupgrader) [01:29:48] 10Research (FY2020-21-Research-July-September): Questionnaire for community feedback on taxonomy of knowledge gaps - https://phabricator.wikimedia.org/T259363 (10leila) @MGerlach here is my update based on the work we started doing together today: - I sent the email to folks who gave us feedback for improvin... [01:31:39] 10DiscussionTools, 10OWC2020, 10Editing-team (FY2020-21 Kanban Board): [SPIKE] How might we categorize talk page edits at scale? - https://phabricator.wikimedia.org/T262107 (10ppelberg) [01:38:52] 10DiscussionTools, 10Editing-team (Tracking): [SPIKE] How can the software tag/categorize historical talk page edits? - https://phabricator.wikimedia.org/T262108 (10ppelberg) [01:39:18] 10DiscussionTools, 10OWC2020, 10Editing-team (FY2020-21 Kanban Board): [Technical Investigation] What constraints limit what notifications can be sent and how they can be delivered? - https://phabricator.wikimedia.org/T254263 (10ppelberg) [01:39:23] 10DiscussionTools, 10OWC2020, 10Editing-team (FY2020-21 Kanban Board): [SPIKE] How might we programmatically categorize talk page edits? - https://phabricator.wikimedia.org/T257644 (10ppelberg) As @Esanders noted in T257644#6360816, we think we found a way to tag talk page edits for the purposes of sending n... [01:39:29] 10DiscussionTools, 10OWC2020, 10Editing-team (FY2020-21 Kanban Board): [SPIKE] How might we programmatically categorize talk page edits? - https://phabricator.wikimedia.org/T257644 (10ppelberg) 05Open→03Resolved a:03ppelberg [01:43:41] (03CR) 10DannyS712: [C: 03+2] build: Updating npm dependencies [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/624999 (owner: 10Libraryupgrader) [01:43:47] (03CR) 10DannyS712: [C: 03+2] build: Updating npm dependencies [extensions/UserAgreement] - 10https://gerrit.wikimedia.org/r/625010 (owner: 10Libraryupgrader) [01:43:58] 10DiscussionTools, 10Wikimedia-Site-requests, 10Editing-team (FY2020-21 Kanban Board): Enable DiscussionTools on jawiki - https://phabricator.wikimedia.org/T261654 (10ppelberg) [01:44:00] (03CR) 10DannyS712: [C: 03+2] build: Updating npm dependencies [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/624992 (owner: 10Libraryupgrader) [01:44:50] 10DiscussionTools, 10Wikimedia-Site-requests, 10Editing-team (FY2020-21 Kanban Board): Enable DiscussionTools on jawiki - https://phabricator.wikimedia.org/T261654 (10ppelberg) [01:46:23] 10DiscussionTools, 10OWC2020, 10Beta-Feature, 10Editing-team (FY2020-21 Kanban Board): Enable Reply Tool on vi.wiki - https://phabricator.wikimedia.org/T262109 (10ppelberg) [01:53:54] (03CR) 10Jayprakash12345: Add protection against CSRF attacks to the REST API (031 comment) [core] - 10https://gerrit.wikimedia.org/r/623130 (https://phabricator.wikimedia.org/T261053) (owner: 10Dbarratt) [01:58:19] (03CR) 10Jayprakash12345: [C: 03+1] Add Preferences link to user menu [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/624910 (https://phabricator.wikimedia.org/T260628) (owner: 10Cicalese) [02:02:53] (03PS1) 10Reedy: Make use of BatchRow(Iterator|Writer)::setCaller [extensions/Echo] - 10https://gerrit.wikimedia.org/r/625017 (https://phabricator.wikimedia.org/T261014) [02:03:47] (03CR) 10Jayprakash12345: [C: 03+1] Add import permissions to highvolume grant [core] - 10https://gerrit.wikimedia.org/r/623960 (owner: 10Urbanecm) [02:09:41] (03PS1) 10Reedy: Make use of BatchRow(Iterator|Writer)::setCaller [extensions/Flow] - 10https://gerrit.wikimedia.org/r/625022 (https://phabricator.wikimedia.org/T261014) [02:11:55] (03PS1) 10Reedy: Make use of BatchRow(Iterator|Writer)::setCaller [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/625024 (https://phabricator.wikimedia.org/T261014) [02:13:25] (03CR) 10Reedy: maintenance: Make use of BatchRowIterator::setCaller (031 comment) [core] - 10https://gerrit.wikimedia.org/r/624786 (https://phabricator.wikimedia.org/T261014) (owner: 10Reedy) [02:14:17] (03PS2) 10Reedy: Make use of BatchRowIterator::setCaller [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/625024 (https://phabricator.wikimedia.org/T261014) [02:18:52] (03PS1) 10DVrandecic: Canonicalize Z9/Reference objects [extensions/WikiLambda] - 10https://gerrit.wikimedia.org/r/625025 (https://phabricator.wikimedia.org/T259932) [02:21:53] 10Developer-Advocacy (Jul-Sep 2020), 10Goal, 10Outreachy (Round 21): Design and plan Outreachy round 21 with a focus on data science and engineering projects - https://phabricator.wikimedia.org/T258524 (10Gopavasanth) [02:24:02] (03CR) 10Jayprakash12345: [C: 03+1] Simplify SkinExample [skins/Example] - 10https://gerrit.wikimedia.org/r/624758 (owner: 10Jdlrobson) [02:25:14] (03CR) 10jerkins-bot: [V: 04-1] Make use of BatchRow(Iterator|Writer)::setCaller [extensions/Echo] - 10https://gerrit.wikimedia.org/r/625017 (https://phabricator.wikimedia.org/T261014) (owner: 10Reedy) [02:26:22] (03CR) 10Jayprakash12345: [C: 03+1] [docs] Update package.json URLs [wvui] - 10https://gerrit.wikimedia.org/r/624889 (owner: 10Niedzielski) [02:28:28] (03CR) 10jerkins-bot: [V: 04-1] Make use of BatchRow(Iterator|Writer)::setCaller [extensions/Flow] - 10https://gerrit.wikimedia.org/r/625022 (https://phabricator.wikimedia.org/T261014) (owner: 10Reedy) [02:35:34] (03PS1) 10Reedy: Remove $wgUser from EchoForeignWikiRequest::canUseCentralAuth() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/625033 (https://phabricator.wikimedia.org/T262110) [02:38:03] (03CR) 10Jayprakash12345: [C: 03+1] Avoid deprecated Article::exists [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/624756 (owner: 10Umherirrender) [02:38:37] (03CR) 10Jayprakash12345: [C: 03+1] "recheck" [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/624756 (owner: 10Umherirrender) [02:41:57] (03PS2) 10Reedy: Make use of BatchRow(Iterator|Writer)::setCaller [extensions/Flow] - 10https://gerrit.wikimedia.org/r/625022 (https://phabricator.wikimedia.org/T261014) [02:42:10] (03PS2) 10Cicalese: Change direction on header shadow [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/624983 (https://phabricator.wikimedia.org/T260299) [02:42:24] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt to 1.3.0 [extensions/WSOAuth] - 10https://gerrit.wikimedia.org/r/625036 (owner: 10Libraryupgrader) [02:42:33] (03CR) 10Jayprakash12345: [C: 03+1] Use hook PageSaveComplete [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/624760 (owner: 10Umherirrender) [02:43:31] (03CR) 10Jayprakash12345: [C: 03+1] Avoid deprecated Article::getTimestamp [extensions/LastModified] - 10https://gerrit.wikimedia.org/r/624682 (owner: 10Umherirrender) [02:43:58] (03Abandoned) 10Reedy: Remove $wgUser from EchoForeignWikiRequest::canUseCentralAuth() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/625033 (https://phabricator.wikimedia.org/T262110) (owner: 10Reedy) [02:47:32] (03PS1) 10Reedy: Ignore usage of $wgUSer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/625039 (https://phabricator.wikimedia.org/T262110) [02:47:41] (03PS2) 10Reedy: Ignore usage of $wgUser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/625039 (https://phabricator.wikimedia.org/T262110) [02:48:30] (03CR) 10Reedy: "This usage is now causing test failures... See T262110" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/567374 (https://phabricator.wikimedia.org/T243732) (owner: 10DannyS712) [02:49:11] 10MediaWiki-extensions-General, 10MW-1.35-notes (1.35.0-wmf.37; 2020-06-16), 10Technical-Debt, 10User-DannyS712: WMF deployed extensions need uses of global $wgUser removed [tracking] - https://phabricator.wikimedia.org/T245959 (10Reedy) [02:52:04] (03PS1) 10Reedy: Ignore usage of $wgUser [extensions/Flow] - 10https://gerrit.wikimedia.org/r/625041 (https://phabricator.wikimedia.org/T262111) [02:53:57] (03PS3) 10Reedy: Make use of BatchRow(Iterator|Writer)::setCaller [extensions/Flow] - 10https://gerrit.wikimedia.org/r/625022 (https://phabricator.wikimedia.org/T261014) [02:54:31] (03PS2) 10Reedy: Make use of BatchRow(Iterator|Writer)::setCaller [extensions/Echo] - 10https://gerrit.wikimedia.org/r/625017 (https://phabricator.wikimedia.org/T261014) [02:59:09] (03PS3) 10Reedy: Ignore usage of $wgUser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/625039 (https://phabricator.wikimedia.org/T262110) [02:59:18] (03PS3) 10Reedy: Make use of BatchRow(Iterator|Writer)::setCaller [extensions/Echo] - 10https://gerrit.wikimedia.org/r/625017 (https://phabricator.wikimedia.org/T261014) [03:11:01] (03PS1) 10Dzahn: fix links for anarchopedias table and detail page [debs/wikistats] - 10https://gerrit.wikimedia.org/r/625042 (https://phabricator.wikimedia.org/T262106) [03:16:43] (03PS4) 10Reedy: Ignore usage of $wgUser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/625039 (https://phabricator.wikimedia.org/T262110) [03:16:51] (03CR) 10Reedy: [C: 03+2] "Self merge to unblock CI/PHPCS failure. No functional changes, just phpcs:ignore on a $wgUser line" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/625039 (https://phabricator.wikimedia.org/T262110) (owner: 10Reedy) [03:17:10] (03CR) 10Reedy: [C: 03+2] "Self merge to unblock CI/PHPCS failure. No functional changes, just phpcs:ignore on a $wgUser line" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/625041 (https://phabricator.wikimedia.org/T262111) (owner: 10Reedy) [03:18:56] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt to 1.3.0 [extensions/Variables] - 10https://gerrit.wikimedia.org/r/625027 (owner: 10Libraryupgrader) [03:19:30] (03PS3) 10Reedy: Remove use of global $wgUser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/567374 (https://phabricator.wikimedia.org/T243732) (owner: 10DannyS712) [03:20:00] (03CR) 10Reedy: [C: 04-1] "Reapply C-1" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/567374 (https://phabricator.wikimedia.org/T243732) (owner: 10DannyS712) [03:36:15] (03Merged) 10jenkins-bot: Ignore usage of $wgUser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/625039 (https://phabricator.wikimedia.org/T262110) (owner: 10Reedy) [03:42:16] (03Merged) 10jenkins-bot: Ignore usage of $wgUser [extensions/Flow] - 10https://gerrit.wikimedia.org/r/625041 (https://phabricator.wikimedia.org/T262111) (owner: 10Reedy) [03:45:56] (03PS4) 10Reedy: Make use of BatchRow(Iterator|Writer)::setCaller [extensions/Echo] - 10https://gerrit.wikimedia.org/r/625017 (https://phabricator.wikimedia.org/T261014) [03:51:16] (03CR) 10Dmaza: Show half star for temporarily watched pages (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/622203 (https://phabricator.wikimedia.org/T251690) (owner: 10MusikAnimal) [03:52:23] (03CR) 10jerkins-bot: [V: 04-1] build: Updating npm dependencies [extensions/WikEdDiff] - 10https://gerrit.wikimedia.org/r/625052 (owner: 10Libraryupgrader) [04:01:41] (03PS1) 10Dzahn: add neoseeker, rodovid, scoutwiki to https_only for update URLs [debs/wikistats] - 10https://gerrit.wikimedia.org/r/625059 [04:02:04] (03CR) 10Dzahn: [C: 03+2] add neoseeker, rodovid, scoutwiki to https_only for update URLs [debs/wikistats] - 10https://gerrit.wikimedia.org/r/625059 (owner: 10Dzahn) [04:02:09] (03PS2) 10Dzahn: add neoseeker, rodovid, scoutwiki to https_only for update URLs [debs/wikistats] - 10https://gerrit.wikimedia.org/r/625059 [04:03:02] (03CR) 10Dzahn: [C: 03+2] fix links for anarchopedias table and detail page [debs/wikistats] - 10https://gerrit.wikimedia.org/r/625042 (https://phabricator.wikimedia.org/T262106) (owner: 10Dzahn) [04:03:07] 10Developer-Advocacy (Jul-Sep 2020), 10Goal: Develop a concept for monthly skill-sharing workshops for international, regional and local wiki communities - https://phabricator.wikimedia.org/T259556 (10srishakatux) Shared by @KCVelaga, as a follow-up to previous meeting, a detailed plan for monthly technical sk... [04:05:39] 10Developer-Advocacy (Jul-Sep 2020), 10Goal: Develop a concept for monthly skill-sharing workshops for international, regional and local wiki communities - https://phabricator.wikimedia.org/T259556 (10srishakatux) Also, as a next step, Dev Advocacy plans to identify a few emerging technical communities using t... [04:11:16] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt to 1.3.0 [extensions/WikiShare] - 10https://gerrit.wikimedia.org/r/625063 (owner: 10Libraryupgrader) [05:18:47] (03PS1) 10Samwilson: Add phpcs and fix some errors [extensions/Diagnosis] - 10https://gerrit.wikimedia.org/r/625083 [05:28:00] 10Magnus Sälgö-Riksarkivet-NAD: Feature request: URL to the archive with NAD number as argument that always work - https://phabricator.wikimedia.org/T200046 (10Salgo60) Sent question to Riksarkivet Fråga 1 vad är domänen för Kyrkböcker? Fråga 2: har ni ett API där vi kan hämta ut den unika domänen för de kopp... [05:28:29] 10Magnus Sälgö-Riksarkivet-NAD: Feature request: URL to the archive with NAD number as argument that always work - https://phabricator.wikimedia.org/T200046 (10Salgo60) **Answer** From: kundtjanst Sent: Friday, September 4, 2020 3:50 PM To: Magnus Sälgö Subject: Sv:... [05:33:29] 10Convenient-Discussions: Make it possible to tell if CD's comment form is open from browser tab's name - https://phabricator.wikimedia.org/T262073 (10Jack_who_built_the_house) So, my current thoughts are the following: * In contrast with DiscussionTools, many comment forms can be open simultaneously in CD. * In... [05:33:32] 10Magnus Sälgö-Riksarkivet-NAD: Feature request: URL to the archive with NAD number as argument that always work - https://phabricator.wikimedia.org/T200046 (10Salgo60) Hej Du har en lista [[ https://w.wiki/bJd | https://w.wiki/bJd ]] med alla kopplingar vi har i Wikidata till NAD vårt unika ID är det som finn... [05:37:23] 10Developer-Advocacy (Jul-Sep 2020): Coordinate Wikimedia's participation in HackMIT 2020 (September 18-20) - https://phabricator.wikimedia.org/T261169 (10srishakatux) Email shared with tech-all, product-all: > Interesting in mentoring at HackMIT? > > Hello everyone, > > We are participating in HackMIT 2020... [06:05:06] (03CR) 10DannyS712: [C: 03+2] build: Updating npm dependencies [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/625080 (owner: 10Libraryupgrader) [06:05:20] (03CR) 10DannyS712: [C: 03+2] build: Updating npm dependencies [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/625055 (owner: 10Libraryupgrader) [06:05:41] (03CR) 10DannyS712: [C: 03+2] build: Updating npm dependencies [extensions/VEForAll] - 10https://gerrit.wikimedia.org/r/625023 (owner: 10Libraryupgrader) [06:07:28] 10Phabricator: How do I edit a project description? - https://phabricator.wikimedia.org/T261442 (10Jack_who_built_the_house) So, project members can't edit their descriptions? Do I need to get added to #trusted-contributors to be able to edit the description of a project I maintain? How do I do that? [06:08:21] (03CR) 10DannyS712: [C: 03+2] Add phpcs and fix some errors [extensions/Diagnosis] - 10https://gerrit.wikimedia.org/r/625083 (owner: 10Samwilson) [06:09:21] 10Wikispeech-STTS, 10Wikispeech-Speech-Data-Collector, 10Wikispeech-Jobrunner (Sprint): load_db tool should filter articles and sentences before adding to db - https://phabricator.wikimedia.org/T262115 (10NikolajLindberg) [06:09:49] 10Phabricator: How do I edit a project description? - https://phabricator.wikimedia.org/T261442 (10mmodell) @Jack_who_built_the_house yes, I have added you to #trusted-contributors [06:10:25] 10Phabricator: How do I edit a project description? - https://phabricator.wikimedia.org/T261442 (10Jack_who_built_the_house) Thanks. [06:12:19] 10Wikispeech-STTS, 10Wikispeech-Speech-Data-Collector, 10Wikispeech-Jobrunner (Sprint): new db chunkfeat type: Unicode code block - https://phabricator.wikimedia.org/T262116 (10NikolajLindberg) [06:12:41] 10Developer-Advocacy (Jul-Sep 2020), 10Goal, 10Outreachy (Round 21): Design and plan Outreachy round 21 with a focus on data science and engineering projects - https://phabricator.wikimedia.org/T258524 (10srishakatux) Sharing an update on the projects/mentors here, with whom I am continuing the discussions:... [06:13:01] 10Wikispeech-Jobrunner, 10Wikispeech-STTS, 10Wikispeech-Speech-Data-Collector: new db chunkfeat type: Unicode code block - https://phabricator.wikimedia.org/T262116 (10NikolajLindberg) [06:13:06] 10Wikispeech-Jobrunner, 10Wikispeech-STTS, 10Wikispeech-Speech-Data-Collector: load_db tool should filter articles and sentences before adding to db - https://phabricator.wikimedia.org/T262115 (10NikolajLindberg) [06:13:23] 10Phabricator: How do I edit a project description? - https://phabricator.wikimedia.org/T261442 (10mmodell) 05Open→03Resolved a:03mmodell I've also added @Iniquity to #trusted-contributors [06:13:25] 10Wikispeech-Jobrunner, 10Wikispeech-STTS, 10Wikispeech-Speech-Data-Collector: dbapi: clean up and remove/un-export some exposed functions - https://phabricator.wikimedia.org/T262015 (10NikolajLindberg) [06:14:00] 10Wikispeech-STTS, 10Wikispeech-Speech-Data-Collector, 10Wikispeech-Jobrunner (Sprint): Add source feature: article length in paragraphs - https://phabricator.wikimedia.org/T261955 (10NikolajLindberg) 05Open→03Resolved [06:14:02] 10Wikispeech-STTS, 10Wikispeech-Speech-Data-Collector, 10Wikispeech-Jobrunner (Sprint): Indexed Relational Database of Text - https://phabricator.wikimedia.org/T261929 (10NikolajLindberg) [06:14:22] 10Wikispeech-Jobrunner, 10Wikispeech-STTS, 10Wikispeech-Speech-Data-Collector: Add tests for lookup - https://phabricator.wikimedia.org/T262014 (10NikolajLindberg) [06:16:39] 10Wikispeech-Jobrunner, 10Wikispeech-STTS, 10Wikispeech-Speech-Data-Collector: generated word frequency table - https://phabricator.wikimedia.org/T262117 (10NikolajLindberg) [06:28:01] (03Merged) 10jenkins-bot: Add phpcs and fix some errors [extensions/Diagnosis] - 10https://gerrit.wikimedia.org/r/625083 (owner: 10Samwilson) [06:50:45] 10MediaWiki-Interface: Provide site notice dismiss button in core - https://phabricator.wikimedia.org/T262118 (10Ammarpad) [06:51:13] 10MediaWiki-Interface: Provide site notice dismiss button in core - https://phabricator.wikimedia.org/T262118 (10Ammarpad) [06:51:16] 10MediaWiki-Core-Skin-Architecture, 10MediaWiki-Interface, 10DismissableSiteNotice, 10MW-1.36-release: Merge DismissableSiteNotice extension into core - https://phabricator.wikimedia.org/T259903 (10Ammarpad) [06:55:07] (03PS3) 10Pwirth: Remove deprecated since 3.0 BsDebug [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/624031 [06:56:21] (03PS2) 10Pwirth: Remove usages of BlueSpice\Services [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/624126 [07:07:46] 10Diffusion-Repository-Administrators, 10Projects-Cleanup, 10Patch-For-Review: Unarchive mediawiki/extensions/MagicNumberedHeadings - https://phabricator.wikimedia.org/T261923 (10Nikerabbit) For @Raymond to check. [07:09:44] (03CR) 10Umherirrender: [C: 03+2] build: Updating npm dependencies [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/625112 (owner: 10Libraryupgrader) [07:10:33] (03CR) 10Umherirrender: "See T250963 for failure" [extensions/Variables] - 10https://gerrit.wikimedia.org/r/625027 (owner: 10Libraryupgrader) [07:15:22] (03CR) 10Umherirrender: "See T256403 for the failure" [extensions/TheWikipediaLibrary] - 10https://gerrit.wikimedia.org/r/624966 (owner: 10Libraryupgrader) [07:18:00] 10Diffusion-Repository-Administrators, 10Projects-Cleanup, 10Patch-For-Review: Unarchive mediawiki/extensions/MagicNumberedHeadings - https://phabricator.wikimedia.org/T261923 (10Umherirrender) Just for information and to connect both tasks: Archive was done with T248758 [07:22:33] 10MediaWiki-Templates: Template formatting is broken - https://phabricator.wikimedia.org/T262119 (101997kB) [07:23:31] (03CR) 10Umherirrender: "Possible CI fix with Ie4f39f4b14e0907afb0e90a70fb705f5ec7376d3" [extensions/Sentry] - 10https://gerrit.wikimedia.org/r/624874 (owner: 10Libraryupgrader) [07:23:49] 10MediaWiki-Templates: Template formatting is broken - https://phabricator.wikimedia.org/T262119 (101997kB) 05Open→03Invalid [07:24:57] (03CR) 10Umherirrender: "Failure unrelated" [extensions/SidebarDonateBox] - 10https://gerrit.wikimedia.org/r/624891 (owner: 10Libraryupgrader) [07:25:55] (03CR) 10Umherirrender: "Failure unrelated" [extensions/SoftRedirector] - 10https://gerrit.wikimedia.org/r/624919 (owner: 10Libraryupgrader) [07:29:50] (03PS1) 10Umherirrender: Make content an array in SkinVector::buildSidebar [skins/Vector] - 10https://gerrit.wikimedia.org/r/625127 [07:31:20] (03CR) 10Umherirrender: "Failure unrelated" [extensions/SplitPrivateWiki] - 10https://gerrit.wikimedia.org/r/624933 (owner: 10Libraryupgrader) [07:38:19] 10MediaWiki-Core-Skin-Architecture, 10MediaWiki-Interface, 10DismissableSiteNotice, 10MW-1.36-release: Deprecate $wgDismissableSiteNoticeForAnons - https://phabricator.wikimedia.org/T262120 (10Ammarpad) [07:38:30] (03CR) 10Umherirrender: "Failure unrelated" [extensions/THICC] - 10https://gerrit.wikimedia.org/r/624953 (owner: 10Libraryupgrader) [07:39:20] 10Wikispeech-Jobrunner, 10Wikispeech-STTS, 10Wikispeech-Speech-Data-Collector: generated word frequency table - https://phabricator.wikimedia.org/T262117 (10NikolajLindberg) 05Open→03Resolved [07:39:22] 10Wikispeech-STTS, 10Wikispeech-Speech-Data-Collector, 10Wikispeech-Jobrunner (Sprint): Indexed Relational Database of Text - https://phabricator.wikimedia.org/T261929 (10NikolajLindberg) [07:39:30] (03CR) 10Umherirrender: "Failure unrelated" [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/624973 (owner: 10Libraryupgrader) [07:40:31] 10MediaWiki-Core-Skin-Architecture, 10MediaWiki-Interface, 10DismissableSiteNotice, 10MW-1.36-release: Deprecate $wgDismissableSiteNoticeForAnons - https://phabricator.wikimedia.org/T262120 (10Ammarpad) [07:40:44] (03CR) 10Umherirrender: "Failure unrelated:" [extensions/TranslationNotifications] - 10https://gerrit.wikimedia.org/r/624986 (owner: 10Libraryupgrader) [07:41:05] (03PS1) 10Umherirrender: Use hook RevisionFromEditComplete [extensions/SplitPrivateWiki] - 10https://gerrit.wikimedia.org/r/625133 [07:41:20] 10MediaWiki-Core-Skin-Architecture, 10MediaWiki-Interface, 10DismissableSiteNotice, 10MW-1.36-release: Deprecate $wgDismissableSiteNoticeForAnons - https://phabricator.wikimedia.org/T262120 (10Ammarpad) [07:41:24] 10Wikispeech-Jobrunner, 10Wikispeech-STTS, 10Wikispeech-Speech-Data-Collector: chunkfeat punct as single characters not character sequence - https://phabricator.wikimedia.org/T262121 (10NikolajLindberg) [07:42:47] (03PS1) 10Umherirrender: Fix case of class in extension.json for APIModules [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/625134 [07:43:04] (03CR) 10Umherirrender: "Failure unrelated" [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/624993 (owner: 10Libraryupgrader) [07:43:33] (03CR) 10Umherirrender: "See T250965 for the failure" [extensions/UploadLogo] - 10https://gerrit.wikimedia.org/r/625004 (owner: 10Libraryupgrader) [07:44:28] (03CR) 10Umherirrender: "Failure unrelated" [extensions/WikiShare] - 10https://gerrit.wikimedia.org/r/625063 (owner: 10Libraryupgrader) [07:45:01] 10MediaWiki-Core-Skin-Architecture, 10MediaWiki-Interface, 10DismissableSiteNotice, 10MW-1.36-release: Deprecate $wgDismissableSiteNoticeForAnons - https://phabricator.wikimedia.org/T262120 (10Ammarpad) [07:45:22] (03CR) 10Umherirrender: [C: 03+1] "Failure unrelated" [extensions/WikEdDiff] - 10https://gerrit.wikimedia.org/r/625052 (owner: 10Libraryupgrader) [07:45:56] (03CR) 10jerkins-bot: [V: 04-1] Fix case of class in extension.json for APIModules [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/625134 (owner: 10Umherirrender) [07:46:04] (03CR) 10Umherirrender: [C: 03+1] "Failure unrelated" [extensions/WSOAuth] - 10https://gerrit.wikimedia.org/r/625036 (owner: 10Libraryupgrader) [07:46:58] (03PS2) 10Umherirrender: build: Updating grunt to 1.3.0 [extensions/SplitPrivateWiki] - 10https://gerrit.wikimedia.org/r/624933 (owner: 10Libraryupgrader) [07:48:28] (03PS2) 10Umherirrender: Fix case of class in extension.json for APIModules [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/625134 [07:48:43] 10MediaWiki-Core-Skin-Architecture, 10MediaWiki-Interface, 10DismissableSiteNotice, 10MW-1.36-release: Undeploy DismissableSiteNotice from Wikimedia Beta Cluster - https://phabricator.wikimedia.org/T262122 (10Ammarpad) [07:51:19] 10MediaWiki-Core-Skin-Architecture, 10MediaWiki-Interface, 10DismissableSiteNotice, 10MW-1.36-release: Merge DismissableSiteNotice extension into core - https://phabricator.wikimedia.org/T259903 (10Ammarpad) [07:51:40] (03PS2) 10Umherirrender: build: Updating grunt to 1.3.0 [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/624993 (owner: 10Libraryupgrader) [07:54:54] 10MediaWiki-Core-Skin-Architecture, 10MediaWiki-Interface: Provide site notice dismiss button in core - https://phabricator.wikimedia.org/T262118 (10Ammarpad) [07:56:24] (03CR) 10Umherirrender: [C: 03+1] "Hopefully fixed with Ifa6984120c2bff191d310a368857fa9f2e578278" [extensions/WSOAuth] - 10https://gerrit.wikimedia.org/r/625036 (owner: 10Libraryupgrader) [08:08:29] (03PS1) 10Umherirrender: build: Fix phan issues [extensions/CognitiveProcessDesigner] - 10https://gerrit.wikimedia.org/r/625138 [08:09:26] (03CR) 10jerkins-bot: [V: 04-1] build: Fix phan issues [extensions/CognitiveProcessDesigner] - 10https://gerrit.wikimedia.org/r/625138 (owner: 10Umherirrender) [08:11:46] (03PS2) 10Umherirrender: build: Updating grunt to 1.3.0 [extensions/NewsBox] - 10https://gerrit.wikimedia.org/r/624530 (owner: 10Libraryupgrader) [08:12:27] (03PS2) 10Umherirrender: build: Updating grunt to 1.3.0 [extensions/SidebarDonateBox] - 10https://gerrit.wikimedia.org/r/624891 (owner: 10Libraryupgrader) [08:12:58] (03PS2) 10Umherirrender: build: Updating grunt to 1.3.0 [extensions/WikiShare] - 10https://gerrit.wikimedia.org/r/625063 (owner: 10Libraryupgrader) [08:15:31] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt to 1.3.0 [extensions/NewsBox] - 10https://gerrit.wikimedia.org/r/624530 (owner: 10Libraryupgrader) [08:15:56] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt to 1.3.0 [extensions/SidebarDonateBox] - 10https://gerrit.wikimedia.org/r/624891 (owner: 10Libraryupgrader) [08:16:18] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt to 1.3.0 [extensions/WikiShare] - 10https://gerrit.wikimedia.org/r/625063 (owner: 10Libraryupgrader) [08:20:26] (03PS2) 10Umherirrender: Make content an array in SkinVector::buildSidebar [skins/Vector] - 10https://gerrit.wikimedia.org/r/625127 [08:20:36] (03CR) 10Umherirrender: "recheck" [extensions/NewsBox] - 10https://gerrit.wikimedia.org/r/624530 (owner: 10Libraryupgrader) [08:26:53] (03CR) 10Umherirrender: "I am trying to fix three extension with the mention failure" [skins/Vector] - 10https://gerrit.wikimedia.org/r/625127 (owner: 10Umherirrender) [08:45:09] 10MediaWiki-Core-Skin-Architecture, 10MediaWiki-Interface, 10DismissableSiteNotice, 10MW-1.36-release: Deprecate $wgDismissableSiteNoticeForAnons - https://phabricator.wikimedia.org/T262120 (10Ammarpad) [08:48:52] 10MediaWiki-Core-Skin-Architecture, 10MediaWiki-Interface, 10DismissableSiteNotice, 10MW-1.36-release: Merge DismissableSiteNotice extension into core - https://phabricator.wikimedia.org/T259903 (10Ammarpad) [08:55:13] (03CR) 10Ammarpad: [C: 03+2] Refactor: Simplify responsive Monobook's optional dependencies [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/618401 (https://phabricator.wikimedia.org/T203023) (owner: 10Jdlrobson) [09:05:26] (03CR) 10Ammarpad: [C: 03+2] Don't change function signature of buildSidebar [skins/Vector] - 10https://gerrit.wikimedia.org/r/624907 (owner: 10Jdlrobson) [09:11:39] 10MediaWiki-User-login-and-signup: SUL will not log me in to some WMF projects - https://phabricator.wikimedia.org/T262123 (10Koavf) [09:14:58] (03CR) 10Ammarpad: [C: 04-1] "This is intentional. Restoring this check means continuing to support legacy behavior, which we don't want to." [skins/Vector] - 10https://gerrit.wikimedia.org/r/625127 (owner: 10Umherirrender) [09:25:24] (03Merged) 10jenkins-bot: Don't change function signature of buildSidebar [skins/Vector] - 10https://gerrit.wikimedia.org/r/624907 (owner: 10Jdlrobson) [09:28:59] (03CR) 10Ammarpad: [C: 03+2] Simplify SkinExample [skins/Example] - 10https://gerrit.wikimedia.org/r/624758 (owner: 10Jdlrobson) [09:30:01] (03CR) 10Ammarpad: Refactor: Simplify responsive Monobook's optional dependencies [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/618401 (https://phabricator.wikimedia.org/T203023) (owner: 10Jdlrobson) [09:30:52] (03CR) 10Ammarpad: [C: 03+2] Refactor: Simplify responsive Monobook's optional dependencies [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/618401 (https://phabricator.wikimedia.org/T203023) (owner: 10Jdlrobson) [09:33:12] (03Merged) 10jenkins-bot: Simplify SkinExample [skins/Example] - 10https://gerrit.wikimedia.org/r/624758 (owner: 10Jdlrobson) [09:35:13] (03Merged) 10jenkins-bot: Refactor: Simplify responsive Monobook's optional dependencies [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/618401 (https://phabricator.wikimedia.org/T203023) (owner: 10Jdlrobson) [09:39:00] (03PS4) 10Ammarpad: Update magic words and special page aliases for Arabic (ar) [core] - 10https://gerrit.wikimedia.org/r/614035 (https://phabricator.wikimedia.org/T258351) (owner: 10Meno25) [09:44:06] (03CR) 10Umherirrender: [C: 03+2] build: Updating npm dependencies [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/625159 (owner: 10Libraryupgrader) [09:45:21] 10MediaWiki-User-login-and-signup: SUL will not log me in to some WMF projects - https://phabricator.wikimedia.org/T262123 (10Bugreporter) [09:45:29] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-CentralAuth: Logging in to a wiki sometimes fails with 'sessionfailure' error (coinciding with SameSite rollout) - https://phabricator.wikimedia.org/T258121 (10Bugreporter) [09:45:49] (03CR) 10Umherirrender: [C: 03+2] build: Updating npm dependencies [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/625164 (owner: 10Libraryupgrader) [10:05:02] (03CR) 10Ammarpad: [C: 03+2] Update magic words and special page aliases for Arabic (ar) [core] - 10https://gerrit.wikimedia.org/r/614035 (https://phabricator.wikimedia.org/T258351) (owner: 10Meno25) [10:08:19] (03CR) 10Ammarpad: [C: 03+1] "LGTM pending core patch" [skins/Vector] - 10https://gerrit.wikimedia.org/r/615322 (https://phabricator.wikimedia.org/T256897) (owner: 10Jdlrobson) [10:16:18] 10Wikispeech-Jobrunner, 10Wikispeech-STTS, 10Wikispeech-Speech-Data-Collector: load_db tool should filter articles and sentences before adding to db - https://phabricator.wikimedia.org/T262115 (10NikolajLindberg) [10:18:47] 10DiscussionTools: Uncaught TypeError: Cannot read property 'tagName' of null - https://phabricator.wikimedia.org/T261885 (10Tacsipacsi) Please note that `Production error` task subtype is for server-side errors, not for client-side ones like this one. Steps to reproduce are welcome—server-side errors are usuall... [10:18:49] (03CR) 10Umherirrender: [C: 03+2] Make use of BatchRow(Iterator|Writer)::setCaller [extensions/Echo] - 10https://gerrit.wikimedia.org/r/625017 (https://phabricator.wikimedia.org/T261014) (owner: 10Reedy) [10:22:24] (03CR) 10Umherirrender: [C: 03+2] Make use of BatchRowIterator::setCaller [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/625024 (https://phabricator.wikimedia.org/T261014) (owner: 10Reedy) [10:24:39] (03Merged) 10jenkins-bot: Update magic words and special page aliases for Arabic (ar) [core] - 10https://gerrit.wikimedia.org/r/614035 (https://phabricator.wikimedia.org/T258351) (owner: 10Meno25) [10:27:13] (03CR) 10Umherirrender: [C: 03+2] Make use of BatchRow(Iterator|Writer)::setCaller [extensions/Flow] - 10https://gerrit.wikimedia.org/r/625022 (https://phabricator.wikimedia.org/T261014) (owner: 10Reedy) [10:28:01] (03CR) 10Umherirrender: [C: 03+2] build: Updating npm dependencies [extensions/Cite] - 10https://gerrit.wikimedia.org/r/625179 (owner: 10Libraryupgrader) [10:32:28] (03PS1) 10Umherirrender: Use extension registration key 'QUnitTestModule' [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/625181 [10:33:47] (03PS2) 10Umherirrender: Use extension registration key 'QUnitTestModule' [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/625181 [10:34:48] 10DiscussionTools: Uncaught TypeError: Cannot read property 'tagName' of null - https://phabricator.wikimedia.org/T261885 (10Ammarpad) >>! In T261885#6438061, @Tacsipacsi wrote: > Please note that `Production error` task subtype is for server-side errors, not for client-side ones like this one. >Tacsipacsi rem... [10:37:37] (03Merged) 10jenkins-bot: Make use of BatchRow(Iterator|Writer)::setCaller [extensions/Echo] - 10https://gerrit.wikimedia.org/r/625017 (https://phabricator.wikimedia.org/T261014) (owner: 10Reedy) [10:38:07] (03CR) 10jerkins-bot: [V: 04-1] Use extension registration key 'QUnitTestModule' [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/625181 (owner: 10Umherirrender) [10:45:05] (03Merged) 10jenkins-bot: Make use of BatchRowIterator::setCaller [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/625024 (https://phabricator.wikimedia.org/T261014) (owner: 10Reedy) [10:45:14] (03Merged) 10jenkins-bot: Make use of BatchRow(Iterator|Writer)::setCaller [extensions/Flow] - 10https://gerrit.wikimedia.org/r/625022 (https://phabricator.wikimedia.org/T261014) (owner: 10Reedy) [10:45:42] (03PS1) 10Umherirrender: Remove hook ResourceLoaderTestModules [extensions/FormWizard] - 10https://gerrit.wikimedia.org/r/625183 [10:46:08] (03PS1) 10Umherirrender: Use extension registration key 'QUnitTestModule' [extensions/Sentry] - 10https://gerrit.wikimedia.org/r/625184 [10:47:09] (03PS1) 10Umherirrender: Remove hook ResourceLoaderTestModules [extensions/THICC] - 10https://gerrit.wikimedia.org/r/625185 [10:47:24] (03PS3) 10Umherirrender: Use extension registration key 'QUnitTestModule' [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/625181 [10:48:57] (03CR) 10jerkins-bot: [V: 04-1] Use extension registration key 'QUnitTestModule' [extensions/Sentry] - 10https://gerrit.wikimedia.org/r/625184 (owner: 10Umherirrender) [10:49:05] 10WPCleaner: Add CW#557: Detect missing space before internal link - https://phabricator.wikimedia.org/T257788 (10NicoV) Many false positives, need to find ways to ignore them: list of possible prefixes, #REDIRECT... - Alkali metal: `n[[ohm|Ω]]`, `Li[[methyl group|Me]]`, `Li[[fluorine|F]]`, `Li[[hydroxide|OH]... [10:50:36] (03PS4) 10Umherirrender: Use extension registration key 'QUnitTestModule' [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/625181 [10:51:03] (03PS2) 10Umherirrender: Use extension registration key 'QUnitTestModule' [extensions/Sentry] - 10https://gerrit.wikimedia.org/r/625184 [10:52:41] (03PS2) 10Umherirrender: build: Updating npm dependencies [extensions/FormWizard] - 10https://gerrit.wikimedia.org/r/624317 (owner: 10Libraryupgrader) [10:52:48] (03CR) 10Umherirrender: [C: 03+2] build: Updating npm dependencies [extensions/FormWizard] - 10https://gerrit.wikimedia.org/r/624317 (owner: 10Libraryupgrader) [10:53:12] (03PS2) 10Umherirrender: build: Updating npm dependencies [extensions/THICC] - 10https://gerrit.wikimedia.org/r/624953 (owner: 10Libraryupgrader) [10:53:56] (03CR) 10jerkins-bot: [V: 04-1] Use extension registration key 'QUnitTestModule' [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/625181 (owner: 10Umherirrender) [10:55:27] (03Abandoned) 10Umherirrender: Use extension registration key 'QUnitTestModule' [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/625181 (owner: 10Umherirrender) [10:56:33] (03PS2) 10Umherirrender: build: Updating npm dependencies [extensions/Sentry] - 10https://gerrit.wikimedia.org/r/624874 (owner: 10Libraryupgrader) [10:59:44] (03CR) 10Umherirrender: "> Patch Set 2: Code-Review-1" [skins/Vector] - 10https://gerrit.wikimedia.org/r/625127 (owner: 10Umherirrender) [11:11:55] 10MediaWiki-User-preferences, 10Machine Learning Platform, 10ORES: Preference on "Recent Changes" tab (Revision scoring: Show only likely problem edits) unexpectedly affects Special:Contributions - https://phabricator.wikimedia.org/T262041 (10Xeno) [11:12:41] 10MobileFrontend: MoveLeadParagraphTransformInfobox should be rewritten to be more similar to mobile apps - https://phabricator.wikimedia.org/T262093 (10Esanders) [11:12:47] 10MediaWiki-User-preferences, 10Machine Learning Platform, 10ORES: Preference on "Recent Changes" tab (Revision scoring: Show only likely problem edits) unexpectedly affects Special:Contributions - https://phabricator.wikimedia.org/T262041 (10Xeno) >>! In T262041#6436273, @Aklapper wrote: > Hi @Xeno, could y... [11:18:18] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt to 1.3.0 [extensions/CognitiveProcessDesigner] - 10https://gerrit.wikimedia.org/r/625194 (owner: 10Libraryupgrader) [11:18:49] 10MediaWiki-extensions-Page_Forms: values from namespace does not use $wgPageFormsMaxLocalAutocompleteValues limit - https://phabricator.wikimedia.org/T262130 (10Oeyvindg) [11:19:07] 10MediaWiki-extensions-Page_Forms: values from namespace does not use $wgPageFormsMaxLocalAutocompleteValues limit - https://phabricator.wikimedia.org/T262130 (10Oeyvindg) [11:25:00] 10Design, 10WMDE-Design, 10Wikidata: Redesign rank icons for better visibility - https://phabricator.wikimedia.org/T206392 (10ChristianKl) Ordering is generally useful (but can create issues as pointed out by @MichaelSchoenitzer) but it doesn't help a user to understand the concept of deprecated statements... [11:44:39] (03CR) 10Ostrzyciel: [C: 03+2] Remove hook ResourceLoaderTestModules [extensions/THICC] - 10https://gerrit.wikimedia.org/r/625185 (owner: 10Umherirrender) [11:48:59] (03CR) 10Umherirrender: [C: 03+2] build: Updating npm dependencies [extensions/Collection] - 10https://gerrit.wikimedia.org/r/625197 (owner: 10Libraryupgrader) [11:49:05] (03CR) 10Umherirrender: [C: 03+2] build: Updating npm dependencies [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/625190 (owner: 10Libraryupgrader) [11:52:05] (03PS2) 10Umherirrender: build: Updating grunt to 1.3.0 [extensions/CognitiveProcessDesigner] - 10https://gerrit.wikimedia.org/r/625194 (owner: 10Libraryupgrader) [11:52:52] (03CR) 10Ammarpad: [C: 04-1] "> But what should extension do, which are using hook "SkinBuildSidebar" at the moment?" [skins/Vector] - 10https://gerrit.wikimedia.org/r/625127 (owner: 10Umherirrender) [11:53:09] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt to 1.3.0 [extensions/CognitiveProcessDesigner] - 10https://gerrit.wikimedia.org/r/625194 (owner: 10Libraryupgrader) [11:55:27] (03Merged) 10jenkins-bot: Remove hook ResourceLoaderTestModules [extensions/THICC] - 10https://gerrit.wikimedia.org/r/625185 (owner: 10Umherirrender) [11:56:16] 10Convenient-Discussions: Make it possible to tell if CD's comment form is open from browser tab's name - https://phabricator.wikimedia.org/T262073 (10Iniquity) I'm not entirely sure if this function is needed. Nobody seems to do this on any site. {F32246868} But if we really want to, then we can use `[]`, inst... [11:56:43] 10MediaWiki-extensions-Page_Forms: values from namespace does not use $wgPageFormsMaxLocalAutocompleteValues limit - https://phabricator.wikimedia.org/T262130 (10Oeyvindg) I've tried this diff from the github mirror which seems to solve the issue. I'm not sure how to work on gerrit or if there is a gitlab transi... [11:58:25] (03CR) 10Umherirrender: [C: 03+1] build: Updating npm dependencies [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/625208 (owner: 10Libraryupgrader) [11:58:48] (03PS1) 10Esanders: Add strtolower for tag name comparison [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/625210 [11:58:50] (03PS1) 10Esanders: Use tagName instead of nodeName when dealing with DOMElement [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/625211 [12:04:38] (03CR) 10Umherirrender: "> Patch Set 2:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/625127 (owner: 10Umherirrender) [12:10:41] (03CR) 10Umherirrender: [V: 03+2 C: 03+2] since it has an extension.json file, there's no need to do require_once to enable [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/623887 (owner: 10Reception123) [12:12:35] 10MediaWiki-Core-Skin-Architecture, 10Beta-Cluster-Infrastructure, 10MW-1.36-release: Undeploy DismissableSiteNotice from Wikimedia Beta Cluster - https://phabricator.wikimedia.org/T262122 (10Reedy) [12:12:37] 10Wikispeech-Jobrunner, 10Wikispeech-STTS, 10Wikispeech-Speech-Data-Collector: Figure out why two different runs of WikiExtractor.py used different paragraph delimiters? - https://phabricator.wikimedia.org/T262131 (10NikolajLindberg) [12:12:49] 10MediaWiki-Core-Skin-Architecture, 10Beta-Cluster-Infrastructure, 10Wikimedia-Site-requests: Undeploy DismissableSiteNotice from Wikimedia Beta Cluster - https://phabricator.wikimedia.org/T262122 (10Reedy) [12:14:22] (03CR) 10Ammarpad: [C: 04-1] "> https://www.mediawiki.org/wiki/Manual:Hooks/SkinBuildSidebar also is documented to use raw html. Not all extensions have a way to provid" [skins/Vector] - 10https://gerrit.wikimedia.org/r/625127 (owner: 10Umherirrender) [12:15:02] 10Humaniki, 10Gender-Support: Wikidata Humans and Gender Data Tools - https://phabricator.wikimedia.org/T230184 (10Aklapper) [12:19:25] (03PS3) 10Reedy: maintenance: Make use of BatchRowIterator::setCaller [core] - 10https://gerrit.wikimedia.org/r/624786 (https://phabricator.wikimedia.org/T261014) [12:21:01] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt to 1.3.0 [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/625214 (owner: 10Libraryupgrader) [12:21:10] 10Wikispeech-STTS, 10Wikispeech-Speech-Data-Collector, 10Wikispeech-Jobrunner (Sprint): Find out how to best extract raw text from Wikipedia articles (probably from a dump file) - https://phabricator.wikimedia.org/T261938 (10NikolajLindberg) [12:21:48] 10Wikispeech-STTS, 10Wikispeech-Speech-Data-Collector, 10Wikispeech-Jobrunner (Sprint): Find out how to best extract raw text from Wikipedia articles (probably from a dump file) - https://phabricator.wikimedia.org/T261938 (10NikolajLindberg) [12:23:54] 10MediaWiki-General, 10MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), 10Patch-For-Review: Make use of (BatchRowIterator|BatchRowWriter)::setCaller - https://phabricator.wikimedia.org/T261014 (10Reedy) And untag a few more... [12:25:56] (03CR) 10Umherirrender: "Failure unrelated" [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/625214 (owner: 10Libraryupgrader) [12:29:16] (03CR) 10jerkins-bot: [V: 04-1] build: Updating npm dependencies [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/625215 (owner: 10Libraryupgrader) [12:29:53] 10MediaWiki-Core-Skin-Architecture, 10ShoutWiki, 10ci-test-error: Extension NewsBox fails CI due to changes to the skin architecture - https://phabricator.wikimedia.org/T262133 (10Umherirrender) [12:30:17] (03PS3) 10Umherirrender: build: Updating grunt to 1.3.0 [extensions/NewsBox] - 10https://gerrit.wikimedia.org/r/624530 (owner: 10Libraryupgrader) [12:30:31] (03CR) 10Umherirrender: "See T262133 for the failure" [extensions/NewsBox] - 10https://gerrit.wikimedia.org/r/624530 (owner: 10Libraryupgrader) [12:33:20] 10MediaWiki-Core-Skin-Architecture, 10MediaWiki-extensions-WikiShare, 10ci-test-error: Extension WikiShare fails CI due to changes to the skin architecture - https://phabricator.wikimedia.org/T262134 (10Umherirrender) [12:33:31] (03PS3) 10Umherirrender: build: Updating grunt to 1.3.0 [extensions/WikiShare] - 10https://gerrit.wikimedia.org/r/625063 (owner: 10Libraryupgrader) [12:33:41] (03CR) 10Umherirrender: "See T262134 for the failure" [extensions/WikiShare] - 10https://gerrit.wikimedia.org/r/625063 (owner: 10Libraryupgrader) [12:34:02] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt to 1.3.0 [extensions/NewsBox] - 10https://gerrit.wikimedia.org/r/624530 (owner: 10Libraryupgrader) [12:34:03] 10MediaWiki-Core-Skin-Architecture, 10MediaWiki-extensions-Other, 10ci-test-error: Extension SidebarDonateBox fails CI due to changes to the skin architecture - https://phabricator.wikimedia.org/T262135 (10Umherirrender) [12:34:11] (03PS3) 10Umherirrender: build: Updating grunt to 1.3.0 [extensions/SidebarDonateBox] - 10https://gerrit.wikimedia.org/r/624891 (owner: 10Libraryupgrader) [12:34:24] (03CR) 10Umherirrender: "See T262135 for the failure" [extensions/SidebarDonateBox] - 10https://gerrit.wikimedia.org/r/624891 (owner: 10Libraryupgrader) [12:34:42] (03Abandoned) 10Umherirrender: Make content an array in SkinVector::buildSidebar [skins/Vector] - 10https://gerrit.wikimedia.org/r/625127 (owner: 10Umherirrender) [12:36:35] (03CR) 10Umherirrender: [C: 03+2] build: Updating npm dependencies [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/625219 (owner: 10Libraryupgrader) [12:36:59] (03PS4) 10Reedy: maintenance: Make use of BatchRowIterator::setCaller [core] - 10https://gerrit.wikimedia.org/r/624786 (https://phabricator.wikimedia.org/T261014) [12:37:06] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt to 1.3.0 [extensions/WikiShare] - 10https://gerrit.wikimedia.org/r/625063 (owner: 10Libraryupgrader) [12:37:11] (03CR) 10Umherirrender: "Failure unrelated" [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/625215 (owner: 10Libraryupgrader) [12:37:46] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt to 1.3.0 [extensions/SidebarDonateBox] - 10https://gerrit.wikimedia.org/r/624891 (owner: 10Libraryupgrader) [12:41:55] (03CR) 10Umherirrender: [C: 03+2] build: Updating npm dependencies [extensions/CreateRedirect] - 10https://gerrit.wikimedia.org/r/625222 (owner: 10Libraryupgrader) [12:45:07] (03PS5) 10Reedy: maintenance: Make use of BatchRowIterator::setCaller [core] - 10https://gerrit.wikimedia.org/r/624786 (https://phabricator.wikimedia.org/T261014) [12:50:13] 10Wikispeech-Jobrunner, 10Wikispeech-STTS, 10Wikispeech-Speech-Data-Collector: load_db tool should filter articles and sentences before adding to db - https://phabricator.wikimedia.org/T262115 (10NikolajLindberg) [12:52:34] (03PS6) 10Reedy: maintenance: Make use of BatchRowIterator::setCaller [core] - 10https://gerrit.wikimedia.org/r/624786 (https://phabricator.wikimedia.org/T261014) [12:55:18] (03PS7) 10Reedy: maintenance: Make use of BatchRowIterator::setCaller [core] - 10https://gerrit.wikimedia.org/r/624786 (https://phabricator.wikimedia.org/T261014) [12:56:24] (03PS1) 10Umherirrender: build: Add missing script to package.json [extensions/IPInfo] - 10https://gerrit.wikimedia.org/r/625234 [12:56:43] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt to 1.3.0 [extensions/DataTable2] - 10https://gerrit.wikimedia.org/r/625231 (owner: 10Libraryupgrader) [12:57:05] (03CR) 10Mainframe98: [C: 03+1] "Looks good. The user and page links could also be moved to the mustache template as they're just wrappers." [skins/Example] - 10https://gerrit.wikimedia.org/r/624802 (owner: 10Jdlrobson) [13:02:25] (03CR) 10Umherirrender: "Failure unrelated" [extensions/DataTable2] - 10https://gerrit.wikimedia.org/r/625231 (owner: 10Libraryupgrader) [13:04:46] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt to 1.3.0 [extensions/DebugMode] - 10https://gerrit.wikimedia.org/r/625236 (owner: 10Libraryupgrader) [13:05:17] 10MediaWiki-Core-Testing, 10Wikidata, 10Wikidata-Query-Service: CategoriesRdfTest mocks getCategoryIterator and getCategoryLinksIterator to be an array - https://phabricator.wikimedia.org/T262075 (10Reedy) 05Open→03Declined Adds complexity to the test for little gain... Other ways we can structure the ca... [13:05:19] 10MediaWiki-General, 10MW-1.36-notes (1.36.0-wmf.8; 2020-09-08), 10Patch-For-Review: Make use of (BatchRowIterator|BatchRowWriter)::setCaller - https://phabricator.wikimedia.org/T261014 (10Reedy) [13:06:36] (03CR) 10Umherirrender: "Failure unrelated" [extensions/DebugMode] - 10https://gerrit.wikimedia.org/r/625236 (owner: 10Libraryupgrader) [13:08:16] 10MediaWiki-extensions-Other, 10ci-test-error: Extension SidebarDonateBox fails CI: PHP Fatal error: Uncaught TypeError: Argument 2 passed to SkinVector::getMenuData() must be of the type array, string given - https://phabricator.wikimedia.org/T262135 (10Ammarpad) [13:09:08] 10ShoutWiki, 10ci-test-error: Extension NewsBox fails CI: PHP Fatal error: Uncaught TypeError: Argument 2 passed to SkinVector::getMenuData() must be of the type array, string given - https://phabricator.wikimedia.org/T262133 (10Ammarpad) [13:09:43] 10MediaWiki-extensions-WikiShare, 10ci-test-error: Extension WikiShare fails CI: PHP Fatal error: Uncaught TypeError: Argument 2 passed to SkinVector::getMenuData() must be of the type array, string given - https://phabricator.wikimedia.org/T262134 (10Ammarpad) [13:16:44] 10Convenient-Discussions: Make it possible to tell if CD's comment form is open from browser tab's name - https://phabricator.wikimedia.org/T262073 (10Jack_who_built_the_house) >>! In T262073#6438125, @Iniquity wrote: > I'm not entirely sure if this function is needed. Nobody seems to do this on any site. Well,... [13:17:08] 10MediaWiki-extensions-WikiShare, 10ci-test-error: Extension WikiShare fails CI: PHP Fatal error: Uncaught TypeError: Argument 2 passed to SkinVector::getMenuData() must be of the type array, string given - https://phabricator.wikimedia.org/T262134 (10Ammarpad) I have renamed these tasks to more correct title... [13:20:36] 10ShoutWiki, 10ci-test-error: Extension NewsBox fails CI: PHP Fatal error: Uncaught TypeError: Argument 2 passed to SkinVector::getMenuData() must be of the type array, string given - https://phabricator.wikimedia.org/T262133 (10Ammarpad) Renamed to more correct title. See T262134#6438231. I'll remain subscri... [13:21:29] 10MediaWiki-extensions-Other, 10ci-test-error: Extension SidebarDonateBox fails CI: PHP Fatal error: Uncaught TypeError: Argument 2 passed to SkinVector::getMenuData() must be of the type array, string given - https://phabricator.wikimedia.org/T262135 (10Ammarpad) Renamed to more correct title. See T262134#64... [13:23:25] 10Convenient-Discussions: Make it possible to tell if CD's comment form is open from browser tab's name - https://phabricator.wikimedia.org/T262073 (10Iniquity) >>! In T262073#6438228, @Jack_who_built_the_house wrote: >>>! In T262073#6438125, @Iniquity wrote: >> I'm not entirely sure if this function is needed.... [13:35:31] 10Phabricator: How do I edit a project description? - https://phabricator.wikimedia.org/T261442 (10Iniquity) @mmodell thanks :) [13:42:12] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt to 1.3.0 [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/625259 (owner: 10Libraryupgrader) [13:43:15] (03CR) 10Umherirrender: "Failure unrelated" [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/625259 (owner: 10Libraryupgrader) [13:50:17] 10Convenient-Discussions: Make it possible to tell if CD's comment form is open from browser tab's name - https://phabricator.wikimedia.org/T262073 (10Jack_who_built_the_house) If using an icon, the [[https://commons.wikimedia.org/wiki/OOUI_icons#edit|OOUI pencil icon]] could be used: | {F32246989} | {F32246991}... [13:52:26] (03CR) 10Umherirrender: [C: 03+2] build: Updating npm dependencies [extensions/Echo] - 10https://gerrit.wikimedia.org/r/625264 (owner: 10Libraryupgrader) [13:53:18] 10Convenient-Discussions: Make it possible to tell if CD's comment form is open from browser tab's name - https://phabricator.wikimedia.org/T262073 (10Jack_who_built_the_house) But the problem is, we would need to lay it on top of the existing icon, and there is plenty of them on Wikimedia wikis. [13:56:36] (03PS1) 10Zoranzoki21: Add phpcs and make it pass [extensions/MinimumNameLength] - 10https://gerrit.wikimedia.org/r/625268 [13:58:12] (03PS2) 10Zoranzoki21: Add phpcs and make it pass [extensions/MinimumNameLength] - 10https://gerrit.wikimedia.org/r/625268 [13:58:43] (03PS3) 10Zoranzoki21: Add phpcs and make it pass [extensions/MinimumNameLength] - 10https://gerrit.wikimedia.org/r/625268 [14:03:48] 10Platform Team Initiatives (API Gateway): Envoy API Gateway Implementation - https://phabricator.wikimedia.org/T254794 (10Naike) [14:03:53] 10Patch-For-Review, 10Platform Team Initiatives (API Gateway), 10Platform Team Sprints Board (Sprint 2), 10Platform Team Workboards (Green): API Gateway LVS Endpoint - https://phabricator.wikimedia.org/T254908 (10Naike) 05Resolved→03Open [14:58:26] 10MW-1.36-notes (1.36.0-wmf.5; 2020-08-18), 10Patch-For-Review, 10Platform Team Initiatives (MW REST API in PHP): Enable cross-origin resource sharing (CORS) for requests in Core REST API - https://phabricator.wikimedia.org/T232176 (10dbarratt) [15:12:43] 04(no projects): GWToolset: The media file URL could not be evaluated - https://phabricator.wikimedia.org/T262137 (10ChristianFerrer) [15:23:26] 10Wikispeech-Jobrunner, 10Wikispeech-STTS, 10Wikispeech-Speech-Data-Collector: chunkfeat punct as single characters not character sequence - https://phabricator.wikimedia.org/T262121 (10NikolajLindberg) 05Open→03Resolved [15:52:17] 10Wikimedia-Site-requests: Cannot open image on main pages of private wikis - https://phabricator.wikimedia.org/T244403 (101234qwer1234qwer4) [15:52:36] 10Wikimedia-Site-requests: Cannot open image on main pages of private wikis - https://phabricator.wikimedia.org/T244403 (101234qwer1234qwer4) [15:58:40] 10Wikimedia-Site-requests: Cannot open image on main pages of private wikis - https://phabricator.wikimedia.org/T244403 (101234qwer1234qwer4) [16:08:06] 10Wikimedia-Site-requests: Cannot open image on main pages of private wikis - https://phabricator.wikimedia.org/T244403 (101234qwer1234qwer4) My requests for affcomwiki and iegcomwiki were invalid, the image on the first intentionally links a page on the wiki instead of the file page, the one on the second links... [16:09:55] (03PS12) 10Dbarratt: Handle CORS preflight request and prevent anon users from unsafe methods [core] - 10https://gerrit.wikimedia.org/r/621900 (https://phabricator.wikimedia.org/T232176) [16:10:25] (03CR) 10jerkins-bot: [V: 04-1] Handle CORS preflight request and prevent anon users from unsafe methods [core] - 10https://gerrit.wikimedia.org/r/621900 (https://phabricator.wikimedia.org/T232176) (owner: 10Dbarratt) [16:14:52] (03PS13) 10Dbarratt: Handle CORS preflight request and prevent anon users from unsafe methods [core] - 10https://gerrit.wikimedia.org/r/621900 (https://phabricator.wikimedia.org/T232176) [16:15:01] (03CR) 10Umherirrender: [C: 03+2] build: Updating npm dependencies [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/625301 (owner: 10Libraryupgrader) [16:15:04] 10MediaWiki-General, 10Technical-Debt (Deprecation process): Remove printableversion mode - https://phabricator.wikimedia.org/T259141 (10AVRS) @Krinkle I am using an [[ https://ankiweb.net/shared/info/935264945 | Incremental Reading ]] add-on for Anki. There is no way to copy the URL from Anki (it is not reall... [16:16:22] (03PS5) 10Dbarratt: Add protection against CSRF attacks to the REST API [core] - 10https://gerrit.wikimedia.org/r/623130 (https://phabricator.wikimedia.org/T261053) [16:16:32] (03CR) 10Dbarratt: Add protection against CSRF attacks to the REST API (031 comment) [core] - 10https://gerrit.wikimedia.org/r/623130 (https://phabricator.wikimedia.org/T261053) (owner: 10Dbarratt) [16:19:35] (03PS14) 10Dbarratt: Handle CORS preflight request and prevent anon users from unsafe methods [core] - 10https://gerrit.wikimedia.org/r/621900 (https://phabricator.wikimedia.org/T232176) [16:22:58] (03PS15) 10Dbarratt: Handle CORS preflight request and prevent anon users from unsafe methods [core] - 10https://gerrit.wikimedia.org/r/621900 (https://phabricator.wikimedia.org/T232176) [16:32:38] 10Wikimedia Chat: policy for creating teams? - https://phabricator.wikimedia.org/T261685 (10Puik) The problem is in better organizing the conversations – for instance WMEE has a Slack workspace with 32 channels, I'm also running a project that has another Slack workspace with 30 channels. Creating different team... [16:35:28] (03CR) 10Dbarratt: "This obviously still needs tests, but please check the direction this is going. During implementation I realized that we may be able to ge" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/621900 (https://phabricator.wikimedia.org/T232176) (owner: 10Dbarratt) [16:37:14] (03CR) 10jerkins-bot: [V: 04-1] Add protection against CSRF attacks to the REST API [core] - 10https://gerrit.wikimedia.org/r/623130 (https://phabricator.wikimedia.org/T261053) (owner: 10Dbarratt) [16:39:01] (03PS16) 10Dbarratt: Handle CORS preflight request and prevent anon users from unsafe methods [core] - 10https://gerrit.wikimedia.org/r/621900 (https://phabricator.wikimedia.org/T232176) [16:39:36] (03CR) 10Dbarratt: Handle CORS preflight request and prevent anon users from unsafe methods (031 comment) [core] - 10https://gerrit.wikimedia.org/r/621900 (https://phabricator.wikimedia.org/T232176) (owner: 10Dbarratt) [16:48:05] (03PS1) 10Zoranzoki21: Add phpcs and make it pass [extensions/GooglePlaces] - 10https://gerrit.wikimedia.org/r/625302 [16:51:48] (03CR) 10jerkins-bot: [V: 04-1] Add phpcs and make it pass [extensions/GooglePlaces] - 10https://gerrit.wikimedia.org/r/625302 (owner: 10Zoranzoki21) [16:53:49] (03PS1) 10Zoranzoki21: Add phpcs and make it pass [extensions/GoogleSiteSearch] - 10https://gerrit.wikimedia.org/r/625303 [16:57:07] (03PS2) 10Zoranzoki21: Add phpcs and make it pass [extensions/GooglePlaces] - 10https://gerrit.wikimedia.org/r/625302 [16:57:57] (03PS17) 10Dbarratt: Handle CORS preflight request and prevent anon users from unsafe methods [core] - 10https://gerrit.wikimedia.org/r/621900 (https://phabricator.wikimedia.org/T232176) [16:57:59] (03CR) 10jerkins-bot: [V: 04-1] Handle CORS preflight request and prevent anon users from unsafe methods [core] - 10https://gerrit.wikimedia.org/r/621900 (https://phabricator.wikimedia.org/T232176) (owner: 10Dbarratt) [17:01:12] 10Wikimedia Chat: policy for creating teams? - https://phabricator.wikimedia.org/T261685 (10Puik) See also [Mattermost help on creating **teams**](https://docs.mattermost.com/help/getting-started/creating-teams.html). [17:05:17] 10Wikimedia Chat: policy for creating teams? - https://phabricator.wikimedia.org/T261685 (10Ladsgroup) I personally have no problem creating teams for wikimedia affiliates, I'm slightly worried it might turn into a slippery slope of replacing channels with teams but definitely each affiliate can have their own t... [17:10:32] 10WPCleaner: CW#92: Ignore categories when comparing content of the 2 sections - https://phabricator.wikimedia.org/T262143 (10NicoV) [17:17:37] 10Wikimedia Chat: policy for creating teams? - https://phabricator.wikimedia.org/T261685 (10Puik) There's this restriction about teams: > Integrations (e.g., webhooks and slash commands) are only persistent across single team deployments. Maybe [enabling the channel organization features](https://docs.mattermos... [17:20:34] (03CR) 10jerkins-bot: [V: 04-1] Handle CORS preflight request and prevent anon users from unsafe methods [core] - 10https://gerrit.wikimedia.org/r/621900 (https://phabricator.wikimedia.org/T232176) (owner: 10Dbarratt) [17:37:49] 10MediaWiki-Search, 10Discovery-Search: Don't focus on search input when displaying search results in Special:Search - https://phabricator.wikimedia.org/T215117 (10Lejonel) Should this really be low priority? It is a really annoying bug that was fixed in earlier search versions and worked fine but was then bro... [17:47:41] 10WPCleaner: Add CW#557: Detect missing space before internal link - https://phabricator.wikimedia.org/T257788 (10NicoV) @Bakertheacre [[ https://github.com/WPCleaner/wpcleaner/commit/d5fdb5e92d77da3f3f8ab898f72bf9270a5f456e | I've modified WPCleaner ]] to use a configurable list of allowed prefixes. [[ https:/... [17:53:25] (03CR) 10Ladsgroup: "> Patch Set 1:" [core] - 10https://gerrit.wikimedia.org/r/623120 (https://phabricator.wikimedia.org/T164898) (owner: 10Ladsgroup) [17:54:17] 10MediaWiki-extensions-GWToolset, 10Commons: The media file URL could not be evaluated - https://phabricator.wikimedia.org/T262137 (10Reedy) [18:03:18] (03PS3) 10Ladsgroup: Migrate langlinks to abstract schema [core] - 10https://gerrit.wikimedia.org/r/623112 (https://phabricator.wikimedia.org/T164898) [18:03:20] (03PS2) 10Ladsgroup: Migrate iwlinks to abstract schema [core] - 10https://gerrit.wikimedia.org/r/623120 (https://phabricator.wikimedia.org/T164898) [18:04:05] (03CR) 10Ladsgroup: "> Patch Set 1:" [core] - 10https://gerrit.wikimedia.org/r/623120 (https://phabricator.wikimedia.org/T164898) (owner: 10Ladsgroup) [18:05:45] (03CR) 10Ladsgroup: Migrate langlinks to abstract schema (032 comments) [core] - 10https://gerrit.wikimedia.org/r/623112 (https://phabricator.wikimedia.org/T164898) (owner: 10Ladsgroup) [18:16:41] (03CR) 10Ladsgroup: "check postgres" [core] - 10https://gerrit.wikimedia.org/r/623112 (https://phabricator.wikimedia.org/T164898) (owner: 10Ladsgroup) [18:16:47] (03CR) 10Ladsgroup: "check postgres" [core] - 10https://gerrit.wikimedia.org/r/623120 (https://phabricator.wikimedia.org/T164898) (owner: 10Ladsgroup) [18:34:24] (03PS1) 10Ladsgroup: Migrate category to abstract schema [core] - 10https://gerrit.wikimedia.org/r/625307 (https://phabricator.wikimedia.org/T164898) [18:36:40] (03CR) 10Ladsgroup: "check postgres" [core] - 10https://gerrit.wikimedia.org/r/625307 (https://phabricator.wikimedia.org/T164898) (owner: 10Ladsgroup) [18:46:10] 10WPCleaner: Java 8 - https://phabricator.wikimedia.org/T256456 (10NicoV) [18:46:12] 10WPCleaner: Java 7: Add a warning in GUI - https://phabricator.wikimedia.org/T261918 (10NicoV) 05Open→03Resolved a:03NicoV [[ https://github.com/WPCleaner/wpcleaner/commit/f80d294df91b2bbfdbde673bfb90f0beffceaf43 | Warning added ]]. [18:48:17] (03PS142) 10Urbanecm: Introduce backend class for blocking users [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) [18:48:45] (03CR) 10jerkins-bot: [V: 04-1] Introduce backend class for blocking users [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) (owner: 10Urbanecm) [18:49:28] (03PS2) 10Ladsgroup: Migrate category to abstract schema [core] - 10https://gerrit.wikimedia.org/r/625307 (https://phabricator.wikimedia.org/T164898) [18:49:48] (03CR) 10Ladsgroup: "check postgres" [core] - 10https://gerrit.wikimedia.org/r/625307 (https://phabricator.wikimedia.org/T164898) (owner: 10Ladsgroup) [18:57:20] (03PS143) 10Urbanecm: Introduce backend class for blocking users [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) [19:00:29] (03PS1) 10Dzahn: sync deploy script, add diff feature, change backup path [debs/wikistats] - 10https://gerrit.wikimedia.org/r/625308 [19:04:48] (03CR) 10Jforrester: [C: 03+2] build: Updating npm dependencies [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/625208 (owner: 10Libraryupgrader) [19:05:09] (03CR) 10Jforrester: [C: 03+2] Use extension registration key 'QUnitTestModule' [extensions/Sentry] - 10https://gerrit.wikimedia.org/r/625184 (owner: 10Umherirrender) [19:05:29] (03CR) 10Jforrester: [C: 03+2] Remove hook ResourceLoaderTestModules [extensions/FormWizard] - 10https://gerrit.wikimedia.org/r/625183 (owner: 10Umherirrender) [19:06:09] (03CR) 10Jforrester: [C: 03+2] Avoid deprecated Article::getTimestamp [extensions/LastModified] - 10https://gerrit.wikimedia.org/r/624682 (owner: 10Umherirrender) [19:06:16] (03PS1) 10Dzahn: fix metapedias updates and links [debs/wikistats] - 10https://gerrit.wikimedia.org/r/625309 (https://phabricator.wikimedia.org/T262112) [19:06:23] (03CR) 10Jforrester: [C: 03+2] Init relevant arrays in NamespaceRelations [extensions/NamespaceRelations] - 10https://gerrit.wikimedia.org/r/624722 (owner: 10Umherirrender) [19:06:49] (03CR) 10Dzahn: [C: 03+2] sync deploy script, add diff feature, change backup path [debs/wikistats] - 10https://gerrit.wikimedia.org/r/625308 (owner: 10Dzahn) [19:08:12] (03PS144) 10Urbanecm: Introduce backend class for blocking users [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) [19:08:14] (03CR) 10Jforrester: [C: 03+2] build: Updating npm dependencies [extensions/GlobalWatchlist] - 10https://gerrit.wikimedia.org/r/624360 (owner: 10Libraryupgrader) [19:09:11] (03CR) 10Jforrester: [C: 03+2] Avoid deprecated Article::exists [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/624756 (owner: 10Umherirrender) [19:09:32] (03CR) 10Jforrester: [C: 03+2] Use hook PageSaveComplete [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/624760 (owner: 10Umherirrender) [19:09:47] (03CR) 10Jforrester: [C: 03+2] Handle false from AdManager::getAdOutputFor [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/624762 (owner: 10Umherirrender) [19:09:49] (03PS2) 10Dzahn: fix metapedias updates and links [debs/wikistats] - 10https://gerrit.wikimedia.org/r/625309 (https://phabricator.wikimedia.org/T262112) [19:10:35] (03CR) 10Jforrester: [C: 03+2] Replace rev_user/rev_user_text database field [extensions/PagesList] - 10https://gerrit.wikimedia.org/r/624784 (owner: 10Umherirrender) [19:10:46] (03CR) 10Urbanecm: Introduce backend class for blocking users (0322 comments) [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) (owner: 10Urbanecm) [19:11:01] (03CR) 10Dzahn: [C: 03+2] fix metapedias updates and links [debs/wikistats] - 10https://gerrit.wikimedia.org/r/625309 (https://phabricator.wikimedia.org/T262112) (owner: 10Dzahn) [19:14:30] (03PS145) 10Urbanecm: Introduce backend class for blocking users [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) [19:15:20] (03PS1) 10Dzahn: add sync script to pull from VPS to local machine [debs/wikistats] - 10https://gerrit.wikimedia.org/r/625310 [19:16:07] (03CR) 10Dzahn: [C: 03+2] add sync script to pull from VPS to local machine [debs/wikistats] - 10https://gerrit.wikimedia.org/r/625310 (owner: 10Dzahn) [19:19:45] (03PS146) 10Urbanecm: Introduce backend class for blocking users [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) [19:24:05] (03CR) 10Jforrester: [C: 03+2] Fix database related function calls [extensions/Athena] - 10https://gerrit.wikimedia.org/r/624757 (owner: 10Umherirrender) [19:24:56] (03CR) 10Jforrester: [C: 03+2] Use hook RevisionFromEditComplete [extensions/SplitPrivateWiki] - 10https://gerrit.wikimedia.org/r/625133 (owner: 10Umherirrender) [19:25:39] (03CR) 10Jforrester: [C: 03+2] Fix case of class in extension.json for APIModules [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/625134 (owner: 10Umherirrender) [19:27:03] (03PS1) 10Dzahn: add more files to ignore to sync.sh [debs/wikistats] - 10https://gerrit.wikimedia.org/r/625312 [19:30:27] (03Merged) 10jenkins-bot: Use extension registration key 'QUnitTestModule' [extensions/Sentry] - 10https://gerrit.wikimedia.org/r/625184 (owner: 10Umherirrender) [19:30:29] (03Merged) 10jenkins-bot: Remove hook ResourceLoaderTestModules [extensions/FormWizard] - 10https://gerrit.wikimedia.org/r/625183 (owner: 10Umherirrender) [19:30:31] (03Merged) 10jenkins-bot: Avoid deprecated Article::getTimestamp [extensions/LastModified] - 10https://gerrit.wikimedia.org/r/624682 (owner: 10Umherirrender) [19:30:33] (03Merged) 10jenkins-bot: Init relevant arrays in NamespaceRelations [extensions/NamespaceRelations] - 10https://gerrit.wikimedia.org/r/624722 (owner: 10Umherirrender) [19:30:37] (03CR) 10jerkins-bot: [V: 04-1] Avoid deprecated Article::exists [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/624756 (owner: 10Umherirrender) [19:30:39] (03CR) 10jerkins-bot: [V: 04-1] Use hook PageSaveComplete [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/624760 (owner: 10Umherirrender) [19:30:41] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt to 1.3.0 [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/624414 (owner: 10Libraryupgrader) [19:30:43] (03Merged) 10jenkins-bot: Handle false from AdManager::getAdOutputFor [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/624762 (owner: 10Umherirrender) [19:30:45] (03Merged) 10jenkins-bot: Replace rev_user/rev_user_text database field [extensions/PagesList] - 10https://gerrit.wikimedia.org/r/624784 (owner: 10Umherirrender) [19:30:47] (03Merged) 10jenkins-bot: Fix database related function calls [extensions/Athena] - 10https://gerrit.wikimedia.org/r/624757 (owner: 10Umherirrender) [19:30:49] (03Merged) 10jenkins-bot: Use hook RevisionFromEditComplete [extensions/SplitPrivateWiki] - 10https://gerrit.wikimedia.org/r/625133 (owner: 10Umherirrender) [19:30:51] (03Merged) 10jenkins-bot: Fix case of class in extension.json for APIModules [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/625134 (owner: 10Umherirrender) [19:33:52] (03PS1) 10Umherirrender: build: Remove .jshintignore and .jshintrc [skins/mediawiki-strapping] - 10https://gerrit.wikimedia.org/r/625313 [19:34:46] (03PS1) 10Umherirrender: build: Remove .jshintrc [skins/webplatform] - 10https://gerrit.wikimedia.org/r/625314 [19:36:22] (03CR) 10Umherirrender: [V: 03+2] "Break dependency tree" [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/624756 (owner: 10Umherirrender) [19:36:57] (03CR) 10Umherirrender: [C: 03+2] "Resubmit" [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/624760 (owner: 10Umherirrender) [19:39:23] (03PS1) 10Umherirrender: build: Remove .jshintrc [extensions/FlickrAPI] - 10https://gerrit.wikimedia.org/r/625315 [19:40:12] (03Merged) 10jenkins-bot: Use hook PageSaveComplete [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/624760 (owner: 10Umherirrender) [19:40:25] (03PS1) 10Umherirrender: build: Remove .jshintrc [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/625316 [19:41:58] (03PS1) 10Umherirrender: build: Remove .jshintignore [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/625317 [19:42:59] (03PS1) 10Umherirrender: build: Remove .jshintrc [extensions/QuickResponse] - 10https://gerrit.wikimedia.org/r/625318 [19:44:08] (03PS1) 10Umherirrender: build: Cleanup jshint config in GruntFile.js [extensions/UILangCode] - 10https://gerrit.wikimedia.org/r/625319 [19:50:12] (03CR) 10Umherirrender: [C: 03+2] Add phpcs and make it pass [extensions/MinimumNameLength] - 10https://gerrit.wikimedia.org/r/625268 (owner: 10Zoranzoki21) [19:51:27] (03PS2) 10Umherirrender: Add phpcs and make it pass [extensions/GoogleSiteSearch] - 10https://gerrit.wikimedia.org/r/625303 (owner: 10Zoranzoki21) [19:52:08] (03CR) 10Umherirrender: [C: 03+2] "I have added a newline at end of the .phpcs.xml" [extensions/GoogleSiteSearch] - 10https://gerrit.wikimedia.org/r/625303 (owner: 10Zoranzoki21) [19:53:17] (03Merged) 10jenkins-bot: Add phpcs and make it pass [extensions/MinimumNameLength] - 10https://gerrit.wikimedia.org/r/625268 (owner: 10Zoranzoki21) [19:55:21] (03Merged) 10jenkins-bot: Add phpcs and make it pass [extensions/GoogleSiteSearch] - 10https://gerrit.wikimedia.org/r/625303 (owner: 10Zoranzoki21) [19:55:41] (03CR) 10Umherirrender: Add phpcs and make it pass (032 comments) [extensions/GooglePlaces] - 10https://gerrit.wikimedia.org/r/625302 (owner: 10Zoranzoki21) [20:01:55] (03CR) 10DannyS712: Introduce backend class for blocking users (0310 comments) [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) (owner: 10Urbanecm) [20:05:43] 10MediaWiki-extensions-OAuth, 10Platform Team Initiatives (API Gateway), 10Platform Team Workboards (S&F Workboard): CORS not enabled for OAuth 2.0 - https://phabricator.wikimedia.org/T245474 (10eprodromou) >>! In T245474#6437372, @eprodromou wrote: > > Yeah, the OAuth 2.0 endpoints aren't authenticated. Th... [20:13:53] 10MediaWiki-extensions-OAuth, 10Platform Team Initiatives (API Gateway), 10Platform Team Workboards (S&F Workboard): CORS not enabled for OAuth 2.0 - https://phabricator.wikimedia.org/T245474 (10dbarratt) >>! In T245474#6438414, @eprodromou wrote: >>>! In T245474#6437372, @eprodromou wrote: >> >> Yeah, the O... [20:23:21] (03PS18) 10Dbarratt: Handle CORS preflight request and prevent anon users from unsafe methods [core] - 10https://gerrit.wikimedia.org/r/621900 (https://phabricator.wikimedia.org/T232176) [20:43:48] (03CR) 10jerkins-bot: [V: 04-1] Handle CORS preflight request and prevent anon users from unsafe methods [core] - 10https://gerrit.wikimedia.org/r/621900 (https://phabricator.wikimedia.org/T232176) (owner: 10Dbarratt) [20:49:39] (03PS19) 10Dbarratt: Handle CORS preflight request and prevent anon users from unsafe methods [core] - 10https://gerrit.wikimedia.org/r/621900 (https://phabricator.wikimedia.org/T232176) [21:09:23] (03CR) 10jerkins-bot: [V: 04-1] Handle CORS preflight request and prevent anon users from unsafe methods [core] - 10https://gerrit.wikimedia.org/r/621900 (https://phabricator.wikimedia.org/T232176) (owner: 10Dbarratt) [21:11:08] 10MediaWiki-extensions-Linter: Additional sort/filter options for Special:LintErrors ( Filter structural vs Cosmetic missing tags; sort by page views; filter by Template called) - https://phabricator.wikimedia.org/T260782 (10ShakespeareFan00) [21:12:50] 10MediaWiki-extensions-General, 10Patch-For-Review, 10good first task: Replace usage of jshint and/or jscs with eslint in MediaWiki extensions (clonable) - https://phabricator.wikimedia.org/T210365 (10Umherirrender) [21:13:30] (03PS1) 10Umherirrender: build: Replace jshint/jsonlint with eslint [extensions/SocialLogin] - 10https://gerrit.wikimedia.org/r/625320 (https://phabricator.wikimedia.org/T210365) [21:13:48] (03PS1) 10Umherirrender: build: Replace jshint/jsonlint with eslint [extensions/Buggy] - 10https://gerrit.wikimedia.org/r/625321 (https://phabricator.wikimedia.org/T210365) [21:14:00] (03PS1) 10Umherirrender: build: Replace jshint/jsonlint with eslint [extensions/CreatePage] - 10https://gerrit.wikimedia.org/r/625323 (https://phabricator.wikimedia.org/T210365) [21:17:38] (03CR) 10Jforrester: [C: 03+2] build: Replace jshint/jsonlint with eslint [extensions/SocialLogin] - 10https://gerrit.wikimedia.org/r/625320 (https://phabricator.wikimedia.org/T210365) (owner: 10Umherirrender) [21:18:16] (03CR) 10Jforrester: [C: 03+2] build: Add missing script to package.json [extensions/IPInfo] - 10https://gerrit.wikimedia.org/r/625234 (owner: 10Umherirrender) [21:18:23] (03CR) 10Jforrester: [C: 03+2] build: Remove .jshintignore and .jshintrc [skins/mediawiki-strapping] - 10https://gerrit.wikimedia.org/r/625313 (owner: 10Umherirrender) [21:18:28] (03CR) 10Jforrester: [C: 03+2] build: Remove .jshintrc [skins/webplatform] - 10https://gerrit.wikimedia.org/r/625314 (owner: 10Umherirrender) [21:18:33] (03CR) 10Jforrester: [C: 03+2] build: Remove .jshintrc [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/625316 (owner: 10Umherirrender) [21:18:42] (03CR) 10Jforrester: [C: 03+2] build: Remove .jshintignore [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/625317 (owner: 10Umherirrender) [21:18:47] (03CR) 10Jforrester: [C: 03+2] build: Remove .jshintrc [extensions/FlickrAPI] - 10https://gerrit.wikimedia.org/r/625315 (owner: 10Umherirrender) [21:18:53] (03CR) 10Jforrester: [C: 03+2] build: Remove .jshintrc [extensions/QuickResponse] - 10https://gerrit.wikimedia.org/r/625318 (owner: 10Umherirrender) [21:19:08] (03CR) 10Jforrester: [C: 03+2] build: Cleanup jshint config in GruntFile.js [extensions/UILangCode] - 10https://gerrit.wikimedia.org/r/625319 (owner: 10Umherirrender) [21:20:26] (03CR) 10Jforrester: [C: 03+2] build: Replace jshint/jsonlint with eslint [extensions/Buggy] - 10https://gerrit.wikimedia.org/r/625321 (https://phabricator.wikimedia.org/T210365) (owner: 10Umherirrender) [21:20:43] (03CR) 10Jforrester: [C: 03+2] build: Replace jshint/jsonlint with eslint [extensions/CreatePage] - 10https://gerrit.wikimedia.org/r/625323 (https://phabricator.wikimedia.org/T210365) (owner: 10Umherirrender) [21:21:28] (03Merged) 10jenkins-bot: build: Replace jshint/jsonlint with eslint [extensions/SocialLogin] - 10https://gerrit.wikimedia.org/r/625320 (https://phabricator.wikimedia.org/T210365) (owner: 10Umherirrender) [21:22:58] (03PS1) 10Umherirrender: build: Replace jshint/jsonlint with eslint [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/625324 (https://phabricator.wikimedia.org/T210365) [21:24:15] (03Merged) 10jenkins-bot: build: Add missing script to package.json [extensions/IPInfo] - 10https://gerrit.wikimedia.org/r/625234 (owner: 10Umherirrender) [21:24:27] (03Merged) 10jenkins-bot: build: Remove .jshintignore and .jshintrc [skins/mediawiki-strapping] - 10https://gerrit.wikimedia.org/r/625313 (owner: 10Umherirrender) [21:24:29] (03Merged) 10jenkins-bot: build: Remove .jshintrc [skins/webplatform] - 10https://gerrit.wikimedia.org/r/625314 (owner: 10Umherirrender) [21:24:31] (03Merged) 10jenkins-bot: build: Remove .jshintrc [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/625316 (owner: 10Umherirrender) [21:24:33] (03Merged) 10jenkins-bot: build: Remove .jshintignore [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/625317 (owner: 10Umherirrender) [21:24:35] (03Merged) 10jenkins-bot: build: Remove .jshintrc [extensions/FlickrAPI] - 10https://gerrit.wikimedia.org/r/625315 (owner: 10Umherirrender) [21:24:37] (03Merged) 10jenkins-bot: build: Remove .jshintrc [extensions/QuickResponse] - 10https://gerrit.wikimedia.org/r/625318 (owner: 10Umherirrender) [21:24:39] (03Merged) 10jenkins-bot: build: Cleanup jshint config in GruntFile.js [extensions/UILangCode] - 10https://gerrit.wikimedia.org/r/625319 (owner: 10Umherirrender) [21:28:29] (03PS1) 10Umherirrender: build: Replace jshint/jsonlint with eslint [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/625326 (https://phabricator.wikimedia.org/T210365) [21:29:56] (03CR) 10Jforrester: [C: 03+2] build: Replace jshint/jsonlint with eslint [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/625324 (https://phabricator.wikimedia.org/T210365) (owner: 10Umherirrender) [21:31:19] (03CR) 10Jforrester: [C: 03+2] build: Replace jshint/jsonlint with eslint [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/625326 (https://phabricator.wikimedia.org/T210365) (owner: 10Umherirrender) [21:34:25] (03PS1) 10Umherirrender: build: Replace jshint/jsonlint with eslint [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/625328 (https://phabricator.wikimedia.org/T210365) [21:38:22] (03CR) 10Jforrester: [C: 03+2] Replace wfGetDB with LoadBalancer in LinkCache service [core] - 10https://gerrit.wikimedia.org/r/620114 (owner: 10Umherirrender) [21:39:34] (03CR) 10Jforrester: [C: 03+2] build: Replace jshint/jsonlint with eslint [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/625328 (https://phabricator.wikimedia.org/T210365) (owner: 10Umherirrender) [21:41:01] (03PS1) 10Umherirrender: build: Replace jshint/jsonlint with eslint [extensions/InlineCategorizer] - 10https://gerrit.wikimedia.org/r/625329 (https://phabricator.wikimedia.org/T210365) [21:43:44] (03Merged) 10jenkins-bot: build: Replace jshint/jsonlint with eslint [extensions/Buggy] - 10https://gerrit.wikimedia.org/r/625321 (https://phabricator.wikimedia.org/T210365) (owner: 10Umherirrender) [21:43:46] (03Merged) 10jenkins-bot: build: Replace jshint/jsonlint with eslint [extensions/CreatePage] - 10https://gerrit.wikimedia.org/r/625323 (https://phabricator.wikimedia.org/T210365) (owner: 10Umherirrender) [21:43:48] (03Merged) 10jenkins-bot: build: Replace jshint/jsonlint with eslint [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/625324 (https://phabricator.wikimedia.org/T210365) (owner: 10Umherirrender) [21:43:50] (03Merged) 10jenkins-bot: build: Replace jshint/jsonlint with eslint [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/625326 (https://phabricator.wikimedia.org/T210365) (owner: 10Umherirrender) [21:57:17] (03Merged) 10jenkins-bot: Replace wfGetDB with LoadBalancer in LinkCache service [core] - 10https://gerrit.wikimedia.org/r/620114 (owner: 10Umherirrender) [21:57:19] (03Merged) 10jenkins-bot: build: Replace jshint/jsonlint with eslint [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/625328 (https://phabricator.wikimedia.org/T210365) (owner: 10Umherirrender) [22:09:04] (03PS1) 10Umherirrender: build: Replace jshint/jsonlint with eslint [extensions/LifeWeb] - 10https://gerrit.wikimedia.org/r/625330 (https://phabricator.wikimedia.org/T210365) [22:10:59] (03PS2) 10Dzahn: add more files to ignore to sync.sh [debs/wikistats] - 10https://gerrit.wikimedia.org/r/625312 [22:11:38] (03PS1) 10Umherirrender: build: Replace jshint/jsonlint with eslint [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/625331 (https://phabricator.wikimedia.org/T210365) [22:14:30] (03CR) 10jerkins-bot: [V: 04-1] build: Replace jshint/jsonlint with eslint [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/625331 (https://phabricator.wikimedia.org/T210365) (owner: 10Umherirrender) [22:15:21] (03PS1) 10Umherirrender: build: Replace jshint/jsonlint with eslint [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/625332 (https://phabricator.wikimedia.org/T210365) [22:19:21] (03PS3) 10Dzahn: add more files to ignore to sync.sh [debs/wikistats] - 10https://gerrit.wikimedia.org/r/625312 [22:19:27] (03PS1) 10Umherirrender: build: Replace jshint/jsonlint with eslint [extensions/LinkSuggest] - 10https://gerrit.wikimedia.org/r/625333 (https://phabricator.wikimedia.org/T210365) [22:20:47] (03PS1) 10Umherirrender: build: Replace jshint/jsonlint with eslint [extensions/MixedNamespaceSearchSuggestions] - 10https://gerrit.wikimedia.org/r/625334 (https://phabricator.wikimedia.org/T210365) [22:24:47] (03PS1) 10Umherirrender: build: Replace jshint/jsonlint with eslint [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/625335 (https://phabricator.wikimedia.org/T210365) [22:25:39] (03PS1) 10Umherirrender: build: Replace jshint/jsonlint with eslint [extensions/NamespacePopups] - 10https://gerrit.wikimedia.org/r/625336 (https://phabricator.wikimedia.org/T210365) [22:28:17] (03PS1) 10Umherirrender: build: Replace jshint/jsonlint with eslint [extensions/OOJsUIAjaxLogin] - 10https://gerrit.wikimedia.org/r/625337 (https://phabricator.wikimedia.org/T210365) [22:29:29] (03PS1) 10Umherirrender: build: Replace jshint/jsonlint with eslint [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/625338 (https://phabricator.wikimedia.org/T210365) [22:31:54] (03PS1) 10Umherirrender: build: Replace jshint/jsonlint with eslint [extensions/PagePopups] - 10https://gerrit.wikimedia.org/r/625339 (https://phabricator.wikimedia.org/T210365) [22:32:48] (03CR) 10jerkins-bot: [V: 04-1] build: Replace jshint/jsonlint with eslint [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/625338 (https://phabricator.wikimedia.org/T210365) (owner: 10Umherirrender) [22:44:27] (03PS1) 10Umherirrender: build: Replace jshint/jsonlint with eslint [extensions/Survey] - 10https://gerrit.wikimedia.org/r/625340 (https://phabricator.wikimedia.org/T210365) [22:55:57] (03PS1) 10Umherirrender: build: Replace jshint/jsonlint with eslint [extensions/SVGEdit] - 10https://gerrit.wikimedia.org/r/625341 (https://phabricator.wikimedia.org/T210365) [23:01:38] (03PS1) 10Umherirrender: onSpecialPage_initList should not depend on user [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/625342 [23:05:42] (03PS1) 10Umherirrender: Avoid deprecated Revision::newFromTitle/newFromId [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/625343 [23:06:25] (03PS2) 10Umherirrender: build: Updating grunt to 1.3.0 [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/624597 (owner: 10Libraryupgrader) [23:07:07] (03PS2) 10Umherirrender: build: Replace jshint/jsonlint with eslint [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/625338 (https://phabricator.wikimedia.org/T210365) [23:07:41] (03PS2) 10Umherirrender: Avoid deprecated Revision::newFromTitle/newFromId [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/625343 [23:10:56] 10MediaWiki-API, 10MediaWiki-extensions-CentralAuth, 10GlobalBlocking, 10Platform Engineering: API: Make list=users display status of globally blocked users - https://phabricator.wikimedia.org/T261752 (10JzG) +1 for this please [23:11:28] (03PS2) 10Umherirrender: build: Updating grunt to 1.3.0 [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/624448 (owner: 10Libraryupgrader) [23:14:27] (03PS1) 10Esanders: Fix variable order in assertions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/625344 [23:14:29] (03PS1) 10Esanders: Ignore template styles when looking for lead paragraph [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/625345 [23:14:31] (03PS1) 10Esanders: Rewite MoveLeadParagraphTransform based on mobile apps approach [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/625346 (https://phabricator.wikimedia.org/T262093) [23:17:51] (03PS3) 10Umherirrender: Decouple PageProps service from Title::getArticleID [core] - 10https://gerrit.wikimedia.org/r/620113 [23:18:29] (03CR) 10Umherirrender: "Rebased (conflict with Ic0394389f7f9fc403b73945af5e7f22f4f2c0641)" [core] - 10https://gerrit.wikimedia.org/r/620113 (owner: 10Umherirrender) [23:21:22] (03PS3) 10Umherirrender: Deprecate SpecialPageFactory::getTitleForAlias [core] - 10https://gerrit.wikimedia.org/r/619121 [23:21:39] (03CR) 10Umherirrender: "Rebased (conflict in release notes)" [core] - 10https://gerrit.wikimedia.org/r/619121 (owner: 10Umherirrender) [23:22:08] (03PS3) 10Umherirrender: Use SpecialPageFactory in DefaultPreferencesFactory [core] - 10https://gerrit.wikimedia.org/r/619122 [23:23:25] (03Abandoned) 10Umherirrender: Sort $specialPageAliases and $magicWords in message files [core] - 10https://gerrit.wikimedia.org/r/606800 (https://phabricator.wikimedia.org/T255826) (owner: 10Umherirrender) [23:23:43] (03PS4) 10Dzahn: add more files to ignore to sync.sh, fix rsync --exclude [debs/wikistats] - 10https://gerrit.wikimedia.org/r/625312 [23:25:47] (03PS5) 10Dzahn: add more files to ignore to sync.sh, fix rsync --exclude [debs/wikistats] - 10https://gerrit.wikimedia.org/r/625312 [23:26:45] (03PS3) 10Umherirrender: Use LinkBatchFactory in pagers, special pages and actions [core] - 10https://gerrit.wikimedia.org/r/619069 [23:27:11] (03CR) 10Umherirrender: "Rebased (conflict with I114c6f77e86ad81b1810fedcd49f52c88700ca16)" [core] - 10https://gerrit.wikimedia.org/r/619069 (owner: 10Umherirrender) [23:28:30] (03PS3) 10Umherirrender: Use LinkBatchFactory in Special:CheckUser(Log) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/619068 [23:28:45] (03CR) 10Umherirrender: "Rebased (conflict with I6654d4dcb8ac5c62e8c72fe00b8cdaf175a95812)" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/619068 (owner: 10Umherirrender) [23:29:39] (03PS4) 10Umherirrender: Use LinkBatchFactory in Special:CheckUser(Log) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/619068 [23:30:11] (03PS5) 10Umherirrender: Use LinkBatchFactory in Special:CheckUser(Log) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/619068 [23:30:25] (03CR) 10Umherirrender: "Fixed rebase" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/619068 (owner: 10Umherirrender) [23:31:37] (03PS4) 10Umherirrender: Use SpecialPageFactory in changes list/tags related classes [core] - 10https://gerrit.wikimedia.org/r/619132 [23:31:42] (03PS2) 10Umherirrender: Use SpecialPageFactory in logging classes [core] - 10https://gerrit.wikimedia.org/r/619127 [23:31:52] (03CR) 10Dzahn: [C: 03+2] add more files to ignore to sync.sh, fix rsync --exclude [debs/wikistats] - 10https://gerrit.wikimedia.org/r/625312 (owner: 10Dzahn) [23:32:05] (03PS2) 10Umherirrender: Use SpecialPageFactory in AuthManager [core] - 10https://gerrit.wikimedia.org/r/619123 [23:34:24] (03CR) 10jerkins-bot: [V: 04-1] Rewite MoveLeadParagraphTransform based on mobile apps approach [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/625346 (https://phabricator.wikimedia.org/T262093) (owner: 10Esanders) [23:38:20] (03CR) 10jerkins-bot: [V: 04-1] Ignore template styles when looking for lead paragraph [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/625345 (owner: 10Esanders) [23:43:44] (03PS2) 10Umherirrender: Use SpecialPageFactory in action classes [core] - 10https://gerrit.wikimedia.org/r/619125 [23:43:55] (03CR) 10Umherirrender: "Rebased" [core] - 10https://gerrit.wikimedia.org/r/619125 (owner: 10Umherirrender)