[00:01:18] (03CR) 10Krinkle: Performance: Reduce DB writes (031 comment) [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/598132 (owner: 10Physikerwelt) [00:04:18] (03CR) 10Krinkle: content: Add hidden preference to disable PST on CSS/JS content (031 comment) [core] - 10https://gerrit.wikimedia.org/r/585811 (https://phabricator.wikimedia.org/T236828) (owner: 10C. Scott Ananian) [00:04:52] 10Research: Exploration on content propagation across Wikimedia projects. - https://phabricator.wikimedia.org/T252933 (10diego) [00:10:47] (03CR) 10DannyS712: content: Add hidden preference to disable PST on CSS/JS content (031 comment) [core] - 10https://gerrit.wikimedia.org/r/585811 (https://phabricator.wikimedia.org/T236828) (owner: 10C. Scott Ananian) [00:11:08] (03PS2) 10Ori.livneh: mime: Add test for MimeAnalyzer::addExtra{Types,Info} [core] - 10https://gerrit.wikimedia.org/r/598129 [00:14:31] (03CR) 10DannyS712: mime: Add test for MimeAnalyzer::addExtra{Types,Info} (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598129 (owner: 10Ori.livneh) [00:15:19] (03CR) 10Krinkle: VueComponentParser: Use RemexHtml instead of PHP's HTML parser (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598133 (https://phabricator.wikimedia.org/T253334) (owner: 10Catrope) [00:16:41] (03CR) 10DannyS712: Use HTML5 semantics for self-closed HTML tags in wikitext (031 comment) [core] - 10https://gerrit.wikimedia.org/r/585519 (https://phabricator.wikimedia.org/T134423) (owner: 10C. Scott Ananian) [00:17:43] (03CR) 10Krinkle: VueComponentParser: Use RemexHtml instead of PHP's HTML parser (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598133 (https://phabricator.wikimedia.org/T253334) (owner: 10Catrope) [00:20:17] (03PS6) 10Krinkle: mediawiki.util: Add mw.util.parseImageUrl [core] - 10https://gerrit.wikimedia.org/r/598115 (https://phabricator.wikimedia.org/T244210) (owner: 10Gergő Tisza) [00:20:18] (03CR) 10Krinkle: [C: 03+2] mediawiki.util: Add mw.util.parseImageUrl [core] - 10https://gerrit.wikimedia.org/r/598115 (https://phabricator.wikimedia.org/T244210) (owner: 10Gergő Tisza) [00:22:08] (03CR) 10Krinkle: mime: Add test for MimeAnalyzer::addExtra{Types,Info} (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598129 (owner: 10Ori.livneh) [00:22:08] (03PS1) 10Scardenasmolinar: Ajax watch: Move JS config var to packageFiles [core] - 10https://gerrit.wikimedia.org/r/598136 (https://phabricator.wikimedia.org/T249259) [00:22:28] 10Wikimedia-GitHub: For mirrored GitHub repositories, actually give the canonical source Gerrit URL in the repo description - https://phabricator.wikimedia.org/T109939 (10bd808) >>! In T109939#4217488, @jayvdb wrote: > We could use github repo topics to identify the repos which are active on github. I think thi... [00:30:09] (03CR) 10Krinkle: [C: 04-1] "Per PS13, hook in buildNavUrls() still breaking its contract." [core] - 10https://gerrit.wikimedia.org/r/596756 (https://phabricator.wikimedia.org/T252917) (owner: 10Jdlrobson) [00:30:52] 10MediaWiki-Documentation, 10MediaWiki-File-management, 10Documentation, 10MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), 10Patch-For-Review: Add includes/filebackend/README as generated documentation page - https://phabricator.wikimedia.org/T87796 (10apaskulin) 05Open→03Resolved [00:32:46] 10MediaWiki-User-management, 10Core Platform Team, 10Dependency injection, 10User-DannyS712: Move information about user edits to a new service - https://phabricator.wikimedia.org/T253431 (10DannyS712) [00:33:02] (03CR) 10Ori.livneh: upload: Fix incorrect handling of missing file extension in UploadStash (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598100 (owner: 10Ori.livneh) [00:34:01] (03CR) 10Krinkle: NamespaceInfo: Throw specifically if called on a non-int namespace (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598117 (https://phabricator.wikimedia.org/T253098) (owner: 10Jforrester) [00:34:02] (03CR) 10Krinkle: NamespaceInfo: Throw specifically if called on a non-int namespace (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598117 (https://phabricator.wikimedia.org/T253098) (owner: 10Jforrester) [00:38:05] 10MediaWiki-User-management, 10Core Platform Team, 10Dependency injection, 10User-DannyS712: Move information about user edits to a new service - https://phabricator.wikimedia.org/T253431 (10DannyS712) [00:39:10] (03Merged) 10jenkins-bot: mediawiki.util: Add mw.util.parseImageUrl [core] - 10https://gerrit.wikimedia.org/r/598115 (https://phabricator.wikimedia.org/T244210) (owner: 10Gergő Tisza) [00:40:29] 10Editing-team (Tracking), 10OWC2020 (OWC2020 Replying 2.0): Show aliases in username completion list - https://phabricator.wikimedia.org/T250329 (10ppelberg) >>! In T250329#6114626, @Pelagic wrote: > To remove the ambiguity, you could display //both// names in a 2-column drop-down. [SD post vkpxssh1ty6lue6t](... [00:41:05] 10Research: Exploration on content propagation across Wikimedia projects. - https://phabricator.wikimedia.org/T252933 (10diego) Week Update: - Testing Multivariable LSTM: implementation uses not just the order of creation of languages for each wiki item, but also inputs the interval between the creation of t... [00:41:13] 10Editing-team (Tracking), 10OWC2020 (OWC2020 Replying 2.0): Show aliases in username completion list - https://phabricator.wikimedia.org/T250329 (10ppelberg) Helpful context @Whatamidoing-WMF shared [here](https://www.mediawiki.org/w/index.php?title=Topic:Vju7lfcav875rt8r&topic_showPostId=vlg2qj6szwee3lgr#flo... [00:42:10] (03CR) 10Mooeypoo: Ajax watch: Move JS config var to packageFiles (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598136 (https://phabricator.wikimedia.org/T249259) (owner: 10Scardenasmolinar) [00:43:07] (03CR) 10Jdlrobson: Treat languages and toolbox like other sidebar links (031 comment) [core] - 10https://gerrit.wikimedia.org/r/596756 (https://phabricator.wikimedia.org/T252917) (owner: 10Jdlrobson) [00:44:23] (03CR) 10Scardenasmolinar: Ajax watch: Move JS config var to packageFiles (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598136 (https://phabricator.wikimedia.org/T249259) (owner: 10Scardenasmolinar) [00:46:01] (03CR) 10Catrope: Ajax watch: Move JS config var to packageFiles (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598136 (https://phabricator.wikimedia.org/T249259) (owner: 10Scardenasmolinar) [00:47:27] (03CR) 10Krinkle: Ajax watch: Move JS config var to packageFiles (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598136 (https://phabricator.wikimedia.org/T249259) (owner: 10Scardenasmolinar) [00:47:40] 10Research (FY2019-20-Research-January-March): Measuring the consistency of information between Wikipedia articles and Wikidata items. - https://phabricator.wikimedia.org/T243256 (10diego) ** Weekly Updates ** - Finalizing the hiring for the intern. - Defining two ML tasks: - **Coverage** is about the overlap... [00:48:15] mooeypoo: sorry :P [00:48:38] And yes, this is relatively new. Credit to Roan for making this happen. [00:49:27] 10Research (FY2019-20-Research-January-March): Build 2 sets of Formal Collaborations to expand our capacity for working on prioritized disinformation projects; - https://phabricator.wikimedia.org/T252451 (10diego) ** Weekly update** * Announced the Collaboration with IBS on wiki-research-l * Created a placehold... [00:49:58] Ha Krinkle commented about the same thing as me, but better / more eloquently [00:50:19] (03CR) 10Krinkle: [C: 03+2] upload: Fix incorrect handling of missing file extension in UploadStash (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598100 (owner: 10Ori.livneh) [00:51:11] RoanKattouw: maybe we should go all-in on T193826 for core [00:51:12] T193826: Organise module files in directories based on their module name - https://phabricator.wikimedia.org/T193826 [00:51:28] I've held off so far so that each one is done "nicely" but maybe a bolder first step would still be useful. [00:53:32] 10MediaWiki-ResourceLoader, 10Front-end-Standards-Group, 10MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), 10Performance-Team (Radar): Organise module files in directories based on their module name - https://phabricator.wikimedia.org/T193826 (10Krinkle) [00:54:20] (03CR) 10Mooeypoo: Ajax watch: Move JS config var to packageFiles (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598136 (https://phabricator.wikimedia.org/T249259) (owner: 10Scardenasmolinar) [00:57:03] (03CR) 10Mooeypoo: [C: 03+2] "lgtm, and thanks all for the input" [core] - 10https://gerrit.wikimedia.org/r/598136 (https://phabricator.wikimedia.org/T249259) (owner: 10Scardenasmolinar) [01:09:02] (03Merged) 10jenkins-bot: upload: Fix incorrect handling of missing file extension in UploadStash [core] - 10https://gerrit.wikimedia.org/r/598100 (owner: 10Ori.livneh) [01:12:31] (03Merged) 10jenkins-bot: Ajax watch: Move JS config var to packageFiles [core] - 10https://gerrit.wikimedia.org/r/598136 (https://phabricator.wikimedia.org/T249259) (owner: 10Scardenasmolinar) [01:19:01] 10Projects-Cleanup: mw:Template:Archived (extension|skin): add new "task" field - https://phabricator.wikimedia.org/T204489 (10Pppery) Coded in the sandbox of the templates in question, see https://www.mediawiki.org/w/index.php?title=Project:Sandbox&oldid=3871698 [01:28:20] 10MediaWiki-User-management, 10Core Platform Team, 10Dependency injection, 10User-DannyS712: Create a User factory - https://phabricator.wikimedia.org/T253432 (10DannyS712) [01:31:40] (03PS1) 10Krinkle: resources: Bundle ajax patrol and ajax rollback code [core] - 10https://gerrit.wikimedia.org/r/598137 [01:34:04] (03PS1) 10Krinkle: Update use of internal 'mediawiki.page.patrol.ajax' module [extensions/Flow] - 10https://gerrit.wikimedia.org/r/598138 [01:34:32] (03CR) 10Krinkle: "There is one pointer to the patrol.js module in Flow, to be updated after this lands with https://gerrit.wikimedia.org/r/#/c/mediawiki/ext" [core] - 10https://gerrit.wikimedia.org/r/598137 (owner: 10Krinkle) [01:40:54] 04(no projects): Web installer CSS fails with ServiceDisabledException - https://phabricator.wikimedia.org/T253433 (10tstarling) [01:42:13] (03PS1) 10Tim Starling: Fix failure of web installer CSS due to main stash [core] - 10https://gerrit.wikimedia.org/r/598139 (https://phabricator.wikimedia.org/T253433) [01:42:24] (03PS1) 10DannyS712: [WIP] UserFactory [core] - 10https://gerrit.wikimedia.org/r/598140 [01:43:09] 10MediaWiki-Installer, 10Patch-For-Review: Web installer CSS fails with ServiceDisabledException - https://phabricator.wikimedia.org/T253433 (10tstarling) [01:48:32] 10Editing-team (Tracking), 10OWC2020 (OWC2020 Replying 2.0): Create an onboarding experience for the Reply tool - https://phabricator.wikimedia.org/T253434 (10ppelberg) [01:48:43] (03CR) 10jerkins-bot: [V: 04-1] resources: Bundle ajax patrol and ajax rollback code [core] - 10https://gerrit.wikimedia.org/r/598137 (owner: 10Krinkle) [01:50:27] (03PS2) 10DannyS712: [WIP] UserFactory [core] - 10https://gerrit.wikimedia.org/r/598140 [01:51:42] (03CR) 10jerkins-bot: [V: 04-1] Update use of internal 'mediawiki.page.patrol.ajax' module [extensions/Flow] - 10https://gerrit.wikimedia.org/r/598138 (owner: 10Krinkle) [01:54:54] (03PS2) 10Krinkle: resources: Bundle ajax patrol and ajax rollback code [core] - 10https://gerrit.wikimedia.org/r/598137 [02:13:04] (03PS3) 10DannyS712: [WIP] UserFactory [core] - 10https://gerrit.wikimedia.org/r/598140 [02:14:47] (03PS1) 10Krinkle: mediawiki.misc-authed-curate: Simplify and clean up patrol.js [core] - 10https://gerrit.wikimedia.org/r/598141 [02:14:56] (03CR) 10Krinkle: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/598138 (owner: 10Krinkle) [02:15:21] (03PS2) 10Krinkle: mediawiki.misc-authed-curate: Simplify and clean up patrol.js [core] - 10https://gerrit.wikimedia.org/r/598141 [02:16:02] (03PS3) 10Krinkle: mediawiki.misc-authed-curate: Simplify and clean up patrol.js [core] - 10https://gerrit.wikimedia.org/r/598141 [02:21:36] (03CR) 10DannyS712: [C: 04-1] resources: Bundle ajax patrol and ajax rollback code (032 comments) [core] - 10https://gerrit.wikimedia.org/r/598137 (owner: 10Krinkle) [02:24:12] (03CR) 10Krinkle: resources: Bundle ajax patrol and ajax rollback code (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598137 (owner: 10Krinkle) [02:24:37] (03CR) 10DannyS712: mediawiki.misc-authed-curate: Simplify and clean up patrol.js (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598141 (owner: 10Krinkle) [02:29:16] (03CR) 10DannyS712: rcfeed: Add 'notify_url' and 'title_url' to MachineReadableRCFeedFormatter (031 comment) [core] - 10https://gerrit.wikimedia.org/r/589166 (https://phabricator.wikimedia.org/T234234) (owner: 10Krinkle) [02:35:54] (03CR) 10DannyS712: [C: 03+1] "LGTM" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/598138 (owner: 10Krinkle) [02:36:20] (03CR) 10Krinkle: resources: Bundle ajax patrol and ajax rollback code (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598137 (owner: 10Krinkle) [02:36:58] (03CR) 10Krinkle: mediawiki.misc-authed-curate: Simplify and clean up patrol.js (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598141 (owner: 10Krinkle) [02:37:54] (03PS4) 10Krinkle: rcfeed: Add 'notify_url' and 'title_url' to MachineReadableRCFeedFormatter [core] - 10https://gerrit.wikimedia.org/r/589166 (https://phabricator.wikimedia.org/T234234) [02:38:28] (03PS5) 10Krinkle: rcfeed: Add 'notify_url' and 'title_url' to MachineReadableRCFeedFormatter [core] - 10https://gerrit.wikimedia.org/r/589166 (https://phabricator.wikimedia.org/T234234) [02:40:48] (03CR) 10Krinkle: "Seems related to 6a8943d8c53b." [core] - 10https://gerrit.wikimedia.org/r/598139 (https://phabricator.wikimedia.org/T253433) (owner: 10Tim Starling) [02:41:50] (03PS2) 10Krinkle: installer: Fix failure of web installer CSS due to main stash [core] - 10https://gerrit.wikimedia.org/r/598139 (https://phabricator.wikimedia.org/T253433) (owner: 10Tim Starling) [02:42:02] (03CR) 10Krinkle: [C: 03+2] "Issue and fix confimed." [core] - 10https://gerrit.wikimedia.org/r/598139 (https://phabricator.wikimedia.org/T253433) (owner: 10Tim Starling) [02:44:18] 10MediaWiki-User-management, 10Research, 10Trust-and-Safety, 10Wikimedia-Site-requests: Add 'deletedtext' right to user group 'researchers' - https://phabricator.wikimedia.org/T253420 (10Nirmos) [02:45:01] 10MediaWiki-Installer, 10Patch-For-Review: Web installer CSS fails with ServiceDisabledException - https://phabricator.wikimedia.org/T253433 (10Krinkle) [02:45:04] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Epic: Redesign ResourceLoader's file dependency tracking (module_deps) - https://phabricator.wikimedia.org/T113916 (10Krinkle) [02:45:28] 10MediaWiki-ResourceLoader, 10DBA, 10Performance-Team, 10Wikimedia-production-error: Deadlock found when trying to get lock; try restarting transaction - https://phabricator.wikimedia.org/T117089 (10Krinkle) [02:45:32] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Epic: Redesign ResourceLoader's file dependency tracking (module_deps) - https://phabricator.wikimedia.org/T113916 (10Krinkle) [02:50:27] 10MediaWiki-Installer, 10Core Platform Team Workboards (Contractor Workboard), 10Patch-For-Review, 10Story: Provide capability for a DB to be added in an extension - https://phabricator.wikimedia.org/T226857 (10Art-Baltai) a:03Art-Baltai [02:56:00] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Add a sniff for non-global variables named like globals - https://phabricator.wikimedia.org/T251443 (10Krinkle) @thiemowmde This seems fine at glance. Do you have and/or could you gather some basic data to see whether this has existing violations... [03:01:03] (03CR) 10Krinkle: Use HttpRequestFactory::createMultiClient() in core where possible (031 comment) [core] - 10https://gerrit.wikimedia.org/r/597671 (https://phabricator.wikimedia.org/T245170) (owner: 10Tim Starling) [03:01:50] (03Merged) 10jenkins-bot: installer: Fix failure of web installer CSS due to main stash [core] - 10https://gerrit.wikimedia.org/r/598139 (https://phabricator.wikimedia.org/T253433) (owner: 10Tim Starling) [03:02:51] (03CR) 10Krinkle: REST: /page/{title}/{bare,html,with_html} endpoints backed by RESTBase. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/565408 (https://phabricator.wikimedia.org/T234377) (owner: 10Ppchelko) [03:05:04] (03CR) 10Krinkle: "Bump :)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/505826 (owner: 10Daimona Eaytoy) [03:09:45] (03PS1) 10Krinkle: mmv.bootstrap: Remove direct static call to OO.Router.prototype [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/598142 (https://phabricator.wikimedia.org/T77258) [03:09:50] (03CR) 10Krinkle: "Fixed in I00c018f97d6569a532e51f817a1faa2df4f2fb1a" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/510804 (https://phabricator.wikimedia.org/T77258) (owner: 10Simon04) [03:10:18] (03CR) 10Krinkle: "Bump :)" [core] - 10https://gerrit.wikimedia.org/r/589311 (owner: 10Esanders) [03:10:38] (03CR) 10Krinkle: "Fixed in https://gerrit.wikimedia.org/r/598136" [core] - 10https://gerrit.wikimedia.org/r/591159 (https://phabricator.wikimedia.org/T249259) (owner: 10Scardenasmolinar) [03:12:16] (03CR) 10Krinkle: OutputPage: allow additional CSS classes to be added to (031 comment) [core] - 10https://gerrit.wikimedia.org/r/592766 (https://phabricator.wikimedia.org/T241925) (owner: 10MusikAnimal) [03:13:20] (03CR) 10jerkins-bot: [V: 04-1] mmv.bootstrap: Remove direct static call to OO.Router.prototype [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/598142 (https://phabricator.wikimedia.org/T77258) (owner: 10Krinkle) [03:36:10] (03PS1) 10DannyS712: ParserOptionsTest: Rename non-global variable `$wgLang` [core] - 10https://gerrit.wikimedia.org/r/598143 [03:37:26] (03PS2) 10DannyS712: ParserOptionsTest: Rename non-global variable `$wgLang` [core] - 10https://gerrit.wikimedia.org/r/598143 [03:37:59] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Add a sniff for non-global variables named like globals - https://phabricator.wikimedia.org/T251443 (10DannyS712) >>! In T251443#6159826, @Krinkle wrote: > @thiemowmde This seems fine at glance. Do you have and/or could you gather some basic data... [03:48:24] (03PS1) 10DannyS712: UserFactory v.1 - wrapper for User::newFrom* static methods [core] - 10https://gerrit.wikimedia.org/r/598144 (https://phabricator.wikimedia.org/T253432) [03:50:57] (03PS2) 10DannyS712: UserFactory v.1 - wrapper for User::newFrom* static methods [core] - 10https://gerrit.wikimedia.org/r/598144 (https://phabricator.wikimedia.org/T253432) [03:51:34] 10MediaWiki-User-management, 10Core Platform Team, 10Core Platform Team Workboards (External Code Reviews), 10Dependency injection, and 2 others: Create a User factory - https://phabricator.wikimedia.org/T253432 (10DannyS712) [03:55:23] (03Abandoned) 10DannyS712: [WIP] UserFactory [core] - 10https://gerrit.wikimedia.org/r/598140 (owner: 10DannyS712) [03:56:51] (03PS1) 10DannyS712: [WIP] WatchlistNotificationManager [core] - 10https://gerrit.wikimedia.org/r/598145 [03:57:19] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Test KaiOS Wikipedia app on slow connection - https://phabricator.wikimedia.org/T252545 (10Jpita) The chrome browser has 3 settings for network throttling {F31837585} During my tests I did mainly 2 actions, search for a short word ("C" or "cat") and load an articl... [03:59:17] 10MediaWiki-File-management, 10MediaWiki-Uploading, 10Commons, 10Operations, and 2 others: Some (recent?) uploads to Commons are not available on other wikis - https://phabricator.wikimedia.org/T253405 (10Dinoguy1000) [04:11:51] (03PS2) 10DannyS712: [WIP] WatchlistNotificationManager [core] - 10https://gerrit.wikimedia.org/r/598145 [04:23:58] 10MediaWiki-File-management, 10MediaWiki-Uploading, 10Commons, 10Operations, and 2 others: Some (recent?) uploads to Commons are not available on other wikis - https://phabricator.wikimedia.org/T253405 (10AntiCompositeNumber) 05Resolved→03Open https://commons.wikimedia.org/wiki/File:Romulo_Espaldon.jpg... [04:26:23] (03CR) 10Reedy: "I don’t know, did it? It’s helpful if you give examples of what seems to be wrong...." [extensions] - 10https://gerrit.wikimedia.org/r/597808 (owner: 10Reedy) [04:29:18] 10Accessibility, 10WikiEditor: Special characters booklet not accessible - https://phabricator.wikimedia.org/T253410 (10Dinoguy1000) [04:47:54] (03PS5) 10Shirayuki: DefaultSettings: Fix @since for $wgStatsdMetricPrefix and $wgSiteTypes [core] - 10https://gerrit.wikimedia.org/r/593882 [04:51:41] (03PS3) 10DannyS712: [WIP] WatchlistNotificationManager [core] - 10https://gerrit.wikimedia.org/r/598145 [04:58:01] (03PS4) 10DannyS712: [WIP] WatchlistNotificationManager [core] - 10https://gerrit.wikimedia.org/r/598145 [04:59:26] (03PS5) 10DannyS712: [WIP] WatchlistNotificationManager [core] - 10https://gerrit.wikimedia.org/r/598145 [05:05:47] 10MediaWiki-API, 10ProofreadPage: action=parse API module disregards the text parameter for index pages when no template is supplied - https://phabricator.wikimedia.org/T252706 (10Soda) [05:06:13] (03PS1) 10DannyS712: UserClearNewTalkNotification: Only require a UserIdentity [extensions/Echo] - 10https://gerrit.wikimedia.org/r/598146 (https://phabricator.wikimedia.org/T253435) [05:07:03] (03PS2) 10DannyS712: UserClearNewTalkNotification: Only require a UserIdentity [extensions/Echo] - 10https://gerrit.wikimedia.org/r/598146 (https://phabricator.wikimedia.org/T253435) [05:07:11] (03CR) 10Catrope: VueComponentParser: Use RemexHtml instead of PHP's HTML parser (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598133 (https://phabricator.wikimedia.org/T253334) (owner: 10Catrope) [05:07:39] (03CR) 10Catrope: [C: 04-1] "This also doesn't work, because self-closing tags aren't parsed correctly. I'll add a failing test case." [core] - 10https://gerrit.wikimedia.org/r/598133 (https://phabricator.wikimedia.org/T253334) (owner: 10Catrope) [05:08:43] (03PS6) 10DannyS712: [WIP] WatchlistNotificationManager [core] - 10https://gerrit.wikimedia.org/r/598145 [05:08:51] (03PS3) 10Ori.livneh: mime: Add test for MimeAnalyzer::addExtra{Types,Info} [core] - 10https://gerrit.wikimedia.org/r/598129 [05:10:03] (03CR) 10DannyS712: resources: Bundle ajax patrol and ajax rollback code (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598137 (owner: 10Krinkle) [05:13:05] (03PS4) 10Ori.livneh: mime: Add test for MimeAnalyzer::addExtra{Types,Info} [core] - 10https://gerrit.wikimedia.org/r/598129 [05:13:16] (03CR) 10Ori.livneh: "Thanks for the reviews" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/598129 (owner: 10Ori.livneh) [05:13:34] (03PS7) 10DannyS712: [WIP] WatchlistNotificationManager [core] - 10https://gerrit.wikimedia.org/r/598145 [05:14:51] (03CR) 10DannyS712: [C: 03+1] "LGTM, waiting for Jenkins to verify" [core] - 10https://gerrit.wikimedia.org/r/598129 (owner: 10Ori.livneh) [05:16:16] (03PS2) 10Catrope: VueComponentParser: Use RemexHtml instead of PHP's HTML parser [core] - 10https://gerrit.wikimedia.org/r/598133 (https://phabricator.wikimedia.org/T253334) [05:16:17] (03PS1) 10Catrope: VueComponentParser: Add test case for self-closing tags [core] - 10https://gerrit.wikimedia.org/r/598147 [05:21:43] 10MediaWiki-General, 10Technical-Debt, 10User-DannyS712: Audit (and potentially remove) old Defines.php constants - https://phabricator.wikimedia.org/T253436 (10DannyS712) [05:32:19] (03CR) 10DannyS712: [C: 03+2] "Test coverage for MimeAnalyzer.php: 46.00% -> 57.67% :)" [core] - 10https://gerrit.wikimedia.org/r/598129 (owner: 10Ori.livneh) [05:32:36] (03CR) 10DannyS712: "recheck" [core] - 10https://gerrit.wikimedia.org/r/593882 (owner: 10Shirayuki) [05:35:59] (03CR) 10jerkins-bot: [V: 04-1] VueComponentParser: Use RemexHtml instead of PHP's HTML parser [core] - 10https://gerrit.wikimedia.org/r/598133 (https://phabricator.wikimedia.org/T253334) (owner: 10Catrope) [05:44:21] (03CR) 10Catrope: [C: 04-1] VueComponentParser: Use RemexHtml instead of PHP's HTML parser (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598133 (https://phabricator.wikimedia.org/T253334) (owner: 10Catrope) [05:45:43] (03CR) 10Shirayuki: "recheck" [extensions/Awesomeness] - 10https://gerrit.wikimedia.org/r/589145 (owner: 10Shirayuki) [05:45:48] (03PS6) 10Ori.livneh: mime: represent lists as arrays instead of space-delimited strings [core] - 10https://gerrit.wikimedia.org/r/598075 [05:52:01] (03Merged) 10jenkins-bot: mime: Add test for MimeAnalyzer::addExtra{Types,Info} [core] - 10https://gerrit.wikimedia.org/r/598129 (owner: 10Ori.livneh) [05:55:43] 10MediaWiki-File-management, 10MediaWiki-Uploading, 10Commons, 10Operations, and 2 others: Some (recent?) uploads to Commons are not available on other wikis - https://phabricator.wikimedia.org/T253405 (10Mbch331) I have problems with https://commons.wikimedia.org/w/index.php?title=File:Baruch_Spinoza_-_Le... [05:57:13] (03PS7) 10Ori.livneh: mime: represent lists as arrays instead of space-delimited strings [core] - 10https://gerrit.wikimedia.org/r/598075 [06:01:16] (03PS8) 10DannyS712: [WIP] WatchlistNotificationManager [core] - 10https://gerrit.wikimedia.org/r/598145 [06:05:50] (03PS9) 10DannyS712: [WIP] WatchlistNotificationManager [core] - 10https://gerrit.wikimedia.org/r/598145 [06:08:46] (03PS10) 10DannyS712: [WIP] WatchlistNotificationManager [core] - 10https://gerrit.wikimedia.org/r/598145 [06:09:23] (03PS11) 10DannyS712: [WIP] WatchlistNotificationManager [core] - 10https://gerrit.wikimedia.org/r/598145 [06:12:37] (03PS12) 10DannyS712: [WIP] WatchlistNotificationManager [core] - 10https://gerrit.wikimedia.org/r/598145 [06:14:10] (03CR) 10jerkins-bot: [V: 04-1] mime: represent lists as arrays instead of space-delimited strings [core] - 10https://gerrit.wikimedia.org/r/598075 (owner: 10Ori.livneh) [06:14:43] (03CR) 10DannyS712: "Since this patch doesn't include hard deprecation, only soft, I suggest splitting it up into:" [core] - 10https://gerrit.wikimedia.org/r/598075 (owner: 10Ori.livneh) [06:19:58] (03PS13) 10DannyS712: [WIP] WatchlistNotificationManager [core] - 10https://gerrit.wikimedia.org/r/598145 [06:41:01] 10NewcomerTasks 1.2, 10Growth-Team (Current Sprint), 10MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), 10Patch-For-Review: Newcomer tasks: post-edit dialog - https://phabricator.wikimedia.org/T245790 (10RHo) Thanks @Miller_WMF - having different messages for FlaggedRevs sounds good. I do worry slightly that "yo... [06:51:22] (03PS14) 10DannyS712: [WIP] WatchlistNotificationManager [core] - 10https://gerrit.wikimedia.org/r/598145 [07:11:38] (03PS15) 10DannyS712: [WIP] WatchlistNotificationManager [core] - 10https://gerrit.wikimedia.org/r/598145 [07:15:50] (03PS16) 10DannyS712: [WIP] WatchlistNotificationManager [core] - 10https://gerrit.wikimedia.org/r/598145 [07:17:30] 10Wikimedia-Takedown-Tools: Takedown Tools: DMCA tool not sending reports with non-Latin filenames to Lumen - https://phabricator.wikimedia.org/T253429 (10Aklapper) Curious if passing `Петр_и_павел.jpg` (no whitespace) or `%D0%9F%D0%B5%D1%82%D1%80_%D0%B8_%D0%BF%D0%B0%D0%B2%D0%B5%D0%BB.jpg` work. [07:18:01] (03PS7) 10DannyS712: Merge htmlform.checker.js into special.userlogin.signup.js [core] - 10https://gerrit.wikimedia.org/r/597903 (https://phabricator.wikimedia.org/T253362) [07:18:08] (03PS8) 10DannyS712: Merge htmlform.checker.js into special.userlogin.signup.js [core] - 10https://gerrit.wikimedia.org/r/597903 (https://phabricator.wikimedia.org/T253362) [07:29:44] 10MediaWiki-File-management, 10MediaWiki-Uploading, 10Commons, 10Operations, and 2 others: Some (recent?) uploads to Commons are not available on other wikis - https://phabricator.wikimedia.org/T253405 (10Kanags) I have the same issue with the uploaded image: https://commons.wikimedia.org/wiki/File:S._S._A... [07:38:25] (03PS17) 10DannyS712: [WIP] WatchlistNotificationManager [core] - 10https://gerrit.wikimedia.org/r/598145 [07:40:20] 10MediaWiki-Page-editing, 10VisualEditor, 10WikiEditor: Special characters → Hebrew displays incorrectly in WikiEditor and VisualEditor - https://phabricator.wikimedia.org/T185980 (10Aklapper) Cannot reproduce. WikiEditor on https://www.mediawiki.org/w/index.php?title=Project:Sandbox&action=edit in Firefox... [07:41:32] 10MediaWiki-Installer, 10Patch-For-Review: "A LocalSettings.php file has been detected. To upgrade this installation, please run update.php instead" output twice - https://phabricator.wikimedia.org/T253341 (10Ammarpad) a:03Ammarpad [07:46:24] (03PS1) 10DannyS712: docs/README: Update link to php documentation on doc.wikimedia.org [core] - 10https://gerrit.wikimedia.org/r/598148 [07:46:39] (03PS2) 10DannyS712: docs/README: Update link to php documentation on doc.wikimedia.org [core] - 10https://gerrit.wikimedia.org/r/598148 [07:47:30] 10MediaWiki-Redirects: broken redirects to sections with special characters - https://phabricator.wikimedia.org/T108761 (10Aklapper) 05Open→03Stalled 1. Chromium 81: Set "Settings > Privacy and Security > Site Settings > Javascript > Blocked". 2. Go to https://en.wikipedia.org/wiki/Wikipedia:POVFORK 3. End u... [07:48:58] (03PS1) 10DannyS712: docs/magicword.md - use markdown's code highlighting for php blocks [core] - 10https://gerrit.wikimedia.org/r/598149 [07:50:02] (03PS2) 10DannyS712: docs/magicword.md - use markdown's code highlighting for php blocks [core] - 10https://gerrit.wikimedia.org/r/598149 [07:54:24] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Allow users to provide feedback from within the app - https://phabricator.wikimedia.org/T236317 (10AMuigai) @eamedina Got the approved message. Please use: "We will use your feedback to help improve this app. Your response will be kept for 90 days, subject to our P... [07:54:44] (03CR) 10jerkins-bot: [V: 04-1] [WIP] WatchlistNotificationManager [core] - 10https://gerrit.wikimedia.org/r/598145 (owner: 10DannyS712) [07:55:01] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Allow users to provide feedback from within the app - https://phabricator.wikimedia.org/T236317 (10AMuigai) [07:58:21] (03CR) 10Fomafix: "Is this module the right place for the JavaScript code for the logout button? This code is used only for logged in users and not for anony" [core] - 10https://gerrit.wikimedia.org/r/598137 (owner: 10Krinkle) [07:58:49] (03PS3) 10DannyS712: docs - minor cleanup, including fixing markdown syntax [core] - 10https://gerrit.wikimedia.org/r/598149 [08:00:17] (03PS18) 10DannyS712: [WIP] WatchlistNotificationManager [core] - 10https://gerrit.wikimedia.org/r/598145 [08:00:50] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Update survey statement on "Feedback" option - https://phabricator.wikimedia.org/T253437 (10AMuigai) [08:01:05] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Update survey statement on "Feedback" option - https://phabricator.wikimedia.org/T253437 (10AMuigai) p:05Triage→03Medium [08:01:06] (03CR) 10DannyS712: [C: 03+2] Add Special:MyLanguage for better user experience [extensions/Awesomeness] - 10https://gerrit.wikimedia.org/r/589145 (owner: 10Shirayuki) [08:01:27] 10Phabricator, 10Wikimedia-GitHub, 10User-Majavah: Automatically create task on Phabricator based on Issues from Github repositories - https://phabricator.wikimedia.org/T253388 (10Majavah) [08:01:31] (03CR) 10DannyS712: [C: 03+2] Add Special:MyLanguage for better user experience [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/589786 (owner: 10Shirayuki) [08:02:13] (03CR) 10DannyS712: [C: 03+2] Add Special:MyLanguage for better user experience [extensions/DataTable2] - 10https://gerrit.wikimedia.org/r/589140 (owner: 10Shirayuki) [08:02:35] (03CR) 10DannyS712: "recheck" [extensions/DynamicPageListEngine] - 10https://gerrit.wikimedia.org/r/589135 (owner: 10Shirayuki) [08:03:16] (03CR) 10DannyS712: "> recheck" [extensions/DynamicPageListEngine] - 10https://gerrit.wikimedia.org/r/589135 (owner: 10Shirayuki) [08:03:41] (03CR) 10DannyS712: [C: 03+2] Add Special:MyLanguage for better user experience [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/589770 (owner: 10Shirayuki) [08:04:03] (03CR) 10DannyS712: "recheck" [extensions/XenForoAuth] - 10https://gerrit.wikimedia.org/r/592647 (owner: 10Shirayuki) [08:05:36] (03Merged) 10jenkins-bot: Add Special:MyLanguage for better user experience [extensions/Awesomeness] - 10https://gerrit.wikimedia.org/r/589145 (owner: 10Shirayuki) [08:06:00] (03CR) 10DannyS712: Avoid HtmlCacheUpdateJob purges for content no longer in CDN (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598114 (https://phabricator.wikimedia.org/T250205) (owner: 10Aaron Schulz) [08:06:36] (03CR) 10DannyS712: [C: 03+2] Add Special:MyLanguage for better user experience [extensions/DynamicPageListEngine] - 10https://gerrit.wikimedia.org/r/589135 (owner: 10Shirayuki) [08:07:46] (03CR) 10DannyS712: [C: 03+2] Update MediaWiki.org links [extensions/XenForoAuth] - 10https://gerrit.wikimedia.org/r/592647 (owner: 10Shirayuki) [08:12:32] (03CR) 10DannyS712: [C: 03+1] "LGTM" [schemas/event/primary] - 10https://gerrit.wikimedia.org/r/598110 (owner: 10Bearloga) [08:12:42] (03CR) 10DannyS712: [C: 03+1] "LGTM" [schemas/event/secondary] - 10https://gerrit.wikimedia.org/r/598111 (owner: 10Bearloga) [08:14:42] (03CR) 10DannyS712: [C: 03+2] Put tests into separate test namespace [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/598049 (owner: 10Tchanders) [08:16:15] (03CR) 10DannyS712: [C: 04-2] "Pending decision on how to apply autopatrol" [extensions/NewUserMessage] - 10https://gerrit.wikimedia.org/r/594263 (https://phabricator.wikimedia.org/T250638) (owner: 10DannyS712) [08:16:54] (03CR) 10DannyS712: "Its a test, autopatrol doesn't matter" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/592392 (https://phabricator.wikimedia.org/T250638) (owner: 10DannyS712) [08:16:57] (03PS7) 10DannyS712: Remove use of WikiPage::doEditContent [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/592392 (https://phabricator.wikimedia.org/T250638) [08:17:16] (03CR) 10DannyS712: [C: 04-2] "Pending decision on how to apply autopatrol" [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/594312 (https://phabricator.wikimedia.org/T250638) (owner: 10DannyS712) [08:17:33] (03CR) 10DannyS712: [C: 04-2] "Pending decision on how to apply autopatrol" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/594315 (https://phabricator.wikimedia.org/T250638) (owner: 10DannyS712) [08:17:42] (03CR) 10DannyS712: [C: 04-2] "Pending decision on how to apply autopatrol" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/594260 (https://phabricator.wikimedia.org/T250638) (owner: 10DannyS712) [08:17:54] (03CR) 10DannyS712: [C: 04-2] "Pending decision on how to apply autopatrol" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/592762 (https://phabricator.wikimedia.org/T250638) (owner: 10DannyS712) [08:20:34] (03PS4) 10DannyS712: Replace use of WikiPage::doEditContent with PageUpdater [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/594314 (https://phabricator.wikimedia.org/T250638) [08:20:47] (03CR) 10DannyS712: "> Uploaded patch set 4." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/594314 (https://phabricator.wikimedia.org/T250638) (owner: 10DannyS712) [08:21:11] (03Merged) 10jenkins-bot: Add Special:MyLanguage for better user experience [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/589786 (owner: 10Shirayuki) [08:21:13] (03Merged) 10jenkins-bot: Add Special:MyLanguage for better user experience [extensions/DataTable2] - 10https://gerrit.wikimedia.org/r/589140 (owner: 10Shirayuki) [08:26:35] (03CR) 10DannyS712: [C: 03+1] "LGTM" [core] - 10https://gerrit.wikimedia.org/r/595018 (owner: 10Amire80) [08:26:58] (03Merged) 10jenkins-bot: Add Special:MyLanguage for better user experience [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/589770 (owner: 10Shirayuki) [08:27:00] (03Merged) 10jenkins-bot: Add Special:MyLanguage for better user experience [extensions/DynamicPageListEngine] - 10https://gerrit.wikimedia.org/r/589135 (owner: 10Shirayuki) [08:27:02] (03Merged) 10jenkins-bot: Update MediaWiki.org links [extensions/XenForoAuth] - 10https://gerrit.wikimedia.org/r/592647 (owner: 10Shirayuki) [08:33:18] (03Merged) 10jenkins-bot: Put tests into separate test namespace [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/598049 (owner: 10Tchanders) [08:43:37] (03PS1) 10DannyS712: Add new WatchlistNotificationManager service [core] - 10https://gerrit.wikimedia.org/r/598150 (https://phabricator.wikimedia.org/T208777) [08:43:39] (03PS12) 10Kosta Harlan: Add Makefile and update CI config [tools/cli] - 10https://gerrit.wikimedia.org/r/598101 (https://phabricator.wikimedia.org/T250241) [08:44:06] 10Magnus Sälgö: Add swedish glaciers and P7442 "glacier status" - https://phabricator.wikimedia.org/T236131 (10Salgo60) [08:44:14] (03CR) 10jerkins-bot: [V: 04-1] Add Makefile and update CI config [tools/cli] - 10https://gerrit.wikimedia.org/r/598101 (https://phabricator.wikimedia.org/T250241) (owner: 10Kosta Harlan) [08:46:21] (03PS2) 10DannyS712: Add new WatchlistNotificationManager service [core] - 10https://gerrit.wikimedia.org/r/598150 (https://phabricator.wikimedia.org/T208777) [08:46:27] (03Abandoned) 10DannyS712: [WIP] WatchlistNotificationManager [core] - 10https://gerrit.wikimedia.org/r/598145 (owner: 10DannyS712) [08:47:22] 10Magnus Sälgö: Add swedish glaciers and P7442 "glacier status" - https://phabricator.wikimedia.org/T236131 (10Salgo60) [08:51:51] 10MediaWiki-Configuration: Eliminate the toil in WMF wiki creation - https://phabricator.wikimedia.org/T253439 (10Ladsgroup) [08:55:27] (03PS13) 10Kosta Harlan: Add Makefile and update CI config [tools/cli] - 10https://gerrit.wikimedia.org/r/598101 (https://phabricator.wikimedia.org/T250241) [08:55:32] 10MediaWiki-Configuration: Eliminate the toil in WMF wiki creation - https://phabricator.wikimedia.org/T253439 (10DannyS712) For the checklist, perhaps a custom form for task creation? [08:55:48] (03CR) 10jerkins-bot: [V: 04-1] Add Makefile and update CI config [tools/cli] - 10https://gerrit.wikimedia.org/r/598101 (https://phabricator.wikimedia.org/T250241) (owner: 10Kosta Harlan) [08:56:17] 10MediaWiki-Configuration: Eliminate the toil in WMF wiki creation - https://phabricator.wikimedia.org/T253439 (10Ladsgroup) [08:57:30] (03PS14) 10Kosta Harlan: Add Makefile and update CI config [tools/cli] - 10https://gerrit.wikimedia.org/r/598101 (https://phabricator.wikimedia.org/T250241) [08:57:49] (03CR) 10jerkins-bot: [V: 04-1] Add Makefile and update CI config [tools/cli] - 10https://gerrit.wikimedia.org/r/598101 (https://phabricator.wikimedia.org/T250241) (owner: 10Kosta Harlan) [09:00:52] 10Magnus Sälgö: Add swedish glaciers and P7442 "glacier status" - https://phabricator.wikimedia.org/T236131 (10Salgo60) [09:00:57] (03PS15) 10Kosta Harlan: Add Makefile and update CI config [tools/cli] - 10https://gerrit.wikimedia.org/r/598101 (https://phabricator.wikimedia.org/T250241) [09:01:00] 10Accessibility, 10MediaWiki-General: Screen reader is announcing edit and edit source along in the headings - https://phabricator.wikimedia.org/T253423 (10Aklapper) [09:01:39] (03CR) 10jerkins-bot: [V: 04-1] Add Makefile and update CI config [tools/cli] - 10https://gerrit.wikimedia.org/r/598101 (https://phabricator.wikimedia.org/T250241) (owner: 10Kosta Harlan) [09:02:44] (03CR) 10DannyS712: [C: 03+1] "LGTM" [core] - 10https://gerrit.wikimedia.org/r/589555 (owner: 10Daimona Eaytoy) [09:04:14] 10Magnus Sälgö: Add swedish glaciers and P7442 "glacier status" - https://phabricator.wikimedia.org/T236131 (10Salgo60) [09:04:31] (03CR) 10DannyS712: [C: 03+2] Add phan assertion for Assert::nonEmptyString [libs/Assert] - 10https://gerrit.wikimedia.org/r/589293 (https://phabricator.wikimedia.org/T226266) (owner: 10Daimona Eaytoy) [09:05:04] (03Merged) 10jenkins-bot: Add phan assertion for Assert::nonEmptyString [libs/Assert] - 10https://gerrit.wikimedia.org/r/589293 (https://phabricator.wikimedia.org/T226266) (owner: 10Daimona Eaytoy) [09:08:02] 10MediaWiki-ContentHandler: Cannot change page content model in Russian Wikinews - https://phabricator.wikimedia.org/T253441 (10Krassotkin) [09:08:35] (03PS16) 10Kosta Harlan: Add Makefile and update CI config [tools/cli] - 10https://gerrit.wikimedia.org/r/598101 (https://phabricator.wikimedia.org/T250241) [09:08:48] (03CR) 10DannyS712: [C: 03+2] Update and add PHPDoc comments to all public methods [extensions/Wigo3] - 10https://gerrit.wikimedia.org/r/585859 (owner: 10Thiemo Kreuz (WMDE)) [09:11:12] (03CR) 10jerkins-bot: [V: 04-1] Add Makefile and update CI config [tools/cli] - 10https://gerrit.wikimedia.org/r/598101 (https://phabricator.wikimedia.org/T250241) (owner: 10Kosta Harlan) [09:12:05] 10MediaWiki-ContentHandler: Cannot change page content model in Russian Wikinews - https://phabricator.wikimedia.org/T253441 (10DannyS712) @Krassotkin did you provide a summary with your change? If not, they may be a known issue - can you try again with a summary? [09:17:26] (03CR) 10DannyS712: [C: 03+1] "LGTM" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/577606 (owner: 10Daimona Eaytoy) [09:18:47] (03PS1) 10Amire80: Clarify WebAuthn messages [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/598151 [09:19:47] 10MediaWiki-ContentHandler: Cannot change page content model in Russian Wikinews - https://phabricator.wikimedia.org/T253441 (10Ammarpad) It's not possible to do any content model change from the UI until T252963 is resolved. The edit summary is checked at the initial load of the page (and you can't put any summ... [09:20:13] 10MediaWiki-ContentHandler: Cannot change page content model in Russian Wikinews - https://phabricator.wikimedia.org/T253441 (10Ammarpad) [09:20:19] 10MediaWiki-Page-editing, 10Core Platform Team Workboards (External Code Reviews), 10Patch-For-Review, 10Wikimedia-production-error: Fatal exception of type "TypeError": Argument 1 passed to MediaWiki\EditPage\SpamChecker::checkSummary() must be of the type string,... - https://phabricator.wikimedia.org/T252963 [09:20:59] (03CR) 10jerkins-bot: [V: 04-1] Update and add PHPDoc comments to all public methods [extensions/Wigo3] - 10https://gerrit.wikimedia.org/r/585859 (owner: 10Thiemo Kreuz (WMDE)) [09:21:20] (03CR) 10DannyS712: [C: 04-1] Mark user page moves as bot on rename user process (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/372803 (https://phabricator.wikimedia.org/T97659) (owner: 10Melos) [09:21:29] 10Projects-Cleanup: mw:Template:Archived (extension|skin): add new "task" field - https://phabricator.wikimedia.org/T204489 (10MarcoAurelio) >>! In T204489#6159776, @Pppery wrote: > Coded in the sandbox of the templates in question, see https://www.mediawiki.org/w/index.php?title=Project:Sandbox&oldid=3871698 L... [09:22:14] 10MediaWiki-ContentHandler: Cannot change page content model in Russian Wikinews - https://phabricator.wikimedia.org/T253441 (10Krassotkin) >>! In T253441#6159971, @DannyS712 wrote: > @Krassotkin did you provide a summary with your change? If not, they may be a known issue - can you try again with a summary? Pr... [09:22:33] 10MediaWiki-File-management, 10MediaWiki-Uploading, 10Commons, 10Operations, and 2 others: Some (recent?) uploads to Commons are not available on other wikis - https://phabricator.wikimedia.org/T253405 (10Path-x21) The same issue for another of my photos/files I uploaded: https://commons.wikimedia.org/wiki... [09:24:00] (03CR) 10DannyS712: [C: 03+1] "> Gate pipeline build failed." [extensions/Wigo3] - 10https://gerrit.wikimedia.org/r/585859 (owner: 10Thiemo Kreuz (WMDE)) [09:29:54] 10MediaWiki-Redirects: broken redirects to sections with special characters - https://phabricator.wikimedia.org/T108761 (10Lahwaacz) @Aklapper: if you end up with https://en.wikipedia.org/wiki/Wikipedia:Content_forking#Point_of_view_(POV)_forks instead of https://en.wikipedia.org/wiki/Wikipedia:POVFORK in the ad... [09:31:48] (03CR) 10DannyS712: [C: 04-1] Fix inconsistent Newsletter permission checking (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/446642 (https://phabricator.wikimedia.org/T188139) (owner: 10Pppery) [09:34:02] (03CR) 10DannyS712: [C: 04-1] "Since a breaking change is being made to ApiAuthManagerHelper, suggesting also tagging as @internal and noting the breaking change in the " [core] - 10https://gerrit.wikimedia.org/r/585023 (owner: 10Umherirrender) [09:37:06] (03CR) 10DannyS712: [C: 03+2] Convert LanguageTag to use extension registration [extensions/LanguageTag] - 10https://gerrit.wikimedia.org/r/406053 (https://phabricator.wikimedia.org/T185648) (owner: 10Jayprakash12345) [09:40:09] (03Merged) 10jenkins-bot: Convert LanguageTag to use extension registration [extensions/LanguageTag] - 10https://gerrit.wikimedia.org/r/406053 (https://phabricator.wikimedia.org/T185648) (owner: 10Jayprakash12345) [09:40:11] (03Merged) 10jenkins-bot: Add phpcs and make it pass [extensions/LanguageTag] - 10https://gerrit.wikimedia.org/r/584596 (owner: 10Zoranzoki21) [09:40:49] (03PS3) 10DannyS712: Use LinkRenderer instead of Linker::link [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/562007 (owner: 10Fomafix) [09:42:03] 10MediaWiki-Redirects: broken redirects to sections with special characters - https://phabricator.wikimedia.org/T108761 (10Aklapper) Hmm. When doing that I also tried other sites (like `facebook.com`) and they showed an error that JS must be enabled. If you are correct then I am not sure how to test this. [09:43:10] (03CR) 10DannyS712: [C: 03+1] "LGTM" [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/562007 (owner: 10Fomafix) [09:47:33] 10MediaWiki-File-management, 10MediaWiki-Uploading, 10Commons, 10Operations, and 2 others: Some (recent?) uploads to Commons are not available on other wikis - https://phabricator.wikimedia.org/T253405 (10Path-x21) I have a potential idea why this bug occurs. I was editing the Wikipedia page and I had alre... [09:56:37] (03CR) 10DannyS712: [C: 03+2] Use private instead of protected in CommentStore [core] - 10https://gerrit.wikimedia.org/r/583042 (owner: 10Thiemo Kreuz (WMDE)) [09:58:04] (03CR) 10DannyS712: [C: 03+2] Convert Sarcasm to use extension registration [extensions/Sarcasm] - 10https://gerrit.wikimedia.org/r/588783 (https://phabricator.wikimedia.org/T250228) (owner: 10Zoranzoki21) [10:02:51] (03CR) 10DannyS712: tests: Introduce basic ApiQueryGlobaluserinfoTest (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/592772 (owner: 10Urbanecm) [10:05:54] 10Magnus Sälgö: Add swedish glaciers and P7442 "glacier status" - https://phabricator.wikimedia.org/T236131 (10Salgo60) [10:08:55] (03PS5) 10Mainframe98: skins: Use local getters rather than globals or static functions [core] - 10https://gerrit.wikimedia.org/r/597122 [10:12:12] 10MediaWiki-Configuration: Eliminate the toil in WMF wiki creation - https://phabricator.wikimedia.org/T253439 (10Ladsgroup) >>! In T253439#6159952, @DannyS712 wrote: > For the checklist, perhaps a custom form for task creation? The wiki creation has a pre-filled form generated from a template: https://meta.wik... [10:15:28] (03CR) 10Mainframe98: Begin merge of SkinVector and VectorTemplate (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/593070 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [10:16:22] (03Merged) 10jenkins-bot: Use private instead of protected in CommentStore [core] - 10https://gerrit.wikimedia.org/r/583042 (owner: 10Thiemo Kreuz (WMDE)) [10:16:24] (03Merged) 10jenkins-bot: Convert Sarcasm to use extension registration [extensions/Sarcasm] - 10https://gerrit.wikimedia.org/r/588783 (https://phabricator.wikimedia.org/T250228) (owner: 10Zoranzoki21) [10:30:38] 10MediaWiki-File-management, 10MediaWiki-Uploading, 10Commons, 10Operations, and 2 others: Some (recent?) uploads to Commons are not available on other wikis - https://phabricator.wikimedia.org/T253405 (10Stryn) [10:33:02] (03CR) 10Mainframe98: [C: 03+1] "This change works for me." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/596756 (https://phabricator.wikimedia.org/T252917) (owner: 10Jdlrobson) [10:35:09] (03CR) 10DannyS712: [C: 04-1] "https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/596756/ will move a lot of this code around, so this may not be worth the effort" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/597122 (owner: 10Mainframe98) [10:39:35] (03CR) 10Mainframe98: "> Patch Set 5: Code-Review-1" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/597122 (owner: 10Mainframe98) [10:40:32] (03CR) 10DannyS712: [C: 03+2] Clarify WebAuthn messages [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/598151 (owner: 10Amire80) [10:42:40] (03PS6) 10Mainframe98: skins: Use local getters rather than globals or static functions [core] - 10https://gerrit.wikimedia.org/r/597122 [10:48:24] 10MediaWiki-extensions-CleanChanges, 10Growth-Team, 10StructuredDiscussions: Flow must play well with CleanChanges (Translatewiki) - https://phabricator.wikimedia.org/T88111 (10Aklapper) [10:50:34] 10Design, 10MediaWiki-Change-tagging, 10MediaWiki-Page-editing, 10VisualEditor, and 2 others: Support tags from editing form - https://phabricator.wikimedia.org/T109032 (10DannyS712) Technically its possible to add tags manually alongside an edit when editing manually: [1] is tagged with `Huggle`, `WPClean... [10:55:58] (03Merged) 10jenkins-bot: Clarify WebAuthn messages [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/598151 (owner: 10Amire80) [11:02:21] (03PS4) 10Gergő Tisza: Add URL template to the return data of mw.util.parseImageUrl [core] - 10https://gerrit.wikimedia.org/r/598127 (https://phabricator.wikimedia.org/T244210) [11:02:27] (03CR) 10Gergő Tisza: mediawiki.util: Add mw.util.parseImageUrl (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598115 (https://phabricator.wikimedia.org/T244210) (owner: 10Gergő Tisza) [11:04:26] 10MediaWiki-extensions-Other, 10Patch-For-Review, 10User-Zoranzoki21: Convert Sarcasm to use extension registration - https://phabricator.wikimedia.org/T250228 (10Zoranzoki21) 05Open→03Resolved [11:04:31] 10MediaWiki-Configuration, 10MediaWiki-extensions-General, 10Goal, 10Patch-For-Review, 10User-Zoranzoki21: Convert all extensions and skins on gerrit to use extension registration - https://phabricator.wikimedia.org/T98668 (10Zoranzoki21) [11:05:24] (03PS5) 10Gergő Tisza: Add URL template to the return data of mw.util.parseImageUrl [core] - 10https://gerrit.wikimedia.org/r/598127 (https://phabricator.wikimedia.org/T244210) [11:06:26] 10MediaWiki-extensions-Other, 10User-Zoranzoki21: Convert LanguageTag to use extension registration - https://phabricator.wikimedia.org/T185648 (10Zoranzoki21) 05Open→03Resolved a:03Zoranzoki21 [11:06:30] 10MediaWiki-Configuration, 10MediaWiki-extensions-General, 10Goal, 10Patch-For-Review, 10User-Zoranzoki21: Convert all extensions and skins on gerrit to use extension registration - https://phabricator.wikimedia.org/T98668 (10Zoranzoki21) [11:22:07] (03CR) 10jerkins-bot: [V: 04-1] Add URL template to the return data of mw.util.parseImageUrl [core] - 10https://gerrit.wikimedia.org/r/598127 (https://phabricator.wikimedia.org/T244210) (owner: 10Gergő Tisza) [11:28:25] 10Magnus Sälgö: Create a Wikidata:Tours for Swedish Glacier - https://phabricator.wikimedia.org/T253443 (10Salgo60) [11:36:29] 10TemplateStyles: Need help installing TemplateStyles / Besoin d'aide pour installer TemplateStyles - https://phabricator.wikimedia.org/T253444 (10Sebunian) [11:40:10] 10TemplateStyles: Need help installing TemplateStyles / Besoin d'aide pour installer TemplateStyles - https://phabricator.wikimedia.org/T253444 (10Aklapper) 05Open→03Invalid Hi @Sebunian. This does not sound like something is wrong in the code base (a so-called "software bug"), but instead like a support req... [11:46:54] 10Magnus Sälgö: Add swedish glaciers and P7442 "glacier status" - https://phabricator.wikimedia.org/T236131 (10Salgo60) [11:48:39] 10TemplateStyles: Need help installing TemplateStyles / Besoin d'aide pour installer TemplateStyles - https://phabricator.wikimedia.org/T253444 (10Sebunian) @Aklapper Oh excuse me for the inconvenience [11:53:05] 10MediaWiki-Special-pages, 10Beta-Cluster-Infrastructure: Changing content model on meta beta impossible - https://phabricator.wikimedia.org/T253445 (10MGChecker) [12:08:16] 10MediaWiki-Special-pages, 10Beta-Cluster-Infrastructure: Changing content model on meta beta impossible - https://phabricator.wikimedia.org/T253445 (10Mainframe98) [12:08:22] 10MediaWiki-Page-editing, 10Core Platform Team Workboards (External Code Reviews), 10Patch-For-Review, 10Wikimedia-production-error: Fatal exception of type "TypeError": Argument 1 passed to MediaWiki\EditPage\SpamChecker::checkSummary() must be of the type string,... - https://phabricator.wikimedia.org/T252963 [12:13:34] 10MediaWiki-extensions-OATHAuth: Recovery option for Webauthn - https://phabricator.wikimedia.org/T244348 (10jeblad) Seems like the setup fail on Firefox with my Yubikey. If it is correct that log-in only depends on a single key, and I can't configure more keys or scratch codes, then this is terrifying. [12:18:39] 10MediaWiki-extensions-OAuth: Allow an option to delete an OAuth Consumer - https://phabricator.wikimedia.org/T224307 (10Iwan.Aucamp) This is really needed, please roll it out. [12:18:41] 10Magnus Sälgö: Add swedish glaciers and P7442 "glacier status" - https://phabricator.wikimedia.org/T236131 (10Salgo60) - [[ https://www.utsidan.se/forum/showthread.php?p=842923#post842923 | Sent a request to Utsidan ]] if they have pictures etc... [12:19:28] 10MediaWiki-extensions-OAuth, 10Patch-For-Review: OAuth: Developers should be able to revoke their own tool's approval - https://phabricator.wikimedia.org/T65712 (10Iwan.Aucamp) Really need this. [12:31:54] (03PS10) 10Reedy: Init [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/588671 (https://phabricator.wikimedia.org/T247837) (owner: 10ItSpiderman) [12:32:04] (03CR) 10Fomafix: [C: 04-1] mediawiki.misc-authed-curate: Simplify and clean up patrol.js (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598141 (owner: 10Krinkle) [12:35:25] 10Android-app-Bugs, 10Mobile-Content-Service, 10Wikipedia-Android-App-Backlog: Map marker is misplaced when loading from MCS - https://phabricator.wikimedia.org/T176739 (10Whir) {F31837823} [12:37:12] (03CR) 10jerkins-bot: [V: 04-1] Init [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/588671 (https://phabricator.wikimedia.org/T247837) (owner: 10ItSpiderman) [12:39:11] 10CPT Initiatives (API Gateway), 10ci-test-error: WikimediaApiPortal results in CI OOM-ing - https://phabricator.wikimedia.org/T253331 (10Reedy) PR merged and pushed to gerrit seems to unblock this - https://github.com/ProfessionalWiki/chameleon/pull/155/files Which means it's some variant of {T253336}, even... [12:39:18] 10CPT Initiatives (API Gateway), 10ci-test-error: WikimediaApiPortal results in CI OOM-ing - https://phabricator.wikimedia.org/T253331 (10Reedy) 05Open→03Resolved a:03Reedy [12:39:20] 10CPT Initiatives (API Gateway), 10Core Platform Team Workboards (Epics), 10Epic: Create API Portal MVP - https://phabricator.wikimedia.org/T247837 (10Reedy) [12:48:57] 10MediaWiki-extensions-OATHAuth: Recovery option for Webauthn - https://phabricator.wikimedia.org/T244348 (10Reedy) You can add many/multiple different yubikeys, as per the "Add key" button {F31837826 size=full} [12:55:33] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Add a sniff for non-global variables named like globals - https://phabricator.wikimedia.org/T251443 (10Daimona) >>! In T251443#6159733, @DannyS712 wrote: > @Daimona @thiemowmde @Jdforrester-WMF Based on the discussion regarding how to handle `$GL... [13:00:09] 10MediaWiki-extensions-NewUserMessage: Add a parameter to disable automatic signature by the welcome message editor. - https://phabricator.wikimedia.org/T253446 (10NottNott) [13:00:45] (03CR) 10Daimona Eaytoy: "> Bump :)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/505826 (owner: 10Daimona Eaytoy) [13:11:44] 10MediaWiki-extensions-OAuth, 10Core Platform Team, 10Documentation: OAuth2 docs seem confused/incomplete - https://phabricator.wikimedia.org/T253447 (10Reedy) [13:12:47] 10MediaWiki-extensions-OAuth, 10Core Platform Team, 10Documentation: OAuth2 docs seem confused/incomplete - https://phabricator.wikimedia.org/T253447 (10Reedy) [13:19:35] 10MediaWiki-extensions-OAuth, 10Core Platform Team, 10Documentation: OAuth2 docs seem confused/incomplete - https://phabricator.wikimedia.org/T253447 (10Reedy) Looking at https://meta.wikimedia.org/wiki/Special:OAuthManageConsumers/approved "Consumer key" is then used... "client token" isn't mentioned in i1... [13:21:07] 10MediaWiki-extensions-OAuth, 10Core Platform Team, 10Documentation: OAuth2 docs seem confused/incomplete - https://phabricator.wikimedia.org/T253447 (10Iwan.Aucamp) I asked a question relating to this here: https://meta.wikimedia.org/wiki/Tech#What_to_use_as_client_id_for_OAuth2 [13:25:00] 04(no projects): Unable to view watchlist pages - https://phabricator.wikimedia.org/T253448 (10Capankajsmilyo) [13:25:40] (03PS10) 10Daimona Eaytoy: Check for PassByRefVariable in more places [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/593005 [13:26:21] (03PS11) 10Daimona Eaytoy: Check for PassByRefVariable in more places [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/593005 [13:26:26] (03PS33) 10Daimona Eaytoy: Big pass-by-ref overhaul [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/592974 (https://phabricator.wikimedia.org/T250689) [13:27:03] 04(no projects): Not switching to mobile version by default on smartphone - https://phabricator.wikimedia.org/T253449 (10Capankajsmilyo) [13:27:42] 04(no projects): Unable to view watchlist pages - https://phabricator.wikimedia.org/T253448 (10Reedy) [13:27:53] 10MediaWiki-Watchlist, 10Core Platform Team, 10Growth-Team, 10User-kostajh, and 2 others: Opening Special:EditWatchlist with a large watchlist hits server timeout (Create watchlist pager) - https://phabricator.wikimedia.org/T41510 (10Reedy) [13:29:31] 10MobileFrontend, 10Mobile: Not switching to mobile version by default on smartphone - https://phabricator.wikimedia.org/T253449 (10Reedy) [13:30:53] (03PS1) 10Daimona Eaytoy: Automatically check if dirs and files exists before adding to config [tools/phan] - 10https://gerrit.wikimedia.org/r/598159 [13:31:42] 10MediaWiki-extensions-OATHAuth: Recovery option for Webauthn - https://phabricator.wikimedia.org/T244348 (10jeblad) So, it is possible to add more keys, what about alternate MFA and in particular scratch codes? [13:34:20] (03PS5) 10Daimona Eaytoy: librarization: Move some methods to a generic Utils class [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/597754 [13:37:59] (03PS7) 10Daimona Eaytoy: Use mediawiki/phan-utils [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/597797 [13:40:32] (03CR) 10Reedy: "Yeah, the problem is these use words that the script doesn't know" [extensions] - 10https://gerrit.wikimedia.org/r/597808 (owner: 10Reedy) [13:43:36] (03PS4) 10Daimona Eaytoy: [WIP] Extract another class for handling hooks [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/598077 [13:43:53] (03CR) 10Reedy: "And running it again (re?) addds more" [extensions] - 10https://gerrit.wikimedia.org/r/597808 (owner: 10Reedy) [13:44:19] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Extract another class for handling hooks [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/598077 (owner: 10Daimona Eaytoy) [13:48:08] (03PS5) 10Daimona Eaytoy: [WIP] Extract another class for handling hooks [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/598077 [13:48:50] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Extract another class for handling hooks [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/598077 (owner: 10Daimona Eaytoy) [13:58:01] (03CR) 10Pppery: "This is why it's important that code gets reviewed quickly; if it languishes for years, it falls out of sync." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/446642 (https://phabricator.wikimedia.org/T188139) (owner: 10Pppery) [13:58:16] (03PS1) 10Reedy: Make sync-with-gerrit.py use state not description for skipping [extensions] - 10https://gerrit.wikimedia.org/r/598160 (https://phabricator.wikimedia.org/T253450) [13:59:50] (03PS1) 10Reedy: Make sync-with-gerrit.py use state not description for skipping [skins] - 10https://gerrit.wikimedia.org/r/598161 (https://phabricator.wikimedia.org/T253450) [14:01:07] (03PS1) 10Reedy: Update submodule [skins] - 10https://gerrit.wikimedia.org/r/598162 [14:01:37] (03CR) 10Reedy: [V: 03+2 C: 03+2] Update submodule [skins] - 10https://gerrit.wikimedia.org/r/598162 (owner: 10Reedy) [14:07:51] (03CR) 10Paladox: [C: 03+1] Make sync-with-gerrit.py use state not description for skipping [extensions] - 10https://gerrit.wikimedia.org/r/598160 (https://phabricator.wikimedia.org/T253450) (owner: 10Reedy) [14:08:31] (03CR) 10Paladox: [C: 03+1] Make sync-with-gerrit.py use state not description for skipping [skins] - 10https://gerrit.wikimedia.org/r/598161 (https://phabricator.wikimedia.org/T253450) (owner: 10Reedy) [14:08:44] 10MediaWiki-extensions-OATHAuth: Recovery option for Webauthn - https://phabricator.wikimedia.org/T244348 (10Reedy) >>! In T244348#6160189, @jeblad wrote: > So, what about alternate MFA and in particular scratch codes? Already answered in this ticket >>! In T244348#5853343, @Reedy wrote: > The rest of this req... [14:10:44] (03CR) 10Reedy: [V: 03+2 C: 03+2] Make sync-with-gerrit.py use state not description for skipping [skins] - 10https://gerrit.wikimedia.org/r/598161 (https://phabricator.wikimedia.org/T253450) (owner: 10Reedy) [14:10:58] (03PS1) 10Reedy: Remove some submodules again [extensions] - 10https://gerrit.wikimedia.org/r/598163 [14:11:09] (03CR) 10Reedy: [V: 03+2 C: 03+2] Make sync-with-gerrit.py use state not description for skipping [extensions] - 10https://gerrit.wikimedia.org/r/598160 (https://phabricator.wikimedia.org/T253450) (owner: 10Reedy) [14:11:25] (03CR) 10Reedy: [V: 03+2 C: 03+2] Remove some submodules again [extensions] - 10https://gerrit.wikimedia.org/r/598163 (owner: 10Reedy) [14:18:01] (03PS1) 10Reedy: Remove git directory if it's not being kept as a submodule [extensions] - 10https://gerrit.wikimedia.org/r/598164 (https://phabricator.wikimedia.org/T253451) [14:18:23] (03CR) 10Reedy: [V: 03+2 C: 03+2] Remove git directory if it's not being kept as a submodule [extensions] - 10https://gerrit.wikimedia.org/r/598164 (https://phabricator.wikimedia.org/T253451) (owner: 10Reedy) [14:19:37] (03PS1) 10Reedy: Remove git directory if it's not being kept as a submodule [skins] - 10https://gerrit.wikimedia.org/r/598165 (https://phabricator.wikimedia.org/T253451) [14:19:55] (03CR) 10Reedy: [V: 03+2 C: 03+2] Remove git directory if it's not being kept as a submodule [skins] - 10https://gerrit.wikimedia.org/r/598165 (https://phabricator.wikimedia.org/T253451) (owner: 10Reedy) [14:24:36] (03PS1) 10Reedy: Update [extensions] - 10https://gerrit.wikimedia.org/r/598166 [14:24:57] (03CR) 10Reedy: [V: 03+2 C: 03+2] Update [extensions] - 10https://gerrit.wikimedia.org/r/598166 (owner: 10Reedy) [14:26:10] (03PS1) 10Reedy: Remove update-extensions.sh [extensions] - 10https://gerrit.wikimedia.org/r/598167 [14:28:03] (03PS2) 10Reedy: Remove update-extensions.sh [extensions] - 10https://gerrit.wikimedia.org/r/598167 [14:28:05] (03PS1) 10Reedy: Improve sync-with-gerrit.py desc [extensions] - 10https://gerrit.wikimedia.org/r/598168 [14:28:26] (03CR) 10Reedy: [V: 03+2 C: 03+2] Improve sync-with-gerrit.py desc [extensions] - 10https://gerrit.wikimedia.org/r/598168 (owner: 10Reedy) [14:28:40] (03CR) 10Reedy: "Does anyone actually use update-extensions.sh?" [extensions] - 10https://gerrit.wikimedia.org/r/598167 (owner: 10Reedy) [14:29:58] (03CR) 10Reedy: "Fixed, and hopefully prevented from regressing again" [extensions] - 10https://gerrit.wikimedia.org/r/597808 (owner: 10Reedy) [14:34:32] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-CentralAuth: CentralAuth: Autologin fails half-way on wikimania2009 – wikimania2012 (Access-Control-Allow-Origin mismatch) - https://phabricator.wikimedia.org/T64880 (10Xqt) Sorry, wrong task [14:36:51] (03PS9) 10Pppery: Fix inconsistent Newsletter permission checking [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/446642 (https://phabricator.wikimedia.org/T188139) [14:37:16] 10MediaWiki-File-management, 10MediaWiki-Uploading, 10Commons, 10Operations, and 2 others: Some (recent?) uploads to Commons are not available on other wikis - https://phabricator.wikimedia.org/T253405 (10CDanis) Of the 500 most recent uploads at the time I pulled the list, 49/500 were affected: | mw.org... [14:39:19] (03PS10) 10Pppery: Fix inconsistent Newsletter permission checking [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/446642 (https://phabricator.wikimedia.org/T188139) [14:46:48] 10MediaWiki-File-management, 10MediaWiki-Uploading, 10Commons, 10Operations, and 2 others: Some (recent?) uploads to Commons are not available on other wikis - https://phabricator.wikimedia.org/T253405 (10Krinkle) [14:50:45] (03CR) 10Umherirrender: "The new arguments in ApiAuthManagerHelper.php are optional. I see no breaking change here" [core] - 10https://gerrit.wikimedia.org/r/585023 (owner: 10Umherirrender) [14:54:33] (03CR) 10Reedy: "Indeed. This is definitely not a breaking change. Parameter is optional and it will fallback to MediaWikiServices::getInstance()->getAuthM" [core] - 10https://gerrit.wikimedia.org/r/585023 (owner: 10Umherirrender) [14:59:32] 10MobileFrontend, 10Timeless: Enhanced RC on Timeless with MF does not show expansion arrows - https://phabricator.wikimedia.org/T253371 (10Ostrzyciel) It turns out Minerva disables enhanced RC altogether through a hook: https://gerrit.wikimedia.org/g/mediawiki/skins/MinervaNeue/+/0c488fa4f775815e96a64924c6b24... [15:16:08] 10MediaWiki-extensions-Other, 10Other-skins, 10Projects-Cleanup, 10Repository-Admins, and 2 others: Archive the extension/skin - https://phabricator.wikimedia.org/T253452 (10RhinosF1) [15:17:31] (03PS1) 10Umherirrender: AtEase::quietCall should restore warnings in exception case [at-ease] - 10https://gerrit.wikimedia.org/r/598169 [15:22:34] (03PS1) 10Reedy: Relax symfony/yaml to ~5.0.5 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/598172 [15:23:24] (03PS1) 10Reedy: symfony/yaml from 5.0.5 to 5.0.8 [core] - 10https://gerrit.wikimedia.org/r/598173 [15:26:44] 10Social-Tools, 10CSS: Remove inline styling from SiteScout - https://phabricator.wikimedia.org/T147260 (10RhinosF1) 05Open→03Declined T253452 [15:26:46] 10Social-Tools, 10CSS, 10Epic, 10Technical-Debt: [EPIC] Remove inline styling from Social Tools extensions - https://phabricator.wikimedia.org/T87148 (10RhinosF1) [15:26:46] (03PS4) 10Reedy: Add missing message `verifyoathforuser` [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/596855 (https://phabricator.wikimedia.org/T209749) (owner: 10DannyS712) [15:26:50] (03CR) 10Reedy: [C: 03+2] Add missing message `verifyoathforuser` [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/596855 (https://phabricator.wikimedia.org/T209749) (owner: 10DannyS712) [15:27:04] (03PS1) 10Reedy: christian-riesen/base32 to 1.3.2 [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/598174 [15:27:26] 10MediaWiki-File-management, 10MediaWiki-Uploading, 10Commons, 10Operations, and 3 others: Some (recent?) uploads to Commons are not available on other wikis - https://phabricator.wikimedia.org/T253405 (10Krinkle) [15:27:41] 10Social-Tools, 10CSS: Clean up CSS for SiteScout - https://phabricator.wikimedia.org/T154059 (10RhinosF1) 05Open→03Declined T253452 [15:27:47] 10Social-Tools, 10CSS, 10Epic, 10Patch-For-Review, 10Technical-Debt: [EPIC] Clean up CSS for socials tools extensions - https://phabricator.wikimedia.org/T154048 (10RhinosF1) [15:27:57] 10Social-Tools, 10CSS, 10Mobile: Bars overflowing on Special:SiteScout on mobile - https://phabricator.wikimedia.org/T156132 (10RhinosF1) 05Open→03Declined T253452 [15:28:44] 10MediaWiki-extensions-OAuth, 10PHP 7.4 support: league/oauth2-server PHP 7.4 - https://phabricator.wikimedia.org/T253453 (10Reedy) [15:29:21] (03PS1) 10Umherirrender: Use real var args in AtEase::quietCall [at-ease] - 10https://gerrit.wikimedia.org/r/598175 [15:30:08] (03Merged) 10jenkins-bot: Add missing message `verifyoathforuser` [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/596855 (https://phabricator.wikimedia.org/T209749) (owner: 10DannyS712) [15:31:00] (03CR) 10RhinosF1: [C: 04-1] "> This patch is technically just fine (although my personal" [extensions/SiteScout] - 10https://gerrit.wikimedia.org/r/597260 (owner: 10Paladox) [15:31:47] (03Abandoned) 10Paladox: Add support for actor [extensions/SiteScout] - 10https://gerrit.wikimedia.org/r/597260 (owner: 10Paladox) [15:31:58] (03PS1) 10Reedy: Updating league/oauth2-server (8.0.0 => 8.1.0) [vendor] - 10https://gerrit.wikimedia.org/r/598176 (https://phabricator.wikimedia.org/T253453) [15:32:46] (03PS1) 10Reedy: Updating league/oauth2-server (8.0.0 => 8.1.0) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/598177 (https://phabricator.wikimedia.org/T253453) [15:35:00] 10AbuseFilter: Add variable for categories added/removed in an edit or new/old categories - https://phabricator.wikimedia.org/T60954 (10Huji) @Daimona is this doable? I am assuming yes, because AbuseFilter has access both to the wikitext and the parsed output, so presumably, it should also have access to categor... [15:36:47] (03PS1) 10Reedy: Update web-auth/* v3.1.1 => v3.2.6 [vendor] - 10https://gerrit.wikimedia.org/r/598178 [15:37:34] (03PS1) 10Reedy: Update web-auth/* v3.1.1 => v3.2.6 [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/598179 [15:40:21] (03CR) 10Cindy-the-browser-test-bot: [V: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/598172 (owner: 10Reedy) [15:42:05] 10AbuseFilter: Add variable for categories added/removed in an edit or new/old categories - https://phabricator.wikimedia.org/T60954 (10Daimona) >>! In T60954#6160302, @Huji wrote: > @Daimona is this doable? I am assuming yes, because AbuseFilter has access both to the wikitext and the parsed output, so presumab... [15:44:42] 10MediaWiki-extensions-OAuth, 10PHP 7.4 support, 10Patch-For-Review: league/oauth2-server PHP 7.4 support - https://phabricator.wikimedia.org/T253453 (10Reedy) [15:45:02] 10MediaWiki-extensions-OAuth, 10PHP 7.4 support, 10Patch-For-Review: league/oauth2-server PHP 7.4 support - https://phabricator.wikimedia.org/T253453 (10Reedy) [15:49:14] 10Accessibility, 10MediaWiki-Parser, 10Epic, 10Technical-Debt: .mw-editsection links should not be part of the element - https://phabricator.wikimedia.org/T13555 (10Izno) [15:49:17] 10Accessibility, 10MediaWiki-General: Screen reader is announcing edit and edit source along in the headings - https://phabricator.wikimedia.org/T253423 (10Izno) [15:55:36] (03PS8) 10Ori.livneh: mime: represent lists as arrays instead of space-delimited strings [core] - 10https://gerrit.wikimedia.org/r/598075 (https://phabricator.wikimedia.org/T252228) [16:01:46] 10MediaWiki-File-management, 10MediaWiki-Uploading, 10Commons, 10Operations, and 3 others: Some (recent?) uploads to Commons are not available on other wikis - https://phabricator.wikimedia.org/T253405 (10JohanahoJ) The usual way of displaying images, with [[File:Filename.jpg|...]], does not work on svwp f... [16:06:58] (03PS6) 10Daimona Eaytoy: [WIP] Extract another class for handling hooks [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/598077 [16:07:41] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Extract another class for handling hooks [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/598077 (owner: 10Daimona Eaytoy) [16:11:49] 10MediaWiki-File-management, 10MediaWiki-Uploading, 10Commons, 10Operations, and 3 others: Some (recent?) uploads to Commons are not available on other wikis - https://phabricator.wikimedia.org/T253405 (10Krinkle) >>! In T253405#6159575, @gerritbot wrote: > Change 598118 **merged** by jenkins-bot: > [media... [16:12:12] (03CR) 10jerkins-bot: [V: 04-1] mime: represent lists as arrays instead of space-delimited strings [core] - 10https://gerrit.wikimedia.org/r/598075 (https://phabricator.wikimedia.org/T252228) (owner: 10Ori.livneh) [16:14:03] 10Desktop Improvements: [EPIC] Desktop Improvements tasks (catalog) - https://phabricator.wikimedia.org/T249676 (10Demian) @ovasileva As this was my 3rd attempt to explain this ticket: was this a sufficient and understandable approach? [16:17:08] (03CR) 10DannyS712: "> The new arguments in ApiAuthManagerHelper.php are optional. I see" [core] - 10https://gerrit.wikimedia.org/r/585023 (owner: 10Umherirrender) [16:21:10] (03PS9) 10Ori.livneh: mime: represent lists as arrays instead of space-delimited strings [core] - 10https://gerrit.wikimedia.org/r/598075 (https://phabricator.wikimedia.org/T252228) [16:21:12] (03PS1) 10Ori.livneh: mime: Update usage of MimeAnalyst methods [core] - 10https://gerrit.wikimedia.org/r/598181 [16:24:20] 10MobileFrontend, 10Mobile: Not switching to mobile version by default on smartphone - https://phabricator.wikimedia.org/T253449 (10Apap04) At the bottom of the page, you can toggle between desktop or mobile view, see if that helps. I think this used to be a recurring issue with MobileFrontend before? But I ca... [16:24:50] 10MobileFrontend, 10Mobile: Not switching to mobile version by default on smartphone - https://phabricator.wikimedia.org/T253449 (10Aklapper) 05Open→03Stalled Hi @Capankajsmilyo, thanks for taking the time to report this! Unfortunately this Wikimedia Phabricator task lacks some information. If you have tim... [16:38:50] (03CR) 10Ori.livneh: "DannyS712: Good idea; done. The split-off change is I45c9fc592." [core] - 10https://gerrit.wikimedia.org/r/598075 (https://phabricator.wikimedia.org/T252228) (owner: 10Ori.livneh) [16:49:50] 10MobileFrontend, 10Mobile: Not switching to mobile version by default on smartphone - https://phabricator.wikimedia.org/T253449 (10Capankajsmilyo) [16:50:08] 10TemplateStyles: Need help installing TemplateStyles / Besoin d'aide pour installer TemplateStyles - https://phabricator.wikimedia.org/T253444 (10Aklapper) @Sebunian: No problem at all! :) I've made an edit in https://www.mediawiki.org/w/index.php?title=Composer&type=revision&diff=3873673&oldid=3832561 to clari... [16:50:49] 10TemplateStyles: Need help installing TemplateStyles / Besoin d'aide pour installer TemplateStyles - https://phabricator.wikimedia.org/T253444 (10Aklapper) Ah, looks like this was moved to https://www.mediawiki.org/wiki/Topic:Vmwfnm6hw0m82pt8 - thanks! [16:56:41] (03PS1) 10Aaron Schulz: filerepo: make LocalRepo::getSharedCacheKey() use makeGlobalKey() [core] - 10https://gerrit.wikimedia.org/r/598182 (https://phabricator.wikimedia.org/T253405) [16:58:52] 04(no projects): Watchlist entries not being grouped in mobile view like it happens in desktop view - https://phabricator.wikimedia.org/T253454 (10Capankajsmilyo) [17:00:04] 10MediaWiki-Watchlist, 10MobileFrontend, 10Growth-Team: Watchlist entries not being grouped in mobile view like it happens in desktop view - https://phabricator.wikimedia.org/T253454 (10Majavah) [17:05:01] 10MediaWiki-extensions-Arrays: Arrays extension cannot parse certain numbers - https://phabricator.wikimedia.org/T245134 (10Kaffeeringe) Same problem here: ` {{#arraydefine:test|-1,-2,1,2,3|,}} {{#arrayprint:test|
|@@@@|Test: @@@@}} ` turns into: ` Test: -Array Test: -Array Test: Array Test: Array Test: Ar... [17:09:11] 04(no projects): Syntax highlight editing is extremely difficult from mobile - https://phabricator.wikimedia.org/T253455 (10Capankajsmilyo) [17:09:59] 10MediaWiki-extensions-CodeMirror, 10Community-Tech: Syntax highlight editing is extremely difficult from mobile - https://phabricator.wikimedia.org/T253455 (10Majavah) [17:11:45] 10Desktop Improvements, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Spike, 10Vue.js (Vue.js-Search): [Spike] How should i18n work for Vue.js search? - https://phabricator.wikimedia.org/T249308 (10Niedzielski) [17:11:58] (03CR) 10Krinkle: [C: 03+1] "These are inherited by Foreign*Repo so no changes needed there." [core] - 10https://gerrit.wikimedia.org/r/598182 (https://phabricator.wikimedia.org/T253405) (owner: 10Aaron Schulz) [17:12:01] (03CR) 10Krinkle: [C: 03+2] filerepo: make LocalRepo::getSharedCacheKey() use makeGlobalKey() [core] - 10https://gerrit.wikimedia.org/r/598182 (https://phabricator.wikimedia.org/T253405) (owner: 10Aaron Schulz) [17:16:51] (03PS21) 10Jdlrobson: Treat languages and toolbox like other sidebar links [core] - 10https://gerrit.wikimedia.org/r/596756 (https://phabricator.wikimedia.org/T252917) [17:18:43] 10Desktop Improvements, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Spike, 10Vue.js (Vue.js-Search): [Spike] How should i18n work for Vue.js search? - https://phabricator.wikimedia.org/T249308 (10Niedzielski) Thank you, @santhosh. Very helpful. I've tried to summarize your feedback in the description.... [17:19:13] (03CR) 10Jdlrobson: Treat languages and toolbox like other sidebar links (031 comment) [core] - 10https://gerrit.wikimedia.org/r/596756 (https://phabricator.wikimedia.org/T252917) (owner: 10Jdlrobson) [17:21:51] (03PS1) 10Aaron Schulz: filerepo: make ForeignDBRepo::getSharedKey() use the DB domain ID for consistency [core] - 10https://gerrit.wikimedia.org/r/598183 [17:21:58] (03CR) 10Krinkle: Add new SiteStatistics service to replace SiteStats (031 comment) [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) (owner: 10DannyS712) [17:26:02] 10Spike, 10Vue.js (Vue.js-Search): [Spike] Build step, ResourceLoader, or both for Vue.js search? - https://phabricator.wikimedia.org/T249350 (10Niedzielski) [17:27:35] (03CR) 10Jdlrobson: [C: 03+2] "Much easier to read! Thank you!" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/597122 (owner: 10Mainframe98) [17:28:42] (03PS2) 10Aaron Schulz: filerepo: make LocalRepo::getSharedCacheKey() use makeGlobalKey() [core] - 10https://gerrit.wikimedia.org/r/598182 (https://phabricator.wikimedia.org/T253405) [17:30:01] (03CR) 10Mainframe98: skins: Use local getters rather than globals or static functions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/597122 (owner: 10Mainframe98) [17:31:20] (03PS1) 10Aaron Schulz: filerepo: make LocalRepo::getSharedCacheKey() use makeGlobalKey() [core] (wmf/1.35.0-wmf.32) - 10https://gerrit.wikimedia.org/r/598185 (https://phabricator.wikimedia.org/T253405) [17:31:44] (03PS2) 10Umherirrender: AtEase::quietCall should restore error level in exception case [at-ease] - 10https://gerrit.wikimedia.org/r/598169 [17:32:20] (03PS22) 10Jdlrobson: Treat languages and toolbox like other sidebar links [core] - 10https://gerrit.wikimedia.org/r/596756 (https://phabricator.wikimedia.org/T252917) [17:33:00] (03PS3) 10Krinkle: filerepo: make LocalRepo::getSharedCacheKey() use makeGlobalKey() [core] - 10https://gerrit.wikimedia.org/r/598182 (https://phabricator.wikimedia.org/T253405) (owner: 10Aaron Schulz) [17:33:15] (03CR) 10Krinkle: [C: 03+2] filerepo: make LocalRepo::getSharedCacheKey() use makeGlobalKey() [core] - 10https://gerrit.wikimedia.org/r/598182 (https://phabricator.wikimedia.org/T253405) (owner: 10Aaron Schulz) [17:33:27] (03PS1) 10Krinkle: filerepo: make LocalRepo::getSharedCacheKey() use makeGlobalKey() [core] (wmf/1.35.0-wmf.31) - 10https://gerrit.wikimedia.org/r/598186 (https://phabricator.wikimedia.org/T253405) [17:33:52] (03CR) 10Krinkle: [C: 03+2] filerepo: make LocalRepo::getSharedCacheKey() use makeGlobalKey() [core] (wmf/1.35.0-wmf.31) - 10https://gerrit.wikimedia.org/r/598186 (https://phabricator.wikimedia.org/T253405) (owner: 10Krinkle) [17:33:57] (03CR) 10Krinkle: [C: 03+2] filerepo: make LocalRepo::getSharedCacheKey() use makeGlobalKey() [core] (wmf/1.35.0-wmf.32) - 10https://gerrit.wikimedia.org/r/598185 (https://phabricator.wikimedia.org/T253405) (owner: 10Aaron Schulz) [17:34:24] (03PS2) 10Aaron Schulz: filerepo: make LocalRepo::getSharedCacheKey() use makeGlobalKey() [core] (wmf/1.35.0-wmf.31) - 10https://gerrit.wikimedia.org/r/598186 (https://phabricator.wikimedia.org/T253405) (owner: 10Krinkle) [17:35:27] 10Desktop Improvements, 10Epic, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Vue.js (Vue.js-Search): [Epic] Build the new Vue.js search experience - https://phabricator.wikimedia.org/T249299 (10Niedzielski) [17:36:37] (03PS3) 10Krinkle: filerepo: make LocalRepo::getSharedCacheKey() use makeGlobalKey() [core] (wmf/1.35.0-wmf.31) - 10https://gerrit.wikimedia.org/r/598186 (https://phabricator.wikimedia.org/T253405) [17:37:41] 10Desktop Improvements, 10Vue.js (Vue.js-Search): Deploy the new Vue.js search experience - https://phabricator.wikimedia.org/T249297 (10Niedzielski) [17:37:52] (03CR) 10Krinkle: [C: 03+2] filerepo: make LocalRepo::getSharedCacheKey() use makeGlobalKey() [core] (wmf/1.35.0-wmf.31) - 10https://gerrit.wikimedia.org/r/598186 (https://phabricator.wikimedia.org/T253405) (owner: 10Krinkle) [17:38:41] 10MediaWiki-File-management, 10MediaWiki-Uploading, 10Commons, 10Operations, and 4 others: Some (recent?) uploads to Commons are not available on other wikis - https://phabricator.wikimedia.org/T253405 (10Bahnmoeller) https://commons.wikimedia.org/wiki/File:Christopher_Fiori.jpg is also not showing on wiki... [17:40:32] (03CR) 10Krinkle: skins: Use local getters rather than globals or static functions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/597122 (owner: 10Mainframe98) [17:41:08] 10Desktop Improvements, 10Epic, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Vue.js (Vue.js-Search): [Epic] Build the new Vue.js search experience - https://phabricator.wikimedia.org/T249299 (10Niedzielski) [17:44:05] (03CR) 10Mainframe98: skins: Use local getters rather than globals or static functions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/597122 (owner: 10Mainframe98) [17:48:22] (03Merged) 10jenkins-bot: skins: Use local getters rather than globals or static functions [core] - 10https://gerrit.wikimedia.org/r/597122 (owner: 10Mainframe98) [17:49:03] (03CR) 10jerkins-bot: [V: 04-1] Treat languages and toolbox like other sidebar links [core] - 10https://gerrit.wikimedia.org/r/596756 (https://phabricator.wikimedia.org/T252917) (owner: 10Jdlrobson) [17:49:57] (03PS4) 10Krinkle: mediawiki.misc-authed-curate: Simplify and clean up patrol.js [core] - 10https://gerrit.wikimedia.org/r/598141 [17:50:07] (03Merged) 10jenkins-bot: filerepo: make LocalRepo::getSharedCacheKey() use makeGlobalKey() [core] (wmf/1.35.0-wmf.32) - 10https://gerrit.wikimedia.org/r/598185 (https://phabricator.wikimedia.org/T253405) (owner: 10Aaron Schulz) [17:50:29] (03CR) 10Krinkle: mediawiki.misc-authed-curate: Simplify and clean up patrol.js (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598141 (owner: 10Krinkle) [17:52:37] (03CR) 10DannyS712: Add new SiteStatistics service to replace SiteStats (031 comment) [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) (owner: 10DannyS712) [17:53:37] (03CR) 10Krinkle: Add new SiteStatistics service to replace SiteStats (031 comment) [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) (owner: 10DannyS712) [17:54:12] (03Merged) 10jenkins-bot: filerepo: make LocalRepo::getSharedCacheKey() use makeGlobalKey() [core] (wmf/1.35.0-wmf.31) - 10https://gerrit.wikimedia.org/r/598186 (https://phabricator.wikimedia.org/T253405) (owner: 10Krinkle) [17:54:22] (03Merged) 10jenkins-bot: filerepo: make LocalRepo::getSharedCacheKey() use makeGlobalKey() [core] - 10https://gerrit.wikimedia.org/r/598182 (https://phabricator.wikimedia.org/T253405) (owner: 10Aaron Schulz) [17:55:35] (03CR) 10DannyS712: Add new SiteStatistics service to replace SiteStats (031 comment) [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) (owner: 10DannyS712) [18:00:32] (03PS3) 10DannyS712: Add new SiteStatistics class to replace SiteStats [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) [18:01:21] 10Spike, 10Vue.js (Vue.js-Search): [Spike] Should shared components be compiled for Vue.js search? - https://phabricator.wikimedia.org/T249658 (10Niedzielski) [18:03:07] (03PS4) 10DannyS712: Add new SiteStatistics class to replace SiteStats [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) [18:03:22] (03PS5) 10DannyS712: Add new SiteStatistics class to replace SiteStats [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) [18:06:51] (03CR) 10jerkins-bot: [V: 04-1] mediawiki.misc-authed-curate: Simplify and clean up patrol.js [core] - 10https://gerrit.wikimedia.org/r/598141 (owner: 10Krinkle) [18:07:26] (03CR) 10DannyS712: mime: represent lists as arrays instead of space-delimited strings (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598075 (https://phabricator.wikimedia.org/T252228) (owner: 10Ori.livneh) [18:10:33] (03PS5) 10Krinkle: mediawiki.misc-authed-curate: Simplify and clean up patrol.js [core] - 10https://gerrit.wikimedia.org/r/598141 [18:13:05] 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Spike, 10Vue.js (Vue.js-Search): [Spike] Build and deploy a Vue.js search prototype to labs - https://phabricator.wikimedia.org/T251832 (10Niedzielski) [18:14:01] 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Spike, 10Vue.js (Vue.js-Search): [Spike] Build and deploy a Vue.js search prototype to labs - https://phabricator.wikimedia.org/T251832 (10Niedzielski) a:05Niedzielski→03None [18:14:35] (03CR) 10Fomafix: [C: 04-1] mediawiki.misc-authed-curate: Simplify and clean up patrol.js (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598141 (owner: 10Krinkle) [18:15:34] (03PS1) 10Esanders: Move extend to regular dependencies [services/cxserver] - 10https://gerrit.wikimedia.org/r/598189 [18:15:58] (03PS6) 10DannyS712: Add new SiteStatistics class to replace SiteStats [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) [18:19:54] (03PS1) 10Aaron Schulz: filerepo: bump LocalFile::VERSION following 88e17d3f7c78 [core] - 10https://gerrit.wikimedia.org/r/598190 (https://phabricator.wikimedia.org/T253405) [18:20:16] (03CR) 10Krinkle: [C: 03+2] "Thx, see also" [at-ease] - 10https://gerrit.wikimedia.org/r/598169 (owner: 10Umherirrender) [18:20:23] (03PS7) 10DannyS712: Add new SiteStatistics class to replace SiteStats [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) [18:20:50] (03Merged) 10jenkins-bot: AtEase::quietCall should restore error level in exception case [at-ease] - 10https://gerrit.wikimedia.org/r/598169 (owner: 10Umherirrender) [18:21:33] (03CR) 10Krinkle: [C: 03+1] Use real var args in AtEase::quietCall [at-ease] - 10https://gerrit.wikimedia.org/r/598175 (owner: 10Umherirrender) [18:21:41] (03CR) 10Krinkle: [C: 03+1] "rebase for https://gerrit.wikimedia.org/r/#/c/at-ease/+/598169/2/src/Wikimedia/AtEase/AtEase.php" [at-ease] - 10https://gerrit.wikimedia.org/r/598175 (owner: 10Umherirrender) [18:25:00] (03PS1) 10Aaron Schulz: filerepo: bump LocalFile::VERSION following 88e17d3f7c78 [core] (wmf/1.35.0-wmf.32) - 10https://gerrit.wikimedia.org/r/598191 (https://phabricator.wikimedia.org/T253405) [18:27:30] (03CR) 10jerkins-bot: [V: 04-1] mediawiki.misc-authed-curate: Simplify and clean up patrol.js [core] - 10https://gerrit.wikimedia.org/r/598141 (owner: 10Krinkle) [18:30:14] (03PS1) 10Aaron Schulz: filerepo: bump LocalFile::VERSION following 88e17d3f7c78 [core] (wmf/1.35.0-wmf.31) - 10https://gerrit.wikimedia.org/r/598193 (https://phabricator.wikimedia.org/T253405) [18:30:38] (03CR) 10Krinkle: Add new SiteStatistics class to replace SiteStats (035 comments) [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) (owner: 10DannyS712) [18:30:51] (03CR) 10Krinkle: [C: 03+2] filerepo: bump LocalFile::VERSION following 88e17d3f7c78 [core] (wmf/1.35.0-wmf.32) - 10https://gerrit.wikimedia.org/r/598191 (https://phabricator.wikimedia.org/T253405) (owner: 10Aaron Schulz) [18:32:08] (03CR) 10Krinkle: [C: 03+2] filerepo: bump LocalFile::VERSION following 88e17d3f7c78 [core] (wmf/1.35.0-wmf.31) - 10https://gerrit.wikimedia.org/r/598193 (https://phabricator.wikimedia.org/T253405) (owner: 10Aaron Schulz) [18:32:19] (03CR) 10Krinkle: [C: 03+2] filerepo: bump LocalFile::VERSION following 88e17d3f7c78 [core] - 10https://gerrit.wikimedia.org/r/598190 (https://phabricator.wikimedia.org/T253405) (owner: 10Aaron Schulz) [18:35:15] (03CR) 10Krinkle: [C: 04-1] DefaultSettings: Fix @since for $wgStatsdMetricPrefix and $wgSiteTypes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/593882 (owner: 10Shirayuki) [18:37:10] (03PS5) 10Paladox: Convert si_title from varcher to MEDIUMTEXT in searchindex [core] - 10https://gerrit.wikimedia.org/r/598104 [18:38:33] 10Spike, 10Vue.js (Vue.js-Search): [Spike] Should shared components be compiled for Vue.js search? - https://phabricator.wikimedia.org/T249658 (10Demian) @Niedzielski The [[ https://docs.google.com/document/d/1SxjahOrPsVPGQAd_OYz3s_gw077XUHQFTNG8RzBnG_I/edit# | Google Docs ]] linked in the description is priv... [18:39:41] 04(no projects): toolforge: redirects to old toolforge url scheme on Commons - https://phabricator.wikimedia.org/T253457 (10Ferdi2005) [18:39:50] (03CR) 10Krinkle: "I remember there was a ticket about this, which had open questions." [core] - 10https://gerrit.wikimedia.org/r/598104 (owner: 10Paladox) [18:40:01] 04(no projects): toolforge: redirects to old toolforge url scheme on Commons - https://phabricator.wikimedia.org/T253457 (10Ferdi2005) p:05Triage→03Lowest [18:40:37] (03PS2) 10Umherirrender: Use real var args in AtEase::quietCall [at-ease] - 10https://gerrit.wikimedia.org/r/598175 [18:41:08] (03CR) 10Umherirrender: "Rebased" [at-ease] - 10https://gerrit.wikimedia.org/r/598175 (owner: 10Umherirrender) [18:44:01] 10MediaWiki-extensions-Other, 10Projects-Cleanup, 10Repository-Admins, 10Social-Tools, and 3 others: Archive the SiteScout extension - https://phabricator.wikimedia.org/T253452 (10Dinoguy1000) [18:46:21] 10MediaWiki-Cache, 10Performance-Team, 10observability: Add WANObjectCache size metrics to Grafana dashboards - https://phabricator.wikimedia.org/T250578 (10aaron) 05Open→03Resolved Added two panels to the regeneration row. [18:47:32] (03Merged) 10jenkins-bot: filerepo: bump LocalFile::VERSION following 88e17d3f7c78 [core] (wmf/1.35.0-wmf.32) - 10https://gerrit.wikimedia.org/r/598191 (https://phabricator.wikimedia.org/T253405) (owner: 10Aaron Schulz) [18:47:39] 04(no projects): toolforge: redirects to old toolforge url scheme on Commons - https://phabricator.wikimedia.org/T253457 (10Majavah) [18:49:19] (03Merged) 10jenkins-bot: filerepo: bump LocalFile::VERSION following 88e17d3f7c78 [core] (wmf/1.35.0-wmf.31) - 10https://gerrit.wikimedia.org/r/598193 (https://phabricator.wikimedia.org/T253405) (owner: 10Aaron Schulz) [18:49:50] 10Projects-Cleanup: mw:Template:Archived (extension|skin): add new "task" field - https://phabricator.wikimedia.org/T204489 (10Dinoguy1000) I'd still like support for multiple tasks, but I don't think that should block. As is, it looks fine. [18:50:16] (03Merged) 10jenkins-bot: filerepo: bump LocalFile::VERSION following 88e17d3f7c78 [core] - 10https://gerrit.wikimedia.org/r/598190 (https://phabricator.wikimedia.org/T253405) (owner: 10Aaron Schulz) [18:51:28] 10Desktop Improvements: [EPIC] Desktop Improvements tasks (catalog) - https://phabricator.wikimedia.org/T249676 (10Demian) [18:53:56] (03PS8) 10DannyS712: Add new SiteStatistics class to replace SiteStats [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) [18:54:08] (03CR) 10DannyS712: Add new SiteStatistics class to replace SiteStats (035 comments) [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) (owner: 10DannyS712) [18:54:10] (03PS9) 10DannyS712: Add new SiteStatistics class to replace SiteStats [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) [18:57:42] 10MediaWiki-extensions-Other, 10Projects-Cleanup, 10Repository-Admins, 10Social-Tools, and 3 others: Archive the SiteScout extension - https://phabricator.wikimedia.org/T253452 (10RhinosF1) p:05Triage→03Medium [18:59:42] 10MediaWiki-extensions-Other, 10Projects-Cleanup, 10Repository-Admins, 10Social-Tools, and 3 others: Archive the SiteScout extension - https://phabricator.wikimedia.org/T253452 (10RhinosF1) a:03RhinosF1 As said above, by late monday, I’ll do the rest I can do [19:06:17] 10Spike, 10Vue.js (Vue.js-Search): [Spike] Should shared components be compiled for Vue.js search? - https://phabricator.wikimedia.org/T249658 (10Niedzielski) @demian, I am not the owner of this internal discussion document but will make the request on your behalf. [19:07:59] (03CR) 10jerkins-bot: [V: 04-1] Add new SiteStatistics class to replace SiteStats [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) (owner: 10DannyS712) [19:08:56] (03PS10) 10DannyS712: Add new SiteStatistics class to replace SiteStats [core] - 10https://gerrit.wikimedia.org/r/597488 (https://phabricator.wikimedia.org/T253184) [19:11:27] 10Projects-Cleanup: mw:Template:Archived (extension|skin): add new "task" field - https://phabricator.wikimedia.org/T204489 (10Pppery) I didn't code that, mostly because it seems to me that if the archival is complicated enough to merit more than one phabricator task, it's likely complicated enough to need a cus... [19:13:30] 10Desktop Improvements, 10Product-Analytics (Kanban), 10Readers-Web-Backlog (Kanbanana-2019-20-Q4): Collapsible Sidebar : Instrumentation and Requirement gathering - https://phabricator.wikimedia.org/T247334 (10Demian) @Mayakp.wiki Now that the [[ https://docs.google.com/spreadsheets/d/1gf0gHuo8pXUZDL8aQDrf... [19:14:21] 10Google-Summer-of-Code (2020): Create a basic skeleton, create API endpoint to parse pagelist tags - https://phabricator.wikimedia.org/T253458 (10Soda) [19:15:48] 10Projects-Cleanup: mw:Template:Archived (extension|skin): add new "task" field - https://phabricator.wikimedia.org/T204489 (10Pppery) 05Open→03Resolved Template changes will need to be marked for translation [19:19:31] (03CR) 10DannyS712: [C: 04-1] language: WIP! Introduce NamespaceNameLocalizer and NamespaceNameFormatter (035 comments) [core] - 10https://gerrit.wikimedia.org/r/596229 (https://phabricator.wikimedia.org/T252137) (owner: 10Peter.ovchyn) [19:26:58] 10MediaWiki-Page-deletion: Create a separate list of suppression-only reasons for action=delete - https://phabricator.wikimedia.org/T250631 (10Umherirrender) p:05Triage→03Medium a:03Umherirrender [19:28:21] (03PS1) 10Umherirrender: Split reason dropdown list for action=delete [core] - 10https://gerrit.wikimedia.org/r/598194 (https://phabricator.wikimedia.org/T250631) [19:39:33] 10MediaWiki-Language-converter, 10CPT Initiatives (Decoupling (CDP2)), 10Core Platform Team Workboards (Contractor Workboard), 10I18n: Replace Language related calls in LanguageConverter by injecting callbacks, and avoid LanguageConverter from Language - https://phabricator.wikimedia.org/T253460 (10Peter.ov... [19:41:58] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10at-ease, 10Proposal: Liberate the @ for AtEase - https://phabricator.wikimedia.org/T253461 (10Krinkle) [19:42:55] (03CR) 10Krinkle: [C: 03+2] VueComponentParser: Add test case for self-closing tags [core] - 10https://gerrit.wikimedia.org/r/598147 (owner: 10Catrope) [19:44:12] 10Desktop Improvements, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Spike: [Spike 8hrs] Make collapsible sidebar persistent across sessions for logged-in users, for sessions for logged-out users - https://phabricator.wikimedia.org/T246427 (10Demian) >>! In T246427#6147077, @nray wrote: > Today I remember... [19:45:31] 10MediaWiki-extensions-CodeMirror, 10Community-Tech: Syntax highlight editing is extremely difficult from mobile - https://phabricator.wikimedia.org/T253455 (10Aklapper) 05Open→03Stalled You chose to use the desktop version on a small screen and this ticket lacks any steps to reproduce the environment (you... [19:45:34] 10MediaWiki-Language-converter, 10CPT Initiatives (Decoupling (CDP2)), 10Core Platform Team Workboards (Contractor Workboard), 10I18n: Replace Language related calls in LanguageConverter by injecting callbacks, and avoid LanguageConverter from Language - https://phabricator.wikimedia.org/T253460 (10Peter.ov... [19:54:49] (03PS13) 10Peter.ovchyn: language: WIP! Introduce NamespaceNameLocalizer and NamespaceNameFormatter [core] - 10https://gerrit.wikimedia.org/r/596229 (https://phabricator.wikimedia.org/T252137) [19:58:38] (03CR) 10Ori.livneh: mime: represent lists as arrays instead of space-delimited strings (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598075 (https://phabricator.wikimedia.org/T252228) (owner: 10Ori.livneh) [19:59:23] 10MediaWiki-Language-converter, 10CPT Initiatives (Decoupling (CDP2)), 10Core Platform Team Workboards (Contractor Workboard), 10I18n: Replace Language related calls in LanguageConverter by injecting callbacks, and avoid LanguageConverter from Language - https://phabricator.wikimedia.org/T253460 (10Peter.ov... [20:01:11] 10Desktop Improvements: [EPIC] Desktop Improvements tasks (catalog) - https://phabricator.wikimedia.org/T249676 (10Demian) [20:01:23] (03Merged) 10jenkins-bot: VueComponentParser: Add test case for self-closing tags [core] - 10https://gerrit.wikimedia.org/r/598147 (owner: 10Catrope) [20:21:21] 10Desktop Improvements: [EPIC] Desktop Improvements tasks (catalog) - https://phabricator.wikimedia.org/T249676 (10Aklapper) >>! In T249676#6157984, @Demian wrote: > It's very hard to find specific tasks, such as: > * Tasks where Alex documented the specifications > * Tasks with the patches linked I don't see a... [20:23:51] 10MediaWiki-Watchlist, 10Advanced Mobile Contributions: Watchlist entries not being grouped in mobile view like it happens in desktop view - https://phabricator.wikimedia.org/T253454 (10Aklapper) 05Open→03Declined That is intentionally as it uses a table. See T228280 for more information. [20:23:53] (03PS23) 10Jdlrobson: Treat languages and toolbox like other sidebar links [core] - 10https://gerrit.wikimedia.org/r/596756 (https://phabricator.wikimedia.org/T252917) [20:25:12] 10MediaWiki-Watchlist, 10Advanced Mobile Contributions: Group watchlist entries in mobile view (like in desktop view) - https://phabricator.wikimedia.org/T253454 (10Aklapper) [20:27:51] 10AbuseFilter, 10WorkType-NewFunctionality: Allow more customization on abuse filter blocks - https://phabricator.wikimedia.org/T212699 (10Aklapper) [20:29:26] (03CR) 10DannyS712: [C: 03+1] "LGTM" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598194 (https://phabricator.wikimedia.org/T250631) (owner: 10Umherirrender) [20:32:06] 10MediaWiki-extensions-NewUserMessage: Add a parameter to disable automatic signature by the welcome message editor. - https://phabricator.wikimedia.org/T253446 (10Aklapper) 05Open→03Stalled Hi @NottNott, thanks for taking the time to report this and welcome to Wikimedia Phabricator! If you have time and can... [20:33:51] (03PS6) 10DannyS712: Allow Blockautopromote duration to be configured for wikis. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536755 (https://phabricator.wikimedia.org/T231756) [20:34:35] (03PS1) 10TK-999: Trim comment field content prior to insertion [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/598196 (https://phabricator.wikimedia.org/T199323) [20:40:28] (03PS1) 10Umherirrender: Do not pass Message to HtmlForm::setWrapperLegend [extensions/ApiFeatureUsage] - 10https://gerrit.wikimedia.org/r/598197 [20:42:56] 10Privacy Engineering, 10Security-Team, 10TechCom, 10TechCom-RFC, and 4 others: RFC: Partial opt-out method for Content security policy - https://phabricator.wikimedia.org/T208188 (10AlexisJazz) >>! In T208188#6159015, @Krinkle wrote: > @AlexisJazz What you describe (one-time permission for a specific thir... [20:43:03] (03PS1) 10Vidhi-Mody: Selenium: Update to WebdriverIO v5 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/598198 (https://phabricator.wikimedia.org/T250610) [20:57:15] (03CR) 10jerkins-bot: [V: 04-1] Selenium: Update to WebdriverIO v5 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/598198 (https://phabricator.wikimedia.org/T250610) (owner: 10Vidhi-Mody) [21:05:29] (03PS2) 10Vidhi-Mody: Selenium: Update to WebdriverIO v5 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/598198 (https://phabricator.wikimedia.org/T250610) [21:16:44] (03PS2) 10Umherirrender: Parse messages in string context [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/592707 [21:19:06] (03CR) 10jerkins-bot: [V: 04-1] Parse messages in string context [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/592707 (owner: 10Umherirrender) [21:19:37] (03CR) 10jerkins-bot: [V: 04-1] Selenium: Update to WebdriverIO v5 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/598198 (https://phabricator.wikimedia.org/T250610) (owner: 10Vidhi-Mody) [21:21:49] 10MediaWiki-Language-converter: Request Latin-Cyrillic converter for Romanian wikis - https://phabricator.wikimedia.org/T169453 (10Base) Looking at the Strainu's comment, is it possible to add language conversion to MW without enabling it by default in all wikis with ro content language? [21:26:18] (03PS1) 10Umherirrender: Parse messages in string context [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/598200 [21:28:26] (03CR) 10jerkins-bot: [V: 04-1] Parse messages in string context [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/598200 (owner: 10Umherirrender) [21:30:11] (03PS2) 10Umherirrender: Parse messages in string context [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/598200 [21:30:42] (03PS3) 10Vidhi-Mody: Selenium: Update to WebdriverIO v5 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/598198 (https://phabricator.wikimedia.org/T250610) [21:31:34] (03CR) 10DannyS712: "2 suggestions" (032 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/598196 (https://phabricator.wikimedia.org/T199323) (owner: 10TK-999) [21:33:45] (03CR) 10DannyS712: [C: 03+2] Do not pass Message to HtmlForm::setWrapperLegend [extensions/ApiFeatureUsage] - 10https://gerrit.wikimedia.org/r/598197 (owner: 10Umherirrender) [21:34:14] (03CR) 10DannyS712: [C: 03+2] Parse messages in string context [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/598200 (owner: 10Umherirrender) [21:36:10] (03Merged) 10jenkins-bot: Do not pass Message to HtmlForm::setWrapperLegend [extensions/ApiFeatureUsage] - 10https://gerrit.wikimedia.org/r/598197 (owner: 10Umherirrender) [21:36:42] (03Merged) 10jenkins-bot: Parse messages in string context [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/598200 (owner: 10Umherirrender) [21:43:18] (03CR) 10DannyS712: SpecialApiSandbox: use subpage syntax for linking specific queries (031 comment) [core] - 10https://gerrit.wikimedia.org/r/528207 (owner: 10Gergő Tisza) [21:43:48] (03CR) 10jerkins-bot: [V: 04-1] Selenium: Update to WebdriverIO v5 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/598198 (https://phabricator.wikimedia.org/T250610) (owner: 10Vidhi-Mody) [21:45:35] (03CR) 10DannyS712: "The task specifies that there should be 100% test coverage; this only bring it to 55.84%. Is the plan to continue developing this or to do" [core] - 10https://gerrit.wikimedia.org/r/585628 (https://phabricator.wikimedia.org/T243756) (owner: 10Art-Baltai) [21:47:09] 10Privacy Engineering, 10Security-Team, 10TechCom, 10TechCom-RFC, and 4 others: RFC: Partial opt-out method for Content security policy - https://phabricator.wikimedia.org/T208188 (10Krinkle) This RFC is about gadgets and other user-generated scripts which are not reviewed and verified prior to being made... [21:47:36] 04(no projects): Allow revdel for the edit summaries of oversight-style deleted diffs - https://phabricator.wikimedia.org/T253462 (10Koavf) [21:47:49] (03CR) 10Krinkle: mime: represent lists as arrays instead of space-delimited strings (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598075 (https://phabricator.wikimedia.org/T252228) (owner: 10Ori.livneh) [21:47:57] 10MediaWiki-Revision-deletion: Allow revdel for the edit summaries of oversight-style deleted diffs - https://phabricator.wikimedia.org/T253462 (10Koavf) [21:48:47] (03CR) 10DannyS712: "The task specifies that there should be 100% test coverage with pure Unit tests; this only bring it to 30.43% and includes integration tes" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/588834 (https://phabricator.wikimedia.org/T243747) (owner: 10Art-Baltai) [21:48:54] 10MediaWiki-Documentation, 10Performance-Team, 10Wikimedia-Rdbms, 10Core Platform Team (Icebox), 10Documentation: Document when to use different ILoadBalancer::get*Connection* methods - https://phabricator.wikimedia.org/T236880 (10TK-999) I think there are some additional nuances to consider here: * getC... [21:49:43] (03PS1) 10Umherirrender: Parse messages in string context [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/598202 [21:50:16] (03CR) 10Krinkle: mime: represent lists as arrays instead of space-delimited strings (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598075 (https://phabricator.wikimedia.org/T252228) (owner: 10Ori.livneh) [21:53:14] (03CR) 10Krinkle: mime: represent lists as arrays instead of space-delimited strings (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598075 (https://phabricator.wikimedia.org/T252228) (owner: 10Ori.livneh) [21:53:30] (03CR) 10DannyS712: Add MathCheckerFactory Service (038 comments) [extensions/Math] - 10https://gerrit.wikimedia.org/r/596006 (https://phabricator.wikimedia.org/T252390) (owner: 10Physikerwelt) [21:54:39] (03CR) 10Krinkle: Treat languages and toolbox like other sidebar links (031 comment) [core] - 10https://gerrit.wikimedia.org/r/596756 (https://phabricator.wikimedia.org/T252917) (owner: 10Jdlrobson) [21:55:11] (03CR) 10DannyS712: [C: 03+1] "LGTM" [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/597467 (owner: 10Thiemo Kreuz (WMDE)) [21:56:52] (03PS1) 10Umherirrender: Escape return of Language::formatTimePeriod [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/598203 [21:56:54] (03CR) 10TK-999: Trim comment field content prior to insertion (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/598196 (https://phabricator.wikimedia.org/T199323) (owner: 10TK-999) [21:59:06] (03CR) 10Krinkle: Trim comment field content prior to insertion (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/598196 (https://phabricator.wikimedia.org/T199323) (owner: 10TK-999) [21:59:25] (03PS2) 10TK-999: Trim comment field content prior to insertion [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/598196 (https://phabricator.wikimedia.org/T199323) [21:59:28] (03CR) 10jerkins-bot: [V: 04-1] Escape return of Language::formatTimePeriod [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/598203 (owner: 10Umherirrender) [22:01:22] (03CR) 10DannyS712: onImgAuthBeforeStream: perform permission check (031 comment) [extensions/NSFileRepo] - 10https://gerrit.wikimedia.org/r/595975 (owner: 10Daniel Kinzler) [22:01:24] (03CR) 10TK-999: Trim comment field content prior to insertion (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/598196 (https://phabricator.wikimedia.org/T199323) (owner: 10TK-999) [22:02:22] (03CR) 10Krinkle: Trim comment field content prior to insertion (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/598196 (https://phabricator.wikimedia.org/T199323) (owner: 10TK-999) [22:03:15] (03CR) 10TK-999: Trim comment field content prior to insertion (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/598196 (https://phabricator.wikimedia.org/T199323) (owner: 10TK-999) [22:07:19] (03CR) 10Krinkle: Selenium: Update to WebdriverIO v5 (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/598198 (https://phabricator.wikimedia.org/T250610) (owner: 10Vidhi-Mody) [22:11:40] (03CR) 10TK-999: Trim comment field content prior to insertion (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/598196 (https://phabricator.wikimedia.org/T199323) (owner: 10TK-999) [22:13:02] 10Projects-Cleanup: mw:Template:Archived (extension|skin): add new "task" field - https://phabricator.wikimedia.org/T204489 (10Pppery) (which has now happened) [22:14:44] (03CR) 10Krinkle: Trim comment field content prior to insertion (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/598196 (https://phabricator.wikimedia.org/T199323) (owner: 10TK-999) [22:16:16] (03CR) 10Krinkle: Trim comment field content prior to insertion (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/598196 (https://phabricator.wikimedia.org/T199323) (owner: 10TK-999) [22:17:33] (03CR) 10Krinkle: "Can you describe for each what they currently do, how, and what/if the observable difference is expected to be?" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/598202 (owner: 10Umherirrender) [22:17:56] (03CR) 10Krinkle: [C: 03+2] Use real var args in AtEase::quietCall [at-ease] - 10https://gerrit.wikimedia.org/r/598175 (owner: 10Umherirrender) [22:18:25] (03Merged) 10jenkins-bot: Use real var args in AtEase::quietCall [at-ease] - 10https://gerrit.wikimedia.org/r/598175 (owner: 10Umherirrender) [22:21:14] (03PS3) 10TK-999: Trim comment field content prior to insertion [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/598196 (https://phabricator.wikimedia.org/T199323) [22:21:21] (03CR) 10TK-999: Trim comment field content prior to insertion (032 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/598196 (https://phabricator.wikimedia.org/T199323) (owner: 10TK-999) [22:21:58] (03Abandoned) 10Krinkle: Declare variadic arguments [core] - 10https://gerrit.wikimedia.org/r/477043 (owner: 10Jakub Vrána) [22:25:15] (03PS3) 10Krinkle: Avoid use of $wgLang and $wgRequest [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/584228 (owner: 10Umherirrender) [22:25:21] (03CR) 10jerkins-bot: [V: 04-1] Avoid use of $wgLang and $wgRequest [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/584228 (owner: 10Umherirrender) [22:28:45] (03CR) 10Jack Phoenix: [C: 04-1] "Almost there! Current patchset runs fine, but the avatars and img alt texts are broken...because on 1.34 getUser() returns a user ID inste" (031 comment) [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/593663 (https://phabricator.wikimedia.org/T250761) (owner: 10DannyS712) [22:28:54] (03PS4) 10Krinkle: Avoid use of $wgLang and $wgRequest [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/584228 (owner: 10Umherirrender) [22:29:00] (03PS2) 10Umherirrender: Escape return of Language::formatTimePeriod [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/598203 [22:29:37] (03PS5) 10Krinkle: Avoid use of $wgLang and $wgRequest [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/584228 (owner: 10Umherirrender) [22:29:51] (03CR) 10Krinkle: "Rebased to resolve merge conflicts with newer commits, and verified locally on a plain MW install with this skin." [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/584228 (owner: 10Umherirrender) [22:30:38] (03CR) 10Krinkle: [C: 03+2] "Pages render fine, and there are no entries in mw-error.log" [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/584228 (owner: 10Umherirrender) [22:31:27] (03CR) 10DannyS712: Avoid use of $wgLang and $wgRequest (031 comment) [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/584228 (owner: 10Umherirrender) [22:31:44] (03CR) 10jerkins-bot: [V: 04-1] Escape return of Language::formatTimePeriod [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/598203 (owner: 10Umherirrender) [22:31:51] (03CR) 10Krinkle: [C: 04-1] Use UserNameUtils in GenderCache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/585310 (owner: 10Umherirrender) [22:32:11] (03CR) 10jerkins-bot: [V: 04-1] Avoid use of $wgLang and $wgRequest [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/584228 (owner: 10Umherirrender) [22:32:57] (03PS1) 10Umherirrender: Parse messages in string context [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/598204 [22:33:32] (03CR) 10Krinkle: [C: 04-1] Use StatsdDataFactory service in ParserCache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/589110 (owner: 10Umherirrender) [22:33:47] (03PS8) 10DannyS712: Remove use of DifferenceEngine::$mNewRev and $mOldRev [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/593663 (https://phabricator.wikimedia.org/T250761) [22:33:54] (03CR) 10DannyS712: Remove use of DifferenceEngine::$mNewRev and $mOldRev (031 comment) [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/593663 (https://phabricator.wikimedia.org/T250761) (owner: 10DannyS712) [22:35:01] (03PS6) 10Krinkle: Use MediaWikiServices::resetServiceForTesting for RepoGroup [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/584986 (owner: 10Umherirrender) [22:35:03] (03PS7) 10Krinkle: Use MediaWikiServices::resetServiceForTesting for RepoGroup [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/584986 (owner: 10Umherirrender) [22:35:27] (03PS1) 10Umherirrender: Parse messages in string context [extensions/Echo] - 10https://gerrit.wikimedia.org/r/598206 [22:35:34] (03CR) 10jerkins-bot: [V: 04-1] Parse messages in string context [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/598204 (owner: 10Umherirrender) [22:36:13] (03CR) 10Krinkle: Use MediaWikiServices::resetServiceForTesting for RepoGroup (031 comment) [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/584986 (owner: 10Umherirrender) [22:36:25] (03CR) 10Art-Baltai: "Decoupling is required to cover 100% with tests" [core] - 10https://gerrit.wikimedia.org/r/585628 (https://phabricator.wikimedia.org/T243756) (owner: 10Art-Baltai) [22:36:31] (03CR) 10Krinkle: [C: 03+1] "Fixed setService call." [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/584986 (owner: 10Umherirrender) [22:37:35] (03PS1) 10Umherirrender: Parse messages in string context [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/598207 [22:37:55] (03CR) 10Krinkle: [C: 03+2] Avoid use of $wgLang and $wgRequest (031 comment) [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/584228 (owner: 10Umherirrender) [22:38:58] (03CR) 10Art-Baltai: New unit and integraton tests for class LinkHolderArray (032 comments) [core] - 10https://gerrit.wikimedia.org/r/588834 (https://phabricator.wikimedia.org/T243747) (owner: 10Art-Baltai) [22:40:24] (03CR) 10Krinkle: [C: 03+2] Avoid use of $wgLang and $wgRequest (031 comment) [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/584228 (owner: 10Umherirrender) [22:41:04] (03CR) 10jerkins-bot: [V: 04-1] Avoid use of $wgLang and $wgRequest [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/584228 (owner: 10Umherirrender) [22:42:51] (03PS10) 10Art-Baltai: New unit and integraton tests for class LinkHolderArray [core] - 10https://gerrit.wikimedia.org/r/588834 (https://phabricator.wikimedia.org/T243747) [22:43:52] (03PS16) 10DannyS712: SkinTemplate: increase test coverage to 55.84% [core] - 10https://gerrit.wikimedia.org/r/585628 (https://phabricator.wikimedia.org/T243756) (owner: 10Art-Baltai) [22:43:57] (03CR) 10DannyS712: [C: 03+2] SkinTemplate: increase test coverage to 55.84% [core] - 10https://gerrit.wikimedia.org/r/585628 (https://phabricator.wikimedia.org/T243756) (owner: 10Art-Baltai) [22:45:43] (03CR) 10Krinkle: Avoid use of $wgLang and $wgRequest (031 comment) [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/584228 (owner: 10Umherirrender) [22:47:48] (03PS6) 10Krinkle: Avoid use of $wgLang and $wgRequest [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/584228 (owner: 10Umherirrender) [22:47:58] (03PS1) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [22:48:27] (03PS1) 10Krinkle: https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Nostalgia/+/584228/ [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/598211 [22:48:47] (03PS2) 10Krinkle: https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Nostalgia/+/584228/ [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/598211 [22:50:21] (03CR) 10jerkins-bot: [V: 04-1] Avoid use of $wgLang and $wgRequest [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/584228 (owner: 10Umherirrender) [22:51:36] (03CR) 10jerkins-bot: [V: 04-1] https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Nostalgia/+/584228/ [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/598211 (owner: 10Krinkle) [22:51:54] (03CR) 10Umherirrender: "phan-seccheck failure looks unrelated to this change" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/598203 (owner: 10Umherirrender) [22:52:10] (03CR) 10Umherirrender: "phan-seccheck failure looks unrelated to this change" [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/598204 (owner: 10Umherirrender) [22:52:58] (03CR) 10Umherirrender: "phan-seccheck failure looks unrelated to this change" [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/584228 (owner: 10Umherirrender) [22:53:10] 10Social-Tools, 10I18n: [[MediaWiki:Sitescout-header-type/sv]] i18n issue: Is "Type" a verb or noun? - https://phabricator.wikimedia.org/T177341 (10Peachey88) [22:53:21] (03CR) 10Krinkle: SkinTemplate: increase test coverage to 55.84% (031 comment) [core] - 10https://gerrit.wikimedia.org/r/585628 (https://phabricator.wikimedia.org/T243756) (owner: 10Art-Baltai) [22:55:35] (03PS1) 10Pppery: Fix links to pages on Wikimedia commons when used on other wikis [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/598212 (https://phabricator.wikimedia.org/T250593) [22:56:17] 10WikimediaMessages, 10I18n, 10Patch-For-Review: MediaWiki:Wm-license-gfdl-full-1.2-link (link fix) MediaWiki:Wm-license-gfdl-1.2-and-later (corresponding code) - https://phabricator.wikimedia.org/T250593 (10Pppery) a:03Pppery [23:00:31] (03CR) 10jerkins-bot: [V: 04-1] SkinTemplate: increase test coverage to 55.84% [core] - 10https://gerrit.wikimedia.org/r/585628 (https://phabricator.wikimedia.org/T243756) (owner: 10Art-Baltai) [23:04:35] (03PS3) 10Krinkle: Fix phan-seccheck warnings [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/598211 [23:06:16] (03PS2) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [23:06:44] (03PS4) 10Krinkle: Fix phan-seccheck warnings [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/598211 [23:07:29] (03PS7) 10Krinkle: Avoid use of $wgLang and $wgRequest [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/584228 (owner: 10Umherirrender) [23:08:16] (03PS1) 10Jack Phoenix: [SECURITY] Fix various classic CSRF points in the special pages and API module + improve no-JS usability as well [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/598213 (https://phabricator.wikimedia.org/T248583) [23:09:10] (03CR) 10jerkins-bot: [V: 04-1] [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 (owner: 10DannyS712) [23:10:56] (03PS3) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [23:18:59] (03PS10) 10Ori.livneh: mime: represent lists as arrays instead of space-delimited strings [core] - 10https://gerrit.wikimedia.org/r/598075 (https://phabricator.wikimedia.org/T252228) [23:19:21] (03CR) 10Krinkle: [C: 03+1] Avoid use of $wgLang and $wgRequest [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/584228 (owner: 10Umherirrender) [23:21:53] (03CR) 10Ori.livneh: mime: represent lists as arrays instead of space-delimited strings (033 comments) [core] - 10https://gerrit.wikimedia.org/r/598075 (https://phabricator.wikimedia.org/T252228) (owner: 10Ori.livneh) [23:22:55] (03PS11) 10Ori.livneh: mime: represent lists as arrays instead of space-delimited strings [core] - 10https://gerrit.wikimedia.org/r/598075 (https://phabricator.wikimedia.org/T252228) [23:25:43] (03CR) 10Krinkle: mime: represent lists as arrays instead of space-delimited strings (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598075 (https://phabricator.wikimedia.org/T252228) (owner: 10Ori.livneh) [23:26:13] (03CR) 10Krinkle: "LGTM, left one nit, will re-review/land tomorrow perhaps." [core] - 10https://gerrit.wikimedia.org/r/598075 (https://phabricator.wikimedia.org/T252228) (owner: 10Ori.livneh) [23:27:42] (03CR) 10jerkins-bot: [V: 04-1] [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 (owner: 10DannyS712) [23:29:13] (03PS4) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [23:29:20] (03CR) 10Krinkle: mime: represent lists as arrays instead of space-delimited strings (031 comment) [core] - 10https://gerrit.wikimedia.org/r/598075 (https://phabricator.wikimedia.org/T252228) (owner: 10Ori.livneh) [23:38:23] 10Utilities-mwdumper: ERROR 1062: Duplicate entry for key 'name_title' (mwDumper failed to insert data into mysql) - https://phabricator.wikimedia.org/T118241 (10awight) a:05awight→03None [23:42:39] (03PS5) 10DannyS712: [WIP] ChangeTagLookup [core] - 10https://gerrit.wikimedia.org/r/598210 [23:48:50] (03PS6) 10Shirayuki: site: Update @since tag from 1.20 to 1.21 for $wgSiteTypes [core] - 10https://gerrit.wikimedia.org/r/593882 [23:57:08] 10MediaWiki-Codesniffer: Forbid usage of array_push with a single element - https://phabricator.wikimedia.org/T242218 (10Krinkle) The `array_push` construct is very rare in our code, and to my knowledge there is no preference or behavioural preference for it from anyone. Perhaps they are a left-over from a time... [23:58:05] 10MediaWiki-Codesniffer: Forbid usage of array_push with a single element - https://phabricator.wikimedia.org/T242218 (10Krinkle) p:05Triage→03Low [23:58:14] 10MediaWiki-Codesniffer, 10User-DannyS712: Add a sniff for unneeded __construct functions - https://phabricator.wikimedia.org/T242402 (10Krinkle) p:05Triage→03Low