[00:03:03] (03Abandoned) 10DannyS712: [WIP] New section summary [core] - 10https://gerrit.wikimedia.org/r/595708 (owner: 10DannyS712) [00:03:03] (03PS1) 10DannyS712: [WIP] New section [core] - 10https://gerrit.wikimedia.org/r/596788 [00:03:09] (03CR) 10jerkins-bot: [V: 04-1] Toggler: Remove `div` check [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/596785 (owner: 10VolkerE) [00:03:16] 10MediaWiki-File-management, 10MediaWiki-extensions-GWToolset, 10Commons, 10Patch-For-Review: GWToolset can not determine the file extension from the file URL - https://phabricator.wikimedia.org/T252909 (10Reedy) 05Open→03Resolved a:03Reedy [00:03:19] 10Accessibility, 10MobileFrontend, 10Readers-Web-Backlog, 10Spike: [Bug] Mobile sections should announce their collapsed/expanded state to screen-readers. - https://phabricator.wikimedia.org/T218404 (10Volker_E) Instead of inventing another button, which has two possible disadvantages: - Cross-browser rend... [00:03:40] (03CR) 10Krinkle: [C: 03+1] Fix even more PSR12.Properties.ConstantVisibility.NotFound (032 comments) [core] - 10https://gerrit.wikimedia.org/r/596775 (owner: 10Reedy) [00:04:46] (03PS2) 10DannyS712: [WIP] New section [core] - 10https://gerrit.wikimedia.org/r/596788 [00:08:26] (03CR) 10jerkins-bot: [V: 04-1] WatchedItemStore: Enforce a maximum watchlist expiry duration [core] - 10https://gerrit.wikimedia.org/r/591203 (https://phabricator.wikimedia.org/T249672) (owner: 10MusikAnimal) [00:08:31] 10Research: Exploration on content propagation across Wikimedia projects. - https://phabricator.wikimedia.org/T252933 (10diego) [00:10:41] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), 10Verified: Support ConfirmEdit captchas in DiscussionTools - https://phabricator.wikimedia.org/T247513 (10Ryasmeen) [00:11:15] 10Research: Exploration on content propagation across Wikimedia projects. - https://phabricator.wikimedia.org/T252933 (10diego) Previous work: * Build a dataset of the creation time of all articles in Wikimedia projects, and their corresponding Wikidata Item. * Build a test subset Weekly Update: * Onboarding @... [00:12:16] (03PS3) 10DannyS712: [WIP] New section [core] - 10https://gerrit.wikimedia.org/r/596788 [00:12:50] 10InteractionTimeline, 10Anti-Harassment (The Letter Song): Migrate Interaction Timeline to toolforge.org - https://phabricator.wikimedia.org/T252418 (10dbarratt) [00:14:13] (03Merged) 10jenkins-bot: Fix even more PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596766 (owner: 10Reedy) [00:14:23] 10InteractionTimeline, 10Anti-Harassment (The Letter Song): Migrate Interaction Timeline to toolforge.org - https://phabricator.wikimedia.org/T252418 (10dbarratt) Here is a PR with all the changes: https://github.com/wikimedia/InteractionTimeline/pull/127 In addition to the PR, when the changes are deployed,... [00:14:41] (03Merged) 10jenkins-bot: Fix even more PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596774 (owner: 10Reedy) [00:15:42] 10DiscussionTools, 10Editing QA, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), 10OWC2020 (OWC2020 Replying 1.0): Server errors on a long page look like it's not posting, even though it did - https://phabricator.wikimedia.org/T249071 (10Ryasmeen) QA will not add... [00:15:55] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), 10OWC2020 (OWC2020 Replying 1.0): Server errors on a long page look like it's not posting, even though it did - https://phabricator.wikimedia.org/T249071 (10Ryasmeen) [00:17:17] (03PS4) 10DannyS712: [WIP] New section [core] - 10https://gerrit.wikimedia.org/r/596788 [00:18:40] (03PS1) 10Reedy: Fix languages/ PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596789 [00:20:55] (03PS5) 10DannyS712: [WIP] New section [core] - 10https://gerrit.wikimedia.org/r/596788 [00:23:17] (03PS6) 10DannyS712: [WIP] New section [core] - 10https://gerrit.wikimedia.org/r/596788 [00:23:52] (03CR) 10Krinkle: [C: 03+2] Fix even more PSR12.Properties.ConstantVisibility.NotFound (031 comment) [core] - 10https://gerrit.wikimedia.org/r/596775 (owner: 10Reedy) [00:26:13] (03PS7) 10DannyS712: [WIP] New section [core] - 10https://gerrit.wikimedia.org/r/596788 [00:27:35] (03PS1) 10Reedy: Fix tests/ PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596790 [00:27:37] (03CR) 10Krinkle: [C: 04-1] Fix even more PSR12.Properties.ConstantVisibility.NotFound (032 comments) [core] - 10https://gerrit.wikimedia.org/r/596780 (owner: 10Reedy) [00:28:53] (03PS5) 10Reedy: Fix even more PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596780 [00:34:14] 10MediaWiki-Page-editing, 10Technical-Debt, 10User-DannyS712: Reduce public variables and methods in EditPage - https://phabricator.wikimedia.org/T252907 (10DannyS712) [00:34:19] (03PS1) 10DannyS712: Make EditPage::$hookError private [core] - 10https://gerrit.wikimedia.org/r/596791 (https://phabricator.wikimedia.org/T252907) [00:34:40] (03PS1) 10Reedy: Fix inclides/Storage PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596792 [00:35:10] (03PS2) 10DannyS712: Make EditPage::$hookError private [core] - 10https://gerrit.wikimedia.org/r/596791 (https://phabricator.wikimedia.org/T252907) [00:35:30] 10MediaWiki-Page-editing, 10Core Platform Team Workboards (External Code Reviews), 10Patch-For-Review, 10Technical-Debt, 10User-DannyS712: Reduce public variables and methods in EditPage - https://phabricator.wikimedia.org/T252907 (10DannyS712) [00:36:03] (03CR) 10Krinkle: [C: 03+2] Fix even more PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596780 (owner: 10Reedy) [00:37:15] (03CR) 10jerkins-bot: [V: 04-1] Fix languages/ PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596789 (owner: 10Reedy) [00:37:49] (03CR) 10Krinkle: Fix languages/ PSR12.Properties.ConstantVisibility.NotFound (031 comment) [core] - 10https://gerrit.wikimedia.org/r/596789 (owner: 10Reedy) [00:38:44] (03CR) 10Reedy: Fix languages/ PSR12.Properties.ConstantVisibility.NotFound (031 comment) [core] - 10https://gerrit.wikimedia.org/r/596789 (owner: 10Reedy) [00:41:41] (03Merged) 10jenkins-bot: Fix even more PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596775 (owner: 10Reedy) [00:41:58] (03PS2) 10Reedy: Fix languages/ PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596789 [00:43:29] (03CR) 10jerkins-bot: [V: 04-1] Fix tests/ PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596790 (owner: 10Reedy) [00:43:48] (03CR) 10jerkins-bot: [V: 04-1] [WIP] New section [core] - 10https://gerrit.wikimedia.org/r/596788 (owner: 10DannyS712) [00:46:22] 10Anti-Harassment, 10Product-Analytics (Kanban): Come up with and track guardrail metrics for IP Masking - https://phabricator.wikimedia.org/T248241 (10Niharika) >>! In T248241#6141318, @Mandruss wrote: > Why is IP masking moving ahead after 95% community opposition? Hi @Mandruss. Thanks for your question. As... [00:48:14] (03PS3) 10Reedy: Fix languages/ PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596789 [00:51:20] (03PS2) 10Reedy: Fix tests/ PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596790 [00:51:23] (03PS6) 10Art-Baltai: Create LanguageConverterFactory and cover with tests [core] - 10https://gerrit.wikimedia.org/r/596530 (https://phabricator.wikimedia.org/T243323) [00:52:20] 10CPT Initiatives (Abstract Schema), 10Core Platform Team Workboards (Initiatives), 10Patch-For-Review: Add a test to check if generated sql files are the same as the abstract - https://phabricator.wikimedia.org/T252919 (10Reedy) [00:53:01] (03Merged) 10jenkins-bot: Fix even more PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596780 (owner: 10Reedy) [00:54:33] (03CR) 10Reedy: Add test to compare generated sql with the abstract schema (031 comment) [core] - 10https://gerrit.wikimedia.org/r/596783 (https://phabricator.wikimedia.org/T252919) (owner: 10Ladsgroup) [00:58:06] (03PS7) 10Reedy: Make import.php call delete.php as it has the same functionality [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/479901 [00:58:23] (03PS8) 10Reedy: Make import.php call delete.php as it has the same functionality [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/479901 [01:00:52] (03PS4) 10Reedy: Fix languages/ PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596789 [01:00:54] (03PS3) 10Reedy: Fix tests/ PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596790 [01:00:56] (03PS2) 10Reedy: Fix includes/Storage PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596792 [01:01:48] (03PS10) 10Reedy: PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596062 [01:06:07] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Fully terminate use of Wikidata item descriptions as short article descriptions for English Wikipedia articles - https://phabricator.wikimedia.org/T248457 (10Jonesey95) WMF staff, please hold up your end of our agreement by disabling the Wikidata fallback for... [01:08:39] (03CR) 10jerkins-bot: [V: 04-1] Fix tests/ PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596790 (owner: 10Reedy) [01:09:36] (03CR) 10jerkins-bot: [V: 04-1] Create LanguageConverterFactory and cover with tests [core] - 10https://gerrit.wikimedia.org/r/596530 (https://phabricator.wikimedia.org/T243323) (owner: 10Art-Baltai) [01:12:55] (03PS5) 10Reedy: Fix languages/ PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596789 [01:13:09] (03PS4) 10Reedy: Fix tests/ PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596790 [01:13:18] (03PS3) 10Reedy: Fix includes/Storage PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596792 [01:13:27] (03PS11) 10Reedy: PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596062 [01:15:58] (03CR) 10jerkins-bot: [V: 04-1] Fix tests/ PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596790 (owner: 10Reedy) [01:16:00] (03CR) 10jerkins-bot: [V: 04-1] Fix includes/Storage PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596792 (owner: 10Reedy) [01:29:08] 10MediaWiki-Language-converter, 10CPT Initiatives (Decoupling (CDP2)), 10Core Platform Team Workboards (Contractor Workboard), 10I18n: Refactor ConverterRule not to use public variables from LanguageConverter and remove mutual dependency between them - https://phabricator.wikimedia.org/T243910 (10Art-Baltai... [01:31:00] 10UI-Standardization: Capture all current Wikimedia deployed products building on top of OOUI - https://phabricator.wikimedia.org/T252274 (10Volker_E) [01:31:27] (03CR) 10jerkins-bot: [V: 04-1] PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596062 (owner: 10Reedy) [01:33:06] (03PS1) 10Reedy: Fix some includes/libs PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596793 [01:53:07] 10MediaWiki-General, 10MediaWiki-Interface, 10CPT Initiatives (Decoupling (CDP2)), 10Core Platform Team Workboards (External Code Reviews), 10Patch-For-Review: Decouple wgValidSkinNames from underlying class - https://phabricator.wikimedia.org/T252760 (10Krinkle) [01:57:35] (03PS6) 10Krinkle: skins: Allow $wgValidSkinNames to take ObjectFactory spec [core] - 10https://gerrit.wikimedia.org/r/596416 (https://phabricator.wikimedia.org/T252760) (owner: 10Reedy) [01:57:37] (03CR) 10Krinkle: [C: 03+2] skins: Allow $wgValidSkinNames to take ObjectFactory spec [core] - 10https://gerrit.wikimedia.org/r/596416 (https://phabricator.wikimedia.org/T252760) (owner: 10Reedy) [02:00:40] (03PS8) 10DannyS712: Inject some services to special pages [core] - 10https://gerrit.wikimedia.org/r/576537 (https://phabricator.wikimedia.org/T232506) [02:01:17] (03CR) 10DannyS712: "> Uploaded patch set 8." [core] - 10https://gerrit.wikimedia.org/r/576537 (https://phabricator.wikimedia.org/T232506) (owner: 10DannyS712) [02:02:00] (03PS9) 10DannyS712: Inject some services to special pages [core] - 10https://gerrit.wikimedia.org/r/576537 (https://phabricator.wikimedia.org/T232506) [02:06:31] (03PS1) 10Reedy: Sync descriptions from extension.schema.v2.json to v1.json [core] - 10https://gerrit.wikimedia.org/r/596794 [02:07:28] (03CR) 10jerkins-bot: [V: 04-1] Inject some services to special pages [core] - 10https://gerrit.wikimedia.org/r/576537 (https://phabricator.wikimedia.org/T232506) (owner: 10DannyS712) [02:08:24] (03CR) 10Krinkle: Fix languages/ PSR12.Properties.ConstantVisibility.NotFound (031 comment) [core] - 10https://gerrit.wikimedia.org/r/596789 (owner: 10Reedy) [02:09:35] (03CR) 10Krinkle: [C: 03+1] Fix tests/ PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596790 (owner: 10Reedy) [02:10:15] (03CR) 10Krinkle: [C: 03+1] Fix includes/Storage PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596792 (owner: 10Reedy) [02:11:39] (03CR) 10Krinkle: [C: 03+2] Fix some includes/libs PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596793 (owner: 10Reedy) [02:12:11] (03CR) 10Reedy: "I'd agree, at minimum the RELEASE-NOTES do need updating" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/596789 (owner: 10Reedy) [02:14:07] (03CR) 10Krinkle: resourceloader: make SqlModuleDependencyStore use CONN_TRX_AUTO (031 comment) [core] - 10https://gerrit.wikimedia.org/r/596739 (https://phabricator.wikimedia.org/T247028) (owner: 10Aaron Schulz) [02:17:12] (03Merged) 10jenkins-bot: skins: Allow $wgValidSkinNames to take ObjectFactory spec [core] - 10https://gerrit.wikimedia.org/r/596416 (https://phabricator.wikimedia.org/T252760) (owner: 10Reedy) [02:17:31] 10MediaWiki-Page-rename, 10MediaWiki-extensions-CentralAuth, 10MediaWiki-extensions-Renameuser, 10MediaWiki-extensions-Translate, and 8 others: Hard deprecate manually constructing MovePage objects - https://phabricator.wikimedia.org/T252934 (10DannyS712) [02:18:03] (03PS1) 10DannyS712: SpecialRenameuser: Use MovePageFactory to construct MovePage [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/596795 (https://phabricator.wikimedia.org/T252934) [02:19:02] (03CR) 10Reedy: Init (032 comments) [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/588671 (https://phabricator.wikimedia.org/T247837) (owner: 10ItSpiderman) [02:19:59] (03PS2) 10DannyS712: SpecialRenameuser: Use MovePageFactory to construct MovePage [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/596795 (https://phabricator.wikimedia.org/T252934) [02:21:18] (03PS1) 10DannyS712: ApiPageTriageListTest: Use MovePageFactory to construct MovePage [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/596796 (https://phabricator.wikimedia.org/T252934) [02:22:03] 10UI-Standardization: Capture all current Wikimedia deployed products building on top of OOUI - https://phabricator.wikimedia.org/T252274 (10Krinkle) > * BlueSpiceVisualEditorConnector This isn't a WMF-deployed extension (afaik). [02:22:17] (03PS2) 10DannyS712: ApiPageTriageListTest: Use MovePageFactory to construct MovePage [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/596796 (https://phabricator.wikimedia.org/T252934) [02:22:57] 10UI-Standardization: Capture all current Wikimedia deployed products building on top of OOUI - https://phabricator.wikimedia.org/T252274 (10Krinkle) [02:23:00] (03CR) 10Reedy: Init (032 comments) [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/588671 (https://phabricator.wikimedia.org/T247837) (owner: 10ItSpiderman) [02:27:06] (03PS10) 10DannyS712: Inject some services to special pages [core] - 10https://gerrit.wikimedia.org/r/576537 (https://phabricator.wikimedia.org/T232506) [02:27:51] (03CR) 10Reedy: "I created https://gerrit.wikimedia.org/r/596797 to enable CI... But that's not really going to help much as it can't inject Chameleon as a" [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/588671 (https://phabricator.wikimedia.org/T247837) (owner: 10ItSpiderman) [02:29:17] (03CR) 10Krinkle: [C: 03+2] Sync descriptions from extension.schema.v2.json to v1.json [core] - 10https://gerrit.wikimedia.org/r/596794 (owner: 10Reedy) [02:30:32] (03Merged) 10jenkins-bot: Fix some includes/libs PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596793 (owner: 10Reedy) [02:32:47] (03Restored) 10Gituser: 70c80049b74ca4bc536961506e9f090fdb5f0b2b [extensions/examples] - 10https://gerrit.wikimedia.org/r/596689 (owner: 10Gituser) [02:35:45] (03Abandoned) 10Gituser: 70c80049b74ca4bc536961506e9f090fdb5f0b2b [extensions/examples] - 10https://gerrit.wikimedia.org/r/596689 (owner: 10Gituser) [02:36:07] (03PS1) 10Art-Baltai: ConverterRule and LanguageConverter properties: make private or protected [core] - 10https://gerrit.wikimedia.org/r/596798 (https://phabricator.wikimedia.org/T243910) [02:44:24] (03Merged) 10jenkins-bot: Sync descriptions from extension.schema.v2.json to v1.json [core] - 10https://gerrit.wikimedia.org/r/596794 (owner: 10Reedy) [02:53:38] (03CR) 10jerkins-bot: [V: 04-1] ConverterRule and LanguageConverter properties: make private or protected [core] - 10https://gerrit.wikimedia.org/r/596798 (https://phabricator.wikimedia.org/T243910) (owner: 10Art-Baltai) [03:19:30] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10Upstream: Add sniff to ensure use of spaces (not tabs) between variable and assignment operator - https://phabricator.wikimedia.org/T232265 (10Krinkle) [03:30:21] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10Upstream: Add sniff to ensure use of spaces (not tabs) between variable and assignment operator - https://phabricator.wikimedia.org/T232265 (10Krinkle) @thiemowmde For sniffs that merekly help enforce pre-established/documented coding conventions I think accepti... [03:30:26] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10Upstream: Add sniff to ensure use of spaces (not tabs) between variable and assignment operator - https://phabricator.wikimedia.org/T232265 (10Krinkle) p:05Triage→03Medium [03:30:53] (03PS5) 10Reedy: Fix tests/ PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596790 [03:30:55] (03PS4) 10Reedy: Fix includes/Storage PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596792 [03:31:24] (03CR) 10Reedy: "Removed the languages/ patch as a parent" [core] - 10https://gerrit.wikimedia.org/r/596790 (owner: 10Reedy) [03:35:58] (03CR) 10Krinkle: [C: 03+2] Fix tests/ PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596790 (owner: 10Reedy) [03:36:08] (03CR) 10Krinkle: [C: 03+2] Fix includes/Storage PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596792 (owner: 10Reedy) [03:36:55] 10Thumbor, 10Wikimedia-SVG-rendering, 10Upstream: Several PNG thumbnail sizes of a specific SVG image do not display correctly - https://phabricator.wikimedia.org/T214738 (10AntiCompositeNumber) Looks like librsvg may have regressed on this issue since 2.44.13, as conversion fails for all thumbnails where th... [03:53:02] (03Merged) 10jenkins-bot: Fix tests/ PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596790 (owner: 10Reedy) [03:53:06] 10MediaWiki-File-management, 10Commons, 10Operations, 10Thumbor, 10Traffic: Thumbnail rendering of complex SVG file leads to Error 500 or Error 429 instead of Error 408 - https://phabricator.wikimedia.org/T226318 (10AntiCompositeNumber) [03:53:09] 10Thumbor, 10Wikimedia-SVG-rendering, 10Upstream: rsvg-convert times out while generating large thumbnails with heavy use of Gaussian blur - https://phabricator.wikimedia.org/T200866 (10AntiCompositeNumber) [03:53:14] 10MediaWiki-File-management, 10Commons, 10Operations, 10Thumbor, 10Traffic: Thumbnail rendering of complex SVG file leads to Error 500 or Error 429 instead of Error 408 - https://phabricator.wikimedia.org/T226318 (10AntiCompositeNumber) rsvg-convert 2.40.16 did not process this file in >5 minutes, 2.48.4... [03:54:40] (03Merged) 10jenkins-bot: Fix includes/Storage PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596792 (owner: 10Reedy) [04:03:52] 10MediaWiki-File-management, 10Commons, 10Operations, 10Thumbor, 10Traffic: Thumbnail rendering of complex SVG file leads to Error 500 or Error 429 instead of Error 408 - https://phabricator.wikimedia.org/T226318 (10AntiCompositeNumber) rsvg-convert 2.40.16 processed this file at 1000px in 75 seconds, wh... [04:05:31] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Inline images within an article are not visible in "Brazil" article; images are full screen instead - https://phabricator.wikimedia.org/T249105 (10SGautam_WMF) Alright then moving it for product signoff. [04:18:09] 10MediaWiki-Special-pages: Given the option to rollback 0 edits in Special:Contributions - https://phabricator.wikimedia.org/T89780 (10Naleksuh) Hello. I also encountered this bug while having to rollback around 50 edits. it said [rollback 0 edits] when it should be [rollback 1 edit]. Like the creator of this bu... [04:24:24] (03PS1) 10DannyS712: Linker: If edit count for rollback is 0, assume race condition and use 1 [core] - 10https://gerrit.wikimedia.org/r/596799 (https://phabricator.wikimedia.org/T89780) [04:25:24] (03PS2) 10DannyS712: Linker: If edit count for rollback is 0, assume race condition and use 1 [core] - 10https://gerrit.wikimedia.org/r/596799 (https://phabricator.wikimedia.org/T89780) [04:25:36] 10MediaWiki-Special-pages, 10Patch-For-Review, 10User-DannyS712: Given the option to rollback 0 edits in Special:Contributions - https://phabricator.wikimedia.org/T89780 (10DannyS712) [04:38:09] (03Restored) 10Gituser: 70c80049b74ca4bc536961506e9f090fdb5f0b2b [extensions/examples] - 10https://gerrit.wikimedia.org/r/596689 (owner: 10Gituser) [04:38:53] 10Design, 10ContentTranslation, 10Language-Team (Language-2020-January-March): CX2: Don't apply unmodified content restrictions to translations published to the user namespace - https://phabricator.wikimedia.org/T215403 (10YTRK) a:05HaussmannSaintLazare→03None [04:45:29] (03PS6) 10DannyS712: [WIP] ChangeTagStore [core] - 10https://gerrit.wikimedia.org/r/595485 [04:46:12] (03PS7) 10DannyS712: [WIP] ChangeTagStore [core] - 10https://gerrit.wikimedia.org/r/595485 [04:54:29] (03PS1) 10VolkerE: Toggler: Remove wrong ARIA attributes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/596800 (https://phabricator.wikimedia.org/T218404) [04:55:14] (03CR) 10BPirkle: "Generally looks good, once CI passes." [core] - 10https://gerrit.wikimedia.org/r/596539 (https://phabricator.wikimedia.org/T245170) (owner: 10Tim Starling) [04:59:09] 10Design, 10ContentTranslation, 10Language-Team (Language-2020-January-March): CX2: Don't apply unmodified content restrictions to translations published to the user namespace - https://phabricator.wikimedia.org/T215403 (10YTRK) I acknowledge that some tasks are better done outside the content translation to... [04:59:11] 10CPT Initiatives (Decoupling (CDP2)): Factor notification-related methods out of User and Title, introduce WatchlistNotificationManager - https://phabricator.wikimedia.org/T208777 (10DannyS712) >>! In T208777#6004612, @daniel wrote: > Merge with {T239640}? Given that T239640 has been merged and the new service... [05:11:50] (03CR) 10jerkins-bot: [V: 04-1] Toggler: Remove wrong ARIA attributes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/596800 (https://phabricator.wikimedia.org/T218404) (owner: 10VolkerE) [05:17:26] (03PS51) 10DannyS712: [WIP] DatabaseBlockStore [core] - 10https://gerrit.wikimedia.org/r/595086 [05:27:39] 10KaiOS-Wikipedia-app, 10I18n, 10Inuka-Team (Kanban): Allow app language to always match device language - https://phabricator.wikimedia.org/T249710 (10Jpita) >>! In T249710#6138166, @AMuigai wrote: > I chose Kashmiri, and it didn't work; the app worked with Urdu. Filing two bugs. oh, you want to create new... [06:02:23] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Images start appearing in the background of text. - https://phabricator.wikimedia.org/T247260 (10Jpita) {F31821016} @SBisson this issue still occurs, do you want me to create a separate ticket? 1- go to http://localhost:8080/#/article/en/Fish/Reproductive_system 2-... [06:14:48] 10CX-boost, 10Language-Team (Language-2020-Focus-Sprint): Generate template parameter alignments for the selected small wikis II - https://phabricator.wikimedia.org/T246317 (10KartikMistry) Some blockers: * Wikidata connection is timing out, will keep trying this, as it is important for last step (getting Tem... [06:19:49] (03PS1) 10VolkerE: Toggler: Re-introduce ARIA attributes and add button role on collapsible headings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/596801 (https://phabricator.wikimedia.org/T218404) [06:23:08] 10Accessibility, 10MobileFrontend, 10Readers-Web-Backlog, 10Patch-For-Review, 10Spike: [Bug] Mobile sections should announce their collapsed/expanded state to screen-readers. - https://phabricator.wikimedia.org/T218404 (10Volker_E) On the small change of keyboard focus outline: Without historical context... [06:23:23] 10MediaWiki-Maintenance-system, 10Growth-Team, 10Wikidata, 10Core Platform Team Workboards (Clinic Duty Team), and 3 others: DatabaseUpdater: protect methods for direct database modification - https://phabricator.wikimedia.org/T249603 (10RhinosF1) [06:32:54] (03PS2) 10VolkerE: Toggler: Remove `div` check [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/596785 [06:34:11] (03CR) 10jerkins-bot: [V: 04-1] Toggler: Re-introduce ARIA attributes and add button role on collapsible headings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/596801 (https://phabricator.wikimedia.org/T218404) (owner: 10VolkerE) [06:39:26] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Test KaiOS Wikipedia app on slow connection - https://phabricator.wikimedia.org/T252545 (10Jpita) QA NOTES: use [[ https://www.charlesproxy.com/documentation/installation/ | Charles ]] proxy to test this on the device. [06:40:33] 10Inuka-Team (Kanban), 10KaiOS-Wikipedia-app (MVP): Prompt users for consent to enable app instrumentation - https://phabricator.wikimedia.org/T250218 (10Jpita) >>! In T250218#6136766, @SBisson wrote: >>>! In T250218#6136001, @Jpita wrote: >> how can I check if the NO option is actually not sending any data? >... [08:02:50] (03PS52) 10DannyS712: [WIP] DatabaseBlockStore [core] - 10https://gerrit.wikimedia.org/r/595086 [08:06:25] (03CR) 10DannyS712: Init (033 comments) [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/588671 (https://phabricator.wikimedia.org/T247837) (owner: 10ItSpiderman) [08:10:08] (03CR) 10DannyS712: [C: 04-1] Rename ILanguageInterface::convert function to eliminate ambiguity (033 comments) [core] - 10https://gerrit.wikimedia.org/r/595341 (https://phabricator.wikimedia.org/T243326) (owner: 10Art-Baltai) [08:14:01] (03CR) 10DannyS712: [C: 03+1] "LGTM" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/596725 (owner: 10Jforrester) [08:26:19] 10NewcomerTasks 1.2, 10Growth-Team (Current Sprint), 10Patch-For-Review: Newcomer tasks: animate transitions between panels - https://phabricator.wikimedia.org/T247999 (10Catrope) Video demo: {F31821269} [08:32:13] (03PS8) 10DannyS712: [WIP] ChangeTags [core] - 10https://gerrit.wikimedia.org/r/595485 [08:37:45] (03PS7) 10DannyS712: RollbackAction: Reduce uses of Revision objects [core] - 10https://gerrit.wikimedia.org/r/592318 (https://phabricator.wikimedia.org/T250579) [08:38:45] (03PS20) 10DannyS712: ImportableOldRevisionImporter: Remove use of Revision::insertOn [core] - 10https://gerrit.wikimedia.org/r/594416 (https://phabricator.wikimedia.org/T251856) [08:39:23] (03PS5) 10DannyS712: Remove use of Revision objects in SpecialNewpages::feedItemDesc [core] - 10https://gerrit.wikimedia.org/r/594253 (https://phabricator.wikimedia.org/T250579) [08:42:11] (03PS15) 10DannyS712: Remove DifferenceEngine::$mNewRev and $mOldRev [core] - 10https://gerrit.wikimedia.org/r/593272 (https://phabricator.wikimedia.org/T250761) [08:42:27] (03CR) 10DannyS712: "> Tagging @Jack who's listed as an author in the file for visibility." [extensions/SpamDiffTool] - 10https://gerrit.wikimedia.org/r/593662 (https://phabricator.wikimedia.org/T250761) (owner: 10DannyS712) [08:42:49] (03CR) 10DannyS712: "> @Danny: Thanks for the patch! I'll try to do an in-depth review in" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/593663 (https://phabricator.wikimedia.org/T250761) (owner: 10DannyS712) [08:42:52] (03PS3) 10DannyS712: Remove use of DifferenceEngine::$mNewRev and $mOldRev [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/593663 (https://phabricator.wikimedia.org/T250761) [08:42:57] (03CR) 10jerkins-bot: [V: 04-1] Remove DifferenceEngine::$mNewRev and $mOldRev [core] - 10https://gerrit.wikimedia.org/r/593272 (https://phabricator.wikimedia.org/T250761) (owner: 10DannyS712) [08:43:37] (03CR) 10DannyS712: "recheck" [core] - 10https://gerrit.wikimedia.org/r/593272 (https://phabricator.wikimedia.org/T250761) (owner: 10DannyS712) [08:57:34] 10MediaWiki-Interface, 10MediaWiki-Parser: Double escaped entities in {{FULLPAGENAME}} on customized Delete-legend message again - https://phabricator.wikimedia.org/T251962 (10Kghbln) > And before you ask, yes, this is stupid. Good that we all agree on this. :) To my observation this must be a MediaWiki 1.3... [09:01:34] 10MediaWiki-Interface, 10MediaWiki-Parser: Double escaped entities in {{FULLPAGENAME}} on customized Delete-legend message again - https://phabricator.wikimedia.org/T251962 (10Kghbln) Ah, this is about `{{FULLPAGENAMEE}}`. Well the behaviour of `{{PAGENAME}}` also changed. [09:02:19] 10MediaWiki-Page-deletion, 10MediaWiki-Special-pages, 10Core Platform Team: Add "Delete associated talk page" option to action=delete - https://phabricator.wikimedia.org/T27471 (10Ammarpad) p:05Low→03Medium a:03Ammarpad [09:31:02] (03PS4) 10Nik Gkountas: MT Abuse warnings: Enforce minimum length consideration for sections with both excluded and non excluded children [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/596635 (https://phabricator.wikimedia.org/T232718) [10:06:12] 10MediaWiki-Blocks, 10Anti-Harassment (The Letter Song), 10MW-1.35-notes (1.35.0-wmf.34; 2020-05-26), 10Patch-For-Review, 10User-DannyS712: Prohibit empty blocks - https://phabricator.wikimedia.org/T208645 (10Amorymeltzer) Isn't the issue with that that the partial block API accepts invalid pages? I thi... [10:47:13] (03PS9) 10DannyS712: [WIP] ChangeTags [core] - 10https://gerrit.wikimedia.org/r/595485 [10:58:35] 10MediaWiki-Special-pages, 10Performance Issue, 10User-DannyS712, 10Wikimedia-production-error: Unable to access SpecialNewpages on enwiki: WMFTimeoutException - https://phabricator.wikimedia.org/T231711 (10DannyS712) This is still an issue (completely forgot about this and just had the same problem with t... [11:06:01] 10MediaWiki-Special-pages, 10Performance Issue, 10User-DannyS712, 10Wikimedia-production-error: Unable to access SpecialNewpages on enwiki: WMFTimeoutException - https://phabricator.wikimedia.org/T231711 (10RhinosF1) >>! In T231711#6142228, @DannyS712 wrote: > This is still an issue (completely forgot abou... [11:08:31] 10MediaWiki-Special-pages, 10Performance Issue, 10User-DannyS712, 10Wikimedia-production-error: Unable to access SpecialNewpages on enwiki: WMFTimeoutException - https://phabricator.wikimedia.org/T231711 (10RhinosF1) To note, the time I got comes from [wgBackendResponseTime](https://meta.wikimedia.org/wiki... [11:21:34] 10MediaWiki-Language-converter, 10CPT Initiatives (Decoupling (CDP2)), 10Core Platform Team Workboards (Contractor Workboard), 10I18n, 10Patch-For-Review: Refactor ConverterRule not to use public variables from LanguageConverter and remove mutual dependency betwe... - https://phabricator.wikimedia.org/T243910 [11:24:14] 10MediaWiki-API, 10Core Platform Team, 10Wikidata: Wikidata API deadlock since 0:49 UTC - https://phabricator.wikimedia.org/T252939 (10Dvorapa) [11:25:18] 10MediaWiki-API, 10Core Platform Team, 10Wikidata: Wikidata API deadlock since 0:49 UTC - https://phabricator.wikimedia.org/T252939 (10Dvorapa) 05Open→03Invalid My bad [11:25:41] 04(no projects): Error - https://phabricator.wikimedia.org/T252939 (10Dvorapa) [11:27:10] 10Wikimedia-Extension-setup, 10Bengali-Sites: Deploy FlaggedRevs on bn.wikibooks - https://phabricator.wikimedia.org/T205145 (10Shahadat) p:05Triage→03High It has already been 2 years since I applied. Bengali wikibooks community would be grateful if you could complete this please. [11:28:32] 10Wikimedia-Extension-setup, 10Bengali-Sites: Deploy FlaggedRevs on bn.wikibooks - https://phabricator.wikimedia.org/T205145 (10RhinosF1) p:05High→03Triage Priority reflects reality not wishes. FlaggedRevs is not been installed on new wikis. >>! In T205145#4609122, @Urbanecm wrote: > IIRC FlaggedRevs woul... [11:43:12] 10MediaWiki-Codesniffer, 10Technical-Debt: Warn when a method/class has a @deprecated annotation but no call to wfDeprecated - https://phabricator.wikimedia.org/T205938 (10thiemowmde) Personally, I think it's fine to have `@deprecated` without `wfDeprecated()`. I think this is still useful. Sure, it's a very "... [11:46:34] 10IA Upload: IA-Upload script cannot find djvm to merge files converted from JP2 back into a single DJVU. - https://phabricator.wikimedia.org/T215647 (10Xover) Provided the "too many arguments" theory is correct, there are two obvious ways to work around it: # Change working directory (i.e. [[ https://www.ph... [12:06:11] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Add sniff to disallow specific tags with no text after them - https://phabricator.wikimedia.org/T252914 (10thiemowmde) Sure. I reviewed the list we currently have in the FunctionAnnotationsSniff, and would suggest the following: Strict errors: *... [13:01:20] (03CR) 10Daimona Eaytoy: "Looks good, aside from Reedy's comment." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/596783 (https://phabricator.wikimedia.org/T252919) (owner: 10Ladsgroup) [13:25:04] 10Wikimedia-Hackathon-2020: Wikidata: revert the erasure of P91 (sexual orientation) AND add a source (newcomer friendly) - https://phabricator.wikimedia.org/T251720 (10Nattes) Set up project pages to continue during month of pride. LGBT user group notified. Francophone wikipedia : done [13:40:13] 10WMEE, 10Vabatahtlikule: Tõenduspõhine Arvamusfestival 2020 - https://phabricator.wikimedia.org/T252943 (10tramm) [13:41:34] 10UploadWizard: Upload Wizard does not allow to publish upload - https://phabricator.wikimedia.org/T252235 (10Cheva) Hi @Aklapper, the same thing has just happened again, with just 10 photos on Chrome. Could you help, please? [13:59:05] 10Wiki-Loves-Monuments-Sources: Add Brandenburg in German to the monuments database - https://phabricator.wikimedia.org/T55269 (10Multichill) [14:03:02] (03CR) 10Reedy: Add test to compare generated sql with the abstract schema (031 comment) [core] - 10https://gerrit.wikimedia.org/r/596783 (https://phabricator.wikimedia.org/T252919) (owner: 10Ladsgroup) [14:05:16] 10MediaWiki-Watchlist, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), and 4 others: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10IKhitron) >>! In T21851... [14:07:15] 10Wiki-Loves-Monuments-Sources: Add Brandenburg in German to the monuments database - https://phabricator.wikimedia.org/T55269 (10Multichill) p:05Lowest→03Medium [14:11:13] 10Wiki-Loves-Monuments-Sources: Import Korea in Korean into monuments database - https://phabricator.wikimedia.org/T177241 (10Multichill) 05Open→03Invalid I'm just going to close this one as invalid because of lack of information and nothing happening for several years. Feel free to add more information and... [14:19:30] 10Wiki-Loves-Monuments-Sources, 10Documentation: Update instructions for adding a new source - https://phabricator.wikimedia.org/T147751 (10Multichill) @Lokal_Profil @JeanFred any news on this? Haven't done this in a while and the documentation at https://commons.wikimedia.org/wiki/Commons:Monuments_database/H... [14:24:35] (03PS4) 10Esanders: WIP Add tests for CommentModifier::removeListItem [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/596531 [14:24:37] (03PS3) 10Esanders: WIP Parser.php: Add tests for getTranscludedFrom [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/596532 [14:34:15] (03PS1) 10Daimona Eaytoy: Annotate Title::getPrefixedDBKey/getPrefixedText as unsafe [core] - 10https://gerrit.wikimedia.org/r/596807 [14:35:17] (03PS5) 10Esanders: Rename removeListItem to removeAddedListItem and remove in PHP [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/596531 [14:35:19] (03PS4) 10Esanders: WIP Parser.php: Add tests for getTranscludedFrom [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/596532 [14:38:51] (03CR) 10jerkins-bot: [V: 04-1] WIP Parser.php: Add tests for getTranscludedFrom [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/596532 (owner: 10Esanders) [14:56:11] (03PS6) 10Reedy: Fix languages/ PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596789 [14:56:13] (03PS12) 10Reedy: PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596062 [14:57:12] (03CR) 10Reedy: "Do we want to update RELEASE-NOTES to remove the deprecation point? Or just leave them and mark them public to be removed in the next vers" [core] - 10https://gerrit.wikimedia.org/r/596789 (owner: 10Reedy) [15:12:36] (03CR) 10jerkins-bot: [V: 04-1] PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596062 (owner: 10Reedy) [15:17:55] (03PS1) 10Reedy: Cleanup CSSMin [core] - 10https://gerrit.wikimedia.org/r/596808 [15:17:57] (03PS1) 10Reedy: Fix more libs PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596809 [15:32:49] (03PS1) 10Daimona Eaytoy: Performance: Use a different algorithm for props dependencies [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/596810 (https://phabricator.wikimedia.org/T203651) [15:33:26] (03CR) 10jerkins-bot: [V: 04-1] Performance: Use a different algorithm for props dependencies [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/596810 (https://phabricator.wikimedia.org/T203651) (owner: 10Daimona Eaytoy) [15:34:35] (03CR) 10jerkins-bot: [V: 04-1] Fix more libs PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596809 (owner: 10Reedy) [15:43:44] (03PS5) 10Esanders: Parser.php: Add tests for getTranscludedFrom [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/596532 [15:46:44] (03PS1) 10Esanders: PHP: More missing typehints [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/596811 [15:50:14] 10Desktop Improvements, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Spike, 10Vue.js (Vue.js-Search): [Spike] How should i18n work for Vue.js search? - https://phabricator.wikimedia.org/T249308 (10Niedzielski) [15:53:48] (03CR) 10Esanders: "We do, but the API results are stored in a local cache, so you see your old API results without this patch ('' = show me everyone)." [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/595608 (owner: 10Esanders) [15:55:07] (03PS2) 10Reedy: Fix more libs PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596809 [15:55:09] (03PS1) 10Reedy: Fix more libs PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596812 [15:55:43] (03Abandoned) 10Reedy: PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596062 (owner: 10Reedy) [15:56:45] 10MediaWiki-Maintenance-system: updateSearchIndex.php sql error not all tables locked - https://phabricator.wikimedia.org/T252853 (10Aklapper) 05Stalled→03Open [16:01:06] (03PS2) 10Daimona Eaytoy: Performance: Use a different algorithm for props dependencies [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/596810 (https://phabricator.wikimedia.org/T203651) [16:01:15] (03PS2) 10Reedy: Fix more libs PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596812 [16:02:09] (03CR) 10jerkins-bot: [V: 04-1] Performance: Use a different algorithm for props dependencies [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/596810 (https://phabricator.wikimedia.org/T203651) (owner: 10Daimona Eaytoy) [16:11:58] 10MediaWiki-File-management, 10MediaWiki-extensions-PagedTiffHandler, 10Commons, 10SRE-swift-storage, 10Thumbor: Specific Thumbnail generation for a broken invalid TIF file not working anymore - https://phabricator.wikimedia.org/T133175 (10Aklapper) [16:13:27] (03CR) 10jerkins-bot: [V: 04-1] Fix more libs PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596812 (owner: 10Reedy) [16:16:50] 10Wiki-Loves-Monuments-Sources, 10Documentation: Update instructions for adding a new source - https://phabricator.wikimedia.org/T147751 (10JeanFred) I updated a bit https://commons.wikimedia.org/wiki/Commons:Monuments_database/Harvesting − it’s not the best docs but looks fairly up to date. The one really mis... [16:30:06] (03PS6) 10Ori.livneh: mime: Convert built-in MIME mappings to PHP arrays [core] - 10https://gerrit.wikimedia.org/r/596698 (https://phabricator.wikimedia.org/T252228) [16:31:58] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.34; 2020-05-26): Port parser.js to PHP - https://phabricator.wikimedia.org/T252252 (10Esanders) Nothing really to review here outside of engineering [16:32:14] (03PS7) 10Ori.livneh: mime: Convert built-in MIME mappings to PHP arrays [core] - 10https://gerrit.wikimedia.org/r/596698 (https://phabricator.wikimedia.org/T252228) [16:32:26] (03PS1) 10Esanders: WIP Add reply links on the server [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/596813 (https://phabricator.wikimedia.org/T252555) [16:33:09] (03CR) 10Ori.livneh: mime: Convert built-in MIME mappings to PHP arrays (033 comments) [core] - 10https://gerrit.wikimedia.org/r/596698 (https://phabricator.wikimedia.org/T252228) (owner: 10Ori.livneh) [16:33:35] (03CR) 10Reedy: "If we capitalise the Mime folder, the manual autoload.php entries shouldn't be needed..." [core] - 10https://gerrit.wikimedia.org/r/596698 (https://phabricator.wikimedia.org/T252228) (owner: 10Ori.livneh) [16:35:45] (03CR) 10jerkins-bot: [V: 04-1] WIP Add reply links on the server [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/596813 (https://phabricator.wikimedia.org/T252555) (owner: 10Esanders) [16:40:59] (03CR) 10Ori.livneh: mime: Convert built-in MIME mappings to PHP arrays (031 comment) [core] - 10https://gerrit.wikimedia.org/r/596698 (https://phabricator.wikimedia.org/T252228) (owner: 10Ori.livneh) [16:46:45] (03PS1) 10Jack Phoenix: Rename BoardBlast error message keys to indicate they won't be JS-only in the near future [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/596814 (https://phabricator.wikimedia.org/T248390) [16:53:03] (03CR) 10Jack Phoenix: [C: 03+2] Rename BoardBlast error message keys to indicate they won't be JS-only in the near future [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/596814 (https://phabricator.wikimedia.org/T248390) (owner: 10Jack Phoenix) [16:55:37] (03Merged) 10jenkins-bot: Rename BoardBlast error message keys to indicate they won't be JS-only in the near future [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/596814 (https://phabricator.wikimedia.org/T248390) (owner: 10Jack Phoenix) [16:57:03] 10MediaWiki-Codesniffer, 10Wikidata: Consider adding bash scripts to mediawiki-codesniffer for only running on touched files - https://phabricator.wikimedia.org/T251533 (10Umherirrender) There is a bootstrap for use of CI/jenkins, but such a way has limitation, see T247209 [17:03:32] (03PS2) 10Esanders: WIP Add reply links on the server [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/596813 (https://phabricator.wikimedia.org/T252555) [17:04:34] 10MediaWiki-Core-Testing: wfDeprecated default behaviour in tests is different from production - https://phabricator.wikimedia.org/T251449 (10Umherirrender) There is a `MediaWikiTestCaseTrait::hideDeprecated` in the test enviroment. From the comment of the function you have to call that to avoid exception in te... [17:06:20] (03CR) 10jerkins-bot: [V: 04-1] WIP Add reply links on the server [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/596813 (https://phabricator.wikimedia.org/T252555) (owner: 10Esanders) [17:18:41] 10Wikimedia-Extension-setup, 10Bengali-Sites: Deploy FlaggedRevs on bn.wikibooks - https://phabricator.wikimedia.org/T205145 (10Aklapper) @Shahadat: [Report status and priority fields summarize and reflect reality and do not cause it.](https://www.mediawiki.org/wiki/Bug_management/Phabricator_etiquette). Pleas... [17:23:56] 10Wikimedia-Site-requests, 10Chinese-Sites: Enable Flagged Revisions (for trial run purpose) at the Chinese Wikipedia - https://phabricator.wikimedia.org/T221933 (10Aklapper) a:05RazeSoldier→03None Not sure why this unactionable task is assigned, hence removing assignee. [17:25:29] 10MediaWiki-Core-Testing: wfDeprecated default behaviour in tests is different from production - https://phabricator.wikimedia.org/T251449 (10Peter.ovchyn) You’re right, but using it I can’t verify that wfDeprecated was called . That’s make me to write 2 set of tests [17:26:36] 10Wikimedia-Extension-setup, 10Tracking-Neverending: FlaggedRev installation requests (tracking) - https://phabricator.wikimedia.org/T31744 (10Aklapper) [17:29:14] 10MediaWiki-extensions-Other, 10Projects-Cleanup, 10Repository-Admins, 10Wikimedia-GitHub, 10translatewiki.net: Archive the Solarium extension - https://phabricator.wikimedia.org/T252911 (10Dinoguy1000) [17:30:39] 10MediaWiki-extensions-FlaggedRevs, 10Code-Stewardship-Reviews, 10Release-Engineering-Team (Code Health): Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10Aklapper) [17:30:41] 10Wikimedia-Extension-setup, 10Bengali-Sites: Deploy FlaggedRevs on bn.wikibooks - https://phabricator.wikimedia.org/T205145 (10Aklapper) [17:30:44] 10Wikimedia-Extension-setup, 10Wikimedia-Site-requests: Flagged Revisions for Vietnamese Wikipedia - https://phabricator.wikimedia.org/T204354 (10Aklapper) [17:30:46] 10Wikimedia-Extension-setup: Activating Flagged revisions on ar.wikinews - https://phabricator.wikimedia.org/T143886 (10Aklapper) [17:30:48] 10Wikimedia-Site-requests, 10Chinese-Sites: Enable Flagged Revisions (for trial run purpose) at the Chinese Wikipedia - https://phabricator.wikimedia.org/T221933 (10Aklapper) [17:35:44] 10MediaWiki-Codesniffer: Codesniffer should check that nullable typehints are lacking superfluous whitespace - https://phabricator.wikimedia.org/T252947 (10Umherirrender) [17:42:17] 10Wikimedia-Site-requests: Enable Local File Uploads for Sysop in Doteli Wikipedia (dtywiki) - https://phabricator.wikimedia.org/T176706 (10Aklapper) 05Stalled→03Declined No policies has been created in the last 2.5 years hence unfortunately closing this Phabricator task. @Saroj_Uprety: After a policy has b... [17:44:36] 10MediaWiki-Search, 10CirrusSearch, 10Discovery, 10Discovery-Search, 10I18n: Update and/or enable custom entries for Hebmorph dictionary - https://phabricator.wikimedia.org/T75862 (10Aklapper) [17:46:40] 10MediaWiki-Search, 10CirrusSearch, 10Discovery, 10Discovery-Search, and 2 others: Update and/or enable custom entries for Hebmorph dictionary - https://phabricator.wikimedia.org/T75862 (10Aklapper) This seems to be blocked on upstream hence adding #upstream. https://github.com/synhershko/HebMorph/issues l... [17:47:55] 10MediaWiki-Codesniffer: Codesniffer should check the whitespace in use statements for traits - https://phabricator.wikimedia.org/T252948 (10Umherirrender) [17:58:07] (03PS3) 10Ladsgroup: Add test to compare generated sql with the abstract schema [core] - 10https://gerrit.wikimedia.org/r/596783 (https://phabricator.wikimedia.org/T252919) [17:58:11] (03CR) 10Ladsgroup: Add test to compare generated sql with the abstract schema (032 comments) [core] - 10https://gerrit.wikimedia.org/r/596783 (https://phabricator.wikimedia.org/T252919) (owner: 10Ladsgroup) [18:08:59] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Fully terminate use of Wikidata item descriptions as short article descriptions for English Wikipedia articles - https://phabricator.wikimedia.org/T248457 (10Aklapper) [18:18:04] (03CR) 10Reedy: [C: 03+2] Add test to compare generated sql with the abstract schema [core] - 10https://gerrit.wikimedia.org/r/596783 (https://phabricator.wikimedia.org/T252919) (owner: 10Ladsgroup) [18:23:27] 10MediaWiki-Special-pages, 10Patch-For-Review, 10User-DannyS712: Given the option to rollback 0 edits in Special:Contributions - https://phabricator.wikimedia.org/T89780 (10Naleksuh) Danny's change seems to just change 0 to 1. I'm not entirely sure if that fixes it, though, for example what happens if you're... [18:34:08] (03PS2) 10Krinkle: resourceloader: Cleanup CSSMin [core] - 10https://gerrit.wikimedia.org/r/596808 (owner: 10Reedy) [18:34:10] (03CR) 10Krinkle: [C: 03+2] resourceloader: Cleanup CSSMin [core] - 10https://gerrit.wikimedia.org/r/596808 (owner: 10Reedy) [18:35:46] (03PS7) 10Art-Baltai: Create LanguageConverterFactory and cover with tests [core] - 10https://gerrit.wikimedia.org/r/596530 (https://phabricator.wikimedia.org/T243323) [18:36:31] (03CR) 10Krinkle: "Aaron recenly refactored most of the related logic into the HtmlCacheUpdater service. Perhaps some of this can go in there as well as it " [core] - 10https://gerrit.wikimedia.org/r/596721 (https://phabricator.wikimedia.org/T250781) (owner: 10Ppchelko) [18:36:42] (03Merged) 10jenkins-bot: Add test to compare generated sql with the abstract schema [core] - 10https://gerrit.wikimedia.org/r/596783 (https://phabricator.wikimedia.org/T252919) (owner: 10Ladsgroup) [18:37:41] (03CR) 10Krinkle: [C: 03+1] Add EventBus backed EventRelayer for CDN purges. (031 comment) [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/596463 (https://phabricator.wikimedia.org/T250781) (owner: 10Ppchelko) [18:51:23] (03Merged) 10jenkins-bot: resourceloader: Cleanup CSSMin [core] - 10https://gerrit.wikimedia.org/r/596808 (owner: 10Reedy) [19:03:31] 10MediaWiki-Installer, 10CPT Initiatives (Abstract Schema), 10Core Platform Team Workboards (Initiatives), 10Epic, and 8 others: RFC: Abstract schemas and schema changes - https://phabricator.wikimedia.org/T191231 (10Reedy) [19:13:36] (03CR) 10Krinkle: Implement WebAuthn module (031 comment) [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/508788 (https://phabricator.wikimedia.org/T218211) (owner: 10ItSpiderman) [19:14:04] 10MediaWiki-Vendor, 10Librarization: What to do about multiple libraries implementing the same thing? - https://phabricator.wikimedia.org/T232099 (10Krinkle) [19:18:04] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Add sniff to disallow specific tags with no text after them - https://phabricator.wikimedia.org/T252914 (10DannyS712) `@param`, `@return`, and `@throws` should already be covered by the FunctionCommentSniff [19:19:09] (03CR) 10Krinkle: [C: 04-1] Fix more libs PSR12.Properties.ConstantVisibility.NotFound (031 comment) [core] - 10https://gerrit.wikimedia.org/r/596809 (owner: 10Reedy) [19:20:45] (03PS3) 10Reedy: Fix more libs PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596809 [19:20:59] 10MediaWiki-Special-pages, 10Patch-For-Review, 10User-DannyS712: Given the option to rollback 0 edits in Special:Contributions - https://phabricator.wikimedia.org/T89780 (10DannyS712) >>! In T89780#6142495, @Naleksuh wrote: > Danny's change seems to just change 0 to 1. I'm not entirely sure if that fixes it,... [19:24:59] (03CR) 10Krinkle: [C: 04-1] Fix more libs PSR12.Properties.ConstantVisibility.NotFound (031 comment) [core] - 10https://gerrit.wikimedia.org/r/596809 (owner: 10Reedy) [19:25:10] (03CR) 10Krinkle: [C: 04-1] "rest LGTM" [core] - 10https://gerrit.wikimedia.org/r/596809 (owner: 10Reedy) [19:25:50] (03PS4) 10Reedy: Fix more libs PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596809 [19:30:43] 10MobileFrontend, 10Growth-Team, 10Notifications: Notification links redirects to desktop site - https://phabricator.wikimedia.org/T211559 (10Aklapper) >>! In T211559#5125988, @SBisson wrote: > @Force_Radical could you specify which notification "type" you are experiencing this with and which link specifical... [19:32:05] 10Phabricator, 10User-Josve05a: My profile picture on Phabricator looks wierd - https://phabricator.wikimedia.org/T235348 (10Aklapper) @Josve05a: Does this also happen in Chrome? Have you found any pattern (assuming this still happens)? [19:34:36] 10MediaWiki-extensions-Scribunto, 10Community-consensus-needed, 10I18n: zh-min-nan Wikipedia: translation of namespace Module - https://phabricator.wikimedia.org/T160618 (10Aklapper) 05Stalled→03Declined >>! In T160618#3762458, @MarcoAurelio wrote: > @Luuva Have you discussed this already with the zh-min... [19:35:33] 10MediaWiki-Internationalization, 10I18n, 10TestMe: Using IPad, Arabic text looks disjoint on Egyptian Arabic (arz) Wikipedia - https://phabricator.wikimedia.org/T135333 (10Aklapper) 05Stalled→03Declined >>! In T135333#4005064, @Amire80 wrote: > Does this still happen? I cannot reproduce it on an iPod to... [19:46:22] (03CR) 10Krinkle: [C: 03+2] Fix more libs PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596809 (owner: 10Reedy) [19:50:11] (03CR) 10DannyS712: [C: 04-1] Create LanguageConverterFactory and cover with tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/596530 (https://phabricator.wikimedia.org/T243323) (owner: 10Art-Baltai) [19:51:55] (03PS7) 10DannyS712: Inject SpamChecker where needed, hard deprecate EditPage static methods [core] - 10https://gerrit.wikimedia.org/r/596287 (https://phabricator.wikimedia.org/T251015) [19:52:08] (03PS3) 10Krinkle: Fix more libs PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596812 (owner: 10Reedy) [19:52:11] (03CR) 10Krinkle: [C: 03+2] Fix more libs PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596812 (owner: 10Reedy) [19:52:39] (03CR) 10Krinkle: "I'd say keep them for now.." [core] - 10https://gerrit.wikimedia.org/r/596789 (owner: 10Reedy) [19:54:47] (03PS7) 10Reedy: Fix languages/ PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596789 [19:56:36] 10MediaWiki-ResourceLoader, 10Performance-Team: ResourceLoader DepStore lock acquired twice? - https://phabricator.wikimedia.org/T252951 (10Krinkle) [19:59:00] (03CR) 10Krinkle: [C: 03+1] resourceloader: make SqlModuleDependencyStore avoid issuing no-op upserts [core] - 10https://gerrit.wikimedia.org/r/596740 (https://phabricator.wikimedia.org/T247028) (owner: 10Aaron Schulz) [19:59:40] (03PS2) 10Art-Baltai: Work with visibility and phpdoc of ConverterRule and LanguageConverter [core] - 10https://gerrit.wikimedia.org/r/596798 (https://phabricator.wikimedia.org/T243910) [20:00:15] (03CR) 10Krinkle: [C: 03+1] "LGTM. phpcs will want a rebase on the libs patch though" [core] - 10https://gerrit.wikimedia.org/r/596789 (owner: 10Reedy) [20:01:51] (03PS5) 10Krinkle: Documentation fixes for upcoming ESLint config change [core] - 10https://gerrit.wikimedia.org/r/596515 (owner: 10Esanders) [20:02:17] (03PS6) 10Krinkle: Documentation fixes for upcoming ESLint config change [core] - 10https://gerrit.wikimedia.org/r/596515 (owner: 10Esanders) [20:02:19] (03CR) 10Krinkle: [C: 03+1] Documentation fixes for upcoming ESLint config change [core] - 10https://gerrit.wikimedia.org/r/596515 (owner: 10Esanders) [20:06:09] 10MediaWiki-extensions-InviteSignup: Special:InviteSignup Too few arguments to function UserGroupMembership::getGroupMemberName() - https://phabricator.wikimedia.org/T252953 (10Addshore) [20:10:45] (03CR) 10Reedy: "Seems jenkins hasn't submitted..." [core] - 10https://gerrit.wikimedia.org/r/596809 (owner: 10Reedy) [20:13:27] (03PS5) 10Reedy: Fix more libs PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596809 [20:13:38] (03PS4) 10Reedy: Fix more libs PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596812 [20:16:04] (03CR) 10jerkins-bot: [V: 04-1] Work with visibility and phpdoc of ConverterRule and LanguageConverter [core] - 10https://gerrit.wikimedia.org/r/596798 (https://phabricator.wikimedia.org/T243910) (owner: 10Art-Baltai) [20:23:39] 10MediaWiki-extensions-Other, 10Parsoid, 10Projects-Cleanup, 10Repository-Admins, and 2 others: Archive the ParsoidBatchAPI extension - https://phabricator.wikimedia.org/T252744 (10Ciencia_Al_Poder) >>! In T252744#6137019, @ssastry wrote: > I would wait on this. We undeployed this only on the Wikimedia clu... [20:29:36] 10MediaWiki-Special-pages, 10Patch-For-Review, 10User-DannyS712: Given the option to rollback 0 edits in Special:Contributions - https://phabricator.wikimedia.org/T89780 (10Naleksuh) In that case, what happens if it should show 2. Does it show 1? Or does this bug only happen when for a single edit? All quest... [20:30:25] (03CR) 10Reedy: [C: 03+2] "reapply" [core] - 10https://gerrit.wikimedia.org/r/596809 (owner: 10Reedy) [20:30:30] (03CR) 10Reedy: [C: 03+2] "reapply" [core] - 10https://gerrit.wikimedia.org/r/596812 (owner: 10Reedy) [20:36:10] 10MediaWiki-Vagrant, 10Patch-For-Review, 10User-zeljkofilipin: MediaWiki-Vagrant should use the same Node.js version as Wikimedia production - https://phabricator.wikimedia.org/T217113 (10Tgr) Wrt using node 10 based CI tools on vagrant, my workaround is using [[https://github.com/ekalinin/nodeenv|nodeenv]].... [20:41:34] 10MediaWiki-Codesniffer, 10User-DannyS712: Add a sniff to warn when public methods lack `@since` - https://phabricator.wikimedia.org/T251785 (10Umherirrender) If the class holds a @since it should be okay also for the function (similar to @covers in unit tests) [20:44:36] 10MediaWiki-Codesniffer: MediaWiki.Commenting.DocComment.SyntaxAlignedDocStar issue - https://phabricator.wikimedia.org/T251248 (10Umherirrender) Not covered by `Generic.WhiteSpace.DisallowSpaceIndent` [20:44:45] (03PS2) 10Karl Wettin (WMSE): Create database for utterance data [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/596676 (https://phabricator.wikimedia.org/T248469) [20:45:39] (03CR) 10jerkins-bot: [V: 04-1] Create database for utterance data [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/596676 (https://phabricator.wikimedia.org/T248469) (owner: 10Karl Wettin (WMSE)) [20:47:48] (03Merged) 10jenkins-bot: Fix more libs PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596809 (owner: 10Reedy) [20:48:22] (03Merged) 10jenkins-bot: Fix more libs PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596812 (owner: 10Reedy) [20:49:16] (03PS8) 10Reedy: Fix languages/ PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596789 [20:54:18] (03PS1) 10Reedy: Squiz.Scope.MethodScope.Missing [core] - 10https://gerrit.wikimedia.org/r/596820 [20:59:00] (03PS1) 10Ephemeralwaves: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TemplateWizard into review/ephemeralwaves/T240766 [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/596821 [21:02:48] (03PS7) 10Ephemeralwaves: Selenium: add page object [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/592508 (https://phabricator.wikimedia.org/T240766) [21:03:21] (03Abandoned) 10Ephemeralwaves: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TemplateWizard into review/ephemeralwaves/T240766 [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/596821 (owner: 10Ephemeralwaves) [21:04:37] 10MediaWiki-Special-pages, 10Patch-For-Review, 10User-DannyS712: Given the option to rollback 0 edits in Special:Contributions - https://phabricator.wikimedia.org/T89780 (10DannyS712) >>! In T89780#6142590, @Naleksuh wrote: > In that case, what happens if it should show 2. Does it show 1? Or does this bug on... [21:05:16] (03PS3) 10Karl Wettin (WMSE): Create database for utterance data [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/596676 (https://phabricator.wikimedia.org/T248469) [21:05:48] 10MediaWiki-Codesniffer, 10User-DannyS712: Add a sniff to warn when public methods lack `@since` - https://phabricator.wikimedia.org/T251785 (10DannyS712) >>! In T251785#6142596, @Umherirrender wrote: > If the class holds a @since it should be okay also for the function (similar to @covers in unit tests) Sure... [21:06:10] (03CR) 10jerkins-bot: [V: 04-1] Create database for utterance data [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/596676 (https://phabricator.wikimedia.org/T248469) (owner: 10Karl Wettin (WMSE)) [21:08:55] (03PS8) 10Ephemeralwaves: Selenium: add page object [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/592508 (https://phabricator.wikimedia.org/T240766) [21:10:58] (03CR) 10jerkins-bot: [V: 04-1] Squiz.Scope.MethodScope.Missing [core] - 10https://gerrit.wikimedia.org/r/596820 (owner: 10Reedy) [21:11:51] (03CR) 10jerkins-bot: [V: 04-1] Selenium: add page object [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/592508 (https://phabricator.wikimedia.org/T240766) (owner: 10Ephemeralwaves) [21:13:15] (03PS9) 10Ephemeralwaves: Selenium: add page object [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/592508 (https://phabricator.wikimedia.org/T240766) [21:18:31] (03PS4) 10Karl Wettin (WMSE): Create database for utterance data [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/596676 (https://phabricator.wikimedia.org/T248469) [21:19:01] (03PS1) 10Reedy: Fix some Squiz.Scope.MethodScope.Missing [core] - 10https://gerrit.wikimedia.org/r/596823 [21:19:25] (03CR) 10jerkins-bot: [V: 04-1] Create database for utterance data [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/596676 (https://phabricator.wikimedia.org/T248469) (owner: 10Karl Wettin (WMSE)) [21:20:23] (03CR) 10Krinkle: [C: 03+2] Fix languages/ PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596789 (owner: 10Reedy) [21:21:00] (03PS2) 10Reedy: Squiz.Scope.MethodScope.Missing [core] - 10https://gerrit.wikimedia.org/r/596820 [21:27:21] (03PS5) 10Karl Wettin (WMSE): Create database for utterance data [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/596676 (https://phabricator.wikimedia.org/T248469) [21:28:14] (03CR) 10jerkins-bot: [V: 04-1] Create database for utterance data [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/596676 (https://phabricator.wikimedia.org/T248469) (owner: 10Karl Wettin (WMSE)) [21:28:48] (03PS8) 10Ori.livneh: mime: Convert built-in MIME mappings to PHP arrays [core] - 10https://gerrit.wikimedia.org/r/596698 (https://phabricator.wikimedia.org/T252228) [21:29:41] (03PS7) 10Anysite: Prevent PageForms saving untouched VEditors when submitting [extensions/VEForAll] - 10https://gerrit.wikimedia.org/r/596608 (https://phabricator.wikimedia.org/T252858) [21:30:38] (03CR) 10Ori.livneh: "I don't know how autoloading works internally so I'd rather not mess with the path in this CL." [core] - 10https://gerrit.wikimedia.org/r/596698 (https://phabricator.wikimedia.org/T252228) (owner: 10Ori.livneh) [21:31:00] (03CR) 10Ori.livneh: mime: Convert built-in MIME mappings to PHP arrays (031 comment) [core] - 10https://gerrit.wikimedia.org/r/596698 (https://phabricator.wikimedia.org/T252228) (owner: 10Ori.livneh) [21:31:35] (03PS6) 10Karl Wettin (WMSE): Create database for utterance data [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/596676 (https://phabricator.wikimedia.org/T248469) [21:32:30] (03CR) 10jerkins-bot: [V: 04-1] Create database for utterance data [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/596676 (https://phabricator.wikimedia.org/T248469) (owner: 10Karl Wettin (WMSE)) [21:37:48] (03CR) 10jerkins-bot: [V: 04-1] Squiz.Scope.MethodScope.Missing [core] - 10https://gerrit.wikimedia.org/r/596820 (owner: 10Reedy) [21:38:53] (03Merged) 10jenkins-bot: Fix languages/ PSR12.Properties.ConstantVisibility.NotFound [core] - 10https://gerrit.wikimedia.org/r/596789 (owner: 10Reedy) [21:44:00] (03PS3) 10Reedy: Squiz.Scope.MethodScope.Missing [core] - 10https://gerrit.wikimedia.org/r/596820 [21:44:02] (03PS1) 10Reedy: Fix some Squiz.Scope.MethodScope.Missing [core] - 10https://gerrit.wikimedia.org/r/596826 [21:45:41] (03CR) 10jerkins-bot: [V: 04-1] mime: Convert built-in MIME mappings to PHP arrays [core] - 10https://gerrit.wikimedia.org/r/596698 (https://phabricator.wikimedia.org/T252228) (owner: 10Ori.livneh) [21:54:30] (03CR) 10Krinkle: mime: Convert built-in MIME mappings to PHP arrays (031 comment) [core] - 10https://gerrit.wikimedia.org/r/596698 (https://phabricator.wikimedia.org/T252228) (owner: 10Ori.livneh) [21:55:06] (03CR) 10Krinkle: mime: Convert built-in MIME mappings to PHP arrays (031 comment) [core] - 10https://gerrit.wikimedia.org/r/596698 (https://phabricator.wikimedia.org/T252228) (owner: 10Ori.livneh) [21:55:47] (03CR) 10Krinkle: [C: 03+2] Fix some Squiz.Scope.MethodScope.Missing [core] - 10https://gerrit.wikimedia.org/r/596823 (owner: 10Reedy) [21:56:06] (03CR) 10Krinkle: [C: 03+1] Fix some Squiz.Scope.MethodScope.Missing [core] - 10https://gerrit.wikimedia.org/r/596826 (owner: 10Reedy) [22:01:49] (03CR) 10jerkins-bot: [V: 04-1] Squiz.Scope.MethodScope.Missing [core] - 10https://gerrit.wikimedia.org/r/596820 (owner: 10Reedy) [22:11:25] 10MediaWiki-Special-pages, 10Patch-For-Review, 10User-DannyS712: Given the option to rollback 0 edits in Special:Contributions - https://phabricator.wikimedia.org/T89780 (10Naleksuh) Since this is a relatively minor bug anyway, I would prefer to leave it until it's actually found out why it counts as 0. If i... [22:14:03] (03Merged) 10jenkins-bot: Fix some Squiz.Scope.MethodScope.Missing [core] - 10https://gerrit.wikimedia.org/r/596823 (owner: 10Reedy) [22:15:16] (03PS1) 10Amire80: Fix GENDER syntax [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/596827 [22:16:43] (03CR) 10Amire80: "To be honest, I haven't tested it, but I'm pretty sure {{GENDER:you}} is not correct :)" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/596827 (owner: 10Amire80) [22:17:50] (03CR) 10Krinkle: [C: 03+2] Fix some Squiz.Scope.MethodScope.Missing [core] - 10https://gerrit.wikimedia.org/r/596826 (owner: 10Reedy) [22:18:13] (03PS1) 10Reedy: Narrow Squiz.Scope.MethodScope.Missing [core] - 10https://gerrit.wikimedia.org/r/596828 [22:22:34] (03PS2) 10Reedy: Narrow Squiz.Scope.MethodScope.Missing [core] - 10https://gerrit.wikimedia.org/r/596828 [22:25:11] (03PS3) 10Esanders: WIP Add reply links on the server [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/596813 (https://phabricator.wikimedia.org/T252555) [22:26:51] (03Abandoned) 10Ammarpad: Show revert action link to all move types [core] - 10https://gerrit.wikimedia.org/r/553790 (https://phabricator.wikimedia.org/T148985) (owner: 10Ammarpad) [22:27:10] 10MediaWiki-Logging, 10Patch-For-Review: Add "revert" link to "move_redir" actions recorded in "Special:Log/move" - https://phabricator.wikimedia.org/T148985 (10Ammarpad) 05Open→03Declined [22:28:04] (03CR) 10jerkins-bot: [V: 04-1] WIP Add reply links on the server [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/596813 (https://phabricator.wikimedia.org/T252555) (owner: 10Esanders) [22:36:15] (03Merged) 10jenkins-bot: Fix some Squiz.Scope.MethodScope.Missing [core] - 10https://gerrit.wikimedia.org/r/596826 (owner: 10Reedy) [22:37:53] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Epic: Redesign ResourceLoader's file dependency tracking (module_deps) - https://phabricator.wikimedia.org/T113916 (10Krinkle) With T252945 in fresh memory, I figured I'd measure the size of the data. ` $ foreachwiki mysql.php -- -e 'SELECT SUM(LENGTH(md_dep... [22:38:03] (03CR) 10jerkins-bot: [V: 04-1] Narrow Squiz.Scope.MethodScope.Missing [core] - 10https://gerrit.wikimedia.org/r/596828 (owner: 10Reedy) [22:47:08] 10MediaWiki-Blocks: Add a way to disable a users session and log them out when blocking - https://phabricator.wikimedia.org/T222281 (10Bugreporter) [22:47:10] 10MediaWiki-Blocks: wgBlockDisablesLogin - block form checkbox? - https://phabricator.wikimedia.org/T35737 (10Bugreporter) [22:48:58] 10MediaWiki-Blocks: Add a way to disable a users session and log them out when blocking - https://phabricator.wikimedia.org/T222281 (10Bugreporter) [22:50:39] (03PS3) 10Reedy: Narrow Squiz.Scope.MethodScope.Missing [core] - 10https://gerrit.wikimedia.org/r/596828 [22:51:54] 10MediaWiki-extensions-OATHAuth: Unable to use webAuthn outside of registration domain - https://phabricator.wikimedia.org/T252954 (10Lars.Dormans) [22:52:45] (03CR) 10Krinkle: [C: 03+1] "I'd be fine with reverting some part of the changes to restore prior behaviour. Can to confirm that this is only restoring previous behavi" [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/582528 (https://phabricator.wikimedia.org/T248237) (owner: 10Reedy) [22:52:53] 10MediaWiki-extensions-OATHAuth: Unable to use webAuthn outside of registration domain - https://phabricator.wikimedia.org/T252954 (10Reedy) [22:52:55] 10MediaWiki-extensions-OATHAuth, 10MW-1.35-notes (1.35.0-wmf.28; 2020-04-14): Logging in at another wiki than WebAuth was set up fails - https://phabricator.wikimedia.org/T244088 (10Reedy) [23:01:55] (03CR) 10Art-Baltai: Rename ILanguageInterface::convert function to eliminate ambiguity (034 comments) [core] - 10https://gerrit.wikimedia.org/r/595341 (https://phabricator.wikimedia.org/T243326) (owner: 10Art-Baltai) [23:02:17] (03PS6) 10Art-Baltai: Rename ILanguageInterface::convert function to eliminate ambiguity [core] - 10https://gerrit.wikimedia.org/r/595341 (https://phabricator.wikimedia.org/T243326) [23:07:24] (03CR) 10Art-Baltai: Create LanguageConverterFactory and cover with tests (036 comments) [core] - 10https://gerrit.wikimedia.org/r/596530 (https://phabricator.wikimedia.org/T243323) (owner: 10Art-Baltai) [23:07:37] 10MediaWiki-Blocks: Add a way to prevent user from log in and disable a users session when blocking - https://phabricator.wikimedia.org/T222281 (10Bugreporter) [23:09:20] (03CR) 10DannyS712: [C: 04-1] Create LanguageConverterFactory and cover with tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/596530 (https://phabricator.wikimedia.org/T243323) (owner: 10Art-Baltai) [23:09:33] (03PS8) 10Art-Baltai: Create SearchNearMatcherFactory and cover with tests [core] - 10https://gerrit.wikimedia.org/r/596530 (https://phabricator.wikimedia.org/T243323) [23:12:50] (03CR) 10Art-Baltai: Create SearchNearMatcherFactory and cover with tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/596530 (https://phabricator.wikimedia.org/T243323) (owner: 10Art-Baltai) [23:18:01] (03PS3) 10Art-Baltai: Work with visibility and phpdoc of ConverterRule and LanguageConverter [core] - 10https://gerrit.wikimedia.org/r/596798 (https://phabricator.wikimedia.org/T243910) [23:18:34] (03PS7) 10Karl Wettin (WMSE): Create database for utterance data [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/596676 (https://phabricator.wikimedia.org/T248469) [23:19:39] (03CR) 10jerkins-bot: [V: 04-1] Create database for utterance data [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/596676 (https://phabricator.wikimedia.org/T248469) (owner: 10Karl Wettin (WMSE)) [23:25:13] (03CR) 10Reedy: "Just go back to the isValid() (rather than isValidIPv4) call at the top of canonicalize()?" [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/582528 (https://phabricator.wikimedia.org/T248237) (owner: 10Reedy) [23:26:42] (03PS8) 10Karl Wettin (WMSE): Create database for utterance data [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/596676 (https://phabricator.wikimedia.org/T248469) [23:27:23] (03CR) 10jerkins-bot: [V: 04-1] Create database for utterance data [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/596676 (https://phabricator.wikimedia.org/T248469) (owner: 10Karl Wettin (WMSE)) [23:33:07] (03PS1) 10Paladox: UserProfile: Remove $user_name variable [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/596834 [23:33:24] (03CR) 10Reedy: Fix up some issues with 2.0.0 canonicalize() (031 comment) [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/582528 (https://phabricator.wikimedia.org/T248237) (owner: 10Reedy) [23:33:45] (03PS2) 10Paladox: UserProfile: Remove $user_name variable [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/596834 [23:34:05] (03PS9) 10Karl Wettin (WMSE): Create database for utterance data [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/596676 (https://phabricator.wikimedia.org/T248469) [23:34:51] (03CR) 10jerkins-bot: [V: 04-1] Create database for utterance data [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/596676 (https://phabricator.wikimedia.org/T248469) (owner: 10Karl Wettin (WMSE)) [23:36:33] 10Wikispeech-Jobrunner, 10Wikispeech-Text-to-Speech, 10Wikispeech-WMSE, 10Patch-For-Review: Create maintenance script for removing voice data - https://phabricator.wikimedia.org/T251261 (10kalle) I didn't mean to, this being in the backlog and all, but I managed to get implement this, T248469 and T251261 a... [23:39:23] 10Wikispeech-Text-to-Speech, 10Wikispeech-WMSE, 10Patch-For-Review, 10Wikispeech-Jobrunner (Sprint): Store Speechoid response as files - https://phabricator.wikimedia.org/T249200 (10kalle) I didn't mean to, but I managed to implement this, T248469 and T251261 all at the same time in the same patch. [23:45:12] (03Abandoned) 10Paladox: UserProfile: Remove $user_name variable [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/596834 (owner: 10Paladox) [23:52:46] (03PS1) 10Paladox: MigrateOldUserProfileUserColumnToActor: Add try and catch [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/596836 [23:57:15] (03PS2) 10Paladox: MigrateOldUserProfileUserColumnToActor: Add try and catch [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/596836 [23:58:23] (03PS3) 10Paladox: MigrateOldUserProfileUserColumnToActor: Add try and catch [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/596836 [23:59:08] (03PS4) 10Art-Baltai: Work with visibility and phpdoc of ConverterRule and LanguageConverter [core] - 10https://gerrit.wikimedia.org/r/596798 (https://phabricator.wikimedia.org/T243910) [23:59:31] (03CR) 10Art-Baltai: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/596798 (https://phabricator.wikimedia.org/T243910) (owner: 10Art-Baltai)