[00:01:27] (03Merged) 10jenkins-bot: Drop wfSetupSession, deprecated in 1.27 [core] - 10https://gerrit.wikimedia.org/r/593767 (https://phabricator.wikimedia.org/T232864) (owner: 10Jforrester) [00:01:34] (03Merged) 10jenkins-bot: Drop wfIsHHVM, deprecated in 1.34 [core] - 10https://gerrit.wikimedia.org/r/593768 (owner: 10Jforrester) [00:09:54] (03PS2) 10Jforrester: Finish dropping wgContentHandlerUseDB; unused anywhere [core] - 10https://gerrit.wikimedia.org/r/589018 [00:11:34] (03PS3) 10Jforrester: Finish dropping wgContentHandlerUseDB; unused anywhere [core] - 10https://gerrit.wikimedia.org/r/589018 [00:12:00] (03CR) 10Catrope: [C: 03+1] "Per my comment on the task, let's merge this on Tuesday after the cut" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/591154 (https://phabricator.wikimedia.org/T46787) (owner: 10Kosta Harlan) [00:15:14] (03CR) 10Jforrester: "> Patch Set 1: Code-Review-1" [core] - 10https://gerrit.wikimedia.org/r/589018 (owner: 10Jforrester) [00:15:40] 10MediaWiki-General, 10MW-1.35-release, 10Patch-For-Review, 10Technical-Debt (Deprecation process): Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release - https://phabricator.wikimedia.org/T232864 (10Jdforrester-WMF) [00:16:13] (03CR) 10Reedy: [C: 03+2] Finish dropping wgContentHandlerUseDB; unused anywhere [core] - 10https://gerrit.wikimedia.org/r/589018 (owner: 10Jforrester) [00:17:51] (03CR) 10Jforrester: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 30.0.0 [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/593793 (owner: 10Libraryupgrader) [00:23:47] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Using assertContains() with string haystacks is deprecated - https://phabricator.wikimedia.org/T251652 (10Reedy) [00:25:27] 10MediaWiki-General, 10MW-1.35-release, 10Patch-For-Review, 10Technical-Debt (Deprecation process): Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release - https://phabricator.wikimedia.org/T232864 (10DannyS712) [00:29:50] (03CR) 10Ppchelko: [C: 03+1] "We've had a discussion and I guess it's better to split changes in a few patches rather then create a monster mega-patch." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/593367 (https://phabricator.wikimedia.org/T251360) (owner: 10Art-Baltai) [00:30:17] 10MediaWiki-extensions-LiquidThreads, 10Core Platform Team Workboards (Contractor Workboard), 10Patch-For-Review: Call Threads::withRoot with WikiPage argument - https://phabricator.wikimedia.org/T251360 (10Art-Baltai) [00:30:35] (03Abandoned) 10DannyS712: [WIP] block log [core] - 10https://gerrit.wikimedia.org/r/578645 (owner: 10DannyS712) [00:30:50] (03PS1) 10DannyS712: [WIP] Empty block [core] - 10https://gerrit.wikimedia.org/r/593871 [00:31:48] 10DiscussionTools, 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.27; 2020-04-07): Enable DiscussionTools on pages not in a talk namespace - https://phabricator.wikimedia.org/T245890 (10ppelberg) [00:32:19] 10DiscussionTools, 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.27; 2020-04-07): Enable DiscussionTools on pages where `__NEWSECTIONLINK__` is present - https://phabricator.wikimedia.org/T245890 (10ppelberg) [00:32:59] 10DiscussionTools, 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.27; 2020-04-07): Enable DiscussionTools on pages where `__NEWSECTIONLINK__` is present - https://phabricator.wikimedia.org/T245890 (10ppelberg) >>! In T245890#6094529, @JTannerWMF wrote: > This task needs... [00:34:32] 10DiscussionTools, 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.27; 2020-04-07): Enable DiscussionTools on pages where `__NEWSECTIONLINK__` is present - https://phabricator.wikimedia.org/T245890 (10ppelberg) >>! In T245890#6095338, @Samat wrote: > I like that the tool... [00:34:34] (03Merged) 10jenkins-bot: Finish dropping wgContentHandlerUseDB; unused anywhere [core] - 10https://gerrit.wikimedia.org/r/589018 (owner: 10Jforrester) [00:35:53] 10DiscussionTools, 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.27; 2020-04-07): Enable DiscussionTools on pages where `__NEWSECTIONLINK__` is present - https://phabricator.wikimedia.org/T245890 (10ppelberg) [00:36:24] 10DiscussionTools, 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board): [RESEARCH SPIKE] Evaluate if some non-talk namespaces should have discussion tools enabled - https://phabricator.wikimedia.org/T249180 (10ppelberg) [00:36:28] 10DiscussionTools, 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.27; 2020-04-07): Enable DiscussionTools on pages where `__NEWSECTIONLINK__` is present - https://phabricator.wikimedia.org/T245890 (10ppelberg) [00:36:52] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), 10Patch-For-Review: Enable the Reply tool in the Project namespace (Wikipedia:) and other "wgExtraSignatureNamespaces" - https://phabricator.wikimedia.org/T249036 (10ppelberg) [00:36:58] 10DiscussionTools, 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.27; 2020-04-07): Enable DiscussionTools on pages where `__NEWSECTIONLINK__` is present - https://phabricator.wikimedia.org/T245890 (10ppelberg) [00:37:06] 10MediaWiki-ContentHandler, 10MediaWiki-Export-or-Import: Special:Import fails poorly if ContentHandler models don't match - https://phabricator.wikimedia.org/T47750 (10Jdforrester-WMF) 05Stalled→03Invalid `wgContentHandlerUseDB` has been deprecated as of MediaWiki 1.34 and removed as of MediaWiki 1.35. Co... [00:37:08] 10MediaWiki-Core-Testing: ImportTest::testHandlePageContainsRedirect failure with non-wikitext content in main namespace - https://phabricator.wikimedia.org/T74214 (10Jdforrester-WMF) [00:37:14] 10DiscussionTools, 10OWC2020, 10Editing-team (Tracking): Prevent DiscussionTools from being enabled on pages they should not be - https://phabricator.wikimedia.org/T249293 (10ppelberg) [00:37:18] 10DiscussionTools, 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.27; 2020-04-07): Enable DiscussionTools on pages where `__NEWSECTIONLINK__` is present - https://phabricator.wikimedia.org/T245890 (10ppelberg) [00:37:36] 10Editing-team (Tracking), 10OWC2020 (OWC2020 Replying 1.0): Explore: how can Reply tool be enabled on pages consisting solely of transcluded conversations - https://phabricator.wikimedia.org/T250540 (10ppelberg) [00:37:40] 10DiscussionTools, 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.27; 2020-04-07): Enable DiscussionTools on pages where `__NEWSECTIONLINK__` is present - https://phabricator.wikimedia.org/T245890 (10ppelberg) [00:37:49] 10MediaWiki-General, 10Core Platform Team Workboards (Contractor Workboard), 10MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), 10Patch-For-Review: Cleanup deprecated calls in production - https://phabricator.wikimedia.org/T251278 (10Pchelolo) [00:39:05] (03PS2) 10DannyS712: [WIP] Empty block [core] - 10https://gerrit.wikimedia.org/r/593871 [00:42:15] 10MediaWiki-General, 10Core Platform Team Workboards (Contractor Workboard), 10MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), 10Patch-For-Review: Cleanup deprecated calls in production - https://phabricator.wikimedia.org/T251278 (10Pchelolo) All the instances of deprecated calls mentioned in this task have bee... [00:43:09] (03PS5) 10DannyS712: Replace Article::$mRevision with RevisionRecord [core] - 10https://gerrit.wikimedia.org/r/593826 (https://phabricator.wikimedia.org/T250976) [00:44:17] 10MediaWiki-General, 10MW-1.35-release, 10Patch-For-Review, 10Technical-Debt (Deprecation process): Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release - https://phabricator.wikimedia.org/T232864 (10Jdforrester-WMF) [00:46:18] 10Product-Analytics, 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 1.0): Calculate adoption of Replying tool (Beta Features) - https://phabricator.wikimedia.org/T249386 (10ppelberg) [00:46:51] 10Product-Analytics, 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 1.0): Calculate adoption of Replying tool (Beta Features) - https://phabricator.wikimedia.org/T249386 (10ppelberg) [00:49:01] 10MediaWiki-General, 10MW-1.35-release, 10Patch-For-Review, 10Technical-Debt (Deprecation process): Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release - https://phabricator.wikimedia.org/T232864 (10Jdforrester-WMF) [00:49:42] (03PS1) 10Jforrester: Follow-up c030dacfb: Drop documentation mentions of $wgLocalInterwiki too [core] - 10https://gerrit.wikimedia.org/r/593873 [00:52:00] 10DiscussionTools, 10Product-Analytics, 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 2.0): Workflow engagement check: Replying v1.0 & v2.0 - https://phabricator.wikimedia.org/T247139 (10ppelberg) [00:53:17] (03CR) 10DannyS712: [C: 03+1] "LGTM" [core] - 10https://gerrit.wikimedia.org/r/593873 (owner: 10Jforrester) [00:53:25] 10DiscussionTools, 10Product-Analytics, 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 2.0): Workflow engagement check: Replying v1.0 & v2.0 - https://phabricator.wikimedia.org/T247139 (10ppelberg) [00:54:29] 10DiscussionTools, 10Product-Analytics, 10Editing-team (Tracking), 10OWC2020 (OWC2020 Replying 1.0): Workflow engagement check: Replying v1.0 - https://phabricator.wikimedia.org/T247138 (10ppelberg) [00:54:31] 10DiscussionTools, 10Product-Analytics, 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 2.0): Workflow engagement check: Replying v1.0 & v2.0 - https://phabricator.wikimedia.org/T247139 (10ppelberg) [00:54:39] (03CR) 10Reedy: [C: 04-1] Follow-up c030dacfb: Drop documentation mentions of $wgLocalInterwiki too (031 comment) [core] - 10https://gerrit.wikimedia.org/r/593873 (owner: 10Jforrester) [00:54:59] 10Editing-team (Tracking), 10OWC2020 (OWC2020 Replying 1.0): Deploy Replying as opt-out Preference on partner wikis - https://phabricator.wikimedia.org/T249394 (10ppelberg) [00:55:50] 10Design, 10Notifications, 10Growth-Team (Current Sprint), 10Patch-For-Review: Notification panel: Control notification volume - https://phabricator.wikimedia.org/T115264 (10Catrope) [00:56:38] (03CR) 10DannyS712: [C: 03+1] "LGTM" [extensions/SpecialNamespaces] - 10https://gerrit.wikimedia.org/r/589767 (owner: 10Shirayuki) [00:56:47] (03PS2) 10Jforrester: Follow-up c030dacfb: Drop documentation mentions of $wgLocalInterwiki too [core] - 10https://gerrit.wikimedia.org/r/593873 [00:56:53] 10Editing-team (Tracking), 10OWC2020 (OWC2020 Replying 1.0): Deploy Replying as opt-out Preference on partner wikis - https://phabricator.wikimedia.org/T249394 (10ppelberg) [00:56:55] 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board): [Epic] Affordance: Replying to specific comments - https://phabricator.wikimedia.org/T233443 (10ppelberg) [00:57:24] 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 2.0): Deploy Replying v2.0 as Beta Feature to partner wikis - https://phabricator.wikimedia.org/T251654 (10ppelberg) [00:57:25] Reedy: Fussy, fussy. [00:57:44] (03CR) 10DannyS712: "Recheck" [extensions/DataTable2] - 10https://gerrit.wikimedia.org/r/589140 (owner: 10Shirayuki) [00:58:08] 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 2.0): Deploy Replying v2.0 as Beta Feature to partner wikis - https://phabricator.wikimedia.org/T251654 (10ppelberg) [00:58:10] 10Product-Analytics, 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 2.0): Replies v2.0: determine what additional instrumentation is needed - https://phabricator.wikimedia.org/T244498 (10ppelberg) [00:59:04] (03PS2) 10Tjones: Add ICU Tokenizer and Retokenizer Class to Glent for M1 [search/glent] - 10https://gerrit.wikimedia.org/r/593866 (https://phabricator.wikimedia.org/T238151) [00:59:24] 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 2.0): Deploy Replying v2.0 as Beta Feature to partner wikis - https://phabricator.wikimedia.org/T251654 (10ppelberg) [00:59:26] 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board): [Epic] Affordance: Replying to specific comments - https://phabricator.wikimedia.org/T233443 (10ppelberg) [00:59:45] 04(no projects): Create a visual VisualEditor plugin tool or Visual CC to add/edit captions to Wikimedia Commons - https://phabricator.wikimedia.org/T251655 (10BoldLuis) [00:59:47] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board): Instrument new replying workflow - https://phabricator.wikimedia.org/T244500 (10ppelberg) [00:59:49] 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board): [Epic] Affordance: Replying to specific comments - https://phabricator.wikimedia.org/T233443 (10ppelberg) [01:00:09] (03CR) 10Ppchelko: [C: 04-1] "A few small nitpicks, mostly LGTM" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/593826 (https://phabricator.wikimedia.org/T250976) (owner: 10DannyS712) [01:00:46] 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 2.0): Deploy Replying v2.0 as Beta Feature to partner wikis - https://phabricator.wikimedia.org/T251654 (10ppelberg) [01:00:48] 10Product-Analytics, 10OWC2020 (OWC2020 Replying 2.0): Determine which Reply text input should be shown by default - https://phabricator.wikimedia.org/T250523 (10ppelberg) [01:01:01] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Replace if wrapping test class in Scribunto_LuaWikibaseLibraryTestCase - https://phabricator.wikimedia.org/T251656 (10Reedy) [01:01:07] 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 2.0): Deploy Replying v2.0 as Beta Feature to partner wikis - https://phabricator.wikimedia.org/T251654 (10ppelberg) [01:01:22] 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 2.0): Deploy Replying v2.0 as Beta Feature to partner wikis - https://phabricator.wikimedia.org/T251654 (10ppelberg) [01:01:36] 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 2.0): Deploy Replying v2.0 as Beta Feature to partner wikis - https://phabricator.wikimedia.org/T251654 (10ppelberg) [01:02:43] (03PS6) 10DannyS712: Replace Article::$mRevision with RevisionRecord [core] - 10https://gerrit.wikimedia.org/r/593826 (https://phabricator.wikimedia.org/T250976) [01:02:52] (03CR) 10DannyS712: Replace Article::$mRevision with RevisionRecord (033 comments) [core] - 10https://gerrit.wikimedia.org/r/593826 (https://phabricator.wikimedia.org/T250976) (owner: 10DannyS712) [01:03:46] 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 2.0): Deploy Replying v2.0 as Beta Feature to partner wikis - https://phabricator.wikimedia.org/T251654 (10ppelberg) [01:03:49] 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 2.0), 10Patch-For-Review: Create a VE-based text input for replying - https://phabricator.wikimedia.org/T234403 (10ppelberg) [01:06:45] 10DiscussionTools, 10Product-Analytics, 10Editing-team (Tracking), 10OWC2020 (OWC2020 Replying 2.0): Workflow engagement check: Replying v1.0 & v2.0 - https://phabricator.wikimedia.org/T247139 (10ppelberg) [01:07:09] 10Editing-team (Tracking), 10OWC2020 (OWC2020 Replying 2.0): Define approach for expanding the Replying tool's `visual` mode toolbar - https://phabricator.wikimedia.org/T249074 (10ppelberg) [01:07:28] (03PS1) 10Jforrester: Drop the LinkBegin and LinkEnd hooks, deprecated since 1.28 [core] - 10https://gerrit.wikimedia.org/r/593874 (https://phabricator.wikimedia.org/T232864) [01:08:07] 10Editing-team (Tracking), 10OWC2020 (OWC2020 Replying 1.0): Publicize Replying v1.0 at en.wiki - https://phabricator.wikimedia.org/T249378 (10ppelberg) [01:08:38] 10DiscussionTools, 10Editing-team (Tracking), 10OWC2020 (OWC2020 Replying 1.0): Make the Reply tool's Special:Tags have links to a relevant page on each of the four partner wikis - https://phabricator.wikimedia.org/T249063 (10ppelberg) [01:08:55] (03CR) 10DannyS712: "I didn't look at all of the files, but I noticed that it was often retrieving the service each time through a loop, instead of once at the" (039 comments) [core] - 10https://gerrit.wikimedia.org/r/593645 (owner: 10Reedy) [01:09:09] 10OWC2020, 10Editing-team (Tracking): Publicize outcomes of new signature proposal discussions - https://phabricator.wikimedia.org/T248632 (10ppelberg) [01:10:13] (03CR) 10Reedy: "While I know you're suggesting improvements, this is technically no worse than the old calls of the wfWaitForSlaves() ;)" [core] - 10https://gerrit.wikimedia.org/r/593645 (owner: 10Reedy) [01:10:34] (03CR) 10DannyS712: [C: 03+1] "LGTM" [core] - 10https://gerrit.wikimedia.org/r/593874 (https://phabricator.wikimedia.org/T232864) (owner: 10Jforrester) [01:11:01] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 1.0): Make it possible to customize the default signature format per wiki - https://phabricator.wikimedia.org/T249861 (10ppelberg) [01:11:52] (03CR) 10DannyS712: "> While I know you're suggesting improvements, this is technically no" [core] - 10https://gerrit.wikimedia.org/r/593645 (owner: 10Reedy) [01:13:18] (03CR) 10Reedy: "I think it's worth fixing the call in the loop at a minimum before merging this" [core] - 10https://gerrit.wikimedia.org/r/593645 (owner: 10Reedy) [01:14:51] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 1.0): If the first reply includes the other kind of list formatting, then don't add any more - https://phabricator.wikimedia.org/T250127 (10ppelberg) [01:16:46] 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 1.0): Investigate why some replies have extra indentation - https://phabricator.wikimedia.org/T249961 (10ppelberg) >>! In T249961#6048035, @Dyolf77_WMF wrote: > - User Faisal in `ar.wiki` and the use of an extra `:`, he [[ https://ar.wi... [01:22:47] (03CR) 10jerkins-bot: [V: 04-1] Drop the LinkBegin and LinkEnd hooks, deprecated since 1.28 [core] - 10https://gerrit.wikimedia.org/r/593874 (https://phabricator.wikimedia.org/T232864) (owner: 10Jforrester) [01:24:09] 10Small-Wiki-Toolkits, 10Developer-Advocacy (Apr-Jun 2020), 10Goal: Small Wiki Toolkits: How-to guidelines and/or potential recommendations for Gadgets - https://phabricator.wikimedia.org/T246181 (10srishakatux) @Aklapper Made a [[ https://meta.wikimedia.org/w/index.php?title=Gadgets&diff=20033222&oldid=2003... [01:28:45] (03PS4) 10Reedy: Replace wfWaitForSlaves() with LBFactory::waitForReplication() [core] - 10https://gerrit.wikimedia.org/r/593645 [01:29:49] (03CR) 10jerkins-bot: [V: 04-1] Replace wfWaitForSlaves() with LBFactory::waitForReplication() [core] - 10https://gerrit.wikimedia.org/r/593645 (owner: 10Reedy) [01:30:30] (03PS5) 10Reedy: Replace wfWaitForSlaves() with LBFactory::waitForReplication() [core] - 10https://gerrit.wikimedia.org/r/593645 [01:31:12] 04(no projects): MediaWiki links in Phabricator - https://phabricator.wikimedia.org/T251657 (10BoldLuis) [01:32:46] 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board): Deploy DiscussionTools to mw.org - https://phabricator.wikimedia.org/T251208 (10ppelberg) [01:34:03] 04(no projects): MediaWiki links in Phabricator - https://phabricator.wikimedia.org/T251657 (10BoldLuis) [01:42:31] (03PS6) 10Reedy: Replace wfWaitForSlaves() with LBFactory::waitForReplication() [core] - 10https://gerrit.wikimedia.org/r/593645 [01:43:08] (03CR) 10Reedy: Replace wfWaitForSlaves() with LBFactory::waitForReplication() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/593645 (owner: 10Reedy) [01:43:51] 10Phabricator: MediaWiki links in Phabricator - https://phabricator.wikimedia.org/T251657 (10Reedy) 05Open→03Declined Not gonna happen [01:44:05] (03PS9) 10Scardenasmolinar: [wip] Replace toast with OOUI popup on watchlist message [core] - 10https://gerrit.wikimedia.org/r/591159 (https://phabricator.wikimedia.org/T249259) [01:45:22] (03CR) 10Scardenasmolinar: [wip] Replace toast with OOUI popup on watchlist message (033 comments) [core] - 10https://gerrit.wikimedia.org/r/591159 (https://phabricator.wikimedia.org/T249259) (owner: 10Scardenasmolinar) [01:46:08] 10CirrusSearch, 10Discovery-Search, 10MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), 10Patch-For-Review: Deal with dropping of Global CirrusSearch class - https://phabricator.wikimedia.org/T250812 (10Reedy) https://gerrit.wikimedia.org/r/591198 and https://gerrit.wikimedia.org/r/591200 cleared up the last few... [01:49:07] (03PS2) 10Reedy: Drop the LinkBegin and LinkEnd hooks, deprecated since 1.28 [core] - 10https://gerrit.wikimedia.org/r/593874 (https://phabricator.wikimedia.org/T232864) (owner: 10Jforrester) [01:51:08] 10Magnus Sälgö: Purge Europeana entries - https://phabricator.wikimedia.org/T251625 (10Salgo60) [01:51:26] (03CR) 10Reedy: [C: 03+2] Follow-up c030dacfb: Drop documentation mentions of $wgLocalInterwiki too [core] - 10https://gerrit.wikimedia.org/r/593873 (owner: 10Jforrester) [01:51:36] 10Phabricator: MediaWiki links in Phabricator - https://phabricator.wikimedia.org/T251657 (10BoldLuis) [01:51:59] 10Phabricator: MediaWiki links in Phabricator - https://phabricator.wikimedia.org/T251657 (10BoldLuis) >>! In T251657#6101717, @Reedy wrote: > Not gonna happen Why?. [01:52:35] (03CR) 10jerkins-bot: [V: 04-1] Drop the LinkBegin and LinkEnd hooks, deprecated since 1.28 [core] - 10https://gerrit.wikimedia.org/r/593874 (https://phabricator.wikimedia.org/T232864) (owner: 10Jforrester) [01:54:37] 10Editing-team (Tracking), 10OWC2020 (OWC2020 Replying 1.0): Add support for extensions within indented comments - https://phabricator.wikimedia.org/T251633 (10ppelberg) [01:56:22] 10Phabricator: MediaWiki links in Phabricator - https://phabricator.wikimedia.org/T251657 (10Reedy) https://secure.phabricator.com/book/phabricator/article/remarkup/ `[[https://en.wikipedia.org/wiki/Main_Page|Wikipedia Main Page]]` is already the syntax for external links - [[https://en.wikipedia.org/wiki/Main_... [01:56:30] 10Phabricator: MediaWiki links in Phabricator - https://phabricator.wikimedia.org/T251657 (10Reedy) [01:58:17] (03CR) 10jerkins-bot: [V: 04-1] [wip] Replace toast with OOUI popup on watchlist message [core] - 10https://gerrit.wikimedia.org/r/591159 (https://phabricator.wikimedia.org/T249259) (owner: 10Scardenasmolinar) [01:59:15] (03CR) 10jerkins-bot: [V: 04-1] Replace wfWaitForSlaves() with LBFactory::waitForReplication() [core] - 10https://gerrit.wikimedia.org/r/593645 (owner: 10Reedy) [02:00:10] (03PS7) 10Reedy: Replace wfWaitForSlaves() with LBFactory::waitForReplication() [core] - 10https://gerrit.wikimedia.org/r/593645 [02:00:45] (03PS10) 10Scardenasmolinar: [wip] Replace toast with OOUI popup on watchlist message [core] - 10https://gerrit.wikimedia.org/r/591159 (https://phabricator.wikimedia.org/T249259) [02:05:35] (03Merged) 10jenkins-bot: Follow-up c030dacfb: Drop documentation mentions of $wgLocalInterwiki too [core] - 10https://gerrit.wikimedia.org/r/593873 (owner: 10Jforrester) [02:06:38] (03Abandoned) 10Reedy: Parser: deprecate OutputType() and Options() [core] - 10https://gerrit.wikimedia.org/r/525221 (owner: 10MaxSem) [02:08:21] 10Anti-Harassment (The Letter Song): Investigate services to fetch underlying information about IP addresses [8 Hours] - https://phabricator.wikimedia.org/T248525 (10SQL) @Niharika, I've emailed you directly with the costs and limits - and explained why in the email. @dbarratt, thank you! [02:13:40] (03PS5) 10Reedy: Typehint or annotate types in places IDEA complains about [core] - 10https://gerrit.wikimedia.org/r/548001 (owner: 10MaxSem) [02:14:38] (03CR) 10Reedy: "Somehow I missed one big conflict" [core] - 10https://gerrit.wikimedia.org/r/548001 (owner: 10MaxSem) [02:15:33] (03PS6) 10Reedy: Typehint or annotate types in places IDEA complains about [core] - 10https://gerrit.wikimedia.org/r/548001 (owner: 10MaxSem) [02:16:18] (03CR) 10Reedy: "Some files were deleted since. Some the changes already integrated, some the changes were obsoleted..." [core] - 10https://gerrit.wikimedia.org/r/548001 (owner: 10MaxSem) [02:16:49] 10Anti-Harassment: Draft: Build a prototype for the IP info feature - https://phabricator.wikimedia.org/T251602 (10SQL) Just FYI, a cursory glance at the [[ https://ipinfo.io/responses | documentation ]] indicates that the free plan does not include the "connection type", and only really exposes data available v... [02:18:13] 10Magnus Sälgö: Speak with Nobelprize.org if they can make linking easier - https://phabricator.wikimedia.org/T248939 (10Salgo60) [02:25:01] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board): Publish Technical RfC: new syntax for multi-line list items/talk page comments - https://phabricator.wikimedia.org/T246960 (10ppelberg) a:05dchan→03None [02:25:25] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board): Publish Technical RfC: new syntax for multi-line list items/talk page comments - https://phabricator.wikimedia.org/T246960 (10ppelberg) [02:27:06] (03PS11) 10Scardenasmolinar: Replace toast with OOUI popup on watchlist message [core] - 10https://gerrit.wikimedia.org/r/591159 (https://phabricator.wikimedia.org/T249259) [02:35:42] 10MediaWiki-Language-converter, 10Chinese-Sites: Some options are missing from the variant drop-down menu - https://phabricator.wikimedia.org/T251521 (10Xiplus) 05Invalid→03Open I found it happened again on MediaWiki.org. See: https://www.mediawiki.org/w/index.php?title=Extension:CentralAuth/zh&safemode=1&... [02:38:40] (03PS4) 10VolkerE: Replace 'mobile.startup.images' module icons with OOUI ones [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/593832 (https://phabricator.wikimedia.org/T208184) [02:42:01] 10Anti-Harassment: Draft: Build a prototype for the IP info feature - https://phabricator.wikimedia.org/T251602 (10Niharika) >>! In T251602#6101746, @SQL wrote: > Just FYI, a cursory glance at the [[ https://ipinfo.io/responses | documentation ]] indicates that the free plan does not include the "connection type... [02:42:44] 10Design, 10Growth-Team, 10Notifications, 10OOUI: Blurred icon lines in OOUI and Notifications repos - https://phabricator.wikimedia.org/T251659 (10Volker_E) [02:43:35] 10Anti-Harassment (The Letter Song): Investigate services to fetch underlying information about IP addresses [8 Hours] - https://phabricator.wikimedia.org/T248525 (10Niharika) 05Open→03Resolved >>! In T248525#6101741, @SQL wrote: > @Niharika, I've emailed you directly with the costs and limits - and explaine... [02:51:40] 10NewcomerTasks 1.2, 10Growth-Team (Current Sprint), 10Patch-For-Review: Newcomer tasks: clean up help panel EventLogging - https://phabricator.wikimedia.org/T250327 (10Catrope) a:03Catrope Corresponding schema edit: https://meta.wikimedia.org/w/index.php?title=Schema:HelpPanel&diff=next&oldid=20029266 [02:55:02] 10MediaWiki-General, 10CSS, 10MW-1.35-notes (1.35.0-wmf.27; 2020-04-07): Deprecate and remove `.background-image-svg()` mixin from 'mediawiki.mixins.less' - https://phabricator.wikimedia.org/T248062 (10Volker_E) @kaldari Thanks for clarifying. The `.background-mixin-svg()` deprecation could continue, while w... [02:59:44] 10Anti-Harassment (The Letter Song): Investigate services to fetch underlying information about IP addresses [8 Hours] - https://phabricator.wikimedia.org/T248525 (10Reedy) Just incase you weren't aware, we do have MaxMind stuff in production too, including some dataset that WMF pays for - https://github.com/wik... [03:04:09] 10Anti-Harassment (The Letter Song): Investigate services to fetch underlying information about IP addresses [8 Hours] - https://phabricator.wikimedia.org/T248525 (10Reedy) Linked on {T205588}, https://stat.ripe.net/ and https://stat.ripe.net/docs/data_api might be useful too [03:13:58] 10Anti-Harassment (The Letter Song): Investigate services to fetch underlying information about IP addresses [8 Hours] - https://phabricator.wikimedia.org/T248525 (10Niharika) @Reedy Thank you! I had no idea any of that existed. I'll poke around to see what data it provides. Looking at [this doc](https://dev.max... [03:14:34] 10Anti-Harassment: Draft: Build a prototype for the IP info feature - https://phabricator.wikimedia.org/T251602 (10Niharika) As a heads up: >>! In T248525#6101785, @Reedy wrote: > Just incase you weren't aware, we do have MaxMind stuff in production too, including some dataset that WMF pays for - https://github.... [03:44:50] 10Magnus Sälgö: Template Nobelprize winners Wikidata property P8024 and new link model to Nobelprize.org - https://phabricator.wikimedia.org/T251055 (10Salgo60) [04:09:46] 10CheckUser, 10Anti-Harassment (The Letter Song): CU 2.0: Implement an option to allow users to copy the wikitext of the results table to their clipboard - https://phabricator.wikimedia.org/T251361 (10Prtksxna) >>! In T251361#6098519, @dbarratt wrote: > I think it's fine if we present the wikitext in a modal l... [04:10:06] 10Quibble, 10Patch-For-Review: Run Parsoid service in quibble - https://phabricator.wikimedia.org/T218534 (10cscott) Parsoid is in PHP now, could make this easier? [04:30:31] 10CheckUser, 10Anti-Harassment (The Letter Song): Investigate how to make Special:InvestigateBlock page [8 hours] - https://phabricator.wikimedia.org/T249871 (10Prtksxna) >>! In T249871#6088473, @Tchanders wrote: > It should be straightforward to limit the widget to accept 1.2.3.4 or User1. But it would be mor... [05:05:27] (03PS4) 10Niedzielski: resources: add checkbox hack Less and JavaScript [core] - 10https://gerrit.wikimedia.org/r/589692 (https://phabricator.wikimedia.org/T246419) [05:15:37] (03PS3) 10C. Scott Ananian: Always tidy the parser output [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/593825 (https://phabricator.wikimedia.org/T198214) [05:20:21] (03CR) 10jerkins-bot: [V: 04-1] Always tidy the parser output [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/593825 (https://phabricator.wikimedia.org/T198214) (owner: 10C. Scott Ananian) [05:21:47] (03CR) 10jerkins-bot: [V: 04-1] resources: add checkbox hack Less and JavaScript [core] - 10https://gerrit.wikimedia.org/r/589692 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [05:26:17] (03PS1) 10C. Scott Ananian: Tidy is no longer configurable in MW 1.35 [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/593879 (https://phabricator.wikimedia.org/T198214) [05:27:58] (03CR) 10jerkins-bot: [V: 04-1] Tidy is no longer configurable in MW 1.35 [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/593879 (https://phabricator.wikimedia.org/T198214) (owner: 10C. Scott Ananian) [05:29:04] (03PS2) 10C. Scott Ananian: Tidy is no longer configurable in MW 1.35 [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/593879 (https://phabricator.wikimedia.org/T198214) [05:30:43] (03CR) 10jerkins-bot: [V: 04-1] Tidy is no longer configurable in MW 1.35 [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/593879 (https://phabricator.wikimedia.org/T198214) (owner: 10C. Scott Ananian) [05:31:27] (03PS3) 10C. Scott Ananian: Tidy is no longer configurable in MW 1.35 [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/593879 (https://phabricator.wikimedia.org/T198214) [05:34:03] (03PS5) 10Niedzielski: resources: add checkbox hack Less and JavaScript [core] - 10https://gerrit.wikimedia.org/r/589692 (https://phabricator.wikimedia.org/T246419) [05:34:48] (03CR) 10Niedzielski: "Thanks for the extensive feedback, Jan. I think I've made the changes requested." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/589692 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [05:44:38] (03PS1) 10C. Scott Ananian: Don't use WikiPage::getOldestRevision(), deprecated in MW 1.35 [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/593880 (https://phabricator.wikimedia.org/T249393) [05:46:01] (03PS4) 10C. Scott Ananian: Always tidy the parser output [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/593825 (https://phabricator.wikimedia.org/T198214) [05:48:58] (03CR) 10jerkins-bot: [V: 04-1] Don't use WikiPage::getOldestRevision(), deprecated in MW 1.35 [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/593880 (https://phabricator.wikimedia.org/T249393) (owner: 10C. Scott Ananian) [05:49:24] (03CR) 10jerkins-bot: [V: 04-1] resources: add checkbox hack Less and JavaScript [core] - 10https://gerrit.wikimedia.org/r/589692 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [05:50:21] (03CR) 10jerkins-bot: [V: 04-1] Always tidy the parser output [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/593825 (https://phabricator.wikimedia.org/T198214) (owner: 10C. Scott Ananian) [05:50:25] (03PS2) 10C. Scott Ananian: Don't use WikiPage::getOldestRevision(), deprecated in MW 1.35 [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/593880 (https://phabricator.wikimedia.org/T249393) [05:52:58] 10CheckUser, 10Anti-Harassment (The Letter Song): Investigate how to make Special:InvestigateBlock page [8 hours] - https://phabricator.wikimedia.org/T249871 (10Tchanders) @Prtksxna Yes, it would be equally difficult in both [05:53:21] (03CR) 10C. Scott Ananian: "recheck" [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/593825 (https://phabricator.wikimedia.org/T198214) (owner: 10C. Scott Ananian) [05:55:09] (03PS26) 10Niedzielski: [feature] add menu button to toggle panel visibility [skins/Vector] - 10https://gerrit.wikimedia.org/r/584694 (https://phabricator.wikimedia.org/T246419) [05:55:12] (03PS1) 10Niedzielski: [dev][JavaScript] allow clients to be version [skins/Vector] - 10https://gerrit.wikimedia.org/r/593881 (https://phabricator.wikimedia.org/T246419) [05:56:07] (03PS2) 10Niedzielski: [dev][JavaScript] allow clients to be versioned [skins/Vector] - 10https://gerrit.wikimedia.org/r/593881 (https://phabricator.wikimedia.org/T246419) [05:56:10] (03PS27) 10Niedzielski: [feature] add menu button to toggle panel visibility [skins/Vector] - 10https://gerrit.wikimedia.org/r/584694 (https://phabricator.wikimedia.org/T246419) [05:57:59] (03CR) 10Niedzielski: [C: 04-1] "Still working on feedback and icon changes." [skins/Vector] - 10https://gerrit.wikimedia.org/r/584694 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [06:07:22] (03CR) 10jerkins-bot: [V: 04-1] [feature] add menu button to toggle panel visibility [skins/Vector] - 10https://gerrit.wikimedia.org/r/584694 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [06:09:15] (03CR) 10jerkins-bot: [V: 04-1] [feature] add menu button to toggle panel visibility [skins/Vector] - 10https://gerrit.wikimedia.org/r/584694 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [06:13:08] (03PS8) 10DannyS712: Replace `NewRevisionFromEditComplete` with `RevisionFromEditComplete` [core] - 10https://gerrit.wikimedia.org/r/589171 (https://phabricator.wikimedia.org/T250338) [06:13:47] (03CR) 10DannyS712: "> Uploaded patch set 8." [core] - 10https://gerrit.wikimedia.org/r/589171 (https://phabricator.wikimedia.org/T250338) (owner: 10DannyS712) [06:14:30] (03PS9) 10DannyS712: Replace `NewRevisionFromEditComplete` with `RevisionFromEditComplete` [core] - 10https://gerrit.wikimedia.org/r/589171 (https://phabricator.wikimedia.org/T250338) [06:24:56] 10Magnus Sälgö: Change management of entities created and deleted in Europeana - https://phabricator.wikimedia.org/T251225 (10Salgo60) Try to get [[ https://www.wikidata.org/wiki/User_talk:Lesko987a#WikiTree_IDs_2 | feedback from WikiTree developer ]] that has done data synch with Wikitree for the last 3 years a... [06:29:51] (03CR) 10jerkins-bot: [V: 04-1] Replace `NewRevisionFromEditComplete` with `RevisionFromEditComplete` [core] - 10https://gerrit.wikimedia.org/r/589171 (https://phabricator.wikimedia.org/T250338) (owner: 10DannyS712) [06:32:23] (03PS10) 10DannyS712: Replace `NewRevisionFromEditComplete` with `RevisionFromEditComplete` [core] - 10https://gerrit.wikimedia.org/r/589171 (https://phabricator.wikimedia.org/T250338) [06:41:12] (03PS1) 10Shirayuki: Fix versions which introduced variables [core] - 10https://gerrit.wikimedia.org/r/593882 [06:42:01] (03PS1) 10DannyS712: Ensure wikilove edits made via pagetriage are also tagged as `pagetriage` [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/593883 (https://phabricator.wikimedia.org/T231541) [06:42:19] (03PS2) 10DannyS712: Ensure wikilove edits made via pagetriage are also tagged as `pagetriage` [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/593883 (https://phabricator.wikimedia.org/T231541) [06:43:15] (03PS3) 10DannyS712: Send a message: Default to article creator [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/563238 (https://phabricator.wikimedia.org/T242324) [06:48:17] 10MediaWiki-Page-Diffs, 10MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), 10Patch-For-Review, 10User-notice: Use monospace font (or editfont preference) for diffs - https://phabricator.wikimedia.org/T250393 (10QEDK) >>! In T250393#6099565, @Aklapper wrote: > Removing #community-consensus-needed as that [is not... [06:53:47] 10Language-Team, 10UniversalLanguageSelector, 10Software-Licensing: Clarify license of Universal Language Selector - https://phabricator.wikimedia.org/T251643 (10Nikerabbit) > Is ULS dual licensed MIT and GPL? Yes. [06:54:42] 10MediaWiki-Configuration, 10Patch-For-Review: Allow license-name to take an array of SPDX identifier strings - https://phabricator.wikimedia.org/T251642 (10Nikerabbit) Seems redundant with the inline syntax: https://spdx.org/ids-how [06:56:05] 10Language-Team, 10UniversalLanguageSelector, 10Software-Licensing: Clarify license of Universal Language Selector - https://phabricator.wikimedia.org/T251643 (10Nikerabbit) Looking at https://spdx.org/ids-how - I think the question to answer would it be `AND` or `OR` type multi licensing. I'm not fully sure... [07:08:20] 10Wikimedia-Site-requests: Update the el.wikiversity.org main logo to the correct one - https://phabricator.wikimedia.org/T248391 (10QEDK) @dds @Mh-3110 Are either of you planning to work on this? [07:10:58] (03PS4) 10Ammarpad: Encase 'actor_id' value in aggregate function [core] - 10https://gerrit.wikimedia.org/r/593742 (https://phabricator.wikimedia.org/T251599) [07:22:21] (03PS1) 10Physikerwelt: WIP: Importer for StackExchange posts [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/593884 (https://phabricator.wikimedia.org/T251662) [07:23:31] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikibase-Lua, 10Wikidata, 10Documentation: Clarification on Interface/Wikibase-SortedProperties to improve documentation - https://phabricator.wikimedia.org/T250634 (10lucamauri) Dear @Bugreporter may I kindly ask you if... [07:25:09] 10Wikimedia-Site-requests: Update the el.wikiversity.org main logo to the correct one - https://phabricator.wikimedia.org/T248391 (10dds) I don't think I have the required privileges to do the change. I can provide any other help needed. [07:33:39] (03CR) 10jerkins-bot: [V: 04-1] WIP: Importer for StackExchange posts [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/593884 (https://phabricator.wikimedia.org/T251662) (owner: 10Physikerwelt) [07:43:38] 10Wikimedia-Site-requests: Update the el.wikiversity.org main logo to the correct one - https://phabricator.wikimedia.org/T248391 (10Aklapper) Putting a patch for review into Gerrit requires no privileges at all - anyone could do that by following https://www.mediawiki.org/wiki/Gerrit/Tutorial :) [07:47:48] 10Phabricator: MediaWiki links in Phabricator - https://phabricator.wikimedia.org/T251657 (10Aklapper) Phabricator supports [Markdown](https://en.wikipedia.org/wiki/Markdown), which is less broken than MediaWiki's wiki markup (which has no proper definition anyway). See https://www.mediawiki.org/wiki/Phabricator... [07:52:10] 10Phabricator: MediaWiki links in Phabricator - https://phabricator.wikimedia.org/T251657 (10Mainframe98) >>! In T251657#6101900, @Aklapper wrote: > Phabricator supports [Markdown](https://en.wikipedia.org/wiki/Markdown), which is less broken than MediaWiki's wiki markup (which has no proper definition anyway).... [07:56:11] 10MediaWiki-General, 10Core Platform Team, 10Documentation, 10Patch-For-Review: Explain how to use Namespaces in Extensions and its relation to wgAutoloadClasses - https://phabricator.wikimedia.org/T251662 (10Aklapper) [07:57:00] 10Wiktionary: Disable auto-capitalization on mobile Wiktionary search bar - https://phabricator.wikimedia.org/T251664 (10Betseg) [07:57:56] 10Wiktionary: Disable auto-capitalization on mobile Wiktionary search bar - https://phabricator.wikimedia.org/T251664 (10Betseg) p:05Triage→03Low [07:58:43] 10Wiktionary: Disable auto-capitalization on mobile Wiktionary search bar - https://phabricator.wikimedia.org/T251664 (10Betseg) [07:59:03] 10MediaWiki-Revision-deletion: Last deleted revision shows undefined when edits are oversighted - https://phabricator.wikimedia.org/T251630 (10Aklapper) @Dreamy_Jazz: Heh, no problem. Glad you found the reason! :) [08:00:17] 10MobileFrontend, 10Wiktionary: Disable auto-capitalization on mobile Wiktionary search bar - https://phabricator.wikimedia.org/T251664 (10Nemo_bis) [08:02:53] (03CR) 10Raimond Spekking: "i18n review" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/565462 (https://phabricator.wikimedia.org/T248527) (owner: 10Ppchelko) [08:05:05] 10MediaWiki-General, 10Epic, 10Technical-Debt: Aim for workflow equivalence for MediaWiki on desktop and mobile web - https://phabricator.wikimedia.org/T158181 (10Nemo_bis) [08:05:35] 10MediaWiki-General, 10Epic, 10Technical-Debt: Aim for workflow equivalence for MediaWiki on desktop and mobile web - https://phabricator.wikimedia.org/T158181 (10Nemo_bis) [08:05:36] 10MobileFrontend, 10Wiktionary: Disable auto-capitalization on mobile Wiktionary search bar - https://phabricator.wikimedia.org/T251664 (10Nemo_bis) [08:09:47] (03PS2) 10Physikerwelt: WIP: Importer for StackExchange posts [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/593884 (https://phabricator.wikimedia.org/T251662) [08:19:59] 10MediaWiki-General, 10Core Platform Team, 10Documentation, 10Patch-For-Review: Explain how to use Namespaces in Extensions and its relation to wgAutoloadClasses - https://phabricator.wikimedia.org/T251662 (10Nikerabbit) I think it's better to use extension.json for defining the autoloader for namespaces:... [08:29:32] 10MediaWiki-extensions-Other, 10Technical-Debt, 10User-Nikerabbit: Termbank extension uses deprecated(/removed) LinkBegin hook - https://phabricator.wikimedia.org/T251665 (10Aklapper) This task should be filed under https://github.com/Nikerabbit/mediawiki-extensions-Termbank/issues instead? :) [08:30:12] 10Phabricator: MediaWiki links in Phabricator - https://phabricator.wikimedia.org/T251657 (10Aklapper) Whoops - you are right, thanks! :) [08:41:36] (03PS1) 10Ammarpad: Remove support for setting IP addresses in the keys of $wgProxyList [core] - 10https://gerrit.wikimedia.org/r/593886 (https://phabricator.wikimedia.org/T232864) [08:48:32] 10Wikimedia-Site-requests: Update the el.wikiversity.org main logo to the correct one - https://phabricator.wikimedia.org/T248391 (10QEDK) >>! In T248391#6101876, @dds wrote: > I don't think I have the required privileges to do the change. I can provide any other help needed. @dds If you get the patch out, I'll... [08:54:17] 10MediaWiki-Page-editing, 10VisualEditor: Show me both editor tabs - https://phabricator.wikimedia.org/T251645 (10Aklapper) 05Open→03Declined User get initially asked which editor they would like to use. Quoting T132760#2210892: > you can change this in your preferences. Go to `Special:Preferences#mw-prefs... [08:56:21] 10MediaWiki-General, 10MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), 10MW-1.35-release, 10Patch-For-Review, 10Technical-Debt (Deprecation process): Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release - https://phabricator.wikimedia.org/T232864 (10Ammarpad) [08:57:04] (03CR) 10jerkins-bot: [V: 04-1] Remove support for setting IP addresses in the keys of $wgProxyList [core] - 10https://gerrit.wikimedia.org/r/593886 (https://phabricator.wikimedia.org/T232864) (owner: 10Ammarpad) [08:58:54] 10MobileFrontend, 10Wiktionary: Disable auto-capitalization on mobile Wiktionary search bar - https://phabricator.wikimedia.org/T251664 (10Aklapper) Hi @Betseg, thanks for taking the time to report this and welcome to Wikimedia Phabricator! Do you [plan to work on fixing this task](https://www.mediawiki.org/wi... [09:01:23] (03PS2) 10Ammarpad: Remove support for setting IP addresses in the keys of $wgProxyList [core] - 10https://gerrit.wikimedia.org/r/593886 (https://phabricator.wikimedia.org/T232864) [09:04:38] (03PS2) 10Awight: Disable ReferencePreviews when gadgets conflict [extensions/Popups] - 10https://gerrit.wikimedia.org/r/593340 (https://phabricator.wikimedia.org/T234204) [09:05:04] (03CR) 10Awight: "PS 2: Now with configurable gadget names :-)" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/593340 (https://phabricator.wikimedia.org/T234204) (owner: 10Awight) [09:06:22] (03CR) 10jerkins-bot: [V: 04-1] Disable ReferencePreviews when gadgets conflict [extensions/Popups] - 10https://gerrit.wikimedia.org/r/593340 (https://phabricator.wikimedia.org/T234204) (owner: 10Awight) [09:08:33] (03PS3) 10Awight: Disable ReferencePreviews when gadgets conflict [extensions/Popups] - 10https://gerrit.wikimedia.org/r/593340 (https://phabricator.wikimedia.org/T234204) [09:10:07] 10DiscussionTools, 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.27; 2020-04-07): Enable DiscussionTools on pages where `__NEWSECTIONLINK__` is present - https://phabricator.wikimedia.org/T245890 (10Samat) > And just to be sure, by saying, //"I haven't seen any problem... [09:10:36] (03CR) 10jerkins-bot: [V: 04-1] Disable ReferencePreviews when gadgets conflict [extensions/Popups] - 10https://gerrit.wikimedia.org/r/593340 (https://phabricator.wikimedia.org/T234204) (owner: 10Awight) [09:20:41] (03PS4) 10Awight: Disable ReferencePreviews when gadgets conflict [extensions/Popups] - 10https://gerrit.wikimedia.org/r/593340 (https://phabricator.wikimedia.org/T234204) [09:25:15] (03CR) 10jerkins-bot: [V: 04-1] Disable ReferencePreviews when gadgets conflict [extensions/Popups] - 10https://gerrit.wikimedia.org/r/593340 (https://phabricator.wikimedia.org/T234204) (owner: 10Awight) [09:26:19] (03CR) 10Awight: "Last error seems to be an npm version mismatch, I just need to rebuild with an older npm." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/593340 (https://phabricator.wikimedia.org/T234204) (owner: 10Awight) [09:36:18] 10MediaWiki-extensions-Other, 10Technical-Debt, 10User-Nikerabbit: Termbank extension uses deprecated(/removed) LinkBegin hook - https://phabricator.wikimedia.org/T251665 (10Nikerabbit) I prefer one place to track my extension tasks, or do you think this is misuse of Phabricator? [09:43:04] 10MobileFrontend, 10Wiktionary: Disable auto-capitalization on mobile Wiktionary search bar - https://phabricator.wikimedia.org/T251664 (10Betseg) p:05Low→03Triage [09:58:28] 10WikimediaMessages, 10I18n: MediaWiki:Wm-license-gfdl-full-1.2-link (link fix) MediaWiki:Wm-license-gfdl-1.2-and-later (corresponding code) - https://phabricator.wikimedia.org/T250593 (10Ciencia_Al_Poder) Cross-reference: [[ https://www.mediawiki.org/wiki/Topic:Vlbm6rfomwzylg5k | Topic:Vlbm6rfomwzylg5k ]] [10:24:25] 10MediaWiki-General, 10Core Platform Team Workboards (Contractor Workboard), 10MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), 10Patch-For-Review: Cleanup deprecated calls in production - https://phabricator.wikimedia.org/T251278 (10Daimona) >>! In T251278#6101605, @Pchelolo wrote: > except AbuseFilter. There i... [10:25:26] (03PS3) 10Physikerwelt: WIP: Importer for StackExchange posts [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/593884 (https://phabricator.wikimedia.org/T251662) [10:28:05] 10AbuseFilter: Change the abusefilter database index definition - https://phabricator.wikimedia.org/T251613 (10Daimona) a:03Daimona IIRC, Jaime told me something about this a few months ago, but I forgot to follow up on that. I'll do it now. [10:29:31] (03CR) 10Ammarpad: [C: 04-1] Send a message: Default to article creator (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/563238 (https://phabricator.wikimedia.org/T242324) (owner: 10DannyS712) [10:34:07] (03CR) 10Ammarpad: Encase 'actor_id' value in aggregate function (031 comment) [core] - 10https://gerrit.wikimedia.org/r/593742 (https://phabricator.wikimedia.org/T251599) (owner: 10Ammarpad) [10:34:43] 10MediaWiki-Page-Diffs, 10MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), 10Patch-For-Review, 10User-notice: Use monospace font (or editfont preference) for diffs - https://phabricator.wikimedia.org/T250393 (10hgzh) Has this been reverted? dewiki seems to have the proportional font back. In addition, diffs show... [10:34:46] (03PS1) 10D3r1ck01: tests/phpunit: Use `levels` param in dirname() method call [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/593887 [10:39:03] (03CR) 10jerkins-bot: [V: 04-1] WIP: Importer for StackExchange posts [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/593884 (https://phabricator.wikimedia.org/T251662) (owner: 10Physikerwelt) [10:39:14] 10MediaWiki-Page-Diffs, 10MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), 10Patch-For-Review, 10User-notice: Use monospace font (or editfont preference) for diffs - https://phabricator.wikimedia.org/T250393 (10RhinosF1) >>! In T250393#6101981, @hgzh wrote: > Has this been reverted? dewiki seems to have the prop... [10:40:31] 10MediaWiki-Page-Diffs, 10MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), 10Patch-For-Review, 10User-notice: Use monospace font (or editfont preference) for diffs - https://phabricator.wikimedia.org/T250393 (10MBH) I agree with QEDK: this change should get consensus on big wikis or option in preferences to get... [10:58:32] 10DiscussionTools, 10OWC2020, 10Editing-team (Tracking): Prevent DiscussionTools from being enabled on pages they should not be - https://phabricator.wikimedia.org/T249293 (10PerfektesChaos) German Wikipedia does not want that threads in a talk archive might be continued. * Talk archive pages are in the rela... [11:21:26] 10Wikipedia-Android-App-Backlog: Official Wikipedia app on Android shouldn't ignore q tags or CSS for q tags - https://phabricator.wikimedia.org/T251667 (10Thibaut120094) [11:24:58] 10Wikipedia-Android-App-Backlog: Official Wikipedia app on Android shouldn't ignore q tags or CSS for q tags - https://phabricator.wikimedia.org/T251667 (10Thibaut120094) [11:25:22] 10Design, 10Growth-Team, 10Notifications, 10OOUI: Blurred icon lines in OOUI and Notifications repos - https://phabricator.wikimedia.org/T251659 (10Esanders) The icons snap to a 1px grid at 20px. The only way to allow for sharp 1.5× scaling would be to snap everything to a 2px grid. I'm not sure that's wor... [11:25:26] 10Wikipedia-Android-App-Backlog: Official Wikipedia app on Android shouldn't ignore q tags or CSS for q tags - https://phabricator.wikimedia.org/T251667 (10Thibaut120094) [11:27:48] 10MediaWiki-extensions-Other, 10Technical-Debt, 10User-Nikerabbit: Termbank extension uses deprecated(/removed) LinkBegin hook - https://phabricator.wikimedia.org/T251665 (10Aklapper) Nah, it just confuses me when projects have more than one place where they list their tickets, because of potential duplicati... [11:28:27] 10MediaWiki-Configuration, 10Patch-For-Review: Allow license-name to take an array of SPDX identifier strings - https://phabricator.wikimedia.org/T251642 (10Reedy) >>! In T251642#6101868, @Nikerabbit wrote: > Seems redundant with the inline syntax: https://spdx.org/ids-how Curious. If that’s the case, does MW... [11:29:12] 10Design, 10UI-Standardization, 10MinervaNeue, 10Patch-For-Review, 10Readers-Web-Backlog (Design): No page search result features wrong icon - https://phabricator.wikimedia.org/T208184 (10Esanders) The screenshot in the description does not show search results, but a link to perform the search action. [11:29:24] 10MediaWiki-Documentation, 10Documentation, 10patch-welcome: Move Help:Preferences from Meta to Mediawiki.org, update it and mark it for translation - https://phabricator.wikimedia.org/T181379 (10Aklapper) a:05Areefa→03None @Areefa: No reply, hence I am resetting the assignee of this task because there h... [11:29:59] 10Editing-team (Tracking), 10OWC2020 (OWC2020 Replying 1.0): Add support for extensions within indented comments - https://phabricator.wikimedia.org/T251633 (10Esanders) Will discuss this next Tuesday, hopefully get some input from @cscott [11:33:28] 10Monumental: Internal server error at login - https://phabricator.wikimedia.org/T251668 (10ESM) [11:34:55] (03Abandoned) 10Reedy: [WIP] registration: Allow arrays for license-name [core] - 10https://gerrit.wikimedia.org/r/593813 (https://phabricator.wikimedia.org/T251642) (owner: 10Reedy) [11:35:35] 10MediaWiki-Configuration, 10Patch-For-Review: Allow license-name to take an array of SPDX identifier strings - https://phabricator.wikimedia.org/T251642 (10Reedy) >>! In T251642#6102021, @Reedy wrote: >>>! In T251642#6101868, @Nikerabbit wrote: >> Seems redundant with the inline syntax: https://spdx.org/ids-h... [11:39:07] 10MediaWiki-Configuration: Improve license-name support of SPDX license expressions - https://phabricator.wikimedia.org/T251642 (10Reedy) [11:39:57] 10DiscussionTools, 10OWC2020, 10Editing-team (Tracking): Change URL of Reply tool's in-context feedback link - https://phabricator.wikimedia.org/T249295 (10Esanders) Is the idea here that after some time we will remove all the customised feedback links and direct everyone to mediawiki.org? [11:45:05] 10MediaWiki-extensions-LiquidThreads, 10Core Platform Team Workboards (Contractor Workboard), 10Patch-For-Review: Call Threads::withRoot with WikiPage argument - https://phabricator.wikimedia.org/T251360 (10Art-Baltai) [11:46:30] (03PS1) 10Reedy: tests: Add test file to test SPDX license expressions [core] - 10https://gerrit.wikimedia.org/r/593895 (https://phabricator.wikimedia.org/T251642) [11:48:42] 10MediaWiki-Page-Diffs, 10MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), 10Patch-For-Review, 10User-notice: Use monospace font (or editfont preference) for diffs - https://phabricator.wikimedia.org/T250393 (10Dvorapa) On cswiki this seems as reverted currently. I personally agree with the change, but better re... [11:49:26] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Official Wikipedia app on Android shouldn't ignore q tags or CSS for q tags - https://phabricator.wikimedia.org/T251667 (10Thibaut120094) [11:50:34] (03PS1) 10Esanders: Link the "Reply" tag to mediawiki.org [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/593896 (https://phabricator.wikimedia.org/T250520) [11:54:24] 10Magnus Sälgö: en:Wikipedia <-> Europeana Entity has problem with the quality of Europeana Linked data - https://phabricator.wikimedia.org/T243764 (10Salgo60) @VladimirAlexiev we have this item now T251225 to fink how we progress... [11:57:42] 10Language-Team, 10UniversalLanguageSelector, 10Software-Licensing: Clarify license of Universal Language Selector - https://phabricator.wikimedia.org/T251643 (10Reedy) >>! In T251643#6101869, @Nikerabbit wrote: > Looking at https://spdx.org/ids-how - I think the question to answer would it be `AND` or `OR`... [11:58:56] 10MediaWiki-Page-Diffs, 10MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), 10Patch-For-Review, 10User-notice: Use monospace font (or editfont preference) for diffs - https://phabricator.wikimedia.org/T250393 (10QEDK) >>! In T250393#6102049, @Dvorapa wrote: > On cswiki this seems as reverted currently. I personal... [11:59:45] (03PS1) 10Reedy: Update license-name to include OR MIT [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/593898 (https://phabricator.wikimedia.org/T251643) [12:00:39] 10Language-Team, 10UniversalLanguageSelector, 10Patch-For-Review, 10Software-Licensing: Clarify license of Universal Language Selector - https://phabricator.wikimedia.org/T251643 (10Reedy) Patch not necessarily to be merged just yet... but gives something to play with for T251642 [12:02:12] 10MediaWiki-Page-Diffs, 10MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), 10Patch-For-Review, 10User-notice: Use monospace font (or editfont preference) for diffs - https://phabricator.wikimedia.org/T250393 (10Dvorapa) I talk about the monospace font used in diffs yesterday: It was a different monospace font fr... [12:04:33] 10MediaWiki-extensions-OATHAuth, 10Software-Licensing: WebAuthn COPYING file incorrect - https://phabricator.wikimedia.org/T251670 (10Reedy) [12:06:57] 10Language-Team, 10UniversalLanguageSelector, 10Patch-For-Review, 10Software-Licensing: Clarify license of Universal Language Selector - https://phabricator.wikimedia.org/T251643 (10Reedy) Though, as far as MW is concerned, it just links the lot, so that's fine {F31791725 size=full} Just need to do somet... [12:08:37] 10Discovery-Search, 10GeoData: Geosearch doesn't work for Iceland IS wiki - https://phabricator.wikimedia.org/T251671 (10Karlth) [12:08:37] (03PS1) 10Reedy: Call static function statically [core] - 10https://gerrit.wikimedia.org/r/593899 [12:08:44] 04(no projects): q tags shouldn't be stripped in TOC headings - https://phabricator.wikimedia.org/T251672 (10Thibaut120094) [12:21:21] 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10ConfirmEdit (CAPTCHA extension), 10Language-Team, and 8 others: Missing detailed license info on enwiki - https://phabricator.wikimedia.org/T234086 (10Tobi_WMDE_SW) [12:22:56] (03PS1) 10Reedy: Update AUTHOR/CREDITS/COPYING/LICENSE comments to match expected case [core] - 10https://gerrit.wikimedia.org/r/593900 [12:22:58] (03PS1) 10Reedy: [WIP] Add SpecialVersion::getExtLicenseFileNames() [core] - 10https://gerrit.wikimedia.org/r/593901 [12:29:36] 10MediaWiki-General, 10MediaWiki-Parser: q tags shouldn't be stripped in TOC headings - https://phabricator.wikimedia.org/T251672 (10RhinosF1) [12:32:56] (03PS2) 10Reedy: Allow extensions (et al) to have multiple LICENSE/COPYING files [core] - 10https://gerrit.wikimedia.org/r/593901 (https://phabricator.wikimedia.org/T251642) [12:34:50] 10MediaWiki-Configuration, 10Patch-For-Review: Improve license-name support of SPDX license expressions - https://phabricator.wikimedia.org/T251642 (10Reedy) >>! In T251642#6102116, @gerritbot wrote: > Change 593901 had a related patch set uploaded (by Reedy; owner: Reedy): > [mediawiki/core@master] Allow exte... [12:37:08] 10Quibble: Don't try to start a redundant ChromeDriver - https://phabricator.wikimedia.org/T251274 (10hashar) Quibble runs chromedriver through a context manager and itt invokes it only once before running `npm run selenium-test` against each repositories. It seems the context manager properly stops the chromedr... [12:40:18] (03PS3) 10Reedy: Allow extensions (et al) to have multiple LICENSE/COPYING files [core] - 10https://gerrit.wikimedia.org/r/593901 (https://phabricator.wikimedia.org/T251642) [12:42:38] (03CR) 10Reedy: Allow extensions (et al) to have multiple LICENSE/COPYING files (033 comments) [core] - 10https://gerrit.wikimedia.org/r/593901 (https://phabricator.wikimedia.org/T251642) (owner: 10Reedy) [12:44:52] 10Small-Wiki-Toolkits, 10Developer-Advocacy (Apr-Jun 2020), 10Goal: Small Wiki Toolkits: How-to guidelines and/or potential recommendations for Gadgets - https://phabricator.wikimedia.org/T246181 (10Aklapper) @srishakatux: Thanks. I think in some cases the wording is/was not clear enough. "It should not be c... [12:46:48] 10DiscussionTools, 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.27; 2020-04-07): Enable DiscussionTools on pages where `__NEWSECTIONLINK__` is present - https://phabricator.wikimedia.org/T245890 (10Esanders) >>! In T245890#6101967, @Samat wrote: > The only thing came i... [12:49:06] 10MediaWiki-Parser: q tags shouldn't be stripped in TOC headings - https://phabricator.wikimedia.org/T251672 (10Aklapper) [12:49:36] (03PS4) 10Reedy: Allow extensions (et al) to have multiple LICENSE/COPYING files [core] - 10https://gerrit.wikimedia.org/r/593901 (https://phabricator.wikimedia.org/T251642) [12:50:02] 10Discovery-Search, 10GeoData: Geosearch doesn't work for Icelandic Wikipedia; same query works on English Wikipedia - https://phabricator.wikimedia.org/T251671 (10Aklapper) [12:50:34] (03CR) 10Esanders: [C: 04-1] Introduce table widget, upstreamed from the Graph extension (031 comment) [core] - 10https://gerrit.wikimedia.org/r/593861 (https://phabricator.wikimedia.org/T251611) (owner: 10Tchanders) [12:52:44] (03PS1) 10Reedy: Add GPL-3.0 license [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/593903 (https://phabricator.wikimedia.org/T251670) [12:53:57] (03PS1) 10MaxSem: ServiceWiring: Don't use wfShellExec, inject CommandFactory [core] - 10https://gerrit.wikimedia.org/r/593904 [12:54:00] (03PS1) 10MaxSem: JobQueue: Don't construct GlobalIdGenerator manually [core] - 10https://gerrit.wikimedia.org/r/593905 [12:54:01] (03CR) 10Esanders: [C: 04-1] "Looks good otherwise" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/593861 (https://phabricator.wikimedia.org/T251611) (owner: 10Tchanders) [12:58:12] 10MediaWiki-Special-pages, 10Patch-For-Review: Make Special:Version/License support multiple license files in a repo - https://phabricator.wikimedia.org/T251642 (10Reedy) [13:00:44] (03PS2) 10Esanders: eslint: Remove upstreamed no-console rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/593828 [13:00:46] (03PS3) 10Esanders: eslint: Enable class-doc rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/593829 [13:05:59] (03PS1) 10Daimona Eaytoy: Give MySQL indexes explicit names, create them outside of CREATE TABLE [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593906 (https://phabricator.wikimedia.org/T251613) [13:06:15] (03CR) 10Reedy: Allow extensions (et al) to have multiple LICENSE/COPYING files (031 comment) [core] - 10https://gerrit.wikimedia.org/r/593901 (https://phabricator.wikimedia.org/T251642) (owner: 10Reedy) [13:07:58] (03CR) 10jerkins-bot: [V: 04-1] Give MySQL indexes explicit names, create them outside of CREATE TABLE [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593906 (https://phabricator.wikimedia.org/T251613) (owner: 10Daimona Eaytoy) [13:09:08] 10AbuseFilter, 10Patch-For-Review: Change the abusefilter database index definition - https://phabricator.wikimedia.org/T251613 (10Daimona) I think the patch above should be enough for indexes. Merging the MySQL schema with SQLite's is not currently possible, I think, because of incompatible types. In fact, th... [13:11:35] (03PS1) 10Esanders: eslint: Fix valid-jsdoc rule [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/593908 [13:11:45] 10AbuseFilter, 10Patch-For-Review: Change the abusefilter database index definition - https://phabricator.wikimedia.org/T251613 (10Reedy) >>! In T251613#6102181, @Daimona wrote: > I think the patch above should be enough for indexes. Merging the MySQL schema with SQLite's is not currently possible, I think, be... [13:13:16] (03CR) 10Reedy: [C: 04-1] "patch-rename-indexes.sql doesn't seem to rename all the indexes?" (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593906 (https://phabricator.wikimedia.org/T251613) (owner: 10Daimona Eaytoy) [13:13:34] 10AbuseFilter, 10Patch-For-Review: Change the abusefilter database index definition - https://phabricator.wikimedia.org/T251613 (10Daimona) >>! In T251613#6102182, @Reedy wrote: >>>! In T251613#6102181, @Daimona wrote: >> I think the patch above should be enough for indexes. Merging the MySQL schema with SQLit... [13:16:15] 10Wikimedia-Site-requests, 10Patch-For-Review: Restore the "reviewer" group for fawiki - https://phabricator.wikimedia.org/T249643 (10Urbanecm) >>! In T249643#6097751, @Huji wrote: > Thanks for the explanation. So should I work on scheduling this? Or make myself available for a particular SWAT window? The bes... [13:17:07] 10AbuseFilter, 10Patch-For-Review: Change the abusefilter database index definition - https://phabricator.wikimedia.org/T251613 (10Reedy) >>! In T251613#6102184, @Daimona wrote: >>>! In T251613#6102182, @Reedy wrote: >>>>! In T251613#6102181, @Daimona wrote: >>> I think the patch above should be enough for ind... [13:20:58] (03PS2) 10Reedy: Call static functions statically [core] - 10https://gerrit.wikimedia.org/r/593899 [13:21:49] 10Technical-blog-posts, 10Developer-Advocacy (Apr-Jun 2020): Write blog post to share the results of Google Code-in 2019 - https://phabricator.wikimedia.org/T244540 (10Majavah) 05Open→03Resolved This [[ https://techblog.wikimedia.org/2020/04/30/google-code-in-2019-the-next-generation-of-technologists-contr... [13:21:51] 10Developer-Advocacy (Jan-Mar 2020), 10Epic, 10Goal: Organize and coordinate Wikimedia's participation in Google Code-In 2019 - https://phabricator.wikimedia.org/T233899 (10Majavah) [13:27:14] (03PS1) 10Esanders: eslint: Fix selenium config [extensions/Popups] - 10https://gerrit.wikimedia.org/r/593909 [13:30:24] 10Wikimedia-Site-requests, 10Patch-For-Review: Restore the "reviewer" group for fawiki - https://phabricator.wikimedia.org/T249643 (10QEDK) >>! In T249643#6102186, @Urbanecm wrote: >>>! In T249643#6097751, @Huji wrote: >> Thanks for the explanation. So should I work on scheduling this? Or make myself available... [13:33:23] 10Wikimedia-Site-requests, 10Patch-For-Review: Restore the "reviewer" group for fawiki - https://phabricator.wikimedia.org/T249643 (10Urbanecm) >>! In T249643#6102193, @QEDK wrote: > Is is possible to list on the Deployment page when the train is blocked, I scheduled patches last time (and was on IRC) only to... [13:36:01] 04(no projects): Allow visual editor users to name refs something useful - https://phabricator.wikimedia.org/T251677 (10Valereee) [13:37:57] (03PS2) 10Daimona Eaytoy: Give MySQL indexes explicit names, create them outside of CREATE TABLE [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593906 (https://phabricator.wikimedia.org/T251613) [13:38:18] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: HistoryTabTest complains about missing view with ID page_list_header_text - https://phabricator.wikimedia.org/T251678 (10isirasen) [13:38:42] (03CR) 10Daimona Eaytoy: ">" (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593906 (https://phabricator.wikimedia.org/T251613) (owner: 10Daimona Eaytoy) [13:39:35] (03CR) 10jerkins-bot: [V: 04-1] Give MySQL indexes explicit names, create them outside of CREATE TABLE [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593906 (https://phabricator.wikimedia.org/T251613) (owner: 10Daimona Eaytoy) [13:42:32] 10AbuseFilter, 10Patch-For-Review: Change the abusefilter database index definition - https://phabricator.wikimedia.org/T251613 (10Daimona) >>! In T251613#6102187, @Reedy wrote: > Potentially... Should be easy enough to test :) Hmmm I don't have SQLite installed, and too lazy to install it right now. Do we h... [13:43:38] (03PS1) 10Paladox: Ignore actor ids that equal 0 [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/593911 [13:48:58] 10Accessibility, 10Lexicographical data, 10Wikidata, 10MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Have the focus on field when adding new element on Sense - https://phabricator.wikimedia.org/T203461 (10Lydia_Pintscher) 05Open→03Resolved \o/ [13:49:03] 10Design, 10Lexicographical data, 10WMDE-Design, 10Wikidata, 10MW-1.35-notes (1.35.0-wmf.31; 2020-05-05): Improve keyboard navigation on Lexeme pages - https://phabricator.wikimedia.org/T201588 (10Lydia_Pintscher) [13:53:12] 10MediaWiki-Page-Diffs, 10MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), 10Patch-For-Review, 10User-notice: Use monospace font (or editfont preference) for diffs - https://phabricator.wikimedia.org/T250393 (10matej_suchanek) While this seems fine for source code based content, I'm not sure about diffs over #Wi... [13:53:29] (03CR) 10Thiemo Kreuz (WMDE): GlobalFunctions: Fix wfPercent() with negative accuracy (031 comment) [core] - 10https://gerrit.wikimedia.org/r/593068 (https://phabricator.wikimedia.org/T248925) (owner: 10MaxSem) [13:53:31] 10Metrolook: autofocus bug with MW Page Forms popups - https://phabricator.wikimedia.org/T251679 (10Revansx) [13:54:24] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] eslint: Remove upstreamed no-console rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/593828 (owner: 10Esanders) [13:54:54] 10Metrolook: autofocus bug with MW Page Forms popups - https://phabricator.wikimedia.org/T251679 (10Revansx) [14:00:56] 10Wikimedia-Site-requests, 10Patch-For-Review: Restore the "reviewer" group for fawiki - https://phabricator.wikimedia.org/T249643 (10Huji) >>! In T249643#6102186, @Urbanecm wrote: >>>! In T249643#6097751, @Huji wrote: >> Thanks for the explanation. So should I work on scheduling this? Or make myself available... [14:01:31] 10MediaWiki-Internationalization: Support for pseudo-language "mul" to indicate multilingual content - https://phabricator.wikimedia.org/T43807 (10Lydia_Pintscher) It seems to me that we have different things mixed in here that should probably be separate: 1) support for a whole wiki to be set to "mul" 2) suppo... [14:01:49] (03PS2) 10Paladox: Ignore actor ids that equal 0 [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/593911 [14:02:13] (03CR) 10Ppchelko: [C: 04-2] "We have just deprecated calling it with WikiPage in 1.35, can't do this until 1.36" [core] - 10https://gerrit.wikimedia.org/r/588534 (https://phabricator.wikimedia.org/T249146) (owner: 10Art-Baltai) [14:02:52] (03CR) 10Ppchelko: [C: 04-2] "We have just deprecated this in 1.35, can't do until 1.36" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/588517 (https://phabricator.wikimedia.org/T249146) (owner: 10Art-Baltai) [14:04:08] 10MediaWiki-Special-pages, 10Patch-For-Review: Contributions appearing out of order - https://phabricator.wikimedia.org/T46841 (10Lydia_Pintscher) My understanding is that this is a general MediaWiki problem and we're only seeing it more on Wikidata because of the high edit frequency. Is that correct? [14:05:27] 10MediaWiki-extensions-WikibaseClient, 10Product-Infrastructure-Team-Backlog, 10Wikidata, 10Wikidata-Campsite: Track implicit use of non-overridden wikidata description - https://phabricator.wikimedia.org/T191831 (10Lydia_Pintscher) [14:07:29] (03Merged) 10jenkins-bot: eslint: Remove upstreamed no-console rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/593828 (owner: 10Esanders) [14:08:34] 10MediaWiki-General, 10Core Platform Team Workboards (Initiatives), 10MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), 10Patch-For-Review: Complete WikiPage/Article split and deprecate Page interface - https://phabricator.wikimedia.org/T239975 (10Pchelolo) [14:11:18] 10DiscussionTools, 10OWC2020, 10Editing-team (Tracking): Prevent DiscussionTools from being enabled on pages they should not be - https://phabricator.wikimedia.org/T249293 (10Samat) @PerfektesChaos: good example. The Hungarian Wikipedia uses the same practice. [14:11:43] (03CR) 10Reedy: [C: 04-1] "Looks like the namings might not be as expected..." (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593906 (https://phabricator.wikimedia.org/T251613) (owner: 10Daimona Eaytoy) [14:12:48] 10MediaWiki-General, 10Core Platform Team Workboards (Initiatives), 10MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), 10Patch-For-Review: Complete WikiPage/Article split and deprecate Page interface - https://phabricator.wikimedia.org/T239975 (10Pchelolo) [14:13:34] 10DiscussionTools, 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.27; 2020-04-07): Enable DiscussionTools on pages where `__NEWSECTIONLINK__` is present - https://phabricator.wikimedia.org/T245890 (10Samat) > That will be part of our new discussion tool which we have sta... [14:15:29] (03PS3) 10Daimona Eaytoy: Give MySQL indexes explicit names, create them outside of CREATE TABLE [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593906 (https://phabricator.wikimedia.org/T251613) [14:16:46] (03CR) 10Daimona Eaytoy: ">" (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593906 (https://phabricator.wikimedia.org/T251613) (owner: 10Daimona Eaytoy) [14:17:25] (03CR) 10jerkins-bot: [V: 04-1] Give MySQL indexes explicit names, create them outside of CREATE TABLE [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593906 (https://phabricator.wikimedia.org/T251613) (owner: 10Daimona Eaytoy) [14:20:05] 10AbuseFilter, 10Patch-For-Review: Change the abusefilter database index definition - https://phabricator.wikimedia.org/T251613 (10Ladsgroup) There's a CI test in core which gets ran in gate-and-submit but I don't know if it's being run in Abusefilter [14:22:26] (03PS3) 10Paladox: Ignore actor ids that equal 0 [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/593911 [14:23:07] (03CR) 10jerkins-bot: [V: 04-1] Ignore actor ids that equal 0 [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/593911 (owner: 10Paladox) [14:24:08] (03PS4) 10Paladox: Ignore actor ids that equal 0 [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/593911 [14:33:58] (03PS1) 10Reedy: Remove SQLite specific files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593912 (https://phabricator.wikimedia.org/T251613) [14:34:33] 10AbuseFilter, 10Patch-For-Review: Change the abusefilter database index definition - https://phabricator.wikimedia.org/T251613 (10Reedy) ^ One way to find out. Though, that really needs to be ontop of Daimona's patch to have any chance of passing... :D [14:34:51] (03CR) 10Ppchelko: [C: 04-1] "Here we can drop pre-1.35 compatibility too. As a rule of thumb, if an extension has a compatibility policy 'release branch' listed on ext" [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/589644 (https://phabricator.wikimedia.org/T249384) (owner: 10DannyS712) [14:35:36] (03CR) 10jerkins-bot: [V: 04-1] Remove SQLite specific files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593912 (https://phabricator.wikimedia.org/T251613) (owner: 10Reedy) [14:37:33] (03PS1) 10Bmansurov: Update team member, banner, and publications [research/landing-page] - 10https://gerrit.wikimedia.org/r/593913 [14:38:38] (03CR) 10Bmansurov: [C: 03+2] Update team member, banner, and publications [research/landing-page] - 10https://gerrit.wikimedia.org/r/593913 (owner: 10Bmansurov) [14:38:53] (03CR) 10Bmansurov: [V: 03+2 C: 03+2] Update team member, banner, and publications [research/landing-page] - 10https://gerrit.wikimedia.org/r/593913 (owner: 10Bmansurov) [14:38:58] 10AbuseFilter, 10Patch-For-Review: Change the abusefilter database index definition - https://phabricator.wikimedia.org/T251613 (10Reedy) It looks like `db_patches/patch-fix-indexes.sql` is doing the reverse of the request of this task [14:39:55] (03PS2) 10Reedy: Remove smoe SQLite specific files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593912 (https://phabricator.wikimedia.org/T251613) [14:41:22] (03CR) 10jerkins-bot: [V: 04-1] Remove smoe SQLite specific files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593912 (https://phabricator.wikimedia.org/T251613) (owner: 10Reedy) [14:41:24] (03CR) 10Reedy: "abusefilter.tables.sql will need some poking" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593912 (https://phabricator.wikimedia.org/T251613) (owner: 10Reedy) [14:42:54] (03PS3) 10Reedy: Remove some SQLite specific files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593912 (https://phabricator.wikimedia.org/T251613) [14:43:16] (03CR) 10Reedy: "God the indexes in here are a mess" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593912 (https://phabricator.wikimedia.org/T251613) (owner: 10Reedy) [14:43:18] (03PS5) 10Daimona Eaytoy: [WIP] Pass-by-ref [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/592974 (https://phabricator.wikimedia.org/T250689) [14:44:19] (03CR) 10jerkins-bot: [V: 04-1] Remove some SQLite specific files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593912 (https://phabricator.wikimedia.org/T251613) (owner: 10Reedy) [14:44:34] (03PS4) 10Reedy: Remove some SQLite specific files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593912 (https://phabricator.wikimedia.org/T251613) [14:44:46] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Pass-by-ref [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/592974 (https://phabricator.wikimedia.org/T250689) (owner: 10Daimona Eaytoy) [14:45:58] (03CR) 10jerkins-bot: [V: 04-1] Remove some SQLite specific files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593912 (https://phabricator.wikimedia.org/T251613) (owner: 10Reedy) [14:46:25] (03CR) 10Reedy: Give MySQL indexes explicit names, create them outside of CREATE TABLE (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593906 (https://phabricator.wikimedia.org/T251613) (owner: 10Daimona Eaytoy) [14:47:55] (03PS5) 10Reedy: Remove some SQLite specific files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593912 (https://phabricator.wikimedia.org/T251613) [14:48:25] 10AbuseFilter, 10Patch-For-Review: Change the abusefilter database index definition - https://phabricator.wikimedia.org/T251613 (10Daimona) >>! In T251613#6102289, @Reedy wrote: > It looks like `db_patches/patch-fix-indexes.sql` is doing the reverse of the request of this task I think it actually tried to do... [14:48:41] (03CR) 10Daimona Eaytoy: Give MySQL indexes explicit names, create them outside of CREATE TABLE (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593906 (https://phabricator.wikimedia.org/T251613) (owner: 10Daimona Eaytoy) [14:49:24] (03PS4) 10Daimona Eaytoy: Give MySQL indexes explicit names, create them outside of CREATE TABLE [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593906 (https://phabricator.wikimedia.org/T251613) [14:51:02] (03CR) 10jerkins-bot: [V: 04-1] Give MySQL indexes explicit names, create them outside of CREATE TABLE [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593906 (https://phabricator.wikimedia.org/T251613) (owner: 10Daimona Eaytoy) [14:53:04] (03PS9) 10Daimona Eaytoy: Actually apply patch-afl_change_deleted_patrolled. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/558199 (https://phabricator.wikimedia.org/T240895) (owner: 10Alexia) [14:54:43] (03PS5) 10Daimona Eaytoy: Give MySQL indexes explicit names, create them outside of CREATE TABLE [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593906 (https://phabricator.wikimedia.org/T251613) [14:56:23] (03PS5) 10Paladox: Ignore actor ids that equal 0 [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/593911 [14:58:50] 10MediaWiki-extensions-WikibaseRepository, 10MediaWiki-extensions-WikibaseView, 10Wikidata, 10Wikidata-Campsite, 10Wikidata-Gadgets: Add another "Add statement" button on top to ensure consistent position - https://phabricator.wikimedia.org/T142082 (10Lydia_Pintscher) [14:59:05] 10MediaWiki-extensions-WikibaseRepository, 10MediaWiki-extensions-WikibaseView, 10Wikidata, 10Wikidata-Campsite, 10Wikidata-Gadgets: Add another "Add statement" button on top to ensure consistent position - https://phabricator.wikimedia.org/T142082 (10Lydia_Pintscher) p:05Low→03Medium [15:00:07] (03PS6) 10Paladox: Ignore user ids that equal 0 [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/593911 [15:18:20] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Campsite: misleading: "Commons link should be well-formed." warning - https://phabricator.wikimedia.org/T251480 (10Lydia_Pintscher) I looked at it and what seems to be happening is that we allow underscores in the input for properties of datat... [15:19:07] (03PS1) 10Paladox: Add a default value to *_actor columns [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/593914 [15:21:11] (03PS2) 10Paladox: Add a default value to *_actor columns [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/593914 [15:28:48] (03CR) 10Jack Phoenix: Ignore user ids that equal 0 (034 comments) [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/593911 (owner: 10Paladox) [15:36:40] (03PS7) 10Paladox: Fix migration script for when actor_id is null [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/593911 [15:37:19] (03CR) 10Paladox: Fix migration script for when actor_id is null (034 comments) [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/593911 (owner: 10Paladox) [15:37:51] (03PS3) 10Paladox: Add a default value to *_actor columns [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/593914 [15:52:55] 10Metrolook: autofocus bug with MW Page Forms popups - https://phabricator.wikimedia.org/T251679 (10Revansx) Even if it is the determination of the Metrolook developers that this is a Page Forms issue, I would be grateful for any simple ways to halt this behavior, even if it is kinda hackish. Thanks! [16:05:25] 10AbuseFilter, 10Patch-For-Review: Change the abusefilter database index definition - https://phabricator.wikimedia.org/T251613 (10Reedy) >>! In T251613#6102290, @Daimona wrote: >>>! In T251613#6102289, @Reedy wrote: >> It looks like `db_patches/patch-fix-indexes.sql` is doing the reverse of the request of thi... [16:07:32] 10Metrolook: autofocus bug with MW Page Forms popups - https://phabricator.wikimedia.org/T251679 (10Revansx) I have isolated the behavior to the following JS code in Metrolook: ` mediawiki/skins/Metrolook/js/fixed-header-scroll-fix.js ` [16:24:09] (03PS4) 10Paladox: Add a default value to *_actor columns [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/593914 [16:24:27] 10MediaWiki-Page-editing: Disable section editing on non current revision - https://phabricator.wikimedia.org/T251680 (10Ammarpad) [16:28:00] (03PS5) 10Paladox: Add a default value to *_actor columns [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/593914 [16:32:07] 10AbuseFilter, 10Patch-For-Review: Change the abusefilter database index definition - https://phabricator.wikimedia.org/T251613 (10Daimona) >>! In T251613#6102307, @Reedy wrote: >>>! In T251613#6102290, @Daimona wrote: >>>>! In T251613#6102289, @Reedy wrote: >>> It looks like `db_patches/patch-fix-indexes.sql`... [16:33:40] 10MediaWiki-Parser, 10Parsing-Team, 10Patch-For-Review: Unexpected PST effect when saving edits to .js pages that were formerly - https://phabricator.wikimedia.org/T236828 (10Krinkle) Tue to the fact that many of these pages have been unmodified for years, for a number of them my edit to the page ha... [16:40:55] (03PS6) 10Niedzielski: resources: add checkbox hack Less and JavaScript [core] - 10https://gerrit.wikimedia.org/r/589692 (https://phabricator.wikimedia.org/T246419) [16:47:25] (03PS6) 10Daimona Eaytoy: [WIP] Pass-by-ref [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/592974 (https://phabricator.wikimedia.org/T250689) [16:48:02] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Pass-by-ref [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/592974 (https://phabricator.wikimedia.org/T250689) (owner: 10Daimona Eaytoy) [16:50:51] (03PS7) 10Daimona Eaytoy: [WIP] Pass-by-ref [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/592974 (https://phabricator.wikimedia.org/T250689) [16:52:08] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Pass-by-ref [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/592974 (https://phabricator.wikimedia.org/T250689) (owner: 10Daimona Eaytoy) [16:56:39] (03PS1) 10Daimona Eaytoy: Split a long method [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/593919 [16:56:46] (03CR) 10jerkins-bot: [V: 04-1] resources: add checkbox hack Less and JavaScript [core] - 10https://gerrit.wikimedia.org/r/589692 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [16:57:29] (03PS8) 10Daimona Eaytoy: [WIP] Pass-by-ref [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/592974 (https://phabricator.wikimedia.org/T250689) [16:59:01] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Pass-by-ref [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/592974 (https://phabricator.wikimedia.org/T250689) (owner: 10Daimona Eaytoy) [16:59:29] (03PS7) 10Niedzielski: resources: add checkbox hack Less and JavaScript [core] - 10https://gerrit.wikimedia.org/r/589692 (https://phabricator.wikimedia.org/T246419) [17:01:27] (03PS28) 10Niedzielski: [feature] add menu button to toggle panel visibility [skins/Vector] - 10https://gerrit.wikimedia.org/r/584694 (https://phabricator.wikimedia.org/T246419) [17:11:51] (03CR) 10jerkins-bot: [V: 04-1] [feature] add menu button to toggle panel visibility [skins/Vector] - 10https://gerrit.wikimedia.org/r/584694 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [17:13:19] (03CR) 10Mooeypoo: "This looks great (just replace VE with MW :) -- also, to note, I think this will be the first OOUI/MW-widget that depends-on and works-wit" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/593861 (https://phabricator.wikimedia.org/T251611) (owner: 10Tchanders) [17:14:00] (03PS29) 10Niedzielski: [feature] add menu button to toggle panel visibility [skins/Vector] - 10https://gerrit.wikimedia.org/r/584694 (https://phabricator.wikimedia.org/T246419) [17:15:18] (03CR) 10jerkins-bot: [V: 04-1] resources: add checkbox hack Less and JavaScript [core] - 10https://gerrit.wikimedia.org/r/589692 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [17:16:20] (03CR) 10ArielGlenn: "> Until then, if the desire is to accurately reflect page protection" [core] - 10https://gerrit.wikimedia.org/r/593668 (https://phabricator.wikimedia.org/T251411) (owner: 10ArielGlenn) [17:17:02] 10Desktop Improvements, 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4): Build collapsible sidebar and sidebar button - https://phabricator.wikimedia.org/T246419 (10Niedzielski) @alexhollender, latest patches are on labs: [[ https://stephen.wmfl... [17:17:44] 10Desktop Improvements, 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4): Build collapsible sidebar and sidebar button - https://phabricator.wikimedia.org/T246419 (10Niedzielski) a:05Niedzielski→03None [17:19:15] (03PS8) 10Niedzielski: resources: add checkbox hack Less and JavaScript [core] - 10https://gerrit.wikimedia.org/r/589692 (https://phabricator.wikimedia.org/T246419) [17:19:21] (03CR) 10jerkins-bot: [V: 04-1] [feature] add menu button to toggle panel visibility [skins/Vector] - 10https://gerrit.wikimedia.org/r/584694 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [17:29:52] 10MediaWiki-Page-editing: Disable section editing on non current revision - https://phabricator.wikimedia.org/T251680 (10Ammarpad) [17:40:23] (03CR) 10Niedzielski: "recheck" [skins/Vector] - 10https://gerrit.wikimedia.org/r/584694 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [17:40:34] (03CR) 10Krinkle: "Neat :) Won't review the internals of this one, other than to note that this should not ship as its own module." [core] - 10https://gerrit.wikimedia.org/r/589692 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [17:41:01] (03PS1) 10Esanders: Fix typo: 'the the' -> 'the' [core] - 10https://gerrit.wikimedia.org/r/593921 [17:43:46] 10Wikimedia-Site-requests, 10Patch-For-Review: Restore the "reviewer" group for fawiki - https://phabricator.wikimedia.org/T249643 (10QEDK) >>! In T249643#6102266, @Huji wrote: >>>! In T249643#6102186, @Urbanecm wrote: >>>>! In T249643#6097751, @Huji wrote: >>> Thanks for the explanation. So should I work on s... [17:55:34] (03PS5) 10Art-Baltai: v1.36 For Action::__construct() use Article instead of Page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/588517 (https://phabricator.wikimedia.org/T249146) [17:55:52] (03PS3) 10Art-Baltai: v1.36 For Action::__construct use Article instead of Page [core] - 10https://gerrit.wikimedia.org/r/588534 (https://phabricator.wikimedia.org/T249146) [17:56:20] (03CR) 10jerkins-bot: [V: 04-1] Fix typo: 'the the' -> 'the' [core] - 10https://gerrit.wikimedia.org/r/593921 (owner: 10Esanders) [17:58:01] (03PS6) 10Art-Baltai: Add pure unit tests for class LinkHolderArray [core] - 10https://gerrit.wikimedia.org/r/588834 (https://phabricator.wikimedia.org/T243747) [17:59:21] (03CR) 10Niedzielski: "> If it is for JS-generated interfaces that only appear after a user interaction (e.g. within a modal or something), then it would seem on" [core] - 10https://gerrit.wikimedia.org/r/589692 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [18:09:42] (03PS30) 10Niedzielski: [feature] add menu button to toggle panel visibility [skins/Vector] - 10https://gerrit.wikimedia.org/r/584694 (https://phabricator.wikimedia.org/T246419) [18:17:44] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/593887 (owner: 10D3r1ck01) [18:23:05] (03CR) 10Krinkle: "This seems to remove use of getMetadataFromCache(). I'm not sure why though. If this is meant to be a replacement or improvement of that, " [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/592305 (owner: 10Aaron Schulz) [18:24:15] (03CR) 10Krinkle: [C: 04-1] GlobalFunctions: Fix wfPercent() with negative accuracy [core] - 10https://gerrit.wikimedia.org/r/593068 (https://phabricator.wikimedia.org/T248925) (owner: 10MaxSem) [18:24:22] (03CR) 10jerkins-bot: [V: 04-1] [feature] add menu button to toggle panel visibility [skins/Vector] - 10https://gerrit.wikimedia.org/r/584694 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [18:27:46] (03PS8) 10Krinkle: [skin] Refactor prepareQuickTemplate [core] - 10https://gerrit.wikimedia.org/r/593326 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [18:27:54] (03PS31) 10Niedzielski: [feature] add menu button to toggle panel visibility [skins/Vector] - 10https://gerrit.wikimedia.org/r/584694 (https://phabricator.wikimedia.org/T246419) [18:28:18] (03PS9) 10Krinkle: skins: Refactor and split up SkinTemplate::prepareQuickTemplate [core] - 10https://gerrit.wikimedia.org/r/593326 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [18:28:21] (03CR) 10Krinkle: [C: 03+2] skins: Refactor and split up SkinTemplate::prepareQuickTemplate [core] - 10https://gerrit.wikimedia.org/r/593326 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [18:28:58] (03CR) 10Krinkle: [C: 04-1] "Still static." [core] - 10https://gerrit.wikimedia.org/r/593040 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [18:29:11] (03CR) 10Krinkle: [C: 03+2] registration: Move SearchMappings to CORE_ATTRIBS from NOT_ATTRIBS [core] - 10https://gerrit.wikimedia.org/r/593582 (https://phabricator.wikimedia.org/T250977) (owner: 10Reedy) [18:29:59] (03CR) 10Krinkle: [C: 03+1] "check php" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593912 (https://phabricator.wikimedia.org/T251613) (owner: 10Reedy) [18:32:08] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/593923 (owner: 10Libraryupgrader) [18:32:11] (03PS4) 10Krinkle: jquery.textSelection: Make jsdoc happier about the @ignore syntax [core] - 10https://gerrit.wikimedia.org/r/588504 (owner: 10Jforrester) [18:32:26] (03PS5) 10Krinkle: jquery.textSelection: Make jsdoc happier about the @ignore syntax [core] - 10https://gerrit.wikimedia.org/r/588504 (owner: 10Jforrester) [18:32:29] (03CR) 10Krinkle: [C: 03+2] jquery.textSelection: Make jsdoc happier about the @ignore syntax [core] - 10https://gerrit.wikimedia.org/r/588504 (owner: 10Jforrester) [18:36:11] 10Wikimedia-Site-requests, 10Patch-For-Review: Restore the "reviewer" group for fawiki - https://phabricator.wikimedia.org/T249643 (10Huji) That clarifies many things, thanks! [18:37:18] 10NewcomerTasks 1.2, 10Growth-Team (Current Sprint): Newcomer tasks: guidance instrumentation - https://phabricator.wikimedia.org/T246919 (10Tgr) Schema changes: [[https://meta.wikimedia.org/w/index.php?title=Schema:HomepageVisit&diff=prev&oldid=20021981|HomepageVisit]], [[https://meta.wikimedia.org/w/index.ph... [18:40:39] (03CR) 10Ladsgroup: "It has been three months now. Can I send an email to wikitech asking for help in review?" [core] - 10https://gerrit.wikimedia.org/r/565741 (https://phabricator.wikimedia.org/T230421) (owner: 10Ladsgroup) [18:43:52] (03CR) 10jerkins-bot: [V: 04-1] [feature] add menu button to toggle panel visibility [skins/Vector] - 10https://gerrit.wikimedia.org/r/584694 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [18:44:46] (03CR) 10Krinkle: "> > I can't prioritise this as a whole. But I could perhaps help unblock part of it if we focus more specifically on the problems you're c" [core] - 10https://gerrit.wikimedia.org/r/588454 (https://phabricator.wikimedia.org/T138401) (owner: 10Jdlrobson) [18:45:32] (03Merged) 10jenkins-bot: skins: Refactor and split up SkinTemplate::prepareQuickTemplate [core] - 10https://gerrit.wikimedia.org/r/593326 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [18:45:55] (03Merged) 10jenkins-bot: registration: Move SearchMappings to CORE_ATTRIBS from NOT_ATTRIBS [core] - 10https://gerrit.wikimedia.org/r/593582 (https://phabricator.wikimedia.org/T250977) (owner: 10Reedy) [18:46:38] (03Merged) 10jenkins-bot: jquery.textSelection: Make jsdoc happier about the @ignore syntax [core] - 10https://gerrit.wikimedia.org/r/588504 (owner: 10Jforrester) [18:46:44] (03PS3) 10Jforrester: [DNM] Benchmark comparing JavaScriptMinifier and MinifyJS [core] - 10https://gerrit.wikimedia.org/r/411387 [18:49:59] (03CR) 10Jforrester: [DNM] Benchmark comparing JavaScriptMinifier and MinifyJS (031 comment) [core] - 10https://gerrit.wikimedia.org/r/411387 (owner: 10Jforrester) [18:52:52] (03PS5) 10Reedy: Drop global namespace CirrusSearch class [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591356 (https://phabricator.wikimedia.org/T250812) [18:53:23] 10MediaWiki-Search, 10Core Platform Team, 10Discovery-Search, 10MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), 10Patch-For-Review: Decouple $wgSearchType/$wgSearchTypeAlternatives from PHP class - https://phabricator.wikimedia.org/T250977 (10Reedy) 05Open→03Resolved [18:53:25] 10MediaWiki-Search, 10Discovery-Search: Use SearchMappings in MW Core - https://phabricator.wikimedia.org/T251525 (10Reedy) [18:53:27] 10CirrusSearch, 10Discovery-Search, 10MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), 10Patch-For-Review: Deal with dropping of Global CirrusSearch class - https://phabricator.wikimedia.org/T250812 (10Reedy) [18:57:53] 10MediaWiki-General, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review, 10PostgreSQL: (Postgres) Error: 42803 ERROR: column "temp_rev_user.revactor_actor" must appear in the GROUP BY clause or be used in an aggregate function - https://phabricator.wikimedia.org/T251599 (10Addshore) >>... [19:01:06] (03CR) 10jerkins-bot: [V: 04-1] [DNM] Benchmark comparing JavaScriptMinifier and MinifyJS [core] - 10https://gerrit.wikimedia.org/r/411387 (owner: 10Jforrester) [19:04:16] 10NewcomerTasks 1.2, 10Growth-Team (Current Sprint), 10Patch-For-Review: Newcomer tasks: mobile peek erroneously in production - https://phabricator.wikimedia.org/T251589 (10kostajh) a:03kostajh [19:18:59] (03PS7) 10Paladox: Fix migration script for when actor_id is null [extensions/Comments] - 10https://gerrit.wikimedia.org/r/593619 [19:19:09] (03PS9) 10Paladox: Fix migration script for when actor_id is null [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/593618 [19:20:09] (03PS5) 10Paladox: Only drop primary key if user_id does not exist [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/593788 [19:22:17] (03PS1) 10Paladox: Fix path to migrateOldUserStatsUserColumnsToActor.php in hooks [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/593926 [19:22:41] (03PS2) 10Paladox: Fix path to migrateOldUserStatsUserColumnsToActor.php in hooks [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/593926 [19:23:51] 10CheckUser, 10Anti-Harassment (The Letter Song): CU 2.0: Implement an option to allow users to copy the wikitext of the results table to their clipboard - https://phabricator.wikimedia.org/T251361 (10Niharika) >>! In T251361#6101809, @Prtksxna wrote: >>>! In T251361#6098519, @dbarratt wrote: >> I think it's f... [19:31:41] (03PS11) 10Art-Baltai: SkinTemplate test coverage [core] - 10https://gerrit.wikimedia.org/r/585628 (https://phabricator.wikimedia.org/T243756) [19:47:18] (03CR) 10jerkins-bot: [V: 04-1] SkinTemplate test coverage [core] - 10https://gerrit.wikimedia.org/r/585628 (https://phabricator.wikimedia.org/T243756) (owner: 10Art-Baltai) [19:56:14] (03CR) 10Fomafix: "This change causes T251682." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/575690 (owner: 10Esanders) [19:57:52] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Official Wikipedia app on Android shouldn't ignore q tags or CSS for q tags - https://phabricator.wikimedia.org/T251667 (10Pic-Sou) Hi, I am the user who reported the bug. I first noticed it on [[ https://fr.wikipedia.org/w/index.php?title=007_Spectre&oldid=... [20:08:35] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Technical-Debt (Deprecation process): mediawiki.util: Deprecate mw.util.$content in favor of mw.hook( 'wikipage.content' ) - https://phabricator.wikimedia.org/T65466 (10Krinkle) 05Declined→03Open [20:09:07] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Technical-Debt (Deprecation process), 10patch-welcome: mediawiki.util: Deprecate mw.util.$content in favor of mw.hook( 'wikipage.content' ) - https://phabricator.wikimedia.org/T65466 (10Krinkle) [20:12:53] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Technical-Debt (Deprecation process), 10patch-welcome: mediawiki.util: Deprecate mw.util.$content in favor of mw.hook( 'wikipage.content' ) - https://phabricator.wikimedia.org/T65466 (10Krinkle) >>! In T65466#683593, @Fomafix wrote: > Thanks for explanation... [20:13:21] 10MediaWiki-Interface, 10MediaWiki-ResourceLoader, 10Performance-Team, 10Documentation, 10JavaScript: Misleading doc for mw.hook('wikipage.content') - https://phabricator.wikimedia.org/T183087 (10Krinkle) [20:34:35] 10MediaWiki-Interface, 10MediaWiki-ResourceLoader, 10Performance-Team, 10Documentation, 10JavaScript: Misleading doc for mw.hook('wikipage.content') - https://phabricator.wikimedia.org/T183087 (10Krinkle) >>! From the **Task description** by @Xover`: > However, the actual code is: > > mw.hook( 'wiki... [20:47:26] 10MediaWiki-Interface: #mw-content-text is incorrectly placed on preview - https://phabricator.wikimedia.org/T38476 (10Krinkle) 05Open→03Resolved a:03Krinkle Looking at the preview page now, it has all the correct CSS rules applies. It inherits a `direction` from a `dir="…"` element, and it is presented wi... [20:50:13] (03CR) 10Krinkle: [C: 03+1] "@VolkerE OK, so this is not something we would document or that gadget/extensions/core is allowed to use as an interface. They cannot beca" [core] - 10https://gerrit.wikimedia.org/r/592784 (https://phabricator.wikimedia.org/T248137) (owner: 10VolkerE) [20:52:54] (03PS25) 10Nikki Nikkhoui: Update setTemporaryHook() to use scopedRegister() [core] - 10https://gerrit.wikimedia.org/r/589097 (https://phabricator.wikimedia.org/T250300) [21:02:31] 10Design, 10UI-Standardization, 10MinervaNeue, 10Patch-For-Review, 10Readers-Web-Backlog (Design): No page search result features wrong icon - https://phabricator.wikimedia.org/T208184 (10Volker_E) [21:02:52] 10Design, 10UI-Standardization, 10MinervaNeue, 10Patch-For-Review, 10Readers-Web-Backlog (Design): No page search result features wrong icon - https://phabricator.wikimedia.org/T208184 (10Volker_E) @Esanders Added second screen to task description. [21:05:47] (03PS5) 10Krinkle: Add "external" class to non-local interwiki links [core] - 10https://gerrit.wikimedia.org/r/146711 (https://phabricator.wikimedia.org/T20562) (owner: 10TTO) [21:05:59] (03PS6) 10Krinkle: Add "external" class to non-local interwiki links [core] - 10https://gerrit.wikimedia.org/r/146711 (https://phabricator.wikimedia.org/T20562) (owner: 10TTO) [21:09:45] (03CR) 10jerkins-bot: [V: 04-1] Update setTemporaryHook() to use scopedRegister() [core] - 10https://gerrit.wikimedia.org/r/589097 (https://phabricator.wikimedia.org/T250300) (owner: 10Nikki Nikkhoui) [21:10:58] (03PS7) 10DannyS712: Use RevisionRecordCallback in ParserOptions, require MW 1.35+ [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/589644 (https://phabricator.wikimedia.org/T249384) [21:12:15] (03CR) 10DannyS712: "> Here we can drop pre-1.35 compatibility too. As a rule of thumb, if" [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/589644 (https://phabricator.wikimedia.org/T249384) (owner: 10DannyS712) [21:17:42] 10MediaWiki-Documentation, 10Documentation, 10User-DannyS712: Move Help:Preferences from Meta to Mediawiki.org, update it and mark it for translation - https://phabricator.wikimedia.org/T181379 (10DannyS712) p:05Triage→03Low a:03DannyS712 (not something that a patch is needed for) Will: * Soft redirec... [21:21:47] (03CR) 10jerkins-bot: [V: 04-1] Add "external" class to non-local interwiki links [core] - 10https://gerrit.wikimedia.org/r/146711 (https://phabricator.wikimedia.org/T20562) (owner: 10TTO) [21:22:16] (03PS1) 10Urbanecm: IRCColourfulRCFeedFormatter: Do not ignore rc_bot flag for log entries [core] - 10https://gerrit.wikimedia.org/r/593927 [21:24:08] 10CirrusSearch, 10Discovery, 10Discovery-Search, 10Elasticsearch, and 2 others: Enable cross-wiki (interwiki) search for French Wikibooks - https://phabricator.wikimedia.org/T251683 (10JackPotte) [21:28:26] (03PS1) 10Paladox: Fix migration script for when actor_id is null [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/593928 [21:31:25] (03PS26) 10Nikki Nikkhoui: Update setTemporaryHook() to use scopedRegister() [core] - 10https://gerrit.wikimedia.org/r/589097 (https://phabricator.wikimedia.org/T250300) [21:40:20] (03PS2) 10Paladox: Add migration script to populate actor [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/593928 [21:43:42] (03PS3) 10Paladox: Add migration script to populate actor [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/593928 [21:46:19] (03PS4) 10Paladox: Add migration script to populate actor [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/593928 [21:47:29] (03CR) 10jerkins-bot: [V: 04-1] Add migration script to populate actor [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/593928 (owner: 10Paladox) [21:48:18] (03PS5) 10Paladox: Add migration script to populate actor [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/593928 [21:51:06] (03PS6) 10Paladox: Add migration script to populate actor [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/593928 [21:52:01] (03CR) 10Jforrester: [C: 03+2] eslint: Fix selenium config [extensions/Popups] - 10https://gerrit.wikimedia.org/r/593909 (owner: 10Esanders) [21:52:08] (03PS8) 10Paladox: Fix migration script for when actor_id is null [extensions/Comments] - 10https://gerrit.wikimedia.org/r/593619 [21:52:21] (03CR) 10Jforrester: [C: 03+2] eslint: Fix valid-jsdoc rule [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/593908 (owner: 10Esanders) [21:52:36] 10AbuseFilter, 10Patch-For-Review: Change the abusefilter database index definition - https://phabricator.wikimedia.org/T251613 (10Reedy) For reference.... enwiki! `lang=sql, lines=25 MariaDB [enwiki]> show create table abuse_filter\G *************************** 1. row *************************** Table... [21:59:26] 10MediaWiki-Page-Diffs, 10MW-1.35-notes (1.35.0-wmf.31; 2020-05-05), 10Patch-For-Review, 10User-notice: Use monospace font (or editfont preference) for diffs - https://phabricator.wikimedia.org/T250393 (10Naleksuh) There should be seperate options for font in editing space and fonts in diffs, with the defa... [22:01:31] (03CR) 10Reedy: [C: 03+2] Give MySQL indexes explicit names, create them outside of CREATE TABLE [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593906 (https://phabricator.wikimedia.org/T251613) (owner: 10Daimona Eaytoy) [22:01:41] (03CR) 10Reedy: [C: 04-1] "Damn it. See comment on task" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593906 (https://phabricator.wikimedia.org/T251613) (owner: 10Daimona Eaytoy) [22:03:16] (03CR) 10Jforrester: [C: 03+2] "Aha, thanks; I had opened an editor to do this as promised, but then failed to follow through." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/593829 (owner: 10Esanders) [22:03:24] 10AbuseFilter, 10Patch-For-Review: Change the abusefilter database index definition - https://phabricator.wikimedia.org/T251613 (10Reedy) My abuse filter tables as is: {F31792520} Applying https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/593906/ and I get this: `` ...abuse_filter table a... [22:08:34] (03CR) 10Jforrester: [C: 03+2] Link the "Reply" tag to mediawiki.org [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/593896 (https://phabricator.wikimedia.org/T250520) (owner: 10Esanders) [22:10:20] (03Merged) 10jenkins-bot: eslint: Fix selenium config [extensions/Popups] - 10https://gerrit.wikimedia.org/r/593909 (owner: 10Esanders) [22:10:22] (03Merged) 10jenkins-bot: eslint: Fix valid-jsdoc rule [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/593908 (owner: 10Esanders) [22:13:02] (03CR) 10Reedy: [C: 04-1] Give MySQL indexes explicit names, create them outside of CREATE TABLE (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/593906 (https://phabricator.wikimedia.org/T251613) (owner: 10Daimona Eaytoy) [22:16:20] 10UploadWizard: Upload Wizard uses template redirect {{PD-1923}} - https://phabricator.wikimedia.org/T251685 (10BMacZero) [22:18:36] (03Merged) 10jenkins-bot: eslint: Enable class-doc rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/593829 (owner: 10Esanders) [22:18:38] (03Merged) 10jenkins-bot: Link the "Reply" tag to mediawiki.org [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/593896 (https://phabricator.wikimedia.org/T250520) (owner: 10Esanders) [22:39:40] 10CirrusSearch, 10Discovery, 10Discovery-Search, 10Elasticsearch, and 2 others: Enable cross-wiki (interwiki) search for French Wikibooks - https://phabricator.wikimedia.org/T251683 (10Reedy) [22:39:55] 10Wikimedia-Site-requests, 10Wiktionary-fr: Enable cross-wiki (interwiki) search for French Wikibooks - https://phabricator.wikimedia.org/T251683 (10Reedy) [22:59:50] (03CR) 10Reedy: [C: 04-1] Fix typo: 'the the' -> 'the' (031 comment) [core] - 10https://gerrit.wikimedia.org/r/593921 (owner: 10Esanders) [23:12:53] 10MediaWiki-Configuration, 10Core Platform Team, 10Documentation, 10Patch-For-Review: Explain how to use Namespaces in Extensions and its relation to wgAutoloadClasses - https://phabricator.wikimedia.org/T251662 (10Reedy) [23:13:35] 10MediaWiki-Configuration, 10MediaWiki-Documentation, 10Core Platform Team, 10Documentation, 10Patch-For-Review: Explain how to use Namespaces in Extensions and its relation to wgAutoloadClasses - https://phabricator.wikimedia.org/T251662 (10Reedy) [23:15:02] 10MediaWiki-Configuration, 10MediaWiki-Documentation, 10Core Platform Team, 10Documentation, 10Patch-For-Review: Explain how to use Namespaces in Extensions and its relation to wgAutoloadClasses - https://phabricator.wikimedia.org/T251662 (10Reedy) >>! In T251662#6101944, @Nikerabbit wrote: > I think it'... [23:28:09] 10Wikimedia-Site-requests: Enable cross-wiki (interwiki) search for French Wikibooks - https://phabricator.wikimedia.org/T251683 (10Reedy) [23:33:51] (03PS12) 10Jdlrobson: BaseTemplate: Refactor skin code to allow us to move away from SkinTemplate [core] - 10https://gerrit.wikimedia.org/r/593040 (https://phabricator.wikimedia.org/T251212) [23:33:53] (03CR) 10Jdlrobson: "Okay. I guess it works if these are public and final. My main concern was around them being extended." [core] - 10https://gerrit.wikimedia.org/r/593040 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [23:41:03] 10MediaWiki-Internationalization, 10translatewiki.net: MediaWiki:Echo-specialmute-label-mute-notifications and MediaWiki:Specialmute-label-mute-email need gender mark - https://phabricator.wikimedia.org/T251687 (10-jem-) [23:46:00] 10MediaWiki-Interface, 10MediaWiki-Special-pages, 10Growth-Team, 10Notifications, 10I18n: MediaWiki:Echo-specialmute-label-mute-notifications and MediaWiki:Specialmute-label-mute-email need gender mark - https://phabricator.wikimedia.org/T251687 (10Reedy) [23:46:10] (03CR) 10jerkins-bot: [V: 04-1] BaseTemplate: Refactor skin code to allow us to move away from SkinTemplate [core] - 10https://gerrit.wikimedia.org/r/593040 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [23:47:07] 10AntiSpoof, 10Equivset, 10I18n: Augment our AntiSpoof normalization data with Unicode/CLDR data - https://phabricator.wikimedia.org/T65217 (10Reedy) [23:51:00] 10MediaWiki-Interface, 10MediaWiki-Special-pages, 10Growth-Team, 10Notifications, 10I18n: MediaWiki:Echo-specialmute-label-mute-notifications and MediaWiki:Specialmute-label-mute-email need gender mark - https://phabricator.wikimedia.org/T251687 (10-jem-) p:05Triage→03Medium [23:54:16] (03CR) 10Jdlrobson: "Now i remember the other reason for using static functions... existing tests... o_o" [core] - 10https://gerrit.wikimedia.org/r/593040 (https://phabricator.wikimedia.org/T251212) (owner: 10Jdlrobson) [23:57:23] 10MediaWiki-Interface, 10MediaWiki-Special-pages, 10Growth-Team, 10Notifications, and 2 others: MediaWiki:Echo-specialmute-label-mute-notifications and MediaWiki:Specialmute-label-mute-email need gender mark - https://phabricator.wikimedia.org/T251687 (10DannyS712) [23:57:26] (03PS1) 10Jdlrobson: Tests: Always set Skin [skins/Vector] - 10https://gerrit.wikimedia.org/r/593931 (https://phabricator.wikimedia.org/T251212) [23:57:38] (03CR) 10Art-Baltai: "recheck" [core] - 10https://gerrit.wikimedia.org/r/592326 (https://phabricator.wikimedia.org/T243755) (owner: 10Art-Baltai) [23:57:45] (03PS13) 10Jdlrobson: BaseTemplate: Refactor skin code to allow us to move away from SkinTemplate [core] - 10https://gerrit.wikimedia.org/r/593040 (https://phabricator.wikimedia.org/T251212) [23:59:19] (03PS1) 10Prod: Updated code based on core changes up to 1.34 from SpecialAllpages, SpecialEditWatchlist, SpecialPrefixindex [extensions/WatchSubpages] - 10https://gerrit.wikimedia.org/r/593932 (https://phabricator.wikimedia.org/T192402)