[00:00:21] (03PS4) 10Krinkle: docs: Update install command to use gerrit.wikimedia.org [fresh] - 10https://gerrit.wikimedia.org/r/591214 (https://phabricator.wikimedia.org/T250766) [00:02:59] 10Editing-team (Tracking), 10OWC2020 (New Discussion 1.0): Explore how wikis will integrate preloaded templates into revised new discussion workflow - https://phabricator.wikimedia.org/T250768 (10ppelberg) [00:03:28] 10Editing-team (Tracking), 10OWC2020 (New Discussion 1.0): Explore how wikis will integrate preloaded templates into revised new discussion workflow - https://phabricator.wikimedia.org/T250768 (10ppelberg) [00:04:58] 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (New Discussion 1.0): [Epic] Affordance: Start a new discussion - https://phabricator.wikimedia.org/T233446 (10ppelberg) [00:05:01] 10Editing-team (Tracking), 10OWC2020 (New Discussion 1.0): Explore how wikis will integrate preloaded templates into revised new discussion workflow - https://phabricator.wikimedia.org/T250768 (10ppelberg) [00:05:08] (03PS5) 10Krinkle: docs: Update install command to use gerrit.wikimedia.org [fresh] - 10https://gerrit.wikimedia.org/r/591214 (https://phabricator.wikimedia.org/T250766) [00:05:41] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.31x-P-Pryanik): Minor crash: TransactionTooLargeException after swiping very many Suggested Edit cards. - https://phabricator.wikimedia.org/T242449 (10cooltey) Note: When loading a long section to edit, it will also cause the `Transa... [00:06:10] 10Editing Design, 10Editing QA, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), 10OWC2020 (OWC2020 Replying 1.0): Create way to share feedback from within the workflow - https://phabricator.wikimedia.org/T249016 (10Ryasmeen) Checked on Beta cluster, looks okay to... [00:06:23] (03PS11) 10DannyS712: Update hook interfaces for recent changes [core] - 10https://gerrit.wikimedia.org/r/588936 [00:07:24] (03CR) 10DannyS712: "> Patch Set 20: Code-Review+2" [core] - 10https://gerrit.wikimedia.org/r/574266 (https://phabricator.wikimedia.org/T240307) (owner: 10Tim Starling) [00:07:45] (03Merged) 10jenkins-bot: Automatically generated hook interfaces [core] - 10https://gerrit.wikimedia.org/r/574266 (https://phabricator.wikimedia.org/T240307) (owner: 10Tim Starling) [00:07:55] (03PS12) 10DannyS712: Update hook interfaces for recent changes [core] - 10https://gerrit.wikimedia.org/r/588936 [00:08:11] (03PS13) 10DannyS712: Update hook interfaces for recent changes [core] - 10https://gerrit.wikimedia.org/r/588936 [00:08:39] 10Editing Design, 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board): [SPIKE] What approaches have people/communities done to make it easier to start new discussion threads? - https://phabricator.wikimedia.org/T249784 (10ppelberg) >>! In T249784#6052748, @Lofhi wrote: > I want to share that some important... [00:08:45] (03PS16) 10Jdlrobson: [modern] A new version of Vector with a new logo [skins/Vector] - 10https://gerrit.wikimedia.org/r/577682 (https://phabricator.wikimedia.org/T246170) [00:09:10] (03PS14) 10DannyS712: Update hook interfaces for recent additions and deprecations [core] - 10https://gerrit.wikimedia.org/r/588936 (https://phabricator.wikimedia.org/T240307) [00:10:47] 10Editing-team (Tracking), 10OWC2020 (New Discussion 1.0): Explore how wikis will integrate preloaded templates into revised new discussion workflow - https://phabricator.wikimedia.org/T250768 (10ppelberg) [00:11:00] 10Editing-team (Tracking), 10OWC2020 (New Discussion 1.0): Explore how wikis will integrate preloaded templates into revised new discussion workflow - https://phabricator.wikimedia.org/T250768 (10ppelberg) [00:14:31] (03CR) 10Reedy: "recheck" [wikimedia/textcat] - 10https://gerrit.wikimedia.org/r/591232 (owner: 10Libraryupgrader) [00:16:19] 10MediaWiki-Core-Hooks, 10MediaWiki-Documentation, 10Documentation, 10Patch-Needs-Improvement: Convert hooks.txt to YAML [Outreachy microtask] - https://phabricator.wikimedia.org/T115388 (10DannyS712) 05Open→03Declined hooks.txt will be removed now that the interfaces are the primary source of document... [00:16:21] 10MediaWiki-Documentation, 10Continuous-Integration-Config, 10Documentation: Create a Jenkins check to verify hooks.yaml formatting - https://phabricator.wikimedia.org/T116965 (10DannyS712) [00:16:55] 10MediaWiki-Core-Hooks, 10CPT Initiatives (MCR), 10Documentation, 10Technical-Debt, 10User-DannyS712: The "SecondaryDataUpdates" hook is listed in documentation as deprecated but doesn't emit deprecation warnings yet - https://phabricator.wikimedia.org/T232878 (10DannyS712) a:05DannyS712→03None [00:17:02] 10MediaWiki-Core-Hooks, 10MediaWiki-ResourceLoader, 10Performance-Team, 10Documentation, and 2 others: The "ResourceLoaderTestModules" hook is listed in documentation as deprecated but doesn't emit deprecation warnings yet - https://phabricator.wikimedia.org/T232875 (10DannyS712) a:05DannyS712→03None [00:17:07] 10MediaWiki-Core-Hooks, 10CPT Initiatives (MCR), 10Documentation, 10Technical-Debt, 10User-DannyS712: The "WikiPageDeletionUpdates" hook is listed in documentation as deprecated but doesn't emit deprecation warnings yet - https://phabricator.wikimedia.org/T232879 (10DannyS712) a:05DannyS712→03None [00:17:12] 10MediaWiki-Core-Hooks, 10Discovery-Search, 10Documentation, 10Technical-Debt, 10User-DannyS712: The "PrefixSearchBackend" hook is listed in documentation as deprecated but doesn't emit deprecation warnings yet - https://phabricator.wikimedia.org/T232874 (10DannyS712) a:05DannyS712→03None [00:17:38] 10MediaWiki-extensions-Page_Forms, 10Patch-For-Review: $wgPageFormsUseDisplayTitle interferes with autocompletion using values_from_concept when Display_title_of not set - https://phabricator.wikimedia.org/T250760 (10Yaron_Koren) @Tinss - That's a good find. I made some changes to the code and commit message f... [00:24:05] (03CR) 10jerkins-bot: [V: 04-1] [modern] A new version of Vector with a new logo [skins/Vector] - 10https://gerrit.wikimedia.org/r/577682 (https://phabricator.wikimedia.org/T246170) (owner: 10Jdlrobson) [00:28:34] 10DiscussionTools, 10Editing QA, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), 10OWC2020 (OWC2020 Replying 2.0): Implement opt-in/out of watching talk page in Replying workflow - https://phabricator.wikimedia.org/T245222 (10Ryasmeen) >>! In T245222#6071066, @Esa... [00:28:58] 10DiscussionTools, 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board): [RESEARCH SPIKE] Evaluate if some non-talk namespaces should have discussion tools enabled - https://phabricator.wikimedia.org/T249180 (10ppelberg) >>! In T249180#6023498, @Esanders wrote: > For the vast majority of wikis it is just "P... [00:34:45] 10MediaWiki-extensions-WatchSubPages, 10Growth-Team: Watchlist: `updateWatchlistNotification` job incorrectly marks revisions as "seen" - https://phabricator.wikimedia.org/T250770 (10Etonkovidova) [00:37:13] 10MediaWiki-Watchlist, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), and 4 others: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10Etonkovidova) >>! I... [00:38:15] 10MediaWiki-Watchlist, 10Growth-Team: Watchlist: `updateWatchlistNotification` job incorrectly marks revisions as "seen" - https://phabricator.wikimedia.org/T250770 (10DannyS712) [00:38:45] 10Spike, 10Vue.js: [Spike] Build step, ResourceLoader, or both for Vue.js search? - https://phabricator.wikimedia.org/T249350 (10Niedzielski) [00:39:19] 10Spike, 10Vue.js: [Spike] Build step, ResourceLoader, or both for Vue.js search? - https://phabricator.wikimedia.org/T249350 (10Niedzielski) [00:39:21] 10GLOW, 10Product-Analytics (Kanban): Code review: Review rec list results - https://phabricator.wikimedia.org/T247768 (10Iflorez) thank you @nettrom_WMF! sorry for the delay [00:41:20] 10MediaWiki-Watchlist, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), and 4 others: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10Etonkovidova) Checked i... [00:53:25] (03PS17) 10Jdlrobson: [modern] A new version of Vector with a new logo [skins/Vector] - 10https://gerrit.wikimedia.org/r/577682 (https://phabricator.wikimedia.org/T246170) [00:54:18] 10MediaWiki-Core-Hooks, 10Core Platform Team, 10Core Platform Team Workboards (Clinic Duty Team), 10Dependency injection, and 4 others: Hook container with strong types and DI - https://phabricator.wikimedia.org/T240307 (10tstarling) >>! In T240307#6066217, @cscott wrote: > It appears that prior to 0adc5f3... [00:55:30] (03PS1) 10Aaron Schulz: objectcache: store the serialized size estimates alongside values [core] - 10https://gerrit.wikimedia.org/r/591237 (https://phabricator.wikimedia.org/T248962) [00:56:38] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board), 10Patch-For-Review: Enable the Reply tool in the Project namespace (Wikipedia:) and other "wgExtraSignaturesNamespaces" - https://phabricator.wikimedia.org/T249036 (10ppelberg) With the "Updates" and "Considerations" below in mind, we think it wo... [01:15:12] (03PS1) 10Tim Starling: HookContainer: add b/c for non-static handler with colons in the function name [core] - 10https://gerrit.wikimedia.org/r/591238 (https://phabricator.wikimedia.org/T240307) [01:15:14] (03CR) 10Tim Starling: "recheck" [core] - 10https://gerrit.wikimedia.org/r/590858 (owner: 10Tim Starling) [01:18:10] 10Editing-team (Tracking), 10OWC2020 (New Discussion 1.0): Explore how wikis will integrate preloaded templates into revised new discussion workflow - https://phabricator.wikimedia.org/T250768 (10Lofhi) More examples on frwiki: - [[ https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Demande_de_suppression_imm%C3%A... [01:20:20] 10MediaWiki-Export-or-Import: Attempting to import revisions that were exported from the current wiki should generate a warning - https://phabricator.wikimedia.org/T250771 (10Dinoguy1000) [01:23:40] (03PS2) 10Aaron Schulz: objectcache: make BagOStuff key encoding more consistent [core] - 10https://gerrit.wikimedia.org/r/589465 (https://phabricator.wikimedia.org/T250239) [01:23:44] 10MediaWiki-Export-or-Import: Special:Import should skip revisions with identical content to the current revision - https://phabricator.wikimedia.org/T250772 (10Dinoguy1000) [01:24:43] 10MediaWiki-Parser, 10Parsing-Team, 10TechCom-RFC: RFC: Future of magic links - https://phabricator.wikimedia.org/T145604 (10Jonesey95) Thanks for the response. Can en.WP turn off magic links locally? [01:25:46] 10MediaWiki-Export-or-Import: Special:Import should skip revisions with identical content to the current revision - https://phabricator.wikimedia.org/T250772 (10Dinoguy1000) [01:29:28] (03PS4) 10VolkerE: Amend Base10 color and remove (affected) PNG fallbacks [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/589816 (https://phabricator.wikimedia.org/T248393) [01:32:24] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Treat assertEmpty() as problematic in PHPUnitAssertEquals - https://phabricator.wikimedia.org/T246674 (10DannyS712) a:03DannyS712 [01:38:38] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Treat assertEmpty() as problematic in PHPUnitAssertEquals - https://phabricator.wikimedia.org/T246674 (10DannyS712) >>! In T246674#5933045, @thiemowmde wrote: > In the past, I liked PHP's `empty()` exactly because it is so relaxed. Whenever I saw... [01:39:56] (03CR) 10jerkins-bot: [V: 04-1] objectcache: make BagOStuff key encoding more consistent [core] - 10https://gerrit.wikimedia.org/r/589465 (https://phabricator.wikimedia.org/T250239) (owner: 10Aaron Schulz) [01:42:33] (03CR) 10Tim Starling: Fix DeprecatedHooks and move emitDeprecatedHookWarnings to HookContainer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/589466 (owner: 10Tim Starling) [01:42:51] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 1.0), 10Patch-For-Review: Prevent page corruption in DiscussionTools caused by broken and incomplete table syntax - https://phabricator.wikimedia.org/T246481 (10ppelberg) - [ ] @matmarex are you able to revise the er... [01:43:53] 10MediaWiki-Codesniffer: Add potentially problematic assertEquals( 1 ) to the PHPUnitAssertEquals sniff - https://phabricator.wikimedia.org/T246662 (10DannyS712) @thiemowmde can this be closed as resolved? [01:46:10] (03PS3) 10Tim Starling: Fix DeprecatedHooks and move emitDeprecatedHookWarnings to HookContainer [core] - 10https://gerrit.wikimedia.org/r/589466 [01:46:11] (03PS2) 10Tim Starling: Change HookContainer's namespace from HookRunner to HookContainer [core] - 10https://gerrit.wikimedia.org/r/589469 [01:48:01] 10MobileFrontend, 10phan-taint-check-plugin: MobileFrontend taint-check fails - https://phabricator.wikimedia.org/T250630 (10sbassett) So https://gerrit.wikimedia.org/r/582909 didn't help at all with T183174? [01:48:18] 10MobileFrontend, 10phan-taint-check-plugin: MobileFrontend taint-check fails - https://phabricator.wikimedia.org/T250630 (10sbassett) p:05Triage→03Medium [01:48:23] (03PS3) 10Tim Starling: More flexible deprecation warnings [core] - 10https://gerrit.wikimedia.org/r/589464 [01:48:25] (03PS4) 10Tim Starling: Fix DeprecatedHooks and move emitDeprecatedHookWarnings to HookContainer [core] - 10https://gerrit.wikimedia.org/r/589466 [01:48:27] (03PS3) 10Tim Starling: Change HookContainer's namespace from HookRunner to HookContainer [core] - 10https://gerrit.wikimedia.org/r/589469 [01:48:29] (03PS1) 10Krinkle: doc: Restore Doxygen welcome page [WrappedString] - 10https://gerrit.wikimedia.org/r/591243 [01:48:33] (03CR) 10Art-Baltai: For Action::__construct() use Article instead of Page (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/588517 (https://phabricator.wikimedia.org/T249146) (owner: 10Art-Baltai) [01:48:36] (03CR) 10Krinkle: "Broken at https://doc.wikimedia.org/WrappedString/master/" [WrappedString] - 10https://gerrit.wikimedia.org/r/591243 (owner: 10Krinkle) [01:49:09] (03CR) 10jerkins-bot: [V: 04-1] Fix DeprecatedHooks and move emitDeprecatedHookWarnings to HookContainer [core] - 10https://gerrit.wikimedia.org/r/589466 (owner: 10Tim Starling) [01:51:01] (03PS1) 10Krinkle: doc: Restore Doxygen welcome page [utfnormal] - 10https://gerrit.wikimedia.org/r/591244 [01:51:07] (03CR) 10Krinkle: "Broken at https://doc.wikimedia.org/utfnormal/master/" [utfnormal] - 10https://gerrit.wikimedia.org/r/591244 (owner: 10Krinkle) [01:51:55] (03PS2) 10Art-Baltai: For Action::__construct use Article instead of Page [core] - 10https://gerrit.wikimedia.org/r/588534 (https://phabricator.wikimedia.org/T249146) [01:52:13] (03CR) 10Art-Baltai: For Action::__construct use Article instead of Page (031 comment) [core] - 10https://gerrit.wikimedia.org/r/588534 (https://phabricator.wikimedia.org/T249146) (owner: 10Art-Baltai) [01:53:54] 10SyntaxHighlight: Remove syntax from SyntaxHighlight (GeSHi) - https://phabricator.wikimedia.org/T39042 (10Pppery) [01:55:26] 10MediaWiki-extensions-WikiShare, 10Projects-Cleanup, 10Repository-Admins, 10Wikimedia-GitHub, 10Patch-For-Review: Unarchive mediawiki/extensions/WikiShare - https://phabricator.wikimedia.org/T250400 (10Pppery) [01:57:38] (03CR) 10Pppery: "FYI the MediaWiki.org page was archived after I tagged it as {{tl|DownloadBroken}} since the external download link it had is dead. Has th" [extensions/UnblockMe] - 10https://gerrit.wikimedia.org/r/510988 (owner: 10Zoranzoki21) [01:57:49] (03PS1) 10Krinkle: doc: Restore Doxygen welcome page [libs/RemexHtml] - 10https://gerrit.wikimedia.org/r/591245 [01:57:58] (03CR) 10Krinkle: "Broken at https://doc.wikimedia.org/mediawiki-libs-RemexHtml/master/" [libs/RemexHtml] - 10https://gerrit.wikimedia.org/r/591245 (owner: 10Krinkle) [01:58:36] (03CR) 10jerkins-bot: [V: 04-1] doc: Restore Doxygen welcome page [libs/RemexHtml] - 10https://gerrit.wikimedia.org/r/591245 (owner: 10Krinkle) [02:00:06] (03CR) 10Zoranzoki21: "> Patch Set 9:" [extensions/UnblockMe] - 10https://gerrit.wikimedia.org/r/510988 (owner: 10Zoranzoki21) [02:00:25] (03CR) 10jerkins-bot: [V: 04-1] Change HookContainer's namespace from HookRunner to HookContainer [core] - 10https://gerrit.wikimedia.org/r/589469 (owner: 10Tim Starling) [02:01:17] (03PS1) 10Krinkle: doc: Restore Doxygen welcome page [at-ease] - 10https://gerrit.wikimedia.org/r/591246 [02:01:24] (03CR) 10Krinkle: "Broken at https://doc.wikimedia.org/at-ease/master/" [at-ease] - 10https://gerrit.wikimedia.org/r/591246 (owner: 10Krinkle) [02:03:21] 10Desktop Improvements, 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4): Build collapsible sidebar and sidebar button - https://phabricator.wikimedia.org/T246419 (10Niedzielski) @alexhollender (/cc @volker_e), setting expectations: - The collap... [02:03:28] (03PS17) 10Tim Starling: Use a SelectQueryBuilder in SpecialWhatLinksHere [core] - 10https://gerrit.wikimedia.org/r/566128 (https://phabricator.wikimedia.org/T243051) [02:03:30] (03PS5) 10Tim Starling: Add rawTables(), getQueryInfo() and queryInfo() to SelectQueryBuilder [core] - 10https://gerrit.wikimedia.org/r/570520 [02:03:32] (03PS7) 10Tim Starling: In ApiQueryBase, use a SelectQueryBuilder to store query information [core] - 10https://gerrit.wikimedia.org/r/570517 (https://phabricator.wikimedia.org/T243051) [02:03:59] (03CR) 10jerkins-bot: [V: 04-1] Fix DeprecatedHooks and move emitDeprecatedHookWarnings to HookContainer [core] - 10https://gerrit.wikimedia.org/r/589466 (owner: 10Tim Starling) [02:05:45] 10DiscussionTools, 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.27; 2020-04-07): Allow non talk pages to be treated as talk pages using a magic word, and allow talk pages to be treated as non-talk pages using a magic word - https://phabricator.wikimedia.org/T245890 (10p... [02:09:09] 10Accessibility, 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 1.0), 10Patch-For-Review: Reply tool isn’t accessible to keyboard users - https://phabricator.wikimedia.org/T249915 (10ppelberg) [02:10:30] (03PS2) 10Samwilson: Use defined colours for upload and button areas [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/564860 (https://phabricator.wikimedia.org/T242352) [02:10:59] 10Accessibility, 10MediaWiki-extensions-MsUpload: Text elements must have sufficient color contrast against the background and Form elements must have labels - https://phabricator.wikimedia.org/T242352 (10Samwilson) @Volker_E I tried to do that in the above patch (but didn't check it very thoroughly; I... [02:11:07] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board), 10Patch-For-Review: Enable the Reply tool in the Project namespace (Wikipedia:) and other "wgExtraSignaturesNamespaces" - https://phabricator.wikimedia.org/T249036 (10Tacsipacsi) One thing I can think of is a help page/policy/guideline/whatever a... [02:12:25] 10MinervaNeue, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Wikimedia-production-error: [Minerva] Uncaught Error: Call to a member function isLocal() on boolean - https://phabricator.wikimedia.org/T250767 (10Jdlrobson) [02:13:04] 10Accessibility, 10MediaWiki-extensions-MsUpload: Text elements must have sufficient color contrast against the background and Form elements must have labels - https://phabricator.wikimedia.org/T242352 (10Volker_E) @Samwilson No, I've got no time to work on this. Was just coming from the merged task to... [02:14:41] (03CR) 10VolkerE: Minimum keyboard-accessibility for the reply link (031 comment) [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/591209 (https://phabricator.wikimedia.org/T249915) (owner: 10Bartosz Dziewoński) [02:14:47] 10Editing Design, 10Editing QA, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), 10OWC2020 (OWC2020 Replying 1.0): Create way to share feedback from within the workflow - https://phabricator.wikimedia.org/T249016 (10ppelberg) >>! In T249016#6073884, @Ryasmeen wrote... [02:16:51] 10MediaWiki-extensions-CentralAuth, 10Security-Team, 10Stewards-and-global-tools, 10Security, and 2 others: globaluserinfo api allows access to information about hidden users - https://phabricator.wikimedia.org/T250594 (10sbassett) >>! In T250594#6070658, @Urbanecm wrote: > Live as of this patch. Danny hel... [02:16:58] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Allow app language to always match device language - https://phabricator.wikimedia.org/T249710 (10SGautam_WMF) Ok, @hueitan I will wait for the PR to be merged. [02:17:00] 10MediaWiki-extensions-CentralAuth, 10Security-Team, 10Stewards-and-global-tools, 10Security, and 2 others: globaluserinfo api allows access to information about hidden users - https://phabricator.wikimedia.org/T250594 (10sbassett) [02:18:49] 10Accessibility, 10MediaWiki-extensions-MsUpload: Text elements must have sufficient color contrast against the background and Form elements must have labels - https://phabricator.wikimedia.org/T242352 (10Samwilson) Oh right, yeah I didn't think you meant you'd do it. :-) It's a good idea to match the... [02:19:20] 10MediaWiki-extensions-CentralAuth, 10Security-Team, 10Stewards-and-global-tools, 10Security, and 2 others: globaluserinfo api allows access to information about hidden users - https://phabricator.wikimedia.org/T250594 (10DannyS712) @sbassett this hasn't been merged to the master branch, just production, i... [02:20:23] 10MediaWiki-extensions-CentralAuth, 10Security-Team, 10Stewards-and-global-tools, 10Security, and 2 others: globaluserinfo api allows access to information about hidden users - https://phabricator.wikimedia.org/T250594 (10sbassett) >>! In T250594#6074036, @DannyS712 wrote: > @sbassett this hasn't been merg... [02:23:58] 10MediaWiki-Revision-backend, 10Core Platform Team Workboards (External Code Reviews), 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove support for Revisions from ContentHandler::getUndoContent - https://phabricator.wikimedia.org/T250773 (10DannyS712) [02:24:07] 10MediaWiki-Revision-backend, 10Core Platform Team Workboards (External Code Reviews), 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove support for Revisions from ContentHandler::getUndoContent - https://phabricator.wikimedia.org/T250773 (10DannyS712) p:05Triage→03Medium [02:25:35] 10MediaWiki-Stakeholders-Group, 10TechCom-RFC: RFC: Hybrid extension management - https://phabricator.wikimedia.org/T250406 (10Samwilson) > Except you probably won't end up with the right extension version; You will if extension authors take care to bump the major version when introducing breaking changes (i.... [02:25:56] 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 1.0): Reply links not working in particular sections - https://phabricator.wikimedia.org/T250425 (10ppelberg) >>! In T250425#6066839, @matmarex wrote: > I think this can be fixed by just adding a closing `` tag to the "end" template,... [02:26:09] (03PS1) 10SBassett: SECURITY: Do not leak user info via API [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/591250 (https://phabricator.wikimedia.org/T250594) [02:26:57] 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 1.0): Reply links not working in particular sections - https://phabricator.wikimedia.org/T250425 (10ppelberg) [02:27:23] (03PS1) 10SBassett: SECURITY: Do not leak user info via API [extensions/CentralAuth] (REL1_34) - 10https://gerrit.wikimedia.org/r/591251 (https://phabricator.wikimedia.org/T250594) [02:27:56] (03PS1) 10SBassett: SECURITY: Do not leak user info via API [extensions/CentralAuth] (REL1_33) - 10https://gerrit.wikimedia.org/r/591252 (https://phabricator.wikimedia.org/T250594) [02:28:51] (03PS1) 10SBassett: SECURITY: Do not leak user info via API [extensions/CentralAuth] (REL1_31) - 10https://gerrit.wikimedia.org/r/591253 (https://phabricator.wikimedia.org/T250594) [02:34:44] 10MediaWiki-Export-or-Import: Attempting to import revisions that were exported from the current wiki should generate a warning - https://phabricator.wikimedia.org/T250771 (10Dinoguy1000) [02:37:45] 10MediaWiki-extensions-CentralAuth, 10Security-Team, 10Stewards-and-global-tools, 10Security, and 2 others: globaluserinfo api allows access to information about hidden users - https://phabricator.wikimedia.org/T250594 (10sbassett) CVE has also requested - will update this task when I have the ID. [02:38:45] (03CR) 10Pppery: "I was primarily asking Examknow (see also T250564, the task I originally filed to archive this)" [extensions/UnblockMe] - 10https://gerrit.wikimedia.org/r/510988 (owner: 10Zoranzoki21) [02:39:40] (03CR) 10SBassett: [C: 03+2] SECURITY: Do not leak user info via API [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/591250 (https://phabricator.wikimedia.org/T250594) (owner: 10SBassett) [02:40:06] (03CR) 10Zoranzoki21: "> Patch Set 9:" [extensions/UnblockMe] - 10https://gerrit.wikimedia.org/r/510988 (owner: 10Zoranzoki21) [02:42:26] (03CR) 10VolkerE: [C: 04-1] "Thanks, yes. A few more nitpicks." (036 comments) [core] - 10https://gerrit.wikimedia.org/r/587544 (https://phabricator.wikimedia.org/T249804) (owner: 10Kevin Bazira) [02:43:17] (03Merged) 10jenkins-bot: SECURITY: Do not leak user info via API [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/591250 (https://phabricator.wikimedia.org/T250594) (owner: 10SBassett) [02:44:37] (03CR) 10VolkerE: [C: 04-1] "> No. That's not what we've agreed to. We would have common.less and legacy/common.less" [skins/Vector] - 10https://gerrit.wikimedia.org/r/591193 (owner: 10Jdlrobson) [02:46:12] (03PS1) 10Krinkle: doc: Restore Doxygen welcome page [CLDRPluralRuleParser] - 10https://gerrit.wikimedia.org/r/591254 [02:46:20] (03CR) 10Krinkle: "broken at https://doc.wikimedia.org/CLDRPluralRuleParser/master/" [CLDRPluralRuleParser] - 10https://gerrit.wikimedia.org/r/591254 (owner: 10Krinkle) [02:47:04] 10Wikimedia Design Style Guide: Document interaction colors - https://phabricator.wikimedia.org/T249347 (10Volker_E) p:05Triage→03Medium [02:47:40] 10Wikimedia Design Style Guide: standardize use of italic/oblique property for non-latin-script alphabets - https://phabricator.wikimedia.org/T227683 (10Volker_E) p:05Triage→03Medium [02:51:01] (03PS1) 10Krinkle: doc: Restore Doxygen welcome page [IPSet] - 10https://gerrit.wikimedia.org/r/591255 [02:51:07] (03CR) 10Krinkle: "broken at https://doc.wikimedia.org/IPSet/master/" [IPSet] - 10https://gerrit.wikimedia.org/r/591255 (owner: 10Krinkle) [02:51:25] 10Design, 10UI-Standardization, 10MinervaNeue, 10Timeless, 10Wikimedia Design Style Guide: [Typography] Rethinking the monospace font stack (source code typography): proposing commonly used fonts tailored for developers - https://phabricator.wikimedia.org/T244803 (10Volker_E) [02:51:35] 10Design, 10UI-Standardization, 10MinervaNeue, 10Timeless, 10Wikimedia Design Style Guide: [Typography] Rethinking the monospace font stack (source code typography): proposing commonly used fonts tailored for developers - https://phabricator.wikimedia.org/T244803 (10Volker_E) p:05Triage→03Low [02:55:21] 10MediaWiki-Parser, 10Parsing-Team, 10TechCom-RFC: RFC: Future of magic links - https://phabricator.wikimedia.org/T145604 (10cscott) [02:55:38] 10MediaWiki-Parser, 10Parsing-Team, 10TechCom-RFC: RFC: Future of magic links - https://phabricator.wikimedia.org/T145604 (10cscott) [02:57:10] (03PS1) 10VolkerE: Update 'wikimedia-ui-base' to v0.15.0 [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/591256 (https://phabricator.wikimedia.org/T248393) [02:58:36] 10MediaWiki-Parser, 10Parsing-Team, 10TechCom-RFC: RFC: Future of magic links - https://phabricator.wikimedia.org/T145604 (10cscott) Yes, magic links are a per-wiki feature flag: https://www.mediawiki.org/wiki/Manual:$wgEnableMagicLinks That said, I'm not certain that Parsoid and VE can turn these off quite... [03:02:09] 10MediaWiki-Parser, 10Parsing-Team, 10TechCom, 10TechCom-RFC: RFC: Future of magic links - https://phabricator.wikimedia.org/T145604 (10Krinkle) [03:04:31] 10Design, 10Growth-Team, 10MinervaNeue, 10StructuredDiscussions, and 4 others: Consolidate MinervaNeue and Flow on one WikimediaUI icon for ToC - https://phabricator.wikimedia.org/T232383 (10Volker_E) a:03Edtadros [03:11:38] 10MinervaNeue: MinervaNeue icons in menu should follow same default color `#54595d` - https://phabricator.wikimedia.org/T250774 (10Volker_E) [03:20:23] 10MinervaNeue: MinervaNeue icons in menu should follow same default color `#54595d` - https://phabricator.wikimedia.org/T250774 (10Volker_E) @alexhollender Remember our conversation from December on that confusing non-Style Guide color `#4A4F53`? [03:21:58] 10MinervaNeue: MinervaNeue icons in menu should follow same default color `#54595d` - https://phabricator.wikimedia.org/T250774 (10Volker_E) [03:23:29] 10MediaWiki-Watchlist, 10Growth-Team: Watchlist: While loading the page displays solid (black) bullet points - https://phabricator.wikimedia.org/T250775 (10Etonkovidova) [03:26:01] 10MinervaNeue: MinervaNeue icons in menu should follow same default color `#54595d` - https://phabricator.wikimedia.org/T250774 (10Volker_E) [03:26:03] 10Readers-Web-Backlog: Investigate color discrepancies in mobile web icons - https://phabricator.wikimedia.org/T240500 (10Volker_E) [03:26:40] 10MediaWiki-General: The $description in the Wikimedia\Assert methods should be callable|string - https://phabricator.wikimedia.org/T250776 (10cscott) [03:27:24] (03PS1) 10VolkerE: Use standard palette color Base20 for icons [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/591257 (https://phabricator.wikimedia.org/T240500) [03:28:48] (03CR) 10C. Scott Ananian: [C: 04-1] HookContainer: add b/c for non-static handler with colons in the function name (031 comment) [core] - 10https://gerrit.wikimedia.org/r/591238 (https://phabricator.wikimedia.org/T240307) (owner: 10Tim Starling) [03:35:54] (03CR) 10C. Scott Ananian: [C: 04-1] Update hook interfaces for recent additions and deprecations (033 comments) [core] - 10https://gerrit.wikimedia.org/r/588936 (https://phabricator.wikimedia.org/T240307) (owner: 10DannyS712) [03:37:36] (03PS15) 10DannyS712: Update hook interfaces for recent additions and deprecations [core] - 10https://gerrit.wikimedia.org/r/588936 (https://phabricator.wikimedia.org/T240307) [03:37:39] (03CR) 10DannyS712: Update hook interfaces for recent additions and deprecations (033 comments) [core] - 10https://gerrit.wikimedia.org/r/588936 (https://phabricator.wikimedia.org/T240307) (owner: 10DannyS712) [03:40:52] (03PS4) 10C. Scott Ananian: Don't use deprecated ParserBeforeTidy/BeforeParserFetchTemplateAndtitle hooks [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/589626 [03:41:38] (03PS5) 10Tim Starling: Fix DeprecatedHooks and move emitDeprecatedHookWarnings to HookContainer [core] - 10https://gerrit.wikimedia.org/r/589466 [03:41:40] (03PS4) 10Tim Starling: Change HookContainer's namespace from HookRunner to HookContainer [core] - 10https://gerrit.wikimedia.org/r/589469 [03:43:46] 10Wikimedia Design Style Guide: Define and add another Base color between Base10 and Base20? - https://phabricator.wikimedia.org/T240514 (10Volker_E) 05Open→03Declined After revisiting T240500 it doesn't seem a good use of our time to care for AAA support in some places while neglecting others. AAA contrast... [03:53:10] (03CR) 10jerkins-bot: [V: 04-1] Fix DeprecatedHooks and move emitDeprecatedHookWarnings to HookContainer [core] - 10https://gerrit.wikimedia.org/r/589466 (owner: 10Tim Starling) [03:53:18] (03CR) 10jerkins-bot: [V: 04-1] Change HookContainer's namespace from HookRunner to HookContainer [core] - 10https://gerrit.wikimedia.org/r/589469 (owner: 10Tim Starling) [04:08:40] 10MediaWiki-extensions-Page_Forms, 10Patch-For-Review: $wgPageFormsUseDisplayTitle interferes with autocompletion using values_from_concept when Display_title_of not set - https://phabricator.wikimedia.org/T250760 (10Tinss) @Yaron_Koren, thanks a bunch. I'll let you +2 the changes on gerrit and close this task. [04:11:48] 10Anti-Harassment (The Letter Song): Investigate services to fetch underlying information about IP addresses [8 Hours] - https://phabricator.wikimedia.org/T248525 (10SQL) >>! In T248525#6073152, @aezell wrote: > Thanks for putting this together. Lots of stuff to consider. > > It's looking more and more like we'... [04:13:49] 10Anti-Harassment (The Letter Song): Investigate services to fetch underlying information about IP addresses [8 Hours] - https://phabricator.wikimedia.org/T248525 (10SQL) >>! In T248525#6071633, @dbarratt wrote: >>>! In T248525#6069636, @Niharika wrote: >> I think most people accessing this information know that... [04:18:46] (03CR) 10Pppery: "This should probably be abandoned, and the extension archived, then, because merging it would only be delaying the inevitable." [extensions/UnblockMe] - 10https://gerrit.wikimedia.org/r/510988 (owner: 10Zoranzoki21) [04:19:45] 10MediaWiki-extensions-Other, 10Projects-Cleanup, 10Repository-Admins, 10Wikimedia-GitHub: Archive the UnblockMe extension - https://phabricator.wikimedia.org/T250564 (10Pppery) 05Declined→03Open See discussion [[ https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/UnblockMe/+/510988/ | on Gerrit]] [04:21:22] 10MediaWiki-extensions-Other, 10Projects-Cleanup, 10Repository-Admins, 10Wikimedia-GitHub: Archive the UnblockMe extension - https://phabricator.wikimedia.org/T250564 (10Pppery) [04:23:43] (03CR) 10Samwilson: "Cargo now aims at MW 1.29, which requires PHP 5.5.9 or later, so I guess this patch could be revisited now." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/471548 (owner: 10Arcayn) [04:24:11] 10CommRel-Specialists-Support (Apr-Jun-2020): Read only time for extension 1 (x1) primary database on 2020-04-30 - https://phabricator.wikimedia.org/T250733 (10Aklapper) [04:27:21] 10CommRel-Specialists-Support (Jan-Mar-2020): Support Wikimania 2020 risk planning - https://phabricator.wikimedia.org/T247030 (10Aklapper) 05Open→03Resolved As per last comment, closing this task by setting the status of this task to "Resolved" via the {nav name=Add Action... > Change Status} dropdown. [04:32:14] 10Wikimedia Design Style Guide: Structure of a “Component” page - https://phabricator.wikimedia.org/T217154 (10Volker_E) [04:34:19] 10Accessibility, 10MediaWiki-extensions-Other: [AutoSave] The name of the "ApplySave" button is wrong - https://phabricator.wikimedia.org/T250756 (10Aklapper) [04:34:45] (03CR) 10Tim Starling: HookContainer: add b/c for non-static handler with colons in the function name (031 comment) [core] - 10https://gerrit.wikimedia.org/r/591238 (https://phabricator.wikimedia.org/T240307) (owner: 10Tim Starling) [04:47:52] 10MediaWiki-extensions-Page_Forms, 10Patch-For-Review: Fix for handling of sections with special characters in their name such as "(", ")", "+" - https://phabricator.wikimedia.org/T246088 (10Sahajsk) I think it has been resolved here T246380 [04:49:45] 10Google-Summer-of-Code (2020): Proposal: Remove use of jQuery UI from Page Forms - https://phabricator.wikimedia.org/T248066 (10Sahajsk) [05:06:36] (03CR) 10Samwilson: Remove password reset invalid email message (032 comments) [core] - 10https://gerrit.wikimedia.org/r/589815 (https://phabricator.wikimedia.org/T249730) (owner: 10HMonroy) [05:07:49] (03Abandoned) 10Zoranzoki21: Initial commit of new extension [extensions/UnblockMe] - 10https://gerrit.wikimedia.org/r/510988 (owner: 10Zoranzoki21) [05:08:00] (03CR) 10Zoranzoki21: "> Patch Set 9:" [extensions/UnblockMe] - 10https://gerrit.wikimedia.org/r/510988 (owner: 10Zoranzoki21) [05:16:40] 10MediaWiki-extensions-Other, 10Projects-Cleanup, 10Repository-Admins, 10Wikimedia-GitHub, 10User-Zoranzoki21: Archive the UnblockMe extension - https://phabricator.wikimedia.org/T250564 (10Zoranzoki21) a:03Zoranzoki21 I will make needed patches. [05:20:24] 10Accessibility: UsersMultiselectWidget not announcing status message - https://phabricator.wikimedia.org/T250762 (10Volker_E) @Bkudiess-msft What extension or other software is this concerning? [05:21:26] (03PS5) 10Santhosh: Storybook: Add story for Autonym, Card, ButtonGroup, Spinner, Bottom Nav [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/588371 (https://phabricator.wikimedia.org/T247499) [05:23:44] (03PS2) 10Santhosh: Add separate dist bundle for lib/mediawiki.ui [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/591035 [05:24:05] (03CR) 10jerkins-bot: [V: 04-1] Add separate dist bundle for lib/mediawiki.ui [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/591035 (owner: 10Santhosh) [05:26:04] 10Google-Summer-of-Code (2020): Proposal : GSoC 2020 | Develop a Wikimedia Zulipchat bot to assist contributors - https://phabricator.wikimedia.org/T248216 (10Sanyam.wikime) @Pavithraes @Medhabansal @D3r1ck01 I have made significant improvements in the prototype over the time. I have outlined all the main poin... [05:27:08] 10Accessibility, 10Growth-Team, 10Notifications: Badge icon focus not visible - https://phabricator.wikimedia.org/T250753 (10Aklapper) 05Open→03Stalled Hi @Bkudiess-msft, thanks for taking the time to report this! I cannot reproduce in Firefox 75 on Linux and using Vector on mediawiki.org: {F31769758} W... [05:27:54] (03PS6) 10Tim Starling: [WIP] Fix DeprecatedHooks and move emitDeprecatedHookWarnings to HookContainer [core] - 10https://gerrit.wikimedia.org/r/589466 [05:34:08] 04(no projects): allow to query image caption through api - https://phabricator.wikimedia.org/T250777 (10Ralfhauser) [05:35:34] 10MediaWiki-Codesniffer: Add potentially problematic assertEquals( 1 ) to the PHPUnitAssertEquals sniff - https://phabricator.wikimedia.org/T246662 (10thiemowmde) 05Open→03Resolved a:03thiemowmde Yup. According to https://gerrit.wikimedia.org/r/#/c/mediawiki/tools/codesniffer/+/576045/2/MediaWiki/Tests/fil... [05:36:51] 10Accessibility, 10MediaWiki-General: UsersMultiselectWidget not announcing status message - https://phabricator.wikimedia.org/T250762 (10Aklapper) Assuming this is about MediaWiki core as `/resources/src/mediawiki.widgets/mw.widgets.UsersMultiselectWidget.js` exists, hence adding #MediaWiki-General in lack of... [05:39:43] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Fix DeprecatedHooks and move emitDeprecatedHookWarnings to HookContainer [core] - 10https://gerrit.wikimedia.org/r/589466 (owner: 10Tim Starling) [05:42:07] 10MediaWiki-extensions-ChangeUserPasswords: Better User Experience - https://phabricator.wikimedia.org/T250713 (10Aklapper) 05Open→03Invalid Hi @Hutchy68, thanks for taking the time to report this! Can you please check https://www.mediawiki.org/wiki/How_to_report_a_bug and split this into separate tasks, to... [05:44:32] 10Structured-Data-Backlog: allow to query image caption through api - https://phabricator.wikimedia.org/T250777 (10Aklapper) [05:51:27] (03PS7) 10Tim Starling: [WIP] Fix DeprecatedHooks and move emitDeprecatedHookWarnings to HookContainer [core] - 10https://gerrit.wikimedia.org/r/589466 [05:51:29] (03PS1) 10Tim Starling: Call TestSetup::applyInitialConfig() from bootstrap.php [core] - 10https://gerrit.wikimedia.org/r/591260 [05:56:05] 10Structured-Data-Backlog: allow to query image caption through api - https://phabricator.wikimedia.org/T250777 (10Gabrielchl) You're supposed to use the action `wbgetentities` to get structured data. For example: https://commons.wikimedia.org/wiki/Special:ApiSandbox#action=wbgetentities&format=json&sites=common... [05:56:43] (03PS3) 10Nikerabbit: Fix typo of targetLanguage [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/591013 (owner: 10Santhosh) [06:03:42] (03CR) 10Jforrester: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 30.0.0 [wikimedia/textcat] - 10https://gerrit.wikimedia.org/r/591232 (owner: 10Libraryupgrader) [06:03:55] 10MediaWiki-extensions-Translate, 10MassMessage, 10Language-Team (Language-2020-Focus-Sprint), 10MW-1.35-notes (1.35.0-wmf.28; 2020-04-14): Allow delivery of multilingual content (TechNews, Editing newsletter, ...) in fallback languages - https://phabricator.wikimedia.org/T165128 (10Nikerabbit) Well, the i... [06:07:47] (03PS8) 10Tim Starling: Fix DeprecatedHooks and move emitDeprecatedHookWarnings to HookContainer [core] - 10https://gerrit.wikimedia.org/r/589466 [06:11:08] (03CR) 10Nikerabbit: [C: 03+2] "submit" [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/591013 (owner: 10Santhosh) [06:11:48] 10DiscussionTools, 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.27; 2020-04-07): Allow non talk pages to be treated as talk pages using a magic word, and allow talk pages to be treated as non-talk pages using a magic word - https://phabricator.wikimedia.org/T245890 (10A... [06:13:21] (03CR) 10Tim Starling: "I moved the test for emitDeprecationWarnings() to HookContainerTest, but that is a unit test, and wfDeprecated() shouldn't really be used " [core] - 10https://gerrit.wikimedia.org/r/589466 (owner: 10Tim Starling) [06:16:19] (03CR) 10Nikerabbit: [C: 03+2] Storybook: Add story for Autonym, Card, ButtonGroup, Spinner, Bottom Nav [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/588371 (https://phabricator.wikimedia.org/T247499) (owner: 10Santhosh) [06:16:52] 10DiscussionTools, 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board): [RESEARCH SPIKE] Evaluate if some non-talk namespaces should have discussion tools enabled - https://phabricator.wikimedia.org/T249180 (10RhinosF1) >>! In T249180#6073923, @ppelberg wrote: >>>! In T249180#6023498, @Esanders wrote: >> F... [06:18:09] (03CR) 10Tim Starling: "In a subsequent commit I'll just make HookContainerTest be an "integration" test. HookContainer accesses $wgHooks, and global access is su" [core] - 10https://gerrit.wikimedia.org/r/589466 (owner: 10Tim Starling) [06:19:31] (03PS1) 10Ammarpad: Replace User::isAllowed* with PermissionManager [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/591262 [06:24:01] (03Merged) 10jenkins-bot: Fix typo of targetLanguage [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/591013 (owner: 10Santhosh) [06:25:43] (03CR) 10Tim Starling: [C: 03+2] docs: Hook interface doc comment review (031 comment) [core] - 10https://gerrit.wikimedia.org/r/580142 (https://phabricator.wikimedia.org/T246855) (owner: 10Alex Paskulin) [06:28:58] (03Merged) 10jenkins-bot: Storybook: Add story for Autonym, Card, ButtonGroup, Spinner, Bottom Nav [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/588371 (https://phabricator.wikimedia.org/T247499) (owner: 10Santhosh) [06:29:08] (03CR) 10jerkins-bot: [V: 04-1] Replace User::isAllowed* with PermissionManager [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/591262 (owner: 10Ammarpad) [06:34:36] (03PS7) 10Vidhi-Mody: Upgraded WebdriverIO from v4 to v5 [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/591060 (https://phabricator.wikimedia.org/T248223) [06:36:37] 10MediaWiki-extensions-Widgets: Git branches not up to date - https://phabricator.wikimedia.org/T231297 (10Kghbln) 05Open→03Declined To be honest, admins have to deal with this. Thus closing. [06:36:52] (03CR) 10jerkins-bot: [V: 04-1] Upgraded WebdriverIO from v4 to v5 [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/591060 (https://phabricator.wikimedia.org/T248223) (owner: 10Vidhi-Mody) [06:37:22] (03CR) 10Nikerabbit: [C: 03+2] Dashboard: Fill missing parameter for suggestions api [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/591014 (owner: 10Santhosh) [06:38:03] 10DiscussionTools, 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board): [RESEARCH SPIKE] Evaluate if some non-talk namespaces should have discussion tools enabled - https://phabricator.wikimedia.org/T249180 (10RhinosF1) dewiki | 100 | Portal dewikivoyage | 102 | Wahl fiwiki | 106 | Wikiprojekti frwiki | 1... [06:40:50] (03CR) 10Kevin Bazira: "> Patch Set 4: Code-Review-1" (036 comments) [core] - 10https://gerrit.wikimedia.org/r/587544 (https://phabricator.wikimedia.org/T249804) (owner: 10Kevin Bazira) [06:41:24] (03Merged) 10jenkins-bot: docs: Hook interface doc comment review [core] - 10https://gerrit.wikimedia.org/r/580142 (https://phabricator.wikimedia.org/T246855) (owner: 10Alex Paskulin) [06:42:36] (03PS5) 10Kevin Bazira: Adjust notification type colors to match utility colors in the Wikimedia Design Style guide [core] - 10https://gerrit.wikimedia.org/r/587544 (https://phabricator.wikimedia.org/T249804) [06:45:23] (03PS5) 10Nikerabbit: MWInput and MWLanguageSelector [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/589287 (https://phabricator.wikimedia.org/T247499) (owner: 10Santhosh) [06:45:59] (03CR) 10Nikerabbit: [C: 03+2] MWInput and MWLanguageSelector [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/589287 (https://phabricator.wikimedia.org/T247499) (owner: 10Santhosh) [06:47:13] 10SyntaxHighlight: Cannot use SyntaxHighlight: "Unable to run external programs, proc_open() is disabled" - https://phabricator.wikimedia.org/T250763 (10Aklapper) [06:48:38] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/WikiShare] - 10https://gerrit.wikimedia.org/r/591291 (owner: 10L10n-bot) [06:49:59] 10SyntaxHighlight: Cannot use SyntaxHighlight: "Unable to run external programs, proc_open() is disabled" - https://phabricator.wikimedia.org/T250763 (10Aklapper) I boldly renamed this task to summarize the actual problem, instead of having debatable statements such as "dangerous functions". [06:54:06] 10MediaWiki-General, 10Desktop Improvements, 10MonoBook, 10Vector, and 5 others: Ensure `#content`, `#footer` and `.portal` code occurrences are element agnostic - https://phabricator.wikimedia.org/T248137 (10Fomafix) The CSS selector `#footer` also matches to the heading created by the wikitext ` == foote... [06:55:04] 10Phabricator: Create new custom fundraising form - https://phabricator.wikimedia.org/T243961 (10Aklapper) >>! In T243961#5946562, @DStrine wrote: > ok thanks. I will run this by the stakeholders. They may still want something in the UI but I'll check. @DStrine: Any news to share? [06:55:17] wikimedia/mediawiki#27618 (master - f898b49 jenkins-bot): The build is still failing. - https://travis-ci.com/wikimedia/mediawiki/builds/161183557 [06:55:58] 10Phabricator: Create subtask should not open new task with deadline form - https://phabricator.wikimedia.org/T209799 (10Aklapper) [06:59:16] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive" [extensions/WikiShare] - 10https://gerrit.wikimedia.org/r/591291 (owner: 10L10n-bot) [07:00:44] (03PS3) 10Santhosh: Dashboard: Fill missing parameter for suggestions api [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/591014 [07:01:54] (03CR) 10VolkerE: [C: 03+2] "Thank you Kevin! Looks good. Please make sure, to update the “after the change” screen on task and also provide one for warning type." [core] - 10https://gerrit.wikimedia.org/r/587544 (https://phabricator.wikimedia.org/T249804) (owner: 10Kevin Bazira) [07:01:56] (03Merged) 10jenkins-bot: MWInput and MWLanguageSelector [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/589287 (https://phabricator.wikimedia.org/T247499) (owner: 10Santhosh) [07:04:17] (03PS8) 10Santhosh: dashboard: Validate the bundle created by webpack [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/587428 (https://phabricator.wikimedia.org/T247499) [07:04:46] (03CR) 10jerkins-bot: [V: 04-1] dashboard: Validate the bundle created by webpack [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/587428 (https://phabricator.wikimedia.org/T247499) (owner: 10Santhosh) [07:06:03] (03CR) 10Nikerabbit: [C: 03+2] Dashboard: Fill missing parameter for suggestions api [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/591014 (owner: 10Santhosh) [07:07:05] (03PS8) 10Vidhi-Mody: Upgraded WebdriverIO from v4 to v5 [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/591060 (https://phabricator.wikimedia.org/T248223) [07:09:28] (03CR) 10jerkins-bot: [V: 04-1] Upgraded WebdriverIO from v4 to v5 [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/591060 (https://phabricator.wikimedia.org/T248223) (owner: 10Vidhi-Mody) [07:09:40] (03PS9) 10Vidhi-Mody: Upgraded WebdriverIO from v4 to v5 [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/591060 (https://phabricator.wikimedia.org/T248223) [07:11:28] (03CR) 10Kosta Harlan: [C: 03+2] build: Add .gitreview and minor fix for WMF CI [fresh] - 10https://gerrit.wikimedia.org/r/591234 (https://phabricator.wikimedia.org/T250766) (owner: 10Krinkle) [07:11:53] (03Merged) 10jenkins-bot: build: Add .gitreview and minor fix for WMF CI [fresh] - 10https://gerrit.wikimedia.org/r/591234 (https://phabricator.wikimedia.org/T250766) (owner: 10Krinkle) [07:12:00] (03PS10) 10Vidhi-Mody: Upgraded WebdriverIO from v4 to v5 [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/591060 (https://phabricator.wikimedia.org/T248223) [07:13:01] (03PS1) 10Edward Chernenko: Be compatible with third-party extensions that use NewMessagesAlert [extensions/Echo] - 10https://gerrit.wikimedia.org/r/591297 [07:13:48] (03PS9) 10Santhosh: dashboard: Validate the bundle created by webpack [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/587428 (https://phabricator.wikimedia.org/T247499) [07:14:16] (03CR) 10jerkins-bot: [V: 04-1] dashboard: Validate the bundle created by webpack [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/587428 (https://phabricator.wikimedia.org/T247499) (owner: 10Santhosh) [07:15:32] (03CR) 10jerkins-bot: [V: 04-1] Upgraded WebdriverIO from v4 to v5 [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/591060 (https://phabricator.wikimedia.org/T248223) (owner: 10Vidhi-Mody) [07:16:24] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Allow app language to always match device language - https://phabricator.wikimedia.org/T249710 (10Jpita) Weird, I tried with the phone in spanish and portuguese and was working fine. what language did you use? [07:16:28] (03Merged) 10jenkins-bot: Adjust notification type colors to match utility colors in the Wikimedia Design Style guide [core] - 10https://gerrit.wikimedia.org/r/587544 (https://phabricator.wikimedia.org/T249804) (owner: 10Kevin Bazira) [07:19:36] (03Merged) 10jenkins-bot: Dashboard: Fill missing parameter for suggestions api [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/591014 (owner: 10Santhosh) [07:23:36] (03PS1) 10Nikerabbit: TableCleanup: Make batch size and reporting interval configurable [core] - 10https://gerrit.wikimedia.org/r/591299 [07:25:21] (03PS10) 10Aaron Schulz: rbms: optimize and rename truncateTable() to truncate() [core] - 10https://gerrit.wikimedia.org/r/582288 [07:26:39] (03PS3) 10Santhosh: Rename wikipedia store module to mediawiki [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/591015 [07:27:21] 10MediaWiki-Codesniffer: How to handle the nullable operator on multi type lists in code - https://phabricator.wikimedia.org/T250734 (10thiemowmde) Uh, nice suggestion! I agree. All examples that include a `?…` and a `…|…` the same time are not wrong, but very confusing. I would love to converted them all to `…|... [07:30:26] (03PS4) 10Santhosh: Rename wikipedia store module to mediawiki [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/591015 [07:42:09] 10MediaWiki-Codesniffer, 10User-DannyS712: PHPCS complains about unused use statements if used in @phan-var - https://phabricator.wikimedia.org/T250765 (10thiemowmde) Sure. Let's just add it to the UnusedUseStatement sniff! [07:47:12] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] "Nice, thanks for the updates!" [extensions/HashTables] - 10https://gerrit.wikimedia.org/r/588446 (owner: 10Zoranzoki21) [07:48:14] 10SyntaxHighlight: SyntaxHighlight_GeSHi does not work with MediaWiki 1.34 - https://phabricator.wikimedia.org/T250684 (10Rossetm) 05Stalled→03Resolved a:03Rossetm Hi, sorry for the delay. I added it this morning and it threw an error about not finding Pygmentize. So I checked the path in `$wgPygmentizePa... [08:01:59] 10SyntaxHighlight: SyntaxHighlight_GeSHi does not work with MediaWiki 1.34 - https://phabricator.wikimedia.org/T250684 (10Aklapper) 05Resolved→03Invalid [08:05:10] 10MediaWiki-Codesniffer: Spaces inside brackets used for array indexing - https://phabricator.wikimedia.org/T249872 (10thiemowmde) 05Resolved→03Open Wait a second. Are we going to enforce one style now? Where is the discussion if this is a good idea, and how exactly it should be implemented? Why is barely an... [08:11:02] 10MediaWiki-Export-or-Import: Special:Import should skip revisions with identical content to the current revision - https://phabricator.wikimedia.org/T250772 (10ArielGlenn) Can you clarify the specific circumstances in which you would want a revision for import to be skipped? What would the person by trying to d... [08:11:11] 10MediaWiki-Codesniffer: Spaces inside brackets used for array indexing - https://phabricator.wikimedia.org/T249872 (10daniel) What @thiemowmde said. I slightly prefer `$a[0]` to `$a[ 0 ]`, but I much prefer `$array[ $this->createKey( $inputValue ) ]` over ` $array[$this->createKey( $inputValue )]`, and `$foo[ $... [08:13:18] (03PS4) 10Ammarpad: Add support for limited pt-out statistics of default gadgets [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/591179 (https://phabricator.wikimedia.org/T121516) [08:15:01] (03CR) 10Daniel Kinzler: [C: 03+2] Call TestSetup::applyInitialConfig() from bootstrap.php [core] - 10https://gerrit.wikimedia.org/r/591260 (owner: 10Tim Starling) [08:15:26] 10Dumps-Generation: Fix multistream download link in recent dumps index.html pages - https://phabricator.wikimedia.org/T249477 (10ArielGlenn) 05Open→03Resolved Closing this, as all links have been fixed up. [08:17:24] 10Phabricator: Create subtask should not open new task with deadline form - https://phabricator.wikimedia.org/T209799 (10Dvorapa) [08:21:23] (03CR) 10Daniel Kinzler: "> The split of PHPUnit tests into "unit" and "integration" tests is really very awkward. I am considering reviewing that decision." [core] - 10https://gerrit.wikimedia.org/r/589466 (owner: 10Tim Starling) [08:23:17] (03CR) 10jerkins-bot: [V: 04-1] Add support for limited pt-out statistics of default gadgets [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/591179 (https://phabricator.wikimedia.org/T121516) (owner: 10Ammarpad) [08:23:28] 10Dumps-Generation, 10MachineVision, 10Security-Team, 10Structured-Data-Backlog, 10SDC-Statements (Machine-vision-depicts): Data dumps for the MachineVision extension - https://phabricator.wikimedia.org/T236431 (10ArielGlenn) 05Open→03Resolved a:03ArielGlenn Sent: https://lists.wikimedia.org/piperm... [08:24:12] 10MediaWiki-extensions-CodeReview, 10DBA, 10Dumps-Generation: Publish SQL dumps of CodeReview tables - https://phabricator.wikimedia.org/T243055 (10ArielGlenn) Just a check-in to see where this is on people's radar. [08:25:03] 10Dumps-Generation: 7z version of en-wiki dump (20200401) pages-meta-history is not accessible via download link - https://phabricator.wikimedia.org/T250018 (10ArielGlenn) 05Open→03Resolved a:03ArielGlenn Closing this since all files are now available and patch has been deployed and used. [08:25:50] 10Dumps-Generation: skip existing page content dump output files in bz2 and 7z generation jobs for each batch of commands - https://phabricator.wikimedia.org/T250260 (10ArielGlenn) Keeping this open until the code path gets used, probably during the May run. [08:26:36] 10Dumps-Generation: Simplify private/public wiki dump handling - https://phabricator.wikimedia.org/T249508 (10ArielGlenn) 05Open→03Resolved This is complete and tables have been dumped using the new code. [08:27:06] (03PS5) 10Ammarpad: Add support for limited pt-out statistics of default gadgets [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/591179 (https://phabricator.wikimedia.org/T121516) [08:27:14] 10Dumps-Generation: write unittest to check prefetch ranges for checkpoint files - https://phabricator.wikimedia.org/T249131 (10ArielGlenn) 05Open→03Resolved Done. [08:33:13] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.31x-P-Pryanik): Contributions view for enhanced user contribs history - https://phabricator.wikimedia.org/T250190 (10schoenbaechler) @Sharvaniharan Yeah let’s go with `Apr 20, 2020` for now. I’m still refining this today and tomorrow – I will update the t... [08:33:26] 10Inuka-Team, 10Patch-For-Review, 10Performance-Team (Radar), 10Readers-Web-Backlog (Kanbanana-2019-20-Q4): Avoid SEO performance and user experience penalties by addressing our handling of lazy loaded images using IntersectionObserver - https://phabricator.wikimedia.org/T246838 (10Gilles) My intuition was... [08:37:39] 10Chinese-Sites, 10Language-Team (Language-2020-Focus-Sprint): Content Translation tool keep saying there is problem with the translation, blocking submission - https://phabricator.wikimedia.org/T248203 (10Pginer-WMF) >>! In T248203#6040122, @Sunny00217 wrote: > Are this task and T246215 the same? After takin... [08:37:54] 10AbuseFilter, 10ContentTranslation: Show disallowed message for AbuseFilter with disallow action but without warn action in CX card - https://phabricator.wikimedia.org/T246215 (10Pginer-WMF) [08:38:15] 10AbuseFilter, 10ContentTranslation, 10Language-Team (Language-2020-January-March): Show disallowed message for AbuseFilter with disallow action but without warn action in CX card - https://phabricator.wikimedia.org/T246215 (10Pginer-WMF) [08:39:51] 10ContentTranslation, 10Tracking-Neverending, 10WorkType-Maintenance: Publishing and saving errors (tracking) - https://phabricator.wikimedia.org/T96003 (10Pginer-WMF) [08:39:53] 10AbuseFilter, 10ContentTranslation, 10Language-Team (Language-2020-January-March): Show disallowed message for AbuseFilter with disallow action but without warn action in CX card - https://phabricator.wikimedia.org/T246215 (10Pginer-WMF) [08:40:10] 10AbuseFilter, 10ContentTranslation, 10Language-Team (Language-2020-January-March): Show disallowed message for AbuseFilter with disallow action but without warn action in CX card - https://phabricator.wikimedia.org/T246215 (10Pginer-WMF) p:05Triage→03Medium [08:55:18] 10MediaWiki-REST-API, 10CPT Initiatives (Core REST API in PHP), 10Core Platform Team Workboards (Contractor Workboard), 10Story: Reader gets page thumbnail with search results - https://phabricator.wikimedia.org/T245673 (10daniel) @EvanProdromou this ticket asks for the thumbnails in the search result to f... [08:57:25] (03CR) 10Daniel Kinzler: rest: Add 'thumbnail' and 'description' fields to the search response (039 comments) [core] - 10https://gerrit.wikimedia.org/r/588999 (https://phabricator.wikimedia.org/T250144) (owner: 10Peter.ovchyn) [08:58:51] (03CR) 10Nikerabbit: [C: 03+2] Rename wikipedia store module to mediawiki [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/591015 (owner: 10Santhosh) [09:03:37] (03CR) 10Nikerabbit: [C: 03+2] doc: Restore Doxygen welcome page [CLDRPluralRuleParser] - 10https://gerrit.wikimedia.org/r/591254 (owner: 10Krinkle) [09:03:57] (03CR) 10ArielGlenn: "I would escape both chars in the expression (\[\]) or neither of them. Personally I prefer the unescaped version as the code has now." [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/569365 (owner: 10Thiemo Kreuz (WMDE)) [09:04:30] (03Merged) 10jenkins-bot: doc: Restore Doxygen welcome page [CLDRPluralRuleParser] - 10https://gerrit.wikimedia.org/r/591254 (owner: 10Krinkle) [09:08:10] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "Full review done. I think the extension.json file is complete and correct and does not miss anything that was there before. With a few exc" (037 comments) [extensions/HashTables] - 10https://gerrit.wikimedia.org/r/566644 (https://phabricator.wikimedia.org/T243480) (owner: 10Zoranzoki21) [09:11:51] (03PS6) 10Ammarpad: Add support for limited opt-out statistics of default gadgets [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/591179 (https://phabricator.wikimedia.org/T121516) [09:12:03] (03Merged) 10jenkins-bot: Rename wikipedia store module to mediawiki [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/591015 (owner: 10Santhosh) [09:13:15] (03CR) 10Daniel Kinzler: [C: 04-1] "The "dangerous" methods on DatabaseUpdater are no longer public, see Ie73e6143bb5cbce0dae705a7451fb49cf7e3abcd." [core] - 10https://gerrit.wikimedia.org/r/475065 (https://phabricator.wikimedia.org/T157651) (owner: 10Gergő Tisza) [09:13:29] (03CR) 10Thiemo Kreuz (WMDE): "Huh? You can not "not escape" the closing ] in pretty much all situations, except it is the first character in the list. As it was before." [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/569365 (owner: 10Thiemo Kreuz (WMDE)) [09:13:33] (03PS11) 10Daniel Kinzler: Structure test for wrong calls in LoadExtensionSchemaUpdates [core] - 10https://gerrit.wikimedia.org/r/475065 (https://phabricator.wikimedia.org/T157651) (owner: 10Gergő Tisza) [09:17:32] (03CR) 10Nikerabbit: [C: 03+1] "Need manual rebase." [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/591035 (owner: 10Santhosh) [09:20:55] (03CR) 10Nikerabbit: [C: 03+2] Add Special:MyLanguage for better user experience [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/589773 (owner: 10Shirayuki) [09:22:33] 10MediaWiki-extensions-CentralAuth, 10Anti-Harassment, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review, 10User-Urbanecm: Globaluserinfo API module should allow getting data for more than one user at once - https://phabricator.wikimedia.org/T237505 (10daniel) p:05High→03Medium [09:26:38] (03CR) 10Daniel Kinzler: "Please add a test case, either as a PHPUnit test, or as a Mocha test. See for example ." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/548966 (https://phabricator.wikimedia.org/T237505) (owner: 10Urbanecm) [09:29:02] (03CR) 10jerkins-bot: [V: 04-1] Structure test for wrong calls in LoadExtensionSchemaUpdates [core] - 10https://gerrit.wikimedia.org/r/475065 (https://phabricator.wikimedia.org/T157651) (owner: 10Gergő Tisza) [09:30:33] (03PS3) 10Santhosh: Add separate dist bundle for lib/mediawiki.ui [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/591035 [09:30:49] (03CR) 10Daniel Kinzler: "> > I apologize for the -2 here. I didn't intend to use the nuclear option." [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) (owner: 10Urbanecm) [09:31:13] (03PS10) 10Santhosh: dashboard: Validate the bundle created by webpack [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/587428 (https://phabricator.wikimedia.org/T247499) [09:31:44] 10MediaWiki-extensions-CentralAuth, 10Anti-Harassment, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review, 10User-Urbanecm: Globaluserinfo API module should allow getting data for more than one user at once - https://phabricator.wikimedia.org/T237505 (10daniel) p:05Medium→03High [09:33:27] 04(no projects): Upgrade WebdriverIO from v4 to v5 - https://phabricator.wikimedia.org/T250784 (10Vidhi-Mody) [09:33:50] (03Merged) 10jenkins-bot: Add Special:MyLanguage for better user experience [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/589773 (owner: 10Shirayuki) [09:34:39] 04(no projects): Upgrade WebdriverIO from v4 to v5 - https://phabricator.wikimedia.org/T250784 (10Vidhi-Mody) [09:35:11] 04(no projects): Upgrade WebdriverIO from v4 to v5 - https://phabricator.wikimedia.org/T250784 (10RhinosF1) Hi @Vidhi-Mody. Can you please associate at least one active [[ https://phabricator.wikimedia.org/project/query/G9vp6zKs.IfE/#R | project ]] with this task (via the {nav name=Add Action... > Change Proje... [09:36:32] (03CR) 10Daniel Kinzler: "It would be great to take this opportunity to create unit tests for CreditsAction. See ViewActionTest and WatchActionTest for examples." [core] - 10https://gerrit.wikimedia.org/r/588076 (https://phabricator.wikimedia.org/T187518) (owner: 10Ammarpad) [09:36:52] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board), 10Patch-For-Review: Enable the Reply tool in the Project namespace (Wikipedia:) and other "wgExtraSignaturesNamespaces" - https://phabricator.wikimedia.org/T249036 (10Esanders) @Tacsipacsi that's a good example, here's a specific page https://nl.... [09:39:11] 10MediaWiki-Maintenance-system, 10Growth-Team, 10Performance-Team, 10StructuredDiscussions, and 5 others: sql.php runs LoadExtensionSchemaUpdates - https://phabricator.wikimedia.org/T157651 (10daniel) It seems like all essential patches are merged. Can this be closed now? [09:40:01] 10MediaWiki-REST-API, 10CPT Initiatives (Core REST API in PHP), 10Core Platform Team Workboards (Contractor Workboard): Implement getting the page description in extension - https://phabricator.wikimedia.org/T250217 (10Peter.ovchyn) @daniel @WMDE-leszek So, what would be a strategy to push this forward? Can... [09:41:31] 10CX-boost, 10Epic, 10Language-Team (Language-2020-January-March): [Epic] Support for Section Translation - https://phabricator.wikimedia.org/T243495 (10Pginer-WMF) [09:42:59] 10MediaWiki-General, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.35-notes (1.35.0-wmf.25; 2020-03-24), 10Patch-For-Review, and 3 others: Remove use of legacy page.page_restrictions field - https://phabricator.wikimedia.org/T218446 (10daniel) Moving to "ready", since the next step seems to be... [09:44:14] (03CR) 10jerkins-bot: [V: 04-1] dashboard: Validate the bundle created by webpack [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/587428 (https://phabricator.wikimedia.org/T247499) (owner: 10Santhosh) [09:45:19] (03CR) 10ArielGlenn: [C: 03+1] "nice catch on the str_replace." [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/590699 (owner: 10Reedy) [09:45:36] 10Phabricator: Create subtask should not open new task with deadline form - https://phabricator.wikimedia.org/T209799 (10Aklapper) 05Open→03Stalled A few weeks after this task was created, https://secure.phabricator.com/T12588#242719 got implemented. Currently, if I click Edit Related Tasks... > Create Subta... [09:46:10] 10MediaWiki-REST-API, 10CPT Initiatives (Core REST API in PHP), 10Core Platform Team Workboards (Contractor Workboard): Implement getting the page description in extension - https://phabricator.wikimedia.org/T250217 (10daniel) >>! In T250217#6074526, @Peter.ovchyn wrote: > @daniel @WMDE-leszek > > So, what... [09:50:04] 10Wikibase - Federated Properties, 10Patch-For-Review: Create ADR for storing federated property ids without source repo identifier prefixes - https://phabricator.wikimedia.org/T247831 (10Samantha_Alipio_WMDE) [09:50:07] 10Wikibase - Federated Properties, 10Patch-For-Review: Automate the test system for federated properties target repo - https://phabricator.wikimedia.org/T248837 (10Samantha_Alipio_WMDE) [09:50:54] 04(no projects): Upgrade WebdriverIO from v4 to v5 - https://phabricator.wikimedia.org/T250784 (10Vidhi-Mody) [09:52:42] (03CR) 10Nikerabbit: [C: 03+2] Add separate dist bundle for lib/mediawiki.ui [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/591035 (owner: 10Santhosh) [09:53:40] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Allow app language to always match device language - https://phabricator.wikimedia.org/T249710 (10SGautam_WMF) I tried a couple of Indian languages including Hindi. [09:54:50] 10puppet-compiler, 10Patch-For-Review: feature request: print PCC invocation in html output - https://phabricator.wikimedia.org/T250169 (10jbond) 05Open→03Resolved a:03jbond I think this is complete now, there is an example [[https://integration.wikimedia.org/ci/job/operations-puppet-catalog-compiler/221... [09:55:06] (03CR) 10ArielGlenn: "> Huh? You can not "not escape" the closing ] in pretty much all" [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/569365 (owner: 10Thiemo Kreuz (WMDE)) [09:57:43] (03CR) 10ArielGlenn: "> This would require manual rebase. In general, given that 1.35 will" [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/552566 (https://phabricator.wikimedia.org/T238921) (owner: 10Daniel Kinzler) [10:07:31] (03Merged) 10jenkins-bot: Add separate dist bundle for lib/mediawiki.ui [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/591035 (owner: 10Santhosh) [10:11:48] 10DiscussionTools, 10Editing QA, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), 10OWC2020 (OWC2020 Replying 2.0): Implement opt-in/out of watching talk page in Replying workflow - https://phabricator.wikimedia.org/T245222 (10Esanders) Yes, the checkbox should beh... [10:15:50] 10Wikimedia Design Style Guide: Make "Working with Design" document accessible through the Wikimedia Style guide - https://phabricator.wikimedia.org/T234919 (10RHo) [10:16:46] (03CR) 10D3r1ck01: "> $wgCommentStreamsAllowedNamespaces = ..." [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/481669 (https://phabricator.wikimedia.org/T246487) (owner: 10Nischayn22) [10:17:25] 10Patch-For-Review, 10Wikibase - Federated Properties (Sprint 4): Automate the test system for federated properties target repo - https://phabricator.wikimedia.org/T248837 (10Samantha_Alipio_WMDE) [10:17:28] 10Wikibase - Federated Properties (Sprint 4): [EPIC] Display statements made with federated properties on item page - https://phabricator.wikimedia.org/T246606 (10Samantha_Alipio_WMDE) [10:17:30] 10Patch-For-Review, 10Wikibase - Federated Properties (Sprint 4): Create ADR for storing federated property ids without source repo identifier prefixes - https://phabricator.wikimedia.org/T247831 (10Samantha_Alipio_WMDE) [10:17:32] 10Wikibase - Federated Properties (Sprint 4): Wire PrefetchingTermLookup into prefetching-term-lookup-callback for federated properties - https://phabricator.wikimedia.org/T249799 (10Samantha_Alipio_WMDE) [10:17:36] (03PS12) 10D3r1ck01: Support for multiple comments blocks in a page [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/481669 (https://phabricator.wikimedia.org/T246487) (owner: 10Nischayn22) [10:17:37] 10Wikibase - Federated Properties (Sprint 4): Implement a PrefetchingTermLookup for federated properties - https://phabricator.wikimedia.org/T249797 (10Samantha_Alipio_WMDE) [10:17:43] 10Wikibase - Federated Properties (Sprint 4): Move Item and Property prefetching-term-lookup-callback service wiring into WikibaseRepo.entitytypes.php - https://phabricator.wikimedia.org/T249796 (10Samantha_Alipio_WMDE) [10:17:48] 10Wikibase - Federated Properties (Sprint 4): Document prefetching-term-lookup-callback in entitytypes.md - https://phabricator.wikimedia.org/T249795 (10Samantha_Alipio_WMDE) [10:17:59] 10Wikibase - Federated Properties (Sprint 4): [EPIC] Display statements made with federated properties on item page - https://phabricator.wikimedia.org/T246606 (10Samantha_Alipio_WMDE) [10:18:33] (03CR) 10jerkins-bot: [V: 04-1] Support for multiple comments blocks in a page [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/481669 (https://phabricator.wikimedia.org/T246487) (owner: 10Nischayn22) [10:18:49] 10Wikimedia Design Style Guide: Make "Working with Design" document accessible through the Wikimedia Style guide - https://phabricator.wikimedia.org/T234919 (10RHo) The doc has been uploaded [[ https://www.mediawiki.org/wiki/File:Working_with_Design_2020-01-10.pdf | here ]] and linked on Mediawiki. The last thi... [10:20:53] (03PS13) 10D3r1ck01: Support for multiple comments blocks in a page [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/481669 (https://phabricator.wikimedia.org/T246487) (owner: 10Nischayn22) [10:21:40] 10MediaWiki-extensions-CodeReview, 10DBA, 10Dumps-Generation, 10Security-Team: Publish SQL dumps of CodeReview tables - https://phabricator.wikimedia.org/T243055 (10Marostegui) I guess this needs a review from #security-team to double check if it needs redaction or it can go as they are. [10:21:55] (03CR) 10jerkins-bot: [V: 04-1] Support for multiple comments blocks in a page [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/481669 (https://phabricator.wikimedia.org/T246487) (owner: 10Nischayn22) [10:22:52] (03CR) 10D3r1ck01: "All fixed now. Could you please check and let me know?" [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/481669 (https://phabricator.wikimedia.org/T246487) (owner: 10Nischayn22) [10:24:05] (03PS14) 10D3r1ck01: Support for multiple comments blocks in a page [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/481669 (https://phabricator.wikimedia.org/T246487) (owner: 10Nischayn22) [10:25:00] (03CR) 10jerkins-bot: [V: 04-1] Support for multiple comments blocks in a page [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/481669 (https://phabricator.wikimedia.org/T246487) (owner: 10Nischayn22) [10:26:19] (03PS15) 10D3r1ck01: Support for multiple comments blocks in a page [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/481669 (https://phabricator.wikimedia.org/T246487) (owner: 10Nischayn22) [10:26:36] (03PS1) 10Abijeet Patro: Add fallback language support when sending translatable page as message [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/591317 (https://phabricator.wikimedia.org/T165128) [10:27:01] 10Wikibase - Federated Properties: Display statements made with deleted federated properties - https://phabricator.wikimedia.org/T250785 (10Samantha_Alipio_WMDE) [10:32:53] (03PS4) 10ItSpiderman: [WIP] Skin implementation [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/589022 [10:35:22] (03PS11) 10Aaron Schulz: rbms: optimize and rename truncateTable() to truncate() [core] - 10https://gerrit.wikimedia.org/r/582288 [10:37:29] 10MediaWiki-General, 10UI-Standardization, 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), 10Patch-For-Review: Adjust bubble notification type colors to match utility colors in the Wikimedia Design Style guide - https://phabricator.wikimedia.org/T249804 (10kevinbazira) [10:37:52] 10Wikibase - Federated Properties: View details of a federated property used in a statement [MVP Version] - https://phabricator.wikimedia.org/T246125 (10Samantha_Alipio_WMDE) [10:42:10] (03PS2) 10Aaron Schulz: Avoid use of deprecated CdnCacheUpdate method [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589771 [10:42:22] 10Wikibase - Federated Properties: Display statements made with deleted federated properties - https://phabricator.wikimedia.org/T250785 (10Samantha_Alipio_WMDE) [10:43:38] (03CR) 10Kevin Bazira: "> Patch Set 5: Code-Review+2" [core] - 10https://gerrit.wikimedia.org/r/587544 (https://phabricator.wikimedia.org/T249804) (owner: 10Kevin Bazira) [11:04:00] 10MediaWiki-General: Add notification type success to mw.notify bubble notifications - https://phabricator.wikimedia.org/T250788 (10kevinbazira) [11:05:27] (03PS2) 10Kevin Bazira: Add notification type success [core] - 10https://gerrit.wikimedia.org/r/587549 (https://phabricator.wikimedia.org/T250788) [11:06:41] (03CR) 10jerkins-bot: [V: 04-1] Add notification type success [core] - 10https://gerrit.wikimedia.org/r/587549 (https://phabricator.wikimedia.org/T250788) (owner: 10Kevin Bazira) [11:09:17] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Allow app language to always match device language - https://phabricator.wikimedia.org/T249710 (10Jpita) ok, must be a language that the app is not translated to. missed that case, sorry team [11:11:32] 10Design, 10MediaWiki-Interface, 10TechCom-RFC, 10Core Platform Team Workboards (Clinic Duty Team), and 2 others: RFC: Section header "share" link - https://phabricator.wikimedia.org/T18691 (10ovasileva) Sorry for the late reply here. The current implementation is approved from our side, in terms of both... [11:17:56] 10Wikibase - Federated Properties (Sprint 4): Implement LabelsProviderEntityIdHtmlLinkFormatter without the checks for if the entity exists - https://phabricator.wikimedia.org/T250789 (10Addshore) [11:18:24] 10Wikibase - Federated Properties (Sprint 4): [EPIC] Display statements made with federated properties on item page - https://phabricator.wikimedia.org/T246606 (10Addshore) [11:18:27] 10Wikibase - Federated Properties (Sprint 4): Implement LabelsProviderEntityIdHtmlLinkFormatter without the checks for if the entity exists - https://phabricator.wikimedia.org/T250789 (10Addshore) [11:19:20] 10Wikibase - Federated Properties (Sprint 4): Wire PrefetchingTermLookup and EntityIdLabelFormatter into prefetching-term-lookup-callback for federated properties - https://phabricator.wikimedia.org/T249799 (10Addshore) [11:19:46] 10Wikibase - Federated Properties (Sprint 4): Implement EntityIdLabelFormatter without the checks for if the entity exists - https://phabricator.wikimedia.org/T250789 (10Addshore) [11:20:08] (03CR) 10Nikerabbit: [C: 04-1] Add fallback language support when sending translatable page as message (034 comments) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/591317 (https://phabricator.wikimedia.org/T165128) (owner: 10Abijeet Patro) [11:24:58] 10GrowthExperiments-Help panel, 10NewcomerTasks 1.2, 10Growth-Team (Current Sprint), 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28): Unify back button design - https://phabricator.wikimedia.org/T248065 (10RHo) [11:25:44] (03PS12) 10Art-Baltai: Hard deprecate Article methods proxying to WikiPage [core] - 10https://gerrit.wikimedia.org/r/581247 (https://phabricator.wikimedia.org/T239975) [11:26:35] (03PS19) 10Peter.ovchyn: rest: Add 'thumbnail' and 'description' fields to the search response [core] - 10https://gerrit.wikimedia.org/r/588999 (https://phabricator.wikimedia.org/T250144) [11:27:58] (03PS5) 10ItSpiderman: [WIP] Skin implementation [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/589022 [11:28:47] (03CR) 10Nikerabbit: [C: 03+2] Amend Base10 color and remove (affected) PNG fallbacks [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/589816 (https://phabricator.wikimedia.org/T248393) (owner: 10VolkerE) [11:31:36] (03Abandoned) 10Daniel Kinzler: Use XML dump schema version 0.11 for new installs. [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/552566 (https://phabricator.wikimedia.org/T238921) (owner: 10Daniel Kinzler) [11:33:14] (03CR) 10Art-Baltai: Hard deprecate Article methods proxying to WikiPage (0318 comments) [core] - 10https://gerrit.wikimedia.org/r/581247 (https://phabricator.wikimedia.org/T239975) (owner: 10Art-Baltai) [11:36:11] (03CR) 10Peter.ovchyn: rest: Add 'thumbnail' and 'description' fields to the search response (036 comments) [core] - 10https://gerrit.wikimedia.org/r/588999 (https://phabricator.wikimedia.org/T250144) (owner: 10Peter.ovchyn) [11:37:28] (03CR) 10Peter.ovchyn: rest: Add 'thumbnail' and 'description' fields to the search response (032 comments) [core] - 10https://gerrit.wikimedia.org/r/588999 (https://phabricator.wikimedia.org/T250144) (owner: 10Peter.ovchyn) [11:37:53] (03CR) 10jerkins-bot: [V: 04-1] rest: Add 'thumbnail' and 'description' fields to the search response [core] - 10https://gerrit.wikimedia.org/r/588999 (https://phabricator.wikimedia.org/T250144) (owner: 10Peter.ovchyn) [11:38:25] 10Phabricator: Create subtask should not open new task with deadline form - https://phabricator.wikimedia.org/T209799 (10Dvorapa) Seems solved on my side as well [11:39:01] (03PS3) 10Aaron Schulz: objectcache: make BagOStuff key encoding more consistent [core] - 10https://gerrit.wikimedia.org/r/589465 (https://phabricator.wikimedia.org/T250239) [11:41:32] (03CR) 10Daniel Kinzler: rest: Add 'thumbnail' and 'description' fields to the search response (032 comments) [core] - 10https://gerrit.wikimedia.org/r/588999 (https://phabricator.wikimedia.org/T250144) (owner: 10Peter.ovchyn) [11:41:42] (03PS3) 10Kevin Bazira: Add notification type success to mw.notify [core] - 10https://gerrit.wikimedia.org/r/587549 (https://phabricator.wikimedia.org/T250788) [11:43:24] (03Merged) 10jenkins-bot: Amend Base10 color and remove (affected) PNG fallbacks [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/589816 (https://phabricator.wikimedia.org/T248393) (owner: 10VolkerE) [11:43:29] (03CR) 10Aaron Schulz: [C: 03+2] Use MediaWikiServices::getAuthManager [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/585889 (owner: 10Umherirrender) [11:44:42] 10MediaWiki-User-management: Ensure test coverage for SpecialBlock::processForm and SpecialUnblock::processUnblock is as full as possible - https://phabricator.wikimedia.org/T250790 (10Tchanders) [11:45:41] (03Merged) 10jenkins-bot: Use MediaWikiServices::getAuthManager [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/585889 (owner: 10Umherirrender) [11:48:26] (03CR) 10Daniel Kinzler: rest: Add 'thumbnail' and 'description' fields to the search response (032 comments) [core] - 10https://gerrit.wikimedia.org/r/588999 (https://phabricator.wikimedia.org/T250144) (owner: 10Peter.ovchyn) [11:49:37] 10observability: Grafana X-Frame-Options Policy - https://phabricator.wikimedia.org/T250792 (10ayounsi) p:05Triage→03Low [12:00:21] 10Phabricator: Create subtask should not open new task with deadline form - https://phabricator.wikimedia.org/T209799 (10mmodell) 05Stalled→03Resolved fixed upstream [12:02:17] (03CR) 10Kevin Bazira: "@Volker, kindly help review this. Thanks!" [core] - 10https://gerrit.wikimedia.org/r/587549 (https://phabricator.wikimedia.org/T250788) (owner: 10Kevin Bazira) [12:03:59] (03PS2) 10Shirayuki: Add Special:MyLanguage for better user experience [extensions/GoogleAnalyticsTopPages] - 10https://gerrit.wikimedia.org/r/589835 [12:17:20] 10Fresh, 10Patch-For-Review: Move Fresh to Gerrit (mirror to GitHub) - https://phabricator.wikimedia.org/T250766 (10hashar) p:05Triage→03Medium I have dropped the CI configuration since it ran commands directly on the Jenkins agent: ` - shell: TERM=xterm ./src/test ` That should instead by run in a contai... [12:29:14] 10Inuka-Team, 10Wikipedia-Previews (Mobile-Prototype): Layout for Wikipedia Preview card - https://phabricator.wikimedia.org/T250796 (10AMuigai) [12:33:45] 10Inuka-Team, 10Wikipedia-Previews (Mobile-Prototype): Open and close actions for Wikipedia Preview on mobile - https://phabricator.wikimedia.org/T250797 (10AMuigai) [12:38:16] 10Inuka-Team: Swipe up functionality - https://phabricator.wikimedia.org/T250798 (10AMuigai) [12:38:37] 10Inuka-Team, 10Wikipedia-Previews (Mobile-Prototype): Swipe up functionality - https://phabricator.wikimedia.org/T250798 (10AMuigai) [12:41:03] 10Inuka-Team, 10Wikipedia-Previews (Mobile-Prototype): Swipe up functionality - https://phabricator.wikimedia.org/T250798 (10AMuigai) [12:44:10] 10Inuka-Team, 10Wikipedia-Previews (Mobile-Prototype): Swipe up functionality - https://phabricator.wikimedia.org/T250798 (10AMuigai) [12:46:43] 10Inuka-Team, 10Wikipedia-Previews (Mobile-Prototype): Image galleries within Wikipedia Preview - https://phabricator.wikimedia.org/T250799 (10AMuigai) [12:47:02] (03PS1) 10ItSpiderman: [WIP] Different main page [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/591327 [12:51:24] 10Inuka-Team, 10Wikipedia-Previews (Mobile-Prototype): Set up translations on TWN for Wikipedia Preview - https://phabricator.wikimedia.org/T250800 (10AMuigai) [12:53:38] (03CR) 10Tchanders: [C: 04-1] "Thanks for getting the ball rolling on this Urbanecm - and thanks for bearing with us." (035 comments) [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) (owner: 10Urbanecm) [12:54:02] (03CR) 10Daniel Kinzler: [C: 03+1] "Looks good, just some documentation nitpicks." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/565462 (https://phabricator.wikimedia.org/T248527) (owner: 10Ppchelko) [13:02:54] (03PS2) 10Bmansurov: Remove the register button [research/wikiworkshop] - 10https://gerrit.wikimedia.org/r/591205 [13:03:01] (03CR) 10Bmansurov: [V: 03+2 C: 03+2] Remove the register button [research/wikiworkshop] - 10https://gerrit.wikimedia.org/r/591205 (owner: 10Bmansurov) [13:03:36] (03CR) 10Daniel Kinzler: Introduce backend classes for (un)blocking users (031 comment) [core] - 10https://gerrit.wikimedia.org/r/588104 (https://phabricator.wikimedia.org/T189073) (owner: 10Urbanecm) [13:05:31] (03PS2) 10ItSpiderman: Init [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/588671 (https://phabricator.wikimedia.org/T247837) [13:07:24] (03CR) 10Peter.ovchyn: rest: Add 'thumbnail' and 'description' fields to the search response (033 comments) [core] - 10https://gerrit.wikimedia.org/r/588999 (https://phabricator.wikimedia.org/T250144) (owner: 10Peter.ovchyn) [13:08:34] (03PS6) 10ItSpiderman: [WIP] Skin implementation [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/589022 (https://phabricator.wikimedia.org/T247837) [13:08:53] (03PS2) 10ItSpiderman: [WIP] Different main page [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/591327 (https://phabricator.wikimedia.org/T247837) [13:09:54] (03PS3) 10ItSpiderman: Init [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/588671 (https://phabricator.wikimedia.org/T247837) [13:10:02] (03PS7) 10ItSpiderman: [WIP] Skin implementation [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/589022 (https://phabricator.wikimedia.org/T247837) [13:13:28] (03PS3) 10ItSpiderman: [WIP] Different main page [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/591327 (https://phabricator.wikimedia.org/T247837) [13:14:57] (03PS2) 10Abijeet Patro: Add fallback language support when sending translatable page as message [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/591317 (https://phabricator.wikimedia.org/T165128) [13:16:33] (03CR) 10Abijeet Patro: Add fallback language support when sending translatable page as message (034 comments) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/591317 (https://phabricator.wikimedia.org/T165128) (owner: 10Abijeet Patro) [13:18:48] (03CR) 10Daniel Kinzler: rest: Add 'thumbnail' and 'description' fields to the search response (032 comments) [core] - 10https://gerrit.wikimedia.org/r/588999 (https://phabricator.wikimedia.org/T250144) (owner: 10Peter.ovchyn) [13:21:10] 10CommRel-Specialists-Support (Apr-Jun-2020): FY2020-21 Annual Plan community consultation - request for support - https://phabricator.wikimedia.org/T246590 (10Elitre) 05Open→03Stalled This is fine by us now, James. Thanks so much for the heads-up! [13:24:17] 10MediaWiki-extensions-Translate, 10MassMessage, 10Language-Team (Language-2020-Focus-Sprint), 10MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), 10Patch-For-Review: Allow delivery of multilingual content (TechNews, Editing newsletter, ...) in fallback languages - https://phabricator.wikimedia.org/T165128 (10El... [13:24:27] (03PS3) 10Abijeet Patro: Add fallback language support when sending translatable page as message [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/591317 (https://phabricator.wikimedia.org/T165128) [13:27:05] 10Dumps-Generation, 10MachineVision, 10Security-Team, 10Structured-Data-Backlog, 10SDC-Statements (Machine-vision-depicts): Data dumps for the MachineVision extension - https://phabricator.wikimedia.org/T236431 (10Mholloway) Thank you, @ArielGlenn! [13:31:40] 10MediaWiki-Revision-backend, 10Core Platform Team Workboards (External Code Reviews), 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove support for Revisions from ContentHandler::getUndoContent - https://phabricator.wikimedia.org/T250773 (10DannyS712) [13:32:24] 10MediaWiki-General, 10JavaScript, 10Patch-For-Review: Add notification type success to mw.notify bubble notifications - https://phabricator.wikimedia.org/T250788 (10DannyS712) [13:33:22] 10MediaWiki-Special-pages, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), 10Performance Issue, and 4 others: Some Special:Contributions requests cause "Error: 0" from database or WMFTimeoutException - https://phabricator.wikimedia.org/T234450 (10daniel) @Mar... [13:34:05] (03PS1) 10Yaron Koren: Version 1.0 [extensions/Mpdf] - 10https://gerrit.wikimedia.org/r/591332 [13:34:09] 10MediaWiki-extensions-Other, 10Projects-Cleanup, 10Repository-Admins, 10Wikimedia-GitHub, and 2 others: Archive the UnblockMe extension - https://phabricator.wikimedia.org/T250564 (10hashar) [13:34:21] 10MediaWiki-Codesniffer, 10User-DannyS712: PHPCS complains about unused use statements if used in @phan-var - https://phabricator.wikimedia.org/T250765 (10DannyS712) >>! In T250765#6074362, @thiemowmde wrote: > Sure. Let's just add it to the UnusedUseStatement sniff! I tried that; `@phan-var` isn't a proper t... [13:35:07] (03PS2) 10Yaron Koren: Version 1.0 [extensions/Mpdf] - 10https://gerrit.wikimedia.org/r/591332 [13:36:37] 10MediaWiki-Special-pages, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), 10Performance Issue, and 4 others: Some Special:Contributions requests cause "Error: 0" from database or WMFTimeoutException - https://phabricator.wikimedia.org/T234450 (10daniel) Ah,... [13:36:42] 10MediaWiki-extensions-Other, 10Projects-Cleanup, 10Repository-Admins, 10Wikimedia-GitHub, and 2 others: Archive the UnblockMe extension - https://phabricator.wikimedia.org/T250564 (10hashar) > Archived on MediaWiki.org by @Kghbln (see T190671). Also, no code was ever added to the Gerrit repository, and th... [13:40:26] (03CR) 10Krinkle: "recheck" [fresh] - 10https://gerrit.wikimedia.org/r/591214 (https://phabricator.wikimedia.org/T250766) (owner: 10Krinkle) [13:45:56] 10MediaWiki-Stakeholders-Group, 10TechCom-RFC: RFC: Hybrid extension management - https://phabricator.wikimedia.org/T250406 (10Tgr) If MyExtension v1.0 is compatible with MW 1.31+ and v2.0 is compatible with MW1.35+ and you have downloaded MW 1.31, added `"mediawiki/myextension": "*"` to `composer.json` and ra... [13:46:17] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board), 10Patch-For-Review: Enable the Reply tool in the Project namespace (Wikipedia:) and other "wgExtraSignaturesNamespaces" - https://phabricator.wikimedia.org/T249036 (10Tacsipacsi) >>! In T249036#6074517, @Esanders wrote: > and I think it's clear f... [13:47:05] (03PS4) 10Abijeet Patro: Move some PHP files into the includes/ for consistency [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/580308 (owner: 10Zoranzoki21) [13:47:09] (03PS5) 10Aaron Schulz: rdbms: add IDatabase::QUERY_* flags to obviate isWriteQuery() [core] - 10https://gerrit.wikimedia.org/r/582022 [13:47:26] (03PS2) 10Reedy: Use AutoloadNamespaces for maintenance scripts [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591126 (https://phabricator.wikimedia.org/T187154) [13:48:25] (03CR) 10Abijeet Patro: "> Patch Set 3:" [extensions/TwnMainPage] - 10https://gerrit.wikimedia.org/r/580308 (owner: 10Zoranzoki21) [13:50:18] (03PS1) 10Reedy: Update path to maintenance script [vagrant] - 10https://gerrit.wikimedia.org/r/591334 [13:50:37] 10Discovery-Search (Current work), 10Epic: [TRACKING] WDQS / Blazegraph optimization / bug fixes - https://phabricator.wikimedia.org/T235759 (10Gehel) 05Open→03Resolved Closing this tracking task as Igor isn't working on this anymore. Subtasks stay valid. [13:56:58] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_filters_insource_api_regex_insource_doesn_t_break_other_clauses, boolean_oper" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591126 (https://phabricator.wikimedia.org/T187154) (owner: 10Reedy) [13:56:59] 10MediaWiki-extensions-Translate, 10MassMessage, 10Language-Team (Language-2020-Focus-Sprint), 10MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), 10Patch-For-Review: Allow delivery of multilingual content (TechNews, Editing newsletter, ...) in fallback languages - https://phabricator.wikimedia.org/T165128 (10Ni... [13:57:28] (03CR) 10Kosta Harlan: [C: 03+1] docs: Update install command to use gerrit.wikimedia.org (032 comments) [fresh] - 10https://gerrit.wikimedia.org/r/591214 (https://phabricator.wikimedia.org/T250766) (owner: 10Krinkle) [13:58:27] (03PS3) 10Reedy: Use AutoloadNamespaces for maintenance scripts [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591126 (https://phabricator.wikimedia.org/T187154) [13:58:47] 10MediaWiki-User-management: Special:Block should not play the role of a central blocking service/utility - https://phabricator.wikimedia.org/T250737 (10Tchanders) [13:58:52] 10MediaWiki-Special-pages, 10MediaWiki-User-management, 10Anti-Harassment (The Letter Song), 10Core Platform Team Workboards (Clinic Duty Team), and 3 others: Refactor logic for doing and logging unblock out of SpecialUnblock so it can be easily reused elsewhere - https://phabricator.wikimedia.org/T250020 (... [13:58:54] 10MediaWiki-General: The code in HTMLUserTextField, as used on Special:Block, would incorrectly check IP ranges (if it worked) - https://phabricator.wikimedia.org/T177329 (10Tchanders) [13:58:59] 10MediaWiki-Special-pages, 10MediaWiki-User-management, 10Anti-Harassment (The Letter Song), 10CPT Initiatives (Decoupling (CDP2)), and 4 others: Refactor logic for creating and logging a block out of SpecialBlock so it can be easily reused elsewhere - https://phabricator.wikimedia.org/T189073 (10Tchanders) [13:59:04] 10MediaWiki-Revision-backend, 10MediaWiki-extensions-FlaggedRevs, 10Growth-Team, 10MachineVision, and 9 others: Replace `ArticleRollbackComplete` hook - https://phabricator.wikimedia.org/T250543 (10Mholloway) That sounds fine to me. [13:59:08] 10MediaWiki-Special-pages, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), 10Performance Issue, and 4 others: Some Special:Contributions requests cause "Error: 0" from database or WMFTimeoutException - https://phabricator.wikimedia.org/T234450 (10Marostegui)... [13:59:53] (03CR) 10jerkins-bot: [V: 04-1] rdbms: add IDatabase::QUERY_* flags to obviate isWriteQuery() [core] - 10https://gerrit.wikimedia.org/r/582022 (owner: 10Aaron Schulz) [14:01:34] (03PS20) 10Peter.ovchyn: rest: Add 'thumbnail' and 'description' fields to the search response [core] - 10https://gerrit.wikimedia.org/r/588999 (https://phabricator.wikimedia.org/T250144) [14:04:29] (03CR) 10Nikerabbit: [C: 04-1] Add fallback language support when sending translatable page as message (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/591317 (https://phabricator.wikimedia.org/T165128) (owner: 10Abijeet Patro) [14:05:32] 10CirrusSearch, 10Discovery-Search: Fix CirrusSearch maint scripts call sites to use file names compliant with autoloader - https://phabricator.wikimedia.org/T250806 (10dcausse) [14:06:50] (03PS2) 10Reedy: Update path to CirrusSearch maintenance script [vagrant] - 10https://gerrit.wikimedia.org/r/591334 (https://phabricator.wikimedia.org/T250806) [14:06:51] 04(no projects): Layout of the citations on the Cite This Page page is not correct on Wikipedia - https://phabricator.wikimedia.org/T250807 (10cries) [14:07:18] (03PS4) 10Reedy: Use AutoloadNamespaces for maintenance scripts [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591126 (https://phabricator.wikimedia.org/T187154) [14:07:27] (03CR) 10jerkins-bot: [V: 04-1] Update path to CirrusSearch maintenance script [vagrant] - 10https://gerrit.wikimedia.org/r/591334 (https://phabricator.wikimedia.org/T250806) (owner: 10Reedy) [14:10:29] (03PS3) 10Reedy: Update path to CirrusSearch maintenance scripts [vagrant] - 10https://gerrit.wikimedia.org/r/591334 (https://phabricator.wikimedia.org/T250806) [14:12:55] (03PS21) 10Peter.ovchyn: rest: Add 'thumbnail' and 'description' fields to the search response [core] - 10https://gerrit.wikimedia.org/r/588999 (https://phabricator.wikimedia.org/T250144) [14:14:30] (03CR) 10Peter.ovchyn: rest: Add 'thumbnail' and 'description' fields to the search response (032 comments) [core] - 10https://gerrit.wikimedia.org/r/588999 (https://phabricator.wikimedia.org/T250144) (owner: 10Peter.ovchyn) [14:14:48] 10Design, 10WMDE-Design, 10Wikidata, 10Wikidata Design System: Styles and component consolidation & documentation - https://phabricator.wikimedia.org/T243388 (10Sarai-WMDE) [14:16:17] 10Design, 10WMDE-Design, 10Wikidata, 10Wikidata Design System: Styles and component consolidation & documentation - https://phabricator.wikimedia.org/T243388 (10Sarai-WMDE) [14:17:29] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591126 (https://phabricator.wikimedia.org/T187154) (owner: 10Reedy) [14:20:56] (03CR) 10ZPapierski: [C: 03+2] Suppress warnings for new SpotBugs analyzer. [search/extra] - 10https://gerrit.wikimedia.org/r/589632 (owner: 10Gehel) [14:21:52] (03CR) 10ZPapierski: [C: 03+2] Removed useless SerialVersionUUID. [search/extra] - 10https://gerrit.wikimedia.org/r/589631 (owner: 10Gehel) [14:22:57] (03CR) 10ZPapierski: [C: 03+2] Suppress warning on new spotbugs check [search/glent] - 10https://gerrit.wikimedia.org/r/589648 (owner: 10Gehel) [14:24:29] (03Merged) 10jenkins-bot: Suppress warning on new spotbugs check [search/glent] - 10https://gerrit.wikimedia.org/r/589648 (owner: 10Gehel) [14:25:12] (03Merged) 10jenkins-bot: Removed useless SerialVersionUUID. [search/extra] - 10https://gerrit.wikimedia.org/r/589631 (owner: 10Gehel) [14:25:14] (03Merged) 10jenkins-bot: Suppress warnings for new SpotBugs analyzer. [search/extra] - 10https://gerrit.wikimedia.org/r/589632 (owner: 10Gehel) [14:25:16] (03PS1) 10Reedy: Remove maintenance script symlinks [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591339 [14:25:42] (03PS2) 10Reedy: Remove maintenance script symlinks [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591339 (https://phabricator.wikimedia.org/T250806) [14:25:47] 10CirrusSearch, 10Discovery-Search, 10SiteMatrix: CirrusSearch throws an error on several wikis - https://phabricator.wikimedia.org/T250810 (10Dvorapa) [14:26:00] (03CR) 10Reedy: [C: 04-2] "Not yet" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591339 (https://phabricator.wikimedia.org/T250806) (owner: 10Reedy) [14:26:52] 10CirrusSearch, 10Discovery-Search, 10SiteMatrix: CirrusSearch throws an error on several wikis - https://phabricator.wikimedia.org/T250810 (10Dvorapa) [14:27:01] (03CR) 10jerkins-bot: [V: 04-1] Use AutoloadNamespaces for maintenance scripts [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591126 (https://phabricator.wikimedia.org/T187154) (owner: 10Reedy) [14:27:27] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_api_geo_nearcoord_with_coordinate, clean_api_geo_nearcoord_with_coordinate_an" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591116 (owner: 10Reedy) [14:29:35] 10MediaWiki-extensions-Other, 10Projects-Cleanup, 10Repository-Admins, 10Wikimedia-GitHub, and 2 others: Archive the UnblockMe extension - https://phabricator.wikimedia.org/T250564 (10Aklapper) >>! In T250564#6074939, @hashar wrote: > Note that it had some changes proposed in Gerrit: https://gerrit.wikimed... [14:29:38] (03PS2) 10Kosta Harlan: Add page linked event title blacklist [extensions/Echo] - 10https://gerrit.wikimedia.org/r/591154 (https://phabricator.wikimedia.org/T46787) [14:29:52] (03PS1) 10Esanders: Create a toolbarReady hook for attaching toolbar tools [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/591341 [14:31:34] (03PS1) 10Santhosh: WIP: Section selector [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/591343 [14:31:42] 10MediaWiki-API, 10CirrusSearch, 10Core Platform Team, 10Discovery-Search, 10Pywikibot: site.search() does not work for wikimania:wikimania - https://phabricator.wikimedia.org/T250811 (10Dvorapa) [14:34:40] (03PS5) 10Reedy: Use AutoloadNamespaces for maintenance scripts [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591126 (https://phabricator.wikimedia.org/T187154) [14:34:47] (03PS3) 10Reedy: Remove maintenance script symlinks [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591339 (https://phabricator.wikimedia.org/T250806) [14:35:03] (03PS4) 10Reedy: Remove maintenance script symlinks [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591339 (https://phabricator.wikimedia.org/T250806) [14:38:17] 10CheckUser, 10Patch-For-Review: Checkuser should reblock users and tag pages even if users are already blocked - https://phabricator.wikimedia.org/T249562 (10Tchanders) We might want to hear from a few more users about this? Presumably the check users would have to be a bit more careful about using this form... [14:39:12] (03CR) 10Tchanders: [C: 03+1] "Looks good from a technical perspective." (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/586462 (https://phabricator.wikimedia.org/T249562) (owner: 10Urbanecm) [14:39:59] (03PS1) 10Reedy: Use namespaced CirrusSearch class [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/591346 [14:40:32] 10CheckUser, 10Anti-Harassment (The Letter Song): Buttons in table cells are cluttered and cause a jump on hover - https://phabricator.wikimedia.org/T250051 (10Tchanders) a:03Tchanders [14:41:56] (03CR) 10Urbanecm: Reblock and tag blocked users in Special:Checkuser (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/586462 (https://phabricator.wikimedia.org/T249562) (owner: 10Urbanecm) [14:42:32] (03PS1) 10Esanders: Wait for document ready before init [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/591347 [14:42:34] (03PS1) 10Esanders: Use more specific disable directive [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/591348 [14:42:36] (03PS1) 10Esanders: Ensure init scripts run last [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/591349 [14:42:38] (03PS1) 10Esanders: Use hook to add TemplateWizard to the toolbar [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/591350 [14:43:16] 10CheckUser, 10Patch-For-Review: Checkuser should reblock users and tag pages even if users are already blocked - https://phabricator.wikimedia.org/T249562 (10Urbanecm) >>! In T249562#6075204, @Tchanders wrote: > We might want to hear from a few more users about this? Presumably the check users would have to b... [14:44:42] (03PS2) 10Esanders: Use more specific disable directive [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/591348 [14:44:44] (03PS2) 10Esanders: Ensure init scripts run last [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/591349 [14:44:46] (03PS2) 10Esanders: Use hook to add TemplateWizard to the toolbar [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/591350 [14:45:42] (03CR) 10jerkins-bot: [V: 04-1] WIP: Section selector [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/591343 (owner: 10Santhosh) [14:46:35] (03CR) 10jerkins-bot: [V: 04-1] Wait for document ready before init [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/591347 (owner: 10Esanders) [14:47:09] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591126 (https://phabricator.wikimedia.org/T187154) (owner: 10Reedy) [14:47:24] (03PS1) 10Reedy: Use namespaced CirrusSearch class [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/591352 [14:47:30] 10CPT Initiatives (API Gateway), 10Core Platform Team Workboards (Green): Configure permissions - https://phabricator.wikimedia.org/T249834 (10CCicalese_WMF) a:03CCicalese_WMF [14:48:06] 10CPT Initiatives (API Gateway), 10Core Platform Team Workboards (Epics), 10Epic: Create API Portal MVP - https://phabricator.wikimedia.org/T247837 (10CCicalese_WMF) [14:48:08] 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Spike, 10Vue.js: [Spike] Should Desktop Improvements use Vue 2 or Vue 3 for Vue.js search? - https://phabricator.wikimedia.org/T249725 (10Jdrewniak) When googling "is Vue 3 production ready" [[ https://forum.vuejs.org/t/is-vue-3-production-ready/84148 | this si... [14:49:22] (03CR) 10Sebastian Berlin (WMSE): [C: 04-1] "There are also a few comments from an earlier patchset." (032 comments) [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/579599 (https://phabricator.wikimedia.org/T246079) (owner: 10Karl Wettin (WMSE)) [14:49:38] (03PS17) 10Esanders: WIP Switching between VE & wikitext (plain) [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/577601 [14:50:34] (03PS1) 10Esanders: eslint: Disable max-len [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/591353 [14:50:58] 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Spike, 10Vue.js: [Spike] Should Desktop Improvements use Vue 2 or Vue 3 for Vue.js search? - https://phabricator.wikimedia.org/T249725 (10Jdrewniak) (sidenote) as of April 15th we also have Vuex! https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/583818/ [14:51:02] 10MediaWiki-extensions-Translate, 10MassMessage, 10Language-Team (Language-2020-Focus-Sprint), 10MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), 10Patch-For-Review: Allow delivery of multilingual content (TechNews, Editing newsletter, ...) in fallback languages - https://phabricator.wikimedia.org/T165128 (10El... [14:52:04] 10MachineVision, 10Structured-Data-Backlog (Current Work), 10Vue.js: [Spike] explore porting MachineVision front-end to Vue.js - https://phabricator.wikimedia.org/T248405 (10AnneT) [14:53:23] 10CirrusSearch, 10Discovery-Search: Deal with dropping of Global CirrusSearch class - https://phabricator.wikimedia.org/T250812 (10Reedy) [14:54:15] 10Desktop Improvements, 10Epic, 10Performance-Team (Radar): [EPIC] New header for desktop improvements project - https://phabricator.wikimedia.org/T240856 (10ovasileva) [14:54:52] (03CR) 10jerkins-bot: [V: 04-1] Use AutoloadNamespaces for maintenance scripts [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591126 (https://phabricator.wikimedia.org/T187154) (owner: 10Reedy) [14:56:56] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_api_update_weight_Redirects_to_redirects_don_t_count_in_the_score" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591339 (https://phabricator.wikimedia.org/T250806) (owner: 10Reedy) [14:58:03] (03PS18) 10Esanders: WIP Switching between VE & wikitext (plain) [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/577601 [14:58:38] (03PS8) 10Reedy: Allow using namespaced CirrusSearch\\CirrusSearch class for $wgSearchType [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591116 (https://phabricator.wikimedia.org/T250812) [15:00:21] 10CirrusSearch, 10Discovery-Search, 10Patch-For-Review: Deal with dropping of Global CirrusSearch class - https://phabricator.wikimedia.org/T250812 (10Reedy) [15:01:02] 10Wikimedia Design Style Guide: Document interaction colors - https://phabricator.wikimedia.org/T249347 (10Sarai-WMDE) [15:01:48] 10Editing QA: Error when trying to save an edit on Wikipedia - https://phabricator.wikimedia.org/T250815 (10Richard_Nevell_WMUK) [15:02:14] 10CirrusSearch, 10Discovery-Search, 10Patch-For-Review: Deal with dropping of Global CirrusSearch class - https://phabricator.wikimedia.org/T250812 (10Reedy) [15:02:24] (03PS1) 10Reedy: [WIP] Drop global namespace CirrusSearch class [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591356 [15:03:09] (03CR) 10Reedy: [C: 04-2] [WIP] Drop global namespace CirrusSearch class [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591356 (owner: 10Reedy) [15:03:49] 10Wikimedia-Portals, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4): Lighthouse warning "Properly size images" for www.wikipedia.org - https://phabricator.wikimedia.org/T242498 (10Jdrewniak) 05Open→03Resolved This change has been deployed and the notice is no longer showing up on lighth... [15:05:07] (03CR) 10Daimona Eaytoy: Use AutoloadNamespaces for maintenance scripts (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591126 (https://phabricator.wikimedia.org/T187154) (owner: 10Reedy) [15:06:05] (03CR) 10Reedy: Use AutoloadNamespaces for maintenance scripts (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591126 (https://phabricator.wikimedia.org/T187154) (owner: 10Reedy) [15:06:32] (03PS6) 10Reedy: Use AutoloadNamespaces for maintenance scripts [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591126 (https://phabricator.wikimedia.org/T187154) [15:06:47] (03PS3) 10Daimona Eaytoy: Collect causedby properties in arrays, not string [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/591104 [15:07:06] 10CirrusSearch, 10Discovery-Search, 10SiteMatrix: CirrusSearch throws an error on several wikis - https://phabricator.wikimedia.org/T250810 (10Aklapper) 05Open→03Stalled @Dvorapa: Please provide a link which shows the issue. Or explain what a "CirrusSearch keyword" is. I go to https://sh.wikipedia.org an... [15:07:35] 10CirrusSearch, 10Discovery-Search: CirrusSearch throws an error on several wikis - https://phabricator.wikimedia.org/T250810 (10Aklapper) [15:08:27] (03PS13) 10Dvogel hallowelt: [WIP] Initial commit [extensions/FlexiSkin] - 10https://gerrit.wikimedia.org/r/588470 [15:10:28] 10CirrusSearch, 10Discovery-Search: CirrusSearch throws an error on several wikis - https://phabricator.wikimedia.org/T250810 (10Dvorapa) [15:10:34] 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4): [AMC] Regression on History page in Advanced Mode - https://phabricator.wikimedia.org/T249518 (10alexhollender) >>! In T249518#6073738, @Jdlrobson wrote: > Alex is this still an issue? Hmm, it's looking better in production but sti... [15:10:55] 10CirrusSearch, 10Discovery-Search: CirrusSearch throws an error on several wikis - https://phabricator.wikimedia.org/T250810 (10Dvorapa) Sorry, forgot to mention which keyword, thank you! [15:11:13] 10CirrusSearch, 10Discovery-Search: CirrusSearch throws an error on several wikis - https://phabricator.wikimedia.org/T250810 (10Dvorapa) [15:11:44] 10CirrusSearch, 10Discovery-Search: CirrusSearch throws an error on several wikis - https://phabricator.wikimedia.org/T250810 (10Dvorapa) [15:12:12] 10Editing QA: Error when trying to save an edit on Wikipedia - https://phabricator.wikimedia.org/T250815 (10Richard_Nevell_WMUK) One editor reports that the problem is persisting. They have tried with Google Chrome and Microsoft Edge and are running Windows 10. [15:12:44] 10CirrusSearch, 10Discovery-Search: CirrusSearch throws an error on several wikis - https://phabricator.wikimedia.org/T250810 (10Dvorapa) [15:13:28] 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4): [AMC] Regression on History page in Advanced Mode - https://phabricator.wikimedia.org/T249518 (10alexhollender) [15:16:25] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591126 (https://phabricator.wikimedia.org/T187154) (owner: 10Reedy) [15:16:33] (03CR) 10Daimona Eaytoy: "recheck" [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/591104 (owner: 10Daimona Eaytoy) [15:19:49] 10MobileFrontend, 10Mobile-Web-Settings, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing-team (Tracking): Ability to select different editors. - https://phabricator.wikimedia.org/T205778 (10JTannerWMF) This task is possibly related to T240697 when we explore that work we can return to this task. [15:20:17] 10MobileFrontend, 10Mobile-Web-Settings, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Editing-team (Tracking): Ability to select different editors for mobile web - https://phabricator.wikimedia.org/T205778 (10JTannerWMF) [15:21:17] 10MinervaNeue: MinervaNeue icons in menu should follow same default color `#54595d` - https://phabricator.wikimedia.org/T250774 (10alexhollender) @Volker_E as part of the recent logo work (T246170) the "WikipediA" wordmark on the mobile website will appear black instead of gray (see [[ https://en.m.wikipedia.bet... [15:21:19] (03CR) 10Reedy: Init (033 comments) [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/588671 (https://phabricator.wikimedia.org/T247837) (owner: 10ItSpiderman) [15:22:41] 10MediaWiki-Codesniffer: How to handle the nullable operator on multi type lists in code - https://phabricator.wikimedia.org/T250734 (10Daimona) I also prefer the 4th version, and agree with Thiemo above: while not wrong, 1 and 3 are a bit confusing, and 2 looks very redundant. I wonder if there's a standard abo... [15:23:40] 10CirrusSearch, 10Discovery-Search: CirrusSearch throws an error on several wikis - https://phabricator.wikimedia.org/T250810 (10EBernhardson) from sh wiktionary: ` { "error": { "root_cause": [ { "type": "parsing_exception", "reason": "[1:1091] [source_regex] failed to parse field [... [15:24:01] (03PS2) 10Krinkle: ooui: Fix ButtonWidget jsduck demo [core] - 10https://gerrit.wikimedia.org/r/589768 (https://phabricator.wikimedia.org/T168812) [15:25:28] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_api_geo_nearcoord_with_coordinate, clean_api_geo_nearcoord_with_coordinate_an" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591356 (owner: 10Reedy) [15:27:15] 10MediaWiki-Codesniffer: Spaces inside brackets used for array indexing - https://phabricator.wikimedia.org/T249872 (10Daimona) >>! In T249872#6074387, @daniel wrote: > What @thiemowmde said. I slightly prefer `$a[0]` to `$a[ 0 ]`, but I much prefer `$array[ $this->createKey( $inputValue ) ]` over ` $array[$this... [15:27:49] (03CR) 10Karl Wettin (WMSE): Add cache to Segmenter (032 comments) [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/579599 (https://phabricator.wikimedia.org/T246079) (owner: 10Karl Wettin (WMSE)) [15:32:42] 10MediaWiki-extensions-GuidedTour, 10ContentTranslation, 10Desktop Improvements, 10Front-end-Standards-Group, and 9 others: Replace jsduck with JSDoc3 across all Wikimedia code bases - https://phabricator.wikimedia.org/T138401 (10JTannerWMF) Is the Editing Team blocking anyone with this? [15:33:21] 10MachineVision, 10SDC-Statements (Machine-vision-depicts), 10Structured-Data-Backlog (Current Work): Add new edit tag for contributions via "Add Tag" on CAT - https://phabricator.wikimedia.org/T250747 (10egardner) a:03egardner [15:34:46] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591339 (https://phabricator.wikimedia.org/T250806) (owner: 10Reedy) [15:40:24] (03CR) 10Krinkle: [C: 03+2] Avoid use of deprecated CdnCacheUpdate method [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589771 (owner: 10Aaron Schulz) [15:40:43] 10CirrusSearch, 10Discovery-Search: CirrusSearch throws an error on several wikis when searching for "intitle:/regex/" - https://phabricator.wikimedia.org/T250810 (10Aklapper) [15:40:47] 10CirrusSearch, 10Discovery-Search: CirrusSearch throws an error on several wikis when searching for "intitle:/regex/" - https://phabricator.wikimedia.org/T250810 (10Aklapper) 05Stalled→03Open [15:44:09] (03CR) 10Hashar: "recheck due to a deadlock in the CI infrastructure ( T250820 )" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591356 (owner: 10Reedy) [15:44:11] (03CR) 10Hashar: "recheck due to a deadlock in the CI infrastructure ( T250820 )" [skins/WikimediaApiPortal] - 10https://gerrit.wikimedia.org/r/588671 (https://phabricator.wikimedia.org/T247837) (owner: 10ItSpiderman) [15:44:13] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591116 (https://phabricator.wikimedia.org/T250812) (owner: 10Reedy) [15:44:15] (03CR) 10Hashar: "recheck due to a deadlock in the CI infrastructure ( T250820 )" [core] - 10https://gerrit.wikimedia.org/r/589768 (https://phabricator.wikimedia.org/T168812) (owner: 10Krinkle) [15:44:17] (03CR) 10Hashar: "recheck due to a deadlock in the CI infrastructure ( T250820 )" [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/591104 (owner: 10Daimona Eaytoy) [15:44:19] 10MinervaNeue, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Wikimedia-production-error: [Minerva] Uncaught Error: Call to a member function isLocal() on boolean - https://phabricator.wikimedia.org/T250767 (10nray) [15:44:20] (03CR) 10Hashar: "recheck due to a deadlock in the CI infrastructure ( T250820 )" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591126 (https://phabricator.wikimedia.org/T187154) (owner: 10Reedy) [15:44:46] (03CR) 10Hashar: "recheck due to a deadlock in the CI infrastructure ( T250820 )" [extensions/FlexiSkin] - 10https://gerrit.wikimedia.org/r/588470 (owner: 10Dvogel hallowelt) [15:44:47] (03CR) 10Hashar: "recheck due to a deadlock in the CI infrastructure ( T250820 )" [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/590638 (https://phabricator.wikimedia.org/T250626) (owner: 10Luca Mauri) [15:44:49] (03CR) 10Hashar: "recheck due to a deadlock in the CI infrastructure ( T250820 )" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/591116 (https://phabricator.wikimedia.org/T250812) (owner: 10Reedy) [15:44:53] (03CR) 10Hashar: "recheck due to a deadlock in the CI infrastructure ( T250820 )" [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/577601 (owner: 10Esanders) [15:44:55] (03CR) 10Hashar: "recheck due to a deadlock in the CI infrastructure ( T250820 )" [extensions/GoogleAnalyticsTopPages] - 10https://gerrit.wikimedia.org/r/589835 (owner: 10Shirayuki) [15:45:57] 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4): [AMC] Regression on History page in Advanced Mode - https://phabricator.wikimedia.org/T249518 (10Jdlrobson) [15:47:03] (03PS7) 10Phuedx: Make legacy mode a feature [skins/Vector] - 10https://gerrit.wikimedia.org/r/585291 (https://phabricator.wikimedia.org/T244481) [15:47:07] (03PS6) 10Phuedx: [Hygiene] featureManager: Move SimpleRequirement... [skins/Vector] - 10https://gerrit.wikimedia.org/r/585525 [15:47:25] 10MediaWiki-Cache, 10Performance-Team, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review: Decouple simple Memcached interface and support pipelined operations without dependency on PECL - https://phabricator.wikimedia.org/T234455 (10Krinkle) >>! From Gerrit: > If this has no applicatio... [15:47:36] 10OOUI: New icons in OOUI v0.37.1 (specialPages, stopHand) are not aligned to pixel grid - https://phabricator.wikimedia.org/T248631 (10Volker_E) Context of specialPages: {F31770322} [15:48:10] (03CR) 10Phuedx: Make legacy mode a feature (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/585291 (https://phabricator.wikimedia.org/T244481) (owner: 10Phuedx) [15:48:20] 10MediaWiki-Page-editing, 10Performance-Team, 10Product-Analytics, 10Patch-For-Review: Tag edits made in the WikiEditor (2010 wikitext editor) - https://phabricator.wikimedia.org/T249038 (10Krinkle) [15:48:57] 10MediaWiki-Page-editing, 10VisualEditor, 10User-DannyS712: Visual Editor should not open edit window normally if user cannot create the page - https://phabricator.wikimedia.org/T238511 (10JTannerWMF) Unfortunately the Editing team can not prioritize this at this time. [15:49:49] (03CR) 10jerkins-bot: [V: 04-1] Remove reference to wfResetSessionID() and fix error related to LoginForm::successfulLogin() [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/590638 (https://phabricator.wikimedia.org/T250626) (owner: 10Luca Mauri) [15:49:56] 10MediaWiki-User-management, 10MediaWiki-User-preferences, 10CPT Initiatives (Decoupling (CDP2)): Factor user options definitions out of PreferencesFactory - https://phabricator.wikimedia.org/T250822 (10Pchelolo) [15:50:48] 10New-Readers, 10Readers-Web-Backlog (Design): Add the print button to mobile browsers other than Chrome - https://phabricator.wikimedia.org/T201954 (10Jdlrobson) It's possible to add the print button to Firefox now thanks to https://bugzilla.mozilla.org/show_bug.cgi?id=1414935 - although note older Firefox br... [15:52:57] 10Hashtags: Help fix [[ https://hashtags.wmflabs.org/ | hashtags tool]] - https://phabricator.wikimedia.org/T250823 (10Wikicology) [15:54:10] 10MediaWiki-General, 10MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), 10Technical-Debt (Deprecation process): Hard-deprecate and remove $wgContLang - https://phabricator.wikimedia.org/T245940 (10Krinkle) p:05Triage→03Medium [15:54:17] (03Merged) 10jenkins-bot: Avoid use of deprecated CdnCacheUpdate method [extensions/Flow] - 10https://gerrit.wikimedia.org/r/589771 (owner: 10Aaron Schulz) [15:54:46] 10Hashtags: Help fix hashtags tool - https://phabricator.wikimedia.org/T250823 (10JJMC89) [15:54:47] (03PS67) 10Ppchelko: Introduce UserOptionsManager and DefaultOptionsManager [core] - 10https://gerrit.wikimedia.org/r/565462 (https://phabricator.wikimedia.org/T248527) [15:57:33] 10MediaWiki-Page-editing, 10VisualEditor, 10Editing-team (Tracking), 10Voice & Tone: Confusing wording in message when session is no longer valid - https://phabricator.wikimedia.org/T190406 (10JTannerWMF) The Editing team will take a look at this [15:57:50] 10OOUI: New icons in OOUI v0.37.1 (specialPages, stopHand) are not aligned to pixel grid - https://phabricator.wikimedia.org/T248631 (10alexhollender) context of stopHand: {F31770373 width=400} [15:57:58] 10Growth-Scaling, 10Goal, 10Growth-Team (Current Sprint): Scale: deploy Growth features to 100 wikis - https://phabricator.wikimedia.org/T247507 (10MMiller_WMF) [15:59:08] (03CR) 10Ppchelko: Introduce UserOptionsManager and DefaultOptionsManager (033 comments) [core] - 10https://gerrit.wikimedia.org/r/565462 (https://phabricator.wikimedia.org/T248527) (owner: 10Ppchelko) [16:00:03] 10Structured-Data-Backlog (Current Work): Adjust Image Grid on Media Search - https://phabricator.wikimedia.org/T250729 (10matthiasmullie) Here's a screenshot of what I've got so far: {F31770350} These are the options to tweak this further, should we want to: - more cropping: the closer the images are to havin... [16:00:51] 10Phabricator: Create new custom fundraising form - https://phabricator.wikimedia.org/T243961 (10DStrine) 05Open→03Resolved [16:01:01] 10MediaWiki-Stakeholders-Group, 10TechCom-RFC: RFC: Hybrid extension management - https://phabricator.wikimedia.org/T250406 (10Nikerabbit) There are some really good points here, which made me to reconsider my stance on this. Most extensions do not follow semantic versioning. I bet 90% of them don't do any ki... [16:01:21] (03CR) 10Jdlrobson: [C: 03+2] "While testing I noticed the icon on watchlist is black not base20. I think a selector there needs updating." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/590625 (https://phabricator.wikimedia.org/T244444) (owner: 10VolkerE) [16:01:23] (03PS2) 10Jdlrobson: Rename user icon module to more general 'mobile.user.icons' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/590625 (https://phabricator.wikimedia.org/T244444) (owner: 10VolkerE) [16:01:25] (03CR) 10Jdlrobson: [C: 03+2] Rename user icon module to more general 'mobile.user.icons' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/590625 (https://phabricator.wikimedia.org/T244444) (owner: 10VolkerE) [16:01:27] (03PS6) 10Jdlrobson: Replace mobile.editor.images with OOUI icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/585857 (https://phabricator.wikimedia.org/T244444) (owner: 10VolkerE) [16:01:48] (03CR) 10jerkins-bot: [V: 04-1] [Hygiene] featureManager: Move SimpleRequirement... [skins/Vector] - 10https://gerrit.wikimedia.org/r/585525 (owner: 10Phuedx) [16:02:44] (03CR) 10jerkins-bot: [V: 04-1] Make legacy mode a feature [skins/Vector] - 10https://gerrit.wikimedia.org/r/585291 (https://phabricator.wikimedia.org/T244481) (owner: 10Phuedx) [16:04:37] 10MediaWiki-Codesniffer, 10User-DannyS712: PHPCS complains about unused use statements if used in @phan-var - https://phabricator.wikimedia.org/T250765 (10thiemowmde) Oh, indeed. Thanks for pointing that out! I can give it a try. [16:05:09] 10MediaWiki-extensions-CentralNotice, 10 Fr-cross-training, 10Fundraising-Backlog, 10Epic, 10Fundraising Sprint Heaven is a page on Wikipedia: Address final code review comments on geotargeting - https://phabricator.wikimedia.org/T250751 (10mepps) So to try to summarize what needs to be addressed: - [ ]... [16:07:09] (03CR) 10DCausse: [C: 03+2] Use namespaced CirrusSearch class [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/591346 (owner: 10Reedy) [16:08:54] (03PS7) 10Jdlrobson: Replace mobile.editor.images with OOUI icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/585857 (https://phabricator.wikimedia.org/T244444) (owner: 10VolkerE) [16:11:33] (03CR) 10Jdlrobson: [C: 03+1] "Raw github is down right now so I can't generate storybook to test. Will soon." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/585857 (https://phabricator.wikimedia.org/T244444) (owner: 10VolkerE) [16:12:12] 10Structured-Data-Backlog (Current Work): Add segmented controller / tabs for media types in media search - https://phabricator.wikimedia.org/T250730 (10matthiasmullie) A few WIP screenshots and some comments: Audio: {F31770346} Video: {F31770347} You'll see that: * the audio/video players are just native b... [16:12:54] 10Wikipedia-Android-App-Backlog: Improve app usability on Chrome OS - https://phabricator.wikimedia.org/T250726 (10Charlotte) p:05Triage→03Medium [16:14:06] (03CR) 10Jdlrobson: [C: 03+2] Use namespaced PageImages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591216 (owner: 10Reedy) [16:14:31] (03CR) 10Jdlrobson: [C: 03+2] Update to use namespaced XAnalytics class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591207 (owner: 10Reedy) [16:14:35] 10CheckUser, 10Patch-For-Review: Checkuser should reblock users and tag pages even if users are already blocked - https://phabricator.wikimedia.org/T249562 (10ST47) I personally would support this feature. In addition to the "blocked" notice provided by CheckUser itself (which is usually accurate), I think mos... [16:14:43] 10MediaWiki-Codesniffer: Spaces inside brackets used for array indexing - https://phabricator.wikimedia.org/T249872 (10Krinkle) I consider array bracket styling as something that does not benefit from blind consistency. Like deciding whether to put a new line between two lines of code, I believe it is best left... [16:14:55] (03PS11) 10Vidhi-Mody: Upgraded WebdriverIO from v4 to v5 [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/591060 (https://phabricator.wikimedia.org/T248223) [16:14:59] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10User-Addshore, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Cleanup rows from wb_items_per_site that should not be there any more - https://phabricator.wikimedia.org/T249613 (10Addshore) [16:15:09] (03CR) 10jerkins-bot: [V: 04-1] Rename user icon module to more general 'mobile.user.icons' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/590625 (https://phabricator.wikimedia.org/T244444) (owner: 10VolkerE) [16:16:16] (03CR) 10jerkins-bot: [V: 04-1] Replace mobile.editor.images with OOUI icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/585857 (https://phabricator.wikimedia.org/T244444) (owner: 10VolkerE) [16:16:57] (03CR) 10Jdlrobson: [C: 03+1] Fixed search_loggedin.js Selenium browser test [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/543697 (https://phabricator.wikimedia.org/T174018) (owner: 10Edward Tadros) [16:17:13] (03CR) 10Jdlrobson: [C: 03+2] Use standard palette color Base20 for icons [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/591257 (https://phabricator.wikimedia.org/T240500) (owner: 10VolkerE) [16:17:54] (03PS2) 10Jdlrobson: Cleanup: Remove unnecessary lazy loading wire up code [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/588028 [16:18:04] 10MediaWiki-Maintenance-system, 10Growth-Team, 10Performance-Team, 10StructuredDiscussions, and 5 others: sql.php must not run LoadExtensionSchemaUpdates - https://phabricator.wikimedia.org/T157651 (10Krinkle) [16:18:31] (03PS3) 10Jdlrobson: Cleanup: Remove unnecessary lazy loading wire up code [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/588028 (https://phabricator.wikimedia.org/T246838) [16:18:57] 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 1.0): Extra line being added elsewhere on page - https://phabricator.wikimedia.org/T249958 (10cscott) Presumably we need to ensure SOL context, but is there any case where SOL `:` *won't* trigger a DL unless we add an extra newline? IE, a... [16:19:14] 10MediaWiki-Maintenance-system, 10Growth-Team, 10Performance-Team, 10StructuredDiscussions, and 5 others: sql.php must not run LoadExtensionSchemaUpdates - https://phabricator.wikimedia.org/T157651 (10Krinkle) >>! In T157651#4765173, @gerritbot wrote: > [mediawiki/core@master] Structure test for wrong call... [16:20:23] (03CR) 10jerkins-bot: [V: 04-1] Upgraded WebdriverIO from v4 to v5 [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/591060 (https://phabricator.wikimedia.org/T248223) (owner: 10Vidhi-Mody) [16:24:48] (03CR) 10Gilles: [C: 03+1] Lazy loading with IntersectionObserver [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/587893 (https://phabricator.wikimedia.org/T246838) (owner: 10Jdlrobson) [16:27:34] (03CR) 10jerkins-bot: [V: 04-1] Replace mobile.editor.images with OOUI icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/585857 (https://phabricator.wikimedia.org/T244444) (owner: 10VolkerE) [16:28:08] (03Merged) 10jenkins-bot: Use namespaced CirrusSearch class [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/591346 (owner: 10Reedy) [16:28:43] 10MobileFrontend, 10phan-taint-check-plugin, 10Readers-Web-Backlog (Tracking): MobileFrontend taint-check fails - https://phabricator.wikimedia.org/T250630 (10Jdlrobson) [16:28:53] (03CR) 10Phuedx: [C: 03+2] Use namespaced CirrusSearch class [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/591352 (owner: 10Reedy) [16:31:07] (03CR) 10jerkins-bot: [V: 04-1] Use namespaced PageImages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591216 (owner: 10Reedy) [16:31:54] (03CR) 10Reedy: "CI issues?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591216 (owner: 10Reedy) [16:32:14] (03CR) 10Krinkle: docs: Update install command to use gerrit.wikimedia.org (031 comment) [fresh] - 10https://gerrit.wikimedia.org/r/591214 (https://phabricator.wikimedia.org/T250766) (owner: 10Krinkle) [16:35:34] (03CR) 10Jdlrobson: [C: 03+2] "Yeh there's a problem with the repo. Leave it with me." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591216 (owner: 10Reedy) [16:35:37] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 1.0), 10Patch-For-Review: Make `unload handlers` work for contributors using NWE - https://phabricator.wikimedia.org/T244942 (10DLynch) We talked about it in a meeting, and @Esanders supports the idea of making a gen... [16:36:26] (03CR) 10Jdlrobson: "version bump is done. Can I review now? (use depends-on rather than -2 in future as it doesn't block on me waiting on you :))" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/589730 (owner: 10VolkerE) [16:37:11] 10Hashtags: Help fix hashtags tool - https://phabricator.wikimedia.org/T250823 (10QEDK) @Wikicology Please give a detailed description of the issues. [16:37:34] (03CR) 10Krinkle: mediawiki.toc: Fix cookie persistence and remove redundant code (031 comment) [core] - 10https://gerrit.wikimedia.org/r/591109 (https://phabricator.wikimedia.org/T210789) (owner: 10Krinkle) [16:37:39] 10MobileFrontend, 10Readers-Web-Backlog, 10Technical-Debt, 10User-Jdlrobson: [Needs investigation] What's the way forward with setMainPage() in MobileFormatter.php? - https://phabricator.wikimedia.org/T231389 (10Jdlrobson) Sounds good. Shall we close this task out or should I leave it open for that patch? [16:37:49] (03PS3) 10Krinkle: mediawiki.toc: Fix cookie persistence and remove redundant code [core] - 10https://gerrit.wikimedia.org/r/591109 (https://phabricator.wikimedia.org/T210789) [16:39:13] (03PS2) 10Jdlrobson: Replace 'byteschanged' with OOUI's 'upTriangle' icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/590855 (https://phabricator.wikimedia.org/T244444) (owner: 10VolkerE) [16:41:27] (03PS16) 10Krinkle: Re-apply "Split FakeMaintenance and LoggedUpdateMaintenance to their own files" [core] - 10https://gerrit.wikimedia.org/r/576349 (https://phabricator.wikimedia.org/T246780) (owner: 10Daimona Eaytoy) [16:42:09] (03CR) 10jerkins-bot: [V: 04-1] Replace 'byteschanged' with OOUI's 'upTriangle' icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/590855 (https://phabricator.wikimedia.org/T244444) (owner: 10VolkerE) [16:42:11] (03PS17) 10Krinkle: maintenance: Move FakeMaintenance and LoggedUpdateMaintenance to their own files [core] - 10https://gerrit.wikimedia.org/r/576349 (https://phabricator.wikimedia.org/T246780) (owner: 10Daimona Eaytoy) [16:42:13] (03CR) 10Krinkle: [C: 03+1] maintenance: Move FakeMaintenance and LoggedUpdateMaintenance to their own files [core] - 10https://gerrit.wikimedia.org/r/576349 (https://phabricator.wikimedia.org/T246780) (owner: 10Daimona Eaytoy) [16:43:43] (03Merged) 10jenkins-bot: Update to use namespaced XAnalytics class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591207 (owner: 10Reedy) [16:44:03] (03Merged) 10jenkins-bot: Use standard palette color Base20 for icons [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/591257 (https://phabricator.wikimedia.org/T240500) (owner: 10VolkerE) [16:44:05] (03Merged) 10jenkins-bot: Use namespaced CirrusSearch class [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/591352 (owner: 10Reedy) [16:46:08] 10MediaWiki-Codesniffer, 10User-DannyS712: PHPCS complains about unused use statements if used in @phan-var - https://phabricator.wikimedia.org/T250765 (10Umherirrender) Workaround: As in the other task you can use the full qualified class name to make phan and phpcs happy [16:50:50] 10MediaWiki-Page-editing, 10VisualEditor, 10User-DannyS712: Visual Editor should not open edit window normally if user cannot create the page - https://phabricator.wikimedia.org/T238511 (10matmarex) >Actual result: >Normal-looking edit window appears, and the only notice is an edit notice is the standard not... [16:52:54] (03CR) 10Daniel Kinzler: Introduce UserOptionsManager and DefaultOptionsManager (031 comment) [core] - 10https://gerrit.wikimedia.org/r/565462 (https://phabricator.wikimedia.org/T248527) (owner: 10Ppchelko) [16:54:56] 10MediaWiki-Codesniffer, 10User-DannyS712: PHPCS complains about unused use statements if used in @phan-var - https://phabricator.wikimedia.org/T250765 (10DannyS712) >>! In T250765#6075938, @Umherirrender wrote: > Workaround: As in the other task you can use the full qualified class name to make phan and phpcs... [16:55:27] 10MediaWiki-Codesniffer, 10User-DannyS712: Remove tabs in function signature - https://phabricator.wikimedia.org/T241520 (10DannyS712) a:03DannyS712 [16:55:51] (03PS5) 10Bartosz Dziewoński: ConfirmEdit CAPTCHA support [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/582944 (https://phabricator.wikimedia.org/T247513) [16:56:07] (03CR) 10Bartosz Dziewoński: "(Rebased.)" [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/582944 (https://phabricator.wikimedia.org/T247513) (owner: 10Bartosz Dziewoński) [16:56:59] (03CR) 10Bartosz Dziewoński: [C: 03+2] eslint: Disable max-len [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/591353 (owner: 10Esanders) [16:57:03] 10MediaWiki-Maintenance-system, 10Growth-Team, 10Performance-Team, 10StructuredDiscussions, and 5 others: sql.php must not run LoadExtensionSchemaUpdates - https://phabricator.wikimedia.org/T157651 (10daniel) >>! In T157651#6075764, @Krinkle wrote: > @daniel I noticed a patch that makes some methods inacce... [16:57:10] (03CR) 10Esanders: [C: 03+2] Show error on pages with fostered content to avoid page corruption in Parsoid [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/589108 (https://phabricator.wikimedia.org/T246481) (owner: 10Bartosz Dziewoński) [16:57:18] (03PS8) 10Niedzielski: Make legacy mode a feature [skins/Vector] - 10https://gerrit.wikimedia.org/r/585291 (https://phabricator.wikimedia.org/T244481) (owner: 10Phuedx) [16:57:24] (03CR) 10Niedzielski: [C: 03+2] Make legacy mode a feature [skins/Vector] - 10https://gerrit.wikimedia.org/r/585291 (https://phabricator.wikimedia.org/T244481) (owner: 10Phuedx) [16:57:33] (03CR) 10Niedzielski: [C: 03+2] Make legacy mode a feature [skins/Vector] - 10https://gerrit.wikimedia.org/r/585291 (https://phabricator.wikimedia.org/T244481) (owner: 10Phuedx) [16:58:31] 10MediaWiki-Codesniffer, 10User-DannyS712: PHPCS complains about unused use statements if used in @phan-var - https://phabricator.wikimedia.org/T250765 (10Daimona) >>! In T250765#6074936, @DannyS712 wrote: >>>! In T250765#6074362, @thiemowmde wrote: >> Sure. Let's just add it to the UnusedUseStatement sniff! >... [16:58:47] 10MediaWiki-Maintenance-system, 10Growth-Team, 10Performance-Team, 10StructuredDiscussions, and 5 others: sql.php must not run LoadExtensionSchemaUpdates - https://phabricator.wikimedia.org/T157651 (10Krinkle) 05Open→03Resolved [16:58:51] (03PS2) 10Bartosz Dziewoński: Show error on pages with fostered content to avoid page corruption in Parsoid [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/589108 (https://phabricator.wikimedia.org/T246481) [16:58:53] (03Merged) 10jenkins-bot: Use namespaced PageImages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591216 (owner: 10Reedy) [16:59:02] 10Editing Design, 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board): [SPIKE] What approaches have people/communities done to make it easier to start new discussion threads? - https://phabricator.wikimedia.org/T249784 (10ppelberg) **Next step: 21-April** - [ ] @ppelberg to update task description; once do... [16:59:17] (03CR) 10Bartosz Dziewoński: "(Fixed PHPCS error.)" [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/589108 (https://phabricator.wikimedia.org/T246481) (owner: 10Bartosz Dziewoński) [17:00:17] 10Discovery-Search (Current work): Literature review for query completion - https://phabricator.wikimedia.org/T250510 (10EBernhardson) User Model-based Metrics for Offline Query SuggestionEvaluation: https://dl.acm.org/doi/pdf/10.1145/2484028.2484041 * Proposes pSaved and eSaved metrics for evaluating autocomplet... [17:01:46] (03CR) 10Esanders: [C: 03+2] Show error on pages with fostered content to avoid page corruption in Parsoid [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/589108 (https://phabricator.wikimedia.org/T246481) (owner: 10Bartosz Dziewoński) [17:02:03] (03Merged) 10jenkins-bot: eslint: Disable max-len [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/591353 (owner: 10Esanders) [17:02:52] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Sorry, I just noticed Peter asked for some copy changes" [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/589108 (https://phabricator.wikimedia.org/T246481) (owner: 10Bartosz Dziewoński) [17:05:12] (03PS1) 10Jforrester: build: Upgrade mediawiki-phan-config from 0.9.2 to 0.10.2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591382 [17:05:14] (03PS1) 10Jforrester: build: Upgrade @wikimedia/mw-node-qunit from 6.1.0 to 6.1.1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591383 [17:05:16] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia to 0.15.3 and make pass [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591384 [17:05:18] (03PS1) 10Jforrester: build: Upgrade stylelint-config-wikimedia from 0.10.0 to 0.10.1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591385 [17:05:20] (03PS1) 10Jforrester: build: Upgrade grunt-banana-checker from 0.8.1 to 0.9.0 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591386 [17:05:23] (03PS1) 10Jforrester: build: Upgrade webpack from 4.21.0 to 4.43.0 and rebuild [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591387 [17:05:26] 10Discovery-Search (Current work), 10Epic: Query Completion - https://phabricator.wikimedia.org/T250436 (10TJones) [17:05:44] (03Abandoned) 10Jforrester: [WIP] Add phan configuration [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/426576 (owner: 10Legoktm) [17:06:12] (03CR) 10Niedzielski: [C: 03+1] "recheck" [skins/Vector] - 10https://gerrit.wikimedia.org/r/585524 (owner: 10Phuedx) [17:06:33] 10MediaWiki-Maintenance-system: Determine faith of sql.php/patchSql.php - https://phabricator.wikimedia.org/T250835 (10Krinkle) [17:06:49] 10MediaWiki-Maintenance-system: Determine faith of sql.php/patchSql.php - https://phabricator.wikimedia.org/T250835 (10Krinkle) [17:07:09] 10MediaWiki-Maintenance-system, 10Core Platform Team: Determine faith of sql.php/patchSql.php - https://phabricator.wikimedia.org/T250835 (10Krinkle) [17:08:05] 10Hashtags: Help fix hashtags tool - https://phabricator.wikimedia.org/T250823 (10Wikicology) I entered my hashtag (#WPWPK), set the start and end date of my campaign. I added the hashtag to the edit summary of an article I edited [[https://yo.wikipedia.org/w/index.php?title=David_Woodard&curid=66352&diff=53... [17:09:52] (03CR) 10Ppchelko: Introduce UserOptionsManager and DefaultOptionsManager (031 comment) [core] - 10https://gerrit.wikimedia.org/r/565462 (https://phabricator.wikimedia.org/T248527) (owner: 10Ppchelko) [17:10:36] (03PS3) 10Jdlrobson: Rename user icon module to more general 'mobile.user.icons' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/590625 (https://phabricator.wikimedia.org/T244444) (owner: 10VolkerE) [17:11:46] (03CR) 10Jforrester: [C: 03+2] maintenance: Move FakeMaintenance and LoggedUpdateMaintenance to their own files [core] - 10https://gerrit.wikimedia.org/r/576349 (https://phabricator.wikimedia.org/T246780) (owner: 10Daimona Eaytoy) [17:12:43] (03Merged) 10jenkins-bot: Make legacy mode a feature [skins/Vector] - 10https://gerrit.wikimedia.org/r/585291 (https://phabricator.wikimedia.org/T244481) (owner: 10Phuedx) [17:12:56] 10Desktop Improvements, 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), 10Patch-For-Review, 10Performance-Team (Radar), 10Readers-Web-Backlog (Kanbanana-2019-20-Q4): Build new logo for Desktop Improvements Header - https://phabricator.wikimedia.org/T246170 (10Jdlrobson) Okay, patch is up and have run by the... [17:15:06] 10MobileFrontend, 10Developer Productivity, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4): PHPUnit warning noise from MwApiContentProviderTest (MobileFrontend) - https://phabricator.wikimedia.org/T247669 (10Krinkle) 05Open→03Resolved Looks lke it was fixed already by 9298341908 ( 10MediaWiki-extensions-CentralAuth, 10Security-Team, 10Stewards-and-global-tools, 10MW-1.34-notes, and 4 others: globaluserinfo api allows access to information about hidden users - https://phabricator.wikimedia.org/T250594 (10Jdforrester-WMF) [17:15:56] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Epic, 10MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), and 2 others: Redesign ResourceLoader's file dependency tracking (module_deps) - https://phabricator.wikimedia.org/T113916 (10Krinkle) [17:15:59] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Performance Issue: Database 'INSERT' query rate doubled (module_deps regression?) - https://phabricator.wikimedia.org/T247028 (10Krinkle) [17:17:25] (03CR) 10Jforrester: [C: 03+2] Update 'wikimedia-ui-base' to v0.15.0 [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/591256 (https://phabricator.wikimedia.org/T248393) (owner: 10VolkerE) [17:18:03] (03PS7) 10VolkerE: 'mediawiki.mixins": Add '.text-overflow()' mixin [core] - 10https://gerrit.wikimedia.org/r/589698 (https://phabricator.wikimedia.org/T250526) [17:18:55] (03Merged) 10jenkins-bot: Update 'wikimedia-ui-base' to v0.15.0 [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/591256 (https://phabricator.wikimedia.org/T248393) (owner: 10VolkerE) [17:19:13] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade eslint-config-wikimedia to 0.15.3 and make pass [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591384 (owner: 10Jforrester) [17:19:30] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade mediawiki-phan-config from 0.9.2 to 0.10.2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591382 (owner: 10Jforrester) [17:20:01] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade webpack from 4.21.0 to 4.43.0 and rebuild [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591387 (owner: 10Jforrester) [17:20:27] 10MediaWiki-Codesniffer: @coversDefaultClass should be allowed on traits as well as classes (MediaWiki.Commenting.PhpunitAnnotations.NotClass) - https://phabricator.wikimedia.org/T230688 (10DannyS712) @Simetrical is this still needed? If so can you provide an example patch that fails but should pass? [17:20:29] (03CR) 10Jforrester: [C: 03+2] SECURITY: Do not leak user info via API [extensions/CentralAuth] (REL1_33) - 10https://gerrit.wikimedia.org/r/591252 (https://phabricator.wikimedia.org/T250594) (owner: 10SBassett) [17:20:31] (03CR) 10Jforrester: [C: 03+2] SECURITY: Do not leak user info via API [extensions/CentralAuth] (REL1_31) - 10https://gerrit.wikimedia.org/r/591253 (https://phabricator.wikimedia.org/T250594) (owner: 10SBassett) [17:20:33] (03CR) 10Jforrester: [C: 03+2] SECURITY: Do not leak user info via API [extensions/CentralAuth] (REL1_34) - 10https://gerrit.wikimedia.org/r/591251 (https://phabricator.wikimedia.org/T250594) (owner: 10SBassett) [17:20:35] (03PS1) 10Daimona Eaytoy: Minimize direct access to taintedOriginalError [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/591390 [17:20:59] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade @wikimedia/mw-node-qunit from 6.1.0 to 6.1.1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591383 (owner: 10Jforrester) [17:21:59] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade stylelint-config-wikimedia from 0.10.0 to 0.10.1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591385 (owner: 10Jforrester) [17:22:42] (03PS7) 10Phuedx: [Hygiene] featureManager: Move SimpleRequirement... [skins/Vector] - 10https://gerrit.wikimedia.org/r/585525 [17:22:45] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade grunt-banana-checker from 0.8.1 to 0.9.0 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591386 (owner: 10Jforrester) [17:23:37] (03Merged) 10jenkins-bot: SECURITY: Do not leak user info via API [extensions/CentralAuth] (REL1_34) - 10https://gerrit.wikimedia.org/r/591251 (https://phabricator.wikimedia.org/T250594) (owner: 10SBassett) [17:23:39] (03Merged) 10jenkins-bot: SECURITY: Do not leak user info via API [extensions/CentralAuth] (REL1_31) - 10https://gerrit.wikimedia.org/r/591253 (https://phabricator.wikimedia.org/T250594) (owner: 10SBassett) [17:24:52] (03Merged) 10jenkins-bot: SECURITY: Do not leak user info via API [extensions/CentralAuth] (REL1_33) - 10https://gerrit.wikimedia.org/r/591252 (https://phabricator.wikimedia.org/T250594) (owner: 10SBassett) [17:25:44] 10Phabricator: If a task has #Patch-Needs-Improvement and Gerritbot adds #Patch-For-Review, remove #Patch-Needs-Improvement - https://phabricator.wikimedia.org/T250839 (10Aklapper) p:05Triage→03Low [17:26:11] 10Phabricator: If a task has #Patch-Needs-Improvement and Gerritbot adds #Patch-For-Review, remove #Patch-Needs-Improvement - https://phabricator.wikimedia.org/T250839 (10Aklapper) 05Open→03Resolved ...because both together makes no sense. Implemented in H363 [17:27:03] (03Merged) 10jenkins-bot: maintenance: Move FakeMaintenance and LoggedUpdateMaintenance to their own files [core] - 10https://gerrit.wikimedia.org/r/576349 (https://phabricator.wikimedia.org/T246780) (owner: 10Daimona Eaytoy) [17:27:23] 10MediaWiki-API, 10CirrusSearch, 10Core Platform Team, 10Discovery-Search, 10Pywikibot: site.search() does not work for wikimania:wikimania - https://phabricator.wikimedia.org/T250811 (10Dvorapa) Complete traceback: ` WARNING: API error toomanyvalues: Too many values supplied for parameter "gsrnamespace"... [17:27:52] (03CR) 10Fomafix: "I expected that this test fail without a dependency on the parsoid change." [core] - 10https://gerrit.wikimedia.org/r/582525 (owner: 10Fomafix) [17:28:04] (03PS1) 10Daimona Eaytoy: Remove code for marking XSS in maintenance scripts as false positives [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/591392 [17:28:08] (03Abandoned) 10Fomafix: Add parsoid parser tests for soft hyphens in DISPLAYTITLE [core] - 10https://gerrit.wikimedia.org/r/582525 (owner: 10Fomafix) [17:28:42] (03CR) 10jerkins-bot: [V: 04-1] Remove code for marking XSS in maintenance scripts as false positives [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/591392 (owner: 10Daimona Eaytoy) [17:29:33] 10MediaWiki-User-management, 10MediaWiki-User-preferences, 10CPT Initiatives (Decoupling (CDP2)): Factor user options definitions out of PreferencesFactory - https://phabricator.wikimedia.org/T250822 (10DannyS712) [17:31:11] 10MediaWiki-extensions-Newsletter, 10Patch-Needs-Improvement: When creating a newsletter, the default newsletter page should be offered as Main Page - https://phabricator.wikimedia.org/T177064 (10Aklapper) [17:31:37] (03PS2) 10Jforrester: build: Upgrade mediawiki-phan-config from 0.9.2 to 0.10.2 and make pass [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591382 [17:33:30] 10Discovery-Search (Current work), 10Epic: Query Completion - https://phabricator.wikimedia.org/T250436 (10EBernhardson) [17:33:52] (03CR) 10jerkins-bot: [V: 04-1] 'mediawiki.mixins": Add '.text-overflow()' mixin [core] - 10https://gerrit.wikimedia.org/r/589698 (https://phabricator.wikimedia.org/T250526) (owner: 10VolkerE) [17:34:15] 10MediaWiki-User-management, 10MediaWiki-User-preferences, 10CPT Initiatives (Decoupling (CDP2)): Factor user options definitions out of PreferencesFactory - https://phabricator.wikimedia.org/T250822 (10DannyS712) @Pchelolo I'd be interested in working on this, but I'm a bit unclear as to what methods are me... [17:34:33] 10MediaWiki-Maintenance-system, 10Patch-For-Review: Split FakeMaintenance and LoggedUpdateMaintenance to their own files - https://phabricator.wikimedia.org/T246780 (10Daimona) 05Open→03Resolved a:03Daimona [17:35:14] (03PS2) 10Daimona Eaytoy: Remove code for marking XSS in maintenance scripts as false positives [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/591392 [17:36:19] (03CR) 10jerkins-bot: [V: 04-1] Remove code for marking XSS in maintenance scripts as false positives [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/591392 (owner: 10Daimona Eaytoy) [17:37:58] (03PS3) 10Bartosz Dziewoński: Show error on pages with fostered content to avoid page corruption in Parsoid [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/589108 (https://phabricator.wikimedia.org/T246481) [17:38:01] 10Discovery-Search (Current work), 10Epic: Query Completion - https://phabricator.wikimedia.org/T250436 (10TJones) Nice write up! A few ideas and comments below. > look at query frequency over time A random thought for a later iteration: Wikipedia is an unusual case because most titles are nouns or proper no... [17:39:09] (03PS2) 10Bkudiess-msft: Fixes screen reader not announcing status message on UsersMultiselectWidget [core] - 10https://gerrit.wikimedia.org/r/591211 [17:39:42] (03CR) 10jerkins-bot: [V: 04-1] Show error on pages with fostered content to avoid page corruption in Parsoid [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/589108 (https://phabricator.wikimedia.org/T246481) (owner: 10Bartosz Dziewoński) [17:39:47] 10MediaWiki-User-management, 10MediaWiki-User-preferences, 10CPT Initiatives (Decoupling (CDP2)): Factor user options definitions out of PreferencesFactory - https://phabricator.wikimedia.org/T250822 (10Pchelolo) For now this is more of a placeholder task than an actionable plan. I will spend some time soon... [17:40:30] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 1.0), 10Patch-For-Review: Prevent page corruption in DiscussionTools caused by broken and incomplete table syntax - https://phabricator.wikimedia.org/T246481 (10matmarex) @ppelberg Done [17:40:39] (03PS4) 10Bartosz Dziewoński: Show error on pages with fostered content to avoid page corruption in Parsoid [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/589108 (https://phabricator.wikimedia.org/T246481) [17:41:38] (03PS3) 10Daimona Eaytoy: Remove code for marking XSS in maintenance scripts as false positives [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/591392 [17:42:01] (03PS1) 10Pwirth: Replace usage of long deprecated and removed mediawiki.api.edit module [extensions/NSFileRepo] - 10https://gerrit.wikimedia.org/r/591398 [17:42:31] 10MediaWiki-extensions-GuidedTour, 10ContentTranslation, 10Desktop Improvements, 10Front-end-Standards-Group, and 9 others: Replace jsduck with JSDoc3 across all Wikimedia code bases - https://phabricator.wikimedia.org/T138401 (10Jdforrester-WMF) >>! In T138401#6075505, @JTannerWMF wrote: > Is the Editing... [17:42:43] wikimedia/mediawiki#27621 (master - 4199c80 jenkins-bot): The build is still failing. - https://travis-ci.com/wikimedia/mediawiki/builds/161287687 [17:43:07] (03CR) 10jerkins-bot: [V: 04-1] Remove code for marking XSS in maintenance scripts as false positives [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/591392 (owner: 10Daimona Eaytoy) [17:45:07] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade mediawiki-phan-config from 0.9.2 to 0.10.2 and make pass [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591382 (owner: 10Jforrester) [17:48:29] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 1.0), 10Patch-For-Review: Prevent page corruption in DiscussionTools caused by broken and incomplete table syntax - https://phabricator.wikimedia.org/T246481 (10ppelberg) >>! In T246481#6076195, @matmarex wrote: > @p... [17:48:43] 10MediaWiki-Cache, 10Patch-For-Review, 10Performance-Team (Radar): Look into a simple way to have global keys with db-replicated - https://phabricator.wikimedia.org/T229062 (10Krinkle) [17:48:45] 10MediaWiki-General, 10Operations, 10serviceops-radar, 10Availability (MediaWiki-MultiDC), and 3 others: Use a multi-dc aware store for ObjectCache's MainStash if needed. - https://phabricator.wikimedia.org/T212129 (10Krinkle) [17:49:38] (03PS3) 10Jforrester: build: Upgrade mediawiki-phan-config from 0.9.2 to 0.10.2 and make pass [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591382 [17:50:55] 10MediaWiki-Cache: Create Default MainStash Solution - https://phabricator.wikimedia.org/T228307 (10Krinkle) 05Open→03Resolved The main stash already has a stock default that satisfies its contract in terms of persistence and replication `name=DefaultSettings.php,lang=php $wgMainStash = 'db-replicated'; `... [17:52:10] 10MediaWiki-Cache, 10Performance-Team, 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), 10Technical-Debt (Deprecation process): Deprecate and remove SquidPurgeClient classes - https://phabricator.wikimedia.org/T250417 (10Krinkle) p:05Triage→03Low [17:52:16] 10MediaWiki-Cache, 10Performance-Team, 10observability: Add WANObjectCache size metrics to Grafana dashboards - https://phabricator.wikimedia.org/T250578 (10Krinkle) p:05Triage→03Low [17:52:35] 10MediaWiki-General, 10Operations, 10serviceops-radar, 10Availability (MediaWiki-MultiDC), and 3 others: Use a multi-dc aware store for ObjectCache's MainStash if needed. - https://phabricator.wikimedia.org/T212129 (10Krinkle) p:05Triage→03High [17:52:49] 10MediaWiki-General, 10MediaWiki-extensions-General, 10Performance-Team, 10MW-1.35-notes (1.35.0-wmf.27; 2020-04-07), and 2 others: Deprecate and remove $wgMemc in MediaWiki Core and bundled extensions - https://phabricator.wikimedia.org/T160813 (10Krinkle) p:05Triage→03Medium [17:53:50] 10MediaWiki-Cache, 10Performance-Team, 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), 10Patch-For-Review, 10Technical-Debt (Deprecation process): Deprecate wfForeignMemcKey() and BagOStuff::getKeyInternal() - https://phabricator.wikimedia.org/T250407 (10Krinkle) p:05Triage→03Low [17:54:02] 10MediaWiki-Parser, 10Parsing-Team, 10Performance-Team, 10MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), 10User-notice: Change {{REVISIONID}} from number to "-" in wgMiserMode - https://phabricator.wikimedia.org/T235957 (10Krinkle) p:05Triage→03Medium [17:54:34] 10Wikimedia-Takedown-Tools, 10Anti-Harassment (The Letter Song): Update POST address for Lumen Database in Takedown Tools - https://phabricator.wikimedia.org/T250507 (10dbarratt) [17:54:37] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog: Show Wikidata description without forced capitalisation - https://phabricator.wikimedia.org/T250841 (10Nnvu) [17:54:57] 10Wikimedia-Takedown-Tools, 10Anti-Harassment (The Letter Song): Update POST address for Lumen Database in Takedown Tools - https://phabricator.wikimedia.org/T250507 (10dbarratt) a:03dbarratt [17:55:01] 10MediaWiki-General, 10Performance-Team: Fix problem of self::$executeContext sometimes being null in DeferredUpdates::handleUpdateQueue - https://phabricator.wikimedia.org/T249069 (10Krinkle) a:05aaron→03Krinkle [17:56:52] (03CR) 10Niedzielski: [C: 03+2] [Hygiene] featureManager: Move SimpleRequirement... [skins/Vector] - 10https://gerrit.wikimedia.org/r/585525 (owner: 10Phuedx) [17:58:18] (03Abandoned) 10Jdlrobson: Split legacy common styles from modern common styles [skins/Vector] - 10https://gerrit.wikimedia.org/r/591193 (owner: 10Jdlrobson) [17:59:03] (03PS3) 10Jdlrobson: Replace 'byteschanged' with OOUI's 'upTriangle' icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/590855 (https://phabricator.wikimedia.org/T244444) (owner: 10VolkerE) [18:00:43] (03PS8) 10VolkerE: 'mediawiki.mixins": Add '.text-overflow()' mixin [core] - 10https://gerrit.wikimedia.org/r/589698 (https://phabricator.wikimedia.org/T250526) [18:01:01] (03Abandoned) 10Daimona Eaytoy: Remove code for marking XSS in maintenance scripts as false positives [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/591392 (owner: 10Daimona Eaytoy) [18:01:09] 10MediaWiki-Codesniffer, 10User-DannyS712: Add sniff to check if all returns of a function are void or non-void returns - https://phabricator.wikimedia.org/T168994 (10DannyS712) a:03DannyS712 @Umherirrender should this autofix to include `void` in the return (`@return int` -> `@return int|void`) or just add... [18:01:17] (03CR) 10jerkins-bot: [V: 04-1] Replace 'byteschanged' with OOUI's 'upTriangle' icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/590855 (https://phabricator.wikimedia.org/T244444) (owner: 10VolkerE) [18:01:33] 10Library-Card-Platform: Investigate delete_data server error - https://phabricator.wikimedia.org/T250842 (10Samwalton9) [18:02:27] 10Library-Card-Platform: Investigate delete_data server error - https://phabricator.wikimedia.org/T250842 (10Samwalton9) [18:02:53] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade mediawiki-phan-config from 0.9.2 to 0.10.2 and make pass [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591382 (owner: 10Jforrester) [18:03:00] 10OOUI, 10Documentation, 10Patch-For-Review: Replace jsduck with JSDoc3 in OOUI - https://phabricator.wikimedia.org/T185396 (10Jdforrester-WMF) [18:03:17] 10Structured-Data-Backlog (Current Work): Add segmented controller / tabs for media types in media search - https://phabricator.wikimedia.org/T250730 (10mwilliams) This is looking really good, thanks Matthias. The 3 things not in line with the designs seem totally fine to not have or have differently for the res... [18:04:06] (03PS4) 10Jforrester: build: Upgrade mediawiki-phan-config from 0.9.2 to 0.10.2 and make pass [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591382 [18:04:53] (03CR) 10Nikki Nikkhoui: More flexible deprecation warnings (031 comment) [core] - 10https://gerrit.wikimedia.org/r/589464 (owner: 10Tim Starling) [18:05:31] 10Discovery-Search (Current work), 10Epic: Query Completion - https://phabricator.wikimedia.org/T250436 (10EBernhardson) [18:05:40] 10Structured-Data-Backlog (Current Work): Adjust Image Grid on Media Search - https://phabricator.wikimedia.org/T250729 (10mwilliams) This is looking much better and totally meets are needs for research. I'd be fine with making them slightly smaller if we think that will help balance things out a bit but that's... [18:07:06] (03CR) 10Jdlrobson: "Thanks D3r1ck01 for fixing https://phabricator.wikimedia.org/T247669!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/574238 (owner: 10D3r1ck01) [18:08:23] (03CR) 10Jdlrobson: [C: 03+2] Rename user icon module to more general 'mobile.user.icons' [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/590625 (https://phabricator.wikimedia.org/T244444) (owner: 10VolkerE) [18:08:42] (03PS4) 10Jdlrobson: Replace 'byteschanged' with OOUI's 'upTriangle' icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/590855 (https://phabricator.wikimedia.org/T244444) (owner: 10VolkerE) [18:09:15] (03PS8) 10Jdlrobson: Replace mobile.editor.images with OOUI icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/585857 (https://phabricator.wikimedia.org/T244444) (owner: 10VolkerE) [18:09:47] (03PS1) 10Krinkle: resourceloader: Move RL hooks to own namespace, use PSR-4 [core] - 10https://gerrit.wikimedia.org/r/591408 (https://phabricator.wikimedia.org/T246855) [18:10:09] (03Merged) 10jenkins-bot: [Hygiene] featureManager: Move SimpleRequirement... [skins/Vector] - 10https://gerrit.wikimedia.org/r/585525 (owner: 10Phuedx) [18:10:22] (03CR) 10Zfilipin: "Nice work!" (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/585880 (https://phabricator.wikimedia.org/T248223) (owner: 10Ashuro07) [18:10:34] (03CR) 10Zfilipin: "Good work!" (034 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/590284 (https://phabricator.wikimedia.org/T250610) (owner: 10Gaura87) [18:10:43] (03CR) 10Krinkle: "Was it intentional that hooks don't use namespaces within core, or just something to do later? That is - is this change fine?" [core] - 10https://gerrit.wikimedia.org/r/591408 (https://phabricator.wikimedia.org/T246855) (owner: 10Krinkle) [18:11:16] (03CR) 10jerkins-bot: [V: 04-1] Replace 'byteschanged' with OOUI's 'upTriangle' icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/590855 (https://phabricator.wikimedia.org/T244444) (owner: 10VolkerE) [18:13:18] (03CR) 10Ashuro07: ">" (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/585880 (https://phabricator.wikimedia.org/T248223) (owner: 10Ashuro07) [18:15:40] 10Desktop Improvements, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Spike, 10Vue.js: [Spike 12.75 hrs] Where does the application-specific Vue.js search code live and what impact does this decision have on the long term? - https://phabricator.wikimedia.org/T249051 (10Niedzielski)... [18:18:10] 10MediaWiki-API, 10CirrusSearch, 10Core Platform Team, 10Discovery-Search, 10Pywikibot: site.search() does not work for wikimania:wikimania - https://phabricator.wikimedia.org/T250811 (10Urbanecm) That's because wikimaniawiki has a lot of content namespaces. Immediate solution would be to grant the user... [18:18:27] (03CR) 10Jforrester: [C: 03+2] Don't use deprecated ParserBeforeTidy/BeforeParserFetchTemplateAndtitle hooks [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/589626 (owner: 10C. Scott Ananian) [18:18:37] (03CR) 10Jforrester: [C: 03+2] build: Updating grunt-banana-checker to 0.9.0 [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/590840 (owner: 10Libraryupgrader) [18:19:31] (03CR) 10Jforrester: "This change is ready for review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591382 (owner: 10Jforrester) [18:19:39] (03PS2) 10Krinkle: resourceloader: Move RL hooks to own namespace, use PSR-4 [core] - 10https://gerrit.wikimedia.org/r/591408 (https://phabricator.wikimedia.org/T246855) [18:19:41] (03PS2) 10Jforrester: build: Upgrade @wikimedia/mw-node-qunit from 6.1.0 to 6.1.1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591383 [18:19:43] 10MediaWiki-extensions-Translate: Extension:Translate Translations Broken Since 1.34 - https://phabricator.wikimedia.org/T249988 (10Lyrixn) Hmm.. I'm not exactly sure what I'm supposed to do here. [18:21:12] (03PS3) 10Krinkle: resourceloader: Move RL hooks to own namespace, use PSR-4 [core] - 10https://gerrit.wikimedia.org/r/591408 (https://phabricator.wikimedia.org/T246855) [18:21:37] (03PS5) 10HMonroy: Remove password reset invalid email message [core] - 10https://gerrit.wikimedia.org/r/589815 (https://phabricator.wikimedia.org/T249730) [18:21:55] (03Merged) 10jenkins-bot: Don't use deprecated ParserBeforeTidy/BeforeParserFetchTemplateAndtitle hooks [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/589626 (owner: 10C. Scott Ananian) [18:23:11] (03PS3) 10Jforrester: Adds anchor option to doEditSectionLink [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/536229 (owner: 10Juan Osorio (Microsoft)) [18:23:30] (03PS1) 10Robert P. J. Day: Bogus change for rday, incorporating Gerrit. [extensions/examples] - 10https://gerrit.wikimedia.org/r/591415 [18:23:32] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/examples] - 10https://gerrit.wikimedia.org/r/591415 (owner: 10Robert P. J. Day) [18:24:58] (03PS9) 10Jdlrobson: Replace mobile.editor.images with OOUI icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/585857 (https://phabricator.wikimedia.org/T244444) (owner: 10VolkerE) [18:25:02] (03CR) 10Jdlrobson: [C: 03+2] Replace mobile.editor.images with OOUI icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/585857 (https://phabricator.wikimedia.org/T244444) (owner: 10VolkerE) [18:25:51] (03CR) 10Ppchelko: [C: 04-1] "The tests are failing cause GadgetTest mocks User::isAllowedAll method in a few places, and the method is not used anymore." [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/591262 (owner: 10Ammarpad) [18:26:24] (03PS27) 10Jforrester: Adds a Share widget to the Section Headers [core] - 10https://gerrit.wikimedia.org/r/513234 (https://phabricator.wikimedia.org/T18691) (owner: 10Juan Osorio (Microsoft)) [18:27:11] (03CR) 10Jforrester: "PS27: Manual trivial rebase." [core] - 10https://gerrit.wikimedia.org/r/513234 (https://phabricator.wikimedia.org/T18691) (owner: 10Juan Osorio (Microsoft)) [18:29:00] 10MediaWiki-Codesniffer: Spaces inside brackets used for array indexing - https://phabricator.wikimedia.org/T249872 (10thiemowmde) Isn't `$a->b` already 3 tokens? [18:30:04] 10MediaWiki-General, 10Wikipedia-iOS-App-Backlog, 10iOS-app-Bugs, 10CSS: Weird CSS tooltip behaviour on iOS devices - https://phabricator.wikimedia.org/T212610 (10Johan) [18:30:18] 10MediaWiki-ResourceLoader, 10Performance-Team: ResourceLoaderOOUIIconPackModule doesn't support selective variants - https://phabricator.wikimedia.org/T250847 (10Jdlrobson) [18:31:35] 10MediaWiki-General, 10Wikipedia-iOS-App-Backlog, 10iOS-app-Bugs, 10CSS: Weird CSS tooltip behaviour on iOS devices - https://phabricator.wikimedia.org/T212610 (10Johan) Per https://www.mediawiki.org/wiki/Topic:Vkxq3qoi65w6fwzh reporting it in the iOS app. [18:32:15] (03PS5) 10Jforrester: build: Upgrade mediawiki-phan-config from 0.9.2 to 0.10.2 and make pass [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591382 (https://phabricator.wikimedia.org/T250630) [18:32:30] 10MobileFrontend, 10phan-taint-check-plugin, 10Patch-For-Review, 10Readers-Web-Backlog (Tracking): MobileFrontend taint-check fails - https://phabricator.wikimedia.org/T250630 (10Jdforrester-WMF) Oh, hey, just found this. [18:32:56] (03CR) 10BPirkle: [C: 03+1] More flexible deprecation warnings (031 comment) [core] - 10https://gerrit.wikimedia.org/r/589464 (owner: 10Tim Starling) [18:34:29] (03CR) 10Jdlrobson: [C: 04-1] Replace 'byteschanged' with OOUI's 'upTriangle' icon (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/590855 (https://phabricator.wikimedia.org/T244444) (owner: 10VolkerE) [18:35:12] (03CR) 10Ppchelko: [C: 04-1] "A few last little nits in release notes, otherwise LGTM." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/581247 (https://phabricator.wikimedia.org/T239975) (owner: 10Art-Baltai) [18:37:28] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Move RL hooks to own namespace, use PSR-4 [core] - 10https://gerrit.wikimedia.org/r/591408 (https://phabricator.wikimedia.org/T246855) (owner: 10Krinkle) [18:38:21] 10MediaWiki-General, 10Performance-Team: Fix problem of self::$executeContext sometimes being null in DeferredUpdates::handleUpdateQueue - https://phabricator.wikimedia.org/T249069 (10Krinkle) I can reproduce this locally on PHP 7.4 with MediaWiki core + Vector and no other extensions, and then making an edit.... [18:39:15] (03Merged) 10jenkins-bot: Replace mobile.editor.images with OOUI icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/585857 (https://phabricator.wikimedia.org/T244444) (owner: 10VolkerE) [18:39:51] 10MediaWiki-Export-or-Import: Special:Import should skip revisions with identical content to the current revision - https://phabricator.wikimedia.org/T250772 (10Dinoguy1000) The specific circumstance is where the imported revision is newer than the current local revision of the page, and would thus replace it an... [18:40:23] (03CR) 10HMonroy: Remove password reset invalid email message (032 comments) [core] - 10https://gerrit.wikimedia.org/r/589815 (https://phabricator.wikimedia.org/T249730) (owner: 10HMonroy) [18:40:47] (03CR) 10jerkins-bot: [V: 04-1] Adds a Share widget to the Section Headers [core] - 10https://gerrit.wikimedia.org/r/513234 (https://phabricator.wikimedia.org/T18691) (owner: 10Juan Osorio (Microsoft)) [18:41:25] (03CR) 10Jdlrobson: [C: 04-1] "Needs updating." [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/589730 (owner: 10VolkerE) [18:41:49] (03CR) 10Jdlrobson: [C: 04-1] "https://gerrit.wikimedia.org/r/#/q/Iaffcefcb7a239d5dd needs updating so I can test this." [core] - 10https://gerrit.wikimedia.org/r/589698 (https://phabricator.wikimedia.org/T250526) (owner: 10VolkerE) [18:43:13] 10MediaWiki-ResourceLoader, 10Performance-Team: ResourceLoaderOOUIIconPackModule doesn't support selective variants - https://phabricator.wikimedia.org/T250847 (10Jdlrobson) [18:44:22] 10MediaWiki-Categories, 10UploadWizard, 10good first task: Automatically redirect users to the correct category in the UploadWizard (Wikimedia Commons) - https://phabricator.wikimedia.org/T196448 (10kaldari) [18:44:49] 10MediaWiki-Categories, 10UploadWizard, 10good first task: Automatically redirect users to the correct category in the UploadWizard (Wikimedia Commons) - https://phabricator.wikimedia.org/T196448 (10kaldari) Note that this bug causes a lot of extra work for the Commons community and should be fairly easy to... [18:45:05] (03PS40) 10Aaron Schulz: objectcache: dependency inject LoadBalancer into SqlBagOStuff [core] - 10https://gerrit.wikimedia.org/r/524655 (https://phabricator.wikimedia.org/T229062) [18:45:57] 10MediaWiki-extensions-Translate: Extension:Translate Translations Broken Since 1.34 - https://phabricator.wikimedia.org/T249988 (10Aklapper) @Lyrixn: Maybe you could try https://www.mediawiki.org/w/index.php?title=Topic:U5cmoaoy73ps8nag&topic_showPostId=u5e6866jjg4g85pz#flow-post-u5e6866jjg4g85pz , though uncle... [18:46:03] 10MediaWiki-Internationalization: Extension:Translate Translations Broken Since 1.34 - https://phabricator.wikimedia.org/T249988 (10Aklapper) [18:47:27] (03PS1) 10Sohom Datta: Updating extension.json to use manifest version 2 [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/591418 (https://phabricator.wikimedia.org/T241898) [18:47:48] (03Abandoned) 10Aklapper: Bogus change for rday, incorporating Gerrit. [extensions/examples] - 10https://gerrit.wikimedia.org/r/591415 (owner: 10Robert P. J. Day) [18:48:37] 10QuickSurveys, 10Readers-Web-Backlog, 10Patch-For-Review, 10good first task, 10patch-welcome: Update QuickSurveys extension.json to manifest version 2 - https://phabricator.wikimedia.org/T241898 (10Soda) a:03Soda [18:48:39] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog: Show Wikidata description without forced capitalisation - https://phabricator.wikimedia.org/T250841 (10Dbrant) This highlights the fact that `mobile-html` is explicitly upper-casing the Wikidata description at the top of the article. However, the... [18:49:45] (03PS2) 10VolkerE: Use `.text-overflow()` mixin from 'mediawiki.mixins' [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/589730 [18:51:09] 10MediaWiki-General, 10Performance-Team: Fix problem of self::$executeContext sometimes being null in DeferredUpdates::handleUpdateQueue - https://phabricator.wikimedia.org/T249069 (10Krinkle) a:05Krinkle→03aaron [18:52:34] (03PS4) 10Krinkle: resourceloader: Move RL hooks to own namespace, use PSR-4 [core] - 10https://gerrit.wikimedia.org/r/591408 (https://phabricator.wikimedia.org/T246855) [18:55:00] (03PS2) 10Reedy: build: Replace jsonlint with eslint's JSON parsing [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/590854 (owner: 10Jforrester) [18:55:05] (03CR) 10Reedy: [C: 03+2] build: Replace jsonlint with eslint's JSON parsing [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/590854 (owner: 10Jforrester) [18:58:36] (03Merged) 10jenkins-bot: build: Replace jsonlint with eslint's JSON parsing [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/590854 (owner: 10Jforrester) [18:59:50] (03CR) 10Nikki Nikkhoui: "> Patch Set 8:" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/589466 (owner: 10Tim Starling) [19:04:10] (03PS41) 10Aaron Schulz: objectcache: dependency inject LoadBalancer into SqlBagOStuff [core] - 10https://gerrit.wikimedia.org/r/524655 (https://phabricator.wikimedia.org/T229062) [19:05:37] (03PS1) 10VolkerE: mediawiki.ui: Add 'border-radius-base' and deprecate 'borderRadius' [core] - 10https://gerrit.wikimedia.org/r/591426 [19:06:57] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: No phpcs rules for space after unary minus operator - https://phabricator.wikimedia.org/T155627 (10DannyS712) a:03DannyS712 [19:07:02] (03PS6) 10Reedy: build: Upgrade mediawiki-phan-config from 0.9.2 to 0.10.2 and make pass [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591382 (https://phabricator.wikimedia.org/T250630) (owner: 10Jforrester) [19:07:43] (03CR) 10Reedy: [C: 03+2] build: Upgrade mediawiki-phan-config from 0.9.2 to 0.10.2 and make pass [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591382 (https://phabricator.wikimedia.org/T250630) (owner: 10Jforrester) [19:08:05] (03CR) 10Krinkle: [C: 03+2] rbms: optimize and rename truncateTable() to truncate() [core] - 10https://gerrit.wikimedia.org/r/582288 (owner: 10Aaron Schulz) [19:09:44] (03CR) 10Krinkle: [C: 04-1] "Clearing from team dash." [core] - 10https://gerrit.wikimedia.org/r/496744 (owner: 10Aaron Schulz) [19:13:43] (03CR) 10Krinkle: Remove unused "memcache" service from container.php (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/585118 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [19:13:47] (03PS1) 10VolkerE: mediawiki.ui: Remove outdated variables [core] - 10https://gerrit.wikimedia.org/r/591427 [19:16:43] (03PS16) 10DannyS712: Update hook interfaces for recent additions and deprecations [core] - 10https://gerrit.wikimedia.org/r/588936 (https://phabricator.wikimedia.org/T240307) [19:19:01] (03PS1) 10Gehel: upgrading to latest parent pom (1.37) [search/extra] - 10https://gerrit.wikimedia.org/r/591428 [19:19:03] (03PS1) 10Gehel: upgrading to latest parent pom (1.37) [search/extra-analysis] - 10https://gerrit.wikimedia.org/r/591429 [19:19:12] (03PS1) 10Gehel: upgrading to latest parent pom (1.37) [search/glent] - 10https://gerrit.wikimedia.org/r/591430 [19:19:32] (03PS1) 10Gehel: upgrading to latest parent pom (1.37) [search/highlighter] - 10https://gerrit.wikimedia.org/r/591431 [19:19:37] (03PS17) 10DannyS712: Update hook interfaces for recent additions and deprecations [core] - 10https://gerrit.wikimedia.org/r/588936 (https://phabricator.wikimedia.org/T240307) [19:20:58] (03PS5) 10VolkerE: Replace 'byteschanged' with OOUI's 'upTriangle' icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/590855 (https://phabricator.wikimedia.org/T244444) [19:22:48] (03Merged) 10jenkins-bot: build: Upgrade mediawiki-phan-config from 0.9.2 to 0.10.2 and make pass [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591382 (https://phabricator.wikimedia.org/T250630) (owner: 10Jforrester) [19:22:49] 10Wikimedia-Site-requests: Import scowiktionary incubator to scowiki Define namespace - https://phabricator.wikimedia.org/T247177 (10MJL) > Also, what about the templates? Should I just import all those which don't exist on scowiki and you will figure out the rest? Yeah, that's fine. Thank you a ton for your wo... [19:22:54] (03Merged) 10jenkins-bot: rbms: optimize and rename truncateTable() to truncate() [core] - 10https://gerrit.wikimedia.org/r/582288 (owner: 10Aaron Schulz) [19:24:48] 10Product-Analytics (Kanban): Review Newpyter Proposal - https://phabricator.wikimedia.org/T250213 (10SNowick_WMF) We will have team discussion on features, issues here: https://docs.google.com/document/d/1AtbjbMHSJ2sm8EZP6CZPJA2uiRaWXYWaBi4TKkoLS9g/edit#heading=h.vpanev2oq14b When feedback is ready will be doc... [19:25:08] (03PS2) 10Jforrester: build: Upgrade eslint-config-wikimedia to 0.15.3 and make pass [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591384 [19:25:19] (03PS2) 10Jforrester: build: Upgrade stylelint-config-wikimedia from 0.10.0 to 0.10.1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591385 [19:25:27] (03PS2) 10Jforrester: build: Upgrade grunt-banana-checker from 0.8.1 to 0.9.0 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591386 [19:25:35] (03PS2) 10Jforrester: build: Upgrade webpack from 4.21.0 to 4.43.0 and rebuild [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591387 [19:25:49] (03PS3) 10Jforrester: build: Upgrade @wikimedia/mw-node-qunit from 6.1.0 to 6.1.1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591383 [19:26:25] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade webpack from 4.21.0 to 4.43.0 and rebuild [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591387 (owner: 10Jforrester) [19:27:22] 10MachineVision, 10Patch-For-Review, 10SDC-Statements (Machine-vision-depicts), 10Structured-Data-Backlog (Current Work): Add new edit tag for contributions via "Add Tag" on CAT - https://phabricator.wikimedia.org/T250747 (10egardner) Can someone verify that the labels here say what they ought to say? The... [19:28:04] (03PS3) 10Peter.ovchyn: WIP! rest: Implement SearchResultProvideThumbnail hook [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/591050 (https://phabricator.wikimedia.org/T250207) [19:28:09] 10MobileFrontend, 10phan-taint-check-plugin, 10Patch-For-Review, 10Readers-Web-Backlog (Tracking): MobileFrontend taint-check fails - https://phabricator.wikimedia.org/T250630 (10Jdforrester-WMF) 05Open→03Resolved a:03Jdforrester-WMF [19:29:05] (03PS2) 10Jforrester: Fix folder naming so seperate namespace mappings aren't needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/590648 (owner: 10Reedy) [19:29:30] 10Inuka-Team, 10Wikipedia-Previews: Show Wikipedia Previews on Wikipedia hyperlinks - https://phabricator.wikimedia.org/T250850 (10SBisson) [19:29:41] (03CR) 10jerkins-bot: [V: 04-1] WIP! rest: Implement SearchResultProvideThumbnail hook [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/591050 (https://phabricator.wikimedia.org/T250207) (owner: 10Peter.ovchyn) [19:29:58] (03CR) 10Reedy: [C: 03+2] build: Upgrade eslint-config-wikimedia to 0.15.3 and make pass [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591384 (owner: 10Jforrester) [19:30:02] (03CR) 10Reedy: [C: 03+2] build: Upgrade stylelint-config-wikimedia from 0.10.0 to 0.10.1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591385 (owner: 10Jforrester) [19:30:32] (03CR) 10Reedy: [C: 03+2] build: Upgrade grunt-banana-checker from 0.8.1 to 0.9.0 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591386 (owner: 10Jforrester) [19:31:34] 10WMEE: Wikimedia särkide/meenete projekt - https://phabricator.wikimedia.org/T224146 (10kruusamagi) 1) Selle vikipisiku failid lähevad muidu Commonsisse ka üles? 2) WMEE liikmete hulgas ja eestikeelses Vikipeedias väike kampaania, et kes tahab särke? [19:31:37] (03CR) 10jerkins-bot: [V: 04-1] Replace 'byteschanged' with OOUI's 'upTriangle' icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/590855 (https://phabricator.wikimedia.org/T244444) (owner: 10VolkerE) [19:32:35] (03PS1) 10Anysite: fix mw133 compatibility by rewrite duplicate method [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/591434 [19:32:56] 10MediaWiki-Codesniffer, 10User-DannyS712: Provide Codesniffer rules to enforce primitive types in lowercase in documentation - https://phabricator.wikimedia.org/T172836 (10DannyS712) a:03DannyS712 [19:33:15] 10MediaWiki-ResourceLoader, 10Desktop Improvements, 10Performance-Team, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Vue.js: Allow skins to override mediawiki.page.ready initialisation - https://phabricator.wikimedia.org/T250851 (10Jdlrobson) [19:33:38] (03PS1) 10Jdlrobson: Allow skins to override the `mediawiki.page.ready` [core] - 10https://gerrit.wikimedia.org/r/591436 (https://phabricator.wikimedia.org/T250851) [19:33:41] (03CR) 10Reedy: [C: 03+2] build: Upgrade @wikimedia/mw-node-qunit from 6.1.0 to 6.1.1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591383 (owner: 10Jforrester) [19:33:52] (03CR) 10Jforrester: [C: 03+2] "This has been copied to a couple of other places, too: https://codesearch.wmflabs.org/search/?q=colorErrorText%7CcolorWarningText&i=nope&f" [core] - 10https://gerrit.wikimedia.org/r/591427 (owner: 10VolkerE) [19:34:18] (03CR) 10Jforrester: [C: 03+2] mediawiki.ui: Add 'border-radius-base' and deprecate 'borderRadius' [core] - 10https://gerrit.wikimedia.org/r/591426 (owner: 10VolkerE) [19:34:46] (03PS6) 10VolkerE: Replace 'byteschanged' with OOUI's 'upTriangle' icon [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/590855 (https://phabricator.wikimedia.org/T244444) [19:36:00] (03CR) 10jerkins-bot: [V: 04-1] Update hook interfaces for recent additions and deprecations [core] - 10https://gerrit.wikimedia.org/r/588936 (https://phabricator.wikimedia.org/T240307) (owner: 10DannyS712) [19:36:12] (03PS1) 10Jdlrobson: DONOTMERGE/POC: Let Vector decide how search works [skins/Vector] - 10https://gerrit.wikimedia.org/r/591437 (https://phabricator.wikimedia.org/T250851) [19:36:17] (03CR) 10Jdlrobson: [C: 04-2] DONOTMERGE/POC: Let Vector decide how search works [skins/Vector] - 10https://gerrit.wikimedia.org/r/591437 (https://phabricator.wikimedia.org/T250851) (owner: 10Jdlrobson) [19:36:25] 10MediaWiki-Configuration, 10Wikimedia-Apache-configuration: noc.wikimedia.org incorrect raw file urls - https://phabricator.wikimedia.org/T250852 (10Dvorapa) [19:36:34] 10MediaWiki-ResourceLoader, 10Desktop Improvements, 10Performance-Team, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4): Add support for ResourceLoaderScriptModule in extension.json and skin.json - https://phabricator.wikimedia.org/T250853 (10Jdlrobson) [19:36:38] (03CR) 10Anysite: "solve bug described in:" [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/591434 (owner: 10Anysite) [19:36:45] 10MediaWiki-Configuration, 10Wikimedia-Apache-configuration: noc.wikimedia.org incorrect raw file urls - https://phabricator.wikimedia.org/T250852 (10Dvorapa) [19:37:23] (03PS3) 10Jforrester: build: Upgrade eslint-config-wikimedia to 0.15.3 and make pass [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591384 [19:37:23] wikimedia/mediawiki#27622 (master - 08b80b9 jenkins-bot): The build is still failing. - https://travis-ci.com/wikimedia/mediawiki/builds/161306374 [19:37:30] (03PS3) 10Jforrester: build: Upgrade stylelint-config-wikimedia from 0.10.0 to 0.10.1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591385 [19:37:38] (03PS3) 10Jforrester: build: Upgrade grunt-banana-checker from 0.8.1 to 0.9.0 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591386 [19:38:51] (03PS3) 10Jforrester: build: Upgrade webpack from 4.21.0 to 4.43.0 and rebuild [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591387 [19:39:07] 10DiscussionTools, 10Editing QA, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), 10OWC2020 (OWC2020 Replying 2.0): Implement opt-in/out of watching talk page in Replying workflow - https://phabricator.wikimedia.org/T245222 (10Ryasmeen) >>! In T245222#6074563, @Esa... [19:39:31] (03CR) 10Jforrester: [C: 03+2] "*re-triggering zuul*" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591384 (owner: 10Jforrester) [19:39:35] 10MediaWiki-Configuration, 10Wikimedia-Apache-configuration: noc.wikimedia.org incorrect raw file urls - https://phabricator.wikimedia.org/T250852 (10Dvorapa) It seems in some cases .txt is needed and in some cases .txt is not needed: T227606 [19:39:37] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), 10OWC2020 (OWC2020 Replying 2.0): Implement opt-in/out of watching talk page in Replying workflow - https://phabricator.wikimedia.org/T245222 (10Ryasmeen) [19:39:41] 10WMEE: Wikimedia Eesti 2020 midpoint report - https://phabricator.wikimedia.org/T250855 (10kruusamagi) [19:40:22] 10WMEE: Wikimedia Eesti 2020 midpoint report - https://phabricator.wikimedia.org/T250855 (10kruusamagi) p:05Triage→03Medium [19:41:10] 10WMEE: Wikimedia Eesti 2020 midpoint report - https://phabricator.wikimedia.org/T250855 (10kruusamagi) [19:42:06] (03PS1) 10VolkerE: mediawiki.ui: Add `@color-base--subtle` [core] - 10https://gerrit.wikimedia.org/r/591438 [19:43:14] (03PS18) 10DannyS712: Update hook interfaces for recent additions and deprecations [core] - 10https://gerrit.wikimedia.org/r/588936 (https://phabricator.wikimedia.org/T240307) [19:45:26] (03CR) 10jerkins-bot: [V: 04-1] Fix folder naming so seperate namespace mappings aren't needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/590648 (owner: 10Reedy) [19:47:21] (03PS1) 10VolkerE: mediawiki.ui: Deprecate `@colorFieldBorder` [core] - 10https://gerrit.wikimedia.org/r/591439 [19:47:52] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), 10OWC2020 (OWC2020 Replying 2.0): Implement opt-in/out of watching talk page in Replying workflow - https://phabricator.wikimedia.org/T245222 (10Ryasmeen) >>! In T245222#6076599, @Ryasmeen wrote: >>>... [19:48:04] 10GrowthExperiments-Help panel, 10NewcomerTasks 1.2, 10Growth-Team (Current Sprint), 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28): Unify back button design - https://phabricator.wikimedia.org/T248065 (10RHo) Thanks @Etonkovidova - I think at least some of the visual design issues you noted in (1) as well a... [19:48:54] 10Phabricator, 10Gerrit, 10Release-Engineering-Team-TODO, 10Release-Engineering-Team (Development services): Stop using Differential for code review - https://phabricator.wikimedia.org/T191182 (10kaldari) [19:49:25] 10Wikimedia-Site-requests, 10Community-consensus-needed: Turkish Wikisource reports low number of content pages - https://phabricator.wikimedia.org/T248747 (10Satirdan_kahraman) Much time has passed and no one opposed to the idea. Can we do the required update? [19:49:51] (03Merged) 10jenkins-bot: build: Upgrade @wikimedia/mw-node-qunit from 6.1.0 to 6.1.1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591383 (owner: 10Jforrester) [19:49:57] (03Merged) 10jenkins-bot: mediawiki.ui: Add 'border-radius-base' and deprecate 'borderRadius' [core] - 10https://gerrit.wikimedia.org/r/591426 (owner: 10VolkerE) [19:50:03] (03PS3) 10Jforrester: Fix folder naming so seperate namespace mappings aren't needed [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/590648 (owner: 10Reedy) [19:51:26] 04(no projects): Add ability to receive nominornewtalk edits via email - https://phabricator.wikimedia.org/T250856 (10Primefac) [19:52:56] (03CR) 10VolkerE: Provide theme-agnostic style variables (031 comment) [core] - 10https://gerrit.wikimedia.org/r/345440 (https://phabricator.wikimedia.org/T112747) (owner: 10VolkerE) [19:52:58] (03Merged) 10jenkins-bot: mediawiki.ui: Remove outdated variables [core] - 10https://gerrit.wikimedia.org/r/591427 (owner: 10VolkerE) [19:53:03] (03CR) 10jerkins-bot: [V: 04-1] DONOTMERGE/POC: Let Vector decide how search works [skins/Vector] - 10https://gerrit.wikimedia.org/r/591437 (https://phabricator.wikimedia.org/T250851) (owner: 10Jdlrobson) [19:53:27] (03PS1) 10VolkerE: mediawiki.ui: Add `@border-base` variable [core] - 10https://gerrit.wikimedia.org/r/591441 [19:53:39] 10MediaWiki-Codesniffer, 10User-DannyS712: Add sniff to check if all returns of a function are void or non-void returns - https://phabricator.wikimedia.org/T168994 (10Umherirrender) I would not add an autofix for this case. It should be looked by a human if there is an error or not. [19:53:41] (03CR) 10jerkins-bot: [V: 04-1] Allow skins to override the `mediawiki.page.ready` [core] - 10https://gerrit.wikimedia.org/r/591436 (https://phabricator.wikimedia.org/T250851) (owner: 10Jdlrobson) [19:54:45] (03PS1) 10Kosta Harlan: Add MultiTitleFilter class [core] - 10https://gerrit.wikimedia.org/r/591442 [19:55:09] (03PS3) 10Scardenasmolinar: [wip] Replace toast with OOUI popup on watchlist message [core] - 10https://gerrit.wikimedia.org/r/591159 (https://phabricator.wikimedia.org/T249259) [19:56:22] (03CR) 10Daniel Kinzler: "> Patch Set 8:" [core] - 10https://gerrit.wikimedia.org/r/589466 (owner: 10Tim Starling) [19:57:01] (03PS3) 10Kosta Harlan: Add page linked event title blacklist [extensions/Echo] - 10https://gerrit.wikimedia.org/r/591154 (https://phabricator.wikimedia.org/T46787) [19:57:13] (03CR) 10Kosta Harlan: "This change is ready for review." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/591154 (https://phabricator.wikimedia.org/T46787) (owner: 10Kosta Harlan) [19:57:20] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia to 0.15.3 and make pass [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591384 (owner: 10Jforrester) [19:57:24] (03Merged) 10jenkins-bot: build: Upgrade stylelint-config-wikimedia from 0.10.0 to 0.10.1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591385 (owner: 10Jforrester) [19:59:14] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade webpack from 4.21.0 to 4.43.0 and rebuild [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591387 (owner: 10Jforrester) [19:59:36] (03CR) 10Jdlrobson: [C: 04-1] Replace 'byteschanged' with OOUI's 'upTriangle' icon (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/590855 (https://phabricator.wikimedia.org/T244444) (owner: 10VolkerE) [20:00:32] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Growth-Team (Current Sprint), 10Product-Analytics (Kanban): Newcomer tasks: experiment analysis - https://phabricator.wikimedia.org/T230174 (10nettrom_WMF) [20:00:46] (03Abandoned) 10Jdlrobson: DONOTMERGE/POC: Let Vector decide how search works [skins/Vector] - 10https://gerrit.wikimedia.org/r/591437 (https://phabricator.wikimedia.org/T250851) (owner: 10Jdlrobson) [20:03:44] 10MediaWiki-Maintenance-system, 10Core Platform Team: Determine fate of sql.php/patchSql.php - https://phabricator.wikimedia.org/T250835 (10daniel) [20:04:15] 10Desktop Improvements, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Spike, 10Vue.js: [Spike 12.75 hrs] Where does the application-specific Vue.js search code live and what impact does this decision have on the long term? - https://phabricator.wikimedia.org/T249051 (10Jdlrobson) >... [20:05:01] 10Desktop Improvements, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4), 10Spike, 10Vue.js: [Spike 12.75 hrs] Where does the application-specific Vue.js search code live and what impact does this decision have on the long term? - https://phabricator.wikimedia.org/T249051 (10Jdlrobson) Fe... [20:05:09] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 10Fundraising Sprint Heaven is a page on Wikipedia: Create employer autocomplete for payments-wiki - https://phabricator.wikimedia.org/T249921 (10jgleeson) a:03jgleeson [20:05:54] (03CR) 10Krinkle: Provide theme-agnostic style variables (032 comments) [core] - 10https://gerrit.wikimedia.org/r/345440 (https://phabricator.wikimedia.org/T112747) (owner: 10VolkerE) [20:06:30] 10MachineVision, 10Patch-For-Review, 10SDC-Statements (Machine-vision-depicts), 10Structured-Data-Backlog (Current Work): Add new edit tag for contributions via "Add Tag" on CAT - https://phabricator.wikimedia.org/T250747 (10Ramsey-WMF) Could we do "Computer-aided Tagging - manual (revert)"? [20:06:55] 10Editing-team (Tracking), 10OWC2020 (OWC2020 Replying 1.0): Explore: how can Reply tool be enabled on pages consisting solely of transcluded conversations - https://phabricator.wikimedia.org/T250540 (10ppelberg) > Develop an approach for how Reply tools can be enabled on discussion pages outside the talk nam... [20:07:28] 10Product-Analytics (Kanban): Product Analytics to prepare Whitelist for properties - https://phabricator.wikimedia.org/T250456 (10nettrom_WMF) [20:08:00] (03CR) 10Krinkle: Provide theme-agnostic style variables (031 comment) [core] - 10https://gerrit.wikimedia.org/r/345440 (https://phabricator.wikimedia.org/T112747) (owner: 10VolkerE) [20:10:08] (03CR) 10jerkins-bot: [V: 04-1] [wip] Replace toast with OOUI popup on watchlist message [core] - 10https://gerrit.wikimedia.org/r/591159 (https://phabricator.wikimedia.org/T249259) (owner: 10Scardenasmolinar) [20:10:43] 10MediaWiki-Codesniffer, 10User-DannyS712: Add sniff to check if all returns of a function are void or non-void returns - https://phabricator.wikimedia.org/T168994 (10DannyS712) >>! In T168994#6076647, @Umherirrender wrote: > I would not add an autofix for this case. It should be looked by a human if there is... [20:11:06] 10MediaWiki-Maintenance-system, 10Core Platform Team: Determine fate of sql.php/patchSql.php - https://phabricator.wikimedia.org/T250835 (10holger.knust) p:05Triage→03Medium [20:12:13] 10DiscussionTools, 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.27; 2020-04-07): Allow non talk pages to be treated as talk pages using a magic word, and allow talk pages to be treated as non-talk pages using a magic word - https://phabricator.wikimedia.org/T245890 (10p... [20:12:58] (03PS8) 10Catrope: Convert ResourceLoaderLanguageDataModule to packageFiles [core] - 10https://gerrit.wikimedia.org/r/487101 [20:13:13] (03CR) 10Catrope: Convert ResourceLoaderLanguageDataModule to packageFiles (031 comment) [core] - 10https://gerrit.wikimedia.org/r/487101 (owner: 10Catrope) [20:14:31] (03CR) 10jerkins-bot: [V: 04-1] Convert ResourceLoaderLanguageDataModule to packageFiles [core] - 10https://gerrit.wikimedia.org/r/487101 (owner: 10Catrope) [20:16:05] 10Growth-Team (Current Sprint), 10Product-Analytics (Kanban): Welcome survey: store aggregates - https://phabricator.wikimedia.org/T235548 (10nettrom_WMF) 05Open→03Resolved [20:16:07] 10Product-Analytics, 10Growth-Team (Current Sprint), 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17): Welcome survey: anonymize data after one year - https://phabricator.wikimedia.org/T208369 (10nettrom_WMF) [20:16:11] 10MediaWiki-User-preferences: Add ability to receive nominornewtalk edits via email - https://phabricator.wikimedia.org/T250856 (10DannyS712) [20:16:17] 10MediaWiki-User-preferences, 10User-DannyS712: Add ability to receive nominornewtalk edits via email - https://phabricator.wikimedia.org/T250856 (10DannyS712) [20:21:24] 10MediaWiki-API, 10CirrusSearch, 10Discovery-Search, 10Pywikibot: site.search() does not work for wikimania:wikimania - https://phabricator.wikimedia.org/T250811 (10holger.knust) p:05Triage→03Low We currently don't see any work for the Core Platform Team on this ticket. Retag us if needed. [20:22:10] 10MediaWiki-Codesniffer: MediaWiki.Commenting.FunctionComment.DefaultNullTypeParam wants redundant "mixed|null" - https://phabricator.wikimedia.org/T218324 (10DannyS712) @Legoktm can this be closed as resolved? [20:23:26] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 30.0.0 [extensions/AddPersonalUrls] - 10https://gerrit.wikimedia.org/r/591445 (owner: 10Libraryupgrader) [20:26:12] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591386 (owner: 10Jforrester) [20:27:14] 10MediaWiki-Core-Hooks, 10CPT Initiatives (New Hook System): Rename BeforeParserrenderImageGalleryHook to BeforeParserRenderImageGalleryHook - https://phabricator.wikimedia.org/T250859 (10cscott) [20:27:26] 10MediaWiki-Core-Hooks, 10CPT Initiatives (New Hook System): Rename BeforeParserrenderImageGalleryHook to BeforeParserRenderImageGalleryHook - https://phabricator.wikimedia.org/T250859 (10cscott) [20:27:37] 10MediaWiki-Core-Hooks, 10Core Platform Team, 10Core Platform Team Workboards (Clinic Duty Team), 10Dependency injection, and 4 others: Hook container with strong types and DI - https://phabricator.wikimedia.org/T240307 (10cscott) [20:28:07] (03CR) 10Nikki Nikkhoui: "> Patch Set 8:" [core] - 10https://gerrit.wikimedia.org/r/589466 (owner: 10Tim Starling) [20:28:12] (03CR) 10C. Scott Ananian: [C: 04-1] Update hook interfaces for recent additions and deprecations (031 comment) [core] - 10https://gerrit.wikimedia.org/r/588936 (https://phabricator.wikimedia.org/T240307) (owner: 10DannyS712) [20:30:09] (03CR) 10Jforrester: [C: 03+2] mediawiki.ui: Add `@color-base--subtle` [core] - 10https://gerrit.wikimedia.org/r/591438 (owner: 10VolkerE) [20:30:17] (03CR) 10Jforrester: [C: 03+2] mediawiki.ui: Deprecate `@colorFieldBorder` [core] - 10https://gerrit.wikimedia.org/r/591439 (owner: 10VolkerE) [20:30:22] 10MediaWiki-JobQueue, 10WMF-JobQueue, 10serviceops, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review: Enable MW REST API on job runners and video scalers (for the new rest.php job executor) - https://phabricator.wikimedia.org/T246389 (10holger.knust) p:05Triage→03Medium [20:30:28] (03CR) 10Jforrester: [C: 03+2] mediawiki.ui: Add `@border-base` variable [core] - 10https://gerrit.wikimedia.org/r/591441 (owner: 10VolkerE) [20:30:57] 10MediaWiki-Codesniffer, 10Documentation: Make a contributing.md file or add to README, steps to contribute to Mediawiki Codesniffer - https://phabricator.wikimedia.org/T133478 (10DannyS712) [20:31:57] 10MediaWiki-Codesniffer: Validate order of Doxygen annotations in documentation comments - https://phabricator.wikimedia.org/T175374 (10DannyS712) [20:32:06] (03PS1) 10Umherirrender: Fix use of MediaWikiServcies in parser hook [extensions/LoopFunctions] - 10https://gerrit.wikimedia.org/r/591458 [20:32:11] 10MediaWiki-Internationalization: Extension:Translate Translations Broken Since 1.34 - https://phabricator.wikimedia.org/T249988 (10Lyrixn) Truncating didn't help. That's a real shame, as we're running a rather large wiki project with years of translations. Tagalog (language) seems to be broken and some more pop... [20:33:44] (03CR) 10jerkins-bot: [V: 04-1] Fix use of MediaWikiServcies in parser hook [extensions/LoopFunctions] - 10https://gerrit.wikimedia.org/r/591458 (owner: 10Umherirrender) [20:35:18] (03PS2) 10Umherirrender: Fix use of MediaWikiServcies in parser hook [extensions/LoopFunctions] - 10https://gerrit.wikimedia.org/r/591458 [20:37:56] (03CR) 10C. Scott Ananian: Adds a Share widget to the Section Headers (033 comments) [core] - 10https://gerrit.wikimedia.org/r/513234 (https://phabricator.wikimedia.org/T18691) (owner: 10Juan Osorio (Microsoft)) [20:39:10] 10MediaWiki-Installer, 10Core Platform Team Workboards (Clinic Duty Team), 10User-Nikerabbit: After upgrade from MediaWiki 1.32 to 1.33 some pages display no text (revision_comment_temp/comment) - https://phabricator.wikimedia.org/T249904 (10holger.knust) p:05Triage→03High [20:41:17] (03PS2) 10Umherirrender: MintyDocsHooks.php: Add param docs [extensions/MintyDocs] - 10https://gerrit.wikimedia.org/r/589574 (owner: 10Zoranzoki21) [20:41:21] (03PS3) 10Umherirrender: MintyDocsHooks.php: Add param docs [extensions/MintyDocs] - 10https://gerrit.wikimedia.org/r/589574 (owner: 10Zoranzoki21) [20:41:24] (03CR) 10Umherirrender: [C: 03+2] MintyDocsHooks.php: Add param docs [extensions/MintyDocs] - 10https://gerrit.wikimedia.org/r/589574 (owner: 10Zoranzoki21) [20:41:28] (03Merged) 10jenkins-bot: build: Upgrade grunt-banana-checker from 0.8.1 to 0.9.0 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591386 (owner: 10Jforrester) [20:41:42] (03PS2) 10Umherirrender: build: Updating grunt-banana-checker to 0.9.0 [extensions/LoopFunctions] - 10https://gerrit.wikimedia.org/r/590329 (owner: 10Libraryupgrader) [20:41:52] 10MediaWiki-Installer, 10Core Platform Team Workboards (Clinic Duty Team), 10User-Nikerabbit: After upgrade from MediaWiki 1.32 to 1.33 some pages display no text (revision_comment_temp/comment) - https://phabricator.wikimedia.org/T249904 (10daniel) @Nikerabbit What site is this from? What version of SMW was... [20:42:24] 10Structured-Data-Backlog: CAT: Adding messaging around which images are not being shown - https://phabricator.wikimedia.org/T250860 (10mwilliams) [20:42:29] (03CR) 10C. Scott Ananian: HookContainer: add b/c for non-static handler with colons in the function name (031 comment) [core] - 10https://gerrit.wikimedia.org/r/591238 (https://phabricator.wikimedia.org/T240307) (owner: 10Tim Starling) [20:42:52] 10MediaWiki-Configuration, 10Wikimedia-Apache-configuration, 10Patch-For-Review, 10User-Urbanecm: noc.wikimedia.org incorrect raw file urls - https://phabricator.wikimedia.org/T250852 (10Urbanecm) a:03Urbanecm Makes sense. [20:43:30] (03PS2) 10Aaron Schulz: Convert $wgMemc use to WANObjectCache in getValidTags() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/585679 (https://phabricator.wikimedia.org/T160813) [20:44:57] (03CR) 10C. Scott Ananian: "Thiemo, ping?" [core] - 10https://gerrit.wikimedia.org/r/583752 (https://phabricator.wikimedia.org/T236813) (owner: 10C. Scott Ananian) [20:45:01] (03CR) 10jerkins-bot: [V: 04-1] Convert $wgMemc use to WANObjectCache in getValidTags() [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/585679 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [20:45:19] (03CR) 10C. Scott Ananian: [C: 04-1] "This code was refactored in 0a53c9725ac44b88c628b7c6ddd543ae5cf50a8c; it would be nice to rebase this on top of that." [core] - 10https://gerrit.wikimedia.org/r/569628 (owner: 10Aaron Schulz) [20:48:35] (03Merged) 10jenkins-bot: mediawiki.ui: Add `@color-base--subtle` [core] - 10https://gerrit.wikimedia.org/r/591438 (owner: 10VolkerE) [20:48:41] (03Merged) 10jenkins-bot: mediawiki.ui: Deprecate `@colorFieldBorder` [core] - 10https://gerrit.wikimedia.org/r/591439 (owner: 10VolkerE) [20:48:43] 10Structured-Data-Backlog: CAT: Adding messaging around which images are not being shown - https://phabricator.wikimedia.org/T250860 (10Ramsey-WMF) [20:48:48] (03Merged) 10jenkins-bot: mediawiki.ui: Add `@border-base` variable [core] - 10https://gerrit.wikimedia.org/r/591441 (owner: 10VolkerE) [20:48:49] (03Merged) 10jenkins-bot: MintyDocsHooks.php: Add param docs [extensions/MintyDocs] - 10https://gerrit.wikimedia.org/r/589574 (owner: 10Zoranzoki21) [20:52:14] (03CR) 10Umherirrender: [C: 03+2] Move efSidebarDonateBox class into the own file [extensions/SidebarDonateBox] - 10https://gerrit.wikimedia.org/r/589671 (owner: 10Zoranzoki21) [20:53:06] 10MediaWiki-extensions-Page_Forms: PageForms with 1.34 and editor=wikieditor does not work - https://phabricator.wikimedia.org/T250862 (10MarkAHershberger) [20:54:38] 10MinervaNeue: MinervaNeue icons in menu should follow same default color `#54595d` - https://phabricator.wikimedia.org/T250774 (10Volker_E) @alexhollender I'd suggest doing the same thing that we've done for OOUI and icons, using `opacity`: The difference is so subtle (compare `0.87` = `#222` on `background-co... [20:55:12] (03CR) 10Jdlrobson: Organize CSS by base, layout and components (0318 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/587855 (https://phabricator.wikimedia.org/T249073) (owner: 10Jdlrobson) [20:55:15] 10MediaWiki-extensions-CategoryTree, 10I18n: CategoryTree count is localized in arbitrary language - https://phabricator.wikimedia.org/T241326 (10Krinkle) [20:55:24] (03Merged) 10jenkins-bot: Move efSidebarDonateBox class into the own file [extensions/SidebarDonateBox] - 10https://gerrit.wikimedia.org/r/589671 (owner: 10Zoranzoki21) [20:55:43] 10MediaWiki-API, 10Community-Tech, 10Core Platform Team, 10Expiring-Watchlist-Items, 10TCB-Team: Add expiry support to remaining APIs that watch pages - https://phabricator.wikimedia.org/T248407 (10holger.knust) Retag Core Platform Team if needed. [20:56:31] (03PS2) 10Umherirrender: build: Updating dependencies [extensions/ArticleIndex] - 10https://gerrit.wikimedia.org/r/591462 (owner: 10Libraryupgrader) [20:57:16] 10MediaWiki-API, 10Community-Tech, 10Expiring-Watchlist-Items, 10TCB-Team: Add expiry support to remaining APIs that watch pages - https://phabricator.wikimedia.org/T248407 (10holger.knust) [20:57:23] 10Structured Data Engineering, 10MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), 10Structured-Data-Backlog (Current Work): [M] Add a "pending" state to QualifierWidget read-mode - https://phabricator.wikimedia.org/T228947 (10Etonkovidova) 05Open→03Resolved Checked in betalabs and `wmf.28`with 2G throttling.... [20:57:48] (03PS1) 10AlQaholic007: GSOC Microtask: Move screenshots and video recording from wdio.conf.js to wdio-mediawiki [core] - 10https://gerrit.wikimedia.org/r/591474 (https://phabricator.wikimedia.org/T247960) [20:58:16] 10MediaWiki-Codesniffer: Validate order of Doxygen annotations in documentation comments - https://phabricator.wikimedia.org/T175374 (10DannyS712) Is it enough to report the invalid orders, or does the rule need to fix them as well? I should be able to write a sniff for reporting, but not autofix [20:58:37] (03PS12) 10Jdlrobson: Organize CSS by base, layout and components [skins/Vector] - 10https://gerrit.wikimedia.org/r/587855 (https://phabricator.wikimedia.org/T249073) [20:58:58] (03PS1) 10Umherirrender: Use passed parser instance in ParserFirstCallInit hook handler [extensions/FormelApplet] - 10https://gerrit.wikimedia.org/r/591475 [20:59:30] (03PS3) 10Umherirrender: Use passed parser instance in ParserFirstCallInit hook handler [extensions/LoopFunctions] - 10https://gerrit.wikimedia.org/r/591458 [20:59:33] (03PS13) 10Jdlrobson: Organize CSS by base, layout and components [skins/Vector] - 10https://gerrit.wikimedia.org/r/587855 (https://phabricator.wikimedia.org/T249073) [21:00:57] (03CR) 10AlQaholic007: "This is the approach Vidhi Mody and I have come up with." [core] - 10https://gerrit.wikimedia.org/r/591474 (https://phabricator.wikimedia.org/T247960) (owner: 10AlQaholic007) [21:01:32] 10Wikibase - Federated Properties (Sprint 4): Document prefetching-term-lookup-callback in entitytypes.md - https://phabricator.wikimedia.org/T249795 (10Rosalie_WMDE) a:03Rosalie_WMDE [21:01:45] 10MediaWiki-Codesniffer, 10User-DannyS712: Add sniff for disallow spaces between variable expression and array offset - https://phabricator.wikimedia.org/T154103 (10DannyS712) a:03DannyS712 [21:03:22] wikimedia/mediawiki#27625 (master - dca1c95 jenkins-bot): The build is still failing. - https://travis-ci.com/wikimedia/mediawiki/builds/161320583 [21:03:43] (03PS2) 10Umherirrender: build: Updating grunt-banana-checker to 0.9.0 [extensions/FormelApplet] - 10https://gerrit.wikimedia.org/r/590198 (owner: 10Libraryupgrader) [21:04:07] (03CR) 10Art-Baltai: Hard deprecate Article methods proxying to WikiPage (033 comments) [core] - 10https://gerrit.wikimedia.org/r/581247 (https://phabricator.wikimedia.org/T239975) (owner: 10Art-Baltai) [21:05:00] 10ArticleRatings, 10Patch-For-Review, 10ci-test-error: Key "CanonicalNamespaceNames" not found in input sources in includes/config/ServiceOptions.php:52 - https://phabricator.wikimedia.org/T237032 (10Umherirrender) [21:05:13] (03PS13) 10Art-Baltai: Hard deprecate Article methods proxying to WikiPage [core] - 10https://gerrit.wikimedia.org/r/581247 (https://phabricator.wikimedia.org/T239975) [21:07:38] (03PS1) 10Umherirrender: Use parenthesis on ?: for php7.4 [extensions/I18nTags] - 10https://gerrit.wikimedia.org/r/591477 [21:08:30] (03PS2) 10Umherirrender: build: Updating grunt-banana-checker to 0.9.0 [extensions/I18nTags] - 10https://gerrit.wikimedia.org/r/590264 (owner: 10Libraryupgrader) [21:11:34] (03CR) 10Nikki Nikkhoui: HookContainer: add b/c for non-static handler with colons in the function name (031 comment) [core] - 10https://gerrit.wikimedia.org/r/591238 (https://phabricator.wikimedia.org/T240307) (owner: 10Tim Starling) [21:11:46] (03PS2) 10Umherirrender: build: Updating grunt-banana-checker to 0.9.0 [extensions/CharRangeSpan] - 10https://gerrit.wikimedia.org/r/590074 (owner: 10Libraryupgrader) [21:12:07] (03PS2) 10Umherirrender: build: Updating grunt-banana-checker to 0.9.0 [extensions/CategoryTagSorter] - 10https://gerrit.wikimedia.org/r/590062 (owner: 10Libraryupgrader) [21:12:10] (03CR) 10Aaron Schulz: [C: 03+2] filerepo: Improve $wgLocalFileRepo docs [core] - 10https://gerrit.wikimedia.org/r/589861 (owner: 10Krinkle) [21:12:24] 10Wikimedia-Site-requests, 10Community-consensus-needed: Turkish Wikisource reports low number of content pages - https://phabricator.wikimedia.org/T248747 (10Superyetkin) 05Stalled→03Open p:05Triage→03High [21:12:33] (03CR) 10AlQaholic007: "recheck" [core] - 10https://gerrit.wikimedia.org/r/591474 (https://phabricator.wikimedia.org/T247960) (owner: 10AlQaholic007) [21:12:52] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 30.0.0 [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/591473 (owner: 10Libraryupgrader) [21:14:19] 10Accessibility, 10Design, 10MediaWiki-extensions-CategoryTree: Subcategory listing counts should be more user friendly - https://phabricator.wikimedia.org/T250864 (10Krinkle) [21:14:27] (03PS1) 10Umherirrender: Fix phpcs issues [extensions/ConfigManager] - 10https://gerrit.wikimedia.org/r/591479 [21:14:31] 10Accessibility, 10Design, 10MediaWiki-extensions-CategoryTree: Subcategory listing counts should be more user friendly - https://phabricator.wikimedia.org/T250864 (10Krinkle) [21:14:44] (03PS2) 10Umherirrender: Fix phpcs issues to make pass [extensions/ConfigManager] - 10https://gerrit.wikimedia.org/r/591479 [21:15:06] (03PS2) 10Umherirrender: build: Updating grunt-banana-checker to 0.9.0 [extensions/ConfigManager] - 10https://gerrit.wikimedia.org/r/590096 (owner: 10Libraryupgrader) [21:15:13] (03PS2) 10Umherirrender: Use SpecialPage::checkReadOnly instead of wfReadOnly [extensions/ConfigManager] - 10https://gerrit.wikimedia.org/r/589375 [21:15:35] (03CR) 10jerkins-bot: [V: 04-1] Use parenthesis on ?: for php7.4 [extensions/I18nTags] - 10https://gerrit.wikimedia.org/r/591477 (owner: 10Umherirrender) [21:15:40] 10Accessibility, 10Design, 10MediaWiki-extensions-CategoryTree: Subcategory listing counts should be more user friendly - https://phabricator.wikimedia.org/T250864 (10Krinkle) [21:15:42] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.9.0 [extensions/I18nTags] - 10https://gerrit.wikimedia.org/r/590264 (owner: 10Libraryupgrader) [21:16:42] 10Accessibility, 10Design, 10MediaWiki-extensions-CategoryTree: Subcategory listing counts should be more user friendly - https://phabricator.wikimedia.org/T250864 (10Krinkle) [21:16:50] 10Accessibility, 10Design, 10MediaWiki-extensions-CategoryTree: Subcategory listing counts should be more user friendly - https://phabricator.wikimedia.org/T250864 (10Krinkle) [21:17:02] 10MediaWiki-Email, 10MediaWiki-User-preferences, 10MediaWiki-Watchlist, 10Growth-Team, 10User-DannyS712: Add ability to receive nominornewtalk edits via email - https://phabricator.wikimedia.org/T250856 (10AntiCompositeNumber) `(nominornewtalk)` isn't really the problem here, as it's behaving as expected... [21:17:11] 10Accessibility, 10Wikimedia Design Style Guide, 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), 10Notice: Amend Base10 color to provide 3:1 contrast to Accent50 - https://phabricator.wikimedia.org/T248393 (10Volker_E) [21:17:50] 10Accessibility, 10Wikimedia Design Style Guide, 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), 10Notice: Amend Base10 color to provide 3:1 contrast to Accent50 - https://phabricator.wikimedia.org/T248393 (10Volker_E) 05Open→03Resolved a:03Volker_E Successfully resolved. 🎉 [21:18:14] (03CR) 10Ppchelko: [C: 03+1] "Ok. This looks good. I will not merge it before this big weekend obviously in case we break CI for extensions." [core] - 10https://gerrit.wikimedia.org/r/581247 (https://phabricator.wikimedia.org/T239975) (owner: 10Art-Baltai) [21:18:21] 10MediaWiki-User-preferences, 10Desktop Improvements, 10RW-Feature-DI-Opt-out-Toggle, 10MW-1.35-notes (1.35.0-wmf.30; 2020-04-28), and 2 others: Cannot link to subsections on Special:Preferences - https://phabricator.wikimedia.org/T248644 (10Edtadros) [21:18:30] 10MediaWiki-Codesniffer: Validate order of Doxygen annotations in documentation comments - https://phabricator.wikimedia.org/T175374 (10Krinkle) I don't think anyone should waste time fixing these by hand. Not worth the effort, so yeah, auto-fix or keep un-enforced without sniff. When auto-fixing keep in mind t... [21:18:39] (03PS1) 10Umherirrender: Use $wgHooks instead of Hooks::register [extensions/DeleteOwn] - 10https://gerrit.wikimedia.org/r/591481 [21:19:00] (03PS2) 10Umherirrender: build: Updating grunt-banana-checker to 0.9.0 [extensions/DeleteOwn] - 10https://gerrit.wikimedia.org/r/590128 (owner: 10Libraryupgrader) [21:19:25] 10MediaWiki-extensions-CategoryTree, 10I18n: CategoryTree count is localized in arbitrary language - https://phabricator.wikimedia.org/T241326 (10Krinkle) Still reproducible. [21:19:44] 10MediaWiki-extensions-CategoryTree, 10I18n, 10patch-welcome: CategoryTree count is localized in arbitrary language - https://phabricator.wikimedia.org/T241326 (10Krinkle) [21:20:14] (03CR) 10jerkins-bot: [V: 04-1] Fix phpcs issues to make pass [extensions/ConfigManager] - 10https://gerrit.wikimedia.org/r/591479 (owner: 10Umherirrender) [21:20:15] 10MobileFrontend, 10Readers-Web-Backlog, 10Technical-Debt, 10User-Jdlrobson: [Needs investigation] What's the way forward with setMainPage() in MobileFormatter.php? - https://phabricator.wikimedia.org/T231389 (10D3r1ck01) We've reached a consensus, you can close the task @Jdlrobson. I'll cleanup several us... [21:20:16] (03PS2) 10Umherirrender: Use parenthesis on ?: for php7.4 [extensions/I18nTags] - 10https://gerrit.wikimedia.org/r/591477 [21:20:32] (03PS3) 10Umherirrender: build: Updating grunt-banana-checker to 0.9.0 [extensions/I18nTags] - 10https://gerrit.wikimedia.org/r/590264 (owner: 10Libraryupgrader) [21:20:34] (03CR) 10jerkins-bot: [V: 04-1] Use SpecialPage::checkReadOnly instead of wfReadOnly [extensions/ConfigManager] - 10https://gerrit.wikimedia.org/r/589375 (owner: 10Umherirrender) [21:20:44] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.9.0 [extensions/ConfigManager] - 10https://gerrit.wikimedia.org/r/590096 (owner: 10Libraryupgrader) [21:21:08] (03CR) 10jerkins-bot: [V: 04-1] Organize CSS by base, layout and components [skins/Vector] - 10https://gerrit.wikimedia.org/r/587855 (https://phabricator.wikimedia.org/T249073) (owner: 10Jdlrobson) [21:22:13] 10MobileFrontend, 10Readers-Web-Backlog, 10Technical-Debt, 10User-Jdlrobson: [Needs investigation] What's the way forward with setMainPage() in MobileFormatter.php? - https://phabricator.wikimedia.org/T231389 (10Jdlrobson) 05Open→03Resolved a:03Jdlrobson Thanks @D3r1ck01 ! [21:24:10] (03CR) 10DannyS712: [C: 04-1] Hard deprecate Article methods proxying to WikiPage (0310 comments) [core] - 10https://gerrit.wikimedia.org/r/581247 (https://phabricator.wikimedia.org/T239975) (owner: 10Art-Baltai) [21:24:56] 04(no projects): Removing a map crashes VE, throws a jQuery exception error "TypeError: map.remove is not a function" - https://phabricator.wikimedia.org/T250865 (10Ryasmeen) [21:25:18] 10MediaWiki-extensions-CategoryTree, 10I18n: CategoryTree count is localized in arbitrary language - https://phabricator.wikimedia.org/T241326 (10Krinkle) [21:26:23] 10MachineVision, 10Patch-For-Review, 10SDC-Statements (Machine-vision-depicts), 10Structured-Data-Backlog (Current Work): Add new edit tag for contributions via "Add Tag" on CAT - https://phabricator.wikimedia.org/T250747 (10egardner) Done! [21:28:19] 10MediaWiki-Codesniffer, 10User-DannyS712: Validate order of Doxygen annotations in documentation comments - https://phabricator.wikimedia.org/T175374 (10DannyS712) a:03DannyS712 >>! In T175374#6076926, @Krinkle wrote: > I don't think anyone should waste time fixing these by hand. Not worth the effort, so ye... [21:28:21] (03Merged) 10jenkins-bot: filerepo: Improve $wgLocalFileRepo docs [core] - 10https://gerrit.wikimedia.org/r/589861 (owner: 10Krinkle) [21:31:42] (03PS14) 10Jdlrobson: Organize CSS by base, layout and components [skins/Vector] - 10https://gerrit.wikimedia.org/r/587855 (https://phabricator.wikimedia.org/T249073) [21:33:40] (03PS18) 10Jdlrobson: [modern] A new version of Vector with a new logo [skins/Vector] - 10https://gerrit.wikimedia.org/r/577682 (https://phabricator.wikimedia.org/T246170) [21:35:48] (03PS1) 10D3r1ck01: specials: Avoid deprecated use of Hook::run() calls [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591489 [21:42:50] wikimedia/mediawiki#27626 (master - 207420f jenkins-bot): The build is still failing. - https://travis-ci.com/wikimedia/mediawiki/builds/161326953 [21:43:10] (03CR) 10Nikki Nikkhoui: Update hook interfaces for recent additions and deprecations (032 comments) [core] - 10https://gerrit.wikimedia.org/r/588936 (https://phabricator.wikimedia.org/T240307) (owner: 10DannyS712) [21:45:58] 10MediaWiki-User-management, 10DBA, 10Core Platform Team Workboards (Clinic Duty Team), 10Schema-change: Rename ipb_address index on ipb_address to ipb_address_unique - https://phabricator.wikimedia.org/T250071 (10Ladsgroup) Fun fact: This index is already named `ipb_address_unique` in Postgres. [21:46:05] (03CR) 10jerkins-bot: [V: 04-1] Organize CSS by base, layout and components [skins/Vector] - 10https://gerrit.wikimedia.org/r/587855 (https://phabricator.wikimedia.org/T249073) (owner: 10Jdlrobson) [21:46:58] 10MediaWiki-User-management, 10DBA, 10Core Platform Team Workboards (Clinic Duty Team), 10Schema-change: Rename ipb_address index on ipb_address to ipb_address_unique - https://phabricator.wikimedia.org/T250071 (10Ladsgroup) Another fun fact: I absolutely hate doing schema changes in Sqlite. [21:47:54] (03PS3) 10Luca Mauri: Remove reference to wfResetSessionID() and fix error related to LoginForm::successfulLogin() [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/590638 (https://phabricator.wikimedia.org/T250626) [21:49:31] (03CR) 10Holger Knust: [C: 03+1] Remove use of WikiPage::doEditContent [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/590749 (https://phabricator.wikimedia.org/T250638) (owner: 10DannyS712) [21:51:44] (03PS19) 10DannyS712: Update hook interfaces for recent additions and deprecations [core] - 10https://gerrit.wikimedia.org/r/588936 (https://phabricator.wikimedia.org/T240307) [21:51:47] (03CR) 10DannyS712: Update hook interfaces for recent additions and deprecations (032 comments) [core] - 10https://gerrit.wikimedia.org/r/588936 (https://phabricator.wikimedia.org/T240307) (owner: 10DannyS712) [21:52:54] (03PS1) 10D3r1ck01: specials, ExtMobileFrontend: Avoid usage of deprecated User::isIP() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591499 [21:53:23] 10MediaWiki-Page-editing, 10Performance-Team, 10Product-Analytics, 10Patch-For-Review: Tag edits made in the WikiEditor (2010 wikitext editor) - https://phabricator.wikimedia.org/T249038 (10Esanders) In theory it would be the same as "saveSuccess" in EditAttemptStep, but without tying the tags to specific... [21:54:37] (03PS1) 10Ladsgroup: Rename ipb_address to ipb_address_unique [core] - 10https://gerrit.wikimedia.org/r/591500 (https://phabricator.wikimedia.org/T250071) [21:54:51] 10Technical blog: Techblog: Author of posts in feed readers is incorrect - https://phabricator.wikimedia.org/T250870 (10Krinkle) [21:55:17] 10Hashtags: Allow wildcard hashtag searches - https://phabricator.wikimedia.org/T216399 (10QEDK) @Samwalton9 would this help given T209359 is open and still causing issues? [21:56:34] 10Hashtags: Fix worker timeout issues on production - https://phabricator.wikimedia.org/T209359 (10QEDK) [21:56:35] (03CR) 10Nikki Nikkhoui: Update hook interfaces for recent additions and deprecations (031 comment) [core] - 10https://gerrit.wikimedia.org/r/588936 (https://phabricator.wikimedia.org/T240307) (owner: 10DannyS712) [21:57:21] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591489 (owner: 10D3r1ck01) [21:58:10] 10Technical blog: Techblog: Brief description about team or product on category page - https://phabricator.wikimedia.org/T250871 (10Krinkle) [22:00:11] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog: Show Wikidata description without forced capitalisation - https://phabricator.wikimedia.org/T250841 (10Charlotte) To add a bit of colour to what @Dbrant said above, until fairly recently we were capitalising the descriptions in articles, but found... [22:04:34] (03PS1) 10Accraze: Add new tables and indexes for secondary schema [extensions/Jade] - 10https://gerrit.wikimedia.org/r/591502 (https://phabricator.wikimedia.org/T229977) [22:04:36] (03PS1) 10Accraze: Re-enable db hooks [extensions/Jade] - 10https://gerrit.wikimedia.org/r/591503 (https://phabricator.wikimedia.org/T229974) [22:04:56] 10Wikimedia-Site-requests: Change HD logos with incorrect size to match expectations - https://phabricator.wikimedia.org/T250731 (10QEDK) @Urbanecm are we replacing images or simply removing them, I can do this with a script if needed. [22:04:59] 10Technical blog: Techblog: Unclear "Engineering" and "Technology" categories - https://phabricator.wikimedia.org/T250872 (10Krinkle) [22:05:26] (03CR) 10jerkins-bot: [V: 04-1] Re-enable db hooks [extensions/Jade] - 10https://gerrit.wikimedia.org/r/591503 (https://phabricator.wikimedia.org/T229974) (owner: 10Accraze) [22:07:04] 10Anti-Harassment, 10Product-Analytics (Kanban): Re-calculate metrics post Special:Mute deployment - https://phabricator.wikimedia.org/T244781 (10Niharika) This is interesting, @jwang. Thanks for pulling this data together. Per our discussion today, let's keep this task open so we can check back on these metri... [22:07:55] (03CR) 10jerkins-bot: [V: 04-1] Add new tables and indexes for secondary schema [extensions/Jade] - 10https://gerrit.wikimedia.org/r/591502 (https://phabricator.wikimedia.org/T229977) (owner: 10Accraze) [22:08:32] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board), 10Patch-For-Review: Enable the Reply tool in the Project namespace (Wikipedia:) and other "wgExtraSignaturesNamespaces" - https://phabricator.wikimedia.org/T249036 (10Whatamidoing-WMF) For help documentation, we could also exploit the redirect-re... [22:09:02] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591499 (owner: 10D3r1ck01) [22:11:42] (03PS1) 10Aaron Schulz: deferred: add turnstile debug logging to DeferredUpdates::attemptUpdate() [core] - 10https://gerrit.wikimedia.org/r/591509 (https://phabricator.wikimedia.org/T249069) [22:11:57] (03CR) 10Ladsgroup: "Please 🥺" [core] - 10https://gerrit.wikimedia.org/r/591500 (https://phabricator.wikimedia.org/T250071) (owner: 10Ladsgroup) [22:15:01] (03PS17) 10Jdlrobson: Refactor: DRY up menu creation! [skins/Vector] - 10https://gerrit.wikimedia.org/r/585808 (https://phabricator.wikimedia.org/T249372) [22:15:05] (03PS18) 10Jdlrobson: Refactor: One menu template to rule them all [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) [22:15:09] (03PS19) 10Jdlrobson: Refactor: Portal is also a Menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/587536 (https://phabricator.wikimedia.org/T249372) [22:16:13] (03PS1) 10VolkerE: mediawiki.ui: Use `@border*` variables [core] - 10https://gerrit.wikimedia.org/r/591514 [22:16:20] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 30.0.0 [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/591510 (owner: 10Libraryupgrader) [22:22:14] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 30.0.0 [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/591511 (owner: 10Libraryupgrader) [22:24:13] 10InternetArchiveBot: Dead link on Dead link - https://phabricator.wikimedia.org/T236694 (10Harej) [22:24:15] 10InternetArchiveBot: IABot put dead link template inside of dead link template - https://phabricator.wikimedia.org/T249399 (10Harej) [22:24:17] 10InternetArchiveBot: Dead link inside dead link - https://phabricator.wikimedia.org/T241951 (10Harej) [22:24:20] 10InternetArchiveBot: Embedded {{dead links}} - https://phabricator.wikimedia.org/T238750 (10Harej) [22:26:56] (03PS15) 10Jdlrobson: Organize CSS by base, layout and components [skins/Vector] - 10https://gerrit.wikimedia.org/r/587855 (https://phabricator.wikimedia.org/T249073) [22:26:59] 10MediaWiki-Codesniffer, 10Patch-For-Review, 10User-DannyS712: Validate order of Doxygen annotations in documentation comments - https://phabricator.wikimedia.org/T175374 (10DannyS712) >>! In T175374#6077046, @gerritbot wrote: > Change 591501 had a related patch set uploaded (by DannyS712; owner: DannyS712):... [22:27:02] (03CR) 10jerkins-bot: [V: 04-1] Refactor: DRY up menu creation! [skins/Vector] - 10https://gerrit.wikimedia.org/r/585808 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [22:27:06] 10InternetArchiveBot: IABot adds dead link template inside of dead link template - https://phabricator.wikimedia.org/T236694 (10Harej) [22:28:07] (03CR) 10Jdrewniak: "I’m contemplating the practical application of this module in terms of the API usability. The Javascript portion seems straightforward, in" [core] - 10https://gerrit.wikimedia.org/r/589692 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [22:28:50] (03CR) 10jerkins-bot: [V: 04-1] Refactor: One menu template to rule them all [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [22:29:19] (03CR) 10jerkins-bot: [V: 04-1] Refactor: Portal is also a Menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/587536 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [22:29:27] (03CR) 10jerkins-bot: [V: 04-1] Refactor: Simplify and standardize menu definitions [skins/Vector] - 10https://gerrit.wikimedia.org/r/589395 (owner: 10Jdlrobson) [22:29:57] (03CR) 10jerkins-bot: [V: 04-1] mediawiki.ui: Use `@border*` variables [core] - 10https://gerrit.wikimedia.org/r/591514 (owner: 10VolkerE) [22:31:05] (03CR) 10Jdlrobson: [C: 03+2] 'mediawiki.mixins": Add '.text-overflow()' mixin [core] - 10https://gerrit.wikimedia.org/r/589698 (https://phabricator.wikimedia.org/T250526) (owner: 10VolkerE) [22:31:08] (03CR) 10Jdlrobson: [C: 03+2] Use `.text-overflow()` mixin from 'mediawiki.mixins' [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/589730 (owner: 10VolkerE) [22:32:32] (03PS1) 10Tchanders: SpecialInvestigate: De-clutter buttons from results table cells [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/591517 (https://phabricator.wikimedia.org/T250051) [22:34:17] (03PS18) 10Jdlrobson: Refactor: DRY up menu creation! [skins/Vector] - 10https://gerrit.wikimedia.org/r/585808 (https://phabricator.wikimedia.org/T249372) [22:34:20] (03PS19) 10Jdlrobson: Refactor: One menu template to rule them all [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) [22:34:24] (03PS20) 10Jdlrobson: Refactor: Portal is also a Menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/587536 (https://phabricator.wikimedia.org/T249372) [22:34:28] (03PS6) 10Jdlrobson: Refactor: Simplify and standardize menu definitions [skins/Vector] - 10https://gerrit.wikimedia.org/r/589395 [22:35:12] (03CR) 10VolkerE: Provide theme-agnostic style variables (031 comment) [core] - 10https://gerrit.wikimedia.org/r/345440 (https://phabricator.wikimedia.org/T112747) (owner: 10VolkerE) [22:36:34] (03PS2) 10Accraze: Add new tables and indexes for secondary schema [extensions/Jade] - 10https://gerrit.wikimedia.org/r/591502 (https://phabricator.wikimedia.org/T229977) [22:36:39] 10Wikimedia-Site-requests: Change HD logos with incorrect size to match expectations - https://phabricator.wikimedia.org/T250731 (10Urbanecm) We should recalculate the png out of the source svg. Basically the 2x image should be 2x the dimensions of the main logo, 1.5x should be likevise. The issue is the sourc... [22:39:59] (03CR) 10C. Scott Ananian: WIP: ExtensionRegistry: Handle Parsoid extension registration (035 comments) [core] - 10https://gerrit.wikimedia.org/r/589092 (owner: 10Subramanya Sastry) [22:40:42] (03CR) 10jerkins-bot: [V: 04-1] Add new tables and indexes for secondary schema [extensions/Jade] - 10https://gerrit.wikimedia.org/r/591502 (https://phabricator.wikimedia.org/T229977) (owner: 10Accraze) [22:41:26] (03PS14) 10VolkerE: Provide theme-agnostic style variables [core] - 10https://gerrit.wikimedia.org/r/345440 (https://phabricator.wikimedia.org/T112747) [22:42:14] (03CR) 10Yaron Koren: "Thanks! Somehow I missed this before." [extensions/MintyDocs] - 10https://gerrit.wikimedia.org/r/589574 (owner: 10Zoranzoki21) [22:44:01] (03PS15) 10VolkerE: Provide theme-agnostic style variables [core] - 10https://gerrit.wikimedia.org/r/345440 (https://phabricator.wikimedia.org/T112747) [22:44:51] (03PS1) 10Jdlrobson: Use standard getJsConfigVars method [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/591518 [22:45:19] (03PS1) 10Jdlrobson: Provide standard way for skins to add JS config variables to page [core] - 10https://gerrit.wikimedia.org/r/591521 [22:46:21] (03PS2) 10Jdlrobson: Use standard getJsConfigVars method [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/591518 [22:46:30] (03Merged) 10jenkins-bot: 'mediawiki.mixins": Add '.text-overflow()' mixin [core] - 10https://gerrit.wikimedia.org/r/589698 (https://phabricator.wikimedia.org/T250526) (owner: 10VolkerE) [22:46:42] (03CR) 10Jdlrobson: [feature] add menu button to toggle panel visibility (032 comments) [skins/Vector] - 10https://gerrit.wikimedia.org/r/584694 (https://phabricator.wikimedia.org/T246419) (owner: 10Niedzielski) [22:47:42] (03Merged) 10jenkins-bot: Use `.text-overflow()` mixin from 'mediawiki.mixins' [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/589730 (owner: 10VolkerE) [22:47:58] (03CR) 10Jdlrobson: [C: 03+1] "I'm taking a break for a few days, but will look at this sometime next week. Somebody should feel free to merge if they are able to verify" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591489 (owner: 10D3r1ck01) [22:48:05] (03CR) 10Jdlrobson: [C: 03+1] "I'm taking a break for a few days, but will look at this sometime next week. Somebody should feel free to merge if they are able to verify" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/591499 (owner: 10D3r1ck01) [22:48:37] 10Accessibility, 10Desktop Improvements, 10Performance-Team (Radar), 10Readers-Web-Backlog (Kanbanana-2019-20-Q4): [SPIKE 8hrs] Determine the optimum Vector DOM structure for a11y and performance - https://phabricator.wikimedia.org/T240489 (10Jdrewniak) With regards to the sidebar, I think that in order to... [22:49:53] (03CR) 10jerkins-bot: [V: 04-1] Refactor: Simplify and standardize menu definitions [skins/Vector] - 10https://gerrit.wikimedia.org/r/589395 (owner: 10Jdlrobson) [22:54:27] (03PS16) 10VolkerE: Provide theme-agnostic style variables [core] - 10https://gerrit.wikimedia.org/r/345440 (https://phabricator.wikimedia.org/T112747) [22:54:30] (03PS12) 10DannyS712: Use RevisionRecord in ResourceLoaderWikiModule::invalidateModuleCache [core] - 10https://gerrit.wikimedia.org/r/587571 (https://phabricator.wikimedia.org/T249561) [22:54:42] (03CR) 10VolkerE: "PS 14 fixes a path for defaults.less and unifies on added `.less` extensions on every import statement." [core] - 10https://gerrit.wikimedia.org/r/345440 (https://phabricator.wikimedia.org/T112747) (owner: 10VolkerE) [22:56:14] 10Desktop Improvements, 10RW-Feature-DI-Opt-out-Toggle, 10Readers-Web-Backlog (Kanbanana-2019-20-Q4): Add title attribute to opt-out link - https://phabricator.wikimedia.org/T250093 (10Edtadros) [22:57:41] 10Accessibility, 10Desktop Improvements, 10RW-Feature-DI-Opt-out-Toggle, 10Vector, and 2 others: Move indicators underneath firstHeading - https://phabricator.wikimedia.org/T248761 (10Edtadros) [23:00:34] wikimedia/mediawiki#27627 (master - 402b745 jenkins-bot): The build is still failing. - https://travis-ci.com/wikimedia/mediawiki/builds/161336413 [23:01:21] (03CR) 10jerkins-bot: [V: 04-1] Use standard getJsConfigVars method [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/591518 (owner: 10Jdlrobson) [23:01:23] (03PS1) 10DannyS712: SpecialUndelete: Make showDiff private, use RevisionRecord [core] - 10https://gerrit.wikimedia.org/r/591524 (https://phabricator.wikimedia.org/T249561) [23:04:31] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 30.0.0 [extensions/BlueSpiceArticlePreviewCapture] - 10https://gerrit.wikimedia.org/r/591523 (owner: 10Libraryupgrader) [23:05:02] (03PS5) 10Jdlrobson: Show red link at top of search results (non-JS version) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/580407 (https://phabricator.wikimedia.org/T219654) (owner: 10Tacsipacsi) [23:08:59] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 30.0.0 [extensions/BlueSpiceAvatars] - 10https://gerrit.wikimedia.org/r/591528 (owner: 10Libraryupgrader) [23:09:41] (03PS2) 10Jdlrobson: Refactor: Make VectorMenu template data conform with MenuDefinition [skins/Vector] - 10https://gerrit.wikimedia.org/r/591512 (https://phabricator.wikimedia.org/T249372) [23:09:44] (03PS2) 10Jdlrobson: Refactor: Make VectorTabs template data conform with MenuDefinition [skins/Vector] - 10https://gerrit.wikimedia.org/r/591513 (https://phabricator.wikimedia.org/T249372) [23:09:48] (03PS19) 10Jdlrobson: Refactor: DRY up menu creation! [skins/Vector] - 10https://gerrit.wikimedia.org/r/585808 (https://phabricator.wikimedia.org/T249372) [23:11:29] 10InternetArchiveBot: IABot adds dead link template inside of dead link template - https://phabricator.wikimedia.org/T236694 (10Harej) Don't know if it's a coincidence, but all the links reported here are alive. Maybe they were dead at the time, I don't know. [23:12:29] (03PS2) 10DannyS712: SpecialUndelete: Make showDiff private, use RevisionRecord [core] - 10https://gerrit.wikimedia.org/r/591524 (https://phabricator.wikimedia.org/T249561) [23:13:04] 04(no projects): API error adding serbian entry to wikidata - https://phabricator.wikimedia.org/T250876 (10RoySmith) [23:13:31] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 30.0.0 [extensions/BlueSpiceBookshelf] - 10https://gerrit.wikimedia.org/r/591529 (owner: 10Libraryupgrader) [23:17:23] (03PS1) 10DannyS712: MediaWikiIntegrationTestCase: Remove use of Revision objects [core] - 10https://gerrit.wikimedia.org/r/591531 (https://phabricator.wikimedia.org/T249021) [23:20:32] (03PS2) 10DannyS712: MediaWikiIntegrationTestCase: Remove use of Revision objects [core] - 10https://gerrit.wikimedia.org/r/591531 (https://phabricator.wikimedia.org/T249021) [23:22:41] (03PS5) 10DannyS712: DifferenceEngine::getRevisionHeader - accept a RevisionRecord [core] - 10https://gerrit.wikimedia.org/r/590283 (https://phabricator.wikimedia.org/T250608) [23:24:58] (03CR) 10jerkins-bot: [V: 04-1] Refactor: Make VectorMenu template data conform with MenuDefinition [skins/Vector] - 10https://gerrit.wikimedia.org/r/591512 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [23:25:09] (03CR) 10jerkins-bot: [V: 04-1] Refactor: Make VectorTabs template data conform with MenuDefinition [skins/Vector] - 10https://gerrit.wikimedia.org/r/591513 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [23:25:38] (03CR) 10jerkins-bot: [V: 04-1] Refactor: DRY up menu creation! [skins/Vector] - 10https://gerrit.wikimedia.org/r/585808 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [23:26:07] (03CR) 10jerkins-bot: [V: 04-1] Refactor: One menu template to rule them all [skins/Vector] - 10https://gerrit.wikimedia.org/r/586438 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [23:26:11] (03CR) 10jerkins-bot: [V: 04-1] Refactor: Simplify and standardize menu definitions [skins/Vector] - 10https://gerrit.wikimedia.org/r/589395 (owner: 10Jdlrobson) [23:26:37] (03CR) 10jerkins-bot: [V: 04-1] Refactor: Portal is also a Menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/587536 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [23:27:33] (03CR) 10jerkins-bot: [V: 04-1] SpecialUndelete: Make showDiff private, use RevisionRecord [core] - 10https://gerrit.wikimedia.org/r/591524 (https://phabricator.wikimedia.org/T249561) (owner: 10DannyS712) [23:29:24] (03CR) 10Nikki Nikkhoui: [C: 03+1] HookContainer: add b/c for non-static handler with colons in the function name [core] - 10https://gerrit.wikimedia.org/r/591238 (https://phabricator.wikimedia.org/T240307) (owner: 10Tim Starling) [23:30:16] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 30.0.0 [extensions/BlueSpiceBookshelfUI] - 10https://gerrit.wikimedia.org/r/591533 (owner: 10Libraryupgrader) [23:33:06] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 30.0.0 [extensions/BlueSpiceCategoryCheck] - 10https://gerrit.wikimedia.org/r/591534 (owner: 10Libraryupgrader) [23:33:22] 10InternetArchiveBot: bot adds dead link template inside cs1|2 templates - https://phabricator.wikimedia.org/T231545 (10Harej) @Cyberpower678, will the fix you submitted for this bug also fix the bug described in T236694? [23:33:46] (03PS3) 10DannyS712: SpecialUndelete: Make showDiff private, use RevisionRecord [core] - 10https://gerrit.wikimedia.org/r/591524 (https://phabricator.wikimedia.org/T249561) [23:36:56] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 30.0.0 [extensions/BlueSpiceConfigManager] - 10https://gerrit.wikimedia.org/r/591537 (owner: 10Libraryupgrader) [23:39:48] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 30.0.0 [extensions/BlueSpiceContextMenu] - 10https://gerrit.wikimedia.org/r/591538 (owner: 10Libraryupgrader) [23:40:27] (03PS2) 10Tim Starling: Call TestSetup::applyInitialConfig() from bootstrap.php [core] - 10https://gerrit.wikimedia.org/r/591260 [23:40:29] 10InternetArchiveBot: URL in ref tag name parameter causes inappropriate insertion of dead link template - https://phabricator.wikimedia.org/T248930 (10Harej) [23:41:11] (03PS3) 10Jdlrobson: Refactor: Make VectorMenu template data conform with MenuDefinition [skins/Vector] - 10https://gerrit.wikimedia.org/r/591512 (https://phabricator.wikimedia.org/T249372) [23:42:51] (03PS4) 10Tim Starling: More flexible deprecation warnings [core] - 10https://gerrit.wikimedia.org/r/589464 [23:42:53] (03PS9) 10Tim Starling: Fix DeprecatedHooks and move emitDeprecatedHookWarnings to HookContainer [core] - 10https://gerrit.wikimedia.org/r/589466 [23:43:13] (03CR) 10Tim Starling: More flexible deprecation warnings (032 comments) [core] - 10https://gerrit.wikimedia.org/r/589464 (owner: 10Tim Starling) [23:44:33] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 30.0.0 [extensions/BlueSpiceCountThings] - 10https://gerrit.wikimedia.org/r/591539 (owner: 10Libraryupgrader) [23:47:21] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 30.0.0 [extensions/BlueSpiceCustomMenu] - 10https://gerrit.wikimedia.org/r/591540 (owner: 10Libraryupgrader) [23:47:46] (03CR) 10jerkins-bot: [V: 04-1] SpecialUndelete: Make showDiff private, use RevisionRecord [core] - 10https://gerrit.wikimedia.org/r/591524 (https://phabricator.wikimedia.org/T249561) (owner: 10DannyS712) [23:53:38] (03CR) 10jerkins-bot: [V: 04-1] Fix DeprecatedHooks and move emitDeprecatedHookWarnings to HookContainer [core] - 10https://gerrit.wikimedia.org/r/589466 (owner: 10Tim Starling) [23:55:08] 10MediaWiki-extensions-DisplayTitle: Show Display Title in diff view - https://phabricator.wikimedia.org/T250879 (10Darenwelsh) [23:55:44] (03CR) 10jerkins-bot: [V: 04-1] Refactor: Make VectorMenu template data conform with MenuDefinition [skins/Vector] - 10https://gerrit.wikimedia.org/r/591512 (https://phabricator.wikimedia.org/T249372) (owner: 10Jdlrobson) [23:56:40] 10InternetArchiveBot: IABot does not recognise archive-url in existing citation templates and doubles up with webarchive - https://phabricator.wikimedia.org/T250880 (10deryckchan) [23:56:59] (03PS4) 10DannyS712: SpecialUndelete: Make showDiff private, use RevisionRecord [core] - 10https://gerrit.wikimedia.org/r/591524 (https://phabricator.wikimedia.org/T249561) [23:57:06] (03CR) 10Nikki Nikkhoui: [C: 03+1] More flexible deprecation warnings [core] - 10https://gerrit.wikimedia.org/r/589464 (owner: 10Tim Starling) [23:57:07] 10MW-1.35-notes (1.35.0-wmf.28; 2020-04-14), 10Structured-Data-Backlog (Current Work): Enable support for the none (novalue) and unknown (somevalue) "special value" types in SDC UI - https://phabricator.wikimedia.org/T239172 (10Etonkovidova) Tested in `wmf.28` - seems to behave according to the specs - the scr... [23:59:05] 10InternetArchiveBot: Bot forgets one of the braces around template - https://phabricator.wikimedia.org/T235977 (10Harej) 05Open→03Resolved [23:59:19] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 30.0.0 [extensions/BlueSpiceDistributionConnector] - 10https://gerrit.wikimedia.org/r/591542 (owner: 10Libraryupgrader) [23:59:39] 10InternetArchiveBot: Bot forgets one of the braces around template - https://phabricator.wikimedia.org/T235977 (10Harej) Fixed a typo in the bot's configuration for German Wikipedia. Please post on this task if it happens again.