[00:00:58] (03PS1) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [vendor] - 10https://gerrit.wikimedia.org/r/579666 [00:01:06] (03PS11) 10Art-Baltai: Replace usage of deprecated Page in favor of WikiPage/Article [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/573680 (https://phabricator.wikimedia.org/T239975) [00:02:20] (03PS1) 10DannyS712: Javascript coding conventions: no yoda conditions [extensions/3D] - 10https://gerrit.wikimedia.org/r/579667 [00:02:33] (03PS2) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [vendor] - 10https://gerrit.wikimedia.org/r/579666 (https://phabricator.wikimedia.org/T242751) [00:03:47] (03PS1) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) [00:05:16] (03PS2) 10DannyS712: Javascript coding conventions: no yoda conditions [extensions/3D] - 10https://gerrit.wikimedia.org/r/579667 [00:05:57] (03PS1) 10DannyS712: Javascript coding conventions: no yoda conditions [extensions/StlHandler] - 10https://gerrit.wikimedia.org/r/579669 [00:06:57] (03PS2) 10DannyS712: Javascript coding conventions: no yoda conditions [extensions/StlHandler] - 10https://gerrit.wikimedia.org/r/579669 [00:09:19] 10MediaWiki-Vagrant, 10Pywikibot-Flow, 10Growth-Team (Current Sprint), 10MW-1.35-notes (1.35.0-wmf.22; 2020-03-03): Cannot read property 'session' of undefined - https://phabricator.wikimedia.org/T246312 (10Tgr) Definetly a bug (if `wikimediaflow` shouldn't be used, it shouldn't exist; if it exists, it sho... [00:12:01] 10MediaWiki-General, 10Core Platform Team, 10Patch-For-Review: Complete TitleFactory to be a real factory service - https://phabricator.wikimedia.org/T247190 (10Tgr) The question is, will Title be around long enough for this to be worth the effort? I imagine at some point it will either be killed (in favor o... [00:12:54] (03PS2) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) [00:13:47] 10MediaWiki-extensions-OAuth, 10MW-1.35-notes (1.35.0-wmf.24; 2020-03-17): Remove duplicate SQL files - https://phabricator.wikimedia.org/T242634 (10Reedy) 05Open→03Resolved a:03Reedy [00:14:23] (03PS27) 10Nray: Add opt-out link to sidebar for Vector Latest/Logged in users [skins/Vector] - 10https://gerrit.wikimedia.org/r/579293 (https://phabricator.wikimedia.org/T243281) [00:16:38] (03PS4) 10Jdlrobson: Move contents of mediawiki.legacy.commonPrint into ResourceLoaderSkinModule [core] - 10https://gerrit.wikimedia.org/r/579420 (https://phabricator.wikimedia.org/T242177) [00:16:48] (03CR) 10Jdlrobson: Move contents of mediawiki.legacy.commonPrint into ResourceLoaderSkinModule (031 comment) [core] - 10https://gerrit.wikimedia.org/r/579420 (https://phabricator.wikimedia.org/T242177) (owner: 10Jdlrobson) [00:16:52] (03PS3) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) [00:19:38] (03CR) 10Brian Wolff: [C: 03+2] No more raw HTML in SystemGifts' i18n messages! [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/578763 (owner: 10Jack Phoenix) [00:22:34] (03Merged) 10jenkins-bot: No more raw HTML in SystemGifts' i18n messages! [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/578763 (owner: 10Jack Phoenix) [00:23:33] (03PS4) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) [00:24:14] (03CR) 10DannyS712: Fix setFriendyName typo (031 comment) [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/579659 (owner: 10Reedy) [00:24:20] (03CR) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) (033 comments) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) (owner: 10Reedy) [00:25:14] (03PS1) 10DannyS712: Javascript coding conventions: Clean up whitespace [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579676 [00:25:48] (03PS2) 10DannyS712: Javascript coding conventions: Clean up whitespace [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579676 [00:29:06] (03PS5) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) [00:39:12] (03PS6) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) [00:39:17] (03CR) 10Samwilson: [C: 03+2] "Looks good to me, works in my testing." [core] - 10https://gerrit.wikimedia.org/r/578605 (https://phabricator.wikimedia.org/T246844) (owner: 10HMonroy) [00:44:42] (03PS7) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) [00:47:24] (03CR) 10Dbarratt: "I tested this and it works well. :)" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/578972 (https://phabricator.wikimedia.org/T245662) (owner: 10Tchanders) [00:48:16] (03PS8) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) [00:48:26] 10Anti-Harassment, 10CheckUser, 10Wikimedia-Site-requests: CU 2.0: Enable Special:Investigate on testwiki - https://phabricator.wikimedia.org/T247645 (10DannyS712) [00:49:02] (03PS9) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) [00:53:22] 10Anti-Harassment, 10CheckUser, 10Wikimedia-Site-requests: CU 2.0: Enable Special:Investigate on testwiki - https://phabricator.wikimedia.org/T247645 (10DannyS712) @Niharika is the intention to add specific configuration so that only users in the staff global group can use the page? `staff` is not a right, b... [00:53:30] (03Merged) 10jenkins-bot: Enhance passwored reset message [core] - 10https://gerrit.wikimedia.org/r/578605 (https://phabricator.wikimedia.org/T246844) (owner: 10HMonroy) [00:54:26] (03PS1) 10DannyS712: "glboally" should be "globally" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/579679 [00:54:53] (03PS2) 10DannyS712: "glboally" should be "globally" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/579679 (https://phabricator.wikimedia.org/T201491) [00:55:56] (03PS10) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) [00:58:52] (03PS1) 10Reedy: Use ::class rather than string class name [core] - 10https://gerrit.wikimedia.org/r/579680 [00:59:31] 10MediaWiki-Internationalization, 10Wikisource, 10translatewiki.net, 10I18n: Add the Garhwali language (gbm) - https://phabricator.wikimedia.org/T247644 (10DannyS712) @Nesmir_Kudilovic does I54f8c136abcce8dd34fc11f745aad5f34f8191cc refer to https://gerrit.wikimedia.org/r/#/c/translatewiki/+/457895/ ? That... [01:00:54] 10MediaWiki-extensions-Scribunto: NS_MODULE not defined - https://phabricator.wikimedia.org/T247629 (10DannyS712) [01:04:11] (03PS11) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) [01:05:08] (03PS12) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) [01:08:02] 10ISA, 10Patch-For-Review, 10Wiki-Techstorm-2019: Save campaign images to the database - https://phabricator.wikimedia.org/T226303 (10Gabrielchl) Fixing the current issues in the above patch: - Test if it works well with "Wiki Loves xxx" campaigns - API query max number of pageids to provide at a time is 50,... [01:12:53] (03PS13) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) [01:15:52] (03PS14) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) [01:17:20] 10MediaWiki-Vagrant: XDebug makes requiring files unreasonably slow and affects open file limit - https://phabricator.wikimedia.org/T247587 (10Tgr) strace without xdebug: P10695 strace with xdebug: P10696 Not sure what to make of that. It does seem to try to close files after requiring them (several times, in f... [01:18:21] 10OOUI, 10Documentation, 10Technical-Debt, 10good first task: Reduce differences between PHP and JS code-comment documentation - https://phabricator.wikimedia.org/T162478 (10Fabrice_Ng) Hi guys, I'm Fabrice, I really want to work on this task because simple tasks like this usually get ignored and the probl... [01:20:21] (03PS1) 10Gergő Tisza: Move xdebug logfile off the shared directory [vagrant] - 10https://gerrit.wikimedia.org/r/579681 (https://phabricator.wikimedia.org/T247587) [01:21:23] 10MediaWiki-Vagrant, 10Patch-For-Review: XDebug makes requiring files unreasonably slow and affects open file limit - https://phabricator.wikimedia.org/T247587 (10Platonides) There are file descriptors being opened that you did not capture. Some suggestions: openat, dup2, socket, accept... [01:22:14] ^ tgr [01:22:56] (03PS15) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) [01:23:08] thanks [01:23:27] my knowledge of strace is pretty superficial [01:23:43] the file descriptor matches though [01:24:02] it looks like [01:24:04] open("/home/vagrant/script1076.php", O_RDONLY) = 1079 [01:24:26] and then close(1079) nine times in a row [01:25:34] there something else is using descriptors [01:25:42] just like, at the beginning: close(3) = 0 [01:25:42] close(3) = 0 [01:25:42] close(4) = 0 [01:25:43] close(4) = 0 [01:25:53] I guess you ran strace -eopen,close [01:26:19] try taking a full strace [01:26:28] or use an exclude approach [01:26:48] e.g. strace -e'!read,write,send,sendto,recv' [01:34:33] (03CR) 10jerkins-bot: [V: 04-1] Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) (owner: 10Reedy) [01:36:26] 10MediaWiki-Vagrant, 10Patch-For-Review: XDebug makes requiring files unreasonably slow and affects open file limit - https://phabricator.wikimedia.org/T247587 (10Tgr) Thanks! Unfiltered, grepped for a single descriptor: P10697 Which I think means the PHP file is closed but for every PHP file required, a new T... [01:43:59] 10MediaWiki-Vagrant, 10Patch-For-Review: XDebug makes requiring files unreasonably slow and affects open file limit - https://phabricator.wikimedia.org/T247587 (10Tgr) [[https://bugs.xdebug.org/bug_view_page.php?bug_id=00001641|XDebug bug #1641]] also seems relevant to the performance problems. (Why are we on... [01:59:59] (03PS16) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) [02:00:10] (03CR) 10Legoktm: [C: 03+2] "glboally" should be "globally" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/579679 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [02:01:04] (03PS2) 10Legoktm: tests: Use ::class rather than string class name [core] - 10https://gerrit.wikimedia.org/r/579680 (owner: 10Reedy) [02:01:06] (03CR) 10Legoktm: [C: 03+2] tests: Use ::class rather than string class name [core] - 10https://gerrit.wikimedia.org/r/579680 (owner: 10Reedy) [02:01:08] (03CR) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) (owner: 10Reedy) [02:12:58] (03CR) 10jerkins-bot: [V: 04-1] Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) (owner: 10Reedy) [02:13:10] (03PS17) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) [02:14:27] (03Merged) 10jenkins-bot: "glboally" should be "globally" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/579679 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [02:15:32] (03Merged) 10jenkins-bot: tests: Use ::class rather than string class name [core] - 10https://gerrit.wikimedia.org/r/579680 (owner: 10Reedy) [02:26:35] (03CR) 10Reedy: [C: 04-1] "Sweeeet. Ok so just LogstashFormatterTest and LogstashFormatter to unbreak" [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) (owner: 10Reedy) [02:26:51] (03PS18) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) [02:28:38] 10MediaWiki-Debug-Logger, 10MediaWiki-Vendor, 10Patch-For-Review: Update monolog/monolog to 2.0.2 - https://phabricator.wikimedia.org/T242751 (10Reedy) >>! In T242751#5968993, @gerritbot wrote: > Change 579668 had a related patch set uploaded (by Reedy; owner: Reedy): > [mediawiki/core@master] Updating monol... [02:38:22] (03CR) 10jerkins-bot: [V: 04-1] Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) (owner: 10Reedy) [02:45:08] (03CR) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) (owner: 10Reedy) [02:45:38] (03PS19) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) [02:57:03] (03CR) 10jerkins-bot: [V: 04-1] Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) (owner: 10Reedy) [03:14:19] 10MediaWiki-Debug-Logger, 10MediaWiki-Vendor, 10Patch-For-Review: Update monolog/monolog to 2.0.2 - https://phabricator.wikimedia.org/T242751 (10Reedy) https://gerrit.wikimedia.org/r/#/c/mediawiki/vendor/+/579666/2/monolog/monolog/UPGRADE.md ` #### LogstashFormatter - Removed Logstash V0 support - Context/e... [03:15:24] 10MediaWiki-Vagrant, 10Patch-For-Review: XDebug makes requiring files unreasonably slow and affects open file limit - https://phabricator.wikimedia.org/T247587 (10Tgr) The slowdown does not happen if there is no debug tool handling those connections. I use PHPStorm, so possibly it's an error with that and not... [03:27:48] 10MediaWiki-Vagrant, 10Patch-For-Review: XDebug makes requiring files unreasonably slow and affects open file limit - https://phabricator.wikimedia.org/T247587 (10Tgr) >>! In T247587#5969103, @Tgr wrote: > The slowdown does not happen if there is no debug tool handling those connections. I use PHPStorm, so pos... [03:31:04] 10MediaWiki-Debug-Logger, 10MediaWiki-Vendor, 10Patch-For-Review: Update monolog/monolog to 2.0.2 - https://phabricator.wikimedia.org/T242751 (10Reedy) Using `var_dump( $record, $formatted );` Old: ` R/var/www/wiki/mediawiki/core/tests/phpunit/unit/includes/debug/logger/monolog/LogstashFormatterTest.php:16:... [03:48:22] 10MediaWiki-Debug-Logger, 10MediaWiki-Vendor, 10Patch-For-Review: Update monolog/monolog to 2.0.2 - https://phabricator.wikimedia.org/T242751 (10Reedy) Shoving in a null (into a non null field) gives some errors for that, but fixes a couple of tests cases... ` There were 3 errors: 1) MediaWiki\Logger\Monol... [03:57:47] 10MediaWiki-extensions-ReplaceText: [ReplaceText] Unchecking the "Announce these edits" textbox should mark edits as bot - https://phabricator.wikimedia.org/T200334 (10SnorlaxMonster) I would like to echo this concern. The fact that the edits are completely hidden from logging even when viewing bot edits makes m... [03:58:05] (03CR) 10DannyS712: Use actor table in AbuseFilter (033 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/445185 (https://phabricator.wikimedia.org/T188180) (owner: 10Matěj Suchánek) [04:16:59] 10MediaWiki-Debug-Logger, 10MediaWiki-Vendor, 10Patch-For-Review: Update monolog/monolog to 2.0.2 - https://phabricator.wikimedia.org/T242751 (10Reedy) I'm not 100% clear if we need to do anything about these context keys anymore (ie no prefixing/renaming neeed?), as they're not moved into the top level, as... [04:19:33] (03PS1) 10Reedy: Cleanup and simplify LogStashFormatter [core] - 10https://gerrit.wikimedia.org/r/579682 (https://phabricator.wikimedia.org/T242751) [04:19:43] 10MediaWiki-Debug-Logger, 10MediaWiki-Vendor, 10Wikimedia-Logstash, 10Patch-For-Review: Update monolog/monolog to 2.0.2 - https://phabricator.wikimedia.org/T242751 (10Reedy) [04:21:07] (03CR) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) (031 comment) [vendor] - 10https://gerrit.wikimedia.org/r/579666 (https://phabricator.wikimedia.org/T242751) (owner: 10Reedy) [04:21:22] (03CR) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) (032 comments) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) (owner: 10Reedy) [04:30:40] 10MediaWiki-Debug-Logger, 10MediaWiki-Vendor, 10Wikimedia-Logstash, 10Patch-For-Review: Update monolog/monolog to 2.0.2 - https://phabricator.wikimedia.org/T242751 (10Reedy) >>! In T242751#5969137, @gerritbot wrote: > Change 579682 had a related patch set uploaded (by Reedy; owner: Reedy): > [mediawiki/cor... [04:33:12] 10MediaWiki-Codesniffer: Create sniff to help prevent logstash_formatter_key_conflict in mediawiki logs - https://phabricator.wikimedia.org/T245289 (10Reedy) {T242751} may make this obsolete if the monolog 2 upgrade prevents this from happening... [04:49:20] 10Google-Summer-of-Code (2020): Proposal: Develop a mechanism to send Wikimedia-specific Zulip welcome messages to newcomers(GSoC 2020) - https://phabricator.wikimedia.org/T247398 (10Rohan-cod) Hi @srishakatux, I will surely let you know if I face any problems. Thank you :) [05:49:57] 10OOUI, 10Documentation, 10Technical-Debt, 10good first task: Reduce differences between PHP and JS code-comment documentation - https://phabricator.wikimedia.org/T162478 (10Suchit1999) >>! In T162478#5969090, @Fabrice_Ng wrote: > Hi guys, I'm Fabrice, I really want to work on this task because simple task... [06:02:59] 10Outreach-Programs-Projects, 10Outreachy (Round 20): Productionize Wikidata-based Topic Model on ORES - https://phabricator.wikimedia.org/T245848 (10Tanvi_Singhal) Hi I am Tanvi a pre-final year undergraduate student from India. Looking forward to contributing to Wikimedia. I have a question @Isaac apart from... [06:16:03] (03CR) 10Ammarpad: Get consumerKey from 'consumerId' not from 'acceptanceId' (031 comment) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/579530 (https://phabricator.wikimedia.org/T247531) (owner: 10Ammarpad) [06:17:15] 10MediaWiki-extensions-Scribunto: NS_MODULE not defined - https://phabricator.wikimedia.org/T247629 (10alex-mashin) >>! In T247629#5968878, @Reedy wrote: > Not defined where? In `LocalSettings.php`, so that `$wgNamespaceProtection [NS_MODULE] = ['editmodule'];` restricts write access to the main namespace rathe... [06:18:49] 10CX-deployments, 10Language-Team (Language-2020-January-March), 10Patch-For-Review: Rebuild packages failing with apertium > 3.6 - https://phabricator.wikimedia.org/T247585 (10KartikMistry) [06:50:48] 10MediaWiki-Vagrant, 10Fundraising-Backlog: Add mediawiki-vagrant php7.2 xdebug support - https://phabricator.wikimedia.org/T220406 (10Tgr) XDebug 2.7.0 is broken horribly with MediaWiki-Vagrant, see {T247587} (same issue @abi mentions above). 2.7.2 works fine. We need this ASAP. [06:56:11] 10MediaWiki-Vagrant, 10Fundraising-Backlog: Package XDebug 2.7.2 for apt.wikimedia.org - https://phabricator.wikimedia.org/T220406 (10Tgr) [06:58:18] 10MediaWiki-Vagrant, 10Fundraising-Backlog, 10Operations: Package XDebug 2.7.2 for apt.wikimedia.org - https://phabricator.wikimedia.org/T220406 (10Tgr) [06:58:29] 10MediaWiki-Vagrant, 10Fundraising-Backlog, 10Operations: Package XDebug 2.7.2 for apt.wikimedia.org - https://phabricator.wikimedia.org/T220406 (10Tgr) Reframed the task since it seems the PECL route was discarded (probably for the better). OTOH we are about to support PHP 7.4 in MediaWiki, and testing that... [07:03:56] 10MediaWiki-Debug-Logger, 10MediaWiki-Vendor, 10Wikimedia-Logstash, 10Patch-For-Review: Update monolog/monolog to 2.0.2 - https://phabricator.wikimedia.org/T242751 (10Tgr) >>! In T242751#5969133, @Reedy wrote: > I'm not 100% clear if we need to do anything about these context keys anymore (ie no prefixing/... [07:06:57] (03CR) 10Aron Manning: "recheck" [skins/Vector] - 10https://gerrit.wikimedia.org/r/579620 (https://phabricator.wikimedia.org/T245734) (owner: 10Aron Manning) [07:07:43] 10MediaWiki-Vagrant, 10Patch-For-Review: XDebug makes requiring files unreasonably slow and affects open file limit - https://phabricator.wikimedia.org/T247587 (10Tgr) This is fixed in 2.7.2 [[https://bugs.xdebug.org/bug_view_page.php?bug_id=00001641|#1641]] or [[https://bugs.xdebug.org/bug_view_page.php?bug_i... [07:42:56] 10MediaWiki-extensions-Scribunto: NS_MODULE not defined - https://phabricator.wikimedia.org/T247629 (10Ammarpad) NS_MODULE is a non canonical namespace, you must use the numerical constant `lang=php $wgNamespaceProtection[ 828 ] = [ 'editmodule' ]; ` [08:00:26] 10MediaWiki-extensions-Page_Forms, 10Google-Summer-of-Code (2020): Remove use of jQuery UI from Page Forms - https://phabricator.wikimedia.org/T241632 (10Vpankaj1998) Hi I'm Pankaj Vaghela, from IIIT Ranchi, India. I'm CSE undergraduate. I love building website and have 3 years of experience. I'm interested in... [08:04:30] 10MediaWiki-extensions-Scribunto: NS_MODULE not defined - https://phabricator.wikimedia.org/T247629 (10alex-mashin) >>! In T247629#5969183, @Ammarpad wrote: > NS_MODULE is a non canonical namespace, you must use the numerical constant > `lang=php > $wgNamespaceProtection[ 828 ] = [ 'editmodule' ]; > ` That's wh... [08:07:45] 10MediaWiki-extensions-Scribunto: NS_MODULE not defined - https://phabricator.wikimedia.org/T247629 (10Ammarpad) >>! In T247629#5969186, @alex-mashin wrote: > That's what I did; No, you used $wgNamespaceProtection [NS_MODULE] = ['editmodule']; they're **not** the same thing. >howere NS_NODULE is mentioned here... [08:29:38] 10Outreach-Programs-Projects, 10Outreachy (Round 20): Productionize Wikidata-based Topic Model on ORES - https://phabricator.wikimedia.org/T245848 (10Srija616) Hey all! Had a doubt for revid_to_qid function. Is wikibase item same as qid?{F31680679} [08:31:01] (03PS1) 10Aron Manning: [POC] Scrollbar styling demonstration [skins/Vector] - 10https://gerrit.wikimedia.org/r/579684 [08:36:37] 10MediaWiki-extensions-Scribunto: NS_MODULE not defined - https://phabricator.wikimedia.org/T247629 (10alex-mashin) >>! In T247629#5969187, @Ammarpad wrote: >>>! In T247629#5969186, @alex-mashin wrote: >> That's what I did; > No, you used `$wgNamespaceProtection [NS_MODULE] = ['editmodule'];` that's **not** the... [08:45:13] 10MediaWiki-extensions-General, 10IPUtils, 10MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), 10Patch-For-Review, and 3 others: Replace IP class with IPUtils (General) - https://phabricator.wikimedia.org/T247155 (10Ankit-Maity) [08:51:32] (03CR) 10MaxSem: [C: 03+2] Setup: Move wgSkipSkins appendix to Skin::getAllowedSkins [core] - 10https://gerrit.wikimedia.org/r/579598 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [08:54:25] 10Google-Summer-of-Code (2020): Proposal: Develop a mechanism to send Wikimedia-specific Zulip welcome messages to newcomers(GSoC 2020) - https://phabricator.wikimedia.org/T247398 (10Rohan-cod) [09:03:27] (03Merged) 10jenkins-bot: Setup: Move wgSkipSkins appendix to Skin::getAllowedSkins [core] - 10https://gerrit.wikimedia.org/r/579598 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [09:04:51] (03PS1) 10QEDK: Bump MW version, remove deprecated IP class, update .gitignore [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/579685 (https://phabricator.wikimedia.org/T247155) [09:15:19] 10Technical blog, 10Developer-Advocacy (Jan-Mar 2020): Decide on favicon image for Technical Blog - https://phabricator.wikimedia.org/T246934 (10Aklapper) >>! In T246934#5968875, @srodlund wrote: > do you happen to know where the original file resides on Commons? @srodlund: tineye.com / images.google.com are y... [09:23:06] 10MediaWiki-extensions-Scribunto: NS_MODULE not defined - https://phabricator.wikimedia.org/T247629 (10Aklapper) @alex-mashin: Instead of having to ask several times due to byte-size information, it would be welcome if you followed https://www.mediawiki.org/wiki/How_to_report_a_bug and provide complete and clear... [09:30:07] 10MediaWiki-Internationalization, 10Wikisource, 10translatewiki.net, 10I18n, 10Patch-For-Review: Add the Garhwali language (gbm) - https://phabricator.wikimedia.org/T247644 (10Amire80) It is already supported in ULS. It doesn't appear in Meta because it doesn't have any localization. I've submitted a pa... [09:34:11] 10MediaWiki-Authentication-and-authorization, 10Documentation: https://www.mediawiki.org/wiki/API:Account_creation confusing - examples and details missing - https://phabricator.wikimedia.org/T235151 (10Seppl2013) I'd like to fix https://github.com/WolfgangFahl/Mediawiki-Japi/issues/46 and need a workaround... [09:40:46] (03PS2) 10Aron Manning: [POC] Scrollbar styling demonstration [skins/Vector] - 10https://gerrit.wikimedia.org/r/579684 [09:43:34] (03PS1) 10Zoranzoki21: build: Replace jshint/jsonlint with eslint [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/579687 (https://phabricator.wikimedia.org/T195542) [09:48:52] (03PS1) 10Zoranzoki21: build: Replace jshint/jsonlint with eslint [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/579688 (https://phabricator.wikimedia.org/T195542) [09:49:39] (03CR) 10Pwirth: [C: 03+2] Add new maintenance script `BSImportFiles` [extensions/BlueSpiceFoundation] (REL1_31) - 10https://gerrit.wikimedia.org/r/579521 (owner: 10Robert Vogel) [09:49:45] (03PS1) 10Pwirth: Add new maintenance script `BSImportFiles` [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/579689 [09:49:50] (03CR) 10Pwirth: [C: 03+2] Add new maintenance script `BSImportFiles` [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/579689 (owner: 10Pwirth) [09:49:55] (03PS1) 10Pwirth: Add new maintenance script `BSImportFiles` [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/579690 [09:50:42] (03CR) 10Pwirth: [C: 03+2] Add new maintenance script `BSImportFiles` [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/579690 (owner: 10Pwirth) [09:51:24] (03CR) 10Pwirth: [V: 03+2 C: 03+2] Replace BlueSpice\Services shortcuts with getService [extensions/BlueSpiceUserManager] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/579555 (owner: 10Robert Vogel) [09:51:29] (03CR) 10Pwirth: [V: 03+2 C: 03+2] Replace BlueSpice\Services shortcuts with getService [extensions/BlueSpiceEmoticons] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/579554 (owner: 10Robert Vogel) [09:51:34] (03CR) 10Pwirth: [V: 03+2 C: 03+2] Replace BlueSpice\Services shortcuts with getService [extensions/BlueSpiceDistributionConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/579552 (owner: 10Robert Vogel) [09:51:39] (03CR) 10Pwirth: [V: 03+2 C: 03+2] Replace BlueSpice\Services shortcuts with getService [extensions/BlueSpiceCustomMenu] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/579551 (owner: 10Robert Vogel) [09:51:44] (03CR) 10Pwirth: [V: 03+2 C: 03+2] Replace BlueSpice\Services shortcuts with getService [extensions/BlueSpiceConfigManager] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/579549 (owner: 10Robert Vogel) [09:52:11] (03Merged) 10jenkins-bot: Add new maintenance script `BSImportFiles` [extensions/BlueSpiceFoundation] (REL1_31) - 10https://gerrit.wikimedia.org/r/579521 (owner: 10Robert Vogel) [09:52:13] (03CR) 10jerkins-bot: [V: 04-1] Add new maintenance script `BSImportFiles` [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/579689 (owner: 10Pwirth) [09:52:33] (03CR) 10Pwirth: [V: 03+2] Promote field id to input element [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/577596 (owner: 10Mglaser) [09:52:40] (03CR) 10Pwirth: [V: 03+2] Promote field id to input element [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/579546 (owner: 10Robert Vogel) [09:53:08] (03CR) 10Pwirth: [C: 03+2] Replace BlueSpice\Services shortcuts with getService [extensions/BlueSpiceAvatars] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/579542 (owner: 10Robert Vogel) [09:53:12] (03CR) 10Pwirth: [C: 03+2] Replace BlueSpice\Services shortcuts with getService [extensions/BlueSpiceArticleInfo] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/579540 (owner: 10Robert Vogel) [09:53:16] (03CR) 10Pwirth: [C: 03+2] Replace BlueSpice\Services shortcuts with getService [extensions/BlueSpiceAuthors] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/579541 (owner: 10Robert Vogel) [09:54:02] (03CR) 10Pwirth: [V: 03+2 C: 03+2] Remove uses of Title::userCan [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/577839 (https://phabricator.wikimedia.org/T246139) (owner: 10DannyS712) [09:54:04] (03CR) 10jerkins-bot: [V: 04-1] Add new maintenance script `BSImportFiles` [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/579690 (owner: 10Pwirth) [09:54:44] (03PS1) 10Zoranzoki21: build: Replace jshint/jsonlint with eslint [extensions/SubpageSortkey] - 10https://gerrit.wikimedia.org/r/579691 (https://phabricator.wikimedia.org/T195542) [09:54:53] (03CR) 10jerkins-bot: [V: 04-1] Replace BlueSpice\Services shortcuts with getService [extensions/BlueSpiceAvatars] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/579542 (owner: 10Robert Vogel) [09:56:04] (03CR) 10jerkins-bot: [V: 04-1] Replace BlueSpice\Services shortcuts with getService [extensions/BlueSpiceAuthors] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/579541 (owner: 10Robert Vogel) [09:56:10] (03CR) 10jerkins-bot: [V: 04-1] Replace BlueSpice\Services shortcuts with getService [extensions/BlueSpiceArticleInfo] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/579540 (owner: 10Robert Vogel) [10:01:25] 10JavaScript, 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), 10Patch-For-Review, 10Technical-Debt: Convert all Wikimedia-deployed extensions and skins to lint JavaScript via eslint, not jshint/jscs - https://phabricator.wikimedia.org/T195542 (10Zoranzoki21) [10:02:03] (03PS1) 10Zoranzoki21: build: Replace jshint/jsonlint with eslint [extensions/SubPageList3] - 10https://gerrit.wikimedia.org/r/579692 (https://phabricator.wikimedia.org/T195542) [10:02:04] 10MediaWiki-Maintenance-scripts, 10MW-1.34-notes, 10MW-1.35-notes (1.35.0-wmf.21; 2020-02-25): updateCollation.php throws an error - https://phabricator.wikimedia.org/T246127 (10alex-mashin) I applied the last patch manually, and the maintenance script started to work. [10:07:00] (03PS1) 10Zoranzoki21: build: Replace jshint/jsonlint with eslint [extensions/SkinPerPage] - 10https://gerrit.wikimedia.org/r/579693 (https://phabricator.wikimedia.org/T195542) [10:08:55] 10Desktop Improvements, 10Patch-For-Review, 10Readers-Web-Backlog (Design): Consider making the new sidebar sticky/fixed - https://phabricator.wikimedia.org/T245734 (10Demian) [10:09:28] 10Desktop Improvements, 10Readers-Web-Backlog: Consider making the new sidebar sticky/fixed (discussion archive) - https://phabricator.wikimedia.org/T247031 (10Demian) [10:10:23] 10Desktop Improvements, 10Patch-For-Review, 10Readers-Web-Backlog (Design): Consider making the new sidebar sticky/fixed - https://phabricator.wikimedia.org/T245734 (10Demian) [10:11:30] (03CR) 10Pwirth: [V: 03+2 C: 03+2] Replace BlueSpice\Services shortcuts with getService [extensions/BlueSpiceAvatars] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/579542 (owner: 10Robert Vogel) [10:11:34] (03CR) 10Pwirth: [V: 03+2 C: 03+2] Replace BlueSpice\Services shortcuts with getService [extensions/BlueSpiceArticleInfo] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/579540 (owner: 10Robert Vogel) [10:11:40] (03CR) 10Pwirth: [V: 03+2 C: 03+2] Replace BlueSpice\Services shortcuts with getService [extensions/BlueSpiceAuthors] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/579541 (owner: 10Robert Vogel) [10:11:57] (03CR) 10Aron Manning: "Preparation for scrolling sidebar demos and potential use, also for body content." [skins/Vector] - 10https://gerrit.wikimedia.org/r/579620 (https://phabricator.wikimedia.org/T245734) (owner: 10Aron Manning) [10:15:41] 10WMEE Miljon+: EV102 campaign - https://phabricator.wikimedia.org/T247656 (10kruusamagi) [10:16:12] 10JavaScript, 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), 10Patch-For-Review, 10Technical-Debt: Convert all Wikimedia-deployed extensions and skins to lint JavaScript via eslint, not jshint/jscs - https://phabricator.wikimedia.org/T195542 (10Zoranzoki21) [10:18:59] 10JavaScript, 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), 10Patch-For-Review, 10Technical-Debt: Convert all Wikimedia-deployed extensions and skins to lint JavaScript via eslint, not jshint/jscs - https://phabricator.wikimedia.org/T195542 (10Zoranzoki21) [10:20:39] 10JavaScript, 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), 10Patch-For-Review, 10Technical-Debt: Convert all Wikimedia-deployed extensions and skins to lint JavaScript via eslint, not jshint/jscs - https://phabricator.wikimedia.org/T195542 (10Zoranzoki21) [10:21:13] 10UI-Standardization, 10Cleanup, 10MinervaNeue, 10MonoBook, and 6 others: Font family variables: use consistent names - https://phabricator.wikimedia.org/T245136 (10Demian) [10:32:54] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "I'm fine with either. My reason to do it the other way around was that $this->params is not really guaranteed to be initialized. It's only" [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/579629 (owner: 10Krinkle) [10:36:16] 10MediaWiki-Cache, 10Core Platform Team Workboards (Clinic Duty Team), 10User-brennen, 10Wikimedia-production-error: Warning: Memcached::setMulti(): failed to set key global:segment:... - https://phabricator.wikimedia.org/T247562 (10thiemowmde) Which of the action APIs is causing this? Is it even a specifi... [10:37:05] 10Accessibility, 10WikiEditor, 10MW-1.35-notes (1.35.0-wmf.24; 2020-03-17): Narrator not announcing the expand and collapse state of Advanced and Special Character Button - https://phabricator.wikimedia.org/T244426 (10TheDJ) Thank you @akinwale-microsoft [10:39:35] 10MediaWiki-extensions-General, 10IPUtils, 10MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), 10Patch-For-Review, and 3 others: Replace IP class with IPUtils (General) - https://phabricator.wikimedia.org/T247155 (10Ankit-Maity) [10:41:11] 10Accessibility, 10Desktop Improvements, 10Performance-Team (Radar), 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): [SPIKE] Determine the optimum Vector DOM structure for a11y and performance - https://phabricator.wikimedia.org/T240489 (10TheDJ) @demian I primarily use VoiceOver MacOS and iOS to test, and I... [10:42:51] (03PS1) 10Zoranzoki21: Fix order of rules in .phpcs.xml [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/579695 [10:46:56] 10JavaScript, 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), 10Patch-For-Review, 10Technical-Debt: Convert all Wikimedia-deployed extensions and skins to lint JavaScript via eslint, not jshint/jscs - https://phabricator.wikimedia.org/T195542 (10Zoranzoki21) [10:47:25] (03PS1) 10Zoranzoki21: build: Replace jshint/jsonlint with eslint [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/579696 (https://phabricator.wikimedia.org/T195542) [10:47:33] (03PS10) 10Fomafix: Rename PHP class RandomPage to SpecialRandomPage [core] - 10https://gerrit.wikimedia.org/r/564067 [10:50:02] (03PS6) 10Aron Manning: Add comments to the font-stacks, reference documentation [skins/Vector] - 10https://gerrit.wikimedia.org/r/577744 (https://phabricator.wikimedia.org/T244794) [10:50:06] (03PS24) 10Aron Manning: Rename font-family variable names to follow WikimediaUI Base [skins/Vector] - 10https://gerrit.wikimedia.org/r/570638 (https://phabricator.wikimedia.org/T246859) [10:52:08] 10Accessibility, 10Desktop Improvements, 10Performance-Team (Radar), 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): [SPIKE] Determine the optimum Vector DOM structure for a11y and performance - https://phabricator.wikimedia.org/T240489 (10TheDJ) Content sub is used for things like ’redirected from’, parent... [10:54:17] (03PS1) 10Zoranzoki21: Fix MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic [extensions/Listings] - 10https://gerrit.wikimedia.org/r/579697 [10:54:47] 10MediaWiki-Debug-Logger, 10MediaWiki-Vendor, 10Wikimedia-Logstash, 10Patch-For-Review: Update monolog/monolog to 2.0.2 - https://phabricator.wikimedia.org/T242751 (10Reedy) >>! In T242751#5969175, @Tgr wrote: >>>! In T242751#5969133, @Reedy wrote: >> I'm not 100% clear if we need to do anything about thes... [10:55:05] 10MediaWiki-extensions-Lockdown, 10Patch-For-Review: Lockdown on 1.27 causes problems with group membership - https://phabricator.wikimedia.org/T205805 (10Kghbln) 05Open→03Declined a:03MarkAHershberger I assume that this issue only affected REL1_27. Thus closing. In case this is not the case please re-open. [10:59:55] (03PS1) 10Zoranzoki21: build: Replace jshint/jsonlint with eslint [extensions/Listings] - 10https://gerrit.wikimedia.org/r/579698 (https://phabricator.wikimedia.org/T195542) [11:00:31] 10MediaWiki-extensions-CommentStreams, 10MediaWiki-extensions-Lockdown: Lockdown of Special:AllComments not possible - https://phabricator.wikimedia.org/T246099 (10Kghbln) @Krabina Have you tried using `CommentStreamsAllComments` as [[ https://github.com/wikimedia/mediawiki-extensions-CommentStreams/blob/maste... [11:04:57] 10UI-Standardization, 10Cleanup, 10MinervaNeue, 10MonoBook, and 6 others: Font family variables: use consistent names - https://phabricator.wikimedia.org/T245136 (10Demian) @ovasileva @Quiddity @phuedx @nray @Niedzielski @Jdlrobson Dear Readers Web Team! The cleanup and refactoring patches are rolling in... [11:09:11] (03CR) 10Aron Manning: [C: 04-1] "@Esanders a friendly reminder: do you know the answer to this question?" [skins/Vector] - 10https://gerrit.wikimedia.org/r/576106 (https://phabricator.wikimedia.org/T245838) (owner: 10Aron Manning) [11:09:39] (03PS5) 10Aron Manning: Cleanup: remove redundant CSS selectors [skins/Vector] - 10https://gerrit.wikimedia.org/r/576106 [11:09:57] (03CR) 10jerkins-bot: [V: 04-1] Cleanup: remove redundant CSS selectors [skins/Vector] - 10https://gerrit.wikimedia.org/r/576106 (owner: 10Aron Manning) [11:10:08] (03Abandoned) 10Aron Manning: Cleanup: remove redundant CSS selectors [skins/Vector] - 10https://gerrit.wikimedia.org/r/576106 (owner: 10Aron Manning) [11:12:28] (03PS9) 10Aron Manning: Cleanup: add Less variables `@font-size-heading-4`, -5, -6 [skins/Vector] - 10https://gerrit.wikimedia.org/r/576105 (https://phabricator.wikimedia.org/T245838) [11:12:58] (03CR) 10Ammarpad: "recheck" [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/579685 (https://phabricator.wikimedia.org/T247155) (owner: 10QEDK) [11:17:19] 10MediaWiki-extensions-Lockdown: Lockdown.alias.php should read Lockdown.php (to avoid warnings)? - https://phabricator.wikimedia.org/T234010 (10Kghbln) > the warning disappears. But I'm not sure if this is the fix and if it causes other problems. You are just avoid the errors but not fixing the issue. The whol... [11:17:24] 10AbuseFilter: Hide "User:" prefix from the "Autopromote block" and "Autopromote restore" logs - https://phabricator.wikimedia.org/T247173 (10Daimona) I think this shouldn't be too hard. The DB rows is storing NS and text separately, so it's just a matter of choosing the right method to build the link. Since the... [11:17:31] (03CR) 10Daimona Eaytoy: [WIP] Make TitleFactory a real factory (0310 comments) [core] - 10https://gerrit.wikimedia.org/r/579615 (https://phabricator.wikimedia.org/T247190) (owner: 10Daimona Eaytoy) [11:20:47] (03PS1) 10Kghbln: Remove call to non-existing alias file [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/579700 (https://phabricator.wikimedia.org/T234010) [11:24:23] (03CR) 10Umherirrender: [C: 03+2] Remove call to non-existing alias file [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/579700 (https://phabricator.wikimedia.org/T234010) (owner: 10Kghbln) [11:26:19] (03CR) 10Kghbln: "In case this fix is ok, which I think it is, I will create the back-ports for REL1_31, REL1_33 and REL1_34." [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/579700 (https://phabricator.wikimedia.org/T234010) (owner: 10Kghbln) [11:26:51] (03PS1) 10Kghbln: Remove call to non-existing alias file [extensions/Lockdown] (REL1_31) - 10https://gerrit.wikimedia.org/r/579701 (https://phabricator.wikimedia.org/T234010) [11:27:14] (03Merged) 10jenkins-bot: Remove call to non-existing alias file [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/579700 (https://phabricator.wikimedia.org/T234010) (owner: 10Kghbln) [11:27:20] (03PS1) 10Kghbln: Remove call to non-existing alias file [extensions/Lockdown] (REL1_33) - 10https://gerrit.wikimedia.org/r/579702 (https://phabricator.wikimedia.org/T234010) [11:27:35] (03PS1) 10Kghbln: Remove call to non-existing alias file [extensions/Lockdown] (REL1_34) - 10https://gerrit.wikimedia.org/r/579703 (https://phabricator.wikimedia.org/T234010) [11:28:34] (03CR) 10Umherirrender: [V: 03+2] "Break cycle with I1cc4d93abb6e53147f9c81abe3da35c540a6aa8f" [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/579560 (owner: 10Daimona Eaytoy) [11:28:48] (03CR) 10Kghbln: "Thanks a lot Umherirrender! Just created the cherry-picks to the supported release branches." [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/579700 (https://phabricator.wikimedia.org/T234010) (owner: 10Kghbln) [11:29:45] (03CR) 10Umherirrender: [C: 03+2] Remove call to non-existing alias file [extensions/Lockdown] (REL1_31) - 10https://gerrit.wikimedia.org/r/579701 (https://phabricator.wikimedia.org/T234010) (owner: 10Kghbln) [11:30:04] 10VideoCutTool, 10Patch-For-Review: Add {{extrancted from}} template in the derivative - https://phabricator.wikimedia.org/T247602 (10Gopavasanth) a:03Gopavasanth [11:30:07] 10MediaWiki-extensions-Translate, 10PHP 7.4 support: Translate PHP 7.4 issues - https://phabricator.wikimedia.org/T247657 (10Reedy) [11:30:12] 10MediaWiki-extensions-Lockdown: Lockdown.alias.php should read Lockdown.php (to avoid warnings)? - https://phabricator.wikimedia.org/T234010 (10Kghbln) [11:30:22] 10OOUI, 10Patch-For-Review, 10good first task: PopupWidget header should allow for an icon and an optional 'x' close button - https://phabricator.wikimedia.org/T164958 (10Soda) @Volker_E I've submitted a patch, could you take a look at it :) [11:30:24] 10MediaWiki-extensions-Lockdown: Lockdown.alias.php should read Lockdown.php (to avoid warnings)? - https://phabricator.wikimedia.org/T234010 (10Kghbln) 05Open→03Resolved a:03Kghbln [11:30:30] (03CR) 10Umherirrender: [C: 03+2] Remove call to non-existing alias file [extensions/Lockdown] (REL1_34) - 10https://gerrit.wikimedia.org/r/579703 (https://phabricator.wikimedia.org/T234010) (owner: 10Kghbln) [11:30:39] (03CR) 10Umherirrender: [C: 03+2] Remove call to non-existing alias file [extensions/Lockdown] (REL1_33) - 10https://gerrit.wikimedia.org/r/579702 (https://phabricator.wikimedia.org/T234010) (owner: 10Kghbln) [11:30:40] 10MediaWiki-extensions-Translate, 10PHP 7.4 support: Translate PHP 7.4 issues - https://phabricator.wikimedia.org/T247657 (10Reedy) [11:31:40] 10Wikimedia-General-or-Unknown, 10PHP 7.4 support: Make Wikimedia Production MediaWiki compatible with PHP 7.4 - https://phabricator.wikimedia.org/T247658 (10Reedy) [11:31:58] 10Wikimedia-General-or-Unknown, 10PHP 7.4 support: Make Wikimedia Production MediaWiki compatible with PHP 7.4 - https://phabricator.wikimedia.org/T247658 (10Reedy) [11:32:02] (03CR) 10jerkins-bot: [V: 04-1] Remove call to non-existing alias file [extensions/Lockdown] (REL1_31) - 10https://gerrit.wikimedia.org/r/579701 (https://phabricator.wikimedia.org/T234010) (owner: 10Kghbln) [11:32:18] (03CR) 10Umherirrender: [C: 03+2] Fix MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic [extensions/Listings] - 10https://gerrit.wikimedia.org/r/579697 (owner: 10Zoranzoki21) [11:32:25] 10MediaWiki-extensions-OAuth, 10MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), 10PHP 7.4 support: OAuth PHP 7.4 failures - https://phabricator.wikimedia.org/T247637 (10Reedy) [11:32:27] 10Wikimedia-General-or-Unknown, 10PHP 7.4 support: Make Wikimedia Production MediaWiki compatible with PHP 7.4 - https://phabricator.wikimedia.org/T247658 (10Reedy) [11:32:29] 10MediaWiki-General, 10MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), 10MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), 10MW-1.35-release, and 3 others: Make MediaWiki core compatible with PHP 7.4 - https://phabricator.wikimedia.org/T233012 (10Reedy) [11:32:45] 10Wikimedia-General-or-Unknown, 10PHP 7.4 support: Make Wikimedia Production MediaWiki compatible with PHP 7.4 - https://phabricator.wikimedia.org/T247658 (10Reedy) [11:32:50] 10MediaWiki-General, 10MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), 10MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), 10MW-1.35-release, and 3 others: Make MediaWiki core compatible with PHP 7.4 - https://phabricator.wikimedia.org/T233012 (10Reedy) [11:33:54] 10Wikimedia-General-or-Unknown, 10PHP 7.4 support: Make Wikimedia Production MediaWiki compatible with PHP 7.4 - https://phabricator.wikimedia.org/T247658 (10Reedy) [11:33:55] (03Merged) 10jenkins-bot: Remove call to non-existing alias file [extensions/Lockdown] (REL1_34) - 10https://gerrit.wikimedia.org/r/579703 (https://phabricator.wikimedia.org/T234010) (owner: 10Kghbln) [11:33:56] 10MediaWiki-extensions-Translate, 10PHP 7.4 support: Translate PHP 7.4 issues - https://phabricator.wikimedia.org/T247657 (10Reedy) [11:34:16] (03Merged) 10jenkins-bot: Remove call to non-existing alias file [extensions/Lockdown] (REL1_33) - 10https://gerrit.wikimedia.org/r/579702 (https://phabricator.wikimedia.org/T234010) (owner: 10Kghbln) [11:34:26] (03CR) 10Kghbln: "Not sure why we have a test against PHP 7.3 in here since MW 1.31 is not meant to support it. Is there a way to force the merge?" [extensions/Lockdown] (REL1_31) - 10https://gerrit.wikimedia.org/r/579701 (https://phabricator.wikimedia.org/T234010) (owner: 10Kghbln) [11:35:02] (03Merged) 10jenkins-bot: Fix MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic [extensions/Listings] - 10https://gerrit.wikimedia.org/r/579697 (owner: 10Zoranzoki21) [11:37:02] (03PS2) 10Umherirrender: No need to pass $parser by reference [extensions/ContributionsList] - 10https://gerrit.wikimedia.org/r/579465 (owner: 10Zoranzoki21) [11:37:06] (03CR) 10Umherirrender: [C: 03+2] No need to pass $parser by reference (031 comment) [extensions/ContributionsList] - 10https://gerrit.wikimedia.org/r/579465 (owner: 10Zoranzoki21) [11:38:39] (03CR) 10Umherirrender: [V: 03+2 C: 03+2] "That is T236070" [extensions/Lockdown] (REL1_31) - 10https://gerrit.wikimedia.org/r/579701 (https://phabricator.wikimedia.org/T234010) (owner: 10Kghbln) [11:39:22] (03CR) 10Kghbln: "Cool. Thanks Umherirrender. Much appreciated!" [extensions/Lockdown] (REL1_31) - 10https://gerrit.wikimedia.org/r/579701 (https://phabricator.wikimedia.org/T234010) (owner: 10Kghbln) [11:39:39] 10UI-Standardization, 10MonoBook, 10Timeless, 10Wikimedia Design Style Guide, and 2 others: Add comments to the font-stacks to summarize the research since 2014's Typography Refresh - https://phabricator.wikimedia.org/T244794 (10Demian) @Volker_E A friendly reminder that there was no response from you rega... [11:39:56] (03Merged) 10jenkins-bot: No need to pass $parser by reference [extensions/ContributionsList] - 10https://gerrit.wikimedia.org/r/579465 (owner: 10Zoranzoki21) [11:41:07] (03PS2) 10Zoranzoki21: build: Replace jshint/jsonlint with eslint [extensions/ContributionsList] - 10https://gerrit.wikimedia.org/r/579466 (https://phabricator.wikimedia.org/T210365) [11:45:34] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Maps (Kartographer): Maplink (via Wikidata) shows only empty window without map on all wikipedias - https://phabricator.wikimedia.org/T225350 (10TheDJ) 05Open→03Resolved a:03TheDJ [11:46:01] 10VideoCutTool, 10Patch-For-Review: Add {{extrancted from}} template in the derivative - https://phabricator.wikimedia.org/T247602 (10Gopavasanth) Hi @Geagea , > And also what about cropping single frame? It would be very useful to crop only a single photo. Can you please describe about this feature little more? [11:46:22] 10MediaWiki-Debug-Logger, 10MediaWiki-Vendor, 10Wikimedia-Logstash, 10MW-1.35-release, 10Patch-For-Review: Update monolog/monolog to 2.0.2 - https://phabricator.wikimedia.org/T242751 (10Reedy) Also tagging 1.35... As 1.35 is going to be an LTS, it seems beneficial to get the newer version of monolog into... [11:49:59] (03CR) 10Aron Manning: "A friendly reminder, that I've very strong reasons to merge this patch:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/576105 (https://phabricator.wikimedia.org/T245838) (owner: 10Aron Manning) [11:50:16] 10MediaWiki-extensions-Lockdown: Lockdown locks namespace 0 if not using array_fill - https://phabricator.wikimedia.org/T211093 (10Kghbln) [11:50:50] (03CR) 10Aron Manning: "Amend: "I've **given** very strong reasons"" [skins/Vector] - 10https://gerrit.wikimedia.org/r/576105 (https://phabricator.wikimedia.org/T245838) (owner: 10Aron Manning) [11:52:10] 10Google-Drive-to-Commons: Not able to select multiple images - https://phabricator.wikimedia.org/T247367 (1001tonythomas) [11:54:31] (03CR) 10Umherirrender: [V: 03+2] "The problem is more about I80ab7c7e0085256f55bd6ceeb890f50a1711e25b" [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/579560 (owner: 10Daimona Eaytoy) [11:55:33] (03CR) 10Aron Manning: "@Volker_E: A friendly reminder that the only useful question to be answered is still UNanswered:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/578679 (owner: 10Aron Manning) [11:56:00] 10Google-Drive-to-Commons: Inform the users that they can edit the details of the image and addition of metadata fields - https://phabricator.wikimedia.org/T247369 (1001tonythomas) [11:58:06] 10VideoCutTool, 10Patch-For-Review: Add {{extracted from}} Commons template in the derivative - https://phabricator.wikimedia.org/T247602 (10Aklapper) [12:01:22] 10Google-Drive-to-Commons: A license selection drop down before uploading pictures - https://phabricator.wikimedia.org/T241425 (1001tonythomas) >>! In T241425#5965551, @Abbasidaniyal wrote: > Since we are selecting multiple images, each image can have a different license. Should be proceed image-wise or some wi... [12:01:25] (03CR) 10Aron Manning: "@Krinkle as no-one else has engaged: what solution have you decided upon to port the selenium script to windows?" [core] - 10https://gerrit.wikimedia.org/r/579245 (owner: 10Aron Manning) [12:02:08] (03CR) 10Umherirrender: Use MediaWikiServices::getRepoGroup (031 comment) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/578076 (owner: 10Umherirrender) [12:05:16] (03PS2) 10Umherirrender: Use MediaWikiServices::getRepoGroup [extensions/ImageTweaks] - 10https://gerrit.wikimedia.org/r/578091 [12:05:25] (03CR) 10Umherirrender: Use MediaWikiServices::getRepoGroup (032 comments) [extensions/ImageTweaks] - 10https://gerrit.wikimedia.org/r/578091 (owner: 10Umherirrender) [12:07:09] 10MediaWiki-General, 10Core Platform Team, 10Patch-For-Review: Complete TitleFactory to be a real factory service - https://phabricator.wikimedia.org/T247190 (10Daimona) >>! In T247190#5969032, @Tgr wrote: > The question is, will Title be around long enough for this to be worth the effort? This is a good qu... [12:07:49] 10Google-Drive-to-Commons: After login, files are listed in a random order - https://phabricator.wikimedia.org/T247338 (1001tonythomas) I think we would be limited by Google https://developers.google.com/picker/docs and feel free to see if there is a way to make it allow us to see folders. Thank you for the repo... [12:09:44] (03PS3) 10Umherirrender: Use MediaWikiServices::getRepoGroup [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/578078 [12:09:53] (03CR) 10Umherirrender: Use MediaWikiServices::getRepoGroup (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/578078 (owner: 10Umherirrender) [12:13:50] 10OOUI, 10Documentation, 10Technical-Debt, 10good first task: Reduce differences between PHP and JS code-comment documentation - https://phabricator.wikimedia.org/T162478 (10Aklapper) > I don't understand that how I clone this file(s) in my local system. Under "Tags" this task says #OOUI. Click it and go... [12:16:27] (03CR) 10Umherirrender: Use MediaWikiServices::getRepoGroup (032 comments) [core] - 10https://gerrit.wikimedia.org/r/578135 (owner: 10Umherirrender) [12:16:38] (03PS2) 10Umherirrender: Use MediaWikiServices::getRepoGroup [core] - 10https://gerrit.wikimedia.org/r/578135 [12:18:08] (03PS3) 10Aron Manning: Fix editor font-size (13px) being too small in comparison to article (15.2px) [skins/Timeless] - 10https://gerrit.wikimedia.org/r/578568 (https://phabricator.wikimedia.org/T247325) [12:19:46] (03PS33) 10Aron Manning: Replace Grunt tasks with NPM scripts. Devdependencies not updated. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/574636 (https://phabricator.wikimedia.org/T246321) [12:19:48] (03PS19) 10Aron Manning: Remove grunt* devdependencies, regenerate package-lock.json [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575665 (https://phabricator.wikimedia.org/T245930) [12:22:46] (03CR) 10Umherirrender: Use MediaWikiServices::getRepoGroup (031 comment) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/578076 (owner: 10Umherirrender) [12:31:38] (03PS3) 10Umherirrender: Use MediaWikiServices::getRepoGroup in special page related classes [core] - 10https://gerrit.wikimedia.org/r/578133 [12:33:12] (03CR) 10Umherirrender: Use MediaWikiServices::getRepoGroup in special page related classes (039 comments) [core] - 10https://gerrit.wikimedia.org/r/578133 (owner: 10Umherirrender) [12:35:16] (03PS4) 10Umherirrender: Use MediaWikiServices::getRepoGroup in special page related classes [core] - 10https://gerrit.wikimedia.org/r/578133 [12:36:48] (03PS3) 10Umherirrender: Use MediaWikiServices::getRepoGroup in file related classes [core] - 10https://gerrit.wikimedia.org/r/578134 [12:37:00] (03CR) 10Umherirrender: Use MediaWikiServices::getRepoGroup in file related classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/578134 (owner: 10Umherirrender) [12:48:09] 10UI-Standardization, 10Wikimedia Design Style Guide: Deprecation of `@font-family-sans` in WikimediaUI Base (tracking) - https://phabricator.wikimedia.org/T247166 (10Demian) Subbing @Volker_E as the person [[ https://phabricator.wikimedia.org/rWMUIc75852427a537edce807f7dca48db6baf12f497b#change-iLpx5UZAFVo7 |... [12:51:38] 10Internet-Archive, 10InternetArchiveBot: Convert archive.today to archive.org - https://phabricator.wikimedia.org/T245276 (10Green_Cardamom) There are seven (known) domains: archive.is, .fo, .li, .today, .vn, .md, .ph The bot does not recognize all of them so it sees the URL as being invalid and converts it... [12:59:24] (03PS1) 10Umherirrender: Use MediaWikiServices::getMessageCache [core] - 10https://gerrit.wikimedia.org/r/579707 [13:00:14] (03CR) 10Thiemo Kreuz (WMDE): "Nice update, thanks a lot to both of you!" [extensions/ContributionsList] - 10https://gerrit.wikimedia.org/r/579465 (owner: 10Zoranzoki21) [13:03:02] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] "Hm. That's not really worth a patch, to be honest. I suggest to not invest to much time in something like this if there is nothing else to" [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/579695 (owner: 10Zoranzoki21) [13:04:30] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Don't call $parserOutput->getExtensionData() if unneeded [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/579216 (owner: 10DannyS712) [13:04:33] (03PS1) 10Umherirrender: Use MediaWikiServices::getMessageCache [extensions/Echo] - 10https://gerrit.wikimedia.org/r/579709 [13:04:50] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Upgrade to manifest_version 2 [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/579214 (owner: 10DannyS712) [13:06:18] (03PS1) 10Umherirrender: Use MediaWikiServices::getMessageCache [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/579710 [13:07:16] (03CR) 10Aron Manning: "> please seek review from Volker on all of these changes. He owns this part of the stack." [skins/Vector] - 10https://gerrit.wikimedia.org/r/577744 (https://phabricator.wikimedia.org/T244794) (owner: 10Aron Manning) [13:08:25] (03PS1) 10Umherirrender: Use MediaWikiServices::getMessageCache [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/579711 [13:08:55] (03CR) 10Umherirrender: "This is possible not the best way to handle services in tests." [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/579711 (owner: 10Umherirrender) [13:10:40] (03PS1) 10Umherirrender: Use MediaWikiServices::getMessageCache [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/579713 [13:12:07] 10DiscussionTools, 10Editing QA, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.24; 2020-03-17): Show error messages immediately when loading fails - https://phabricator.wikimedia.org/T247533 (10matmarex) [13:13:44] (03CR) 10jerkins-bot: [V: 04-1] Use MediaWikiServices::getMessageCache [core] - 10https://gerrit.wikimedia.org/r/579707 (owner: 10Umherirrender) [13:16:40] (03PS4) 10Bartosz Dziewoński: controller: Make edit summary use the wiki's content language [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/578521 (https://phabricator.wikimedia.org/T246043) [13:17:52] (03PS2) 10Umherirrender: Use MediaWikiServices::getMessageCache [core] - 10https://gerrit.wikimedia.org/r/579707 [13:18:18] 10Accessibility, 10Desktop Improvements, 10Performance-Team (Radar), 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): [SPIKE] Determine the optimum Vector DOM structure for a11y and performance - https://phabricator.wikimedia.org/T240489 (10Demian) >>! In T240489#5969246, @TheDJ wrote: > @demian I primarily u... [13:18:49] (03PS5) 10Bartosz Dziewoński: controller: Make edit summary use the wiki's content language [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/578521 (https://phabricator.wikimedia.org/T246043) [13:19:52] (03CR) 10Bartosz Dziewoński: controller: Make edit summary use the wiki's content language (031 comment) [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/578521 (https://phabricator.wikimedia.org/T246043) (owner: 10Bartosz Dziewoński) [13:20:00] (03CR) 10jerkins-bot: [V: 04-1] Use MediaWikiServices::getMessageCache [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/579711 (owner: 10Umherirrender) [13:20:48] (03PS2) 10Umherirrender: Use MediaWikiServices::getMessageCache [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/579711 [13:25:28] (03PS3) 10Umherirrender: Use MediaWikiServices::getMessageCache [core] - 10https://gerrit.wikimedia.org/r/579707 [13:28:38] (03PS1) 10Umherirrender: Use MediaWikiServices::getRepoGroup [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/579717 [13:30:08] 10Accessibility, 10Desktop Improvements, 10Performance-Team (Radar), 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): [SPIKE] Determine the optimum Vector DOM structure for a11y and performance - https://phabricator.wikimedia.org/T240489 (10Demian) Related: https://webaim.org/projects/screenreadersurvey8/ (... [13:30:30] 10MediaWiki-Revision-backend, 10Beta-Cluster-Infrastructure, 10User-DannyS712: BetaCluster: ExternalStoreException - Unable to store text to external storage - https://phabricator.wikimedia.org/T228088 (10AlexisJazz) My gut says T247207, T247617 and "//Upload error Unable to modify the file "6f2dbfewe.jpg" b... [13:30:56] (03PS1) 10Umherirrender: Use MediaWikiServices::getRepoGroup [extensions/3D] - 10https://gerrit.wikimedia.org/r/579719 [13:33:12] (03Merged) 10jenkins-bot: Fix order of rules in .phpcs.xml [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/579695 (owner: 10Zoranzoki21) [13:33:14] (03Merged) 10jenkins-bot: Upgrade to manifest_version 2 [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/579214 (owner: 10DannyS712) [13:33:16] (03Merged) 10jenkins-bot: Remove old inline comment, since resolved [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/579215 (owner: 10DannyS712) [13:33:18] (03Merged) 10jenkins-bot: Don't call $parserOutput->getExtensionData() if unneeded [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/579216 (owner: 10DannyS712) [13:33:20] (03Merged) 10jenkins-bot: Remove JsonToPgnParser.php, not used or loaded in extension.json [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/579217 (owner: 10DannyS712) [13:33:22] (03Merged) 10jenkins-bot: Remove unused FenParser0x88::$longNotation [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/579218 (owner: 10DannyS712) [13:33:24] (03CR) 10jerkins-bot: [V: 04-1] Use MediaWikiServices::getRepoGroup [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/579717 (owner: 10Umherirrender) [13:34:12] (03PS1) 10Umherirrender: Use MediaWikiServices::getRepoGroup [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/579720 [13:34:31] (03PS7) 10Bartosz Dziewoński: Merge RL modules which are only loaded by 'ext.discussionTools.init' [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/574630 (https://phabricator.wikimedia.org/T240474) [13:34:42] (03PS5) 10Bartosz Dziewoński: parser: Improve merging multiple comments on one line [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/578013 [13:36:29] (03PS1) 10Umherirrender: Use MediaWikiServices::getRepoGroup [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/579721 [13:37:29] (03PS1) 10Umherirrender: Use MediaWikiServices::getRepoGroup [extensions/LinkSuggest] - 10https://gerrit.wikimedia.org/r/579722 [13:39:11] (03PS1) 10Umherirrender: Use MediaWikiServices::getRepoGroup [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/579723 [13:43:22] (03PS1) 10Umherirrender: Use MediaWikiServices::getRepoGroup [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/579724 [13:44:31] (03PS5) 10Daimona Eaytoy: [WIP] Make TitleFactory a real factory [core] - 10https://gerrit.wikimedia.org/r/579615 (https://phabricator.wikimedia.org/T247190) [13:45:28] (03PS1) 10Umherirrender: Use MediaWikiServices::getRepoGroup [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/579725 [13:46:26] (03PS1) 10Umherirrender: Use MediaWikiServices::getRepoGroup [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/579726 [13:48:35] (03PS1) 10Umherirrender: Use MediaWikiServices::getRepoGroup [extensions/Score] - 10https://gerrit.wikimedia.org/r/579727 [13:49:35] (03PS2) 10Umherirrender: Use MediaWikiServices::getRepoGroup [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/579717 [13:50:32] (03PS2) 10Umherirrender: Use MediaWikiServices::getRepoGroup [extensions/Score] - 10https://gerrit.wikimedia.org/r/579727 [13:59:23] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Make TitleFactory a real factory [core] - 10https://gerrit.wikimedia.org/r/579615 (https://phabricator.wikimedia.org/T247190) (owner: 10Daimona Eaytoy) [14:01:57] (03PS1) 10Zoranzoki21: build: Replace jshint/jsonlint with eslint [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/579728 (https://phabricator.wikimedia.org/T195542) [14:02:01] 10Design, 10Revision-Slider, 10TCB-Team, 10WMDE-Design, 10WMDE-QWERTY-Sprint-2020-03-04: Fix misleading help text talking about yellow/blue knobs - https://phabricator.wikimedia.org/T247662 (10thiemowmde) [14:02:18] (03PS1) 10Daimona Eaytoy: MediaWikiTitleCodec: Change constructor signature, drop BC code [core] - 10https://gerrit.wikimedia.org/r/579729 [14:03:13] (03PS2) 10Daimona Eaytoy: MediaWikiTitleCodec: Change constructor signature, drop BC code [core] - 10https://gerrit.wikimedia.org/r/579729 [14:05:00] (03PS3) 10Daimona Eaytoy: MediaWikiTitleCodec: Change constructor signature, drop BC code [core] - 10https://gerrit.wikimedia.org/r/579729 [14:05:07] (03CR) 10Zfilipin: "Disclaimer: I am not an Windows or unix/linux expert." [core] - 10https://gerrit.wikimedia.org/r/579245 (owner: 10Aron Manning) [14:08:21] (03CR) 10jerkins-bot: [V: 04-1] MediaWikiTitleCodec: Change constructor signature, drop BC code [core] - 10https://gerrit.wikimedia.org/r/579729 (owner: 10Daimona Eaytoy) [14:11:47] (03PS4) 10Daimona Eaytoy: MediaWikiTitleCodec: Change constructor signature, drop BC code [core] - 10https://gerrit.wikimedia.org/r/579729 [14:14:09] 10Google-Summer-of-Code (2020): [Proposal] Create OOUI widget for Index page pagelists {Google Summer of Code 2020} - https://phabricator.wikimedia.org/T247157 (10Soda) [14:14:23] 10Google-Summer-of-Code (2020): [Proposal] Create OOUI widget for Index page pagelists {Google Summer of Code 2020} - https://phabricator.wikimedia.org/T247157 (10Soda) @shrishakatux, I'll get in touch with the mentors ASAP [14:17:00] 10Google-Summer-of-Code (2020): [Proposal] Create OOUI widget for Index page pagelists {Google Summer of Code 2020} - https://phabricator.wikimedia.org/T247157 (10Soda) [14:17:30] (03CR) 10Aron Manning: "Thank you for your comment and adding reviewers, Željko!" [core] - 10https://gerrit.wikimedia.org/r/579245 (owner: 10Aron Manning) [14:36:14] (03PS6) 10Daimona Eaytoy: [WIP] Make TitleFactory a real factory [core] - 10https://gerrit.wikimedia.org/r/579615 (https://phabricator.wikimedia.org/T247190) [14:38:38] 10MediaWiki-General, 10MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), 10Patch-For-Review, 10User-Andreas, and 3 others: Fix common typos in code - https://phabricator.wikimedia.org/T201491 (10Ankit-Maity) [14:40:05] 10MediaWiki-General, 10MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), 10Patch-For-Review, 10User-Andreas, and 3 others: Fix common typos in code - https://phabricator.wikimedia.org/T201491 (10Ankit-Maity) [14:41:11] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Make TitleFactory a real factory [core] - 10https://gerrit.wikimedia.org/r/579615 (https://phabricator.wikimedia.org/T247190) (owner: 10Daimona Eaytoy) [14:43:12] (03PS7) 10Daimona Eaytoy: [WIP] Make TitleFactory a real factory [core] - 10https://gerrit.wikimedia.org/r/579615 (https://phabricator.wikimedia.org/T247190) [14:45:25] (03PS1) 10Zoranzoki21: .phpcs.xml: Remove non-available file from exclude-pattern [extensions/intersection] - 10https://gerrit.wikimedia.org/r/579734 [14:46:54] (03PS2) 10Zoranzoki21: .phpcs.xml: Remove unavailable file from exclude-pattern [extensions/intersection] - 10https://gerrit.wikimedia.org/r/579734 [14:50:40] (03CR) 10Esanders: [C: 03+2] controller: Make edit summary use the wiki's content language [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/578521 (https://phabricator.wikimedia.org/T246043) (owner: 10Bartosz Dziewoński) [14:51:29] (03PS1) 10Zoranzoki21: build: Replace jshint/jsonlint with eslint [extensions/intersection] - 10https://gerrit.wikimedia.org/r/579735 (https://phabricator.wikimedia.org/T195542) [14:51:40] (03PS2) 10Zoranzoki21: build: Replace jshint/jsonlint with eslint [extensions/intersection] - 10https://gerrit.wikimedia.org/r/579735 (https://phabricator.wikimedia.org/T195542) [14:52:43] (03PS1) 10QEDK: Bump MW version, remove deprecated IP class, update .gitignore [extensions/SecureSessions] - 10https://gerrit.wikimedia.org/r/579736 (https://phabricator.wikimedia.org/T247155) [14:53:35] (03CR) 10Esanders: [C: 03+2] Merge RL modules which are only loaded by 'ext.discussionTools.init' [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/574630 (https://phabricator.wikimedia.org/T240474) (owner: 10Bartosz Dziewoński) [14:54:41] 10MediaWiki-extensions-General, 10IPUtils, 10MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), 10Patch-For-Review, and 3 others: Replace IP class with IPUtils (General) - https://phabricator.wikimedia.org/T247155 (10Ankit-Maity) [14:57:53] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Make TitleFactory a real factory [core] - 10https://gerrit.wikimedia.org/r/579615 (https://phabricator.wikimedia.org/T247190) (owner: 10Daimona Eaytoy) [15:00:29] (03CR) 10Zoranzoki21: "recheck" [extensions/SecureSessions] - 10https://gerrit.wikimedia.org/r/579736 (https://phabricator.wikimedia.org/T247155) (owner: 10QEDK) [15:06:24] 10MediaWiki-extensions-General, 10IPUtils, 10MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), 10Patch-For-Review, and 3 others: Replace IP class with IPUtils (General) - https://phabricator.wikimedia.org/T247155 (10Ankit-Maity) [15:13:15] (03PS1) 10Zoranzoki21: build: Replace jshint/jsonlint with eslint [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/579739 (https://phabricator.wikimedia.org/T195542) [15:23:26] (03PS7) 10Sahajsk: Cargo: Make Special:CargoQuery autocompletion appearance as standard MediaWiki [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/574163 (https://phabricator.wikimedia.org/T242973) [15:24:30] 10Google-Summer-of-Code (2020): Proposal: Develop a mechanism to send Wikimedia-specific Zulip welcome messages to newcomers(GSoC 2020) - https://phabricator.wikimedia.org/T247398 (10Rohan-cod) [15:27:29] (03CR) 10Sahajsk: "> Uploaded patch set 7." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/574163 (https://phabricator.wikimedia.org/T242973) (owner: 10Sahajsk) [15:35:53] (03PS1) 10Zoranzoki21: build: Replace jshint/jsonlint with eslint [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/579740 (https://phabricator.wikimedia.org/T195542) [15:39:58] (03PS8) 10Sahajsk: Cargo: Make Special:CargoQuery autocompletion appearance as standard MediaWiki [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/574163 (https://phabricator.wikimedia.org/T242973) [15:41:29] (03CR) 10Sahajsk: "> Uploaded patch set 8." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/574163 (https://phabricator.wikimedia.org/T242973) (owner: 10Sahajsk) [15:42:55] (03PS1) 10Zoranzoki21: build: Replace jshint/jsonlint with eslint [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/579741 (https://phabricator.wikimedia.org/T195542) [15:43:52] (03CR) 10Jforrester: [C: 04-1] "Quite apart from the poor violations of the CoC in responding to review, this patch will break on systems that don't have bash installed b" [core] - 10https://gerrit.wikimedia.org/r/579245 (owner: 10Aron Manning) [15:47:06] (03PS1) 10Zoranzoki21: build: Replace jshint/jsonlint with eslint [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/579743 (https://phabricator.wikimedia.org/T195542) [15:47:44] (03Merged) 10jenkins-bot: controller: Make edit summary use the wiki's content language [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/578521 (https://phabricator.wikimedia.org/T246043) (owner: 10Bartosz Dziewoński) [15:47:46] (03Merged) 10jenkins-bot: Merge RL modules which are only loaded by 'ext.discussionTools.init' [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/574630 (https://phabricator.wikimedia.org/T240474) (owner: 10Bartosz Dziewoński) [15:47:48] (03Merged) 10jenkins-bot: parser: Improve merging multiple comments on one line [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/578013 (owner: 10Bartosz Dziewoński) [15:48:44] 10MobileFrontend, 10MinervaNeue: Pressing the "Show on map" button in advanced mode reloads the page - https://phabricator.wikimedia.org/T247664 (10BrandonXLF) [15:50:31] (03CR) 10Jforrester: [C: 03+2] Bump MW version, remove deprecated IP class, update .gitignore [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/579685 (https://phabricator.wikimedia.org/T247155) (owner: 10QEDK) [15:51:42] (03PS1) 10Zoranzoki21: Move sql files into the sql/ directory [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579744 [15:51:44] (03CR) 10Jforrester: [C: 03+2] Bump MW version, remove deprecated IP class, update .gitignore [extensions/SecureSessions] - 10https://gerrit.wikimedia.org/r/579736 (https://phabricator.wikimedia.org/T247155) (owner: 10QEDK) [15:57:28] 10MediaWiki-extensions-General, 10IPUtils, 10MW-1.35-notes (1.35.0-wmf.24; 2020-03-17), 10Patch-For-Review, and 3 others: Replace IP class with IPUtils (General) - https://phabricator.wikimedia.org/T247155 (10Ankit-Maity) [15:57:43] (03PS1) 10Zoranzoki21: Move CodeCommentLinkerHtml class into the own file [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579745 [15:59:01] (03PS2) 10Zoranzoki21: Move CodeCommentLinkerHtml class into the own file [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579745 [15:59:50] (03PS1) 10Zoranzoki21: Move CodeCommentLinkerWiki class into the own file [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579746 [16:00:02] (03PS2) 10Zoranzoki21: Move CodeCommentLinkerWiki class into the own file [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579746 [16:00:50] (03Merged) 10jenkins-bot: Bump MW version, remove deprecated IP class, update .gitignore [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/579685 (https://phabricator.wikimedia.org/T247155) (owner: 10QEDK) [16:00:52] (03Merged) 10jenkins-bot: Bump MW version, remove deprecated IP class, update .gitignore [extensions/SecureSessions] - 10https://gerrit.wikimedia.org/r/579736 (https://phabricator.wikimedia.org/T247155) (owner: 10QEDK) [16:00:59] (03CR) 10Jforrester: [C: 03+2] Move sql files into the sql/ directory [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579744 (owner: 10Zoranzoki21) [16:01:53] (03PS1) 10Zoranzoki21: Move SubversionPecl class into the own file [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579747 [16:02:48] (03CR) 10Jforrester: "check php" [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/579629 (owner: 10Krinkle) [16:03:09] (03PS1) 10Zoranzoki21: Move SubversionShell class into the own file [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579748 [16:03:54] (03Merged) 10jenkins-bot: Move sql files into the sql/ directory [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579744 (owner: 10Zoranzoki21) [16:04:04] (03PS2) 10Zoranzoki21: Move SubversionPecl class into the own file [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579747 [16:04:09] (03PS2) 10Zoranzoki21: Move SubversionShell class into the own file [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579748 [16:04:21] (03CR) 10Jforrester: [C: 03+2] Updating web-auth/* (v2.1.7 => v3.1.1) [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/564691 (https://phabricator.wikimedia.org/T242753) (owner: 10Reedy) [16:04:23] (03CR) 10Jforrester: [C: 03+2] Updating web-auth/* (v2.1.7 => v3.1.1) [vendor] - 10https://gerrit.wikimedia.org/r/564688 (https://phabricator.wikimedia.org/T242753) (owner: 10Reedy) [16:04:33] (03PS1) 10Zoranzoki21: Move SubversionProxy class into the own file [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579749 [16:04:39] (03PS2) 10Zoranzoki21: Move SubversionProxy class into the own file [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579749 [16:05:30] (03CR) 10jerkins-bot: [V: 04-1] Move SubversionShell class into the own file [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579748 (owner: 10Zoranzoki21) [16:06:31] (03CR) 10Jforrester: [C: 03+2] tests: Remove PHP 7.4 workaround [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/579629 (owner: 10Krinkle) [16:06:34] (03PS1) 10Zoranzoki21: Move CodeCommentsTablePager class into the own file [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579750 [16:06:40] (03CR) 10Jforrester: [C: 03+2] Move CodeCommentLinkerHtml class into the own file [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579745 (owner: 10Zoranzoki21) [16:06:44] (03PS2) 10Zoranzoki21: Move CodeCommentsTablePager class into the own file [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579750 [16:06:48] (03CR) 10jerkins-bot: [V: 04-1] Move CodeCommentsTablePager class into the own file [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579750 (owner: 10Zoranzoki21) [16:06:51] (03CR) 10Jforrester: [C: 03+2] Move CodeCommentLinkerWiki class into the own file [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579746 (owner: 10Zoranzoki21) [16:07:05] (03CR) 10Jforrester: [C: 03+2] Move SubversionPecl class into the own file [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579747 (owner: 10Zoranzoki21) [16:07:27] (03CR) 10Jforrester: [C: 03+2] Move SubversionShell class into the own file [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579748 (owner: 10Zoranzoki21) [16:07:47] (03CR) 10Jforrester: [C: 03+2] Move SubversionProxy class into the own file [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579749 (owner: 10Zoranzoki21) [16:08:26] (03CR) 10Jforrester: [C: 03+2] build: Replace jshint/jsonlint with eslint [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/579687 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:08:34] (03CR) 10Jforrester: [C: 03+2] build: Replace jshint/jsonlint with eslint [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/579688 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:08:47] (03CR) 10Jforrester: [C: 03+2] build: Replace jshint/jsonlint with eslint [extensions/SubpageSortkey] - 10https://gerrit.wikimedia.org/r/579691 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:08:56] (03CR) 10Jforrester: [C: 03+2] build: Replace jshint/jsonlint with eslint [extensions/SubPageList3] - 10https://gerrit.wikimedia.org/r/579692 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:09:03] (03CR) 10jerkins-bot: [V: 04-1] Move CodeCommentsTablePager class into the own file [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579750 (owner: 10Zoranzoki21) [16:09:05] (03CR) 10Jforrester: [C: 03+2] build: Replace jshint/jsonlint with eslint [extensions/SkinPerPage] - 10https://gerrit.wikimedia.org/r/579693 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:09:07] 10MediaWiki-General, 10MediaWiki-extensions-CentralNotice, 10MediaWiki-extensions-Graph, 10MediaWiki-extensions-InputBox, and 14 others: Deprecate jquery.throttle-debounce in favour of mw.util.debounce or OO.ui.debounce/throttle - https://phabricator.wikimedia.org/T213426 (10TheDJ) [16:09:25] (03CR) 10Jforrester: [C: 03+2] build: Replace jshint/jsonlint with eslint [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/579696 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:09:33] (03CR) 10Jforrester: [C: 03+2] build: Replace jshint/jsonlint with eslint [extensions/Listings] - 10https://gerrit.wikimedia.org/r/579698 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:09:46] (03CR) 10Jforrester: [C: 03+2] build: Replace jshint/jsonlint with eslint [extensions/ContributionsList] - 10https://gerrit.wikimedia.org/r/579466 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [16:09:53] (03CR) 10Jforrester: [C: 03+2] build: Replace jshint/jsonlint with eslint [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/579728 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:10:26] (03PS1) 10Jack Phoenix: Preliminary cleanup to the maintenance scripts [extensions/Athena] - 10https://gerrit.wikimedia.org/r/579751 [16:10:35] (03CR) 10Jforrester: [C: 03+2] build: Replace jshint/jsonlint with eslint [extensions/intersection] - 10https://gerrit.wikimedia.org/r/579735 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:10:56] (03CR) 10Jforrester: [C: 03+2] build: Replace jshint/jsonlint with eslint [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/579739 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:11:04] (03CR) 10Jforrester: [C: 03+2] build: Replace jshint/jsonlint with eslint [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/579740 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:11:11] (03CR) 10Jforrester: [C: 03+2] build: Replace jshint/jsonlint with eslint [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/579741 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:11:20] (03CR) 10Jforrester: [C: 03+2] build: Replace jshint/jsonlint with eslint [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/579743 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:11:43] (03CR) 10Jforrester: [C: 03+2] .phpcs.xml: Remove unavailable file from exclude-pattern [extensions/intersection] - 10https://gerrit.wikimedia.org/r/579734 (owner: 10Zoranzoki21) [16:12:25] 10MediaWiki-extensions-Graph: Graph with dates displays fine in preview, but duplicates labels in rendered PNG - https://phabricator.wikimedia.org/T247667 (10AntiCompositeNumber) [16:12:39] (03CR) 10Jforrester: [C: 03+2] Move some files into the directories for consistency [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/577767 (owner: 10Zoranzoki21) [16:13:03] 10JavaScript, 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), 10Patch-For-Review, 10Technical-Debt: Convert all Wikimedia-deployed extensions and skins to lint JavaScript via eslint, not jshint/jscs - https://phabricator.wikimedia.org/T195542 (10Zoranzoki21) [16:13:21] (03CR) 10Jforrester: [C: 03+2] Convert SmiteSpam to use extension registration [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/577772 (https://phabricator.wikimedia.org/T204329) (owner: 10Zoranzoki21) [16:13:29] (03CR) 10Jforrester: [C: 03+2] Drop generate-autoloads.php and autoload.php [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/577773 (owner: 10Zoranzoki21) [16:14:26] 10MediaWiki-extensions-SmiteSpam, 10Patch-For-Review, 10User-Zoranzoki21: Convert SmiteSpam to use extension registration - https://phabricator.wikimedia.org/T204329 (10Zoranzoki21) 05Open→03Resolved Patch got +2, and it will be merged. I'm closing this task as resolved now, so I don't forget later to do... [16:14:31] 10MediaWiki-Configuration, 10MediaWiki-extensions-General, 10Goal, 10Patch-For-Review, 10User-Zoranzoki21: Convert all extensions and skins on gerrit to use extension registration - https://phabricator.wikimedia.org/T98668 (10Zoranzoki21) [16:14:40] (03PS10) 10Jforrester: Convert DidYouKnow to use extension registration [extensions/DidYouKnow] - 10https://gerrit.wikimedia.org/r/452660 (https://phabricator.wikimedia.org/T201906) (owner: 10Zoranzoki21) [16:15:03] (03CR) 10jerkins-bot: [V: 04-1] Preliminary cleanup to the maintenance scripts [extensions/Athena] - 10https://gerrit.wikimedia.org/r/579751 (owner: 10Jack Phoenix) [16:15:42] (03CR) 10Jforrester: [C: 03+1] Convert DidYouKnow to use extension registration (031 comment) [extensions/DidYouKnow] - 10https://gerrit.wikimedia.org/r/452660 (https://phabricator.wikimedia.org/T201906) (owner: 10Zoranzoki21) [16:16:06] 10MediaWiki-General, 10Composer: Composer Library Updates, late 2019 edition - https://phabricator.wikimedia.org/T235266 (10Jdforrester-WMF) [16:16:08] (03Merged) 10jenkins-bot: Updating web-auth/* (v2.1.7 => v3.1.1) [vendor] - 10https://gerrit.wikimedia.org/r/564688 (https://phabricator.wikimedia.org/T242753) (owner: 10Reedy) [16:16:10] (03Merged) 10jenkins-bot: Updating web-auth/* (v2.1.7 => v3.1.1) [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/564691 (https://phabricator.wikimedia.org/T242753) (owner: 10Reedy) [16:16:12] (03Merged) 10jenkins-bot: tests: Remove PHP 7.4 workaround [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/579629 (owner: 10Krinkle) [16:16:14] (03Merged) 10jenkins-bot: Move CodeCommentLinkerHtml class into the own file [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579745 (owner: 10Zoranzoki21) [16:16:16] (03Merged) 10jenkins-bot: Move CodeCommentLinkerWiki class into the own file [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579746 (owner: 10Zoranzoki21) [16:16:18] (03Merged) 10jenkins-bot: Move SubversionPecl class into the own file [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579747 (owner: 10Zoranzoki21) [16:16:20] (03Merged) 10jenkins-bot: Move SubversionShell class into the own file [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579748 (owner: 10Zoranzoki21) [16:16:22] (03Merged) 10jenkins-bot: Move SubversionProxy class into the own file [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579749 (owner: 10Zoranzoki21) [16:16:24] (03Merged) 10jenkins-bot: build: Replace jshint/jsonlint with eslint [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/579687 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:16:26] (03Merged) 10jenkins-bot: build: Replace jshint/jsonlint with eslint [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/579688 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:16:41] 10MediaWiki-General, 10Composer: Composer Library Updates, late 2019 edition - https://phabricator.wikimedia.org/T235266 (10Jdforrester-WMF) (Or "…ahead of MW 1.35 release", but…) [16:17:30] (03PS3) 10Zoranzoki21: Move CodeCommentsTablePager class into the own file [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579750 [16:18:20] 10MediaWiki-extensions-OATHAuth, 10Patch-For-Review: Upgrade web-auth/* from 2.1.7 to 3.0.1 - https://phabricator.wikimedia.org/T242753 (10Jdforrester-WMF) 05Open→03Resolved a:03Reedy [16:18:22] 10MediaWiki-General, 10Composer: Composer Library Updates, late 2019 edition - https://phabricator.wikimedia.org/T235266 (10Jdforrester-WMF) [16:19:26] (03PS11) 10Zoranzoki21: Convert DidYouKnow to use extension registration [extensions/DidYouKnow] - 10https://gerrit.wikimedia.org/r/452660 (https://phabricator.wikimedia.org/T201906) [16:19:42] (03CR) 10Zoranzoki21: Convert DidYouKnow to use extension registration (031 comment) [extensions/DidYouKnow] - 10https://gerrit.wikimedia.org/r/452660 (https://phabricator.wikimedia.org/T201906) (owner: 10Zoranzoki21) [16:19:45] 10MediaWiki-extensions-Graph: Graph with dates displays fine in preview, but duplicates labels in rendered PNG - https://phabricator.wikimedia.org/T247667 (10AntiCompositeNumber) {F31681118} Looking closer, in the preview SVG, the label is offset from the data point in an inconsistent manner. The rendered PNG fi... [16:20:09] (03PS9) 10Daimona Eaytoy: TitleFactory #1: Add params to Title::__construct, kill secureAndSplit [core] - 10https://gerrit.wikimedia.org/r/579570 (https://phabricator.wikimedia.org/T247190) [16:20:29] (03CR) 10Jforrester: [C: 03+2] Use MediaWikiServices::getRepoGroup [core] - 10https://gerrit.wikimedia.org/r/578135 (owner: 10Umherirrender) [16:21:15] (03Merged) 10jenkins-bot: build: Replace jshint/jsonlint with eslint [extensions/SubpageSortkey] - 10https://gerrit.wikimedia.org/r/579691 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:22:01] (03CR) 10Jforrester: [C: 03+2] Convert DidYouKnow to use extension registration [extensions/DidYouKnow] - 10https://gerrit.wikimedia.org/r/452660 (https://phabricator.wikimedia.org/T201906) (owner: 10Zoranzoki21) [16:22:56] 10InternetArchiveBot: bot creates |quote= parameters from google books url - https://phabricator.wikimedia.org/T246762 (10Green_Cardamom) It will be disabled with the next batch. The data is not lost it is saved on my computer should it need to be restored or used in some way in the future. [16:22:58] (03PS2) 10Jack Phoenix: Preliminary cleanup to the maintenance scripts [extensions/Athena] - 10https://gerrit.wikimedia.org/r/579751 [16:23:19] (03PS8) 10Daimona Eaytoy: [WIP] Make TitleFactory a real factory [core] - 10https://gerrit.wikimedia.org/r/579615 (https://phabricator.wikimedia.org/T247190) [16:23:40] (03Merged) 10jenkins-bot: build: Replace jshint/jsonlint with eslint [extensions/SubPageList3] - 10https://gerrit.wikimedia.org/r/579692 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:23:42] (03Merged) 10jenkins-bot: build: Replace jshint/jsonlint with eslint [extensions/SkinPerPage] - 10https://gerrit.wikimedia.org/r/579693 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:23:44] (03Merged) 10jenkins-bot: build: Replace jshint/jsonlint with eslint [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/579696 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:23:46] (03Merged) 10jenkins-bot: build: Replace jshint/jsonlint with eslint [extensions/Listings] - 10https://gerrit.wikimedia.org/r/579698 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:23:48] (03Merged) 10jenkins-bot: build: Replace jshint/jsonlint with eslint [extensions/ContributionsList] - 10https://gerrit.wikimedia.org/r/579466 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [16:23:50] (03Merged) 10jenkins-bot: build: Replace jshint/jsonlint with eslint [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/579728 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:25:04] (03PS9) 10Daimona Eaytoy: [WIP] Make TitleFactory a real factory [core] - 10https://gerrit.wikimedia.org/r/579615 (https://phabricator.wikimedia.org/T247190) [16:25:25] (03CR) 10Jack Phoenix: "CI failure is unrelated because the main extension code assumes that the "franc" binary is always installed and usable. I assume that this" [extensions/Athena] - 10https://gerrit.wikimedia.org/r/579751 (owner: 10Jack Phoenix) [16:25:30] (03Merged) 10jenkins-bot: build: Replace jshint/jsonlint with eslint [extensions/intersection] - 10https://gerrit.wikimedia.org/r/579735 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:25:32] (03Merged) 10jenkins-bot: build: Replace jshint/jsonlint with eslint [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/579740 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:25:34] (03CR) 10jerkins-bot: [V: 04-1] build: Replace jshint/jsonlint with eslint [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/579741 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:25:42] 10ISA, 10Patch-For-Review, 10Wiki-Techstorm-2019: Save campaign images to the database - https://phabricator.wikimedia.org/T226303 (10Gabrielchl) A problem with the above patch is that it doesn't work for Wiki Love campaigns, as they require specific category information of the images. I've considered fetchi... [16:26:17] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/579741 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:27:15] (03Merged) 10jenkins-bot: build: Replace jshint/jsonlint with eslint [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/579743 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:27:17] (03Merged) 10jenkins-bot: .phpcs.xml: Remove unavailable file from exclude-pattern [extensions/intersection] - 10https://gerrit.wikimedia.org/r/579734 (owner: 10Zoranzoki21) [16:27:19] (03Merged) 10jenkins-bot: Move some files into the directories for consistency [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/577767 (owner: 10Zoranzoki21) [16:27:21] (03Merged) 10jenkins-bot: Convert SmiteSpam to use extension registration [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/577772 (https://phabricator.wikimedia.org/T204329) (owner: 10Zoranzoki21) [16:27:23] (03Merged) 10jenkins-bot: Drop generate-autoloads.php and autoload.php [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/577773 (owner: 10Zoranzoki21) [16:27:27] (03CR) 10jerkins-bot: [V: 04-1] build: Replace jshint/jsonlint with eslint [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/579739 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:27:53] (03CR) 10Jforrester: [C: 03+2] Use MediaWikiServices::getRepoGroup [extensions/3D] - 10https://gerrit.wikimedia.org/r/579719 (owner: 10Umherirrender) [16:28:14] (03CR) 10Zoranzoki21: "Permission denied... again..." [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/579739 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:28:41] (03CR) 10Jforrester: [C: 03+2] Use MediaWikiServices::getRepoGroup [extensions/ImageTweaks] - 10https://gerrit.wikimedia.org/r/578091 (owner: 10Umherirrender) [16:29:01] (03CR) 10Jforrester: [C: 03+2] Use MediaWikiServices::getRepoGroup [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/579724 (owner: 10Umherirrender) [16:29:12] (03CR) 10Jforrester: [C: 03+2] Use MediaWikiServices::getRepoGroup [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/579723 (owner: 10Umherirrender) [16:29:15] (03CR) 10Jforrester: [C: 03+2] Use MediaWikiServices::getRepoGroup [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/579717 (owner: 10Umherirrender) [16:29:27] (03CR) 10Jforrester: [C: 03+2] Use MediaWikiServices::getRepoGroup [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/579721 (owner: 10Umherirrender) [16:30:12] (03CR) 10Jforrester: [C: 03+2] "Death to wfFindFile!" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/578078 (owner: 10Umherirrender) [16:30:40] (03CR) 10Jforrester: [C: 03+2] Use MediaWikiServices::getRepoGroup [extensions/Score] - 10https://gerrit.wikimedia.org/r/579727 (owner: 10Umherirrender) [16:30:42] (03CR) 10Zoranzoki21: "Can you +2 this also so I can resume with work without "merge conflict" and others?" [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579750 (owner: 10Zoranzoki21) [16:30:45] (03CR) 10Jforrester: [C: 03+2] Use MediaWikiServices::getRepoGroup [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/579720 (owner: 10Umherirrender) [16:30:55] (03CR) 10Jforrester: [C: 03+2] Use MediaWikiServices::getRepoGroup [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/579726 (owner: 10Umherirrender) [16:31:01] (03CR) 10Jforrester: [C: 03+2] Use MediaWikiServices::getRepoGroup [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/579725 (owner: 10Umherirrender) [16:31:09] (03CR) 10Jforrester: [C: 03+2] Use MediaWikiServices::getRepoGroup [extensions/LinkSuggest] - 10https://gerrit.wikimedia.org/r/579722 (owner: 10Umherirrender) [16:31:19] 10MediaWiki-extensions-WikimediaBadges, 10Wikidata, 10Wikimedia-Interwiki-links: Update the code behind the Wikimedia Commons link in the sidebar to use P910 and P1754 instead of P373 - https://phabricator.wikimedia.org/T232927 (10Mike_Peel) @Lydia_Pintscher Is this within WMDE's scope, or WMF? It would be n... [16:31:58] 10MediaWiki-extensions-Other, 10Patch-For-Review, 10User-Zoranzoki21: Convert DidYouKnow to use extension registration - https://phabricator.wikimedia.org/T201906 (10Zoranzoki21) 05Open→03Resolved One more resolved, finally! [16:33:17] (03CR) 10Jforrester: [C: 03+2] Use MediaWikiServices::getRepoGroup (031 comment) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/578076 (owner: 10Umherirrender) [16:33:51] (03CR) 10Jforrester: [C: 03+2] Use MediaWikiServices::getRepoGroup [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/579044 (owner: 10Umherirrender) [16:34:10] (03CR) 10Jforrester: [C: 03+2] Use MediaWikiServices::getRepoGroup [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/579046 (owner: 10Umherirrender) [16:35:20] (03CR) 10Jforrester: [C: 03+2] Use MediaWikiServices::getRepoGroup [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/578085 (owner: 10Umherirrender) [16:35:31] (03CR) 10DannyS712: [C: 03+1] "LGTM" [core] - 10https://gerrit.wikimedia.org/r/579729 (owner: 10Daimona Eaytoy) [16:35:46] (03Merged) 10jenkins-bot: Use MediaWikiServices::getRepoGroup [core] - 10https://gerrit.wikimedia.org/r/578135 (owner: 10Umherirrender) [16:35:48] (03Merged) 10jenkins-bot: Convert DidYouKnow to use extension registration [extensions/DidYouKnow] - 10https://gerrit.wikimedia.org/r/452660 (https://phabricator.wikimedia.org/T201906) (owner: 10Zoranzoki21) [16:35:50] (03Merged) 10jenkins-bot: build: Replace jshint/jsonlint with eslint [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/579741 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [16:35:54] (03Merged) 10jenkins-bot: Use MediaWikiServices::getRepoGroup [extensions/3D] - 10https://gerrit.wikimedia.org/r/579719 (owner: 10Umherirrender) [16:36:04] (03CR) 10jerkins-bot: [V: 04-1] Preliminary cleanup to the maintenance scripts [extensions/Athena] - 10https://gerrit.wikimedia.org/r/579751 (owner: 10Jack Phoenix) [16:36:54] (03PS1) 10Jack Phoenix: Preliminary cleanup to main extension code [extensions/Athena] - 10https://gerrit.wikimedia.org/r/579753 [16:37:17] (03CR) 10Zoranzoki21: "Permission denied again" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/579723 (owner: 10Umherirrender) [16:37:45] (03CR) 10Jack Phoenix: [C: 03+2] Javascript coding conventions: Clean up whitespace [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579676 (owner: 10DannyS712) [16:38:10] (03CR) 10Jforrester: [C: 03+2] Use MediaWikiServices::getRepoGroup in file related classes [core] - 10https://gerrit.wikimedia.org/r/578134 (owner: 10Umherirrender) [16:38:12] (03CR) 10DannyS712: [C: 03+1] "LGTM" [core] - 10https://gerrit.wikimedia.org/r/578134 (owner: 10Umherirrender) [16:38:37] (03CR) 10jerkins-bot: [V: 04-1] Preliminary cleanup to main extension code [extensions/Athena] - 10https://gerrit.wikimedia.org/r/579753 (owner: 10Jack Phoenix) [16:39:48] (03CR) 10DannyS712: [C: 03+1] "LGTM" [core] - 10https://gerrit.wikimedia.org/r/578133 (owner: 10Umherirrender) [16:40:19] (03PS2) 10Jack Phoenix: Preliminary cleanup to main extension code [extensions/Athena] - 10https://gerrit.wikimedia.org/r/579753 [16:40:30] (03Merged) 10jenkins-bot: Use MediaWikiServices::getRepoGroup [extensions/ImageTweaks] - 10https://gerrit.wikimedia.org/r/578091 (owner: 10Umherirrender) [16:40:36] (03CR) 10Krinkle: [C: 03+2] Move contents of mediawiki.legacy.commonPrint into ResourceLoaderSkinModule [core] - 10https://gerrit.wikimedia.org/r/579420 (https://phabricator.wikimedia.org/T242177) (owner: 10Jdlrobson) [16:40:44] (03Merged) 10jenkins-bot: Use MediaWikiServices::getRepoGroup [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/579724 (owner: 10Umherirrender) [16:40:46] (03CR) 10jerkins-bot: [V: 04-1] Use MediaWikiServices::getRepoGroup [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/579723 (owner: 10Umherirrender) [16:40:49] (03Merged) 10jenkins-bot: Use MediaWikiServices::getRepoGroup [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/579717 (owner: 10Umherirrender) [16:41:22] (03CR) 10Jforrester: [C: 03+2] Use MediaWikiServices::getRepoGroup in special page related classes [core] - 10https://gerrit.wikimedia.org/r/578133 (owner: 10Umherirrender) [16:41:58] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/579723 (owner: 10Umherirrender) [16:42:16] (03CR) 10jerkins-bot: [V: 04-1] Preliminary cleanup to main extension code [extensions/Athena] - 10https://gerrit.wikimedia.org/r/579753 (owner: 10Jack Phoenix) [16:42:46] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Make TitleFactory a real factory [core] - 10https://gerrit.wikimedia.org/r/579615 (https://phabricator.wikimedia.org/T247190) (owner: 10Daimona Eaytoy) [16:43:08] 10MediaWiki-extensions-Other, 10User-Zoranzoki21: Convert DidYouKnow to use extension registration - https://phabricator.wikimedia.org/T201906 (10DannyS712) [16:43:17] (03CR) 10Jforrester: [C: 03+2] Use MediaWikiServices::getMessageCache [extensions/Echo] - 10https://gerrit.wikimedia.org/r/579709 (owner: 10Umherirrender) [16:43:27] (03CR) 10Jforrester: [C: 03+2] Use MediaWikiServices::getMessageCache [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/579713 (owner: 10Umherirrender) [16:43:32] (03CR) 10Jforrester: [C: 03+2] Use MediaWikiServices::getMessageCache [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/579710 (owner: 10Umherirrender) [16:43:41] (03PS2) 10Krinkle: resourceloader: Merge 'user.tokens' module into 'user.options' [core] - 10https://gerrit.wikimedia.org/r/579660 (https://phabricator.wikimedia.org/T235457) [16:44:34] (03CR) 10Jforrester: [C: 03+2] Use MediaWikiServices::getMessageCache [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/579711 (owner: 10Umherirrender) [16:45:06] (03CR) 10Jforrester: [C: 03+2] Use MediaWikiServices::getMessageCache [core] - 10https://gerrit.wikimedia.org/r/579707 (owner: 10Umherirrender) [16:47:53] 10MobileFrontend, 10Readers-Web-Backlog, 10Developer Productivity: PHPUnit warning noise from MwApiContentProviderTest (MobileFrontend) - https://phabricator.wikimedia.org/T247669 (10Krinkle) [16:48:43] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Wikidata-Campsite, 10Developer Productivity: PHPUnit warning noise from ClientParserOutputDataUpdaterTest (Wikibase) - https://phabricator.wikimedia.org/T247670 (10Krinkle) [16:49:44] (03Merged) 10jenkins-bot: Use MediaWikiServices::getRepoGroup [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/579721 (owner: 10Umherirrender) [16:50:13] (03PS2) 10Krinkle: Convert $wgMemc use to WANObjectCache [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/570714 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [16:52:49] (03PS3) 10Krinkle: Convert $wgMemc use to WANObjectCache [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/570714 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [16:52:56] (03CR) 10Krinkle: [C: 03+2] Convert $wgMemc use to WANObjectCache [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/570714 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [16:59:38] (03PS1) 10Krinkle: Setup: Remove compat for $wgUseSquid and friends [core] - 10https://gerrit.wikimedia.org/r/579755 (https://phabricator.wikimedia.org/T189966) [16:59:52] (03Merged) 10jenkins-bot: Use MediaWikiServices::getRepoGroup [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/578078 (owner: 10Umherirrender) [17:00:36] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/579739 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [17:01:16] (03CR) 10Jforrester: [C: 03+2] Move CodeCommentsTablePager class into the own file [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579750 (owner: 10Zoranzoki21) [17:09:00] (03PS4) 10Ammarpad: OAuth: Replace User::isAllowed calls with PermissionManager. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/575768 (https://phabricator.wikimedia.org/T246567) [17:10:06] (03CR) 10jerkins-bot: [V: 04-1] Use MediaWikiServices::getRepoGroup [extensions/Score] - 10https://gerrit.wikimedia.org/r/579727 (owner: 10Umherirrender) [17:10:29] (03CR) 10jerkins-bot: [V: 04-1] OAuth: Replace User::isAllowed calls with PermissionManager. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/575768 (https://phabricator.wikimedia.org/T246567) (owner: 10Ammarpad) [17:14:02] 10Outreach-Programs-Projects, 10Outreachy (Round 20): Productionize Wikidata-based Topic Model on ORES - https://phabricator.wikimedia.org/T245848 (10Tanvi_Singhal) @Srija616, as mentioned in the instructions the revision ID, is language-specific, so if the revision is from English Wikipedia, the page props... [17:21:31] 10MediaWiki-extensions-OATHAuth, 10MW-1.35-notes (1.35.0-wmf.24; 2020-03-17): Upgrade web-auth/* from 2.1.7 to 3.1.1 - https://phabricator.wikimedia.org/T242753 (10Reedy) [17:22:17] 10CX-deployments, 10Language-Team (Language-2020-January-March), 10Patch-For-Review: Rebuild packages failing with apertium > 3.6 - https://phabricator.wikimedia.org/T247585 (10KartikMistry) [17:22:52] 10WMEE: EV102 campaign - https://phabricator.wikimedia.org/T247656 (10tramm) [17:28:11] 10MediaWiki-API, 10Core Platform Team, 10Technical-Debt: Remove deprecated ApiQueryDeletedRevs - https://phabricator.wikimedia.org/T221869 (10Aklapper) Yes, there are still uses. :) The logstash query (`_type:"mediawiki" AND channel:"api-feature-usage" AND feature.raw:"action=query&list=deletedrevs"`; last 3... [17:31:10] 10WMEE: Särkide pildistamine + postitus - https://phabricator.wikimedia.org/T247612 (10tramm) 05Open→03Resolved FB, Twitter, Instagram ja blogi. Tehtud. [17:31:12] 10WMEE: Särkide turundamine - https://phabricator.wikimedia.org/T247341 (10tramm) [17:31:53] (03PS1) 10Zoranzoki21: build: Replace jshint/jsonlint with eslint [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/579760 (https://phabricator.wikimedia.org/T195542) [17:43:00] (03CR) 10jerkins-bot: [V: 04-1] Use MediaWikiServices::getRepoGroup [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/579720 (owner: 10Umherirrender) [17:47:11] (03Merged) 10jenkins-bot: Use MediaWikiServices::getRepoGroup [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/579726 (owner: 10Umherirrender) [17:47:20] (03Merged) 10jenkins-bot: Use MediaWikiServices::getRepoGroup [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/579725 (owner: 10Umherirrender) [17:47:22] (03Merged) 10jenkins-bot: Use MediaWikiServices::getRepoGroup [extensions/LinkSuggest] - 10https://gerrit.wikimedia.org/r/579722 (owner: 10Umherirrender) [17:49:38] 10MediaWiki-Debug-Logger, 10MediaWiki-Vendor, 10Wikimedia-Logstash, 10MW-1.35-release, 10Patch-For-Review: Update monolog/monolog to 2.0.2 - https://phabricator.wikimedia.org/T242751 (10Reedy) The other option is to bring in code from the old version of the parent class in monolog, and carry on things as... [17:51:01] (03Merged) 10jenkins-bot: Use MediaWikiServices::getRepoGroup [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/578076 (owner: 10Umherirrender) [17:53:17] (03Merged) 10jenkins-bot: Use MediaWikiServices::getRepoGroup [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/579044 (owner: 10Umherirrender) [17:53:19] (03Merged) 10jenkins-bot: Use MediaWikiServices::getRepoGroup [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/579046 (owner: 10Umherirrender) [17:53:45] (03Merged) 10jenkins-bot: Use MediaWikiServices::getRepoGroup [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/578085 (owner: 10Umherirrender) [17:53:59] (03PS3) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [vendor] - 10https://gerrit.wikimedia.org/r/579666 (https://phabricator.wikimedia.org/T242751) [17:54:04] 10MediaWiki-Recent-changes, 10MediaWiki-extensions-WikibaseClient, 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10Wikidata: Bot edits on Wikidata should be hidden in other project's recent changes - https://phabricator.wikimedia.org/T246746 (10Strainu) @Magnus ^^ Sorry for nagging you folks, but p... [17:55:18] 10MobileFrontend, 10MinervaNeue: Pressing the "Show on map" button in advanced mode reloads the page - https://phabricator.wikimedia.org/T247664 (10BrandonXLF) Realized this is caused by the https://en.wikipedia.org/wiki/MediaWiki:Gadget-mobilemaps.js gadget on the English Wikipedia. [17:55:24] 04(no projects): Pressing the "Show on map" button in advanced mode reloads the page - https://phabricator.wikimedia.org/T247664 (10BrandonXLF) [17:58:54] (03CR) 10Umherirrender: "Waiting for I3653452377ce5cde753a637de5e1eeea624b8f6c" [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/579720 (owner: 10Umherirrender) [17:59:17] (03CR) 10Umherirrender: "Waiting for I3653452377ce5cde753a637de5e1eeea624b8f6c" [extensions/Score] - 10https://gerrit.wikimedia.org/r/579727 (owner: 10Umherirrender) [18:07:00] (03PS20) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) [18:07:02] (03PS1) 10Reedy: Import LogstashFormatter::formatV1 from monolog/monolog 1.25.3 [core] - 10https://gerrit.wikimedia.org/r/579761 (https://phabricator.wikimedia.org/T242751) [18:08:37] (03PS2) 10Reedy: Import LogstashFormatter::formatV1 from monolog/monolog 1.25.3 [core] - 10https://gerrit.wikimedia.org/r/579761 (https://phabricator.wikimedia.org/T242751) [18:09:14] (03CR) 10Umherirrender: tests: Avoid calling Title::__construct (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/579574 (owner: 10Daimona Eaytoy) [18:09:58] (03CR) 10Reedy: Import LogstashFormatter::formatV1 from monolog/monolog 1.25.3 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/579761 (https://phabricator.wikimedia.org/T242751) (owner: 10Reedy) [18:10:50] (03CR) 10Umherirrender: "there is 2.6.1 now" [tools/phan] - 10https://gerrit.wikimedia.org/r/578058 (owner: 10Daimona Eaytoy) [18:11:08] (03PS3) 10Reedy: Import LogstashFormatter::formatV1 from monolog/monolog 1.25.3 [core] - 10https://gerrit.wikimedia.org/r/579761 (https://phabricator.wikimedia.org/T242751) [18:11:21] (03Merged) 10jenkins-bot: Javascript coding conventions: Clean up whitespace [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579676 (owner: 10DannyS712) [18:11:25] (03Merged) 10jenkins-bot: Use MediaWikiServices::getRepoGroup in file related classes [core] - 10https://gerrit.wikimedia.org/r/578134 (owner: 10Umherirrender) [18:11:31] (03Merged) 10jenkins-bot: Move contents of mediawiki.legacy.commonPrint into ResourceLoaderSkinModule [core] - 10https://gerrit.wikimedia.org/r/579420 (https://phabricator.wikimedia.org/T242177) (owner: 10Jdlrobson) [18:11:38] (03Merged) 10jenkins-bot: Use MediaWikiServices::getRepoGroup in special page related classes [core] - 10https://gerrit.wikimedia.org/r/578133 (owner: 10Umherirrender) [18:11:40] (03Merged) 10jenkins-bot: Use MediaWikiServices::getRepoGroup [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/579723 (owner: 10Umherirrender) [18:11:43] (03Merged) 10jenkins-bot: Use MediaWikiServices::getMessageCache [extensions/Echo] - 10https://gerrit.wikimedia.org/r/579709 (owner: 10Umherirrender) [18:11:46] (03Merged) 10jenkins-bot: Use MediaWikiServices::getMessageCache [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/579713 (owner: 10Umherirrender) [18:11:48] (03Merged) 10jenkins-bot: Use MediaWikiServices::getMessageCache [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/579710 (owner: 10Umherirrender) [18:16:02] (03CR) 10Daimona Eaytoy: tests: Avoid calling Title::__construct (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/579574 (owner: 10Daimona Eaytoy) [18:16:28] (03PS3) 10Daimona Eaytoy: tests: Avoid calling Title::__construct [extensions/Echo] - 10https://gerrit.wikimedia.org/r/579574 [18:16:46] (03PS4) 10Reedy: Import LogstashFormatter::formatV1 from monolog/monolog 1.25.3 [core] - 10https://gerrit.wikimedia.org/r/579761 (https://phabricator.wikimedia.org/T242751) [18:17:04] (03PS3) 10Daimona Eaytoy: Upgrade phan to 2.6.1 [tools/phan] - 10https://gerrit.wikimedia.org/r/578058 [18:17:19] (03Abandoned) 10DannyS712: Handle ChessSquare::newFromCoords returning false [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/578713 (owner: 10DannyS712) [18:17:21] (03CR) 10Daimona Eaytoy: "> there is 2.6.1 now" [tools/phan] - 10https://gerrit.wikimedia.org/r/578058 (owner: 10Daimona Eaytoy) [18:17:44] (03PS5) 10Reedy: Import LogstashFormatter::formatV1 from monolog/monolog 1.25.3 [core] - 10https://gerrit.wikimedia.org/r/579761 (https://phabricator.wikimedia.org/T242751) [18:18:09] (03CR) 10MaxSem: "Only one third-party usage left, in SharedHelpPages: https://codesearch.wmflabs.org/search/?q=(UseSquid%7CSquidServers%7CSquidServersNoPur" [core] - 10https://gerrit.wikimedia.org/r/579755 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [18:19:06] (03PS5) 10Ammarpad: OAuth: Replace User::isAllowed calls with PermissionManager. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/575768 (https://phabricator.wikimedia.org/T246567) [18:19:31] (03CR) 10jerkins-bot: [V: 04-1] Upgrade phan to 2.6.1 [tools/phan] - 10https://gerrit.wikimedia.org/r/578058 (owner: 10Daimona Eaytoy) [18:20:26] (03CR) 10jerkins-bot: [V: 04-1] Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) (owner: 10Reedy) [18:21:48] (03CR) 10jerkins-bot: [V: 04-1] Import LogstashFormatter::formatV1 from monolog/monolog 1.25.3 [core] - 10https://gerrit.wikimedia.org/r/579761 (https://phabricator.wikimedia.org/T242751) (owner: 10Reedy) [18:24:41] (03Merged) 10jenkins-bot: Use MediaWikiServices::getMessageCache [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/579711 (owner: 10Umherirrender) [18:24:54] (03CR) 10Daimona Eaytoy: "recheck" [tools/phan] - 10https://gerrit.wikimedia.org/r/578058 (owner: 10Daimona Eaytoy) [18:25:26] (03PS1) 10Krinkle: languages: Move default $wgNamespaceAliases to MessagesEn.php [core] - 10https://gerrit.wikimedia.org/r/579762 (https://phabricator.wikimedia.org/T233676) [18:25:59] (03CR) 10Krinkle: "Yep, I saw that, but that doesn't seem blocking to me. It's had a release cycle of deprecation with warnings and release notes." [core] - 10https://gerrit.wikimedia.org/r/579755 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [18:27:16] (03Merged) 10jenkins-bot: Use MediaWikiServices::getMessageCache [core] - 10https://gerrit.wikimedia.org/r/579707 (owner: 10Umherirrender) [18:27:18] (03Merged) 10jenkins-bot: Convert $wgMemc use to WANObjectCache [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/570714 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [18:27:20] (03Merged) 10jenkins-bot: build: Replace jshint/jsonlint with eslint [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/579739 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [18:27:22] (03Merged) 10jenkins-bot: Move CodeCommentsTablePager class into the own file [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/579750 (owner: 10Zoranzoki21) [18:28:52] (03CR) 10Krinkle: "Test Plan I used:" [core] - 10https://gerrit.wikimedia.org/r/579762 (https://phabricator.wikimedia.org/T233676) (owner: 10Krinkle) [18:28:53] (03PS2) 10Krinkle: languages: Move default $wgNamespaceAliases to MessagesEn.php [core] - 10https://gerrit.wikimedia.org/r/579762 (https://phabricator.wikimedia.org/T233676) [18:28:55] (03PS1) 10Umherirrender: Use MediaWikiServices::getRepoGroup [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/579763 [18:29:48] (03PS12) 10Daimona Eaytoy: [WIP] Upgrade phan to latest version [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/555662 [18:31:11] (03CR) 10jerkins-bot: [V: 04-1] Import LogstashFormatter::formatV1 from monolog/monolog 1.25.3 [core] - 10https://gerrit.wikimedia.org/r/579761 (https://phabricator.wikimedia.org/T242751) (owner: 10Reedy) [18:31:32] (03CR) 10jerkins-bot: [V: 04-1] Use MediaWikiServices::getRepoGroup [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/579763 (owner: 10Umherirrender) [18:32:12] 10Turkish-Sites: New rights to interface admin - https://phabricator.wikimedia.org/T247672 (10TmY_e12) [18:33:52] Urbanecm: ^ [18:34:03] I think we don't allow changing interface-admin privs? [18:34:17] or I am imaging things? [18:34:26] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Wikidata-Campsite, 10Developer Productivity: PHPUnit warning noise from ClientParserOutputDataUpdaterTest (Wikibase) - https://phabricator.wikimedia.org/T247670 (10Daimona) It doesn't seem a recent regression, see https://gerrit.wikimedia.org/r/plugins/g... [18:34:28] *am I [18:34:58] hauskatze: that's right - only users who really do need to change CSS/JS should be a member of that group, so no new permissions should be granted to that group. [18:35:13] (03PS1) 10Umherirrender: Use MediaWikiServices::getRepoGroup [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/579765 [18:35:28] Agreed [18:35:39] Decline? [18:35:53] yup [18:36:00] Not in Phab ATM, waiting for our PM to declare the lockdown [18:36:37] I can do it if you want [18:37:27] If you want to, feel free; but don't feel obliged [18:38:05] okay :-) [18:38:08] hauskatze: did you see https://meta.wikimedia.org/wiki/Limits_to_configuration_changes/Update_2019 btw? [18:38:14] (03PS1) 10Umherirrender: Use MediaWikiServices::getRepoGroup [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/579767 [18:38:22] Maybe I missed it Urbanecm [18:38:25] Let me check [18:39:42] thanks [18:41:09] (03PS4) 10Umherirrender: tests: Avoid calling Title::__construct [extensions/Echo] - 10https://gerrit.wikimedia.org/r/579574 (owner: 10Daimona Eaytoy) [18:41:12] (03CR) 10Umherirrender: [C: 03+2] tests: Avoid calling Title::__construct [extensions/Echo] - 10https://gerrit.wikimedia.org/r/579574 (owner: 10Daimona Eaytoy) [18:42:24] (03CR) 10jerkins-bot: [V: 04-1] languages: Move default $wgNamespaceAliases to MessagesEn.php [core] - 10https://gerrit.wikimedia.org/r/579762 (https://phabricator.wikimedia.org/T233676) (owner: 10Krinkle) [18:44:09] hauskatze: done [18:44:35] 10Wikimedia-Site-requests, 10Turkish-Sites: New rights to interface admin - https://phabricator.wikimedia.org/T247672 (10Urbanecm) 05Open→03Declined Hi, I would like to inform you that it isn't allowed to grant new permissions to interface-admin group. That is because the purpose of interface-admins is to... [18:45:15] Urbanecm: thanks [18:45:19] yw [18:49:00] 10Wikimedia-Site-requests, 10Turkish-Sites: New rights to interface admin - https://phabricator.wikimedia.org/T247672 (10TmY_e12) [18:51:39] (03PS1) 10Krinkle: Setup: Remove compat for $wgDisableCounters [core] - 10https://gerrit.wikimedia.org/r/579769 (https://phabricator.wikimedia.org/T233676) [18:52:20] (03PS3) 10Krinkle: languages: Move default $wgNamespaceAliases to MessagesEn.php [core] - 10https://gerrit.wikimedia.org/r/579762 (https://phabricator.wikimedia.org/T233676) [18:52:22] (03PS2) 10Krinkle: Setup: Remove compat for $wgDisableCounters [core] - 10https://gerrit.wikimedia.org/r/579769 (https://phabricator.wikimedia.org/T233676) [18:53:32] 10Wikimedia-Site-requests, 10Turkish-Sites: New rights to interface admin - https://phabricator.wikimedia.org/T247672 (10TmY_e12) 05Declined→03Open Okay, so can you just give edit protected and edit semi protected rights to the technician (interface editor) group? [18:53:34] (03PS4) 10Krinkle: languages: Move default $wgNamespaceAliases to MessagesEn.php [core] - 10https://gerrit.wikimedia.org/r/579762 (https://phabricator.wikimedia.org/T233676) [18:53:36] (03PS3) 10Krinkle: Setup: Remove compat for $wgDisableCounters [core] - 10https://gerrit.wikimedia.org/r/579769 (https://phabricator.wikimedia.org/T233676) [18:53:45] (03Merged) 10jenkins-bot: tests: Avoid calling Title::__construct [extensions/Echo] - 10https://gerrit.wikimedia.org/r/579574 (owner: 10Daimona Eaytoy) [18:54:06] (03PS1) 10Umherirrender: Use MediaWikiServices::getRepoGroup [skins/Timeless] - 10https://gerrit.wikimedia.org/r/579770 [18:56:06] (03PS2) 10Umherirrender: Use MediaWikiServices::getRepoGroup [skins/Timeless] - 10https://gerrit.wikimedia.org/r/579770 [18:56:14] (03PS1) 10Umherirrender: Use MediaWikiServices::getRepoGroup [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/579771 [18:57:04] (03PS6) 10Reedy: Import LogstashFormatter::formatV1 from monolog/monolog 1.25.3 [core] - 10https://gerrit.wikimedia.org/r/579761 (https://phabricator.wikimedia.org/T242751) [18:57:06] (03PS3) 10Umherirrender: Replace deprecated User::isAllowed with PermissionManager [extensions/Echo] - 10https://gerrit.wikimedia.org/r/577537 (https://phabricator.wikimedia.org/T220191) (owner: 10Ammarpad) [18:58:54] (03CR) 10Reedy: Import LogstashFormatter::formatV1 from monolog/monolog 1.25.3 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/579761 (https://phabricator.wikimedia.org/T242751) (owner: 10Reedy) [18:59:56] 10Wikimedia-Site-requests, 10Turkish-Sites: New rights to interface admin - https://phabricator.wikimedia.org/T247672 (10YenilenebilirAdam) So Dear Urbanecm, our request from you is merge Technician and Interface-Editor group and permissions. Can you do that? [19:01:08] 10Wikimedia-Site-requests, 10Turkish-Sites: New rights to interface admin - https://phabricator.wikimedia.org/T247672 (10Urbanecm) >>! In T247672#5969724, @YenilenebilirAdam wrote: > So Dear Urbanecm, our request from you is to merge Technician and Interface-Editor group and permissions. Can you do that? No.... [19:03:04] (03CR) 10jerkins-bot: [V: 04-1] Setup: Remove compat for $wgDisableCounters [core] - 10https://gerrit.wikimedia.org/r/579769 (https://phabricator.wikimedia.org/T233676) (owner: 10Krinkle) [19:04:05] 10MediaWiki-Debug-Logger, 10MediaWiki-Vendor, 10Wikimedia-Logstash, 10MW-1.35-release, 10Patch-For-Review: Update monolog/monolog to 2.0.2 - https://phabricator.wikimedia.org/T242751 (10Reedy) Old output of LogstashFormatterTest::testV1WithPrefix ` array(2) { 'extra' => array(1) { 'url' => i... [19:07:25] 10MediaWiki-extensions-GraphQL, 10GraphQL: Gateway throws error when slot and slots are both defined on service - https://phabricator.wikimedia.org/T247673 (10dbarratt) [19:07:41] 10MediaWiki-extensions-GraphQL, 10GraphQL: Gateway throws error when slot and slots are both defined on MediaWikiRevision - https://phabricator.wikimedia.org/T247673 (10dbarratt) [19:07:58] (03PS7) 10Reedy: Import LogstashFormatter::formatV1 from monolog/monolog 1.25.3 [core] - 10https://gerrit.wikimedia.org/r/579761 (https://phabricator.wikimedia.org/T242751) [19:08:40] (03PS21) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) [19:08:42] (03Abandoned) 10Reedy: Import LogstashFormatter::formatV1 from monolog/monolog 1.25.3 [core] - 10https://gerrit.wikimedia.org/r/579761 (https://phabricator.wikimedia.org/T242751) (owner: 10Reedy) [19:11:52] 10MediaWiki-Debug-Logger, 10MediaWiki-Vendor, 10Wikimedia-Logstash, 10MW-1.35-release, 10Patch-For-Review: Update monolog/monolog to 2.0.2 - https://phabricator.wikimedia.org/T242751 (10Reedy) Ok, so tests now passing (with minimal changes to them), importing the old format output... [19:12:02] (03PS22) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) [19:12:14] (03CR) 10jerkins-bot: [V: 04-1] Replace deprecated User::isAllowed with PermissionManager [extensions/Echo] - 10https://gerrit.wikimedia.org/r/577537 (https://phabricator.wikimedia.org/T220191) (owner: 10Ammarpad) [19:12:48] 10MediaWiki-Templates: Parameter names in templates should be case-insensitive - https://phabricator.wikimedia.org/T6964 (10Pppery) Removing good first task project since this is evidently not "non-controversial", as required by bullet point 2 in the description. [19:14:41] (03PS4) 10Umherirrender: Replace deprecated User::isAllowed with PermissionManager [extensions/Echo] - 10https://gerrit.wikimedia.org/r/577537 (https://phabricator.wikimedia.org/T220191) (owner: 10Ammarpad) [19:14:54] (03PS23) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) [19:16:30] (03PS24) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) [19:17:52] (03CR) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) (owner: 10Reedy) [19:19:35] 10MediaWiki-General, 10Composer: Composer Library Updates, late 2019/early 2020 edition - https://phabricator.wikimedia.org/T235266 (10Reedy) [19:20:24] (03CR) 10Umherirrender: "includes/resourceloader/ResourceLoaderOOUIIconPackModule.php:41 PhanTypeArraySuspiciousNullable Suspicious array access to nullable array|" [tools/phan] - 10https://gerrit.wikimedia.org/r/578058 (owner: 10Daimona Eaytoy) [19:23:12] 10MediaWiki-ServiceContainer, 10TechCom: Should MediaWikiServices be used in unit tests? - https://phabricator.wikimedia.org/T246907 (10dbarratt) Thanks @Krinkle ! My thinking with mocking was if you had a long dependency chain like: Class A → Dependency B → Dependency C → Dependency D → Dependency E and you... [19:24:53] (03CR) 10Umherirrender: "This can result in a database query for each entry of the special page. That could be 5000 extra queries, which increase the load time and" [core] - 10https://gerrit.wikimedia.org/r/575764 (https://phabricator.wikimedia.org/T244655) (owner: 10Ammarpad) [19:27:45] (03PS5) 10Krinkle: languages: Move default $wgNamespaceAliases to MessagesEn.php [core] - 10https://gerrit.wikimedia.org/r/579762 (https://phabricator.wikimedia.org/T189966) [19:27:55] (03PS4) 10Krinkle: Setup: Remove compat for $wgDisableCounters [core] - 10https://gerrit.wikimedia.org/r/579769 (https://phabricator.wikimedia.org/T233676) [19:28:06] (03PS5) 10Krinkle: Setup: Remove compat for $wgDisableCounters [core] - 10https://gerrit.wikimedia.org/r/579769 (https://phabricator.wikimedia.org/T189966) [19:29:44] 10MediaWiki-Internationalization: Remove $wgContLanguageCode - https://phabricator.wikimedia.org/T247674 (10Krinkle) [19:29:52] (03CR) 10jerkins-bot: [V: 04-1] Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) (owner: 10Reedy) [19:30:22] (03PS25) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) [19:31:23] (03PS1) 10Umherirrender: Use local var to avoid null for LanguageConverter::mTables [core] - 10https://gerrit.wikimedia.org/r/579773 [19:31:25] (03PS1) 10Krinkle: Replace $wgContLanguageCode with $wgLanguageCode [extensions/Math] - 10https://gerrit.wikimedia.org/r/579774 (https://phabricator.wikimedia.org/T247674) [19:32:28] (03PS1) 10Krinkle: Replace $wgContLanguageCode with $wgLanguageCode [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/579775 (https://phabricator.wikimedia.org/T247674) [19:32:43] pankajvaghela/wikimedia-core#1 (master - 216d109 jenkins-bot): The build passed. - https://travis-ci.com/pankajvaghela/wikimedia-core/builds/153348843 [19:33:02] (03CR) 10Umherirrender: [C: 03+1] Replace deprecated User::isAllowed with PermissionManager [extensions/Echo] - 10https://gerrit.wikimedia.org/r/577537 (https://phabricator.wikimedia.org/T220191) (owner: 10Ammarpad) [19:33:57] (03PS1) 10Krinkle: Replace $wgContLanguageCode with $wgLanguageCode [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/579776 (https://phabricator.wikimedia.org/T247674) [19:41:57] (03CR) 10Umherirrender: "This may be a false positive" [tools/phan] - 10https://gerrit.wikimedia.org/r/578058 (owner: 10Daimona Eaytoy) [19:42:32] (03PS1) 10Krinkle: Replace $wgContLanguageCode with $wgLanguageCode [extensions/DoubleWiki] - 10https://gerrit.wikimedia.org/r/579777 (https://phabricator.wikimedia.org/T247674) [19:44:09] (03PS1) 10Krinkle: Remove outdated use of $wgContLanguageCode [extensions/SiteSettings] - 10https://gerrit.wikimedia.org/r/579778 (https://phabricator.wikimedia.org/T247674) [19:47:16] (03CR) 10jerkins-bot: [V: 04-1] Use local var to avoid null for LanguageConverter::mTables [core] - 10https://gerrit.wikimedia.org/r/579773 (owner: 10Umherirrender) [19:47:37] (03PS26) 10Reedy: Updating monolog/monolog (1.25.3 => 2.0.2) [core] - 10https://gerrit.wikimedia.org/r/579668 (https://phabricator.wikimedia.org/T242751) [19:48:12] 10MediaWiki-General, 10WorkType-NewFunctionality: Allow page-specific inclusion of