[00:02:31] (03PS1) 10SLF bot: Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/577828 [00:04:11] 10Google-Summer-of-Code (2020): Add leaderboard based on user's edits using Commons Android app - https://phabricator.wikimedia.org/T244197 (10maskaravivek) Welcome everyone and thanks for showing interest in this app. @Agarain99 We are planning to host a new DB on toolsforge and the schema isn't decided yet.... [00:12:29] 10Google-Summer-of-Code (2020): Add leaderboard based on user's edits using Commons Android app - https://phabricator.wikimedia.org/T244197 (10maskaravivek) [00:12:48] 10Outreachy (Round 20): Add leaderboard based on user's edits using Commons Android app - https://phabricator.wikimedia.org/T217439 (10maskaravivek) [00:20:44] 10MediaWiki-Interface, 10Language-Team, 10Patch-For-Review: native language name for Northern Tatar (code 'sty', written in Cyrillic) uses an incorrect initial Latin small letter C instead of the Cyrillic small letter ES - https://phabricator.wikimedia.org/T247170 (10Verdy_p) There's no reason why only the f... [00:24:52] 10MediaWiki-Interface, 10Language-Team, 10Patch-For-Review: native language name for Northern Tatar (code 'sty', written in Cyrillic) uses an incorrect initial Latin small letter C instead of the Cyrillic small letter ES - https://phabricator.wikimedia.org/T247170 (10Verdy_p) Also If I google it now, I actua... [00:34:45] (03PS1) 10Cicalese: Fixed typo [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/577834 [00:35:25] (03CR) 10Cicalese: [C: 03+2] Fixed typo [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/577834 (owner: 10Cicalese) [00:36:17] (03CR) 10jerkins-bot: [V: 04-1] Fixed typo [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/577834 (owner: 10Cicalese) [00:38:15] (03CR) 10Cicalese: [V: 03+2 C: 03+2] Fixed typo [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/577834 (owner: 10Cicalese) [00:40:32] (03CR) 10jerkins-bot: [V: 04-1] Fixed typo [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/577834 (owner: 10Cicalese) [00:52:11] 10MediaWiki-Interface, 10Language-Team, 10Patch-For-Review: native language name for Northern Tatar (code 'sty', written in Cyrillic) uses an incorrect initial Latin small letter C instead of the Cyrillic small letter ES - https://phabricator.wikimedia.org/T247170 (10Verdy_p) And now after a few minutes that... [00:58:08] 10MediaWiki-Internationalization, 10User-MarcoAurelio: Add Siberian Tatar (sty) to Names.php - https://phabricator.wikimedia.org/T186359 (10Verdy_p) Note that "Northern Tatar" is an alternate (and probably prefered) name in English for "Siberian Tatar" (which is too restrictive for that language). The native n... [01:00:27] 10MediaWiki-extensions-Linter, 10Parsoid: Linter does not detect link-in-link when wikilink is wrapped in italics - https://phabricator.wikimedia.org/T242068 (10ssastry) p:05Triage→03Medium [01:08:20] 10MediaWiki-Interface, 10Language-Team, 10Patch-For-Review: native language name for Northern Tatar (code 'sty', written in Cyrillic) uses an incorrect initial Latin small letter C instead of the Cyrillic small letter ES - https://phabricator.wikimedia.org/T247170 (10Ebe123) @Verdy_p, the fix is not yet acce... [01:32:18] 10MediaWiki-General, 10User-DannyS712: Audit all userCan calls - https://phabricator.wikimedia.org/T246414 (10DannyS712) 05Open→03Resolved All checked, now just need to replace uses [01:32:25] 10MediaWiki-General, 10Technical-Debt (Deprecation process), 10User-DannyS712: Follow up: Hard deprecate not passing a user to ::userCan methods - https://phabricator.wikimedia.org/T246189 (10DannyS712) [01:32:27] 10MediaWiki-General, 10Technical-Debt, 10User-DannyS712: Remove remaining Title::userCan calls - https://phabricator.wikimedia.org/T246139 (10DannyS712) [01:34:44] (03PS13) 10Aaron Schulz: rdbms: allow merging IDatabase::upsert() rows with current ones [core] - 10https://gerrit.wikimedia.org/r/574101 [01:36:07] (03PS19) 10Aron Manning: [TEST] Font update: use Roboto (sans) and Noto Serif (heading) webfonts with monospace Fira Code for consistent look on all platforms. [skins/Vector] - 10https://gerrit.wikimedia.org/r/570639 (https://phabricator.wikimedia.org/T243508) [01:41:47] (03PS1) 10Aaron Schulz: rdbms: remove Database::bufferResults() and Database::tableNamesWithAlias() [core] - 10https://gerrit.wikimedia.org/r/577837 [01:44:27] 10MediaWiki-General, 10Technical-Debt, 10User-DannyS712: Remove remaining Title::userCan calls - https://phabricator.wikimedia.org/T246139 (10DannyS712) [01:44:56] (03PS6) 10Aaron Schulz: rdbms: reduce duplication in Database via helper methods [core] - 10https://gerrit.wikimedia.org/r/576492 [01:45:06] (03PS14) 10Aaron Schulz: rdbms: allow merging IDatabase::upsert() rows with current ones [core] - 10https://gerrit.wikimedia.org/r/574101 [01:46:27] (03PS1) 10DannyS712: Remove uses of Title::userCan [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/577838 (https://phabricator.wikimedia.org/T246139) [01:50:18] (03PS2) 10DannyS712: Remove uses of Title::userCan [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/577838 (https://phabricator.wikimedia.org/T246139) [01:50:43] (03PS1) 10DannyS712: Remove uses of Title::userCan [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/577839 (https://phabricator.wikimedia.org/T246139) [01:50:49] (03CR) 10jerkins-bot: [V: 04-1] [TEST] Font update: use Roboto (sans) and Noto Serif (heading) webfonts with monospace Fira Code for consistent look on all platforms. [skins/Vector] - 10https://gerrit.wikimedia.org/r/570639 (https://phabricator.wikimedia.org/T243508) (owner: 10Aron Manning) [01:51:17] (03CR) 10jerkins-bot: [V: 04-1] Remove uses of Title::userCan [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/577838 (https://phabricator.wikimedia.org/T246139) (owner: 10DannyS712) [01:51:37] (03CR) 10jerkins-bot: [V: 04-1] Remove uses of Title::userCan [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/577839 (https://phabricator.wikimedia.org/T246139) (owner: 10DannyS712) [01:59:57] (03PS2) 10DannyS712: Remove uses of Title::userCan [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/577839 (https://phabricator.wikimedia.org/T246139) [01:59:59] (03CR) 10Aron Manning: "Thank you for the feedback." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/577780 (https://phabricator.wikimedia.org/T244790) (owner: 10Aron Manning) [02:00:48] (03CR) 10jerkins-bot: [V: 04-1] Remove uses of Title::userCan [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/577839 (https://phabricator.wikimedia.org/T246139) (owner: 10DannyS712) [02:00:50] (03PS11) 10Aron Manning: Add documentation for the font stacks [wikimedia-ui-base] - 10https://gerrit.wikimedia.org/r/571944 (https://phabricator.wikimedia.org/T244790) [02:00:52] (03PS8) 10Aron Manning: Add comments to the WMUI font stacks [wikimedia-ui-base] - 10https://gerrit.wikimedia.org/r/573609 (https://phabricator.wikimedia.org/T244794) [02:00:54] (03PS2) 10Aron Manning: Rename 'font-family-heading-main' to 'font-family-heading' [wikimedia-ui-base] - 10https://gerrit.wikimedia.org/r/577786 (https://phabricator.wikimedia.org/T245136) [02:00:56] (03PS3) 10Aron Manning: Rename 2 font-family-* variables to font-family-system-* [wikimedia-ui-base] - 10https://gerrit.wikimedia.org/r/577787 (https://phabricator.wikimedia.org/T245136) [02:00:58] (03PS11) 10Aron Manning: Update WMUI Base metadata, History.md for v0.15.0 [wikimedia-ui-base] - 10https://gerrit.wikimedia.org/r/573433 (https://phabricator.wikimedia.org/T244794) [02:01:06] (03PS3) 10DannyS712: Remove uses of Title::userCan [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/577838 (https://phabricator.wikimedia.org/T246139) [02:01:50] (03CR) 10DannyS712: "Recheck" [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/577839 (https://phabricator.wikimedia.org/T246139) (owner: 10DannyS712) [02:04:20] (03PS3) 10DannyS712: Remove uses of Title::userCan [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/577839 (https://phabricator.wikimedia.org/T246139) [02:06:19] (03CR) 10jerkins-bot: [V: 04-1] Remove uses of Title::userCan [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/577838 (https://phabricator.wikimedia.org/T246139) (owner: 10DannyS712) [02:06:42] (03CR) 10DannyS712: "Unrelated parser tests are failing" [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/577838 (https://phabricator.wikimedia.org/T246139) (owner: 10DannyS712) [02:09:52] (03CR) 10jerkins-bot: [V: 04-1] Remove uses of Title::userCan [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/577839 (https://phabricator.wikimedia.org/T246139) (owner: 10DannyS712) [02:16:56] (03CR) 10DannyS712: "Failures are unrelated parser tests" [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/577839 (https://phabricator.wikimedia.org/T246139) (owner: 10DannyS712) [02:39:58] (03PS27) 10VolkerE: build: Add 'svgo', SVG minifier script and unify SVGO rules [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (https://phabricator.wikimedia.org/T247004) (owner: 10Aron Manning) [02:40:03] (03CR) 10VolkerE: [C: 03+2] build: Add 'svgo', SVG minifier script and unify SVGO rules [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (https://phabricator.wikimedia.org/T247004) (owner: 10Aron Manning) [02:58:52] (03PS20) 10Aron Manning: [POC] Font update: use Lato (sans), Lora (serif) fonts for consistent look on all platforms [skins/Vector] - 10https://gerrit.wikimedia.org/r/570639 (https://phabricator.wikimedia.org/T243508) [03:05:55] 10Readers-Web-Backlog (Tracking): Provide a way to access slack for a contributor - https://phabricator.wikimedia.org/T246214 (10MZMcBride) Mozilla recently shut down its IRC server and switched to Matrix: . [03:07:29] (03PS2) 10Aron Manning: Update 'wikimedia-ui-base.less' [core] - 10https://gerrit.wikimedia.org/r/577779 (https://phabricator.wikimedia.org/T244794) [03:07:31] (03PS3) 10Aron Manning: Add documentation for the font stacks [core] - 10https://gerrit.wikimedia.org/r/577780 (https://phabricator.wikimedia.org/T244790) [03:07:33] (03PS3) 10Aron Manning: Add comments to the WMUI font stacks [core] - 10https://gerrit.wikimedia.org/r/577781 (https://phabricator.wikimedia.org/T244794) [03:07:35] (03PS2) 10Aron Manning: Rename 'font-family-heading-main' to 'font-family-heading' [core] - 10https://gerrit.wikimedia.org/r/577790 (https://phabricator.wikimedia.org/T245136) [03:07:37] (03PS2) 10Aron Manning: Rename 2 font-family-* variables to font-family-system-* [core] - 10https://gerrit.wikimedia.org/r/577791 (https://phabricator.wikimedia.org/T245136) [03:14:37] (03PS14) 10DannyS712: Add a new class to represent a specific square [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/577382 [03:14:41] (03CR) 10DannyS712: Add a new class to represent a specific square (036 comments) [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/577382 (owner: 10DannyS712) [03:22:56] (03PS1) 10DannyS712: Remove reference to LudoDBRegistry [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/577841 [03:24:27] (03PS2) 10DannyS712: Remove reference to LudoDBRegistry [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/577841 [03:25:09] (03PS4) 10DannyS712: Testing: Tests for FenParser0x88 [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/576491 (https://phabricator.wikimedia.org/T246736) (owner: 10Wugapodes) [03:26:51] (03CR) 10jerkins-bot: [V: 04-1] Testing: Tests for FenParser0x88 [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/576491 (https://phabricator.wikimedia.org/T246736) (owner: 10Wugapodes) [03:39:15] (03CR) 10DannyS712: [C: 03+1] "LGTM" [extensions/IframePage] - 10https://gerrit.wikimedia.org/r/577796 (owner: 10Zoranzoki21) [03:39:37] (03CR) 10DannyS712: [C: 03+1] "LGTM" [extensions/UploadBlacklist] - 10https://gerrit.wikimedia.org/r/577800 (owner: 10Zoranzoki21) [03:39:57] (03CR) 10DannyS712: [C: 03+1] "LGTM" [extensions/IframePage] - 10https://gerrit.wikimedia.org/r/577795 (owner: 10Zoranzoki21) [03:40:28] (03CR) 10DannyS712: [C: 04-1] Autofix errors found by phpcs (031 comment) [extensions/IframePage] - 10https://gerrit.wikimedia.org/r/577793 (owner: 10Zoranzoki21) [03:41:35] (03PS1) 10VolkerE: build: Add 'sortAttrs' convention rule to 'svgo' & re-run [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/577842 [03:42:43] (03CR) 10DannyS712: [C: 03+1] "LGTM" [extensions/IframePage] - 10https://gerrit.wikimedia.org/r/577777 (https://phabricator.wikimedia.org/T243629) (owner: 10Zoranzoki21) [03:48:08] (03CR) 10DannyS712: [C: 04-1] Deprecate Title and WikiPage getFirstRevision methods (032 comments) [core] - 10https://gerrit.wikimedia.org/r/577729 (https://phabricator.wikimedia.org/T246284) (owner: 10Ppchelko) [03:48:48] (03PS28) 10VolkerE: build: Add 'svgo', SVG minifier script and unify SVGO rules [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (https://phabricator.wikimedia.org/T247004) (owner: 10Aron Manning) [03:48:51] (03CR) 10DannyS712: [C: 03+1] "LGTM" [core] - 10https://gerrit.wikimedia.org/r/576588 (https://phabricator.wikimedia.org/T246284) (owner: 10Ppchelko) [03:52:04] (03PS24) 10Aron Manning: Run SVG minifier in Vector skin [skins/Vector] - 10https://gerrit.wikimedia.org/r/575812 (https://phabricator.wikimedia.org/T178867) [03:57:26] 10UI-Standardization, 10MonoBook, 10Timeless, 10Wikimedia Design Style Guide, and 2 others: Add comments to the font-stacks to summarize the research since 2014's Typography Refresh - https://phabricator.wikimedia.org/T244794 (10Demian) [04:04:22] 10Social-Tools, 10SocialProfile: Undefined property: stdClass::$rev_actor - https://phabricator.wikimedia.org/T247184 (10Vishkujo) [04:05:43] (03CR) 10VolkerE: [C: 03+2] "In order to move this forward, PS 28 was rebased against master. As dependent patches were not directly connected around the same topic." [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (https://phabricator.wikimedia.org/T247004) (owner: 10Aron Manning) [04:09:53] (03PS1) 10VolkerE: build: Add 'sortAttrs' convention rule to 'svgo' & re-run [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/577843 [04:12:53] (03PS25) 10VolkerE: Re-crush SVG files with unified SVGO rules [skins/Vector] - 10https://gerrit.wikimedia.org/r/575812 (https://phabricator.wikimedia.org/T178867) (owner: 10Aron Manning) [04:12:57] (03CR) 10VolkerE: [C: 03+2] Re-crush SVG files with unified SVGO rules [skins/Vector] - 10https://gerrit.wikimedia.org/r/575812 (https://phabricator.wikimedia.org/T178867) (owner: 10Aron Manning) [04:14:46] 10UI-Standardization, 10Front-end-Standards-Group, 10Epic, 10Patch-For-Review: [EPIC] Unify and optimize SVG markup across Foundation products - https://phabricator.wikimedia.org/T178867 (10Volker_E) [04:15:29] (03PS7) 10Aron Manning: Add comments to the WMUI font stacks [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/573065 (https://phabricator.wikimedia.org/T244794) [04:15:31] (03PS1) 10Aron Manning: Rename @fontFamily* variables to WMUI Base convention [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/577844 (https://phabricator.wikimedia.org/T245136) [04:15:33] (03PS1) 10Aron Manning: Add semantic @font-family-* variables [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/577845 (https://phabricator.wikimedia.org/T245136) [04:16:54] (03CR) 10Akinwale-microsoft: "> Patch Set 5:" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/570730 (https://phabricator.wikimedia.org/T244543) (owner: 10Akinwale-microsoft) [04:17:44] (03CR) 10VolkerE: [C: 03+2] Remove .floatright, .floatleft, .tright, .tleft { position: relative } [core] - 10https://gerrit.wikimedia.org/r/562836 (owner: 10Fomafix) [04:19:42] (03PS5) 10Akinwale-microsoft: Fix: Provide an option to supply the aria-label attribute to the inputbox to allow generated markup be accessible to screen readers type=search2 width=120 buttonlabel=Search **arialabel=Search this wiki** [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/572050 (https://phabricator.wikimedia.org/T242354) [04:20:11] (03CR) 10jerkins-bot: [V: 04-1] build: Add 'svgo', SVG minifier script and unify SVGO rules [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (https://phabricator.wikimedia.org/T247004) (owner: 10Aron Manning) [04:20:15] (03CR) 10jerkins-bot: [V: 04-1] Re-crush SVG files with unified SVGO rules [skins/Vector] - 10https://gerrit.wikimedia.org/r/575812 (https://phabricator.wikimedia.org/T178867) (owner: 10Aron Manning) [04:23:54] (03CR) 10VolkerE: [C: 03+2] "recheck" [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (https://phabricator.wikimedia.org/T247004) (owner: 10Aron Manning) [04:25:19] (03CR) 10Akinwale-microsoft: "> Patch Set 5:" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/570730 (https://phabricator.wikimedia.org/T244543) (owner: 10Akinwale-microsoft) [04:29:14] (03CR) 10VolkerE: [C: 03+2] EnhancedChangesList: add screen reader support to live changes [core] - 10https://gerrit.wikimedia.org/r/576089 (owner: 10Abbe98) [04:33:25] (03Merged) 10jenkins-bot: Remove .floatright, .floatleft, .tright, .tleft { position: relative } [core] - 10https://gerrit.wikimedia.org/r/562836 (owner: 10Fomafix) [04:37:33] (03PS5) 10Akinwale-microsoft: Fix: Filter by changes and days button accessibility Screen reader just announces x changes, y days, it doesn't announce the meaning of the button We added an aria-label property to the button to make it accessible to visually impaired audiences [core] - 10https://gerrit.wikimedia.org/r/574865 (https://phabricator.wikimedia.org/T246178) [04:38:55] (03Merged) 10jenkins-bot: build: Add 'svgo', SVG minifier script and unify SVGO rules [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (https://phabricator.wikimedia.org/T247004) (owner: 10Aron Manning) [04:47:42] (03CR) 10Aron Manning: "Thank you for the rebase and merge!" [skins/Vector] - 10https://gerrit.wikimedia.org/r/575811 (https://phabricator.wikimedia.org/T247004) (owner: 10Aron Manning) [04:47:46] (03Merged) 10jenkins-bot: Re-crush SVG files with unified SVGO rules [skins/Vector] - 10https://gerrit.wikimedia.org/r/575812 (https://phabricator.wikimedia.org/T178867) (owner: 10Aron Manning) [04:47:50] (03CR) 10jerkins-bot: [V: 04-1] EnhancedChangesList: add screen reader support to live changes [core] - 10https://gerrit.wikimedia.org/r/576089 (owner: 10Abbe98) [04:50:48] 10Toolforge (Software install/update): Install dotnet-runtime-3.0 on Toolforge hosts - https://phabricator.wikimedia.org/T238180 (10bd808) [04:51:53] (03PS2) 10Aron Manning: Add comments to the font-stacks, reference documentation [skins/Vector] - 10https://gerrit.wikimedia.org/r/577744 (https://phabricator.wikimedia.org/T245136) [04:51:56] (03PS19) 10Aron Manning: Rename font-family variable names to follow WikimediaUI Base [skins/Vector] - 10https://gerrit.wikimedia.org/r/570638 (https://phabricator.wikimedia.org/T246859) [04:52:12] (03PS21) 10Aron Manning: [POC] Font update: use Lato (sans), Lora (serif) fonts for consistent look on all platforms [skins/Vector] - 10https://gerrit.wikimedia.org/r/570639 (https://phabricator.wikimedia.org/T243508) [04:52:39] 10Wikimedia-Site-requests: Turn off direct account creations at Wikimania, at least for periods of time - https://phabricator.wikimedia.org/T247185 (10Billinghurst) [05:05:53] 10UI-Standardization, 10Front-end-Standards-Group, 10Epic, 10MW-1.35-notes (1.35.0-wmf.23; 2020-03-10): [EPIC] Unify and optimize SVG markup across Foundation products - https://phabricator.wikimedia.org/T178867 (10Volker_E) 05Open→03Resolved [05:07:01] 10Desktop Improvements, 10MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), 10Product-Analytics (Kanban), 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): Data QA for Editcount on PrefUpdate schema - https://phabricator.wikimedia.org/T246028 (10phuedx) Thanks for looking into this @Mayakp.wiki. I see {F31670562,si... [05:07:46] (03CR) 10VolkerE: [C: 03+2] "recheck" [core] - 10https://gerrit.wikimedia.org/r/576089 (owner: 10Abbe98) [05:17:18] (03CR) 10Aron Manning: [C: 03+1] "I've split the renames to a patch before and one after." [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/573065 (https://phabricator.wikimedia.org/T244794) (owner: 10Aron Manning) [05:19:18] (03CR) 10VolkerE: [C: 04-1] Fix: Filter by changes and days button accessibility Screen reader just announces x changes, y days, it doesn't announce the meaning of the (031 comment) [core] - 10https://gerrit.wikimedia.org/r/574865 (https://phabricator.wikimedia.org/T246178) (owner: 10Akinwale-microsoft) [05:20:33] (03CR) 10jerkins-bot: [V: 04-1] EnhancedChangesList: add screen reader support to live changes [core] - 10https://gerrit.wikimedia.org/r/576089 (owner: 10Abbe98) [05:22:06] (03CR) 10Aron Manning: [C: 03+1] "@Jdlrobson wrote:" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/573065 (https://phabricator.wikimedia.org/T244794) (owner: 10Aron Manning) [05:22:57] 10Technical-Tool-Request: Microphone upload from browser for reading tutoring with pronunciation assessment - https://phabricator.wikimedia.org/T166929 (10Jsalsman) p:05Lowest→03Medium a:05Brijsri→03Jsalsman [05:23:53] (03CR) 10Aron Manning: "Trivial, ready for merge." [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/577844 (https://phabricator.wikimedia.org/T245136) (owner: 10Aron Manning) [05:25:05] 10PAWS (zero-to-jupyterhub-k8s 0.8.0): Determine TLS termination - https://phabricator.wikimedia.org/T218157 (10bd808) [05:25:09] (03CR) 10Aron Manning: "Simple, no effects outside the 3 files patched." [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/577845 (https://phabricator.wikimedia.org/T245136) (owner: 10Aron Manning) [05:25:43] 10MediaWiki-extensions-Quiz, 10Pywikibot, 10Outreachy (Round-13), 10Pywikibot-Wikidata: Create new Python library to serialize Wikimedia Quiz format, GIFT quiz format, and allow round-trip conversions between the two formats. - https://phabricator.wikimedia.org/T89761 (10Jsalsman) I am working on a version... [05:26:51] 10PAWS (zero-to-jupyterhub-k8s 0.8.0): Sane ingress methods for PAWS - https://phabricator.wikimedia.org/T195217 (10bd808) [05:27:06] (03CR) 10VolkerE: [C: 04-1] "General feedback: As much as I think we should consider high contrast mode, I'd prefer a more structural, architectural approach here than" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/576165 (owner: 10Akinwale-microsoft) [05:29:48] (03PS10) 10Aron Manning: Remove unnecessary devdependency 'stylelint' [skins/Vector] - 10https://gerrit.wikimedia.org/r/576472 (https://phabricator.wikimedia.org/T247004) [05:29:51] (03PS6) 10Aron Manning: Add script 'npm run lint:fix:js' and 'lint:fix:styles', remove 'lint:fix' [skins/Vector] - 10https://gerrit.wikimedia.org/r/577359 (https://phabricator.wikimedia.org/T247004) [05:31:27] 10PAWS (zero-to-jupyterhub-k8s 0.8.0): Develop availability metrics for PAWS - https://phabricator.wikimedia.org/T195030 (10bd808) [05:36:04] (03PS6) 10Aron Manning: Cleanup: add Less variables `@font-size-heading-4`, -5, -6 [skins/Vector] - 10https://gerrit.wikimedia.org/r/576105 (https://phabricator.wikimedia.org/T245838) [05:36:08] (03PS6) 10Aron Manning: [POC] Typography: make h5, h6 in `.mw-body-content` bold [skins/Vector] - 10https://gerrit.wikimedia.org/r/576107 [05:36:12] (03PS6) 10Aron Manning: [POC] Typography: headings h3-h6 in `.mw-body` use the `@font-family-heading` stack like h1-h2 [skins/Vector] - 10https://gerrit.wikimedia.org/r/576108 [05:36:16] (03PS6) 10Aron Manning: [POC] [Typography] Fix sizes and consistent font usage of headings h1-h6. [skins/Vector] - 10https://gerrit.wikimedia.org/r/576109 (https://phabricator.wikimedia.org/T65844) [06:01:42] (03CR) 10jerkins-bot: [V: 04-1] build: Updating acorn to 7.1.1 [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/577851 (owner: 10Libraryupgrader) [06:10:13] 10Outreach-Programs-Projects, 10Outreachy (Round 20): Productionize Wikidata-based Topic Model on ORES - https://phabricator.wikimedia.org/T245848 (10Svensevenslow) Hi! I am Kainaat. I am currently doing B.tech in CSE and I'm interested in applying to Wikimedia for Outreachy. I found this project "Productioniz... [06:40:11] 10MediaWiki-Categories, 10Commons: Wrong subcategory counts in Commons - https://phabricator.wikimedia.org/T247187 (10Ghouston) [06:51:39] (03PS3) 10Aron Manning: Update 'wikimedia-ui-base.less' [core] - 10https://gerrit.wikimedia.org/r/577779 (https://phabricator.wikimedia.org/T244794) [06:51:41] (03PS4) 10Aron Manning: Add documentation for the font stacks [core] - 10https://gerrit.wikimedia.org/r/577780 (https://phabricator.wikimedia.org/T244790) [06:51:43] (03PS4) 10Aron Manning: Add comments to the WMUI font stacks [core] - 10https://gerrit.wikimedia.org/r/577781 (https://phabricator.wikimedia.org/T244794) [06:51:45] (03PS3) 10Aron Manning: Rename 'font-family-heading-main' to 'font-family-heading' [core] - 10https://gerrit.wikimedia.org/r/577790 (https://phabricator.wikimedia.org/T245136) [06:51:47] (03PS3) 10Aron Manning: Rename 2 font-family-* variables to font-family-system-* [core] - 10https://gerrit.wikimedia.org/r/577791 (https://phabricator.wikimedia.org/T245136) [07:24:59] 10MediaWiki-extensions-General, 10IPUtils, 10MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), 10Patch-For-Review: Replace IP class with IPUtils (Wikimedia-deployed) - https://phabricator.wikimedia.org/T242556 (10Ammarpad) 05Open→03Resolved a:03Ammarpad All done for now, save donation interface which is not... [07:26:17] (03Abandoned) 10Ammarpad: Remove autogeneration of Deletion summary. [core] - 10https://gerrit.wikimedia.org/r/552484 (https://phabricator.wikimedia.org/T239012) (owner: 10Ammarpad) [07:30:09] (03PS7) 10DannyS712: [WIP] msg [core] - 10https://gerrit.wikimedia.org/r/577687 [07:31:53] (03PS8) 10DannyS712: Add a MessageFactory service to inject a message localizer [core] - 10https://gerrit.wikimedia.org/r/577687 (https://phabricator.wikimedia.org/T247127) [07:43:56] 10MediaWiki-General, 10Technical-Debt (Deprecation process), 10User-DannyS712: PageArchive::undelete falls back to $wgUser - https://phabricator.wikimedia.org/T247188 (10DannyS712) [07:44:23] 10MediaWiki-General, 10Technical-Debt (Deprecation process), 10User-DannyS712: PageArchive::undelete falls back to $wgUser - https://phabricator.wikimedia.org/T247188 (10DannyS712) [07:44:25] 10MediaWiki-General, 10MW-1.36-release, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove core fallbacks to global $wgUser [1.36] - https://phabricator.wikimedia.org/T245331 (10DannyS712) [07:44:27] 10MediaWiki-General, 10MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), 10Patch-For-Review, 10Technical-Debt, 10User-DannyS712: Deprecate core fallbacks to $wgUser - https://phabricator.wikimedia.org/T242935 (10DannyS712) [07:45:06] 10MediaWiki-General, 10Core Platform Team, 10Technical-Debt (Deprecation process), 10User-DannyS712: PageArchive::undelete falls back to $wgUser - https://phabricator.wikimedia.org/T247188 (10DannyS712) Tagging CPT to review which method of requiring a user would be better (moving the parameter to 1st or a... [07:45:18] 10MediaWiki-General, 10Core Platform Team, 10Technical-Debt (Deprecation process), 10User-DannyS712: PageArchive::undelete falls back to $wgUser - https://phabricator.wikimedia.org/T247188 (10DannyS712) p:05Triage→03Medium [07:58:28] 10MediaWiki-General, 10Technical-Debt, 10User-DannyS712: MessageCache::getParserOptions should be private - https://phabricator.wikimedia.org/T247189 (10DannyS712) [07:58:42] 10MediaWiki-General, 10Technical-Debt, 10User-DannyS712: MessageCache::getParserOptions should be private - https://phabricator.wikimedia.org/T247189 (10DannyS712) p:05Triage→03Medium [07:59:11] 10MediaWiki-General, 10Core Platform Team, 10Technical-Debt, 10User-DannyS712: MessageCache::getParserOptions should be private - https://phabricator.wikimedia.org/T247189 (10DannyS712) Tagging CPT to review the proposal [08:02:33] 10Google-Summer-of-Code (2020): Add leaderboard based on user's edits using Commons Android app - https://phabricator.wikimedia.org/T244197 (10Sudoaccessdenied) Sir , My name is Nishant and I am student of JNU. Here is my linkedIn Profile .https://www.linkedin.com/in/nishant-sharma-46b655165/?originalSubdomain... [08:09:57] 10Outreachy (Round 20): Outreachy Application Task: Simple example of topic classification - https://phabricator.wikimedia.org/T246013 (10Idadelveloper) Hello guys. Please how do I use the use the mwbase Python package in the qid_to_claims function? [08:17:49] 10Outreachy (Round 20): Outreachy Application Task: Simple example of topic classification - https://phabricator.wikimedia.org/T246013 (10Soniya51) >>! In T246013#5951813, @Idadelveloper wrote: > Hello guys. Please how do I use the use the mwbase Python package in the qid_to_claims function? @Idadelveloper I us... [08:18:58] 10Outreachy (Round 20): Outreachy Application Task: Simple example of topic classification - https://phabricator.wikimedia.org/T246013 (10Hammad.aamer) @Idadelveloper You'll have to install and import mwbase first of all. From there you can use https://github.com/mediawiki-utilities/python-mwbase to understand t... [08:29:30] 10MediaWiki-General, 10Core Platform Team, 10Technical-Debt, 10User-DannyS712: MessageCache::getParserOptions should be private - https://phabricator.wikimedia.org/T247189 (10DannyS712) What section of the release notes should this be? `Breaking changes in 1.35` or `Other changes in 1.35`? [08:30:12] (03CR) 10Nikerabbit: [C: 03+2] Add `nuke` right to `delete` grant [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/559437 (https://phabricator.wikimedia.org/T241116) (owner: 10DannyS712) [08:33:48] 10Outreachy (Round 20): Outreachy Application Task: Simple example of topic classification - https://phabricator.wikimedia.org/T246013 (10Idadelveloper) So the mwbase package isn't necessary? [08:33:59] (03PS3) 10DannyS712: WIP user tests [core] - 10https://gerrit.wikimedia.org/r/577332 [08:35:03] 10Outreachy (Round 20): Outreachy Application Task: Simple example of topic classification - https://phabricator.wikimedia.org/T246013 (10Idadelveloper) Okay then :) [08:40:28] 10Outreachy (Round 20): Outreachy Application Task: Simple example of topic classification - https://phabricator.wikimedia.org/T246013 (10Soniya51) >>! In T246013#5951825, @Idadelveloper wrote: > So the mwbase package isn't necessary? Its an alternative. You can use either:) [08:45:33] (03Merged) 10jenkins-bot: Add `nuke` right to `delete` grant [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/559437 (https://phabricator.wikimedia.org/T241116) (owner: 10DannyS712) [08:47:27] (03CR) 10jerkins-bot: [V: 04-1] WIP user tests [core] - 10https://gerrit.wikimedia.org/r/577332 (owner: 10DannyS712) [08:56:02] (03PS4) 10DannyS712: WIP user tests [core] - 10https://gerrit.wikimedia.org/r/577332 [08:56:58] 10MediaWiki-extensions-Nuke, 10User-DannyS712: nuke should be included in a grant - https://phabricator.wikimedia.org/T241116 (10DannyS712) 05Open→03Resolved [08:57:02] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-General, 10MediaWiki-extensions-OAuth, 10Epic, 10good first task: Most extensions which add a user right should also add or extend a grant - https://phabricator.wikimedia.org/T142308 (10DannyS712) [08:58:23] (03PS1) 10DannyS712: Remove old comment from when PgnParser was to be a submodule [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/577896 [08:58:36] (03PS2) 10DannyS712: Remove old comment from when PgnParser was to be a submodule [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/577896 [09:02:00] (03CR) 10DannyS712: "No change to code, just a comment -> uncontrovertial" [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/577896 (owner: 10DannyS712) [09:02:02] (03CR) 10DannyS712: [C: 03+2] Remove old comment from when PgnParser was to be a submodule [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/577896 (owner: 10DannyS712) [09:02:15] (03PS1) 10DannyS712: Add missing periods to CONTRIBUTING.md [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/577897 [09:02:34] (03PS2) 10DannyS712: Add missing periods to CONTRIBUTING.md [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/577897 [09:06:57] (03CR) 10DannyS712: "No change to code, just 2 periods in the docs -> should be uncontrovertial" [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/577897 (owner: 10DannyS712) [09:06:59] (03CR) 10DannyS712: [C: 03+2] Add missing periods to CONTRIBUTING.md [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/577897 (owner: 10DannyS712) [09:11:25] (03PS2) 10Thiemo Kreuz (WMDE): Autofix errors found by phpcs [extensions/IframePage] - 10https://gerrit.wikimedia.org/r/577793 (owner: 10Zoranzoki21) [09:11:28] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Autofix errors found by phpcs [extensions/IframePage] - 10https://gerrit.wikimedia.org/r/577793 (owner: 10Zoranzoki21) [09:11:41] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Fix MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected [extensions/IframePage] - 10https://gerrit.wikimedia.org/r/577795 (owner: 10Zoranzoki21) [09:12:45] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Add phpcs and make it pass [extensions/UploadBlacklist] - 10https://gerrit.wikimedia.org/r/577800 (owner: 10Zoranzoki21) [09:17:35] (03PS5) 10DannyS712: WIP user tests [core] - 10https://gerrit.wikimedia.org/r/577332 [09:19:53] 10Outreachy (Round 20): Outreachy Application Task: Simple example of topic classification - https://phabricator.wikimedia.org/T246013 (10Idadelveloper) I keep getting a json decode error [09:21:15] 10DiscussionTools, 10OWC2020, 10Editing-team (Tracking): Allow non talk pages to be treated as talk pages using a magic word - https://phabricator.wikimedia.org/T245890 (10Alsee) There should be two magic words. One to enable Discussion Tool, and one to disable Discussion Tool. The magic words would each ove... [09:23:12] 10DiscussionTools, 10OWC2020, 10Editing-team (Tracking): Allow non talk pages to be treated as talk pages using a magic word, and allow talk pages to be treated as non-talk pages using a magic word - https://phabricator.wikimedia.org/T245890 (10Alsee) [09:25:54] (03PS2) 10Zoranzoki21: Fix MediaWiki.Commenting.FunctionComment.MissingDocumentationProtected [extensions/IframePage] - 10https://gerrit.wikimedia.org/r/577795 [09:26:00] (03PS2) 10Zoranzoki21: Add phpcs [extensions/IframePage] - 10https://gerrit.wikimedia.org/r/577796 [09:27:10] 10Outreachy (Round 20): Outreachy Application Task: Simple example of topic classification - https://phabricator.wikimedia.org/T246013 (10Hammad.aamer) @Idadelveloper Could you provide details of how to reproduce that error or any snaps of the error? [09:27:38] (03Merged) 10jenkins-bot: Add phpcs and make it pass [extensions/UploadBlacklist] - 10https://gerrit.wikimedia.org/r/577800 (owner: 10Zoranzoki21) [09:30:52] (03CR) 10jerkins-bot: [V: 04-1] WIP user tests [core] - 10https://gerrit.wikimedia.org/r/577332 (owner: 10DannyS712) [09:31:18] 10MediaWiki-Cache, 10Beta-Cluster-Infrastructure, 10User-zeljkofilipin: Main pages of several Beta Cluster wikis redirect to other production wikis - https://phabricator.wikimedia.org/T247078 (10dom_walden) >>! In T247078#5950988, @zeljkofilipin wrote: > @dom_walden you've noticed this yesterday, right? I d... [09:31:54] (03PS6) 10DannyS712: WIP user tests [core] - 10https://gerrit.wikimedia.org/r/577332 [09:53:05] 10Outreachy (Round 20): Outreachy Application Task: Simple example of topic classification - https://phabricator.wikimedia.org/T246013 (10Idadelveloper) I figured out the problem of the json decode error. Turns out the dictionary of my properties is empty. I do not know why. [09:58:32] (03PS1) 10Zoranzoki21: TwitterCards.magic.php: Fix Generic.Arrays.DisallowLongArraySyntax.Found error [extensions/TwitterCards] - 10https://gerrit.wikimedia.org/r/577907 [09:58:34] (03PS1) 10Zoranzoki21: TwitterCards.php: Fix MediaWiki.Commenting.LicenseComment.InvalidLicenseTag warning found by phpcs [extensions/TwitterCards] - 10https://gerrit.wikimedia.org/r/577908 [09:58:36] (03PS1) 10Zoranzoki21: Add phpcs and make it pass [extensions/TwitterCards] - 10https://gerrit.wikimedia.org/r/577909 [10:00:06] (03PS1) 10DannyS712: Don't call mediawikiservices::getMainWANObjectCache if not needed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/577911 [10:00:32] (03CR) 10jerkins-bot: [V: 04-1] Add phpcs and make it pass [extensions/TwitterCards] - 10https://gerrit.wikimedia.org/r/577909 (owner: 10Zoranzoki21) [10:00:34] (03PS2) 10DannyS712: Don't call mediawikiservices::getMainWANObjectCache if not needed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/577911 [10:03:37] (03PS2) 10Zoranzoki21: Add phpcs and make it pass [extensions/TwitterCards] - 10https://gerrit.wikimedia.org/r/577909 [10:08:45] 10Outreachy (Round 20): Outreachy Application Task: Simple example of topic classification - https://phabricator.wikimedia.org/T246013 (10Hammad.aamer) @Idadelveloper Wikidata items don't always have values for everything. You'll need to accommodate such cases [10:10:58] (03PS1) 10Zoranzoki21: TimeMachine.alias.php: Fix Generic.Arrays.DisallowLongArraySyntax.Found [extensions/TimeMachine] - 10https://gerrit.wikimedia.org/r/577919 [10:11:33] 10Outreach-Programs-Projects, 10Outreachy (Round 20): Productionize Wikidata-based Topic Model on ORES - https://phabricator.wikimedia.org/T245848 (10Muskansharma67) Hi, I am Muskan, an undergraudate in Computer Engnieering. I am so excited to contribute to this project. [10:11:51] 10Outreachy (Round 20): Outreachy Application Task: Simple example of topic classification - https://phabricator.wikimedia.org/T246013 (10Mugs-iiit) Hello.... How would we know if the values we get after performing the cosine similarity are accurate representations of similarity? Also can we try and compare it u... [10:12:10] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: langlinks table is not always updated on new link connection - https://phabricator.wikimedia.org/T220794 (10matej_suchanek) This might have been fixed with T233520 resolved. [10:12:36] (03PS1) 10DannyS712: Don't fall back to global $wgUser when creating ParserOptions [extensions/BlueSpiceRSSFeeder] - 10https://gerrit.wikimedia.org/r/577921 (https://phabricator.wikimedia.org/T246861) [10:13:23] (03PS2) 10DannyS712: Don't fall back to global $wgUser when creating ParserOptions [extensions/BlueSpiceRSSFeeder] - 10https://gerrit.wikimedia.org/r/577921 (https://phabricator.wikimedia.org/T246861) [10:14:41] (03PS1) 10DannyS712: Use ParserOptions::newFromAnon() instead of relying on global $wgUser [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/577925 (https://phabricator.wikimedia.org/T246861) [10:15:24] (03PS2) 10DannyS712: Use ParserOptions::newFromAnon() instead of relying on global $wgUser [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/577925 (https://phabricator.wikimedia.org/T246861) [10:16:56] (03PS1) 10DannyS712: Use ParserOptions::newFromAnon() instead of relying on global $wgUser [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/577927 (https://phabricator.wikimedia.org/T246861) [10:17:20] (03PS2) 10DannyS712: Use ParserOptions::newFromAnon() instead of relying on global $wgUser [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/577927 (https://phabricator.wikimedia.org/T246861) [10:18:59] (03PS1) 10DannyS712: Use ParserOptions::newFromAnon() instead of relying on global $wgUser [extensions/PhpTagsStorage] - 10https://gerrit.wikimedia.org/r/577930 (https://phabricator.wikimedia.org/T246861) [10:19:19] (03PS2) 10DannyS712: Use ParserOptions::newFromAnon() instead of relying on global $wgUser [extensions/PhpTagsStorage] - 10https://gerrit.wikimedia.org/r/577930 (https://phabricator.wikimedia.org/T246861) [10:20:31] (03PS1) 10DannyS712: Use ParserOptions::newFromAnon() instead of relying on global $wgUser [extensions/MassMessageEmail] - 10https://gerrit.wikimedia.org/r/577931 (https://phabricator.wikimedia.org/T246861) [10:20:45] (03PS2) 10DannyS712: Use ParserOptions::newFromAnon() instead of relying on global $wgUser [extensions/MassMessageEmail] - 10https://gerrit.wikimedia.org/r/577931 (https://phabricator.wikimedia.org/T246861) [10:20:59] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Problems with page_props on clients - https://phabricator.wikimedia.org/T119738 (10matej_suchanek) This might have been fixed with T233520 resolved. [10:21:43] (03PS1) 10Zoranzoki21: Add phpcs and make it pass [extensions/TimeMachine] - 10https://gerrit.wikimedia.org/r/577933 [10:22:03] (03CR) 10jerkins-bot: [V: 04-1] Use ParserOptions::newFromAnon() instead of relying on global $wgUser [extensions/PhpTagsStorage] - 10https://gerrit.wikimedia.org/r/577930 (https://phabricator.wikimedia.org/T246861) (owner: 10DannyS712) [10:26:24] 10MediaWiki-extensions-General, 10Patch-For-Review, 10good first task: Replace usage of jshint and/or jscs with eslint in MediaWiki extensions (clonable) - https://phabricator.wikimedia.org/T210365 (10Zoranzoki21) [10:27:38] 10MediaWiki-extensions-General, 10Patch-For-Review, 10good first task: Replace usage of jshint and/or jscs with eslint in MediaWiki extensions (clonable) - https://phabricator.wikimedia.org/T210365 (10Zoranzoki21) [10:30:32] (03PS1) 10DannyS712: Are master tests failing? [extensions/PhpTagsStorage] - 10https://gerrit.wikimedia.org/r/577939 [10:32:15] 10MediaWiki-General, 10Core Platform Team: Complete TitleFactory to be a real factory service - https://phabricator.wikimedia.org/T247190 (10Daimona) [10:33:07] (03CR) 10jerkins-bot: [V: 04-1] Are master tests failing? [extensions/PhpTagsStorage] - 10https://gerrit.wikimedia.org/r/577939 (owner: 10DannyS712) [10:33:20] (03PS3) 10Daimona Eaytoy: Avoid using Title::__construct [extensions/Math] - 10https://gerrit.wikimedia.org/r/577763 [10:34:12] (03CR) 10DannyS712: "> Main test build failed." [extensions/PhpTagsStorage] - 10https://gerrit.wikimedia.org/r/577930 (https://phabricator.wikimedia.org/T246861) (owner: 10DannyS712) [10:36:02] 10MediaWiki-General, 10Core Platform Team: Complete TitleFactory to be a real factory service - https://phabricator.wikimedia.org/T247190 (10DannyS712) Adding those involved with original creation at https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/543918/ Explanation for current wrapper, from commit messag... [10:37:40] 10Outreachy (Round 20): Outreachy Application Task: Simple example of topic classification - https://phabricator.wikimedia.org/T246013 (10Hammad.aamer) >>! In T246013#5951867, @Mugs-iiit wrote: > Hello.... How would we know if the values we get after performing the cosine similarity are accurate representations... [10:38:12] (03PS1) 10Zoranzoki21: build: Replace jshint/jsonlint with eslint, add stylelint [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/577940 (https://phabricator.wikimedia.org/T210365) [10:43:24] (03CR) 10jerkins-bot: [V: 04-1] build: Updating acorn to 7.1.1 [extensions/PhpTagsStorage] - 10https://gerrit.wikimedia.org/r/577942 (owner: 10Libraryupgrader) [10:45:19] 10ChessBrowser, 10Security Readiness Reviews: Security Readiness Review For ChessBrowser extension - https://phabricator.wikimedia.org/T244076 (10DannyS712) p:05Lowest→03Triage >>! In T244076#5857157, @Jcross wrote: > @Wugapodes - thanks for submitting this review. Is the goal in working upon and reviewing... [10:46:30] (03CR) 10Daimona Eaytoy: Add a MessageFactory service to inject a message localizer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/577687 (https://phabricator.wikimedia.org/T247127) (owner: 10DannyS712) [10:46:54] 10ChessBrowser, 10Security Readiness Reviews: Security Readiness Review For ChessBrowser extension - https://phabricator.wikimedia.org/T244076 (10DannyS712) [10:49:56] (03PS9) 10DannyS712: Add a MessageFactory service to inject a message localizer [core] - 10https://gerrit.wikimedia.org/r/577687 (https://phabricator.wikimedia.org/T247127) [10:51:36] 10MediaWiki-General, 10User-DannyS712: Refactor Message class into a service - https://phabricator.wikimedia.org/T247191 (10DannyS712) [10:52:13] (03CR) 10DannyS712: Add a MessageFactory service to inject a message localizer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/577687 (https://phabricator.wikimedia.org/T247127) (owner: 10DannyS712) [10:53:17] 10MediaWiki-General, 10CPT Initiatives (Decoupling (CDP2)), 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review, 10User-DannyS712: Add a MessageLocalizer service - https://phabricator.wikimedia.org/T247127 (10DannyS712) [10:57:03] (03CR) 10jerkins-bot: [V: 04-1] build: Updating acorn to 7.1.1 [extensions/PreferencesList] - 10https://gerrit.wikimedia.org/r/577945 (owner: 10Libraryupgrader) [11:03:20] 10MediaWiki-General, 10User-DannyS712: Refactor Message class into a service - https://phabricator.wikimedia.org/T247191 (10DannyS712) [11:03:40] (03PS1) 10DannyS712: [WIP] msg [core] - 10https://gerrit.wikimedia.org/r/577951 [11:03:57] 10DiscussionTools, 10Editing-team (Tracking), 10OWC2020 (OWC2020 Replying 2.0): Implement editing specific comments - https://phabricator.wikimedia.org/T245225 (10matmarex) @Alsee I don't see how the behavior of full-page editing is relevant here. We are not changing how it works. We're building a tool to p... [11:10:51] 10MediaWiki-General, 10MW-1.35-release, 10Patch-For-Review, 10Technical-Debt (Deprecation process): Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release - https://phabricator.wikimedia.org/T232864 (10Daimona) [11:13:08] (03PS2) 10DannyS712: [WIP] msg [core] - 10https://gerrit.wikimedia.org/r/577951 [11:13:18] (03PS1) 10Daimona Eaytoy: Remove deprecated Title::getUserCaseDBKey [core] - 10https://gerrit.wikimedia.org/r/577954 [11:14:16] 10MediaWiki-General, 10MW-1.35-release, 10Patch-For-Review, 10Technical-Debt (Deprecation process): Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release - https://phabricator.wikimedia.org/T232864 (10Daimona) [11:14:36] (03CR) 10DannyS712: [C: 03+1] "LGTM" [core] - 10https://gerrit.wikimedia.org/r/577954 (owner: 10Daimona Eaytoy) [11:16:04] (03CR) 10jerkins-bot: [V: 04-1] [WIP] msg [core] - 10https://gerrit.wikimedia.org/r/577951 (owner: 10DannyS712) [11:16:36] 10MediaWiki-Internationalization, 10WMFI, 10WMNO-Sami, 10Wikidata, 10MW-1.34-notes (1.34.0-wmf.6; 2019-05-21): WMHack19: The native language name for [sje] Pite Sami should be changed from "Pite Sami" to "bidumsámegiella" - https://phabricator.wikimedia.org/T223539 (10jhsoby-WMNO) 05Open→03Resolved [11:16:43] 10MediaWiki-Internationalization, 10UniversalLanguageSelector, 10WMFI, 10WMNO-Sami, and 3 others: WMHack19: Add Saami + Romani languages to Wikidata - https://phabricator.wikimedia.org/T223524 (10jhsoby-WMNO) [11:17:25] (03PS3) 10DannyS712: [WIP] msg [core] - 10https://gerrit.wikimedia.org/r/577951 [11:19:26] 10WMNO-Sami: Create script for uploading bibliographical data to Wikidata - https://phabricator.wikimedia.org/T205635 (10jhsoby-WMNO) 05Open→03Resolved [11:19:28] 10WMNO-Sami: Create scripts for processing and uploading bibliography data - https://phabricator.wikimedia.org/T205631 (10jhsoby-WMNO) [11:20:36] (03CR) 10jerkins-bot: [V: 04-1] [WIP] msg [core] - 10https://gerrit.wikimedia.org/r/577951 (owner: 10DannyS712) [11:24:58] (03PS4) 10DannyS712: [WIP] msg [core] - 10https://gerrit.wikimedia.org/r/577951 [11:31:54] 10MediaWiki-Categories, 10MediaWiki-Parser, 10Tracking-Neverending: Tracking categories (tracking) - https://phabricator.wikimedia.org/T35033 (10DannyS712) Please see {T247192} for potentially converting this to a project [11:34:05] (03CR) 10jerkins-bot: [V: 04-1] [WIP] msg [core] - 10https://gerrit.wikimedia.org/r/577951 (owner: 10DannyS712) [11:35:02] 10WMNO-Sami: Data reconciliation for Sámi placenames - https://phabricator.wikimedia.org/T247193 (10jhsoby-WMNO) [11:35:28] 10WMNO-Sami: Script for data reconciliation for Sámi placenames - https://phabricator.wikimedia.org/T247193 (10jhsoby-WMNO) [11:37:00] 10MediaWiki-Categories, 10Core Platform Team, 10User-DannyS712: Convert TrackingCategories to a service with DI - https://phabricator.wikimedia.org/T247194 (10DannyS712) [11:49:41] 10MediaWiki-Categories, 10Core Platform Team, 10User-DannyS712: Convert TrackingCategories to a service with DI - https://phabricator.wikimedia.org/T247194 (10DannyS712) [11:49:43] 10MediaWiki-Categories, 10MediaWiki-Parser, 10Tracking-Neverending: Tracking categories (tracking) - https://phabricator.wikimedia.org/T35033 (10DannyS712) [11:51:24] 10WMNO-Sami: Sami education program: red link list - https://phabricator.wikimedia.org/T235880 (10jhsoby-WMNO) 05Open→03Resolved a:05WMNOastrid→03jhsoby-WMNO [11:51:26] 10WMNO-Sami: Education program - https://phabricator.wikimedia.org/T235876 (10jhsoby-WMNO) [11:56:39] (03CR) 10Kosta Harlan: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/570730 (https://phabricator.wikimedia.org/T244543) (owner: 10Akinwale-microsoft) [12:12:13] 10Google-Drive-to-Commons, 10Documentation: Prepare development documentation for Gdrive-to-commons tool - https://phabricator.wikimedia.org/T235969 (1001tonythomas) [12:16:42] (03CR) 10jerkins-bot: [V: 04-1] build: Updating acorn to 7.1.1 [extensions/RandomGameUnit] - 10https://gerrit.wikimedia.org/r/577959 (owner: 10Libraryupgrader) [12:28:19] 10DiscussionTools, 10OWC2020, 10Editing-team (Tracking): Allow non talk pages to be treated as talk pages using a magic word, and allow talk pages to be treated as non-talk pages using a magic word - https://phabricator.wikimedia.org/T245890 (10PerfektesChaos) >>! In T245890#5951850, @Alsee wrote: > The magi... [12:31:10] 10MediaWiki-Categories: Category pages causes articles to list in one row and the "letter" in another - https://phabricator.wikimedia.org/T104541 (10matmarex) @PerfektesChaos We tried and reverted that solution in 2015, because it results in very ugly lists if some of the headings have many more items than other... [12:53:51] (03PS5) 10Edward Chernenko: Support cookies in GuzzleHttpRequest [core] - 10https://gerrit.wikimedia.org/r/567389 (https://phabricator.wikimedia.org/T245644) [12:56:25] (03PS1) 10Daimona Eaytoy: Remove deprecated methods in the Interwiki class [core] - 10https://gerrit.wikimedia.org/r/577974 [12:56:31] (03CR) 10Edward Chernenko: "Added Middleware solution + two unit tests:" [core] - 10https://gerrit.wikimedia.org/r/567389 (https://phabricator.wikimedia.org/T245644) (owner: 10Edward Chernenko) [12:56:57] 10MediaWiki-General, 10MW-1.35-release, 10Patch-For-Review, 10Technical-Debt (Deprecation process): Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release - https://phabricator.wikimedia.org/T232864 (10Daimona) [13:05:21] (03PS1) 10Daimona Eaytoy: Remove back-compat code for WikiPage::selectFields [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/577975 [13:07:55] (03CR) 10Esanders: "If we're going to change the functionality significantly, we should rename the method." [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/577618 (owner: 10Bartosz Dziewoński) [13:08:16] (03CR) 10jerkins-bot: [V: 04-1] Support cookies in GuzzleHttpRequest [core] - 10https://gerrit.wikimedia.org/r/567389 (https://phabricator.wikimedia.org/T245644) (owner: 10Edward Chernenko) [13:08:57] (03PS1) 10Daimona Eaytoy: Remove WikiPage::selectFields [core] - 10https://gerrit.wikimedia.org/r/577977 [13:09:29] 10MediaWiki-General, 10MW-1.35-release, 10Patch-For-Review, 10Technical-Debt (Deprecation process): Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release - https://phabricator.wikimedia.org/T232864 (10Daimona) [13:10:20] (03CR) 10jerkins-bot: [V: 04-1] Remove deprecated methods in the Interwiki class [core] - 10https://gerrit.wikimedia.org/r/577974 (owner: 10Daimona Eaytoy) [13:10:24] (03PS1) 10Daimona Eaytoy: Stop using deprecated User::selectFields [extensions/AzharAuth] - 10https://gerrit.wikimedia.org/r/577978 [13:12:11] (03Abandoned) 10Daimona Eaytoy: Stop using deprecated User::selectFields [extensions/AzharAuth] - 10https://gerrit.wikimedia.org/r/577978 (owner: 10Daimona Eaytoy) [13:15:31] (03PS1) 10Zoranzoki21: Add phpcs and make it pass [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/577982 [13:16:29] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/577975 (owner: 10Daimona Eaytoy) [13:18:50] (03CR) 10Zoranzoki21: [C: 04-1] Remove deprecated methods in the Interwiki class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/577974 (owner: 10Daimona Eaytoy) [13:19:33] (03PS2) 10Daimona Eaytoy: Remove deprecated methods in the Interwiki class [core] - 10https://gerrit.wikimedia.org/r/577974 [13:21:39] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] Add phpcs and make it pass [extensions/TimeMachine] - 10https://gerrit.wikimedia.org/r/577933 (owner: 10Zoranzoki21) [13:21:49] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] TimeMachine.alias.php: Fix Generic.Arrays.DisallowLongArraySyntax.Found [extensions/TimeMachine] - 10https://gerrit.wikimedia.org/r/577919 (owner: 10Zoranzoki21) [13:22:19] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Don't call mediawikiservices::getMainWANObjectCache if not needed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/577911 (owner: 10DannyS712) [13:22:29] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] TwitterCards.php: Fix MediaWiki.Commenting.LicenseComment.InvalidLicenseTag warning found by phpcs [extensions/TwitterCards] - 10https://gerrit.wikimedia.org/r/577908 (owner: 10Zoranzoki21) [13:22:41] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] TwitterCards.magic.php: Fix Generic.Arrays.DisallowLongArraySyntax.Found error [extensions/TwitterCards] - 10https://gerrit.wikimedia.org/r/577907 (owner: 10Zoranzoki21) [13:22:44] (03PS1) 10Daimona Eaytoy: Remove $options parameter from OutputPage::parserOptions [core] - 10https://gerrit.wikimedia.org/r/577986 [13:23:27] 10MediaWiki-General, 10MW-1.35-release, 10Patch-For-Review, 10Technical-Debt (Deprecation process): Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release - https://phabricator.wikimedia.org/T232864 (10Daimona) [13:24:00] (03PS2) 10Daimona Eaytoy: Remove $options parameter from OutputPage::parserOptions [core] - 10https://gerrit.wikimedia.org/r/577986 [13:25:19] (03PS1) 10Zoranzoki21: build: Replace jshint/jsonlint with eslint [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/577987 (https://phabricator.wikimedia.org/T210365) [13:25:43] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] Add phpcs and make it pass (032 comments) [extensions/TwitterCards] - 10https://gerrit.wikimedia.org/r/577909 (owner: 10Zoranzoki21) [13:27:26] (03CR) 10Zoranzoki21: Add phpcs and make it pass (032 comments) [extensions/TwitterCards] - 10https://gerrit.wikimedia.org/r/577909 (owner: 10Zoranzoki21) [13:30:54] (03CR) 10Zoranzoki21: [C: 03+1] "Nice!" [core] - 10https://gerrit.wikimedia.org/r/577974 (owner: 10Daimona Eaytoy) [13:31:31] (03CR) 10Daimona Eaytoy: "> Nice!" [core] - 10https://gerrit.wikimedia.org/r/577974 (owner: 10Daimona Eaytoy) [13:34:31] (03PS1) 10Daimona Eaytoy: Remove the ArticleAfterFetchContentObject hook [core] - 10https://gerrit.wikimedia.org/r/577988 [13:35:13] 10MediaWiki-General, 10MW-1.35-release, 10Patch-For-Review, 10Technical-Debt (Deprecation process): Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release - https://phabricator.wikimedia.org/T232864 (10Daimona) [13:35:24] (03Merged) 10jenkins-bot: TimeMachine.alias.php: Fix Generic.Arrays.DisallowLongArraySyntax.Found [extensions/TimeMachine] - 10https://gerrit.wikimedia.org/r/577919 (owner: 10Zoranzoki21) [13:36:53] (03Merged) 10jenkins-bot: Don't call mediawikiservices::getMainWANObjectCache if not needed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/577911 (owner: 10DannyS712) [13:36:56] (03Merged) 10jenkins-bot: TwitterCards.magic.php: Fix Generic.Arrays.DisallowLongArraySyntax.Found error [extensions/TwitterCards] - 10https://gerrit.wikimedia.org/r/577907 (owner: 10Zoranzoki21) [13:36:58] (03Merged) 10jenkins-bot: TwitterCards.php: Fix MediaWiki.Commenting.LicenseComment.InvalidLicenseTag warning found by phpcs [extensions/TwitterCards] - 10https://gerrit.wikimedia.org/r/577908 (owner: 10Zoranzoki21) [13:37:26] (03PS5) 10Daimona Eaytoy: Rewrite findDeprecated using phan instead of php-parser [core] - 10https://gerrit.wikimedia.org/r/566537 (https://phabricator.wikimedia.org/T243403) [13:37:34] (03CR) 10Zoranzoki21: "recheck" [extensions/AnonPrivacy] - 10https://gerrit.wikimedia.org/r/577794 (owner: 10Libraryupgrader) [13:37:48] (03CR) 10Zoranzoki21: "recheck" [extensions/InterwikiExtracts] - 10https://gerrit.wikimedia.org/r/577874 (owner: 10Libraryupgrader) [13:37:59] (03CR) 10Zoranzoki21: "recheck" [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/577960 (owner: 10Libraryupgrader) [13:38:23] (03CR) 10Zoranzoki21: "recheck" [extensions/RandomImageByCategory] - 10https://gerrit.wikimedia.org/r/577961 (owner: 10Libraryupgrader) [13:38:28] (03CR) 10Zoranzoki21: "recheck" [extensions/RandomInCategory] - 10https://gerrit.wikimedia.org/r/577962 (owner: 10Libraryupgrader) [13:41:33] (03PS6) 10Edward Chernenko: Support cookies in GuzzleHttpRequest [core] - 10https://gerrit.wikimedia.org/r/567389 (https://phabricator.wikimedia.org/T245644) [13:45:36] (03PS1) 10Zoranzoki21: build: Replace jshint/jsonlint with eslint [extensions/TimeMachine] - 10https://gerrit.wikimedia.org/r/577991 (https://phabricator.wikimedia.org/T210365) [13:47:30] 10Outreach-Programs-Projects, 10Google-Summer-of-Code (2020): Develop a mechanism to send Wikimedia-specific Zulip welcome messages to newcomers - https://phabricator.wikimedia.org/T233478 (10Pavithraes) [13:47:32] 10Accessibility, 10UniversalLanguageSelector: Add more ARIA attributes to ULS cog - https://phabricator.wikimedia.org/T52921 (10Aklapper) @MattFitzpatrick: Hi! This task has been assigned to you a while ago. Could you maybe share an update? Do you still plan to work on this task, or [do you need any help](http... [13:50:51] (03CR) 10jerkins-bot: [V: 04-1] Rewrite findDeprecated using phan instead of php-parser [core] - 10https://gerrit.wikimedia.org/r/566537 (https://phabricator.wikimedia.org/T243403) (owner: 10Daimona Eaytoy) [13:57:37] (03PS1) 10Zoranzoki21: build: Replace jshint/jsonlint with eslint [extensions/TitleIcon] - 10https://gerrit.wikimedia.org/r/577997 (https://phabricator.wikimedia.org/T210365) [14:04:06] (03PS1) 10Zoranzoki21: Bump mediawiki/mediawiki-codesniffer to 30.0.0 [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/577999 [14:06:27] (03PS1) 10Zoranzoki21: Move some files into the directories for consistency [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/578000 [14:07:25] (03CR) 10jerkins-bot: [V: 04-1] Move some files into the directories for consistency [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/578000 (owner: 10Zoranzoki21) [14:08:58] 10Epic, 10Google-Summer-of-Code (2020): Create or improve a tool for monitoring or automating tasks for Wikimedia databases - https://phabricator.wikimedia.org/T246435 (10Popsauce) Hi @jcrespo @Marostegui, I'm Karan Lohaan. I'm currently pursuing my Bachelor's degree from Amrita School of Engineering in India... [14:09:33] (03PS1) 10Zoranzoki21: build: Replace jshint/jsonlint with eslint [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/578001 (https://phabricator.wikimedia.org/T210365) [14:10:35] (03CR) 10Bartosz Dziewoński: parser: Detect comments transcluded from another page (032 comments) [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/576949 (https://phabricator.wikimedia.org/T245694) (owner: 10Bartosz Dziewoński) [14:10:39] (03CR) 10jerkins-bot: [V: 04-1] build: Replace jshint/jsonlint with eslint [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/578001 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [14:10:43] (03PS3) 10Bartosz Dziewoński: parser: Detect comments transcluded from another page [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/576949 (https://phabricator.wikimedia.org/T245694) [14:11:08] (03PS2) 10Zoranzoki21: Move some files into the directories for consistency [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/578000 [14:11:13] (03PS2) 10Zoranzoki21: build: Replace jshint/jsonlint with eslint [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/578001 (https://phabricator.wikimedia.org/T210365) [14:12:06] (03CR) 10jerkins-bot: [V: 04-1] Move some files into the directories for consistency [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/578000 (owner: 10Zoranzoki21) [14:12:14] (03CR) 10jerkins-bot: [V: 04-1] build: Replace jshint/jsonlint with eslint [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/578001 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [14:12:58] (03PS3) 10Zoranzoki21: Move some files into the directories for consistency [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/578000 [14:13:02] (03PS3) 10Zoranzoki21: build: Replace jshint/jsonlint with eslint [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/578001 (https://phabricator.wikimedia.org/T210365) [14:14:04] (03CR) 10Bartosz Dziewoński: [C: 04-1] "PS3: Responded to comments, added tests. The tests reveal incorrect behavior for multiline comments, the thing I did with 'commonAncestorC" [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/576949 (https://phabricator.wikimedia.org/T245694) (owner: 10Bartosz Dziewoński) [14:15:17] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Wikibase property names are missing - https://phabricator.wikimedia.org/T247196 (10CXuesong) [14:15:39] (03CR) 10jerkins-bot: [V: 04-1] parser: Detect comments transcluded from another page [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/576949 (https://phabricator.wikimedia.org/T245694) (owner: 10Bartosz Dziewoński) [14:17:21] 10Outreachy (Round 20): Outreachy Application Task: Simple example of topic classification - https://phabricator.wikimedia.org/T246013 (10Idadelveloper) Hello guys. I clicked on the 'Public Link' of my notebook to generate the public link. That should be the last step in finishing the microtask right? [14:18:49] (03CR) 10DannyS712: [C: 03+1] "LGTM" [core] - 10https://gerrit.wikimedia.org/r/577974 (owner: 10Daimona Eaytoy) [14:21:07] (03PS3) 10DannyS712: Remove reference to LudoDBRegistry [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/577841 [14:22:36] (03PS1) 10DannyS712: Remove unused ChessJson::toJavascript [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/578003 [14:23:24] (03PS2) 10DannyS712: Remove unused ChessJson::toJavascript and jsKeys [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/578003 [14:23:35] (03PS4) 10Bartosz Dziewoński: parser: Detect comments transcluded from another page [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/576949 (https://phabricator.wikimedia.org/T245694) [14:26:02] (03CR) 10Bartosz Dziewoński: "I think this way is fine… "en-bigafd" now looks as expected, and I checked the three changes in "en-big" and they also look correct." [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/576949 (https://phabricator.wikimedia.org/T245694) (owner: 10Bartosz Dziewoński) [14:31:01] (03CR) 10Bartosz Dziewoński: "closestElement?" [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/577618 (owner: 10Bartosz Dziewoński) [14:36:43] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Wikibase property names are missing when renders - https://phabricator.wikimedia.org/T247196 (10CXuesong) [14:37:49] 10MediaWiki-Recent-changes, 10Growth-Team: The word "diff" in Recent Changes entry for a new page doesn't link anywhere - https://phabricator.wikimedia.org/T135358 (10subins2000) > for example to the old version as a rendered page, to a diff from an empty page, or to editing the old version If it's a new page... [14:38:59] (03PS1) 10DannyS712: build: Updating mediawiki/mediawiki-codesniffer to 30.0.0 [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/578011 [14:39:15] (03PS2) 10DannyS712: build: Updating mediawiki/mediawiki-codesniffer to 30.0.0 [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/578011 [14:40:52] (03CR) 10DannyS712: [C: 03+1] "LGTM, not sure why Libraryupgrader doesn't have +2" [extensions/RandomInCategory] - 10https://gerrit.wikimedia.org/r/577962 (owner: 10Libraryupgrader) [14:40:57] (03CR) 10DannyS712: [C: 03+1] "LGTM, not sure why Libraryupgrader doesn't have +2" [extensions/RandomImageByCategory] - 10https://gerrit.wikimedia.org/r/577961 (owner: 10Libraryupgrader) [14:41:02] (03CR) 10DannyS712: [C: 03+1] "LGTM, not sure why Libraryupgrader doesn't have +2" [extensions/AnonPrivacy] - 10https://gerrit.wikimedia.org/r/577794 (owner: 10Libraryupgrader) [14:41:06] (03CR) 10DannyS712: [C: 03+1] "LGTM, not sure why Libraryupgrader doesn't have +2" [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/577960 (owner: 10Libraryupgrader) [14:41:09] (03CR) 10DannyS712: [C: 03+1] "LGTM, not sure why Libraryupgrader doesn't have +2" [extensions/InterwikiExtracts] - 10https://gerrit.wikimedia.org/r/577874 (owner: 10Libraryupgrader) [14:42:24] (03CR) 10DannyS712: "Should be uncontroversial, usually done by bot" [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/578011 (owner: 10DannyS712) [14:42:26] (03CR) 10DannyS712: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 30.0.0 [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/578011 (owner: 10DannyS712) [14:50:33] (03PS1) 10Bartosz Dziewoński: [WIP] parser: Improve merging multiple comments on one line [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/578013 [14:50:45] (03CR) 10jerkins-bot: [V: 04-1] [WIP] parser: Improve merging multiple comments on one line [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/578013 (owner: 10Bartosz Dziewoński) [14:52:09] (03PS2) 10Bartosz Dziewoński: Replace the closest() polyfill [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/577618 [14:52:29] (03PS3) 10Bartosz Dziewoński: Fix signatureRanges overlapping for some comments [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/577619 [15:19:33] (03CR) 10Daimona Eaytoy: Replace call to deprecated User::isBlocked with User::getBlock (032 comments) [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/577732 (owner: 10DannyS712) [15:21:23] (03CR) 10Daimona Eaytoy: "This should really be moved to another repo..." [core] - 10https://gerrit.wikimedia.org/r/566537 (https://phabricator.wikimedia.org/T243403) (owner: 10Daimona Eaytoy) [15:24:16] (03PS5) 10DannyS712: Replace call to deprecated User::isBlocked with User::getBlock [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/577732 [15:25:34] (03CR) 10jerkins-bot: [V: 04-1] Replace call to deprecated User::isBlocked with User::getBlock [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/577732 (owner: 10DannyS712) [15:29:47] (03PS17) 10Edward Chernenko: MCR: provide MultiContentSave hook to replace PageContentSave [core] - 10https://gerrit.wikimedia.org/r/467308 (https://phabricator.wikimedia.org/T205982) [15:34:39] (03PS6) 10DannyS712: Replace call to deprecated User::isBlocked with User::getBlock [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/577732 [15:34:45] (03PS7) 10DannyS712: Replace call to deprecated User::isBlocked with User::getBlock [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/577732 [15:35:06] 10Design, 10TCB-Team, 10Two-Column-Edit-Conflict-Merge, 10WMDE-Design: Permanent or long-term storage of edit conflict text - https://phabricator.wikimedia.org/T245523 (10awight) On my local wiki, I discovered that the edit page calls the [[ https://www.mediawiki.org/w/api.php?action=help&modules=stashedit... [15:44:47] (03CR) 10Daimona Eaytoy: Replace call to deprecated User::isBlocked with User::getBlock (032 comments) [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/577732 (owner: 10DannyS712) [15:45:49] (03PS8) 10DannyS712: Replace call to deprecated User::isBlocked with User::getBlock [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/577732 [16:14:49] (03PS1) 10Reedy: Drop $ceAllowConfirmedEmail [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/578042 [16:16:35] 10Wikimedia-GitHub, 10Composer: Add the Packagist webhook to wikimedia/mediawiki repo on GitHub - https://phabricator.wikimedia.org/T194878 (10Krinkle) 05Open→03Declined There are a many of ways in which one //could// distribute, install, support or extendn the MediaWiki software. A number of those we have... [16:16:41] 10MediaWiki-General, 10TechCom, 10Composer, 10Patch-For-Review: Cannot use Composer's CLI to manage a project's dependencies - https://phabricator.wikimedia.org/T166956 (10Krinkle) [16:17:32] (03PS2) 10Reedy: Drop $ceAllowConfirmedEmail [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/578042 [16:20:00] 10Wikimedia-Site-requests: Turn off direct account creations at Wikimania, at least for periods of time - https://phabricator.wikimedia.org/T247185 (10Reedy) So I was looking how we "disable" registration by the public on private wikis... ie https://office.wikimedia.org/wiki/Special:CreateAccount It's a mixture... [16:20:38] (03PS1) 10DannyS712: Pass a user to ParserOptions::newCanonical [extensions/TEI] - 10https://gerrit.wikimedia.org/r/578043 (https://phabricator.wikimedia.org/T246861) [16:21:41] (03PS2) 10DannyS712: Replace ParserOptions::newCanonical with ::newFromUser, pass a user [extensions/TEI] - 10https://gerrit.wikimedia.org/r/578043 (https://phabricator.wikimedia.org/T246861) [16:32:23] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10User-Addshore, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Wikibase property names are missing when renders - https://phabricator.wikimedia.org/T247196 (10Addshore) a:03Addshore Did you run update.php as part of the upgrade process? [16:46:55] (03CR) 10Ammarpad: "I think this is really redundant since all redirects are now automatically tagged and the tag does show up in more places than where this " (031 comment) [core] - 10https://gerrit.wikimedia.org/r/577303 (https://phabricator.wikimedia.org/T177281) (owner: 10Subins2000) [16:53:13] 10Wikimedia-Site-requests: Turn off direct account creations at Wikimania, at least for periods of time - https://phabricator.wikimedia.org/T247185 (10Reedy) Looking at least one of the users... They passed captcha to create account (via Special:CreateAccount)... But then seemingly couldn't pass it to add spam l... [16:53:48] 10MediaWiki-Internationalization, 10Wikimedia-General-or-Unknown, 10I18n: On bd wikimedia, local overwrite of string "Timezone-bdt" is ignored: Timestamp shows "(+06)" instead of "(বিএসটি)" (BST) - https://phabricator.wikimedia.org/T238851 (10Aftabuzzaman) Yes, working. Thanks. You may close this bug. [16:53:58] 10Wikimedia-Site-requests: Turn off direct account creations at Wikimania, at least for periods of time - https://phabricator.wikimedia.org/T247185 (10Urbanecm) I would grant autocreateaccount to * if we revoke createaccount, so users can still login with accounts from other wikis. [16:55:38] 10MediaWiki-Internationalization, 10Wikimedia-General-or-Unknown, 10I18n: On bd wikimedia, local overwrite of string "Timezone-bdt" is ignored: Timestamp shows "(+06)" instead of "(বিএসটি)" (BST) - https://phabricator.wikimedia.org/T238851 (10RhinosF1) 05Open→03Resolved a:03Aftabuzzaman [17:00:58] 10Wikimedia-GitHub: Move all code hosting from GitHub to FSF Forge - https://phabricator.wikimedia.org/T247203 (10Koavf) [17:01:13] (03CR) 10Ammarpad: [C: 04-1] ChangesList: Mark redirects [core] - 10https://gerrit.wikimedia.org/r/577303 (https://phabricator.wikimedia.org/T177281) (owner: 10Subins2000) [17:03:03] 10Wikimedia-GitHub, 10Community-consensus-needed: Move all code hosting from GitHub to FSF Forge - https://phabricator.wikimedia.org/T247203 (10RhinosF1) [17:03:43] 10Wikimedia-GitHub, 10Community-consensus-needed: Move all code hosting from GitHub to FSF Forge - https://phabricator.wikimedia.org/T247203 (10Krenair) Alternatively, move the few things we do have on GitHub to be authored through our own Gerrit instance, and leave the GitHub mirrors be? [17:03:54] 10Wikimedia-GitHub, 10Community-consensus-needed: Move all code hosting from GitHub to FSF Forge - https://phabricator.wikimedia.org/T247203 (10RhinosF1) We should probably discuss this first. Either via a TechCom RfC or MediaWiki RfC. [17:05:39] 10Wikimedia-GitHub, 10Community-consensus-needed: Move all code hosting from GitHub to FSF Forge - https://phabricator.wikimedia.org/T247203 (10Reedy) Noting most of the GitHub "code hosting" is code mirrors. I don't see any problem with having the visibility of the repos in more places. For repos/projects wh... [17:07:20] 10Wikimedia-Site-requests, 10Patch-For-Review: Turn off direct account creations at Wikimania, at least for periods of time - https://phabricator.wikimedia.org/T247185 (10Reedy) >>! In T247185#5952178, @Urbanecm wrote: > I would grant autocreateaccount to * if we revoke createaccount, so users can still login... [17:09:24] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10CPT Initiatives (Decoupling (CDP2)), and 2 others: Phase out deprecated Title::isValidMoveTarget - https://phabricator.wikimedia.org/T214317 (10Daimona) 05Open→03Resolved This was done. [17:09:27] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10CPT Initiatives (Decoupling (CDP2)), 10Epic: Untangle MediaHandler, FileRepo, File, Title and Linker - https://phabricator.wikimedia.org/T208786 (10Daimona) [17:13:08] 10Data-Portability: Add a Button for Data Sheet downloads - https://phabricator.wikimedia.org/T247204 (10Phess2) [17:18:13] 10Epic, 10Google-Summer-of-Code (2020): Create or improve a tool for monitoring or automating tasks for Wikimedia databases - https://phabricator.wikimedia.org/T246435 (10Aklapper) >>! In T246435#5952058, @Popsauce wrote: > i would love to get more insight related to the project and in getting started with the... [17:19:29] (03PS1) 10Daimona Eaytoy: Stop accepting ApiMain instances in ApiResult::__construct [core] - 10https://gerrit.wikimedia.org/r/578050 [17:19:52] 10Wikimedia-Site-requests, 10Patch-For-Review: Turn off direct account creations at Wikimania, at least for periods of time - https://phabricator.wikimedia.org/T247185 (10Reedy) p:05Triage→03Medium TBD if we want to allow `'user'` to create account. As per https://wikimania.wikimedia.org/wiki/Special:ListG... [17:20:05] 10MediaWiki-General, 10MW-1.35-release, 10Patch-For-Review, 10Technical-Debt (Deprecation process): Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release - https://phabricator.wikimedia.org/T232864 (10Daimona) [17:21:14] 10MediaWiki-General, 10Data-Portability: Add a Button for Data Sheet downloads - https://phabricator.wikimedia.org/T247204 (10Reedy) [17:21:36] 10MediaWiki-General, 10Data-Portability: Add a Button for Data Sheet downloads - https://phabricator.wikimedia.org/T247204 (10Reedy) Can you provide an example of the sort of thing you want to "export"? [17:22:24] 10MediaWiki-File-management, 10Commons, 10Wiktionary: Lower case file titles don’t show Commons description - https://phabricator.wikimedia.org/T247159 (10Reedy) [17:23:36] 10Wikimedia-GitHub, 10Community-consensus-needed: Move all code hosting from GitHub to FSF Forge - https://phabricator.wikimedia.org/T247203 (10Aklapper) 05Open→03Stalled Please clarify which specific code hosting you mean when writing "Move all code hosting from GitHub". Or how this relates to Wikimedia G... [17:27:18] 10Wikimedia-GitHub, 10Community-consensus-needed: Move all code hosting from GitHub to FSF Forge - https://phabricator.wikimedia.org/T247203 (10Koavf) >>! In T247203#5952250, @Aklapper wrote: > Please clarify which specific code hosting you mean when writing "Move all code hosting from GitHub". Or how this rel... [17:28:12] (03CR) 10Umherirrender: [C: 03+2] "Changes to .gitignore and other files are not whitelisted and need manual review" [extensions/RandomInCategory] - 10https://gerrit.wikimedia.org/r/577962 (owner: 10Libraryupgrader) [17:28:51] (03CR) 10Umherirrender: [C: 03+2] build: Updating acorn to 7.1.1 [extensions/AnonPrivacy] - 10https://gerrit.wikimedia.org/r/577794 (owner: 10Libraryupgrader) [17:29:24] (03CR) 10Umherirrender: [C: 03+2] build: Updating acorn to 7.1.1 [extensions/InterwikiExtracts] - 10https://gerrit.wikimedia.org/r/577874 (owner: 10Libraryupgrader) [17:30:41] (03CR) 10Umherirrender: [C: 03+2] build: Updating acorn to 7.1.1 [extensions/RandomImageByCategory] - 10https://gerrit.wikimedia.org/r/577961 (owner: 10Libraryupgrader) [17:31:34] (03PS1) 10Daimona Eaytoy: Remove check for vulnerable PHPUnit version [core] - 10https://gerrit.wikimedia.org/r/578056 (https://phabricator.wikimedia.org/T180231) [17:32:23] (03CR) 10Umherirrender: [C: 03+2] build: Updating acorn to 7.1.1 [extensions/RandomImage] - 10https://gerrit.wikimedia.org/r/577960 (owner: 10Libraryupgrader) [17:35:30] (03CR) 10Umherirrender: [C: 03+2] build: Updating acorn to 7.1.1 [extensions/Widgets] - 10https://gerrit.wikimedia.org/r/578033 (owner: 10Libraryupgrader) [17:35:54] (03PS1) 10Krinkle: watchlist: Misc cleanup for ApiQueryRecentChangesIntegrationTest [core] - 10https://gerrit.wikimedia.org/r/578057 [17:37:16] (03CR) 10Umherirrender: [C: 03+2] build: Updating acorn to 7.1.1 [extensions/WikiTextLoggedInOut] - 10https://gerrit.wikimedia.org/r/578037 (owner: 10Libraryupgrader) [17:38:16] (03CR) 10Krinkle: [C: 04-1] "The resources/lib/ must not be changed in this repository. It is imported from ooui (oojs/ui.git) via foreign-resources.yaml." [core] - 10https://gerrit.wikimedia.org/r/577780 (https://phabricator.wikimedia.org/T244790) (owner: 10Aron Manning) [17:38:29] 10Wikimedia-GitHub, 10Community-consensus-needed: Move all code hosting from GitHub to FSF Forge - https://phabricator.wikimedia.org/T247203 (10Aklapper) @Koavf: Is this about mirroring to Github? Or is this about code repositories that have their canonical hosting on Github? Or both? And again, how does this... [17:39:11] 10MediaWiki-Authentication-and-authorization: Log in a structured way the source of account creation - https://phabricator.wikimedia.org/T247205 (10Reedy) [17:40:06] 10MediaWiki-General, 10Data-Portability: Add a Button for Data Sheet downloads - https://phabricator.wikimedia.org/T247204 (10Aklapper) Hi @Phess2, thanks for taking the time to report this and welcome to Wikimedia Phabricator! Could you please provide specific and clear steps to reproduce the situation that m... [17:40:19] (03PS2) 10Daimona Eaytoy: Remove check for vulnerable PHPUnit version [core] - 10https://gerrit.wikimedia.org/r/578056 (https://phabricator.wikimedia.org/T180231) [17:40:26] (03CR) 10Umherirrender: [V: 03+2] "T245629" [extensions/RandomGameUnit] - 10https://gerrit.wikimedia.org/r/577959 (owner: 10Libraryupgrader) [17:41:41] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10User-Addshore, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Wikibase property names are missing when renders - https://phabricator.wikimedia.org/T247196 (10CXuesong) Yes, I have. And actually the Property labels can be fetched from DB succes... [17:42:30] (03CR) 10Umherirrender: [V: 03+2] build: Updating acorn to 7.1.1 [extensions/PhpTagsStorage] - 10https://gerrit.wikimedia.org/r/577942 (owner: 10Libraryupgrader) [17:42:59] (03PS9) 10Daimona Eaytoy: [WIP] Upgrade phan to latest version [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/555662 [17:43:39] (03PS1) 10Daimona Eaytoy: Upgrade phan to 2.6.0 [tools/phan] - 10https://gerrit.wikimedia.org/r/578058 [17:43:45] (03CR) 10jerkins-bot: [V: 04-1] Upgrade phan to 2.6.0 [tools/phan] - 10https://gerrit.wikimedia.org/r/578058 (owner: 10Daimona Eaytoy) [17:43:53] (03PS2) 10Daimona Eaytoy: Upgrade phan to 2.6.0 [tools/phan] - 10https://gerrit.wikimedia.org/r/578058 [17:44:04] 10MediaWiki-Configuration, 10Shape Expressions, 10Wikidata, 10Wikidata-Campsite, and 3 others: mediawiki/core webdriver.io tests fail in EntitySchema extension - https://phabricator.wikimedia.org/T245629 (10Umherirrender) With the extension Gadget this also affects wmf deployed extension https://integrati... [17:44:08] (03CR) 10Umherirrender: [V: 03+2] "T245629" [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/577851 (owner: 10Libraryupgrader) [17:44:21] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Upgrade phan to latest version [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/555662 (owner: 10Daimona Eaytoy) [17:44:48] (03CR) 10Umherirrender: [V: 03+2] "T245629" [extensions/BlogPage] - 10https://gerrit.wikimedia.org/r/577807 (owner: 10Libraryupgrader) [17:45:10] (03CR) 10Umherirrender: [V: 03+2] build: Updating acorn to 7.1.1 [extensions/PreferencesList] - 10https://gerrit.wikimedia.org/r/577945 (owner: 10Libraryupgrader) [17:45:29] (03PS10) 10Daimona Eaytoy: [WIP] Upgrade phan to latest version [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/555662 [17:47:04] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Upgrade phan to latest version [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/555662 (owner: 10Daimona Eaytoy) [17:47:10] (03CR) 10Daimona Eaytoy: "New warnings: "Suspicious array access to nullable" in various language converters." [tools/phan] - 10https://gerrit.wikimedia.org/r/578058 (owner: 10Daimona Eaytoy) [17:47:12] (03CR) 10Aron Manning: "Yes, I know it's supposed to be imported. But actually it is NOT updated, wikimedia-ui-base.less is outdated. Therefore I've submitted thi" [core] - 10https://gerrit.wikimedia.org/r/577780 (https://phabricator.wikimedia.org/T244790) (owner: 10Aron Manning) [17:49:09] (03PS11) 10Daimona Eaytoy: [WIP] Upgrade phan to latest version [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/555662 [17:50:04] (03CR) 10DannyS712: [C: 03+1] "LGTM" [core] - 10https://gerrit.wikimedia.org/r/577986 (owner: 10Daimona Eaytoy) [17:50:07] (03CR) 10jerkins-bot: [V: 04-1] watchlist: Misc cleanup for ApiQueryRecentChangesIntegrationTest [core] - 10https://gerrit.wikimedia.org/r/578057 (owner: 10Krinkle) [17:53:13] 10Wikimedia-GitHub: Move all code hosting from GitHub to FSF Forge - https://phabricator.wikimedia.org/T247203 (10Aklapper) [17:56:46] (03PS1) 10Zoranzoki21: Move PHP files into the includes/ for consistency [extensions/Theme] - 10https://gerrit.wikimedia.org/r/578059 [17:59:39] (03PS11) 10Daimona Eaytoy: Add RAW_PARAM taint type [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/542953 [18:01:26] (03PS1) 10D3r1ck01: specialpage: Avoid deprecated usage of Title::newFromTitleValue() [core] - 10https://gerrit.wikimedia.org/r/578063 [18:02:34] (03PS1) 10Zoranzoki21: Add phpcs and make it pass [extensions/Theme] - 10https://gerrit.wikimedia.org/r/578064 [18:02:58] (03PS1) 10D3r1ck01: specials: Use self::getTitleFor() as method is declared static [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/578065 [18:03:20] 10Wikimedia-GitHub: Move all code hosting from GitHub to FSF Forge - https://phabricator.wikimedia.org/T247203 (10Demian) > Ditch the Microsoft-run code hosting and move to one run by the FSF, focus on free culture Because ideologies and who produces that hammer matters more than whether that hammer actually ex... [18:04:14] (03PS2) 10D3r1ck01: specials: Use self::getTitleFor() as method is declared static [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/578065 [18:04:16] (03CR) 10Umherirrender: [C: 03+2] "There is no need to update the codesniffer version manual" [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/577999 (owner: 10Zoranzoki21) [18:04:50] (03CR) 10Zoranzoki21: "> There is no need to update the codesniffer version manual" [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/577999 (owner: 10Zoranzoki21) [18:05:41] 10Wikimedia-GitHub: Move all code hosting from GitHub to FSF Forge - https://phabricator.wikimedia.org/T247203 (10Reedy) >>! In T247203#5952301, @Demian wrote: > Furthermore, WMF could run a GitLab instance. That has the potential of replacing the outdated gerrit, thus boosting the WMF into this decade. That's w... [18:06:46] (03CR) 10Umherirrender: [C: 03+2] Move some files into the directories for consistency [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/578000 (owner: 10Zoranzoki21) [18:07:55] (03Merged) 10jenkins-bot: Bump mediawiki/mediawiki-codesniffer to 30.0.0 [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/577999 (owner: 10Zoranzoki21) [18:08:07] (03CR) 10Umherirrender: [C: 03+2] build: Updating acorn to 7.1.1 [extensions/YotpoReviews] - 10https://gerrit.wikimedia.org/r/578066 (owner: 10Libraryupgrader) [18:08:32] (03CR) 10Umherirrender: [C: 03+2] build: Updating acorn to 7.1.1 [extensions/YouTube] - 10https://gerrit.wikimedia.org/r/578067 (owner: 10Libraryupgrader) [18:08:54] (03PS1) 10Zoranzoki21: Move css and js files into the modules/ for consistency [extensions/TextScroller] - 10https://gerrit.wikimedia.org/r/578069 [18:10:16] (03Merged) 10jenkins-bot: Move some files into the directories for consistency [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/578000 (owner: 10Zoranzoki21) [18:11:48] (03PS1) 10Reedy: Updating zordius/lightncandy (v1.2.4 => v1.2.5) [vendor] - 10https://gerrit.wikimedia.org/r/578070 (https://phabricator.wikimedia.org/T242980) [18:12:30] (03PS2) 10Reedy: Updating zordius/lightncandy (v1.2.4 => v1.2.5) [vendor] - 10https://gerrit.wikimedia.org/r/578070 (https://phabricator.wikimedia.org/T242980) [18:12:40] (03CR) 10Krinkle: rdbms: reduce duplication in Database via helper methods (037 comments) [core] - 10https://gerrit.wikimedia.org/r/576492 (owner: 10Aaron Schulz) [18:13:26] (03PS2) 10Krinkle: watchlist: Misc cleanup for ApiQueryRecentChangesIntegrationTest [core] - 10https://gerrit.wikimedia.org/r/578057 [18:13:32] (03PS1) 10Reedy: Updating zordius/lightncandy (v1.2.4 => v1.2.5) [core] - 10https://gerrit.wikimedia.org/r/578071 (https://phabricator.wikimedia.org/T242980) [18:15:21] 10Wikimedia-GitHub: Move all code hosting from GitHub to FSF Forge - https://phabricator.wikimedia.org/T247203 (10Demian) >>! In T247203#5952303, @Reedy wrote: >>>! In T247203#5952301, @Demian wrote: >> Furthermore, WMF could run a GitLab instance. That has the potential of replacing the outdated gerrit, thus bo... [18:18:37] 10Wikimedia-GitHub: Move all code hosting from GitHub to FSF Forge - https://phabricator.wikimedia.org/T247203 (10Reedy) >>! In T247203#5952313, @Demian wrote: >>>! In T247203#5952303, @Reedy wrote: >>>>! In T247203#5952301, @Demian wrote: >>> Furthermore, WMF could run a GitLab instance. That has the potential... [18:19:42] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/578063 (owner: 10D3r1ck01) [18:19:50] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/578065 (owner: 10D3r1ck01) [18:24:25] (03PS1) 10Zoranzoki21: build: Replace jsonlint with eslint, add stylelint [extensions/TextScroller] - 10https://gerrit.wikimedia.org/r/578074 [18:26:00] (03PS1) 10Umherirrender: Use MediaWikiServices::getRepoGroup [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/578076 [18:26:35] (03PS3) 10Krinkle: watchlist: Misc cleanup for ApiQueryRecentChangesIntegrationTest [core] - 10https://gerrit.wikimedia.org/r/578057 [18:27:47] 10Wikimedia-GitHub: Move all code hosting from GitHub to FSF Forge - https://phabricator.wikimedia.org/T247203 (10Demian) >>! In T247203#5952316, @Reedy wrote: > There are also more than 3 comments on the task. https://phabricator.wikimedia.org/T167547#3336421 Fifth comment: "Declined". 1 comment by the same us... [18:28:16] (03CR) 10jerkins-bot: [V: 04-1] Updating zordius/lightncandy (v1.2.4 => v1.2.5) [core] - 10https://gerrit.wikimedia.org/r/578071 (https://phabricator.wikimedia.org/T242980) (owner: 10Reedy) [18:32:15] (03PS1) 10Umherirrender: Use MediaWikiServices::getRepoGroup [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/578078 [18:32:24] 10Wikimedia-GitHub: Move all code hosting from GitHub to FSF Forge - https://phabricator.wikimedia.org/T247203 (10Aklapper) @Demian: Please stop adding off-topic comments here. If you want to discuss Gitlab, then please go to the Gitlab task. This task is about "FSF Forge" - see its task summary. Thanks for your... [18:32:31] (03CR) 10Reedy: "This introduced a class with a duplicate class name" [core] - 10https://gerrit.wikimedia.org/r/576828 (https://phabricator.wikimedia.org/T113095) (owner: 10Phuedx) [18:33:39] 10MediaWiki-HTML-Templating, 10Developer-Wishlist (2017), 10MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): A cached server-side HTML template should update when you change a partial template which it includes - https://phabricator.wikimedia.org/T113095 (10Reedy) >>... [18:33:54] 10MediaWiki-extensions-Other, 10User-Zoranzoki21: Convert TemplateInfo to use extension registration - https://phabricator.wikimedia.org/T247208 (10Zoranzoki21) [18:34:26] (03CR) 10Reedy: "Failure commented https://phabricator.wikimedia.org/T113095#5952339" [core] - 10https://gerrit.wikimedia.org/r/578071 (https://phabricator.wikimedia.org/T242980) (owner: 10Reedy) [18:37:41] (03PS1) 10Krinkle: phpunit: Speed up MediaWikiCoversValidator trait [core] - 10https://gerrit.wikimedia.org/r/578083 (https://phabricator.wikimedia.org/T225730) [18:38:15] (03PS1) 10Reedy: Rename TemplateParserTest.php -> TemplateParserIntegrationTest.php [core] - 10https://gerrit.wikimedia.org/r/578084 (https://phabricator.wikimedia.org/T113095) [18:38:28] (03PS1) 10Umherirrender: Use MediaWikiServices::getRepoGroup [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/578085 [18:39:45] (03CR) 10Sophivorus: [C: 03+2] Add phpcs and make it pass [extensions/TimeMachine] - 10https://gerrit.wikimedia.org/r/577933 (owner: 10Zoranzoki21) [18:39:55] (03PS2) 10Krinkle: phpunit: Speed up MediaWikiCoversValidator trait [core] - 10https://gerrit.wikimedia.org/r/578083 (https://phabricator.wikimedia.org/T225730) [18:40:26] (03CR) 10Sophivorus: [C: 03+2] build: Replace jshint/jsonlint with eslint [extensions/TimeMachine] - 10https://gerrit.wikimedia.org/r/577991 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [18:41:06] Reedy: wait how does having two TemplateParserTest not cause a failure? [18:41:16] Krinkle: it does [18:41:19] Sometimes, but not always [18:41:27] 10MediaWiki-extensions-Other, 10User-Zoranzoki21: Convert TemplateInfo to use extension registration - https://phabricator.wikimedia.org/T247208 (10Zoranzoki21) 05Open→03Stalled Hmm, https://www.mediawiki.org/wiki/Extension:TemplateInfo says: "This extension was superseded by Extension:TemplateData." So,... [18:41:31] Krinkle: Like, it failed on https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/578071/ but not apparently before? [18:41:36] 10MediaWiki-Configuration, 10MediaWiki-extensions-General, 10Goal, 10Patch-For-Review, 10User-Zoranzoki21: Convert all extensions and skins on gerrit to use extension registration - https://phabricator.wikimedia.org/T98668 (10Zoranzoki21) [18:41:40] (03PS2) 10Krinkle: Rename TemplateParserTest.php -> TemplateParserIntegrationTest.php [core] - 10https://gerrit.wikimedia.org/r/578084 (https://phabricator.wikimedia.org/T113095) (owner: 10Reedy) [18:41:40] 10Wikimedia-GitHub: Move all code hosting from GitHub to FSF Forge - https://phabricator.wikimedia.org/T247203 (10Krenair) >>! In T247203#5952329, @Demian wrote: >> Please don't make statements if you're not going to even attempt to back them up with a reason (personal or otherwise), or evidence. Is Gerrit outda... [18:41:50] (03CR) 10Krinkle: [C: 03+2] Rename TemplateParserTest.php -> TemplateParserIntegrationTest.php [core] - 10https://gerrit.wikimedia.org/r/578084 (https://phabricator.wikimedia.org/T113095) (owner: 10Reedy) [18:42:09] Reedy: strange, ok [18:42:42] (03Merged) 10jenkins-bot: Add phpcs and make it pass [extensions/TimeMachine] - 10https://gerrit.wikimedia.org/r/577933 (owner: 10Zoranzoki21) [18:42:45] (03CR) 10Daimona Eaytoy: [C: 03+1] Updating zordius/lightncandy (v1.2.4 => v1.2.5) [vendor] - 10https://gerrit.wikimedia.org/r/578070 (https://phabricator.wikimedia.org/T242980) (owner: 10Reedy) [18:43:12] 10MediaWiki-extensions-RevisionCommentSupplement, 10Technical-Debt, 10User-DannyS712: RevisionCommentSupplement needs uses of global $wgUser removed - https://phabricator.wikimedia.org/T246305 (10DannyS712) [18:43:17] (03PS2) 10Reedy: Updating zordius/lightncandy (v1.2.4 => v1.2.5) [core] - 10https://gerrit.wikimedia.org/r/578071 (https://phabricator.wikimedia.org/T242980) [18:43:21] 10MediaWiki-extensions-RevisionCommentSupplement: Convert RevisionCommentSupplement to use extension registration - https://phabricator.wikimedia.org/T243688 (10DannyS712) [18:43:42] (03Merged) 10jenkins-bot: build: Replace jshint/jsonlint with eslint [extensions/TimeMachine] - 10https://gerrit.wikimedia.org/r/577991 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [18:43:54] 10MediaWiki-General, 10MediaWiki-extensions-Approved-Revs, 10MediaWiki-extensions-AutoProxyBlock, 10MediaWiki-extensions-BlockAndNuke, and 13 others: Calls to LogPage::addEntry should pass a user - https://phabricator.wikimedia.org/T243652 (10DannyS712) [18:44:10] 10MediaWiki-extensions-RevisionCommentSupplement: [RevisionCommentSupplement] Error: 1060 Duplicate column name 'rcs_latest' - https://phabricator.wikimedia.org/T196529 (10DannyS712) [18:44:32] 10MediaWiki-extensions-RevisionCommentSupplement: [RevisionCommentSupplement] Update for expiring user groups - https://phabricator.wikimedia.org/T160024 (10DannyS712) [18:45:00] (03CR) 10Daimona Eaytoy: [C: 03+1] "I'd suggest mentioning in a method comment the reason why we're not using a data provider." [core] - 10https://gerrit.wikimedia.org/r/578083 (https://phabricator.wikimedia.org/T225730) (owner: 10Krinkle) [18:47:03] 10Wikimedia-GitHub: Move all code hosting from GitHub to FSF Forge - https://phabricator.wikimedia.org/T247203 (10Demian) @Krenair I did not wish to discuss that topic either here, nor on T167547. I've just answered Reedy's comment to point out 3 comments in 12 minutes is not a consensus, then the topic blew up... [18:47:07] (03PS1) 10Umherirrender: Use MediaWikiServices::getRepoGroup [extensions/Video] - 10https://gerrit.wikimedia.org/r/578088 [18:47:54] (03CR) 10Ladsgroup: [C: 03+2] "Wow. Thanks!" [core] - 10https://gerrit.wikimedia.org/r/578083 (https://phabricator.wikimedia.org/T225730) (owner: 10Krinkle) [18:51:27] 10MediaWiki-General: MW/CI allowed two test files with the same class name to exist - https://phabricator.wikimedia.org/T247209 (10Reedy) [18:51:59] (03PS3) 10Krinkle: phpunit: Speed up MediaWikiCoversValidator trait [core] - 10https://gerrit.wikimedia.org/r/578083 (https://phabricator.wikimedia.org/T225730) [18:52:11] (03CR) 10Krinkle: [C: 03+2] "Per Ladsgroup." [core] - 10https://gerrit.wikimedia.org/r/578083 (https://phabricator.wikimedia.org/T225730) (owner: 10Krinkle) [18:53:30] (03CR) 10Daimona Eaytoy: [C: 03+2] "Re-applying +2. For me, running ApiQueryRecentChangesIntegrationTest went from 53 tests and 37-40 seconds to 27 tests and 31-32 seconds." [core] - 10https://gerrit.wikimedia.org/r/578083 (https://phabricator.wikimedia.org/T225730) (owner: 10Krinkle) [18:56:10] (03Merged) 10jenkins-bot: Rename TemplateParserTest.php -> TemplateParserIntegrationTest.php [core] - 10https://gerrit.wikimedia.org/r/578084 (https://phabricator.wikimedia.org/T113095) (owner: 10Reedy) [19:00:22] (03PS1) 10Umherirrender: Use MediaWikiServices::getRepoGroup [extensions/ImageTweaks] - 10https://gerrit.wikimedia.org/r/578091 [19:05:48] (03Merged) 10jenkins-bot: phpunit: Speed up MediaWikiCoversValidator trait [core] - 10https://gerrit.wikimedia.org/r/578083 (https://phabricator.wikimedia.org/T225730) (owner: 10Krinkle) [19:08:25] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Add phpcs and make it pass (031 comment) [extensions/Theme] - 10https://gerrit.wikimedia.org/r/578064 (owner: 10Zoranzoki21) [19:14:41] (03CR) 10jerkins-bot: [V: 04-1] Use MediaWikiServices::getRepoGroup [extensions/Video] - 10https://gerrit.wikimedia.org/r/578088 (owner: 10Umherirrender) [19:17:44] 10MediaWiki-General, 10MW-1.35-release, 10PHP 7.4 support, 10Patch-For-Review, 10Upstream: implode() the wrong way round in lightncandy - https://phabricator.wikimedia.org/T242980 (10Reedy) p:05Triage→03Medium [19:20:20] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] specials: Use self::getTitleFor() as method is declared static [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/578065 (owner: 10D3r1ck01) [19:21:17] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Avoid using Title::__construct [extensions/Math] - 10https://gerrit.wikimedia.org/r/577763 (owner: 10Daimona Eaytoy) [19:27:17] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] EditPage: Avoid PHP notice when simple antispam check fails [core] - 10https://gerrit.wikimedia.org/r/577783 (owner: 10Daimona Eaytoy) [19:31:04] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Avoid using Title::__construct [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/577766 (owner: 10Daimona Eaytoy) [19:31:33] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Avoid using Title::__construct [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/577765 (owner: 10Daimona Eaytoy) [19:32:32] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Pass a user when creating a new ParserOptions [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/577720 (https://phabricator.wikimedia.org/T246861) (owner: 10DannyS712) [19:32:58] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Pass a user when creating a new ParserOptions [extensions/NewUserMessage] - 10https://gerrit.wikimedia.org/r/577714 (https://phabricator.wikimedia.org/T246861) (owner: 10DannyS712) [19:37:53] (03CR) 10Jforrester: [C: 03+2] Updating zordius/lightncandy (v1.2.4 => v1.2.5) [core] - 10https://gerrit.wikimedia.org/r/578071 (https://phabricator.wikimedia.org/T242980) (owner: 10Reedy) [19:38:16] (03CR) 10Jforrester: [C: 03+2] Updating zordius/lightncandy (v1.2.4 => v1.2.5) [vendor] - 10https://gerrit.wikimedia.org/r/578070 (https://phabricator.wikimedia.org/T242980) (owner: 10Reedy) [19:38:59] (03CR) 10Jforrester: [C: 03+2] Normalise comments to // rather than # [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577808 (owner: 10Reedy) [19:39:27] (03Merged) 10jenkins-bot: Normalise comments to // rather than # [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577808 (owner: 10Reedy) [19:39:33] (03CR) 10Jforrester: [C: 03+2] Kill off $wgLocalInterwiki [core] - 10https://gerrit.wikimedia.org/r/577810 (owner: 10Reedy) [19:40:07] (03CR) 10Jforrester: [C: 03+2] Drop $ceAllowConfirmedEmail [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/578042 (owner: 10Reedy) [19:41:51] 10Google-Drive-to-Commons, 10Outreachy (Round 20): Enhancements to gdrive-to-commons uploader tool - https://phabricator.wikimedia.org/T243456 (10Raymond_Ndibe) Hello, i am an outreachy aspirant and I chose to work only on wikimedia projects. just a quick question, are we allowed to start working immediately o... [19:42:13] (03PS3) 10Daimona Eaytoy: Hard-deprecate Title::__construct for foreign callers [core] - 10https://gerrit.wikimedia.org/r/577770 [19:42:18] (03CR) 10Daimona Eaytoy: Hard-deprecate Title::__construct for foreign callers [core] - 10https://gerrit.wikimedia.org/r/577770 (owner: 10Daimona Eaytoy) [19:42:32] (03CR) 10Jforrester: [C: 03+2] Stop allowing invalid /0 subnet [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577778 (https://phabricator.wikimedia.org/T247165) (owner: 10Reedy) [19:43:05] (03Merged) 10jenkins-bot: Stop allowing invalid /0 subnet [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577778 (https://phabricator.wikimedia.org/T247165) (owner: 10Reedy) [19:45:16] (03CR) 10Jforrester: [C: 03+1] Allow explicit ranges in IPUtils::isValidRange() (031 comment) [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577774 (https://phabricator.wikimedia.org/T247156) (owner: 10Reedy) [19:45:30] (03CR) 10Jforrester: [C: 03+2] Fix provider for comments [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577753 (owner: 10Reedy) [19:45:54] (03Merged) 10jenkins-bot: Fix provider for comments [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577753 (owner: 10Reedy) [19:46:32] (03CR) 10Jforrester: "Is this intended as a micro-optimisation because IPv4 IPs are more common in the real world? If so, should we comment this so that that ca" [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577775 (owner: 10Reedy) [19:46:34] (03CR) 10Jforrester: "Is this intended as a micro-optimisation because IPv4 IPs are more common in the real world? If so, should we comment this so that that ca" [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577775 (owner: 10Reedy) [19:47:27] (03CR) 10Jforrester: [C: 03+2] Add tests to cover IPUtils::parseRange [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577752 (https://phabricator.wikimedia.org/T247156) (owner: 10Reedy) [19:47:31] (03CR) 10Reedy: "Kinda, and to match the function above that does IPv4 first. It just seems odd one does one first, the other the other" [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577775 (owner: 10Reedy) [19:47:47] (03CR) 10jerkins-bot: [V: 04-1] Add tests to cover IPUtils::parseRange [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577752 (https://phabricator.wikimedia.org/T247156) (owner: 10Reedy) [19:48:29] (03CR) 10Jforrester: [C: 03+2] "+ @covers parseCIDR and parseCIDR6 too?" [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577752 (https://phabricator.wikimedia.org/T247156) (owner: 10Reedy) [19:48:47] (03PS8) 10Jforrester: Add tests to cover IPUtils::parseRange [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577752 (https://phabricator.wikimedia.org/T247156) (owner: 10Reedy) [19:48:49] (03CR) 10jerkins-bot: [V: 04-1] Add tests to cover IPUtils::parseRange [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577752 (https://phabricator.wikimedia.org/T247156) (owner: 10Reedy) [19:48:55] (03CR) 10Jforrester: Add tests to cover IPUtils::parseRange [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577752 (https://phabricator.wikimedia.org/T247156) (owner: 10Reedy) [19:49:06] (03CR) 10jerkins-bot: [V: 04-1] Add tests to cover IPUtils::parseRange [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577752 (https://phabricator.wikimedia.org/T247156) (owner: 10Reedy) [19:49:18] 10IPUtils, 10Patch-For-Review, 10Technical-Debt: IPUtils allows illegal value for netmask (/0) - https://phabricator.wikimedia.org/T247165 (10Reedy) 05Open→03Resolved a:03Reedy [19:49:54] 10IPUtils, 10Patch-For-Review, 10Test-Coverage: IPUtils test coverage is poor - https://phabricator.wikimedia.org/T247156 (10Reedy) [19:50:14] (03CR) 10Jforrester: Add tests to cover IPUtils::parseRange (031 comment) [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577752 (https://phabricator.wikimedia.org/T247156) (owner: 10Reedy) [19:51:35] (03PS9) 10Jforrester: Add tests to cover IPUtils::parseRange [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577752 (https://phabricator.wikimedia.org/T247156) (owner: 10Reedy) [19:51:59] (03CR) 10Jforrester: [C: 03+2] Allow explicit ranges in IPUtils::isValidRange() [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577774 (https://phabricator.wikimedia.org/T247156) (owner: 10Reedy) [19:52:36] (03Merged) 10jenkins-bot: Allow explicit ranges in IPUtils::isValidRange() [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577774 (https://phabricator.wikimedia.org/T247156) (owner: 10Reedy) [19:53:20] (03CR) 10Jforrester: Fix return values where function doesn't always return [ string, string ] (032 comments) [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577782 (owner: 10Reedy) [19:53:22] (03Merged) 10jenkins-bot: Avoid using Title::__construct [extensions/Math] - 10https://gerrit.wikimedia.org/r/577763 (owner: 10Daimona Eaytoy) [19:53:26] (03Merged) 10jenkins-bot: EditPage: Avoid PHP notice when simple antispam check fails [core] - 10https://gerrit.wikimedia.org/r/577783 (owner: 10Daimona Eaytoy) [19:53:28] (03Merged) 10jenkins-bot: Avoid using Title::__construct [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/577766 (owner: 10Daimona Eaytoy) [19:53:31] (03Merged) 10jenkins-bot: Avoid using Title::__construct [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/577765 (owner: 10Daimona Eaytoy) [19:53:34] (03Merged) 10jenkins-bot: Pass a user when creating a new ParserOptions [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/577720 (https://phabricator.wikimedia.org/T246861) (owner: 10DannyS712) [19:53:36] (03Merged) 10jenkins-bot: Pass a user when creating a new ParserOptions [extensions/NewUserMessage] - 10https://gerrit.wikimedia.org/r/577714 (https://phabricator.wikimedia.org/T246861) (owner: 10DannyS712) [19:53:38] (03Merged) 10jenkins-bot: Updating zordius/lightncandy (v1.2.4 => v1.2.5) [vendor] - 10https://gerrit.wikimedia.org/r/578070 (https://phabricator.wikimedia.org/T242980) (owner: 10Reedy) [19:53:43] (03Merged) 10jenkins-bot: Updating zordius/lightncandy (v1.2.4 => v1.2.5) [core] - 10https://gerrit.wikimedia.org/r/578071 (https://phabricator.wikimedia.org/T242980) (owner: 10Reedy) [19:53:53] (03Merged) 10jenkins-bot: Kill off $wgLocalInterwiki [core] - 10https://gerrit.wikimedia.org/r/577810 (owner: 10Reedy) [19:53:55] (03Merged) 10jenkins-bot: Drop $ceAllowConfirmedEmail [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/578042 (owner: 10Reedy) [19:54:08] (03PS4) 10Jforrester: Fix return values where function doesn't always return [ string, string ] [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577782 (owner: 10Reedy) [19:54:25] (03CR) 10Jforrester: "Clearly we should run phan on this repo. :-)" [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577782 (owner: 10Reedy) [19:54:58] (03CR) 10Reedy: [C: 04-1] Fix return values where function doesn't always return [ string, string ] (032 comments) [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577782 (owner: 10Reedy) [19:55:30] 10IPUtils, 10phan: Enable Phan on IPUtils - https://phabricator.wikimedia.org/T247210 (10Reedy) [19:56:08] 10IPUtils, 10phan: Enable phan and seccheck on IPUtils - https://phabricator.wikimedia.org/T247210 (10Reedy) [19:56:15] (03PS5) 10Jforrester: Fix return values where function doesn't always return [string, string] [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577782 (owner: 10Reedy) [19:56:21] (03CR) 10Jforrester: [C: 03+1] Fix return values where function doesn't always return [string, string] [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577782 (owner: 10Reedy) [19:56:26] 10IPSet, 10phan: Enable phan and seccheck on IPSet - https://phabricator.wikimedia.org/T247211 (10Reedy) [19:56:42] (03CR) 10Reedy: [C: 03+1] Fix return values where function doesn't always return [string, string] [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577782 (owner: 10Reedy) [19:56:49] (03CR) 10Reedy: [C: 03+2] "+1+1=+2" [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577782 (owner: 10Reedy) [19:57:17] (03Merged) 10jenkins-bot: Fix return values where function doesn't always return [string, string] [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577782 (owner: 10Reedy) [19:57:40] (03PS3) 10Jforrester: Check for IPv4 before IPv6 in IPUtils::isValidRange [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577775 (owner: 10Reedy) [19:57:44] (03CR) 10Jforrester: [C: 03+1] Check for IPv4 before IPv6 in IPUtils::isValidRange [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577775 (owner: 10Reedy) [19:59:54] (03CR) 10Jforrester: [C: 03+2] "Good t" [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577752 (https://phabricator.wikimedia.org/T247156) (owner: 10Reedy) [20:00:58] (03Merged) 10jenkins-bot: Add tests to cover IPUtils::parseRange [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577752 (https://phabricator.wikimedia.org/T247156) (owner: 10Reedy) [20:01:11] (03PS6) 10Jforrester: Updating composer/semver and mediawiki/mediawiki-codesniffer [core] - 10https://gerrit.wikimedia.org/r/564142 (owner: 10Reedy) [20:01:13] (03CR) 10jerkins-bot: [V: 04-1] Updating composer/semver and mediawiki/mediawiki-codesniffer [core] - 10https://gerrit.wikimedia.org/r/564142 (owner: 10Reedy) [20:01:37] (03PS1) 10Reedy: Add phan [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578103 (https://phabricator.wikimedia.org/T247210) [20:01:57] (03CR) 10Umherirrender: [C: 03+1] build: Updating acorn to 7.1.1 [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/578098 (owner: 10Libraryupgrader) [20:02:22] Reedy: You're ahead of me. :-) [20:02:32] lol [20:03:00] (03PS1) 10Reedy: Add phan [IPSet] - 10https://gerrit.wikimedia.org/r/578104 (https://phabricator.wikimedia.org/T247211) [20:03:08] (03CR) 10Jforrester: [C: 03+2] build: Updating acorn to 7.1.1 [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/578098 (owner: 10Libraryupgrader) [20:04:23] It really irrtates me that the IPUtils repo is properly namespaced but IPSet is just a top-level mess. [20:04:31] (03CR) 10Jforrester: [C: 03+2] Add phan [IPSet] - 10https://gerrit.wikimedia.org/r/578104 (https://phabricator.wikimedia.org/T247211) (owner: 10Reedy) [20:04:48] (03CR) 10Jforrester: [C: 03+1] "Wait, we need a config file too, right?" [IPSet] - 10https://gerrit.wikimedia.org/r/578104 (https://phabricator.wikimedia.org/T247211) (owner: 10Reedy) [20:04:57] 10IPUtils, 10Patch-For-Review, 10Test-Coverage: IPUtils test coverage is poor - https://phabricator.wikimedia.org/T247156 (10Reedy) Progress! (on lines at least) {F31671601 size=full} to {F31671621 size=full} [20:05:06] (03CR) 10Reedy: "damn it, missed git add" [IPSet] - 10https://gerrit.wikimedia.org/r/578104 (https://phabricator.wikimedia.org/T247211) (owner: 10Reedy) [20:05:33] (03PS2) 10Reedy: Add phan [IPSet] - 10https://gerrit.wikimedia.org/r/578104 (https://phabricator.wikimedia.org/T247211) [20:05:47] Reedy: If you're OK with my comment on https://gerrit.wikimedia.org/r/c/mediawiki/libs/IPUtils/+/577775 just C+2 it. [20:05:52] (03CR) 10jerkins-bot: [V: 04-1] Hard-deprecate Title::__construct for foreign callers [core] - 10https://gerrit.wikimedia.org/r/577770 (owner: 10Daimona Eaytoy) [20:06:07] (03CR) 10Reedy: [C: 03+2] "WFM" [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577775 (owner: 10Reedy) [20:06:29] 10MediaWiki-General, 10Data-Portability: Add a Button for Data Sheet downloads - https://phabricator.wikimedia.org/T247204 (10Phess2) @Reedy For example, a list of countries by average temperature. Essentially rows and columns of data, as you would see in excel. @Aklapper, Hello! I was working on a model to d... [20:06:34] (03Merged) 10jenkins-bot: Check for IPv4 before IPv6 in IPUtils::isValidRange [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/577775 (owner: 10Reedy) [20:07:26] (03Abandoned) 10Daimona Eaytoy: Add isValidExplicitRange function [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/522989 (https://phabricator.wikimedia.org/T218074) (owner: 10Daimona Eaytoy) [20:08:00] Reedy: You writing sanitizeIP tests? :-) [20:08:30] (03PS3) 10Daimona Eaytoy: Allow single IPs in ip_in_range [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/498204 (https://phabricator.wikimedia.org/T218074) [20:08:36] 10IPUtils, 10Patch-For-Review: IPUtils::isValidRange doesn't consider explicit ranges as valid - https://phabricator.wikimedia.org/T247163 (10Reedy) 05Open→03Resolved a:03Reedy [20:08:46] (03CR) 10jerkins-bot: [V: 04-1] Allow single IPs in ip_in_range [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/498204 (https://phabricator.wikimedia.org/T218074) (owner: 10Daimona Eaytoy) [20:08:51] (03CR) 10Jforrester: "Ah, was going to ask if the explicit differentiation between a CIDR range and explicit range was needed." [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/522989 (https://phabricator.wikimedia.org/T218074) (owner: 10Daimona Eaytoy) [20:09:12] (03CR) 10Daimona Eaytoy: "> Ah, was going to ask if the explicit differentiation between a CIDR" [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/522989 (https://phabricator.wikimedia.org/T218074) (owner: 10Daimona Eaytoy) [20:10:05] (03CR) 10Jforrester: [C: 03+2] Remove check for vulnerable PHPUnit version [core] - 10https://gerrit.wikimedia.org/r/578056 (https://phabricator.wikimedia.org/T180231) (owner: 10Daimona Eaytoy) [20:11:04] (03PS4) 10Daimona Eaytoy: Allow single IPs in ip_in_range [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/498204 (https://phabricator.wikimedia.org/T218074) [20:11:29] (03PS5) 10Daimona Eaytoy: Allow single IPs in ip_in_range [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/498204 (https://phabricator.wikimedia.org/T218074) [20:11:38] (03CR) 10Jforrester: [C: 03+1] Remove $options parameter from OutputPage::parserOptions [core] - 10https://gerrit.wikimedia.org/r/577986 (owner: 10Daimona Eaytoy) [20:13:02] (03CR) 10Daimona Eaytoy: "check experimental" [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578103 (https://phabricator.wikimedia.org/T247210) (owner: 10Reedy) [20:13:29] (03CR) 10Daimona Eaytoy: "check experimental" [IPSet] - 10https://gerrit.wikimedia.org/r/578104 (https://phabricator.wikimedia.org/T247211) (owner: 10Reedy) [20:13:33] (03PS2) 10Reedy: Add phan [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578103 (https://phabricator.wikimedia.org/T247210) [20:13:46] (03PS3) 10Jforrester: Add phan [IPSet] - 10https://gerrit.wikimedia.org/r/578104 (https://phabricator.wikimedia.org/T247211) (owner: 10Reedy) [20:14:07] (03CR) 10jerkins-bot: [V: 04-1] Add phan [IPSet] - 10https://gerrit.wikimedia.org/r/578104 (https://phabricator.wikimedia.org/T247211) (owner: 10Reedy) [20:14:10] (03CR) 10Reedy: "check experimental" [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578103 (https://phabricator.wikimedia.org/T247210) (owner: 10Reedy) [20:14:43] Reedy: The future is running phan inline in composer test, so... [20:15:10] (03PS4) 10Daimona Eaytoy: Add phan [IPSet] - 10https://gerrit.wikimedia.org/r/578104 (https://phabricator.wikimedia.org/T247211) (owner: 10Reedy) [20:15:29] (03CR) 10jerkins-bot: [V: 04-1] Add phan [IPSet] - 10https://gerrit.wikimedia.org/r/578104 (https://phabricator.wikimedia.org/T247211) (owner: 10Reedy) [20:15:31] (03PS3) 10Daimona Eaytoy: Add phan [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578103 (https://phabricator.wikimedia.org/T247210) (owner: 10Reedy) [20:15:52] (03CR) 10jerkins-bot: [V: 04-1] Add phan [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578103 (https://phabricator.wikimedia.org/T247210) (owner: 10Reedy) [20:16:57] (03PS5) 10Daimona Eaytoy: Add phan [IPSet] - 10https://gerrit.wikimedia.org/r/578104 (https://phabricator.wikimedia.org/T247211) (owner: 10Reedy) [20:16:57] Oh good, phan spots actual issues in both. [20:17:02] Well, at least there's that. [20:17:08] woop [20:17:24] (03PS4) 10Daimona Eaytoy: Add phan [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578103 (https://phabricator.wikimedia.org/T247210) (owner: 10Reedy) [20:17:37] (03CR) 10Daimona Eaytoy: [C: 03+1] Add phan [IPSet] - 10https://gerrit.wikimedia.org/r/578104 (https://phabricator.wikimedia.org/T247211) (owner: 10Reedy) [20:17:45] (03CR) 10jerkins-bot: [V: 04-1] Add phan [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578103 (https://phabricator.wikimedia.org/T247210) (owner: 10Reedy) [20:18:09] (03CR) 10Reedy: "check experimental" [IPSet] - 10https://gerrit.wikimedia.org/r/578104 (https://phabricator.wikimedia.org/T247211) (owner: 10Reedy) [20:18:42] (03CR) 10Jforrester: [C: 03+2] Add phan [IPSet] - 10https://gerrit.wikimedia.org/r/578104 (https://phabricator.wikimedia.org/T247211) (owner: 10Reedy) [20:19:06] (03Merged) 10jenkins-bot: Add phan [IPSet] - 10https://gerrit.wikimedia.org/r/578104 (https://phabricator.wikimedia.org/T247211) (owner: 10Reedy) [20:19:23] Reedy: Oh, hmm, seccheck won't run with phan yet, right? [20:19:26] Next release. [20:19:39] I'm not sure tbh [20:19:53] Daimona's been doing all the work, of course. :-) [20:22:53] (03PS5) 10Reedy: Add phan [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578103 (https://phabricator.wikimedia.org/T247210) [20:23:15] (03CR) 10jerkins-bot: [V: 04-1] Add phan [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578103 (https://phabricator.wikimedia.org/T247210) (owner: 10Reedy) [20:23:38] (03Merged) 10jenkins-bot: Remove check for vulnerable PHPUnit version [core] - 10https://gerrit.wikimedia.org/r/578056 (https://phabricator.wikimedia.org/T180231) (owner: 10Daimona Eaytoy) [20:23:51] (03CR) 10jerkins-bot: [V: 04-1] Allow single IPs in ip_in_range [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/498204 (https://phabricator.wikimedia.org/T218074) (owner: 10Daimona Eaytoy) [20:26:58] (03PS1) 10Jforrester: Bug: T247156 [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578110 (https://phabricator.wikimedia.org/T247156) [20:29:18] (03PS2) 10Jforrester: tests: Add IPv6 coverage of sanitizeIP() [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578110 (https://phabricator.wikimedia.org/T247156) [20:29:37] (03CR) 10jerkins-bot: [V: 04-1] tests: Add IPv6 coverage of sanitizeIP() [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578110 (https://phabricator.wikimedia.org/T247156) (owner: 10Jforrester) [20:29:55] 10IPSet, 10Patch-For-Review, 10phan: Enable phan and seccheck on IPSet - https://phabricator.wikimedia.org/T247211 (10Reedy) 05Open→03Resolved a:03Reedy [20:30:27] (03PS3) 10Jforrester: tests: Add IPv6 coverage of sanitizeIP() [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578110 (https://phabricator.wikimedia.org/T247156) [20:35:19] (03CR) 10Reedy: [C: 03+2] tests: Add IPv6 coverage of sanitizeIP() [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578110 (https://phabricator.wikimedia.org/T247156) (owner: 10Jforrester) [20:35:44] (03Merged) 10jenkins-bot: tests: Add IPv6 coverage of sanitizeIP() [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578110 (https://phabricator.wikimedia.org/T247156) (owner: 10Jforrester) [20:36:28] yay, 10% more coverage [20:36:35] * James_F bows. ;-) [20:52:06] (03PS1) 10Reedy: Make getSubnet actually not accept invalid IPv4 addresses [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578120 [20:53:57] (03CR) 10Jforrester: [C: 03+2] Make getSubnet actually not accept invalid IPv4 addresses [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578120 (owner: 10Reedy) [20:54:21] (03Merged) 10jenkins-bot: Make getSubnet actually not accept invalid IPv4 addresses [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578120 (owner: 10Reedy) [20:55:49] (03PS1) 10Reedy: Add IPv4 tests for IPUtils::getSubnet() [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578121 [20:56:08] (03CR) 10jerkins-bot: [V: 04-1] Add IPv4 tests for IPUtils::getSubnet() [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578121 (owner: 10Reedy) [20:58:32] (03PS2) 10Reedy: Add IPv4 tests for IPUtils::getSubnet() [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578121 [20:59:16] 10MediaWiki-Categories: Category pages causes articles to list in one row and the "letter" in another - https://phabricator.wikimedia.org/T104541 (10PerfektesChaos) Well, it seems to depend on browser technology. * Your example browser is ignoring the orphans/widows rule. They take the wording //avoid// too seri... [20:59:50] 10MediaWiki-Page-editing, 10Epic, 10Patch-For-Review, 10User-Daniel: Edit conflict detection by timestamp should be deprecated - https://phabricator.wikimedia.org/T58849 (10awight) I found something surprising while playing with a proof-of-concept for {T245523}. It seems that `wpEdittime` is required and... [21:00:07] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/578115 (owner: 10Libraryupgrader) [21:00:14] (03CR) 10Jforrester: [C: 03+2] "Oops." [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578121 (owner: 10Reedy) [21:00:22] James_F: This is why we need tests... :D [21:00:29] Reedy: Indeed. [21:00:37] (03Merged) 10jenkins-bot: Add IPv4 tests for IPUtils::getSubnet() [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578121 (owner: 10Reedy) [21:01:16] 79% of lines :) [21:01:23] (03PS6) 10Reedy: Add phan [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578103 (https://phabricator.wikimedia.org/T247210) [21:01:32] (03CR) 10Reedy: "Right, let's see if we can fix these failures.." [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578103 (https://phabricator.wikimedia.org/T247210) (owner: 10Reedy) [21:01:46] (03CR) 10jerkins-bot: [V: 04-1] Add phan [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578103 (https://phabricator.wikimedia.org/T247210) (owner: 10Reedy) [21:01:56] Reedy: Why does it claim that parserCIDR/etc. don't have any function coverage? [21:02:16] James_F: I think it's because not 100% line coverage? [21:02:27] Oh, right. [21:09:17] (03PS7) 10Reedy: Add phan and fix issues [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578103 (https://phabricator.wikimedia.org/T247210) [21:09:39] (03CR) 10jerkins-bot: [V: 04-1] Add phan and fix issues [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578103 (https://phabricator.wikimedia.org/T247210) (owner: 10Reedy) [21:18:35] 10Google-Drive-to-Commons, 10Outreachy (Round 20): Enhancements to gdrive-to-commons uploader tool - https://phabricator.wikimedia.org/T243456 (10srishakatux) @Raymond_Ndibe Hi! See point 8 in the guide here: https://www.mediawiki.org/wiki/Outreachy/Participants. Between now and the application deadline, you w... [21:18:40] https://github.com/wikimedia/mediawiki-libs-IPUtils/blob/master/src/IPUtils.php#L604 [21:18:44] Guarded by is_numeric [21:18:50] src/IPUtils.php:604 PhanTypeMismatchArgumentInternal Argument 3 ($length) is non-empty-string but \substr() takes int [21:18:52] * Reedy stabs [21:21:46] (03PS8) 10Reedy: Add phan and fix issues [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578103 (https://phabricator.wikimedia.org/T247210) [21:22:09] (03CR) 10jerkins-bot: [V: 04-1] Add phan and fix issues [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578103 (https://phabricator.wikimedia.org/T247210) (owner: 10Reedy) [21:24:38] (03CR) 10Reedy: "Any suggestions on fixing the last few, Daimona?" [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578103 (https://phabricator.wikimedia.org/T247210) (owner: 10Reedy) [21:27:56] (03CR) 10jerkins-bot: [V: 04-1] build: Updating acorn to 7.1.1 [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/578125 (owner: 10Libraryupgrader) [21:31:35] (03PS1) 10Reedy: Make tests for IPUtils::isInRanges() test IPUtils::isInRanges() [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578131 [21:32:54] 10IPUtils, 10MW-1.35-release: Make new IPUtils release - https://phabricator.wikimedia.org/T247212 (10Reedy) [21:32:59] (03PS1) 10Umherirrender: Use MediaWikiServices::getRepoGroup in /api/ [core] - 10https://gerrit.wikimedia.org/r/578132 [21:33:15] 10IPUtils, 10MW-1.35-release: Make new IPUtils release - https://phabricator.wikimedia.org/T247212 (10Reedy) [21:33:17] 10IPUtils, 10Patch-For-Review, 10phan: Enable phan and seccheck on IPUtils - https://phabricator.wikimedia.org/T247210 (10Reedy) [21:33:56] 10IPUtils, 10Test-Coverage: IPUtils test coverage is poor - https://phabricator.wikimedia.org/T247156 (10Reedy) [21:35:49] (03PS1) 10Umherirrender: Use MediaWikiServices::getRepoGroup in /specials/ [core] - 10https://gerrit.wikimedia.org/r/578133 [21:38:46] (03PS3) 10Reedy: Updating symfony/* from v4.4.4 to v4.4.5 [vendor] - 10https://gerrit.wikimedia.org/r/575799 [21:39:10] (03PS1) 10Umherirrender: Use MediaWikiServices::getRepoGroup in file related classes [core] - 10https://gerrit.wikimedia.org/r/578134 [21:44:07] (03PS2) 10Umherirrender: Use MediaWikiServices::getRepoGroup in api related classes [core] - 10https://gerrit.wikimedia.org/r/578132 [21:46:02] (03PS2) 10Umherirrender: Use MediaWikiServices::getRepoGroup in file related classes [core] - 10https://gerrit.wikimedia.org/r/578134 [21:47:02] (03PS2) 10Umherirrender: Use MediaWikiServices::getRepoGroup in special page related classes [core] - 10https://gerrit.wikimedia.org/r/578133 [21:47:40] (03PS1) 10Umherirrender: Use MediaWikiServices::getRepoGroup [core] - 10https://gerrit.wikimedia.org/r/578135 [21:51:33] (03PS2) 10Umherirrender: Use MediaWikiServices::getRepoGroup [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/578076 [21:52:27] (03CR) 10Umherirrender: [C: 04-2] "Can replace wfLocalFile / wfFindFile as well" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/578078 (owner: 10Umherirrender) [21:52:35] (03CR) 10Umherirrender: [C: 04-2] "Can replace wfLocalFile / wfFindFile as well" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/578085 (owner: 10Umherirrender) [21:55:53] (03CR) 10Umherirrender: [C: 03+2] "Resubmit" [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/578125 (owner: 10Libraryupgrader) [21:58:07] 10IPUtils, 10Patch-For-Review, 10phan: Enable phan and seccheck on IPUtils - https://phabricator.wikimedia.org/T247210 (10Reedy) Current issues still to fix: ` 21:22:06 src/IPUtils.php:242 PhanTypeMismatchArgumentNullableInternal Argument 2 ($subject) is ?string but \preg_match() takes string (expected type... [22:09:06] (03CR) 10Krinkle: [C: 03+2] Updating symfony/* from v4.4.4 to v4.4.5 [vendor] - 10https://gerrit.wikimedia.org/r/575799 (owner: 10Reedy) [22:09:38] (03CR) 10Umherirrender: [C: 03+1] build: Updating acorn to 7.1.1 [extensions/EmailCapture] - 10https://gerrit.wikimedia.org/r/578137 (owner: 10Libraryupgrader) [22:10:20] (03CR) 10Krinkle: [C: 03+2] Make tests for IPUtils::isInRanges() test IPUtils::isInRanges() [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578131 (owner: 10Reedy) [22:10:46] (03Merged) 10jenkins-bot: Make tests for IPUtils::isInRanges() test IPUtils::isInRanges() [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578131 (owner: 10Reedy) [22:13:13] (03CR) 10Krinkle: [C: 03+2] Make CentralAuth schema patches consistent to canonical file [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/574189 (https://phabricator.wikimedia.org/T245924) (owner: 10Reedy) [22:13:35] 10IPUtils, 10Test-Coverage: IPUtils test coverage is poor - https://phabricator.wikimedia.org/T247156 (10Reedy) {F31671601 size=full} to {F31671621 size=full} to {F31671824 size=full} [22:15:57] (03CR) 10Umherirrender: [C: 03+2] build: Updating acorn to 7.1.1 [extensions/EmailCapture] - 10https://gerrit.wikimedia.org/r/578137 (owner: 10Libraryupgrader) [22:20:32] (03CR) 10Umherirrender: [C: 03+2] specialpage: Avoid deprecated usage of Title::newFromTitleValue() [core] - 10https://gerrit.wikimedia.org/r/578063 (owner: 10D3r1ck01) [22:22:42] (03Merged) 10jenkins-bot: Updating symfony/* from v4.4.4 to v4.4.5 [vendor] - 10https://gerrit.wikimedia.org/r/575799 (owner: 10Reedy) [22:22:44] (03Merged) 10jenkins-bot: Make CentralAuth schema patches consistent to canonical file [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/574189 (https://phabricator.wikimedia.org/T245924) (owner: 10Reedy) [22:23:52] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Tracking-Neverending: Reduce the "banner bump" (tracking) - https://phabricator.wikimedia.org/T109634 (10Wladek92) similar skip detected as long as banner is open => https://www.mediawiki.org/wiki/Topic:Vi6zfn6099atwqp6 which disappears once ban... [22:24:06] 10Design, 10TCB-Team, 10Two-Column-Edit-Conflict-Merge, 10WMDE-Design: Permanent or long-term storage of edit conflict text - https://phabricator.wikimedia.org/T245523 (10awight) This MediaWiki user script can replay conflicts, and will provide action buttons on any page with a title like, `Conflict:User:A... [22:25:25] (03PS1) 10Reedy: Add test for IPUtils::canonicalize() for IPv6 loopback [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578143 [22:25:45] (03CR) 10jerkins-bot: [V: 04-1] Add test for IPUtils::canonicalize() for IPv6 loopback [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578143 (owner: 10Reedy) [22:27:12] (03PS2) 10Reedy: Add test for IPUtils::canonicalize() for IPv6 loopback [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578143 [22:27:32] (03CR) 10jerkins-bot: [V: 04-1] Add test for IPUtils::canonicalize() for IPv6 loopback [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578143 (owner: 10Reedy) [22:30:42] (03CR) 10Umherirrender: Hard-deprecate Title::__construct for foreign callers (033 comments) [core] - 10https://gerrit.wikimedia.org/r/577770 (owner: 10Daimona Eaytoy) [22:33:30] (03Merged) 10jenkins-bot: specialpage: Avoid deprecated usage of Title::newFromTitleValue() [core] - 10https://gerrit.wikimedia.org/r/578063 (owner: 10D3r1ck01) [22:34:53] (03Merged) 10jenkins-bot: specials: Use self::getTitleFor() as method is declared static [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/578065 (owner: 10D3r1ck01) [22:37:14] (03PS3) 10Reedy: Add test for IPUtils::canonicalize() for IPv6 loopback [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578143 [22:37:18] (03CR) 10Reedy: Add test for IPUtils::canonicalize() for IPv6 loopback (031 comment) [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578143 (owner: 10Reedy) [22:37:35] (03CR) 10jerkins-bot: [V: 04-1] Add test for IPUtils::canonicalize() for IPv6 loopback [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578143 (owner: 10Reedy) [22:38:56] (03PS4) 10Reedy: Add test for IPUtils::canonicalize() for IPv6 loopback [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578143 [22:40:48] (03PS5) 10Reedy: Add test for IPUtils::canonicalize() for IPv6 loopback [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578143 [22:42:49] (03CR) 10Reedy: Add test for IPUtils::canonicalize() for IPv6 loopback (031 comment) [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578143 (owner: 10Reedy) [22:43:10] So many edge cases [22:45:52] 10MediaWiki-extensions-Page_Forms: Page Forms: Checkboxes labels in multiple-instance templates are not clickable - https://phabricator.wikimedia.org/T217516 (10AdhamKhatean) Hello, @Yaron_Koren does this issue still exist? If yes, I have been trying to experience this issue from what I learned from your discuss... [22:46:18] 10Outreach-Programs-Projects, 10Outreachy (Round 20): Productionize Wikidata-based Topic Model on ORES - https://phabricator.wikimedia.org/T245848 (10Tushcathy) Hello everyone, my name is Catherine Tushabe and Electrical Engineer from Uganda. I am currently pursuing post-graduate Diploma in Data science and I... [22:46:20] (03PS1) 10Reedy: Combine hexToOctet and hexToQuad tests to cover formatHex [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578148 [22:48:12] (03CR) 10Krinkle: Add test for IPUtils::canonicalize() for IPv6 loopback (031 comment) [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578143 (owner: 10Reedy) [22:48:25] (03PS2) 10Reedy: Combine hexToOctet and hexToQuad tests to cover formatHex [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578148 [22:49:25] (03CR) 10Reedy: Add test for IPUtils::canonicalize() for IPv6 loopback (031 comment) [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578143 (owner: 10Reedy) [22:50:09] (03PS1) 10Reedy: Add isValidIPv4 and isValidIPv6 [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578149 [22:53:02] (03PS2) 10Reedy: Add isValidIPv4 and isValidIPv6 [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578149 [22:53:17] (03PS3) 10Reedy: Add isValidIPv4 and isValidIPv6 [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578149 [22:53:21] (03CR) 10jerkins-bot: [V: 04-1] Add isValidIPv4 and isValidIPv6 [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578149 (owner: 10Reedy) [22:55:18] (03CR) 10Reedy: Add test for IPUtils::canonicalize() for IPv6 loopback (031 comment) [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578143 (owner: 10Reedy) [22:55:23] 10MediaWiki-extensions-Nuke, 10UI-Standardization, 10User-Ladsgroup: Migrate Special:Nuke to OOUI - https://phabricator.wikimedia.org/T153988 (10Ladsgroup) a:05Ladsgroup→03None >>! In T153988#5950797, @DannyS712 wrote: > @Ladsgroup are you still working on this? Nope. [22:55:30] (03PS6) 10Reedy: Add test for IPUtils::canonicalize() for IPv6 loopback [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578143 [22:55:58] (03PS7) 10Reedy: Add test for IPUtils::canonicalize() for IPv6 loopback [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/578143 [23:02:47] 10MediaWiki-extensions-CentralAuth, 10MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), 10Patch-For-Review: CentrlAuth db_patches inconsistent to centralauth.sql - https://phabricator.wikimedia.org/T245924 (10Reedy) 05Open→03Resolved a:03Reedy [23:14:54] 10MediaWiki-General, 10MW-1.35-notes (1.35.0-wmf.23; 2020-03-10), 10MW-1.35-release, 10PHP 7.4 support, and 2 others: implode() the wrong way round in lightncandy - https://phabricator.wikimedia.org/T242980 (10Reedy) 05Open→03Resolved a:03Reedy [23:14:58] 10MediaWiki-General, 10MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), 10MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), 10MW-1.35-release, and 3 others: Make MediaWiki core compatible with PHP 7.4 - https://phabricator.wikimedia.org/T233012 (10Reedy) [23:15:03] 10MediaWiki-General, 10Continuous-Integration-Config, 10PHP 7.4 support: Re-enable PHP74 in gate - https://phabricator.wikimedia.org/T247214 (10Reedy) [23:16:03] 10MediaWiki-General, 10Continuous-Integration-Config, 10PHP 7.4 support, 10Patch-For-Review: Re-enable PHP74 in gate for skin-quibble - https://phabricator.wikimedia.org/T247214 (10Reedy) [23:22:15] 10MediaWiki-extensions-General, 10IPUtils, 10Technical-Debt, 10good first task: Replace IP class with IPUtils (General) - https://phabricator.wikimedia.org/T247155 (10Reedy) [23:25:48] 10MediaWiki-General, 10MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), 10MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), 10MW-1.35-release, and 3 others: Make MediaWiki core compatible with PHP 7.4 - https://phabricator.wikimedia.org/T233012 (10Reedy) [23:25:51] 10MediaWiki-General, 10Continuous-Integration-Config, 10PHP 7.4 support, 10Patch-For-Review: Re-enable PHP74 in gate for skin-quibble - https://phabricator.wikimedia.org/T247214 (10Reedy) [23:32:51] 10MediaWiki-Maintenance-scripts: Incorrect output of recountCategories.php - https://phabricator.wikimedia.org/T247215 (10Reedy) [23:33:40] (03PS1) 10Reedy: Fix output of RecountCategories::doWork() [core] - 10https://gerrit.wikimedia.org/r/578151 (https://phabricator.wikimedia.org/T247215) [23:35:45] (03PS1) 10Reedy: Make RecountCategories use >= not > [core] - 10https://gerrit.wikimedia.org/r/578152 [23:37:09] 10MediaWiki-Maintenance-scripts, 10Patch-For-Review: Incorrect output of recountCategories.php - https://phabricator.wikimedia.org/T247215 (10Reedy) [23:37:47] (03PS2) 10Reedy: Fix output of RecountCategories::doWork() [core] - 10https://gerrit.wikimedia.org/r/578151 (https://phabricator.wikimedia.org/T247215) [23:42:03] 10MediaWiki-Categories, 10Commons: Wrong subcategory counts in Commons - https://phabricator.wikimedia.org/T247187 (10Reedy) I've fixed those two specific cases by running `populateCategories.php`... AFAIK, drift is known to occur, or has in the past. This may be fixed now though I don't know if we need to s... [23:44:10] 10MediaWiki-Maintenance-scripts, 10TestMe: populateCategory output is confusing in read-only mode - https://phabricator.wikimedia.org/T35993 (10Reedy) 05Open→03Stalled Is this still an issue? The script doesn't output "Category population complete." anywhere Also, maintenance scripts generally have no `$... [23:45:13] (03PS2) 10Reedy: Make RecountCategories use >= not > [core] - 10https://gerrit.wikimedia.org/r/578152