[00:01:45] (03CR) 10jerkins-bot: [V: 04-1] WIP: Build opt-out link for logged in, vector latest users [skins/Vector] - 10https://gerrit.wikimedia.org/r/575328 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [00:02:43] (03CR) 10jerkins-bot: [V: 04-1] WIP: Isolate Vector Styles to their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575609 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [00:02:48] 10Wikipedia-Android-App-Backlog: Make the warning message on the suicide methods page appear in the android app - https://phabricator.wikimedia.org/T245322 (10bearND) > As per @JMinor for ios version: > - This is a hatnote that appears on this and other pages, but doesn't appear to be labeled clearly in the mark... [00:03:02] 10Wikipedia-Android-App-Backlog: Make the warning message on the suicide methods page appear in the android app - https://phabricator.wikimedia.org/T245322 (10bearND) > Not sure how universal this will be language-wise, would be good to know if/what other hatnotes or templates might exist outside english The la... [00:03:35] 10Desktop Improvements, 10MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): Update PrefUpdate schema to include edit count - https://phabricator.wikimedia.org/T243071 (10Niedzielski) @Nuria got to the bottom of things (and thanks for the tip @Edtad... [00:04:08] (03CR) 10jerkins-bot: [V: 04-1] WIP: Rename Storybook Files to Reflect Their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575639 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [00:04:20] (03PS1) 10DannyS712: Replace uses of old deprecated SpecialPageFactory [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/575651 (https://phabricator.wikimedia.org/T246142) [00:04:59] (03PS2) 10DannyS712: Replace uses of old deprecated SpecialPageFactory [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/575651 (https://phabricator.wikimedia.org/T246142) [00:05:34] (03PS1) 10DannyS712: Replace uses of old deprecated SpecialPageFactory [extensions/BlueSpiceRating] - 10https://gerrit.wikimedia.org/r/575652 (https://phabricator.wikimedia.org/T246142) [00:06:47] (03PS2) 10DannyS712: Replace uses of old deprecated SpecialPageFactory [extensions/BlueSpiceRating] - 10https://gerrit.wikimedia.org/r/575652 (https://phabricator.wikimedia.org/T246142) [00:07:17] (03PS1) 10DannyS712: Replace uses of old deprecated SpecialPageFactory [extensions/BlueSpiceWikiExplorer] - 10https://gerrit.wikimedia.org/r/575653 (https://phabricator.wikimedia.org/T246142) [00:08:23] (03PS2) 10DannyS712: Replace uses of old deprecated SpecialPageFactory [extensions/BlueSpiceWikiExplorer] - 10https://gerrit.wikimedia.org/r/575653 (https://phabricator.wikimedia.org/T246142) [00:08:54] (03PS1) 10DannyS712: Replace uses of old deprecated SpecialPageFactory [extensions/BlueSpiceBookshelfUI] - 10https://gerrit.wikimedia.org/r/575654 (https://phabricator.wikimedia.org/T246142) [00:09:33] (03PS2) 10DannyS712: Replace uses of old deprecated SpecialPageFactory [extensions/BlueSpiceBookshelfUI] - 10https://gerrit.wikimedia.org/r/575654 (https://phabricator.wikimedia.org/T246142) [00:09:45] (03CR) 10Bartosz Dziewoński: [C: 04-1] Menu items added via addPortletLinks should look like other menu items (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/571111 (https://phabricator.wikimedia.org/T236711) (owner: 10Jdlrobson) [00:10:00] (03CR) 10jerkins-bot: [V: 04-1] Replace uses of old deprecated SpecialPageFactory [extensions/BlueSpiceRating] - 10https://gerrit.wikimedia.org/r/575652 (https://phabricator.wikimedia.org/T246142) (owner: 10DannyS712) [00:10:02] 10Wikipedia-Android-App-Backlog: Use regular urls instead of mobile url while sharing links - https://phabricator.wikimedia.org/T246510 (10Sharvaniharan) [00:10:23] (03CR) 10jerkins-bot: [V: 04-1] Replace uses of old deprecated SpecialPageFactory [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/575651 (https://phabricator.wikimedia.org/T246142) (owner: 10DannyS712) [00:10:58] (03CR) 10DannyS712: "> Main test build failed." [extensions/BlueSpiceRating] - 10https://gerrit.wikimedia.org/r/575652 (https://phabricator.wikimedia.org/T246142) (owner: 10DannyS712) [00:11:14] (03CR) 10DannyS712: "> Main test build failed." [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/575651 (https://phabricator.wikimedia.org/T246142) (owner: 10DannyS712) [00:11:31] (03PS10) 10Jdlrobson: Menu items added via addPortletLinks should look like other menu items [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/571111 (https://phabricator.wikimedia.org/T236711) [00:11:54] (03CR) 10jerkins-bot: [V: 04-1] Replace uses of old deprecated SpecialPageFactory [extensions/BlueSpiceWikiExplorer] - 10https://gerrit.wikimedia.org/r/575653 (https://phabricator.wikimedia.org/T246142) (owner: 10DannyS712) [00:12:02] (03PS1) 10DannyS712: Replace uses of old deprecated SpecialPageFactory [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/575655 (https://phabricator.wikimedia.org/T246142) [00:12:39] (03CR) 10Jdlrobson: Menu items added via addPortletLinks should look like other menu items (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/571111 (https://phabricator.wikimedia.org/T236711) (owner: 10Jdlrobson) [00:12:54] (03CR) 10jerkins-bot: [V: 04-1] Replace uses of old deprecated SpecialPageFactory [extensions/BlueSpiceBookshelfUI] - 10https://gerrit.wikimedia.org/r/575654 (https://phabricator.wikimedia.org/T246142) (owner: 10DannyS712) [00:13:21] (03PS2) 10DannyS712: Replace uses of old deprecated SpecialPageFactory [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/575655 (https://phabricator.wikimedia.org/T246142) [00:15:05] 10MediaWiki-General, 10MediaWiki-extensions-AdminLinks, 10MediaWiki-extensions-BibManager, 10MediaWiki-extensions-Cargo, and 12 others: Remove remaining calls to old SpecialPageFactory methods - https://phabricator.wikimedia.org/T246142 (10DannyS712) >>! In T246142#5928511, @gerritbot wrote: > Change 57565... [00:16:32] (03CR) 10jerkins-bot: [V: 04-1] Replace uses of old deprecated SpecialPageFactory [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/575655 (https://phabricator.wikimedia.org/T246142) (owner: 10DannyS712) [00:16:52] (03CR) 10Tchanders: "> Patch Set 1:" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/575384 (owner: 10Tchanders) [00:17:58] (03CR) 10Bartosz Dziewoński: "recheck" [skins/Vector] - 10https://gerrit.wikimedia.org/r/575102 (https://phabricator.wikimedia.org/T246162) (owner: 10Jdlrobson) [00:18:30] (03PS7) 10Jdlrobson: Generalise skin preferences so it can be used by Monobook [core] - 10https://gerrit.wikimedia.org/r/575103 (https://phabricator.wikimedia.org/T246296) [00:18:44] 10MediaWiki-extensions-Linter: Lint error counts on "Page information" page do not update, even with null edit - https://phabricator.wikimedia.org/T246403 (10Jonesey95) I don't think so. For example, https://en.wikipedia.org/wiki/Brian_Willoughby has the same type of error (unclosed italics). LintHint and the Pa... [00:20:39] (03CR) 10DannyS712: "> Main test build failed." [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/575655 (https://phabricator.wikimedia.org/T246142) (owner: 10DannyS712) [00:22:06] (03PS1) 10DannyS712: Hard deprecate Revision::loadFromTitle [core] - 10https://gerrit.wikimedia.org/r/575656 (https://phabricator.wikimedia.org/T246284) [00:27:38] 10Security-Team, 10TechCom-RFC: RFC: Adopt a modern JavaScript framework for use with MediaWiki - https://phabricator.wikimedia.org/T241180 (10Ladsgroup) I think mentioning two points are necessary here. First, regarding breaking changes, I have been maintaining several gadgets in my home wiki at my volunteer... [00:31:03] (03PS2) 10DannyS712: Hard deprecate Revision::loadFromTitle [core] - 10https://gerrit.wikimedia.org/r/575656 (https://phabricator.wikimedia.org/T246284) [00:35:59] (03PS6) 10Bartosz Dziewoński: Make sure Vector skin preferences always follows skin [skins/Vector] - 10https://gerrit.wikimedia.org/r/575102 (https://phabricator.wikimedia.org/T246162) (owner: 10Jdlrobson) [00:36:02] (03PS1) 10DannyS712: Hard deprecate Revision::countByPageId [core] - 10https://gerrit.wikimedia.org/r/575657 (https://phabricator.wikimedia.org/T246284) [00:38:12] (03PS2) 10DannyS712: Hard deprecate Revision::countByPageId [core] - 10https://gerrit.wikimedia.org/r/575657 (https://phabricator.wikimedia.org/T246284) [00:38:55] (03PS1) 10DannyS712: Hard deprecate Revision::countByTitle [core] - 10https://gerrit.wikimedia.org/r/575658 (https://phabricator.wikimedia.org/T246284) [00:38:59] (03CR) 10Gergő Tisza: [C: 03+2] OAuth: Add navigation links to special pages (part two) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/573394 (https://phabricator.wikimedia.org/T241869) (owner: 10Ammarpad) [00:39:45] (03PS2) 10DannyS712: Hard deprecate Revision::countByTitle [core] - 10https://gerrit.wikimedia.org/r/575658 (https://phabricator.wikimedia.org/T246284) [00:40:57] (03CR) 10Gergő Tisza: "Matěj, sorry, can you update this one more time now that https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OAuth/+/573394 has been mer" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/534951 (https://phabricator.wikimedia.org/T149346) (owner: 10Matěj Suchánek) [00:42:10] 10MediaWiki-Revision-backend, 10Core Platform Team, 10Epic, 10Patch-For-Review, and 2 others: Hard deprecate the Revision class - https://phabricator.wikimedia.org/T246284 (10DannyS712) Also having no callers outside of core: * ::newKnownContent - https://codesearch.wmflabs.org/search/?q=Revision%3A%3AnewK... [00:42:38] 10MediaWiki-General: Add accessibility label to menu widget - https://phabricator.wikimedia.org/T246513 (10Akinwale-microsoft) [00:43:46] (03Merged) 10jenkins-bot: OAuth: Add navigation links to special pages (part two) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/573394 (https://phabricator.wikimedia.org/T241869) (owner: 10Ammarpad) [00:44:05] (03CR) 10jerkins-bot: [V: 04-1] Hard deprecate Revision::loadFromTitle [core] - 10https://gerrit.wikimedia.org/r/575656 (https://phabricator.wikimedia.org/T246284) (owner: 10DannyS712) [00:44:15] (03PS3) 10DannyS712: Hard deprecate Revision::loadFromTitle [core] - 10https://gerrit.wikimedia.org/r/575656 (https://phabricator.wikimedia.org/T246284) [00:45:16] 10MediaWiki-extensions-OAuth, 10MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), 10good first task: Display convenient links from OAuth special pages to each other (where appropriate) - https://phabricator.wikimedia.org/T241869 (10DannyS712) [00:45:23] 10Accessibility, 10MediaWiki-General: Add accessibility label to menu widget - https://phabricator.wikimedia.org/T246513 (10DannyS712) [00:47:19] 10MediaWiki-extensions-OAuth, 10MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), 10good first task: Display convenient links from OAuth special pages to each other (where appropriate) - https://phabricator.wikimedia.org/T241869 (10Tgr) [00:47:55] 10Wikipedia-Android-App-Backlog: No apps to open external links - https://phabricator.wikimedia.org/T246514 (10Sharvaniharan) [00:49:38] (03PS12) 10Aron Manning: Consistently follow WikimediaUI Base's CSS variable naming convention for font variable names. Document the fonts. [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/570619 (https://phabricator.wikimedia.org/T245136) [00:49:38] 10MediaWiki-extensions-OAuth, 10MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), 10good first task: Display convenient links from OAuth special pages to each other (where appropriate) - https://phabricator.wikimedia.org/T241869 (10Tgr) Looks great, thanks @Florian and @Ammarpad! One small fix is left: > Another c... [00:52:03] (03CR) 10Bartosz Dziewoński: [C: 03+2] Make sure Vector skin preferences always follows skin [skins/Vector] - 10https://gerrit.wikimedia.org/r/575102 (https://phabricator.wikimedia.org/T246162) (owner: 10Jdlrobson) [00:52:07] (03CR) 10Bartosz Dziewoński: [C: 03+2] Reveal Monobook "enable responsive design" option when skin selected [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/575099 (https://phabricator.wikimedia.org/T246296) (owner: 10Jdlrobson) [00:52:10] (03CR) 10Bartosz Dziewoński: [C: 03+2] Generalise skin preferences so it can be used by Monobook [core] - 10https://gerrit.wikimedia.org/r/575103 (https://phabricator.wikimedia.org/T246296) (owner: 10Jdlrobson) [00:54:05] (03CR) 10jerkins-bot: [V: 04-1] Hard deprecate Revision::countByPageId [core] - 10https://gerrit.wikimedia.org/r/575657 (https://phabricator.wikimedia.org/T246284) (owner: 10DannyS712) [00:55:52] (03CR) 10jerkins-bot: [V: 04-1] Hard deprecate Revision::countByTitle [core] - 10https://gerrit.wikimedia.org/r/575658 (https://phabricator.wikimedia.org/T246284) (owner: 10DannyS712) [00:57:57] (03CR) 10jerkins-bot: [V: 04-1] Hard deprecate Revision::loadFromTitle [core] - 10https://gerrit.wikimedia.org/r/575656 (https://phabricator.wikimedia.org/T246284) (owner: 10DannyS712) [00:59:13] (03PS6) 10Nray: Isolate Vector Styles to their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575609 (https://phabricator.wikimedia.org/T243281) [00:59:16] (03PS3) 10Nray: Rename Storybook Files to Reflect Their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575639 (https://phabricator.wikimedia.org/T243281) [00:59:20] (03PS9) 10Nray: WIP: Build opt-out link for logged in, vector latest users [skins/Vector] - 10https://gerrit.wikimedia.org/r/575328 (https://phabricator.wikimedia.org/T243281) [01:03:19] (03CR) 10jerkins-bot: [V: 04-1] Isolate Vector Styles to their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575609 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [01:04:02] 10Technical blog, 10Developer-Advocacy (Jan-Mar 2020), 10Documentation: Confirm additional production domains - https://phabricator.wikimedia.org/T246385 (10srodlund) 05Open→03Resolved Resolved. There will be only one production domain: Techblog.wikimedia.org [01:04:05] 10Developer-Advocacy (Jan-Mar 2020), 10Documentation: Set up Tech blog to share stories from the Wikimedia Technical community - https://phabricator.wikimedia.org/T242619 (10srodlund) [01:04:21] (03CR) 10Gergő Tisza: [C: 04-1] OAuth: Add reason field to consumer proposal form (033 comments) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/573876 (https://phabricator.wikimedia.org/T245291) (owner: 10Ammarpad) [01:04:29] (03CR) 10jerkins-bot: [V: 04-1] Rename Storybook Files to Reflect Their Respective Component [skins/Vector] - 10https://gerrit.wikimedia.org/r/575639 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [01:05:34] (03CR) 10jerkins-bot: [V: 04-1] WIP: Build opt-out link for logged in, vector latest users [skins/Vector] - 10https://gerrit.wikimedia.org/r/575328 (https://phabricator.wikimedia.org/T243281) (owner: 10Nray) [01:07:00] (03Merged) 10jenkins-bot: Generalise skin preferences so it can be used by Monobook [core] - 10https://gerrit.wikimedia.org/r/575103 (https://phabricator.wikimedia.org/T246296) (owner: 10Jdlrobson) [01:07:03] (03Merged) 10jenkins-bot: Reveal Monobook "enable responsive design" option when skin selected [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/575099 (https://phabricator.wikimedia.org/T246296) (owner: 10Jdlrobson) [01:08:22] (03Merged) 10jenkins-bot: Make sure Vector skin preferences always follows skin [skins/Vector] - 10https://gerrit.wikimedia.org/r/575102 (https://phabricator.wikimedia.org/T246162) (owner: 10Jdlrobson) [01:10:18] 10MediaWiki-User-preferences, 10Desktop Improvements, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): Put skin preference in the correct place - https://phabricator.wikimedia.org/T246162 (10matmarex) > This spike seeks to answer firstly: for all wikis in production, how do Vector skin pre... [01:11:41] 10Desktop Improvements, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): Build opt-out link for logged-in users with new vector on - https://phabricator.wikimedia.org/T243281 (10nray) I'm moving this to code review because 2 out my 3 patches are ready for review: I have three patches relate... [01:11:52] 10MonoBook: Responsive monobook preference should be listed under a section "Monobook preferences" a la Vector - https://phabricator.wikimedia.org/T246296 (10matmarex) 05Open→03Resolved a:03Jdlrobson [01:12:01] 10Wikipedia-Android-App-Backlog: Voice recognition not available - https://phabricator.wikimedia.org/T246515 (10Sharvaniharan) [01:12:06] 10MediaWiki-User-preferences, 10Desktop Improvements, 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): Put skin preference in the correct place - https://phabricator.wikimedia.org/T246162 (10matmarex) [01:12:25] 10Wikipedia-Android-App-Backlog: Voice recognition not available on Google Slate - https://phabricator.wikimedia.org/T246515 (10Sharvaniharan) [01:14:08] (03CR) 10Ppchelko: [C: 03+2] Replace uses of old deprecated SpecialPageFactory in MW 1.32+ [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/575617 (https://phabricator.wikimedia.org/T246142) (owner: 10DannyS712) [01:15:15] 10Wikipedia-Android-App-Backlog: No apps to open external links - https://phabricator.wikimedia.org/T246514 (10Sharvaniharan) [01:17:08] (03CR) 10Ppchelko: [C: 03+2] Replace uses of old deprecated SpecialPageFactory in MW 1.32+ [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/575643 (https://phabricator.wikimedia.org/T246142) (owner: 10DannyS712) [01:17:10] (03Merged) 10jenkins-bot: Replace uses of old deprecated SpecialPageFactory in MW 1.32+ [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/575617 (https://phabricator.wikimedia.org/T246142) (owner: 10DannyS712) [01:17:12] (03PS3) 10Akinwale-microsoft: Fix: Adding accessible label to namespace and tag buttons [core] - 10https://gerrit.wikimedia.org/r/575618 (https://phabricator.wikimedia.org/T246179) [01:19:04] (03PS4) 10Akinwale-microsoft: Fix: Adding accessible label to namespace and tag buttons [core] - 10https://gerrit.wikimedia.org/r/575618 (https://phabricator.wikimedia.org/T246179) [01:19:54] (03Merged) 10jenkins-bot: Replace uses of old deprecated SpecialPageFactory in MW 1.32+ [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/575643 (https://phabricator.wikimedia.org/T246142) (owner: 10DannyS712) [01:19:55] 10MediaWiki-General, 10DiscussionTools, 10VisualEditor, 10Editing-team (Q3 2019-2020 Kanban Board), and 3 others: Upstream API error handling from VisualEditor to MediaWiki, use it in DiscussionTools - https://phabricator.wikimedia.org/T240519 (10ppelberg) 05Open→03Resolved [01:20:45] 10MediaWiki-General, 10User-DannyS712: Audit all userCan calls - https://phabricator.wikimedia.org/T246414 (10DannyS712) Checking key: T - Title R - Revision AF - ArchivedFile OL - OldLocalFile PM - PermissionManager All repositories that need to be checked: [] mediawiki / core: ? need to trace [] extensions... [01:23:02] (03PS4) 10DannyS712: Hard deprecate Revision::loadFromTitle [core] - 10https://gerrit.wikimedia.org/r/575656 (https://phabricator.wikimedia.org/T246284) [01:23:38] 10Wikipedia-Android-App-Backlog: Error loading page on Samsung Tablet - https://phabricator.wikimedia.org/T246516 (10Sharvaniharan) [01:23:59] 10MediaWiki-extensions-OAuth, 10Technical-Debt: Replace OAuth.php with something we can bring in via composer - https://phabricator.wikimedia.org/T217515 (10Tgr) >>! In T217515#4996636, @Tgr wrote: > A couple people have made a GitHub fork and restlyed the code to look more modern. I think the nicest was https... [01:24:25] (03CR) 10Gergő Tisza: "Seems somewhat pointless since the classes that are being tested are in one file as well. What would be more useful (but is way more work)" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/571049 (owner: 10Umherirrender) [01:26:52] (03CR) 10Gergő Tisza: "Hm, I guess this file is not really related to testing the library as such..." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/571049 (owner: 10Umherirrender) [01:27:50] 10Wikipedia-Android-App-Backlog: Error in article content - https://phabricator.wikimedia.org/T246517 (10Sharvaniharan) [01:28:42] 10Wikipedia-Android-App-Backlog: Error loading page on Samsung Tablet - https://phabricator.wikimedia.org/T246516 (10Dbrant) 05Open→03Declined There is no useful information except a screenshot that says "error". [01:28:45] (03CR) 10Gergő Tisza: [C: 03+2] Move TestOAuthSignatureMethod_RSA_SHA1 to own class file [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/571049 (owner: 10Umherirrender) [01:29:10] (03CR) 10Gergő Tisza: [C: 04-2] Move TestOAuthSignatureMethod_RSA_SHA1 to own class file [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/571049 (owner: 10Umherirrender) [01:30:27] 10Android-app-Bugs, 10Android-app-feature-mobile-html, 10Wikipedia-Android-App-Backlog, 10wikimedia-page-library: [BUG] Article section heading display issues - https://phabricator.wikimedia.org/T235614 (10Dbrant) [01:30:29] 10Wikipedia-Android-App-Backlog: Error in article content - https://phabricator.wikimedia.org/T246517 (10Dbrant) [01:31:23] (03CR) 10Aron Manning: "Hello, Bartosz!" [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/570174 (owner: 10Aron Manning) [01:31:53] (03CR) 10Ppchelko: "> Patch Set 2:" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/575655 (https://phabricator.wikimedia.org/T246142) (owner: 10DannyS712) [01:33:25] (03CR) 10Gergő Tisza: [C: 03+1] "Looks good to go." [vendor] - 10https://gerrit.wikimedia.org/r/575633 (owner: 10Reedy) [01:33:57] (03CR) 10Ppchelko: [C: 03+2] Replace uses of old deprecated SpecialPageFactory [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/575644 (https://phabricator.wikimedia.org/T246142) (owner: 10DannyS712) [01:34:09] (03CR) 10Aron Manning: "Hello, Bartosz!" [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/570619 (https://phabricator.wikimedia.org/T245136) (owner: 10Aron Manning) [01:34:36] (03CR) 10Gergő Tisza: [C: 03+2] Updating firebase/php-jwt (v5.0.0 => v5.1.0) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/575634 (owner: 10Reedy) [01:34:52] (03CR) 10Gergő Tisza: [C: 03+2] Updating firebase/php-jwt (v5.0.0 => v5.1.0) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/575635 (owner: 10Reedy) [01:34:58] 10GapFinder, 10Research, 10Patch-For-Review: Extend GapFinder to support WikiGap - https://phabricator.wikimedia.org/T244587 (10Isaac) Ok, @bmansurov thanks for your patience. A final request was put in to add some more descriptive text for the campaign. I know this would require changing templating for the... [01:35:10] (03CR) 10Gergő Tisza: [C: 03+2] Updating firebase/php-jwt (v5.0.0 => v5.1.0) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/575636 (owner: 10Reedy) [01:36:11] (03PS6) 10Aron Manning: [TEST] Font update: use Lato (sans) for the content. Load the necessary fonts from the wmflabs fontcdn. [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/572456 (https://phabricator.wikimedia.org/T243508) [01:36:49] (03Merged) 10jenkins-bot: Replace uses of old deprecated SpecialPageFactory [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/575644 (https://phabricator.wikimedia.org/T246142) (owner: 10DannyS712) [01:37:29] (03CR) 10Ppchelko: [C: 03+2] Replace uses of old deprecated SpecialPageFactory in MW 1.32+ [extensions/URNames] - 10https://gerrit.wikimedia.org/r/575649 (https://phabricator.wikimedia.org/T246142) (owner: 10DannyS712) [01:40:16] (03Merged) 10jenkins-bot: Replace uses of old deprecated SpecialPageFactory in MW 1.32+ [extensions/URNames] - 10https://gerrit.wikimedia.org/r/575649 (https://phabricator.wikimedia.org/T246142) (owner: 10DannyS712) [01:45:13] (03CR) 10Gergő Tisza: [C: 04-1] "Should be under maintenance or test, not the backend code. Or maybe just use an anonymous class." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/571049 (owner: 10Umherirrender) [01:45:57] (03CR) 10Bartosz Dziewoński: [C: 03+2] mediawiki.util: addPortletLink fires hook for Minerva UX support [core] - 10https://gerrit.wikimedia.org/r/545636 (https://phabricator.wikimedia.org/T236711) (owner: 10Jdlrobson) [01:45:59] (03CR) 10Bartosz Dziewoński: [C: 03+2] Menu items added via addPortletLinks should look like other menu items [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/571111 (https://phabricator.wikimedia.org/T236711) (owner: 10Jdlrobson) [01:47:30] (03CR) 10Ppchelko: [C: 04-1] "1 functional issue, one request for a little improvement inlined. LGTM otherwise." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/575656 (https://phabricator.wikimedia.org/T246284) (owner: 10DannyS712) [01:55:14] (03PS5) 10DannyS712: Hard deprecate Revision::loadFromTitle [core] - 10https://gerrit.wikimedia.org/r/575656 (https://phabricator.wikimedia.org/T246284) [01:55:22] (03CR) 10DannyS712: Hard deprecate Revision::loadFromTitle (032 comments) [core] - 10https://gerrit.wikimedia.org/r/575656 (https://phabricator.wikimedia.org/T246284) (owner: 10DannyS712) [01:56:35] (03CR) 10DannyS712: "> > Patch Set 2:" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/575655 (https://phabricator.wikimedia.org/T246142) (owner: 10DannyS712) [01:57:49] 10MediaWiki-General, 10MediaWiki-extensions-AdminLinks, 10MediaWiki-extensions-BibManager, 10MediaWiki-extensions-Cargo, and 12 others: Remove remaining calls to old SpecialPageFactory methods - https://phabricator.wikimedia.org/T246142 (10DannyS712) [01:57:50] (03CR) 10Ppchelko: "> Patch Set 2:" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/575655 (https://phabricator.wikimedia.org/T246142) (owner: 10DannyS712) [01:59:02] (03CR) 10Ppchelko: [V: 03+2 C: 03+2] Replace uses of old deprecated SpecialPageFactory [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/575655 (https://phabricator.wikimedia.org/T246142) (owner: 10DannyS712) [01:59:13] (03Merged) 10jenkins-bot: mediawiki.util: addPortletLink fires hook for Minerva UX support [core] - 10https://gerrit.wikimedia.org/r/545636 (https://phabricator.wikimedia.org/T236711) (owner: 10Jdlrobson) [01:59:56] (03PS6) 10DannyS712: Hard deprecate Revision::loadFromTitle [core] - 10https://gerrit.wikimedia.org/r/575656 (https://phabricator.wikimedia.org/T246284) [01:59:58] (03CR) 10Ppchelko: "recheck" [extensions/BlueSpiceBookshelfUI] - 10https://gerrit.wikimedia.org/r/575654 (https://phabricator.wikimedia.org/T246142) (owner: 10DannyS712) [02:00:08] 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 2.0): Create a VE-based text input for replying - https://phabricator.wikimedia.org/T234403 (10ppelberg) [02:00:16] (03CR) 10DannyS712: "Recheck" [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/575651 (https://phabricator.wikimedia.org/T246142) (owner: 10DannyS712) [02:00:22] (03CR) 10DannyS712: "Recheck" [extensions/BlueSpiceWikiExplorer] - 10https://gerrit.wikimedia.org/r/575653 (https://phabricator.wikimedia.org/T246142) (owner: 10DannyS712) [02:00:25] (03CR) 10DannyS712: "Recheck" [extensions/BlueSpiceRating] - 10https://gerrit.wikimedia.org/r/575652 (https://phabricator.wikimedia.org/T246142) (owner: 10DannyS712) [02:01:34] (03Merged) 10jenkins-bot: Menu items added via addPortletLinks should look like other menu items [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/571111 (https://phabricator.wikimedia.org/T236711) (owner: 10Jdlrobson) [02:01:44] 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 2.0): Create a VE-based text input for replying - https://phabricator.wikimedia.org/T234403 (10ppelberg) [02:02:04] 10MediaWiki-extensions-General, 10Technical-Debt, 10User-DannyS712: WMF deployed extensions need uses of global $wgUser removed [tracking] - https://phabricator.wikimedia.org/T245959 (10DannyS712) [02:02:07] 10MediaWiki-extensions-CentralNotice, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), 10Technical-Debt, 10User-DannyS712: CentralNotice needs uses of global $wgUser replaced - https://phabricator.wikimedia.org/T241615 (10DannyS712) 05Open→03Resolved [02:04:48] (03PS1) 10DannyS712: Remove use of Title::userCan [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/575659 (https://phabricator.wikimedia.org/T246139) [02:06:52] (03CR) 10Ppchelko: [V: 03+2 C: 03+2] Replace uses of old deprecated SpecialPageFactory [extensions/BlueSpiceWikiExplorer] - 10https://gerrit.wikimedia.org/r/575653 (https://phabricator.wikimedia.org/T246142) (owner: 10DannyS712) [02:08:20] (03PS2) 10DannyS712: Remove use of Title::userCan [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/575659 (https://phabricator.wikimedia.org/T246139) [02:09:03] (03CR) 10DannyS712: "> Change has been successfully merged by Ppchelko" [extensions/BlueSpiceWikiExplorer] - 10https://gerrit.wikimedia.org/r/575653 (https://phabricator.wikimedia.org/T246142) (owner: 10DannyS712) [02:09:05] (03CR) 10Ppchelko: [V: 03+2 C: 03+2] Replace uses of old deprecated SpecialPageFactory [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/575651 (https://phabricator.wikimedia.org/T246142) (owner: 10DannyS712) [02:11:26] (03CR) 10jerkins-bot: [V: 04-1] Remove use of Title::userCan [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/575659 (https://phabricator.wikimedia.org/T246139) (owner: 10DannyS712) [02:13:34] (03CR) 10jerkins-bot: [V: 04-1] Hard deprecate Revision::loadFromTitle [core] - 10https://gerrit.wikimedia.org/r/575656 (https://phabricator.wikimedia.org/T246284) (owner: 10DannyS712) [02:16:44] (03PS7) 10Ppchelko: Hard deprecate Revision::loadFromTitle [core] - 10https://gerrit.wikimedia.org/r/575656 (https://phabricator.wikimedia.org/T246284) (owner: 10DannyS712) [02:23:12] (03CR) 10Gergő Tisza: [C: 03+2] Declare missing dependency on mediawiki.storage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/575240 (https://phabricator.wikimedia.org/T246312) (owner: 10Kosta Harlan) [02:26:57] 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board): Coordinating signature preference validation changes - https://phabricator.wikimedia.org/T244519 (10ppelberg) >>! In T244519#5923965, @matmarex wrote: > @ppelberg Thanks, I made some minor tweaks. [They](https://meta.wikimedia.org/w/index.php?title=New_req... [02:29:42] (03CR) 10jerkins-bot: [V: 04-1] Hard deprecate Revision::loadFromTitle [core] - 10https://gerrit.wikimedia.org/r/575656 (https://phabricator.wikimedia.org/T246284) (owner: 10DannyS712) [02:32:36] (03PS8) 10Ppchelko: Hard deprecate Revision::loadFromTitle [core] - 10https://gerrit.wikimedia.org/r/575656 (https://phabricator.wikimedia.org/T246284) (owner: 10DannyS712) [02:34:58] (03CR) 10jerkins-bot: [V: 04-1] Declare missing dependency on mediawiki.storage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/575240 (https://phabricator.wikimedia.org/T246312) (owner: 10Kosta Harlan) [02:37:55] 10Wikipedia-Android-App-Backlog: [Bug] No apps to open external links - https://phabricator.wikimedia.org/T246514 (10Sharvaniharan) [02:45:42] (03PS9) 10Ppchelko: Hard deprecate Revision::loadFromTitle [core] - 10https://gerrit.wikimedia.org/r/575656 (https://phabricator.wikimedia.org/T246284) (owner: 10DannyS712) [02:46:29] (03PS10) 10Ppchelko: Hard deprecate Revision::loadFromTitle [core] - 10https://gerrit.wikimedia.org/r/575656 (https://phabricator.wikimedia.org/T246284) (owner: 10DannyS712) [02:47:26] (03CR) 10Ppchelko: "gosh, haha.. why didn't it pass... cause someone forgot to include the changes for 3 consecutive patchsets" [core] - 10https://gerrit.wikimedia.org/r/575656 (https://phabricator.wikimedia.org/T246284) (owner: 10DannyS712) [02:59:52] (03CR) 10jerkins-bot: [V: 04-1] Hard deprecate Revision::loadFromTitle [core] - 10https://gerrit.wikimedia.org/r/575656 (https://phabricator.wikimedia.org/T246284) (owner: 10DannyS712) [03:02:18] (03PS1) 10Bartosz Dziewoński: ReplyWidget: Disable "Reply" button if input is empty [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/575660 (https://phabricator.wikimedia.org/T246058) [03:03:39] 10MediaWiki-General, 10Desktop Improvements, 10Readers-Web-Backlog, 10MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), and 3 others: It should be possible to customise the implementation of mw.util.addPortletLink function on a skin basis - https://phabricator.wikimedia.org/T236711 (10matmarex) 05Open→03Resolv... [03:10:36] (03PS11) 10Ppchelko: Hard deprecate Revision::loadFromTitle [core] - 10https://gerrit.wikimedia.org/r/575656 (https://phabricator.wikimedia.org/T246284) (owner: 10DannyS712) [03:14:08] (03CR) 10Bartosz Dziewoński: [C: 03+2] "Huh, am I?" [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/570174 (owner: 10Aron Manning) [03:14:38] (03CR) 10Bartosz Dziewoński: "This seems a bit unnecessary… I don't think the existing code in this skin is trying to follow those conventions." [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/570619 (https://phabricator.wikimedia.org/T245136) (owner: 10Aron Manning) [03:15:15] (03CR) 10Gergő Tisza: [C: 03+2] "A bunch of VE/CX tests fail with "Pending AJAX requests: 0 (active: 1)". I imagine it's unrelated." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/575240 (https://phabricator.wikimedia.org/T246312) (owner: 10Kosta Harlan) [03:15:32] (03CR) 10Gergő Tisza: [C: 03+2] Declare missing dependency on mediawiki.storage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/575240 (https://phabricator.wikimedia.org/T246312) (owner: 10Kosta Harlan) [03:17:13] (03Merged) 10jenkins-bot: Extend documentation of CSS trick that sets the minimum content font-size to 11.43px [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/570174 (owner: 10Aron Manning) [03:23:46] (03CR) 10Ppchelko: [C: 03+2] Hard deprecate Revision::loadFromTitle [core] - 10https://gerrit.wikimedia.org/r/575656 (https://phabricator.wikimedia.org/T246284) (owner: 10DannyS712) [03:23:59] (03PS3) 10Ppchelko: Hard deprecate Revision::countByPageId [core] - 10https://gerrit.wikimedia.org/r/575657 (https://phabricator.wikimedia.org/T246284) (owner: 10DannyS712) [03:24:28] (03PS3) 10Ppchelko: Hard deprecate Revision::countByTitle [core] - 10https://gerrit.wikimedia.org/r/575658 (https://phabricator.wikimedia.org/T246284) (owner: 10DannyS712) [03:26:19] (03CR) 10jerkins-bot: [V: 04-1] Declare missing dependency on mediawiki.storage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/575240 (https://phabricator.wikimedia.org/T246312) (owner: 10Kosta Harlan) [03:26:23] (03PS4) 10Aron Manning: [TEST] Regenerate 'package-lock.json' [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575396 [03:29:40] 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board): Coordinating signature preference validation changes - https://phabricator.wikimedia.org/T244519 (10matmarex) >>! In T244519#5928734, @ppelberg wrote: > @matmarex The elimination of this question [1] leads me to think we're not open to these validation rul... [03:38:20] (03Merged) 10jenkins-bot: Hard deprecate Revision::loadFromTitle [core] - 10https://gerrit.wikimedia.org/r/575656 (https://phabricator.wikimedia.org/T246284) (owner: 10DannyS712) [03:45:45] (03CR) 10Aron Manning: "> Huh, am I?" [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/570174 (owner: 10Aron Manning) [03:48:37] (03PS8) 10Aaron Schulz: rdbms: allow merging IDatabase::upsert() rows with current ones [core] - 10https://gerrit.wikimedia.org/r/574101 [03:50:38] (03CR) 10Ppchelko: [C: 03+2] Hard deprecate Revision::countByTitle [core] - 10https://gerrit.wikimedia.org/r/575658 (https://phabricator.wikimedia.org/T246284) (owner: 10DannyS712) [03:50:57] (03CR) 10Ppchelko: [C: 03+2] Hard deprecate Revision::countByPageId [core] - 10https://gerrit.wikimedia.org/r/575657 (https://phabricator.wikimedia.org/T246284) (owner: 10DannyS712) [03:52:08] (03CR) 10Dmaza: "Few nit-picks. Other than that it looks good. The results presented are also good with the data that I've generated. It would be good if w" (033 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/575013 (https://phabricator.wikimedia.org/T245499) (owner: 10Tchanders) [03:52:26] (03PS1) 10Ppchelko: Hard deprecate Revision::newKnownCurrent [core] - 10https://gerrit.wikimedia.org/r/575661 (https://phabricator.wikimedia.org/T246284) [03:55:08] (03CR) 10jerkins-bot: [V: 04-1] Hard deprecate Revision::newKnownCurrent [core] - 10https://gerrit.wikimedia.org/r/575661 (https://phabricator.wikimedia.org/T246284) (owner: 10Ppchelko) [04:03:04] (03CR) 10jerkins-bot: [V: 04-1] rdbms: allow merging IDatabase::upsert() rows with current ones [core] - 10https://gerrit.wikimedia.org/r/574101 (owner: 10Aaron Schulz) [04:04:51] (03Merged) 10jenkins-bot: Hard deprecate Revision::countByPageId [core] - 10https://gerrit.wikimedia.org/r/575657 (https://phabricator.wikimedia.org/T246284) (owner: 10DannyS712) [04:04:58] (03Merged) 10jenkins-bot: Hard deprecate Revision::countByTitle [core] - 10https://gerrit.wikimedia.org/r/575658 (https://phabricator.wikimedia.org/T246284) (owner: 10DannyS712) [04:49:46] (03PS2) 10Ppchelko: Hard deprecate Revision::newKnownCurrent [core] - 10https://gerrit.wikimedia.org/r/575661 (https://phabricator.wikimedia.org/T246284) [04:52:10] (03CR) 10jerkins-bot: [V: 04-1] Hard deprecate Revision::newKnownCurrent [core] - 10https://gerrit.wikimedia.org/r/575661 (https://phabricator.wikimedia.org/T246284) (owner: 10Ppchelko) [04:53:12] (03PS3) 10Ppchelko: Hard deprecate Revision::newKnownCurrent [core] - 10https://gerrit.wikimedia.org/r/575661 (https://phabricator.wikimedia.org/T246284) [04:58:38] (03PS3) 10DannyS712: Remove use of Title::userCan [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/575659 (https://phabricator.wikimedia.org/T246139) [04:59:35] (03CR) 10jerkins-bot: [V: 04-1] Remove use of Title::userCan [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/575659 (https://phabricator.wikimedia.org/T246139) (owner: 10DannyS712) [05:01:01] (03PS4) 10DannyS712: Remove use of Title::userCan [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/575659 (https://phabricator.wikimedia.org/T246139) [05:03:53] (03CR) 10jerkins-bot: [V: 04-1] Remove use of Title::userCan [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/575659 (https://phabricator.wikimedia.org/T246139) (owner: 10DannyS712) [05:08:32] (03PS1) 10Gergő Tisza: mw.Api: Add utility function for asserting the current user [core] - 10https://gerrit.wikimedia.org/r/575662 [05:12:03] (03CR) 10Ppchelko: "src/PermissionChecker/Title.php seem to be the problem." [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/575659 (https://phabricator.wikimedia.org/T246139) (owner: 10DannyS712) [05:16:58] (03PS5) 10DannyS712: Remove use of Title::userCan [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/575659 (https://phabricator.wikimedia.org/T246139) [05:20:48] (03CR) 10Ppchelko: [C: 03+2] Remove use of Title::userCan [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/575659 (https://phabricator.wikimedia.org/T246139) (owner: 10DannyS712) [05:21:20] (03CR) 10jerkins-bot: [V: 04-1] mw.Api: Add utility function for asserting the current user [core] - 10https://gerrit.wikimedia.org/r/575662 (owner: 10Gergő Tisza) [05:22:36] (03PS6) 10DannyS712: Remove use of Title::userCan [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/575659 (https://phabricator.wikimedia.org/T246139) [05:22:42] (03CR) 10DannyS712: "> Patch Set 5: Code-Review+2" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/575659 (https://phabricator.wikimedia.org/T246139) (owner: 10DannyS712) [05:23:07] 10GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: [betalabs] Newcomer tasks: se-card-end-of-queue dispalys Uncaught TypeError: this.currentCard.getTaskType is not a function - https://phabricator.wikimedia.org/T246512 (10Catrope) a:03Catrope [05:26:01] (03PS17) 10Aron Manning: Replace Grunt tasks with NPM scripts. Devdependencies not updated. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/574636 (https://phabricator.wikimedia.org/T246321) [05:26:03] (03PS1) 10Aron Manning: Update node_modules dependencies in package-lock.json [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575664 (https://phabricator.wikimedia.org/T245930) [05:26:05] (03PS1) 10Aron Manning: Replace grunt* devdependencies with eslint, update node_modules dependencies in package-lock.json [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575665 (https://phabricator.wikimedia.org/T245930) [05:26:07] (03PS1) 10Aron Manning: Regenerate package-lock.json [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575666 (https://phabricator.wikimedia.org/T245930) [05:32:17] (03PS7) 10DannyS712: Remove use of Title::userCan [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/575659 (https://phabricator.wikimedia.org/T246139) [05:33:45] (03PS8) 10DannyS712: Remove use of Title::userCan [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/575659 (https://phabricator.wikimedia.org/T246139) [05:37:20] (03CR) 10DannyS712: "Should be good now" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/575659 (https://phabricator.wikimedia.org/T246139) (owner: 10DannyS712) [05:39:32] (03CR) 10Aron Manning: "> Patch Set 17:" (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/574636 (https://phabricator.wikimedia.org/T246321) (owner: 10Aron Manning) [05:50:00] (03CR) 10DannyS712: [C: 03+1] "LGTM" [core] - 10https://gerrit.wikimedia.org/r/575661 (https://phabricator.wikimedia.org/T246284) (owner: 10Ppchelko) [06:10:36] (03CR) 10DannyS712: Improve performance of query for Special:Investigate Compare tab (033 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/575013 (https://phabricator.wikimedia.org/T245499) (owner: 10Tchanders) [06:13:01] (03PS1) 10DannyS712: Fix git review - `CentralAuth` should be `CiteDrawer` [extensions/CiteDrawer] - 10https://gerrit.wikimedia.org/r/575667 [06:13:13] (03PS2) 10DannyS712: Fix git review - `CentralAuth` should be `CiteDrawer` [extensions/CiteDrawer] - 10https://gerrit.wikimedia.org/r/575667 [06:18:51] (03CR) 10Nischayn22: "This was needed as per my change 465572 but now that it has got newer patchsets I am not really sure :/" [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/465572 (owner: 10Nischayn22) [06:20:55] (03CR) 10DannyS712: [C: 04-1] Initial commit (0314 comments) [extensions/CiteDrawer] - 10https://gerrit.wikimedia.org/r/492393 (owner: 10tosfos) [06:24:00] (03CR) 10DannyS712: [C: 04-1] Initial commit (038 comments) [extensions/CollapsibleSections] - 10https://gerrit.wikimedia.org/r/492394 (owner: 10tosfos) [06:38:25] 10Security-Team, 10Wikimedia-Site-requests: enable bot passwords otrs-wiki.wikimedia.org - https://phabricator.wikimedia.org/T246489 (10Krd) I could imagine it was not enabled at private wikis because there are usually no bots running there. As things are growing and automation is generally a good idea, it sho... [06:39:05] 10DynamicPageList (Wikimedia): Add excludepage parameter to DynamicPageList - https://phabricator.wikimedia.org/T32578 (10DannyS712) [06:41:11] 10MinervaNeue, 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend and MinervaNeue architecture): Block notice on the mobile site doesn't support wikitext - https://phabricator.wikimedia.org/T246521 (10Masumrezarock100) [06:44:00] 10MediaWiki-Page-protection: Allow reprotect with the same expiry but different summary text - https://phabricator.wikimedia.org/T44264 (10DannyS712) [06:44:10] (03PS2) 10Aron Manning: Update node_modules dependencies in package-lock.json [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575664 (https://phabricator.wikimedia.org/T245930) [06:44:12] (03PS2) 10Aron Manning: Replace grunt* devdependencies with eslint, update node_modules dependencies in package-lock.json [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575665 (https://phabricator.wikimedia.org/T245930) [06:44:14] (03PS2) 10Aron Manning: Regenerate package-lock.json [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575666 (https://phabricator.wikimedia.org/T245930) [06:44:16] (03PS1) 10Aron Manning: Update node_modules dependencies in package-lock.json after deleting node_modules [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575668 (https://phabricator.wikimedia.org/T245930) [06:44:40] 10MediaWiki-User-login-and-signup: Enable users to change their own username if their current username is unacceptable - https://phabricator.wikimedia.org/T34330 (10DannyS712) [06:45:21] 10MediaWiki-extensions-Gadgets: Add ability for section description of gadgets section - https://phabricator.wikimedia.org/T46233 (10DannyS712) [06:45:41] 10MediaWiki-Categories: Special pages that list includeonly links - https://phabricator.wikimedia.org/T7178 (10DannyS712) [06:45:53] (03CR) 10Aron Manning: "This change is ready for review." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575664 (https://phabricator.wikimedia.org/T245930) (owner: 10Aron Manning) [06:46:16] (03CR) 10Aron Manning: "This change is ready for review." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575665 (https://phabricator.wikimedia.org/T245930) (owner: 10Aron Manning) [06:46:30] (03CR) 10Aron Manning: "This change is ready for review." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575666 (https://phabricator.wikimedia.org/T245930) (owner: 10Aron Manning) [06:46:50] (03CR) 10Aron Manning: "This change is ready for review." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575668 (https://phabricator.wikimedia.org/T245930) (owner: 10Aron Manning) [06:47:29] (03CR) 10Aron Manning: "Last patch in the sequence, bringing package-lock.json up to date." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575668 (https://phabricator.wikimedia.org/T245930) (owner: 10Aron Manning) [06:47:44] 10ConfirmEdit (CAPTCHA extension): Add capability for QuestyCaptcha to ask two questions, rather than just one - https://phabricator.wikimedia.org/T44056 (10DannyS712) [06:48:22] 10MinervaNeue, 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend and MinervaNeue architecture): Block notice on the mobile site doesn't support wikitext - https://phabricator.wikimedia.org/T246521 (10Masumrezarock100) @Jdlrobson @ovasileva Wikimedia sites do get a fair amount of traffic on the mobile s... [06:48:48] 10MediaWiki-User-login-and-signup: Enable users to change their own username if their current username is unacceptable - https://phabricator.wikimedia.org/T34330 (10RhinosF1) > Once the name change is in place, the user can proceed doing what they wanted to do. A rename would lock a user out globally for potent... [06:48:51] 10MediaWiki-Page-protection: Magic word returning number of protected pages - https://phabricator.wikimedia.org/T51659 (10DannyS712) [06:48:55] 10MediaWiki-extensions-FlaggedRevs: Magic word returning number of stable pages - https://phabricator.wikimedia.org/T51661 (10DannyS712) [06:49:22] 10MediaWiki-Categories: Filter Special:NewPages by category - https://phabricator.wikimedia.org/T23673 (10DannyS712) [06:50:28] (03CR) 10Aron Manning: "npm generated the same package-lock.json albeit with tabs instead of spaces." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575666 (https://phabricator.wikimedia.org/T245930) (owner: 10Aron Manning) [06:50:37] 10MinervaNeue, 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend and MinervaNeue architecture): Block notice on the mobile site doesn't support wikitext - https://phabricator.wikimedia.org/T246521 (10Ammarpad) [06:50:41] 10MediaWiki-User-management, 10MobileFrontend, 10Anti-Harassment, 10Readers-Web-Backlog (Tracking): Better handle block reasons on mobile (specifically templates and HTML comments) - https://phabricator.wikimedia.org/T189717 (10Ammarpad) [06:51:36] 10MinervaNeue, 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend and MinervaNeue architecture): Block notice on the mobile site doesn't support wikitext - https://phabricator.wikimedia.org/T246521 (10Masumrezarock100) 05duplicate→03Open [06:55:55] 10MinervaNeue, 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend and MinervaNeue architecture): Block notice on the mobile site doesn't support wikitext - https://phabricator.wikimedia.org/T246521 (10Masumrezarock100) My bad, I was still editing the task when you closed this task. So we ended up having... [06:56:34] 10MinervaNeue, 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend and MinervaNeue architecture): Block notice on the mobile site doesn't support wikitext - https://phabricator.wikimedia.org/T246521 (10Masumrezarock100) [06:56:37] 10MediaWiki-User-management, 10MobileFrontend, 10Anti-Harassment, 10Readers-Web-Backlog (Tracking): Better handle block reasons on mobile (specifically templates and HTML comments) - https://phabricator.wikimedia.org/T189717 (10Masumrezarock100) [06:57:28] (03CR) 10Aron Manning: "> This seems a bit unnecessary… I don't think the existing code in this skin is trying to follow those conventions." [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/570619 (https://phabricator.wikimedia.org/T245136) (owner: 10Aron Manning) [07:20:06] (03PS1) 10Ppchelko: Experiment lazy loading of services [core] - 10https://gerrit.wikimedia.org/r/575669 [07:25:29] (03CR) 10jerkins-bot: [V: 04-1] Experiment lazy loading of services [core] - 10https://gerrit.wikimedia.org/r/575669 (owner: 10Ppchelko) [08:04:47] (03CR) 10Scheleon: [C: 03+1] Api: Populate variables startsortkey and endsortkey before conditional check [core] - 10https://gerrit.wikimedia.org/r/575398 (https://phabricator.wikimedia.org/T245310) (owner: 10Scheleon) [08:07:11] (03CR) 10MarcoAurelio: [C: 03+2] Fix git review - `CentralAuth` should be `CiteDrawer` [extensions/CiteDrawer] - 10https://gerrit.wikimedia.org/r/575667 (owner: 10DannyS712) [08:09:53] (03Merged) 10jenkins-bot: Fix git review - `CentralAuth` should be `CiteDrawer` [extensions/CiteDrawer] - 10https://gerrit.wikimedia.org/r/575667 (owner: 10DannyS712) [08:32:19] (03PS2) 10Gergő Tisza: mw.Api: Add utility function for asserting the current user [core] - 10https://gerrit.wikimedia.org/r/575662 [08:35:19] (03PS1) 10Gergő Tisza: Set $wgResourceLoaderStorageEnabled = false [vagrant] - 10https://gerrit.wikimedia.org/r/575671 [09:00:16] (03PS13) 10Matěj Suchánek: Replace Linker::link usage with LinkRenderer [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/534951 (https://phabricator.wikimedia.org/T149346) [09:01:35] (03CR) 10Matěj Suchánek: "> Patch Set 12:" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/534951 (https://phabricator.wikimedia.org/T149346) (owner: 10Matěj Suchánek) [09:06:31] (03CR) 10Umherirrender: Replace grunt* devdependencies with eslint, update node_modules dependencies in package-lock.json (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575665 (https://phabricator.wikimedia.org/T245930) (owner: 10Aron Manning) [09:17:06] (03PS3) 10Umherirrender: Move TestOAuthSignatureMethod_RSA_SHA1 to anon inline class [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/571049 [09:18:06] (03CR) 10Umherirrender: "It is not a class for unit tests, so it is wrong under /tests/. For proper autoloading I have moved it into /includes/, because /maintenan" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/571049 (owner: 10Umherirrender) [09:21:01] (03PS1) 10Gergő Tisza: Assert the current user during all write operations [extensions/Flow] - 10https://gerrit.wikimedia.org/r/575673 (https://phabricator.wikimedia.org/T217774) [09:21:03] (03PS1) 10Gergő Tisza: Display API errors when resolving / unresolving topics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/575674 [09:25:39] (03PS4) 10Umherirrender: Remove unused code, mark code as private, update type hints [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/569591 (owner: 10Thiemo Kreuz (WMDE)) [09:25:41] (03PS5) 10Umherirrender: Remove unused code, mark code as private, update type hints [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/569591 (owner: 10Thiemo Kreuz (WMDE)) [09:25:44] (03CR) 10Umherirrender: [C: 03+2] Remove unused code, mark code as private, update type hints [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/569591 (owner: 10Thiemo Kreuz (WMDE)) [09:41:01] (03Merged) 10jenkins-bot: Remove unused code, mark code as private, update type hints [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/569591 (owner: 10Thiemo Kreuz (WMDE)) [09:50:53] (03PS1) 10Krinkle: build: Simplify gitattributes file, add missing @covers [WrappedString] - 10https://gerrit.wikimedia.org/r/575675 [09:51:43] (03PS2) 10Krinkle: profiler: Remove support for $wgDebugLogGroups['profileoutput'] [core] - 10https://gerrit.wikimedia.org/r/575294 (https://phabricator.wikimedia.org/T245835) [09:52:25] (03CR) 10jerkins-bot: [V: 04-1] profiler: Remove support for $wgDebugLogGroups['profileoutput'] [core] - 10https://gerrit.wikimedia.org/r/575294 (https://phabricator.wikimedia.org/T245835) (owner: 10Krinkle) [10:00:04] (03PS1) 10Umherirrender: Use AntiSpoof::checkUnicodeStringStatus [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/575676 [10:06:15] (03CR) 10Krinkle: [C: 03+2] Use AntiSpoof::checkUnicodeStringStatus [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/575676 (owner: 10Umherirrender) [10:06:29] (03PS1) 10Umherirrender: Soft deprecate AntiSpoof::checkUnicodeString and SpoofUser::getError [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/575678 [10:06:40] (03CR) 10Umherirrender: "Last replacement is in I5d79426a328c6ddc02789d795bc84599e8e5c06d" [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/575678 (owner: 10Umherirrender) [10:08:07] (03CR) 10Krinkle: [C: 04-1] Replace all stdClass with object in PHPDoc tags (031 comment) [core] - 10https://gerrit.wikimedia.org/r/575547 (owner: 10Thiemo Kreuz (WMDE)) [10:09:28] (03CR) 10Krinkle: [C: 03+2] Soft deprecate AntiSpoof::checkUnicodeString and SpoofUser::getError [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/575678 (owner: 10Umherirrender) [10:11:16] (03Merged) 10jenkins-bot: Use AntiSpoof::checkUnicodeStringStatus [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/575676 (owner: 10Umherirrender) [10:19:10] (03CR) 10Krinkle: [C: 03+2] Cleanup various calls to IDatabase::upsert() [core] - 10https://gerrit.wikimedia.org/r/575375 (owner: 10Aaron Schulz) [10:22:24] (03Merged) 10jenkins-bot: Soft deprecate AntiSpoof::checkUnicodeString and SpoofUser::getError [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/575678 (owner: 10Umherirrender) [10:23:16] (03CR) 10Krinkle: [C: 04-1] Remove unused variable from closures used() list (034 comments) [core] - 10https://gerrit.wikimedia.org/r/575624 (owner: 10Umherirrender) [10:28:12] (03PS2) 10Umherirrender: Remove unused variable from closures used() list [core] - 10https://gerrit.wikimedia.org/r/575624 [10:28:51] (03CR) 10Umherirrender: Remove unused variable from closures used() list (031 comment) [core] - 10https://gerrit.wikimedia.org/r/575624 (owner: 10Umherirrender) [10:30:11] (03CR) 10Umherirrender: "It seems the RAII plugin does not work for closures with use, see https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/575624/1/includes/li" [tools/phan] - 10https://gerrit.wikimedia.org/r/555682 (https://phabricator.wikimedia.org/T240075) (owner: 10Daimona Eaytoy) [10:33:00] (03Merged) 10jenkins-bot: Cleanup various calls to IDatabase::upsert() [core] - 10https://gerrit.wikimedia.org/r/575375 (owner: 10Aaron Schulz) [10:57:25] (03CR) 10Daimona Eaytoy: "> (5 comments)" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/574261 (https://phabricator.wikimedia.org/T245231) (owner: 10DannyS712) [11:01:30] 10AntiSpoof, 10I18n: AntiSpoof doesn't allow names in N'Ko, Santali (Ol Chiki), Ho (Warang Citi), Meetei, and perhaps more writing systems - https://phabricator.wikimedia.org/T246525 (10Amire80) [11:02:39] (03CR) 10Reedy: "recheck" [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575621 (owner: 10Jdlrobson) [11:02:45] (03CR) 10Reedy: "recheck" [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575622 (owner: 10Jdlrobson) [11:02:49] (03CR) 10Reedy: "recheck" [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575623 (owner: 10Jdlrobson) [11:02:56] (03CR) 10Reedy: "recheck" [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575626 (owner: 10Jdlrobson) [11:04:26] (03CR) 10jerkins-bot: [V: 04-1] Ignore files appropriately in checkins and linting [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575621 (owner: 10Jdlrobson) [11:04:33] (03CR) 10jerkins-bot: [V: 04-1] Allow development build to allow testing of non-JS mode [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575622 (owner: 10Jdlrobson) [11:04:35] (03CR) 10jerkins-bot: [V: 04-1] Nearby button should be hidden with JS disabled [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575623 (owner: 10Jdlrobson) [11:04:50] (03CR) 10jerkins-bot: [V: 04-1] Dev: Provide stubbing for api and mw.config in dev [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575626 (owner: 10Jdlrobson) [11:07:06] (03PS1) 10Reedy: Add manifest_version 1 [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575681 [11:09:31] (03CR) 10jerkins-bot: [V: 04-1] Add manifest_version 1 [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575681 (owner: 10Reedy) [11:09:50] (03CR) 10Reedy: [V: 03+2 C: 03+2] "Failure is JS related" [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575681 (owner: 10Reedy) [11:10:30] (03CR) 10Reedy: "recheck" [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575626 (owner: 10Jdlrobson) [11:12:07] 10Wikimedia-Site-requests: Enabling Citoid on Balinese Wikipedia - https://phabricator.wikimedia.org/T246418 (10MarcoAurelio) Citoid is already installed on banwiki as can be seen at https://ban.wikipedia.org/wiki/Kusus:Versi. I guess you'll need local configuration though. [11:13:28] (03PS2) 10Reedy: Ignore files appropriately in checkins and linting [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575621 (owner: 10Jdlrobson) [11:13:34] (03PS3) 10Reedy: Allow development build to allow testing of non-JS mode [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575622 (owner: 10Jdlrobson) [11:13:37] (03PS4) 10Reedy: Nearby button should be hidden with JS disabled [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575623 (owner: 10Jdlrobson) [11:13:41] (03PS2) 10Reedy: Dev: Provide stubbing for api and mw.config in dev [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575626 (owner: 10Jdlrobson) [11:18:35] (03CR) 10Reedy: [C: 03+2] "reapply" [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575621 (owner: 10Jdlrobson) [11:18:43] (03CR) 10Reedy: [C: 03+2] "reapply" [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575622 (owner: 10Jdlrobson) [11:18:50] (03CR) 10Reedy: [C: 03+2] "reapply" [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575623 (owner: 10Jdlrobson) [11:21:32] (03Merged) 10jenkins-bot: Ignore files appropriately in checkins and linting [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575621 (owner: 10Jdlrobson) [11:21:34] (03Merged) 10jenkins-bot: Allow development build to allow testing of non-JS mode [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575622 (owner: 10Jdlrobson) [11:22:19] 10NearbyPages, 10Software-Licensing: License NearbyPages repo - https://phabricator.wikimedia.org/T246526 (10Reedy) [11:22:28] 10NearbyPages, 10Software-Licensing: License NearbyPages repo - https://phabricator.wikimedia.org/T246526 (10Reedy) p:05Triage→03High [11:24:00] (03Merged) 10jenkins-bot: Nearby button should be hidden with JS disabled [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575623 (owner: 10Jdlrobson) [11:24:37] 10NearbyPages: Enable PHPCS - https://phabricator.wikimedia.org/T246528 (10Reedy) [11:25:52] 10AntiSpoof, 10Equivset, 10I18n: AntiSpoof doesn't allow names in N'Ko, Santali (Ol Chiki), Ho (Warang Citi), Meetei, and perhaps more writing systems - https://phabricator.wikimedia.org/T246525 (10Reedy) [11:26:43] 10NearbyPages, 10Software-Licensing: License NearbyPages repo - https://phabricator.wikimedia.org/T246526 (10Peachey88) The [[ https://www.mediawiki.org/wiki/Extension:NearbyPages | extension page ]] is claiming GPL-2.0+ [11:29:54] (03PS1) 10MarcoAurelio: Add licencing [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575683 [11:31:24] (03PS2) 10MarcoAurelio: Add licencing [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575683 [11:31:51] (03PS3) 10MarcoAurelio: Add licencing [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575683 (https://phabricator.wikimedia.org/T246526) [11:34:29] (03PS4) 10MarcoAurelio: Add licencing [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575683 (https://phabricator.wikimedia.org/T246526) [12:07:51] 10Wikimedia-General-or-Unknown, 10Documentation: Add a wiki says to add wiki to dblists, dblists say not to edit them directly - https://phabricator.wikimedia.org/T246530 (10Reedy) [12:19:43] 10Wikimedia-General-or-Unknown, 10Documentation: Add a wiki says to add wiki to dblists, dblists say not to edit them directly - https://phabricator.wikimedia.org/T246530 (10Reedy) And as part of {T246511}, I'm having to work out which yaml files need changing, which commands then need to be run... [12:27:57] 10Lingua Libre: New interface and logo - https://phabricator.wikimedia.org/T240552 (10Opsylac) {F31650866} {F31650865} propositions de logos (prononciation audio, langue des signes, visuels) [12:46:29] 10Security-Team, 10Wikimedia-Site-requests: enable bot passwords otrs-wiki.wikimedia.org - https://phabricator.wikimedia.org/T246489 (10Reedy) >>! In T246489#5928772, @Krd wrote: > I could imagine it was not enabled at private wikis because there are usually no bots running there. As things are growing and aut... [13:02:00] (03PS1) 10Zoranzoki21: Add phpcs and phan [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575685 [13:02:17] (03PS2) 10Zoranzoki21: Add phpcs and phan [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575685 (https://phabricator.wikimedia.org/T246527) [13:11:03] (03CR) 10Zoranzoki21: "recheck" [core] - 10https://gerrit.wikimedia.org/r/575398 (https://phabricator.wikimedia.org/T245310) (owner: 10Scheleon) [13:12:29] (03CR) 10Zoranzoki21: "recheck" [core] - 10https://gerrit.wikimedia.org/r/571733 (owner: 10محمد شعیب) [13:13:57] (03CR) 10TheDJ: [C: 03+2] Unify monospace font stack. Avoid potential sizing bug caused by weird browser behavior with `font-family: monospace;` [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/573427 (https://phabricator.wikimedia.org/T176636) (owner: 10Aron Manning) [13:15:05] 10ISA, 10Patch-For-Review: Set End date to 'Not Set' instead of 'None' on campaign home - https://phabricator.wikimedia.org/T245759 (10Gabrielchihonglee) 05Open→03Resolved [13:19:34] (03Merged) 10jenkins-bot: Unify monospace font stack. Avoid potential sizing bug caused by weird browser behavior with `font-family: monospace;` [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/573427 (https://phabricator.wikimedia.org/T176636) (owner: 10Aron Manning) [13:31:54] (03CR) 10TheDJ: Add "external" class to non-local interwiki links (031 comment) [core] - 10https://gerrit.wikimedia.org/r/146711 (https://phabricator.wikimedia.org/T20562) (owner: 10TTO) [13:35:20] 10Lingua Libre: New interface and logo - https://phabricator.wikimedia.org/T240552 (10WikiLucas00) {F31650931} Ébauche proposition logo [13:35:25] 10MediaWiki-extensions-TitleKey: TitleKey blocks opensearch from suggesting titles in namespaces outside of NS_MAIN and NS_SPECIAL - https://phabricator.wikimedia.org/T246531 (10maiden_taiwan) [13:36:42] 10MediaWiki-Special-pages: Localize Special:Nearby on trwiki - https://phabricator.wikimedia.org/T246532 (10Superyetkin) [13:47:38] 10Lingua Libre: New interface and logo - https://phabricator.wikimedia.org/T240552 (10Eavqwiki) Critères - plus sérieux que les propositions actuelles, géométrique - pas le nom dans le logo, ou lisible au moins lisible ou en-dessous - des mains pour les ailes de l'enregistreur - rec plutôt que mains et la langue... [13:51:09] (03PS2) 10Sohom Datta: Fixed missing public function documentation error [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/574224 (https://phabricator.wikimedia.org/T243932) [13:54:32] (03CR) 10Daimona Eaytoy: [C: 03+2] filerepo: Add and fix visibility keywords in ArchivedFile [core] - 10https://gerrit.wikimedia.org/r/575553 (owner: 10Thiemo Kreuz (WMDE)) [13:55:48] (03CR) 10Daimona Eaytoy: "check experimental" [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575685 (https://phabricator.wikimedia.org/T246527) (owner: 10Zoranzoki21) [13:55:49] 10MediaWiki-extensions-Page_Forms, 10Google-Summer-of-Code (2020): Remove use of jQuery UI from Page Forms - https://phabricator.wikimedia.org/T241632 (10AghaSaad04) Hi, This is Agha Saad Fraz, pursuing Software Engineering. I am interested in applying to Wikimedia for GSoC'20. I am interested in this idea. I... [13:58:20] (03CR) 10Daimona Eaytoy: [C: 04-1] Add phpcs and phan (031 comment) [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575685 (https://phabricator.wikimedia.org/T246527) (owner: 10Zoranzoki21) [13:58:53] 10NearbyPages: Localize Special:Nearby on trwiki - https://phabricator.wikimedia.org/T246532 (10Ammarpad) The feature is being rewritten as a separate extension decoupled from MobileFrontend. Therefore the change should be made in the new extension. But you'll not see this change even if it's merged until after... [14:00:04] (03CR) 10Daimona Eaytoy: [C: 04-2] "> It seems the RAII plugin does not work for closures with use, see" [tools/phan] - 10https://gerrit.wikimedia.org/r/555682 (https://phabricator.wikimedia.org/T240075) (owner: 10Daimona Eaytoy) [14:03:38] 10ISA: [Bug] Campaign does not include .tif images? - https://phabricator.wikimedia.org/T232038 (10NavinoEvans) [14:04:03] 10ISA: [Bug] Campaigns do not include .tif images - https://phabricator.wikimedia.org/T232038 (10NavinoEvans) [14:04:32] (03CR) 10Daimona Eaytoy: "T245629" [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/575601 (owner: 10Umherirrender) [14:07:10] (03PS4) 10Daimona Eaytoy: [WIP][POC] Require taint-check [tools/phan] - 10https://gerrit.wikimedia.org/r/574190 (https://phabricator.wikimedia.org/T235390) [14:07:30] (03PS3) 10Zoranzoki21: Add phpcs and phan [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575685 (https://phabricator.wikimedia.org/T246527) [14:07:51] (03CR) 10Zoranzoki21: Add phpcs and phan (031 comment) [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575685 (https://phabricator.wikimedia.org/T246527) (owner: 10Zoranzoki21) [14:08:08] (03Merged) 10jenkins-bot: filerepo: Add and fix visibility keywords in ArchivedFile [core] - 10https://gerrit.wikimedia.org/r/575553 (owner: 10Thiemo Kreuz (WMDE)) [14:08:17] 10ISA: Add ISA to Hay's tools - https://phabricator.wikimedia.org/T231644 (10NavinoEvans) [14:08:19] 10ISA: Add ISA to Hay's Tools Directory - https://phabricator.wikimedia.org/T239854 (10NavinoEvans) [14:08:35] 10ISA: Add ISA to Hay's Tools Directory - https://phabricator.wikimedia.org/T239854 (10NavinoEvans) p:05Triage→03Medium [14:08:46] (03PS5) 10Daimona Eaytoy: [WIP][POC] Require taint-check [tools/phan] - 10https://gerrit.wikimedia.org/r/574190 (https://phabricator.wikimedia.org/T235390) [14:09:35] (03CR) 10Daimona Eaytoy: "check experimental" [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575685 (https://phabricator.wikimedia.org/T246527) (owner: 10Zoranzoki21) [14:11:30] (03CR) 10Daimona Eaytoy: [C: 04-1] "" [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575685 (https://phabricator.wikimedia.org/T246527) (owner: 10Zoranzoki21) [14:13:11] (03PS1) 10Florianschmidtwelzow: [Special:Random] Do not cache response in frontend-cache [core] - 10https://gerrit.wikimedia.org/r/575687 [14:13:53] (03PS1) 10Ammarpad: NearbyPages: Add special page aliases [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575688 (https://phabricator.wikimedia.org/T246532) [14:15:22] 10Lingua Libre: New interface and logo - https://phabricator.wikimedia.org/T240552 (10WikiLucas00) {F31650995} {F31650996} Variations autour des symboles Recording et Play (communs à l'enregistrement audio et vidéo et l'écoute/visionnage de langues parlées ou signées) et des couleurs Wikimédia (présence du nom... [14:21:25] 10NearbyPages, 10Patch-For-Review: Localize Special:Nearby on trwiki - https://phabricator.wikimedia.org/T246532 (10Ammarpad) [14:26:24] 10MediaWiki-Email, 10MediaWiki-User-login-and-signup: Some valid Email addresses cannot be accepted - https://phabricator.wikimedia.org/T41236 (10Aklapper) [14:26:26] 10MediaWiki-Email, 10MediaWiki-User-login-and-signup: Some invalid Email addresses are accepted (Abc.@example.com Abc..123@example.com) - https://phabricator.wikimedia.org/T41239 (10Aklapper) [14:35:19] 10NearbyPages, 10Patch-For-Review: Localize Special:Nearby on trwiki - https://phabricator.wikimedia.org/T246532 (10Ammarpad) On second thought, if #NearbyPages will take long time before being deployed, maybe your alias should be added in the MF notwithstanding the impending removal of the whole code. The pat... [14:35:54] (03CR) 10Reedy: "recheck" [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575685 (https://phabricator.wikimedia.org/T246527) (owner: 10Zoranzoki21) [14:38:26] (03CR) 10jerkins-bot: [V: 04-1] Add phpcs and phan [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575685 (https://phabricator.wikimedia.org/T246527) (owner: 10Zoranzoki21) [14:40:28] (03PS4) 10Reedy: Add phpcs and phan [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575685 (https://phabricator.wikimedia.org/T246527) (owner: 10Zoranzoki21) [14:41:24] (03CR) 10Daimona Eaytoy: Add phpcs and phan (031 comment) [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575685 (https://phabricator.wikimedia.org/T246527) (owner: 10Zoranzoki21) [14:41:31] (03PS5) 10Reedy: Add phpcs and phan [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575685 (https://phabricator.wikimedia.org/T246527) (owner: 10Zoranzoki21) [14:41:34] (03CR) 10jerkins-bot: [V: 04-1] Add phpcs and phan [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575685 (https://phabricator.wikimedia.org/T246527) (owner: 10Zoranzoki21) [14:42:17] (03CR) 10Reedy: Add phpcs and phan (031 comment) [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575685 (https://phabricator.wikimedia.org/T246527) (owner: 10Zoranzoki21) [14:42:30] (03PS6) 10Reedy: Add phpcs and phan [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575685 (https://phabricator.wikimedia.org/T246527) (owner: 10Zoranzoki21) [14:45:00] (03CR) 10jerkins-bot: [V: 04-1] Add phpcs and phan [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575685 (https://phabricator.wikimedia.org/T246527) (owner: 10Zoranzoki21) [14:47:01] (03CR) 10Florianschmidtwelzow: [C: 03+1] "Looks good to me. Giving Krinkle the chance to take a look as well :)" [core] - 10https://gerrit.wikimedia.org/r/575624 (owner: 10Umherirrender) [14:47:02] (03PS7) 10Reedy: Add phpcs and phan [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575685 (https://phabricator.wikimedia.org/T246527) (owner: 10Zoranzoki21) [14:47:03] 10MediaWiki-extensions-Page_Forms, 10Google-Summer-of-Code (2020): Remove use of jQuery UI from Page Forms - https://phabricator.wikimedia.org/T241632 (10Aklapper) Hi and welcome AghaSaad04! Please see the last line in the description here, and https://www.mediawiki.org/wiki/Google_Summer_of_Code/2020 for more... [14:49:38] (03CR) 10Reedy: [C: 03+2] Add phpcs and phan [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575685 (https://phabricator.wikimedia.org/T246527) (owner: 10Zoranzoki21) [14:49:41] 10Accessibility, 10MediaWiki-Watchlist, 10Growth-Team: Add accessibility label to menu widget - https://phabricator.wikimedia.org/T246513 (10Aklapper) [14:51:20] 10Developer-Advocacy (Jan-Mar 2020), 10Documentation: Set up Tech blog to share stories from the Wikimedia Technical community - https://phabricator.wikimedia.org/T242619 (10Aklapper) [14:52:22] (03Merged) 10jenkins-bot: Add phpcs and phan [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575685 (https://phabricator.wikimedia.org/T246527) (owner: 10Zoranzoki21) [14:52:58] 10NearbyPages, 10Epic: [EPIC] Deploy NearbyPages everywhere - https://phabricator.wikimedia.org/T246493 (10Reedy) [14:53:06] 10NearbyPages, 10Epic: [EPIC] Deploy NearbyPages everywhere - https://phabricator.wikimedia.org/T246493 (10Reedy) [15:01:44] 10Security-Team, 10TechCom-RFC: RFC: Adopt a modern JavaScript framework for use with MediaWiki - https://phabricator.wikimedia.org/T241180 (10Esanders) >>! In T241180#5928546, @Ladsgroup wrote: > Second, Your point is true, there will cost with adapting a new framework, specially for VE. I'm not disputing tha... [15:05:11] 10MediaWiki-Recent-changes, 10Growth-Team, 10good first task: Function applyDiffStyle uses regexes which do not detect CSS classes appropriately - https://phabricator.wikimedia.org/T36801 (10subins2000) a:03subins2000 I'd like to work on this [15:22:06] 10Lingua Libre: New interface and logo - https://phabricator.wikimedia.org/T240552 (10Opsylac) {F31651058} D'autres variations. Vers la fin, feeling un peu "commons" avec le rouge et bleu wikimédiens [15:23:29] 10Lingua Libre: New interface and logo - https://phabricator.wikimedia.org/T240552 (10Opsylac) Note : aucun des deux bleus de la maquette n'est le même que celui du logo wikimédia. [15:27:32] 10Editing Design, 10OWC2020, 10Editing-team (Tracking): Determine our approach for displaying date and time a comment was made, in a user's local timezone and preferred date format - https://phabricator.wikimedia.org/T240360 (10Alsee) @Demian I don't understand your objection about being "less dramatic". Wha... [15:35:38] (03PS1) 10Esanders: Replace arrow variants with CSS transformations [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/575690 [15:45:19] 10Lingua Libre: New interface and logo - https://phabricator.wikimedia.org/T240552 (10Opsylac) {F31651072} Bon faut que je me calme. Bises :) [15:56:43] 10MediaWiki-extensions-Other, 10Cleanup, 10Other-skins, 10Repository-Admins, and 2 others: Archive mediawiki/services/html5depurate ? - https://phabricator.wikimedia.org/T246534 (10Aklapper) [15:56:45] 10Lingua Libre: New interface and logo - https://phabricator.wikimedia.org/T240552 (10WikiLucas00) >>! In T240552#5929125, @Opsylac wrote: > {F31651058} > > {F31651063} > > D'autres variations. Vers la fin, feeling un peu "commons" avec le rouge et bleu wikimédiens Je ne suis pas forcément en faveur de l'inté... [15:58:31] (03PS1) 10D3r1ck01: resourceloader: Avoid deprecated Revision class and use MCR approach [core] - 10https://gerrit.wikimedia.org/r/575691 [16:03:25] 10UI-Standardization, 10WikiEditor, 10MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), 10Patch-For-Review: WikiEditor uses Apex-like styling in Vector for the toolbar; change this to WikimediaUI-style - https://phabricator.wikimedia.org/T223155 (10Dvorapa) Per [[https://cs.wikipedia.org/wiki/Wikipedie:Pod_l%C3%A... [16:09:10] 10UI-Standardization, 10WikiEditor, 10MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), 10Patch-For-Review: WikiEditor uses Apex-like styling in Vector for the toolbar; change this to WikimediaUI-style - https://phabricator.wikimedia.org/T223155 (10TheDJ) Note: `importScript('Wikipedista:Draceane/vector.js')` Do... [16:14:56] (03CR) 10Umherirrender: "You could remove the phan stub, which defined the constant for phan" (031 comment) [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/574842 (owner: 10Thiemo Kreuz (WMDE)) [16:18:52] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/575691 (owner: 10D3r1ck01) [16:19:13] 10Mathe für Nicht-Freaks: Hilfeseite "Interaktion mit der Community" - https://phabricator.wikimedia.org/T246536 (10Claudia4) [16:23:45] (03PS1) 10D3r1ck01: skins: Remove comment as this is done & 1.34 is already released [core] - 10https://gerrit.wikimedia.org/r/575694 [16:27:16] 10Anti-Harassment (The Letter Song), 10Epic: Deploy Special:Mute features - https://phabricator.wikimedia.org/T231577 (10stjn) Yes. (Sorry for taking too long to answer :-)) [16:27:47] (03PS1) 10D3r1ck01: skins: Fix typo, should be "default" instead [core] - 10https://gerrit.wikimedia.org/r/575696 [16:28:20] 10Lingua Libre: New interface and logo - https://phabricator.wikimedia.org/T240552 (10Opsylac) > Je ne suis pas forcément en faveur de l'intégration du logo dans un phylactère (bulle), qui réfère surtout aux langues prononcées Je comprends l'idée, mais quelle autre symbole pour la parole ? C'est déjà plus neutr... [16:31:28] (03PS2) 10D3r1ck01: skins: Remove deprecated method Skin::getSkinNameMessages() [core] - 10https://gerrit.wikimedia.org/r/575696 [16:31:47] 10QRpedia-General: Make QRpedia codes become permanent links - https://phabricator.wikimedia.org/T245907 (10Quarz) Maybe I should ping a few people who are part of the WMUK staff (or contractors)? They could certainly point out this proposal at WMUK. @Kelson, @ErrantX please take a look at this. [16:32:22] (03CR) 10Umherirrender: Always enable stylelint rules after disable (036 comments) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/575610 (owner: 10Umherirrender) [16:35:02] (03PS1) 10D3r1ck01: skins: Soft & Hard deprecation must have same MW version number [core] - 10https://gerrit.wikimedia.org/r/575698 [16:39:29] 10UploadWizard: Incomplete uploads in Upload Wizard - https://phabricator.wikimedia.org/T246537 (10Rodhullandemu) [16:39:30] (03PS1) 10D3r1ck01: skins: Remove deprecated Skin::escapeSearchLink() [core] - 10https://gerrit.wikimedia.org/r/575699 [16:39:44] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/575694 (owner: 10D3r1ck01) [16:45:49] 10Internet-Archive, 10Community-Tech (Kanban-Q3-2019-20): Spike: New/Improved OCR tool [8 hours] - https://phabricator.wikimedia.org/T244100 (10aezell) Thanks @kaldari ! That's great. I just had a thought about our goals for this work and maybe the role of OCR on WikiSource in general. That is, are we looking... [16:46:53] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/575696 (owner: 10D3r1ck01) [16:49:55] (03PS1) 10D3r1ck01: skins: Soft and hard deprecate SkinTemplate::makeArticleUrlDetails() [core] - 10https://gerrit.wikimedia.org/r/575700 [16:50:44] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/575698 (owner: 10D3r1ck01) [16:52:56] 10AbuseFilter, 10Wikimedia-maintenance-script-run: Dry-run, then actually run updateVarDumps - https://phabricator.wikimedia.org/T246539 (10Daimona) [16:53:07] 10AbuseFilter, 10Wikimedia-maintenance-script-run: Dry-run, then actually run updateVarDumps - https://phabricator.wikimedia.org/T246539 (10Daimona) 05Open→03Stalled [16:53:15] 10AbuseFilter, 10Wikimedia-maintenance-script-run: Dry-run, then actually run updateVarDumps - https://phabricator.wikimedia.org/T246539 (10Daimona) [16:55:53] (03PS2) 10D3r1ck01: skins: Soft and hard deprecate SkinTemplate::makeArticleUrlDetails() [core] - 10https://gerrit.wikimedia.org/r/575700 [16:57:21] (03PS1) 10D3r1ck01: skins: Soft deprecate SkinTemplate::getNameSpaceKey() method [core] - 10https://gerrit.wikimedia.org/r/575702 [16:57:49] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/575699 (owner: 10D3r1ck01) [16:58:43] (03PS39) 10Daimona Eaytoy: Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006) [17:00:39] (03PS40) 10Daimona Eaytoy: Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006) [17:00:44] 10MediaWiki-Interface, 10MediaWiki-ResourceLoader, 10Performance-Team, 10CSS: Consider adding .mw-wiki-logo {background-size: 135px} to skin CSS - https://phabricator.wikimedia.org/T203822 (10Krinkle) 05Open→03Resolved a:03Krinkle This issue was already solved a year or so ago. The CSS for the logo i... [17:01:24] 10MediaWiki-Interface, 10ContentTranslation, 10Desktop Improvements, 10Core Platform Team Workboards (Clinic Duty Team), and 4 others: Separate out logo handling into square image logos and long text/wordmark banner logos - https://phabricator.wikimedia.org/T232140 (10Krinkle) [17:03:44] 10MediaWiki-Interface, 10ContentTranslation, 10Desktop Improvements, 10Core Platform Team Workboards (Clinic Duty Team), and 4 others: Separate out logo handling into square image logos and long text/wordmark banner logos - https://phabricator.wikimedia.org/T232140 (10Krinkle) I note that Setup.php and Ski... [17:04:06] (03Restored) 10Daimona Eaytoy: Use a BlobStore for storing var dumps. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/538599 (https://phabricator.wikimedia.org/T198341) (owner: 10Daniel Kinzler) [17:10:34] (03PS3) 10Krinkle: Remove unused variables from closure use() lists [core] - 10https://gerrit.wikimedia.org/r/575624 (owner: 10Umherirrender) [17:10:38] (03CR) 10Krinkle: [C: 03+1] Remove unused variables from closure use() lists [core] - 10https://gerrit.wikimedia.org/r/575624 (owner: 10Umherirrender) [17:11:43] (03CR) 10Florianschmidtwelzow: [C: 03+2] Remove unused variables from closure use() lists [core] - 10https://gerrit.wikimedia.org/r/575624 (owner: 10Umherirrender) [17:11:57] (03CR) 10Krinkle: [C: 03+2] Move TestOAuthSignatureMethod_RSA_SHA1 to anon inline class [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/571049 (owner: 10Umherirrender) [17:15:34] (03CR) 10Jdlrobson: [C: 03+2] Dev: Provide stubbing for api and mw.config in dev [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575626 (owner: 10Jdlrobson) [17:15:53] (03CR) 10Krinkle: Bundle services at top of TraditionalImageGallery::toHtml (032 comments) [core] - 10https://gerrit.wikimedia.org/r/574213 (owner: 10Umherirrender) [17:16:06] (03CR) 10Esanders: [C: 03+2] ReplyWidget: Disable "Reply" button if input is empty (031 comment) [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/575660 (https://phabricator.wikimedia.org/T246058) (owner: 10Bartosz Dziewoński) [17:16:22] (03CR) 10jerkins-bot: [V: 04-1] Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [17:19:00] (03PS1) 10Zoranzoki21: Add names for special pages on Serbian [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/575704 [17:22:54] (03CR) 10Aron Manning: "Thanks for the comment." (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575665 (https://phabricator.wikimedia.org/T245930) (owner: 10Aron Manning) [17:22:58] 10DiscussionTools, 10Editing QA, 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 1.0): DiscussionTool does not work on ar wiki when using Google Translate browser extension - https://phabricator.wikimedia.org/T245563 (10Esanders) I too wouldn't expect any of our products to work wit... [17:23:35] 10Anti-Harassment, 10CheckUser: Iterate on the design of highlighting for Special:Investigate - https://phabricator.wikimedia.org/T246294 (10aezell) I think parsing the date string should be OK. Not sure how that might work with localization though. Maybe moment.js has some helpers for this? I think it's alrea... [17:27:06] (03Merged) 10jenkins-bot: Remove unused variables from closure use() lists [core] - 10https://gerrit.wikimedia.org/r/575624 (owner: 10Umherirrender) [17:27:08] (03Merged) 10jenkins-bot: Move TestOAuthSignatureMethod_RSA_SHA1 to anon inline class [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/571049 (owner: 10Umherirrender) [17:27:10] (03Merged) 10jenkins-bot: Dev: Provide stubbing for api and mw.config in dev [extensions/NearbyPages] - 10https://gerrit.wikimedia.org/r/575626 (owner: 10Jdlrobson) [17:27:12] (03Merged) 10jenkins-bot: ReplyWidget: Disable "Reply" button if input is empty [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/575660 (https://phabricator.wikimedia.org/T246058) (owner: 10Bartosz Dziewoński) [17:29:10] (03PS2) 10Esanders: Reply-to placeholder [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/575534 (https://phabricator.wikimedia.org/T245227) [17:29:18] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/575702 (owner: 10D3r1ck01) [17:29:43] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/575700 (owner: 10D3r1ck01) [17:30:37] 10Editing Design, 10OWC2020, 10Editing-team (Tracking): Determine our approach for displaying date and time a comment was made, in a user's local timezone and preferred date format - https://phabricator.wikimedia.org/T240360 (10Jc86035) You know, you could just display both... I imagine most people don't ha... [17:30:40] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 2.0): Implement opt-in/out of watching talk page in Replying workflow - https://phabricator.wikimedia.org/T245222 (10Esanders) See also {T245579} [17:38:25] 10Accessibility, 10MediaWiki-Watchlist, 10Growth-Team, 10MW-1.35-notes (1.35.0-wmf.22; 2020-03-03): Add accessibility label to menu widget - https://phabricator.wikimedia.org/T246513 (10Volker_E) 05Open→03Resolved I was searching for a corresponding task and here it is. Patch was https://gerrit.wikimed... [17:39:50] 10Editing Design, 10OWC2020, 10Editing-team (Tracking): Determine our approach for displaying date and time a comment was made, in a user's local timezone and preferred date format - https://phabricator.wikimedia.org/T240360 (10Jc86035) I don't think it makes sense to change the timestamp display upon hoveri... [17:48:51] (03PS4) 10Daimona Eaytoy: Add updateVarDumps to update.php [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/551603 (https://phabricator.wikimedia.org/T213006) [17:50:40] 10Google-Summer-of-Code (2020): Add leaderboard based on user's edits using Commons Android app - https://phabricator.wikimedia.org/T244197 (10Sudoaccessdenied) Hi Everyone, I am Nishant ,I am founder at Melonskart and student of JNU ,New Delhi, India.This project seems interested . [17:50:44] 10MediaWiki-Internationalization, 10Performance-Team, 10Release-Engineering-Team-TODO, 10Scap: Use static php array files for l10n cache at WMF (instead of CDB) - https://phabricator.wikimedia.org/T99740 (10Krinkle) ##### Debug profile These are the one-off Tideways/XHGui profiles from mwdebug1001 collect... [17:55:06] 10DiscussionTools, 10Editing-team (Tracking), 10OWC2020 (OWC2020 Replying 1.0): Reply links are not showing up for a Project Talk page on hu.wiki - https://phabricator.wikimedia.org/T245889 (10matmarex) Yes, that's right. # Yes, should be easy. # No, but they should be rare, and should only appear in old di... [17:56:53] (03CR) 10VolkerE: [C: 04-1] Fix: ListBox is not accessible to screen readers (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/570730 (https://phabricator.wikimedia.org/T244543) (owner: 10Akinwale-microsoft) [18:01:42] (03PS12) 10VolkerE: Don't let CodeMirror set the font to monospace if it's set on an ancestor. [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/572876 (https://phabricator.wikimedia.org/T245568) (owner: 10Aron Manning) [18:01:55] (03CR) 10VolkerE: [C: 03+2] Don't let CodeMirror set the font to monospace if it's set on an ancestor. [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/572876 (https://phabricator.wikimedia.org/T245568) (owner: 10Aron Manning) [18:05:10] 10Wikimedia-Hackathon-2020: Workshop for beginners on using Gerrit and Phabricator - https://phabricator.wikimedia.org/T246509 (10Aklapper) Heja @Dzahn, I was planning to run an "Intro to Phab" session [like last year](https://phabricator.wikimedia.org/T216261) which are basically [these slides](https://commons.... [18:07:00] (03Merged) 10jenkins-bot: Don't let CodeMirror set the font to monospace if it's set on an ancestor. [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/572876 (https://phabricator.wikimedia.org/T245568) (owner: 10Aron Manning) [18:08:00] 10MediaWiki-Internationalization, 10Performance-Team, 10Release-Engineering-Team-TODO, 10Scap: Use static php array files for l10n cache at WMF (instead of CDB) - https://phabricator.wikimedia.org/T99740 (10Krinkle) [18:08:38] (03PS1) 10Bartosz Dziewoński: Work around mw.Uri crash on fallback encoding in links [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/575708 (https://phabricator.wikimedia.org/T245889) [18:09:32] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 1.0), 10Patch-For-Review: Reply links are not showing up for a Project Talk page on hu.wiki - https://phabricator.wikimedia.org/T245889 (10matmarex) [18:09:58] 10Developer-Advocacy (Apr-Jun 2020), 10Wikimedia-Hackathon-2020: Technical development statistics (mostly Git and Gerrit) - https://phabricator.wikimedia.org/T246541 (10Aklapper) p:05Triage→03Lowest [18:10:13] 10Design, 10UI-Standardization, 10OOUI, 10UI-Standardization-Kanban: How to represent several articles/pages in icons? - https://phabricator.wikimedia.org/T246044 (10Esanders) I prefer `articles`. Is this the new tabs vs spaces? Flip a coin? [18:10:30] 10Developer-Advocacy (Apr-Jun 2020), 10Documentation: May 2020 Technical Engagement Newsletter - https://phabricator.wikimedia.org/T233125 (10Aklapper) [18:10:35] 10Developer-Advocacy (Apr-Jun 2020), 10Documentation: June 2020 Modern Event Platform program - https://phabricator.wikimedia.org/T241009 (10Aklapper) [18:10:37] 10Developer-Advocacy (Apr-Jun 2020), 10Documentation: July 2020 Technical Engagement Newsletter - https://phabricator.wikimedia.org/T233126 (10Aklapper) [18:10:39] 10Developer-Advocacy (Apr-Jun 2020), 10Documentation: Wikimedia Technical Talks: May 2020 - https://phabricator.wikimedia.org/T242255 (10Aklapper) [18:10:48] 10Developer-Advocacy (Apr-Jun 2020): Invite GCI 2019 winners and mentor to visit WMF SF office around June 21-25, 2020 - https://phabricator.wikimedia.org/T241929 (10Aklapper) [18:14:44] (03CR) 10Esanders: [C: 03+2] Work around mw.Uri crash on fallback encoding in links [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/575708 (https://phabricator.wikimedia.org/T245889) (owner: 10Bartosz Dziewoński) [18:19:38] (03Merged) 10jenkins-bot: Work around mw.Uri crash on fallback encoding in links [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/575708 (https://phabricator.wikimedia.org/T245889) (owner: 10Bartosz Dziewoński) [18:20:02] 10GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.35-notes (1.35.0-wmf.22; 2020-03-03): [betalabs] Newcomer tasks: se-card-end-of-queue displays Uncaught TypeError: this.currentCard.getTaskType is not a function - https://phabricator.wikimedia.org/T246512 (10Aklapper) [18:22:27] 10Wikimedia-GitHub: Add Inuka engineers to github Wikimedia org - https://phabricator.wikimedia.org/T246542 (10SBisson) [18:22:59] 10Wikimedia-GitHub: Add Inuka engineers to github Wikimedia org - https://phabricator.wikimedia.org/T246542 (10SBisson) [18:24:56] (03PS3) 10Krinkle: profiler: Remove support for $wgDebugLogGroups['profileoutput'] [core] - 10https://gerrit.wikimedia.org/r/575294 (https://phabricator.wikimedia.org/T245835) [18:30:30] (03CR) 10Krinkle: cssmin: Remove MediaWiki dependencies (031 comment) [core] - 10https://gerrit.wikimedia.org/r/573342 (https://phabricator.wikimedia.org/T88914) (owner: 10Anomie) [18:35:00] 10Design, 10UI-Standardization, 10OOUI, 10UI-Standardization-Kanban: How to represent several articles/pages in icons? - https://phabricator.wikimedia.org/T246044 (10Demian) >>! In T246044#5929609, @Esanders wrote: > I prefer `articles`. Is this the new tabs vs spaces? Flip a coin? > (see also https://then... [18:38:53] 10Wikimedia-GitHub: Add Inuka engineers to github Wikimedia org - https://phabricator.wikimedia.org/T246542 (10Krenair) 05Open→03Resolved a:03Krenair [18:40:54] 10Design, 10Growth-Team, 10Thanks, 10User-DannyS712: Design: What should happen if thanks fails - https://phabricator.wikimedia.org/T241550 (10Ahmad252) When thank isn't sent for non-AF reasons, I think there should be a notification like the one we see when a ping is unsuccessful, with a gray "File:OOjs U... [19:02:50] 10MediaWiki-Parser, 10Parsing-Team, 10Performance-Team, 10MW-1.35-notes (1.35.0-wmf.21; 2020-02-25), 10User-notice: Change {{REVISIONID}} from number to "-" in wgMiserMode - https://phabricator.wikimedia.org/T235957 (10Pppery) >>! In T235957#5927239, @Wbm1058 wrote: > Thanks, but this link https://en.wik... [19:04:46] 10Editing Design, 10OWC2020, 10Editing-team (Tracking): Determine our approach for displaying date and time a comment was made, in a user's local timezone and preferred date format - https://phabricator.wikimedia.org/T240360 (10Demian) >>! In T240360#5929546, @Jc86035 wrote: > You know, you could just displa... [19:06:46] 10MediaWiki-General, 10Wikidata, 10Wikidata-Campsite, 10Wikimedia-production-error: Using Special:NewItem on wikidata.org sometimes times out - https://phabricator.wikimedia.org/T246288 (10Krinkle) [19:09:34] 10MediaWiki-General, 10Wikidata, 10Wikidata-Campsite, 10Wikimedia-production-error: Using Special:NewItem on wikidata.org sometimes times out - https://phabricator.wikimedia.org/T246288 (10Krinkle) @Addshore Time outs often happen in unrelated code. It is not an indicating that the unrelated code is where... [19:09:40] 10MediaWiki-General, 10Wikidata, 10Wikidata-Campsite, 10Wikimedia-production-error: Using Special:NewItem on wikidata.org sometimes times out - https://phabricator.wikimedia.org/T246288 (10Krinkle) 05Open→03Declined [19:10:06] 10MediaWiki-Change-tagging, 10Core Platform Team, 10MassMessage, 10Wikimedia-production-error: At least one of: RCID, revision ID, and log ID MUST be specified when adding or removing a tag from a change! - https://phabricator.wikimedia.org/T246217 (10Krinkle) [19:12:49] 10MediaWiki-Special-pages, 10Wikidata, 10Wikidata-Campsite, 10Wikimedia-database-error: SpecialFewestRevisions::reallyDoQuery takes more than 9h to run - https://phabricator.wikimedia.org/T238199 (10Krinkle) [19:14:22] 10MediaWiki-Parser, 10Parsoid, 10Performance-Team, 10Patch-For-Review, 10User-notice: Deal with poor edit stash hit rate due to Lua modules using {{REVISIONID}} - https://phabricator.wikimedia.org/T137900 (10Pppery) [19:14:45] 10MediaWiki-Parser, 10Parsoid, 10Performance-Team, 10User-notice: Deal with poor edit stash hit rate due to Lua modules using {{REVISIONID}} - https://phabricator.wikimedia.org/T137900 (10Pppery) [19:16:16] (03CR) 10Krinkle: [C: 03+2] Stop using reserved word 'host' as logging parameter [core] - 10https://gerrit.wikimedia.org/r/575278 (https://phabricator.wikimedia.org/T245280) (owner: 10Reedy) [19:16:18] (03PS2) 10Krinkle: rdbms: Avoid using reserved word "host" in Monolog context keys [core] - 10https://gerrit.wikimedia.org/r/575278 (https://phabricator.wikimedia.org/T245280) (owner: 10Reedy) [19:16:20] (03CR) 10Krinkle: rdbms: Avoid using reserved word "host" in Monolog context keys [core] - 10https://gerrit.wikimedia.org/r/575278 (https://phabricator.wikimedia.org/T245280) (owner: 10Reedy) [19:16:22] (03CR) 10Krinkle: [C: 03+2] rdbms: Avoid using reserved word "host" in Monolog context keys [core] - 10https://gerrit.wikimedia.org/r/575278 (https://phabricator.wikimedia.org/T245280) (owner: 10Reedy) [19:17:44] (03CR) 10Fomafix: [C: 04-1] "The indicator for expanding the headline menu (up arrow) is now missing." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/575690 (owner: 10Esanders) [19:19:55] 10CirrusSearch, 10Discovery-Search: Update restify in CirrusSearch extension - https://phabricator.wikimedia.org/T246543 (10Umherirrender) [19:26:31] 10MinervaNeue: Update svgo in MinervaNeue skin - https://phabricator.wikimedia.org/T246544 (10Umherirrender) [19:31:02] (03Merged) 10jenkins-bot: rdbms: Avoid using reserved word "host" in Monolog context keys [core] - 10https://gerrit.wikimedia.org/r/575278 (https://phabricator.wikimedia.org/T245280) (owner: 10Reedy) [19:32:16] 10Modern, 10Chinese-Sites: Visual editor is not compatible with Modern skin - https://phabricator.wikimedia.org/T227410 (10Cohaf) Hello, No updates since Jul. Is it a yes or a no? Or what is the status of adding the button to the skin now? I know this is sort of low priority but is there any news. Thanks so... [19:33:16] (03PS18) 10Aron Manning: Replace Grunt tasks with NPM scripts. Devdependencies not updated. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/574636 (https://phabricator.wikimedia.org/T246321) [19:33:18] (03PS3) 10Aron Manning: Replace grunt* devdependencies with eslint, update node_modules dependencies in package-lock.json [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575665 (https://phabricator.wikimedia.org/T245930) [19:33:20] (03PS3) 10Aron Manning: Regenerate package-lock.json [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575666 (https://phabricator.wikimedia.org/T245930) [19:37:19] (03CR) 10jerkins-bot: [V: 04-1] Regenerate package-lock.json [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575666 (https://phabricator.wikimedia.org/T245930) (owner: 10Aron Manning) [19:37:25] (03CR) 10Krinkle: Menu items added via addPortletLinks should look like other menu items (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/571111 (https://phabricator.wikimedia.org/T236711) (owner: 10Jdlrobson) [19:38:59] (03PS2) 10Krinkle: skins: Remove incorrect comment about msgWiki() deprecation [core] - 10https://gerrit.wikimedia.org/r/575694 (owner: 10D3r1ck01) [19:39:55] (03CR) 10Krinkle: [C: 04-1] "Revision::newKnownCurrent returns 'new Revision' at the end, which this does not add." [core] - 10https://gerrit.wikimedia.org/r/575691 (owner: 10D3r1ck01) [19:40:03] (03PS3) 10Krinkle: skins: Remove incorrect comment about msgWiki() deprecation [core] - 10https://gerrit.wikimedia.org/r/575694 (owner: 10D3r1ck01) [19:40:07] (03CR) 10Krinkle: [C: 03+2] skins: Remove incorrect comment about msgWiki() deprecation [core] - 10https://gerrit.wikimedia.org/r/575694 (owner: 10D3r1ck01) [19:49:29] (03CR) 10Jayprakash12345: "recheck" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/574224 (https://phabricator.wikimedia.org/T243932) (owner: 10Sohom Datta) [19:52:50] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Wikimedia-production-error: BannerDataException: Banner name must be in format /^[A-Za-z0-9_]+$/ - https://phabricator.wikimedia.org/T244020 (10Krinkle) [19:53:47] (03CR) 10Jforrester: [C: 03+1] Add a maintenance script to block a list of users (031 comment) [core] - 10https://gerrit.wikimedia.org/r/575374 (https://phabricator.wikimedia.org/T246368) (owner: 10Reedy) [19:54:17] (03CR) 10Jforrester: [C: 03+2] Don't use logging reserved word 'ip' as parameter [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/575257 (https://phabricator.wikimedia.org/T245280) (owner: 10Reedy) [19:54:54] (03CR) 10Jforrester: [C: 03+2] Split FakeMaintenance and LoggedUpdateMaintenance to their own files [core] - 10https://gerrit.wikimedia.org/r/575619 (owner: 10Reedy) [19:55:25] (03Merged) 10jenkins-bot: skins: Remove incorrect comment about msgWiki() deprecation [core] - 10https://gerrit.wikimedia.org/r/575694 (owner: 10D3r1ck01) [19:56:04] (03PS1) 10Umherirrender: Enable Generic.Files.LineLength.TooLong and make pass [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/575715 [19:56:06] (03CR) 10Jforrester: [C: 03+2] Updating ramsey/uuid (3.9.2 => 3.9.3) [vendor] - 10https://gerrit.wikimedia.org/r/575629 (owner: 10Reedy) [19:56:44] (03CR) 10Jforrester: [C: 03+2] Updating spomky-labs/cbor-php (v1.0.7 => v1.0.8) [vendor] - 10https://gerrit.wikimedia.org/r/575630 (owner: 10Reedy) [19:57:38] (03CR) 10Jforrester: [C: 03+2] Updating symfony/polyfill-php73 (v1.13.1 => v1.14.0) [vendor] - 10https://gerrit.wikimedia.org/r/575632 (owner: 10Reedy) [19:57:48] (03CR) 10Jforrester: [C: 03+2] Move PHP files into includes dir. Match to class name [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/575597 (owner: 10Reedy) [19:59:43] (03Abandoned) 10Zoranzoki21: Add phpcs and make it pass [extensions/WhitelistPages] - 10https://gerrit.wikimedia.org/r/572469 (owner: 10Zoranzoki21) [20:02:41] (03CR) 10Krinkle: [C: 03+2] include blob: as a default script-src [core] - 10https://gerrit.wikimedia.org/r/574401 (https://phabricator.wikimedia.org/T245981) (owner: 10Brian Wolff) [20:03:05] 10MediaWiki-extensions-NavigationTiming, 10ContentSecurityPolicy, 10Performance-Team, 10Patch-For-Review: NavigationTiming extension causes CSP report from using a blob url via webworker - https://phabricator.wikimedia.org/T245981 (10Krinkle) 05Open→03Resolved a:05Krinkle→03Bawolff [20:06:55] (03Merged) 10jenkins-bot: Don't use logging reserved word 'ip' as parameter [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/575257 (https://phabricator.wikimedia.org/T245280) (owner: 10Reedy) [20:08:07] (03PS1) 10Umherirrender: Add missing public visibility on some methods [core] - 10https://gerrit.wikimedia.org/r/575716 [20:08:54] (03Merged) 10jenkins-bot: Split FakeMaintenance and LoggedUpdateMaintenance to their own files [core] - 10https://gerrit.wikimedia.org/r/575619 (owner: 10Reedy) [20:10:45] (03Merged) 10jenkins-bot: Updating ramsey/uuid (3.9.2 => 3.9.3) [vendor] - 10https://gerrit.wikimedia.org/r/575629 (owner: 10Reedy) [20:10:47] (03Merged) 10jenkins-bot: Updating spomky-labs/cbor-php (v1.0.7 => v1.0.8) [vendor] - 10https://gerrit.wikimedia.org/r/575630 (owner: 10Reedy) [20:10:49] (03CR) 10jerkins-bot: [V: 04-1] Updating symfony/polyfill-php73 (v1.13.1 => v1.14.0) [vendor] - 10https://gerrit.wikimedia.org/r/575632 (owner: 10Reedy) [20:10:51] (03Merged) 10jenkins-bot: Move PHP files into includes dir. Match to class name [extensions/BlockAndNuke] - 10https://gerrit.wikimedia.org/r/575597 (owner: 10Reedy) [20:11:03] 10Wiki-Loves-Monuments: Wiki loves Monuments Database / tools - https://phabricator.wikimedia.org/T246545 (10Erinamukuta) [20:13:05] (03CR) 10D3r1ck01: "> Are the two different objects fully compatible for the purposes exposed here?" [core] - 10https://gerrit.wikimedia.org/r/575691 (owner: 10D3r1ck01) [20:15:35] 10Wiki-Loves-Monuments-Database: Queries of wiki loves monuments Database - https://phabricator.wikimedia.org/T246546 (10Erinamukuta) [20:17:00] (03PS19) 10Aron Manning: Replace Grunt tasks with NPM scripts. Devdependencies not updated. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/574636 (https://phabricator.wikimedia.org/T246321) [20:17:02] (03PS4) 10Aron Manning: Remove grunt* devdependencies, update dependencies in package-lock.json [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575665 (https://phabricator.wikimedia.org/T245930) [20:17:04] (03PS4) 10Aron Manning: Regenerate package-lock.json [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575666 (https://phabricator.wikimedia.org/T245930) [20:17:07] (03Merged) 10jenkins-bot: include blob: as a default script-src [core] - 10https://gerrit.wikimedia.org/r/574401 (https://phabricator.wikimedia.org/T245981) (owner: 10Brian Wolff) [20:18:21] (03PS20) 10Aron Manning: Replace Grunt tasks with NPM scripts. Devdependencies not updated. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/574636 (https://phabricator.wikimedia.org/T246321) [20:18:23] (03PS5) 10Aron Manning: Remove grunt* devdependencies, update dependencies in package-lock.json [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575665 (https://phabricator.wikimedia.org/T245930) [20:18:25] (03PS5) 10Aron Manning: Regenerate package-lock.json [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575666 (https://phabricator.wikimedia.org/T245930) [20:18:51] (03Abandoned) 10Aron Manning: [TEST] Regenerate 'package-lock.json' [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575396 (owner: 10Aron Manning) [20:20:37] 10Desktop Improvements, 10MW-1.35-notes (1.35.0-wmf.22; 2020-03-03), 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): Add a Vector skin version preference - https://phabricator.wikimedia.org/T242381 (10Edtadros) a:05Edtadros→03olga This still needs QA steps. Might have fallen off your radar. [20:21:24] (03CR) 10jerkins-bot: [V: 04-1] Add missing public visibility on some methods [core] - 10https://gerrit.wikimedia.org/r/575716 (owner: 10Umherirrender) [20:22:07] (03CR) 10jerkins-bot: [V: 04-1] Remove grunt* devdependencies, update dependencies in package-lock.json [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575665 (https://phabricator.wikimedia.org/T245930) (owner: 10Aron Manning) [20:22:15] (03CR) 10jerkins-bot: [V: 04-1] Regenerate package-lock.json [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575666 (https://phabricator.wikimedia.org/T245930) (owner: 10Aron Manning) [20:22:30] (03PS2) 10Aron Manning: Update node_modules dependencies in package-lock.json after deleting node_modules [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575668 [20:22:51] (03Abandoned) 10Aron Manning: Update node_modules dependencies in package-lock.json after deleting node_modules [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575668 (owner: 10Aron Manning) [20:23:55] 10ISA: Profile page with list of own campaigns - https://phabricator.wikimedia.org/T232835 (10Gabrielchihonglee) 05Open→03Resolved [20:26:34] 10Library-Card-Platform: Server 500 on trying to modify application status from INVALID to anything else - https://phabricator.wikimedia.org/T239503 (10lalit97) Hello @Samwalton9 I am able to reproduce this error, and I think I can fix this. Can I work on this one? [20:28:29] (03CR) 10Aron Manning: Remove grunt* devdependencies, update dependencies in package-lock.json (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575665 (https://phabricator.wikimedia.org/T245930) (owner: 10Aron Manning) [20:28:42] (03PS1) 10Umherirrender: Improve param docs [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/575720 [20:31:36] (03PS1) 10Umherirrender: Improve param docs [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/575721 [20:34:13] (03PS1) 10Umherirrender: Improve param docs [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/575722 [20:37:47] (03PS1) 10Umherirrender: Improve param docs [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/575723 [20:39:40] 10MediaWiki-Docker, 10Core Platform Team: Warning: file_put_contents(/en.l10n.php): failed to open stream: Permission denied in /var/www/html/includes/cache/localisation/LCStoreStaticArray.php on line 123 - https://phabricator.wikimedia.org/T246547 (10kostajh) [20:40:09] (03PS1) 10Kosta Harlan: DevelopmentSettings: Set cache dir to system temp by default [core] - 10https://gerrit.wikimedia.org/r/575724 (https://phabricator.wikimedia.org/T246547) [20:43:43] 10MediaWiki-Docker: Set log dir in compose environment variables - https://phabricator.wikimedia.org/T246548 (10kostajh) [20:44:18] (03PS21) 10Aron Manning: Replace Grunt tasks with NPM scripts. Devdependencies not updated. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/574636 (https://phabricator.wikimedia.org/T246321) [20:44:20] (03PS6) 10Aron Manning: Remove grunt* devdependencies, update dependencies in package-lock.json [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575665 (https://phabricator.wikimedia.org/T245930) [20:44:22] (03PS6) 10Aron Manning: Regenerate package-lock.json [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575666 (https://phabricator.wikimedia.org/T245930) [20:45:09] (03PS1) 10Kosta Harlan: [docker] Set log directory by default [core] - 10https://gerrit.wikimedia.org/r/575726 (https://phabricator.wikimedia.org/T246548) [20:46:04] (03Restored) 10Aron Manning: [Typography] Fix sizes and consistent font usage of headings h1-h6. [skins/Vector] - 10https://gerrit.wikimedia.org/r/573052 (https://phabricator.wikimedia.org/T65844) (owner: 10Aron Manning) [20:46:30] (03PS3) 10Aron Manning: [POC] [Typography] Fix sizes and consistent font usage of headings h1-h6. [skins/Vector] - 10https://gerrit.wikimedia.org/r/573052 (https://phabricator.wikimedia.org/T65844) [20:48:12] (03CR) 10Aron Manning: "This was lost from Gerrit's "Recently closed" list, therefore I've restored it as POC WIP." [skins/Vector] - 10https://gerrit.wikimedia.org/r/573052 (https://phabricator.wikimedia.org/T65844) (owner: 10Aron Manning) [20:48:46] (03CR) 10jerkins-bot: [V: 04-1] Regenerate package-lock.json [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575666 (https://phabricator.wikimedia.org/T245930) (owner: 10Aron Manning) [20:48:51] (03CR) 10jerkins-bot: [V: 04-1] Remove grunt* devdependencies, update dependencies in package-lock.json [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575665 (https://phabricator.wikimedia.org/T245930) (owner: 10Aron Manning) [20:48:54] (03PS5) 10Aron Manning: [POC] [Typography] Apply the same relative heading sizes as for Vector. h2 is now clearly bigger than h3. [core] - 10https://gerrit.wikimedia.org/r/573035 (https://phabricator.wikimedia.org/T71999) [20:53:49] (03CR) 10Fomafix: resourceloader: Avoid deprecated Revision class and use MCR approach (031 comment) [core] - 10https://gerrit.wikimedia.org/r/575691 (owner: 10D3r1ck01) [20:57:33] (03PS2) 10D3r1ck01: resourceloader: Avoid deprecated Revision class and use MCR approach [core] - 10https://gerrit.wikimedia.org/r/575691 [20:57:54] (03CR) 10D3r1ck01: resourceloader: Avoid deprecated Revision class and use MCR approach (031 comment) [core] - 10https://gerrit.wikimedia.org/r/575691 (owner: 10D3r1ck01) [21:00:08] (03CR) 10Reedy: "flaky tests?" [vendor] - 10https://gerrit.wikimedia.org/r/575632 (owner: 10Reedy) [21:03:40] 10UI-Standardization, 10CheckUser, 10good first task: CheckUser should not hardcode parentheses in the HTML - https://phabricator.wikimedia.org/T223872 (10Kapilchhipa4) hi @Jdlrobson i have set up the mediawiki locally. I want to work on this issue. please help me how should I get start. [21:03:59] (03CR) 10Reedy: Add a maintenance script to block a list of users (031 comment) [core] - 10https://gerrit.wikimedia.org/r/575374 (https://phabricator.wikimedia.org/T246368) (owner: 10Reedy) [21:05:43] (03CR) 10Umherirrender: Split FakeMaintenance and LoggedUpdateMaintenance to their own files (031 comment) [core] - 10https://gerrit.wikimedia.org/r/575619 (owner: 10Reedy) [21:08:58] (03CR) 10Gergő Tisza: [C: 04-1] Allow site owners to render block reason at a particular wiki (037 comments) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/568420 (https://phabricator.wikimedia.org/T243863) (owner: 10Urbanecm) [21:09:19] (03CR) 10Florianschmidtwelzow: "Puhh... First of all: Thanks for fixing this. However, what I kind of dislike is, that the user of the logging interfaces in MediaWiki's c" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/575257 (https://phabricator.wikimedia.org/T245280) (owner: 10Reedy) [21:11:04] (03PS1) 10Umherirrender: Improve param docs [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/575728 [21:14:17] (03PS1) 10Umherirrender: Improve param docs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/575729 [21:15:49] (03CR) 10Reedy: "recheck" [vendor] - 10https://gerrit.wikimedia.org/r/575632 (owner: 10Reedy) [21:16:10] (03PS4) 10Urbanecm: Allow site owners to render block reason at a particular wiki [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/568420 (https://phabricator.wikimedia.org/T243863) [21:16:16] (03CR) 10jerkins-bot: [V: 04-1] Allow site owners to render block reason at a particular wiki [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/568420 (https://phabricator.wikimedia.org/T243863) (owner: 10Urbanecm) [21:16:49] (03PS2) 10Umherirrender: Add missing public visibility on some methods [core] - 10https://gerrit.wikimedia.org/r/575716 [21:17:31] (03PS1) 10Umherirrender: Improve param docs [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/575730 [21:18:01] (03PS5) 10Urbanecm: Allow site owners to render block reason at a particular wiki [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/568420 (https://phabricator.wikimedia.org/T243863) [21:18:14] (03CR) 10jerkins-bot: [V: 04-1] Allow site owners to render block reason at a particular wiki [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/568420 (https://phabricator.wikimedia.org/T243863) (owner: 10Urbanecm) [21:18:44] (03CR) 10Urbanecm: Allow site owners to render block reason at a particular wiki (036 comments) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/568420 (https://phabricator.wikimedia.org/T243863) (owner: 10Urbanecm) [21:18:48] (03PS1) 10Umherirrender: Improve param docs [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/575731 [21:19:34] (03PS6) 10Urbanecm: Allow site owners to render block reason at a particular wiki [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/568420 (https://phabricator.wikimedia.org/T243863) [21:20:07] (03CR) 10Urbanecm: Allow site owners to render block reason at a particular wiki (031 comment) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/568420 (https://phabricator.wikimedia.org/T243863) (owner: 10Urbanecm) [21:21:03] (03PS1) 10Umherirrender: Improve param docs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/575733 [21:23:05] (03PS1) 10Umherirrender: Improve param docs [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/575734 [21:24:04] 10MediaWiki-General, 10Technical-Debt, 10good first task: Deprecate and remove QueryPage::getSQL() - https://phabricator.wikimedia.org/T244138 (10Kapilchhipa4) im tring to clone a repository but it is giving this error. C:\xampp\htdocs>git clone ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CheckU... [21:27:07] 10ISA: Add participant/country tables to campaign page on mobile - https://phabricator.wikimedia.org/T232839 (10Gabrielchihonglee) 05Open→03Resolved [21:28:01] (03PS1) 10Fomafix: Add z-index: 1 to menu options [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/575735 (https://phabricator.wikimedia.org/T246550) [21:28:21] (03PS1) 10Umherirrender: Improve param docs [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/575736 [21:28:23] 10ISA: Improve sizing of titles on Campaign home and stats page - https://phabricator.wikimedia.org/T232838 (10Gabrielchihonglee) 05Open→03Resolved [21:28:26] (03CR) 10Krinkle: [C: 03+2] Improve param docs [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/575734 (owner: 10Umherirrender) [21:28:43] (03CR) 10Krinkle: [C: 03+2] Improve param docs [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/575730 (owner: 10Umherirrender) [21:28:49] (03PS7) 10Aron Manning: Remove grunt* devdependencies, update dependencies in package-lock.json [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575665 (https://phabricator.wikimedia.org/T245930) [21:28:51] (03PS7) 10Aron Manning: Regenerate package-lock.json [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575666 (https://phabricator.wikimedia.org/T245930) [21:29:13] (03CR) 10Krinkle: [C: 03+2] Improve param docs [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/575721 (owner: 10Umherirrender) [21:30:34] 10ISA: Return to current previous page after login - https://phabricator.wikimedia.org/T232818 (10Gabrielchihonglee) 05Open→03Resolved [21:30:59] 10ISA: Edit box highlight and depict helper text - https://phabricator.wikimedia.org/T226525 (10Gabrielchihonglee) 05Open→03Resolved [21:31:36] 10ISA: Add pie charts to campaign stats page - https://phabricator.wikimedia.org/T232397 (10Gabrielchihonglee) 05Open→03Resolved [21:31:49] 10ISA: Update stats page - https://phabricator.wikimedia.org/T232522 (10Gabrielchihonglee) 05Open→03Resolved [21:32:35] 10ISA: Add url link on participant user name in the campaign page - https://phabricator.wikimedia.org/T232185 (10Gabrielchihonglee) 05Open→03Resolved [21:32:45] 10ISA: Change "images improved" to "contributions" on stats tables - https://phabricator.wikimedia.org/T231186 (10Gabrielchihonglee) 05Open→03Resolved [21:32:49] (03Merged) 10jenkins-bot: Improve param docs [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/575734 (owner: 10Umherirrender) [21:32:59] 10ISA: Add campaign id to edit summary - https://phabricator.wikimedia.org/T232274 (10Gabrielchihonglee) 05Open→03Resolved [21:33:42] 10ISA: Add missing required fields to campaign form - https://phabricator.wikimedia.org/T231435 (10Gabrielchihonglee) 05Open→03Resolved [21:33:59] 10ISA: Remove legend from campaign stats page charts - https://phabricator.wikimedia.org/T233315 (10Gabrielchihonglee) 05Open→03Resolved [21:34:33] (03Merged) 10jenkins-bot: Improve param docs [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/575730 (owner: 10Umherirrender) [21:34:35] (03Merged) 10jenkins-bot: Improve param docs [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/575721 (owner: 10Umherirrender) [21:36:46] (03PS1) 10Umherirrender: Improve param docs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/575739 [21:37:40] (03PS1) 10Umherirrender: Improve param docs [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/575740 [21:38:06] (03PS2) 10Umherirrender: Improve param docs [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/575740 [21:38:21] (03CR) 10Aron Manning: "The chain (3 patches) is ready for review." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/574636 (https://phabricator.wikimedia.org/T246321) (owner: 10Aron Manning) [21:40:14] (03PS1) 10Umherirrender: Improve param docs [extensions/Wikisource] - 10https://gerrit.wikimedia.org/r/575741 [21:43:19] (03PS3) 10Aron Manning: Update node_modules dependencies in package-lock.json [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575664 [21:43:35] (03PS4) 10Aron Manning: Update node_modules dependencies in package-lock.json [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575664 [21:44:00] (03Abandoned) 10Aron Manning: Update node_modules dependencies in package-lock.json [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575664 (owner: 10Aron Manning) [21:44:04] (03Restored) 10Aron Manning: Update node_modules dependencies in package-lock.json [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575664 (owner: 10Aron Manning) [21:44:11] (03Abandoned) 10Aron Manning: Update node_modules dependencies in package-lock.json [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575664 (owner: 10Aron Manning) [21:45:51] (03PS2) 10Fomafix: Add z-index: 1 to menu options [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/575735 (https://phabricator.wikimedia.org/T246550) [21:47:59] 10MediaWiki-General, 10Epic, 10Technical-Debt: Transition Gruntfile.js tasks to NPM scripts (process template) - https://phabricator.wikimedia.org/T246326 (10Demian) [21:48:59] 10MediaWiki-General, 10Epic, 10Technical-Debt: Transition Gruntfile.js tasks to NPM scripts (process template) - https://phabricator.wikimedia.org/T246326 (10Demian) [21:52:04] (03CR) 10Fomafix: "I wonder that a @return to a private function should solve the phpcs rule exception, because there are other private functions without @re" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/575731 (owner: 10Umherirrender) [21:54:37] (03CR) 10Umherirrender: "The other private function is missing the comment at all, that is MissingDocumentationPrivate." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/575731 (owner: 10Umherirrender) [21:54:51] (03PS10) 10Fomafix: Enable spellchecking on Firefox [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/421349 (https://phabricator.wikimedia.org/T177509) (owner: 10Niharika29) [21:59:03] (03CR) 10Umherirrender: Remove grunt* devdependencies, update dependencies in package-lock.json (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/575665 (https://phabricator.wikimedia.org/T245930) (owner: 10Aron Manning) [22:00:44] (03PS1) 10Kosta Harlan: DEVELOPERS.md: Remove reference to Docker/Recipes [core] - 10https://gerrit.wikimedia.org/r/575743 (https://phabricator.wikimedia.org/T246433) [22:04:52] (03CR) 10Umherirrender: Bundle services at top of TraditionalImageGallery::toHtml (032 comments) [core] - 10https://gerrit.wikimedia.org/r/574213 (owner: 10Umherirrender) [23:23:47] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Record InukaPageView from KaiOS app - https://phabricator.wikimedia.org/T242358 (10nshahquinn-wmf) >>! In T242358#5928187, @mpopov wrote: >> It doesn't look like we can spoof the user agent on the `sendBeacon` call. Have you seen this being done before? > > Nope :... [23:55:08] (03CR) 10D3r1ck01: "> Patch Set 3: Code-Review+2" [core] - 10https://gerrit.wikimedia.org/r/575694 (owner: 10D3r1ck01)