[00:03:35] 04(no projects): Wikimedia-Site-requests - https://phabricator.wikimedia.org/T245323 (10CoppAB) [00:06:02] (03CR) 10Bartosz Dziewoński: [C: 03+2] widgets: Split out SearchWidgets into their own tree [core] - 10https://gerrit.wikimedia.org/r/342282 (owner: 10Jforrester) [00:07:41] 10Wikimedia-Site-requests: Throttle exemption for Vancouver Community College library event - https://phabricator.wikimedia.org/T245323 (10Reedy) [00:08:28] 10MediaWiki-Parser, 10Parsoid: Migrate sanitizer to HTML5 semantics - https://phabricator.wikimedia.org/T145002 (10ssastry) [00:11:41] 10MediaWiki-General, 10Technical-Debt, 10User-DannyS712: Remove $wgAllowImageMoving - https://phabricator.wikimedia.org/T245293 (10Reedy) Noting there is already a 'movefile' right anyway.... [00:15:59] (03PS13) 10Reedy: Add missing schema change update patches [extensions/Jade] - 10https://gerrit.wikimedia.org/r/511080 (https://phabricator.wikimedia.org/T223747) [00:18:14] 10Wikimedia-Site-requests: Throttle exemption for Vancouver Community College library event - https://phabricator.wikimedia.org/T245323 (10Reedy) p:05Triage→03Medium [00:20:13] (03Merged) 10jenkins-bot: widgets: Split out SearchWidgets into their own tree [core] - 10https://gerrit.wikimedia.org/r/342282 (owner: 10Jforrester) [00:26:36] 10Product-Analytics (Kanban): Update wmfdata to use sensible Spark settings - https://phabricator.wikimedia.org/T245097 (10nshahquinn-wmf) I've requested input from #analytics on their email list, and will push the update once I've heard from them. In the meantime, if you're having trouble with wmfdata.hive (pa... [00:28:33] 10MobileFrontend, 10Readers-Web-Backlog, 10VisualEditor, 10Mobile: VisualDiff toggle buttons appear in mobile when the relevant page doesn't have wikitext content model - https://phabricator.wikimedia.org/T245172 (10Jdlrobson) [00:29:54] 10MobileFrontend, 10VisualEditor, 10VisualEditor-VisualDiffs, 10Mobile, 10Readers-Web-Backlog (Tracking): VisualDiff toggle buttons appear in mobile when the relevant page doesn't have wikitext content model - https://phabricator.wikimedia.org/T245172 (10Jdlrobson) > Current special:mobilediff creates a... [00:34:17] 10MinervaNeue, 10Structured Data Engineering, 10Structured-Data-Backlog, 10Readers-Web-Backlog (Kanbanana-2019-20-Q3), 10Wikimedia-production-error: Job unable to create file page "Fatal: Call function inNamespace() on null" (via MinervaHooks) - https://phabricator.wikimedia.org/T245162 (10Jdlrobson) Thi... [00:35:12] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Patch-For-Review: Consider using JSON.parse() literal for startup manifest - https://phabricator.wikimedia.org/T245313 (10Krinkle) [00:40:44] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Patch-For-Review: Consider using JSON.parse() literal for startup manifest - https://phabricator.wikimedia.org/T245313 (10Krinkle) ##### Results from Fresnel This is with MediaWiki core using Headless Chromium, run on WMF CI: |Metric|Before|After|Difference... [00:40:49] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Patch-For-Review: Consider using JSON.parse() literal for startup manifest - https://phabricator.wikimedia.org/T245313 (10Krinkle) p:05Triage→03Low [00:41:27] 10MediaWiki-General, 10Technical-Debt (Deprecation process), 10User-DannyS712: Hard deprecate Title user permission methods - https://phabricator.wikimedia.org/T244922 (10DannyS712) p:05Triage→03Medium [00:41:39] 10MediaWiki-General, 10MediaWiki-extensions-LiquidThreads, 10MediaWiki-extensions-Newsletter, 10MediaWiki-extensions-Nuke, and 11 others: Hard deprecate Title::getUserPermissionsErrors - https://phabricator.wikimedia.org/T244929 (10DannyS712) p:05Triage→03Medium [00:43:51] (03PS1) 10DannyS712: Article: Remove use of Title::getUserPermissionsErrors (part 3) [core] - 10https://gerrit.wikimedia.org/r/572370 (https://phabricator.wikimedia.org/T244929) [00:44:25] 10MobileFrontend, 10VisualEditor, 10VisualEditor-VisualDiffs, 10Mobile, 10Readers-Web-Backlog (Tracking): VisualDiff toggle buttons appear in mobile when the relevant page doesn't have wikitext content model - https://phabricator.wikimedia.org/T245172 (10Masumrezarock100) >>! In T245172#5886707, @Jdlrobs... [00:45:30] 10MediaWiki-ResourceLoader, 10Librarization, 10Performance-Team, 10Core Platform Team Workboards (Clinic Duty Team), 10patch-welcome: CSSMin library calls global function wfExpandUrl() - https://phabricator.wikimedia.org/T88914 (10Krinkle) For third-parties, letting `url(./foo/bar.png)` and `url(../image... [00:52:55] (03CR) 10Reedy: Add ar_del_time (033 comments) [core] - 10https://gerrit.wikimedia.org/r/572134 (https://phabricator.wikimedia.org/T245234) (owner: 10Superbass) [00:54:30] (03PS1) 10Accraze: Merge branch 'master' into review/kevin_bazira/css/552616 [extensions/Jade] - 10https://gerrit.wikimedia.org/r/572372 [00:54:42] (03CR) 10jerkins-bot: [V: 04-1] Merge branch 'master' into review/kevin_bazira/css/552616 [extensions/Jade] - 10https://gerrit.wikimedia.org/r/572372 (owner: 10Accraze) [00:56:51] (03PS2) 10Accraze: Implemented Jade UI styles based on wireframe [extensions/Jade] - 10https://gerrit.wikimedia.org/r/571508 (https://phabricator.wikimedia.org/T242648) (owner: 10Kevin Bazira) [00:56:59] (03CR) 10jerkins-bot: [V: 04-1] Implemented Jade UI styles based on wireframe [extensions/Jade] - 10https://gerrit.wikimedia.org/r/571508 (https://phabricator.wikimedia.org/T242648) (owner: 10Kevin Bazira) [00:58:10] (03PS2) 10DannyS712: Article: Remove use of Title::getUserPermissionsErrors (part 3) [core] - 10https://gerrit.wikimedia.org/r/572370 (https://phabricator.wikimedia.org/T244929) [00:58:54] 10MediaWiki-General, 10MediaWiki-extensions-LiquidThreads, 10MediaWiki-extensions-Newsletter, 10MediaWiki-extensions-Nuke, and 11 others: Hard deprecate Title::getUserPermissionsErrors - https://phabricator.wikimedia.org/T244929 (10DannyS712) Doing the core patches separately because they sometimes include... [01:01:40] (03Abandoned) 10Accraze: Merge branch 'master' into review/kevin_bazira/css/552616 [extensions/Jade] - 10https://gerrit.wikimedia.org/r/572372 (owner: 10Accraze) [01:07:47] (03CR) 10DannyS712: [C: 04-1] tests: Use PHPUnit's `assertNull()` in lieu of `assertSame( null, ... )` (031 comment) [core] - 10https://gerrit.wikimedia.org/r/571831 (owner: 10D3r1ck01) [01:08:00] (03CR) 10DannyS712: [C: 03+1] "Misclick" [core] - 10https://gerrit.wikimedia.org/r/571831 (owner: 10D3r1ck01) [01:10:10] (03PS7) 10Jforrester: Replace use of ArticleEditUpdates hook with RevisionDataUpdates [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/571392 (https://phabricator.wikimedia.org/T245175) [01:10:21] (03CR) 10Jforrester: Replace use of ArticleEditUpdates hook with RevisionDataUpdates (032 comments) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/571392 (https://phabricator.wikimedia.org/T245175) (owner: 10Jforrester) [01:12:06] (03CR) 10jerkins-bot: [V: 04-1] Replace use of ArticleEditUpdates hook with RevisionDataUpdates [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/571392 (https://phabricator.wikimedia.org/T245175) (owner: 10Jforrester) [01:13:17] (03CR) 10jerkins-bot: [V: 04-1] Article: Remove use of Title::getUserPermissionsErrors (part 3) [core] - 10https://gerrit.wikimedia.org/r/572370 (https://phabricator.wikimedia.org/T244929) (owner: 10DannyS712) [01:14:13] (03CR) 10DannyS712: [C: 04-1] Fix: Add alt text to MediaResultWidget image (033 comments) [core] - 10https://gerrit.wikimedia.org/r/572336 (https://phabricator.wikimedia.org/T245307) (owner: 10Akinwale-microsoft) [01:15:36] (03CR) 10Ppchelko: Article: Remove use of Title::getUserPermissionsErrors (part 3) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/572370 (https://phabricator.wikimedia.org/T244929) (owner: 10DannyS712) [01:15:49] (03CR) 10DannyS712: [C: 04-1] "Jenkins failure is unrelated, and actual change is fine, but change doesn't match commit message" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/572335 (owner: 10Akinwale-microsoft) [01:16:12] (03PS8) 10Jforrester: Replace use of ArticleEditUpdates hook with RevisionDataUpdates [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/571392 (https://phabricator.wikimedia.org/T245175) [01:17:01] (03CR) 10DannyS712: Fix: Filter by changes and days button accessibility Screen reader just announces x changes, y days, it doesn't announce the meaning of the (031 comment) [core] - 10https://gerrit.wikimedia.org/r/570972 (owner: 10Akinwale-microsoft) [01:17:43] (03CR) 10DannyS712: [C: 04-1] ">" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/572335 (owner: 10Akinwale-microsoft) [01:18:02] (03CR) 10jerkins-bot: [V: 04-1] Replace use of ArticleEditUpdates hook with RevisionDataUpdates [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/571392 (https://phabricator.wikimedia.org/T245175) (owner: 10Jforrester) [01:18:05] (03PS2) 10DannyS712: Fix: Add aria-label to Filter Tag in Special:RecentChanges This widget failed accessibility test using the accessibility insights tool see https://accessibilityinsights.io/ The options associated with this tool also need to have an aria-label attribute [core] - 10https://gerrit.wikimedia.org/r/570960 (owner: 10Akinwale-microsoft) [01:18:33] (03CR) 10DannyS712: "Needs to be rebased, should fix the jenkins failure" [core] - 10https://gerrit.wikimedia.org/r/570972 (owner: 10Akinwale-microsoft) [01:20:06] (03CR) 10DannyS712: Replace use of ArticleEditUpdates hook with RevisionDataUpdates (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/571392 (https://phabricator.wikimedia.org/T245175) (owner: 10Jforrester) [01:22:32] (03CR) 10Jforrester: Replace use of ArticleEditUpdates hook with RevisionDataUpdates (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/571392 (https://phabricator.wikimedia.org/T245175) (owner: 10Jforrester) [01:22:42] (03PS3) 10Accraze: Implemented Jade UI styles based on wireframe [extensions/Jade] - 10https://gerrit.wikimedia.org/r/571508 (https://phabricator.wikimedia.org/T242648) (owner: 10Kevin Bazira) [01:23:34] (03CR) 10Ppchelko: Add a user parameter to LanguageConverter::getUserVariant (032 comments) [core] - 10https://gerrit.wikimedia.org/r/571226 (https://phabricator.wikimedia.org/T243708) (owner: 10DannyS712) [01:23:47] (03CR) 10DannyS712: tests: Skip mw.loader.store tests if it's disabled (032 comments) [core] - 10https://gerrit.wikimedia.org/r/572351 (owner: 10Bartosz Dziewoński) [01:26:28] (03CR) 10jerkins-bot: [V: 04-1] Implemented Jade UI styles based on wireframe [extensions/Jade] - 10https://gerrit.wikimedia.org/r/571508 (https://phabricator.wikimedia.org/T242648) (owner: 10Kevin Bazira) [01:28:24] (03PS4) 10Accraze: Implemented Jade UI styles based on wireframe [extensions/Jade] - 10https://gerrit.wikimedia.org/r/571508 (https://phabricator.wikimedia.org/T242648) (owner: 10Kevin Bazira) [01:29:14] (03CR) 10Catrope: "> Patch Set 2:" [core] - 10https://gerrit.wikimedia.org/r/569666 (owner: 10Catrope) [01:32:34] (03CR) 10Accraze: [C: 03+2] Implemented Jade UI styles based on wireframe [extensions/Jade] - 10https://gerrit.wikimedia.org/r/571508 (https://phabricator.wikimedia.org/T242648) (owner: 10Kevin Bazira) [01:32:58] (03CR) 10jerkins-bot: [V: 04-1] Fix: Add aria-label to Filter Tag in Special:RecentChanges This widget failed accessibility test using the accessibility insights tool see https://accessibilityinsights.io/ The options associated with this tool also need to have an aria-label attribute [core] - 10https://gerrit.wikimedia.org/r/570960 (owner: 10Akinwale-microsoft) [01:34:09] 10LibUp: LibUp web listing out of date - https://phabricator.wikimedia.org/T245171 (10Jdforrester-WMF) 05Open→03Invalid Hmm. So it's just this repo, and we can ignore it? OK. [01:37:59] 10DiscussionTools: Better handle bad token errors (user logs in or out in another tab) in DiscussionTools - https://phabricator.wikimedia.org/T245327 (10matmarex) [01:38:02] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board): Better handle bad token errors (user logs in or out in another tab) in DiscussionTools - https://phabricator.wikimedia.org/T245327 (10matmarex) a:03matmarex [01:43:15] 10CheckUser, 10Patch-For-Review: Installation of CheckUser barfs when run on a brand new mediawiki installation - https://phabricator.wikimedia.org/T244283 (10MMigurski) I fixed the two change in response to PHP quibbles, and both seem happy now. [01:43:47] 10MediaWiki-API, 10Documentation, 10User-DannyS712: Document how to implement tokens in (extension) api modules - https://phabricator.wikimedia.org/T43956 (10DannyS712) 05Open→03Resolved a:03DannyS712 Added link to https://www.mediawiki.org/wiki/Manual:Hooks/ApiQueryTokensRegisterTypes in https://www.m... [01:48:31] 10MediaWiki-General, 10Technical-Debt (Deprecation process), 10User-DannyS712: Hard deprecate deprecated api token hooks and functions - https://phabricator.wikimedia.org/T245329 (10DannyS712) [01:50:56] 10MediaWiki-General, 10DiscussionTools, 10Editing QA, 10VisualEditor, and 3 others: Upstream API error handling from VisualEditor to MediaWiki, use it in DiscussionTools - https://phabricator.wikimedia.org/T240519 (10matmarex) > For DiscussionTools I did not get any such API response, but I did get error m... [01:50:59] (03CR) 10DannyS712: Article: Remove use of Title::getUserPermissionsErrors (part 3) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/572370 (https://phabricator.wikimedia.org/T244929) (owner: 10DannyS712) [01:51:31] (03PS3) 10DannyS712: Article: Remove use of Title::getUserPermissionsErrors (part 3) [core] - 10https://gerrit.wikimedia.org/r/572370 (https://phabricator.wikimedia.org/T244929) [01:53:36] (03PS1) 10DannyS712: Hard-deprecate api hooks and functions for getting tokens [core] - 10https://gerrit.wikimedia.org/r/572373 (https://phabricator.wikimedia.org/T232869) [01:53:44] (03Merged) 10jenkins-bot: Implemented Jade UI styles based on wireframe [extensions/Jade] - 10https://gerrit.wikimedia.org/r/571508 (https://phabricator.wikimedia.org/T242648) (owner: 10Kevin Bazira) [01:54:56] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board): Better handle bad token errors (user logs in or out in another tab) in DiscussionTools - https://phabricator.wikimedia.org/T245327 (10matmarex) Current behavior is: {F31613620} Expected behavior: * If the token simply expired, we should refresh it... [01:58:52] (03PS3) 10Sahajsk: Make Special:ListFiles not show usernames with underscores [core] - 10https://gerrit.wikimedia.org/r/571681 [02:03:22] (03CR) 10Ppchelko: [C: 03+1] "This looks good. At first I thought maybe in light of https://phabricator.wikimedia.org/T232506 it would be good to inject the PermissionM" [core] - 10https://gerrit.wikimedia.org/r/572146 (https://phabricator.wikimedia.org/T244929) (owner: 10DannyS712) [02:05:48] (03PS2) 10DannyS712: Hard-deprecate api hooks and functions for getting tokens [core] - 10https://gerrit.wikimedia.org/r/572373 (https://phabricator.wikimedia.org/T232869) [02:07:43] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board), 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), 10Verified: Reply added in the wrong place in case of list gap in the discussion - https://phabricator.wikimedia.org/T242822 (10ppelberg) 05Open→03Resolved [02:08:00] 10MediaWiki-General, 10Documentation, 10Patch-For-Review, 10Technical-Debt, 10User-DannyS712: The "ApiTokensGetTokenTypes" hook is listed in documentation as deprecated but doesn't emit deprecation warnings yet - https://phabricator.wikimedia.org/T232873 (10DannyS712) a:03DannyS712 [02:08:52] 10MediaWiki-General, 10MediaWiki-extensions-BounceHandler, 10MediaWiki-extensions-CodeReview, 10MediaWiki-extensions-Newsletter, and 13 others: Api tests: Hard deprecate $this->doLogin, remove calls in favor of passing a user where needed - https://phabricator.wikimedia.org/T244039 (10Pchelolo) All uses ha... [02:09:54] (03CR) 10Ppchelko: [C: 03+2] Remove use of Title::userCan [extensions/SubPageList3] - 10https://gerrit.wikimedia.org/r/571873 (https://phabricator.wikimedia.org/T244923) (owner: 10DannyS712) [02:10:00] (03PS1) 10Bartosz Dziewoński: ApiMain: Add support for assert=anon [core] - 10https://gerrit.wikimedia.org/r/572374 (https://phabricator.wikimedia.org/T245327) [02:10:04] (03PS1) 10Bartosz Dziewoński: Use built-in mw.Api 'badtoken' handling, also 'assert'/'assertuser' [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/572376 (https://phabricator.wikimedia.org/T245327) [02:10:45] (03PS3) 10DannyS712: Hard-deprecate api hooks and functions for getting tokens [core] - 10https://gerrit.wikimedia.org/r/572373 (https://phabricator.wikimedia.org/T232869) [02:11:25] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-Debug-Logger, 10MediaWiki-extensions-LoginNotify, 10Community-Tech, and 2 others: logstash_formatter_key_conflict in mediawiki logs - https://phabricator.wikimedia.org/T245280 (10Reedy) [02:12:34] 10Editing Design, 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 1.0): Replies v1.0: Create mockups - https://phabricator.wikimedia.org/T235592 (10ppelberg) 05Open→03Resolved [02:12:36] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 1.0): Replies v1.0: release replying to specific comments - https://phabricator.wikimedia.org/T235923 (10ppelberg) [02:13:21] 10NewcomerTasks Future Release , 10Growth-Team (Current Sprint): Newcomer tasks: evaluate link recommendation (Feb 14 2020) - https://phabricator.wikimedia.org/T245330 (10MMiller_WMF) [02:14:48] 10NewcomerTasks Future Release , 10Growth-Team (Current Sprint): Newcomer tasks: evaluate link recommendation (Feb 14 2020) - https://phabricator.wikimedia.org/T245330 (10MMiller_WMF) @revi @PPham @Dyolf77_WMF @Urbanecm -- this task is ready for you. I know this may be confusing, so please let me know if you... [02:14:57] 10NewcomerTasks Future Release , 10Growth-Team (Current Sprint): Newcomer tasks: evaluate link recommendation (Feb 14 2020) - https://phabricator.wikimedia.org/T245330 (10MMiller_WMF) [02:15:11] (03CR) 10Bartosz Dziewoński: "Note that this feature was considered and rejected when this code was originally added, because there was no use case (see "nassert parame" [core] - 10https://gerrit.wikimedia.org/r/572374 (https://phabricator.wikimedia.org/T245327) (owner: 10Bartosz Dziewoński) [02:15:57] (03CR) 10Bartosz Dziewoński: "Example patch using this in VE: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/572375" [core] - 10https://gerrit.wikimedia.org/r/572374 (https://phabricator.wikimedia.org/T245327) (owner: 10Bartosz Dziewoński) [02:16:54] (03CR) 10Ppchelko: "Nitpicking about the commit message inlined." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/567325 (https://phabricator.wikimedia.org/T243708) (owner: 10DannyS712) [02:20:01] (03Merged) 10jenkins-bot: Remove use of ApiTestCase::doLogin [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/569572 (https://phabricator.wikimedia.org/T244039) (owner: 10DannyS712) [02:20:03] (03Merged) 10jenkins-bot: Remove use of ApiTestCase::doLogin [extensions/ORES] - 10https://gerrit.wikimedia.org/r/570526 (https://phabricator.wikimedia.org/T244039) (owner: 10DannyS712) [02:20:05] (03Merged) 10jenkins-bot: Remove use of Title::userCan [extensions/SubPageList3] - 10https://gerrit.wikimedia.org/r/571873 (https://phabricator.wikimedia.org/T244923) (owner: 10DannyS712) [02:20:40] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board), 10Patch-For-Review: Better handle bad token errors (user logs in or out in another tab) in DiscussionTools - https://phabricator.wikimedia.org/T245327 (10matmarex) These patches implement the first part (retrying without displaying any errors if... [02:23:38] (03CR) 10jerkins-bot: [V: 04-1] Hard-deprecate api hooks and functions for getting tokens [core] - 10https://gerrit.wikimedia.org/r/572373 (https://phabricator.wikimedia.org/T232869) (owner: 10DannyS712) [02:28:10] (03CR) 10Ppchelko: "Some nitpicking, lgtm in general" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/571855 (https://phabricator.wikimedia.org/T233385) (owner: 10DannyS712) [02:28:52] (03PS1) 10DannyS712: Hard deprecate ApiTestCase::doLogin [core] - 10https://gerrit.wikimedia.org/r/572379 (https://phabricator.wikimedia.org/T244039) [02:30:31] 10Inuka-Team, 10Product-Analytics (Kanban): Investigate significant drop in KaiOS pageviews - https://phabricator.wikimedia.org/T242853 (10nshahquinn-wmf) [02:31:48] (03PS2) 10DannyS712: Hard deprecate ApiTestCase::doLogin [core] - 10https://gerrit.wikimedia.org/r/572379 (https://phabricator.wikimedia.org/T244039) [02:32:33] 10MediaWiki-General, 10MediaWiki-extensions-BounceHandler, 10MediaWiki-extensions-CodeReview, 10MediaWiki-extensions-Newsletter, and 13 others: Api tests: Hard deprecate $this->doLogin, remove calls in favor of passing a user where needed - https://phabricator.wikimedia.org/T244039 (10DannyS712) [02:33:27] (03CR) 10DannyS712: Add more tests for the user class (032 comments) [core] - 10https://gerrit.wikimedia.org/r/571855 (https://phabricator.wikimedia.org/T233385) (owner: 10DannyS712) [02:33:45] (03PS13) 10DannyS712: Add more tests for the user class [core] - 10https://gerrit.wikimedia.org/r/571855 (https://phabricator.wikimedia.org/T233385) [02:33:50] (03CR) 10DannyS712: Add more tests for the user class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/571855 (https://phabricator.wikimedia.org/T233385) (owner: 10DannyS712) [02:34:05] (03CR) 10Ppchelko: [C: 03+1] "I'll let @Anomie pull the trigger, he's the owner of the api stuff" [core] - 10https://gerrit.wikimedia.org/r/572379 (https://phabricator.wikimedia.org/T244039) (owner: 10DannyS712) [02:37:53] 10MediaWiki-General, 10MW-1.36-release, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove core fallbacks to global $wgUser [1.36] - https://phabricator.wikimedia.org/T245331 (10DannyS712) [02:38:56] (03PS6) 10Superbass: Add ar_del_time [core] - 10https://gerrit.wikimedia.org/r/572134 (https://phabricator.wikimedia.org/T245234) [02:40:47] (03PS7) 10Superbass: Add ar_del_time [core] - 10https://gerrit.wikimedia.org/r/572134 (https://phabricator.wikimedia.org/T245234) [02:42:25] (03CR) 10Superbass: Add ar_del_time (033 comments) [core] - 10https://gerrit.wikimedia.org/r/572134 (https://phabricator.wikimedia.org/T245234) (owner: 10Superbass) [02:42:28] (03PS9) 10Aaron Schulz: Replace use of ArticleEditUpdates hook with RevisionDataUpdates [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/571392 (https://phabricator.wikimedia.org/T245175) (owner: 10Jforrester) [02:45:19] 10MediaWiki-General, 10BlueSpice, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove ApiTestCase::doLogin - https://phabricator.wikimedia.org/T245332 (10DannyS712) [02:47:23] (03PS1) 10DannyS712: Remove use of ApiTestCase::doLogin [extensions/BlueSpiceChecklist] - 10https://gerrit.wikimedia.org/r/572383 (https://phabricator.wikimedia.org/T245332) [02:49:13] (03PS2) 10DannyS712: Remove use of ApiTestCase::doLogin [extensions/BlueSpiceChecklist] - 10https://gerrit.wikimedia.org/r/572383 (https://phabricator.wikimedia.org/T245332) [02:50:15] (03PS1) 10DannyS712: Remove use of ApiTestCase::doLogin [extensions/BlueSpiceBookshelf] - 10https://gerrit.wikimedia.org/r/572384 (https://phabricator.wikimedia.org/T245332) [02:50:43] (03PS2) 10DannyS712: Remove use of ApiTestCase::doLogin [extensions/BlueSpiceBookshelf] - 10https://gerrit.wikimedia.org/r/572384 (https://phabricator.wikimedia.org/T245332) [02:51:21] (03PS1) 10DannyS712: Remove use of ApiTestCase::doLogin [extensions/BlueSpiceDashboards] - 10https://gerrit.wikimedia.org/r/572386 (https://phabricator.wikimedia.org/T245332) [02:51:56] (03PS2) 10DannyS712: Remove use of ApiTestCase::doLogin [extensions/BlueSpiceDashboards] - 10https://gerrit.wikimedia.org/r/572386 (https://phabricator.wikimedia.org/T245332) [02:53:17] (03PS1) 10DannyS712: Remove use of ApiTestCase::doLogin [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/572389 (https://phabricator.wikimedia.org/T245332) [02:53:39] (03PS2) 10DannyS712: Remove use of ApiTestCase::doLogin [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/572389 (https://phabricator.wikimedia.org/T245332) [02:54:08] (03PS1) 10DannyS712: Remove use of ApiTestCase::doLogin [extensions/BlueSpiceReminder] - 10https://gerrit.wikimedia.org/r/572390 (https://phabricator.wikimedia.org/T245332) [02:54:28] (03PS2) 10DannyS712: Remove use of ApiTestCase::doLogin [extensions/BlueSpiceReminder] - 10https://gerrit.wikimedia.org/r/572390 (https://phabricator.wikimedia.org/T245332) [02:55:07] (03PS1) 10DannyS712: Remove use of ApiTestCase::doLogin [extensions/BlueSpiceInsertFile] - 10https://gerrit.wikimedia.org/r/572392 (https://phabricator.wikimedia.org/T245332) [02:55:40] (03PS2) 10DannyS712: Remove use of ApiTestCase::doLogin [extensions/BlueSpiceInsertFile] - 10https://gerrit.wikimedia.org/r/572392 (https://phabricator.wikimedia.org/T245332) [02:58:31] 10MediaWiki-General, 10MediaWiki-extensions-BounceHandler, 10MediaWiki-extensions-CodeReview, 10MediaWiki-extensions-Newsletter, and 13 others: Api tests: Hard deprecate $this->doLogin, remove calls in favor of passing a user where needed - https://phabricator.wikimedia.org/T244039 (10DannyS712) p:05Triag... [02:59:28] (03CR) 10Krinkle: "Shouldn't be needed as that's what the stub is for. However, I'll accept it as a temporary patch to help you along if you file a task :)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/572351 (owner: 10Bartosz Dziewoński) [03:05:40] (03PS1) 10DannyS712: Testing failures [core] - 10https://gerrit.wikimedia.org/r/572393 [03:12:53] 10DiscussionTools: When you get an error while posting a reply, but eventually succeed, the reply is posted twice - https://phabricator.wikimedia.org/T245333 (10matmarex) [03:13:02] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board): When you get an error while posting a reply, but eventually succeed, the reply is posted twice - https://phabricator.wikimedia.org/T245333 (10matmarex) a:03matmarex [03:13:49] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board): When you get an error while posting a reply, but eventually succeed, the reply is posted twice - https://phabricator.wikimedia.org/T245333 (10ppelberg) Good catch, BD. [03:18:08] (03CR) 10DannyS712: ImageBuilder: Update to LocalFile::recordUpload2, pass a user (031 comment) [core] - 10https://gerrit.wikimedia.org/r/567325 (https://phabricator.wikimedia.org/T243708) (owner: 10DannyS712) [03:18:25] (03CR) 10Krinkle: "Queries should only be coming from 1 place and the rest use the abstraction layer, so that's presumably easy. I'm not sure I get why it in" [core] - 10https://gerrit.wikimedia.org/r/501840 (owner: 10Aaron Schulz) [03:21:36] (03CR) 10Krinkle: "Oh, I see isSane() treats <0 as special. Hm.. that's tricky indeed. Not sure we need that still. If such bad state is known to happen, we " [core] - 10https://gerrit.wikimedia.org/r/501840 (owner: 10Aaron Schulz) [03:24:26] (03CR) 10DannyS712: ">" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/567325 (https://phabricator.wikimedia.org/T243708) (owner: 10DannyS712) [03:25:36] (03CR) 10DannyS712: "Recheck" [core] - 10https://gerrit.wikimedia.org/r/572373 (https://phabricator.wikimedia.org/T232869) (owner: 10DannyS712) [03:25:38] (03CR) 10Krinkle: Follow-up 37a69a2f: ResourceLoaderSkinModule: Fix wfDeprecated() syntax (031 comment) [core] - 10https://gerrit.wikimedia.org/r/572322 (owner: 10Jforrester) [03:37:51] (03CR) 10Krinkle: API: Fix fetching login token from action=query&meta=tokens on private wikis (031 comment) [core] - 10https://gerrit.wikimedia.org/r/572332 (https://phabricator.wikimedia.org/T245149) (owner: 10Anomie) [03:40:49] (03CR) 10Krinkle: [C: 03+1] "Are there plans for removal and/or shimming with something we maintain/cache elsewhere that might be able to pass as a compatable/close-en" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/570780 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [03:43:39] (03CR) 10Krinkle: REST endpoint for executing jobs (031 comment) [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/571816 (https://phabricator.wikimedia.org/T244826) (owner: 10Clarakosi) [03:47:22] (03CR) 10Ppchelko: REST endpoint for executing jobs (031 comment) [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/571816 (https://phabricator.wikimedia.org/T244826) (owner: 10Clarakosi) [03:47:51] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-Debug-Logger, 10MediaWiki-extensions-LoginNotify, 10Community-Tech, and 2 others: logstash_formatter_key_conflict in mediawiki logs - https://phabricator.wikimedia.org/T245280 (10Krinkle) @Reedy Can you confirm that this is only for making Logstash... [03:53:08] (03CR) 10Krinkle: REST endpoint for executing jobs (031 comment) [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/571816 (https://phabricator.wikimedia.org/T244826) (owner: 10Clarakosi) [03:56:45] 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board): When you get an error while posting a reply, but eventually succeed, the reply is posted twice - https://phabricator.wikimedia.org/T245333 (10matmarex) I'm pretty sure it was @Esanders who noticed this first, I merely remembered about it ;) (severa... [04:16:55] 10Wikipedia-Android-App-Backlog, 10wikimedia-page-library: Infobox subsections are rendered as separate infoboxes on https://fr.m.wikipedia.org/wiki/Burkina_Faso - https://phabricator.wikimedia.org/T188096 (10Niedzielski) 05Open→03Resolved PR is merged so I hope this task is done. [04:17:17] 10Wikipedia-Android-App-Backlog, 10wikimedia-page-library: Black theme doesn't render Chess template properly - https://phabricator.wikimedia.org/T183333 (10Niedzielski) 05Open→03Resolved PR is merged so I hope this task is done. [04:18:55] 10Readers-Web-Backlog (Tracking): Delete readers-web-stephen.reading-webstaging.eqiad.wmflabs and marvin-staging.reading-webstaging.eqiad.wmflabs? - https://phabricator.wikimedia.org/T234258 (10Niedzielski) a:05Niedzielski→03None [04:33:16] (03CR) 10Tim Starling: "> Patch Set 3: Code-Review+1" [core] - 10https://gerrit.wikimedia.org/r/571943 (owner: 10Tim Starling) [04:41:01] (03CR) 10Tpt: [C: 03+2] Unset dynamic property on Parser when not needed any more [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572340 (owner: 10Thiemo Kreuz (WMDE)) [04:41:48] (03CR) 10Tpt: [C: 03+2] Remove reference to non-existing SearchEngine::$showRedirects [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572338 (owner: 10Thiemo Kreuz (WMDE)) [04:42:45] (03CR) 10Tpt: "My concern was wrong. Removing -1" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572249 (owner: 10WMDE-Fisch) [04:46:19] (03Merged) 10jenkins-bot: Unset dynamic property on Parser when not needed any more [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572340 (owner: 10Thiemo Kreuz (WMDE)) [04:46:55] (03Merged) 10jenkins-bot: Remove reference to non-existing SearchEngine::$showRedirects [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572338 (owner: 10Thiemo Kreuz (WMDE)) [04:53:20] (03PS1) 10Bartosz Dziewoński: Rebuild Parsoid document before attempting to save [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/572398 (https://phabricator.wikimedia.org/T245333) [04:53:22] (03PS1) 10Bartosz Dziewoński: Try to resolve edit conflicts [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/572399 (https://phabricator.wikimedia.org/T240643) [04:53:24] (03PS1) 10Bartosz Dziewoński: When launched from an old revision, reply to latest revision [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/572400 [04:53:47] (03PS4) 10DannyS712: Hard-deprecate api hooks for getting tokens [core] - 10https://gerrit.wikimedia.org/r/572373 (https://phabricator.wikimedia.org/T232869) [04:58:00] (03CR) 10jerkins-bot: [V: 04-1] When launched from an old revision, reply to latest revision [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/572400 (owner: 10Bartosz Dziewoński) [05:04:57] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-Debug-Logger, 10MediaWiki-extensions-LoginNotify, 10Community-Tech, and 2 others: logstash_formatter_key_conflict in mediawiki logs - https://phabricator.wikimedia.org/T245280 (10Reedy) It does rewrite them, but it leaves the errors behind too, to h... [05:21:58] 10Developer-Advocacy (Jan-Mar 2020): Decide which GCI 2019 mentor to attend GCI Grand Prize winners weekend in June 2020 (before 2020-02-21) - https://phabricator.wikimedia.org/T241927 (10Aklapper) >>! In T241927#5885745, @Ebe123 wrote: > They'll (GCI) will send an email to the org admins next week with the date... [05:26:35] (03CR) 10Tpt: [C: 03+1] "Thank you! Sadly the CI fails because of some phpcs lint errors. Do you want to fix them?" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572348 (owner: 10Thiemo Kreuz (WMDE)) [06:55:54] 10MediaWiki-General, 10BlueSpice, 10Patch-For-Review, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove ApiTestCase::doLogin - https://phabricator.wikimedia.org/T245332 (10DannyS712) >>! In T245332#5887030, @Aklapper wrote: > This task does not seem to be about the MediaWiki Core codebase,... [07:15:38] (03CR) 10Gergő Tisza: [C: 03+1] "Are we waiting for a quiet train week or can we merge this now?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/572322 (owner: 10Jforrester) [07:17:41] 10MediaWiki-General: citation button created URL that duplicated unique identifier - https://phabricator.wikimedia.org/T245335 (10Leela52452) [07:21:25] (03CR) 10Gergő Tisza: "> Hmm, I just noticed that there is some special handling of authevents in logging.php which this might mess up" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/571426 (owner: 10Brian Wolff) [07:23:28] (03CR) 10Gergő Tisza: "Yeah this is not really useful. No idea why I even added it." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/571426 (owner: 10Brian Wolff) [07:23:41] (03CR) 10Gergő Tisza: [C: 03+1] Change the logging entry for just loading CentralAutoLogin to debug [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/571426 (owner: 10Brian Wolff) [07:44:10] 10Phabricator, 10Release-Engineering-Team: change "default" column on Parsoid workboard - https://phabricator.wikimedia.org/T245308 (10Aklapper) I was about to look into this while wondering if this could simply be solved by renaming columns, but seems that @LGoto already did the right thing by renaming `Needs... [07:50:34] 10MediaWiki-General, 10BlueSpice, 10Patch-For-Review, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove ApiTestCase::doLogin - https://phabricator.wikimedia.org/T245332 (10Aklapper) @DannyS712: That sounds like two separate tasks and the extension tasks should be subtasks of the MediaWiki... [07:57:11] 10Move-Files-To-Commons, 10Technical-Tool-Request: A new tool to (mass) import files that were previously imported without history - https://phabricator.wikimedia.org/T215008 (10Aklapper) @WMDE-Fisch: #Technical-Tool-Request is the best I can come up with. [07:57:53] 10MediaWiki-extensions-WikibaseClient, 10Maps, 10Wikidata: Maplink (via Wikidata) shows only empty window without map on all wikipedias - https://phabricator.wikimedia.org/T225350 (10Evad37) This seems similar to {T227402} [07:58:38] 10MediaWiki-General, 10BlueSpice, 10Patch-For-Review, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove ApiTestCase::doLogin - https://phabricator.wikimedia.org/T245332 (10DannyS712) >>! In T245332#5887076, @Aklapper wrote: > @DannyS712: That sounds like two separate tasks and the extensio... [07:58:49] 10MediaWiki-Special-pages, 10Core Platform Team Workboards (Contractor Workboard): Remove deprecated code from SpecialPageFactory - https://phabricator.wikimedia.org/T245128 (10Aklapper) @Peter.ovchyn: Assuming this task is about the #MediaWiki-Special-pages code base, hence adding project tag so other people... [08:04:43] 10MediaWiki-General, 10BlueSpice, 10Patch-For-Review, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove ApiTestCase::doLogin - https://phabricator.wikimedia.org/T245332 (10Aklapper) I don't think there are any "rules" about this. To me personally it feels messy, and from reading the task d... [08:05:49] 10MediaWiki-General, 10BlueSpice, 10Patch-For-Review, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove ApiTestCase::doLogin - https://phabricator.wikimedia.org/T245332 (10DannyS712) >>! In T245332#5887090, @Aklapper wrote: > I don't think there are any "rules" about this. To me personally... [08:23:04] (03CR) 10Gergő Tisza: "To keep the captcha dashboard working, authenvent-statsd will have to be added as a handler for this channel as well." [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/571461 (https://phabricator.wikimedia.org/T210817) (owner: 10Brian Wolff) [08:46:22] 10MediaWiki-Parser, 10TechCom, 10Readers-Web-Backlog (Tracking): Links in table of contents don't work for certain characters - https://phabricator.wikimedia.org/T238385 (10Bawolff) So this is kind of an interesting bug. > The two TOC links that don't work *are* incorrect - they contain an unencoded percent... [08:55:45] 10MediaWiki-Parser, 10TechCom, 10Readers-Web-Backlog (Tracking): Links in table of contents don't work for certain characters - https://phabricator.wikimedia.org/T238385 (10Bawolff) In my other testing, it seems like carriage returns aren't handled properly either, although i suppose that's a pretty extreme... [08:57:21] (03PS1) 10DannyS712: [WIP] Add Special:VerifyOATHForUser [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/572402 [09:09:17] (03CR) 10Phuedx: Deprecate wgMinervaCustomLogos in favor of $wgLogos (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/551670 (https://phabricator.wikimedia.org/T232140) (owner: 10Jdlrobson) [09:32:02] (03PS2) 10DannyS712: [WIP] Add Special:VerifyOATHForUser [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/572402 [09:33:13] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add Special:VerifyOATHForUser [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/572402 (owner: 10DannyS712) [09:35:56] (03PS1) 10Brian Wolff: Escape % sign if form valid percent-encoding in fragment identifiers [core] - 10https://gerrit.wikimedia.org/r/572403 (https://phabricator.wikimedia.org/T238385) [09:35:58] (03PS1) 10Brian Wolff: Make $wgFragmentMode = [ 'html5', 'legacy' ]; default [core] - 10https://gerrit.wikimedia.org/r/572404 [09:36:56] (03CR) 10Brian Wolff: "Note: fragments containing carriage returns still don't work properly. I'm assuming that's such an edge case that nobody cares." [core] - 10https://gerrit.wikimedia.org/r/572403 (https://phabricator.wikimedia.org/T238385) (owner: 10Brian Wolff) [09:37:51] (03CR) 10Brian Wolff: "Note: Part of the impetus for this change was the thread at https://www.mediawiki.org/w/index.php?title=Topic:Vgsj3fxgall1cnlu&topic_showP" [core] - 10https://gerrit.wikimedia.org/r/572404 (owner: 10Brian Wolff) [09:49:40] (03CR) 10jerkins-bot: [V: 04-1] Make $wgFragmentMode = [ 'html5', 'legacy' ]; default [core] - 10https://gerrit.wikimedia.org/r/572404 (owner: 10Brian Wolff) [09:50:56] (03CR) 10jerkins-bot: [V: 04-1] Escape % sign if form valid percent-encoding in fragment identifiers [core] - 10https://gerrit.wikimedia.org/r/572403 (https://phabricator.wikimedia.org/T238385) (owner: 10Brian Wolff) [10:05:49] (03PS3) 10DannyS712: [WIP] Add Special:VerifyOATHForUser [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/572402 [10:07:54] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add Special:VerifyOATHForUser [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/572402 (owner: 10DannyS712) [10:14:29] (03PS1) 10Brian Wolff: Make id attributes not include ascii whitespace per spec [core] - 10https://gerrit.wikimedia.org/r/572405 (https://phabricator.wikimedia.org/T238385) [10:22:48] (03PS2) 10Brian Wolff: Escape % sign if form valid percent-encoding in fragment identifiers [core] - 10https://gerrit.wikimedia.org/r/572403 (https://phabricator.wikimedia.org/T238385) [10:22:50] (03PS2) 10Brian Wolff: Make $wgFragmentMode = [ 'html5', 'legacy' ]; default [core] - 10https://gerrit.wikimedia.org/r/572404 [10:25:53] 10Security-Team: Create preference to control using personal JS - https://phabricator.wikimedia.org/T120889 (10DannyS712) [10:26:04] 10MediaWiki-User-management, 10Security-Team: Create preference to control using personal JS - https://phabricator.wikimedia.org/T120889 (10DannyS712) [10:26:20] (03CR) 10jerkins-bot: [V: 04-1] Make id attributes not include ascii whitespace per spec [core] - 10https://gerrit.wikimedia.org/r/572405 (https://phabricator.wikimedia.org/T238385) (owner: 10Brian Wolff) [10:26:26] 10MediaWiki-User-management, 10Security-Team: Create preference to control using personal JS - https://phabricator.wikimedia.org/T120889 (10DannyS712) Suggest declining in light of {T190015} [10:28:37] (03CR) 10Brian Wolff: "So there's a literal parser test that contains a headline with a newline in it... I guess that's just coincidental" [core] - 10https://gerrit.wikimedia.org/r/572405 (https://phabricator.wikimedia.org/T238385) (owner: 10Brian Wolff) [10:32:59] (03PS2) 10Brian Wolff: Make id attributes not include ascii whitespace per spec [core] - 10https://gerrit.wikimedia.org/r/572405 (https://phabricator.wikimedia.org/T238385) [10:34:19] (03CR) 10Brian Wolff: "I guess the unit tests circularly depend on the CirrusSearch unit tests" [core] - 10https://gerrit.wikimedia.org/r/572404 (owner: 10Brian Wolff) [10:36:19] (03CR) 10jerkins-bot: [V: 04-1] Escape % sign if form valid percent-encoding in fragment identifiers [core] - 10https://gerrit.wikimedia.org/r/572403 (https://phabricator.wikimedia.org/T238385) (owner: 10Brian Wolff) [10:36:32] (03CR) 10jerkins-bot: [V: 04-1] Make $wgFragmentMode = [ 'html5', 'legacy' ]; default [core] - 10https://gerrit.wikimedia.org/r/572404 (owner: 10Brian Wolff) [10:44:44] (03CR) 10jerkins-bot: [V: 04-1] Make id attributes not include ascii whitespace per spec [core] - 10https://gerrit.wikimedia.org/r/572405 (https://phabricator.wikimedia.org/T238385) (owner: 10Brian Wolff) [10:45:10] 10MediaWiki-Page-editing: Real-time indicator that another edit has happened since you began editing - https://phabricator.wikimedia.org/T245274 (10Schnark) This has been discussed before, see T137318#2438653 and related pages. As far as I can see and remember, the conclusion was that this needs more research on... [10:48:41] (03PS1) 10Brian Wolff: Adjust test to work with $wgFragmentMode = [ 'html5', 'legacy' ] [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/572407 [10:57:14] (03PS2) 10Brian Wolff: Adjust test to work with $wgFragmentMode = [ 'html5', 'legacy' ] [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/572407 [11:02:01] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/572407 (owner: 10Brian Wolff) [11:04:40] (03PS3) 10Brian Wolff: Adjust test to explicitly set $wgFragmentMode [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/572407 [11:05:08] (03PS3) 10Brian Wolff: Escape % sign if form valid percent-encoding in fragment identifiers [core] - 10https://gerrit.wikimedia.org/r/572403 (https://phabricator.wikimedia.org/T238385) [11:05:10] (03PS3) 10Brian Wolff: Make $wgFragmentMode = [ 'html5', 'legacy' ]; default [core] - 10https://gerrit.wikimedia.org/r/572404 [11:05:42] (03CR) 10Brian Wolff: "Tbh, i don't understand what this unit test is testing well enough to be sure that this is an appropriate change." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/572407 (owner: 10Brian Wolff) [11:19:35] (03CR) 10jerkins-bot: [V: 04-1] Make $wgFragmentMode = [ 'html5', 'legacy' ]; default [core] - 10https://gerrit.wikimedia.org/r/572404 (owner: 10Brian Wolff) [11:21:31] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/572407 (owner: 10Brian Wolff) [11:22:58] 10UI-Standardization, 10Timeless, 10Wikimedia Design Style Guide: Rethink the fonts and typography in skins, document the decisions - https://phabricator.wikimedia.org/T244425 (10Demian) >>! In T244425#5885502, @Quiddity wrote: > We are not considering any font changes via the Desktop Improvements project. T... [12:11:48] 04(no projects): Incomplete upload - https://phabricator.wikimedia.org/T245339 (10Minorax) [12:13:42] 04(no projects): Incomplete upload - https://phabricator.wikimedia.org/T245339 (10Minorax) Recently, there are several cases of incomplete uploads where the file is uploaded but the file page isn't created. For ref, see https://commons.wikimedia.org/w/index.php?title=Commons:Administrators%27_noticeboard&oldid=... [12:21:34] 10Library-Card-Platform, 10good first task: Provide a list of applicant's other recent applications on review page - https://phabricator.wikimedia.org/T186502 (10Soumyaa1804) a:05Soumyaa1804→03None [12:54:27] (03PS1) 10Aron Manning: Move up `background:` rule from table cells to table rows to enable row background-color overrides in wikitext [skins/Timeless] - 10https://gerrit.wikimedia.org/r/572408 (https://phabricator.wikimedia.org/T238482) [12:57:59] (03CR) 10Aron Manning: "This change is ready for review." [skins/Timeless] - 10https://gerrit.wikimedia.org/r/572408 (https://phabricator.wikimedia.org/T238482) (owner: 10Aron Manning) [13:03:52] (03PS12) 10MarcoAurelio: Convert UploadBlacklist to use extension registration [extensions/UploadBlacklist] - 10https://gerrit.wikimedia.org/r/571068 (https://phabricator.wikimedia.org/T211483) [13:04:57] (03CR) 10MarcoAurelio: Convert UploadBlacklist to use extension registration (033 comments) [extensions/UploadBlacklist] - 10https://gerrit.wikimedia.org/r/571068 (https://phabricator.wikimedia.org/T211483) (owner: 10MarcoAurelio) [13:05:43] (03CR) 10MarcoAurelio: Convert UploadBlacklist to use extension registration (031 comment) [extensions/UploadBlacklist] - 10https://gerrit.wikimedia.org/r/571068 (https://phabricator.wikimedia.org/T211483) (owner: 10MarcoAurelio) [13:06:41] (03CR) 10MarcoAurelio: "check php" [extensions/UploadBlacklist] - 10https://gerrit.wikimedia.org/r/571068 (https://phabricator.wikimedia.org/T211483) (owner: 10MarcoAurelio) [13:10:11] (03CR) 10MarcoAurelio: "check experimental" [extensions/UploadBlacklist] - 10https://gerrit.wikimedia.org/r/571068 (https://phabricator.wikimedia.org/T211483) (owner: 10MarcoAurelio) [13:24:01] 10MediaWiki-Configuration, 10Commons: MediaWiki $wgMaxArticleSize is not enforced during file/page creation - https://phabricator.wikimedia.org/T188852 (10Nemo_bis) >>! In T188852#4023188, @Fae wrote: > Has anyone seen the same behaviour when posting via the API, or does this not happen? The task of this repo... [13:32:19] 10Inuka-Team: Gallery - image title being cut - https://phabricator.wikimedia.org/T245235 (10Jpita) 05Open→03Invalid does not happen on firefox nor the device [13:33:13] (03CR) 10Matěj Suchánek: "recheck" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/571681 (owner: 10Sahajsk) [13:41:42] 10Design, 10Design-Research: [Design] Evaluate the feasibility and impact of restoring font-size to the browser default / user setting - https://phabricator.wikimedia.org/T245146 (10Demian) [13:43:18] (03PS11) 10Aron Manning: Font update: reset font-size from 95% (15.2px) to default 100% (16px typical), thereby removing some font-rendering artifacts where the width of some strokes is inconsistent. Changes to layout are barely noticeable. [skins/Timeless] - 10https://gerrit.wikimedia.org/r/570276 (https://phabricator.wikimedia.org/T245146) [13:43:20] (03PS11) 10Aron Manning: [TEST] Font update: use Lato (sans) for the content, Lora (serif) for headings. Load the necessary fonts from the wmflabs fontcdn. [skins/Timeless] - 10https://gerrit.wikimedia.org/r/570074 (https://phabricator.wikimedia.org/T243508) [13:46:24] (03PS11) 10Aron Manning: [TEST] Font update: use Roboto (sans) and Noto Serif (heading) webfonts with monospace Fira Code for consistent look on all platforms. [skins/Vector] - 10https://gerrit.wikimedia.org/r/570639 (https://phabricator.wikimedia.org/T243508) [13:47:57] (03PS10) 10Aron Manning: Consistently follow WikimediaUI Base's CSS variable naming convention for font variable names. Document the fonts. [skins/Vector] - 10https://gerrit.wikimedia.org/r/570638 (https://phabricator.wikimedia.org/T245136) [13:47:59] (03PS12) 10Aron Manning: [TEST] Font update: use Roboto (sans) and Noto Serif (heading) webfonts with monospace Fira Code for consistent look on all platforms. [skins/Vector] - 10https://gerrit.wikimedia.org/r/570639 (https://phabricator.wikimedia.org/T243508) [13:49:13] (03PS1) 10Thiemo Kreuz (WMDE): Remove unused $input parameters from render() methods [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572409 [13:51:24] 10Design, 10Design Research and product team collaboration, 10Design-Research, 10Readers-Web-Backlog (Design): Enable the user to choose up-to-date fonts, more legible on LCD screens - https://phabricator.wikimedia.org/T243508 (10Demian) [13:51:28] (03PS4) 10Sahajsk: Make Special:ListFiles not show usernames with underscores [core] - 10https://gerrit.wikimedia.org/r/571681 [13:51:57] (03PS1) 10Thiemo Kreuz (WMDE): Minor clean-ups to regular expressions in PageContentHandler [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572410 [13:54:32] (03PS2) 10Thiemo Kreuz (WMDE): Minor code cleanups in various places in the codebase [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572348 [14:00:16] 10VideoCutTool, 10Mobile: Not able to drag and extend the crop layer in mobile version of the tool. - https://phabricator.wikimedia.org/T245341 (10Gopavasanth) [14:02:30] 10VideoCutTool, 10Mobile, 10Patch-For-Review: Make VideoCutTool mobile responsive - https://phabricator.wikimedia.org/T243315 (10Gopavasanth) [14:02:32] 10VideoCutTool, 10Mobile: Not able to drag and extend the crop layer in mobile version of the tool. - https://phabricator.wikimedia.org/T245341 (10Gopavasanth) [14:03:21] (03PS1) 10Thiemo Kreuz (WMDE): Use assertSame() instead of assertEquals() in all tests [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572411 [14:03:43] 10MediaWiki-Uploading: Large files are failing to post file information - https://phabricator.wikimedia.org/T244557 (10Ammarpad) [14:06:32] (03CR) 10jerkins-bot: [V: 04-1] Use assertSame() instead of assertEquals() in all tests [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572411 (owner: 10Thiemo Kreuz (WMDE)) [14:07:30] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] Better document trimming of textbox input (031 comment) [core] - 10https://gerrit.wikimedia.org/r/572248 (owner: 10WMDE-Fisch) [14:13:05] (03CR) 10Bartosz Dziewoński: "This also fixed T172155." [core] - 10https://gerrit.wikimedia.org/r/561285 (https://phabricator.wikimedia.org/T237190) (owner: 10TheDJ) [14:15:31] 10MediaWiki-Categories: Suggestion: deep hidden categories - https://phabricator.wikimedia.org/T245342 (10tomert) [14:15:48] 10Design, 10Design Research and product team collaboration, 10Design-Research, 10Readers-Web-Backlog (Design): Enable the user to choose up-to-date fonts, more legible on LCD screens - https://phabricator.wikimedia.org/T243508 (10Demian) [14:20:40] (03CR) 10Bartosz Dziewoński: "recheck" [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/572400 (owner: 10Bartosz Dziewoński) [14:24:48] (03PS2) 10Thiemo Kreuz (WMDE): Remove lines from PHPDoc comments that aren't helpful [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572320 [14:25:40] 10Design, 10Design Research and product team collaboration, 10Design-Research, 10Readers-Web-Backlog (Design): Enable the user to choose up-to-date fonts, more legible on LCD screens - https://phabricator.wikimedia.org/T243508 (10Demian) [14:25:53] (03PS2) 10Thiemo Kreuz (WMDE): Add some missing PHPDoc comments [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572321 [14:26:17] 10Design, 10Design Research and product team collaboration, 10Design-Research, 10Readers-Web-Backlog (Design): Enable the user to choose up-to-date fonts, more legible on LCD screens - https://phabricator.wikimedia.org/T243508 (10Demian) [14:30:18] 10NewcomerTasks 1.1, 10Growth-Team (Current Sprint): Regenerate data for prototype using updated ORES models - https://phabricator.wikimedia.org/T243956 (10kostajh) cswiki data export is done and can be reviewed at https://deploy-preview-1--newcomertasks-ores-drafttopic.netlify.com I'm working on the other w... [14:30:57] (03CR) 10jerkins-bot: [V: 04-1] Add some missing PHPDoc comments [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572321 (owner: 10Thiemo Kreuz (WMDE)) [14:33:05] (03PS11) 10Aron Manning: Consistently follow WikimediaUI Base's CSS variable naming convention for font variable names. Document the fonts. [skins/Timeless] - 10https://gerrit.wikimedia.org/r/570275 (https://phabricator.wikimedia.org/T245136) [14:33:07] (03PS12) 10Aron Manning: Font update: reset font-size from 95% (15.2px) to default 100% (16px typical), thereby removing some font-rendering artifacts where the width of some strokes is inconsistent. Changes to layout are barely noticeable. [skins/Timeless] - 10https://gerrit.wikimedia.org/r/570276 (https://phabricator.wikimedia.org/T245146) [14:33:44] (03PS12) 10Aron Manning: [TEST] Font update: use Lato (sans) for the content, Lora (serif) for headings. Load the necessary fonts from the wmflabs fontcdn. [skins/Timeless] - 10https://gerrit.wikimedia.org/r/570074 (https://phabricator.wikimedia.org/T243508) [14:40:24] 10MediaWiki-extensions-OAuth: Special:OAuthManageMyGrants should not be bold in Special:SpecialPages - https://phabricator.wikimedia.org/T168052 (10Ammarpad) >Special:OAuthManageMyGrants is the only page from Special:SpecialPages, which is not for anonymous users. No, it's not. >It is super confusing for novice... [14:44:52] 10Texvcjs: texvcjs should not replace $\omicron$ with $\mathrm{o}$ - https://phabricator.wikimedia.org/T245343 (10Physikerwelt) [14:49:55] 10MediaWiki-Page-editing: Real-time indicator that another edit has happened since you began editing - https://phabricator.wikimedia.org/T245274 (10awight) 05Open→03Invalid @Reedy @Schnark Thank you for the thoughtful links, and apologies for the ticket spam. So many things are annoying about edit conflicts... [14:59:32] (03PS27) 10Kosta Harlan: Add a docker-compose development environment [core] - 10https://gerrit.wikimedia.org/r/550708 (https://phabricator.wikimedia.org/T238224) [15:00:55] (03CR) 10Kosta Harlan: "> I've tried running it, it runs. The documentation is nice. But in general it seems like a way less feature-rich clone of what @Addshore'" (035 comments) [core] - 10https://gerrit.wikimedia.org/r/550708 (https://phabricator.wikimedia.org/T238224) (owner: 10Kosta Harlan) [15:19:41] 10MediaWiki-Special-pages, 10MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), 10Patch-For-Review, 10good first task: Show number of items on Whatlinkshere if less than limit value - https://phabricator.wikimedia.org/T44357 (10Scott) Hi, great to see this suggestion finally being implemented 7 years after I filed... [15:26:51] 10MediaWiki-extensions-WikibaseClient, 10Commons, 10TestMe: "Failed to serialize data" on Commons pages using Wikidata based templates - https://phabricator.wikimedia.org/T195962 (10Jarekt) File [https://commons.wikimedia.org/wiki/File:L%27Int%C3%A9rieur_du_Mus%C3%A9e_des_beaux-arts_de_Nancy.jpg|c:File:L%27I... [15:32:04] 10Google-Code-in-2019: Potentially invite GCI 2018 winners and mentor to visit WMF SF office in June 2020 - https://phabricator.wikimedia.org/T245345 (10Ebe123) [15:32:07] 10Structured Data Engineering, 10Structured-Data-Backlog, 10WikibaseMediaInfo, 10Wikimedia-production-error: Wikibase\Lib\Store\DivergingEntityIdException: "Revision 386521405 belongs to M43864745 instead of expected M79277318" - https://phabricator.wikimedia.org/T244654 (10Jarekt) We are still getting thi... [15:33:09] 10Google-Code-in-2019: Potentially invite GCI 2018 winners and mentor to visit WMF SF office in June 2020 - https://phabricator.wikimedia.org/T245345 (10IAmNetx) Isn't this a duplicate of T241929? [15:33:56] 10Developer-Advocacy: Potentially invite GCI 2019 winners and mentor to visit WMF SF office in June 2020 - https://phabricator.wikimedia.org/T241929 (10Urbanecm) [15:34:00] 10Google-Code-in-2019: Potentially invite GCI 2018 winners and mentor to visit WMF SF office in June 2020 - https://phabricator.wikimedia.org/T245345 (10Ebe123) [15:34:02] 10Google-Code-in-2019: Potentially invite GCI 2018 winners and mentor to visit WMF SF office in June 2020 - https://phabricator.wikimedia.org/T245345 (10Urbanecm) >>! In T245345#5887367, @IAmNetx wrote: > Isn't this a duplicate of T241929? Indeed it is, merged. [15:34:04] 10Developer-Advocacy: Potentially invite GCI 2019 winners and mentor to visit WMF SF office in June 2020 - https://phabricator.wikimedia.org/T241929 (10Ebe123) [15:34:08] 10Google-Code-in-2019: Potentially invite GCI 2018 winners and mentor to visit WMF SF office in June 2020 - https://phabricator.wikimedia.org/T245345 (10Ebe123) Yeah, didn't notice. [15:37:31] (03Abandoned) 10Ammarpad: Use OOUI icon for user contributions menu item [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/570882 (https://phabricator.wikimedia.org/T244436) (owner: 10Ammarpad) [15:38:28] (03CR) 10Ammarpad: "> There is a more complete solution to this in the works in" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/570882 (https://phabricator.wikimedia.org/T244436) (owner: 10Ammarpad) [15:45:25] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I support the idea, but this doesn't seem to work very well. It works for portlets inside the hamburger menu, but not for other menus on t" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/571111 (https://phabricator.wikimedia.org/T236711) (owner: 10Jdlrobson) [15:55:55] 10Texvcjs: texvcjs should not replace $\omicron$ with $\mathrm{o}$ - https://phabricator.wikimedia.org/T245343 (10Physikerwelt) @Debenben Can you have a look at the replacement list https://github.com/ag-gipp/texvc-latex/blob/master/texvc.pdf and check if there are further commands, where the replacements genera... [16:04:44] 10Google-Code-in-2019: Potentially invite GCI 2019 winners and mentor to visit WMF SF office in June 2020 - https://phabricator.wikimedia.org/T245345 (10Aklapper) [16:23:22] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Campsite, 10MW-1.35-notes (1.35.0-wmf.8; 2019-11-26): Wikibase's cache/integration-tests incompatible with PHPUnit 8 - https://phabricator.wikimedia.org/T237164 (10Ladsgroup) >>! In T237164#5827895, @Addshore wrote: > Disabling this test loo... [16:40:15] 10MediaWiki-Installer, 10MediaWiki-Internationalization, 10Core Platform Team, 10Patch-For-Review: PLURAL magicword not parsed during installation: "Password must be at least {{PLURAL:10|1 character|10 characters}}" - https://phabricator.wikimedia.org/T238464 (10Aklapper) Boldly adding #Core_Platform_Team... [16:41:50] 10MediaWiki-extensions-OATHAuth: Webauthn: key unknown (due to not using the same site) - https://phabricator.wikimedia.org/T244347 (10Aklapper) [16:42:51] (03PS2) 10Thiemo Kreuz (WMDE): Prefer assertSame() over assertEquals() if possible [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572411 [16:44:27] 10Structured Data Engineering, 10Structured-Data-Backlog, 10WikibaseMediaInfo, 10Wikimedia-production-error: Wikibase\Lib\Store\DivergingEntityIdException: "Revision 386521405 belongs to M43864745 instead of expected M79277318" - https://phabricator.wikimedia.org/T244654 (10Tacsipacsi) This may be relevant... [16:45:17] (03PS3) 10Thiemo Kreuz (WMDE): Add some missing PHPDoc comments [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572321 [16:55:07] 10AbuseFilter: Spam filter for the Konkani WIkipedia - https://phabricator.wikimedia.org/T242441 (10Aklapper) @The_Discoverer: As this does not seem to be a topic about actual AbuseFilter code, but about its configuration on a wiki, https://www.mediawiki.org/wiki/Extension_talk:AbuseFilter or https://www.mediawi... [16:56:04] 10AbuseFilter: Spam filter for the Konkani WIkipedia - https://phabricator.wikimedia.org/T242441 (10Aklapper) Also CC'ing @Daimona for a potential opinion ^ [16:57:10] (03PS1) 10Urbanecm: Inform users about common.js's power [core] - 10https://gerrit.wikimedia.org/r/572415 (https://phabricator.wikimedia.org/T200878) [17:01:15] 10Developer-Advocacy, 10Epic: Develop, test and evaluate different formats to build technical capacity in smaller wikis - https://phabricator.wikimedia.org/T242542 (10Aklapper) @srishakatux: Would "Local AbuseFilter rules configuration" justify a task on its own? Example: https://phabricator.wikimedia.org/T242... [17:10:53] (03CR) 10jerkins-bot: [V: 04-1] Inform users about common.js's power [core] - 10https://gerrit.wikimedia.org/r/572415 (https://phabricator.wikimedia.org/T200878) (owner: 10Urbanecm) [17:22:14] 10Security-Team, 10PM: Create weekly status email for security-team@ combining Asana and Phab - https://phabricator.wikimedia.org/T242285 (10Aklapper) @chasemp: Most simple would be to use one or more existing `queryKey`s when calling `maniphest.search` and then parsing the JSON output, as a good bunch of Secu... [17:23:51] (03CR) 10Matěj Suchánek: Inform users about common.js's power (031 comment) [core] - 10https://gerrit.wikimedia.org/r/572415 (https://phabricator.wikimedia.org/T200878) (owner: 10Urbanecm) [17:25:02] (03CR) 10Matěj Suchánek: "recheck" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/571681 (owner: 10Sahajsk) [17:26:24] (03PS2) 10Urbanecm: Inform users about common.js's power [core] - 10https://gerrit.wikimedia.org/r/572415 (https://phabricator.wikimedia.org/T200878) [17:26:34] (03CR) 10Urbanecm: Inform users about common.js's power (031 comment) [core] - 10https://gerrit.wikimedia.org/r/572415 (https://phabricator.wikimedia.org/T200878) (owner: 10Urbanecm) [17:27:01] (03CR) 10Tpt: [C: 03+2] Add some missing PHPDoc comments [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572321 (owner: 10Thiemo Kreuz (WMDE)) [17:27:09] 10MediaWiki-General, 10Patch-For-Review, 10Security, 10Security Related, 10User-Urbanecm: Users should be warned againts putting arbitrary code to personal scripts - https://phabricator.wikimedia.org/T200878 (10Urbanecm) a:03Urbanecm [17:27:55] (03CR) 10Tpt: [C: 03+2] Prefer assertSame() over assertEquals() if possible [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572411 (owner: 10Thiemo Kreuz (WMDE)) [17:28:25] (03CR) 10Tpt: [C: 03+2] Remove lines from PHPDoc comments that aren't helpful [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572320 (owner: 10Thiemo Kreuz (WMDE)) [17:29:26] (03CR) 10Tpt: [C: 03+2] Minor code cleanups in various places in the codebase [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572348 (owner: 10Thiemo Kreuz (WMDE)) [17:30:01] 10Mathe für Nicht-Freaks: Artikel "Koordinatenraum" - https://phabricator.wikimedia.org/T238016 (10ZornschesLemma) a:03Matheoldie [17:30:29] (03CR) 10Tpt: [C: 03+2] Minor clean-ups to regular expressions in PageContentHandler [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572410 (owner: 10Thiemo Kreuz (WMDE)) [17:31:02] (03CR) 10Tpt: [C: 03+2] Remove unused $input parameters from render() methods [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572409 (owner: 10Thiemo Kreuz (WMDE)) [17:31:29] 10Wikispeech-STTS, 10Wikispeech-Text-to-Speech, 10Wikispeech-Jobrunner (Sprint): Create pull request for STTS' AhoTTS fork - https://phabricator.wikimedia.org/T243493 (10HannaLindgren) [17:33:07] (03Merged) 10jenkins-bot: Add some missing PHPDoc comments [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572321 (owner: 10Thiemo Kreuz (WMDE)) [17:33:22] (03Merged) 10jenkins-bot: Prefer assertSame() over assertEquals() if possible [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572411 (owner: 10Thiemo Kreuz (WMDE)) [17:33:48] (03Merged) 10jenkins-bot: Remove lines from PHPDoc comments that aren't helpful [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572320 (owner: 10Thiemo Kreuz (WMDE)) [17:33:50] (03CR) 10jerkins-bot: [V: 04-1] Minor code cleanups in various places in the codebase [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572348 (owner: 10Thiemo Kreuz (WMDE)) [17:35:58] (03Merged) 10jenkins-bot: Minor clean-ups to regular expressions in PageContentHandler [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572410 (owner: 10Thiemo Kreuz (WMDE)) [17:36:20] (03Merged) 10jenkins-bot: Remove unused $input parameters from render() methods [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572409 (owner: 10Thiemo Kreuz (WMDE)) [17:38:26] (03CR) 10Ammarpad: Inform users about common.js's power (031 comment) [core] - 10https://gerrit.wikimedia.org/r/572415 (https://phabricator.wikimedia.org/T200878) (owner: 10Urbanecm) [18:25:56] 10VideoCutTool, 10good first task: Tool should also to take the Video URL as param and edit. - https://phabricator.wikimedia.org/T243746 (10Gopavasanth) Hey @lalit97, Do you have any updates to share? [18:26:21] 10MediaWiki-extensions-Scribunto, 10I18n, 10good first task: Define lmo translations for Module namespace - https://phabricator.wikimedia.org/T244887 (10Sciking) Ok, the correct translation in Lombard for "Module" is "Mòdul" [18:32:47] (03PS9) 10Krinkle: registration: Cache lazy-loaded attributes and make easier to use [core] - 10https://gerrit.wikimedia.org/r/559321 (https://phabricator.wikimedia.org/T220994) (owner: 10Legoktm) [18:41:45] (03CR) 10Krinkle: "I see a PSR-4 oppertunity ;-)" [core] - 10https://gerrit.wikimedia.org/r/342282 (owner: 10Jforrester) [18:44:30] 10Texvcjs: texvcjs should not replace $\omicron$ with $\mathrm{o}$ - https://phabricator.wikimedia.org/T245343 (10Physikerwelt) I realized that `\Omicron` (the uppercase variant) does not render on https://www.tuhh.de/MathJax/test/sample-dynamic.html [18:47:05] 10MobileFrontend, 10AbuseFilter, 10Contributors-Team: Source editing gets stuck when saving changes that hit an abuse filter - https://phabricator.wikimedia.org/T123269 (10Ammarpad) 05Open→03Resolved I think this get fixed in the meanwhile. I am seeing error message correctly [19:01:23] (03PS2) 10Aron Manning: Remove `background:` rule from table cells to enable row background-color overrides in wikitext. [skins/Timeless] - 10https://gerrit.wikimedia.org/r/572408 (https://phabricator.wikimedia.org/T238482) [19:04:20] 10Texvcjs: texvcjs should not replace $\omicron$ with $\mathrm{o}$ - https://phabricator.wikimedia.org/T245343 (10Debenben) @Physikerwelt \Omicron being upright is fine, see https://tex.stackexchange.com/questions/119248. I would use the unicode-math package for XeLaTeX or LuaLaTeX as reference here, for non-L... [19:05:58] 10Timeless, 10CSS, 10Patch-For-Review: Timeless class=wikitable hides styles on table rows - https://phabricator.wikimedia.org/T238482 (10Demian) >>! In T238482#5758202, @Seudo wrote: > Note that the same is true when adding a style on the whole table (in addition to the "wikitable" class"). The second patch... [19:06:10] (03CR) 10jerkins-bot: [V: 04-1] registration: Cache lazy-loaded attributes and make easier to use [core] - 10https://gerrit.wikimedia.org/r/559321 (https://phabricator.wikimedia.org/T220994) (owner: 10Legoktm) [19:09:11] (03PS3) 10Thiemo Kreuz (WMDE): Minor code cleanups in various places in the codebase [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572348 [19:12:17] (03CR) 10Krinkle: [C: 04-1] "[DeferredUpdates] Deferred update 'MWCallableUpdate_MediaWiki->schedulePostSendJobs' failed to run. LogicException: JobRunner::run called " [core] - 10https://gerrit.wikimedia.org/r/559321 (https://phabricator.wikimedia.org/T220994) (owner: 10Legoktm) [19:14:16] (03CR) 10Krinkle: [C: 03+2] Follow-up 37a69a2f: ResourceLoaderSkinModule: Fix wfDeprecated() syntax (031 comment) [core] - 10https://gerrit.wikimedia.org/r/572322 (owner: 10Jforrester) [19:18:51] (03PS1) 10Krinkle: DevelopmentSettings: Enable 'fatal' and 'DeferredUpdates' error channels [core] - 10https://gerrit.wikimedia.org/r/572418 [19:19:51] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "This is really scary code if all you actually want to do is a str_replace( '_', ' ', … ). What's the issue with that?" [core] - 10https://gerrit.wikimedia.org/r/571681 (owner: 10Sahajsk) [19:21:21] (03Abandoned) 10Krinkle: objectcache: Add corruption debugger to MemcachedPeclBagOStuff::doGetMulti [core] - 10https://gerrit.wikimedia.org/r/558589 (https://phabricator.wikimedia.org/T239724) (owner: 10Krinkle) [19:21:58] (03CR) 10Krinkle: [C: 03+2] Convert $wgMemc use to WANObjectCache [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/570780 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [19:22:30] 10MediaWiki-General, 10User-DannyS712: Factor username logic out of the User class - https://phabricator.wikimedia.org/T245231 (10daniel) >>! In T245231#5885545, @DannyS712 wrote: > For UserNameUtils, I don't know if this will remain stateless, since it will still interact with some globals As long as it only... [19:22:46] (03CR) 10Aron Manning: "That CSS trick - setting #globalWrapper minimum font-size to 11.43px - actually makes sense for the rare user, who sets the browser's font" (031 comment) [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/570174 (https://phabricator.wikimedia.org/T245136) (owner: 10Aron Manning) [19:23:22] (03PS8) 10Aron Manning: Extend documentation of CSS trick to set the minimum content font-size to 11.43px [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/570174 [19:23:46] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Relax wikimedia/assert dependency to allow upgrade to 0.5.0 (031 comment) [libs/LangConv] - 10https://gerrit.wikimedia.org/r/572328 (owner: 10Jforrester) [19:24:39] (03Merged) 10jenkins-bot: Relax wikimedia/assert dependency to allow upgrade to 0.5.0 [libs/LangConv] - 10https://gerrit.wikimedia.org/r/572328 (owner: 10Jforrester) [19:25:50] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Relax wikimedia/assert dependency to allow upgrade to 0.5.0 [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/572325 (owner: 10Jforrester) [19:26:36] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Fix MediaWiki.Commenting.LicenseComment.InvalidLicenseTag [extensions/ArticleToCategory2] - 10https://gerrit.wikimedia.org/r/572114 (owner: 10Zoranzoki21) [19:28:34] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Fix MediaWiki.Files.ClassMatchesFilename.NotMatch [extensions/ArticleToCategory2] - 10https://gerrit.wikimedia.org/r/572113 (owner: 10Zoranzoki21) [19:29:07] (03CR) 10Aron Manning: "Note that this patch is just a byproduct of making consistent the font-family-* name usage. It's not an important patch." [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/570174 (owner: 10Aron Manning) [19:29:32] (03Merged) 10jenkins-bot: Follow-up 37a69a2f: ResourceLoaderSkinModule: Fix wfDeprecated() syntax [core] - 10https://gerrit.wikimedia.org/r/572322 (owner: 10Jforrester) [19:29:47] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Rename WhitelistPages.class.php to WhitelistPages.php [extensions/WhitelistPages] - 10https://gerrit.wikimedia.org/r/571395 (owner: 10Zoranzoki21) [19:32:17] (03CR) 10Aron Manning: "Also, recall my previous question above:" [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/570174 (owner: 10Aron Manning) [19:32:43] 10VideoCutTool, 10good first task: Tool should also to take the Video URL as param and edit. - https://phabricator.wikimedia.org/T243746 (10lalit97) nope, I will share updates within 2-3 days [19:38:40] (03Merged) 10jenkins-bot: Convert $wgMemc use to WANObjectCache [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/570780 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [19:38:57] (03PS9) 10Aron Manning: Extend documentation of CSS trick that sets the minimum content font-size to 11.43px [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/570174 [19:47:13] (03CR) 10Krinkle: [C: 03+1] Switch mw.user.sessionId back to session-cookie persistence (032 comments) [core] - 10https://gerrit.wikimedia.org/r/572011 (https://phabricator.wikimedia.org/T223931) (owner: 10Bearloga) [19:48:38] (03Merged) 10jenkins-bot: Relax wikimedia/assert dependency to allow upgrade to 0.5.0 [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/572325 (owner: 10Jforrester) [19:48:40] (03Merged) 10jenkins-bot: Fix MediaWiki.Files.ClassMatchesFilename.NotMatch [extensions/ArticleToCategory2] - 10https://gerrit.wikimedia.org/r/572113 (owner: 10Zoranzoki21) [19:48:42] (03Merged) 10jenkins-bot: Fix MediaWiki.Commenting.LicenseComment.InvalidLicenseTag [extensions/ArticleToCategory2] - 10https://gerrit.wikimedia.org/r/572114 (owner: 10Zoranzoki21) [19:48:44] (03Merged) 10jenkins-bot: Rename WhitelistPages.class.php to WhitelistPages.php [extensions/WhitelistPages] - 10https://gerrit.wikimedia.org/r/571395 (owner: 10Zoranzoki21) [19:54:21] (03CR) 10Krinkle: [C: 03+1] Switch mw.user.sessionId back to session-cookie persistence (031 comment) [core] - 10https://gerrit.wikimedia.org/r/572011 (https://phabricator.wikimedia.org/T223931) (owner: 10Bearloga) [19:57:12] 10MediaWiki-Interface, 10Desktop Improvements, 10Core Platform Team Workboards (Clinic Duty Team), 10Logos, and 3 others: Separate out logo handling into square image logos and long text/wordmark banner logos - https://phabricator.wikimedia.org/T232140 (10Krinkle) >>! Change 572322 by @Jdforrester-WMF and... [19:57:47] (03CR) 10Krinkle: "James and Gergo did the same at Iadeec9520867, which I landed meanwhile. Didn't notice this one in time." [core] - 10https://gerrit.wikimedia.org/r/572308 (https://phabricator.wikimedia.org/T232140) (owner: 10Jdlrobson) [19:59:23] (03CR) 10Krinkle: [C: 03+2] Follow-up 37a69a2f: ResourceLoaderSkinModule: Fix wfDeprecated() syntax (031 comment) [core] - 10https://gerrit.wikimedia.org/r/572322 (owner: 10Jforrester) [20:36:32] (03PS25) 10Wugapodes: parsing: build board in PHP [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/563326 (https://phabricator.wikimedia.org/T239437) [20:37:45] (03CR) 10jerkins-bot: [V: 04-1] parsing: build board in PHP [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/563326 (https://phabricator.wikimedia.org/T239437) (owner: 10Wugapodes) [20:39:03] (03PS26) 10Wugapodes: parsing: build board in PHP [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/563326 (https://phabricator.wikimedia.org/T239437) [20:53:48] (03PS10) 10Aaron Schulz: Replace use of ArticleEditUpdates hook with RevisionDataUpdates [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/571392 (https://phabricator.wikimedia.org/T245175) (owner: 10Jforrester) [20:54:13] 10Structured Data Engineering, 10Structured-Data-Backlog, 10SDC-Statements (Machine-vision-depicts): Suggested Tags should not suggest tags that are already applied - https://phabricator.wikimedia.org/T245208 (10kaldari) [20:54:15] 10MachineVision, 10Structured-Data-Backlog, 10SDC-Statements (Machine-vision-depicts): Do not serve label suggestions that have already been added as depicts statements - https://phabricator.wikimedia.org/T240516 (10kaldari) [21:00:45] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Maps (Kartographer): Maplink (via Wikidata) shows only empty window without map on all wikipedias - https://phabricator.wikimedia.org/T225350 (10UV) [21:06:37] (03PS17) 10Wugapodes: Submodule and license: Add PGN Parser Submodule [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/561389 (https://phabricator.wikimedia.org/T239438) [21:14:27] (03CR) 10Aaron Schulz: [C: 03+1] Replace use of ArticleEditUpdates hook with RevisionDataUpdates [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/571392 (https://phabricator.wikimedia.org/T245175) (owner: 10Jforrester) [21:30:53] (03CR) 10Jason Linehan: [C: 04-1] Switch mw.user.sessionId back to session-cookie persistence (031 comment) [core] - 10https://gerrit.wikimedia.org/r/572011 (https://phabricator.wikimedia.org/T223931) (owner: 10Bearloga) [21:39:23] (03PS18) 10Wugapodes: Submodule and license: Add PGN Parser Submodule [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/561389 (https://phabricator.wikimedia.org/T239438) [21:39:23] (03PS16) 10Wugapodes: parsing: implement json data output [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/563005 (https://phabricator.wikimedia.org/T239438) [21:43:44] 10Phabricator, 10Release-Engineering-Team: change "default" column on Parsoid workboard - https://phabricator.wikimedia.org/T245308 (10LGoto) Looks like only 90 tasks moved when I first did this, though. I'm trying the "move to column" again for the remaining tasks. [21:45:08] (03PS27) 10Wugapodes: parsing: build board in PHP [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/563326 (https://phabricator.wikimedia.org/T239437) [21:46:19] (03CR) 10jerkins-bot: [V: 04-1] parsing: build board in PHP [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/563326 (https://phabricator.wikimedia.org/T239437) (owner: 10Wugapodes) [21:48:13] (03PS28) 10Wugapodes: parsing: build board in PHP [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/563326 (https://phabricator.wikimedia.org/T239437) [21:49:43] (03CR) 10jerkins-bot: [V: 04-1] parsing: build board in PHP [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/563326 (https://phabricator.wikimedia.org/T239437) (owner: 10Wugapodes) [21:49:43] (03PS29) 10Wugapodes: parsing: build board in PHP [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/563326 (https://phabricator.wikimedia.org/T239437) [21:50:46] (03PS30) 10Wugapodes: parsing: build board in PHP [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/563326 (https://phabricator.wikimedia.org/T239437) [21:54:44] (03CR) 10Matěj Suchánek: "> Patch Set 4: Code-Review-1" [core] - 10https://gerrit.wikimedia.org/r/571681 (owner: 10Sahajsk) [21:57:01] (03PS2) 10Krinkle: rdbms: make Database::build(Greatest|Least) support expressions [core] - 10https://gerrit.wikimedia.org/r/571684 (owner: 10Aaron Schulz) [21:57:05] (03CR) 10Krinkle: [C: 03+2] rdbms: make Database::build(Greatest|Least) support expressions [core] - 10https://gerrit.wikimedia.org/r/571684 (owner: 10Aaron Schulz) [21:57:14] (03PS5) 10Krinkle: Make SiteStatsUpdate avoid setting negative values in the table [core] - 10https://gerrit.wikimedia.org/r/501840 (owner: 10Aaron Schulz) [21:57:52] (03CR) 10Krinkle: [C: 03+2] "This general area needs more work, but this doesn't make it work and is a quick way to avoid strict errors and make the display less confu" [core] - 10https://gerrit.wikimedia.org/r/501840 (owner: 10Aaron Schulz) [22:04:10] (03PS14) 10Wugapodes: javascript: implement new JS module code [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/567699 (https://phabricator.wikimedia.org/T240742) [22:05:28] (03CR) 10jerkins-bot: [V: 04-1] javascript: implement new JS module code [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/567699 (https://phabricator.wikimedia.org/T240742) (owner: 10Wugapodes) [22:12:59] (03Merged) 10jenkins-bot: rdbms: make Database::build(Greatest|Least) support expressions [core] - 10https://gerrit.wikimedia.org/r/571684 (owner: 10Aaron Schulz) [22:13:13] (03Merged) 10jenkins-bot: Make SiteStatsUpdate avoid setting negative values in the table [core] - 10https://gerrit.wikimedia.org/r/501840 (owner: 10Aaron Schulz) [22:24:35] (03PS10) 10Krinkle: rdbms: dependency inject domain aliases into LBFactory [core] - 10https://gerrit.wikimedia.org/r/520684 (owner: 10Aaron Schulz) [22:25:09] (03CR) 10DannyS712: "Could use some cleanup, but will do as a subsequent patch; looks good from my point of view, though I'm not able to test" [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/561389 (https://phabricator.wikimedia.org/T239438) (owner: 10Wugapodes) [22:25:55] (03PS15) 10DannyS712: javascript: implement new JS module code [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/567699 (https://phabricator.wikimedia.org/T240742) (owner: 10Wugapodes) [22:29:12] (03PS1) 10Jforrester: build: Drop direct dependency on eslint, we only use it through grunt-eslint [extensions/Jade] - 10https://gerrit.wikimedia.org/r/572424 [22:29:14] (03PS1) 10Jforrester: build: Pin versions, to avoid CI issues [extensions/Jade] - 10https://gerrit.wikimedia.org/r/572425 [22:29:16] (03PS1) 10Jforrester: build: Upgrade stylelint-config-wikimedia from 0.7.0 to 0.9.0 [extensions/Jade] - 10https://gerrit.wikimedia.org/r/572426 [22:29:18] (03PS1) 10Jforrester: build: Upgrade eslint-plugin-compat from 3.3.0 to 3.5.1 [extensions/Jade] - 10https://gerrit.wikimedia.org/r/572427 [22:29:20] (03PS1) 10Jforrester: build: Replace jsonlint with eslint's JSON parsing and make pass [extensions/Jade] - 10https://gerrit.wikimedia.org/r/572428 [22:29:22] (03PS1) 10Jforrester: build: Fix stylelint config to run on style files(!) and make pass [extensions/Jade] - 10https://gerrit.wikimedia.org/r/572429 [22:31:58] (03PS11) 10Krinkle: rdbms: dependency inject domain aliases into LBFactory [core] - 10https://gerrit.wikimedia.org/r/520684 (owner: 10Aaron Schulz) [22:32:44] (03CR) 10Krinkle: rdbms: dependency inject domain aliases into LBFactory (032 comments) [core] - 10https://gerrit.wikimedia.org/r/520684 (owner: 10Aaron Schulz) [22:34:46] (03PS12) 10Krinkle: rdbms: dependency inject domain aliases into LBFactory [core] - 10https://gerrit.wikimedia.org/r/520684 (owner: 10Aaron Schulz) [22:34:50] (03CR) 10Krinkle: [C: 03+2] rdbms: dependency inject domain aliases into LBFactory [core] - 10https://gerrit.wikimedia.org/r/520684 (owner: 10Aaron Schulz) [22:37:58] (03CR) 10Jforrester: [C: 03+1] Replace use of ArticleEditUpdates hook with RevisionDataUpdates [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/571392 (https://phabricator.wikimedia.org/T245175) (owner: 10Jforrester) [22:38:14] (03PS5) 10Jforrester: build: Updating composer dependencies [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/568321 (owner: 10Libraryupgrader) [22:38:25] (03PS4) 10Jforrester: Remove use of Title::userCan [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/572030 (https://phabricator.wikimedia.org/T244923) (owner: 10DannyS712) [22:44:24] (03CR) 10Legoktm: [C: 03+2] build: Drop direct dependency on eslint, we only use it through grunt-eslint [extensions/Jade] - 10https://gerrit.wikimedia.org/r/572424 (owner: 10Jforrester) [22:44:34] (03CR) 10Legoktm: [C: 03+2] build: Pin versions, to avoid CI issues [extensions/Jade] - 10https://gerrit.wikimedia.org/r/572425 (owner: 10Jforrester) [22:44:44] (03CR) 10Legoktm: [C: 03+2] build: Upgrade stylelint-config-wikimedia from 0.7.0 to 0.9.0 [extensions/Jade] - 10https://gerrit.wikimedia.org/r/572426 (owner: 10Jforrester) [22:44:53] (03CR) 10Legoktm: [C: 03+2] build: Upgrade eslint-plugin-compat from 3.3.0 to 3.5.1 [extensions/Jade] - 10https://gerrit.wikimedia.org/r/572427 (owner: 10Jforrester) [22:45:22] (03CR) 10Legoktm: [C: 03+2] build: Replace jsonlint with eslint's JSON parsing and make pass [extensions/Jade] - 10https://gerrit.wikimedia.org/r/572428 (owner: 10Jforrester) [22:46:03] (03CR) 10Legoktm: [C: 03+2] build: Fix stylelint config to run on style files(!) and make pass [extensions/Jade] - 10https://gerrit.wikimedia.org/r/572429 (owner: 10Jforrester) [22:47:27] (03PS1) 10TheDJ: Syntaxhighlight: Classnames for the highlighted language [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/572432 (https://phabricator.wikimedia.org/T189106) [22:47:34] (03CR) 10Jforrester: [C: 03+2] DevelopmentSettings: Enable 'fatal' and 'DeferredUpdates' error channels [core] - 10https://gerrit.wikimedia.org/r/572418 (owner: 10Krinkle) [22:48:31] (03CR) 10jerkins-bot: [V: 04-1] Syntaxhighlight: Classnames for the highlighted language [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/572432 (https://phabricator.wikimedia.org/T189106) (owner: 10TheDJ) [22:50:58] (03Merged) 10jenkins-bot: rdbms: dependency inject domain aliases into LBFactory [core] - 10https://gerrit.wikimedia.org/r/520684 (owner: 10Aaron Schulz) [22:51:00] (03Merged) 10jenkins-bot: build: Drop direct dependency on eslint, we only use it through grunt-eslint [extensions/Jade] - 10https://gerrit.wikimedia.org/r/572424 (owner: 10Jforrester) [22:51:02] (03Merged) 10jenkins-bot: build: Pin versions, to avoid CI issues [extensions/Jade] - 10https://gerrit.wikimedia.org/r/572425 (owner: 10Jforrester) [22:51:04] (03Merged) 10jenkins-bot: build: Upgrade stylelint-config-wikimedia from 0.7.0 to 0.9.0 [extensions/Jade] - 10https://gerrit.wikimedia.org/r/572426 (owner: 10Jforrester) [22:51:06] (03Merged) 10jenkins-bot: build: Upgrade eslint-plugin-compat from 3.3.0 to 3.5.1 [extensions/Jade] - 10https://gerrit.wikimedia.org/r/572427 (owner: 10Jforrester) [22:52:05] 10OOUI, 10Documentation: Probably error in doc of SelectFileWidget change event - https://phabricator.wikimedia.org/T242107 (10TheDJ) [22:52:25] (03CR) 10Jforrester: [C: 03+1] Escape % sign if form valid percent-encoding in fragment identifiers [core] - 10https://gerrit.wikimedia.org/r/572403 (https://phabricator.wikimedia.org/T238385) (owner: 10Brian Wolff) [22:55:07] (03Merged) 10jenkins-bot: build: Replace jsonlint with eslint's JSON parsing and make pass [extensions/Jade] - 10https://gerrit.wikimedia.org/r/572428 (owner: 10Jforrester) [22:55:18] (03Merged) 10jenkins-bot: build: Fix stylelint config to run on style files(!) and make pass [extensions/Jade] - 10https://gerrit.wikimedia.org/r/572429 (owner: 10Jforrester) [22:57:26] (03PS1) 10Jforrester: Follow-up d4964feaa3: Also drop .travis.yml reference from .gitattributes [WrappedString] - 10https://gerrit.wikimedia.org/r/572433 [22:58:05] (03PS1) 10Jforrester: Follow-up f1f6b5548f: Also drop .travis.yml reference from .gitattributes [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/572434 [22:59:04] 10Wikiportrait: Non-functioning Wikiportret checkboxes - https://phabricator.wikimedia.org/T245351 (10Encycloon) [22:59:53] (03PS1) 10Jforrester: Drop Travis testing, no extra advantage over Wikimedia CI and runs post-merge anyway [libs/Zest] - 10https://gerrit.wikimedia.org/r/572435 [23:00:50] (03PS1) 10Jforrester: Follow-up 269f42149d: Also drop .travis.yml reference from .gitattributes [libs/Timestamp] - 10https://gerrit.wikimedia.org/r/572436 [23:01:21] (03PS1) 10Jforrester: Follow-up 010cc8d553c: Also drop .travis.yml reference from .gitattributes [libs/WaitConditionLoop] - 10https://gerrit.wikimedia.org/r/572437 [23:02:11] (03PS1) 10Jforrester: Follow-up 93db0ebbd: Also drop .travis.yml reference from .gitattributes [libs/ScopedCallback] - 10https://gerrit.wikimedia.org/r/572438 [23:02:43] (03PS1) 10Jforrester: Follow-up 298bdf6afb: Also drop .travis.yml reference from .gitattributes [RunningStat] - 10https://gerrit.wikimedia.org/r/572439 [23:03:17] (03PS1) 10Jforrester: Follow-up 52a10e9788d: Also drop .travis.yml reference from .gitattributes [libs/RemexHtml] - 10https://gerrit.wikimedia.org/r/572440 [23:04:07] (03PS1) 10Jforrester: Follow-up 7253698c36: Also drop .travis.yml reference from .gitattributes [RelPath] - 10https://gerrit.wikimedia.org/r/572441 [23:05:22] (03PS1) 10Jforrester: Drop Travis testing, no extra advantage over Wikimedia CI and runs post-merge anyway [libs/ObjectFactory] - 10https://gerrit.wikimedia.org/r/572442 [23:05:52] (03Merged) 10jenkins-bot: DevelopmentSettings: Enable 'fatal' and 'DeferredUpdates' error channels [core] - 10https://gerrit.wikimedia.org/r/572418 (owner: 10Krinkle) [23:07:35] (03PS2) 10TheDJ: Syntaxhighlight: Classnames for the highlighted language [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/572432 (https://phabricator.wikimedia.org/T189106) [23:07:49] (03PS1) 10Jforrester: Follow-up 8270f11003: Also drop .travis.yml reference from .gitattributes [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/572444 [23:08:33] (03PS1) 10Jforrester: Follow-up 8df7b6b196: Also drop .travis.yml reference from .gitattributes [IPSet] - 10https://gerrit.wikimedia.org/r/572445 [23:09:15] (03PS1) 10Jforrester: Follow-up bc221b3245: Also drop .travis.yml reference from .gitattributes [HtmlFormatter] - 10https://gerrit.wikimedia.org/r/572446 [23:10:21] (03PS1) 10Jforrester: Follow-up 4f8d6d8082: Also drop .travis.yml reference from .gitattributes [libs/Equivset] - 10https://gerrit.wikimedia.org/r/572447 [23:10:54] (03PS1) 10Jforrester: Follow-up 2edb03e92bf: Also drop .travis.yml reference from .gitattributes [CLDRPluralRuleParser] - 10https://gerrit.wikimedia.org/r/572448 [23:11:46] (03PS1) 10Jforrester: Follow-up d7c3443fc6d: Also drop .travis.yml reference from .gitattributes [cdb] - 10https://gerrit.wikimedia.org/r/572449 [23:12:16] (03CR) 10jerkins-bot: [V: 04-1] Syntaxhighlight: Classnames for the highlighted language [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/572432 (https://phabricator.wikimedia.org/T189106) (owner: 10TheDJ) [23:12:56] (03PS1) 10Jforrester: Follow-up ffd94fa: Also drop .travis.yml reference from .gitattributes [libs/Assert] - 10https://gerrit.wikimedia.org/r/572450 [23:13:58] (03PS1) 10Jforrester: Drop Travis testing, no extra advantage over Wikimedia CI and runs post-merge anyway [libs/alea] - 10https://gerrit.wikimedia.org/r/572451 [23:14:34] (03PS1) 10Jforrester: Follow-up c6f0026: Also drop .travis.yml reference from .gitattributes [AhoCorasick] - 10https://gerrit.wikimedia.org/r/572452 [23:28:58] (03CR) 10Krinkle: [C: 03+2] Follow-up c6f0026: Also drop .travis.yml reference from .gitattributes [AhoCorasick] - 10https://gerrit.wikimedia.org/r/572452 (owner: 10Jforrester) [23:29:19] (03CR) 10Krinkle: [C: 03+2] Follow-up 2edb03e92bf: Also drop .travis.yml reference from .gitattributes [CLDRPluralRuleParser] - 10https://gerrit.wikimedia.org/r/572448 (owner: 10Jforrester) [23:31:23] (03CR) 10Krinkle: [C: 03+2] Drop Travis testing, no extra advantage over Wikimedia CI and runs post-merge anyway [libs/alea] - 10https://gerrit.wikimedia.org/r/572451 (owner: 10Jforrester) [23:37:05] (03Merged) 10jenkins-bot: Follow-up c6f0026: Also drop .travis.yml reference from .gitattributes [AhoCorasick] - 10https://gerrit.wikimedia.org/r/572452 (owner: 10Jforrester) [23:37:07] (03Merged) 10jenkins-bot: Follow-up 2edb03e92bf: Also drop .travis.yml reference from .gitattributes [CLDRPluralRuleParser] - 10https://gerrit.wikimedia.org/r/572448 (owner: 10Jforrester) [23:37:09] (03Merged) 10jenkins-bot: Drop Travis testing, no extra advantage over Wikimedia CI and runs post-merge anyway [libs/alea] - 10https://gerrit.wikimedia.org/r/572451 (owner: 10Jforrester) [23:40:13] hi xSavitar [23:48:16] (03CR) 10Krinkle: [C: 04-1] "recheck" [core] - 10https://gerrit.wikimedia.org/r/559321 (https://phabricator.wikimedia.org/T220994) (owner: 10Legoktm) [23:49:03] (03PS3) 10Krinkle: Remove IE 6 security features from JS code [core] - 10https://gerrit.wikimedia.org/r/552931 (https://phabricator.wikimedia.org/T232563) (owner: 10Tim Starling) [23:49:14] (03CR) 10Krinkle: [C: 03+2] "Some time has passed." [core] - 10https://gerrit.wikimedia.org/r/552931 (https://phabricator.wikimedia.org/T232563) (owner: 10Tim Starling) [23:49:59] (03CR) 10Jforrester: [C: 03+1] ApiMain: Add support for assert=anon [core] - 10https://gerrit.wikimedia.org/r/572374 (https://phabricator.wikimedia.org/T245327) (owner: 10Bartosz Dziewoński) [23:52:16] (03PS2) 10Esther Akinloose: Test for the expiry parameter of action=protect [tools/api-testing] - 10https://gerrit.wikimedia.org/r/572257 [23:54:31] (03CR) 10jerkins-bot: [V: 04-1] Test for the expiry parameter of action=protect [tools/api-testing] - 10https://gerrit.wikimedia.org/r/572257 (owner: 10Esther Akinloose) [23:55:12] 10MediaWiki-General, 10Browser-Support-Apple-Safari: Bump browser compatibility for Safari 5 and 6 from Modern to Basic. - https://phabricator.wikimedia.org/T134068 (10Krinkle) 05Open→03Declined We no longer use browsing sniffing as our main method of switching the user experience. Unless the proposal is t... [23:55:14] 10MediaWiki-General, 10Browser-Support-Apple-Safari: Page freezes/failures for Safari 6 users - https://phabricator.wikimedia.org/T134067 (10Krinkle) [23:56:20] (03CR) 10Jforrester: [C: 03+1] Use a SelectQueryBuilder in SpecialWhatLinksHere [core] - 10https://gerrit.wikimedia.org/r/566128 (https://phabricator.wikimedia.org/T243051) (owner: 10Tim Starling) [23:56:22] (03PS3) 10Esther Akinloose: Test for the expiry parameter of action=protect [tools/api-testing] - 10https://gerrit.wikimedia.org/r/572257 [23:58:31] (03Restored) 10Aron Manning: Font update: TEST adding Hack (monospaced) @font-face declarations. [skins/Timeless] - 10https://gerrit.wikimedia.org/r/570277 (https://phabricator.wikimedia.org/T244425) (owner: 10Aron Manning) [23:59:38] (03PS9) 10Aron Manning: [TEST] Font update: host 2 fonts in MediaWiki [skins/Timeless] - 10https://gerrit.wikimedia.org/r/570277 (https://phabricator.wikimedia.org/T244425)