[00:00:13] 04(no projects): Replies v2.0: Engineering - https://phabricator.wikimedia.org/T245221 (10ppelberg) [00:00:41] 10Editing-team (Tracking), 10OWC2020 (OWC2020 Replying 2.0): Replies v2.0: Engineering - https://phabricator.wikimedia.org/T245221 (10ppelberg) [00:00:42] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/572119 (https://phabricator.wikimedia.org/T245202) (owner: 10EBernhardson) [00:01:28] 10Editing-team (Tracking), 10OWC2020 (OWC2020 Replying 2.0): Replies v2.0: Engineering - https://phabricator.wikimedia.org/T245221 (10ppelberg) [00:01:30] 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board): [Epic] Affordance: Replying to specific comments - https://phabricator.wikimedia.org/T233443 (10ppelberg) [00:02:08] (03CR) 10jerkins-bot: [V: 04-1] Force namespace filter to use strings [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/572119 (https://phabricator.wikimedia.org/T245202) (owner: 10EBernhardson) [00:02:31] 10Editing-team (Tracking), 10OWC2020 (OWC2020 Replying 2.0): Replies v2.0: Engineering - https://phabricator.wikimedia.org/T245221 (10ppelberg) [00:02:33] 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board): Develop a technical approach for editing a specific comment - https://phabricator.wikimedia.org/T242562 (10ppelberg) [00:02:56] 10Editing-team (Tracking), 10OWC2020 (OWC2020 Replying 2.0): Replies v2.0: Engineering - https://phabricator.wikimedia.org/T245221 (10ppelberg) [00:03:41] 10Editing-team (Tracking), 10OWC2020 (OWC2020 Replying 2.0): Implement opt-in/out of watching talk page in Replying workflow - https://phabricator.wikimedia.org/T245222 (10ppelberg) [00:04:34] (03CR) 10jerkins-bot: [V: 04-1] Fix some PHPStorm inspection warnings in includes/api [core] - 10https://gerrit.wikimedia.org/r/571943 (owner: 10Tim Starling) [00:05:09] 10Editing-team (Tracking), 10OWC2020 (OWC2020 Replying 2.0): Replies v2.0: Engineering - https://phabricator.wikimedia.org/T245221 (10ppelberg) [00:08:22] 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board): [Epic] Affordance: Replying to specific comments - https://phabricator.wikimedia.org/T233443 (10ppelberg) [00:08:36] 10Product-Analytics: Move wmfdata to a standard Gerrit repository - https://phabricator.wikimedia.org/T245223 (10nshahquinn-wmf) [00:08:49] 10Product-Analytics: Move wmfdata to a standard Gerrit repository - https://phabricator.wikimedia.org/T245223 (10nshahquinn-wmf) p:05Triage→03Medium [00:10:00] 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board): Develop a technical approach for editing a specific comment - https://phabricator.wikimedia.org/T242562 (10ppelberg) [00:10:02] 10DiscussionTools: Comment parser should report range of comment and signature separately for comment editing - https://phabricator.wikimedia.org/T245220 (10ppelberg) [00:10:05] (03PS4) 10Nray: build: Replace JSDuck with JSDoc [skins/Vector] - 10https://gerrit.wikimedia.org/r/571841 (https://phabricator.wikimedia.org/T239258) [00:10:44] (03PS3) 10Tim Starling: Fix some PHPStorm inspection warnings in includes/api [core] - 10https://gerrit.wikimedia.org/r/571943 [00:11:48] 10Product-Analytics, 10Epic: Set consistent process for wmfdata development and updates - https://phabricator.wikimedia.org/T211951 (10nshahquinn-wmf) [00:14:08] 10Editing-team (Tracking), 10OWC2020 (OWC2020 Replying 2.0): Implement editing specific comments - https://phabricator.wikimedia.org/T245225 (10ppelberg) [00:15:11] 10Editing-team (Tracking), 10OWC2020 (OWC2020 Replying 2.0): Implement editing specific comments - https://phabricator.wikimedia.org/T245225 (10ppelberg) [00:17:33] 10OWC2020, 10Editing-team (Q3 2019-2020 Kanban Board): Develop a technical approach for editing a specific comment - https://phabricator.wikimedia.org/T242562 (10ppelberg) [00:17:35] 10Editing-team (Tracking), 10OWC2020 (OWC2020 Replying 2.0): Replies v2.0: Engineering - https://phabricator.wikimedia.org/T245221 (10ppelberg) [00:19:54] 10Anti-Harassment, 10Product-Analytics, 10Epic: [Epic] Analytics for CheckUser - https://phabricator.wikimedia.org/T245226 (10Niharika) p:05Triage→03Medium [00:20:43] 10Anti-Harassment, 10Product-Analytics, 10Epic: [Epic] Analytics for CheckUser - https://phabricator.wikimedia.org/T245226 (10Niharika) [00:21:00] 10Anti-Harassment, 10Product-Analytics, 10Epic: [Epic] Analytics for CheckUser - https://phabricator.wikimedia.org/T245226 (10Niharika) [00:21:21] 10Anti-Harassment, 10Product-Analytics, 10Epic: [Epic] Analytics for CheckUser - https://phabricator.wikimedia.org/T245226 (10Niharika) [00:21:24] 10Editing-team (Tracking), 10OWC2020 (OWC2020 Replying 2.0): Populate reply text input w/ link to parent comment's author's user page - https://phabricator.wikimedia.org/T245227 (10ppelberg) [00:27:25] (03Abandoned) 10Gergő Tisza: Do not trample over raw error parameters in HTMLForm [core] - 10https://gerrit.wikimedia.org/r/485479 (owner: 10Gergő Tisza) [00:27:29] (03CR) 10Nray: "> -1 for this question: The two event links lead to a global.html" [skins/Vector] - 10https://gerrit.wikimedia.org/r/571841 (https://phabricator.wikimedia.org/T239258) (owner: 10Nray) [00:28:04] (03CR) 10Zoranzoki21: [C: 04-1] "Commit message still needs to be fixed and merge conflict resolved." (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/570453 (owner: 10Akinwale-microsoft) [00:29:23] (03CR) 10EBernhardson: "recheck" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/572119 (https://phabricator.wikimedia.org/T245202) (owner: 10EBernhardson) [00:31:00] 10MediaWiki-General: Avoid nested dirname() calls - https://phabricator.wikimedia.org/T245228 (10Reedy) [00:32:37] 10MediaWiki-General: Avoid nested dirname() calls - https://phabricator.wikimedia.org/T245228 (10Reedy) [00:33:03] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10TestMe: Unify view-implementations in JS frontend - https://phabricator.wikimedia.org/T74666 (10TerraCodes) Is there anything that needs to be tested? Also could this issue be closed (per the above comment)? [00:39:21] (03PS5) 10Nray: build: Replace JSDuck with JSDoc [skins/Vector] - 10https://gerrit.wikimedia.org/r/571841 (https://phabricator.wikimedia.org/T239258) [00:42:16] (03CR) 10Bartosz Dziewoński: [C: 04-1] Fix: Text input label (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/571376 (owner: 10Akinwale-microsoft) [00:42:57] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup: "Cookies disabled" error on login page when cookies are enabled - https://phabricator.wikimedia.org/T30201 (10TerraCodes) I can't reproduce this, so maybe this issue no longer exists? [00:43:12] 10MediaWiki-User-login-and-signup, 10TestMe: "No cookies" error shown on login page when already logged-in - https://phabricator.wikimedia.org/T32167 (10TerraCodes) I can't reproduce this, so maybe it no longer exists? [00:44:52] (03CR) 10Akinwale-microsoft: Fix: Text input label (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/571376 (owner: 10Akinwale-microsoft) [00:45:40] (03CR) 10Jforrester: [C: 04-1] "Failures are real." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/572119 (https://phabricator.wikimedia.org/T245202) (owner: 10EBernhardson) [00:50:31] (03PS1) 10Nray: Add 'jsdoc-wmf-theme' to jsdoc [skins/Vector] - 10https://gerrit.wikimedia.org/r/572127 (https://phabricator.wikimedia.org/T239258) [00:51:29] (03CR) 10Nray: [C: 04-1] "Not ready for merge: see commit message" [skins/Vector] - 10https://gerrit.wikimedia.org/r/572127 (https://phabricator.wikimedia.org/T239258) (owner: 10Nray) [00:52:18] (03PS2) 10Nray: Add 'jsdoc-wmf-theme' to jsdoc [skins/Vector] - 10https://gerrit.wikimedia.org/r/572127 (https://phabricator.wikimedia.org/T239258) [00:53:03] 10MediaWiki-Logging, 10TestMe: User field is cleared in Special:Log if no log entries are found - https://phabricator.wikimedia.org/T35567 (10TerraCodes) Both Performer and Target fields are there for me, with text in them. [00:55:25] (03CR) 10Eric Gardner: Add Vue i18n plugin (031 comment) [core] - 10https://gerrit.wikimedia.org/r/570500 (owner: 10Catrope) [01:00:00] (03PS6) 10Nray: build: Replace JSDuck with JSDoc [skins/Vector] - 10https://gerrit.wikimedia.org/r/571841 (https://phabricator.wikimedia.org/T239258) [01:00:03] (03PS3) 10Nray: Add 'jsdoc-wmf-theme' to jsdoc [skins/Vector] - 10https://gerrit.wikimedia.org/r/572127 (https://phabricator.wikimedia.org/T239258) [01:03:19] (03PS5) 10DannyS712: EditPage: Remove use of Title::getUserPermissionsErrors (part 1) [core] - 10https://gerrit.wikimedia.org/r/572094 (https://phabricator.wikimedia.org/T244929) [01:04:09] (03PS6) 10DannyS712: EditPage: Remove use of Title::getUserPermissionsErrors (part 1) [core] - 10https://gerrit.wikimedia.org/r/572094 (https://phabricator.wikimedia.org/T244929) [01:07:58] 10Design, 10Growth-Team, 10Notifications, 10TestMe: Echo: Inconsistent link/bold formatting in flyout - https://phabricator.wikimedia.org/T68385 (10TerraCodes) I can reproduce this too (some times the username is bolded, but sometimes it isn't, looks like the page link is always bold tho) {F31615384} [01:11:35] (03PS3) 10Tchanders: Update preliminary check classes to use multi-column pagination [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572040 (https://phabricator.wikimedia.org/T244517) [01:14:44] 10MediaWiki-General, 10User-DannyS712: Factor username verification logic out of the User class - https://phabricator.wikimedia.org/T245231 (10DannyS712) [01:14:59] (03CR) 10Tchanders: Update preliminary check classes to use multi-column pagination (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572040 (https://phabricator.wikimedia.org/T244517) (owner: 10Tchanders) [01:17:41] 10MediaWiki-General, 10User-DannyS712: Factor username logic out of the User class - https://phabricator.wikimedia.org/T245231 (10DannyS712) [01:34:04] 10CheckUser: Installation of CheckUser barfs when run on a brand new mediawiki installation - https://phabricator.wikimedia.org/T244283 (10MMigurski) I’ve published a slightly smaller patch: https://github.com/migurski/extension-checkuser/commit/96c0441900b83e179306994b0fac8dc866e831c7 [01:39:00] (03CR) 10Sahajsk: "I have made the changes but is there any way to run the following tests to run on local machine." [core] - 10https://gerrit.wikimedia.org/r/571681 (owner: 10Sahajsk) [01:45:53] (03CR) 10Krinkle: Add Vue i18n plugin (031 comment) [core] - 10https://gerrit.wikimedia.org/r/570500 (owner: 10Catrope) [01:55:08] (03CR) 10Krinkle: "Do we know what caused the types to change? Was it intentional?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/572119 (https://phabricator.wikimedia.org/T245202) (owner: 10EBernhardson) [01:59:28] 10Arc-Lamp, 10SRE-swift-storage, 10Patch-For-Review, 10Performance-Team (Radar): Swift container for performance flame graphs (ArcLamp) - https://phabricator.wikimedia.org/T244776 (10dpifke) I submitted a patch which I *think* does what's needed to create the user, less the private keys. I don't know if t... [02:21:12] (03PS4) 10DannyS712: Pass a user to LogPage::addEntry [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/570145 (https://phabricator.wikimedia.org/T243652) [02:30:05] (03PS3) 10DannyS712: Remove CommentStore::newKey, deprecated and unused [core] - 10https://gerrit.wikimedia.org/r/571861 (https://phabricator.wikimedia.org/T241957) [02:30:49] (03PS10) 10Aron Manning: Font update: TEST using Roboto (sans) and Roboto Slab (serif) webfonts with fallback Noto and monospaced Fira Code for consistent look on all platforms. [skins/Vector] - 10https://gerrit.wikimedia.org/r/570639 (https://phabricator.wikimedia.org/T243508) [02:32:05] (03Abandoned) 10Aron Manning: Font update: TEST using Roboto (sans) font. @import the necessary @font-face declarations from the wmflabs fontcdn. [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/570245 (https://phabricator.wikimedia.org/T244425) (owner: 10Aron Manning) [02:33:44] (03Abandoned) 10Aron Manning: Style links added by `mw.util.addPortletLink()` consistent with basic menu items: use css selectors starting at the list root, traversing element tags (consistent with other skins). [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/567439 (https://phabricator.wikimedia.org/T236711) (owner: 10Aron Manning) [02:34:36] 10CPT Initiatives (OAuth 2.0): can't use new OAuth2 consumer archiveleaf-test - https://phabricator.wikimedia.org/T245232 (10kamholz) [02:36:12] 10MediaWiki-General, 10Technical-Debt, 10User-DannyS712: FileDeleteForm uses $wgUser - https://phabricator.wikimedia.org/T245233 (10DannyS712) [02:37:08] 10MediaWiki-extensions-OAuth, 10CPT Initiatives (OAuth 2.0): can't use new OAuth2 consumer archiveleaf-test - https://phabricator.wikimedia.org/T245232 (10Reedy) [02:38:32] 10Anti-Harassment, 10Product-Analytics, 10Epic: [Epic] Analytics for CheckUser - https://phabricator.wikimedia.org/T245226 (10Reedy) [02:39:22] 10MediaWiki-extensions-OAuth, 10CPT Initiatives (OAuth 2.0): can't use new OAuth2 consumer archiveleaf-test - https://phabricator.wikimedia.org/T245232 (10kamholz) [02:42:39] 10Product-Analytics (Kanban): Update wmfdata to use sensible Spark settings - https://phabricator.wikimedia.org/T245097 (10nshahquinn-wmf) [02:43:34] 10Product-Analytics (Kanban): Update wmfdata to use sensible Spark settings - https://phabricator.wikimedia.org/T245097 (10nshahquinn-wmf) [02:43:49] (03CR) 10jerkins-bot: [V: 04-1] Remove CommentStore::newKey, deprecated and unused [core] - 10https://gerrit.wikimedia.org/r/571861 (https://phabricator.wikimedia.org/T241957) (owner: 10DannyS712) [02:51:56] 10MediaWiki-General, 10Technical-Debt, 10User-DannyS712: FileDeleteForm uses $wgUser - https://phabricator.wikimedia.org/T245233 (10DannyS712) [02:53:30] (03PS4) 10DannyS712: FileDeleteForm: Add a user to constructor, hard deprecate not providing [core] - 10https://gerrit.wikimedia.org/r/567324 (https://phabricator.wikimedia.org/T245233) [02:54:01] (03PS5) 10DannyS712: FileDeleteForm: Add a user to constructor, hard deprecate not providing [core] - 10https://gerrit.wikimedia.org/r/567324 (https://phabricator.wikimedia.org/T245233) [02:54:22] (03CR) 10jerkins-bot: [V: 04-1] FileDeleteForm: Add a user to constructor, hard deprecate not providing [core] - 10https://gerrit.wikimedia.org/r/567324 (https://phabricator.wikimedia.org/T245233) (owner: 10DannyS712) [02:55:08] (03CR) 10jerkins-bot: [V: 04-1] FileDeleteForm: Add a user to constructor, hard deprecate not providing [core] - 10https://gerrit.wikimedia.org/r/567324 (https://phabricator.wikimedia.org/T245233) (owner: 10DannyS712) [02:57:07] (03PS6) 10DannyS712: FileDeleteForm: Add a user to constructor, hard deprecate not providing [core] - 10https://gerrit.wikimedia.org/r/567324 (https://phabricator.wikimedia.org/T245233) [02:58:03] 10MediaWiki-General, 10Patch-For-Review, 10Technical-Debt (Deprecation process), 10User-DannyS712: FileDeleteForm uses $wgUser - https://phabricator.wikimedia.org/T245233 (10DannyS712) [02:58:15] 10MediaWiki-General, 10Patch-For-Review, 10Technical-Debt (Deprecation process), 10User-DannyS712: FileDeleteForm uses $wgUser - https://phabricator.wikimedia.org/T245233 (10DannyS712) p:05Triage→03Medium [02:58:50] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Empty state for Search when user's device is offline - https://phabricator.wikimedia.org/T241171 (10Jpita) we should load all the needed resources when we first enter the app, this is what I see if I go the app and immediately cut the internet. |search page|setting... [03:01:53] 10MediaWiki-Page-deletion: Add ar_del_time (timestamp of page deletion) - https://phabricator.wikimedia.org/T245234 (10Superacidic) [03:03:32] 10Inuka-Team: Gallery - image title being cut - https://phabricator.wikimedia.org/T245235 (10Jpita) [03:04:29] (03PS4) 10DannyS712: Remove CommentStore::newKey, deprecated and unused [core] - 10https://gerrit.wikimedia.org/r/571861 (https://phabricator.wikimedia.org/T241957) [03:05:45] (03CR) 10Jforrester: [C: 04-1] "> Patch Set 1:" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/572119 (https://phabricator.wikimedia.org/T245202) (owner: 10EBernhardson) [03:08:09] (03PS1) 10Gergő Tisza: Add missing release note for I59fb647483 [libs/Assert] - 10https://gerrit.wikimedia.org/r/572130 [03:08:11] (03PS1) 10Gergő Tisza: Allow arrays for type lists for parameterElementType [libs/Assert] - 10https://gerrit.wikimedia.org/r/572131 [03:08:13] (03PS1) 10Gergő Tisza: Release v0.5.0 [libs/Assert] - 10https://gerrit.wikimedia.org/r/572132 [03:11:33] (03PS1) 10Gergő Tisza: Remove Scrutinizer CI shield from readme page [libs/Assert] - 10https://gerrit.wikimedia.org/r/572133 [03:12:02] (03CR) 10jerkins-bot: [V: 04-1] FileDeleteForm: Add a user to constructor, hard deprecate not providing [core] - 10https://gerrit.wikimedia.org/r/567324 (https://phabricator.wikimedia.org/T245233) (owner: 10DannyS712) [03:12:38] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Empty state for Search when user's device is offline - https://phabricator.wikimedia.org/T241171 (10Jpita) if I change the language while offline, the option changes on the list but not on the app. not sure this is part of this task or not, if not , let me know and... [03:12:56] (03PS7) 10DannyS712: FileDeleteForm: Add a user to constructor, hard deprecate not providing [core] - 10https://gerrit.wikimedia.org/r/567324 (https://phabricator.wikimedia.org/T245233) [03:15:40] (03PS1) 10Superbass: Add ar_del_time [core] - 10https://gerrit.wikimedia.org/r/572134 (https://phabricator.wikimedia.org/T245234) [03:16:47] (03PS1) 10Prondubuisi: Phpcs : fix Private function documention error [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572136 (https://phabricator.wikimedia.org/T243932) [03:19:46] (03CR) 10Ppchelko: FileDeleteForm: Add a user to constructor, hard deprecate not providing (031 comment) [core] - 10https://gerrit.wikimedia.org/r/567324 (https://phabricator.wikimedia.org/T245233) (owner: 10DannyS712) [03:20:26] (03PS8) 10DannyS712: FileDeleteForm: Add a user to constructor, hard deprecate not providing [core] - 10https://gerrit.wikimedia.org/r/567324 (https://phabricator.wikimedia.org/T245233) [03:22:59] (03CR) 10Ppchelko: [C: 03+1] "LGTM, let's leave it for a little bit to see if others have opinions." [core] - 10https://gerrit.wikimedia.org/r/571861 (https://phabricator.wikimedia.org/T241957) (owner: 10DannyS712) [03:23:45] (03CR) 10Ppchelko: [C: 03+2] Pass a user to LogPage::addEntry [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/570145 (https://phabricator.wikimedia.org/T243652) (owner: 10DannyS712) [03:26:51] (03Merged) 10jenkins-bot: Pass a user to LogPage::addEntry [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/570145 (https://phabricator.wikimedia.org/T243652) (owner: 10DannyS712) [03:28:02] (03CR) 10DannyS712: Pass a user to LogPage::addEntry (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/567174 (https://phabricator.wikimedia.org/T243652) (owner: 10DannyS712) [03:29:45] 10MediaWiki-General, 10MediaWiki-extensions-Approved-Revs, 10MediaWiki-extensions-AutoProxyBlock, 10MediaWiki-extensions-BlockAndNuke, and 12 others: Calls to LogPage::addEntry should pass a user - https://phabricator.wikimedia.org/T243652 (10DannyS712) [03:44:28] (03Abandoned) 10Tim Starling: Fix failure to restore the scroll position on close in Firefox [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/553523 (https://phabricator.wikimedia.org/T229484) (owner: 10Tim Starling) [03:46:03] (03PS1) 10Yaron Koren: Fix for 197438ad7fe8 - remove excess newline [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/572139 [03:47:17] (03PS2) 10Yaron Koren: Fix for 197438ad7fe8 - remove excess newline [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/572139 [03:57:09] (03CR) 10Yaron Koren: [C: 03+2] Fix for 197438ad7fe8 - remove excess newline [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/572139 (owner: 10Yaron Koren) [03:59:48] (03Merged) 10jenkins-bot: Fix for 197438ad7fe8 - remove excess newline [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/572139 (owner: 10Yaron Koren) [04:06:06] (03PS10) 10Aron Manning: Follow consistently the CSS variable naming convention in font variable names. Document the fonts. [skins/Timeless] - 10https://gerrit.wikimedia.org/r/570275 (https://phabricator.wikimedia.org/T245136) [04:06:08] (03PS10) 10Aron Manning: Font update: reset font-size from 95% (15.2px) to default 100% (16px typical), thereby removing some font-rendering artifacts where the width of some strokes is inconsistent. Changes to layout are barely noticeable. [skins/Timeless] - 10https://gerrit.wikimedia.org/r/570276 (https://phabricator.wikimedia.org/T244425) [04:06:10] (03PS10) 10Aron Manning: Font update: TEST using font Lato (sans) for the content, Lora (serif) for headings. Load the necessary fonts from the wmflabs fontcdn. [skins/Timeless] - 10https://gerrit.wikimedia.org/r/570074 (https://phabricator.wikimedia.org/T244425) [04:06:12] (03PS1) 10Aron Manning: No local fonts [skins/Timeless] - 10https://gerrit.wikimedia.org/r/572140 [04:07:45] 10MediaWiki-General, 10Anti-Harassment, 10TechCom: MediaWiki does not support consistent pagination on non-unique fields - https://phabricator.wikimedia.org/T244579 (10Mooeypoo) The product we're discussing (an expansion to CheckUser) deals with potentially large chunks of data from the database, which trigg... [04:08:05] (03Abandoned) 10Aron Manning: No local fonts [skins/Timeless] - 10https://gerrit.wikimedia.org/r/572140 (owner: 10Aron Manning) [04:09:50] 10MediaWiki-Page-deletion, 10I18n: "Mediawiki:Excontentauthor" order problem - https://phabricator.wikimedia.org/T114490 (10Ammarpad) >>! In T114490#5883618, @TerraCodes wrote: > Seems to still be happening? https://www.mediawiki.org/wiki/Certified_Translation Yes [04:10:35] (03CR) 10Aron Manning: "This patch is finished. Submitting for consideration to include it in Timeless. That's a subjective design decision." [skins/Timeless] - 10https://gerrit.wikimedia.org/r/570276 (https://phabricator.wikimedia.org/T244425) (owner: 10Aron Manning) [04:13:13] (03CR) 10Aron Manning: "Submitting for consideration. This patch adds extensive documentation to the font stack and renames the font-stack variables to follow the" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/570275 (https://phabricator.wikimedia.org/T245136) (owner: 10Aron Manning) [04:46:46] (03PS4) 10DannyS712: Add more tests for the user class [core] - 10https://gerrit.wikimedia.org/r/571855 (https://phabricator.wikimedia.org/T233385) [04:50:54] 10MediaWiki-Page-deletion, 10Patch-For-Review: Add ar_del_time (timestamp of page deletion) - https://phabricator.wikimedia.org/T245234 (10Superacidic) Adding Brion since he authored the part about this deficiency. https://www.mediawiki.org/w/index.php?title=Manual%3AArchive_table&type=revision&diff=60583&oldi... [05:00:13] (03CR) 10Reedy: [C: 04-1] Add ar_del_time (033 comments) [core] - 10https://gerrit.wikimedia.org/r/572134 (https://phabricator.wikimedia.org/T245234) (owner: 10Superbass) [05:00:15] (03CR) 10jerkins-bot: [V: 04-1] Add more tests for the user class [core] - 10https://gerrit.wikimedia.org/r/571855 (https://phabricator.wikimedia.org/T233385) (owner: 10DannyS712) [05:08:23] (03PS5) 10DannyS712: Add more tests for the user class [core] - 10https://gerrit.wikimedia.org/r/571855 (https://phabricator.wikimedia.org/T233385) [05:10:43] 10UI-Standardization, 10Desktop Improvements, 10Timeless, 10Wikimedia Design Style Guide: Rethink the font stacks used in skins, make it more consistent, unify common parts, document the decisions and the reasons - https://phabricator.wikimedia.org/T244425 (10Demian) [05:11:34] 10UI-Standardization, 10Desktop Improvements, 10Timeless, 10Wikimedia Design Style Guide: Rethink the font stacks used in skins, make it more consistent, unify common parts, document the decisions and the reasons - https://phabricator.wikimedia.org/T244425 (10Demian) [05:12:56] 10UI-Standardization, 10Desktop Improvements, 10Timeless, 10Wikimedia Design Style Guide: Rethink the font stacks used in skins, make it more consistent, unify common parts, document the decisions and the reasons - https://phabricator.wikimedia.org/T244425 (10Demian) [05:13:36] 10Design, 10ContentTranslation, 10Chinese-Sites, 10Language-Team (Language-2020-January-March), 10WorkType-NewFunctionality: Expose Traditional Chinese variant in addition to Simplified Chinese for services supporting it - https://phabricator.wikimedia.org/T240185 (10VulpesVulpes825) I think the problem... [05:20:37] (03CR) 10Wugapodes: "So I've looked into this more, and I think we can use this code as licensed under the LGPL v3. The GPL has, in every version contained the" [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/561389 (https://phabricator.wikimedia.org/T239438) (owner: 10Wugapodes) [05:21:23] (03CR) 10Ppchelko: [C: 03+1] "LGTM, but given that you're boldly hard-deprecating old constructor signature, let's give it a bit of time for others to chip in" [core] - 10https://gerrit.wikimedia.org/r/567324 (https://phabricator.wikimedia.org/T245233) (owner: 10DannyS712) [05:22:03] (03CR) 10jerkins-bot: [V: 04-1] Add more tests for the user class [core] - 10https://gerrit.wikimedia.org/r/571855 (https://phabricator.wikimedia.org/T233385) (owner: 10DannyS712) [05:22:29] (03PS2) 10Reedy: Update symfony/* from 4.4.2 to 5.0.4 [vendor] - 10https://gerrit.wikimedia.org/r/564145 [05:22:31] (03PS1) 10Reedy: Updating symfony/debug (v4.4.2 => v4.4.4) [vendor] - 10https://gerrit.wikimedia.org/r/572142 [05:23:06] (03CR) 10Ppchelko: [C: 03+2] EditPage: Remove use of Title::getUserPermissionsErrors (part 1) [core] - 10https://gerrit.wikimedia.org/r/572094 (https://phabricator.wikimedia.org/T244929) (owner: 10DannyS712) [05:24:08] (03CR) 10jerkins-bot: [V: 04-1] Update symfony/* from 4.4.2 to 5.0.4 [vendor] - 10https://gerrit.wikimedia.org/r/564145 (owner: 10Reedy) [05:24:26] (03CR) 10jerkins-bot: [V: 04-1] Updating symfony/debug (v4.4.2 => v4.4.4) [vendor] - 10https://gerrit.wikimedia.org/r/572142 (owner: 10Reedy) [05:24:29] (03CR) 10Reedy: "Now blocked by the version in parsoid..." [vendor] - 10https://gerrit.wikimedia.org/r/564141 (owner: 10Reedy) [05:25:24] (03Abandoned) 10Reedy: Update symfony/* from 4.4.2 to 5.0.4 [vendor] - 10https://gerrit.wikimedia.org/r/564145 (owner: 10Reedy) [05:25:29] (03Abandoned) 10Reedy: Updating symfony/debug (v4.4.2 => v4.4.4) [vendor] - 10https://gerrit.wikimedia.org/r/572142 (owner: 10Reedy) [05:26:26] (03CR) 10Ppchelko: [C: 03+2] Remove use of Title::userCan [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/572030 (https://phabricator.wikimedia.org/T244923) (owner: 10DannyS712) [05:29:43] (03PS1) 10Reedy: Updating symfony/* (v4.4.2 => v4.4.4) [vendor] - 10https://gerrit.wikimedia.org/r/572145 [05:33:43] (03PS3) 10Reedy: Updating composer/semver (1.5.0 => 1.5.1) [core] - 10https://gerrit.wikimedia.org/r/564142 [05:34:04] (03CR) 10jerkins-bot: [V: 04-1] Updating composer/semver (1.5.0 => 1.5.1) [core] - 10https://gerrit.wikimedia.org/r/564142 (owner: 10Reedy) [05:37:08] (03Merged) 10jenkins-bot: EditPage: Remove use of Title::getUserPermissionsErrors (part 1) [core] - 10https://gerrit.wikimedia.org/r/572094 (https://phabricator.wikimedia.org/T244929) (owner: 10DannyS712) [05:40:14] (03PS6) 10Reedy: Update ruflin/elastica and elasticsearch/elasticsearch [vendor] - 10https://gerrit.wikimedia.org/r/542307 [05:44:23] (03PS6) 10DannyS712: Add more tests for the user class [core] - 10https://gerrit.wikimedia.org/r/571855 (https://phabricator.wikimedia.org/T233385) [05:47:43] (03PS1) 10DannyS712: Special pages: Remove use of Title::getUserPermissionsErrors (part 2) [core] - 10https://gerrit.wikimedia.org/r/572146 (https://phabricator.wikimedia.org/T244929) [05:48:49] 10Phabricator: Phab stalling on "exporting data" of bulk job - https://phabricator.wikimedia.org/T245236 (10TerraCodes) [05:58:18] (03CR) 10jerkins-bot: [V: 04-1] Add more tests for the user class [core] - 10https://gerrit.wikimedia.org/r/571855 (https://phabricator.wikimedia.org/T233385) (owner: 10DannyS712) [06:00:09] (03PS2) 10DannyS712: Special pages: Remove use of Title::getUserPermissionsErrors (part 2) [core] - 10https://gerrit.wikimedia.org/r/572146 (https://phabricator.wikimedia.org/T244929) [06:03:50] (03PS7) 10DannyS712: Add more tests for the user class [core] - 10https://gerrit.wikimedia.org/r/571855 (https://phabricator.wikimedia.org/T233385) [06:06:41] 10OOUI: Wikitext not parsed in tooltip label - https://phabricator.wikimedia.org/T245237 (10Ammarpad) [06:08:03] (03PS1) 10Samwilson: Purge expired watchlist items [core] - 10https://gerrit.wikimedia.org/r/572147 (https://phabricator.wikimedia.org/T244804) [06:12:01] (03CR) 10DannyS712: [C: 04-1] "> So I've looked into this more, and I think we can use this code as" [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/561389 (https://phabricator.wikimedia.org/T239438) (owner: 10Wugapodes) [06:13:47] (03PS3) 10DannyS712: Special pages: Remove use of Title::getUserPermissionsErrors (part 2) [core] - 10https://gerrit.wikimedia.org/r/572146 (https://phabricator.wikimedia.org/T244929) [06:15:24] (03CR) 10Reedy: Purge expired watchlist items (033 comments) [core] - 10https://gerrit.wikimedia.org/r/572147 (https://phabricator.wikimedia.org/T244804) (owner: 10Samwilson) [06:15:44] (03PS8) 10DannyS712: Add more tests for the user class [core] - 10https://gerrit.wikimedia.org/r/571855 (https://phabricator.wikimedia.org/T233385) [06:20:27] (03CR) 10jerkins-bot: [V: 04-1] Purge expired watchlist items [core] - 10https://gerrit.wikimedia.org/r/572147 (https://phabricator.wikimedia.org/T244804) (owner: 10Samwilson) [06:20:52] (03CR) 10Samwilson: "You're quick!" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/572147 (https://phabricator.wikimedia.org/T244804) (owner: 10Samwilson) [06:27:53] (03CR) 10DannyS712: Purge expired watchlist items (034 comments) [core] - 10https://gerrit.wikimedia.org/r/572147 (https://phabricator.wikimedia.org/T244804) (owner: 10Samwilson) [06:31:14] 10conftool: dbctl: treat read only ES hosts as standalone hosts - https://phabricator.wikimedia.org/T245239 (10Marostegui) [06:31:39] (03CR) 10DannyS712: [C: 04-1] Add ar_del_time (033 comments) [core] - 10https://gerrit.wikimedia.org/r/572134 (https://phabricator.wikimedia.org/T245234) (owner: 10Superbass) [06:33:31] (03CR) 10Samwilson: "This change is ready for review." (037 comments) [core] - 10https://gerrit.wikimedia.org/r/572147 (https://phabricator.wikimedia.org/T244804) (owner: 10Samwilson) [06:34:14] (03PS2) 10Samwilson: Purge expired watchlist items [core] - 10https://gerrit.wikimedia.org/r/572147 (https://phabricator.wikimedia.org/T244804) [06:43:04] (03PS9) 10DannyS712: Add more tests for the user class [core] - 10https://gerrit.wikimedia.org/r/571855 (https://phabricator.wikimedia.org/T233385) [06:45:39] (03CR) 10jerkins-bot: [V: 04-1] Purge expired watchlist items [core] - 10https://gerrit.wikimedia.org/r/572147 (https://phabricator.wikimedia.org/T244804) (owner: 10Samwilson) [06:54:36] 10Phabricator, 10Security-Team, 10Security, 10Security Related: Update protect as security issue to use acl*security - https://phabricator.wikimedia.org/T245201 (10Bugreporter) As the policy of space is absolute, other users can not be invited to the task. [07:01:57] 10MediaWiki-extensions-OAuth, 10CPT Initiatives (OAuth 2.0): can't use new OAuth2 consumer archiveleaf-test - https://phabricator.wikimedia.org/T245232 (10kamholz) I just tried making a new OAuth 2.0 consumer called archiveleaf which is not owner-only. It's not approved yet (in fact I requested it not be appro... [07:15:35] (03PS10) 10DannyS712: Add more tests for the user class [core] - 10https://gerrit.wikimedia.org/r/571855 (https://phabricator.wikimedia.org/T233385) [07:23:59] (03PS4) 10DannyS712: Remove MessageLog::getMessagesFormatted, unused [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/566794 (https://phabricator.wikimedia.org/T243526) [07:25:32] (03CR) 10jerkins-bot: [V: 04-1] Remove MessageLog::getMessagesFormatted, unused [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/566794 (https://phabricator.wikimedia.org/T243526) (owner: 10DannyS712) [07:28:27] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/572168 (owner: 10L10n-bot) [07:29:56] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/572168 (owner: 10L10n-bot) [07:31:00] (03PS10) 10DannyS712: Remove use of global $wgUser (part 1) [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/567375 (https://phabricator.wikimedia.org/T243733) [07:33:36] (03CR) 10jerkins-bot: [V: 04-1] Remove use of global $wgUser (part 1) [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/567375 (https://phabricator.wikimedia.org/T243733) (owner: 10DannyS712) [07:33:51] (03PS11) 10DannyS712: Remove use of global $wgUser (part 1) [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/567375 (https://phabricator.wikimedia.org/T243733) [07:35:40] (03PS11) 10DannyS712: Add more tests for the user class [core] - 10https://gerrit.wikimedia.org/r/571855 (https://phabricator.wikimedia.org/T233385) [07:35:45] (03PS12) 10DannyS712: Add more tests for the user class [core] - 10https://gerrit.wikimedia.org/r/571855 (https://phabricator.wikimedia.org/T233385) [07:36:15] (03CR) 10Santhosh: [C: 04-1] Document origin and reason for core code duplication (032 comments) [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/572096 (https://phabricator.wikimedia.org/T243286) (owner: 10Krinkle) [07:39:28] 10Inuka-Team: change language on article view while offline breaks the app - https://phabricator.wikimedia.org/T245240 (10Jpita) [07:54:13] (03PS1) 10Pwirth: Remove currently non functional old category check functionality [extensions/BlueSpiceCategoryCheck] - 10https://gerrit.wikimedia.org/r/572192 [08:00:44] (03PS1) 10Pwirth: Remove unused resources [extensions/BlueSpiceCategoryManager] - 10https://gerrit.wikimedia.org/r/572193 [08:04:05] (03CR) 10Robert Vogel: [C: 03+2] Add help message for config BlueSpiceAboutShowMenuLinks [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/571932 (owner: 10Pwirth) [08:04:11] (03PS1) 10Robert Vogel: Add help message for config BlueSpiceAboutShowMenuLinks [extensions/BlueSpiceAbout] (REL1_31) - 10https://gerrit.wikimedia.org/r/572194 [08:04:14] (03CR) 10Robert Vogel: [C: 03+2] Add help message for config BlueSpiceAboutShowMenuLinks [extensions/BlueSpiceAbout] (REL1_31) - 10https://gerrit.wikimedia.org/r/572194 (owner: 10Robert Vogel) [08:04:19] (03PS1) 10Robert Vogel: Add help message for config BlueSpiceAboutShowMenuLinks [extensions/BlueSpiceAbout] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/572195 [08:04:22] (03CR) 10Robert Vogel: [V: 03+2 C: 03+2] Add help message for config BlueSpiceAboutShowMenuLinks [extensions/BlueSpiceAbout] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/572195 (owner: 10Robert Vogel) [08:06:53] (03Merged) 10jenkins-bot: Add help message for config BlueSpiceAboutShowMenuLinks [extensions/BlueSpiceAbout] (REL1_31) - 10https://gerrit.wikimedia.org/r/572194 (owner: 10Robert Vogel) [08:07:53] (03Merged) 10jenkins-bot: Add help message for config BlueSpiceAboutShowMenuLinks [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/571932 (owner: 10Pwirth) [08:10:04] (03CR) 10Raimond Spekking: [C: 03+1] "i18n review" [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/571963 (owner: 10Pwirth) [08:14:46] 10Inuka-Team, 10KaiOS-Wikipedia-app: "Suggested articles" should be in content language (not in interface language) - https://phabricator.wikimedia.org/T244524 (10AMuigai) p:05High→03Medium [08:28:05] (03CR) 10Matěj Suchánek: "> Patch Set 2:" [core] - 10https://gerrit.wikimedia.org/r/571681 (owner: 10Sahajsk) [08:28:23] 10LibUp: LibUp web listing out of date - https://phabricator.wikimedia.org/T245171 (10Legoktm) The problem is that for whatever reason, the default branch for CentralNotice is set to `wmf_deploy` instead of `master`. I don't know who changed that, but that seems problematic and should be reconsidered. ` user@de... [08:33:33] 10MediaWiki-extensions-TinyMCE: TinyMce REL1_32, MediaWiki, undefined method TitleValue::getArticleID() when opening page Special:Categories - https://phabricator.wikimedia.org/T213644 (10aoxomoxoa) 05Open→03Resolved a:03aoxomoxoa Hi, thank you for retesting and letting me know. [08:36:10] (03CR) 10Jack Phoenix: [C: 04-1] Add phpcs and make it pass (034 comments) [extensions/Video] - 10https://gerrit.wikimedia.org/r/571824 (owner: 10Zoranzoki21) [08:37:48] (03Abandoned) 10Zoranzoki21: Add phpcs and make it pass [extensions/Video] - 10https://gerrit.wikimedia.org/r/571824 (owner: 10Zoranzoki21) [10:28:41] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10TestMe: Unify view-implementations in JS frontend - https://phabricator.wikimedia.org/T74666 (10Lydia_Pintscher) 05Open→03Resolved a:03Lydia_Pintscher Yeah let's close this. [10:35:56] 10Design, 10TCB-Team, 10Two-Column-Edit-Conflict-Merge, 10WMDE-Design: Possibility to use both versions of a paragraph in two-col-conflict - https://phabricator.wikimedia.org/T213270 (10awight) [10:37:09] 10Design, 10TCB-Team, 10Two-Column-Edit-Conflict-Merge, 10WMDE-Design: Possibility to use both versions of a paragraph in two-col-conflict - https://phabricator.wikimedia.org/T213270 (10awight) This is an excellent idea, thanks for collecting the requests. I've merged with the feature task, feel free to r... [10:44:01] 10Phabricator: Phab stalling on "exporting data" of bulk job - https://phabricator.wikimedia.org/T245236 (10Aklapper) 05Open→03Declined p:05Triage→03Lowest > and I have more than just like 200 or etc) No, you have 6536. Given such vague search criteria I can imagine some code in the software stack to si... [10:46:57] 10MediaWiki-General, 10Desktop Improvements, 10MinervaNeue (3rd party support), 10Patch-For-Review, and 2 others: It should be possible to customise the implementation of mw.util.addPortletLink function on a skin basis - https://phabricator.wikimedia.org/T236711 (10ovasileva) @Jdlrobson - I'm having a bit... [10:47:09] 10CheckUser: Installation of CheckUser barfs when run on a brand new mediawiki installation - https://phabricator.wikimedia.org/T244283 (10Aklapper) @MMigurski: Hi, if you would like to propose your code changes for inclusion, then you are very welcome to use [[ https://www.mediawiki.org/wiki/Developer_access |... [10:50:15] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup: "Cookies disabled" error on login page when cookies are enabled - https://phabricator.wikimedia.org/T30201 (10Aklapper) >>! In T30201#5883829, @TerraCodes wrote: > I can't reproduce this That's likely with bugs. If everyone could... [10:50:43] (03PS3) 10Pwirth: Removed unused resources and and current resources conditionally [extensions/BlueSpiceChecklist] - 10https://gerrit.wikimedia.org/r/572202 [10:51:09] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup: "Cookies disabled" error on login page when cookies are enabled - https://phabricator.wikimedia.org/T30201 (10Aklapper) 05Open→03Declined This issue was nine / five years ago, and given the changes in MediaWiki's authenticatio... [10:53:39] 10Inuka-Team: Gallery - image title being cut - https://phabricator.wikimedia.org/T245235 (10Jpita) >>! In T245235#5884213, @hueitan wrote: > This happens only in Chrome, doesn't get overflow in Firefox, > > to have consistency between browsers, we can add `overflow: hidden` to image container. I'll try in the... [10:58:27] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10TestMe: Aliases that are too long fail with wrong Error - https://phabricator.wikimedia.org/T222591 (10Lydia_Pintscher) 05Open→03Resolved a:03Lydia_Pintscher Yay :) Thanks for testing. [10:59:16] 10MediaWiki-Internationalization, 10I18n, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), 10Patch-For-Review, 10User-Zoranzoki21: Add magicWord "#REDIRECT" with translation to MessagesCkb - https://phabricator.wikimedia.org/T243680 (10Aklapper) Code has been merged at https://phabricator.wikimedia.org/sourc... [11:02:56] (03PS1) 10Pwirth: Remove empty resources [extensions/BlueSpiceCustomMenu] - 10https://gerrit.wikimedia.org/r/572206 [11:07:17] 10MediaWiki-Internationalization, 10I18n, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), 10Patch-For-Review, 10User-Zoranzoki21: Add magicWord "#REDIRECT" with translation to MessagesCkb - https://phabricator.wikimedia.org/T243680 (10AramBakir) @Aklapper I checked out now. It also worked for us. Thank you... [11:14:26] 10MediaWiki-Internationalization, 10I18n, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), 10Patch-For-Review, 10User-Zoranzoki21: Add magicWord "#REDIRECT" with translation to MessagesCkb - https://phabricator.wikimedia.org/T243680 (10AramBakir) 05Open→03Resolved [11:22:30] 10Phabricator, 10Release-Engineering-Team, 10User-Addshore: "Production Error" tasks do not have a Story Points field - https://phabricator.wikimedia.org/T240343 (10Aklapper) I made https://phabricator.wikimedia.org/transactions/editengine/maniphest.task/view/68/ show the "Estimate Story Points" field on 202... [11:22:45] 10AbuseFilter: Add subroutines to AbuseFilter - https://phabricator.wikimedia.org/T186960 (10matej_suchanek) Random ideas: # we **must** avoid circular dependencies # we should cache whether a filter was triggered # we can enable filters that don't log hits and only execute on demand from other filters [11:22:54] (03PS1) 10Pwirth: Add resources conditionally [extensions/BlueSpiceDashboards] - 10https://gerrit.wikimedia.org/r/572208 [11:31:23] 10MediaWiki-Watchlist, 10Core Platform Team, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), and 3 others: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10JM) Yes, it still happens from time to time, although much less... [11:32:57] (03PS1) 10Awight: Show "saved" notification after conflict resolution [core] - 10https://gerrit.wikimedia.org/r/572210 (https://phabricator.wikimedia.org/T245244) [11:33:48] 10Design, 10Growth-Team, 10Notifications: Echo: Inconsistent link/bold formatting in flyout - https://phabricator.wikimedia.org/T68385 (10matej_suchanek) [11:46:10] 10MediaWiki-Watchlist, 10Commons, 10Growth-Team: "TypeError: this.emptyFilterMessage is undefined" on Commons Watchlist - https://phabricator.wikimedia.org/T245139 (10Aklapper) [11:47:10] (03PS24) 10Kosta Harlan: Add a docker-compose development environment [core] - 10https://gerrit.wikimedia.org/r/550708 (https://phabricator.wikimedia.org/T238224) [11:47:37] 10WMF-Communications, 10wikimediafoundation.org: [Bug] Design assets overlapping on Work with Us page - https://phabricator.wikimedia.org/T244919 (10Aklapper) 05Open→03Declined [11:51:23] 10Desktop Improvements, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): Add a Vector skin version preference - https://phabricator.wikimedia.org/T242381 (10phuedx) >>! In T242381#5883635, @Niedzielski wrote: > - Questions to bounce with @phuedx: > - Do you think I should add support for a... [11:52:50] (03CR) 10Awight: "> PHP test coverage increased (or stayed the same) :-)" [core] - 10https://gerrit.wikimedia.org/r/572210 (https://phabricator.wikimedia.org/T245244) (owner: 10Awight) [11:57:28] 10MediaWiki-Special-pages, 10UI-Standardization, 10Readers-Web-Backlog (Design), 10UI-Standardization-Kanban: Special:Contributions – add 'pinning' functionality to collapsible form? - https://phabricator.wikimedia.org/T234569 (10ovasileva) Seems like this belongs more in the design backlog - moving there... [12:01:00] (03PS25) 10Kosta Harlan: Add a docker-compose development environment [core] - 10https://gerrit.wikimedia.org/r/550708 (https://phabricator.wikimedia.org/T238224) [12:01:57] (03PS1) 10Pwirth: Add resources conditionally [extensions/BlueSpiceDistributionConnector] - 10https://gerrit.wikimedia.org/r/572216 [12:10:52] 10Library-Card-Platform, 10good first task: Error on 'Mark as Sent' page for automatic-send partners - https://phabricator.wikimedia.org/T234551 (10lalit97) Hello @Samwalton9 just raised a pull request for this at https://github.com/WikipediaLibrary/TWLight/pull/405 [12:12:37] 10Library-Card-Platform-Proxy: Implement Library Bundle functionality - https://phabricator.wikimedia.org/T235262 (10Samwalton9) a:03jsn.sherman [12:12:52] 10Library-Card-Platform-Proxy: Track users' recent edits (and block status) for Library Bundle requirements - https://phabricator.wikimedia.org/T236781 (10Samwalton9) a:03jsn.sherman [12:13:03] 10Library-Card-Platform: Drop all sessions when deploying Library Bundle - https://phabricator.wikimedia.org/T244895 (10Samwalton9) a:03jsn.sherman [12:13:18] 10Library-Card-Platform: Differentiate proxy and bundle authorizations - https://phabricator.wikimedia.org/T244896 (10Samwalton9) a:03jsn.sherman [12:13:29] 10Library-Card-Platform: Create a management command to email proxy/bundle users for the rollout - https://phabricator.wikimedia.org/T236287 (10Samwalton9) a:03jsn.sherman [12:13:42] 10Library-Card-Platform: When updating Bundle eligibility via cron, email users who are no longer eligible - https://phabricator.wikimedia.org/T245177 (10Samwalton9) a:03jsn.sherman [12:21:14] 10CX-boost, 10Language-Team (Language-2020-January-March): Enable Content Translation in Bosnian Wikipedia as a default tool - https://phabricator.wikimedia.org/T244139 (10Pginer-WMF) 05Open→03Resolved [12:21:25] 10CX-boost, 10Language-Team (Language-2020-January-March): Enable Content Translation in Macedonian Wikipedia as a default tool - https://phabricator.wikimedia.org/T244140 (10Pginer-WMF) 05Open→03Resolved [12:29:24] (03PS1) 10Superbass: Fix problems pointed out by Reedy and DannyS712; also revise code so that the ar_del_time will now be the same as log_timestamp [core] - 10https://gerrit.wikimedia.org/r/572219 [12:30:37] (03CR) 10Superbass: "Responded" (036 comments) [core] - 10https://gerrit.wikimedia.org/r/572134 (https://phabricator.wikimedia.org/T245234) (owner: 10Superbass) [12:30:45] 10Wikimedia-Phabricator-Extensions: Related Gerrit Patches: Do not display CR-2 patches as "awaiting review" - https://phabricator.wikimedia.org/T245247 (10MarcoAurelio) [12:31:58] (03PS2) 10Superbass: Fix problems pointed out by Reedy and DannyS712; also revise code so that the ar_del_time will now be the same as log_timestamp [core] - 10https://gerrit.wikimedia.org/r/572219 [12:33:32] (03Abandoned) 10Superbass: Fix problems pointed out by Reedy and DannyS712; also revise code so that the ar_del_time will now be the same as log_timestamp [core] - 10https://gerrit.wikimedia.org/r/572219 (owner: 10Superbass) [12:36:36] (03PS2) 10Superbass: Add ar_del_time [core] - 10https://gerrit.wikimedia.org/r/572134 (https://phabricator.wikimedia.org/T245234) [12:36:37] 10MediaWiki-extensions-OATHAuth: Enable downloading scratch codes for OAuth - https://phabricator.wikimedia.org/T245027 (10TheDJ) [12:39:32] 10WMSE-Bug-Reporting-and-Translation-2020: Gadget Special:ContentTranslation with broken JS - https://phabricator.wikimedia.org/T245217 (10Creditor_Editor) 05Stalled→03Open [12:40:31] 10WMSE-Bug-Reporting-and-Translation-2020: Gadget Special:ContentTranslation with broken JS - https://phabricator.wikimedia.org/T245217 (10Creditor_Editor) [12:41:37] (03PS3) 10Superbass: Add ar_del_time [core] - 10https://gerrit.wikimedia.org/r/572134 (https://phabricator.wikimedia.org/T245234) [12:44:21] (03PS1) 10WMDE-Fisch: Rtrim input text [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572220 (https://phabricator.wikimedia.org/T245154) [12:45:02] (03PS4) 10Superbass: Add ar_del_time [core] - 10https://gerrit.wikimedia.org/r/572134 (https://phabricator.wikimedia.org/T245234) [12:45:30] (03PS2) 10WMDE-Fisch: Rtrim input text [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572220 (https://phabricator.wikimedia.org/T245154) [12:47:34] (03CR) 10Mholloway: "recheck" [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/571839 (https://phabricator.wikimedia.org/T243612) (owner: 10Mholloway) [12:48:53] (03PS4) 10Dmaza: Add compare tab to Special:Investigate [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/571626 (https://phabricator.wikimedia.org/T238782) [12:51:28] (03PS1) 10Peter.ovchyn: deprecation: Improve file attribution for “Called deprecation function” logs [core] - 10https://gerrit.wikimedia.org/r/572223 (https://phabricator.wikimedia.org/T245075) [12:52:48] 10Library-Card-Platform: Launch Proxy and Library Bundle access methods - https://phabricator.wikimedia.org/T240120 (10Samwalton9) [12:54:01] (03PS26) 10Kosta Harlan: Add a docker-compose development environment [core] - 10https://gerrit.wikimedia.org/r/550708 (https://phabricator.wikimedia.org/T238224) [12:58:26] 10Library-Card-Platform: When updating Bundle eligibility via cron, email users who are no longer eligible - https://phabricator.wikimedia.org/T245177 (10Samwalton9) p:05Triage→03Medium [12:58:47] 10Library-Card-Platform: Prep new partners for launch - https://phabricator.wikimedia.org/T240121 (10Samwalton9) a:03Nikkimaria [13:04:59] (03CR) 10WMDE-Fisch: [C: 03+1] Show "saved" notification after conflict resolution [core] - 10https://gerrit.wikimedia.org/r/572210 (https://phabricator.wikimedia.org/T245244) (owner: 10Awight) [13:06:03] 10Library-Card-Platform: Improve project documentation - https://phabricator.wikimedia.org/T240156 (10Samwalton9) p:05Low→03Medium [13:07:39] (03PS1) 10Dmaza: Improve documentation of abstract methods [core] - 10https://gerrit.wikimedia.org/r/572224 [13:08:35] (03CR) 10Dmaza: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/572224 (owner: 10Dmaza) [13:10:30] 10Library-Card-Platform: Improve project documentation - https://phabricator.wikimedia.org/T207404 (10Samwalton9) [13:10:58] 10Library-Card-Platform: Improve Library Card documentation - https://phabricator.wikimedia.org/T240156 (10Samwalton9) [13:11:14] 10Library-Card-Platform: Improve developer documentation - https://phabricator.wikimedia.org/T207404 (10Samwalton9) [13:12:09] 10Library-Card-Platform: Server 500 on trying to modify application status from INVALID to anything else - https://phabricator.wikimedia.org/T239503 (10Samwalton9) [13:12:11] 10Library-Card-Platform: Tech improvements - https://phabricator.wikimedia.org/T240153 (10Samwalton9) [13:12:13] 10NewcomerTasks 1.1, 10Growth-Team (Current Sprint): Newcomer tasks: text in overlay should stay in its column - https://phabricator.wikimedia.org/T243365 (10RHo) @MMiller_WMF this falls into the missed design review of the topic intro overlay, so I have added it to T244421 since it seems like it should be fix... [13:12:25] 10Library-Card-Platform: If a user is interrupted from their workflow for whatever reason, return them back to their previous workflow afterwards - https://phabricator.wikimedia.org/T238779 (10Samwalton9) [13:12:27] 10Library-Card-Platform: Tech improvements - https://phabricator.wikimedia.org/T240153 (10Samwalton9) [13:12:30] 10Library-Card-Platform: If a user is interrupted from their workflow for whatever reason, return them back to their previous workflow afterwards - https://phabricator.wikimedia.org/T238779 (10Samwalton9) a:05jsn.sherman→03None [13:12:45] 10Library-Card-Platform: Address project technical debt - https://phabricator.wikimedia.org/T240153 (10Samwalton9) [13:13:45] 10Library-Card-Platform: Address project technical debt - https://phabricator.wikimedia.org/T240153 (10Samwalton9) [13:14:09] 10Library-Card-Platform: Django upgrade - https://phabricator.wikimedia.org/T240130 (10Samwalton9) [13:14:11] 10Library-Card-Platform: Address project technical debt - https://phabricator.wikimedia.org/T240153 (10Samwalton9) [13:14:22] 10Library-Card-Platform: Django upgrade - https://phabricator.wikimedia.org/T240130 (10Samwalton9) [13:14:24] 10Library-Card-Platform: Upgrade to Django 2 - https://phabricator.wikimedia.org/T238754 (10Samwalton9) [13:14:26] 10Library-Card-Platform: Address project technical debt - https://phabricator.wikimedia.org/T240153 (10Samwalton9) [13:14:33] 10Library-Card-Platform: Upgrade to Django 2 - https://phabricator.wikimedia.org/T238754 (10Samwalton9) p:05Medium→03High [13:16:03] 10Library-Card-Platform: Switch from an Alpine Docker image to something more suitable - https://phabricator.wikimedia.org/T245253 (10Samwalton9) [13:16:08] 10Library-Card-Platform: Switch from an Alpine Docker image to something more suitable - https://phabricator.wikimedia.org/T245253 (10Samwalton9) p:05Triage→03Medium [13:16:20] 10Library-Card-Platform: Address project technical debt - https://phabricator.wikimedia.org/T240153 (10Samwalton9) p:05Low→03Medium [13:16:32] (03CR) 10Dmaza: Add compare tab to Special:Investigate (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/571626 (https://phabricator.wikimedia.org/T238782) (owner: 10Dmaza) [13:17:01] 10WMSE-Wikipedia-in-Education-2020: OER Network - https://phabricator.wikimedia.org/T244724 (10JosefineHellrothLarssonWMSE) https://se.wikimedia.org/wiki/M%C3%B6tesplats_OER [13:17:18] 10Library-Card-Platform: Improve coordinator workflows - https://phabricator.wikimedia.org/T240146 (10Samwalton9) p:05Medium→03Low [13:17:25] 10Library-Card-Platform, 10Epic: Overhaul and improve Library Card information security processes - https://phabricator.wikimedia.org/T191777 (10Samwalton9) p:05Medium→03Low [13:18:58] 10NewcomerTasks 1.2, 10Growth-Team (Current Sprint): Newcomer task: Suggested article image should be repeated when image width is less than card width - https://phabricator.wikimedia.org/T244210 (10RHo) [13:19:22] 10Library-Card-Platform: Pull Request builds in Travis should check for merge against target branch instead of always using master - https://phabricator.wikimedia.org/T245255 (10Samwalton9) [13:19:29] 10Library-Card-Platform: Pull Request builds in Travis should check for merge against target branch instead of always using master - https://phabricator.wikimedia.org/T245255 (10Samwalton9) p:05Triage→03Medium [13:19:38] (03CR) 10Tchanders: [C: 03+2] Improve documentation of abstract methods [core] - 10https://gerrit.wikimedia.org/r/572224 (owner: 10Dmaza) [13:21:06] 10Library-Card-Platform: Switch from Travis CI to Github Actions - https://phabricator.wikimedia.org/T245256 (10Samwalton9) [13:21:11] 10Library-Card-Platform: Switch from Travis CI to Github Actions - https://phabricator.wikimedia.org/T245256 (10Samwalton9) p:05Triage→03Low [13:21:21] 10Library-Card-Platform: Pull Request builds in Travis should check for merge against target branch instead of always using master - https://phabricator.wikimedia.org/T245255 (10Samwalton9) [13:22:41] 10Library-Card-Platform: Improve usability of our staging environment - https://phabricator.wikimedia.org/T245257 (10Samwalton9) [13:22:47] 10Library-Card-Platform: Improve usability of our staging environment - https://phabricator.wikimedia.org/T245257 (10Samwalton9) p:05Triage→03Low [13:25:03] 10Library-Card-Platform: Improve test coverage - https://phabricator.wikimedia.org/T240155 (10Samwalton9) [13:25:04] 10Library-Card-Platform: Address project technical debt - https://phabricator.wikimedia.org/T240153 (10Samwalton9) [13:25:04] 10Library-Card-Platform: Improve test coverage and design - https://phabricator.wikimedia.org/T240155 (10Samwalton9) [13:25:35] 10NewcomerTasks 1.2, 10Growth-Team (Current Sprint): [Bug] Newcomer task: Suggested article image should be repeated when image width is less than card width - https://phabricator.wikimedia.org/T244210 (10RHo) [13:26:09] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q3), 10SEO: Investigate and fix tags in page source - https://phabricator.wikimedia.org/T244614 (10phuedx) [13:26:18] 10Library-Card-Platform: Improve test file layout and structure - https://phabricator.wikimedia.org/T245258 (10Samwalton9) [13:31:53] (03PS1) 10Dmaza: Remove browser autocomplete from the form [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572227 [13:32:36] 10Library-Card-Platform: Split test files out into sub-files for each app - https://phabricator.wikimedia.org/T245261 (10Samwalton9) [13:33:33] 10Library-Card-Platform: Rethink test classes - https://phabricator.wikimedia.org/T245262 (10Samwalton9) [13:33:36] 10Library-Card-Platform: Rethink test classes - https://phabricator.wikimedia.org/T245262 (10Samwalton9) p:05Triage→03Low [13:33:43] 10Library-Card-Platform: Improve test file layout and structure - https://phabricator.wikimedia.org/T245258 (10Samwalton9) p:05Triage→03Low [13:33:52] 10Library-Card-Platform: Split test files out into sub-files for each app - https://phabricator.wikimedia.org/T245261 (10Samwalton9) p:05Triage→03Medium [13:35:15] (03CR) 10Dmaza: "This change is ready for review." [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572227 (owner: 10Dmaza) [13:36:51] (03Merged) 10jenkins-bot: Improve documentation of abstract methods [core] - 10https://gerrit.wikimedia.org/r/572224 (owner: 10Dmaza) [13:38:25] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup: "Cookies disabled" error on login page when cookies are enabled - https://phabricator.wikimedia.org/T30201 (10TerraCodes) >>! In T30201#5884319, @Aklapper wrote: > That's likely with bugs. My repro, or the original report? [13:46:49] 10Library-Card-Platform: Use VCR or similar request mocking to improve test coverage for requests - https://phabricator.wikimedia.org/T245263 (10Samwalton9) [13:46:58] 10Library-Card-Platform: Use VCR or similar request mocking to improve test coverage for requests - https://phabricator.wikimedia.org/T245263 (10Samwalton9) p:05Triage→03Low [13:49:45] 10MediaWiki-extensions-WikibaseView, 10WikibaseMediaInfo, 10Wikidata: Wikibase javascript attempts to automatically render MediaInfo content - https://phabricator.wikimedia.org/T245264 (10Cparle) [13:50:24] 10MediaWiki-extensions-WikibaseView, 10WikibaseMediaInfo, 10Wikidata: Wikibase javascript attempts to automatically render MediaInfo content - https://phabricator.wikimedia.org/T245264 (10Cparle) [13:51:03] 10Library-Card-Platform, 10Epic: Code refactor - https://phabricator.wikimedia.org/T245265 (10Samwalton9) [13:51:13] 10Library-Card-Platform, 10Epic: Code refactor - https://phabricator.wikimedia.org/T245265 (10Samwalton9) p:05Triage→03Low [13:51:14] (03CR) 10Tchanders: [C: 03+2] Remove browser autocomplete from the form [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572227 (owner: 10Dmaza) [13:52:44] 10Library-Card-Platform: Add a shell script linter - https://phabricator.wikimedia.org/T245266 (10Samwalton9) [13:53:04] 10Library-Card-Platform: Add a shell script linter - https://phabricator.wikimedia.org/T245266 (10Samwalton9) p:05Triage→03Lowest [13:53:08] 10MediaWiki-General, 10TechCom: MediaWiki does not support consistent pagination on non-unique fields - https://phabricator.wikimedia.org/T244579 (10Tchanders) [13:54:04] 10Library-Card-Platform: Improve error handling - https://phabricator.wikimedia.org/T245267 (10Samwalton9) [13:54:09] 10Library-Card-Platform: Improve error handling - https://phabricator.wikimedia.org/T245267 (10Samwalton9) p:05Triage→03Low [13:55:14] 10Discovery-Search (Current work): Restart Elasticsearch clusters for JVM upgrade - https://phabricator.wikimedia.org/T245120 (10Gehel) [13:55:41] 10Library-Card-Platform: Block /admin login page in production & staging - https://phabricator.wikimedia.org/T245268 (10Samwalton9) [13:55:47] 10Library-Card-Platform: Block /admin login page in production & staging - https://phabricator.wikimedia.org/T245268 (10Samwalton9) p:05Triage→03Low [13:57:11] 10Library-Card-Platform: Switch from Pandoc to Parsoid - https://phabricator.wikimedia.org/T245269 (10Samwalton9) [13:57:22] 10Library-Card-Platform: Switch from Pandoc to Parsoid - https://phabricator.wikimedia.org/T245269 (10Samwalton9) p:05Triage→03Low [13:57:22] (03CR) 10Awight: "Looks consistent! Could include tests to prevent regression." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572220 (https://phabricator.wikimedia.org/T245154) (owner: 10WMDE-Fisch) [13:57:25] (03CR) 10Awight: [C: 03+2] Rtrim input text [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572220 (https://phabricator.wikimedia.org/T245154) (owner: 10WMDE-Fisch) [13:58:05] 10Library-Card-Platform: Stop using external Javascript hosting - https://phabricator.wikimedia.org/T245270 (10Samwalton9) [13:58:09] 10Library-Card-Platform: Stop using external Javascript hosting - https://phabricator.wikimedia.org/T245270 (10Samwalton9) p:05Triage→03Low [13:58:58] 10MediaWiki-General, 10Core Platform Team, 10TCB-Team, 10Patch-For-Review: Conflict resolution process ends with incorrect "This page has been restored" - https://phabricator.wikimedia.org/T245244 (10awight) [14:00:16] 10Anti-Harassment: Prevent browser autocomplete in the UsersMultiselectWidget in Special:Investigate - https://phabricator.wikimedia.org/T245271 (10Tchanders) [14:00:30] 10Anti-Harassment, 10CheckUser: Prevent browser autocomplete in the UsersMultiselectWidget in Special:Investigate - https://phabricator.wikimedia.org/T245271 (10Tchanders) [14:01:37] (03CR) 10Dmaza: Update preliminary check classes to use multi-column pagination (033 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572040 (https://phabricator.wikimedia.org/T244517) (owner: 10Tchanders) [14:02:06] 10UI-Standardization, 10Desktop Improvements, 10Timeless, 10Wikimedia Design Style Guide: Rethink the fonts and typography in skins, document the decisions - https://phabricator.wikimedia.org/T244425 (10Demian) [14:06:36] (03Merged) 10jenkins-bot: Remove browser autocomplete from the form [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572227 (owner: 10Dmaza) [14:06:38] (03Merged) 10jenkins-bot: Rtrim input text [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572220 (https://phabricator.wikimedia.org/T245154) (owner: 10WMDE-Fisch) [14:07:04] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Growth-Team (Current Sprint), 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07): Newcomer tasks: show skeleton screen while loading - https://phabricator.wikimedia.org/T238231 (10RHo) Relevant stills of the current loading behaviour: {F31616232} Video from... [14:10:19] (03CR) 10Tchanders: Update preliminary check classes to use multi-column pagination (033 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572040 (https://phabricator.wikimedia.org/T244517) (owner: 10Tchanders) [14:12:11] 10Internet-Archive, 10Language-Team: moving palmleaf.org platform to Balinese Wikisource/Wikipedia - https://phabricator.wikimedia.org/T244796 (10Nemo_bis) > I'd appreciate any suggestions for who to contact and what to do next. I provided some over IRC at #wikimedia-tech. Let me know if you need more (ideal... [14:13:10] 10Internet-Archive, 10Language-Team: moving palmleaf.org platform to Balinese Wikisource/Wikipedia - https://phabricator.wikimedia.org/T244796 (10Nemo_bis) [14:18:22] 10CheckUser, 10Anti-Harassment (The Letter Song): CU 2.0: Display data in the Compare tab - https://phabricator.wikimedia.org/T238782 (10Tchanders) I have a few questions about the acceptance criteria: > * There is a new tab next to Preliminary check for Compare (need to come up with a better name though). S... [14:20:14] (03PS4) 10Clarakosi: REST endpoint for executing jobs [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/571816 (https://phabricator.wikimedia.org/T244826) [14:20:35] (03CR) 10Clarakosi: REST endpoint for executing jobs (0315 comments) [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/571816 (https://phabricator.wikimedia.org/T244826) (owner: 10Clarakosi) [14:24:03] (03PS1) 10Robert Vogel: Remove unused code [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/572231 [14:24:23] (03CR) 10Pwirth: [C: 03+2] Remove legacy HTMLForm styling [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/572200 (owner: 10Robert Vogel) [14:26:17] (03PS2) 10Pwirth: Load resources conditionally [extensions/BlueSpiceUniversalExport] - 10https://gerrit.wikimedia.org/r/572003 (owner: 10Robert Vogel) [14:27:08] (03CR) 10Pwirth: [C: 03+2] Small fixes [extensions/BlueSpiceInsertFile] - 10https://gerrit.wikimedia.org/r/571995 (owner: 10ItSpiderman) [14:27:13] (03PS1) 10Pwirth: Small fixes [extensions/BlueSpiceInsertFile] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/572233 [14:27:17] (03PS1) 10Pwirth: Small fixes [extensions/BlueSpiceInsertFile] (REL1_31) - 10https://gerrit.wikimedia.org/r/572234 [14:27:20] (03CR) 10Pwirth: [C: 03+2] Small fixes [extensions/BlueSpiceInsertFile] (REL1_31) - 10https://gerrit.wikimedia.org/r/572234 (owner: 10Pwirth) [14:27:26] (03CR) 10Pwirth: [C: 03+2] Small fixes [extensions/BlueSpiceInsertFile] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/572233 (owner: 10Pwirth) [14:27:28] (03CR) 10Pwirth: [V: 03+2 C: 03+2] Small fixes [extensions/BlueSpiceInsertFile] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/572233 (owner: 10Pwirth) [14:28:08] (03CR) 10Pwirth: [C: 03+2] Use non-static access to SpecialPage factory [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/571982 (owner: 10Robert Vogel) [14:28:42] (03Merged) 10jenkins-bot: Remove legacy HTMLForm styling [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/572200 (owner: 10Robert Vogel) [14:28:54] 10MediaWiki-General, 10User-DannyS712: Factor username logic out of the User class - https://phabricator.wikimedia.org/T245231 (10Art-Baltai) class UserName as ValueObject is a good way to improve strict types in PHP, give us the map of coupling, prepare this "domain" for re-engineering, etc. But probably this... [14:29:40] (03CR) 10Pwirth: [C: 03+2] Switch to font icons [extensions/BlueSpiceUEModuleBookPDF] - 10https://gerrit.wikimedia.org/r/571989 (owner: 10Robert Vogel) [14:29:47] (03PS1) 10Pwirth: Switch to font icons [extensions/BlueSpiceUEModuleBookPDF] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/572235 [14:29:55] (03CR) 10Pwirth: [V: 03+2 C: 03+2] Switch to font icons [extensions/BlueSpiceUEModuleBookPDF] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/572235 (owner: 10Pwirth) [14:30:01] (03PS1) 10Pwirth: Switch to font icons [extensions/BlueSpiceUEModuleBookPDF] (REL1_31) - 10https://gerrit.wikimedia.org/r/572236 [14:30:04] (03CR) 10Pwirth: [C: 03+2] Switch to font icons [extensions/BlueSpiceUEModuleBookPDF] (REL1_31) - 10https://gerrit.wikimedia.org/r/572236 (owner: 10Pwirth) [14:30:41] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q3), 10SEO: Investigate and fix tags in page source - https://phabricator.wikimedia.org/T244614 (10phuedx) I'm moving this into **Needs Code Review** after a discussio... [14:30:42] (03CR) 10Pwirth: [C: 03+2] Load resources conditionally [extensions/BlueSpiceUserInfo] - 10https://gerrit.wikimedia.org/r/572015 (owner: 10Robert Vogel) [14:30:49] (03PS1) 10Pwirth: Load resources conditionally [extensions/BlueSpiceUserInfo] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/572237 [14:30:53] (03CR) 10Pwirth: [V: 03+2 C: 03+2] Load resources conditionally [extensions/BlueSpiceUserInfo] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/572237 (owner: 10Pwirth) [14:31:00] (03PS1) 10Pwirth: Load resources conditionally [extensions/BlueSpiceUserInfo] (REL1_31) - 10https://gerrit.wikimedia.org/r/572238 [14:31:03] (03CR) 10Pwirth: [C: 03+2] Load resources conditionally [extensions/BlueSpiceUserInfo] (REL1_31) - 10https://gerrit.wikimedia.org/r/572238 (owner: 10Pwirth) [14:31:34] (03CR) 10Pwirth: [C: 03+2] Refactor js structure [extensions/BlueSpiceFilterableTables] - 10https://gerrit.wikimedia.org/r/571986 (owner: 10ItSpiderman) [14:31:37] (03Merged) 10jenkins-bot: Small fixes [extensions/BlueSpiceInsertFile] - 10https://gerrit.wikimedia.org/r/571995 (owner: 10ItSpiderman) [14:31:39] (03Merged) 10jenkins-bot: Small fixes [extensions/BlueSpiceInsertFile] (REL1_31) - 10https://gerrit.wikimedia.org/r/572234 (owner: 10Pwirth) [14:31:41] (03PS1) 10Pwirth: Refactor js structure [extensions/BlueSpiceFilterableTables] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/572239 [14:31:44] (03CR) 10Pwirth: [V: 03+2 C: 03+2] Refactor js structure [extensions/BlueSpiceFilterableTables] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/572239 (owner: 10Pwirth) [14:31:50] (03PS1) 10Pwirth: Refactor js structure [extensions/BlueSpiceFilterableTables] (REL1_31) - 10https://gerrit.wikimedia.org/r/572240 [14:31:53] (03CR) 10Pwirth: [C: 03+2] Refactor js structure [extensions/BlueSpiceFilterableTables] (REL1_31) - 10https://gerrit.wikimedia.org/r/572240 (owner: 10Pwirth) [14:32:13] (03Merged) 10jenkins-bot: Use non-static access to SpecialPage factory [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/571982 (owner: 10Robert Vogel) [14:32:51] (03CR) 10Tchanders: Add compare tab to Special:Investigate (034 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/571626 (https://phabricator.wikimedia.org/T238782) (owner: 10Dmaza) [14:33:41] (03Merged) 10jenkins-bot: Switch to font icons [extensions/BlueSpiceUEModuleBookPDF] - 10https://gerrit.wikimedia.org/r/571989 (owner: 10Robert Vogel) [14:33:43] (03Merged) 10jenkins-bot: Switch to font icons [extensions/BlueSpiceUEModuleBookPDF] (REL1_31) - 10https://gerrit.wikimedia.org/r/572236 (owner: 10Pwirth) [14:34:15] (03Merged) 10jenkins-bot: Load resources conditionally [extensions/BlueSpiceUserInfo] - 10https://gerrit.wikimedia.org/r/572015 (owner: 10Robert Vogel) [14:34:20] (03Merged) 10jenkins-bot: Load resources conditionally [extensions/BlueSpiceUserInfo] (REL1_31) - 10https://gerrit.wikimedia.org/r/572238 (owner: 10Pwirth) [14:34:30] 10Design, 10Design Research and product team collaboration, 10Design-Research, 10Desktop Improvements, and 2 others: Enable the user to choose up-to-date fonts, more legible on LCD screens - https://phabricator.wikimedia.org/T243508 (10Demian) [14:35:32] (03Merged) 10jenkins-bot: Refactor js structure [extensions/BlueSpiceFilterableTables] - 10https://gerrit.wikimedia.org/r/571986 (owner: 10ItSpiderman) [14:35:34] (03Merged) 10jenkins-bot: Refactor js structure [extensions/BlueSpiceFilterableTables] (REL1_31) - 10https://gerrit.wikimedia.org/r/572240 (owner: 10Pwirth) [14:40:02] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Growth-Team (Current Sprint), 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07): Newcomer tasks: show skeleton screen while loading - https://phabricator.wikimedia.org/T238231 (10kostajh) > Based on the current way these issues are appearing, here is a sugges... [14:40:09] (03PS1) 10Pwirth: Injuect document into JS code instead of using global [extensions/BlueSpiceExportTables] - 10https://gerrit.wikimedia.org/r/572242 [14:43:06] (03PS2) 10Pwirth: Inject document into JS code instead of using global [extensions/BlueSpiceExportTables] - 10https://gerrit.wikimedia.org/r/572242 [14:43:20] (03CR) 10Pwirth: [C: 03+2] Load resources conditionally [extensions/BlueSpiceUniversalExport] - 10https://gerrit.wikimedia.org/r/572003 (owner: 10Robert Vogel) [14:43:24] (03PS1) 10Pwirth: Load resources conditionally [extensions/BlueSpiceUniversalExport] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/572244 [14:43:32] (03CR) 10Pwirth: [V: 03+2 C: 03+2] Load resources conditionally [extensions/BlueSpiceUniversalExport] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/572244 (owner: 10Pwirth) [14:44:12] (03CR) 10Pwirth: [C: 03+2] Remove unused code [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/572231 (owner: 10Robert Vogel) [14:44:17] (03PS1) 10Pwirth: Remove unused code [extensions/BlueSpiceSocial] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/572245 [14:44:30] (03CR) 10Pwirth: [V: 03+2 C: 03+2] Remove unused code [extensions/BlueSpiceSocial] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/572245 (owner: 10Pwirth) [14:44:35] (03PS1) 10Pwirth: Remove unused code [extensions/BlueSpiceSocial] (REL1_31) - 10https://gerrit.wikimedia.org/r/572246 [14:44:38] (03CR) 10Pwirth: [C: 03+2] Remove unused code [extensions/BlueSpiceSocial] (REL1_31) - 10https://gerrit.wikimedia.org/r/572246 (owner: 10Pwirth) [14:46:29] (03CR) 10jerkins-bot: [V: 04-1] Remove unused code [extensions/BlueSpiceSocial] (REL1_31) - 10https://gerrit.wikimedia.org/r/572246 (owner: 10Pwirth) [14:46:32] (03Merged) 10jenkins-bot: Load resources conditionally [extensions/BlueSpiceUniversalExport] - 10https://gerrit.wikimedia.org/r/572003 (owner: 10Robert Vogel) [14:48:33] 10NewcomerTasks 1.1, 10Growth-Team (Current Sprint): Regenerate data for prototype using updated ORES models - https://phabricator.wikimedia.org/T243956 (10kostajh) @MMiller_WMF I'm nearly done with data generation for `cswiki` and I'll have to work on production the other wiki data later today / tonight / thi... [14:49:44] (03Merged) 10jenkins-bot: Remove unused code [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/572231 (owner: 10Robert Vogel) [14:51:28] 10MediaWiki-General, 10Core Platform Team, 10TCB-Team, 10Patch-For-Review: Conflict resolution process ends with incorrect "This page has been restored" - https://phabricator.wikimedia.org/T245244 (10awight) [14:53:39] (03CR) 10Dmaza: Update preliminary check classes to use multi-column pagination (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572040 (https://phabricator.wikimedia.org/T244517) (owner: 10Tchanders) [14:57:08] 10Stashbot: Allow !log in #wikimedia-sre - https://phabricator.wikimedia.org/T245242 (10MarcoAurelio) a:03bd808 As requested via IRC. [14:58:58] (03PS1) 10WMDE-Fisch: Better document trimming of textbox input [core] - 10https://gerrit.wikimedia.org/r/572248 [15:03:06] 10MediaWiki-General, 10Core Platform Team, 10TCB-Team, 10Patch-For-Review: Conflict resolution process ends with incorrect "This page has been restored" - https://phabricator.wikimedia.org/T245244 (10awight) This is really strange, but now I get a "Your edit was saved" notification on betawiki, and not the... [15:06:28] (03PS1) 10WMDE-Fisch: Use documented method for trimming input [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572249 [15:07:08] (03CR) 10Pwirth: [V: 03+2 C: 03+2] Remove unused code [extensions/BlueSpiceSocial] (REL1_31) - 10https://gerrit.wikimedia.org/r/572246 (owner: 10Pwirth) [15:07:53] (03CR) 10Lucas Werkmeister (WMDE): "CCing some more people from I47a7cabf75." [core] - 10https://gerrit.wikimedia.org/r/571959 (owner: 10Lucas Werkmeister (WMDE)) [15:09:34] 10MediaWiki-Core-Testing, 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-CentralAuth, 10Beta-Cluster-Infrastructure, and 3 others: Login to at least en.wikipedia.beta.wmflabs.org and commons.wikimedia.beta.wmflabs.org sometimes fails with `There seems to... - https://phabricator.wikimedia.org/T243123 [15:10:09] 10MediaWiki-General, 10Core Platform Team, 10TCB-Team, 10Patch-For-Review: Conflict resolution process ends with incorrect "This page has been restored" - https://phabricator.wikimedia.org/T245244 (10awight) >>! In T245244#5885019, @awight wrote: > This is really strange, but now I get a "Your edit was sav... [15:11:34] (03CR) 10Awight: [C: 04-2] "There's something I don't understand here. Now I get "oldid=0" all the time, starting to think that my patch is only helpful for an edge " [core] - 10https://gerrit.wikimedia.org/r/572210 (https://phabricator.wikimedia.org/T245244) (owner: 10Awight) [15:13:35] 10Stashbot: Allow !log in #wikimedia-sre - https://phabricator.wikimedia.org/T245242 (10bd808) Configured to mirror the config of the `#wikimedia-operations` channel using YAML anchors and references. Functionally: `name=etc/config-k8s.yaml,lang=yaml sal: channels: '#wikimedia-operations': &OPERATIONS... [15:13:37] 10Inuka-Team (Kanban): How to correctly add missing keys to i18n json files - https://phabricator.wikimedia.org/T245100 (10eamedina) Wonderful, thank you @SBisson @Aklapper @hueitan for all the informative replies. Certainly learned something from this thread, will take a look at translatewiki.net 👍 [15:15:36] (03PS1) 10Tchanders: HTMLUsersMultiselectField: Pass through config for widget's input [core] - 10https://gerrit.wikimedia.org/r/572254 (https://phabricator.wikimedia.org/T245271) [15:16:55] (03PS1) 10Ori.livneh: Fix for create_pygmentize_bundle Python 3 compat [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/572255 [15:17:25] (03PS1) 10Robert Vogel: Make `composer.json` valid [extensions/OpenIDConnect] - 10https://gerrit.wikimedia.org/r/572256 [15:18:19] (03PS1) 10Esther Akinloose: Test for the expiry parameter of action=protect [tools/api-testing] - 10https://gerrit.wikimedia.org/r/572257 [15:18:30] 10Stashbot: Allow !log in #wikimedia-sre - https://phabricator.wikimedia.org/T245242 (10bd808) 05Open→03Resolved https://twitter.com/wikimedia_sal/status/1228337426642460672 [15:18:37] (03PS1) 10Tchanders: SpecialInvestigate: Remove browser autocomplete from target widget [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572258 (https://phabricator.wikimedia.org/T245271) [15:19:39] 10MediaWiki-General: Real-time indicator that another edit has happened since you began editing - https://phabricator.wikimedia.org/T245274 (10awight) [15:20:04] (03CR) 10jerkins-bot: [V: 04-1] Test for the expiry parameter of action=protect [tools/api-testing] - 10https://gerrit.wikimedia.org/r/572257 (owner: 10Esther Akinloose) [15:20:07] 10Stashbot: Add Mastodon support to stashbot - https://phabricator.wikimedia.org/T52109 (10bd808) 05Open→03Resolved Still working, seems safe to close. [15:22:43] 10MediaWiki-General, 10Core Platform Team, 10TCB-Team, 10Patch-For-Review: Conflict resolution process ends with incorrect "This page has been restored" - https://phabricator.wikimedia.org/T245244 (10awight) I just got "restored", then "saved" one after another when going through the steps to reproduce. 🌵 [15:23:24] (03PS1) 10Esther Akinloose: --amend [tools/api-testing] - 10https://gerrit.wikimedia.org/r/572263 [15:23:42] (03CR) 10C. Scott Ananian: [C: 03+2] Use proper SemVer comparison in CheckComposerLockUpToDate [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/572102 (owner: 10Reedy) [15:23:53] (03CR) 10Dmaza: Update preliminary check classes to use multi-column pagination (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572040 (https://phabricator.wikimedia.org/T244517) (owner: 10Tchanders) [15:25:36] (03CR) 10C. Scott Ananian: "We'll need to tag and release a new version of Parsoid. I'll do that in -a3; we're going to try to get parsoid 0.12.0-a2 fully deployed f" [vendor] - 10https://gerrit.wikimedia.org/r/564141 (owner: 10Reedy) [15:25:38] 10QuickSurveys, 10Epic: Increase QuickSurveys' observability - https://phabricator.wikimedia.org/T245275 (10phuedx) [15:26:41] 10Internet-Archive, 10InternetArchiveBot: Convert archive.today to archive.org - https://phabricator.wikimedia.org/T245276 (10Green_Cardamom) [15:27:29] (03Abandoned) 10Esther Akinloose: --amend [tools/api-testing] - 10https://gerrit.wikimedia.org/r/572263 (owner: 10Esther Akinloose) [15:30:02] (03PS4) 10Tchanders: Update preliminary check classes to use multi-column pagination [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572040 (https://phabricator.wikimedia.org/T244517) [15:31:05] (03CR) 10C. Scott Ananian: "Oh, we also need a new version of mediawiki-codesniffer released to pick up https://github.com/wikimedia/mediawiki-tools-codesniffer/commi" [vendor] - 10https://gerrit.wikimedia.org/r/564141 (owner: 10Reedy) [15:31:37] (03CR) 10C. Scott Ananian: "This will need a new version of mediawiki-codesniffer released to pick up https://github.com/wikimedia/mediawiki-tools-codesniffer/commit/" [core] - 10https://gerrit.wikimedia.org/r/564142 (owner: 10Reedy) [15:32:50] (03Merged) 10jenkins-bot: Use proper SemVer comparison in CheckComposerLockUpToDate [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/572102 (owner: 10Reedy) [15:36:25] (03PS1) 10Migurski: Added rc_user null check to prevent failing inserts [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572266 [15:38:39] 10CheckUser: Installation of CheckUser barfs when run on a brand new mediawiki installation - https://phabricator.wikimedia.org/T244283 (10MMigurski) Thanks @Aklapper, I started the process and ended up with a change here: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CheckUser/+/572266/ This is on th... [15:42:56] 04(no projects): VE can't edit tables with row number column from {{Rank}}. Another reason to implement built-in row number option. - https://phabricator.wikimedia.org/T245277 (10Timeshifter) [15:43:58] (03PS1) 10Migurski: Added rc_user null check to prevent failing inserts [extensions/CheckUser] (REL1_33) - 10https://gerrit.wikimedia.org/r/572271 [15:44:32] 10CheckUser: Installation of CheckUser barfs when run on a brand new mediawiki installation - https://phabricator.wikimedia.org/T244283 (10MMigurski) Ah, here we go with the branch: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CheckUser/+/572271/ [15:45:09] 04(no projects): VE can't edit tables with row number column from {{Rank}}. Another reason to implement built-in row number option. - https://phabricator.wikimedia.org/T245277 (10Timeshifter) [15:46:27] (03CR) 10Dmaza: "Couple comments with questions but LGTM." (032 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572040 (https://phabricator.wikimedia.org/T244517) (owner: 10Tchanders) [15:46:33] (03CR) 10Niedzielski: [C: 03+2] Unify XML declaration in SVG files [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/570522 (owner: 10VolkerE) [15:46:51] (03CR) 10Robert Vogel: [C: 03+2] Use tag integration for tag universalexport:meta [extensions/BlueSpiceUniversalExport] - 10https://gerrit.wikimedia.org/r/571521 (owner: 10Pwirth) [15:46:56] (03PS1) 10Robert Vogel: Use tag integration for tag universalexport:meta [extensions/BlueSpiceUniversalExport] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/572272 [15:47:00] (03CR) 10Robert Vogel: [V: 03+2 C: 03+2] Use tag integration for tag universalexport:meta [extensions/BlueSpiceUniversalExport] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/572272 (owner: 10Robert Vogel) [15:53:23] 10MediaWiki-Page-editing: Provide automatic numbering for rows in wikitable (currently manual) - https://phabricator.wikimedia.org/T180687 (10Timeshifter) There is already a task for this. It has a solution, I believe, but for some reason unknown to me, it is not being implemented. See: T42618. jquery.tablesort... [15:54:23] (03CR) 10Niedzielski: [C: 03+2] Ensure hover state is only available on active elements [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/571854 (owner: 10VolkerE) [15:57:06] (03CR) 10Niedzielski: [C: 03+1] build: Replace JSDuck with JSDoc [skins/Vector] - 10https://gerrit.wikimedia.org/r/571841 (https://phabricator.wikimedia.org/T239258) (owner: 10Nray) [15:59:44] (03CR) 10Niedzielski: [C: 04-1] build: Replace JSDuck with JSDoc (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/571841 (https://phabricator.wikimedia.org/T239258) (owner: 10Nray) [16:00:23] (03PS5) 10Nikki Nikkhoui: Hook Container [core] - 10https://gerrit.wikimedia.org/r/571297 (https://phabricator.wikimedia.org/T240307) [16:03:41] (03Merged) 10jenkins-bot: Unify XML declaration in SVG files [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/570522 (owner: 10VolkerE) [16:03:43] (03Merged) 10jenkins-bot: Use tag integration for tag universalexport:meta [extensions/BlueSpiceUniversalExport] - 10https://gerrit.wikimedia.org/r/571521 (owner: 10Pwirth) [16:09:04] (03CR) 10jerkins-bot: [V: 04-1] Ensure hover state is only available on active elements [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/571854 (owner: 10VolkerE) [16:09:28] 10Library-Card-Platform, 10good first task: Error on 'Mark as Sent' page for automatic-send partners - https://phabricator.wikimedia.org/T234551 (10Samwalton9) 05Open→03Resolved [16:09:30] 10Library-Card-Platform: Improve coordinator workflows - https://phabricator.wikimedia.org/T240146 (10Samwalton9) [16:15:08] (03CR) 10jerkins-bot: [V: 04-1] Hook Container [core] - 10https://gerrit.wikimedia.org/r/571297 (https://phabricator.wikimedia.org/T240307) (owner: 10Nikki Nikkhoui) [16:18:11] 10MediaWiki-extensions-WikimediaEvents, 10Product-Analytics, 10MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): Remove instrumentation for Schema:Print - https://phabricator.wikimedia.org/T196159 (10Edtadros) @phuedx Can you confirm that the cod... [16:20:24] (03PS5) 10Dmaza: Add compare tab to Special:Investigate [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/571626 (https://phabricator.wikimedia.org/T238782) [16:20:55] 10MediaWiki-extensions-Other: S5SlideShow extension does not work anymore with Mediawiki 1.33+ - https://phabricator.wikimedia.org/T241706 (10Seppl2013) I tried a request https://www.mediawiki.org/wiki/Gerrit/New_repositories/Requests and now a question showed up there and i have no clue how to answer it since t... [16:24:20] 10Google-Drive-to-Commons: Plan for Google drive to Commons and GSoC 2020 ? - https://phabricator.wikimedia.org/T243456 (1001tonythomas) I have it pending here https://www.outreachy.org/outreachy-may-2020-internship-round/communities/wikimedia/#enhancements-to-gdrive-to-commons-uploader-tool. Will keep on polish... [16:25:11] 10MediaWiki-General: logstash_formatter_key_conflict in mediawiki logs - https://phabricator.wikimedia.org/T245280 (10fgiunchedi) [16:33:12] 10Developer-Advocacy (Jan-Mar 2020), 10Documentation: Set up Tech blog to share stories from the Wikimedia Technical community - https://phabricator.wikimedia.org/T242619 (10srodlund) @RHeigl It is a big universe, and I'm confident between the two blogs there will be plenty of content--and likely different tak... [16:35:25] 10MediaWiki-extensions-WikimediaEvents, 10Product-Analytics, 10MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): Remove instrumentation for Schema:Print - https://phabricator.wikimedia.org/T196159 (10Edtadros) a:05Edtadros→03phuedx [16:39:12] (03PS7) 10Nray: build: Replace JSDuck with JSDoc [skins/Vector] - 10https://gerrit.wikimedia.org/r/571841 (https://phabricator.wikimedia.org/T239258) [16:39:14] (03PS4) 10Nray: Add 'jsdoc-wmf-theme' to jsdoc [skins/Vector] - 10https://gerrit.wikimedia.org/r/572127 (https://phabricator.wikimedia.org/T239258) [16:40:12] 10MediaWiki-Parser, 10Parsoid, 10TemplateData, 10VisualEditor, 10Technical-Debt: Evaluate how to structure internal calls to TemplateData in PHP - https://phabricator.wikimedia.org/T243854 (10ssastry) p:05Triage→03Medium [16:41:34] (03CR) 10Eric Gardner: Add Vue i18n plugin (031 comment) [core] - 10https://gerrit.wikimedia.org/r/570500 (owner: 10Catrope) [16:41:39] 10MediaWiki-Page-Diffs, 10Parsoid-PHP, 10Patch-For-Review: Undefined property: Diff::$edits in includes/diff/DiffFormatter.php - https://phabricator.wikimedia.org/T234040 (10ssastry) 05Open→03Resolved I am going to mark this resolved. Please reopen / refile if there is anything else that needs fixing. [16:49:08] (03CR) 10Niedzielski: [C: 03+1] build: Replace JSDuck with JSDoc [skins/Vector] - 10https://gerrit.wikimedia.org/r/571841 (https://phabricator.wikimedia.org/T239258) (owner: 10Nray) [16:49:44] (03CR) 10Anomie: "> Do we know what caused the types to change? Was it intentional?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/572119 (https://phabricator.wikimedia.org/T245202) (owner: 10EBernhardson) [16:51:20] (03Abandoned) 10EBernhardson: Force namespace filter to use strings [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/572119 (https://phabricator.wikimedia.org/T245202) (owner: 10EBernhardson) [16:54:37] (03CR) 10Tchanders: "Looks great. Good to go after the commit message fix" (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/571626 (https://phabricator.wikimedia.org/T238782) (owner: 10Dmaza) [16:54:39] 10Phabricator, 10Security-Team, 10Security, 10Security Related: Update protect as security issue to use acl*security - https://phabricator.wikimedia.org/T245201 (10mmodell) @chasemp: The best way I can think of to make the transition easy (and ease future maintainability of the code) is to make the project... [16:58:58] (03CR) 10Thiemo Kreuz (WMDE): "Is there a way we can apply an additional rtrim() in the TwoColConflict extension as well, just to be sure a similar bug does not hit us a" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572220 (https://phabricator.wikimedia.org/T245154) (owner: 10WMDE-Fisch) [16:59:29] (03PS5) 10Tchanders: Update preliminary check classes to use multi-column pagination [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572040 (https://phabricator.wikimedia.org/T244517) [17:06:14] 10MediaWiki-Interface, 10MediaWiki-ResourceLoader, 10MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), 10Readers-Web-Backlog (Kanbanana-2019-20-Q3), 10Wikimedia-production-error: Use of $wgLogoHD was deprecated in Rename configuration variable to $wgLogos - https://phabricator.wikimedia.org/T245182 (10Jdlrobson... [17:07:07] 10Library-Card-Platform-Proxy: Ensure that we can track how many editors are actively using authentication - https://phabricator.wikimedia.org/T153432 (10jsn.sherman) there are statistics available for download via the ezproxy reporting interface. The login details are in 1password [17:07:19] (03CR) 10Nray: [C: 04-1] "When I run npm run test repeatedly, stylelint is throwing errors...i think the docs folder needs to be ignored" [skins/Vector] - 10https://gerrit.wikimedia.org/r/571841 (https://phabricator.wikimedia.org/T239258) (owner: 10Nray) [17:08:32] 10Developer-Advocacy (Jan-Mar 2020): Decide which GCI 2019 mentor to attend GCI Grand Prize winners weekend in June 2020 (before 2020-02-21) - https://phabricator.wikimedia.org/T241927 (10Aklapper) Hmm, does anyone know / remember how to proceed? I found an email from Google on 2020-01-05 that "We will issue th... [17:12:08] 10MediaWiki-extensions-WikimediaEvents, 10Product-Analytics, 10MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): Remove instrumentation for Schema:Print - https://phabricator.wikimedia.org/T196159 (10phuedx) >>! In T196159#5885148, @Edtadros wrot... [17:17:00] 10Library-Card-Platform: Improve usability of our staging environment - https://phabricator.wikimedia.org/T245257 (10jsn.sherman) [17:20:22] (03CR) 10Vedmaka Wakalaka: "* RestrictionStore is moved to the MediaWiki\Restrictions namespace" [core] - 10https://gerrit.wikimedia.org/r/549909 (https://phabricator.wikimedia.org/T218395) (owner: 10Vedmaka Wakalaka) [17:21:20] (03CR) 10Vedmaka Wakalaka: Create UserGroupManager (0311 comments) [core] - 10https://gerrit.wikimedia.org/r/545690 (https://phabricator.wikimedia.org/T234921) (owner: 10Ppchelko) [17:21:57] (03CR) 10Vedmaka Wakalaka: Adds a new RestrictionStore service with aim to move restrictions logic out of Title class and from PermissionManger service. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/549909 (https://phabricator.wikimedia.org/T218395) (owner: 10Vedmaka Wakalaka) [17:22:35] 10MediaWiki-extensions-Other: S5SlideShow extension does not work anymore with Mediawiki 1.33+ - https://phabricator.wikimedia.org/T241706 (10Aklapper) >>! In T241706#5885166, @Seppl2013 wrote: > I tried a request https://www.mediawiki.org/wiki/Gerrit/New_repositories/Requests and now a question showed up there... [17:23:33] (03PS2) 10Aklapper: Added rc_user null check to prevent failing inserts [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572266 (https://phabricator.wikimedia.org/T244283) (owner: 10Migurski) [17:23:37] (03PS2) 10Aklapper: Added rc_user null check to prevent failing inserts [extensions/CheckUser] (REL1_33) - 10https://gerrit.wikimedia.org/r/572271 (https://phabricator.wikimedia.org/T244283) (owner: 10Migurski) [17:24:29] (03CR) 10jerkins-bot: [V: 04-1] Added rc_user null check to prevent failing inserts [extensions/CheckUser] (REL1_33) - 10https://gerrit.wikimedia.org/r/572271 (https://phabricator.wikimedia.org/T244283) (owner: 10Migurski) [17:24:43] 04(no projects): VE can't edit tables with row number column from {{Rank}} - https://phabricator.wikimedia.org/T245277 (10Aklapper) [17:24:46] 10QuickSurveys: Increase QuickSurveys' observability - https://phabricator.wikimedia.org/T245275 (10phuedx) [17:25:02] (03CR) 10Nikki Nikkhoui: Hook Container (033 comments) [core] - 10https://gerrit.wikimedia.org/r/571297 (https://phabricator.wikimedia.org/T240307) (owner: 10Nikki Nikkhoui) [17:32:17] (03PS8) 10Nray: build: Replace JSDuck with JSDoc [skins/Vector] - 10https://gerrit.wikimedia.org/r/571841 (https://phabricator.wikimedia.org/T239258) [17:32:19] (03PS5) 10Nray: Add 'jsdoc-wmf-theme' to jsdoc [skins/Vector] - 10https://gerrit.wikimedia.org/r/572127 (https://phabricator.wikimedia.org/T239258) [17:32:23] (03PS6) 10Nikki Nikkhoui: Hook Container [core] - 10https://gerrit.wikimedia.org/r/571297 (https://phabricator.wikimedia.org/T240307) [17:32:27] (03CR) 10Niedzielski: [C: 03+1] build: Replace JSDuck with JSDoc [skins/Vector] - 10https://gerrit.wikimedia.org/r/571841 (https://phabricator.wikimedia.org/T239258) (owner: 10Nray) [17:32:35] (03CR) 10Niedzielski: [C: 03+1] "Thanks, @nray! Happy to merge next week if there are no objections (or see it merged by someone else before then!)." [skins/Vector] - 10https://gerrit.wikimedia.org/r/571841 (https://phabricator.wikimedia.org/T239258) (owner: 10Nray) [17:33:14] 10Developer-Advocacy (Jan-Mar 2020): Decide which GCI 2019 mentor to attend GCI Grand Prize winners weekend in June 2020 (before 2020-02-21) - https://phabricator.wikimedia.org/T241927 (10Urbanecm) IIRC, last year, Google sent an email to all the org admins that was to be forwarded to the selected mentor. Unsure... [17:34:57] 10donate.wikimedia.org, 10Browser-Support-Internet-Explorer: Wikimedia Foundation image cut off on IE 11 - https://phabricator.wikimedia.org/T244525 (10Pcoombe) 05Open→03Resolved a:03Pcoombe Nice catch @jbolorinos-ctr! Fixed by adding a height attribute to the svg: [diff](https://donate.wikimedia.org/w/i... [17:36:45] (03CR) 10jerkins-bot: [V: 04-1] Added rc_user null check to prevent failing inserts [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572266 (https://phabricator.wikimedia.org/T244283) (owner: 10Migurski) [17:37:11] 10MediaWiki-General: Real-time indicator that another edit has happened since you began editing - https://phabricator.wikimedia.org/T245274 (10Reedy) https://www.mediawiki.org/wiki/Extension:EditWarning was an attempt to do something like this [17:38:22] (03CR) 10Aezell: "Is there documentation for the multi-column sort that will inform other devs about this idiosyncrasy of `getDefaultSort`?" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/571848 (owner: 10Tchanders) [17:38:31] (03PS1) 10Tpt: Revert "Rtrim input text" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572286 [17:39:07] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-Debug-Logger: logstash_formatter_key_conflict in mediawiki logs - https://phabricator.wikimedia.org/T245280 (10Reedy) [17:39:13] (03PS2) 10Tpt: Revert "Rtrim input text" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572286 (https://phabricator.wikimedia.org/T245154) [17:39:28] (03CR) 10Nray: build: Replace JSDuck with JSDoc (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/571841 (https://phabricator.wikimedia.org/T239258) (owner: 10Nray) [17:43:35] (03CR) 10Tpt: [C: 04-1] "See https://phabricator.wikimedia.org/T245154#anchor-5885428" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572249 (owner: 10WMDE-Fisch) [17:44:47] (03PS6) 10Nray: Add 'jsdoc-wmf-theme' to jsdoc [skins/Vector] - 10https://gerrit.wikimedia.org/r/572127 (https://phabricator.wikimedia.org/T239258) [17:46:17] (03PS1) 10Reedy: Don't pass 'ip' through to logging [core] - 10https://gerrit.wikimedia.org/r/572287 (https://phabricator.wikimedia.org/T245280) [17:46:32] (03CR) 10jerkins-bot: [V: 04-1] Hook Container [core] - 10https://gerrit.wikimedia.org/r/571297 (https://phabricator.wikimedia.org/T240307) (owner: 10Nikki Nikkhoui) [17:46:33] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-Debug-Logger, 10MediaWiki-extensions-LoginNotify, 10Community-Tech, 10Patch-For-Review: logstash_formatter_key_conflict in mediawiki logs - https://phabricator.wikimedia.org/T245280 (10Reedy) [17:47:45] (03PS1) 10Reedy: Don't use 'type' as a log parameter as it is a reserved word [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/572289 (https://phabricator.wikimedia.org/T245280) [17:49:03] (03PS1) 10Reedy: Don't pass 'ip' through to logging [core] - 10https://gerrit.wikimedia.org/r/572290 (https://phabricator.wikimedia.org/T245280) [17:49:22] 10MediaWiki-Parser: Parser::getTitle() is not allowed to return null, eventhough it can happen - https://phabricator.wikimedia.org/T245129 (10Jdforrester-WMF) [17:49:25] 10MediaWiki-Parser, 10MediaWiki-extensions-Translate, 10MediaWiki Language Extension Bundle, 10Patch-For-Review: "PageTranslationHooks.php": Call to a member function getIsSectionPreview() on null - https://phabricator.wikimedia.org/T228881 (10Jdforrester-WMF) [17:49:30] (03PS3) 10Migurski: Added rc_user null check to prevent failing inserts [extensions/CheckUser] (REL1_33) - 10https://gerrit.wikimedia.org/r/572271 [17:50:03] 10MediaWiki-Parser, 10MediaWiki-extensions-Translate, 10MediaWiki Language Extension Bundle, 10Parsing-Team, 10Patch-For-Review: "PageTranslationHooks.php": Call to a member function getIsSectionPreview() on null - https://phabricator.wikimedia.org/T228881 (10Jdforrester-WMF) [17:50:23] (03PS3) 10Migurski: Added rc_user null check to prevent failing inserts [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572266 [17:50:25] 10MobileFrontend, 10Epic, 10MW-1.35-notes (1.35.0-wmf.20; 2020-02-18), 10Readers-Web-Backlog (Tracking), 10Reading-Web-Local-Wiki-Issues: [EPIC] MobileFrontend extension should stop special-casing main page - https://phabricator.wikimedia.org/T32405 (10Jdlrobson) [17:50:27] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-Debug-Logger, 10MediaWiki-extensions-LoginNotify, 10Community-Tech, and 2 others: logstash_formatter_key_conflict in mediawiki logs - https://phabricator.wikimedia.org/T245280 (10Reedy) [17:50:43] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: Find alternative to Special:HideBanners cookies to mitigate the loss of 3rd-party cookie support - https://phabricator.wikimedia.org/T244699 (10Pcoombe) [17:57:58] 10Developer-Advocacy (Jan-Mar 2020): Decide which GCI 2019 mentor to attend GCI Grand Prize winners weekend in June 2020 (before 2020-02-21) - https://phabricator.wikimedia.org/T241927 (10Ebe123) There was no org admin form to fill (other than the Payoneer stuff). I've sent a message to ask about how to proceed... [17:59:52] (03PS1) 10Reedy: Don't use 'host' as a log parameter [core] - 10https://gerrit.wikimedia.org/r/572291 (https://phabricator.wikimedia.org/T245280) [18:03:04] (03CR) 10Jdlrobson: [C: 03+2] build: Replace JSDuck with JSDoc [skins/Vector] - 10https://gerrit.wikimedia.org/r/571841 (https://phabricator.wikimedia.org/T239258) (owner: 10Nray) [18:07:19] (03PS6) 10Dmaza: Add compare tab to Special:Investigate [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/571626 (https://phabricator.wikimedia.org/T238782) [18:07:54] (03CR) 10Dmaza: Add compare tab to Special:Investigate (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/571626 (https://phabricator.wikimedia.org/T238782) (owner: 10Dmaza) [18:08:35] (03CR) 10MaxSem: [C: 03+2] Don't use 'type' as a log parameter as it is a reserved word [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/572289 (https://phabricator.wikimedia.org/T245280) (owner: 10Reedy) [18:08:37] (03PS7) 10Jdlrobson: Deprecate wgMinervaCustomLogos in favor of $wgLogos [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/551670 (https://phabricator.wikimedia.org/T232140) [18:09:53] 10MediaWiki-extensions-Other: S5SlideShow extension does not work anymore with Mediawiki 1.33+ - https://phabricator.wikimedia.org/T241706 (10MarcoAurelio) Thanks for the ping @Seppl2013. I'll go ahead and create/import the repo shortly. @Aklapper I think the process might be a bit confusing indeed. I've propose... [18:10:34] 10UI-Standardization, 10Timeless, 10Wikimedia Design Style Guide: Rethink the fonts and typography in skins, document the decisions - https://phabricator.wikimedia.org/T244425 (10Quiddity) We are not considering any font changes via the Desktop Improvements project. That would be a massive research project t... [18:10:59] 10Desktop Improvements, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): Add a Vector skin version preference - https://phabricator.wikimedia.org/T242381 (10Niedzielski) Thank you, @phuedx! > Could you add a note to the feature management task that the ability to enable "sets" and individua... [18:11:04] 10Design, 10Design Research and product team collaboration, 10Design-Research, 10Vector, 10Readers-Web-Backlog (Design): Enable the user to choose up-to-date fonts, more legible on LCD screens - https://phabricator.wikimedia.org/T243508 (10Quiddity) [18:11:35] 10Design, 10UI-Standardization, 10MinervaNeue, 10Timeless, 10Wikimedia Design Style Guide: RfC: [Design] Monospace font stack (source code typography): add commonly used fonts tailored for developers - https://phabricator.wikimedia.org/T244803 (10Quiddity) [18:11:55] 10Design, 10Design-Research: [Design] Evaluate the feasibility and impact of restoring font-size to the browser default / user setting in the Desktop Improvements project - https://phabricator.wikimedia.org/T245146 (10Quiddity) [18:12:49] (03CR) 10Dmaza: [C: 03+2] HTMLUsersMultiselectField: Pass through config for widget's input [core] - 10https://gerrit.wikimedia.org/r/572254 (https://phabricator.wikimedia.org/T245271) (owner: 10Tchanders) [18:13:20] (03CR) 10Dmaza: [C: 03+2] SpecialInvestigate: Remove browser autocomplete from target widget [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572258 (https://phabricator.wikimedia.org/T245271) (owner: 10Tchanders) [18:14:40] (03PS1) 10Pwirth: Use tag integration for universalexport:params and upgrade to BS3 [extensions/BlueSpiceUniversalExport] - 10https://gerrit.wikimedia.org/r/572294 [18:15:12] 10MediaWiki-Codesniffer: Create sniff to help prevent logstash_formatter_key_conflict in mediawiki logs - https://phabricator.wikimedia.org/T245289 (10Reedy) [18:16:39] (03CR) 10jerkins-bot: [V: 04-1] Use tag integration for universalexport:params and upgrade to BS3 [extensions/BlueSpiceUniversalExport] - 10https://gerrit.wikimedia.org/r/572294 (owner: 10Pwirth) [18:17:15] 10CheckUser, 10Anti-Harassment (The Letter Song), 10Patch-For-Review: CU 2.0: Display data in the Compare tab - https://phabricator.wikimedia.org/T238782 (10Niharika) >>! In T238782#5884950, @Tchanders wrote: > I have a few questions about the acceptance criteria: > >> * There is a new tab next to Prelimina... [18:17:55] (03Merged) 10jenkins-bot: build: Replace JSDuck with JSDoc [skins/Vector] - 10https://gerrit.wikimedia.org/r/571841 (https://phabricator.wikimedia.org/T239258) (owner: 10Nray) [18:17:57] (03Merged) 10jenkins-bot: Don't use 'type' as a log parameter as it is a reserved word [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/572289 (https://phabricator.wikimedia.org/T245280) (owner: 10Reedy) [18:18:17] (03PS2) 10Gergő Tisza: Allow arrays for type lists for parameterElementType [libs/Assert] - 10https://gerrit.wikimedia.org/r/572131 [18:18:48] (03CR) 10Gergő Tisza: Allow arrays for type lists for parameterElementType (031 comment) [libs/Assert] - 10https://gerrit.wikimedia.org/r/572131 (owner: 10Gergő Tisza) [18:18:55] (03PS2) 10Gergő Tisza: Release v0.5.0 [libs/Assert] - 10https://gerrit.wikimedia.org/r/572132 [18:19:01] (03PS2) 10Gergő Tisza: Remove Scrutinizer CI shield from readme page [libs/Assert] - 10https://gerrit.wikimedia.org/r/572133 [18:19:03] 10CheckUser, 10Anti-Harassment (The Letter Song), 10Patch-For-Review: CU 2.0: Display data in the Compare tab - https://phabricator.wikimedia.org/T238782 (10Niharika) [18:19:22] 10CheckUser, 10Anti-Harassment (The Letter Song), 10Patch-For-Review: CU 2.0: Display data in the Compare tab - https://phabricator.wikimedia.org/T238782 (10Niharika) [18:20:15] (03CR) 10Tchanders: [C: 03+2] Add compare tab to Special:Investigate [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/571626 (https://phabricator.wikimedia.org/T238782) (owner: 10Dmaza) [18:20:37] (03CR) 10jerkins-bot: [V: 04-1] Deprecate wgMinervaCustomLogos in favor of $wgLogos [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/551670 (https://phabricator.wikimedia.org/T232140) (owner: 10Jdlrobson) [18:20:42] (03CR) 10Aezell: [C: 03+2] PreliminaryCheckPager: Don't set unsortable field as default sort [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/571848 (owner: 10Tchanders) [18:21:58] (03PS2) 10Pwirth: Use tag integration for universalexport:params and upgrade to BS3 [extensions/BlueSpiceUniversalExport] - 10https://gerrit.wikimedia.org/r/572294 [18:22:39] (03PS6) 10Tchanders: Update preliminary check classes to use multi-column pagination [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572040 (https://phabricator.wikimedia.org/T244517) [18:23:04] 10MediaWiki-Page-editing: Real-time indicator that another edit has happened since you began editing - https://phabricator.wikimedia.org/T245274 (10Aklapper) [18:24:45] (03CR) 10DannyS712: Create UserGroupManager (0319 comments) [core] - 10https://gerrit.wikimedia.org/r/545690 (https://phabricator.wikimedia.org/T234921) (owner: 10Ppchelko) [18:26:42] 10MediaWiki-Page-editing, 10Core Platform Team, 10TCB-Team, 10Patch-For-Review: Conflict resolution process ends with incorrect "This page has been restored" - https://phabricator.wikimedia.org/T245244 (10Aklapper) [18:28:10] 10MediaWiki-General, 10User-DannyS712: Factor username logic out of the User class - https://phabricator.wikimedia.org/T245231 (10DannyS712) For UserNameUtils, I don't know if this will remain stateless, since it will still interact with some globals For UserNameFactory, it is indeed helpful to have the interm... [18:28:36] 10UploadWizard: Uploading fails with HTTP status 502 - https://phabricator.wikimedia.org/T244836 (10Pigsonthewing) Same symptoms for me, in Firefox. After small amount of testing, I found it fails in the same way in PaleMoon (a fork of an earlier version of Firefox) and works without issue on Chrome, and on MS E... [18:30:41] (03PS1) 10Tchanders: TablePager: Improve documentation for getDefaultSort [core] - 10https://gerrit.wikimedia.org/r/572299 [18:32:58] (03Merged) 10jenkins-bot: HTMLUsersMultiselectField: Pass through config for widget's input [core] - 10https://gerrit.wikimedia.org/r/572254 (https://phabricator.wikimedia.org/T245271) (owner: 10Tchanders) [18:33:01] (03Merged) 10jenkins-bot: SpecialInvestigate: Remove browser autocomplete from target widget [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572258 (https://phabricator.wikimedia.org/T245271) (owner: 10Tchanders) [18:34:02] (03CR) 10Thiemo Kreuz (WMDE): Revert "Rtrim input text" (031 comment) [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572286 (https://phabricator.wikimedia.org/T245154) (owner: 10Tpt) [18:34:16] (03CR) 10tosfos: Adds a new RestrictionStore service with aim to move restrictions logic out of Title class and from PermissionManger service. (033 comments) [core] - 10https://gerrit.wikimedia.org/r/549909 (https://phabricator.wikimedia.org/T218395) (owner: 10Vedmaka Wakalaka) [18:35:20] (03Merged) 10jenkins-bot: Add compare tab to Special:Investigate [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/571626 (https://phabricator.wikimedia.org/T238782) (owner: 10Dmaza) [18:38:32] (03PS6) 10Jdlrobson: Icons in skins.minerva.mainMenu.icons come from OOUI [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/570769 (https://phabricator.wikimedia.org/T244444) [18:38:39] 10MediaWiki-extensions-OAuth: OAuth consumer review interface should show changes from the last approved version - https://phabricator.wikimedia.org/T245290 (10Tgr) [18:40:09] 10UI-Standardization, 10OOUI, 10MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), and 2 others: Replace all possible, non-product specific icons in MobileFrontend/MinervaNeue with WikimediaUI/OOUI ones - https://phabricator.wikimedia.org/T244444 (10Vo... [18:41:35] 10MediaWiki-General, 10Technical-Debt (Deprecation process): Deprecate $messageMemc - https://phabricator.wikimedia.org/T243175 (10Krinkle) [18:41:38] 10MediaWiki-General, 10Performance-Team, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.35-notes (1.35.0-wmf.1; 2019-10-08): Audit and simplify MediaWiki initialisation code (Spring 2018) - https://phabricator.wikimedia.org/T189966 (10Krinkle) [18:41:40] 10MediaWiki-General, 10Technical-Debt (Deprecation process): Deprecate and remove $messageMemc - https://phabricator.wikimedia.org/T243175 (10Krinkle) [18:41:52] 10MediaWiki-extensions-OAuth: OAuth consumer proposal form should have a reason field - https://phabricator.wikimedia.org/T245291 (10Tgr) [18:43:17] 10MediaWiki-General, 10Technical-Debt (Deprecation process): Deprecate and remove $messageMemc - https://phabricator.wikimedia.org/T243175 (10Krinkle) [18:43:46] 10MediaWiki-Cache, 10Technical-Debt (Deprecation process): Deprecate wfGetMessageCacheStorage - https://phabricator.wikimedia.org/T243176 (10Krinkle) [18:43:46] (03CR) 10Aezell: [C: 03+1] "recheck" [core] - 10https://gerrit.wikimedia.org/r/572299 (owner: 10Tchanders) [18:43:48] 10MediaWiki-General, 10Technical-Debt (Deprecation process): Deprecate and remove $messageMemc - https://phabricator.wikimedia.org/T243175 (10Krinkle) [18:44:07] 10MediaWiki-Cache, 10Technical-Debt (Deprecation process): Deprecate wfGetMessageCacheStorage - https://phabricator.wikimedia.org/T243176 (10Krinkle) [18:44:12] 10CheckUser, 10Anti-Harassment (The Letter Song), 10Patch-For-Review: Prevent browser autocomplete in the UsersMultiselectWidget in Special:Investigate - https://phabricator.wikimedia.org/T245271 (10Niharika) [18:44:31] 10CheckUser, 10Anti-Harassment (The Letter Song), 10Patch-For-Review: Prevent browser autocomplete in the UsersMultiselectWidget in Special:Investigate - https://phabricator.wikimedia.org/T245271 (10Niharika) @Tchanders Should we move this to Done? [18:44:48] (03CR) 10Jforrester: [C: 03+2] Don't pass 'ip' through to logging [core] - 10https://gerrit.wikimedia.org/r/572287 (https://phabricator.wikimedia.org/T245280) (owner: 10Reedy) [18:45:56] (03CR) 10Aezell: [C: 03+2] TablePager: Improve documentation for getDefaultSort [core] - 10https://gerrit.wikimedia.org/r/572299 (owner: 10Tchanders) [18:46:06] (03CR) 10Jdlrobson: [C: 03+2] No longer emit alternate link with android-app scheme. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/571560 (https://phabricator.wikimedia.org/T244614) (owner: 10Dbrant) [18:46:11] 10MediaWiki-Cache, 10Technical-Debt (Deprecation process): Deprecate wfGetMessageCacheStorage - https://phabricator.wikimedia.org/T243176 (10Krinkle) It was only recently moved to ServiceWiring. The function should be considered "internal" in my opinion and should have been removed as part of 752e7dd707a9. Fe... [18:46:18] 10MediaWiki-Cache, 10Technical-Debt (Deprecation process): Remove wfGetMessageCacheStorage - https://phabricator.wikimedia.org/T243176 (10Krinkle) [18:46:24] 10MediaWiki-Cache, 10Technical-Debt (Deprecation process): Remove wfGetMessageCacheStorage - https://phabricator.wikimedia.org/T243176 (10Krinkle) [18:46:26] 10MediaWiki-General, 10Technical-Debt (Deprecation process): Deprecate and remove $messageMemc - https://phabricator.wikimedia.org/T243175 (10Krinkle) [18:47:06] 10CheckUser, 10Anti-Harassment (The Letter Song), 10Patch-For-Review: Prevent browser autocomplete in the UsersMultiselectWidget in Special:Investigate - https://phabricator.wikimedia.org/T245271 (10Tchanders) @Niharika Good idea. @dmaza and I have tested, I think that should be enough for such a small change [18:47:12] (03CR) 10Jforrester: [C: 03+1] Add missing release note for I59fb647483 (031 comment) [libs/Assert] - 10https://gerrit.wikimedia.org/r/572130 (owner: 10Gergő Tisza) [18:47:27] 10CheckUser, 10Anti-Harassment (The Letter Song), 10Patch-For-Review: Prevent browser autocomplete in the UsersMultiselectWidget in Special:Investigate - https://phabricator.wikimedia.org/T245271 (10Tchanders) 05Open→03Resolved a:03Tchanders [18:47:37] 10MediaWiki-API, 10MediaWiki-User-management, 10Core Platform Team Workboards (Clinic Duty Team), 10Technical-Debt, 10User-DannyS712: Replace $wgUser in core Api modules - https://phabricator.wikimedia.org/T241557 (10Krinkle) [18:48:04] 10MediaWiki-API, 10MediaWiki-User-management, 10Core Platform Team Workboards (Clinic Duty Team), 10Technical-Debt, 10User-DannyS712: Replace $wgUser in core Api modules - https://phabricator.wikimedia.org/T241557 (10Krinkle) This task is not tracking the deprecation process of wgUser. It is tracking mig... [18:49:37] (03CR) 10Jforrester: [C: 03+2] Remove Scrutinizer CI shield from readme page (031 comment) [libs/Assert] - 10https://gerrit.wikimedia.org/r/572133 (owner: 10Gergő Tisza) [18:51:02] (03PS1) 10Jforrester: Follow-up ffd94fa889: README.md: Drop Travis badge [libs/Assert] - 10https://gerrit.wikimedia.org/r/572303 [18:51:04] 10CheckUser, 10Anti-Harassment (The Letter Song), 10Patch-For-Review: CU 2.0: Pagination in the compare tab - https://phabricator.wikimedia.org/T238808 (10Tchanders) @Niharika The default limit is decided by user preferences in Special:Preferences > Recent changes. We could override that default - is the 100... [18:51:18] (03PS1) 10MarcoAurelio: Add .gitreview [extensions/S5SlideShow] - 10https://gerrit.wikimedia.org/r/572304 [18:51:53] (03PS2) 10MarcoAurelio: Add .gitreview [extensions/S5SlideShow] - 10https://gerrit.wikimedia.org/r/572304 [18:51:55] (03CR) 10Jforrester: "This should be two patches (one badging the date, the other adding 0.5.1) so that the git tag can point at an "intact" version of the repo" [libs/Assert] - 10https://gerrit.wikimedia.org/r/572132 (owner: 10Gergő Tisza) [18:51:57] (03PS2) 10Jdlrobson: Ensure hover state is only available on active elements [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/571854 (owner: 10VolkerE) [18:52:05] (03CR) 10MarcoAurelio: [V: 03+2 C: 03+2] Add .gitreview [extensions/S5SlideShow] - 10https://gerrit.wikimedia.org/r/572304 (owner: 10MarcoAurelio) [18:54:14] (03PS1) 10VolkerE: [WIP] Unify SVGO rules to Wikimedia coding conventions [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/572305 [18:54:16] (03CR) 10Krinkle: Move UIDGenerator code to a service and put it under /libs (033 comments) [core] - 10https://gerrit.wikimedia.org/r/513708 (owner: 10Aaron Schulz) [18:54:52] (03CR) 10jerkins-bot: [V: 04-1] Icons in skins.minerva.mainMenu.icons come from OOUI [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/570769 (https://phabricator.wikimedia.org/T244444) (owner: 10Jdlrobson) [18:55:59] 10Design, 10MinervaNeue, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): Spacing between icons and labels is too large in tablet mode - https://phabricator.wikimedia.org/T237019 (10Volker_E) @alexhollender It's now available for you to test o... [18:56:02] (03PS2) 10Jforrester: Add missing release note for I59fb647483 [libs/Assert] - 10https://gerrit.wikimedia.org/r/572130 (owner: 10Gergő Tisza) [18:56:04] (03PS3) 10Jforrester: Allow arrays for type lists for parameterElementType [libs/Assert] - 10https://gerrit.wikimedia.org/r/572131 (owner: 10Gergő Tisza) [18:56:06] (03PS3) 10Jforrester: README.md: Remove Scrutinizer CI shield [libs/Assert] - 10https://gerrit.wikimedia.org/r/572133 (owner: 10Gergő Tisza) [18:56:08] (03PS2) 10Jforrester: Follow-up ffd94fa889: README.md: Drop Travis badge [libs/Assert] - 10https://gerrit.wikimedia.org/r/572303 [18:56:10] (03PS3) 10Jforrester: Release v0.5.0 [libs/Assert] - 10https://gerrit.wikimedia.org/r/572132 (owner: 10Gergő Tisza) [18:56:12] (03PS1) 10Jforrester: Start v0.5.1 [libs/Assert] - 10https://gerrit.wikimedia.org/r/572306 [18:56:17] (03CR) 10Jforrester: [C: 03+2] Add missing release note for I59fb647483 [libs/Assert] - 10https://gerrit.wikimedia.org/r/572130 (owner: 10Gergő Tisza) [18:56:50] (03Merged) 10jenkins-bot: Add missing release note for I59fb647483 [libs/Assert] - 10https://gerrit.wikimedia.org/r/572130 (owner: 10Gergő Tisza) [18:57:06] (03CR) 10Jforrester: [C: 03+1] Allow arrays for type lists for parameterElementType [libs/Assert] - 10https://gerrit.wikimedia.org/r/572131 (owner: 10Gergő Tisza) [18:57:10] (03CR) 10Jforrester: [C: 03+2] README.md: Remove Scrutinizer CI shield [libs/Assert] - 10https://gerrit.wikimedia.org/r/572133 (owner: 10Gergő Tisza) [18:57:14] (03CR) 10Jforrester: [C: 03+2] Release v0.5.0 [libs/Assert] - 10https://gerrit.wikimedia.org/r/572132 (owner: 10Gergő Tisza) [18:57:27] (03CR) 10Jforrester: [C: 03+2] Don't use 'host' as a log parameter [core] - 10https://gerrit.wikimedia.org/r/572291 (https://phabricator.wikimedia.org/T245280) (owner: 10Reedy) [18:57:57] (03CR) 10Jforrester: [C: 03+2] Don't pass 'ip' through to logging [core] - 10https://gerrit.wikimedia.org/r/572290 (https://phabricator.wikimedia.org/T245280) (owner: 10Reedy) [18:58:03] 10MediaWiki-extensions-Other: S5SlideShow extension does not work anymore with Mediawiki 1.33+ - https://phabricator.wikimedia.org/T241706 (10MarcoAurelio) Repo created and imported as requested. If you intend to use Phabricator for bug tracking, I'll be more than happy to create a project for S5SlideShow. Thanks. [18:58:30] (03PS7) 10Jdlrobson: Icons in skins.minerva.mainMenu.icons come from OOUI [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/570769 (https://phabricator.wikimedia.org/T244444) [18:58:42] (03CR) 10Jdlrobson: "New OOUI release has now happened." [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/570769 (https://phabricator.wikimedia.org/T244444) (owner: 10Jdlrobson) [18:59:02] 10CheckUser, 10Anti-Harassment (The Letter Song), 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04): CU 2.0: Fetch information to be displayed in Compare tab - https://phabricator.wikimedia.org/T238714 (10Tchanders) @dom_walden This can be tested with T238808 and T238782 [18:59:33] 10QuickSurveys: Don't lazily load messages - https://phabricator.wikimedia.org/T245292 (10phuedx) [19:00:20] (03Merged) 10jenkins-bot: Don't pass 'ip' through to logging [core] - 10https://gerrit.wikimedia.org/r/572287 (https://phabricator.wikimedia.org/T245280) (owner: 10Reedy) [19:02:39] (03Merged) 10jenkins-bot: No longer emit alternate link with android-app scheme. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/571560 (https://phabricator.wikimedia.org/T244614) (owner: 10Dbrant) [19:04:04] (03PS8) 10Jdlrobson: Deprecate wgMinervaCustomLogos in favor of $wgLogos [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/551670 (https://phabricator.wikimedia.org/T232140) [19:04:16] 10MediaWiki-General, 10Technical-Debt: Remove $wgAllowImageMoving - https://phabricator.wikimedia.org/T245293 (10Bugreporter) [19:04:53] (03CR) 10VolkerE: [C: 04-1] "Wrong task is linked from the patch. This patch has no connection to standard naming convention." [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/570174 (https://phabricator.wikimedia.org/T245136) (owner: 10Aron Manning) [19:04:54] 10MediaWiki-Interface, 10Desktop Improvements, 10Core Platform Team Workboards (Clinic Duty Team), 10Logos, and 3 others: Separate out logo handling into square image logos and long text/wordmark banner logos - https://phabricator.wikimedia.org/T232140 (10Jdlrobson) >>! In T232140#5873587, @phuedx wrote: >... [19:06:14] (03CR) 10VolkerE: [C: 04-1] Css cleanup: merge font-size: 127%; with font-size: x-small; -> font-size: 0.79375em; (031 comment) [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/570174 (https://phabricator.wikimedia.org/T245136) (owner: 10Aron Manning) [19:06:29] 10CheckUser, 10Anti-Harassment (The Letter Song), 10Patch-For-Review: Add links to preliminary check results table - https://phabricator.wikimedia.org/T243631 (10Tchanders) > |Wiki|Wiki's name in canonical form|On-wiki user page (red or blue link depending on page existence)| Have been discussing this with... [19:06:43] (03CR) 10Jdlrobson: [C: 03+1] "thanks James!" [core] (wmf/1.35.0-wmf.19) - 10https://gerrit.wikimedia.org/r/572064 (https://phabricator.wikimedia.org/T245182) (owner: 10Jforrester) [19:07:52] (03CR) 10Jforrester: "> Patch Set 1: Code-Review+1" [core] (wmf/1.35.0-wmf.19) - 10https://gerrit.wikimedia.org/r/572064 (https://phabricator.wikimedia.org/T245182) (owner: 10Jforrester) [19:07:54] (03PS1) 10MarcoAurelio: [S5SlideShow] Register extension [extensions] - 10https://gerrit.wikimedia.org/r/572307 [19:08:05] (03CR) 10Clarakosi: "Linting error ... In the command line you can type: `node_modules/.bin/eslint --fix test/PageProtection.js` to fix errors on that page" [tools/api-testing] - 10https://gerrit.wikimedia.org/r/572257 (owner: 10Esther Akinloose) [19:08:19] (03CR) 10MarcoAurelio: [V: 03+2 C: 03+2] [S5SlideShow] Register extension [extensions] - 10https://gerrit.wikimedia.org/r/572307 (owner: 10MarcoAurelio) [19:08:41] (03PS1) 10Jdlrobson: Correctly use wfDeprecated function signature for wgLogoHD [core] - 10https://gerrit.wikimedia.org/r/572308 (https://phabricator.wikimedia.org/T232140) [19:10:17] 10MediaWiki-General, 10Technical-Debt, 10User-DannyS712: Remove $wgAllowImageMoving - https://phabricator.wikimedia.org/T245293 (10DannyS712) p:05Triage→03Low a:03DannyS712 Probably needs to be deprecated first: * 1.35: Add hard deprecation for setting to false * 1.36: Remove entirely [19:10:21] 10MobileFrontend, 10Android-app-Bugs, 10Readers-Web-Backlog, 10Wikipedia-Android-App-Backlog, 10SEO: Investigate and fix tags in page source - https://phabricator.wikimedia.org/T244614 (10Jdlrobson) For history this was added here: https://github.com/wikimedia/mediawiki-extensions... [19:11:09] (03PS4) 10Krinkle: Allow arrays for type lists for parameterElementType [libs/Assert] - 10https://gerrit.wikimedia.org/r/572131 (owner: 10Gergő Tisza) [19:12:01] (03PS1) 10Mainframe98: Remove wfGetMessageCacheStorage [core] - 10https://gerrit.wikimedia.org/r/572309 (https://phabricator.wikimedia.org/T243176) [19:12:13] (03Merged) 10jenkins-bot: Don't use 'host' as a log parameter [core] - 10https://gerrit.wikimedia.org/r/572291 (https://phabricator.wikimedia.org/T245280) (owner: 10Reedy) [19:12:42] (03Merged) 10jenkins-bot: Don't pass 'ip' through to logging [core] - 10https://gerrit.wikimedia.org/r/572290 (https://phabricator.wikimedia.org/T245280) (owner: 10Reedy) [19:13:47] (03CR) 10DannyS712: [C: 03+1] "Looks fine" [core] - 10https://gerrit.wikimedia.org/r/572308 (https://phabricator.wikimedia.org/T232140) (owner: 10Jdlrobson) [19:14:35] (03CR) 10jerkins-bot: [V: 04-1] Icons in skins.minerva.mainMenu.icons come from OOUI [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/570769 (https://phabricator.wikimedia.org/T244444) (owner: 10Jdlrobson) [19:15:07] (03CR) 10Jforrester: [C: 03+1] Allow arrays for type lists for parameterElementType [libs/Assert] - 10https://gerrit.wikimedia.org/r/572131 (owner: 10Gergő Tisza) [19:15:32] 10MediaWiki-Cache, 10Patch-For-Review, 10Technical-Debt (Deprecation process): Remove wfGetMessageCacheStorage - https://phabricator.wikimedia.org/T243176 (10Mainframe98) a:03Mainframe98 [19:15:45] 10MinervaNeue, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q3), 10Regression: [Regression, Production] user contributions icon missing on AMC mode - https://phabricator.wikimedia.org/T244436 (10Jdlrobson) [19:17:19] 10MinervaNeue, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q3), 10Regression: [Regression, Production] user contributions icon missing on AMC mode - https://phabricator.wikimedia.org/T244436 (10Jdlrobson) [19:17:31] (03CR) 10jerkins-bot: [V: 04-1] Deprecate wgMinervaCustomLogos in favor of $wgLogos [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/551670 (https://phabricator.wikimedia.org/T232140) (owner: 10Jdlrobson) [19:17:40] 10MinervaNeue, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), 10Readers-Web-Backlog (Kanbanana-2019-20-Q3), 10Regression: [Regression, Production] user contributions icon missing on AMC mode - https://phabricator.wikimedia.org/T244436 (10Jdlrobson) >>! In T244436#5880170, @phuedx wrote: > I recommended that... [19:19:06] (03CR) 10Krinkle: [C: 03+2] Allow arrays for type lists for parameterElementType [libs/Assert] - 10https://gerrit.wikimedia.org/r/572131 (owner: 10Gergő Tisza) [19:19:15] (03PS4) 10Krinkle: README.md: Remove Scrutinizer CI shield [libs/Assert] - 10https://gerrit.wikimedia.org/r/572133 (owner: 10Gergő Tisza) [19:19:23] (03PS3) 10Krinkle: Follow-up ffd94fa889: README.md: Drop Travis badge [libs/Assert] - 10https://gerrit.wikimedia.org/r/572303 (owner: 10Jforrester) [19:19:31] (03Merged) 10jenkins-bot: Allow arrays for type lists for parameterElementType [libs/Assert] - 10https://gerrit.wikimedia.org/r/572131 (owner: 10Gergő Tisza) [19:21:44] (03CR) 10Ppchelko: REST endpoint for executing jobs (032 comments) [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/571816 (https://phabricator.wikimedia.org/T244826) (owner: 10Clarakosi) [19:21:51] (03CR) 10Krinkle: [C: 03+2] Follow-up ffd94fa889: README.md: Drop Travis badge [libs/Assert] - 10https://gerrit.wikimedia.org/r/572303 (owner: 10Jforrester) [19:22:01] (03PS4) 10Krinkle: Release v0.5.0 [libs/Assert] - 10https://gerrit.wikimedia.org/r/572132 (owner: 10Gergő Tisza) [19:22:03] 10Accessibility, 10VisualEditor, 10Patch-For-Review: Internal and External Link annotation widget - https://phabricator.wikimedia.org/T245294 (10Akinwale-microsoft) [19:22:14] (03PS2) 10Clarakosi: Add Content-Type to Headers [core] - 10https://gerrit.wikimedia.org/r/571512 [19:22:28] (03CR) 10DannyS712: Move UIDGenerator code to a service and put it under /libs (035 comments) [core] - 10https://gerrit.wikimedia.org/r/513708 (owner: 10Aaron Schulz) [19:22:42] (03CR) 10Krinkle: [C: 03+2] Release v0.5.0 [libs/Assert] - 10https://gerrit.wikimedia.org/r/572132 (owner: 10Gergő Tisza) [19:22:48] (03Abandoned) 10Tpt: Revert "Rtrim input text" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572286 (https://phabricator.wikimedia.org/T245154) (owner: 10Tpt) [19:22:58] (03CR) 10jerkins-bot: [V: 04-1] Correctly use wfDeprecated function signature for wgLogoHD [core] - 10https://gerrit.wikimedia.org/r/572308 (https://phabricator.wikimedia.org/T232140) (owner: 10Jdlrobson) [19:23:11] (03CR) 10Krinkle: Move UIDGenerator code to a service and put it under /libs (033 comments) [core] - 10https://gerrit.wikimedia.org/r/513708 (owner: 10Aaron Schulz) [19:23:15] (03Merged) 10jenkins-bot: Release v0.5.0 [libs/Assert] - 10https://gerrit.wikimedia.org/r/572132 (owner: 10Gergő Tisza) [19:23:33] (03CR) 10Krinkle: Move UIDGenerator code to a service and put it under /libs (031 comment) [core] - 10https://gerrit.wikimedia.org/r/513708 (owner: 10Aaron Schulz) [19:23:40] 10Password-Reset-Update, 10Community-Tech (Kanban-Q3-2019-20), 10MW-1.35-notes (1.35.0-wmf.19; 2020-02-11): PRU: Improve Security & Standardize Experience for Password Reset [medium] - https://phabricator.wikimedia.org/T238961 (10ifried) Hello @dom_walden and @Samwilson There seems to be some confusion (and... [19:24:59] (03PS8) 10Jdlrobson: Icons in skins.minerva.mainMenu.icons come from OOUI [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/570769 (https://phabricator.wikimedia.org/T244444) [19:25:02] (03CR) 10DannyS712: [C: 03+1] "> Main test build failed." [core] - 10https://gerrit.wikimedia.org/r/572308 (https://phabricator.wikimedia.org/T232140) (owner: 10Jdlrobson) [19:25:32] (03PS9) 10Jdlrobson: Deprecate wgMinervaCustomLogos in favor of $wgLogos [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/551670 (https://phabricator.wikimedia.org/T232140) [19:26:01] (03PS2) 10Jdlrobson: Correctly use wfDeprecated function signature for wgLogoHD [core] - 10https://gerrit.wikimedia.org/r/572308 (https://phabricator.wikimedia.org/T232140) [19:28:54] (03CR) 10Krinkle: REST endpoint for executing jobs (031 comment) [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/571816 (https://phabricator.wikimedia.org/T244826) (owner: 10Clarakosi) [19:30:47] 10Developer-Advocacy (Jan-Mar 2020): Decide which GCI 2019 mentor to attend GCI Grand Prize winners weekend in June 2020 (before 2020-02-21) - https://phabricator.wikimedia.org/T241927 (10Ebe123) They'll (GCI) will send an email to the org admins next week with the dates //etc.// [19:30:57] (03PS2) 10Jforrester: Start v0.5.1 [libs/Assert] - 10https://gerrit.wikimedia.org/r/572306 [19:31:12] (03CR) 10VolkerE: Icons in skins.minerva.mainMenu.icons come from OOUI (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/570769 (https://phabricator.wikimedia.org/T244444) (owner: 10Jdlrobson) [19:31:44] (03CR) 10Krinkle: REST endpoint for executing jobs (031 comment) [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/571816 (https://phabricator.wikimedia.org/T244826) (owner: 10Clarakosi) [19:32:48] 10MediaWiki-Logging, 10Wikimedia-production-error: A malformed(?) production error corrupted the error channels, with the message field being over-written with `class@anonymous` - https://phabricator.wikimedia.org/T245295 (10Jdforrester-WMF) [19:35:32] (03PS9) 10Jdlrobson: Icons in skins.minerva.mainMenu.icons come from OOUI [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/570769 (https://phabricator.wikimedia.org/T244444) [19:36:11] (03CR) 10Jforrester: "Tagged." [libs/Assert] - 10https://gerrit.wikimedia.org/r/572132 (owner: 10Gergő Tisza) [19:36:14] (03CR) 10Jforrester: [C: 03+2] Start v0.5.1 [libs/Assert] - 10https://gerrit.wikimedia.org/r/572306 (owner: 10Jforrester) [19:36:38] (03Merged) 10jenkins-bot: Start v0.5.1 [libs/Assert] - 10https://gerrit.wikimedia.org/r/572306 (owner: 10Jforrester) [19:37:13] (03CR) 10Jdlrobson: [C: 03+2] mobile.init/editor: Fix reporting of loading errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/571806 (owner: 10Bartosz Dziewoński) [19:38:10] (03CR) 10Thiemo Kreuz (WMDE): build: Updating composer dependencies (032 comments) [extensions/cldr] - 10https://gerrit.wikimedia.org/r/569008 (owner: 10Libraryupgrader) [19:38:23] 10MinervaNeue (Tracking), 10Reading-Web-Local-Wiki-Issues: Presence of .mbox-small forces content to start after it - https://phabricator.wikimedia.org/T244848 (10Jdlrobson) Can a wrapping container be used? e.g. `
... ` [19:38:31] (03PS5) 10MarcoAurelio: [WIP] Convert UploadBlacklist to use extension registration [extensions/UploadBlacklist] - 10https://gerrit.wikimedia.org/r/571068 [19:38:54] (03CR) 10Ppchelko: REST endpoint for executing jobs (0312 comments) [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/571816 (https://phabricator.wikimedia.org/T244826) (owner: 10Clarakosi) [19:39:07] (03CR) 10DannyS712: ChangeTags: Use dropdown menu for selecting tags (0318 comments) [core] - 10https://gerrit.wikimedia.org/r/211497 (https://phabricator.wikimedia.org/T27909) (owner: 10Cenarium) [19:40:31] 10MediaWiki-ResourceLoader, 10UI-Standardization, 10Front-end-Standards-Group, 10MinervaNeue, and 8 others: Ordered lists per default receive `decimal` list style type, which causes issues in non-arabic numeral scripts - https://phabricator.wikimedia.org/T217616 (10Jdlrobson) @ladsgroup any chance you coul... [19:40:45] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Convert UploadBlacklist to use extension registration [extensions/UploadBlacklist] - 10https://gerrit.wikimedia.org/r/571068 (owner: 10MarcoAurelio) [19:43:27] (03CR) 10MarcoAurelio: "recheck" [extensions/UploadBlacklist] - 10https://gerrit.wikimedia.org/r/571068 (owner: 10MarcoAurelio) [19:45:35] (03CR) 10Jdlrobson: [C: 03+1] "this looks fine to me although I'm not 100% sure if there is any situation where del or ins could be outside those 3 elements." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/571572 (https://phabricator.wikimedia.org/T244673) (owner: 10Bartosz Dziewoński) [19:45:46] 10MediaWiki-Configuration, 10Parsoid, 10TimedMediaHandler, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07): TestAutoloadClasses in extension.json is not taking effect during Parsoid parser tests CI - https://phabricator.wikimedia.org/T241964 (10Arlolra) 05Open→03Resolved a:03Arlolra [19:45:55] 10MediaWiki-Configuration, 10Parsoid, 10TimedMediaHandler, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07): TestAutoloadClasses in extension.json is not taking effect during Parsoid parser tests CI - https://phabricator.wikimedia.org/T241964 (10Arlolra) a:05Arlolra→03Legoktm [19:47:03] (03CR) 10Ppchelko: Add Content-Type to Headers (031 comment) [core] - 10https://gerrit.wikimedia.org/r/571512 (owner: 10Clarakosi) [19:47:19] 10Design, 10MobileFrontend, 10VisualEditor: Consider adding a button to let users edit the whole page in MobileFrontend - https://phabricator.wikimedia.org/T203151 (10Jdlrobson) [19:48:31] (03CR) 10Jdlrobson: [C: 03+2] mobile.init/editor: Show detailed loading error if available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/571807 (owner: 10Bartosz Dziewoński) [19:49:45] (03CR) 10Jdlrobson: [C: 03+1] "Note mobile view API is deprecated and I don't think widely used within the WMF so performance team should feel free to merge when you are" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/570780 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [19:50:18] (03PS6) 10MarcoAurelio: Convert UploadBlacklist to use extension registration [extensions/UploadBlacklist] - 10https://gerrit.wikimedia.org/r/571068 (https://phabricator.wikimedia.org/T211483) [19:50:27] (03CR) 10Jdlrobson: [C: 03+1] Convert $wgMemc use to WANObjectCache (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/570780 (https://phabricator.wikimedia.org/T160813) (owner: 10Aaron Schulz) [19:50:45] (03PS7) 10Jforrester: [WIP] Convert UploadBlacklist to use extension registration [extensions/UploadBlacklist] - 10https://gerrit.wikimedia.org/r/571068 (owner: 10MarcoAurelio) [19:50:52] (03Merged) 10jenkins-bot: mobile.init/editor: Fix reporting of loading errors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/571806 (owner: 10Bartosz Dziewoński) [19:51:39] 10MediaWiki-Logging, 10Wikimedia-production-error: A malformed(?) production error corrupted the error channels, with the message field being over-written with `class@anonymous` - https://phabricator.wikimedia.org/T245295 (10Krinkle) Source: 10MediaWiki-Debug-Logger, 10Wikimedia-production-error: A malformed(?) production error corrupted the error channels, with the message field being over-written with `class@anonymous` - https://phabricator.wikimedia.org/T245295 (10Krinkle) [19:52:01] (03PS8) 10MarcoAurelio: Convert UploadBlacklist to use extension registration [extensions/UploadBlacklist] - 10https://gerrit.wikimedia.org/r/571068 (https://phabricator.wikimedia.org/T211483) [19:52:31] (03CR) 10DannyS712: Remove usages of deprecated Language methods (037 comments) [core] - 10https://gerrit.wikimedia.org/r/561921 (owner: 10Ppchelko) [19:52:51] 10MobileFrontend (MobileFrontend and MinervaNeue architecture): Unify SVG optimization to Wikimedia coding conventions - https://phabricator.wikimedia.org/T245296 (10Volker_E) [19:53:19] (03CR) 10Ppchelko: Add Content-Type to Headers (031 comment) [core] - 10https://gerrit.wikimedia.org/r/571512 (owner: 10Clarakosi) [19:53:51] 10Wikimedia-Rdbms: Get rid of the Uncommitted DB writes notice - https://phabricator.wikimedia.org/T85762 (10Krinkle) 05Stalled→03Declined [19:53:56] (03CR) 10jerkins-bot: [V: 04-1] Convert UploadBlacklist to use extension registration [extensions/UploadBlacklist] - 10https://gerrit.wikimedia.org/r/571068 (https://phabricator.wikimedia.org/T211483) (owner: 10MarcoAurelio) [19:54:21] (03CR) 10Jdlrobson: [C: 04-1] "The content element is intentionally disabled as the diff is meant to line horizontally with the title." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/571573 (https://phabricator.wikimedia.org/T244673) (owner: 10Bartosz Dziewoński) [19:54:48] (03CR) 10Jdlrobson: [C: 03+1] "pending Alex" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/565272 (https://phabricator.wikimedia.org/T237019) (owner: 10Esanders) [19:55:48] (03PS9) 10DannyS712: Convert UploadBlacklist to use extension registration [extensions/UploadBlacklist] - 10https://gerrit.wikimedia.org/r/571068 (https://phabricator.wikimedia.org/T211483) (owner: 10MarcoAurelio) [19:56:11] (03PS2) 10VolkerE: Unify SVGO rules to Wikimedia coding conventions and re-crush SVGs [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/572305 (https://phabricator.wikimedia.org/T245296) [19:57:40] (03CR) 10jerkins-bot: [V: 04-1] Convert UploadBlacklist to use extension registration [extensions/UploadBlacklist] - 10https://gerrit.wikimedia.org/r/571068 (https://phabricator.wikimedia.org/T211483) (owner: 10MarcoAurelio) [19:57:47] (03PS10) 10MarcoAurelio: Convert UploadBlacklist to use extension registration [extensions/UploadBlacklist] - 10https://gerrit.wikimedia.org/r/571068 (https://phabricator.wikimedia.org/T211483) [19:59:44] (03CR) 10jerkins-bot: [V: 04-1] Convert UploadBlacklist to use extension registration [extensions/UploadBlacklist] - 10https://gerrit.wikimedia.org/r/571068 (https://phabricator.wikimedia.org/T211483) (owner: 10MarcoAurelio) [20:01:44] (03Merged) 10jenkins-bot: mobile.init/editor: Show detailed loading error if available [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/571807 (owner: 10Bartosz Dziewoński) [20:02:09] 10MediaWiki-extensions-PropertySuggester, 10Structured Data Engineering, 10Wikidata, 10Structured-Data-Backlog (Current Work): Prefer relevant unit suggestions over other entities - https://phabricator.wikimedia.org/T244856 (10Multichill) F31552245 is a nice mock up. When adding a unit, we want to have s... [20:02:51] (03PS11) 10MarcoAurelio: Convert UploadBlacklist to use extension registration [extensions/UploadBlacklist] - 10https://gerrit.wikimedia.org/r/571068 (https://phabricator.wikimedia.org/T211483) [20:03:44] 10MediaWiki-API, 10MediaWiki-Authentication-and-authorization, 10Core Platform Team Workboards (Clinic Duty Team), 10Regression: API readapidenied with private wiki on v1.34 - https://phabricator.wikimedia.org/T245149 (10Anomie) Thanks for posting the code. I've confirmed the bug; seems to be a regression... [20:04:14] 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Technical-Debt: Unify SVG optimization to Wikimedia coding conventions - https://phabricator.wikimedia.org/T245296 (10Volker_E) [20:06:21] (03PS1) 10VolkerE: Unify SVGO rules to Wikimedia coding conventions and re-crush SVGs [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/572317 (https://phabricator.wikimedia.org/T245296) [20:06:54] (03PS1) 10Jdlrobson: [Dev] Remove renderNavigation function for readability [skins/Vector] - 10https://gerrit.wikimedia.org/r/572318 [20:07:21] (03CR) 10DannyS712: Alter `revision` for actor, comment, and MCR (036 comments) [core] - 10https://gerrit.wikimedia.org/r/552339 (https://phabricator.wikimedia.org/T161671) (owner: 10Anomie) [20:07:35] 10DannyS712-Global_watchlist.js: Make empty lists list collapsible and collapsed - https://phabricator.wikimedia.org/T245298 (10IKhitron) a:03DannyS712 [20:10:27] 10CheckUser, 10Anti-Harassment (The Letter Song), 10Patch-For-Review: Add links to preliminary check results table - https://phabricator.wikimedia.org/T243631 (10Niharika) >>! In T243631#5885686, @Tchanders wrote: >> |Wiki|Wiki's name in canonical form|On-wiki user page (red or blue link depending on page ex... [20:11:04] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Personally, I clearly prefer the shorter, more specialized assertions PHPUnit provides. I feel the test is a little bit easier to read whe" [core] - 10https://gerrit.wikimedia.org/r/571831 (owner: 10D3r1ck01) [20:11:13] 10CheckUser, 10Anti-Harassment (The Letter Song), 10Patch-For-Review: Add links to preliminary check results table - https://phabricator.wikimedia.org/T243631 (10Niharika) [20:11:33] 10CheckUser, 10Anti-Harassment (The Letter Song), 10Patch-For-Review: Add links to preliminary check results table - https://phabricator.wikimedia.org/T243631 (10Niharika) [20:12:46] (03CR) 10Dmaza: Add links to Special:Investigate preliminary check results table (032 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/570471 (https://phabricator.wikimedia.org/T243631) (owner: 10Tchanders) [20:14:53] (03CR) 10VolkerE: "Would be interested if there was historically a reason for doing it that way." [skins/Vector] - 10https://gerrit.wikimedia.org/r/572318 (owner: 10Jdlrobson) [20:16:52] 10DannyS712-Global_watchlist.js: Move the settings from global.js to personal json page. - https://phabricator.wikimedia.org/T245300 (10IKhitron) a:03DannyS712 [20:18:11] (03PS1) 10Thiemo Kreuz (WMDE): Remove lines from PHPDoc comments that aren't helpful [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572320 [20:19:27] 10MediaWiki-extensions-FlaggedRevs, 10Patch-For-Review, 10User-DannyS712: FlaggedRevs uses hard deprecated ArticleEditUpdates hook - https://phabricator.wikimedia.org/T245175 (10Jdforrester-WMF) p:05Triage→03Low [20:19:30] (03CR) 10jerkins-bot: [V: 04-1] Remove lines from PHPDoc comments that aren't helpful [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572320 (owner: 10Thiemo Kreuz (WMDE)) [20:19:48] (03PS33) 10Krinkle: objectcache: dependency inject LoadBalancer into SqlBagOStuff [core] - 10https://gerrit.wikimedia.org/r/524655 (https://phabricator.wikimedia.org/T229062) (owner: 10Aaron Schulz) [20:19:53] 10MediaWiki-API, 10Core Platform Team, 10Wikimedia-production-error: PHP Notice: Array to string conversion from libs/StatusValue.php (via ApiClientLogin) - https://phabricator.wikimedia.org/T245155 (10Jdforrester-WMF) Presumably this is being caused when `$error['message']` isn't a `MessageSpecifier` but `$... [20:20:20] (03CR) 10jerkins-bot: [V: 04-1] [Dev] Remove renderNavigation function for readability [skins/Vector] - 10https://gerrit.wikimedia.org/r/572318 (owner: 10Jdlrobson) [20:21:48] 10Product-Analytics (Kanban): Contribute slides for BUOD stakeholder update - https://phabricator.wikimedia.org/T245301 (10Mayakp.wiki) [20:21:54] 10Product-Analytics (Kanban): Contribute slides for BUOD stakeholder update - https://phabricator.wikimedia.org/T245301 (10Mayakp.wiki) p:05Triage→03Medium [20:22:02] 10Product-Analytics (Kanban): Contribute slides for BUOD stakeholder update - https://phabricator.wikimedia.org/T245301 (10Mayakp.wiki) p:05Medium→03Low [20:22:42] (03PS1) 10Thiemo Kreuz (WMDE): Add some missing PHPDoc comments [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572321 [20:23:03] (03PS1) 10Jforrester: Follow-up 37a69a2f: ResourceLoaderSkinModule: Fix wfDeprecated() syntax [core] - 10https://gerrit.wikimedia.org/r/572322 [20:24:55] (03CR) 10VolkerE: "When are we then able to delete the old icons?" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/570769 (https://phabricator.wikimedia.org/T244444) (owner: 10Jdlrobson) [20:25:09] 10MediaWiki-Debug-Logger, 10Wikimedia-Rdbms: Query tab of $wgDebugToolbar is broken when $wgDebugLogFile is false - https://phabricator.wikimedia.org/T241516 (10Krinkle) `lang=php # $wgDebugLogFile = ''; (default) $wgDebugToolbar = true; $wgDebugDumpSql = true; ` Works for me so long as `$wgDebugDumpSql` is... [20:25:28] (03CR) 10VolkerE: "Sry, just saw the 2-3 weeks note" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/570769 (https://phabricator.wikimedia.org/T244444) (owner: 10Jdlrobson) [20:26:10] (03PS2) 10Jdlrobson: [Dev] Remove renderNavigation function for readability [skins/Vector] - 10https://gerrit.wikimedia.org/r/572318 [20:26:15] 10MediaWiki-Interface, 10MediaWiki-ResourceLoader, 10MW-1.35-notes (1.35.0-wmf.19; 2020-02-11), 10Readers-Web-Backlog (Kanbanana-2019-20-Q3), 10Wikimedia-production-error: Use of $wgLogoHD was deprecated in Rename configuration variable to $wgLogos - https://phabricator.wikimedia.org/T245182 (10Jdforreste... [20:26:22] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-Debug-Logger, 10MediaWiki-extensions-LoginNotify, 10Community-Tech, and 3 others: logstash_formatter_key_conflict in mediawiki logs - https://phabricator.wikimedia.org/T245280 (10Reedy) >>! In T245280#5885929, @Stashbot wrote: > {nav icon=file, name... [20:26:33] (03CR) 10Dmaza: [C: 03+1] Update preliminary check classes to use multi-column pagination [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572040 (https://phabricator.wikimedia.org/T244517) (owner: 10Tchanders) [20:27:40] (03CR) 10jerkins-bot: [V: 04-1] Add some missing PHPDoc comments [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572321 (owner: 10Thiemo Kreuz (WMDE)) [20:28:09] 10MediaWiki-HTMLForm: Wikitext not parsed in tooltip label - https://phabricator.wikimedia.org/T245237 (10matmarex) [20:28:55] (03CR) 10VolkerE: [C: 04-1] "logIn isn't visible locally for me…" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/570769 (https://phabricator.wikimedia.org/T244444) (owner: 10Jdlrobson) [20:30:21] (03CR) 10Aezell: Update preliminary check classes to use multi-column pagination (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572040 (https://phabricator.wikimedia.org/T244517) (owner: 10Tchanders) [20:30:23] (03PS1) 10Polishdeveloper: FeatureManagement in Vector [skins/Vector] - 10https://gerrit.wikimedia.org/r/572323 (https://phabricator.wikimedia.org/T244481) [20:30:52] (03CR) 10Aezell: [C: 03+1] Update preliminary check classes to use multi-column pagination [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572040 (https://phabricator.wikimedia.org/T244517) (owner: 10Tchanders) [20:31:32] (03CR) 10jerkins-bot: [V: 04-1] objectcache: dependency inject LoadBalancer into SqlBagOStuff [core] - 10https://gerrit.wikimedia.org/r/524655 (https://phabricator.wikimedia.org/T229062) (owner: 10Aaron Schulz) [20:31:40] (03PS1) 10Reedy: Don't use 'message' as a logging key [core] - 10https://gerrit.wikimedia.org/r/572324 (https://phabricator.wikimedia.org/T245280) [20:32:41] 10MediaWiki-Debug-Logger, 10Core Platform Team, 10Wikimedia-Rdbms: Query tab of $wgDebugToolbar is broken when $wgDebugLogFile is false - https://phabricator.wikimedia.org/T241516 (10Krinkle) Intro task for @holger.knust. [20:32:49] 10MediaWiki-HTMLForm: HTMLForm's checkmatrix control doesn't support parsed text in its jquery.tipsy tooltips - https://phabricator.wikimedia.org/T123994 (10matmarex) [20:32:51] 10MediaWiki-HTMLForm: Wikitext not parsed in tooltip label - https://phabricator.wikimedia.org/T245237 (10matmarex) [20:34:31] 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Technical-Debt: Unify SVG optimization to Wikimedia coding conventions - https://phabricator.wikimedia.org/T245296 (10Volker_E) When above MN patch is merged, it would be helpful to have @Edtadros look over the changed icon... [20:35:54] 10Design, 10TCB-Team, 10Two-Column-Edit-Conflict-Merge, 10WMDE-Design: Possibility to use both versions of a paragraph in two-col-conflict - https://phabricator.wikimedia.org/T213270 (10Dvorapa) >>! In T213270#5619401, @thiemowmde wrote: > This is mostly a duplicate of {T230231}, and can probably be closed... [20:35:56] (03PS10) 10Jdlrobson: Icons in skins.minerva.mainMenu.icons come from OOUI [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/570769 (https://phabricator.wikimedia.org/T244444) [20:36:28] (03CR) 10Jdlrobson: [C: 03+1] "This also works for me." [core] - 10https://gerrit.wikimedia.org/r/572322 (owner: 10Jforrester) [20:37:28] 10Timeless: Timeless footer links don’t wrap - https://phabricator.wikimedia.org/T245302 (10Tacsipacsi) [20:37:55] 10CirrusSearch, 10Discovery-Search: CirrusSearch logging logs with reserved parameter message - https://phabricator.wikimedia.org/T245303 (10Reedy) [20:37:55] (03PS7) 10Dmaza: Update preliminary check classes to use multi-column pagination [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572040 (https://phabricator.wikimedia.org/T244517) (owner: 10Tchanders) [20:38:11] 10CirrusSearch, 10Discovery-Search: CirrusSearch logging logs with reserved parameter message - https://phabricator.wikimedia.org/T245303 (10Reedy) [20:38:30] (03PS1) 10Jforrester: Relax wikimedia/assert dependency to allow upgrade to 0.5.0 [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/572325 [20:38:32] (03PS1) 10Jforrester: Increase wikimedia/assert dependency to 0.5.0 [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/572326 [20:40:08] (03CR) 10Dmaza: [C: 03+2] Update preliminary check classes to use multi-column pagination [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572040 (https://phabricator.wikimedia.org/T244517) (owner: 10Tchanders) [20:41:07] (03PS1) 10Jforrester: Relax wikimedia/assert dependency to allow upgrade to 0.5.0 [libs/LangConv] - 10https://gerrit.wikimedia.org/r/572328 [20:41:09] (03PS1) 10Jforrester: Increase wikimedia/assert dependency to 0.5.0 [libs/LangConv] - 10https://gerrit.wikimedia.org/r/572329 [20:42:02] (03CR) 10jerkins-bot: [V: 04-1] [Dev] Remove renderNavigation function for readability [skins/Vector] - 10https://gerrit.wikimedia.org/r/572318 (owner: 10Jdlrobson) [20:43:14] (03PS1) 10Anomie: API: Fix fetching login token from action=query&meta=tokens on private wikis [core] - 10https://gerrit.wikimedia.org/r/572332 (https://phabricator.wikimedia.org/T245149) [20:43:39] 10Phabricator, 10Security-Team, 10Security, 10Security Related: Update protect as security issue to use acl*security - https://phabricator.wikimedia.org/T245201 (10chasemp) >>! In T245201#5885238, @mmodell wrote: > @chasemp: The best way I can think of to make the transition easy (and ease future maintaina... [20:44:23] (03CR) 10Gergő Tisza: Follow-up 37a69a2f: ResourceLoaderSkinModule: Fix wfDeprecated() syntax (031 comment) [core] - 10https://gerrit.wikimedia.org/r/572322 (owner: 10Jforrester) [20:47:36] (03CR) 10Ppchelko: "A couple of nit picks inlined." (035 comments) [core] - 10https://gerrit.wikimedia.org/r/550708 (https://phabricator.wikimedia.org/T238224) (owner: 10Kosta Harlan) [20:48:22] (03PS1) 10Jdlrobson: POC: processTemplate used in one place [skins/Vector] - 10https://gerrit.wikimedia.org/r/572334 [20:49:42] (03PS2) 10Jdlrobson: POC: processTemplate used in one place [skins/Vector] - 10https://gerrit.wikimedia.org/r/572334 [20:50:12] (03PS2) 10Akinwale-microsoft: Fix: Filter by changes and days button accessibility Screen reader just announces x changes, y days, it doesn't announce the meaning of the button We added an aria-label property to the button to make it accessible to visually impaired audiences [core] - 10https://gerrit.wikimedia.org/r/570972 [20:50:14] (03PS1) 10Akinwale-microsoft: Fix: Add aria-label to Filter Tag in Special:RecentChanges This widget failed accessibility test using the accessibility insights tool see https://accessibilityinsights.io/ The options associated with this tool also need to have an aria-label attribute [core] - 10https://gerrit.wikimedia.org/r/572335 [20:50:16] (03PS1) 10Akinwale-microsoft: Fix: Add alt text to MediaResultWidget image [core] - 10https://gerrit.wikimedia.org/r/572336 [20:51:25] (03CR) 10Jdlrobson: "My understanding was that it was a useful transitional state as we ported over Vector to use templates however I feel now it is not so use" [skins/Vector] - 10https://gerrit.wikimedia.org/r/572318 (owner: 10Jdlrobson) [20:52:40] (03PS1) 10Thiemo Kreuz (WMDE): Remove reference to non-existing SearchEngine::$showRedirects [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572338 [20:53:01] 10MediaWiki-Cache: MemcachedPhpBagOStuff::incr() returns string instead of integer - https://phabricator.wikimedia.org/T105341 (10Krinkle) We currently use MemcachedPeclBagOStuff in production, which is unaffected. The bug is still reproducible though, as before, on `MemcachedPhpBagOStuff` which I believe Aaron... [20:53:06] (03PS3) 10Jdlrobson: [Dev] Remove renderNavigation function for readability [skins/Vector] - 10https://gerrit.wikimedia.org/r/572318 [20:53:18] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-Debug-Logger, 10MediaWiki-extensions-LoginNotify, 10Community-Tech, and 3 others: logstash_formatter_key_conflict in mediawiki logs - https://phabricator.wikimedia.org/T245280 (10Reedy) p:05Triage→03Medium This should be in a much better place n... [20:54:05] (03PS3) 10Jdlrobson: POC: processTemplate used in one place [skins/Vector] - 10https://gerrit.wikimedia.org/r/572334 [20:55:50] 10Core Platform Team, 10Wikimedia-production-error: PHP Notice: Array to string conversion from libs/StatusValue.php (via ApiClientLogin) - https://phabricator.wikimedia.org/T245155 (10Anomie) Bug is in StatusValue, it's assuming all message parameters are simple scalars and choking on something that's not (e.... [20:56:17] (03Merged) 10jenkins-bot: Update preliminary check classes to use multi-column pagination [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572040 (https://phabricator.wikimedia.org/T244517) (owner: 10Tchanders) [20:56:26] (03PS1) 10Thiemo Kreuz (WMDE): Unset dynamic property on Parser when not needed any more [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572340 [20:57:22] 10Desktop Improvements, 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): Build opt-out button for logged-in users with new vector on - https://phabricator.wikimedia.org/T243281 (10Jdlrobson) >>! In T243281#5877508, @Niedzielski wrote: > This needs discussion on approach with @jdlrobson and the other devs. Yes pl... [20:58:37] (03PS1) 10Anomie: StatusValue: Fix __toString() to not choke on special parameters [core] - 10https://gerrit.wikimedia.org/r/572342 (https://phabricator.wikimedia.org/T245155) [20:59:10] 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review, 10Wikimedia-production-error: PHP Notice: Array to string conversion from libs/StatusValue.php (via ApiClientLogin) - https://phabricator.wikimedia.org/T245155 (10Anomie) [20:59:50] (03PS1) 10Jforrester: Upgrade wikimedia/assert from 0.4.0 to 0.5.0 [core] - 10https://gerrit.wikimedia.org/r/572344 [21:00:02] (03PS1) 10Reedy: Fix some excessive indenting [extensions/Math] - 10https://gerrit.wikimedia.org/r/572345 [21:00:04] (03PS1) 10Reedy: Stop using 'url' param when logging [extensions/Math] - 10https://gerrit.wikimedia.org/r/572346 (https://phabricator.wikimedia.org/T245306) [21:00:06] 10MediaWiki-Cache, 10Core Platform Team, 10Technical-Debt: Consider limiting SqlBagOStuff makeKey logic - https://phabricator.wikimedia.org/T224808 (10Krinkle) [21:01:11] (03PS2) 10Akinwale-microsoft: Fix: Add alt text to MediaResultWidget image [core] - 10https://gerrit.wikimedia.org/r/572336 (https://phabricator.wikimedia.org/T245307) [21:01:22] (03PS1) 10Reedy: Remove trailing : from log error messages [extensions/Math] - 10https://gerrit.wikimedia.org/r/572347 [21:01:23] 10MediaWiki-Cache, 10Core Platform Team, 10Technical-Debt: Consider limiting SqlBagOStuff makeKey logic - https://phabricator.wikimedia.org/T224808 (10Krinkle) This might be a good one as well. I'm not sure what the failure mode is right now if e.g. parser cache or CACHE_DB access provides a key that is too... [21:01:27] (03CR) 10Krinkle: [C: 03+1] [Dev] Remove renderNavigation function for readability [skins/Vector] - 10https://gerrit.wikimedia.org/r/572318 (owner: 10Jdlrobson) [21:01:50] (03PS1) 10Thiemo Kreuz (WMDE): Minor code cleanups in various places in the codebase [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572348 [21:02:47] (03CR) 10Krinkle: POC: processTemplate used in one place (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/572334 (owner: 10Jdlrobson) [21:02:49] 10Phabricator, 10Release-Engineering-Team: change "default" column on Parsoid workboard - https://phabricator.wikimedia.org/T245308 (10LGoto) [21:03:52] 10MediaWiki-extensions-Scribunto, 10Commons, 10SDC General, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.35-notes (1.35.0-wmf.20; 2020-02-18): page ID accessed from Lua by calling "mw.title.getCurrentTitle().id" ocassionally returns "0" - https://phabricator.wikimedia.org/T237746 (10Anomie)... [21:04:53] (03CR) 10Gergő Tisza: "> Tagged." [libs/Assert] - 10https://gerrit.wikimedia.org/r/572132 (owner: 10Gergő Tisza) [21:04:57] (03CR) 10jerkins-bot: [V: 04-1] Minor code cleanups in various places in the codebase [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/572348 (owner: 10Thiemo Kreuz (WMDE)) [21:05:06] 10CirrusSearch, 10Discovery-Search: CirrusSearch logging logs with reserved parameter message - https://phabricator.wikimedia.org/T245303 (10Reedy) [21:06:42] (03PS1) 10Jforrester: Upgrade wikimedia/assert from 0.4.0 to 0.5.0 [vendor] - 10https://gerrit.wikimedia.org/r/572349 [21:06:49] (03CR) 10jerkins-bot: [V: 04-1] Upgrade wikimedia/assert from 0.4.0 to 0.5.0 [core] - 10https://gerrit.wikimedia.org/r/572344 (owner: 10Jforrester) [21:07:16] (03CR) 10jerkins-bot: [V: 04-1] Fix: Filter by changes and days button accessibility Screen reader just announces x changes, y days, it doesn't announce the meaning of the button We added an aria-label property to the button to make it accessible to visually impaired audiences [core] - 10https://gerrit.wikimedia.org/r/570972 (owner: 10Akinwale-microsoft) [21:07:28] (03CR) 10Dmaza: [C: 03+2] Add links to Special:Investigate preliminary check results table [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/570471 (https://phabricator.wikimedia.org/T243631) (owner: 10Tchanders) [21:07:31] (03CR) 10Raimond Spekking: "i18n review" (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/571626 (https://phabricator.wikimedia.org/T238782) (owner: 10Dmaza) [21:09:01] (03CR) 10jerkins-bot: [V: 04-1] POC: processTemplate used in one place [skins/Vector] - 10https://gerrit.wikimedia.org/r/572334 (owner: 10Jdlrobson) [21:09:05] (03CR) 10jerkins-bot: [V: 04-1] Upgrade wikimedia/assert from 0.4.0 to 0.5.0 [vendor] - 10https://gerrit.wikimedia.org/r/572349 (owner: 10Jforrester) [21:09:24] (03CR) 10jerkins-bot: [V: 04-1] Fix: Add aria-label to Filter Tag in Special:RecentChanges This widget failed accessibility test using the accessibility insights tool see https://accessibilityinsights.io/ The options associated with this tool also need to have an aria-label attribute [core] - 10https://gerrit.wikimedia.org/r/572335 (owner: 10Akinwale-microsoft) [21:10:04] 10Phabricator, 10Release-Engineering-Team: change "default" column on Parsoid workboard - https://phabricator.wikimedia.org/T245308 (10Peachey88) You can't change which column is default, You need to make a new one, move contents out then rename (at least last time I researched) [21:10:14] (03CR) 10jerkins-bot: [V: 04-1] Fix: Add alt text to MediaResultWidget image [core] - 10https://gerrit.wikimedia.org/r/572336 (https://phabricator.wikimedia.org/T245307) (owner: 10Akinwale-microsoft) [21:10:22] (03PS2) 10Jforrester: Upgrade wikimedia/assert from 0.4.0 to 0.5.0 [vendor] - 10https://gerrit.wikimedia.org/r/572349 [21:10:24] (03PS1) 10Bartosz Dziewoński: tests: Skip mw.loader.store tests if it's disabled [core] - 10https://gerrit.wikimedia.org/r/572351 [21:10:26] (03CR) 10jerkins-bot: [V: 04-1] Stop using 'url' param when logging [extensions/Math] - 10https://gerrit.wikimedia.org/r/572346 (https://phabricator.wikimedia.org/T245306) (owner: 10Reedy) [21:10:44] (03CR) 10Tchanders: Update preliminary check classes to use multi-column pagination (032 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572040 (https://phabricator.wikimedia.org/T244517) (owner: 10Tchanders) [21:10:51] 10MediaWiki-Codesniffer: Release mediawiki-codesniffer 30.0 - https://phabricator.wikimedia.org/T245309 (10Reedy) [21:10:52] (03CR) 10Bartosz Dziewoński: "This is just an idea, not sure if it's a good or bad one." [core] - 10https://gerrit.wikimedia.org/r/572351 (owner: 10Bartosz Dziewoński) [21:10:54] 10Phabricator, 10Release-Engineering-Team: change "default" column on Parsoid workboard - https://phabricator.wikimedia.org/T245308 (10RhinosF1) The default column can not be changed as far as I can tell. You’d need to rename ‘backlog’ to ‘Needs Triage’ and move tasks. [21:10:57] 10MediaWiki-extensions-Translate, 10Mobile-Web-Settings, 10Readers-Web-Backlog, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04): tag has wasteful heading on narrow screens - https://phabricator.wikimedia.org/T243997 (10TheDJ) I have to say.. I don't think I have ever been as happy and satisfied wit... [21:12:16] (03CR) 10jerkins-bot: [V: 04-1] Upgrade wikimedia/assert from 0.4.0 to 0.5.0 [vendor] - 10https://gerrit.wikimedia.org/r/572349 (owner: 10Jforrester) [21:12:50] (03CR) 10jerkins-bot: [V: 04-1] Remove trailing : from log error messages [extensions/Math] - 10https://gerrit.wikimedia.org/r/572347 (owner: 10Reedy) [21:13:02] (03PS2) 10Reedy: Stop using 'url' param when logging [extensions/Math] - 10https://gerrit.wikimedia.org/r/572346 (https://phabricator.wikimedia.org/T245306) [21:13:07] (03PS2) 10Reedy: Remove trailing : from log error messages [extensions/Math] - 10https://gerrit.wikimedia.org/r/572347 [21:14:22] 10Phabricator, 10Release-Engineering-Team: change "default" column on Parsoid workboard - https://phabricator.wikimedia.org/T245308 (10Reedy) >However, this problem here is the large number of tasks which would create a ton of notifications. Generally, don't worry about that. If people don't care about column... [21:14:23] (03CR) 10Jforrester: [C: 03+1] "Oh, I see." [core] - 10https://gerrit.wikimedia.org/r/572342 (https://phabricator.wikimedia.org/T245155) (owner: 10Anomie) [21:14:51] (03CR) 10Jforrester: [C: 03+2] Don't use 'message' as a logging key [core] - 10https://gerrit.wikimedia.org/r/572324 (https://phabricator.wikimedia.org/T245280) (owner: 10Reedy) [21:15:05] (03CR) 10Jforrester: [C: 03+2] Fix some excessive indenting [extensions/Math] - 10https://gerrit.wikimedia.org/r/572345 (owner: 10Reedy) [21:15:36] (03CR) 10jerkins-bot: [V: 04-1] StatusValue: Fix __toString() to not choke on special parameters [core] - 10https://gerrit.wikimedia.org/r/572342 (https://phabricator.wikimedia.org/T245155) (owner: 10Anomie) [21:16:32] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Remove redundant Stub class not compatible with PHPUnit any more [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/569599 (owner: 10Thiemo Kreuz (WMDE)) [21:17:00] (03CR) 10Dmaza: Add compare tab to Special:Investigate (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/571626 (https://phabricator.wikimedia.org/T238782) (owner: 10Dmaza) [21:17:50] 04(no projects): API calls ignoring cmendsortkeyprefix parameter when continue parameter is present - https://phabricator.wikimedia.org/T245310 (10William_Avery) [21:18:05] 10MediaWiki-API, 10Core Platform Team: API calls ignoring cmendsortkeyprefix parameter when continue parameter is present - https://phabricator.wikimedia.org/T245310 (10Reedy) [21:19:26] (03CR) 10jerkins-bot: [V: 04-1] Fix: Add alt text to MediaResultWidget image [core] - 10https://gerrit.wikimedia.org/r/572336 (https://phabricator.wikimedia.org/T245307) (owner: 10Akinwale-microsoft) [21:20:38] (03CR) 10Halfak: [C: 03+2] "This looks great for a start. Let's get this merged and address my follow-up notes in https://phabricator.wikimedia.org/T245311 in future" [extensions/Jade] - 10https://gerrit.wikimedia.org/r/552616 (https://phabricator.wikimedia.org/T208819) (owner: 10Accraze) [21:21:46] (03PS2) 10Jforrester: Follow-up 37a69a2f: ResourceLoaderSkinModule: Fix wfDeprecated() syntax [core] - 10https://gerrit.wikimedia.org/r/572322 [21:21:46] 10Phabricator, 10Release-Engineering-Team: change "default" column on Parsoid workboard - https://phabricator.wikimedia.org/T245308 (10greg) Or we can do the mass move for you silently. When doing a bulk job there's a interstitial that says something like "to run this job without notification, run this command... [21:21:59] (03CR) 10Jforrester: "a" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/572322 (owner: 10Jforrester) [21:23:15] 10MediaWiki-Cache, 10Core Platform Team, 10Technical-Debt: Consider limiting SqlBagOStuff makeKey logic - https://phabricator.wikimedia.org/T224808 (10Anomie) >>! In T224808#5886054, @Krinkle wrote: > I'm not sure what the failure mode is right now if e.g. parser cache or CACHE_DB access provides a key that... [21:24:09] (03CR) 10Reedy: Relax wikimedia/assert dependency to allow upgrade to 0.5.0 (031 comment) [libs/LangConv] - 10https://gerrit.wikimedia.org/r/572328 (owner: 10Jforrester) [21:24:13] (03CR) 10jerkins-bot: [V: 04-1] Add links to Special:Investigate preliminary check results table [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/570471 (https://phabricator.wikimedia.org/T243631) (owner: 10Tchanders) [21:25:15] (03CR) 10Jforrester: Relax wikimedia/assert dependency to allow upgrade to 0.5.0 (031 comment) [libs/LangConv] - 10https://gerrit.wikimedia.org/r/572328 (owner: 10Jforrester) [21:25:58] (03PS1) 10Reedy: Remove travis and scrutinizer badges [libs/Assert] - 10https://gerrit.wikimedia.org/r/572356 [21:26:16] (03CR) 10jerkins-bot: [V: 04-1] tests: Skip mw.loader.store tests if it's disabled [core] - 10https://gerrit.wikimedia.org/r/572351 (owner: 10Bartosz Dziewoński) [21:26:44] (03Abandoned) 10Reedy: Remove travis and scrutinizer badges [libs/Assert] - 10https://gerrit.wikimedia.org/r/572356 (owner: 10Reedy) [21:26:57] (03CR) 10Jforrester: build: Updating composer dependencies (031 comment) [extensions/cldr] - 10https://gerrit.wikimedia.org/r/569008 (owner: 10Libraryupgrader) [21:30:17] (03Merged) 10jenkins-bot: Don't use 'message' as a logging key [core] - 10https://gerrit.wikimedia.org/r/572324 (https://phabricator.wikimedia.org/T245280) (owner: 10Reedy) [21:30:18] 10MediaWiki-Codesniffer: Release mediawiki-codesniffer 30.0 - https://phabricator.wikimedia.org/T245309 (10Reedy) Are we waiting on any other tickets/open patchsets? [21:31:37] 10MediaWiki-Page-editing, 10TCB-Team, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review: Conflict resolution process ends with incorrect "This page has been restored" - https://phabricator.wikimedia.org/T245244 (10Anomie) [21:31:47] 10Phabricator, 10Release-Engineering-Team: change "default" column on Parsoid workboard - https://phabricator.wikimedia.org/T245308 (10LGoto) @reedy thanks, good to know! The column move would probably be fine, but maybe it's safer to do the silent move. @greg Sorry if this is an obvious question, but how do... [21:33:16] 10Phabricator, 10Release-Engineering-Team: change "default" column on Parsoid workboard - https://phabricator.wikimedia.org/T245308 (10Peachey88) You need to be in the triage group and use bulk edit, but I just checked and there isn't any workboard move options. [21:35:37] 10Phabricator, 10Release-Engineering-Team: change "default" column on Parsoid workboard - https://phabricator.wikimedia.org/T245308 (10Reedy) >>! In T245308#5886156, @LGoto wrote: > @greg Sorry if this is an obvious question, but how do I figure out the job number? It doesn't look like this is possible for a... [21:35:44] 10MediaWiki-Language-converter, 10Parsoid-Read-Views, 10Chinese-Sites, 10Core Platform Team Legacy (Watching / External), and 3 others: Support language variant conversion in Parsoid - https://phabricator.wikimedia.org/T43716 (10VulpesVulpes825) In my opinion, it would be the best to dump the whole Languag... [21:36:52] 10MediaWiki-Debug-Logger, 10Core Platform Team, 10Patch-For-Review: Improve file attribution for “Called deprecation function” logs - https://phabricator.wikimedia.org/T245075 (10Anomie) I think I agree with @Krinkle on this, turning things inside out with DeprecationHelper being passed a callback seems to h... [21:37:13] (03CR) 10Jforrester: [C: 03+2] Stop using 'url' param when logging [extensions/Math] - 10https://gerrit.wikimedia.org/r/572346 (https://phabricator.wikimedia.org/T245306) (owner: 10Reedy) [21:37:21] (03CR) 10Jforrester: [C: 03+2] Remove trailing : from log error messages [extensions/Math] - 10https://gerrit.wikimedia.org/r/572347 (owner: 10Reedy) [21:37:40] (03CR) 10Jforrester: "Ha, sorry." [libs/Assert] - 10https://gerrit.wikimedia.org/r/572356 (owner: 10Reedy) [21:39:25] (03PS1) 10Bartosz Dziewoński: tests: Fix mw.api.options tests when logged in [core] - 10https://gerrit.wikimedia.org/r/572357 [21:39:33] 10Phabricator, 10Release-Engineering-Team: change "default" column on Parsoid workboard - https://phabricator.wikimedia.org/T245308 (10greg) >>! In T245308#5886156, @LGoto wrote: > @greg Sorry if this is an obvious question, but how do I figure out the job number? You find the job number when doing a bulk edi... [21:40:36] (03CR) 10Bartosz Dziewoński: "Wow, that is one annoying lint check." [core] - 10https://gerrit.wikimedia.org/r/572351 (owner: 10Bartosz Dziewoński) [21:40:50] (03PS2) 10Bartosz Dziewoński: tests: Skip mw.loader.store tests if it's disabled [core] - 10https://gerrit.wikimedia.org/r/572351 [21:41:28] 10Phabricator, 10Release-Engineering-Team: change "default" column on Parsoid workboard - https://phabricator.wikimedia.org/T245308 (10Reedy) >>! In T245308#5886169, @greg wrote: > I'm sorry I promised something we didn't have; this use case always bites me. Googling looks like this solution was the implement... [21:42:52] (03PS1) 10Dmaza: Fix missing i18n message param description [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572358 [21:43:14] (03CR) 10Dmaza: "This change is ready for review." [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572358 (owner: 10Dmaza) [21:44:17] wikimedia/grunt-stylelint#220 (stylelint-13.2.0 - 74afa9b James D. Forrester): The build passed. - https://travis-ci.org/wikimedia/grunt-stylelint/builds/650632004 [21:45:00] (03CR) 10Dmaza: Add compare tab to Special:Investigate (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/571626 (https://phabricator.wikimedia.org/T238782) (owner: 10Dmaza) [21:47:47] wikimedia/grunt-stylelint#222 (stylelint-13.2.0 - 85ea178 James D. Forrester): The build passed. - https://travis-ci.org/wikimedia/grunt-stylelint/builds/650633879 [21:48:11] 10MediaWiki-Codesniffer: Release mediawiki-codesniffer 30.0 - https://phabricator.wikimedia.org/T245309 (10Daimona) >>! In T245309#5886152, @Reedy wrote: > Are we waiting on any other tickets/open patchsets? AFAIAA, no. Also, I think it makes sense to tag 30.0.0 now, given the number of changes in 29..master. [21:51:02] 10MediaWiki-Codesniffer: Release mediawiki-codesniffer 30.0 - https://phabricator.wikimedia.org/T245309 (10Jdforrester-WMF) Possibly https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/+/571023 ? [21:51:41] (03PS2) 10Anomie: StatusValue: Fix __toString() to not choke on special parameters [core] - 10https://gerrit.wikimedia.org/r/572342 (https://phabricator.wikimedia.org/T245155) [21:53:02] 10MediaWiki-extensions-ContactPage, 10Stewards-and-global-tools, 10Security, 10Security Related: Should https://meta.wikimedia.org/wiki/Special:Contact/Stewards require a login - https://phabricator.wikimedia.org/T224059 (10Trijnstel) This is likely a duplicate of T167219. [21:54:24] (03Merged) 10jenkins-bot: Fix some excessive indenting [extensions/Math] - 10https://gerrit.wikimedia.org/r/572345 (owner: 10Reedy) [21:54:26] (03Merged) 10jenkins-bot: Remove redundant Stub class not compatible with PHPUnit any more [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/569599 (owner: 10Thiemo Kreuz (WMDE)) [21:54:28] (03Merged) 10jenkins-bot: Implement Jade entity UI [extensions/Jade] - 10https://gerrit.wikimedia.org/r/552616 (https://phabricator.wikimedia.org/T208819) (owner: 10Accraze) [21:56:01] (03CR) 10jerkins-bot: [V: 04-1] tests: Skip mw.loader.store tests if it's disabled [core] - 10https://gerrit.wikimedia.org/r/572351 (owner: 10Bartosz Dziewoński) [21:57:15] 10MediaWiki-Page-deletion, 10Patch-For-Review: Add ar_del_time (timestamp of page deletion) - https://phabricator.wikimedia.org/T245234 (10Superacidic) I'm thinking we can add the field in MW 1.35 and then actually do something with it in 1.36, after people have had time to upgrade. [21:57:40] (03CR) 10Anomie: Alter `revision` for actor, comment, and MCR (033 comments) [core] - 10https://gerrit.wikimedia.org/r/552339 (https://phabricator.wikimedia.org/T161671) (owner: 10Anomie) [22:00:22] 10DannyS712-Global_watchlist.js: Make setTimeout value for live updatesv configurable - https://phabricator.wikimedia.org/T245312 (10IKhitron) a:03DannyS712 [22:00:52] (03PS9) 10Anomie: Alter `revision` for actor, comment, and MCR [core] - 10https://gerrit.wikimedia.org/r/552339 (https://phabricator.wikimedia.org/T161671) [22:01:20] 10CheckUser, 10Anti-Harassment (The Letter Song), 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17): "Undefined variable: globalUser" submitting Special:Investigate form without CentralAuth - https://phabricator.wikimedia.org/T240585 (10dmaza) @dom_walden I can't reproduce this as anymore as of 005ce473e11b7fae036... [22:02:26] (03CR) 10jerkins-bot: [V: 04-1] Alter `revision` for actor, comment, and MCR [core] - 10https://gerrit.wikimedia.org/r/552339 (https://phabricator.wikimedia.org/T161671) (owner: 10Anomie) [22:07:34] 10Structured-Data-Backlog, 10StructuredDataOnCommons: 5 character limit is too restrictive for structured data on commons for character-based languages - https://phabricator.wikimedia.org/T244953 (10Ramsey-WMF) a:03matthiasmullie Any ideas on this one, Matthias? [22:11:41] (03CR) 10Anomie: "Code looks fine. One question regarding the @since." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/571861 (https://phabricator.wikimedia.org/T241957) (owner: 10DannyS712) [22:12:13] (03Merged) 10jenkins-bot: Stop using 'url' param when logging [extensions/Math] - 10https://gerrit.wikimedia.org/r/572346 (https://phabricator.wikimedia.org/T245306) (owner: 10Reedy) [22:12:15] (03Merged) 10jenkins-bot: Remove trailing : from log error messages [extensions/Math] - 10https://gerrit.wikimedia.org/r/572347 (owner: 10Reedy) [22:13:11] (03CR) 10Anomie: "> But, I'm no expert in this code, added @Anomie, maybe he knows better." [core] - 10https://gerrit.wikimedia.org/r/571861 (https://phabricator.wikimedia.org/T241957) (owner: 10DannyS712) [22:13:43] 10MediaWiki-ResourceLoader, 10Performance-Team: Consider using JSON.parse() literal for startup manifest - https://phabricator.wikimedia.org/T245313 (10Krinkle) [22:13:49] (03PS3) 10Bartosz Dziewoński: tests: Skip mw.loader.store tests if it's disabled [core] - 10https://gerrit.wikimedia.org/r/572351 [22:14:01] (03PS3) 10Krinkle: [WIP] resourceloader: Experiment with JSON.parse()ing the startup manifest [core] - 10https://gerrit.wikimedia.org/r/531722 (https://phabricator.wikimedia.org/T245313) (owner: 10Catrope) [22:15:31] (03CR) 10jerkins-bot: [V: 04-1] [WIP] resourceloader: Experiment with JSON.parse()ing the startup manifest [core] - 10https://gerrit.wikimedia.org/r/531722 (https://phabricator.wikimedia.org/T245313) (owner: 10Catrope) [22:16:51] (03PS4) 10Jdlrobson: POC: processTemplate used in one place [skins/Vector] - 10https://gerrit.wikimedia.org/r/572334 [22:17:08] (03PS4) 10Krinkle: [WIP] resourceloader: Experiment with JSON.parse()ing the startup manifest [core] - 10https://gerrit.wikimedia.org/r/531722 (https://phabricator.wikimedia.org/T245313) (owner: 10Catrope) [22:19:43] (03PS1) 10Ammarpad: Show help message atop SpecialLogin when a user is redirected there [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/572360 (https://phabricator.wikimedia.org/T235621) [22:20:15] (03CR) 10jerkins-bot: [V: 04-1] Show help message atop SpecialLogin when a user is redirected there [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/572360 (https://phabricator.wikimedia.org/T235621) (owner: 10Ammarpad) [22:20:15] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-Debug-Logger, 10MediaWiki-extensions-LoginNotify, 10Community-Tech, and 2 others: logstash_formatter_key_conflict in mediawiki logs - https://phabricator.wikimedia.org/T245280 (10Reedy) [22:20:53] 10MediaWiki-extensions-Page_Forms: Prevent double save on double click on "Save page" button - https://phabricator.wikimedia.org/T69409 (10Swayamsrk) I can try this.@Yaron_Koren can you please give me some micro-tasks to solve in this project. [22:21:19] 10NewcomerTasks 1.1, 10Growth-Team (Current Sprint): Regenerate data for prototype using updated ORES models - https://phabricator.wikimedia.org/T243956 (10kostajh) cswiki is closer to being complete but not quite done. I've pushed what I have. I'll keep processing the data for the other wikis over the weekend... [22:23:18] (03CR) 10Anomie: [C: 03+1] "Code looks good. Do you mind if I edit to adjust the whitespace in a few places before +2ing?" [core] - 10https://gerrit.wikimedia.org/r/571943 (owner: 10Tim Starling) [22:23:56] (03CR) 10Mooeypoo: [C: 03+2] Fix missing i18n message param description [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572358 (owner: 10Dmaza) [22:24:57] (03PS2) 10Ammarpad: Show help message atop SpecialLogin when a user is redirected there [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/572360 (https://phabricator.wikimedia.org/T235621) [22:25:26] 10Phabricator, 10Release-Engineering-Team: change "default" column on Parsoid workboard - https://phabricator.wikimedia.org/T245308 (10LGoto) No worries, thanks everyone for looking into this. I'll give the team a heads up and then move the tasks via the workboard. [22:26:41] (03CR) 10jerkins-bot: [V: 04-1] Show help message atop SpecialLogin when a user is redirected there [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/572360 (https://phabricator.wikimedia.org/T235621) (owner: 10Ammarpad) [22:26:58] (03PS5) 10Superbass: Add ar_del_time [core] - 10https://gerrit.wikimedia.org/r/572134 (https://phabricator.wikimedia.org/T245234) [22:27:35] (03PS3) 10Ammarpad: Show help message atop SpecialLogin when a user is redirected there [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/572360 (https://phabricator.wikimedia.org/T235621) [22:28:34] 10Password-Reset-Update, 10Community-Tech (Kanban-Q3-2019-20), 10MW-1.35-notes (1.35.0-wmf.19; 2020-02-11): PRU: Improve Security & Standardize Experience for Password Reset [medium] - https://phabricator.wikimedia.org/T238961 (10Mooeypoo) Just to clarify for engineering related thing, am I right to say that... [22:28:49] 10MobileFrontend, 10VisualEditor, 10Mobile, 10Readers-Web-Backlog (Tracking): VisualDiff toggle buttons appear in mobile when the relevant page doesn't have wikitext content model - https://phabricator.wikimedia.org/T245172 (10matmarex) This is a bug in MobileFrontend. It looks like it passes "Special:Mobi... [22:28:55] (03PS4) 10Ammarpad: Show help message atop SpecialLogin when a user is redirected there [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/572360 (https://phabricator.wikimedia.org/T235621) [22:29:53] (03CR) 10jerkins-bot: [V: 04-1] POC: processTemplate used in one place [skins/Vector] - 10https://gerrit.wikimedia.org/r/572334 (owner: 10Jdlrobson) [22:30:19] (03CR) 10Brian Wolff: [C: 04-1] "Hmm, I just noticed that there is some special handling of authevents in logging.php which this might mess up" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/571426 (owner: 10Brian Wolff) [22:30:36] (03CR) 10jerkins-bot: [V: 04-1] Show help message atop SpecialLogin when a user is redirected there [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/572360 (https://phabricator.wikimedia.org/T235621) (owner: 10Ammarpad) [22:31:25] 10MediaWiki-API, 10Core Platform Team: Add filtering to list=allimages for feature parity with Special:NewFiles - https://phabricator.wikimedia.org/T239639 (10Anomie) The media type filters and an equivalent to the "Hide patrolled uploads" checkbox are still missing. But since there's apparently no one asking... [22:32:20] (03PS6) 10Niedzielski: [WIP] [Special:Preferences] [PHP] Add skin version user preference and configs [skins/Vector] - 10https://gerrit.wikimedia.org/r/566881 (https://phabricator.wikimedia.org/T242381) [22:32:22] (03CR) 10Bartosz Dziewoński: [C: 03+2] Show number of displayed pages on WhatLinksHere [core] - 10https://gerrit.wikimedia.org/r/127866 (https://phabricator.wikimedia.org/T44357) (owner: 10Gerrit Patch Uploader) [22:33:17] (03CR) 10jerkins-bot: [V: 04-1] [WIP] resourceloader: Experiment with JSON.parse()ing the startup manifest [core] - 10https://gerrit.wikimedia.org/r/531722 (https://phabricator.wikimedia.org/T245313) (owner: 10Catrope) [22:33:47] (03CR) 10Jforrester: [C: 03+2] StatusValue: Fix __toString() to not choke on special parameters [core] - 10https://gerrit.wikimedia.org/r/572342 (https://phabricator.wikimedia.org/T245155) (owner: 10Anomie) [22:35:37] 10Accessibility, 10VisualEditor: Insert_comment is missing name(aria-label) - https://phabricator.wikimedia.org/T245315 (10Akinwale-microsoft) [22:36:48] 10Password-Reset-Update, 10Community-Tech (Kanban-Q3-2019-20), 10MW-1.35-notes (1.35.0-wmf.19; 2020-02-11): PRU: Improve Security & Standardize Experience for Password Reset [medium] - https://phabricator.wikimedia.org/T238961 (10ifried) Yes, @Mooeypoo, you are correct. We should remove the message (i.e., "B... [22:37:02] 10Design, 10Jade, 10Scoring-platform-team (Current): Implement Jade Entity UI - https://phabricator.wikimedia.org/T208819 (10ACraze) [22:38:34] 10Design, 10Jade, 10Scoring-platform-team (Current): Implement Jade Entity UI - https://phabricator.wikimedia.org/T208819 (10ACraze) [22:40:07] (03Merged) 10jenkins-bot: Fix missing i18n message param description [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/572358 (owner: 10Dmaza) [22:42:58] (03PS1) 10Accraze: [WIP] Implement Diff view for Jade Entity UI [extensions/Jade] - 10https://gerrit.wikimedia.org/r/572362 (https://phabricator.wikimedia.org/T245316) [22:44:17] wikimedia/grunt-stylelint#225 (release-0.14.0 - eaa7e8b James D. Forrester): The build passed. - https://travis-ci.org/wikimedia/grunt-stylelint/builds/650651810 [22:44:22] (03CR) 10TheDJ: [C: 03+2] "note.. it's hard to review a bundle of 'unknown' executable code." [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/571354 (owner: 10Ori.livneh) [22:46:17] (03PS6) 10Tchanders: Add links to Special:Investigate preliminary check results table [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/570471 (https://phabricator.wikimedia.org/T243631) [22:46:33] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Implement Diff view for Jade Entity UI [extensions/Jade] - 10https://gerrit.wikimedia.org/r/572362 (https://phabricator.wikimedia.org/T245316) (owner: 10Accraze) [22:46:37] (03CR) 10TheDJ: [C: 03+2] Fix for create_pygmentize_bundle Python 3 compat [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/572255 (owner: 10Ori.livneh) [22:47:05] wikimedia/grunt-stylelint#227 (master - 9e23fcf James Forrester): The build passed. - https://travis-ci.org/wikimedia/grunt-stylelint/builds/650652699 [22:48:32] (03Merged) 10jenkins-bot: Show number of displayed pages on WhatLinksHere [core] - 10https://gerrit.wikimedia.org/r/127866 (https://phabricator.wikimedia.org/T44357) (owner: 10Gerrit Patch Uploader) [22:49:01] (03CR) 10jerkins-bot: [V: 04-1] [WIP] [Special:Preferences] [PHP] Add skin version user preference and configs [skins/Vector] - 10https://gerrit.wikimedia.org/r/566881 (https://phabricator.wikimedia.org/T242381) (owner: 10Niedzielski) [22:49:17] (03CR) 10Aaron Schulz: "It could be kludged at runtime. $wgMiserMode should protect against huge queries https://phabricator.wikimedia.org/T36156 due to a near-0 " [core] - 10https://gerrit.wikimedia.org/r/501840 (owner: 10Aaron Schulz) [22:50:01] (03Merged) 10jenkins-bot: StatusValue: Fix __toString() to not choke on special parameters [core] - 10https://gerrit.wikimedia.org/r/572342 (https://phabricator.wikimedia.org/T245155) (owner: 10Anomie) [22:50:03] (03Merged) 10jenkins-bot: Update pygments to 2.5.2 [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/571354 (owner: 10Ori.livneh) [22:51:18] (03CR) 10Mooeypoo: [C: 03+2] "re-+2'ing after rebase" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/570471 (https://phabricator.wikimedia.org/T243631) (owner: 10Tchanders) [22:51:30] (03Merged) 10jenkins-bot: Fix for create_pygmentize_bundle Python 3 compat [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/572255 (owner: 10Ori.livneh) [22:51:47] wikimedia/grunt-stylelint#228 (v0.14.0 - 9e23fcf James Forrester): The build passed. - https://travis-ci.org/wikimedia/grunt-stylelint/builds/650653914 [22:54:05] (03PS5) 10Ammarpad: Show help message atop SpecialLogin when a user is redirected there [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/572360 (https://phabricator.wikimedia.org/T235621) [22:55:44] 10MinervaNeue, 10Readers-Web-Backlog, 10Structured Data Engineering, 10Structured-Data-Backlog, 10Wikimedia-production-error: Job unable to create file page "Fatal: Call function inNamespace() on null" (via MinervaHooks) - https://phabricator.wikimedia.org/T245162 (10matmarex) This issue doesn't seem to... [22:55:51] 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10ProofreadPage: Syntax highlighter forces the header and footer to end up at the bottom of the proofread page. - https://phabricator.wikimedia.org/T241521 (10TheDJ) wrong syntax highlighting extension.. [22:56:21] 10MediaWiki-Revision-backend, 10Operations: Compress data at external storage - https://phabricator.wikimedia.org/T106386 (10Anomie) 05Open→03Stalled This can't be done until Flow's data isn't going to be deleted when the recompression is run. But now the tasks for moving Flow's data out of the MW External... [22:56:43] 10MediaWiki-Watchlist, 10Commons, 10Growth-Team: "TypeError: this.emptyFilterMessage is undefined" on Commons Watchlist - https://phabricator.wikimedia.org/T245139 (10Etonkovidova) The same error appears on RecentChanges too. @Catrope - seems to be the same error as in {T245073}? [22:57:11] 10MediaWiki-Special-pages, 10Patch-For-Review, 10good first task: Show number of items on Whatlinkshere if less than limit value - https://phabricator.wikimedia.org/T44357 (10matmarex) 05Open→03Resolved [22:57:54] 10MediaWiki-Revision-backend, 10Operations: Compress data at external storage - https://phabricator.wikimedia.org/T106386 (10Anomie) [22:58:11] 10MobileFrontend, 10Readers-Web-Backlog, 10VisualEditor, 10Mobile: VisualDiff toggle buttons appear in mobile when the relevant page doesn't have wikitext content model - https://phabricator.wikimedia.org/T245172 (10Masumrezarock100) I suggest #Reading-Web to look into it. Since this appears to be a MF bug... [22:58:23] 10SyntaxHighlight: Yaml doesn't highlight difference between keys and values - https://phabricator.wikimedia.org/T216725 (10TheDJ) 05Open→03Resolved a:03TheDJ This is fixed with https://gerrit.wikimedia.org/r/571354 [23:03:11] 10MediaWiki-Watchlist, 10Commons, 10Growth-Team (Current Sprint): "TypeError: this.emptyFilterMessage is undefined" on Commons Watchlist - https://phabricator.wikimedia.org/T245139 (10Etonkovidova) [23:03:53] 10MediaWiki-ResourceLoader, 10Librarization, 10Performance-Team, 10Core Platform Team Workboards (Clinic Duty Team), 10patch-welcome: CSSMin library calls global function wfExpandUrl() - https://phabricator.wikimedia.org/T88914 (10Anomie) I did some investigation of libraries with high usage numbers on p... [23:04:48] (03Merged) 10jenkins-bot: Add links to Special:Investigate preliminary check results table [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/570471 (https://phabricator.wikimedia.org/T243631) (owner: 10Tchanders) [23:05:55] 10SyntaxHighlight: Cannot highlight dot language - https://phabricator.wikimedia.org/T143196 (10TheDJ) Someone wrote a lexer, but it isn't upstreamed yet: https://github.com/nikeee/pygments-lexer-graphviz/tree/master/graphviz [23:10:40] 10SyntaxHighlight, 10Upstream: Script element in SVG not treated as script code with lang=xml - https://phabricator.wikimedia.org/T130688 (10TheDJ) [23:11:14] 10Structured-Data-Backlog: The "X" button to dismiss the CAT UploadWizard prompt keeps returning - https://phabricator.wikimedia.org/T245317 (10Ramsey-WMF) [23:11:39] 10Structured-Data-Backlog: The "X" button to dismiss the CAT UploadWizard prompt does not prevent the prompt from returning later - https://phabricator.wikimedia.org/T245317 (10Ramsey-WMF) [23:11:39] (03PS7) 10Niedzielski: [WIP] [Special:Preferences] [PHP] Add skin version user preference and configs [skins/Vector] - 10https://gerrit.wikimedia.org/r/566881 (https://phabricator.wikimedia.org/T242381) [23:14:15] 10SyntaxHighlight: Content without spaces in
 should wrap and break words - https://phabricator.wikimedia.org/T75282 (10TheDJ) 05Open→03Resolved a:03TheDJ This was fixed by https://gerrit.wikimedia.org/r/561285 as part of T237190
[23:17:32] 	 (03CR) 10Niedzielski: [WIP] [Special:Preferences] [PHP] Add skin version user preference and configs (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/566881 (https://phabricator.wikimedia.org/T242381) (owner: 10Niedzielski)
[23:19:19] 	 10Desktop Improvements, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): Add a Vector skin version preference - https://phabricator.wikimedia.org/T242381 (10Niedzielski) @phuedx, I've left a comment for you in code review regarding preference conversion. This still "needs work" but is pendin...
[23:19:51] 	 10Desktop Improvements, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): Add a Vector skin version preference - https://phabricator.wikimedia.org/T242381 (10Niedzielski) a:05Niedzielski→03phuedx
[23:20:43] 	 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 1.0): Publish Replying deployment plan on MediaWiki - https://phabricator.wikimedia.org/T244869 (10ppelberg) === 14-February **Update:** - The draft is complete: https://office.wikimedia.org/wiki/User:PPelberg_(WMF)/sa...
[23:21:01] 	 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 1.0): Publish Replying deployment plan on MediaWiki - https://phabricator.wikimedia.org/T244869 (10ppelberg) a:05ppelberg→03Whatamidoing-WMF
[23:21:23] 	 (03CR) 10D3r1ck01: Convert UploadBlacklist to use extension registration (031 comment) [extensions/UploadBlacklist] - 10https://gerrit.wikimedia.org/r/571068 (https://phabricator.wikimedia.org/T211483) (owner: 10MarcoAurelio)
[23:22:20] 	 10DiscussionTools, 10Editing-team (Q3 2019-2020 Kanban Board), 10OWC2020 (OWC2020 Replying 1.0): Publish Replying deployment plan on MediaWiki - https://phabricator.wikimedia.org/T244869 (10ppelberg)
[23:25:02] 	 (03CR) 10jerkins-bot: [V: 04-1] [WIP] [Special:Preferences] [PHP] Add skin version user preference and configs [skins/Vector] - 10https://gerrit.wikimedia.org/r/566881 (https://phabricator.wikimedia.org/T242381) (owner: 10Niedzielski)
[23:32:24] 	 10Research (FY2019-20-Research-January-March): Launch experimental API for Wikidata-based topic model - https://phabricator.wikimedia.org/T242176 (10leila) @Isaac thank you. I reviewed and left some comments. Please run it by the team and ask that they get back to you in 1-2 days with feedback. I think this is a...
[23:33:51] 	 (03PS2) 10Polishdeveloper: FeatureManagement in Vector [skins/Vector] - 10https://gerrit.wikimedia.org/r/572323 (https://phabricator.wikimedia.org/T244481)
[23:35:28] 	 (03CR) 10DannyS712: Remove CommentStore::newKey, deprecated and unused (031 comment) [core] - 10https://gerrit.wikimedia.org/r/571861 (https://phabricator.wikimedia.org/T241957) (owner: 10DannyS712)
[23:50:45] 	 10Wikipedia-Android-App-Backlog: Make the warning message on the suicide methods page appear in the android app - https://phabricator.wikimedia.org/T245322 (10Tnegrin)
[23:52:04] 	 10Wikipedia-Android-App-Backlog: Make the warning message on the suicide methods page appear in the android app - https://phabricator.wikimedia.org/T245322 (10Tnegrin) ios ticket: https://phabricator.wikimedia.org/T245321
[23:53:58] 	 10MediaWiki-Parser, 10TechCom, 10Readers-Web-Backlog (Tracking): Links in table of contents don't work for certain characters - https://phabricator.wikimedia.org/T238385 (10ssastry)
[23:54:55] 	 10Timeless, 10CSS: Timeless class=wikitable hides styles on table rows - https://phabricator.wikimedia.org/T238482 (10Masumrezarock100) Same thing is happening with the Statistics table in the stewards election page. The table color and styles are hidden different on timeless. https://meta.wikimedia.org/wiki/S...
[23:57:26] 	 10Design, 10Growth-Team, 10Notifications: Echo: Inconsistent link/bold formatting in flyout - https://phabricator.wikimedia.org/T68385 (10Etonkovidova) Re-checked the notifications types that were described in the task, i.e.  - a  page was reviewed - a page was linked   There were some updates on wording in...