[00:01:19] (03PS1) 10SLF bot: Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/567296 [00:01:52] 10MediaWiki-Gerrit-Group-Requests: +2 for Zoranzoki21 in mediawiki/* - https://phabricator.wikimedia.org/T243700 (10Zoranzoki21) >>! In T243700#5832134, @DannyS712 wrote: > @Zoranzoki21 can you give some examples of more complex contributions? A lot of your commits appear to be fairly rote, even if they are larg... [00:04:55] (03PS1) 10Samwilson: Support MediaWiki 1.31 [extensions/MissedPages] - 10https://gerrit.wikimedia.org/r/567297 [00:04:56] 10MediaWiki-extensions-OATHAuth, 10Security-Team, 10Trust-and-Safety, 10Security, 10User-DannyS712: Allow privileged accounts to determine if an account has enrolled in 2FA - https://phabricator.wikimedia.org/T209749 (10DannyS712) a:03DannyS712 Based on rereading the above, going to * Create Special:V... [00:09:46] 10MediaWiki-Logging, 10MediaWiki-User-management, 10Anti-Harassment: Determine then implement the proper way to log partial blocks - https://phabricator.wikimedia.org/T202781 (10DannyS712) Given that partial blocks are live and being logged, is this still needed? [00:13:21] (03PS4) 10DannyS712: Remove SpecialRecentChanges::filterByCategories(), deprecated and unused [core] - 10https://gerrit.wikimedia.org/r/567111 (https://phabricator.wikimedia.org/T241690) [00:23:42] 10MediaWiki-Gerrit-Group-Requests: +2 for Zoranzoki21 in mediawiki/* - https://phabricator.wikimedia.org/T243700 (10Bawolff) My opinion is same as last time. Sorry. [00:26:19] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/567111 (https://phabricator.wikimedia.org/T241690) (owner: 10DannyS712) [00:28:02] 10MediaWiki-Gerrit-Group-Requests: +2 for Zoranzoki21 in mediawiki/* - https://phabricator.wikimedia.org/T243700 (10Bawolff) To be clear, i don't mean to say your patches are unimportant in any way. Part of a +2'ers job is to ensure that code, even simple patches, don't have unintended consequences. This is why... [00:35:31] (03CR) 10Jforrester: [C: 03+2] Require PHPUnit 8 like MW core [testing-access-wrapper] - 10https://gerrit.wikimedia.org/r/567208 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:36:02] (03Merged) 10jenkins-bot: Require PHPUnit 8 like MW core [testing-access-wrapper] - 10https://gerrit.wikimedia.org/r/567208 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:36:18] (03PS3) 10Jforrester: Require PHP 7.2.9+ [oauthclient-php] - 10https://gerrit.wikimedia.org/r/567217 (owner: 10Daimona Eaytoy) [00:37:46] (03CR) 10Jforrester: [C: 03+2] "We can tag non-HEAD revisions easily enough." [oauthclient-php] - 10https://gerrit.wikimedia.org/r/567217 (owner: 10Daimona Eaytoy) [00:37:59] (03PS6) 10Jforrester: Require PHPUnit 8 like MW core [oauthclient-php] - 10https://gerrit.wikimedia.org/r/567218 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:38:15] (03Merged) 10jenkins-bot: Require PHP 7.2.9+ [oauthclient-php] - 10https://gerrit.wikimedia.org/r/567217 (owner: 10Daimona Eaytoy) [00:38:17] (03CR) 10Jforrester: [C: 03+2] Require PHPUnit 8 like MW core [oauthclient-php] - 10https://gerrit.wikimedia.org/r/567218 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:38:41] (03CR) 10Jforrester: [C: 03+2] Require PHPUnit 8 like MW core [libs/alea] - 10https://gerrit.wikimedia.org/r/567203 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:38:43] (03Merged) 10jenkins-bot: Require PHPUnit 8 like MW core [oauthclient-php] - 10https://gerrit.wikimedia.org/r/567218 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:38:46] (03CR) 10Jforrester: [C: 03+2] Require PHPUnit 8 like MW core [libs/LangConv] - 10https://gerrit.wikimedia.org/r/567204 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:39:13] (03Merged) 10jenkins-bot: Require PHPUnit 8 like MW core [libs/alea] - 10https://gerrit.wikimedia.org/r/567203 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:39:41] (03Merged) 10jenkins-bot: Require PHPUnit 8 like MW core [libs/LangConv] - 10https://gerrit.wikimedia.org/r/567204 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:41:28] (03PS3) 10Jforrester: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [oauthclient-php] - 10https://gerrit.wikimedia.org/r/563800 (owner: 10Libraryupgrader) [00:41:58] (03CR) 10Jforrester: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [oauthclient-php] - 10https://gerrit.wikimedia.org/r/563800 (owner: 10Libraryupgrader) [00:42:36] (03CR) 10Jforrester: [C: 03+2] Require PHPUnit 8 like MW core [libs/Zest] - 10https://gerrit.wikimedia.org/r/567205 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:42:40] (03CR) 10Jforrester: [C: 03+2] Require PHPUnit 8 like MW core [libs/etcd] - 10https://gerrit.wikimedia.org/r/567226 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:42:45] (03CR) 10Jforrester: [C: 03+2] Require PHPUnit 8 like MW core [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/567227 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:42:49] (03CR) 10Jforrester: [C: 03+2] Require PHPUnit 8 like MW core [libs/ObjectFactory] - 10https://gerrit.wikimedia.org/r/567228 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:43:05] (03CR) 10Jforrester: [C: 03+2] Require PHPUnit 8 like MW core [libs/Assert] - 10https://gerrit.wikimedia.org/r/567225 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:43:07] (03Merged) 10jenkins-bot: Require PHPUnit 8 like MW core [libs/Zest] - 10https://gerrit.wikimedia.org/r/567205 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:43:10] (03CR) 10Jforrester: [C: 03+2] Require PHPUnit 8 like MW core [libs/PasswordBlacklist] - 10https://gerrit.wikimedia.org/r/567229 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:43:12] (03Merged) 10jenkins-bot: Require PHPUnit 8 like MW core [libs/etcd] - 10https://gerrit.wikimedia.org/r/567226 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:43:14] (03CR) 10Jforrester: [C: 03+2] Require PHPUnit 8 like MW core [libs/RemexHtml] - 10https://gerrit.wikimedia.org/r/567230 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:43:17] (03Merged) 10jenkins-bot: Require PHPUnit 8 like MW core [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/567227 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:43:20] (03CR) 10Jforrester: [C: 03+2] Require PHPUnit 8 like MW core [libs/ScopedCallback] - 10https://gerrit.wikimedia.org/r/567231 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:43:23] (03Merged) 10jenkins-bot: Require PHPUnit 8 like MW core [libs/ObjectFactory] - 10https://gerrit.wikimedia.org/r/567228 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:43:25] (03CR) 10Jforrester: [C: 03+2] Require PHPUnit 8 like MW core [libs/Services] - 10https://gerrit.wikimedia.org/r/567232 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:43:31] (03CR) 10Jforrester: [C: 03+2] Require PHPUnit 8 like MW core [libs/Timestamp] - 10https://gerrit.wikimedia.org/r/567233 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:43:35] (03Merged) 10jenkins-bot: Require PHPUnit 8 like MW core [libs/Assert] - 10https://gerrit.wikimedia.org/r/567225 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:43:37] (03CR) 10Jforrester: [C: 03+2] Require PHPUnit 8 like MW core [libs/WaitConditionLoop] - 10https://gerrit.wikimedia.org/r/567234 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:43:40] (03CR) 10Jforrester: [C: 03+2] Require PHPUnit 8 like MW core [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/567235 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:43:46] (03Merged) 10jenkins-bot: Require PHPUnit 8 like MW core [libs/PasswordBlacklist] - 10https://gerrit.wikimedia.org/r/567229 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:43:55] (03Merged) 10jenkins-bot: Require PHPUnit 8 like MW core [libs/RemexHtml] - 10https://gerrit.wikimedia.org/r/567230 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:43:57] (03Merged) 10jenkins-bot: Require PHPUnit 8 like MW core [libs/ScopedCallback] - 10https://gerrit.wikimedia.org/r/567231 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:43:59] (03CR) 10Jforrester: [C: 03+2] Require PHPUnit 8 like MW core [tools/phpunit-patch-coverage] - 10https://gerrit.wikimedia.org/r/567236 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:44:01] (03Merged) 10jenkins-bot: Require PHPUnit 8 like MW core [libs/Services] - 10https://gerrit.wikimedia.org/r/567232 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:44:03] (03CR) 10Jforrester: [C: 03+2] Require PHPUnit 8 like MW core [wikimedia/lucene-explain-parser] - 10https://gerrit.wikimedia.org/r/567238 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:44:06] (03Merged) 10jenkins-bot: Require PHPUnit 8 like MW core [libs/Timestamp] - 10https://gerrit.wikimedia.org/r/567233 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:44:11] (03Merged) 10jenkins-bot: Require PHPUnit 8 like MW core [libs/WaitConditionLoop] - 10https://gerrit.wikimedia.org/r/567234 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:44:15] (03Merged) 10jenkins-bot: Require PHPUnit 8 like MW core [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/567235 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:44:25] (03Merged) 10jenkins-bot: Require PHPUnit 8 like MW core [tools/phpunit-patch-coverage] - 10https://gerrit.wikimedia.org/r/567236 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:44:32] (03Merged) 10jenkins-bot: Require PHPUnit 8 like MW core [wikimedia/lucene-explain-parser] - 10https://gerrit.wikimedia.org/r/567238 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:44:51] (03CR) 10Jforrester: [C: 03+2] Require PHPUnit 8 like MW core [utfnormal] - 10https://gerrit.wikimedia.org/r/567209 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:44:55] (03CR) 10Jforrester: [C: 03+2] Require PHPUnit 8 like MW core [AhoCorasick] - 10https://gerrit.wikimedia.org/r/567219 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:44:58] (03CR) 10Jforrester: [C: 03+2] Require PHPUnit 8 like MW core [at-ease] - 10https://gerrit.wikimedia.org/r/567220 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:45:02] (03CR) 10Jforrester: [C: 03+2] Require PHPUnit 8 like MW core [base-convert] - 10https://gerrit.wikimedia.org/r/567221 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:45:06] (03CR) 10Jforrester: [C: 03+2] Require PHPUnit 8 like MW core [cdb] - 10https://gerrit.wikimedia.org/r/567222 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:45:10] (03CR) 10Jforrester: [C: 03+2] Require PHPUnit 8 like MW core [CLDRPluralRuleParser] - 10https://gerrit.wikimedia.org/r/567223 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:45:14] (03CR) 10Jforrester: [C: 03+2] Require PHPUnit 8 like MW core [IPSet] - 10https://gerrit.wikimedia.org/r/567224 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:45:18] (03CR) 10Jforrester: [C: 03+2] Require PHPUnit 8 like MW core [RelPath] - 10https://gerrit.wikimedia.org/r/567237 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:45:22] (03CR) 10Jforrester: [C: 03+2] Require PHPUnit 8 like MW core [WrappedString] - 10https://gerrit.wikimedia.org/r/567239 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:46:04] (03Merged) 10jenkins-bot: Require PHPUnit 8 like MW core [utfnormal] - 10https://gerrit.wikimedia.org/r/567209 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:46:06] (03Merged) 10jenkins-bot: Require PHPUnit 8 like MW core [AhoCorasick] - 10https://gerrit.wikimedia.org/r/567219 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:46:08] (03Merged) 10jenkins-bot: Require PHPUnit 8 like MW core [at-ease] - 10https://gerrit.wikimedia.org/r/567220 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:46:10] (03Merged) 10jenkins-bot: Require PHPUnit 8 like MW core [base-convert] - 10https://gerrit.wikimedia.org/r/567221 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:46:12] (03Merged) 10jenkins-bot: Require PHPUnit 8 like MW core [cdb] - 10https://gerrit.wikimedia.org/r/567222 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:46:15] (03Merged) 10jenkins-bot: Require PHPUnit 8 like MW core [CLDRPluralRuleParser] - 10https://gerrit.wikimedia.org/r/567223 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:46:16] (03Merged) 10jenkins-bot: Require PHPUnit 8 like MW core [IPSet] - 10https://gerrit.wikimedia.org/r/567224 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:46:18] (03Merged) 10jenkins-bot: Require PHPUnit 8 like MW core [RelPath] - 10https://gerrit.wikimedia.org/r/567237 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:46:20] (03Merged) 10jenkins-bot: Require PHPUnit 8 like MW core [WrappedString] - 10https://gerrit.wikimedia.org/r/567239 (https://phabricator.wikimedia.org/T243647) (owner: 10Daimona Eaytoy) [00:46:37] 10MediaWiki-Gerrit-Group-Requests: +2 for Zoranzoki21 in mediawiki/* - https://phabricator.wikimedia.org/T243700 (10Zoranzoki21) >>! In T243700#5832169, @Bawolff wrote: > To be clear, i don't mean to say your patches are unimportant in any way. Part of a +2'ers job is to ensure that code, even simple patches, do... [00:47:50] (03CR) 10Jforrester: [C: 03+2] Remove usage of EditPageBeforeEditToolbar [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/567257 (owner: 10TheDJ) [00:48:13] (03Abandoned) 10Jforrester: Remove use of global $wgUser [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/562071 (https://phabricator.wikimedia.org/T241952) (owner: 10DannyS712) [01:04:50] (03Merged) 10jenkins-bot: Remove usage of EditPageBeforeEditToolbar [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/567257 (owner: 10TheDJ) [01:07:58] (03CR) 10DannyS712: "> Abandoned" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/562071 (https://phabricator.wikimedia.org/T241952) (owner: 10DannyS712) [01:08:46] 10MediaWiki-User-management, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Patch-For-Review, 10Technical-Debt (Deprecation process), 10User-DannyS712: Deprecate $wgUser - https://phabricator.wikimedia.org/T159299 (10DannyS712) [01:14:56] (03PS1) 10DannyS712: [WIP] 1.35 [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/567299 [01:15:36] 10MediaWiki-Core-Testing, 10Core Platform Team, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04): The phpunit wrapper mishandles parsing of --wiki parameter. - https://phabricator.wikimedia.org/T243523 (10Jdforrester-WMF) [01:15:46] 10CheckUser, 10OOUI, 10Anti-Harassment (The Letter Song), 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04): TagMultiselectWidget performs unnecessary validity check in change handler - https://phabricator.wikimedia.org/T243077 (10Jdforrester-WMF) [01:15:50] 10DiscussionTools, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), 10VisualEditor (Current work): Reply added in the wrong place in case of list gap in the discussion - https://phabricator.wikimedia.org/T242822 (10Jdforrester-WMF) [01:15:52] 10MediaWiki-General, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), 10Patch-For-Review, 10Technical-Debt, 10User-DannyS712: Deprecate core fallbacks to $wgUser - https://phabricator.wikimedia.org/T242935 (10Jdforrester-WMF) [01:15:52] (03CR) 10jerkins-bot: [V: 04-1] [WIP] 1.35 [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/567299 (owner: 10DannyS712) [01:15:58] 10MediaWiki-extensions-CentralNotice, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), 10Technical-Debt, 10User-DannyS712: CentralNotice needs uses of global $wgUser replaced - https://phabricator.wikimedia.org/T241615 (10Jdforrester-WMF) [01:16:02] 10CPT Initiatives (Core REST API in PHP), 10Core Platform Team Workboards (Green), 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), 10Story: Reader reads a page offline - https://phabricator.wikimedia.org/T234375 (10Jdforrester-WMF) [01:16:04] 10CheckUser, 10Anti-Harassment (The Letter Song), 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04): Let UsersMultiselectWidget disallow arbitrary input - https://phabricator.wikimedia.org/T238318 (10Jdforrester-WMF) [01:16:10] 10MediaWiki-User-preferences, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), 10Patch-For-Review: In the Prefs, for the time, there are a contradiction and an error - https://phabricator.wikimedia.org/T132264 (10Jdforrester-WMF) [01:16:16] 10RegexBlock: Use GetUserBlock hook instead of deprecated GetBlockedStatus - https://phabricator.wikimedia.org/T236058 (10DannyS712) [01:16:18] 10CPT Initiatives (Core REST API in PHP), 10Core Platform Team Workboards (Green), 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04): Implement get media file endpoint - https://phabricator.wikimedia.org/T236170 (10Jdforrester-WMF) [01:16:20] 10MediaWiki-extensions-General, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), 10Patch-For-Review: Replace IP class with IPUtils - https://phabricator.wikimedia.org/T242556 (10Jdforrester-WMF) [01:16:22] 10CheckUser, 10Anti-Harassment (The Letter Song), 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04): CU 2.0: Fetch information to be displayed in Compare tab - https://phabricator.wikimedia.org/T238714 (10Jdforrester-WMF) [01:16:28] 10MediaWiki-REST-API, 10CPT Initiatives (Core REST API in PHP), 10Core Platform Team Workboards (Green), 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04): Client Developer uses client-side cache - https://phabricator.wikimedia.org/T238374 (10Jdforrester-WMF) [01:16:32] 10MediaWiki-extensions-LiquidThreads, 10MediaWiki-extensions-Maintenance, 10MediaWiki-extensions-UserMerge, 10MediaWiki-extensions-WikibaseClient, and 9 others: Remove Title::moveTo - https://phabricator.wikimedia.org/T221949 (10Jdforrester-WMF) [01:17:57] (03PS2) 10DannyS712: [WIP] 1.35 [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/567299 [01:20:27] (03CR) 10Jforrester: [C: 03+2] Replace usage of deprecated Sanitizer::escapeId() [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/567130 (owner: 10C. Scott Ananian) [01:21:21] (03CR) 10Jforrester: [C: 03+2] Remove Sanitizer::attributeWhitelist()/setupAttributeWhitelist() [core] - 10https://gerrit.wikimedia.org/r/567139 (owner: 10C. Scott Ananian) [01:23:00] (03CR) 10Jforrester: [C: 03+2] Remove unneeded nowiki [extensions/Cite] - 10https://gerrit.wikimedia.org/r/567256 (owner: 10Raimond Spekking) [01:24:06] (03CR) 10Jforrester: [C: 03+2] Mark @internal a number of Parser methods not used outside MW core [core] - 10https://gerrit.wikimedia.org/r/567251 (owner: 10C. Scott Ananian) [01:24:17] (03CR) 10Jforrester: [C: 03+2] Convert OdbcDatabase to use extension registration [extensions/OdbcDatabase] - 10https://gerrit.wikimedia.org/r/567244 (https://phabricator.wikimedia.org/T243683) (owner: 10Zoranzoki21) [01:26:46] (03CR) 10Jforrester: [C: 03+2] Convert OnlineStatusBar to use extension registration [extensions/OnlineStatusBar] - 10https://gerrit.wikimedia.org/r/503686 (https://phabricator.wikimedia.org/T204313) (owner: 10Zoranzoki21) [01:28:42] (03CR) 10Jforrester: Convert OnlineStatus to use extension registration (031 comment) [extensions/OnlineStatus] - 10https://gerrit.wikimedia.org/r/567246 (https://phabricator.wikimedia.org/T204312) (owner: 10Zoranzoki21) [01:30:29] 10MediaWiki-Gerrit-Group-Requests: +2 for Zoranzoki21 in mediawiki/* - https://phabricator.wikimedia.org/T243700 (10Aklapper) Apart from the [Principle of least privilege](https://en.wikipedia.org/wiki/Principle_of_least_privilege), adding two links which might help understand experience when it comes to recogni... [01:33:44] (03Merged) 10jenkins-bot: Replace usage of deprecated Sanitizer::escapeId() [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/567130 (owner: 10C. Scott Ananian) [01:35:41] (03Merged) 10jenkins-bot: Remove Sanitizer::attributeWhitelist()/setupAttributeWhitelist() [core] - 10https://gerrit.wikimedia.org/r/567139 (owner: 10C. Scott Ananian) [01:38:30] (03Merged) 10jenkins-bot: Remove unneeded nowiki [extensions/Cite] - 10https://gerrit.wikimedia.org/r/567256 (owner: 10Raimond Spekking) [01:40:23] (03Merged) 10jenkins-bot: Mark @internal a number of Parser methods not used outside MW core [core] - 10https://gerrit.wikimedia.org/r/567251 (owner: 10C. Scott Ananian) [01:40:25] (03Merged) 10jenkins-bot: Convert OdbcDatabase to use extension registration [extensions/OdbcDatabase] - 10https://gerrit.wikimedia.org/r/567244 (https://phabricator.wikimedia.org/T243683) (owner: 10Zoranzoki21) [01:40:27] (03Merged) 10jenkins-bot: Convert OnlineStatusBar to use extension registration [extensions/OnlineStatusBar] - 10https://gerrit.wikimedia.org/r/503686 (https://phabricator.wikimedia.org/T204313) (owner: 10Zoranzoki21) [01:45:54] (03CR) 10Jforrester: [C: 03+2] Remove Preprocessor_DOM, deprecated in 1.34 [core] - 10https://gerrit.wikimedia.org/r/567150 (https://phabricator.wikimedia.org/T204945) (owner: 10C. Scott Ananian) [01:48:17] (03CR) 10Jforrester: [C: 03+2] UsersMultiselectWidget: Add pre-selected items as options [core] - 10https://gerrit.wikimedia.org/r/567166 (https://phabricator.wikimedia.org/T243643) (owner: 10Tchanders) [02:02:48] (03Merged) 10jenkins-bot: Remove Preprocessor_DOM, deprecated in 1.34 [core] - 10https://gerrit.wikimedia.org/r/567150 (https://phabricator.wikimedia.org/T204945) (owner: 10C. Scott Ananian) [02:04:48] (03CR) 10jerkins-bot: [V: 04-1] UsersMultiselectWidget: Add pre-selected items as options [core] - 10https://gerrit.wikimedia.org/r/567166 (https://phabricator.wikimedia.org/T243643) (owner: 10Tchanders) [02:05:33] (03PS3) 10DannyS712: [WIP] 1.35 [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/567299 [02:06:15] (03CR) 10jerkins-bot: [V: 04-1] [WIP] 1.35 [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/567299 (owner: 10DannyS712) [02:06:32] (03PS4) 10DannyS712: [WIP] 1.35 [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/567299 [02:07:06] (03PS5) 10DannyS712: [WIP] 1.35 [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/567299 [02:10:12] (03PS5) 10DannyS712: Remove SpecialRecentChanges::filterByCategories(), deprecated and unused [core] - 10https://gerrit.wikimedia.org/r/567111 (https://phabricator.wikimedia.org/T241690) [02:17:07] (03CR) 10Jforrester: [C: 04-1] "Needs next OOUI release." [core] - 10https://gerrit.wikimedia.org/r/567173 (https://phabricator.wikimedia.org/T243643) (owner: 10Tchanders) [02:17:48] (03CR) 10Jforrester: [C: 03+2] "…" [core] - 10https://gerrit.wikimedia.org/r/567166 (https://phabricator.wikimedia.org/T243643) (owner: 10Tchanders) [02:19:10] (03PS1) 10DannyS712: Add missing documentation for php functions [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/567301 [02:22:24] (03PS2) 10DannyS712: Add missing documentation for php functions [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/567301 [02:23:02] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/567111 (https://phabricator.wikimedia.org/T241690) (owner: 10DannyS712) [02:23:23] (03CR) 10jerkins-bot: [V: 04-1] Add missing documentation for php functions [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/567301 (owner: 10DannyS712) [02:24:40] (03PS3) 10DannyS712: Add missing documentation for php functions [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/567301 [02:25:36] (03CR) 10jerkins-bot: [V: 04-1] Add missing documentation for php functions [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/567301 (owner: 10DannyS712) [02:34:39] (03Merged) 10jenkins-bot: UsersMultiselectWidget: Add pre-selected items as options [core] - 10https://gerrit.wikimedia.org/r/567166 (https://phabricator.wikimedia.org/T243643) (owner: 10Tchanders) [02:49:29] (03PS1) 10Cicalese: Remove dependency on mw.user. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/567302 [02:52:05] (03PS1) 10Cicalese: Avoid global button:hover CSS [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/567303 (https://phabricator.wikimedia.org/T217955) [02:57:28] (03PS1) 10Brion VIBBER: Get SVGEdit working again, add local copy of app [extensions/SVGEdit] - 10https://gerrit.wikimedia.org/r/567304 [03:00:12] (03CR) 10jerkins-bot: [V: 04-1] Get SVGEdit working again, add local copy of app [extensions/SVGEdit] - 10https://gerrit.wikimedia.org/r/567304 (owner: 10Brion VIBBER) [03:09:54] (03PS2) 10Brion VIBBER: Get SVGEdit working again, add local copy of app [extensions/SVGEdit] - 10https://gerrit.wikimedia.org/r/567304 [03:33:53] (03CR) 10Brion VIBBER: [C: 03+2] "Ah, perfection! "Just works" in Firefox/Chrome, falls back in IE to setting the offset." [core] - 10https://gerrit.wikimedia.org/r/566883 (https://phabricator.wikimedia.org/T18763) (owner: 10Bartosz Dziewoński) [03:34:36] 10MediaWiki-User-preferences, 10Patch-For-Review: Present list of matching timezone locations based on client offset - https://phabricator.wikimedia.org/T18763 (10brion) This is much better than my originally suggested hack. :) +2'ing it. [03:46:59] (03Merged) 10jenkins-bot: mw.special.preferences: Allow filling in real time zone instead of offset [core] - 10https://gerrit.wikimedia.org/r/566883 (https://phabricator.wikimedia.org/T18763) (owner: 10Bartosz Dziewoński) [04:21:53] 04(no projects): Visual Editor should accept pre-formatted references - https://phabricator.wikimedia.org/T243703 (10RoySmith) [04:57:22] 10Internet-Archive, 10InternetArchiveBot: Linking page numbers - https://phabricator.wikimedia.org/T243704 (10Imzadi1979) [06:13:20] (03PS1) 10Ammarpad: Disable parsing of prefs-memberingroups message [core] - 10https://gerrit.wikimedia.org/r/567314 (https://phabricator.wikimedia.org/T142882) [06:14:48] (03CR) 10Samwilson: [C: 03+2] Support MediaWiki 1.31 [extensions/MissedPages] - 10https://gerrit.wikimedia.org/r/567297 (owner: 10Samwilson) [06:18:16] (03Merged) 10jenkins-bot: Support MediaWiki 1.31 [extensions/MissedPages] - 10https://gerrit.wikimedia.org/r/567297 (owner: 10Samwilson) [06:20:28] 10MediaWiki-Special-pages: `usergroups` field label entity-encoded twice in Special:Preferences - https://phabricator.wikimedia.org/T142882 (10Ammarpad) a:03Ammarpad [06:25:46] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/567314 (https://phabricator.wikimedia.org/T142882) (owner: 10Ammarpad) [06:52:35] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/567263 (owner: 10Umherirrender) [06:52:44] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/BlueSpiceInsertCategory] - 10https://gerrit.wikimedia.org/r/567265 (owner: 10Umherirrender) [06:53:00] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/BlueSpiceInsertFile] - 10https://gerrit.wikimedia.org/r/567267 (owner: 10Umherirrender) [06:53:04] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/567263 (owner: 10Umherirrender) [06:53:08] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/BlueSpiceInsertMagic] - 10https://gerrit.wikimedia.org/r/567268 (owner: 10Umherirrender) [06:53:19] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/BlueSpiceInsertLink] - 10https://gerrit.wikimedia.org/r/567266 (owner: 10Umherirrender) [06:53:27] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/BlueSpiceInterWikiLinks] - 10https://gerrit.wikimedia.org/r/567270 (owner: 10Umherirrender) [06:53:32] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/BlueSpiceMultiUpload] - 10https://gerrit.wikimedia.org/r/567271 (owner: 10Umherirrender) [06:53:46] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/BlueSpicePageTemplates] - 10https://gerrit.wikimedia.org/r/567274 (owner: 10Umherirrender) [06:53:56] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/BlueSpicePermissionManager] - 10https://gerrit.wikimedia.org/r/567275 (owner: 10Umherirrender) [06:54:17] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/BlueSpiceReaders] - 10https://gerrit.wikimedia.org/r/567279 (owner: 10Umherirrender) [06:54:25] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/BlueSpiceSaferEdit] - 10https://gerrit.wikimedia.org/r/567280 (owner: 10Umherirrender) [06:54:42] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/BlueSpiceSmartList] - 10https://gerrit.wikimedia.org/r/567281 (owner: 10Umherirrender) [06:54:57] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/BlueSpiceTagCloud] - 10https://gerrit.wikimedia.org/r/567283 (owner: 10Umherirrender) [06:55:38] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/567282 (owner: 10Umherirrender) [06:55:56] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/BlueSpiceRating] - 10https://gerrit.wikimedia.org/r/567278 (owner: 10Umherirrender) [06:56:42] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/BlueSpiceInsertCategory] - 10https://gerrit.wikimedia.org/r/567265 (owner: 10Umherirrender) [06:56:50] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [libs/ObjectFactory] - 10https://gerrit.wikimedia.org/r/567310 (owner: 10Libraryupgrader) [06:57:01] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/BlueSpiceInsertFile] - 10https://gerrit.wikimedia.org/r/567267 (owner: 10Umherirrender) [06:57:03] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/BlueSpiceInsertMagic] - 10https://gerrit.wikimedia.org/r/567268 (owner: 10Umherirrender) [06:57:14] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [css-sanitizer] - 10https://gerrit.wikimedia.org/r/567309 (owner: 10Libraryupgrader) [06:57:36] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [libs/Services] - 10https://gerrit.wikimedia.org/r/567311 (owner: 10Libraryupgrader) [06:58:02] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [libs/Timestamp] - 10https://gerrit.wikimedia.org/r/567312 (owner: 10Libraryupgrader) [07:01:04] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/BlueSpiceInsertLink] - 10https://gerrit.wikimedia.org/r/567266 (owner: 10Umherirrender) [07:01:21] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/567282 (owner: 10Umherirrender) [07:01:22] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/BlueSpiceRating] - 10https://gerrit.wikimedia.org/r/567278 (owner: 10Umherirrender) [07:02:58] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/BlueSpicePrivacy] - 10https://gerrit.wikimedia.org/r/567276 (owner: 10Umherirrender) [07:19:02] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/BlueSpicePrivacy] - 10https://gerrit.wikimedia.org/r/567276 (owner: 10Umherirrender) [07:30:43] (03CR) 10Legoktm: [C: 03+2] Upgrade phan to 0.9.1 [core] - 10https://gerrit.wikimedia.org/r/567128 (owner: 10Daimona Eaytoy) [07:37:33] 10MediaWiki-General, 10Patch-For-Review, 10phan: Make maintenance/findDeprecated use phan instead of php-parser, consider moving to another repo - https://phabricator.wikimedia.org/T243403 (10Legoktm) The Flow script looks ancient and is actually broken, we can safely remove it. [07:40:30] (03PS1) 10Legoktm: Remove obsolete/broken scripts/one-class-per-file.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/567318 [07:42:50] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, 10translatewiki.net: Archive the MWVersionInfo extension - https://phabricator.wikimedia.org/T243670 (10Masumrezarock100) [07:43:17] (03CR) 10Legoktm: [C: 03+2] build: Updating dependencies [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/567316 (owner: 10Libraryupgrader) [07:44:27] (03Merged) 10jenkins-bot: Upgrade phan to 0.9.1 [core] - 10https://gerrit.wikimedia.org/r/567128 (owner: 10Daimona Eaytoy) [07:45:05] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/567318 (owner: 10Legoktm) [07:45:18] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/567316 (owner: 10Libraryupgrader) [07:46:45] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, 10translatewiki.net: Archive the MWVersionInfo extension - https://phabricator.wikimedia.org/T243670 (10Masumrezarock100) [07:48:16] (03PS1) 10DannyS712: [WIP] Tests [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/567320 [07:49:09] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Tests [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/567320 (owner: 10DannyS712) [07:53:43] (03CR) 10DannyS712: "Recheck" [extensions/RegexBlock] (REL1_34) - 10https://gerrit.wikimedia.org/r/567320 (owner: 10DannyS712) [07:58:13] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, 10translatewiki.net: Archive the MWVersionInfo extension - https://phabricator.wikimedia.org/T243670 (10Legoktm) Er, please don't start archiving just yet. The extension, which I mostly finished writing in https://gerrit.wik... [08:03:08] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, 10translatewiki.net: Archive the MWVersionInfo extension - https://phabricator.wikimedia.org/T243670 (10Masumrezarock100) [08:03:55] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, 10translatewiki.net: Archive the MWVersionInfo extension - https://phabricator.wikimedia.org/T243670 (10Masumrezarock100) Erm, sorry about that. I should not have started archiving without clear approval. [08:04:26] (03PS4) 10DannyS712: Add missing documentation for php functions [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/567301 [08:05:20] (03CR) 10jerkins-bot: [V: 04-1] Add missing documentation for php functions [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/567301 (owner: 10DannyS712) [08:06:11] (03PS5) 10DannyS712: Add missing documentation for php functions [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/567301 [08:07:19] (03CR) 10DannyS712: "Recheck" [extensions/MWVersionInfo] - 10https://gerrit.wikimedia.org/r/316241 (owner: 10Legoktm) [08:09:04] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Initial commit [extensions/MWVersionInfo] - 10https://gerrit.wikimedia.org/r/316241 (owner: 10Legoktm) [08:10:34] 10MediaWiki-Gerrit-Group-Requests: +2 for Zoranzoki21 in mediawiki/* - https://phabricator.wikimedia.org/T243700 (10Tgr) [08:11:10] (03CR) 10DannyS712: [C: 03+2] "No changes to code" [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/567301 (owner: 10DannyS712) [08:12:08] 10LibUp: libup error on CirrusSearch due to '*' dependency - https://phabricator.wikimedia.org/T243262 (10Legoktm) 05Open→03Resolved a:03Legoktm [08:12:46] 10LibUp: https://libraryupgrader2.wmflabs.org/library/composer/php should ignore whitespace - https://phabricator.wikimedia.org/T243001 (10Legoktm) Well that's one way to fix it... [08:15:52] (03PS1) 10DannyS712: Misc. tweaks and clean up [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/567321 [08:19:04] (03PS2) 10DannyS712: Misc. tweaks and clean up [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/567321 [08:22:49] 10MediaWiki-Gerrit-Group-Requests: +2 for Zoranzoki21 in mediawiki/* - https://phabricator.wikimedia.org/T243700 (10Tgr) Hi @Zoranzoki21, thanks for all your work on MediaWiki! I tried to look at your +1/-1 votes (not very successfully, Gerrit is crap at mass review of somebody's actions) and they seemed mostly... [08:26:19] (03PS3) 10DannyS712: Minor cleanup to PgnParser class [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/567321 [08:27:49] (03PS1) 10DannyS712: Add a separate ChessBrowserException [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/567322 [08:29:31] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] logging: Remove unused autopatrol code from PatrolLog class [core] - 10https://gerrit.wikimedia.org/r/562409 (owner: 10DannyS712) [08:30:31] (03PS2) 10DannyS712: Add a separate ChessBrowserException [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/567322 [08:37:47] (03PS2) 10DannyS712: Disable parsing of prefs-memberingroups message [core] - 10https://gerrit.wikimedia.org/r/567314 (https://phabricator.wikimedia.org/T142882) (owner: 10Ammarpad) [08:43:30] (03Merged) 10jenkins-bot: logging: Remove unused autopatrol code from PatrolLog class [core] - 10https://gerrit.wikimedia.org/r/562409 (owner: 10DannyS712) [08:47:06] 10MediaWiki-Internationalization, 10Wikidata: Lexemes: in English and qqx only, "unknown language" appears instead of "English" in search, and "Q1860" appears instead of "English" on lexeme pages - https://phabricator.wikimedia.org/T243705 (10Jc86035) [08:48:11] 10MediaWiki-General, 10Technical-Debt: Replace Article::doEditContent() with WikiPage::doEditContent() - https://phabricator.wikimedia.org/T155696 (10DannyS712) [08:48:15] 10MediaWiki-General, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), 10Patch-For-Review, 10Technical-Debt, 10User-DannyS712: Deprecate core fallbacks to $wgUser - https://phabricator.wikimedia.org/T242935 (10DannyS712) [08:49:37] 10MediaWiki-Internationalization, 10Wikidata: Lexemes: in English and qqx only, "unknown language" appears instead of "English" in search, and "Q1860" appears instead of "English" on lexeme pages - https://phabricator.wikimedia.org/T243705 (10Jc86035) [08:51:36] 10MediaWiki-extensions-CentralAuth: CentralAuth error with ppor UX - https://phabricator.wikimedia.org/T243706 (10Tgr) [08:53:00] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/567314 (https://phabricator.wikimedia.org/T142882) (owner: 10Ammarpad) [08:56:42] 10MediaWiki-Internationalization, 10Wikidata: Lexemes: in English, "unknown language" appears instead of "English" in search, and "Q1860" appears instead of "English" on lexeme pages - https://phabricator.wikimedia.org/T243705 (10Jc86035) [08:57:15] 10MediaWiki-Internationalization, 10Wikidata: Lexemes: in English, "unknown language" appears instead of "English" in search, and "Q1860" appears instead of "English" on lexeme pages - https://phabricator.wikimedia.org/T243705 (10Jc86035) [09:16:26] 10MediaWiki-General, 10Technical-Debt: Replace Article::doEditContent() with WikiPage::doEditContent() - https://phabricator.wikimedia.org/T155696 (10DannyS712) Since the functions have the same names, searching for the `->doEditContent\(` returns both the old and the new, and call each needs to be checked: To... [09:26:01] (03PS22) 10DannyS712: Deprecate falling back to $wgUser in some functions [core] - 10https://gerrit.wikimedia.org/r/563759 (https://phabricator.wikimedia.org/T242935) [09:26:25] (03PS23) 10DannyS712: Deprecate falling back to $wgUser in some functions [core] - 10https://gerrit.wikimedia.org/r/563759 (https://phabricator.wikimedia.org/T242935) [09:28:33] (03PS24) 10DannyS712: Deprecate falling back to $wgUser in some functions [core] - 10https://gerrit.wikimedia.org/r/563759 (https://phabricator.wikimedia.org/T242935) [09:42:18] (03PS2) 10DannyS712: build: Updating dependencies [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/567316 (owner: 10Libraryupgrader) [09:45:06] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/563759 (https://phabricator.wikimedia.org/T242935) (owner: 10DannyS712) [09:55:32] 10MediaWiki-General, 10Technical-Debt, 10User-DannyS712: Mediawiki core needs uses of global $wgUser removed - https://phabricator.wikimedia.org/T243708 (10DannyS712) p:05Triage→03Normal [09:57:21] 10MediaWiki-User-management, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Patch-For-Review, 10Technical-Debt (Deprecation process), 10User-DannyS712: Deprecate $wgUser - https://phabricator.wikimedia.org/T159299 (10DannyS712) [09:57:23] 10MediaWiki-API, 10MediaWiki-User-management, 10Core Platform Team Workboards (Clinic Duty Team), 10Technical-Debt (Deprecation process), 10User-DannyS712: Replace $wgUser in core Api modules - https://phabricator.wikimedia.org/T241557 (10DannyS712) [09:57:25] 10MediaWiki-General, 10Technical-Debt, 10User-DannyS712: Mediawiki core needs uses of global $wgUser removed - https://phabricator.wikimedia.org/T243708 (10DannyS712) [09:57:27] 10MediaWiki-General, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), 10Patch-For-Review, 10Technical-Debt, 10User-DannyS712: Deprecate core fallbacks to $wgUser - https://phabricator.wikimedia.org/T242935 (10DannyS712) [09:57:29] 10MediaWiki-API, 10MediaWiki-User-management, 10Core Platform Team Workboards (Clinic Duty Team), 10Technical-Debt (Deprecation process), 10User-DannyS712: Replace $wgUser in core Api modules - https://phabricator.wikimedia.org/T241557 (10DannyS712) [09:57:31] 10MediaWiki-General, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), 10Patch-For-Review, 10Technical-Debt, 10User-DannyS712: Deprecate core fallbacks to $wgUser - https://phabricator.wikimedia.org/T242935 (10DannyS712) [09:58:09] (03PS1) 10DannyS712: FileDeleteForm: Pass output, user, and request to showForm [core] - 10https://gerrit.wikimedia.org/r/567324 (https://phabricator.wikimedia.org/T243708) [10:03:55] (03PS2) 10DannyS712: FileDeleteForm: Pass needed global variables to private functions [core] - 10https://gerrit.wikimedia.org/r/567324 (https://phabricator.wikimedia.org/T243708) [10:13:02] (03PS1) 10DannyS712: ImageBuilder: Update to LocalFile::recordUpload2, pass a user [core] - 10https://gerrit.wikimedia.org/r/567325 (https://phabricator.wikimedia.org/T243708) [10:18:55] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/567324 (https://phabricator.wikimedia.org/T243708) (owner: 10DannyS712) [10:19:13] (03PS2) 10DannyS712: ImageBuilder: Update to LocalFile::recordUpload2, pass a user [core] - 10https://gerrit.wikimedia.org/r/567325 (https://phabricator.wikimedia.org/T243708) [10:19:53] (03CR) 10Daimona Eaytoy: [C: 04-1] "(Restoring my previous CR until the Revision thing is decided)" [core] - 10https://gerrit.wikimedia.org/r/563759 (https://phabricator.wikimedia.org/T242935) (owner: 10DannyS712) [10:22:13] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: wgWikibaseItemId should be available on the edit page - https://phabricator.wikimedia.org/T185437 (10Aschroet) Is there any workaround? [10:23:18] (03CR) 10DannyS712: "> (Restoring my previous CR until the Revision thing is decided)" [core] - 10https://gerrit.wikimedia.org/r/563759 (https://phabricator.wikimedia.org/T242935) (owner: 10DannyS712) [10:23:51] (03CR) 10Daimona Eaytoy: [C: 03+2] "I'd also like to add that IDEs already provide the same functionality." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/567318 (owner: 10Legoktm) [10:27:08] (03CR) 10Daimona Eaytoy: [C: 04-1] "> > (Restoring my previous CR until the Revision thing is decided)" [core] - 10https://gerrit.wikimedia.org/r/563759 (https://phabricator.wikimedia.org/T242935) (owner: 10DannyS712) [10:29:02] (03PS3) 10DannyS712: Remove global $wgUser, replace Article::doEditContent with WikiPage [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/564170 (https://phabricator.wikimedia.org/T242695) [10:29:22] 10MediaWiki-General, 10Patch-For-Review, 10Technical-Debt, 10User-DannyS712: Replace Article::doEditContent() with WikiPage::doEditContent() - https://phabricator.wikimedia.org/T155696 (10DannyS712) [10:30:39] (03PS1) 10Daimona Eaytoy: [WIP] Fix some new phan issues [core] - 10https://gerrit.wikimedia.org/r/567327 [10:30:57] (03PS2) 10Daimona Eaytoy: [WIP] Fix some new phan issues [core] - 10https://gerrit.wikimedia.org/r/567327 [10:34:19] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/567325 (https://phabricator.wikimedia.org/T243708) (owner: 10DannyS712) [10:37:16] (03Merged) 10jenkins-bot: Remove obsolete/broken scripts/one-class-per-file.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/567318 (owner: 10Legoktm) [10:42:04] (03CR) 10jerkins-bot: [V: 04-1] build: Updating composer dependencies [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/567331 (owner: 10Libraryupgrader) [10:44:49] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/567327 (owner: 10Daimona Eaytoy) [10:44:58] (03CR) 10jerkins-bot: [V: 04-1] build: Updating composer dependencies [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/567329 (owner: 10Libraryupgrader) [10:45:41] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Fix some new phan issues [core] - 10https://gerrit.wikimedia.org/r/567327 (owner: 10Daimona Eaytoy) [10:57:35] (03PS1) 10MarcoAurelio: Archive the BlueSpiceMenues repository [extensions/BlueSpiceMenues] - 10https://gerrit.wikimedia.org/r/567333 (https://phabricator.wikimedia.org/T240788) [10:57:53] (03CR) 10MarcoAurelio: [V: 03+2 C: 03+2] Archive the BlueSpiceMenues repository [extensions/BlueSpiceMenues] - 10https://gerrit.wikimedia.org/r/567333 (https://phabricator.wikimedia.org/T240788) (owner: 10MarcoAurelio) [11:03:43] 10Hashtags, 10Google-Code-in-2019: Allow users to customise data granularity for edits over time graph - https://phabricator.wikimedia.org/T239598 (10AdityaJ) For a span of 2 years, user really would not want to view the daily edits but for a span of 100 days they might want to. Therefore, we will provide them... [11:13:03] (03PS1) 10MarcoAurelio: Remove submodule for extension-BlueSpiceMenues [extensions] - 10https://gerrit.wikimedia.org/r/567335 (https://phabricator.wikimedia.org/T240788) [11:13:26] (03CR) 10MarcoAurelio: [V: 03+2 C: 03+2] Remove submodule for extension-BlueSpiceMenues [extensions] - 10https://gerrit.wikimedia.org/r/567335 (https://phabricator.wikimedia.org/T240788) (owner: 10MarcoAurelio) [11:29:53] (03Abandoned) 10Daimona Eaytoy: [WIP] Fix some new phan issues [core] - 10https://gerrit.wikimedia.org/r/567327 (owner: 10Daimona Eaytoy) [11:43:29] 10MediaWiki-Interface, 10Performance-Team, 10User-notice: Remove jquery.checkboxShiftClick from default payload - https://phabricator.wikimedia.org/T232688 (10Amorymeltzer) Anywhere where revision deletion or suppression could be used, it'd be useful, in particular I'm thinking of Special:Log. It's useful o... [11:46:01] 10VideoCutTool: VideoCutTool pending tasks to release version 0.2 - https://phabricator.wikimedia.org/T243589 (10Crutishnyk) My thought about progress bar in step 2: I want to believe that it is not working in production because all video editing progress now are listening via `stderr` channel which is not empty... [11:47:16] 10MediaWiki-Internationalization, 10Lexicographical data, 10Wikidata: Lexemes: in English, "unknown language" appears instead of "English" in search, and "Q1860" appears instead of "English" on lexeme pages - https://phabricator.wikimedia.org/T243705 (10LucasWerkmeister) [12:55:28] (03PS8) 10Daimona Eaytoy: Add RAW_PARAM taint type [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/542953 [12:59:36] (03PS1) 10Ammarpad: Replace deprecated IP class with IP Utilities [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/567336 (https://phabricator.wikimedia.org/T242556) [13:07:47] (03PS2) 10Ammarpad: Replace deprecated IP class with IP Utilities [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/567336 (https://phabricator.wikimedia.org/T242556) [13:09:10] 10MediaWiki-Gerrit-Group-Requests: +2 for Zoranzoki21 in mediawiki/* - https://phabricator.wikimedia.org/T243700 (10Zoranzoki21) >>! In T243700#5832342, @Tgr wrote: > Hi @Zoranzoki21, thanks for all your work on MediaWiki! > > I tried to look at your +1/-1 votes (not very successfully, Gerrit is crap at mass re... [13:11:26] 10Library-Card-Platform, 10good first task: Fix server error on /users/ when site has no coordinators - https://phabricator.wikimedia.org/T226648 (10Samwalton9) 05Open→03Resolved [13:15:07] (03PS9) 10Daimona Eaytoy: Add RAW_PARAM taint type [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/542953 [13:21:48] (03PS1) 10Ammarpad: Replace deprecated IP class with IPUtils [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/567338 (https://phabricator.wikimedia.org/T242556) [13:26:14] (03PS1) 10Daimona Eaytoy: Avoid shelling out to run tests [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/567339 [13:26:41] (03CR) 10jerkins-bot: [V: 04-1] Avoid shelling out to run tests [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/567339 (owner: 10Daimona Eaytoy) [13:28:12] (03PS2) 10Daimona Eaytoy: Avoid shelling out to run tests [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/567339 [13:28:40] (03CR) 10jerkins-bot: [V: 04-1] Avoid shelling out to run tests [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/567339 (owner: 10Daimona Eaytoy) [13:29:06] (03PS3) 10Daimona Eaytoy: Avoid shelling out to run tests [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/567339 [13:29:56] (03CR) 10jerkins-bot: [V: 04-1] Avoid shelling out to run tests [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/567339 (owner: 10Daimona Eaytoy) [13:31:15] (03PS1) 10Ammarpad: Replace deprecated IP class with IP Utilities [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/567340 (https://phabricator.wikimedia.org/T242556) [13:33:11] 10MediaWiki-Interface: Wikipedia main page displays incorrect traanslation for article namespace - https://phabricator.wikimedia.org/T243712 (10Superyetkin) [13:45:29] (03CR) 10Pwirth: [C: 03+2] Use unix newline style in extension.json [extensions/BlueSpiceRSSFeeder] - 10https://gerrit.wikimedia.org/r/567289 (owner: 10Umherirrender) [13:45:56] (03Merged) 10jenkins-bot: Use unix newline style in extension.json [extensions/BlueSpiceRSSFeeder] - 10https://gerrit.wikimedia.org/r/567289 (owner: 10Umherirrender) [13:45:58] (03CR) 10Pwirth: [C: 03+2] build: Use unix newline style in .phpcs.xml [extensions/BlueSpicePageAccess] - 10https://gerrit.wikimedia.org/r/567285 (owner: 10Umherirrender) [13:46:10] (03CR) 10Pwirth: [C: 03+2] build: Use unix newline style in .phpcs.xml [extensions/BlueSpiceSocialResolve] - 10https://gerrit.wikimedia.org/r/567288 (owner: 10Umherirrender) [13:46:15] (03CR) 10Pwirth: [C: 03+2] build: Use unix newline style in .phpcs.xml [extensions/BlueSpiceSocialBlog] - 10https://gerrit.wikimedia.org/r/567286 (owner: 10Umherirrender) [13:46:19] (03CR) 10Pwirth: [C: 03+2] build: Use unix newline style in .phpcs.xml [extensions/BlueSpiceSocialComments] - 10https://gerrit.wikimedia.org/r/567287 (owner: 10Umherirrender) [13:46:34] (03CR) 10Pwirth: [C: 03+2] Use unix newline style in extension.json [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/567291 (owner: 10Umherirrender) [13:46:43] (03CR) 10Pwirth: [C: 03+2] Use unix newline style in Config.class.php [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/567292 (owner: 10Umherirrender) [13:46:53] (03PS1) 10Pwirth: Use unix newline style in Config.class.php [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/567341 [13:47:03] (03CR) 10Pwirth: [V: 03+2 C: 03+2] Use unix newline style in Config.class.php [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/567341 (owner: 10Pwirth) [13:48:22] (03CR) 10Pwirth: [V: 03+2 C: 03+2] "known issue, force merge" [extensions/BlueSpiceEditNotifyConnector] - 10https://gerrit.wikimedia.org/r/567284 (owner: 10Umherirrender) [13:49:20] (03CR) 10Pwirth: "recheck" [extensions/BlueSpicePageFormsConnector] - 10https://gerrit.wikimedia.org/r/567272 (owner: 10Umherirrender) [13:49:48] (03Merged) 10jenkins-bot: build: Use unix newline style in .phpcs.xml [extensions/BlueSpicePageAccess] - 10https://gerrit.wikimedia.org/r/567285 (owner: 10Umherirrender) [13:52:36] (03Merged) 10jenkins-bot: build: Use unix newline style in .phpcs.xml [extensions/BlueSpiceSocialResolve] - 10https://gerrit.wikimedia.org/r/567288 (owner: 10Umherirrender) [13:53:07] (03Merged) 10jenkins-bot: build: Use unix newline style in .phpcs.xml [extensions/BlueSpiceSocialBlog] - 10https://gerrit.wikimedia.org/r/567286 (owner: 10Umherirrender) [13:56:20] (03Merged) 10jenkins-bot: build: Use unix newline style in .phpcs.xml [extensions/BlueSpiceSocialComments] - 10https://gerrit.wikimedia.org/r/567287 (owner: 10Umherirrender) [13:56:22] (03Merged) 10jenkins-bot: Use unix newline style in extension.json [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/567291 (owner: 10Umherirrender) [13:56:23] (03Merged) 10jenkins-bot: Use unix newline style in Config.class.php [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/567292 (owner: 10Umherirrender) [14:05:46] (03CR) 10Fomafix: "> Patch Set 16:" [core] - 10https://gerrit.wikimedia.org/r/493162 (https://phabricator.wikimedia.org/T121979) (owner: 10Fomafix) [14:06:03] (03PS17) 10Fomafix: Strip additional special Unicode characters from title [core] - 10https://gerrit.wikimedia.org/r/493162 (https://phabricator.wikimedia.org/T121979) [14:11:11] Crutishnyk: Hi, I just tested your new patch in production, video encoding progress bar is not working in production due to some unknown reason :| (T243589) [14:11:12] T243589: VideoCutTool pending tasks to release version 0.2 - https://phabricator.wikimedia.org/T243589 [14:13:11] 10VideoCutTool: VideoCutTool pending tasks to release version 0.2 - https://phabricator.wikimedia.org/T243589 (10Gopavasanth) Hi @Crutishnyk, I just tested your new patch in production, for video encodings progress bar is not working in production due to some unknown reason :| [14:14:38] 10MediaWiki-extensions-OnlineStatusBar, 10Patch-For-Review, 10User-Zoranzoki21: Convert OnlineStatusBar to use extension registration - https://phabricator.wikimedia.org/T204313 (10Zoranzoki21) 05Open→03Resolved [14:14:40] 10MediaWiki-Configuration, 10MediaWiki-extensions-General, 10Goal, 10Google-Code-in-2019, 10User-Zoranzoki21: Convert all extensions and skins on gerrit to use extension registration - https://phabricator.wikimedia.org/T98668 (10Zoranzoki21) [14:14:47] 10MediaWiki-extensions-Other, 10Patch-For-Review, 10User-Zoranzoki21: Convert OdbcDatabase to use extension registration - https://phabricator.wikimedia.org/T243683 (10Zoranzoki21) 05Open→03Resolved [14:14:49] 10MediaWiki-Configuration, 10MediaWiki-extensions-General, 10Goal, 10Google-Code-in-2019, 10User-Zoranzoki21: Convert all extensions and skins on gerrit to use extension registration - https://phabricator.wikimedia.org/T98668 (10Zoranzoki21) [14:16:05] Seeing GCI people working on stuff and me just be over here, dying with schoolwork be like [14:16:31] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, 10translatewiki.net: Archive the Semantic Social Profile extension - https://phabricator.wikimedia.org/T241916 (10Zoranzoki21) [14:17:53] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Archive the Semantic Social Profile extension - https://phabricator.wikimedia.org/T241916 (10Zoranzoki21) a:03Zoranzoki21 I will do other things. I don't see anyone objecting. [14:19:03] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/493162 (https://phabricator.wikimedia.org/T121979) (owner: 10Fomafix) [14:20:56] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Archive the Semantic Social Profile extension - https://phabricator.wikimedia.org/T241916 (10Zoranzoki21) [14:25:12] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, 10translatewiki.net: Archive the Semantic Social Profile extension - https://phabricator.wikimedia.org/T241916 (10Zoranzoki21) 05Open→03Resolved a:05Zoranzoki21→03None I don't see something what we can do. Extension i... [14:25:25] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, 10translatewiki.net: Archive the Semantic Social Profile extension - https://phabricator.wikimedia.org/T241916 (10Zoranzoki21) [14:27:08] 10MediaWiki-extensions-Other: Convert CreateAPage to use extension registration - https://phabricator.wikimedia.org/T240791 (10Zoranzoki21) 05Open→03Declined a:05Zoranzoki21→03None Declined as this can't be done right now. [14:27:11] 10MediaWiki-Configuration, 10MediaWiki-extensions-General, 10Goal, 10Google-Code-in-2019, 10User-Zoranzoki21: Convert all extensions and skins on gerrit to use extension registration - https://phabricator.wikimedia.org/T98668 (10Zoranzoki21) [14:30:45] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, 10Patch-For-Review: Archive the EditAccount extension - https://phabricator.wikimedia.org/T221494 (10Zoranzoki21) [14:49:49] (03PS1) 10Pwirth: Use Tagintegration for tag NoExport [extensions/BlueSpiceUniversalExport] - 10https://gerrit.wikimedia.org/r/567342 [15:10:58] 10MediaWiki-extensions-PropertySuggester, 10Wikidata, 10Wikidata-Trailblazing-Exploration, 10Patch-For-Review, 10Proposal: [RfC] Property suggester suggests human properties for non-human items - https://phabricator.wikimedia.org/T132839 (10Lydia_Pintscher) There is no separate ticket I'm aware of. I am... [15:14:28] (03CR) 10Daimona Eaytoy: [C: 04-1] "FTR: I've spent way too much time investigating. Phan saves some data in private static variables, and those aren't cleared between tests," [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/567339 (owner: 10Daimona Eaytoy) [15:20:02] (03CR) 10Florianschmidtwelzow: "Fun fact: I got an e-mail in my gerrit e-mail inbox and clicked on the link. I reviewed all the changes in this change here and also check" [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/460768 (https://phabricator.wikimedia.org/T204456) (owner: 10Florianschmidtwelzow) [16:11:10] 10MediaWiki-Interface: Wikipedia main page displays incorrect traanslation for article namespace - https://phabricator.wikimedia.org/T243712 (10Pols12) BaRaN6161_TURK has turned [[https://translatewiki.net/w/i.php?title=Wikimedia:Portals-wiki.entries/tr&diff=next&oldid=7308986 | “madde” into “makaleler”]] on Sep... [16:12:36] (03CR) 10Siebrand: [C: 03+2] MessagesCkb.php: Add magicWord "#REDIRECT" with translation word [core] - 10https://gerrit.wikimedia.org/r/567242 (https://phabricator.wikimedia.org/T243680) (owner: 10Zoranzoki21) [16:23:49] (03CR) 10Siebrand: [C: 03+2] Renamed .inc files to .php [core] - 10https://gerrit.wikimedia.org/r/563710 (owner: 10Ary1733) [16:24:44] (03PS13) 10Siebrand: Renamed .inc files to .php [core] - 10https://gerrit.wikimedia.org/r/563710 (owner: 10Ary1733) [16:24:58] (03CR) 10Huji: [C: 03+2] Replace deprecated IP class with IP Utilities [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/567336 (https://phabricator.wikimedia.org/T242556) (owner: 10Ammarpad) [16:25:37] (03CR) 10Siebrand: [C: 03+2] "Whoops. I accidentally hit a wrong button there. Created a new revision so this hopefully will not be merged." [core] - 10https://gerrit.wikimedia.org/r/563710 (owner: 10Ary1733) [16:27:59] (03PS14) 10Siebrand: Renamed .inc files to .php [core] - 10https://gerrit.wikimedia.org/r/563710 (owner: 10Ary1733) [16:28:00] 04(no projects): Time-out error - https://phabricator.wikimedia.org/T243713 (10JEumerus) [16:28:31] 10MediaWiki-Interface: Wikipedia main page displays incorrect translation for article namespace - https://phabricator.wikimedia.org/T243712 (10Dinoguy1000) [16:28:50] (03CR) 10Siebrand: "Looks like Zuul went ahead with a commit message only change. I added a trailing space to .phan/config.php. That hopefully constitutes a c" [core] - 10https://gerrit.wikimedia.org/r/563710 (owner: 10Ary1733) [16:29:05] (03Merged) 10jenkins-bot: MessagesCkb.php: Add magicWord "#REDIRECT" with translation word [core] - 10https://gerrit.wikimedia.org/r/567242 (https://phabricator.wikimedia.org/T243680) (owner: 10Zoranzoki21) [16:31:50] 04(no projects): Time-out error - https://phabricator.wikimedia.org/T243713 (10JEumerus) [16:32:56] 10Performance Issue: Time-out error - https://phabricator.wikimedia.org/T243713 (10JEumerus) [16:33:06] (03Merged) 10jenkins-bot: Replace deprecated IP class with IP Utilities [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/567336 (https://phabricator.wikimedia.org/T242556) (owner: 10Ammarpad) [16:42:23] (03CR) 10jerkins-bot: [V: 04-1] Renamed .inc files to .php [core] - 10https://gerrit.wikimedia.org/r/563710 (owner: 10Ary1733) [16:43:53] (03CR) 10Siebrand: "PS 15 removes the trailing space that was introduced to block a merge after an erroneous +2 for PS 12." [core] - 10https://gerrit.wikimedia.org/r/563710 (owner: 10Ary1733) [16:44:07] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/563710 (owner: 10Ary1733) [16:44:24] (03PS15) 10Siebrand: Renamed .inc files to .php [core] - 10https://gerrit.wikimedia.org/r/563710 (owner: 10Ary1733) [16:44:36] 10Performance Issue: Time-out error - https://phabricator.wikimedia.org/T243713 (10GPSLeo) Since about two hours I also have timeouts on API and webpage. (Location Berlin) The Grafana boards also show low edit rates and API requests and HTTP Errors. [16:52:25] 10MediaWiki-Special-pages, 10MediaWiki-extensions-Translate, 10I18n: Allow to hide translations on special page "WhatLinksHere" - https://phabricator.wikimedia.org/T216368 (10Nikerabbit) If it need to be done with SQL, perhaps setting a prop in page_props (or revtag) could make it fast and accurate enough? [16:53:22] 10Performance Issue, 10Wikimedia-production-error: Time-out error - https://phabricator.wikimedia.org/T243713 (10Reedy) [16:56:49] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/563710 (owner: 10Ary1733) [16:58:48] 10MediaWiki-Interface: Wikipedia main page displays incorrect translation for article namespace - https://phabricator.wikimedia.org/T243712 (10Superyetkin) 05Open→03Resolved a:03Superyetkin Change undone, thanks. [17:13:16] 10Wikimedia-Site-requests: Enable AddThis extension on hywiki - https://phabricator.wikimedia.org/T243714 (10Ashot1997) [17:30:15] (03PS1) 10Kotovalexarian: Fix location and hometown display [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/567349 [17:58:09] 10Wikimedia-Site-requests: Enable AddThis extension on hywiki - https://phabricator.wikimedia.org/T243714 (10MarcoAurelio) 05Open→03Declined Hello @Ashot1997. The [[ https://www.mediawiki.org/wiki/Extension:AddThis | AddThis ]] extension is [[ https://phabricator.wikimedia.org/source/mediawiki-config/browse/... [18:10:47] 04(no projects): Fix float dropdown user menu - https://phabricator.wikimedia.org/T243716 (10A-NEUN) [18:11:56] 04(no projects): Fix float dropdown user menu - https://phabricator.wikimedia.org/T243716 (10A-NEUN) p:05Triage→03Low [18:14:05] (03PS3) 10Umherirrender: build: Updating dependencies [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/567316 (owner: 10Libraryupgrader) [18:14:49] (03CR) 10Umherirrender: [C: 03+2] build: Updating dependencies [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/566926 (owner: 10Libraryupgrader) [18:16:50] (03CR) 10Umherirrender: [C: 03+2] Replace deprecated IP class with IP Utilities [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/567340 (https://phabricator.wikimedia.org/T242556) (owner: 10Ammarpad) [18:18:10] (03CR) 10Umherirrender: [C: 03+2] Replace deprecated IP class with IPUtils [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/567338 (https://phabricator.wikimedia.org/T242556) (owner: 10Ammarpad) [18:18:33] (03CR) 10Umherirrender: [C: 03+2] build: Updating dependencies [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/567316 (owner: 10Libraryupgrader) [18:19:09] 10MediaWiki-User-preferences, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04): In the Prefs, for the time, there are a contradiction and an error - https://phabricator.wikimedia.org/T132264 (10matmarex) 05Open→03Resolved [18:19:25] 10MediaWiki-User-preferences: Present list of matching timezone locations based on client offset - https://phabricator.wikimedia.org/T18763 (10matmarex) 05Open→03Resolved Thanks! [18:20:27] 10MediaWiki-User-preferences: Present list of matching timezone locations based on client offset - https://phabricator.wikimedia.org/T18763 (10matmarex) 05Resolved→03Declined (I guess this is more appropriate? I don't want to rewrite the whole description :) ) [18:20:35] (03Merged) 10jenkins-bot: Replace deprecated IP class with IP Utilities [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/567340 (https://phabricator.wikimedia.org/T242556) (owner: 10Ammarpad) [18:21:05] (03Merged) 10jenkins-bot: Replace deprecated IP class with IPUtils [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/567338 (https://phabricator.wikimedia.org/T242556) (owner: 10Ammarpad) [18:22:22] (03PS2) 10Daimona Eaytoy: build: Updating composer dependencies [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/567331 (owner: 10Libraryupgrader) [18:24:48] (03PS2) 10Daimona Eaytoy: build: Updating composer dependencies [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/567329 (owner: 10Libraryupgrader) [18:25:32] 04(no projects): Fix float dropdown user menu - https://phabricator.wikimedia.org/T243716 (10A-NEUN) 05Open→03Resolved Fixed in D1175 [18:30:43] 10LibUp: libup should not assume Gruntfile.js exists everywhere - https://phabricator.wikimedia.org/T243717 (10Umherirrender) [18:32:02] (03CR) 10MusikAnimal: [C: 03+2] Use `Special:MyLanguage/...` for notification link [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/567191 (https://phabricator.wikimedia.org/T243653) (owner: 10DannyS712) [18:36:32] (03Merged) 10jenkins-bot: Use `Special:MyLanguage/...` for notification link [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/567191 (https://phabricator.wikimedia.org/T243653) (owner: 10DannyS712) [18:48:25] 10LibUp: libup web ui returns sometimes 500 Internal Server Error - https://phabricator.wikimedia.org/T243718 (10Umherirrender) [18:48:52] 10LibUp: libup has problems to run karma - https://phabricator.wikimedia.org/T243719 (10Umherirrender) [18:50:08] (03CR) 10Umherirrender: [C: 03+2] Reorder files into the directories [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/560333 (owner: 10Zoranzoki21) [18:53:30] (03Merged) 10jenkins-bot: Reorder files into the directories [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/560333 (owner: 10Zoranzoki21) [18:55:26] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/567350 [18:57:59] (03CR) 10Jack Phoenix: [C: 04-1] "Hi and thanks for the patch! Some notes/questions:" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/567349 (owner: 10Kotovalexarian) [18:58:01] 10MediaWiki-Internationalization: Wikipedia main page displays incorrect translation for article namespace - https://phabricator.wikimedia.org/T243712 (10Pols12) [18:58:34] (03PS1) 10Zoranzoki21: WIP [core] - 10https://gerrit.wikimedia.org/r/567352 [18:59:35] (03Abandoned) 10Zoranzoki21: WIP [core] - 10https://gerrit.wikimedia.org/r/567352 (owner: 10Zoranzoki21) [19:00:55] (03CR) 10Anomie: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 (031 comment) [css-sanitizer] - 10https://gerrit.wikimedia.org/r/567309 (owner: 10Libraryupgrader) [19:00:57] (03PS1) 10Anomie: Cleanup after If667bb0e [css-sanitizer] - 10https://gerrit.wikimedia.org/r/567353 [19:02:51] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/567354 [19:09:09] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] ""Out of memory". That's something different." [extensions/BlueSpicePageFormsConnector] - 10https://gerrit.wikimedia.org/r/567272 (owner: 10Umherirrender) [19:09:20] 10MediaWiki-Codesniffer: Autofix of sniff MediaWiki.Commenting.DocComment fails / produce invalid file - https://phabricator.wikimedia.org/T243721 (10Umherirrender) [19:10:01] 10LibUp: libup web ui returns sometimes 500 Internal Server Error - https://phabricator.wikimedia.org/T243718 (10Umherirrender) On Html2Wiki there is an issue with autofix - T243721 - but I have no idea if that produce the error in the web ui [19:11:54] (03CR) 10Thiemo Kreuz (WMDE): build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 (032 comments) [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/567354 (owner: 10Umherirrender) [19:12:32] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/567350 (owner: 10Umherirrender) [19:13:43] 10Performance Issue, 10Wikimedia-production-error: Time-out error - https://phabricator.wikimedia.org/T243713 (10Vachovec1) T242501 is most probably unrelated. This was a major outage affecting most of Europe (e. g. problems in esams / Amsterdam datacenter). Now it seems to be finally over. I am from Czech r... [19:15:59] 04(no projects): wgRelevantUserName is unevenly defined between Special:Block and Special:DeletedContributions - https://phabricator.wikimedia.org/T243722 (10Amorymeltzer) [19:16:19] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/567355 [19:17:38] 10MediaWiki-extensions-LoginNotify, 10Community-Tech, 10MW-1.35-notes (1.35.0-wmf.18; 2020-02-04), 10User-DannyS712: LoginNotify: Link to `Special:MyLanguage` for help page - https://phabricator.wikimedia.org/T243653 (10DannyS712) 05Open→03Resolved [19:20:08] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/567350 (owner: 10Umherirrender) [19:21:56] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/Popups] - 10https://gerrit.wikimedia.org/r/567356 [19:24:38] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/Popups] - 10https://gerrit.wikimedia.org/r/567356 (owner: 10Umherirrender) [19:25:30] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/BlueSpicePageFormsConnector] - 10https://gerrit.wikimedia.org/r/567272 (owner: 10Umherirrender) [19:25:58] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/567356 (owner: 10Umherirrender) [19:26:25] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/567358 [19:27:11] 10LibUp: libup web ui returns sometimes 500 Internal Server Error - https://phabricator.wikimedia.org/T243718 (10Umherirrender) Another one: https://libraryupgrader2.wmflabs.org/r/mediawiki/services/parsoid [19:30:27] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [libs/LangConv] - 10https://gerrit.wikimedia.org/r/567359 [19:51:43] (03CR) 10Umherirrender: "recheck" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/567356 (owner: 10Umherirrender) [19:52:47] (03CR) 10Umherirrender: [C: 03+2] Cleanup after If667bb0e [css-sanitizer] - 10https://gerrit.wikimedia.org/r/567353 (owner: 10Anomie) [19:53:29] (03Merged) 10jenkins-bot: Cleanup after If667bb0e [css-sanitizer] - 10https://gerrit.wikimedia.org/r/567353 (owner: 10Anomie) [19:58:58] (03CR) 10Umherirrender: "Just remove yourself from CR+2 to avoid merge, the tests are still run in the gate-and-submit queue but it is not merged after that." [core] - 10https://gerrit.wikimedia.org/r/563710 (owner: 10Ary1733) [19:59:40] (03PS2) 10Kotovalexarian: Fix location and hometown display [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/567349 [20:04:36] 10MediaWiki-General: wgRelevantUserName is unevenly defined between Special:Block and Special:DeletedContributions - https://phabricator.wikimedia.org/T243722 (10Masumrezarock100) [20:06:12] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/BlueSpicePageAccess] - 10https://gerrit.wikimedia.org/r/567361 [20:08:40] (03CR) 10Subramanya Sastry: [C: 03+2] Avoid O(N) substr and array_splice operations [libs/LangConv] - 10https://gerrit.wikimedia.org/r/560424 (owner: 10C. Scott Ananian) [20:08:41] (03CR) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 (031 comment) [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/567354 (owner: 10Umherirrender) [20:09:20] (03CR) 10Subramanya Sastry: [C: 03+2] Execute FST in depth-first order rather than breadth-first [libs/LangConv] - 10https://gerrit.wikimedia.org/r/560436 (owner: 10C. Scott Ananian) [20:09:28] (03CR) 10Subramanya Sastry: [C: 03+2] Inline the $emit method [libs/LangConv] - 10https://gerrit.wikimedia.org/r/560440 (owner: 10C. Scott Ananian) [20:09:39] (03Merged) 10jenkins-bot: Avoid O(N) substr and array_splice operations [libs/LangConv] - 10https://gerrit.wikimedia.org/r/560424 (owner: 10C. Scott Ananian) [20:09:41] (03Merged) 10jenkins-bot: Inline the $save method. [libs/LangConv] - 10https://gerrit.wikimedia.org/r/560425 (owner: 10C. Scott Ananian) [20:09:43] (03Merged) 10jenkins-bot: Add `composer phpunit` so we can run unit tests w/o having lint-free code [libs/LangConv] - 10https://gerrit.wikimedia.org/r/560435 (owner: 10C. Scott Ananian) [20:10:05] (03Merged) 10jenkins-bot: Execute FST in depth-first order rather than breadth-first [libs/LangConv] - 10https://gerrit.wikimedia.org/r/560436 (owner: 10C. Scott Ananian) [20:10:07] (03Merged) 10jenkins-bot: Inline the $reset method [libs/LangConv] - 10https://gerrit.wikimedia.org/r/560437 (owner: 10C. Scott Ananian) [20:10:17] (03Merged) 10jenkins-bot: Inline the $emit method [libs/LangConv] - 10https://gerrit.wikimedia.org/r/560440 (owner: 10C. Scott Ananian) [20:11:15] 10LibUp: libup should not assume Gruntfile.js exists everywhere - https://phabricator.wikimedia.org/T243717 (10Umherirrender) MobileFrontend would have the same error, but fails at other location for the moment - https://libraryupgrader2.wmflabs.org/r/mediawiki/extensions/MobileFrontend ` After I built the ass... [20:15:13] 10MediaWiki-General: $wgUrlProtocols [] = '/' breaks wikilinks to subpages since MW 1.32 or 1.33 - https://phabricator.wikimedia.org/T243724 (10alex-mashin) [20:17:56] (03CR) 10Subramanya Sastry: [C: 03+2] Support `html+untidy` tests and version flag in parserTests file [core] - 10https://gerrit.wikimedia.org/r/461797 (https://phabricator.wikimedia.org/T174199) (owner: 10C. Scott Ananian) [20:19:28] (03CR) 10Subramanya Sastry: [C: 03+2] Update parserTests to v2 format (default html/php tests to tidy) [core] - 10https://gerrit.wikimedia.org/r/565146 (https://phabricator.wikimedia.org/T174199) (owner: 10C. Scott Ananian) [20:20:52] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [libs/LangConv] - 10https://gerrit.wikimedia.org/r/567359 [20:34:29] (03Merged) 10jenkins-bot: Support `html+untidy` tests and version flag in parserTests file [core] - 10https://gerrit.wikimedia.org/r/461797 (https://phabricator.wikimedia.org/T174199) (owner: 10C. Scott Ananian) [20:35:58] (03CR) 10jerkins-bot: [V: 04-1] Update parserTests to v2 format (default html/php tests to tidy) [core] - 10https://gerrit.wikimedia.org/r/565146 (https://phabricator.wikimedia.org/T174199) (owner: 10C. Scott Ananian) [20:43:00] (03CR) 10Jforrester: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/567358 (owner: 10Umherirrender) [20:43:25] (03CR) 10Jforrester: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/Popups] - 10https://gerrit.wikimedia.org/r/567356 (owner: 10Umherirrender) [20:44:28] (03CR) 10Jforrester: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 (032 comments) [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/567354 (owner: 10Umherirrender) [20:44:47] (03CR) 10Jforrester: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/BlueSpicePageAccess] - 10https://gerrit.wikimedia.org/r/567361 (owner: 10Umherirrender) [20:49:42] (03PS2) 10Jforrester: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/567355 (owner: 10Umherirrender) [20:49:51] (03CR) 10Jforrester: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 (031 comment) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/567355 (owner: 10Umherirrender) [20:50:15] (03CR) 10Jforrester: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [libs/LangConv] - 10https://gerrit.wikimedia.org/r/567359 (owner: 10Umherirrender) [20:51:07] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [libs/LangConv] - 10https://gerrit.wikimedia.org/r/567359 (owner: 10Umherirrender) [20:55:54] (03CR) 10Jforrester: "recheck" [extensions/BlueSpicePageFormsConnector] - 10https://gerrit.wikimedia.org/r/567272 (owner: 10Umherirrender) [20:57:12] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/567358 (owner: 10Umherirrender) [20:57:13] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/Popups] - 10https://gerrit.wikimedia.org/r/567356 (owner: 10Umherirrender) [20:57:15] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/567354 (owner: 10Umherirrender) [20:57:18] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/BlueSpicePageAccess] - 10https://gerrit.wikimedia.org/r/567361 (owner: 10Umherirrender) [20:57:20] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 29.0.0 [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/567355 (owner: 10Umherirrender) [21:01:37] (03CR) 10Jforrester: [C: 03+2] build: Updating composer dependencies [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/567331 (owner: 10Libraryupgrader) [21:01:39] (03CR) 10Jforrester: [C: 03+2] build: Updating composer dependencies [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/567329 (owner: 10Libraryupgrader) [21:02:10] (03CR) 10Jforrester: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/560000 (owner: 10Libraryupgrader) [21:08:52] (03PS1) 10Krinkle: Lower timeout for API reqs from Babel from 10s to 0.5s [extensions/Babel] - 10https://gerrit.wikimedia.org/r/567366 [21:09:19] (03PS1) 10Krinkle: Lower timeout for API reqs from Babel from 10s to 0.5s [extensions/Babel] (wmf/1.35.0-wmf.16) - 10https://gerrit.wikimedia.org/r/567367 [21:09:33] (03PS1) 10Krinkle: Lower timeout for API reqs from Babel from 10s to 0.5s [extensions/Babel] (wmf/1.35.0-wmf.15) - 10https://gerrit.wikimedia.org/r/567368 [21:10:38] 10MediaWiki-Interface, 10Performance-Team, 10User-notice: Remove jquery.checkboxShiftClick from default payload - https://phabricator.wikimedia.org/T232688 (10JJMC89) >>! In T232688#5832501, @Amorymeltzer wrote: > I believe the checkboxes on Special:Contribs are due to a userscript. Oh, you're right. [21:11:27] (03PS2) 10Krinkle: Lower timeout for API reqs from Babel from 10s to 1s [extensions/Babel] - 10https://gerrit.wikimedia.org/r/567366 [21:11:37] (03PS2) 10Krinkle: Lower timeout for API reqs from Babel from 10s to 1s [extensions/Babel] (wmf/1.35.0-wmf.16) - 10https://gerrit.wikimedia.org/r/567367 [21:11:48] (03PS2) 10Krinkle: Lower timeout for API reqs from Babel from 10s to 1s [extensions/Babel] (wmf/1.35.0-wmf.15) - 10https://gerrit.wikimedia.org/r/567368 [21:15:00] (03CR) 10Legoktm: [C: 03+2] Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/567296 (owner: 10SLF bot) [21:16:20] (03CR) 10Legoktm: "Can I get a +2 please? :)" [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/560960 (https://phabricator.wikimedia.org/T241522) (owner: 10Legoktm) [21:17:13] (03CR) 10Legoktm: "Is there a corresponding bug for this?" [extensions/Babel] - 10https://gerrit.wikimedia.org/r/567366 (owner: 10Krinkle) [21:18:33] (03Merged) 10jenkins-bot: Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/567296 (owner: 10SLF bot) [21:24:06] (03CR) 10Legoktm: "For reference, I used 10 because that's what Aaron had asked me to use in GlobalUserPage's cross-wiki API requests." [extensions/Babel] - 10https://gerrit.wikimedia.org/r/567366 (owner: 10Krinkle) [21:28:13] (03PS1) 10Ammarpad: Update extension.json schema to v2 [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/567369 (https://phabricator.wikimedia.org/T234114) [21:29:52] (03CR) 10Jforrester: [C: 03+1] "Fiiiine. :-)" [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/560960 (https://phabricator.wikimedia.org/T241522) (owner: 10Legoktm) [21:34:09] (03CR) 10Jforrester: [C: 03+2] Remove all traces of preprocessorClass from $wgParserConf (031 comment) [core] - 10https://gerrit.wikimedia.org/r/567153 (https://phabricator.wikimedia.org/T204945) (owner: 10C. Scott Ananian) [21:35:51] (03CR) 10Jforrester: Remove $wgMaxGeneratedPPNodeCount (031 comment) [core] - 10https://gerrit.wikimedia.org/r/567156 (https://phabricator.wikimedia.org/T204945) (owner: 10C. Scott Ananian) [21:36:29] (03CR) 10Jforrester: Remove $wgMaxGeneratedPPNodeCount (031 comment) [core] - 10https://gerrit.wikimedia.org/r/567156 (https://phabricator.wikimedia.org/T204945) (owner: 10C. Scott Ananian) [21:37:59] (03CR) 10Jforrester: [C: 03+2] selenium: Replace wdio-chromedriver with ./selenium.sh script [core] - 10https://gerrit.wikimedia.org/r/558617 (https://phabricator.wikimedia.org/T234610) (owner: 10Krinkle) [21:38:11] 10MediaWiki-extensions-Babel: Babel should get cross-wiki languages via DB instead of making an HTTP request - https://phabricator.wikimedia.org/T243726 (10Bawolff) [21:38:13] 10MediaWiki-extensions-Babel: Babel should get cross-wiki languages via DB instead of making an HTTP request - https://phabricator.wikimedia.org/T243726 (10Legoktm) a:03Legoktm [21:39:31] 10Wikimedia-Site-requests: Internal API HTTP requests should hit the app server internal service IP, not the public HTTPS URL - https://phabricator.wikimedia.org/T243727 (10Legoktm) [21:44:42] 10Wikimedia-Site-requests: Internal API HTTP requests should hit the app server internal service IP, not the public HTTPS URL - https://phabricator.wikimedia.org/T243727 (10Bawolff) The one's I can think of off the top of my head: * Commons file descriptions (wmf-config/filebackend.php) * GlobalUserPage * Babel... [21:47:16] 10Wikimedia-Site-requests: Internal API HTTP requests should hit the app server internal service IP, not the public HTTPS URL - https://phabricator.wikimedia.org/T243727 (10Jdforrester-WMF) [21:47:18] 10MediaWiki-extensions-Babel: Babel should get cross-wiki languages via DB instead of making an HTTP request - https://phabricator.wikimedia.org/T243726 (10Jdforrester-WMF) [21:48:00] 10MediaWiki-API, 10Core Platform Team, 10Wikimedia-General-or-Unknown, 10Performance Issue: Internal API HTTP requests should hit the app server internal service IP, not the public HTTPS URL - https://phabricator.wikimedia.org/T243727 (10Jdforrester-WMF) [21:48:26] 10MediaWiki-API, 10MediaWiki-extensions-JsonConfig, 10CirrusSearch, 10Core Platform Team, and 5 others: Internal API HTTP requests should hit the app server internal service IP, not the public HTTPS URL - https://phabricator.wikimedia.org/T243727 (10Jdforrester-WMF) [21:48:27] (03Merged) 10jenkins-bot: Remove all traces of preprocessorClass from $wgParserConf [core] - 10https://gerrit.wikimedia.org/r/567153 (https://phabricator.wikimedia.org/T204945) (owner: 10C. Scott Ananian) [21:51:31] (03Merged) 10jenkins-bot: selenium: Replace wdio-chromedriver with ./selenium.sh script [core] - 10https://gerrit.wikimedia.org/r/558617 (https://phabricator.wikimedia.org/T234610) (owner: 10Krinkle) [22:02:37] (03CR) 10Jforrester: [C: 03+2] Hard-deprecate Sanitizer::escapeId() [core] - 10https://gerrit.wikimedia.org/r/567136 (owner: 10C. Scott Ananian) [22:03:30] (03CR) 10Jforrester: [C: 04-1] "Oops, you missed one in Timeless." [core] - 10https://gerrit.wikimedia.org/r/567136 (owner: 10C. Scott Ananian) [22:03:46] (03CR) 10Jforrester: Replace usage of Sanitizer::escapeId(), deprecated in MW 1.30 (031 comment) [skins/Timeless] - 10https://gerrit.wikimedia.org/r/567134 (owner: 10C. Scott Ananian) [22:04:36] 10MediaWiki-API, 10CirrusSearch, 10Core Platform Team, 10Discovery-Search, and 5 others: Internal API HTTP requests should hit the app server internal service IP, not the public HTTPS URL - https://phabricator.wikimedia.org/T243727 (10Legoktm) @Jdforrester-WMF I don't think any of these merit fixing in the... [22:05:24] (03PS1) 10Jforrester: Follow-up 688fff1: Fix the other use of Sanitizer::escapeId() [skins/Timeless] - 10https://gerrit.wikimedia.org/r/567370 [22:05:50] (03PS3) 10Jforrester: Hard-deprecate Sanitizer::escapeId() [core] - 10https://gerrit.wikimedia.org/r/567136 (owner: 10C. Scott Ananian) [22:05:58] (03CR) 10Jforrester: [C: 03+2] Hard-deprecate Sanitizer::escapeId() [core] - 10https://gerrit.wikimedia.org/r/567136 (owner: 10C. Scott Ananian) [22:05:59] 10DiscussionTools, 10OWC2020, 10VisualEditor (Current work): [Feedback] Not supporting adding multiple signatures in a comment - https://phabricator.wikimedia.org/T240640 (10Alsee) >When the page already contains a comment with multiple signatures (within a single paragraph or list item), there will be only... [22:06:09] (03CR) 10Jforrester: [C: 03+2] Follow-up 688fff1: Fix the other use of Sanitizer::escapeId() [skins/Timeless] - 10https://gerrit.wikimedia.org/r/567370 (owner: 10Jforrester) [22:11:28] 10MediaWiki-General, 10JavaScript: wgRelevantUserName is unevenly defined between Special:Block and Special:DeletedContributions - https://phabricator.wikimedia.org/T243722 (10SD0001) p:05Triage→03Lowest [22:12:41] 10MediaWiki-extensions-Babel: Babel should get cross-wiki languages via DB instead of making an HTTP request - https://phabricator.wikimedia.org/T243726 (10Legoktm) The database table on metawiki that we want to query uses the metawiki user_id. @anomie I don't currently see a way to get the metawiki user id via... [22:15:50] (03Merged) 10jenkins-bot: Follow-up 688fff1: Fix the other use of Sanitizer::escapeId() [skins/Timeless] - 10https://gerrit.wikimedia.org/r/567370 (owner: 10Jforrester) [22:20:37] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, and 3 others: Archive the Semantic Tasks extension due to move to GitHub - https://phabricator.wikimedia.org/T221549 (10Jdforrester-WMF) [22:21:38] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/567136 (owner: 10C. Scott Ananian) [22:22:33] (03Merged) 10jenkins-bot: Hard-deprecate Sanitizer::escapeId() [core] - 10https://gerrit.wikimedia.org/r/567136 (owner: 10C. Scott Ananian) [22:22:52] 10MediaWiki-extensions-Babel: Babel should get cross-wiki languages via DB instead of making an HTTP request - https://phabricator.wikimedia.org/T243726 (10Legoktm) https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CentralAuth/+/master/includes/CentralAuthUser.php#600 I guess we could just do... [22:28:19] (03PS1) 10Jforrester: Drop the "SemanticTasks" extension, moving to GitHub hosting [extensions] - 10https://gerrit.wikimedia.org/r/567371 (https://phabricator.wikimedia.org/T221549) [22:29:22] (03CR) 10Jforrester: [V: 03+2 C: 03+2] Drop the "SemanticTasks" extension, moving to GitHub hosting [extensions] - 10https://gerrit.wikimedia.org/r/567371 (https://phabricator.wikimedia.org/T221549) (owner: 10Jforrester) [22:29:48] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, and 3 others: Archive the Semantic Tasks extension due to move to GitHub - https://phabricator.wikimedia.org/T221549 (10Jdforrester-WMF) [22:40:36] 10MediaWiki-API, 10CirrusSearch, 10Core Platform Team, 10Discovery-Search, and 5 others: Internal API HTTP requests should hit the app server internal service IP, not the public HTTPS URL - https://phabricator.wikimedia.org/T243727 (10Ladsgroup) >>! In T243727#5833006, @Legoktm wrote: > @Jdforrester-WMF I... [22:47:37] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, 10Patch-For-Review: Archive the EditAccount extension - https://phabricator.wikimedia.org/T221494 (10Zoranzoki21) Only mirror on GitHub is left to be deleted, can @Jdforrester-WMF, @MarcoAurelio or someone else who have permi... [22:50:13] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, 10Patch-For-Review: Archive the EditAccount extension - https://phabricator.wikimedia.org/T221494 (10Jdforrester-WMF) 05Open→03Resolved [22:50:17] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, 10Patch-For-Review: Archive the EditAccount extension - https://phabricator.wikimedia.org/T221494 (10Jdforrester-WMF) Done. [22:51:23] 10MediaWiki-API, 10CirrusSearch, 10Core Platform Team, 10Discovery-Search, and 5 others: Internal API HTTP requests should hit the app server internal service IP, not the public HTTPS URL - https://phabricator.wikimedia.org/T243727 (10Jdforrester-WMF) >>! In T243727#5833006, @Legoktm wrote: > @Jdforrester-... [23:00:08] 10MediaWiki-extensions-Babel: Babel should get cross-wiki languages via DB instead of making an HTTP request - https://phabricator.wikimedia.org/T243726 (10Anomie) >>! In T243726#5833036, @Legoktm wrote: > I guess we could just do a JOIN on the user table for now. That's what I'd do here. [23:01:47] (03CR) 10Zoranzoki21: [C: 04-1] "I took a quick look, and I know that I should take a deeper look, but for now, for start, in comments I wrote what I think that should be " (035 comments) [extensions/MWVersionInfo] - 10https://gerrit.wikimedia.org/r/316241 (owner: 10Legoktm) [23:21:53] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, and 3 others: Archive the Semantic Tasks extension due to move to GitHub - https://phabricator.wikimedia.org/T221549 (10Jdforrester-WMF) 05Open→03Resolved