[00:01:00] (03PS1) 10SLF bot: Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/565750 [00:01:37] (03CR) 10Zoranzoki21: "recheck" [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/565750 (owner: 10SLF bot) [00:03:13] (03CR) 10Zoranzoki21: "recheck" [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/565738 (https://phabricator.wikimedia.org/T243134) (owner: 10Luca Mauri) [00:04:08] (03CR) 10Jack Phoenix: [C: 04-1] "PostgreSQL support is still there (although it doesn't currently work as intended, but I do plan on fixing it once the work on T227345 for" [extensions/Comments] - 10https://gerrit.wikimedia.org/r/565749 (owner: 10Zoranzoki21) [00:04:40] (03CR) 10jerkins-bot: [V: 04-1] Current version of the extension returns the error [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/565738 (https://phabricator.wikimedia.org/T243134) (owner: 10Luca Mauri) [00:06:08] (03CR) 10Reedy: [C: 03+2] Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/565750 (owner: 10SLF bot) [00:07:36] (03CR) 10Jack Phoenix: [C: 03+2] Remove use of global $wgUser (part 1) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/565334 (https://phabricator.wikimedia.org/T242994) (owner: 10DannyS712) [00:08:34] (03CR) 10Jack Phoenix: [C: 03+2] "Looks like the code could use a bit -- or a lot -- of love in general, wow...your changes here are totally fine (although by the looks of " [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/565147 (https://phabricator.wikimedia.org/T242890) (owner: 10DannyS712) [00:09:25] (03Merged) 10jenkins-bot: Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/565750 (owner: 10SLF bot) [00:10:35] (03Merged) 10jenkins-bot: Remove use of global $wgUser (part 1) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/565334 (https://phabricator.wikimedia.org/T242994) (owner: 10DannyS712) [00:11:26] (03Merged) 10jenkins-bot: Remove uses of global $wgUser (part 2) [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/565147 (https://phabricator.wikimedia.org/T242890) (owner: 10DannyS712) [00:38:15] (03PS15) 10Aron Manning: Bug: T229484 After closing, browser sometimes scrolls to the top of the page [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/560576 (https://phabricator.wikimedia.org/T229484) [00:43:45] (03PS16) 10Aron Manning: After closing, browser sometimes scrolls to the top of the page [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/560576 (https://phabricator.wikimedia.org/T229484) [02:36:24] 10NewcomerTasks 1.1, 10Growth-Team (Current Sprint): Newcomer tasks: investigate discrepancy between topics in module and API - https://phabricator.wikimedia.org/T243035 (10Tgr) The module uses more random results (roughly identical to using the API with `gglimit=250` instead of `10`, ie. top 250 results inste... [02:37:44] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, 10translatewiki.net: Archive the TagContent extension - https://phabricator.wikimedia.org/T243093 (10Zoranzoki21) [03:48:32] 10Library-Card-Platform: Withdraw applications - https://phabricator.wikimedia.org/T243137 (10Nikkimaria) [04:21:06] (03PS2) 10Ammarpad: Upgrade skin.json schema to manifest_version 2 [skins/Timeless] - 10https://gerrit.wikimedia.org/r/563649 (https://phabricator.wikimedia.org/T242504) [04:22:43] (03CR) 10jerkins-bot: [V: 04-1] Upgrade skin.json schema to manifest_version 2 [skins/Timeless] - 10https://gerrit.wikimedia.org/r/563649 (https://phabricator.wikimedia.org/T242504) (owner: 10Ammarpad) [04:30:27] (03CR) 10Ammarpad: "> This is all fine and technically correct, but isn't the whole point" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/563649 (https://phabricator.wikimedia.org/T242504) (owner: 10Ammarpad) [04:41:19] (03PS3) 10Ammarpad: Upgrade skin.json schema to manifest_version 2 [skins/Timeless] - 10https://gerrit.wikimedia.org/r/563649 (https://phabricator.wikimedia.org/T242504) [04:59:28] 10Discovery-Search, 10GeoData: Support query continuation for Nearby requests - https://phabricator.wikimedia.org/T78703 (10CXuesong) Just want to let you know now we have some external dependents on the continuation support of `action=query&list=geosearch` XD (T95241 has been merged into this task) * https:/... [06:01:19] 10Developer-Advocacy, 10Documentation: Set up Tech blog to share stories from the Wikimedia Technical community - https://phabricator.wikimedia.org/T242619 (10Legoktm) In the past we used to have a Wikimedia tech blog, and for reasons that I'm not familiar with, it was merged in to the main Wikimedia blog. Are... [06:42:21] 04(no projects): allow to exclude selected claims from wbgetentities (or state positively which properties you want) - https://phabricator.wikimedia.org/T243138 (10Ralfhauser) [06:47:39] 04(no projects): allow to exclude selected claims from wbgetentities (or state positively which properties you want) - https://phabricator.wikimedia.org/T243138 (10Ralfhauser) see also https://github.com/maxlath/wikibase-sdk/issues/64 [06:49:33] 10MediaWiki-General, 10Growth Design, 10Schema-change: Add primary key to pagetriage_page_tags - https://phabricator.wikimedia.org/T243073 (10Marostegui) >>! In T243073#5813362, @DannyS712 wrote: > Can `ptrpt_page_tag_id` be converted from a `UNIQUE KEY` to a primary key? Yes, it can be done by adding the P... [07:54:25] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: Unexpected side-effect of CentralNotice wmf_deploy branch strategy - https://phabricator.wikimedia.org/T179536 (10Legoktm) [07:56:57] (03PS1) 10Pwirth: Add hook hander base classes for hooks [extensions/BlueSpiceBookshelf] - 10https://gerrit.wikimedia.org/r/565753 [07:58:17] 10Phabricator, 10VPS-project-codesearch: Consider adding a way to query https://codesearch.wmflabs.org/search/ from phabricator. - https://phabricator.wikimedia.org/T183608 (10Legoktm) 05Open→03Stalled [08:08:26] 10Developer-Advocacy (Jan-Mar 2020), 10Google-Code-in-2019: Google Code-In 2019 Design Wikimedia Friends of the Docs Appreciation Stickers - https://phabricator.wikimedia.org/T239641 (10JeremyNguyenGCI) {F31516923} [08:30:21] 10MediaWiki-Core-Testing, 10Release-Engineering-Team-TODO, 10Google-Code-in-2019, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), and 3 others: Stop using jsonlint and instead use eslint-plugin-json for the linting - https://phabricator.wikimedia.org/T220036 (10Majavah) [08:46:34] 10Wikimedia-General-or-Unknown, 10Composer: Set up a packagist mirror for Wikimedia - https://phabricator.wikimedia.org/T203529 (10Legoktm) >>! In T203529#5805410, @Webysther wrote: > There's a fork location of repository? No, it's using your code off of github, I just hadn't pulled it in a while (just did so... [08:51:37] (03CR) 10Legoktm: [C: 03+2] build: Replace jshint/jsonlint with eslint [extensions/PageBlock] - 10https://gerrit.wikimedia.org/r/564136 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [08:52:18] (03CR) 10Legoktm: [C: 03+2] Move files into the directories for consistency [extensions/PageBlock] - 10https://gerrit.wikimedia.org/r/564133 (owner: 10Zoranzoki21) [08:52:24] (03CR) 10jerkins-bot: [V: 04-1] Move files into the directories for consistency [extensions/PageBlock] - 10https://gerrit.wikimedia.org/r/564133 (owner: 10Zoranzoki21) [08:52:26] (03CR) 10jerkins-bot: [V: 04-1] build: Replace jshint/jsonlint with eslint [extensions/PageBlock] - 10https://gerrit.wikimedia.org/r/564136 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [08:53:44] (03CR) 10Legoktm: [C: 04-1] "Needs rebase." [extensions/PageBlock] - 10https://gerrit.wikimedia.org/r/564133 (owner: 10Zoranzoki21) [09:29:28] 10MediaWiki-extensions-MediaWikiAuth: MediaWikiAuth extension: "Undefined property stdClass::$clientlogin" error on new user login - https://phabricator.wikimedia.org/T243134 (10lucamauri) The Gerrit patch was not automatically referenced here, so here's the link https://gerrit.wikimedia.org/r/c/mediawiki/extens... [09:35:03] 10MediaWiki-extensions-MediaWikiAuth, 10Patch-For-Review: MediaWikiAuth extension: "Undefined property stdClass::$clientlogin" error on new user login - https://phabricator.wikimedia.org/T243134 (10Aklapper) [09:36:35] (03CR) 10Luca Mauri: "Jenkins reports a configuration error" [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/565738 (https://phabricator.wikimedia.org/T243134) (owner: 10Luca Mauri) [09:49:08] 10MediaWiki-extensions-MediaWikiAuth, 10Patch-For-Review: MediaWikiAuth extension: "Undefined property stdClass::$clientlogin" error on new user login - https://phabricator.wikimedia.org/T243134 (10Peachey88) >>! In T243134#5815053, @lucamauri wrote: > The Gerrit patch was not automatically referenced here Fr... [10:01:13] (03PS1) 10Pwirth: Add hook hander base classes for hooks [extensions/BlueSpiceBookshelfUI] - 10https://gerrit.wikimedia.org/r/565754 [10:01:43] (03PS2) 10Pwirth: Add hook hander base classes for hooks [extensions/BlueSpiceBookshelfUI] - 10https://gerrit.wikimedia.org/r/565754 [10:03:28] (03CR) 10jerkins-bot: [V: 04-1] Add hook hander base classes for hooks [extensions/BlueSpiceBookshelfUI] - 10https://gerrit.wikimedia.org/r/565754 (owner: 10Pwirth) [10:10:30] (03PS3) 10Pwirth: Add hook hander base classes for hooks [extensions/BlueSpiceBookshelfUI] - 10https://gerrit.wikimedia.org/r/565754 [10:11:36] (03PS1) 10Ostrzyciel: Use a table alias for compatibility with other extensions [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/565755 [10:45:12] (03PS1) 10Pwirth: Add hook hander base classes for hooks [extensions/BlueSpiceCategoryManager] - 10https://gerrit.wikimedia.org/r/565756 [10:46:35] (03CR) 10Majavah: [C: 04-1] "Hi, could you format the commit message to comply with the guidelines at https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines? " [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/565738 (https://phabricator.wikimedia.org/T243134) (owner: 10Luca Mauri) [10:52:15] 10AbuseFilter: Log entries for global filter hits are broken if wiki goes beyond their range - https://phabricator.wikimedia.org/T174000 (10matej_suchanek) 05Stalled→03Open p:05Triage→03Low We can probably show "Global filter #123" instead or always query with `afl_global = 0` when T220791 is done. [11:00:00] 10Wikispore: Commons integration - https://phabricator.wikimedia.org/T241598 (10Mike_Peel) 05Open→03Resolved This is now live in the main version of the infobox. [11:01:11] 10Wikimedia-Site-requests, 10Patch-For-Review: Arbcom wikis are in both wikipedia.dblist and special.dblist - https://phabricator.wikimedia.org/T183549 (10Urbanecm) >>! In T183549#5776463, @Zoranzoki21 wrote: > Arbcom wikis should be in own arbcom dblist and problem resovled :). The dblists are often used in... [11:06:22] 10MediaWiki-User-preferences, 10MediaWiki-extensions-General, 10good first task: Remove uses of 'cols' and 'rows' preferences from extensions - https://phabricator.wikimedia.org/T155153 (10matej_suchanek) [11:09:16] 10Wikimedia-Site-requests: Change autoconfirmed days and edits limit in he@wiki. - https://phabricator.wikimedia.org/T243076 (10Urbanecm) p:05Triage→03Low [11:12:24] 10MediaWiki-Special-pages, 10Patch-For-Review, 10good first task: Show number of items on Whatlinkshere if less than limit value - https://phabricator.wikimedia.org/T44357 (10matej_suchanek) [11:19:47] 10MediaWiki-General, 10Technical-Debt, 10User-Matthewrbowker, 10good first task: Remove MediaWiki code marked for removal in a past release - https://phabricator.wikimedia.org/T61113 (10matej_suchanek) [12:02:26] 10MediaWiki-Templates: develop a generic stand-alone service that adapts templates across wikis - https://phabricator.wikimedia.org/T243150 (10Amire80) [12:03:31] 10MediaWiki-Core-Testing, 10MediaWiki-Uploading, 10Multimedia, 10Google-Code-in-2019, and 2 others: Create tests for UploadFromUrl::isAllowedHost - https://phabricator.wikimedia.org/T225862 (10Majavah) a:03Majavah [12:10:23] 10MediaWiki-Core-Testing, 10MediaWiki-Uploading, 10Multimedia, 10Google-Code-in-2019, and 2 others: Create tests for UploadFromUrl::isAllowedHost - https://phabricator.wikimedia.org/T225862 (10Majavah) Hi, I'm working on this but `UploadFromUrlTest` is marked as `@group Broken` and it seems like that test... [12:14:44] 10doxygen: Abstract class UploadBase is not present in Doxygen - https://phabricator.wikimedia.org/T243152 (10Ciencia_Al_Poder) [12:18:18] 10ReleaseTaggerBot, 10Patch-For-Review: Adapt RTB to new yaml release config - https://phabricator.wikimedia.org/T242920 (10valhallasw) 05Open→03Resolved a:03valhallasw Thanks, deployed! [12:24:11] 10ReleaseTaggerBot: RTB errors with "Fatal Python error: Py_Initialize: Unable to get the locale encoding" - https://phabricator.wikimedia.org/T242802 (10valhallasw) Looking at the examples, a call is now supposed to be done along these lines: ` $ curl https://phabricator.wikimedia.org/api/project.query \ -... [12:36:18] 10ReleaseTaggerBot: RTB errors with "Fatal Python error: Py_Initialize: Unable to get the locale encoding" - https://phabricator.wikimedia.org/T242802 (10valhallasw) python-phabricator supports tokens as well: https://github.com/disqus/python-phabricator/blob/master/phabricator/__init__.py#L378 and still uses pa... [13:17:45] (03PS1) 10Florianschmidtwelzow: [UploadFromUrl] Unbreak Api tests [core] - 10https://gerrit.wikimedia.org/r/565759 [13:19:26] 10MediaWiki-Core-Testing, 10MediaWiki-Uploading, 10Multimedia, 10Google-Code-in-2019, and 2 others: Create tests for UploadFromUrl::isAllowedHost - https://phabricator.wikimedia.org/T225862 (10Florian) Good catch, didn't see that, sorry for the confusion! I worked on [[ https://gerrit.wikimedia.org/r/c/med... [13:29:32] (03PS1) 10Majavah: Create tests for UploadFromUrl::isAllowedHost [core] - 10https://gerrit.wikimedia.org/r/565760 (https://phabricator.wikimedia.org/T225862) [13:29:57] (03CR) 10jerkins-bot: [V: 04-1] [UploadFromUrl] Unbreak Api tests [core] - 10https://gerrit.wikimedia.org/r/565759 (owner: 10Florianschmidtwelzow) [13:30:33] (03PS3) 10D3r1ck01: tests, preferences: Use `$this->` instead of `self::` when creating TD [core] - 10https://gerrit.wikimedia.org/r/565613 [13:33:01] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/565759 (owner: 10Florianschmidtwelzow) [13:33:32] 10MediaWiki-Core-Testing, 10MediaWiki-Uploading, 10Multimedia, 10Google-Code-in-2019, and 3 others: Create tests for UploadFromUrl::isAllowedHost - https://phabricator.wikimedia.org/T225862 (10Majavah) >>! In T225862#5815351, @Florian wrote: > Good catch, didn't see that, sorry for the confusion! I worked... [13:36:53] (03PS3) 10Luca Mauri: Fix Respnse Status check in MediaWikiAuth [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/565738 (https://phabricator.wikimedia.org/T243134) [13:37:27] (03CR) 10Luca Mauri: "@Majavah I just did so, thanks for pointing it out" [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/565738 (https://phabricator.wikimedia.org/T243134) (owner: 10Luca Mauri) [13:39:58] (03CR) 10Majavah: "Thanks for fixing, however you have a typo "Respnse" instead of "Response". Also "Response" and "Status" should be in lowercase. Sorry for" [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/565738 (https://phabricator.wikimedia.org/T243134) (owner: 10Luca Mauri) [13:41:12] 10MediaWiki-Templates: develop a generic stand-alone service that adapts templates across wikis - https://phabricator.wikimedia.org/T243150 (10Amire80) [13:41:20] 10MediaWiki-Templates, 10MediaWiki-extensions-Scribunto, 10Community-Wishlist-Survey-2015, 10Crosswiki: We need a common repository for Scribunto modules and templates - https://phabricator.wikimedia.org/T52329 (10Amire80) [13:41:59] (03CR) 10jerkins-bot: [V: 04-1] Create tests for UploadFromUrl::isAllowedHost [core] - 10https://gerrit.wikimedia.org/r/565760 (https://phabricator.wikimedia.org/T225862) (owner: 10Majavah) [13:42:08] (03CR) 10Zoranzoki21: "> Needs rebase." [extensions/PageBlock] - 10https://gerrit.wikimedia.org/r/564133 (owner: 10Zoranzoki21) [13:44:30] (03PS2) 10Majavah: Create tests for UploadFromUrl::isAllowedHost [core] - 10https://gerrit.wikimedia.org/r/565760 (https://phabricator.wikimedia.org/T225862) [13:44:32] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/565760 (https://phabricator.wikimedia.org/T225862) (owner: 10Majavah) [13:45:10] (03PS4) 10Luca Mauri: Fix Respnse Status check in MediaWikiAuth [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/565738 (https://phabricator.wikimedia.org/T243134) [13:45:37] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/565613 (owner: 10D3r1ck01) [13:45:58] (03PS5) 10Luca Mauri: Fix response status check in MediaWikiAuth [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/565738 (https://phabricator.wikimedia.org/T243134) [13:46:50] (03CR) 10Majavah: "Thank you! I'll let other people review the code changes." [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/565738 (https://phabricator.wikimedia.org/T243134) (owner: 10Luca Mauri) [13:47:39] 10MediaWiki-extensions-MediaWikiAuth, 10Patch-For-Review: MediaWikiAuth extension: "Undefined property stdClass::$clientlogin" error on new user login - https://phabricator.wikimedia.org/T243134 (10lucamauri) > In T243134#5815072, @Peachey88 wrote: > From memory, Thats caused by the blank line in between the B... [13:47:56] (03PS2) 10Zoranzoki21: build: Replace jshint/jsonlint with eslint [extensions/PageBlock] - 10https://gerrit.wikimedia.org/r/564136 (https://phabricator.wikimedia.org/T210365) [13:53:53] (03PS2) 10Zoranzoki21: Move files into the directories for consistency [extensions/PageBlock] - 10https://gerrit.wikimedia.org/r/564133 [13:54:12] (03PS1) 10D3r1ck01: PathRouter: Allow duplicate names for subpatterns in RegEx [core] - 10https://gerrit.wikimedia.org/r/565762 (https://phabricator.wikimedia.org/T242859) [13:55:36] 10MediaWiki-General, 10Patch-For-Review, 10User-brennen, 10Wikimedia-production-error: PHP Warning: preg_match(): Compilation failed: two named subpatterns have the same name at offset 62 - https://phabricator.wikimedia.org/T242859 (10D3r1ck01) @brennen, I think this can be fixed by using the `(?J)` patter... [13:56:29] Crutishnyk: Hi, around ? [13:57:40] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/565613 (owner: 10D3r1ck01) [13:58:10] (03CR) 10Zoranzoki21: "> PostgreSQL support is still there (although it doesn't currently" [extensions/Comments] - 10https://gerrit.wikimedia.org/r/565749 (owner: 10Zoranzoki21) [13:58:15] (03Abandoned) 10Zoranzoki21: Remove comment from CommentsHooks.php about files removed in I5c7e5f0a9360943c9625d87daa4589dae8ab9839. [extensions/Comments] - 10https://gerrit.wikimedia.org/r/565749 (owner: 10Zoranzoki21) [13:58:35] Gopa: Hi, yes [13:59:29] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/565760 (https://phabricator.wikimedia.org/T225862) (owner: 10Majavah) [13:59:36] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] tests, preferences: Use `$this->` instead of `self::` when creating TD [core] - 10https://gerrit.wikimedia.org/r/565613 (owner: 10D3r1ck01) [13:59:41] Crutishnyk: Good work, I just mentioned few comments in the GCI website hope you already noticed them? [14:00:17] I didn't get a notification [14:00:35] I see [14:00:41] :) [14:00:53] (03PS2) 10Florianschmidtwelzow: [UploadFromUrl] Unbreak Api tests [core] - 10https://gerrit.wikimedia.org/r/565759 [14:01:03] (03PS4) 10D3r1ck01: sparql: Avoid use of deprecated Http::getUserAgent() [core] - 10https://gerrit.wikimedia.org/r/561583 [14:01:23] (03CR) 10D3r1ck01: "> Patch Set 3: Code-Review+2" [core] - 10https://gerrit.wikimedia.org/r/565613 (owner: 10D3r1ck01) [14:02:04] Welp, I'll do it but later. I need to do homework [14:02:11] (03PS5) 10D3r1ck01: sparql: Avoid use of deprecated Http::getUserAgent() [core] - 10https://gerrit.wikimedia.org/r/561583 [14:02:27] Crutishnyk: yeah no worries, Good luck :) [14:02:37] Thanks! [14:03:02] (03CR) 10Thiemo Kreuz (WMDE): Use a table alias for compatibility with other extensions (031 comment) [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/565755 (owner: 10Ostrzyciel) [14:05:19] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] Use PHP syntax features from PHP 7.1 (031 comment) [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/565731 (owner: 10Fomafix) [14:06:02] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Pretify messages [extensions/Shibboleth] - 10https://gerrit.wikimedia.org/r/565729 (owner: 10Raimond Spekking) [14:06:59] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Raimond, does this still apply? If so, I will merge it." [extensions/Collection] - 10https://gerrit.wikimedia.org/r/550029 (owner: 10Raimond Spekking) [14:08:18] (03CR) 10Fomafix: "The parent commit f01088f2ed31a246584742a7644538fe60963234 ensures that only PHP 7.1+ is used." [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/565731 (owner: 10Fomafix) [14:08:56] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/565762 (https://phabricator.wikimedia.org/T242859) (owner: 10D3r1ck01) [14:12:09] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/565762 (https://phabricator.wikimedia.org/T242859) (owner: 10D3r1ck01) [14:12:29] (03PS1) 10Pwirth: Add hook hander base classes for hooks [extensions/BlueSpiceCustomMenu] - 10https://gerrit.wikimedia.org/r/565764 [14:13:12] (03Merged) 10jenkins-bot: tests, preferences: Use `$this->` instead of `self::` when creating TD [core] - 10https://gerrit.wikimedia.org/r/565613 (owner: 10D3r1ck01) [14:13:14] (03CR) 10jerkins-bot: [V: 04-1] Pretify messages [extensions/Shibboleth] - 10https://gerrit.wikimedia.org/r/565729 (owner: 10Raimond Spekking) [14:13:49] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/565759 (owner: 10Florianschmidtwelzow) [14:14:20] (03PS2) 10Ostrzyciel: Use a table alias for compatibility with other extensions [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/565755 [14:15:06] (03CR) 10Ostrzyciel: "> Patch Set 1:" (031 comment) [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/565755 (owner: 10Ostrzyciel) [14:15:29] (03CR) 10jerkins-bot: [V: 04-1] Use a table alias for compatibility with other extensions [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/565755 (owner: 10Ostrzyciel) [14:17:00] 10MediaWiki-Core-Testing, 10MediaWiki-Uploading, 10Multimedia, 10Google-Code-in-2019, and 3 others: Create tests for UploadFromUrl::isAllowedHost - https://phabricator.wikimedia.org/T225862 (10Florian) @Majavah Yeah, that's what I mean :) Sorry, that I didn't link this in the first place, I didn't think ab... [14:18:08] (03CR) 10jerkins-bot: [V: 04-1] sparql: Avoid use of deprecated Http::getUserAgent() [core] - 10https://gerrit.wikimedia.org/r/561583 (owner: 10D3r1ck01) [14:18:10] (03PS3) 10Ostrzyciel: Use a table alias for compatibility with other extensions [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/565755 [14:18:42] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/561583 (owner: 10D3r1ck01) [14:21:10] (03CR) 10D3r1ck01: "@addshore, see failure:" [core] - 10https://gerrit.wikimedia.org/r/561583 (owner: 10D3r1ck01) [14:25:52] (03PS1) 10Paladox: Convert si_title to `varchar(255) BINARY NOT NULL default ''` [core] - 10https://gerrit.wikimedia.org/r/565765 [14:26:20] (03PS2) 10Paladox: Convert si_title to `varchar(255) BINARY NOT NULL default ''` [core] - 10https://gerrit.wikimedia.org/r/565765 [14:30:38] (03PS3) 10Paladox: Convert si_title to `varchar(255) BINARY NOT NULL default ''` [core] - 10https://gerrit.wikimedia.org/r/565765 [14:30:39] 10MediaWiki-General, 10MW-1.34-notes, 10MW-1.34-release, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07): PHP Notice: Constant MW_ENTRY_POINT already defined in /srv/mediawiki/w/thumb.php on line 28 - https://phabricator.wikimedia.org/T241340 (10D3r1ck01) Do we still see this in logspam? I guess not? [14:30:54] 10MediaWiki-General, 10MW-1.34-notes, 10MW-1.34-release, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07): PHP Notice: Constant MW_ENTRY_POINT already defined in /srv/mediawiki/w/thumb.php on line 28 - https://phabricator.wikimedia.org/T241340 (10D3r1ck01) p:05Triage→03Low [14:35:24] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Apart from that, I think we're on a right way here :)" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/565760 (https://phabricator.wikimedia.org/T225862) (owner: 10Majavah) [14:36:47] (03CR) 10Raimond Spekking: "@Thiemo: Yes." [extensions/Collection] - 10https://gerrit.wikimedia.org/r/550029 (owner: 10Raimond Spekking) [14:37:26] (03PS4) 10Paladox: Convert si_title to `varchar(255) BINARY NOT NULL default ''` [core] - 10https://gerrit.wikimedia.org/r/565765 [14:49:13] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/565765 (owner: 10Paladox) [14:52:14] (03PS1) 10D3r1ck01: ServiceWiring: Cleanup unused closure signatures in serivice wires [core] - 10https://gerrit.wikimedia.org/r/565767 [14:54:34] 10MediaWiki-General, 10MW-1.34-notes, 10MW-1.34-release, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07): PHP Notice: Constant MW_ENTRY_POINT already defined in /srv/mediawiki/w/thumb.php on line 28 - https://phabricator.wikimedia.org/T241340 (10Reedy) 05Open→03Resolved a:03Reedy [15:03:59] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/565767 (owner: 10D3r1ck01) [15:15:13] (03PS1) 10Maruf.hossen: hassan commited [sandbox] - 10https://gerrit.wikimedia.org/r/565769 [15:17:16] (03PS1) 10Maruf.hossen: Hasan edited [sandbox] - 10https://gerrit.wikimedia.org/r/565770 [15:20:17] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Use PHP syntax features from PHP 7.1 [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/565731 (owner: 10Fomafix) [15:27:33] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/565767 (owner: 10D3r1ck01) [15:32:53] 10Design, 10Design Research and product team collaboration, 10Design-Research, 10Research: Gesture-based navigation system for mobile devices - https://phabricator.wikimedia.org/T243155 (10Peteole) [15:45:04] (03CR) 10Florianschmidtwelzow: [C: 03+2] Upgrade skin.json schema to manifest_version 2 [skins/Timeless] - 10https://gerrit.wikimedia.org/r/563649 (https://phabricator.wikimedia.org/T242504) (owner: 10Ammarpad) [15:45:15] 10Timeless, 10Patch-For-Review: Upgrade Timeless skin.json schema to manifest_version 2 - https://phabricator.wikimedia.org/T242504 (10Florian) 05Open→03Resolved a:03Florian [15:45:17] 10Other-skins: Upgrade skins skin.json schema to manifest_version 2 - https://phabricator.wikimedia.org/T242503 (10Florian) [15:45:25] 10Timeless: Upgrade Timeless skin.json schema to manifest_version 2 - https://phabricator.wikimedia.org/T242504 (10Florian) a:05Florian→03Ammarpad [15:47:54] (03Merged) 10jenkins-bot: Upgrade skin.json schema to manifest_version 2 [skins/Timeless] - 10https://gerrit.wikimedia.org/r/563649 (https://phabricator.wikimedia.org/T242504) (owner: 10Ammarpad) [15:47:57] 10Timeless: Sitename with whitespace breaks over the header size - https://phabricator.wikimedia.org/T243156 (10Florian) [15:56:12] (03CR) 10Art-Baltai: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/565746 (https://phabricator.wikimedia.org/T235165) (owner: 10Art-Baltai) [15:58:51] (03PS1) 10D3r1ck01: preferences: Avoid use of deprecated Language::fetchLanguageNames() [core] - 10https://gerrit.wikimedia.org/r/565773 [16:02:12] (03PS1) 10Thiemo Kreuz (WMDE): Streamline a few pieces of JavaScript code [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/565774 [16:04:16] (03CR) 10Thiemo Kreuz (WMDE): "The code in this patch is fine. I just feel it's a little to complex for what it does. I tried to reduce this complexity in a follow-up pa" (031 comment) [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/564559 (https://phabricator.wikimedia.org/T63115) (owner: 10Abijeet Patro) [16:07:02] (03CR) 10Thiemo Kreuz (WMDE): "What this patch does is not wrong. However, I feel it is also not really necessary. This is similar to unused parameters in hook handler f" [core] - 10https://gerrit.wikimedia.org/r/565767 (owner: 10D3r1ck01) [16:07:51] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Clarify messages. Book Creator PDF rendering died [extensions/Collection] - 10https://gerrit.wikimedia.org/r/550029 (owner: 10Raimond Spekking) [16:08:19] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Use a table alias for compatibility with other extensions [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/565755 (owner: 10Ostrzyciel) [16:10:54] (03Merged) 10jenkins-bot: Clarify messages. Book Creator PDF rendering died [extensions/Collection] - 10https://gerrit.wikimedia.org/r/550029 (owner: 10Raimond Spekking) [16:11:29] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/565773 (owner: 10D3r1ck01) [16:13:07] (03Merged) 10jenkins-bot: Use a table alias for compatibility with other extensions [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/565755 (owner: 10Ostrzyciel) [16:21:15] 10Google-Drive-to-Commons, 10Google-Code-in-2019: Design a logo for our Google Drive to Wikimedia Commons Uploader - https://phabricator.wikimedia.org/T241443 (10AF00001) {F31517310} {F31517309} CodeIn Username- AF01 [16:22:40] (03CR) 10Zoranzoki21: [V: 03+2 C: 03+2] "CR+2 because of cleanup of workflow." [sandbox] - 10https://gerrit.wikimedia.org/r/564676 (owner: 10Ewa Jozefczuk) [16:22:59] (03CR) 10Zoranzoki21: [V: 03+2 C: 03+2] "CR+2 because of cleanup of workflow." [sandbox] - 10https://gerrit.wikimedia.org/r/564720 (owner: 10Ewa Jozefczuk) [16:23:47] (03PS1) 10Zoranzoki21: Revert of bad changes [sandbox] - 10https://gerrit.wikimedia.org/r/565776 [16:24:34] (03Abandoned) 10Zoranzoki21: Revert of bad changes [sandbox] - 10https://gerrit.wikimedia.org/r/565776 (owner: 10Zoranzoki21) [16:25:27] (03CR) 10Zoranzoki21: [V: 03+2 C: 03+2] "CR+2 because of cleanup of workflow." [sandbox] - 10https://gerrit.wikimedia.org/r/565769 (owner: 10Maruf.hossen) [16:26:02] (03CR) 10Zoranzoki21: [C: 04-1] "Can you please resolve this merge conflict?" [sandbox] - 10https://gerrit.wikimedia.org/r/565770 (owner: 10Maruf.hossen) [16:26:26] (03PS2) 10Zoranzoki21: Changed README.md file this was just part of the gerrit tutorial [sandbox] - 10https://gerrit.wikimedia.org/r/563755 (owner: 10Bilijin) [16:27:00] (03PS3) 10Zoranzoki21: Changed README.md file this was just part of the gerrit tutorial [sandbox] - 10https://gerrit.wikimedia.org/r/563755 (owner: 10Bilijin) [16:27:29] (03CR) 10Zoranzoki21: [V: 03+2 C: 03+2] "Much better, LGTM!" [sandbox] - 10https://gerrit.wikimedia.org/r/563755 (owner: 10Bilijin) [16:28:18] (03CR) 10Florianschmidtwelzow: [C: 03+2] "I'm with Jack, we should elaborate if the EmailUser hook can get a user passed as well. Otherwise, this change looks good, I don't see and" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/565161 (https://phabricator.wikimedia.org/T242936) (owner: 10DannyS712) [16:28:40] (03PS2) 10Zoranzoki21: Hasan edited [sandbox] - 10https://gerrit.wikimedia.org/r/565770 (owner: 10Maruf.hossen) [16:28:46] (03PS3) 10Zoranzoki21: Hasan edited [sandbox] - 10https://gerrit.wikimedia.org/r/565770 (owner: 10Maruf.hossen) [16:29:59] (03PS4) 10Zoranzoki21: Delete some files [sandbox] - 10https://gerrit.wikimedia.org/r/565770 (owner: 10Maruf.hossen) [16:30:09] (03CR) 10Zoranzoki21: [V: 03+2 C: 03+2] "Cleanup of workflow!" [sandbox] - 10https://gerrit.wikimedia.org/r/565770 (owner: 10Maruf.hossen) [16:30:52] (03CR) 10Florianschmidtwelzow: [C: 03+2] Stop passing objects by reference [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/551705 (https://phabricator.wikimedia.org/T193950) (owner: 10MaxSem) [16:34:56] (03CR) 10Florianschmidtwelzow: [C: 04-1] Update extension.json files to use manifest_version 2 (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/543672 (https://phabricator.wikimedia.org/T234114) (owner: 10Jforrester) [16:36:04] (03PS4) 10Florianschmidtwelzow: Update extension.json files to use manifest_version 2 [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/543672 (https://phabricator.wikimedia.org/T234114) (owner: 10Jforrester) [16:36:23] (03CR) 10Florianschmidtwelzow: [C: 03+1] Update extension.json files to use manifest_version 2 [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/543672 (https://phabricator.wikimedia.org/T234114) (owner: 10Jforrester) [16:40:57] (03Merged) 10jenkins-bot: Remove use of global $wgUser [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/565161 (https://phabricator.wikimedia.org/T242936) (owner: 10DannyS712) [16:42:21] (03CR) 10D3r1ck01: "> Patch Set 1:" [core] - 10https://gerrit.wikimedia.org/r/565767 (owner: 10D3r1ck01) [16:43:12] (03Merged) 10jenkins-bot: Stop passing objects by reference [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/551705 (https://phabricator.wikimedia.org/T193950) (owner: 10MaxSem) [16:43:18] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/565773 (owner: 10D3r1ck01) [16:49:27] (03CR) 10Jack Phoenix: [C: 03+2] Remove use of global $wgUser (part 9) [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/565747 (https://phabricator.wikimedia.org/T242677) (owner: 10DannyS712) [16:50:08] 10Timeless: Sitename with whitespace breaks over the header size - https://phabricator.wikimedia.org/T243156 (10Ammarpad) I think this is a browser issue or something else interfering. I cannot reproduce with Chrome. {F31517336} Even if I shrink my window to the absolute minimum size {F31517328} [16:50:15] 10MediaWiki-General, 10Core Platform Team Workboards (Clinic Duty Team), 10User-brennen, 10Wikimedia-production-error: PHP Warning: preg_match(): Compilation failed: two named subpatterns have the same name at offset 62 - https://phabricator.wikimedia.org/T235357 (10D3r1ck01) [16:50:18] 10MediaWiki-General, 10Patch-For-Review, 10User-brennen, 10Wikimedia-production-error: PHP Warning: preg_match(): Compilation failed: two named subpatterns have the same name at offset 62 - https://phabricator.wikimedia.org/T242859 (10D3r1ck01) [16:52:17] (03Merged) 10jenkins-bot: Remove use of global $wgUser (part 9) [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/565747 (https://phabricator.wikimedia.org/T242677) (owner: 10DannyS712) [16:52:35] (03CR) 10Jack Phoenix: [C: 03+2] "Looks good, though I don't expect the extension to work on post-AuthManager MWs as it seems to be using the old $wgAuth system, but that's" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/565363 (https://phabricator.wikimedia.org/T242566) (owner: 10DannyS712) [16:55:26] (03Merged) 10jenkins-bot: Remove uses of global $wgUser (part 3) [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/565363 (https://phabricator.wikimedia.org/T242566) (owner: 10DannyS712) [17:20:26] 10Map-of-monuments, 10Google-Code-in-2019: Add a filter by country and language to the map - https://phabricator.wikimedia.org/T241513 (10IAmNetx) p:05Normal→03Low a:05NicholasG04→03IAmNetx [17:21:02] Urbanecm: do you have a .sql file for the map-of-monuments db? [17:21:30] IAmNetx: sure, give me a moment [17:23:53] 04(no projects): Connection with Wikidata - https://phabricator.wikimedia.org/T243130 (10Dudley_Miles) The notifications are on Commons, Your notices. I get a notification that a category has been linked to Wikidata. Unticking'Connection with Wikidata' in Preferences, Notifications, appears to be the correct... [17:26:20] IAmNetx: https://people.wikimedia.org/~urbanecm/s53844__heritage_p.sql.gz [17:26:38] Urbanecm: thanks! [17:26:44] Happy to help! [17:31:52] 10MediaWiki-General, 10I18n: ӧ-letter shown wrong in article names and in section headings - https://phabricator.wikimedia.org/T243119 (10kruusamagi) {F31517354} That was sent to me from Udmurt Wikipedia. That person was using Chrome and having the same problem. And one other Udmurt also showed that she has t... [17:49:53] (03PS1) 10Jack Phoenix: Actor support, now requires MW 1.34+ [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/565779 (https://phabricator.wikimedia.org/T227345) [17:50:36] (03CR) 10jerkins-bot: [V: 04-1] Actor support, now requires MW 1.34+ [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/565779 (https://phabricator.wikimedia.org/T227345) (owner: 10Jack Phoenix) [17:53:43] 10Desktop Improvements, 10Readers-Web-Backlog, 10MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), 10Technical-Debt: Upgrade Vector skin.json schema to v2 - https://phabricator.wikimedia.org/T242469 (10Ammarpad) [17:57:10] (03PS2) 10Jack Phoenix: Actor support, now requires MW 1.34+ [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/565779 (https://phabricator.wikimedia.org/T227345) [17:57:51] (03CR) 10jerkins-bot: [V: 04-1] Actor support, now requires MW 1.34+ [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/565779 (https://phabricator.wikimedia.org/T227345) (owner: 10Jack Phoenix) [18:00:43] (03Abandoned) 10Jack Phoenix: Migrate to exclusively using actor support, and thus requiring MW 1.34+ [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/561337 (owner: 10Jack Phoenix) [18:00:52] 10Desktop Improvements, 10Readers-Web-Backlog, 10MW-1.35-notes (1.35.0-wmf.15; 2020-01-14), 10Technical-Debt: Upgrade Vector skin.json schema to v2 - https://phabricator.wikimedia.org/T242469 (10Ammarpad) a:05Ammarpad→03None Upgraded to manifest version 2, but I am not sure what the third point means. [18:10:32] (03PS3) 10Majavah: Create tests for UploadFromUrl::isAllowedHost [core] - 10https://gerrit.wikimedia.org/r/565760 (https://phabricator.wikimedia.org/T225862) [18:18:18] Hi! So the watch-translations tool (https://tools.wmflabs.org/watch-translations/) shows off a Bad Gateway 502 Error. Is this supposed to be like this? [18:21:56] I'd guess a tool isn't supposed to error, no [18:23:48] (03PS4) 10Majavah: Create tests for UploadFromUrl::isAllowedHost [core] - 10https://gerrit.wikimedia.org/r/565760 (https://phabricator.wikimedia.org/T225862) [18:30:54] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] "Oh, so the style was already mixed before? Well, then let's do this." [core] - 10https://gerrit.wikimedia.org/r/565767 (owner: 10D3r1ck01) [18:34:19] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] preferences: Avoid use of deprecated Language::fetchLanguageNames() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/565773 (owner: 10D3r1ck01) [18:36:47] (03PS6) 10Thiemo Kreuz (WMDE): sparql: Avoid use of deprecated Http::getUserAgent() [core] - 10https://gerrit.wikimedia.org/r/561583 (owner: 10D3r1ck01) [18:37:28] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/565760 (https://phabricator.wikimedia.org/T225862) (owner: 10Majavah) [18:44:29] (03Merged) 10jenkins-bot: ServiceWiring: Cleanup unused closure signatures in serivice wires [core] - 10https://gerrit.wikimedia.org/r/565767 (owner: 10D3r1ck01) [18:46:15] (03CR) 10Jack Phoenix: "I literally can't see what jerkins is complaining about anymore (but I totally expect it to complain about the migration scripts "too long" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/565779 (https://phabricator.wikimedia.org/T227345) (owner: 10Jack Phoenix) [18:46:41] (03PS2) 10Fomafix: Use PHP syntax features from PHP 7.1 [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/565731 [18:48:10] (03PS13) 10Daimona Eaytoy: build: Upgrade phan [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/555686 [18:48:56] (03PS14) 10Daimona Eaytoy: build: Upgrade phan [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/555686 [18:49:11] (03CR) 10jerkins-bot: [V: 04-1] sparql: Avoid use of deprecated Http::getUserAgent() [core] - 10https://gerrit.wikimedia.org/r/561583 (owner: 10D3r1ck01) [18:49:40] (03Merged) 10jenkins-bot: preferences: Avoid use of deprecated Language::fetchLanguageNames() [core] - 10https://gerrit.wikimedia.org/r/565773 (owner: 10D3r1ck01) [18:51:55] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/561583 (owner: 10D3r1ck01) [18:56:38] ping Urbanecm: watch-translations gives 503 (see above) [18:56:53] thanks tassu , looking [18:59:30] JeremyNguyen: it seems to be working now [18:59:35] yup, restarted [19:00:13] Alright thank you. [19:00:39] yw [19:06:43] 10VideoCutTool, 10Toolforge (Software install/update): Request to enable node version 12.14.1 in toolforge to deploy VideoCutTool - https://phabricator.wikimedia.org/T243159 (10JJMC89) [19:09:18] 10MediaViewer: Extension:Media Viewer shows the date before as the date "Created" - https://phabricator.wikimedia.org/T243160 (10Coffeeandcrumbs) [19:09:52] (03CR) 10Skizzerz: [C: 04-2] "Code is correct as-is for this response, the problem you are experiencing lies elsewhere. Following up in phabricator for more details." [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/565738 (https://phabricator.wikimedia.org/T243134) (owner: 10Luca Mauri) [19:12:27] 10MediaWiki-extensions-MediaWikiAuth, 10Patch-For-Review: MediaWikiAuth extension: "Undefined property stdClass::$clientlogin" error on new user login - https://phabricator.wikimedia.org/T243134 (10Skizzerz) The code is fetching the correct properties; all successful API responses have a top-level element equa... [19:14:15] 10MediaWiki-User-management: Prohibit empty blocks - https://phabricator.wikimedia.org/T208645 (10DonTrung) @JRBS Wouldn't this technically be handy for final warnings? Though it probably wouldn't be that beneficial for users, but it could show the seriousness of a warning. [19:23:01] (03PS1) 10MaxSem: Bump codesniffer to 29.0.0 and fix failures [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/565781 [19:23:03] (03PS1) 10MaxSem: Make tests pass with PHPUnit 8 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/565782 (https://phabricator.wikimedia.org/T192167) [19:25:07] 10VideoCutTool: Notify users after computing & uploading videos to commons. - https://phabricator.wikimedia.org/T234783 (10Cernam2) a:03Cernam2 [19:28:30] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/565781 (owner: 10MaxSem) [19:30:58] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/565782 (https://phabricator.wikimedia.org/T192167) (owner: 10MaxSem) [19:31:31] (03CR) 10tosfos: Replaces User watch related calls that are going to be deprecated (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/506885 (https://phabricator.wikimedia.org/T208766) (owner: 10Vedmaka Wakalaka) [19:37:31] (03PS2) 10Legoktm: Remove completely useless (since 2008) EditSimilar::$mMarkerType [extensions/EditSimilar] - 10https://gerrit.wikimedia.org/r/562286 (owner: 10Jack Phoenix) [19:37:36] (03CR) 10Legoktm: [C: 03+2] Remove completely useless (since 2008) EditSimilar::$mMarkerType [extensions/EditSimilar] - 10https://gerrit.wikimedia.org/r/562286 (owner: 10Jack Phoenix) [19:39:47] 10VideoCutTool: Implement "Upload a video from device" and edit using VideoCutTool - https://phabricator.wikimedia.org/T233683 (10Gopavasanth) 05Open→03Resolved [19:40:25] (03Merged) 10jenkins-bot: Remove completely useless (since 2008) EditSimilar::$mMarkerType [extensions/EditSimilar] - 10https://gerrit.wikimedia.org/r/562286 (owner: 10Jack Phoenix) [19:41:37] 10VideoCutTool, 10Google-Code-in-2019: Implement progress bar for video encodings in tool. - https://phabricator.wikimedia.org/T232457 (10Gopavasanth) 05Open→03Resolved As per https://github.com/gopavasanth/video-cut-tool/pull/24 and https://github.com/gopavasanth/video-cut-tool-back-end/pull/9 [19:41:40] (03PS5) 10Jack Phoenix: Set context in OutputPageBeforeHTML hook subscriber function [extensions/EditSimilar] - 10https://gerrit.wikimedia.org/r/556285 [19:42:12] 10VideoCutTool, 10Google-Code-in-2019: Notify users after computing & uploading videos to commons. - https://phabricator.wikimedia.org/T234783 (10Gopavasanth) [19:46:30] (03PS3) 10Legoktm: Unbreak hacky inline JavaScript [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/559458 (owner: 10Jack Phoenix) [19:52:31] (03CR) 10Legoktm: [C: 03+2] "Few points:" [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/559458 (owner: 10Jack Phoenix) [19:55:18] (03Merged) 10jenkins-bot: Unbreak hacky inline JavaScript [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/559458 (owner: 10Jack Phoenix) [19:57:12] (03PS6) 10Jack Phoenix: Set context in OutputPageBeforeHTML hook subscriber function [extensions/EditSimilar] - 10https://gerrit.wikimedia.org/r/556285 [19:57:40] (03CR) 10Legoktm: [C: 03+2] Set context in OutputPageBeforeHTML hook subscriber function [extensions/EditSimilar] - 10https://gerrit.wikimedia.org/r/556285 (owner: 10Jack Phoenix) [20:00:25] (03Merged) 10jenkins-bot: Set context in OutputPageBeforeHTML hook subscriber function [extensions/EditSimilar] - 10https://gerrit.wikimedia.org/r/556285 (owner: 10Jack Phoenix) [20:00:39] (03PS2) 10Legoktm: More RequestContext, less globals [extensions/EditSimilar] - 10https://gerrit.wikimedia.org/r/562345 (owner: 10Jack Phoenix) [20:00:47] (03CR) 10Legoktm: [C: 03+2] More RequestContext, less globals [extensions/EditSimilar] - 10https://gerrit.wikimedia.org/r/562345 (owner: 10Jack Phoenix) [20:01:07] (03PS2) 10MaxSem: Make tests pass with PHPUnit 8 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/565782 (https://phabricator.wikimedia.org/T192167) [20:02:02] (03CR) 10MaxSem: "recheck" [core] - 10https://gerrit.wikimedia.org/r/552312 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [20:03:51] (03Merged) 10jenkins-bot: More RequestContext, less globals [extensions/EditSimilar] - 10https://gerrit.wikimedia.org/r/562345 (owner: 10Jack Phoenix) [20:05:37] (03CR) 10D3r1ck01: preferences: Avoid use of deprecated Language::fetchLanguageNames() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/565773 (owner: 10D3r1ck01) [20:05:47] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/565782 (https://phabricator.wikimedia.org/T192167) (owner: 10MaxSem) [20:10:39] (03PS1) 10Jack Phoenix: Actor support, now requires MW 1.34+ [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/565783 (https://phabricator.wikimedia.org/T227345) [20:11:37] (03CR) 10jerkins-bot: [V: 04-1] Actor support, now requires MW 1.34+ [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/565783 (https://phabricator.wikimedia.org/T227345) (owner: 10Jack Phoenix) [20:13:48] (03CR) 10Florianschmidtwelzow: [C: 03+2] Create tests for UploadFromUrl::isAllowedHost [core] - 10https://gerrit.wikimedia.org/r/565760 (https://phabricator.wikimedia.org/T225862) (owner: 10Majavah) [20:14:36] (03CR) 10Jack Phoenix: "I'd be lying if I said I expected jenkins to V+2 this." [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/565783 (https://phabricator.wikimedia.org/T227345) (owner: 10Jack Phoenix) [20:14:42] 10MediaWiki-Core-Testing, 10MediaWiki-Uploading, 10Multimedia, 10Google-Code-in-2019, and 3 others: Create tests for UploadFromUrl::isAllowedHost - https://phabricator.wikimedia.org/T225862 (10Florian) 05Open→03Resolved [20:14:44] 10MediaWiki-extensions-MediaWikiAuth, 10Patch-For-Review: MediaWikiAuth extension: "Undefined property stdClass::$clientlogin" error on new user login - https://phabricator.wikimedia.org/T243134 (10lucamauri) >>! In T243134#5815545, @Skizzerz wrote: > Please enable debug logging so that we can better determine... [20:29:24] 10Developer-Advocacy (Jan-Mar 2020), 10Google-Code-in-2019: Google Code-In 2019 Create a logo to represent Friends of the Docs - https://phabricator.wikimedia.org/T239637 (10Userring) a:03Userring [20:34:35] 10Developer-Advocacy (Jan-Mar 2020), 10Google-Code-in-2019: Google Code-In 2019 Create a logo to represent Friends of the Docs - https://phabricator.wikimedia.org/T239637 (10Userring) My logo design for Friends of the Docs as part of a GCI task: {F31517467} This is my work and no other author's work has bee... [20:37:41] (03PS1) 10MaxSem: Fix PHPUnit 8 warnings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/565785 (https://phabricator.wikimedia.org/T192167) [20:39:52] (03PS1) 10MaxSem: Fix PHPUnit 8 warning [extensions/Cite] - 10https://gerrit.wikimedia.org/r/565786 (https://phabricator.wikimedia.org/T192167) [20:40:31] 10Wikimedia-Site-requests, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): Create and use the Latin wikipedia (VICIPÆDIA) wordmark on mobile site - https://phabricator.wikimedia.org/T240728 (10UV) 05Resolved→03Open Reopening. Not resolved yet. https://la.m.wikipedia.org/static/images/m... [20:43:22] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/565785 (https://phabricator.wikimedia.org/T192167) (owner: 10MaxSem) [20:45:31] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/565786 (https://phabricator.wikimedia.org/T192167) (owner: 10MaxSem) [20:45:45] (03CR) 10Umherirrender: [V: 03+2] Pretify messages [extensions/Shibboleth] - 10https://gerrit.wikimedia.org/r/565729 (owner: 10Raimond Spekking) [20:48:58] (03CR) 10Jforrester: [C: 03+2] Bump codesniffer to 29.0.0 and fix failures [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/565781 (owner: 10MaxSem) [20:49:20] (03CR) 10Jforrester: [C: 03+2] Make tests pass with PHPUnit 8 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/565782 (https://phabricator.wikimedia.org/T192167) (owner: 10MaxSem) [21:03:55] (03Merged) 10jenkins-bot: Bump codesniffer to 29.0.0 and fix failures [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/565781 (owner: 10MaxSem) [21:04:05] (03Merged) 10jenkins-bot: Make tests pass with PHPUnit 8 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/565782 (https://phabricator.wikimedia.org/T192167) (owner: 10MaxSem) [21:10:32] 10Wikimedia-Site-requests, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): Create and use the Latin wikipedia (VICIPÆDIA) wordmark on mobile site - https://phabricator.wikimedia.org/T240728 (10MarcoAurelio) The patch (https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/557439/)... [21:17:25] 10Wikimedia-Site-requests, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): Create and use the Latin wikipedia (VICIPÆDIA) wordmark on mobile site - https://phabricator.wikimedia.org/T240728 (10Zoranzoki21) >>! In T240728#5815581, @MarcoAurelio wrote: > The patch (https://gerrit.wikimedia.or... [21:26:16] 10Wikimedia-Site-requests, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q3): Create and use the Latin wikipedia (VICIPÆDIA) wordmark on mobile site - https://phabricator.wikimedia.org/T240728 (10Ammarpad) >>! In T240728#5815581, @MarcoAurelio wrote: > The patch (https://gerrit.wikimedia.org/r... [21:40:31] (03CR) 10Reedy: [C: 04-1] Convert si_title to `varchar(255) BINARY NOT NULL default ''` (032 comments) [core] - 10https://gerrit.wikimedia.org/r/565765 (owner: 10Paladox) [21:41:30] (03PS1) 10Reedy: Swap 1,33 for 1.33 in MysqlUpdater [core] - 10https://gerrit.wikimedia.org/r/565787 [21:41:34] (03PS5) 10Paladox: Convert si_title to `varchar(255) BINARY NOT NULL default ''` [core] - 10https://gerrit.wikimedia.org/r/565765 [21:41:46] (03CR) 10Paladox: Convert si_title to `varchar(255) BINARY NOT NULL default ''` (032 comments) [core] - 10https://gerrit.wikimedia.org/r/565765 (owner: 10Paladox) [21:55:07] 10MediaWiki-extensions-WikibaseRepository, 10StructuredDataOnCommons, 10Wikidata, 10MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Add monolingual language code WLS (Wallisian) - https://phabricator.wikimedia.org/T239411 (10Skimel) Hello, thanks for closin... [21:55:19] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/565765 (owner: 10Paladox) [21:56:53] (03CR) 10SonarQube Bot: [V: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/565787 (owner: 10Reedy) [22:01:25] 10MediaWiki-extensions-WikibaseRepository, 10StructuredDataOnCommons, 10Wikidata, 10MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Add monolingual language code WLS (Wallisian) - https://phabricator.wikimedia.org/T239411 (10Mbch331) >>! In T239411#5815588,... [22:11:01] 10MediaWiki-General, 10User-RhinosF1: searchindex: Data too long for column 'si_title' - https://phabricator.wikimedia.org/T243162 (10Paladox) [22:11:35] 10MediaWiki-Search, 10Discovery-Search, 10User-RhinosF1: searchindex: Data too long for column 'si_title' - https://phabricator.wikimedia.org/T243162 (10Reedy) [22:16:40] (03PS3) 10Jack Phoenix: Actor support, now requires MW 1.34+ [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/565779 (https://phabricator.wikimedia.org/T227345) [22:17:35] (03CR) 10jerkins-bot: [V: 04-1] Actor support, now requires MW 1.34+ [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/565779 (https://phabricator.wikimedia.org/T227345) (owner: 10Jack Phoenix) [22:23:26] 10MediaWiki-extensions-WikibaseRepository, 10StructuredDataOnCommons, 10Wikidata, 10MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Add monolingual language code WLS (Wallisian) - https://phabricator.wikimedia.org/T239411 (10Skimel) Alright, I need to type... [22:53:57] 10MediaWiki-Search, 10Discovery-Search, 10User-RhinosF1: searchindex: Data too long for column 'si_title' - https://phabricator.wikimedia.org/T243162 (10Paladox) User blog comment:Lost Labyrinth/If you missed out on certain expansions or stuff packs for The Sims 2, here's your chance to grab them now/@commen... [22:59:24] 10MediaWiki-User-management: Prohibit empty blocks - https://phabricator.wikimedia.org/T208645 (10jrbs) >>! In T208645#5815547, @DonTrung wrote: > @JRBS Wouldn't this technically be handy for final warnings? Though it probably wouldn't be that beneficial for users, but it could show the seriousness of a warning....