[00:01:14] (03CR) 10Umherirrender: "It would only break when running the unit tests with Mediawiki < 1.35, but it does not break production compatibility" [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/561188 (https://phabricator.wikimedia.org/T196090) (owner: 10Umherirrender) [00:02:49] (03PS3) 10TheSandDoctor: Hard deprecated $wgParser [core] - 10https://gerrit.wikimedia.org/r/561174 (https://phabricator.wikimedia.org/T160811) [00:03:03] (03Merged) 10jenkins-bot: Upgrade phan and unbreak master [extensions/ImageRating] - 10https://gerrit.wikimedia.org/r/560844 (owner: 10Daimona Eaytoy) [00:05:45] (03CR) 10TheSandDoctor: [C: 04-1] "That didnt commit as intended. Stand by" [core] - 10https://gerrit.wikimedia.org/r/561174 (https://phabricator.wikimedia.org/T160811) (owner: 10TheSandDoctor) [00:07:03] (03PS1) 10DannyS712: Remove uses of global $wgUser [extensions/AbsenteeLandlord] - 10https://gerrit.wikimedia.org/r/561220 (https://phabricator.wikimedia.org/T241613) [00:07:53] (03PS2) 10DannyS712: Remove uses of global $wgUser [extensions/AbsenteeLandlord] - 10https://gerrit.wikimedia.org/r/561220 (https://phabricator.wikimedia.org/T241613) [00:08:57] (03PS4) 10TheSandDoctor: Hard deprecate $wgParser [core] - 10https://gerrit.wikimedia.org/r/561174 (https://phabricator.wikimedia.org/T160811) [00:09:06] (03PS1) 10DannyS712: Remove uses of global $wgUser [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/561225 (https://phabricator.wikimedia.org/T241612) [00:09:58] (03PS5) 10TheSandDoctor: Hard deprecate $wgParser [core] - 10https://gerrit.wikimedia.org/r/561174 (https://phabricator.wikimedia.org/T160811) [00:12:06] (03PS2) 10DannyS712: Remove uses of global $wgUser [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/561225 (https://phabricator.wikimedia.org/T241612) [00:13:00] (03PS1) 10DannyS712: Remove uses of global $wgUser [extensions/LogEntry] - 10https://gerrit.wikimedia.org/r/561228 (https://phabricator.wikimedia.org/T241611) [00:14:19] (03PS2) 10DannyS712: Remove uses of global $wgUser [extensions/LogEntry] - 10https://gerrit.wikimedia.org/r/561228 (https://phabricator.wikimedia.org/T241611) [00:15:05] (03CR) 10jerkins-bot: [V: 04-1] Remove uses of global $wgUser [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/561225 (https://phabricator.wikimedia.org/T241612) (owner: 10DannyS712) [00:15:16] (03PS1) 10DannyS712: Remove uses of global $wgUser [extensions/EditSimilar] - 10https://gerrit.wikimedia.org/r/561229 (https://phabricator.wikimedia.org/T241610) [00:16:15] (03CR) 10jerkins-bot: [V: 04-1] Remove uses of global $wgUser [extensions/LogEntry] - 10https://gerrit.wikimedia.org/r/561228 (https://phabricator.wikimedia.org/T241611) (owner: 10DannyS712) [00:17:16] (03PS2) 10DannyS712: Remove uses of global $wgUser [extensions/EditSimilar] - 10https://gerrit.wikimedia.org/r/561229 (https://phabricator.wikimedia.org/T241610) [00:18:09] (03PS1) 10DannyS712: Remove uses of global $wgUser [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/561231 (https://phabricator.wikimedia.org/T241609) [00:20:30] (03PS2) 10DannyS712: Remove uses of global $wgUser [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/561231 (https://phabricator.wikimedia.org/T241609) [00:21:25] (03PS1) 10DannyS712: Remove uses of global $wgUser [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/561233 (https://phabricator.wikimedia.org/T241608) [00:24:07] (03CR) 10Jack Phoenix: [C: 03+2] Remove uses of global $wgUser [extensions/EditSimilar] - 10https://gerrit.wikimedia.org/r/561229 (https://phabricator.wikimedia.org/T241610) (owner: 10DannyS712) [00:24:46] (03PS1) 10Umherirrender: Remove duplicate message key jade-nochange from en.json [extensions/Jade] - 10https://gerrit.wikimedia.org/r/561236 [00:24:56] (03CR) 10jerkins-bot: [V: 04-1] Hard deprecate $wgParser [core] - 10https://gerrit.wikimedia.org/r/561174 (https://phabricator.wikimedia.org/T160811) (owner: 10TheSandDoctor) [00:27:14] (03Merged) 10jenkins-bot: Remove uses of global $wgUser [extensions/EditSimilar] - 10https://gerrit.wikimedia.org/r/561229 (https://phabricator.wikimedia.org/T241610) (owner: 10DannyS712) [00:33:44] (03PS2) 10DannyS712: Remove uses of global $wgUser [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/561233 (https://phabricator.wikimedia.org/T241608) [00:35:55] (03CR) 10DannyS712: "Special page doesn't work - "Undefined variable: page" but that is unrelated to this patch" (031 comment) [extensions/LogEntry] - 10https://gerrit.wikimedia.org/r/561228 (https://phabricator.wikimedia.org/T241611) (owner: 10DannyS712) [00:39:08] (03CR) 10jerkins-bot: [V: 04-1] Remove uses of global $wgUser [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/561233 (https://phabricator.wikimedia.org/T241608) (owner: 10DannyS712) [00:43:11] (03PS3) 10DannyS712: Remove uses of global $wgUser [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/561225 (https://phabricator.wikimedia.org/T241612) [00:43:54] (03CR) 10jerkins-bot: [V: 04-1] Remove uses of global $wgUser [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/561225 (https://phabricator.wikimedia.org/T241612) (owner: 10DannyS712) [00:44:37] (03PS3) 10DannyS712: Remove uses of global $wgUser [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/561233 (https://phabricator.wikimedia.org/T241608) [00:45:04] (03PS4) 10DannyS712: Remove uses of global $wgUser [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/561225 (https://phabricator.wikimedia.org/T241612) [00:48:09] (03CR) 10jerkins-bot: [V: 04-1] Remove uses of global $wgUser [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/561225 (https://phabricator.wikimedia.org/T241612) (owner: 10DannyS712) [00:50:32] (03PS5) 10DannyS712: Remove uses of global $wgUser [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/561225 (https://phabricator.wikimedia.org/T241612) [00:50:58] (03PS4) 10DannyS712: Remove use of global $wgUser [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/561137 (https://phabricator.wikimedia.org/T241582) [00:53:35] (03CR) 10jerkins-bot: [V: 04-1] Remove uses of global $wgUser [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/561225 (https://phabricator.wikimedia.org/T241612) (owner: 10DannyS712) [00:57:12] (03CR) 10DannyS712: "> Main test build failed." [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/561225 (https://phabricator.wikimedia.org/T241612) (owner: 10DannyS712) [01:08:35] (03PS1) 10DannyS712: Remove uses of global $wgUser [extensions/Collection] - 10https://gerrit.wikimedia.org/r/561238 (https://phabricator.wikimedia.org/T241616) [01:09:09] (03PS2) 10DannyS712: Remove uses of global $wgUser [extensions/Collection] - 10https://gerrit.wikimedia.org/r/561238 (https://phabricator.wikimedia.org/T241616) [01:10:51] (03PS1) 10DannyS712: Remove uses of global $wgUser [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/561239 (https://phabricator.wikimedia.org/T241617) [01:12:18] (03PS2) 10DannyS712: Remove uses of global $wgUser and of global $wgRequest [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/561239 (https://phabricator.wikimedia.org/T241617) [01:15:31] (03CR) 10jerkins-bot: [V: 04-1] Remove uses of global $wgUser and of global $wgRequest [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/561239 (https://phabricator.wikimedia.org/T241617) (owner: 10DannyS712) [01:15:41] (03PS3) 10DannyS712: Remove uses of global $wgUser and of global $wgRequest [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/561239 (https://phabricator.wikimedia.org/T241617) [01:38:35] (03CR) 10DannyS712: [C: 03+1] "Looks good" [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/561217 (https://phabricator.wikimedia.org/T196090) (owner: 10Umherirrender) [01:39:58] (03CR) 10DannyS712: [C: 03+1] "Looks good" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/561181 (https://phabricator.wikimedia.org/T196090) (owner: 10Umherirrender) [01:41:03] (03CR) 10DannyS712: Remove duplicate message key jade-nochange from en.json (031 comment) [extensions/Jade] - 10https://gerrit.wikimedia.org/r/561236 (owner: 10Umherirrender) [02:07:03] (03CR) 10Yaron Koren: [C: 03+2] Remove uses of global $wgUser [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/561231 (https://phabricator.wikimedia.org/T241609) (owner: 10DannyS712) [02:10:08] (03Merged) 10jenkins-bot: Remove uses of global $wgUser [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/561231 (https://phabricator.wikimedia.org/T241609) (owner: 10DannyS712) [02:14:19] (03PS1) 10DannyS712: Remove uses of global $wgUser [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/561242 (https://phabricator.wikimedia.org/T241619) [02:22:44] (03PS2) 10DannyS712: Remove uses of global $wgUser and some uses of $wgOut and $wgRequest [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/561242 (https://phabricator.wikimedia.org/T241619) [02:24:01] (03CR) 10jerkins-bot: [V: 04-1] Remove uses of global $wgUser and some uses of $wgOut and $wgRequest [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/561242 (https://phabricator.wikimedia.org/T241619) (owner: 10DannyS712) [02:30:54] (03PS3) 10DannyS712: Remove uses of global $wgUser and some uses of $wgOut and $wgRequest [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/561242 (https://phabricator.wikimedia.org/T241619) [02:32:28] (03CR) 10jerkins-bot: [V: 04-1] Remove uses of global $wgUser and some uses of $wgOut and $wgRequest [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/561242 (https://phabricator.wikimedia.org/T241619) (owner: 10DannyS712) [02:34:36] (03PS4) 10DannyS712: Remove uses of global $wgUser and some uses of $wgOut and $wgRequest [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/561242 (https://phabricator.wikimedia.org/T241619) [02:37:43] (03CR) 10jerkins-bot: [V: 04-1] Remove uses of global $wgUser and some uses of $wgOut and $wgRequest [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/561242 (https://phabricator.wikimedia.org/T241619) (owner: 10DannyS712) [02:38:25] (03PS1) 10DannyS712: Remove uses of global $wgUser [extensions/Survey] - 10https://gerrit.wikimedia.org/r/561243 (https://phabricator.wikimedia.org/T241620) [02:41:04] (03PS1) 10BrandonXLF: Pass empty array to addToRecipient [extensions/Mailgun] - 10https://gerrit.wikimedia.org/r/561244 (https://phabricator.wikimedia.org/T230739) [02:43:10] (03PS2) 10DannyS712: Remove uses of global $wgUser [extensions/Survey] - 10https://gerrit.wikimedia.org/r/561243 (https://phabricator.wikimedia.org/T241620) [02:44:13] (03CR) 10DannyS712: "> Main test build failed." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/561242 (https://phabricator.wikimedia.org/T241619) (owner: 10DannyS712) [02:46:54] (03CR) 10DannyS712: "Recheck" [extensions/Mailgun] - 10https://gerrit.wikimedia.org/r/561244 (https://phabricator.wikimedia.org/T230739) (owner: 10BrandonXLF) [02:48:14] (03CR) 10DannyS712: "Recheck" [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/561128 (https://phabricator.wikimedia.org/T239882) (owner: 10BrandonXLF) [02:49:12] (03PS1) 10DannyS712: Remove uses of global $wgUser [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/561245 (https://phabricator.wikimedia.org/T241621) [02:50:03] (03CR) 10jerkins-bot: [V: 04-1] Remove uses of global $wgUser [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/561245 (https://phabricator.wikimedia.org/T241621) (owner: 10DannyS712) [02:51:20] (03PS2) 10DannyS712: Remove uses of global $wgUser [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/561245 (https://phabricator.wikimedia.org/T241621) [02:52:14] (03CR) 10jerkins-bot: [V: 04-1] Remove uses of global $wgUser [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/561245 (https://phabricator.wikimedia.org/T241621) (owner: 10DannyS712) [02:52:32] (03CR) 10DannyS712: "test 1.34" [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/561245 (https://phabricator.wikimedia.org/T241621) (owner: 10DannyS712) [02:53:28] (03CR) 10DannyS712: "recheck 1_34" [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/561245 (https://phabricator.wikimedia.org/T241621) (owner: 10DannyS712) [02:53:47] (03CR) 10DannyS712: "test 1_34" [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/561245 (https://phabricator.wikimedia.org/T241621) (owner: 10DannyS712) [02:57:59] (03CR) 10DannyS712: "Extension doesn't work in 1.35 - can't figure out how to test against 1.34" [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/561245 (https://phabricator.wikimedia.org/T241621) (owner: 10DannyS712) [03:00:09] (03PS1) 10DannyS712: Remove uses of global $wgUser [extensions/AnonPrivacy] - 10https://gerrit.wikimedia.org/r/561246 (https://phabricator.wikimedia.org/T241622) [03:01:05] (03PS2) 10DannyS712: Remove uses of global $wgUser [extensions/AnonPrivacy] - 10https://gerrit.wikimedia.org/r/561246 (https://phabricator.wikimedia.org/T241622) [03:01:35] (03CR) 10Jack Phoenix: [V: 03+2 C: 03+2] "Let's cross that bridge when it's appropriate (i.e. when 1.35 is stable, or so); if and when it works on 1.34, that's good enough since 1." [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/561245 (https://phabricator.wikimedia.org/T241621) (owner: 10DannyS712) [03:02:50] (03CR) 10Jack Phoenix: [C: 03+2] "Awesome, thank you!" [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/561165 (owner: 10Daimona Eaytoy) [03:05:55] (03Merged) 10jenkins-bot: Use normal Database wrappers instead of raw SQL [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/561165 (owner: 10Daimona Eaytoy) [03:10:19] (03PS2) 10Jack Phoenix: Replace crappy inline JS with something slightly more proper, I hope [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/559458 [03:11:07] (03CR) 10Jack Phoenix: "Thiemo, I appreciate you taking the time to review this patch and comment on it, but I have to say I'm a bit baffled here. To me, as a dev" [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/559458 (owner: 10Jack Phoenix) [03:28:16] (03PS1) 10DannyS712: Remove uses of global $wgUser [extensions/MarkAsHelpful] - 10https://gerrit.wikimedia.org/r/561247 (https://phabricator.wikimedia.org/T241624) [03:31:20] (03PS2) 10DannyS712: Remove uses of global $wgUser [extensions/MarkAsHelpful] - 10https://gerrit.wikimedia.org/r/561247 (https://phabricator.wikimedia.org/T241624) [03:32:04] (03PS1) 10DannyS712: Remove uses of global $wgUser [extensions/Athena] - 10https://gerrit.wikimedia.org/r/561248 (https://phabricator.wikimedia.org/T241625) [03:33:18] (03PS2) 10DannyS712: Remove uses of global $wgUser [extensions/Athena] - 10https://gerrit.wikimedia.org/r/561248 (https://phabricator.wikimedia.org/T241625) [03:34:21] (03PS1) 10DannyS712: Remove uses of global $wgUser [extensions/AzharAuth] - 10https://gerrit.wikimedia.org/r/561249 (https://phabricator.wikimedia.org/T241626) [03:36:52] (03PS2) 10DannyS712: Remove uses of global $wgUser [extensions/AzharAuth] - 10https://gerrit.wikimedia.org/r/561249 (https://phabricator.wikimedia.org/T241626) [03:37:57] (03PS1) 10DannyS712: Remove uses of global $wgUser [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/561250 (https://phabricator.wikimedia.org/T241627) [03:41:31] (03PS2) 10DannyS712: Remove uses of global $wgUser [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/561250 (https://phabricator.wikimedia.org/T241627) [03:42:19] (03PS1) 10DannyS712: Remove uses of global $wgUser [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/561251 (https://phabricator.wikimedia.org/T241628) [03:44:34] (03CR) 10jerkins-bot: [V: 04-1] Remove uses of global $wgUser [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/561250 (https://phabricator.wikimedia.org/T241627) (owner: 10DannyS712) [03:46:07] (03CR) 10jerkins-bot: [V: 04-1] Remove uses of global $wgUser [extensions/Athena] - 10https://gerrit.wikimedia.org/r/561248 (https://phabricator.wikimedia.org/T241625) (owner: 10DannyS712) [03:47:00] Hi, I'm a student for Google Code-in! So I just finished installing Vagrant and I'm on http://dev.wiki.local.wmftest.net:8080/ and I see just a page said "Main Page [03:47:00] ". What do I do now? [03:47:08] (03PS2) 10DannyS712: Remove uses of global $wgUser and some uses of $wgOut and $wgRequest [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/561251 (https://phabricator.wikimedia.org/T241628) [03:47:21] For reference, I'm working on the task on replacing "wfMessage()->rawParams()" [03:47:23] (03CR) 10jerkins-bot: [V: 04-1] Remove uses of global $wgUser and some uses of $wgOut and $wgRequest [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/561251 (https://phabricator.wikimedia.org/T241628) (owner: 10DannyS712) [03:47:59] (03PS3) 10DannyS712: Remove uses of global $wgUser and some uses of $wgOut and $wgRequest [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/561251 (https://phabricator.wikimedia.org/T241628) [03:52:06] (03CR) 10DannyS712: "Tests failing do not appear to be caused by this change - hooks just take too long" [extensions/Athena] - 10https://gerrit.wikimedia.org/r/561248 (https://phabricator.wikimedia.org/T241625) (owner: 10DannyS712) [03:52:31] (03PS3) 10DannyS712: Remove uses of global $wgUser [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/561250 (https://phabricator.wikimedia.org/T241627) [03:54:31] (03PS1) 10DannyS712: Remove uses of global $wgUser [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/561252 (https://phabricator.wikimedia.org/T241629) [03:56:09] (03PS2) 10DannyS712: Remove uses of global $wgUser and reduce use of global $wgOut [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/561252 (https://phabricator.wikimedia.org/T241629) [03:57:15] (03PS1) 10DannyS712: Remove uses of global $wgUser [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/561253 (https://phabricator.wikimedia.org/T241630) [03:58:55] (03PS2) 10DannyS712: Remove uses of global $wgUser [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/561253 (https://phabricator.wikimedia.org/T241630) [04:23:08] (03CR) 10DannyS712: [C: 03+1] "Looks good" [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/561152 (owner: 10Jack Phoenix) [04:24:31] (03PS4) 10DannyS712: Removed all usages of $wgLang and $wgUser [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/561150 (https://phabricator.wikimedia.org/T241631) (owner: 10Jack Phoenix) [04:25:07] (03CR) 10DannyS712: "I tweaked the commit message, including a reference to T241631, which I filed as part of T159299 - hope you don't mind" [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/561150 (https://phabricator.wikimedia.org/T241631) (owner: 10Jack Phoenix) [04:28:40] (03CR) 10Jack Phoenix: [C: 03+2] Remove uses of global $wgUser [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/561250 (https://phabricator.wikimedia.org/T241627) (owner: 10DannyS712) [04:31:16] (03CR) 10DannyS712: [C: 03+1] "Some nitpicking" (036 comments) [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/561150 (https://phabricator.wikimedia.org/T241631) (owner: 10Jack Phoenix) [04:31:47] (03Merged) 10jenkins-bot: Remove uses of global $wgUser [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/561250 (https://phabricator.wikimedia.org/T241627) (owner: 10DannyS712) [04:37:20] (03CR) 10DannyS712: [C: 03+1] Pass 1 always as string to IDatabase::select and friends [core] - 10https://gerrit.wikimedia.org/r/561176 (owner: 10Umherirrender) [04:46:41] (03CR) 10DannyS712: [C: 03+1] "Couldn't find any other uses of true" [core] - 10https://gerrit.wikimedia.org/r/561175 (owner: 10Umherirrender) [04:47:48] (03CR) 10DannyS712: [V: 03+1 C: 03+1] "Look good; no affect on actual code" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/560973 (owner: 10Umherirrender) [04:59:01] (03PS14) 10DannyS712: [WIP] Thanks [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/560802 [05:02:45] JeremyNguyen: did you figure it out? sorry only just saw your message [05:03:03] no i have not [05:03:27] so uh hi! how you doin [05:04:03] I'm very tired but can try to help [05:04:10] go to sleep man [05:04:27] good night [05:05:10] so I'm confused by your message, by you only see a page called main page, do you mean the only text on the page is "Main Page"? [05:05:24] if so, you probably need to install a skin [05:05:40] No, I mean I see the normal wikimedia page and the heading being "Main Page" [05:05:47] oh [05:06:07] right are you asking what you do for the task? [05:06:13] pretty much haha [05:06:19] thought you were having issues with the installation aha [05:06:49] i wasn't sure if i was having trouble with the installation but i guess that's right then? [05:06:56] if I remember correctly, you need to choose an extension and replace all instances of rawParams()? [05:07:02] yeah, that's normal [05:07:26] it's just replace one instance if i recall [05:07:32] main page doesn't have anything on it post-install iirc [05:07:40] > The task is to find one instance of wfMessage() [05:07:42] yup [05:07:52] okay, so you need to install an extension, find an instance of that and replace it [05:07:58] then push your changes to Gerrit [05:08:05] oh ok [05:08:06] thank you! [05:08:11] good night man [05:08:55] probably won't be able to sleep for a while, be sure to mention me if you need anything else :) [05:09:15] alright no worries! [05:10:03] (03PS2) 10Yaron Koren: Replace $wgParser with MediaWikiServices for MW >= 1.29 [extensions/DataTransfer] - 10https://gerrit.wikimedia.org/r/561172 (https://phabricator.wikimedia.org/T241568) (owner: 10TheSandDoctor) [05:11:46] (03PS1) 10DannyS712: Update `gadgets-prefstext` regarding interface administrators [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/561254 (https://phabricator.wikimedia.org/T241634) [05:12:45] (03PS2) 10DannyS712: Update `gadgets-prefstext` regarding interface administrators [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/561254 (https://phabricator.wikimedia.org/T241634) [05:18:40] (03CR) 10Yaron Koren: [C: 03+2] Replace $wgParser with MediaWikiServices for MW >= 1.29 [extensions/DataTransfer] - 10https://gerrit.wikimedia.org/r/561172 (https://phabricator.wikimedia.org/T241568) (owner: 10TheSandDoctor) [05:21:41] (03Merged) 10jenkins-bot: Replace $wgParser with MediaWikiServices for MW >= 1.29 [extensions/DataTransfer] - 10https://gerrit.wikimedia.org/r/561172 (https://phabricator.wikimedia.org/T241568) (owner: 10TheSandDoctor) [07:02:53] (03CR) 10Legoktm: [C: 03+2] Move test-only classes to new TestAutoloadClasses declaration [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/561189 (https://phabricator.wikimedia.org/T196090) (owner: 10Umherirrender) [07:03:32] (03CR) 10Legoktm: [C: 03+2] Move test-only classes to new TestAutoloadClasses declaration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/561181 (https://phabricator.wikimedia.org/T196090) (owner: 10Umherirrender) [07:25:11] 10Wikimedia-Site-requests: Add domain to $wgCopyUploadsDomains - https://phabricator.wikimedia.org/T241637 (10ChristianFerrer) [07:25:21] (03Merged) 10jenkins-bot: Move test-only classes to new TestAutoloadClasses declaration [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/561189 (https://phabricator.wikimedia.org/T196090) (owner: 10Umherirrender) [07:25:23] (03Merged) 10jenkins-bot: Move test-only classes to new TestAutoloadClasses declaration [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/561181 (https://phabricator.wikimedia.org/T196090) (owner: 10Umherirrender) [07:36:00] 04(no projects): I am getting ContainerDisabledException in ServiceContainer - https://phabricator.wikimedia.org/T241638 (10mkysoft) [07:38:41] 04(no projects): I am getting ContainerDisabledException in ServiceContainer - https://phabricator.wikimedia.org/T241638 (10mkysoft) [07:54:08] (03PS1) 10DannyS712: LoadBalancer: `and` should just be `an` [core] - 10https://gerrit.wikimedia.org/r/561263 (https://phabricator.wikimedia.org/T201491) [07:54:59] (03PS2) 10DannyS712: LoadBalancer: `and` should just be `an` [core] - 10https://gerrit.wikimedia.org/r/561263 (https://phabricator.wikimedia.org/T201491) [08:08:51] (03CR) 10DCausse: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/559985 (owner: 10Libraryupgrader) [08:11:56] (03CR) 10DCausse: [C: 03+2] Migrate Database::query with true to IDatabase::QUERY_SILENCE_ERRORS [core] - 10https://gerrit.wikimedia.org/r/561175 (owner: 10Umherirrender) [08:13:35] 10MediaWiki-Internationalization, 10I18n, 10JavaScript: jquery.i18n does not support loading a single message file for all languages from a URL - https://phabricator.wikimedia.org/T241639 (10LucasWerkmeister) [08:20:36] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/559985 (owner: 10Libraryupgrader) [08:25:45] (03Merged) 10jenkins-bot: Migrate Database::query with true to IDatabase::QUERY_SILENCE_ERRORS [core] - 10https://gerrit.wikimedia.org/r/561175 (owner: 10Umherirrender) [08:27:08] 04(no projects): I am getting ContainerDisabledException in ServiceContainer - https://phabricator.wikimedia.org/T241638 (10Peachey88) [08:28:19] 10Wikimedia-production-error: I am getting ContainerDisabledException in ServiceContainer - https://phabricator.wikimedia.org/T241638 (10Masumrezarock100) [08:29:28] 04(no projects): I am getting ContainerDisabledException in ServiceContainer - https://phabricator.wikimedia.org/T241638 (10Peachey88) @Masumrezarock100 The stack trace shows that it is a not a production wiki, that isn't a appropriate tag for the task. [08:32:55] 10ShoutWiki: Attempt to create Shoutwiki wiki results in error - https://phabricator.wikimedia.org/T241623 (10Masumrezarock100) [08:45:19] (03Abandoned) 10Hashar: Reenable selenium-test in CI [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/537369 (https://phabricator.wikimedia.org/T229033) (owner: 10Hashar) [08:45:50] 10ShoutWiki: Attempt to create Shoutwiki wiki results in error - https://phabricator.wikimedia.org/T241623 (10Peachey88) [09:10:55] 10MediaWiki-General: I am getting ContainerDisabledException in ServiceContainer - https://phabricator.wikimedia.org/T241638 (10jcrespo) [09:11:52] 10MediaWiki-Internationalization, 10I18n, 10JavaScript, 10Patch-For-Review: jquery.i18n does not support loading a single message file for all languages from a URL - https://phabricator.wikimedia.org/T241639 (10LucasWerkmeister) #patch-for-review: [wikimedia/jquery.i18n#206](https://github.com/wikimedia/jq... [09:12:19] (03CR) 10Hashar: "recheck" [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/561188 (https://phabricator.wikimedia.org/T196090) (owner: 10Umherirrender) [09:12:42] 10MediaWiki-General, 10MediaWiki-Installer: I am getting ContainerDisabledException in ServiceContainer - https://phabricator.wikimedia.org/T241638 (10jcrespo) [09:13:39] (03CR) 10Hashar: "the phan failure is unrelated :)" [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/561188 (https://phabricator.wikimedia.org/T196090) (owner: 10Umherirrender) [09:15:18] 10MediaWiki-General, 10MediaWiki-Installer, 10MediaWiki-Internationalization: I am getting ContainerDisabledException in ServiceContainer - https://phabricator.wikimedia.org/T241638 (10jcrespo) [09:15:35] (03CR) 10jerkins-bot: [V: 04-1] Move test-only classes to new TestAutoloadClasses declaration [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/561188 (https://phabricator.wikimedia.org/T196090) (owner: 10Umherirrender) [09:18:37] (03CR) 10Daimona Eaytoy: [C: 03+2] Remove uses of global $wgUser [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/561130 (https://phabricator.wikimedia.org/T241577) (owner: 10DannyS712) [09:18:54] 10MediaWiki-extensions-AdminLinks, 10Technical-Debt (Deprecation process), 10User-DannyS712: AdminLinks needs uses of global $wgUser removed - https://phabricator.wikimedia.org/T241577 (10Daimona) 05Open→03Resolved [09:18:59] 10MediaWiki-User-management, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Patch-For-Review, 10Technical-Debt (Deprecation process), 10User-DannyS712: Deprecate $wgUser - https://phabricator.wikimedia.org/T159299 (10Daimona) [09:19:28] 10MediaWiki-General, 10MediaWiki-Installer, 10MediaWiki-Internationalization: I am getting ContainerDisabledException in ServiceContainer - https://phabricator.wikimedia.org/T241638 (10jcrespo) I am no mediawiki developer, but normally one would ask for the Mediawiki version, what steps you were trying to ac... [09:21:07] (03CR) 10Daimona Eaytoy: [C: 04-1] "I just realised that I haven't been very clear in my previous comment. Since this method is apparently dead code, I'd suggest to make it n" [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/561132 (https://phabricator.wikimedia.org/T241578) (owner: 10DannyS712) [09:21:37] (03Merged) 10jenkins-bot: Remove uses of global $wgUser [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/561130 (https://phabricator.wikimedia.org/T241577) (owner: 10DannyS712) [09:23:30] (03CR) 10Daimona Eaytoy: [C: 04-1] Hard deprecate $wgParser (031 comment) [core] - 10https://gerrit.wikimedia.org/r/561174 (https://phabricator.wikimedia.org/T160811) (owner: 10TheSandDoctor) [09:25:04] 10ContentTranslation: In Content Translation article selector an exact match should appear first, before other titles that begin with this string - https://phabricator.wikimedia.org/T241640 (10Amire80) [09:27:59] 04(no projects): Add title property to links - https://phabricator.wikimedia.org/T241641 (10Maurizioricci95) [09:29:29] 10MediaWiki-Page-editing, 10VisualEditor, 10VisualEditor-Links, 10VisualEditor-MediaWiki-Links: Add title property to links - https://phabricator.wikimedia.org/T241641 (10Maurizioricci95) [09:36:13] (03CR) 10Daimona Eaytoy: [C: 04-1] "Also, I'd recommend replacing all assertEquals with assertSame - the former brings all disadvantages of weak comparisons." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/560455 (https://phabricator.wikimedia.org/T241406) (owner: 10DannyS712) [09:41:28] (03CR) 10Daimona Eaytoy: "Belatedly, I would have preferred dependency injection to be used here. As I've already mentioned, RequestContext::getMain is still subpar" (031 comment) [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/561245 (https://phabricator.wikimedia.org/T241621) (owner: 10DannyS712) [09:43:05] (03CR) 10Daimona Eaytoy: [C: 04-1] Remove uses of global $wgUser (031 comment) [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/561129 (https://phabricator.wikimedia.org/T241576) (owner: 10DannyS712) [09:44:50] (03PS1) 10Daimona Eaytoy: Try to avoid RequestContext::getMain() [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/561269 [09:45:53] (03CR) 10jerkins-bot: [V: 04-1] Try to avoid RequestContext::getMain() [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/561269 (owner: 10Daimona Eaytoy) [10:00:04] (03PS2) 10Daimona Eaytoy: Try to avoid RequestContext::getMain() [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/561269 [10:00:59] (03CR) 10jerkins-bot: [V: 04-1] Try to avoid RequestContext::getMain() [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/561269 (owner: 10Daimona Eaytoy) [10:01:48] (03CR) 10Daimona Eaytoy: ">" (031 comment) [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/561245 (https://phabricator.wikimedia.org/T241621) (owner: 10DannyS712) [10:03:34] (03PS1) 10Daimona Eaytoy: Fixup phan and taint-check warnings [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/561270 [10:04:01] 10MediaWiki-General, 10DBA, 10Operations, 10Patch-For-Review: Evaluate and decide the future of relational datastore at WMF after the upgrade of MariaDB 10.1 is finished - https://phabricator.wikimedia.org/T193224 (10Marostegui) I have upgraded db1107 from 10.4.10 to the latest version: 10.4.11 [10:06:38] (03CR) 10jerkins-bot: [V: 04-1] Fixup phan and taint-check warnings [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/561270 (owner: 10Daimona Eaytoy) [10:09:39] (03PS2) 10Daimona Eaytoy: Fixup phan and taint-check warnings [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/561270 [10:12:30] (03CR) 10Daimona Eaytoy: [C: 03+2] "> I suspect this may be serious enough for an immediate 2.4.7 release." [tools/phan] - 10https://gerrit.wikimedia.org/r/561093 (owner: 10Umherirrender) [10:13:26] (03PS1) 10Daimona Eaytoy: Upgrade phan to 2.4.7 [tools/phan] - 10https://gerrit.wikimedia.org/r/561272 [10:13:41] (03PS2) 10Daimona Eaytoy: Upgrade phan to 2.4.7 [tools/phan] - 10https://gerrit.wikimedia.org/r/561272 [10:14:01] (03CR) 10jerkins-bot: [V: 04-1] Upgrade phan to 2.4.7 [tools/phan] - 10https://gerrit.wikimedia.org/r/561272 (owner: 10Daimona Eaytoy) [10:25:33] (03CR) 10Florianschmidtwelzow: [C: 03+2] Pass empty array to addToRecipient [extensions/Mailgun] - 10https://gerrit.wikimedia.org/r/561244 (https://phabricator.wikimedia.org/T230739) (owner: 10BrandonXLF) [10:28:45] (03Merged) 10jenkins-bot: Pass empty array to addToRecipient [extensions/Mailgun] - 10https://gerrit.wikimedia.org/r/561244 (https://phabricator.wikimedia.org/T230739) (owner: 10BrandonXLF) [10:30:27] (03CR) 10Daimona Eaytoy: [C: 04-1] Remove uses of global $wgUser and reduce use of global $wgOut (031 comment) [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/561252 (https://phabricator.wikimedia.org/T241629) (owner: 10DannyS712) [10:35:35] 10Scribe: Add Cite template to VE text content - https://phabricator.wikimedia.org/T241643 (10Eugene233) [10:36:24] (03CR) 10Daimona Eaytoy: [C: 03+2] "Unfortunately, there seems to be no better way here." [extensions/AnonPrivacy] - 10https://gerrit.wikimedia.org/r/561246 (https://phabricator.wikimedia.org/T241622) (owner: 10DannyS712) [10:38:30] (03CR) 10Daimona Eaytoy: [C: 04-1] "I may seem OCD, but I suggest moving whitespace-related changes to another patch. This kind of "spacey" commits tend to create a lot of co" [extensions/Survey] - 10https://gerrit.wikimedia.org/r/561243 (https://phabricator.wikimedia.org/T241620) (owner: 10DannyS712) [10:39:28] (03Merged) 10jenkins-bot: Remove uses of global $wgUser [extensions/AnonPrivacy] - 10https://gerrit.wikimedia.org/r/561246 (https://phabricator.wikimedia.org/T241622) (owner: 10DannyS712) [10:42:52] (03CR) 10Daimona Eaytoy: [C: 04-1] Remove uses of global $wgUser (037 comments) [extensions/Collection] - 10https://gerrit.wikimedia.org/r/561238 (https://phabricator.wikimedia.org/T241616) (owner: 10DannyS712) [10:46:27] 10MediaWiki-General, 10MediaWiki-Installer, 10MediaWiki-Internationalization: I am getting ContainerDisabledException in ServiceContainer - https://phabricator.wikimedia.org/T241638 (10mkysoft) [11:00:16] 10MediaWiki-Installer, 10MediaWiki-Internationalization: I am getting ContainerDisabledException in ServiceContainer - https://phabricator.wikimedia.org/T241638 (10Aklapper) @mkysoft: Can you please provide a complete list of all steps to reproduce the problem? [11:01:29] 10ShoutWiki: Attempt to create Shoutwiki wiki results in LoadBalancer error: Got connection to 'btech_wiki', but expected local domain ('shoutwiki') - https://phabricator.wikimedia.org/T241623 (10Aklapper) [11:05:45] (03CR) 10Daimona Eaytoy: [C: 04-1] Remove uses of global $wgUser (035 comments) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/561233 (https://phabricator.wikimedia.org/T241608) (owner: 10DannyS712) [11:13:50] 10MediaWiki-extensions-Mailgun: Mailgun extension should allow use of other alternate mailgun api endpoints - https://phabricator.wikimedia.org/T236396 (1001tonythomas) We might be able to make this a #google-code-in-2019 task as well. Probably once we upgrade the composer library, $mailgunAPIEndpoint as a para... [11:14:27] (03CR) 10Daimona Eaytoy: [V: 03+2 C: 03+2] "This is one of those extensions that should just die. It was created in 2008, but it receives no updates since at least 2013. Just to give" [extensions/LogEntry] - 10https://gerrit.wikimedia.org/r/561228 (https://phabricator.wikimedia.org/T241611) (owner: 10DannyS712) [11:25:58] (03CR) 10Daimona Eaytoy: [C: 04-1] Remove uses of global $wgUser (031 comment) [extensions/AbsenteeLandlord] - 10https://gerrit.wikimedia.org/r/561220 (https://phabricator.wikimedia.org/T241613) (owner: 10DannyS712) [11:28:04] 10Magnus Sälgö: Create Wiki Template Europeana on Swedish Wikipedia using the Europeana Entity property in Wikidata - https://phabricator.wikimedia.org/T241552 (10Salgo60) [11:31:36] 10Magnus Sälgö: Create Wiki Template Europeana on Swedish Wikipedia using the Europeana Entity property in Wikidata - https://phabricator.wikimedia.org/T241552 (10Salgo60) [11:47:46] (03CR) 10Umherirrender: [C: 03+2] Fixup phan and taint-check warnings [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/561270 (owner: 10Daimona Eaytoy) [11:47:56] (03PS2) 10Umherirrender: Move test-only classes to new TestAutoloadClasses declaration [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/561188 (https://phabricator.wikimedia.org/T196090) [11:51:02] (03Merged) 10jenkins-bot: Fixup phan and taint-check warnings [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/561270 (owner: 10Daimona Eaytoy) [11:51:38] 10MediaWiki-Installer, 10MediaWiki-Internationalization: I am getting ContainerDisabledException in ServiceContainer - https://phabricator.wikimedia.org/T241638 (10mkysoft) [11:53:07] 10MediaWiki-Installer, 10MediaWiki-Internationalization: I am getting ContainerDisabledException in ServiceContainer - https://phabricator.wikimedia.org/T241638 (10mkysoft) Hi @Aklapper , I found the problem. Turkish language fail on installation. I chose English and it is completed. Thanks for support. [12:00:59] 10MediaWiki-Email: Special:EmailUser just delivery text of mail, nothing another - https://phabricator.wikimedia.org/T241633 (10Umherirrender) There is a text at the end of the mail (msg emailuserfooter) ` -- This email was sent by $1 to $2 by the "Email this user" function at {{SITENAME}}. If you reply to thi... [12:07:02] 10MediaWiki-extensions-Mailgun: MW-Vagrant role for Mailgun extension - https://phabricator.wikimedia.org/T185907 (1001tonythomas) a:0301tonythomas I'm going to fix it myself, probably making it easier for GCI students to start contributing to the extensions easily. [12:15:26] 10MediaWiki-Email: Special:EmailUser just delivery text of mail, nothing another - https://phabricator.wikimedia.org/T241633 (10Zoranzoki21) 05Open→03Invalid Ah yes, it is right. I forgot about it. Closing task so. [12:27:34] 10MediaWiki-Installer, 10MediaWiki-Internationalization: I am getting ContainerDisabledException in ServiceContainer - https://phabricator.wikimedia.org/T241638 (10Aklapper) Hi, could you explain what "failed" means exactly, and which steps you performed? Wondering if some checks or error messages could be imp... [12:27:49] 10MediaWiki-Installer, 10MediaWiki-Internationalization: ContainerDisabledException in ServiceContainer due to failed language installation - https://phabricator.wikimedia.org/T241638 (10Aklapper) [12:29:14] 10MediaWiki-extensions-Mailgun: Bump up Mailgun library to v2.4.0 - https://phabricator.wikimedia.org/T241645 (1001tonythomas) [12:29:42] 10Developer-Advocacy (Jul-Sep 2019): User Scripts and Gadgets Workshop @Wikimania Hackathon 2019 - https://phabricator.wikimedia.org/T228234 (10Aklapper) [12:29:45] 10Developer-Advocacy (Jul-Sep 2019): Wikimania Hackathon Focus Area: Small Wiki Toolkits - https://phabricator.wikimedia.org/T221394 (10Aklapper) [12:30:05] 10MediaWiki-Installer, 10MediaWiki-Internationalization: ContainerDisabledException in ServiceContainer due to failed language installation - https://phabricator.wikimedia.org/T241638 (10mkysoft) [12:33:29] (03CR) 10Daimona Eaytoy: [C: 04-1] Remove uses of global $wgUser (031 comment) [extensions/AbsenteeLandlord] - 10https://gerrit.wikimedia.org/r/561220 (https://phabricator.wikimedia.org/T241613) (owner: 10DannyS712) [12:34:13] 10MediaWiki-Installer, 10MediaWiki-Internationalization: ContainerDisabledException in ServiceContainer due to failed installation with different language then English - https://phabricator.wikimedia.org/T241638 (10mkysoft) [12:34:29] 10MediaWiki-Installer, 10MediaWiki-Internationalization: ContainerDisabledException in ServiceContainer due to failed installation with different language then English - https://phabricator.wikimedia.org/T241638 (10mkysoft) I detailed steps. [12:39:51] 10MediaWiki-Installer, 10MediaWiki-Internationalization, 10MediaWiki-ServiceContainer: ContainerDisabledException in ServiceContainer due to failed installation with different language then English - https://phabricator.wikimedia.org/T241638 (10jcrespo) [12:40:04] (03PS1) 10Fomafix: Forbid wfDeprecated with $version = true [core] - 10https://gerrit.wikimedia.org/r/561284 [12:41:31] (03CR) 10Daimona Eaytoy: [C: 04-1] Remove uses of global $wgUser (033 comments) [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/561253 (https://phabricator.wikimedia.org/T241630) (owner: 10DannyS712) [12:43:13] 10MediaWiki-Installer, 10MediaWiki-Internationalization, 10MediaWiki-ServiceContainer: ContainerDisabledException in ServiceContainer due to failed installation with different language then English - https://phabricator.wikimedia.org/T241638 (10jcrespo) My guess is there may be a dependency cycle in which th... [12:48:07] (03CR) 10Daimona Eaytoy: [C: 04-1] "> Tests failing do not appear to be caused by this change - hooks" (032 comments) [extensions/Athena] - 10https://gerrit.wikimedia.org/r/561248 (https://phabricator.wikimedia.org/T241625) (owner: 10DannyS712) [12:50:22] (03CR) 10Daimona Eaytoy: [C: 04-1] Remove uses of global $wgUser and some uses of $wgOut and $wgRequest (031 comment) [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/561251 (https://phabricator.wikimedia.org/T241628) (owner: 10DannyS712) [12:53:10] (03CR) 10Daimona Eaytoy: [C: 04-1] "The part where $wgUser is written to should be moved to another commit because it cannot be merged for now." (032 comments) [extensions/AzharAuth] - 10https://gerrit.wikimedia.org/r/561249 (https://phabricator.wikimedia.org/T241626) (owner: 10DannyS712) [12:55:59] (03PS1) 10TheDJ: Break words in
 and .mw-code when overflowing [core] - 10https://gerrit.wikimedia.org/r/561285 (https://phabricator.wikimedia.org/T237190)
[12:55:59] 	 (03CR) 10Fomafix: [C: 04-1] Forbid wfDeprecated with $version = true (031 comment) [core] - 10https://gerrit.wikimedia.org/r/561284 (owner: 10Fomafix)
[12:56:32] 	 10MediaWiki-Page-editing, 10SyntaxHighlight, 10Patch-For-Review, 10User-TheDJ: style="overflow:auto" should be applied directly to the  - https://phabricator.wikimedia.org/T237190 (10TheDJ) a:03TheDJ
[12:56:33] 	 (03PS2) 10Fomafix: Forbid wfDeprecated with $version = true [core] - 10https://gerrit.wikimedia.org/r/561284
[12:56:35] 	 (03CR) 10Fomafix: [C: 04-1] Forbid wfDeprecated with $version = true (031 comment) [core] - 10https://gerrit.wikimedia.org/r/561284 (owner: 10Fomafix)
[12:57:15] 	 (03CR) 10Daimona Eaytoy: [C: 04-1] Remove uses of global $wgUser (032 comments) [extensions/MarkAsHelpful] - 10https://gerrit.wikimedia.org/r/561247 (https://phabricator.wikimedia.org/T241624) (owner: 10DannyS712)
[13:04:09] 	 10MediaWiki-Installer, 10MediaWiki-Internationalization, 10MediaWiki-ServiceContainer: ContainerDisabledException in ServiceContainer due to failed installation with different language then English - https://phabricator.wikimedia.org/T241638 (10jcrespo) I was able to reproduce it quite consistently with the...
[13:04:34] 	 10Developer-Advocacy: Small Wiki Toolkits: Main page customization (adaptive/responsive CSS basics; Template basics?) - https://phabricator.wikimedia.org/T241646 (10Aklapper)
[13:09:56] 	 (03CR) 10jerkins-bot: [V: 04-1] Break words in 
 and .mw-code when overflowing [core] - 10https://gerrit.wikimedia.org/r/561285 (https://phabricator.wikimedia.org/T237190) (owner: 10TheDJ)
[13:11:04] 	 (03CR) 10Daimona Eaytoy: [C: 04-1] "> Issue: [...] not caused by this patch" (0315 comments) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/561242 (https://phabricator.wikimedia.org/T241619) (owner: 10DannyS712)
[13:16:23] 	 10MediaWiki-Installer, 10MediaWiki-Parser: PLURAL magicword not parsed during installation: "Password must be at least {{PLURAL:10|1 character|10 characters}}" - https://phabricator.wikimedia.org/T238464 (10jcrespo) I was able to reproduce this on 1.34. I wonder if the root cause is similar to T241638, transla...
[13:27:36] 	 (03CR) 10Majavah: "@DannyS712, @Florianschmidtwelzow: I am not sure if that's possible. Git doesn't realize that these two files are related as there are so " (031 comment) [core] - 10https://gerrit.wikimedia.org/r/556007 (https://phabricator.wikimedia.org/T233244) (owner: 10Majavah)
[13:30:38] 	 04(no projects): SVG rendering incorrectly - https://phabricator.wikimedia.org/T241600 (10Aklapper) 05Stalled→03Invalid @Ian_Furst: Thanks a lot for the explanation! I guess that means that the SVG rendering is not incorrect (that is what the task summary currently states), but that the PNG thumbnail is inc...
[13:33:08] 	 10Developer-Advocacy: Small Wiki Toolkits: Main page customization (adaptive/responsive CSS basics; Template basics?) - https://phabricator.wikimedia.org/T241646 (10Aklapper)
[13:35:55] 	 (03PS5) 10Majavah: Disallow renaming own accounts with Special:GlobalRenameQueue [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/549586 (https://phabricator.wikimedia.org/T111789)
[13:36:26] 	 (03CR) 10Majavah: "See patch set 5" (032 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/549586 (https://phabricator.wikimedia.org/T111789) (owner: 10Majavah)
[13:38:04] 	 (03PS4) 10Octfx: Change method of setting and retrieving page props [extensions/WikiSEO] - 10https://gerrit.wikimedia.org/r/560414
[13:40:32] 	 Urbanecm: where has the "make wikimedia configuration change" task gone on GCI dashboard? I can't find it
[13:40:55] 	 (03CR) 10jerkins-bot: [V: 04-1] Change method of setting and retrieving page props [extensions/WikiSEO] - 10https://gerrit.wikimedia.org/r/560414 (owner: 10Octfx)
[13:41:00] 	 10MediaWiki-extensions-Gadgets, 10I18n, 10Patch-For-Review, 10User-DannyS712: `gadgets-prefstext` needs to be updated regarding interface administrators - https://phabricator.wikimedia.org/T241634 (10Aklapper)
[13:41:34] 	 tassu: you already did it, right? It's one-claim task. 
[13:42:02] 	 Urbanecm: you can't do that multiple times? :/
[13:46:06] 	 No, one task can be done only one time. Sometimes, it's bypassed by creating multiple tasks about the same thing, but iirc it's not the case with config change task. It might be done later in gci, if there will be still missing config things ;)
[13:46:16] * Urbanecm brb
[13:47:48] 	 10Wikimedia-maintenance-script-run: Special:BrokenRedirects shows displays an incorrect state on srwiki - https://phabricator.wikimedia.org/T241648 (10Zoranzoki21)
[13:49:17] 	 Not the case currently, but we could duplicate it
[13:51:51] 	 10MediaWiki-extensions-CentralAuth, 10Google-Code-in-2019, 10User-Majavah: Convert CentralAuth extension.json to manifest_version 2 - https://phabricator.wikimedia.org/T241199 (10Majavah) a:03Majavah
[13:53:17] 	 (03PS1) 10Majavah: Convert CentralAuth extension.json to manifest_version 2 [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/561287 (https://phabricator.wikimedia.org/T241199)
[14:07:16] 	 (03PS5) 10Octfx: Change method of setting and retrieving page props [extensions/WikiSEO] - 10https://gerrit.wikimedia.org/r/560414
[14:08:32] 	 10Wikimedia-Site-requests, 10Wikimedia-maintenance-script-run: Special:BrokenRedirects shows displays an incorrect state on srwiki - https://phabricator.wikimedia.org/T241648 (10jcrespo)
[14:09:21] 	 10Wikimedia-Site-requests, 10Serbian-Sites, 10Wikimedia-maintenance-script-run: Special:BrokenRedirects shows displays an incorrect state on srwiki - https://phabricator.wikimedia.org/T241648 (10jcrespo)
[14:10:53] 	 (03CR) 10Octfx: "check php" [extensions/WikiSEO] - 10https://gerrit.wikimedia.org/r/560414 (owner: 10Octfx)
[14:12:36] 	 04(no projects): SVG rendering incorrectly - https://phabricator.wikimedia.org/T241600 (10Ian_Furst) made the changes suggested and all fixed.  I'm guessing that the way svg is rendered in different programs is slightly different - e.g. looked good in chrome but the png converter was slightly different.   Thank...
[14:17:10] 	 (03PS1) 10D3r1ck01: Objects are accessed via references by default, no need to use `&` [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/561288
[14:30:14] 	 (03PS2) 10TheDJ: Break words in 
 and .mw-code when overflowing [core] - 10https://gerrit.wikimedia.org/r/561285 (https://phabricator.wikimedia.org/T237190)
[14:30:33] 	 IAmNetx: you around?
[14:31:28] 	 (03PS2) 10Daimona Eaytoy: [DNM] Jenkins test [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/557221
[14:34:29] 	 (03CR) 10jerkins-bot: [V: 04-1] [DNM] Jenkins test [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/557221 (owner: 10Daimona Eaytoy)
[14:34:37] 	 10MediaWiki-extensions-General, 10Google-Code-in-2019, 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), and 2 others: Update extension.json files to manifest_version 2 to use description instead of @globalname documentation - https://phabricator.wikimedia.org/T234114...
[14:35:38] 	 (03CR) 10D3r1ck01: "This change is ready for review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/561288 (owner: 10D3r1ck01)
[14:37:55] 	 (03CR) 10D3r1ck01: [C: 03+1] "lgtm!" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/561200 (https://phabricator.wikimedia.org/T196090) (owner: 10Umherirrender)
[14:43:07] 	 (03PS1) 10D3r1ck01: specials: Avoid use of deprecated `Language::fetchLanguageNames()` [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/561290
[14:44:36] 	 (03PS2) 10D3r1ck01: specials: Avoid use of deprecated `Language::fetchLanguageNames()` [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/561290
[14:46:06] 	 (03CR) 10D3r1ck01: [C: 03+1] "lgtm!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/556811 (https://phabricator.wikimedia.org/T240622) (owner: 10Jdlrobson)
[15:00:56] 	 (03PS1) 10Daimona Eaytoy: Bump psr/log [oauthclient-php] - 10https://gerrit.wikimedia.org/r/561291 (https://phabricator.wikimedia.org/T240753)
[15:01:58] 	 10MediaWiki-extensions-OAuthAuthentication, 10Patch-For-Review: OAuthAuthentication build failing due conflicting composer dependencies - https://phabricator.wikimedia.org/T240753 (10Daimona) Hah, the requirement in oauthclient was already bumped. So we only need to make a new release and start using it.
[15:08:07] 	 (03CR) 10D3r1ck01: "This change is ready for review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/561290 (owner: 10D3r1ck01)
[15:11:37] 	 (03Abandoned) 10Daimona Eaytoy: Bump psr/log [oauthclient-php] - 10https://gerrit.wikimedia.org/r/561291 (https://phabricator.wikimedia.org/T240753) (owner: 10Daimona Eaytoy)
[15:17:17] 	 (03PS1) 10Daimona Eaytoy: Bump oauthclient to 1.0.* [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/561292 (https://phabricator.wikimedia.org/T240753)
[15:17:19] 	 (03PS2) 10Daimona Eaytoy: Bump oauthclient to 1.0.* [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/561292 (https://phabricator.wikimedia.org/T240753)
[15:20:40] 	 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): encode search key when opening preview - https://phabricator.wikimedia.org/T240952 (10hueitan) similar here if you seach for the key  {F31495642}
[15:21:25] 	 Urbanecm: Hi!
[15:21:37] 	 Hi alcarazzam!
[15:21:54] 	 I've claimed this task (https://codein.withgoogle.com/dashboard/task-instances/5191108108222464/)
[15:21:56] 	 (03PS3) 10Daimona Eaytoy: Bump oauthclient to 1.0.* [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/561292 (https://phabricator.wikimedia.org/T240753)
[15:22:18] 	 Can you tell me where the Tracker make requests?
[15:22:23] 	 (03Abandoned) 10Daimona Eaytoy: [DNM] Jenkins test [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/557221 (owner: 10Daimona Eaytoy)
[15:24:15] 	 (03CR) 10Daimona Eaytoy: [C: 04-1] "I'd suggest splitting this patch in two. I242ca81a126cd3e051685ae7423b4afe3876262f fixes the CI issue, you can rebase this patch on top of" (031 comment) [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/561225 (https://phabricator.wikimedia.org/T241612) (owner: 10DannyS712)
[15:24:39] 	 alcarazzam: Sure, but...it seems it's already solved :D
[15:24:58] 	 Ohhh
[15:25:07] 	 What can I do?
[15:25:31] 	 alcarazzam: Abandon the task and I'll delete it
[15:25:53] 	 Well, it's fine
[15:26:06] 	 Don't think you can delete it, just unpublish
[15:27:29] 	 Urbanecm: Abandoned. Also marked as Resolved in Phabricator
[15:28:08] 	 Ebe123: you're right, I've set task instance count to 0
[15:28:48] 	 Tracker interfaces with Wikimedia (other than in OAuth?)
[15:28:50] 	 ?
[15:29:14] 	 Or was the user-agent for OAuth?
[15:29:56] 	 Ebe123: it has lightweight API client for making edits
[15:30:30] 	 It marks photos attached to tickets as "Photographed with WMCZ's support" on Commons
[15:31:55] 	 Oh
[15:32:02] 	 Cool!
[15:34:34] 	 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): encode search key when opening preview - https://phabricator.wikimedia.org/T240952 (10hueitan) yet another cases when the title has `:`  go to `http://localhost:8080/#/article/en/Cat/External%20links`, then click on the `cat` and `Cat` on first page.
[15:38:22] 	 (03CR) 10Daimona Eaytoy: "I've seen various places where the fallback could be avoided, or a User parameter injected. I don't know how this extension is used, but w" [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/561150 (https://phabricator.wikimedia.org/T241631) (owner: 10Jack Phoenix)
[15:39:43] 	 10Developer-Advocacy (Oct-Dec 2019), 10Google-Code-in-2019: Google Code-In 2019 Design Wikimedia Friends of the Docs Appreciation Stickers - https://phabricator.wikimedia.org/T239641 (10Path_slopu1234) Hi greetings, I would like to submit my creation here. Thank you.   {F31495652}
[15:42:23] 	 (03PS6) 10Daimona Eaytoy: Evaluate left-to-right when adding elements to array [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/547724 (https://phabricator.wikimedia.org/T237090)
[15:44:31] 	 (03PS6) 10Daimona Eaytoy: Handle DUNDEFINED in array offsets [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/548315 (https://phabricator.wikimedia.org/T237214)
[15:45:05] 	 (03PS35) 10Daimona Eaytoy: Start using new format for var dumps [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482500 (https://phabricator.wikimedia.org/T213006)
[15:45:13] 	 (03PS64) 10Daimona Eaytoy: Add a maintenance script to clean afl_var_dump [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482499 (https://phabricator.wikimedia.org/T213006)
[15:45:34] 	 (03PS3) 10Daimona Eaytoy: Add updateVarDumps to update.php [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/551603 (https://phabricator.wikimedia.org/T213006)
[15:45:43] 	 (03CR) 10Daimona Eaytoy: [C: 04-2] "Per commit msg" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/551603 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy)
[15:45:44] 	 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): sections menu doesn't take into account section I'm currently reading - https://phabricator.wikimedia.org/T240992 (10Jpita) yes, I checked your branch now and it is ok. we need to discuss with @SBisson the right flow for us: Dev->CR->Merge PR->QA in master OR Dev->...
[15:49:18] 	 (03PS34) 10Daimona Eaytoy: Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006)
[15:49:58] 	 (03PS4) 10Daimona Eaytoy: Simplify User handling in AFComputedVariable [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539702
[15:50:03] 	 (03PS4) 10Daimona Eaytoy: Simplify page handling in AFComputedVariable [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539709
[15:50:28] 	 (03PS7) 10Daimona Eaytoy: Kill the last use of wgUser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/538706 (https://phabricator.wikimedia.org/T159299)
[15:52:35] 	 (03PS11) 10Daimona Eaytoy: Allow parsers to return extra info [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536773
[15:53:01] 	 (03PS10) 10Daimona Eaytoy: Group slow filters by warm/cold cache [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/537499 (https://phabricator.wikimedia.org/T231112)
[15:56:25] 	 (03PS43) 10Daimona Eaytoy: [WIP] Factor out variables-related methods [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/519064
[15:59:36] 	 (03CR) 10jerkins-bot: [V: 04-1] Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy)
[16:01:46] 	 (03CR) 10jerkins-bot: [V: 04-1] Simplify page handling in AFComputedVariable [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539709 (owner: 10Daimona Eaytoy)
[16:02:22] 	 (03CR) 10jerkins-bot: [V: 04-1] Kill the last use of wgUser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/538706 (https://phabricator.wikimedia.org/T159299) (owner: 10Daimona Eaytoy)
[16:02:47] 	 10SyntaxHighlight, 10Technical-Debt: Decide the fate of  - https://phabricator.wikimedia.org/T237267 (10Dinoguy1000) >>! In T237267#5768201, @DannyS712 wrote: > could we add a tracking category when it is used, for now, so that its easier to see the extent of changes needed on-wiki?  I'd be fine with t...
[16:03:34] 	 (03CR) 10jerkins-bot: [V: 04-1] Simplify User handling in AFComputedVariable [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539702 (owner: 10Daimona Eaytoy)
[16:05:06] 	 (03PS5) 10Daimona Eaytoy: Factor out a Status subclass [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/519409
[16:06:15] 	 (03PS6) 10Daimona Eaytoy: Factor out a Status subclass [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/519409
[16:06:45] 	 (03PS7) 10Daimona Eaytoy: Factor out a Status subclass [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/519409
[16:07:00] 	 Urbanecm: hey, you around?
[16:13:25] 	 10SyntaxHighlight, 10Technical-Debt: Decide the fate of  - https://phabricator.wikimedia.org/T237267 (10Izno) This is {T39042}, no?
[16:14:50] 	 10SyntaxHighlight, 10Technical-Debt: Decide the fate of  - https://phabricator.wikimedia.org/T237267 (10Izno) (Mind you, I support deprecation and removal too. There are only [[https://en.wikipedia.org/w/index.php?sort=relevance&search=insource%3Asource+insource%3A%2F%5C%3C+%2Asource%2F&title=Special:S...
[16:24:08] 	 A few hours late, IAmNetx :p
[16:24:41] 	 Ebe123: I currently have a lack of a sleep schedule
[16:25:03] 	 Especially that we're to stay awake at midnight tonight
[16:26:01] 	 Giving students extensions on tasks for New Years
[16:27:32] 	 10Wikimedia-Site-requests, 10Serbian-Sites, 10Wikimedia-maintenance-script-run: Special:BrokenRedirects shows displays an incorrect state on srwiki - https://phabricator.wikimedia.org/T241648 (10Reedy) >The following data is cached, and was last updated 15:59, 31 December 2019.  The list is empty  Is there a...
[16:44:00] 	 IAmNetx: here!
[16:44:17] 	 Urbanecm: hey!
[16:46:35] 	 Urbanecm: assuming you read my comment last night then
[16:46:40] 	 IAmNetx: What about using a GET parameter, or even another URL path, but maybe we can use same template&form, to avoid code duplications?
[16:46:43] 	 IAmNetx: yeah, I did
[16:49:03] 	 Urbanecm: the thing that's causing me doubts is that the template that I created feels more clean for a signup flow than the already existing details page, I could hide things and add more text depending on whether that parameter is there but to me it feels like at that point you might as well create a new page anyway
[16:50:09] 	 IAmNetx: Okay, convinced :). What do you think about moving the URL under /accounts/register/, to make it clear it is a part of registration process?
[16:50:54] 	 Urbanecm: aye, the current URL was intended as a placeholder anyway since I couldn't think of one, will do that now
[16:51:07] 	 Great!
[16:54:12] 	 hello irc
[16:54:34] 	 hello!
[16:54:45] 	 Hello tobimori 
[16:54:51] 	 are you a GCI student, tobimori ?
[16:55:11] 	 sure ^^
[16:55:18] 	 don't forget to register!
[16:55:24] 	 tobimori: Hi!
[16:56:01] 	 Happy New Year 
[16:56:23] 	 Subscriptshoe9: Thanks
[16:57:07] 	 Subscriptshoe9: is 2020 where you live?
[16:57:20] 	 In still in 2019 :)
[16:57:33] 	 the ISO calender is already in 2020
[16:57:38] 	 2019 for me still
[16:58:10] 	 I’m in UTC+8
[16:59:08] 	 UTC +1
[16:59:24] 	 utc+1 for me too
[17:00:03] * Urbanecm too
[17:00:17] 	 UTC+1 is a fake timezone, we still have 7 more hours!
[17:00:18] 	 -4
[17:01:54] 	 10Developer-Advocacy, 10wikimedia.biterg.io: Sort out a process to add new Github repositories to wikimedia.biterg.io Git indexing - https://phabricator.wikimedia.org/T218528 (10Kaartic) > There is nothing in the JSON output of https://api.github.com/orgs/wikimedia/repos that indicates whether a Github reposit...
[17:03:51] 	 IAmNetx: What do you mean?
[17:05:10] 	 alcarazzam: UTC+0 is the only real time-zone, all other clocks are wrong and inadequate ;)
[17:07:19] 	 UTC-4 is the best one
[17:08:38] 	 UTC+0 just splits a small island in 2
[17:09:14] 	 UTC+8 has most people on the earth (
[17:10:52] 	 Yeah, because the main country that uses it should be split in many TZ
[17:11:27] 	 But what's nice is I know the time there, as 12h difference is easy to remember
[17:14:36] 	 UTC+1 is easier to remember
[17:14:43] 	 If you're in UTC+0 that is
[17:19:21] 	 Well, it's 1:15am for Subscriptshoe9...
[17:23:45] 	 IAmNetx: still here?
[17:23:57] 	 Urbanecm: yup
[17:24:20] 	 IAmNetx: when I loaded mainpage, the warning appeared. That's correct, but the "here" link leads to...the mainpage. 
[17:24:27] 	 See screenshot: https://usercontent.irccloud-cdn.com/file/csyeIvj6/image.png
[17:24:32] 	 (cursor is at "here")
[17:25:11] 	 that is definitely not intended behaviour, will investigate
[17:25:29] 	 thanks
[17:25:37] 	 04(no projects): Need new temporary kerberos password - https://phabricator.wikimedia.org/T241651 (10Groceryheist)
[17:32:32] 	 10Anti-Harassment: Allow overriding a range block with a more specific block with different settings - https://phabricator.wikimedia.org/T241652 (10ST47)
[17:35:35] 	 Urbanecm: try now
[17:35:47] 	 Sure
[17:37:48] 	 (03PS5) 10DannyS712: Remove uses of global $wgUser and some uses of $wgOut and $wgRequest [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/561242 (https://phabricator.wikimedia.org/T241619)
[17:38:46] 	 (03CR) 10jerkins-bot: [V: 04-1] Remove uses of global $wgUser and some uses of $wgOut and $wgRequest [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/561242 (https://phabricator.wikimedia.org/T241619) (owner: 10DannyS712)
[17:38:49] 	 (03CR) 10DannyS712: Remove uses of global $wgUser and some uses of $wgOut and $wgRequest (031 comment) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/561242 (https://phabricator.wikimedia.org/T241619) (owner: 10DannyS712)
[17:41:32] 	 IAmNetx: what about reversing the URL in the middleware? If someone wants to change it, they'd need only to change urls.py and it'll be done
[17:42:07] 	 10MediaWiki-extensions-LogEntry, 10Technical-Debt, 10User-DannyS712: LogEntry needs uses of global $wgUser replaced - https://phabricator.wikimedia.org/T241611 (10DannyS712) 05Open→03Resolved
[17:42:08] 	 10MediaWiki-User-management, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Patch-For-Review, 10Technical-Debt (Deprecation process), 10User-DannyS712: Deprecate $wgUser - https://phabricator.wikimedia.org/T159299 (10DannyS712)
[17:42:36] 	 Urbanecm: I was going to do that but I must've forgotten - will do
[17:42:46] 	 (y)
[17:44:05] 	 (03PS3) 10DannyS712: Remove uses of global $wgUser and reduce use of global $wgOut [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/561252 (https://phabricator.wikimedia.org/T241629)
[17:45:57] 	 (03PS4) 10DannyS712: Remove uses of global $wgUser and some uses of $wgOut and $wgRequest [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/561251 (https://phabricator.wikimedia.org/T241628)
[17:46:53] 	 10MediaWiki-extensions-Other, 10Technical-Debt, 10User-DannyS712: AnonPrivacy needs uses of global $wgUser removed - https://phabricator.wikimedia.org/T241622 (10DannyS712) 05Open→03Resolved
[17:46:57] 	 10MediaWiki-User-management, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Patch-For-Review, 10Technical-Debt (Deprecation process), 10User-DannyS712: Deprecate $wgUser - https://phabricator.wikimedia.org/T159299 (10DannyS712)
[17:47:39] 	 Urbanecm: done!
[17:47:56] 	 looking IAmNetx 
[17:49:55] 	 Urbanecm: Can you approve my task when you finish with IAmNetx?
[17:50:10] 	 10MediaWiki-Installer, 10MediaWiki-Internationalization: PLURAL magicword not parsed during installation: "Password must be at least {{PLURAL:10|1 character|10 characters}}" - https://phabricator.wikimedia.org/T238464 (10Reedy)
[17:51:59] 	 IAmNetx: when I register with OAuth, I'm redirected directly to main page. Could I be directed to the details page instead?
[17:52:12] 	 alcarazzam: I can have a look, could you link the instance, please?
[17:52:51] 	 (03CR) 10Daimona Eaytoy: [C: 03+2] Remove uses of global $wgUser and reduce use of global $wgOut [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/561252 (https://phabricator.wikimedia.org/T241629) (owner: 10DannyS712)
[17:53:21] 	 (03Merged) 10jenkins-bot: Remove uses of global $wgUser and reduce use of global $wgOut [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/561252 (https://phabricator.wikimedia.org/T241629) (owner: 10DannyS712)
[17:53:58] 	 (03CR) 10Daimona Eaytoy: [C: 04-1] Remove uses of global $wgUser and some uses of $wgOut and $wgRequest (031 comment) [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/561251 (https://phabricator.wikimedia.org/T241628) (owner: 10DannyS712)
[17:55:35] 	 10MediaWiki-extensions-Other, 10Technical-Debt, 10User-DannyS712: TwitterLogin needs uses of global $wgUser removed - https://phabricator.wikimedia.org/T241629 (10DannyS712) 05Open→03Resolved
[17:55:40] 	 10MediaWiki-User-management, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Patch-For-Review, 10Technical-Debt (Deprecation process), 10User-DannyS712: Deprecate $wgUser - https://phabricator.wikimedia.org/T159299 (10DannyS712)
[17:56:12] 	 (03PS5) 10DannyS712: Remove uses of global $wgUser and some uses of $wgOut and $wgRequest [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/561251 (https://phabricator.wikimedia.org/T241628)
[17:57:06] 	 (03CR) 10Daimona Eaytoy: [C: 04-1] "Restoring -1 per previous comment; if you send a patch for fixing phan, please add me as reviewer. Otherwise I'll push one tomorrowish." (031 comment) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/561242 (https://phabricator.wikimedia.org/T241619) (owner: 10DannyS712)
[17:57:42] 	 Urbanecm: uh, is there an oauth key/secret for testing tracker with mediawiki?
[17:57:50] 	 10MediaWiki-Installer, 10MediaWiki-Internationalization: PLURAL magicword not parsed during installation: "Password must be at least {{PLURAL:10|1 character|10 characters}}" - https://phabricator.wikimedia.org/T238464 (10Reedy) From https://www.mediawiki.org/wiki/Manual:Messages_API#Notes_about_gender,_grammar...
[17:57:52] 	 or will i have to request one
[17:58:03] 	 10MediaWiki-Installer, 10MediaWiki-Internationalization, 10MediaWiki-ServiceContainer: ContainerDisabledException in ServiceContainer due to failed installation with different language then English - https://phabricator.wikimedia.org/T241638 (10Reedy) >>! In T241638#5768475, @jcrespo wrote: > My guess is the...
[17:58:39] 	 IAmNetx: see PM
[17:58:50] 	 Urbanecm: ty
[17:58:51] 	 10MediaWiki-Installer, 10MediaWiki-Internationalization: PLURAL magicword not parsed during installation: "Password must be at least {{PLURAL:10|1 character|10 characters}}" - https://phabricator.wikimedia.org/T238464 (10Nullzero) @Reedy I do think it's related to MediaWiki Parser. See T238633 which is a dup o...
[17:59:20] 	 yw
[17:59:57] 	 10MediaWiki-Installer, 10MediaWiki-Internationalization: PLURAL magicword not parsed during installation: "Password must be at least {{PLURAL:10|1 character|10 characters}}" - https://phabricator.wikimedia.org/T238464 (10Reedy) >>! In T238464#5768676, @Nullzero wrote: > @Reedy I do think it's related to MediaW...
[18:00:33] 	 10MediaWiki-Installer: Bad errorbox in MediaWiki installation - https://phabricator.wikimedia.org/T238633 (10Nullzero)
[18:01:34] 	 10MediaWiki-User-management, 10Anti-Harassment: Allow overriding a range block with a more specific block with different settings - https://phabricator.wikimedia.org/T241652 (10Aklapper) Assuming this task is about #mediawiki-user-management code in MediaWiki core, hence adding project tag so others can find t...
[18:03:09] 	 10MediaWiki-Installer, 10MediaWiki-Internationalization: PLURAL magicword not parsed during installation: "Password must be at least {{PLURAL:10|1 character|10 characters}}" - https://phabricator.wikimedia.org/T238464 (10Nullzero) Gotcha. Yes, I agree with your diagnosis.
[18:03:51] 	 (03CR) 10Ammarpad: [C: 03+1] "Looks good to me" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/561287 (https://phabricator.wikimedia.org/T241199) (owner: 10Majavah)
[18:06:03] 	 alcarazzam: Great work, merged.
[18:06:16] 	 Urbanecm: done, unfortunately cannot use reverse() in common_settings otherwise it complains **a lot**
[18:06:59] 	 IAmNetx: looking
[18:07:35] 	 IAmNetx: just out of curiosity, what does complain a lot mean?
[18:09:10] 	 Urbanecm: it complains that SECRET_KEY is not set for some reason
[18:09:26] 	 IAmNetx: that's...interesting
[18:12:54] 	 IAmNetx: could you add tests to CreateUserTest , to assert signup process works as expected? OAuth part is optional, as it's bigger puzzle :-) (solving it would surely be awarded with extra credit :-) )
[18:20:37] 	 IAmNetx: just want to ask if you saw my message 🙂
[18:23:20] 	 (03CR) 10Fomafix: [C: 03+2] LoadBalancer: `and` should just be `an` [core] - 10https://gerrit.wikimedia.org/r/561263 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712)
[18:31:22] 	 (03PS6) 10Daimona Eaytoy: Remove uses of global $wgUser and some uses of $wgOut and $wgRequest [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/561251 (https://phabricator.wikimedia.org/T241628) (owner: 10DannyS712)
[18:31:36] 	 (03CR) 10Daimona Eaytoy: [C: 03+2] "(I've fixed the order, I always get confused without phpcs...)" [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/561251 (https://phabricator.wikimedia.org/T241628) (owner: 10DannyS712)
[18:33:26] 	 (03PS35) 10Daimona Eaytoy: Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006)
[18:33:39] 	 (03PS5) 10Daimona Eaytoy: Simplify User handling in AFComputedVariable [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539702
[18:33:43] 	 (03PS5) 10Daimona Eaytoy: Simplify page handling in AFComputedVariable [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539709
[18:33:49] 	 (03PS8) 10Daimona Eaytoy: Kill the last use of wgUser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/538706 (https://phabricator.wikimedia.org/T159299)
[18:37:08] 	 (03Merged) 10jenkins-bot: LoadBalancer: `and` should just be `an` [core] - 10https://gerrit.wikimedia.org/r/561263 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712)
[18:37:10] 	 (03Merged) 10jenkins-bot: Remove uses of global $wgUser and some uses of $wgOut and $wgRequest [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/561251 (https://phabricator.wikimedia.org/T241628) (owner: 10DannyS712)
[18:38:07] 	 Urbanecm: Thanks, I was having shower and I could not reply
[18:38:15] 	 Urbanecm: yeah I saw it, just having to entertain my brother rn
[18:38:17] 	 alcarazzam: no problem!
[18:38:40] 	 IAmNetx: cute! I've sent the task back to hide it from my dashboard :-). Let me know if I can help. 
[18:39:15] * Ebe123 laughs
[18:39:32] 	 Hello all
[18:39:44] 	 RishabhL: Hi!
[18:39:45] 	 Hi RishabhL!
[18:40:01] 	 Hi RishabhL 
[18:41:09] 	 10MediaWiki-extensions-Duplicator, 10Technical-Debt, 10User-DannyS712: Duplicator needs uses of global $wgUser removed - https://phabricator.wikimedia.org/T241628 (10DannyS712) 05Open→03Resolved
[18:41:14] 	 10MediaWiki-User-management, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Patch-For-Review, 10Technical-Debt (Deprecation process), 10User-DannyS712: Deprecate $wgUser - https://phabricator.wikimedia.org/T159299 (10DannyS712)
[18:41:14] 	 RishabhL: Are you a GCI student?
[18:45:20] 	 Yes
[18:45:39] 	 Are you doing the IRC task?
[18:45:51] 	 Yep, and have been for far too many days
[18:47:03] 	 Maybe you need to switch to another irc client, if I remember correctly, web clients are not allowed to complete that task
[18:47:19] 	 Urbanecm: Is the django.pot in patchset 4 fine, I saw that there were no differences between it and patchset 3, so maybe I made a mistake whilst committing as I did regenerate the file. https://gerrit.wikimedia.org/r/#/c/wikimedia-cz/tracker/+/560864/ 
[18:47:55] 	 alcarazzam: Sorry, I am  not doing that task, didn't read your message correctly.
[18:48:07] 	 No problem :)
[18:49:18] 	 (03CR) 10Fomafix: [C: 03+1] "PS9 is like PS1/PS2." [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/421349 (https://phabricator.wikimedia.org/T177509) (owner: 10Niharika29)
[18:50:55] 	 (03CR) 10Daimona Eaytoy: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/559985 (owner: 10Libraryupgrader)
[18:54:02] 	 RishabhL, the difference between both patchsets seem to be rebasing, not regeneration
[18:55:07] 	 Happi New Year 2020 from India  
[18:55:08] 	 Ebe123: That's my point, although I regenerated the file using manage.py makemessages, it seems that it didn't get committed.
[18:56:03] 	 Good 2020, Gopa!
[18:56:34] * alcarazzam wishes a Happy New Year to Gopa
[18:57:11] 	  ;)
[18:57:34] 	 RishabhL: I'll have a look
[18:58:29] 	 Did you stage your changes?
[18:59:23] 	 RishabhL: it doesn't seem you regenerated the django.pot file. 
[18:59:43] 	 RishabhL: or you didn't commit the regenerated version
[19:00:02] 	 could you share git status with us, so we can learn the status of your environment?
[19:02:55] 	 Urbanecm: Here is the git status I sent yesterday: https://paste.ee/p/rQBdr
[19:03:36] 	 RishabhL: run manage.py makemessages --keep-pot, run git status and git diff and send output of both commands
[19:07:00] 	 (03CR) 10Skizzerz: Remove uses of global $wgUser (031 comment) [extensions/AbsenteeLandlord] - 10https://gerrit.wikimedia.org/r/561220 (https://phabricator.wikimedia.org/T241613) (owner: 10DannyS712)
[19:09:49] 	 Urbanecm: How I add a link inside a translatable test?
[19:09:52] 	 *text
[19:10:09] 	 alcarazzam: could you elaborate?
[19:10:40] 	 https://www.irccloud.com/pastebin/txi2iBJO/
[19:11:15] 	 Urbanecm: would you like to see git diff of just django.pot?
[19:11:20] 	 Normal HTML code
[19:11:31] 	 RishabhL: whatever the command outputs, please
[19:12:08] 	 alcarazzam: as Ebe123 says
[19:12:10] 	 A link in Django, specify the URL outside the blocktrans, like {% url '...' as some_link %} and call it with {{ some_link }}) in the block
[19:12:26] 	 Ebe123: that's a warning, it's in views.py
[19:12:38] 	 What do you mean?
[19:12:45] 	 it's not in a template
[19:12:48] 	 it's a command in a veiw
[19:12:49] 	 Oh
[19:12:50] 	 *view
[19:13:02] 	 alcarazzam what i see in the paste should be good
[19:13:12] 	 Not works
[19:13:28] 	 https://usercontent.irccloud-cdn.com/file/KEB25ORr/Screenshot_20191231_201317.png
[19:14:16] 	 alcarazzam: ahh... that's because messages clearly aren't recognized as safe and are automatically HTML escaped...
[19:15:12] 	 mark_safe(_(...
[19:15:33] 	 ^^
[19:15:37] 	 or format_html
[19:16:23] 	 mark_safe works
[19:16:28] 	 (y)
[19:16:29] 	 Thanks
[19:17:34] 	 By the way, orrible color contrast
[19:17:50] 	 (of urls in warning)
[19:18:20] 	 alcarazzam: create a task!
[19:18:34] 	 you, no?
[19:18:40] 	 (03CR) 10Daimona Eaytoy: [C: 04-1] Remove uses of global $wgUser (031 comment) [extensions/AbsenteeLandlord] - 10https://gerrit.wikimedia.org/r/561220 (https://phabricator.wikimedia.org/T241613) (owner: 10DannyS712)
[19:18:45] 	 alcarazzam: you can create a task too!
[19:18:46] 	 I can't create tasks :D
[19:18:53] 	 you can!
[19:18:55] 	 why not?
[19:18:55] 	 Urbanecm: You sure that you wan't the output of everything from git diff, as it is going to output all the locale django.po files as well.
[19:19:09] 	 Ahh in Phabricator, no?
[19:19:23] 	 alcarazzam: yeah, in Phabricator :-). For the contrast issue
[19:19:41] 	 RishabhL: yes, I want. You can use script command to record what your terminal outputs
[19:19:43] 	 I think that was in GCi
[19:19:54] 	 No, Phabricator :)
[19:24:14] 	 Urbanecm: I'll do tomorrow
[19:24:26] 	 (y)
[19:27:04] 	 10Developer-Advocacy (Jan-Mar 2020): Intro to Phab video: Write script and publish it - https://phabricator.wikimedia.org/T226062 (10Aklapper)
[19:27:23] 	 10Developer-Advocacy (Jan-Mar 2020), 10Epic, 10Google-Code-in-2019: Organize and coordinate Wikimedia's participation in Google Code-In 2019 - https://phabricator.wikimedia.org/T233899 (10Aklapper)
[19:27:34] 	 10Developer-Advocacy: Intro to Phab video: Play with local Vagrant instance of Phab and with lipsum to generate tasks - https://phabricator.wikimedia.org/T226061 (10Aklapper)
[19:29:35] 	 10Developer-Advocacy (Oct-Dec 2019), 10Documentation: Oct 2019 Technical Engagement Newsletter - https://phabricator.wikimedia.org/T233123 (10Aklapper) @srodlund: Can this be closed as resolved, or is there work left to do here?
[19:30:47] 	 (03PS1) 10Paladox: Fix "Field 'choice_answer_count' doesn't have a default value" [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/561302
[19:31:39] 	 (03PS2) 10Paladox: Fix "Field 'choice_answer_count' doesn't have a default value" [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/561302
[19:32:27] 	 10MediaWiki-General: Provide a tooltip to logged in users to quickly start a discussion based on the highlighted text - https://phabricator.wikimedia.org/T241654 (10dbarratt)
[19:34:47] 	  Urbanecm: Here is both git diff and git status
[19:34:49] 	 https://paste.ee/p/3LdTi
[19:36:21] 	 RishabhL: looking
[19:36:24] 	 (03PS3) 10Paladox: Fix "Field 'choice_answer_count' doesn't have a default value" [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/561302
[19:36:26] 	 (03CR) 10Jforrester: [C: 03+2] Add docblocks to EntityBuilder [extensions/Jade] - 10https://gerrit.wikimedia.org/r/560976 (owner: 10Daimona Eaytoy)
[19:36:27] 	 10MediaWiki-General: Provide a tooltip to logged in users to quickly start a discussion based on the highlighted text - https://phabricator.wikimedia.org/T241654 (10dbarratt)
[19:37:13] 	 (03CR) 10Jforrester: Remove phan exclusions (031 comment) [extensions/Jade] - 10https://gerrit.wikimedia.org/r/560975 (owner: 10Daimona Eaytoy)
[19:37:14] 	 RishabhL: now, open django.pot in a text editor, and using find and replace feature, change \ with / and remove ./. 
[19:40:36] 	 (03Merged) 10jenkins-bot: Add docblocks to EntityBuilder [extensions/Jade] - 10https://gerrit.wikimedia.org/r/560976 (owner: 10Daimona Eaytoy)
[19:41:23] 	 Urbanecm: Done.
[19:41:58] 	 RishabhL: do git add path/to/django.pot (replace path/to/django.pot with the actual path to django.pot), git commit --amend and git review -R
[19:43:32] 	 04(no projects): Commons upload warning is ambiguously worded - https://phabricator.wikimedia.org/T241655 (10RoySmith)
[19:46:30] 	 Urbanecm: https://gerrit.wikimedia.org/r/#/c/wikimedia-cz/tracker/+/560864/, I think the problem last time was that I ran git stash and git clean -f when rebasing and I had probably not done git commit --amend thus the regenerated django.pot file did not get committed.
[19:47:12] 	 10UploadWizard: Commons upload warning is ambiguously worded - https://phabricator.wikimedia.org/T241655 (10Reedy)
[19:47:47] 	 10LibUp: Missing update mediawiki/mediawiki-phan-config to 0.9.0 from libup - https://phabricator.wikimedia.org/T241594 (10Legoktm)
[19:47:52] 	 RishabhL: looks good so far
[19:49:52] 	 (03PS4) 10Paladox: Fix "Field 'choice_answer_count' doesn't have a default value" [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/561302
[19:49:57] 	 ...but there is Yet Another Conflict
[19:51:05] 	 May I know where?
[19:51:29] 	 RishabhL: django.pot was changed again :-). Git simply doesn't know how to merge your patch with the update :-). 
[19:51:35] 	 RishabhL: you need to basically repeat the whole procedure. 
[19:52:01] 	 Shall I rebase as well?
[19:52:58] 	 Also, shall I also manually add Line 15, Langauge: \n
[19:53:05] 	 (03CR) 10Paladox: "Patch tested and works (fixes the issue and allows quiz to be created)" [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/561302 (owner: 10Paladox)
[19:53:18] 	 RishabhL: yeah, just as you did before
[19:53:18] 	 10LibUp: Missing update mediawiki/mediawiki-phan-config to 0.9.0 from libup - https://phabricator.wikimedia.org/T241594 (10Legoktm) The new libup tries to upgrade all possible things at once, and (right now) if one of those fails, it all fails. I unbroke the web UI so you can see the logs yourself and we'll have...
[19:56:45] 	 alcarazzam: still around?
[19:59:04] 	 uhhh... from looking up, we may have a bit of a conflict with features here
[19:59:13] 	 both me and alcarazzam have implemented that warning
[20:00:02] 	 Merge conflicts are always fun :(
[20:00:51] 	 merge conflicts aren't as problematic as two people writing the same thing
[20:00:59] 	 Urbanecm pls advise
[20:01:06] * Urbanecm is writing
[20:01:16] 	 IAmNetx: yeah, thinking about possible solution. When I consulted WMCZ's executive director about the feature, she said some people might have Tracker account for watching what's happening (they can watch tickets or topics, so it can be useful for them) and that we perhaps shouldn't assume all Tracker account owners are here to request reimbursement.
[20:01:55] 	 So, maybe let's warn users only if they're trying to request reimbursement?
[20:02:02] 	 could make it so that the warning banner disappears if you click skip on /fill/details?
[20:02:13] 	 would have to add field to model for that though
[20:03:25] 	 a solution, I feel that the form you made informs users that bank account number might be necessary at some point should be enough
[20:04:18] 	 sounds good to me
[20:04:28] 	 Okay, could you make the change then?
[20:04:39] 	 doing so
[20:05:02] 	 (y)
[20:06:42] 	 (03PS1) 10Legoktm: build: Upgrading grunt-banana-checker to 0.8.1 [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/561305
[20:15:24] 	 (03PS2) 10Legoktm: build: Upgrading grunt-banana-checker to 0.8.1 [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/561305
[20:16:52] 	 10Wikimedia-Site-requests, 10Serbian-Sites, 10Wikimedia-maintenance-script-run: Special:BrokenRedirects shows displays an incorrect state on srwiki - https://phabricator.wikimedia.org/T241648 (10Zoranzoki21) 05Open→03Invalid >>! In T241648#5768600, @Reedy wrote: >>The following data is cached, and was la...
[20:30:08] 	 (03PS1) 10Legoktm: Rename namemsg/descriptionmsg message keys to be all lowercase [extensions/TheWikipediaLibrary] - 10https://gerrit.wikimedia.org/r/561309
[20:34:09] 	 (03CR) 10jerkins-bot: [V: 04-1] Rename namemsg/descriptionmsg message keys to be all lowercase [extensions/TheWikipediaLibrary] - 10https://gerrit.wikimedia.org/r/561309 (owner: 10Legoktm)
[20:36:58] 	 10LibUp: libup2: Error 502: cannot see individual repository details - https://phabricator.wikimedia.org/T238136 (10Legoktm) 05Open→03Resolved a:03Legoktm I disabled the really slow stuff in 2d00737ac9dc35893cb978c90d0cf1057b4733cb and now the pages load for me.
[20:38:15] 	 10UploadWizard: Commons upload warning options are ambiguously worded: "OK" and "Cancel" - https://phabricator.wikimedia.org/T241655 (10Aklapper)
[20:38:17] 	 (03CR) 10Raimond Spekking: [C: 03+1] "i18n review" [extensions/TheWikipediaLibrary] - 10https://gerrit.wikimedia.org/r/561309 (owner: 10Legoktm)
[20:40:43] 	 (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/560150 (owner: 10Libraryupgrader)
[20:41:30] 	 (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/560068 (owner: 10Libraryupgrader)
[20:42:09] 	 (03CR) 10Legoktm: [C: 03+2] Allow any kind of array on Skin::makeSpecialUrl [core] - 10https://gerrit.wikimedia.org/r/561096 (owner: 10Umherirrender)
[20:42:42] 	 (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/Collection] - 10https://gerrit.wikimedia.org/r/560001 (owner: 10Libraryupgrader)
[20:43:10] 	 Urbanecm; Here is the new patch: https://gerrit.wikimedia.org/r/#/c/wikimedia-cz/tracker/+/560864/
[20:43:19] 	 (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/560034 (owner: 10Libraryupgrader)
[20:44:11] 	 (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/560024 (owner: 10Libraryupgrader)
[20:44:14] 	 RishabhL: please regenerate django.pot
[20:44:54] 	 (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/560217 (owner: 10Libraryupgrader)
[20:46:57] 	 (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/560179 (owner: 10Libraryupgrader)
[20:47:55] 	 (03CR) 10Legoktm: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 (031 comment) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/560107 (owner: 10Libraryupgrader)
[20:48:21] 	 (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/560098 (owner: 10Libraryupgrader)
[20:50:22] 	 (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/560031 (owner: 10Libraryupgrader)
[20:52:42] 	 (03PS3) 10DannyS712: Remove uses of global $wgUser [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/561253 (https://phabricator.wikimedia.org/T241630)
[20:53:37] 	 (03CR) 10DannyS712: Remove uses of global $wgUser (033 comments) [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/561253 (https://phabricator.wikimedia.org/T241630) (owner: 10DannyS712)
[20:54:15] 	 Urbanecm: Why? Is there another problem?
[20:54:16] 	 (03CR) 10Legoktm: [C: 03+2] Fix doc of File::getSize() [core] - 10https://gerrit.wikimedia.org/r/561154 (owner: 10Umherirrender)
[20:54:44] 	 (03CR) 10Legoktm: [C: 03+2] Expand documentation of RevisionStore::newRevisionFromRow [core] - 10https://gerrit.wikimedia.org/r/555544 (owner: 10Umherirrender)
[20:54:58] 	 (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/560067 (owner: 10Libraryupgrader)
[20:55:16] 	 RishabhL: see django.pot's diff at Gerrit, do you see the HEAD markers?
[20:55:27] 	 yes
[20:55:29] 	 that's the way how git notes conflicts
[20:55:51] 	 you didn't regenerate or commit django.pot after rebasing
[20:55:58] 	 (03PS1) 10DannyS712: Clean up trailing whitespace in some files [extensions/Survey] - 10https://gerrit.wikimedia.org/r/561310
[20:56:10] 	 yes, I regenerated it before rebasing
[20:56:25] 	 (03Merged) 10jenkins-bot: Allow any kind of array on Skin::makeSpecialUrl [core] - 10https://gerrit.wikimedia.org/r/561096 (owner: 10Umherirrender)
[20:56:42] 	 So I should rebase first because I was always doing it just before I did git review -R
[20:57:11] 	 Urbanecm: But I did commit --amend before rebasing
[20:57:36] 	 (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/560007 (owner: 10Libraryupgrader)
[20:57:40] 	 RishabhL: yes, you do need to rebase first, then regenerate
[20:57:58] 	 (03PS2) 10DannyS712: Clean up trailing whitespace in some files [extensions/Survey] - 10https://gerrit.wikimedia.org/r/561310
[20:58:18] 	 Urbanecm: What about committing before rebasing?
[20:58:26] 	 Does that not work?
[20:58:35] 	 (03CR) 10DannyS712: "> I may seem OCD, but I suggest moving whitespace-related changes to" [extensions/Survey] - 10https://gerrit.wikimedia.org/r/561243 (https://phabricator.wikimedia.org/T241620) (owner: 10DannyS712)
[20:58:57] 	 No, when you rebase, git notices the conflict, marks it into the file and wants you to resolve it. 
[20:59:08] 	 The way how we resolve it is by regenerating django.pot
[20:59:26] 	 ok, got it/
[20:59:28] 	 *.
[20:59:34] 	 with a normal file (like views.py), you would need to manually decide which version is correct
[20:59:46] 	 the advantage of autogenerated file is that you can easily regenerate it
[21:00:53] 	 10LibUp: Missing update mediawiki/mediawiki-phan-config to 0.9.0 from libup - https://phabricator.wikimedia.org/T241594 (10Legoktm) I submitted patches for some of grunt-banana-checker repos, I'll do more as I have time. And then libup should automatically reprocess the repo the next day.
[21:02:36] 	 (03PS5) 10DannyS712: Remove uses of global $wgUser [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/561129 (https://phabricator.wikimedia.org/T241576)
[21:02:57] 	 (03CR) 10Daimona Eaytoy: Remove phan exclusions (031 comment) [extensions/Jade] - 10https://gerrit.wikimedia.org/r/560975 (owner: 10Daimona Eaytoy)
[21:03:00] 	 (03CR) 10DannyS712: Remove uses of global $wgUser (031 comment) [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/561129 (https://phabricator.wikimedia.org/T241576) (owner: 10DannyS712)
[21:03:35] 	 (03CR) 10Daimona Eaytoy: [C: 03+2] Clean up trailing whitespace in some files [extensions/Survey] - 10https://gerrit.wikimedia.org/r/561310 (owner: 10DannyS712)
[21:04:17] 	 (03PS5) 10DannyS712: Remove use of global $wgUser [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/561132 (https://phabricator.wikimedia.org/T241578)
[21:05:57] 	 (03CR) 10Daimona Eaytoy: [C: 03+2] Remove use of global $wgUser [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/561132 (https://phabricator.wikimedia.org/T241578) (owner: 10DannyS712)
[21:05:59] 	 Urbanecm: So I should reset branch(to have a fresh start) -> rebase -> Autogenerate -> git add -> commit -> review -R
[21:06:43] 	 RishabhL: now, just regenerate the file - you have already rebased
[21:08:13] 	 (03CR) 10Daimona Eaytoy: [C: 04-1] "Yay, we're on the right track" (031 comment) [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/561129 (https://phabricator.wikimedia.org/T241576) (owner: 10DannyS712)
[21:08:39] 	 (03Merged) 10jenkins-bot: Fix doc of File::getSize() [core] - 10https://gerrit.wikimedia.org/r/561154 (owner: 10Umherirrender)
[21:09:21] 	 (03Merged) 10jenkins-bot: Expand documentation of RevisionStore::newRevisionFromRow [core] - 10https://gerrit.wikimedia.org/r/555544 (owner: 10Umherirrender)
[21:09:37] 	 (03CR) 10Daimona Eaytoy: Remove uses of global $wgUser (031 comment) [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/561253 (https://phabricator.wikimedia.org/T241630) (owner: 10DannyS712)
[21:10:00] 	 (03Merged) 10jenkins-bot: Clean up trailing whitespace in some files [extensions/Survey] - 10https://gerrit.wikimedia.org/r/561310 (owner: 10DannyS712)
[21:10:02] 	 (03Merged) 10jenkins-bot: Remove use of global $wgUser [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/561132 (https://phabricator.wikimedia.org/T241578) (owner: 10DannyS712)
[21:10:04] 	 (03CR) 10DannyS712: Remove uses of global $wgUser (031 comment) [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/561129 (https://phabricator.wikimedia.org/T241576) (owner: 10DannyS712)
[21:10:43] 	 10MediaWiki-extensions-Html2Wiki, 10Technical-Debt (Deprecation process), 10User-DannyS712: Html2Wiki needs uses of global $wgUser removed - https://phabricator.wikimedia.org/T241578 (10DannyS712) 05Open→03Resolved
[21:10:44] 	 10MediaWiki-User-management, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Patch-For-Review, 10Technical-Debt (Deprecation process), 10User-DannyS712: Deprecate $wgUser - https://phabricator.wikimedia.org/T159299 (10DannyS712)
[21:11:46] 	 (03PS1) 10DannyS712: Remove uses of global $wgUser [extensions/Survey] - 10https://gerrit.wikimedia.org/r/561311 (https://phabricator.wikimedia.org/T241620)
[21:11:53] 	 (03Abandoned) 10DannyS712: Remove uses of global $wgUser [extensions/Survey] - 10https://gerrit.wikimedia.org/r/561243 (https://phabricator.wikimedia.org/T241620) (owner: 10DannyS712)
[21:12:20] 	 (03CR) 10Daimona Eaytoy: [C: 04-1] Remove uses of global $wgUser (031 comment) [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/561129 (https://phabricator.wikimedia.org/T241576) (owner: 10DannyS712)
[21:14:34] 	 (03PS2) 10DannyS712: Remove uses of global $wgUser [extensions/Survey] - 10https://gerrit.wikimedia.org/r/561311 (https://phabricator.wikimedia.org/T241620)
[21:15:34] 	 Urbanecm: https://gerrit.wikimedia.org/r/#/q/status:open
[21:17:20] 	 You mean https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/560864 ?
[21:17:40] 	 The link you sent is a list of all the open patches :)
[21:17:51] 	 (03PS6) 10DannyS712: Remove uses of global $wgUser [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/561129 (https://phabricator.wikimedia.org/T241576)
[21:18:04] 	 I realised, but Urbanecm understood
[21:18:11] 	 Thank you for pointing it out though
[21:18:22] * Urbanecm just reloaded what he have opened
[21:18:39] 	 RishabhL: looks good
[21:18:57] 	 In before another merge conflict shows up
[21:19:03] 	 RishabhL: could you submit via gci?
[21:19:10] 	 Sure
[21:19:22] 	 Do you want me to post the link for evidene?
[21:19:26] 	 *evidence
[21:19:30] 	 10MediaWiki-User-management, 10Anti-Harassment: Allow overriding a range block with a more specific block with different settings - https://phabricator.wikimedia.org/T241652 (10Bugreporter)
[21:19:32] 	 10MediaWiki-User-management: Allowing whitelisting single IP addresses within a blocked IP range - https://phabricator.wikimedia.org/T5340 (10Bugreporter)
[21:19:36] 	 well i just approved the commit, so it should merge soon
[21:19:43] 	 RishabhL: ideally :)
[21:19:56] 	 10MediaWiki-General: Provide a tooltip to logged in users to quickly start a discussion based on the highlighted text - https://phabricator.wikimedia.org/T241654 (10Aklapper) Sounds related to {T29570}?
[21:20:55] 	 :)
[21:21:06] 	 (03PS1) 10DannyS712: Clean up whitespace in more files [extensions/Survey] - 10https://gerrit.wikimedia.org/r/561312
[21:23:41] 	 Urbanecm: Just wanted to point out that there is a whitespace difference in django.pot. This may not be an issue but just wanted to point it out to you, if you didn't know already.
[21:23:59] 	 (03PS2) 10DannyS712: Clean up whitespace in more files [extensions/Survey] - 10https://gerrit.wikimedia.org/r/561312
[21:25:33] 	 (03PS3) 10DannyS712: Clean up whitespace in more files [extensions/Survey] - 10https://gerrit.wikimedia.org/r/561312
[21:36:40] 	 Happy new year everyone!
[21:36:51] 	 I'm doing a task for Google Code-in right?
[21:37:05] 	 And it's uh replacing "wfMessage()->rawParams()"
[21:37:52] 	 I've got my dev environment set up I think (I can see the dev wiki), but I'm not sure what files to look through? I assume .php files
[21:40:05] 	 Yeah
[21:44:15] 	 JeremyNguyen: yes, any PHP file for either core or any extension on Gerrit
[21:44:33] 	 but only replace instances of ->rawParams() where it is not needed
[21:44:45] 	 10UploadWizard: Commons upload warning options are ambiguously worded: "OK" and "Cancel" - https://phabricator.wikimedia.org/T241655 (10Masumrezarock100) Those looks like a [[https://www.mediawiki.org/wiki/OOUI/Windows/Simple_messages|OOUI simple confirmation dialog]] to me.
[21:46:36] 	 10MediaWiki-extensions-Gadgets, 10Patch-For-Review, 10User-DannyS712, 10Voice & Tone: `gadgets-prefstext` needs to be updated regarding interface administrators - https://phabricator.wikimedia.org/T241634 (10Aklapper)
[21:47:06] 	 Is there a folder I should be looking in specifically? Sorry I'm just not sure where to start
[21:48:25] 	 the includes/ folder is probably where you might wanna start looking
[21:48:34] 	 if you have any extensions, then within their extension folders
[21:48:40] 	 oh okay!
[21:48:41] 	 thank you!
[21:48:44] 	 happy new year too!
[21:49:06] 	 happy new year!
[21:58:56] 	 (03CR) 10Daimona Eaytoy: [C: 03+2] Remove uses of global $wgUser [extensions/Survey] - 10https://gerrit.wikimedia.org/r/561311 (https://phabricator.wikimedia.org/T241620) (owner: 10DannyS712)
[22:00:56] 	 (03CR) 10Daimona Eaytoy: [C: 03+2] Clean up whitespace in more files [extensions/Survey] - 10https://gerrit.wikimedia.org/r/561312 (owner: 10DannyS712)
[22:02:03] 	 (03Merged) 10jenkins-bot: Remove uses of global $wgUser [extensions/Survey] - 10https://gerrit.wikimedia.org/r/561311 (https://phabricator.wikimedia.org/T241620) (owner: 10DannyS712)
[22:03:45] 	 (03Merged) 10jenkins-bot: Clean up whitespace in more files [extensions/Survey] - 10https://gerrit.wikimedia.org/r/561312 (owner: 10DannyS712)
[22:12:47] 	 Happy new year, JeremyNguyen!
[22:13:06] 	 Thank you Ebe123!
[22:13:13] 	 Left a comment on your task instance
[22:13:20] 	 Oh thank you haha 
[22:13:37] 	 Wait you're joking? I'm right?
[22:14:12] 	 I didn't test it; it just looks good. I'm waiting for a proper patch!
[22:14:38] 	 10wikimedia.biterg.io, 10Developer-Advocacy (Apr-Jun 2019): Advertise wikimedia.biterg.io more widely in the Wikimedia community - https://phabricator.wikimedia.org/T179820 (10Aklapper)
[22:14:40] 	 10Developer-Advocacy, 10wikimedia.biterg.io: Investigate indexing Issues and PRs of Github repositories canonical on wikimedia.biterg.io - https://phabricator.wikimedia.org/T218529 (10Aklapper)
[22:15:36] 	 oh okay thank you! but uh how do i test it? also it's inside a nested switch statement (so there's like 12 of them like that): should i change all of them?
[22:15:58] 	 If you think it's applicable, yes
[22:16:17] 	 oh okay thank you!
[22:18:38] 	 And try to do stuff to get to the case you want. The 'protectedarticle' message is the log message when protecting a page; try doing that and looking at the log for the page
[22:22:13] 	 Also, don't bother with Github; create your patch and git review to Gerrit
[22:25:13] 	 10MediaWiki-extensions-Survey, 10Technical-Debt, 10User-DannyS712: Survey needs uses of global $wgUser removed - https://phabricator.wikimedia.org/T241620 (10DannyS712) 05Open→03Resolved
[22:25:17] 	 10MediaWiki-User-management, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Patch-For-Review, 10Technical-Debt (Deprecation process), 10User-DannyS712: Deprecate $wgUser - https://phabricator.wikimedia.org/T159299 (10DannyS712)
[22:30:55] 	 (03PS1) 10Jasper Deng: Replace hacky hardcoded rangeblock limit with configurable setting akin to local blocking and CheckUser. [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/561314
[22:31:41] 	 10Developer-Advocacy: Gather data how much code development activity takes place canonically in Phabricator Diffusion - https://phabricator.wikimedia.org/T241659 (10Aklapper) p:05Triage→03Low
[22:31:43] 	 10Developer-Advocacy: Gather data how much code development activity takes place canonically in Phabricator Diffusion - https://phabricator.wikimedia.org/T241659 (10Aklapper) Have not taken a really close look, so just dropping stuff here: * Running https://phabricator.wikimedia.org/conduit/method/diffusion.comm...
[22:35:53] 	 Urbanecm: Hey! What do you want?
[22:36:23] * alcarazzam wish a Happy New year to everyone
[22:37:05] 	 alcarazzam: Hi!
[22:37:18] 	 thinking about this mix of messages: https://usercontent.irccloud-cdn.com/file/gr7heNrD/image.png
[22:37:34] 	 can't a mix of a warning and success message confuse the user?
[22:37:51] 	 Yeah
[22:38:04] 	 But can I do?
[22:38:09] 	 subdue the warnings?
[22:38:48] 	 Think that in production is one warning less
[22:39:00] 	 Ebe123: well, the GCI task was to inform user they should add a bank account number to their preferences if they submit a ticket for approval before. 
[22:39:34] 	 *Not saying to remove, but change CSS if it'd confuse otherwise
[22:39:44] 	 What about returning the form with an error, and ignore the error on the second try?
[22:40:01] 	 Or, a far simpler solution, suppress the success message, and incorporate it into the warning
[22:40:07] 	 so, user sees only one message, that's a warning
[22:40:27] 	 Yeah
[22:40:35] 	 That's a good option
[22:40:53] 	 I'll implement next year :)
[22:41:10] 	 How many hours
[22:41:12] 	 ?
[22:41:23] 	 It's 23:41
[22:41:37] 	 Or, include the warning in the form itself?
[22:41:38] 	 18h41
[22:41:45] * Urbanecm is brainstorming ideas
[22:42:18] 	 In 12h
[22:44:17] 	 Urbanecm: I can do whatever you want, but let it clear!
[22:46:40] 	 alcarazzam: I'm just suggesting solutions, and open to opinions :-)
[22:46:43] 	 (03CR) 10DannyS712: Replace hacky hardcoded rangeblock limit with configurable setting akin to local blocking and CheckUser. (031 comment) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/561314 (owner: 10Jasper Deng)
[22:47:19] 	 IAmNetx: feel free to voice your opinions on this issue!
[22:48:27] 	 I think that the second one is the best
[22:50:19] 	 (03PS1) 10Jasper Deng: Add comma. The rest should be good syntactically. [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/561315
[22:50:37] 	 gah how do I add to an existing one :<<
[22:50:58] 	 (03PS3) 10DannyS712: Remove uses of global $wgUser [extensions/Athena] - 10https://gerrit.wikimedia.org/r/561248 (https://phabricator.wikimedia.org/T241625)
[22:51:13] 	 (03Abandoned) 10Jasper Deng: Add comma. The rest should be good syntactically. [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/561315 (owner: 10Jasper Deng)
[22:51:15] 	 (03CR) 10DannyS712: Remove uses of global $wgUser (032 comments) [extensions/Athena] - 10https://gerrit.wikimedia.org/r/561248 (https://phabricator.wikimedia.org/T241625) (owner: 10DannyS712)
[22:54:16] 	 I would suggest that the second option might be more effective, but you should still add the first solution as well
[22:54:40] 	 (03PS6) 10DannyS712: Remove some uses of global $wgUser [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/561225 (https://phabricator.wikimedia.org/T241612)
[22:54:54] 	 (03CR) 10DannyS712: Remove some uses of global $wgUser (031 comment) [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/561225 (https://phabricator.wikimedia.org/T241612) (owner: 10DannyS712)
[22:55:35] 	 IAmNetx: what are you working on?
[22:56:29] 	 alcarazzam: post registration details form 
[22:56:47] 	 and a broken laptop which thinks its about to become the 23rd of June 
[22:57:04] 	 The 2020 bug?
[22:57:46] 	 (03CR) 10jerkins-bot: [V: 04-1] Remove some uses of global $wgUser [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/561225 (https://phabricator.wikimedia.org/T241612) (owner: 10DannyS712)
[22:58:18] 	 (03PS2) 10Jasper Deng: Replace hacky hardcoded rangeblock limit with configurable setting akin to local blocking and CheckUser. [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/561314
[22:58:37] 	 is that the bug where the iso year has 2020 on 12/30?
[22:59:04] 	 Wouldn't be
[22:59:13] 	 is Danny on IRC?
[22:59:57] 	 (03PS3) 10DannyS712: Remove uses of global $wgUser and global $wgCommunityCollectionNamespace [extensions/Collection] - 10https://gerrit.wikimedia.org/r/561238 (https://phabricator.wikimedia.org/T241616)
[23:01:20] 	 Happy new years to the Europe folk
[23:02:38] 	 (03CR) 10DannyS712: "Test fails due to missing OAuthClient, which isn't affected" [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/561225 (https://phabricator.wikimedia.org/T241612) (owner: 10DannyS712)
[23:03:51] 	 (03CR) 10jerkins-bot: [V: 04-1] Remove uses of global $wgUser [extensions/Athena] - 10https://gerrit.wikimedia.org/r/561248 (https://phabricator.wikimedia.org/T241625) (owner: 10DannyS712)
[23:05:05] 	 (03CR) 10DannyS712: "Division by zero in /workspace/src/extensions/Athena/AthenaHelper.php - not affected by this patch" [extensions/Athena] - 10https://gerrit.wikimedia.org/r/561248 (https://phabricator.wikimedia.org/T241625) (owner: 10DannyS712)
[23:05:24] 	 (03PS3) 10Jasper Deng: Configurable CIDR rangeblock limits (https://phabricator.wikimedia.org/T46836) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/561314
[23:10:06] 	 (03PS3) 10DannyS712: Remove uses of global $wgUser [extensions/AzharAuth] - 10https://gerrit.wikimedia.org/r/561249 (https://phabricator.wikimedia.org/T241626)
[23:15:41] 	 (03CR) 10Samwilson: "Thanks for this. :)" (033 comments) [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/561270 (owner: 10Daimona Eaytoy)
[23:19:24] 	 (03PS14) 10DannyS712: Expand tests for title class [core] - 10https://gerrit.wikimedia.org/r/560455 (https://phabricator.wikimedia.org/T241406)
[23:20:33] 	 (03CR) 10DannyS712: Expand tests for title class (034 comments) [core] - 10https://gerrit.wikimedia.org/r/560455 (https://phabricator.wikimedia.org/T241406) (owner: 10DannyS712)
[23:22:16] 	 IAmNetx: what do you mean with the second?
[23:22:37] 	 Sorry for my bad English :)
[23:22:39] 	 (03PS4) 10Gergő Tisza: Configurable CIDR rangeblock limits [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/561314 (https://phabricator.wikimedia.org/T46836) (owner: 10Jasper Deng)
[23:23:48] 	 (03CR) 10jerkins-bot: [V: 04-1] Configurable CIDR rangeblock limits [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/561314 (https://phabricator.wikimedia.org/T46836) (owner: 10Jasper Deng)
[23:25:11] 	 10Developer-Advocacy: Gather data how much code development activity takes place canonically in Phabricator Diffusion - https://phabricator.wikimedia.org/T241659 (10bd808) The `isImporting` attribute seems to about active imports, not mirroring. The wording on the conduit API page is not clear, but listing all o...
[23:26:15] 	 10MediaWiki-extensions-Translate, 10WMF-JobQueue, 10Core Platform Team Workboards (Clinic Duty Team), 10User-DannyS712: Can't rename the translatable page mw:Global_templates/Draft_spec - https://phabricator.wikimedia.org/T239394 (10DannyS712) 05Open→03Resolved Closing as resolved - does not appear to...
[23:26:21] 	 (03PS1) 10Samwilson: Fix error message escaping for invalid page titles [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/561317
[23:29:54] 	 10SyntaxHighlight, 10Technical-Debt: Decide the fate of  - https://phabricator.wikimedia.org/T237267 (10Dinoguy1000) >>! In T237267#5768596, @Izno wrote: > This is {T39042}, no?  Sort of? I'm not looking specifically for deprecation and removal in this task (though that's what I personally would prefer...
[23:32:09] 	 (03CR) 10Gergő Tisza: Configurable CIDR rangeblock limits (032 comments) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/561314 (https://phabricator.wikimedia.org/T46836) (owner: 10Jasper Deng)
[23:33:30] 	 (03PS1) 10Samwilson: Set minimum MediaWiki version to 1.31 (current LTS) [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/561318
[23:33:32] 	 (03CR) 10jerkins-bot: [V: 04-1] Expand tests for title class [core] - 10https://gerrit.wikimedia.org/r/560455 (https://phabricator.wikimedia.org/T241406) (owner: 10DannyS712)
[23:35:21] 	 (03PS15) 10DannyS712: Expand tests for title class [core] - 10https://gerrit.wikimedia.org/r/560455 (https://phabricator.wikimedia.org/T241406)
[23:40:57] 	 10SyntaxHighlight, 10Technical-Debt: Decide the fate of  - https://phabricator.wikimedia.org/T237267 (10DannyS712) >>! In T237267#5768884, @Dinoguy1000 wrote: >>>! In T237267#5768596, @Izno wrote: >> This is {T39042}, no? >  > Sort of? I'm not looking specifically for deprecation and removal in this ta...
[23:45:48] 	 (03CR) 10Samwilson: [C: 03+2] Set minimum MediaWiki version to 1.31 (current LTS) [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/561318 (owner: 10Samwilson)
[23:46:39] 	 (03CR) 10Samwilson: [C: 04-1] "> It would only break when running the unit tests with Mediawiki < 1.35, but it does not break production compatibility" [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/561188 (https://phabricator.wikimedia.org/T196090) (owner: 10Umherirrender)
[23:49:26] 	 (03Merged) 10jenkins-bot: Set minimum MediaWiki version to 1.31 (current LTS) [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/561318 (owner: 10Samwilson)
[23:49:36] 	 (03CR) 10jerkins-bot: [V: 04-1] Expand tests for title class [core] - 10https://gerrit.wikimedia.org/r/560455 (https://phabricator.wikimedia.org/T241406) (owner: 10DannyS712)
[23:50:57] 	 (03PS16) 10DannyS712: Expand tests for title class [core] - 10https://gerrit.wikimedia.org/r/560455 (https://phabricator.wikimedia.org/T241406)
[23:52:59] 	 Hi! So I finished making the changes for the rawParams() thing. How should I name my branch? T182213
[23:52:59] 	 , cleanup/logging, cleanup/LogFormatter.php or some other thing?
[23:53:00] 	 T182213: [Clonable] replace wfMessage()->rawParams() with wfMessage()->plaintextParams() where applicable - https://phabricator.wikimedia.org/T182213
[23:54:37] 	 JeremyNguyen: yes, that's a good name
[23:54:45] 	 Which one?
[23:55:07] 	 The task number
[23:55:17] 	 okay thank you!
[23:55:39] 	 Yw