[00:00:43] 10MediaWiki-Special-pages, 10Core Platform Team, 10MW-1.34-notes, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), 10User-DannyS712: Special:NewPages - allow hiding pages created by users when non-users can create talk pages - https://phabricator.wikimedia.org/T238483 (10DannyS712) >>! In T238483#5764828, @X... [00:09:53] (03PS1) 10Samwilson: Fix Phan config [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/560865 [00:16:10] (03CR) 10Samwilson: "check experimental" [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/560865 (owner: 10Samwilson) [00:27:39] (03CR) 10Samwilson: [C: 03+2] Fix Phan config [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/560865 (owner: 10Samwilson) [00:30:41] (03Merged) 10jenkins-bot: Fix Phan config [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/560865 (owner: 10Samwilson) [00:30:47] 10MediaWiki-General, 10Core Platform Team, 10Developer-Wishlist (2017): Core should be aware of the domain it is running on and render mobile domains where necessary - https://phabricator.wikimedia.org/T156847 (10Tgr) Blindly accepting the host header is already possible (but highly inadvisable in a producti... [00:37:25] (03PS1) 10Zoranzoki21: Convert SiteMatrix extension.json to manifest_version 2 [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/560866 (https://phabricator.wikimedia.org/T241205) [00:45:00] 10MediaWiki-extensions-GoogleAdSense: Convert GoogleAdSense extension to extension registration - https://phabricator.wikimedia.org/T199036 (10Zoranzoki21) [00:45:04] 10MediaWiki-extensions-GoogleAdSense, 10Patch-For-Review, 10User-Zoranzoki21: Convert GoogleAdSense to use extension registration - https://phabricator.wikimedia.org/T220896 (10Zoranzoki21) [00:49:52] (03PS3) 10Zoranzoki21: Convert GoogleAdSense to use extension registration [extensions/GoogleAdSense] - 10https://gerrit.wikimedia.org/r/503692 (https://phabricator.wikimedia.org/T220896) [00:53:36] Hello, i'm virdio, i'm GCI Student [00:53:44] hi Virdio! [00:54:22] Hi👋 [00:56:23] hi Virdio [00:56:39] Hi Krenair [00:56:45] Hello Virdio! [00:57:08] Hello Ebe123 [01:12:53] 10MediaWiki-Special-pages, 10Core Platform Team, 10MW-1.34-notes, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), 10User-DannyS712: Special:NewPages - allow hiding pages created by users when non-users can create talk pages - https://phabricator.wikimedia.org/T238483 (10Xaosflux) What I'm saying is that whe... [01:32:44] 10MediaWiki-Special-pages, 10Core Platform Team, 10MW-1.34-notes, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), 10User-DannyS712: Special:NewPages - allow hiding pages created by users when non-users can create talk pages - https://phabricator.wikimedia.org/T238483 (10DannyS712) >>! In T238483#5764843, @X... [01:56:01] 10MediaWiki-Special-pages, 10Core Platform Team, 10MW-1.34-notes, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), 10User-DannyS712: Special:NewPages - allow hiding pages created by users when non-users can create talk pages - https://phabricator.wikimedia.org/T238483 (10Xaosflux) It's non-default, and only... [02:22:49] Hello Ebe123 [02:23:27] Hey! Have you submitted your task? [02:24:27] No, i havent [02:26:54] How about you Ebe123 ? [02:27:03] I'm an org admin [02:27:23] I'm not a student, can only review and create tasks ;) [02:28:03] Woah, 😂😂 [02:30:56] Also making sure no one is cheating [02:31:15] (Tell a lot of students to be careful for rule 4.2 :) ) [02:35:38] I'm sorry, there's a rulebook? [02:36:34] https://codein.withgoogle.com/student-terms/ [02:36:59] Yes. It basically says to not cheat (quite a tautology) [02:37:47] The main points are to not copy off others, no plagiarism, and no working on many tasks at once [02:38:09] Yeah cheating is bad! [02:40:24] I agree with you [02:40:28] We've caught some students copying from others and mis-representing their work [02:40:46] Wow😮 [02:41:16] Student try to re-register after getting kicked ouy [02:41:19] *out [02:41:38] Might get a few tasks completed but we'll find out [02:44:55] People try to rejoin? [02:45:07] I'd assume it'd be a lot more effort than it's worth to create a new LDAP each time [02:46:13] Yes, but Google would have caught them as they can't change their parents ;) [02:46:48] XD [02:46:51] Harder to fool Google, we just found them earlier than their check [02:58:06] Me wonders how many people lie about their parents [03:08:55] Had a student basically lie to the mentors to get approval for their tasks (4 times...) [03:09:54] I was trusting and was approving their tasks based on their answers, but a little more digging revealed it [03:11:04] Ah, we're past the half-way point of GCI! [03:11:42] How could they lie to get a task accepted...? [03:12:58] Depends on the task, some are really objective, and others have an amount of trust in the student [03:13:17] 10Google-Code-in-2019: Test "Correct typos in one click" script - https://phabricator.wikimedia.org/T239541 (10Gopavasanth) Yes, I agree with @Urbanecm and @Aklapper comments, I followed the same steps and fixed a typo, Me as I already used several user scripts and gadgets before, so I know how this works, But f... [03:13:20] Such as claiming that all work is original in a design task [03:15:05] ah, I see [03:15:14] Or that a criteron is moot in a task [03:15:40] yeah I sort by code so I probably don't see the ones like that [03:15:47] filter rather* [03:15:49] Hey, have I been here for an hour? [03:15:56] i.e. "Find and correct typos in an extension" -> "Looked through extension x and there were no typos' [03:16:00] you've been here for around three hours [03:16:23] Virdio, I did ask whether you submitted your task; tacitly telling you to [03:17:11] I haven't submit my task [03:17:21] You should do so [03:17:35] Okay [03:17:48] So I feel such a coding task should be approved, as the student did work on finding a typo; just that there is no code changes to do [03:18:40] aye [03:19:02] But it does open the possibility of lying [03:19:23] my first thought for a second was that you could look for typos beforehand to catch them out - but that'd be more counterproductive than it's worth as there'd be no point in the student looking for any [03:20:09] If I go out and look for typos, might as well correct them; the effort is basically equal [03:20:29] aye, my point exactly [03:20:36] (I just took the idea of the task from the last wikibugs post :) ) [03:23:40] 10DynamicPageList (Wikimedia), 10Google-Code-in-2019: Make DynamicPageList_(wikimedia) use page images as the image in gallery mode for pages that are not in the File namespace - https://phabricator.wikimedia.org/T240108 (10BrandonXLF) a:03BrandonXLF [03:24:16] I find it pretty funny how most orgs have >100 tasks completed and at least 20 people with more than 5 tasks, then there's just Copyleft Games with 58 tasks and 1 person who's done 5 tasks [03:24:40] it's pretty obvious from those stats what kind of tasks organizations have [03:26:33] Yep [03:27:11] Maybe we're just very exacting in our standards to accept tasks, so it's lower here [03:28:16] I have a feeling it's more that some organisations have more tasks which are like "use a CLI" or "create a github account" or something really basic like that whereas the Wikimedia ones are more targeted, and consist more of actual bugs/feature requests/etc rather than how-tos [03:28:58] (03PS1) 10JeremyNguyenGCI: JeremyNguyen.txt: Text file for Google Code-in task. [sandbox] - 10https://gerrit.wikimedia.org/r/560869 [03:29:00] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [sandbox] - 10https://gerrit.wikimedia.org/r/560869 (owner: 10JeremyNguyenGCI) [03:29:11] Great JeremyNguyen! [03:29:41] Interesting file contents [03:29:59] I thought we corrected him on "Hello Gamers." [03:30:31] -2 for mentioning Fortnite. [03:30:48] (03CR) 10Ebe123: [V: 03+2 C: 03+2] "Fine, but we're not all gamers here, as Urbanecm said on IRC :P" [sandbox] - 10https://gerrit.wikimedia.org/r/560869 (owner: 10JeremyNguyenGCI) [03:31:20] Too much personal info, Google wouldn't be happy with us [03:31:48] Hey wait that's me [03:32:13] Please link to https://gerrit.wikimedia.org/r/560869 on GCI [03:32:18] Then submit [03:32:34] (We really dislike screenshots) [03:32:45] Surprised Google doesn't seem angry about the fact that Gerrit shows people's names and email addresses xD [03:32:53] Hi sorry but how do you find the link to the patch? [03:33:16] Everything on Gerrit is mentioned by Wikibugs here [03:33:36] Oh okay, that's neat [03:34:26] Yep; they probably understand the necessity of revealing some PPI for GCI [03:34:42] Or else there wouldn't be much in terms of tasks [03:34:51] For any org [03:35:16] "Upload your work as a .zip file so that a mentor can upload it to Gerrit" [03:36:26] Can't use Git; that requires an email [03:38:02] Tell that to the orgs with those tasks for creating a new github account! [03:38:52] Creating a Github account is implicit in some of our tasks [03:39:06] But should really not be a task on its own [03:39:35] are mentors able to see tasks from other organizations? [03:39:45] Google has been sending the organization admins (for all orgs) warnings about doing that (also about having 'Go on IRC' tasks...) [03:40:55] I can see their point of view on the IRC bit but honestly I'm surprised at how many people have trouble with that task [03:41:23] I think the origin of those emails was some organization this year creating a task where you have to star their repos [03:41:35] That's just dirty [03:42:19] For the 'Get on IRC', the warning is as sometimes orgs require PPI for tasks such as that, while we don't [03:42:43] Basically "say hi" and not "say your name, etc." [03:44:12] mhm, I was looking at it from a "free marketing" kinda stance, but I don't really think joining IRC would be free marketing considering there's nothing to gain from having more people in here + the fact that most leave as soon as their hour is up [03:44:54] irc is pretty cool [03:45:01] i like it more than slack [03:45:06] The "star our repos" is free marketing, but IRC doesn't really affect popularity outside [03:45:44] The idea of IRC is that of FLOSS; you don't like something, you can change it! [03:46:22] So IRC clients can be extended to do a lot and is not closed like slack [03:47:24] yeah [03:47:31] the biggest irc network is technically twitch :) [03:49:05] I've never actually used Slack or Twitch. Telegram only once... [03:49:15] Sadly I use Messenger quite a bit [03:49:55] :/ facebook isn't foss [03:49:59] Facebook Messenger? [03:50:55] can't remember the last time I used facebook purely because I deleted my account just to avoid a lot of people who I didn't like [03:51:07] honestly if all my friends would use it, i would much rather prefer using riot or telegram [03:51:17] but everyone's on facebook [03:51:26] I'm disappointed in myself for that [03:52:07] (03PS1) 10Zoranzoki21: Add phpcs and make it pass [extensions/GoogleAnalyticsTopPages] - 10https://gerrit.wikimedia.org/r/560870 [03:52:57] (03PS2) 10Zoranzoki21: Add phpcs [extensions/ContributionCredits] - 10https://gerrit.wikimedia.org/r/560798 [03:53:04] I have a lot of chat applications open at the same time (including telegram) purely because I have several friends who don't use anything but that specific chat application because their friends only use that chat application [03:53:12] (03CR) 10Zoranzoki21: ">" (032 comments) [extensions/ContributionCredits] - 10https://gerrit.wikimedia.org/r/560798 (owner: 10Zoranzoki21) [03:53:32] do u use discord [03:53:41] (03CR) 10jerkins-bot: [V: 04-1] Add phpcs [extensions/ContributionCredits] - 10https://gerrit.wikimedia.org/r/560798 (owner: 10Zoranzoki21) [03:54:05] aye [03:54:08] that's really respectable i respect u a lot IAmNetx [03:54:58] why, thank you :) [03:55:16] :) [03:55:50] No [03:56:21] Never used Discord [03:56:35] Currently have IRC, email, and Messenger open [03:56:51] One too many [03:57:30] I currently have irc, discord, whatsapp web, telegram and a carrier pigeon on my desk [03:58:23] whats the pigeon's name [03:58:31] Is the pigeon open-source? [03:58:59] Pigeon is open source but with a limited license [03:59:11] his name is Pigeon [03:59:37] that's a nice name [03:59:41] So, forking and cloning are unacceptable? [04:00:00] *contrary to the AGPL? (Avian GPL) [04:00:49] Aye, pushing is general frowned upon as well, please make pull requests instead [04:01:17] Are releases frequent? [04:01:32] No you have to build it yourself# [04:02:20] But builds are bootstrapped [04:02:33] Need two to build another [04:03:24] I've ran out of pigeon-code related humour [04:03:57] Fancy bird though [04:05:55] one of a kind, can't think of any other bird which has a license since they're all usually... well, birds [04:27:05] (03CR) 10Ammarpad: [C: 03+1] "Looks good to me." [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/560866 (https://phabricator.wikimedia.org/T241205) (owner: 10Zoranzoki21) [04:48:06] 10Magnus Sälgö: Europeana Entity <-> Wikidata Property 7704 - https://phabricator.wikimedia.org/T240290 (10Salgo60) [04:54:00] 10Developer-Advocacy (Oct-Dec 2019), 10Google-Code-in-2019: Google Code-In 2019 Design Wikimedia Friends of the Docs Appreciation Stickers - https://phabricator.wikimedia.org/T239641 (10Praduman30642) {F31490540} [04:54:14] (03PS1) 10BrandonXLF: Use page image when in gallery mode [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) [04:55:49] (03PS2) 10BrandonXLF: Use page image when in gallery mode [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) [05:02:21] (03CR) 10DannyS712: [C: 04-1] Add phpcs (031 comment) [extensions/ContributionCredits] - 10https://gerrit.wikimedia.org/r/560798 (owner: 10Zoranzoki21) [05:05:38] 10Developer-Advocacy (Oct-Dec 2019), 10Google-Code-in-2019: Google Code-In 2019 Design Wikimedia Friends of the Docs Appreciation Stickers - https://phabricator.wikimedia.org/T239641 (10Praduman30642) {F31490551} [05:16:56] 10Password-Reset-Update, 10Community-Tech (Kanban-Q2-2019-20): PRU: Address 'No Email Will Be Sent' Issue for Unconfirmed Users [small] - https://phabricator.wikimedia.org/T239938 (10Prtksxna) >>! In T239938#5748742, @ifried wrote: > However, if we receive feedback that users are confused, we can change the pl... [05:37:43] (03PS3) 10Zoranzoki21: Add phpcs [extensions/ContributionCredits] - 10https://gerrit.wikimedia.org/r/560798 [05:39:40] (03CR) 10Zoranzoki21: [C: 04-1] Use page image when in gallery mode (032 comments) [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) (owner: 10BrandonXLF) [05:45:01] (03PS3) 10BrandonXLF: Use page image when in gallery mode [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) [05:45:27] (03CR) 10BrandonXLF: Use page image when in gallery mode (032 comments) [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) (owner: 10BrandonXLF) [05:56:58] (03CR) 10Zoranzoki21: ">" (032 comments) [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) (owner: 10BrandonXLF) [05:57:13] (03CR) 10Zoranzoki21: "recheck" [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) (owner: 10BrandonXLF) [05:58:16] (03CR) 10jerkins-bot: [V: 04-1] Use page image when in gallery mode [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) (owner: 10BrandonXLF) [06:00:18] (03CR) 10Brian Wolff: [C: 04-1] "A small coding convention thing about using arrays when specifying ON conditions." (031 comment) [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) (owner: 10BrandonXLF) [06:06:16] (03CR) 10Brian Wolff: [C: 04-1] "Additionally, for the phan complaint from jenkins bot - its intentional so you can use an @suppress annotation in the docblock comment to " [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) (owner: 10BrandonXLF) [06:45:19] 10MediaWiki-Special-pages, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10User-DannyS712: Add help link to Special:NewSection - https://phabricator.wikimedia.org/T231260 (10DannyS712) [06:45:22] 10MediaWiki-General, 10Epic, 10User-DannyS712: Special pages help links [Tracking] - https://phabricator.wikimedia.org/T226350 (10DannyS712) [06:47:55] 10MediaWiki-REST-API, 10CPT Initiatives (Core REST API in PHP), 10Core Platform Team Workboards (Green), 10Story: Curator reads a revision offline - https://phabricator.wikimedia.org/T235240 (10Legoktm) >>! In T235240#5654910, @tstarling wrote: > What is "bogobytes"? It's the (theoretically) arbitrary siz... [06:48:39] 10MediaWiki-General, 10Epic, 10User-DannyS712: Special pages help links [Tracking] - https://phabricator.wikimedia.org/T226350 (10DannyS712) [06:50:34] (03PS2) 10Legoktm: Use the ParserFirstCallInit hook as appropriate [extensions/WantedPagesFromNS] - 10https://gerrit.wikimedia.org/r/559082 (owner: 10Jack Phoenix) [06:50:59] (03CR) 10Legoktm: [C: 03+2] Use the ParserFirstCallInit hook as appropriate [extensions/WantedPagesFromNS] - 10https://gerrit.wikimedia.org/r/559082 (owner: 10Jack Phoenix) [06:51:13] (03PS2) 10Legoktm: Don't use the deprecated $wgContLang global [extensions/WantedPagesFromNS] - 10https://gerrit.wikimedia.org/r/559083 (owner: 10Jack Phoenix) [06:51:17] 10MediaWiki-General, 10Epic, 10Google-Code-in-2019, 10User-DannyS712: Special pages help links [Tracking] - https://phabricator.wikimedia.org/T226350 (10DannyS712) Would submitting patches for special pages be an easy #google-code-in-2019 task? I could make a subtask for each remaining special page if that... [06:51:21] (03PS4) 10BrandonXLF: Use page image when in gallery mode [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) [06:51:40] (03CR) 10Legoktm: [C: 03+2] Don't use the deprecated $wgContLang global [extensions/WantedPagesFromNS] - 10https://gerrit.wikimedia.org/r/559083 (owner: 10Jack Phoenix) [06:51:49] (03CR) 10BrandonXLF: Use page image when in gallery mode (031 comment) [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) (owner: 10BrandonXLF) [06:53:01] (03PS2) 10Legoktm: Rewrite the SQL query to not use Database::query() directly [extensions/WantedPagesFromNS] - 10https://gerrit.wikimedia.org/r/559084 (owner: 10Jack Phoenix) [06:53:07] (03PS3) 10Legoktm: Rewrite the SQL query to not use Database::query() directly [extensions/WantedPagesFromNS] - 10https://gerrit.wikimedia.org/r/559084 (owner: 10Jack Phoenix) [06:53:12] (03CR) 10Legoktm: [C: 03+2] Rewrite the SQL query to not use Database::query() directly [extensions/WantedPagesFromNS] - 10https://gerrit.wikimedia.org/r/559084 (owner: 10Jack Phoenix) [06:53:22] (03PS5) 10BrandonXLF: Use page image when in gallery mode [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) [06:54:32] (03Merged) 10jenkins-bot: Use the ParserFirstCallInit hook as appropriate [extensions/WantedPagesFromNS] - 10https://gerrit.wikimedia.org/r/559082 (owner: 10Jack Phoenix) [06:55:11] (03CR) 10Legoktm: [C: 04-1] "I'll fix these since it's minor" (032 comments) [extensions/WantedPagesFromNS] - 10https://gerrit.wikimedia.org/r/559085 (owner: 10Jack Phoenix) [06:55:13] (03Merged) 10jenkins-bot: Don't use the deprecated $wgContLang global [extensions/WantedPagesFromNS] - 10https://gerrit.wikimedia.org/r/559083 (owner: 10Jack Phoenix) [06:55:44] this is so sad [06:56:16] (03PS2) 10Legoktm: Convert to use extension.json [extensions/WantedPagesFromNS] - 10https://gerrit.wikimedia.org/r/559085 (https://phabricator.wikimedia.org/T200233) (owner: 10Jack Phoenix) [06:56:18] (03Merged) 10jenkins-bot: Rewrite the SQL query to not use Database::query() directly [extensions/WantedPagesFromNS] - 10https://gerrit.wikimedia.org/r/559084 (owner: 10Jack Phoenix) [06:56:32] (03PS3) 10Legoktm: Convert to use extension.json [extensions/WantedPagesFromNS] - 10https://gerrit.wikimedia.org/r/559085 (https://phabricator.wikimedia.org/T200233) (owner: 10Jack Phoenix) [06:56:39] (03CR) 10Legoktm: [C: 03+2] Convert to use extension.json [extensions/WantedPagesFromNS] - 10https://gerrit.wikimedia.org/r/559085 (https://phabricator.wikimedia.org/T200233) (owner: 10Jack Phoenix) [06:56:57] 10MediaWiki-extensions-Other, 10Patch-For-Review: Convert WantedPagesFromNS to use extension registration - https://phabricator.wikimedia.org/T200233 (10Legoktm) 05Open→03Resolved a:03ashley [06:57:00] 10MediaWiki-Configuration, 10MediaWiki-extensions-General, 10Goal, 10Google-Code-in-2019, 10User-Zoranzoki21: Convert all extensions and skins on gerrit to use extension registration - https://phabricator.wikimedia.org/T98668 (10Legoktm) [06:58:11] JeremyNguyen: what's wrong? [06:59:41] (03Merged) 10jenkins-bot: Convert to use extension.json [extensions/WantedPagesFromNS] - 10https://gerrit.wikimedia.org/r/559085 (https://phabricator.wikimedia.org/T200233) (owner: 10Jack Phoenix) [07:05:42] JeremyNguyen: what happen ? [07:25:18] 10Upstream, 10phan: Phan should handle always-throw-function like ApiBase::dieWithError better - https://phabricator.wikimedia.org/T240141 (10Legoktm) >>! In T240141#5760426, @Daimona wrote: > I've filed https://github.com/phan/phan/issues/3602. ...which was closed with a pointer to https://github.com/phan/ph... [07:26:56] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/560216 (owner: 10Libraryupgrader) [07:27:29] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/DoubleWiki] - 10https://gerrit.wikimedia.org/r/560015 (owner: 10Libraryupgrader) [07:30:50] (03PS4) 10Legoktm: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/560195 (owner: 10Libraryupgrader) [07:31:02] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/560195 (owner: 10Libraryupgrader) [07:31:10] (03CR) 10Legoktm: [C: 03+2] Use friends of WebRequest::getVal [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/557118 (owner: 10Umherirrender) [07:31:18] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/560054 (owner: 10Libraryupgrader) [07:33:14] (03PS2) 10Legoktm: Use friends of WebRequest::getVal [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/557118 (owner: 10Umherirrender) [07:33:16] (03PS5) 10Legoktm: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/560195 (owner: 10Libraryupgrader) [07:34:49] 10Upstream, 10phan: Phan should handle always-throw-function like ApiBase::dieWithError better - https://phabricator.wikimedia.org/T240141 (10Legoktm) [07:35:42] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 (031 comment) [extensions/ApiFeatureUsage] - 10https://gerrit.wikimedia.org/r/559921 (owner: 10Libraryupgrader) [07:35:54] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/560180 (owner: 10Libraryupgrader) [07:36:19] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/cldr] - 10https://gerrit.wikimedia.org/r/560220 (owner: 10Libraryupgrader) [07:36:28] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/XAnalytics] - 10https://gerrit.wikimedia.org/r/560219 (owner: 10Libraryupgrader) [07:37:37] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/560195 (owner: 10Libraryupgrader) [07:46:43] Sorry the earlier wikibug thing got denied my bad [07:47:08] (03CR) 10Zoranzoki21: "recheck" [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) (owner: 10BrandonXLF) [07:48:29] (03CR) 10Zoranzoki21: "recheck" [extensions/BlueSpiceNSFileRepoConnector] - 10https://gerrit.wikimedia.org/r/559947 (owner: 10Libraryupgrader) [07:50:14] (03CR) 10jerkins-bot: [V: 04-1] Use page image when in gallery mode [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) (owner: 10BrandonXLF) [07:50:54] (03CR) 10Legoktm: [C: 03+2] "I skimmed the changelog and it all looked sane, no breaking changes. We can probably also drop v3 support now..." [tools/minus-x] - 10https://gerrit.wikimedia.org/r/556873 (owner: 10Samwilson) [07:51:22] (03Merged) 10jenkins-bot: Permit symfony/console version 5 [tools/minus-x] - 10https://gerrit.wikimedia.org/r/556873 (owner: 10Samwilson) [07:53:00] 10MediaWiki-extensions-RecentActivityFeed, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Archive the RecentActivityFeed extension - https://phabricator.wikimedia.org/T241032 (10Zoranzoki21) a:03Zoranzoki21 [07:56:37] 10MediaWiki-extensions-RecentActivityFeed: Edits with no edit summary do not show [inspect diff] link - https://phabricator.wikimedia.org/T72643 (10Zoranzoki21) 05Open→03Declined We're going to archive this extension, see T241032. [07:56:48] 10MediaWiki-extensions-RecentActivityFeed: [inspect diff] does not work for the first edit to a page - https://phabricator.wikimedia.org/T72644 (10Zoranzoki21) 05Open→03Declined We're going to archive this extension, see T241032. [07:57:00] 10MediaWiki-extensions-RecentActivityFeed: Add order by datetime option - https://phabricator.wikimedia.org/T72729 (10Zoranzoki21) 05Open→03Declined We're going to archive this extension, see T241032. [07:57:14] 10MediaWiki-extensions-RecentActivityFeed: RecentActivityFeed should be used by Special:MyCourses - https://phabricator.wikimedia.org/T73430 (10Zoranzoki21) 05Open→03Declined We're going to archive this extension, see T241032. [07:57:26] 10MediaWiki-extensions-RecentActivityFeed, 10ci-test-error: Special:RecentActivityFeed: Error: Call to undefined method RecentChange::selectFields() - https://phabricator.wikimedia.org/T241031 (10Zoranzoki21) 05Open→03Declined We're going to archive this extension, see T241032. [07:59:01] 10MediaWiki-extensions-RecentActivityFeed, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Archive the RecentActivityFeed extension - https://phabricator.wikimedia.org/T241032 (10Zoranzoki21) [08:02:57] 10Wikimedia-Site-requests: Remove old user groups from Wikimedia wikis (afttest, afttest-hide, etc.) - https://phabricator.wikimedia.org/T105570 (10Bugreporter) [08:02:59] 10MediaWiki-extensions-WikimediaMaintenance, 10Growth-Team, 10StructuredDiscussions: Remove 'bot' and 'flow-bot' rights for Flow talk page manager on wikis where Flow was uninstalled - https://phabricator.wikimedia.org/T190261 (10Bugreporter) [08:04:43] 10MediaWiki-extensions-RecentActivityFeed, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Archive the RecentActivityFeed extension - https://phabricator.wikimedia.org/T241032 (10Zoranzoki21) [08:07:30] (03PS1) 10Zoranzoki21: Remove RecentActivityFeed extension [extensions] - 10https://gerrit.wikimedia.org/r/560873 (https://phabricator.wikimedia.org/T241032) [08:07:59] (03PS2) 10Zoranzoki21: Remove RecentActivityFeed extension [extensions] - 10https://gerrit.wikimedia.org/r/560873 (https://phabricator.wikimedia.org/T241032) [08:09:39] (03CR) 10Legoktm: [C: 03+2] Add phpcs and make it pass [extensions/EditSubpages] - 10https://gerrit.wikimedia.org/r/560810 (owner: 10Zoranzoki21) [08:09:47] (03PS4) 10Siebrand: Convert GoogleAdSense to use extension registration [extensions/GoogleAdSense] - 10https://gerrit.wikimedia.org/r/503692 (https://phabricator.wikimedia.org/T220896) (owner: 10Zoranzoki21) [08:10:35] (03CR) 10Legoktm: [C: 03+2] Add phpcs and make it pass [extensions/EditSimilar] - 10https://gerrit.wikimedia.org/r/560809 (owner: 10Zoranzoki21) [08:11:14] (03PS2) 10Legoktm: Move "manifest_version" to bottom of extension.json [extensions/DebateTree] - 10https://gerrit.wikimedia.org/r/560804 (owner: 10Zoranzoki21) [08:11:20] (03CR) 10Legoktm: [C: 03+2] Move "manifest_version" to bottom of extension.json [extensions/DebateTree] - 10https://gerrit.wikimedia.org/r/560804 (owner: 10Zoranzoki21) [08:13:47] (03CR) 10Legoktm: [C: 04-1] "You're making too many changes in one patch, it's too hard to review. Please split it into multiple patches." [extensions/GlobalContribs] - 10https://gerrit.wikimedia.org/r/560819 (owner: 10Zoranzoki21) [08:14:15] 10MediaWiki-extensions-RecentActivityFeed, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, and 3 others: Archive the RecentActivityFeed extension - https://phabricator.wikimedia.org/T241032 (10Zoranzoki21) [08:15:50] (03PS1) 10Zoranzoki21: Archive RecentActivityFeed extension [extensions/RecentActivityFeed] - 10https://gerrit.wikimedia.org/r/560875 (https://phabricator.wikimedia.org/T241032) [08:15:52] (03CR) 10Legoktm: [C: 04-1] Convert SiteMatrix extension.json to manifest_version 2 (031 comment) [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/560866 (https://phabricator.wikimedia.org/T241205) (owner: 10Zoranzoki21) [08:16:11] (03CR) 10Zoranzoki21: "> You're making too many changes in one patch, it's too hard to" [extensions/GlobalContribs] - 10https://gerrit.wikimedia.org/r/560819 (owner: 10Zoranzoki21) [08:16:19] (03PS2) 10Legoktm: Delete FilterSpecialPages.setup.php [extensions/FilterSpecialPages] - 10https://gerrit.wikimedia.org/r/560813 (owner: 10Zoranzoki21) [08:16:37] (03CR) 10Legoktm: [C: 03+2] Delete FilterSpecialPages.setup.php [extensions/FilterSpecialPages] - 10https://gerrit.wikimedia.org/r/560813 (owner: 10Zoranzoki21) [08:16:39] (03Merged) 10jenkins-bot: Use friends of WebRequest::getVal [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/557118 (owner: 10Umherirrender) [08:17:08] (03Merged) 10jenkins-bot: Add phpcs and make it pass [extensions/EditSubpages] - 10https://gerrit.wikimedia.org/r/560810 (owner: 10Zoranzoki21) [08:17:10] (03Merged) 10jenkins-bot: Add phpcs and make it pass [extensions/EditSimilar] - 10https://gerrit.wikimedia.org/r/560809 (owner: 10Zoranzoki21) [08:17:12] (03Merged) 10jenkins-bot: Move "manifest_version" to bottom of extension.json [extensions/DebateTree] - 10https://gerrit.wikimedia.org/r/560804 (owner: 10Zoranzoki21) [08:17:14] (03CR) 10Zoranzoki21: Convert SiteMatrix extension.json to manifest_version 2 (031 comment) [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/560866 (https://phabricator.wikimedia.org/T241205) (owner: 10Zoranzoki21) [08:17:16] (03CR) 10Legoktm: [C: 03+2] Add phpcs [extensions/CharRangeSpan] - 10https://gerrit.wikimedia.org/r/560797 (owner: 10Zoranzoki21) [08:18:05] 10MediaWiki-extensions-RecentActivityFeed, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, and 3 others: Archive the RecentActivityFeed extension - https://phabricator.wikimedia.org/T241032 (10Zoranzoki21) Patches ready! https://gerrit.wikimedia.org/r/#/q/topic:T241032+(status:open+OR+status:merged) [08:19:33] (03CR) 10Siebrand: [C: 03+2] "Thanks a lot. This is a small extension, and it was changed significantly with compatibility consequences. So I increased the major versio" [extensions/GoogleAdSense] - 10https://gerrit.wikimedia.org/r/503692 (https://phabricator.wikimedia.org/T220896) (owner: 10Zoranzoki21) [08:19:46] (03Merged) 10jenkins-bot: Delete FilterSpecialPages.setup.php [extensions/FilterSpecialPages] - 10https://gerrit.wikimedia.org/r/560813 (owner: 10Zoranzoki21) [08:20:10] (03Merged) 10jenkins-bot: Add phpcs [extensions/CharRangeSpan] - 10https://gerrit.wikimedia.org/r/560797 (owner: 10Zoranzoki21) [08:21:27] (03Merged) 10jenkins-bot: Convert GoogleAdSense to use extension registration [extensions/GoogleAdSense] - 10https://gerrit.wikimedia.org/r/503692 (https://phabricator.wikimedia.org/T220896) (owner: 10Zoranzoki21) [08:22:12] (03CR) 10Legoktm: [V: 03+2 C: 03+2] Remove RecentActivityFeed extension [extensions] - 10https://gerrit.wikimedia.org/r/560873 (https://phabricator.wikimedia.org/T241032) (owner: 10Zoranzoki21) [08:23:51] 10MediaWiki-extensions-GoogleAdSense, 10Patch-For-Review, 10User-Zoranzoki21: Convert GoogleAdSense to use extension registration - https://phabricator.wikimedia.org/T220896 (10Zoranzoki21) 05Open→03Resolved [08:23:54] 10MediaWiki-Configuration, 10MediaWiki-extensions-General, 10Goal, 10Google-Code-in-2019, 10User-Zoranzoki21: Convert all extensions and skins on gerrit to use extension registration - https://phabricator.wikimedia.org/T98668 (10Zoranzoki21) [08:24:08] 10LibUp: Add README to labs/libraryupgrader/config - https://phabricator.wikimedia.org/T229132 (10Legoktm) 05Open→03Resolved [08:25:55] 10MediaWiki-extensions-SecureLinkFixer, 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17): Add sanity check test for SecureLinkFixer's domains.php - https://phabricator.wikimedia.org/T240743 (10Legoktm) 05Open→03Resolved [08:25:57] 10MediaWiki-extensions-SecureLinkFixer, 10Gerrit-Privilege-Requests: SLF bot should have +2 rights and automatically merge own patches - https://phabricator.wikimedia.org/T239005 (10Legoktm) [08:28:02] (03PS1) 10Zoranzoki21: Split classes into their own file [extensions/GlobalContribs] - 10https://gerrit.wikimedia.org/r/560876 [08:30:35] (03PS3) 10Zoranzoki21: Add phpcs and make it pass [extensions/GlobalContribs] - 10https://gerrit.wikimedia.org/r/560819 [08:31:09] (03CR) 10Zoranzoki21: "Patch for classes https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/GlobalContribs/+/560876/1" [extensions/GlobalContribs] - 10https://gerrit.wikimedia.org/r/560819 (owner: 10Zoranzoki21) [08:32:40] (03PS1) 10Zoranzoki21: Fix syntax of extension.json [extensions/GoogleAdSense] - 10https://gerrit.wikimedia.org/r/560877 [08:34:04] (03PS2) 10Zoranzoki21: Fix syntax of extension.json [extensions/GoogleAdSense] - 10https://gerrit.wikimedia.org/r/560877 [08:42:49] 10Wikimedia-Site-requests: Remove old user groups from Wikimedia wikis (afttest, afttest-hide, etc.) - https://phabricator.wikimedia.org/T105570 (10DannyS712) >>! In T105570#3986798, @MarcoAurelio wrote: > Those need to be removed via SQL. emptyUserGroup.php should do the trick? [08:45:58] 10MediaWiki-extensions-RecentActivityFeed, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, and 3 others: Archive the RecentActivityFeed extension - https://phabricator.wikimedia.org/T241032 (10Zoranzoki21) [08:53:40] 10MediaWiki-extensions-WikibaseClient, 10Math, 10Wikidata, 10User-DannyS712: Don't list Special:MathWikibase if Wikibase is unavailable - https://phabricator.wikimedia.org/T241507 (10DannyS712) [08:54:10] (03PS1) 10DannyS712: Don't list Special:MathWikibase if the wikibase client isn't loaded [extensions/Math] - 10https://gerrit.wikimedia.org/r/560878 (https://phabricator.wikimedia.org/T241507) [08:59:39] 10MediaWiki-extensions-WikibaseClient, 10Math, 10Wikidata, 10Patch-For-Review, 10User-DannyS712: Don't list Special:MathWikibase if Wikibase client is unavailable - https://phabricator.wikimedia.org/T241507 (10DannyS712) [09:01:01] (03PS2) 10DannyS712: Don't list Special:MathWikibase if the wikibase client isn't loaded [extensions/Math] - 10https://gerrit.wikimedia.org/r/560878 (https://phabricator.wikimedia.org/T241507) [09:02:33] (03CR) 10jerkins-bot: [V: 04-1] Don't list Special:MathWikibase if the wikibase client isn't loaded [extensions/Math] - 10https://gerrit.wikimedia.org/r/560878 (https://phabricator.wikimedia.org/T241507) (owner: 10DannyS712) [09:06:50] (03PS3) 10DannyS712: Don't list Special:MathWikibase if the wikibase client isn't loaded [extensions/Math] - 10https://gerrit.wikimedia.org/r/560878 (https://phabricator.wikimedia.org/T241507) [09:15:19] (03Abandoned) 10Zoranzoki21: New version 1.2 [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [09:21:04] 10Timeless: Graphic bug on template documentation - https://phabricator.wikimedia.org/T241508 (10Roumpf) [09:26:56] (03PS1) 10Zoranzoki21: build: Replace jshint/jsonlint with eslint [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/560879 (https://phabricator.wikimedia.org/T210365) [09:27:17] (03PS1) 10DannyS712: HTMLForm: Fix grammar of class description [core] - 10https://gerrit.wikimedia.org/r/560880 [09:27:39] (03PS2) 10DannyS712: HTMLForm: Fix grammar of class description [core] - 10https://gerrit.wikimedia.org/r/560880 [09:29:39] (03PS2) 10Zoranzoki21: build: Replace jshint/jsonlint with eslint [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/560879 (https://phabricator.wikimedia.org/T210365) [09:32:21] (03PS3) 10DannyS712: Fix `user_former_groups` description of autopromotion [core] - 10https://gerrit.wikimedia.org/r/552600 [09:33:03] 10Magnus Sälgö: Europeana Entity <-> Wikidata Property 7704 - https://phabricator.wikimedia.org/T240290 (10Salgo60) [09:34:41] 10Timeless: Graphic bug on template documentation - https://phabricator.wikimedia.org/T241508 (10DannyS712) [09:35:12] (03PS2) 10Ammarpad: Convert SiteMatrix extension.json to manifest_version 2 [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/560866 (https://phabricator.wikimedia.org/T241205) (owner: 10Zoranzoki21) [09:41:44] 10MediaWiki-extensions-GoogleAdSense: [Google Adsense] Allow to pause ad delivery as long as the user was asked for consent - https://phabricator.wikimedia.org/T199037 (10Zoranzoki21) >>! In T199037#4913592, @Liuxinyu970226 wrote: > This extension seems [[https://www.mediawiki.org/wiki/Extension:Google_Adsense|a... [09:45:01] (03CR) 10jerkins-bot: [V: 04-1] Convert SiteMatrix extension.json to manifest_version 2 [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/560866 (https://phabricator.wikimedia.org/T241205) (owner: 10Zoranzoki21) [09:49:23] 10Timeless: Graphic bug on template documentation - https://phabricator.wikimedia.org/T241508 (10DannyS712) Cause by css rules in [screen-commone.less](https://gerrit.wikimedia.org/g/mediawiki/skins/Timeless/+/73438f40183d4e63d10d0ce86b03af725d75f2b6/resources/screen-common.less) and [VisualEditor.article.less](... [09:52:15] (03PS1) 10Zoranzoki21: build: Replace jshint/jsonlint with eslint [extensions/GoogleAdSense] - 10https://gerrit.wikimedia.org/r/560881 (https://phabricator.wikimedia.org/T210365) [09:54:05] (03PS3) 10Ammarpad: Convert SiteMatrix extension.json to manifest_version 2 [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/560866 (https://phabricator.wikimedia.org/T241205) (owner: 10Zoranzoki21) [10:03:05] (03PS4) 10Ammarpad: Convert SiteMatrix extension.json to manifest_version 2 [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/560866 (https://phabricator.wikimedia.org/T241205) (owner: 10Zoranzoki21) [10:05:03] (03CR) 10Reedy: Don't list Special:MathWikibase if the wikibase client isn't loaded (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/560878 (https://phabricator.wikimedia.org/T241507) (owner: 10DannyS712) [10:10:29] (03PS1) 10Zoranzoki21: Add option for changing language and encoding of ads [extensions/GoogleAdSense] - 10https://gerrit.wikimedia.org/r/560882 [10:12:29] (03CR) 10Reedy: "It's also curious there at all" [extensions/Math] - 10https://gerrit.wikimedia.org/r/560878 (https://phabricator.wikimedia.org/T241507) (owner: 10DannyS712) [10:14:47] (03CR) 10DannyS712: "> It's also curious there at all" (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/560878 (https://phabricator.wikimedia.org/T241507) (owner: 10DannyS712) [10:18:12] (03CR) 10Reedy: "It kinda sounds like it was never supposed to be listed based on the previously copied PHP code. Or, the use of "invisible" isn't exactly " [extensions/Math] - 10https://gerrit.wikimedia.org/r/560878 (https://phabricator.wikimedia.org/T241507) (owner: 10DannyS712) [10:20:41] (03CR) 10DannyS712: "> It kinda sounds like it was never supposed to be listed based on" [extensions/Math] - 10https://gerrit.wikimedia.org/r/560878 (https://phabricator.wikimedia.org/T241507) (owner: 10DannyS712) [10:23:32] (03PS1) 10DannyS712: Replace `@return true|false` with `@return bool` [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/560883 [10:23:50] (03PS2) 10DannyS712: Replace `@return true|false` with `@return bool` [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/560883 [10:25:12] (03PS1) 10DannyS712: Replace `@param string[]|true|false` with `@param string[]|bool` [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/560884 [10:25:40] (03PS2) 10DannyS712: Replace `@param string[]|true|false` with `@param string[]|bool` [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/560884 [10:28:03] (03PS1) 10DannyS712: Replace `@return sdtClass|true|false|null` with `@return sdtClass|bool|null` [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/560885 [10:28:18] (03PS2) 10DannyS712: Replace `@return sdtClass|true|false|null` with `@return sdtClass|bool|null` [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/560885 [10:29:06] (03PS1) 10DannyS712: Replace `@return true|false` with `@return bool` [extensions/Math] - 10https://gerrit.wikimedia.org/r/560886 [10:29:16] lol [10:29:21] (03PS2) 10DannyS712: Replace `@return true|false` with `@return bool` [extensions/Math] - 10https://gerrit.wikimedia.org/r/560886 [10:30:42] (03CR) 10DannyS712: "> [...]" [extensions/Math] - 10https://gerrit.wikimedia.org/r/560878 (https://phabricator.wikimedia.org/T241507) (owner: 10DannyS712) [10:33:25] (03CR) 10Siebrand: [C: 03+2] Fix syntax of extension.json [extensions/GoogleAdSense] - 10https://gerrit.wikimedia.org/r/560877 (owner: 10Zoranzoki21) [10:34:31] (03CR) 10Siebrand: [C: 03+2] Add option for changing language and encoding of ads [extensions/GoogleAdSense] - 10https://gerrit.wikimedia.org/r/560882 (owner: 10Zoranzoki21) [10:34:52] (03CR) 10Siebrand: [C: 03+2] build: Replace jshint/jsonlint with eslint [extensions/GoogleAdSense] - 10https://gerrit.wikimedia.org/r/560881 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [10:36:32] (03Merged) 10jenkins-bot: Fix syntax of extension.json [extensions/GoogleAdSense] - 10https://gerrit.wikimedia.org/r/560877 (owner: 10Zoranzoki21) [10:38:11] (03Merged) 10jenkins-bot: build: Replace jshint/jsonlint with eslint [extensions/GoogleAdSense] - 10https://gerrit.wikimedia.org/r/560881 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [10:38:13] (03Merged) 10jenkins-bot: Add option for changing language and encoding of ads [extensions/GoogleAdSense] - 10https://gerrit.wikimedia.org/r/560882 (owner: 10Zoranzoki21) [10:40:38] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/560884 (owner: 10DannyS712) [10:44:47] (03CR) 10DannyS712: [C: 03+1] Convert SiteMatrix extension.json to manifest_version 2 [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/560866 (https://phabricator.wikimedia.org/T241205) (owner: 10Zoranzoki21) [10:45:28] (03CR) 10Physikerwelt: "Thank you. Sorry that we did not implement that in the first place." (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/560878 (https://phabricator.wikimedia.org/T241507) (owner: 10DannyS712) [10:45:55] (03CR) 10DannyS712: [C: 03+1] Add phpcs and make it pass [extensions/GlobalContribs] - 10https://gerrit.wikimedia.org/r/560819 (owner: 10Zoranzoki21) [10:46:15] (03CR) 10DannyS712: [C: 03+1] Add phpcs [extensions/ContributionCredits] - 10https://gerrit.wikimedia.org/r/560798 (owner: 10Zoranzoki21) [10:46:24] (03CR) 10Siebrand: "Is there a convention that requires updating the minimal version of MediaWiki supported (https://www.mediawiki.org/wiki/Manual:Extension.j" [extensions/ChangeUserPasswords] - 10https://gerrit.wikimedia.org/r/555583 (https://phabricator.wikimedia.org/T140007) (owner: 10Zoranzoki21) [10:46:41] 10MediaWiki-extensions-WikibaseClient, 10Math, 10Wikidata, 10Patch-For-Review, 10User-DannyS712: Don't list Special:MathWikibase if Wikibase client is unavailable - https://phabricator.wikimedia.org/T241507 (10Physikerwelt) p:05Triage→03Normal [10:47:09] (03CR) 10DannyS712: [C: 03+1] Add phpcs and make it pass [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/560815 (owner: 10Zoranzoki21) [10:48:07] (03CR) 10Siebrand: [C: 03+2] Add phpcs [extensions/ContributionCredits] - 10https://gerrit.wikimedia.org/r/560798 (owner: 10Zoranzoki21) [10:48:40] (03CR) 10Siebrand: [C: 03+2] Add phpcs and make it pass [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/560815 (owner: 10Zoranzoki21) [10:48:42] (03CR) 10Reedy: [C: 03+2] Replace `@return true|false` with `@return bool` [extensions/Math] - 10https://gerrit.wikimedia.org/r/560886 (owner: 10DannyS712) [10:49:58] (03CR) 10DannyS712: Don't list Special:MathWikibase if the wikibase client isn't loaded (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/560878 (https://phabricator.wikimedia.org/T241507) (owner: 10DannyS712) [10:50:00] (03CR) 10Siebrand: "Does a manifest version update require an extension version update in extension.json?" [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/560866 (https://phabricator.wikimedia.org/T241205) (owner: 10Zoranzoki21) [10:50:28] 10Gerrit-Privilege-Requests: +2 for Zoranzoki21 in mediawiki/extensions/GoogleAdSense - https://phabricator.wikimedia.org/T241509 (10Zoranzoki21) [10:50:38] 10Gerrit-Privilege-Requests: +2 for Zoranzoki21 in mediawiki/extensions/GoogleAdSense - https://phabricator.wikimedia.org/T241509 (10Zoranzoki21) [10:50:52] (03CR) 10Samwilson: "The PhanSuspiciousValueComparison failure here is due to a bug that's been fixed: https://github.com/phan/phan/issues/3605" [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/560865 (owner: 10Samwilson) [10:51:15] (03Merged) 10jenkins-bot: Add phpcs [extensions/ContributionCredits] - 10https://gerrit.wikimedia.org/r/560798 (owner: 10Zoranzoki21) [10:51:17] (03Merged) 10jenkins-bot: Add phpcs and make it pass [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/560815 (owner: 10Zoranzoki21) [10:51:37] (03CR) 10Siebrand: [C: 03+2] Add aliases for Serbian language [extensions/RandomInCategory] - 10https://gerrit.wikimedia.org/r/560593 (https://phabricator.wikimedia.org/T212586) (owner: 10Zoranzoki21) [10:53:12] (03CR) 10Siebrand: "recheck" [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/560569 (owner: 10Zoranzoki21) [10:53:22] (03PS3) 10Zoranzoki21: Remove PHP entry point [extensions/ChangeUserPasswords] - 10https://gerrit.wikimedia.org/r/555583 (https://phabricator.wikimedia.org/T140007) [10:53:27] (03PS4) 10Zoranzoki21: Remove PHP entry point [extensions/ChangeUserPasswords] - 10https://gerrit.wikimedia.org/r/555583 (https://phabricator.wikimedia.org/T140007) [10:53:49] (03CR) 10Zoranzoki21: "> Is there a convention that requires updating the minimal version of" [extensions/ChangeUserPasswords] - 10https://gerrit.wikimedia.org/r/555583 (https://phabricator.wikimedia.org/T140007) (owner: 10Zoranzoki21) [10:53:54] (03CR) 10Siebrand: [C: 03+2] Add aliases for Serbian language [extensions/WebChat] - 10https://gerrit.wikimedia.org/r/560600 (https://phabricator.wikimedia.org/T212586) (owner: 10Zoranzoki21) [10:54:37] (03CR) 10Zoranzoki21: "> recheck" [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/560569 (owner: 10Zoranzoki21) [10:54:53] (03CR) 10Reedy: "version 2 has been around since 1.29 (so older than current LTS)" [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/560866 (https://phabricator.wikimedia.org/T241205) (owner: 10Zoranzoki21) [10:56:15] (03CR) 10Siebrand: "Hmm... Why?" [extensions/WebChat] - 10https://gerrit.wikimedia.org/r/560599 (owner: 10Zoranzoki21) [10:57:23] (03CR) 10Siebrand: [C: 03+2] Remove PHP entry point [extensions/ChangeUserPasswords] - 10https://gerrit.wikimedia.org/r/555583 (https://phabricator.wikimedia.org/T140007) (owner: 10Zoranzoki21) [10:58:02] (03CR) 10Zoranzoki21: "> Hmm... Why?" [extensions/WebChat] - 10https://gerrit.wikimedia.org/r/560599 (owner: 10Zoranzoki21) [10:58:20] (03CR) 10Siebrand: [C: 03+2] "Thanks, Sam." [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/560866 (https://phabricator.wikimedia.org/T241205) (owner: 10Zoranzoki21) [10:59:01] (03CR) 10Siebrand: [C: 03+2] "No idea why Jenkins isn't picking this up." [extensions/WebChat] - 10https://gerrit.wikimedia.org/r/560600 (https://phabricator.wikimedia.org/T212586) (owner: 10Zoranzoki21) [10:59:09] (03CR) 10Siebrand: [C: 03+2] "recheck" [extensions/WebChat] - 10https://gerrit.wikimedia.org/r/560600 (https://phabricator.wikimedia.org/T212586) (owner: 10Zoranzoki21) [10:59:55] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/560884 (owner: 10DannyS712) [11:00:03] (03CR) 10Zoranzoki21: "> recheck" [extensions/WebChat] - 10https://gerrit.wikimedia.org/r/560600 (https://phabricator.wikimedia.org/T212586) (owner: 10Zoranzoki21) [11:03:14] (03CR) 10Siebrand: "Special page alias are not exposed anywhere. They're only URL prettification. So the first alias for a language makes up the special page " [extensions/WebChat] - 10https://gerrit.wikimedia.org/r/560599 (owner: 10Zoranzoki21) [11:03:39] (03CR) 10Zoranzoki21: "> Special page alias are not exposed anywhere. They're only URL" [extensions/WebChat] - 10https://gerrit.wikimedia.org/r/560599 (owner: 10Zoranzoki21) [11:03:48] (03Abandoned) 10Zoranzoki21: Add more aliases for English and remove it from other languages [extensions/WebChat] - 10https://gerrit.wikimedia.org/r/560599 (owner: 10Zoranzoki21) [11:03:58] (03PS3) 10Zoranzoki21: Add aliases for Serbian language [extensions/WebChat] - 10https://gerrit.wikimedia.org/r/560600 (https://phabricator.wikimedia.org/T212586) [11:04:37] (03CR) 10Zoranzoki21: "This is bad romantic, Zuul no starts gate-and-submit when rebasing...." [extensions/WebChat] - 10https://gerrit.wikimedia.org/r/560600 (https://phabricator.wikimedia.org/T212586) (owner: 10Zoranzoki21) [11:07:03] 10MediaWiki-extensions-General, 10I18n, 10MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), and 2 others: Add Serbian aliases at extensions/skins (tracking) - https://phabricator.wikimedia.org/T212586 (10Zoranzoki21) 05Open→03Resolved Can be closed as resolved. [11:07:12] 10Gerrit-Privilege-Requests: +2 for Zoranzoki21 in mediawiki/extensions/GoogleAdSense - https://phabricator.wikimedia.org/T241509 (10siebrand) As registered extension author, I approve this request. [11:08:44] (03CR) 10Siebrand: [C: 03+2] "@hashar: Any idea why this is not being picked up?" [extensions/WebChat] - 10https://gerrit.wikimedia.org/r/560600 (https://phabricator.wikimedia.org/T212586) (owner: 10Zoranzoki21) [11:09:57] (03CR) 10Zoranzoki21: "> @hashar: Any idea why this is not being picked up?" [extensions/WebChat] - 10https://gerrit.wikimedia.org/r/560600 (https://phabricator.wikimedia.org/T212586) (owner: 10Zoranzoki21) [11:12:44] (03CR) 10Siebrand: "Are the file path changes (moving files to resources/) a requirement of this change? If not, it would probably be better to split this int" [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/560879 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [11:13:37] 10MediaWiki-extensions-LiquidThreads, 10MediaWiki-extensions-Maintenance, 10MediaWiki-extensions-UserMerge, 10MediaWiki-extensions-WikibaseClient, and 7 others: Remove uses of Title::moveTo - https://phabricator.wikimedia.org/T221949 (10Aklapper) [11:16:02] (03CR) 10Zoranzoki21: "> Are the file path changes (moving files to resources/) a" [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/560879 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [11:16:27] (03CR) 10Siebrand: [C: 04-1] "This certainly needs a version update in extension.json." [extensions/GlobalContribs] - 10https://gerrit.wikimedia.org/r/560876 (owner: 10Zoranzoki21) [11:17:06] (03CR) 10Zoranzoki21: "> This certainly needs a version update in extension.json." [extensions/GlobalContribs] - 10https://gerrit.wikimedia.org/r/560876 (owner: 10Zoranzoki21) [11:17:31] (03CR) 10Siebrand: [C: 03+1] Archive RecentActivityFeed extension [extensions/RecentActivityFeed] - 10https://gerrit.wikimedia.org/r/560875 (https://phabricator.wikimedia.org/T241032) (owner: 10Zoranzoki21) [11:19:54] (03CR) 10Physikerwelt: [C: 03+1] Don't list Special:MathWikibase if the wikibase client isn't loaded (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/560878 (https://phabricator.wikimedia.org/T241507) (owner: 10DannyS712) [11:20:07] 10MediaWiki-extensions-Graph: wikiraw: protocal ignore $wgScriptPath - https://phabricator.wikimedia.org/T241479 (10Aklapper) 05Open→03Stalled @TheEndOfKeyHighSchool: Hi, can you please explain what does this have to do with #MediaWiki-extensions-Graph ? Also, can you please correct the backticks in task des... [11:21:06] (03CR) 10Siebrand: [C: 03+2] build: Replace jshint/jsonlint with eslint [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/560879 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [11:21:29] (03CR) 10Zoranzoki21: [C: 04-1] "I'll split this into a few patches." [extensions/EmailCapture] - 10https://gerrit.wikimedia.org/r/560811 (https://phabricator.wikimedia.org/T220036) (owner: 10Zoranzoki21) [11:24:11] (03CR) 10Siebrand: [C: 03+2] Add phpcs and make it pass [extensions/GoogleAnalyticsTopPages] - 10https://gerrit.wikimedia.org/r/560870 (owner: 10Zoranzoki21) [11:25:09] (03Merged) 10jenkins-bot: Replace `@return true|false` with `@return bool` [extensions/Math] - 10https://gerrit.wikimedia.org/r/560886 (owner: 10DannyS712) [11:25:11] (03Merged) 10jenkins-bot: Add aliases for Serbian language [extensions/RandomInCategory] - 10https://gerrit.wikimedia.org/r/560593 (https://phabricator.wikimedia.org/T212586) (owner: 10Zoranzoki21) [11:25:13] (03Merged) 10jenkins-bot: Remove PHP entry point [extensions/ChangeUserPasswords] - 10https://gerrit.wikimedia.org/r/555583 (https://phabricator.wikimedia.org/T140007) (owner: 10Zoranzoki21) [11:25:15] (03Merged) 10jenkins-bot: Convert SiteMatrix extension.json to manifest_version 2 [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/560866 (https://phabricator.wikimedia.org/T241205) (owner: 10Zoranzoki21) [11:25:17] (03Merged) 10jenkins-bot: Add aliases for Serbian language [extensions/WebChat] - 10https://gerrit.wikimedia.org/r/560600 (https://phabricator.wikimedia.org/T212586) (owner: 10Zoranzoki21) [11:25:19] (03Merged) 10jenkins-bot: build: Replace jshint/jsonlint with eslint [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/560879 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [11:26:07] (03PS7) 10Zoranzoki21: Convert GoogleAppEngine to use extension registration [extensions/GoogleAppEngine] - 10https://gerrit.wikimedia.org/r/460740 (https://phabricator.wikimedia.org/T204213) [11:27:14] (03CR) 10jerkins-bot: [V: 04-1] Convert GoogleAppEngine to use extension registration [extensions/GoogleAppEngine] - 10https://gerrit.wikimedia.org/r/460740 (https://phabricator.wikimedia.org/T204213) (owner: 10Zoranzoki21) [11:27:18] (03Merged) 10jenkins-bot: Add phpcs and make it pass [extensions/GoogleAnalyticsTopPages] - 10https://gerrit.wikimedia.org/r/560870 (owner: 10Zoranzoki21) [11:28:16] 10MediaWiki-extensions-General, 10Google-Code-in-2019, 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), and 2 others: Update extension.json files to manifest_version 2 to use description instead of @globalname documentation - https://phabricator.wikimedia.org/T234114... [11:31:21] (03CR) 10Siebrand: "recheck" [extensions/FilterSpecialPages] - 10https://gerrit.wikimedia.org/r/560814 (owner: 10Zoranzoki21) [11:33:16] (03CR) 10Siebrand: [C: 03+2] Add phpcs [extensions/CreateUserPage] - 10https://gerrit.wikimedia.org/r/560801 (owner: 10Zoranzoki21) [11:34:06] (03CR) 10Siebrand: [C: 03+2] Add phpcs and make it pass [extensions/FilterListUsers] - 10https://gerrit.wikimedia.org/r/560812 (owner: 10Zoranzoki21) [11:36:22] (03Merged) 10jenkins-bot: Add phpcs [extensions/CreateUserPage] - 10https://gerrit.wikimedia.org/r/560801 (owner: 10Zoranzoki21) [11:37:07] (03Merged) 10jenkins-bot: Add phpcs and make it pass [extensions/FilterListUsers] - 10https://gerrit.wikimedia.org/r/560812 (owner: 10Zoranzoki21) [11:38:56] (03CR) 10Acamicamacaraca: "Also, create file like "resources/lib/jquery.i18n/src/languages/bs.js"" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/533544 (https://phabricator.wikimedia.org/T35546) (owner: 10Zoranzoki21) [11:39:36] (03CR) 10Siebrand: [C: 03+2] Add phpcs and make it pass [extensions/GlobalUserrights] - 10https://gerrit.wikimedia.org/r/560821 (owner: 10Zoranzoki21) [11:40:58] (03PS1) 10Zoranzoki21: build: Add mediawiki/mediawiki-codesniffer [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560889 [11:41:00] (03PS1) 10Zoranzoki21: Autofixing Generic.Arrays.DisallowLongArraySyntax.Found errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560890 [11:41:02] (03PS1) 10Zoranzoki21: Autofixing Generic.Functions.* errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560891 [11:41:04] (03PS1) 10Zoranzoki21: Autofixing MediaWiki.ControlStructures.IfElseStructure.SpaceBeforeElse errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560892 [11:41:06] (03PS1) 10Zoranzoki21: Autofixing MediaWiki.WhiteSpace.* errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560893 [11:41:08] (03PS1) 10Zoranzoki21: Autofixing PSR2.ControlStructures.ElseIfDeclaration.NotAllowed errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560894 [11:41:10] (03PS1) 10Zoranzoki21: Autofixing PSR2.Files.EndFileNewline.NoneFound errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560895 [11:41:12] (03PS1) 10Zoranzoki21: Autofixing PSR2.Methods.FunctionClosingBrace.SpacingBeforeClose errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560896 [11:41:14] (03PS1) 10Zoranzoki21: Autofixing PSR2.Namespaces.NamespaceDeclaration.BlankLineAfter errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560897 [11:41:16] (03PS1) 10Zoranzoki21: Autofixing Squiz.Functions.* errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560898 [11:41:18] (03PS1) 10Zoranzoki21: Autofixing Squiz.Strings.ConcatenationSpacing.PaddingFound errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560899 [11:41:27] (03PS2) 10Zoranzoki21: build: Add mediawiki/mediawiki-codesniffer [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560889 [11:41:57] (03CR) 10Zoranzoki21: "Done with script of Legoktm :)." [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560889 (owner: 10Zoranzoki21) [11:42:03] (03CR) 10Siebrand: [C: 04-1] "Looks like Jenkins is finding somethign wrong here." [extensions/FilterSpecialPages] - 10https://gerrit.wikimedia.org/r/560814 (owner: 10Zoranzoki21) [11:42:36] (03CR) 10Zoranzoki21: "> Looks like Jenkins is finding somethign wrong here." [extensions/FilterSpecialPages] - 10https://gerrit.wikimedia.org/r/560814 (owner: 10Zoranzoki21) [11:42:42] (03Merged) 10jenkins-bot: Add phpcs and make it pass [extensions/GlobalUserrights] - 10https://gerrit.wikimedia.org/r/560821 (owner: 10Zoranzoki21) [11:42:46] (03CR) 10Siebrand: [C: 04-1] "Looks like Jenkins is finding something wrong here." [extensions/GoogleAppEngine] - 10https://gerrit.wikimedia.org/r/460740 (https://phabricator.wikimedia.org/T204213) (owner: 10Zoranzoki21) [11:43:50] (03CR) 10Siebrand: [C: 03+2] Autofixing Squiz.Strings.ConcatenationSpacing.PaddingFound errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560899 (owner: 10Zoranzoki21) [11:46:25] (03CR) 10Siebrand: [C: 03+2] Autofixing PSR2.Namespaces.NamespaceDeclaration.BlankLineAfter errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560897 (owner: 10Zoranzoki21) [11:46:28] (03CR) 10Siebrand: [C: 03+2] Autofixing Squiz.Functions.* errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560898 (owner: 10Zoranzoki21) [11:46:41] (03CR) 10Siebrand: [C: 03+2] Autofixing Generic.Functions.* errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560891 (owner: 10Zoranzoki21) [11:46:54] (03CR) 10Siebrand: [C: 03+2] Autofixing PSR2.ControlStructures.ElseIfDeclaration.NotAllowed errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560894 (owner: 10Zoranzoki21) [11:47:05] (03CR) 10Zoranzoki21: "> Looks like Jenkins is finding something wrong here." [extensions/GoogleAppEngine] - 10https://gerrit.wikimedia.org/r/460740 (https://phabricator.wikimedia.org/T204213) (owner: 10Zoranzoki21) [11:47:22] (03CR) 10Siebrand: [C: 03+2] Autofixing PSR2.Files.EndFileNewline.NoneFound errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560895 (owner: 10Zoranzoki21) [11:47:32] (03CR) 10Siebrand: [C: 03+2] Autofixing Generic.Arrays.DisallowLongArraySyntax.Found errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560890 (owner: 10Zoranzoki21) [11:47:54] (03CR) 10Siebrand: [C: 03+2] Autofixing MediaWiki.WhiteSpace.* errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560893 (owner: 10Zoranzoki21) [11:48:01] (03CR) 10Siebrand: [C: 03+2] Autofixing MediaWiki.ControlStructures.IfElseStructure.SpaceBeforeElse errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560892 (owner: 10Zoranzoki21) [11:48:17] (03CR) 10Siebrand: [C: 03+2] Autofixing PSR2.Methods.FunctionClosingBrace.SpacingBeforeClose errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560896 (owner: 10Zoranzoki21) [11:48:38] (03CR) 10Siebrand: [C: 03+2] build: Add mediawiki/mediawiki-codesniffer [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560889 (owner: 10Zoranzoki21) [11:50:43] (03Merged) 10jenkins-bot: build: Add mediawiki/mediawiki-codesniffer [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560889 (owner: 10Zoranzoki21) [11:51:58] (03CR) 10Siebrand: [C: 04-1] "Would be good to reply to Thiemo's concerns here and get some consensus. Possible take this wides, and add to code conventions." [extensions/DeviceMapLogCapture] - 10https://gerrit.wikimedia.org/r/560806 (owner: 10Zoranzoki21) [11:52:48] (03CR) 10Siebrand: [C: 04-1] "Per Ida7a8463070." [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/560805 (owner: 10Zoranzoki21) [11:53:59] (03CR) 10Siebrand: [C: 03+2] Add phpcs [extensions/CreateRedirect] - 10https://gerrit.wikimedia.org/r/560800 (owner: 10Zoranzoki21) [11:54:35] (03CR) 10Zoranzoki21: Add phpcs and fix errors found by it (031 comment) [extensions/DeviceMapLogCapture] - 10https://gerrit.wikimedia.org/r/560806 (owner: 10Zoranzoki21) [11:54:51] 10Wikimedia-Site-requests: Remove old user groups from Wikimedia wikis (afttest, afttest-hide, etc.) - https://phabricator.wikimedia.org/T105570 (10MarcoAurelio) >>! In T105570#5765029, @DannyS712 wrote: >>>! In T105570#3986798, @MarcoAurelio wrote: >> Those need to be removed via SQL. > > emptyUserGroup.php sh... [11:55:02] (03CR) 10Siebrand: [C: 03+2] Add phpcs and make it pass [extensions/GlobalContributions] - 10https://gerrit.wikimedia.org/r/560820 (owner: 10Zoranzoki21) [11:55:34] (03CR) 10Siebrand: [C: 04-1] "Please address open comment." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/560572 (owner: 10Zoranzoki21) [11:55:54] (03CR) 10Siebrand: [C: 03+2] build: Upgrade grunt-jsonlint from 1.0.7 to 2.0.0 [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/560338 (owner: 10Zoranzoki21) [11:56:34] (03CR) 10Zoranzoki21: Add phpcs and fix errors found by it (031 comment) [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/560805 (owner: 10Zoranzoki21) [11:56:52] (03CR) 10Siebrand: [C: 03+2] build: Upgrade grunt-jsonlint from 1.0.7 to 2.0.0 [extensions/AddHTMLMetaAndTitle] - 10https://gerrit.wikimedia.org/r/560330 (owner: 10Zoranzoki21) [11:56:54] (03CR) 10Siebrand: [C: 03+2] build: Upgrade grunt-jsonlint from i.0.7 to 2.0.0 [extensions/AddMessages] - 10https://gerrit.wikimedia.org/r/560331 (owner: 10Zoranzoki21) [11:56:56] (03CR) 10Siebrand: [C: 03+2] build: Upgrade grunt-jsonlint from 1.0.7 to 2.0.0 [extensions/AddThis] - 10https://gerrit.wikimedia.org/r/560332 (owner: 10Zoranzoki21) [11:56:58] (03CR) 10Siebrand: [C: 03+2] build: Upgrade grunt-jsonlint from 1.0.7 to 2.0.0 [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/560334 (owner: 10Zoranzoki21) [11:57:08] (03CR) 10Siebrand: [C: 03+2] build: Upgrade grunt-jsonlint from 1.0.7 to 2.0.0 [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/560335 (owner: 10Zoranzoki21) [11:57:19] (03CR) 10Siebrand: [C: 03+2] build: Upgrade grunt-jsonlint from 1.0.7 to 2.0.0 [extensions/AllTimeZones] - 10https://gerrit.wikimedia.org/r/560336 (owner: 10Zoranzoki21) [11:57:26] (03CR) 10Siebrand: [V: 03+2 C: 03+2] build: Upgrade grunt-jsonlint from 1.0.7 to 2.0.0 [extensions/AllTimeZones] - 10https://gerrit.wikimedia.org/r/560336 (owner: 10Zoranzoki21) [11:57:32] (03PS2) 10Zoranzoki21: Autofixing Generic.Arrays.DisallowLongArraySyntax.Found errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560890 [11:57:36] (03CR) 10Siebrand: [C: 03+2] build: Upgrade grunt-jsonlint from 1.0.7 to 2.0.0 [extensions/AnchorHandler] - 10https://gerrit.wikimedia.org/r/560337 (owner: 10Zoranzoki21) [11:57:48] (03CR) 10Siebrand: [C: 03+2] build: Upgrade grunt-jsonlint from 1.0.7 to 2.0.0 [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/560329 (owner: 10Zoranzoki21) [11:58:01] (03CR) 10Siebrand: [V: 03+2 C: 03+2] build: Upgrade grunt-jsonlint from 1.0.7 to 2.0.0 [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/560329 (owner: 10Zoranzoki21) [11:58:09] (03Merged) 10jenkins-bot: Add phpcs and make it pass [extensions/GlobalContributions] - 10https://gerrit.wikimedia.org/r/560820 (owner: 10Zoranzoki21) [12:00:20] (03Abandoned) 10Zoranzoki21: Autofixing Squiz.Strings.ConcatenationSpacing.PaddingFound errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560899 (owner: 10Zoranzoki21) [12:00:24] (03Abandoned) 10Zoranzoki21: Autofixing PSR2.Namespaces.NamespaceDeclaration.BlankLineAfter errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560897 (owner: 10Zoranzoki21) [12:00:28] (03Abandoned) 10Zoranzoki21: Autofixing Squiz.Functions.* errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560898 (owner: 10Zoranzoki21) [12:00:31] (03Abandoned) 10Zoranzoki21: Autofixing Generic.Functions.* errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560891 (owner: 10Zoranzoki21) [12:00:33] (03Abandoned) 10Zoranzoki21: Autofixing PSR2.ControlStructures.ElseIfDeclaration.NotAllowed errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560894 (owner: 10Zoranzoki21) [12:00:36] (03Abandoned) 10Zoranzoki21: Autofixing PSR2.Files.EndFileNewline.NoneFound errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560895 (owner: 10Zoranzoki21) [12:00:42] (03Abandoned) 10Zoranzoki21: Autofixing MediaWiki.ControlStructures.IfElseStructure.SpaceBeforeElse errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560892 (owner: 10Zoranzoki21) [12:00:44] (03Abandoned) 10Zoranzoki21: Autofixing PSR2.Methods.FunctionClosingBrace.SpacingBeforeClose errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560896 (owner: 10Zoranzoki21) [12:00:46] (03Abandoned) 10Zoranzoki21: Autofixing Generic.Arrays.DisallowLongArraySyntax.Found errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560890 (owner: 10Zoranzoki21) [12:00:49] (03Abandoned) 10Zoranzoki21: Autofixing MediaWiki.WhiteSpace.* errors [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560893 (owner: 10Zoranzoki21) [12:01:25] (03Merged) 10jenkins-bot: build: Upgrade grunt-jsonlint from 1.0.7 to 2.0.0 [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/560338 (owner: 10Zoranzoki21) [12:01:27] (03Merged) 10jenkins-bot: build: Upgrade grunt-jsonlint from 1.0.7 to 2.0.0 [extensions/AddHTMLMetaAndTitle] - 10https://gerrit.wikimedia.org/r/560330 (owner: 10Zoranzoki21) [12:01:29] (03Merged) 10jenkins-bot: build: Upgrade grunt-jsonlint from i.0.7 to 2.0.0 [extensions/AddMessages] - 10https://gerrit.wikimedia.org/r/560331 (owner: 10Zoranzoki21) [12:01:31] (03Merged) 10jenkins-bot: build: Upgrade grunt-jsonlint from 1.0.7 to 2.0.0 [extensions/AddThis] - 10https://gerrit.wikimedia.org/r/560332 (owner: 10Zoranzoki21) [12:01:33] (03Merged) 10jenkins-bot: build: Upgrade grunt-jsonlint from 1.0.7 to 2.0.0 [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/560334 (owner: 10Zoranzoki21) [12:01:35] (03Merged) 10jenkins-bot: build: Upgrade grunt-jsonlint from 1.0.7 to 2.0.0 [extensions/AkismetKlik] - 10https://gerrit.wikimedia.org/r/560335 (owner: 10Zoranzoki21) [12:01:37] (03Merged) 10jenkins-bot: build: Upgrade grunt-jsonlint from 1.0.7 to 2.0.0 [extensions/AllTimeZones] - 10https://gerrit.wikimedia.org/r/560336 (owner: 10Zoranzoki21) [12:01:39] (03Merged) 10jenkins-bot: build: Upgrade grunt-jsonlint from 1.0.7 to 2.0.0 [extensions/AnchorHandler] - 10https://gerrit.wikimedia.org/r/560337 (owner: 10Zoranzoki21) [12:01:41] (03Merged) 10jenkins-bot: build: Upgrade grunt-jsonlint from 1.0.7 to 2.0.0 [extensions/AccountInfo] - 10https://gerrit.wikimedia.org/r/560329 (owner: 10Zoranzoki21) [12:02:07] (03CR) 10Zoranzoki21: "> Please address open comment." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/560572 (owner: 10Zoranzoki21) [12:04:36] (03CR) 10Siebrand: "If you're going to push a lot of similar changes for different repositories, please consider using a topic for those. That makes it easy t" [extensions/GoogleDocs4MW] - 10https://gerrit.wikimedia.org/r/560328 (owner: 10Zoranzoki21) [12:04:55] 10MediaWiki-extensions-CentralAuth, 10Beta-Cluster-Infrastructure, 10GlobalRename, 10User-DannyS712: Global renames aren't being processed on beta cluster - https://phabricator.wikimedia.org/T241294 (10MarcoAurelio) I performed a rename yesterday after various instances and services restarts, and other mai... [12:05:31] 10Magnus Sälgö: Europeana Entity <-> Wikidata Property 7704 - https://phabricator.wikimedia.org/T240290 (10Salgo60) [12:05:37] (03CR) 10Siebrand: [C: 03+2] build: Update grunt-jsonlint from 1.0.7 to 2.0.0 [extensions/GoogleDocs4MW] - 10https://gerrit.wikimedia.org/r/560328 (owner: 10Zoranzoki21) [12:06:09] (03PS1) 10Zoranzoki21: Fix some PHPCS errors/warnings [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560900 [12:07:03] (03CR) 10Siebrand: [C: 03+2] build: Replace jshint/jsonlint with eslint [extensions/Poll] - 10https://gerrit.wikimedia.org/r/560590 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [12:07:12] 10Magnus Sälgö: Europeana Entity <-> Wikidata Property 7704 - https://phabricator.wikimedia.org/T240290 (10Salgo60) [12:08:01] 10Magnus Sälgö: Europeana Entity <-> Wikidata Property 7704 - https://phabricator.wikimedia.org/T240290 (10Salgo60) [12:08:23] (03CR) 10Siebrand: [C: 04-1] Convert Poll to use extension registration (031 comment) [extensions/Poll] - 10https://gerrit.wikimedia.org/r/560585 (https://phabricator.wikimedia.org/T241449) (owner: 10Zoranzoki21) [12:08:38] (03Merged) 10jenkins-bot: build: Update grunt-jsonlint from 1.0.7 to 2.0.0 [extensions/GoogleDocs4MW] - 10https://gerrit.wikimedia.org/r/560328 (owner: 10Zoranzoki21) [12:08:45] (03PS4) 10Zoranzoki21: build: Replace jshint/jsonlint with eslint [extensions/Poll] - 10https://gerrit.wikimedia.org/r/560590 (https://phabricator.wikimedia.org/T210365) [12:08:58] (03CR) 10Siebrand: [C: 03+2] OfflineImportLexicon.alias.php: Remove redudant aliases, make use of short array syntax [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/560574 (owner: 10Zoranzoki21) [12:09:10] (03PS3) 10Zoranzoki21: Convert Poll to use extension registration [extensions/Poll] - 10https://gerrit.wikimedia.org/r/560585 (https://phabricator.wikimedia.org/T241449) [12:09:12] 10Magnus Sälgö: Check WD objects with more Europeana Entities - https://phabricator.wikimedia.org/T241363 (10Salgo60) [12:09:16] (03CR) 10jerkins-bot: [V: 04-1] build: Replace jshint/jsonlint with eslint [extensions/Poll] - 10https://gerrit.wikimedia.org/r/560590 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [12:09:18] (03CR) 10Zoranzoki21: ">" (031 comment) [extensions/Poll] - 10https://gerrit.wikimedia.org/r/560585 (https://phabricator.wikimedia.org/T241449) (owner: 10Zoranzoki21) [12:09:31] (03CR) 10Siebrand: [C: 04-2] "As explained elsewhere." [extensions/Form] - 10https://gerrit.wikimedia.org/r/560817 (owner: 10Zoranzoki21) [12:09:37] (03CR) 10Zoranzoki21: "Patch for extreg needs +2 too." [extensions/Poll] - 10https://gerrit.wikimedia.org/r/560590 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [12:09:42] 10Magnus Sälgö: Check WD objects with more Europeana Entities - https://phabricator.wikimedia.org/T241363 (10Salgo60) [12:10:11] 10Magnus Sälgö: Check WD objects with more Europeana Entities - https://phabricator.wikimedia.org/T241363 (10Salgo60) [12:11:11] (03CR) 10Siebrand: [C: 03+2] Move css and js files into the resources directory [extensions/DisqusTag] - 10https://gerrit.wikimedia.org/r/560808 (owner: 10Zoranzoki21) [12:11:37] (03CR) 10Zoranzoki21: "> As explained elsewhere." [extensions/Form] - 10https://gerrit.wikimedia.org/r/560817 (owner: 10Zoranzoki21) [12:11:59] (03Merged) 10jenkins-bot: OfflineImportLexicon.alias.php: Remove redudant aliases, make use of short array syntax [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/560574 (owner: 10Zoranzoki21) [12:12:01] (03PS4) 10Zoranzoki21: Convert Poll to use extension registration [extensions/Poll] - 10https://gerrit.wikimedia.org/r/560585 (https://phabricator.wikimedia.org/T241449) [12:12:22] (03CR) 10Siebrand: [C: 03+2] Convert Poll to use extension registration [extensions/Poll] - 10https://gerrit.wikimedia.org/r/560585 (https://phabricator.wikimedia.org/T241449) (owner: 10Zoranzoki21) [12:13:48] 10Magnus Sälgö: Europeana Entity <-> Wikidata Property 7704 - https://phabricator.wikimedia.org/T240290 (10Salgo60) [12:13:52] (03CR) 10Siebrand: [C: 03+2] Fix some PHPCS errors/warnings [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560900 (owner: 10Zoranzoki21) [12:14:05] (03CR) 10Siebrand: [C: 03+2] build: Replace jshint/jsonlint with eslint [extensions/CreateRedirect] - 10https://gerrit.wikimedia.org/r/560799 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [12:14:29] (03Merged) 10jenkins-bot: Move css and js files into the resources directory [extensions/DisqusTag] - 10https://gerrit.wikimedia.org/r/560808 (owner: 10Zoranzoki21) [12:14:35] 10MediaWiki-extensions-Other, 10User-Zoranzoki21: Convert GoogleCustomWikiSearch to use extension registration - https://phabricator.wikimedia.org/T241510 (10Zoranzoki21) [12:15:03] (03PS1) 10Zoranzoki21: Convert GoogleCustomWikiSearch to use extension registration [extensions/GoogleCustomWikiSearch] - 10https://gerrit.wikimedia.org/r/560902 (https://phabricator.wikimedia.org/T241510) [12:15:43] (03Merged) 10jenkins-bot: Convert Poll to use extension registration [extensions/Poll] - 10https://gerrit.wikimedia.org/r/560585 (https://phabricator.wikimedia.org/T241449) (owner: 10Zoranzoki21) [12:15:45] (03Merged) 10jenkins-bot: build: Replace jshint/jsonlint with eslint [extensions/Poll] - 10https://gerrit.wikimedia.org/r/560590 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [12:15:55] (03CR) 10Siebrand: [C: 03+2] Remove jshint and jscs [extensions/BaseHooks] - 10https://gerrit.wikimedia.org/r/560099 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [12:16:04] (03Merged) 10jenkins-bot: Fix some PHPCS errors/warnings [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/560900 (owner: 10Zoranzoki21) [12:16:37] (03CR) 10jerkins-bot: [V: 04-1] Convert GoogleCustomWikiSearch to use extension registration [extensions/GoogleCustomWikiSearch] - 10https://gerrit.wikimedia.org/r/560902 (https://phabricator.wikimedia.org/T241510) (owner: 10Zoranzoki21) [12:16:43] (03CR) 10Siebrand: [C: 03+2] build: Replace jshint with eslint [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/560097 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [12:16:59] 10MediaWiki-extensions-CentralAuth, 10Beta-Cluster-Infrastructure, 10GlobalRename, 10User-DannyS712: Global renames aren't being processed on beta cluster - https://phabricator.wikimedia.org/T241294 (10MarcoAurelio) Nah, it does not work: ` maurelio@deployment-deploy01:~$ mwscript extensions/CentralAuth/m... [12:17:24] (03Merged) 10jenkins-bot: build: Replace jshint/jsonlint with eslint [extensions/CreateRedirect] - 10https://gerrit.wikimedia.org/r/560799 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [12:17:26] (03Merged) 10jenkins-bot: Add phpcs [extensions/CreateRedirect] - 10https://gerrit.wikimedia.org/r/560800 (owner: 10Zoranzoki21) [12:17:28] (03PS1) 10Zoranzoki21: Remove GoogleCustomWikiSearch.settings.php file [extensions/GoogleCustomWikiSearch] - 10https://gerrit.wikimedia.org/r/560903 [12:18:58] (03Merged) 10jenkins-bot: Remove jshint and jscs [extensions/BaseHooks] - 10https://gerrit.wikimedia.org/r/560099 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [12:19:23] (03CR) 10jerkins-bot: [V: 04-1] Remove GoogleCustomWikiSearch.settings.php file [extensions/GoogleCustomWikiSearch] - 10https://gerrit.wikimedia.org/r/560903 (owner: 10Zoranzoki21) [12:19:45] (03Merged) 10jenkins-bot: build: Replace jshint with eslint [extensions/BiblioPlus] - 10https://gerrit.wikimedia.org/r/560097 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [12:20:02] (03PS2) 10Zoranzoki21: Convert GoogleCustomWikiSearch to use extension registration [extensions/GoogleCustomWikiSearch] - 10https://gerrit.wikimedia.org/r/560902 (https://phabricator.wikimedia.org/T241510) [12:20:09] (03PS3) 10Siebrand: Remove PHP entry point [extensions/CharRangeSpan] - 10https://gerrit.wikimedia.org/r/555582 (https://phabricator.wikimedia.org/T140007) (owner: 10Zoranzoki21) [12:21:56] (03CR) 10jerkins-bot: [V: 04-1] Convert GoogleCustomWikiSearch to use extension registration [extensions/GoogleCustomWikiSearch] - 10https://gerrit.wikimedia.org/r/560902 (https://phabricator.wikimedia.org/T241510) (owner: 10Zoranzoki21) [12:22:11] (03CR) 10Umherirrender: "check experimental" [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/560856 (owner: 10Umherirrender) [12:25:05] (03PS6) 10Daimona Eaytoy: Add site name and language variables [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/558567 (https://phabricator.wikimedia.org/T240948) [12:25:40] (03CR) 10Daimona Eaytoy: Add site name and language variables (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/558567 (https://phabricator.wikimedia.org/T240948) (owner: 10Daimona Eaytoy) [12:31:26] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/560140 (owner: 10Libraryupgrader) [12:31:52] (03PS1) 10Umherirrender: Split alias file for special page alias and magic word alias [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/560904 [12:33:36] (03CR) 10jerkins-bot: [V: 04-1] Split alias file for special page alias and magic word alias [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/560904 (owner: 10Umherirrender) [12:35:33] (03PS1) 10Umherirrender: Require MediaWiki 1.29 in extension.json for manifest_version 2 [extensions/XSL] - 10https://gerrit.wikimedia.org/r/560906 [12:43:29] (03PS1) 10Umherirrender: Require MediaWiki 1.29 in extension.json for manifest_version 2 [extensions/SiteSettings] - 10https://gerrit.wikimedia.org/r/560909 [12:44:15] (03PS1) 10Umherirrender: Require MediaWiki 1.31 in extension.json for AutoloadNamespaces [extensions/Popups] - 10https://gerrit.wikimedia.org/r/560910 [12:45:02] (03PS1) 10Umherirrender: Require MediaWiki 1.29 in extension.json for manifest_version 2 [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/560911 [12:49:04] (03PS1) 10Umherirrender: Fix ident in extension.json [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/560912 [12:50:29] (03PS1) 10Umherirrender: Require MediaWiki 1.31 in extension.json for AutoloadNamespaces [extensions/LDAPGroups] - 10https://gerrit.wikimedia.org/r/560913 [12:52:12] (03PS1) 10Umherirrender: Require MediaWiki 1.29 in extension.json for manifest_version 2 [extensions/InterwikiExtracts] - 10https://gerrit.wikimedia.org/r/560914 [12:56:20] (03PS1) 10Umherirrender: Fix name of desc message in extension.json [extensions/ProtectionIndicator] - 10https://gerrit.wikimedia.org/r/560915 [13:03:19] (03PS1) 10Umherirrender: Fix name of desc message in extension.json [extensions/EventStreamConfig] - 10https://gerrit.wikimedia.org/r/560916 [13:04:50] (03CR) 10Siebrand: [C: 03+2] Add aliases for Serbian latin script [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/560572 (owner: 10Zoranzoki21) [13:06:04] (03CR) 10Siebrand: [C: 04-1] Add phpcs and fix errors found by it (031 comment) [extensions/DeviceMapLogCapture] - 10https://gerrit.wikimedia.org/r/560806 (owner: 10Zoranzoki21) [13:06:29] (03CR) 10Siebrand: [C: 04-1] "recheck" [extensions/FilterSpecialPages] - 10https://gerrit.wikimedia.org/r/560814 (owner: 10Zoranzoki21) [13:07:46] (03CR) 10Siebrand: [C: 04-1] Fix name of desc message in extension.json (031 comment) [extensions/EventStreamConfig] - 10https://gerrit.wikimedia.org/r/560916 (owner: 10Umherirrender) [13:08:03] (03Merged) 10jenkins-bot: Add aliases for Serbian latin script [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/560572 (owner: 10Zoranzoki21) [13:14:19] (03CR) 10Umherirrender: Add phpcs and fix errors found by it (031 comment) [extensions/DeviceMapLogCapture] - 10https://gerrit.wikimedia.org/r/560806 (owner: 10Zoranzoki21) [13:23:04] 10Magnus Sälgö: Europeana Entity <-> Wikidata Property 7704 - https://phabricator.wikimedia.org/T240290 (10Salgo60) [13:31:51] (03PS2) 10Umherirrender: Fix name of desc message in extension.json [extensions/EventStreamConfig] - 10https://gerrit.wikimedia.org/r/560916 [13:32:42] (03PS3) 10Umherirrender: Fix name of desc message in extension.json [extensions/EventStreamConfig] - 10https://gerrit.wikimedia.org/r/560916 [13:32:56] (03CR) 10Umherirrender: Fix name of desc message in extension.json (031 comment) [extensions/EventStreamConfig] - 10https://gerrit.wikimedia.org/r/560916 (owner: 10Umherirrender) [13:56:32] 10Magnus Sälgö: Europeana Entity <-> Wikidata Property 7704 - https://phabricator.wikimedia.org/T240290 (10Salgo60) [14:15:02] (03PS1) 10Umherirrender: Add CreateAPage [extensions] - 10https://gerrit.wikimedia.org/r/560917 [14:15:18] (03CR) 10Umherirrender: [V: 03+2 C: 03+2] Add CreateAPage [extensions] - 10https://gerrit.wikimedia.org/r/560917 (owner: 10Umherirrender) [14:21:51] (03PS1) 10Umherirrender: Add AbuseFilterBypass [extensions] - 10https://gerrit.wikimedia.org/r/560918 [14:22:18] (03CR) 10Umherirrender: [V: 03+2 C: 03+2] Add AbuseFilterBypass [extensions] - 10https://gerrit.wikimedia.org/r/560918 (owner: 10Umherirrender) [14:24:36] 10MediaWiki-extensions-CentralAuth, 10Beta-Cluster-Infrastructure, 10GlobalRename, 10User-DannyS712: Global renames aren't being processed on beta cluster - https://phabricator.wikimedia.org/T241294 (10Urbanecm) @MarcoAurelio Found the issue. fixStuckGlobalRename.php requires **spaces**, the MediaWiki doct... [14:25:54] (03CR) 10Reedy: [C: 03+2] Replace `@param string[]|true|false` with `@param string[]|bool` [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/560884 (owner: 10DannyS712) [14:27:06] 10MediaWiki-extensions-CentralAuth, 10Beta-Cluster-Infrastructure, 10GlobalRename, 10User-DannyS712: Global renames aren't being processed on beta cluster - https://phabricator.wikimedia.org/T241294 (10Urbanecm) [Added](https://wikitech.wikimedia.org/w/index.php?title=Stuck_global_renames&diff=1849244&oldi... [14:37:10] (03PS1) 10Umherirrender: Add NativeSvgHandler [extensions] - 10https://gerrit.wikimedia.org/r/560919 [14:37:25] (03CR) 10Umherirrender: [V: 03+2 C: 03+2] Add NativeSvgHandler [extensions] - 10https://gerrit.wikimedia.org/r/560919 (owner: 10Umherirrender) [14:37:29] (03Merged) 10jenkins-bot: Replace `@param string[]|true|false` with `@param string[]|bool` [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/560884 (owner: 10DannyS712) [14:39:30] (03PS1) 10Umherirrender: Add ShortDescription [extensions] - 10https://gerrit.wikimedia.org/r/560920 [14:39:50] (03PS2) 10Umherirrender: Add ShortDescription [extensions] - 10https://gerrit.wikimedia.org/r/560920 [14:40:00] (03CR) 10Umherirrender: [V: 03+2 C: 03+2] Add ShortDescription [extensions] - 10https://gerrit.wikimedia.org/r/560920 (owner: 10Umherirrender) [14:40:25] (03PS3) 10Reedy: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/560106 (owner: 10Libraryupgrader) [14:40:30] (03CR) 10Reedy: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/560106 (owner: 10Libraryupgrader) [14:53:29] Hi everyone! [14:54:09] hey! [14:55:55] Bonjour! [14:56:30] (03PS2) 10D3r1ck01: resourceloader: Use Config object to get value instead of PHP global [core] - 10https://gerrit.wikimedia.org/r/560536 [14:57:57] Still been quite ill so spent most of yesterday in bed :C [14:58:15] 4 hours left to quickly finish Mr Urbanec's task ;o [14:58:34] (03PS1) 10Umherirrender: Rename message apihelp-query+compsuggestbuilddoc-param-method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/560923 [15:00:35] You need an extension? [15:00:42] Nah, I should be alright [15:01:03] Hate being ill over Christmas, really annoying -_- [15:02:16] I caught this years christmas plague on my birthday so that was fun [15:03:35] :C [15:04:51] 10Magnus Sälgö: Europeana Entity <-> Wikidata Property 7704 - https://phabricator.wikimedia.org/T240290 (10Salgo60) [15:08:56] 10MediaWiki-extensions-CentralAuth, 10Beta-Cluster-Infrastructure, 10GlobalRename, 10User-DannyS712: Global renames aren't being processed on beta cluster - https://phabricator.wikimedia.org/T241294 (10MarcoAurelio) There's now no stuck global renames anymore; but the issue with renames taking forever to p... [15:09:24] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Use Config object to get value instead of PHP global [core] - 10https://gerrit.wikimedia.org/r/560536 (owner: 10D3r1ck01) [15:09:39] 10MediaWiki-extensions-CentralAuth, 10Beta-Cluster-Infrastructure, 10GlobalRename, 10User-DannyS712: Global renames aren't being processed on beta cluster - https://phabricator.wikimedia.org/T241294 (10MarcoAurelio) >>! In T241294#5765194, @Urbanecm wrote: > @MarcoAurelio Found the issue. fixStuckGlobalRen... [15:09:44] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/560923 (owner: 10Umherirrender) [15:27:38] (03CR) 10Raimond Spekking: [C: 03+1] "i18n review" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/560923 (owner: 10Umherirrender) [15:30:06] hi NicholasG04 ! [15:30:42] Hello Mr Urbanec [15:30:52] So sorry about the continued delays - I'm nearly done with the Tracker task [15:31:14] I've just moved the details editing form to another page which is being included in the other pages [15:32:19] No problem - I'm excited to see your solution NicholasG04 [15:32:25] Thanks :) [15:45:00] Finally! https://codein.withgoogle.com/tasks/6699392778633216/ [15:46:27] aa but i'm mid tracker task :C [15:46:41] Pour après [16:13:15] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] HTMLForm: Fix grammar of class description [core] - 10https://gerrit.wikimedia.org/r/560880 (owner: 10DannyS712) [16:14:30] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Fix ident in extension.json [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/560912 (owner: 10Umherirrender) [16:15:30] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Fix name of desc message in extension.json (031 comment) [extensions/ProtectionIndicator] - 10https://gerrit.wikimedia.org/r/560915 (owner: 10Umherirrender) [16:17:41] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Fix name of desc message in extension.json [extensions/EventStreamConfig] - 10https://gerrit.wikimedia.org/r/560916 (owner: 10Umherirrender) [16:20:20] (03PS4) 10Thiemo Kreuz (WMDE): Add missing .phpcs.xml file and make pass [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/560856 (owner: 10Umherirrender) [16:20:35] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Add missing .phpcs.xml file and make pass [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/560856 (owner: 10Umherirrender) [16:25:12] (03CR) 10Umherirrender: [C: 03+2] Replace `@return true|false` with `@return bool` [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/560883 (owner: 10DannyS712) [16:25:39] (03CR) 10Umherirrender: [C: 03+2] Replace `@return sdtClass|true|false|null` with `@return sdtClass|bool|null` [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/560885 (owner: 10DannyS712) [16:26:15] UrbanecM - I've tried so much but I just can't seem to get something to work. How can I make two FormViews render on the same page? [16:26:29] (03CR) 10Umherirrender: [C: 03+1] Fix `user_former_groups` description of autopromotion [core] - 10https://gerrit.wikimedia.org/r/552600 (owner: 10DannyS712) [16:26:33] Using include just means it includes the django code which loads the normal (wrong) FormView on /register [16:26:37] 10MediaWiki-Codesniffer: Create optional sniff to require documenting private methods - https://phabricator.wikimedia.org/T233838 (10Daimona) 05Open→03Resolved [16:27:15] I therefore tried to duplicate the UserDetailsRegister class but can't get that to be invoked on /register for sign-ups :C [16:27:28] (03Merged) 10jenkins-bot: HTMLForm: Fix grammar of class description [core] - 10https://gerrit.wikimedia.org/r/560880 (owner: 10DannyS712) [16:29:42] Use a formset? [16:29:59] Or just combine both forms [16:30:08] I'll look into formsets [16:30:19] The thing is I need one form to show on page and both to show on another [16:30:25] And I think they're calling different API endpoints [16:33:06] NicholasG04: have a look how (pre)expeditures are handled in create_ticket/edit_ticket [16:33:11] I have done [16:33:22] But I think that it's just calling it onto one page, right? [16:33:42] Oh wait [16:33:45] edit_ticket as well [16:33:47] Thanks, I will! [16:33:58] it's the same solution I think [16:34:02] (03CR) 10Umherirrender: [C: 03+2] Archive RecentActivityFeed extension [extensions/RecentActivityFeed] - 10https://gerrit.wikimedia.org/r/560875 (https://phabricator.wikimedia.org/T241032) (owner: 10Zoranzoki21) [16:34:08] well, it's really similar to what you're trying to accomplish [16:34:16] Ticket is one object, and Expediture is another object [16:34:17] hello [16:34:29] (03CR) 10Brian Wolff: [C: 04-1] "So the unit test is complaining that the links in the gallery no longer have the class image added. I guess the easiest way to fix is have" [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) (owner: 10BrandonXLF) [16:34:33] in your case, you have User object (built-in Django) and Trackerprofile object, which is custom one [16:34:37] Ubaid: hi! [16:34:54] Hello [16:35:02] Ubaid: are you a GCI student? :-) [16:35:21] NicholasG04: see my messages above :-) [16:35:30] 10MediaWiki-extensions-RecentActivityFeed, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, and 3 others: Archive the RecentActivityFeed extension - https://phabricator.wikimedia.org/T241032 (10Umherirrender) [16:35:35] Thanks Martin :) [16:35:38] yw [16:36:02] Hi Ubaid! [16:36:08] hi [16:36:32] you are doing code-in [16:36:50] yes [16:37:20] Ubaid: in that case, you'd need to use a different client - you're currently using a web based one, right? [16:37:21] Urbanecm and I are org admins, so yes, we're doing GCI, but giving and reviewing tasks [16:38:40] Ubaid: Also need to register your nickname [16:39:06] ok where i register my nick name [16:39:17] Ubaid: see https://freenode.net/kb/answer/registration [16:39:23] but firstly, do the client thing :-) [16:39:44] Agree [16:39:59] Thanks [16:41:20] I am Pakistani [16:42:56] hello [16:43:10] hi [16:43:29] hi Crutishnyk [16:44:02] Hello! [16:44:39] That is my task in code-in [16:45:21] Ubaid: oh, are you a beginner right? [16:45:48] yes [16:46:07] Ubaid: you need to use a different client - web client isn't eglible [16:46:26] Ubaid: welcome to Wikimedia then! Good luck in doing tasks. [16:46:41] Thanks [16:47:57] Urbanecm - I've began to understand what you were talking about with regards to the objects. I'm therefore trying to change the current UserWithEmailForm class to incorporate the TrackerProfile object so it can submit that too. Is that a good path to go on? [16:49:06] Sounds good to me, but don't know much Tracker. Remember to support OAuth [16:49:23] Yeah I'm going to work on that after - all that needs changing on that is the redirect URI [16:50:07] (03Merged) 10jenkins-bot: Fix ident in extension.json [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/560912 (owner: 10Umherirrender) [16:50:11] (03Merged) 10jenkins-bot: Fix name of desc message in extension.json [extensions/ProtectionIndicator] - 10https://gerrit.wikimedia.org/r/560915 (owner: 10Umherirrender) [16:50:13] (03Merged) 10jenkins-bot: Fix name of desc message in extension.json [extensions/EventStreamConfig] - 10https://gerrit.wikimedia.org/r/560916 (owner: 10Umherirrender) [16:50:15] (03Merged) 10jenkins-bot: Add missing .phpcs.xml file and make pass [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/560856 (owner: 10Umherirrender) [16:50:17] (03Merged) 10jenkins-bot: Replace `@return true|false` with `@return bool` [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/560883 (owner: 10DannyS712) [16:50:19] (03Merged) 10jenkins-bot: Replace `@return sdtClass|true|false|null` with `@return sdtClass|bool|null` [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/560885 (owner: 10DannyS712) [16:50:52] NicholasG04: yup, that's a great idea :) [16:51:05] Thanks! [16:51:05] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/560193 (owner: 10Libraryupgrader) [16:51:25] yw [16:52:31] Hello, Guys! Now I have connected through KVIrc client. Checking if I really am. Ubaid here. [16:53:52] Ebe123 merci beaucoup :) [16:54:02] You're here [16:54:09] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/560193 (owner: 10Libraryupgrader) [16:54:10] Pour l'extension? [16:54:15] Ouais [17:01:31] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/560175 (owner: 10Libraryupgrader) [17:02:52] (03PS3) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/560193 (owner: 10Libraryupgrader) [17:03:52] (03CR) 10Thiemo Kreuz (WMDE): "Thanks, but I'm afraid this raises even more questions. First, this is not really a failing test, but an optional warning from ESLint. We " [extensions/Flow] (REL1_34) - 10https://gerrit.wikimedia.org/r/560438 (owner: 10Paladox) [17:06:41] (03PS1) 10Umherirrender: Use tabs for indent in extension.json [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/560925 [17:06:41] Ubaid|3: Hello [17:07:52] @Gopa Hello [17:08:17] Ubaid|3: How are you doing with GCI ? [17:09:08] @Gopa it is going good [17:09:10] (03PS3) 10Thiemo Kreuz (WMDE): Add phpcs and make it pass [extensions/FilterSpecialPages] - 10https://gerrit.wikimedia.org/r/560814 (owner: 10Zoranzoki21) [17:09:20] Ubaid|3: Nice :) [17:09:52] (03CR) 10jerkins-bot: [V: 04-1] Add phpcs and make it pass [extensions/FilterSpecialPages] - 10https://gerrit.wikimedia.org/r/560814 (owner: 10Zoranzoki21) [17:09:53] Ubaid|3: You don't need to add a @ before a nickname :) [17:10:18] Just write the nickname [17:10:48] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] Add phpcs and make it pass (031 comment) [extensions/FilterSpecialPages] - 10https://gerrit.wikimedia.org/r/560814 (owner: 10Zoranzoki21) [17:11:26] alcarazzam: Thank you for guidence [17:11:48] 10Map-of-monuments, 10Google-Code-in-2019: Add a filter by country and language to the map - https://phabricator.wikimedia.org/T241513 (10Urbanecm) [17:12:03] (03PS4) 10Thiemo Kreuz (WMDE): Add phpcs and make it pass [extensions/FilterSpecialPages] - 10https://gerrit.wikimedia.org/r/560814 (owner: 10Zoranzoki21) [17:12:50] (03PS3) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/560175 (owner: 10Libraryupgrader) [17:14:51] (03CR) 10Thiemo Kreuz (WMDE): "Thanks for the update, that's very helpful!" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/559986 (owner: 10Libraryupgrader) [17:15:28] (03PS5) 10Umherirrender: Add phpcs and make it pass [extensions/FilterSpecialPages] - 10https://gerrit.wikimedia.org/r/560814 (owner: 10Zoranzoki21) [17:15:32] (03CR) 10Umherirrender: [C: 03+2] Add phpcs and make it pass [extensions/FilterSpecialPages] - 10https://gerrit.wikimedia.org/r/560814 (owner: 10Zoranzoki21) [17:16:04] Woow you made it Ubaid|3 Going good :) [17:17:38] (03CR) 10Umherirrender: [V: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 28.0.0 [extensions/BlueSpiceNSFileRepoConnector] - 10https://gerrit.wikimedia.org/r/559947 (owner: 10Libraryupgrader) [17:18:36] Thank you. Gopa, I am wondering how to tag someone in IRC. [17:18:40] (03Merged) 10jenkins-bot: Add phpcs and make it pass [extensions/FilterSpecialPages] - 10https://gerrit.wikimedia.org/r/560814 (owner: 10Zoranzoki21) [17:19:28] yeah Ubaid|3 hope you are enjoying via learning . [17:19:45] Yes [17:24:18] You are my Mentor [17:24:27] Gopa [17:24:40] Type their name; you've got it! [17:25:15] Ubaid|3: I'm one of wikimedia mentor & admin in GCI :) [17:25:15] ok, Ebe 123 [17:26:07] ok,Gopa that is great [17:26:24] Ubaid|3 :) [17:26:34] No space, it's Ebe123 [17:26:47] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/560171 (owner: 10Libraryupgrader) [17:27:13] OK, just hit an annoying curveball [17:27:20] ok,Ebe123 thanks for tell my mistake [17:27:47] What, NicholasG04? [17:27:49] Tried to incorporate the functions from UserDetailsChange class into RegisterView class but the model form is causing an error [17:28:03] Probably because I'm trying to combine a model form and a standard form into one [17:28:09] 10Map-of-monuments, 10Google-Code-in-2019: Add a filter by country and language to the map - https://phabricator.wikimedia.org/T241513 (10Urbanecm) https://codein.withgoogle.com/tasks/5846120282980352/ [17:28:09] This was probably not a good way of doing it, eek [17:28:36] Gopa, what more work i do you writ in Dashboard [17:28:54] my is write [17:29:06] in this text [17:29:37] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/560166 (owner: 10Libraryupgrader) [17:29:39] Ubaid|3: You can just wait/spend an hour in this channel and submit for review. [17:29:39] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/560171 (owner: 10Libraryupgrader) [17:30:16] ok, Thanks to tell me this [17:30:36] Ubaid|3: where are you from ? [17:30:47] Pakistan [17:30:51] 10Map-of-monuments, 10Google-Code-in-2019: Change Wikimedia Czech Republic's logo - https://phabricator.wikimedia.org/T241514 (10Urbanecm) [17:30:57] Ubaid|3: Cool :) [17:31:52] Thanks [17:32:28] Ubaid|3: yw [17:32:38] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Wikibase client: #statements parser function outputs category name with sortkey equal to category name. - https://phabricator.wikimedia.org/T241515 (10AS) [17:38:07] Gopa you are Indian. Student, i learn from your Profile [17:38:13] 10Magnus Sälgö: Europeana Entity <-> Wikidata Property 7704 - https://phabricator.wikimedia.org/T240290 (10Salgo60) [17:39:08] Yes Ubaid|3 good research about people :) [17:39:27] Thanks [17:42:04] Gopa, are you Student of University [17:50:26] Ubaid|3: Yes, I'm pursuving junior level of mybachelors in Computer Science at Amrita University. [17:50:45] Awesome [17:52:30] Thank you for approving my task. [17:52:31] Ubaid|3: you task is approved, All the best for your next GCI task :) [17:53:36] your* [17:55:12] 10WatchTranslations, 10Google-Code-in-2019: Organize list of message groups by aggregate groups - https://phabricator.wikimedia.org/T240240 (10IAmNetx) a:03IAmNetx [17:56:59] IAmNetx: nice to see you claiming a task :-) [17:57:53] Urbanecm: aye, mostly recovered from burnout so gonna get back into things :) [17:58:21] great! [18:02:06] (03PS6) 10BrandonXLF: Use page image when in gallery mode [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) [18:03:32] IAmNetx: Awesome enthusiasm, Good luck :) [18:03:59] But take it slow; don't get burned out again [18:09:12] (03CR) 10BrandonXLF: "> Patch Set 5: Code-Review-1" [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) (owner: 10BrandonXLF) [18:32:13] (03PS1) 10Thiemo Kreuz (WMDE): Add missing parser tests for relevant responsive edge cases [extensions/Cite] - 10https://gerrit.wikimedia.org/r/560927 (https://phabricator.wikimedia.org/T241303) [18:32:30] (03CR) 10Brian Wolff: "recheck" [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) (owner: 10BrandonXLF) [18:33:06] (03PS2) 10Thiemo Kreuz (WMDE): Fix handling of `` [extensions/Cite] - 10https://gerrit.wikimedia.org/r/560850 (https://phabricator.wikimedia.org/T241303) (owner: 10Bartosz Dziewoński) [18:33:10] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Fix handling of `` [extensions/Cite] - 10https://gerrit.wikimedia.org/r/560850 (https://phabricator.wikimedia.org/T241303) (owner: 10Bartosz Dziewoński) [18:35:41] (03CR) 10jerkins-bot: [V: 04-1] Fix handling of `` [extensions/Cite] - 10https://gerrit.wikimedia.org/r/560850 (https://phabricator.wikimedia.org/T241303) (owner: 10Bartosz Dziewoński) [18:36:08] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Wikibase client: #statements parser function outputs category with sortkey equal to category name. - https://phabricator.wikimedia.org/T241515 (10AS) [18:36:09] * Gopa Good night :) [18:37:46] (03PS1) 10Umherirrender: Avoid deprecated param on Maintenance::error [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/560928 [18:39:41] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/560146 (owner: 10Libraryupgrader) [18:40:59] (03PS3) 10Thiemo Kreuz (WMDE): Fix handling of `` [extensions/Cite] - 10https://gerrit.wikimedia.org/r/560850 (https://phabricator.wikimedia.org/T241303) (owner: 10Bartosz Dziewoński) [18:41:02] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Fix handling of `` [extensions/Cite] - 10https://gerrit.wikimedia.org/r/560850 (https://phabricator.wikimedia.org/T241303) (owner: 10Bartosz Dziewoński) [18:41:29] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/560145 (owner: 10Libraryupgrader) [18:42:51] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/560146 (owner: 10Libraryupgrader) [18:43:58] (03PS1) 10Umherirrender: Allow null for unused param of CirrusSearch\Search\Result [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/560929 [18:44:36] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/560145 (owner: 10Libraryupgrader) [18:45:36] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] "I tried to create a backport of this following https://www.mediawiki.org/wiki/Gerrit/Advanced_usage#Submitting_a_change_to_a_branch_for_re" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/560850 (https://phabricator.wikimedia.org/T241303) (owner: 10Bartosz Dziewoński) [18:45:48] (03Abandoned) 10TK-999: VE: Fix CodeMirror overlay alignment on new lines [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/559228 (https://phabricator.wikimedia.org/T198278) (owner: 10TK-999) [18:51:01] (03PS1) 10Umherirrender: Use real varargs for WarningCollector::addWarning [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/560932 [18:52:16] (03PS2) 10M1cr0man: Add UserGroupsRequest::UserGidNumber class [extensions/LDAPProvider] - 10https://gerrit.wikimedia.org/r/559951 (https://phabricator.wikimedia.org/T241279) [18:53:21] (03CR) 10M1cr0man: "Thanks for the review Ammarpad. I removed that import now." (031 comment) [extensions/LDAPProvider] - 10https://gerrit.wikimedia.org/r/559951 (https://phabricator.wikimedia.org/T241279) (owner: 10M1cr0man) [18:53:37] (03Merged) 10jenkins-bot: Fix handling of `` [extensions/Cite] - 10https://gerrit.wikimedia.org/r/560850 (https://phabricator.wikimedia.org/T241303) (owner: 10Bartosz Dziewoński) [18:54:05] (03PS3) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/560145 (owner: 10Libraryupgrader) [18:58:54] (03PS3) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/560146 (owner: 10Libraryupgrader) [18:58:57] (03CR) 10Ricordisamoa: Add type declarations including strict_types, nullable types, void return (031 comment) [extensions/Babel] - 10https://gerrit.wikimedia.org/r/560524 (owner: 10Ricordisamoa) [18:59:38] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/560929 (owner: 10Umherirrender) [19:02:01] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/560146 (owner: 10Libraryupgrader) [19:03:03] 10Upstream, 10phan: Phan should handle always-throw-function like ApiBase::dieWithError better - https://phabricator.wikimedia.org/T240141 (10Daimona) [19:03:42] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/560127 (owner: 10Libraryupgrader) [19:03:45] (03CR) 10Siebrand: [C: 03+2] Use tabs for indent in extension.json [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/560925 (owner: 10Umherirrender) [19:04:10] 10Upstream, 10phan: Phan should handle always-throw-function like ApiBase::dieWithError better - https://phabricator.wikimedia.org/T240141 (10Daimona) >>! In T240141#5764971, @Legoktm wrote: > Do we want to just wait for phan upstream to make progress or should we be looking into a plugin or something? Well,... [19:04:38] (03CR) 10Siebrand: [C: 04-1] "Please fix the merge conflict." [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/560357 (https://phabricator.wikimedia.org/T241344) (owner: 10DannyS712) [19:05:33] (03PS4) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/560146 (owner: 10Libraryupgrader) [19:06:24] (03CR) 10Siebrand: [C: 03+2] Rename message apihelp-query+compsuggestbuilddoc-param-method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/560923 (owner: 10Umherirrender) [19:06:57] (03Merged) 10jenkins-bot: Use tabs for indent in extension.json [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/560925 (owner: 10Umherirrender) [19:08:33] (03CR) 10Siebrand: [C: 04-1] "I think it would be good try to and see if there is some consensus for one way or another to prevent future major re-factorings. Is this s" [extensions/DeviceMapLogCapture] - 10https://gerrit.wikimedia.org/r/560806 (owner: 10Zoranzoki21) [19:09:50] (03CR) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 (033 comments) [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/560171 (owner: 10Libraryupgrader) [19:11:09] (03PS1) 10Umherirrender: build: Add phan-taint-check-plugin config [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/560934 [19:11:57] (03CR) 10Siebrand: [C: 04-1] "It looks like some dependency is not getting installed for this extension, which makes Jenkins fail. That will need to be resolved before " [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/560904 (owner: 10Umherirrender) [19:13:50] 10MediaWiki-Parser, 10Cite, 10VisualEditor-MediaWiki-References, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), and 3 others: does not work anymore - https://phabricator.wikimedia.org/T241303 (10thiemowmde) Not meant as a defense or anything, really just for documentation: * When th... [19:14:30] (03CR) 10Brian Wolff: [C: 04-1] Use page image when in gallery mode (031 comment) [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) (owner: 10BrandonXLF) [19:15:45] 10MediaWiki-Parser, 10Cite, 10VisualEditor-MediaWiki-References, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), and 4 others: does not work anymore - https://phabricator.wikimedia.org/T241303 (10thiemowmde) [19:16:51] (03CR) 10Siebrand: [C: 03+2] Slightly rephrase blockedtext and autoblockedtext [core] - 10https://gerrit.wikimedia.org/r/556656 (owner: 10Amire80) [19:17:07] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/560127 (owner: 10Libraryupgrader) [19:17:20] (03PS7) 10BrandonXLF: Use page image when in gallery mode [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) [19:17:30] (03CR) 10BrandonXLF: "Oops." (031 comment) [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) (owner: 10BrandonXLF) [19:17:53] (03CR) 10Siebrand: [C: 03+2] Add description message for tracking category [extensions/timeline] - 10https://gerrit.wikimedia.org/r/560803 (https://phabricator.wikimedia.org/T241409) (owner: 10Pppery) [19:17:56] (03Merged) 10jenkins-bot: Rename message apihelp-query+compsuggestbuilddoc-param-method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/560923 (owner: 10Umherirrender) [19:18:37] (03CR) 10BrandonXLF: "> Patch Set 7:" (031 comment) [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) (owner: 10BrandonXLF) [19:18:59] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/560932 (owner: 10Umherirrender) [19:22:04] (03CR) 10Siebrand: [C: 04-1] Link to localized page in interfaceadmin-info message (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/560581 (https://phabricator.wikimedia.org/T241260) (owner: 10Pppery) [19:22:42] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Add phpcs and make it pass [extensions/GlobalContribs] - 10https://gerrit.wikimedia.org/r/560819 (owner: 10Zoranzoki21) [19:25:32] (03PS1) 10AndreG-P: Activate formula links [extensions/Math] - 10https://gerrit.wikimedia.org/r/560936 (https://phabricator.wikimedia.org/T239356) [19:29:47] 10MediaWiki-Debug-Logger, 10Core Platform Team, 10Wikimedia-Rdbms: Query tab of $wgDebugToolbar is broken - https://phabricator.wikimedia.org/T241516 (10Bawolff) [19:30:33] (03Merged) 10jenkins-bot: Slightly rephrase blockedtext and autoblockedtext [core] - 10https://gerrit.wikimedia.org/r/556656 (owner: 10Amire80) [19:30:35] (03Merged) 10jenkins-bot: Add description message for tracking category [extensions/timeline] - 10https://gerrit.wikimedia.org/r/560803 (https://phabricator.wikimedia.org/T241409) (owner: 10Pppery) [19:33:26] 10MediaWiki-Debug-Logger, 10Core Platform Team, 10Wikimedia-Rdbms: Query tab of $wgDebugToolbar is broken - https://phabricator.wikimedia.org/T241516 (10Bawolff) It should be noted that queries also no longer show up in the $wgDebugLogFile file, which I usually use as a catch-all for all debugging channels. [19:34:07] (03PS2) 10Thiemo Kreuz (WMDE): Allow null for unused param of CirrusSearch\Search\Result [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/560929 (owner: 10Umherirrender) [19:35:00] (03CR) 10Thiemo Kreuz (WMDE): "It seems this entire Result class is unused. I could only find it being used in tests." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/560929 (owner: 10Umherirrender) [19:36:03] 10MediaWiki-Debug-Logger, 10Core Platform Team, 10Wikimedia-Rdbms: Query tab of $wgDebugToolbar is broken - https://phabricator.wikimedia.org/T241516 (10Bawolff) 05Open→03Invalid I don't get it, I changed nothing but this randomly started working :S. Oh well, sorry for the spam [19:36:38] (03CR) 10Umherirrender: "It is extended by WikibaseLexemeCirrusSearch and WikibaseCirrusSearch extension where phan was trigger an issue for the notnull arg" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/560929 (owner: 10Umherirrender) [19:37:41] (03PS2) 10Pppery: Link to localized page in interfaceadmin-info message [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/560581 (https://phabricator.wikimedia.org/T241260) [19:38:06] 10MediaWiki-Debug-Logger, 10Core Platform Team, 10Wikimedia-Rdbms: Query tab of $wgDebugToolbar is broken - https://phabricator.wikimedia.org/T241516 (10Bawolff) 05Invalid→03Open Ok, I get it, the query tab of $wgDebugToolbar only shows up if $wgDebugLogFile is set to something [19:38:50] 10MediaWiki-Debug-Logger, 10Core Platform Team, 10Wikimedia-Rdbms: Query tab of $wgDebugToolbar is broken when $wgDebugLogFile is false - https://phabricator.wikimedia.org/T241516 (10Bawolff) [19:40:39] (03CR) 10Umherirrender: "Not sure how to fix the last issues or what the cause is" (033 comments) [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/560127 (owner: 10Libraryupgrader) [19:44:40] 10Upstream, 10phan: Phan should handle always-throw-function like ApiBase::dieWithError better - https://phabricator.wikimedia.org/T240141 (10Umherirrender) I am not a fan of hardcoded list, but adding support for an annotation maybe more complex and time consuming, so that would be okay. Another function for... [19:48:51] (03CR) 10Brian Wolff: [C: 04-1] "There's a bug if you have a normal page with a page image followed by a page in the file namespace, the second page will have the first pa" (031 comment) [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) (owner: 10BrandonXLF) [19:49:26] (03CR) 10AndreG-P: Don't list Special:MathWikibase if the wikibase client isn't loaded (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/560878 (https://phabricator.wikimedia.org/T241507) (owner: 10DannyS712) [19:50:20] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/560929 (owner: 10Umherirrender) [19:51:45] (03PS1) 10Umherirrender: Fix return type for MediaHandler::pageCount [core] - 10https://gerrit.wikimedia.org/r/560937 [19:52:30] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/560121 (owner: 10Libraryupgrader) [19:54:48] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/560121 (owner: 10Libraryupgrader) [19:56:50] (03PS1) 10Umherirrender: Allow float for IDatabase::addQuotes [core] - 10https://gerrit.wikimedia.org/r/560938 [19:57:10] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/ORES] - 10https://gerrit.wikimedia.org/r/560108 (owner: 10Libraryupgrader) [19:57:21] (03PS1) 10Fomafix: Remove bad tab in source code [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/560939 [19:57:57] (03PS3) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/560121 (owner: 10Libraryupgrader) [19:59:44] (03CR) 10Umherirrender: "I have no idea how to fix the last issues or what there are caused by, similiar to PdfHandler extension" (033 comments) [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/560121 (owner: 10Libraryupgrader) [20:00:05] (03PS8) 10BrandonXLF: Use page image when in gallery mode [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) [20:01:32] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/560121 (owner: 10Libraryupgrader) [20:01:56] (03CR) 10BrandonXLF: Use page image when in gallery mode (031 comment) [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) (owner: 10BrandonXLF) [20:02:45] (03CR) 10Physikerwelt: [C: 03+2] Activate formula links [extensions/Math] - 10https://gerrit.wikimedia.org/r/560936 (https://phabricator.wikimedia.org/T239356) (owner: 10AndreG-P) [20:03:01] (03PS9) 10BrandonXLF: Use page image when in gallery mode [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) [20:05:04] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/NewUserMessage] - 10https://gerrit.wikimedia.org/r/560096 (owner: 10Libraryupgrader) [20:07:19] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Sure. I know this codebase does have it's history. Do you think the "mixed" type hint is fine? Please feel free to +2 this then." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/560929 (owner: 10Umherirrender) [20:08:06] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/NewUserMessage] - 10https://gerrit.wikimedia.org/r/560096 (owner: 10Libraryupgrader) [20:08:19] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/MiniInvite] - 10https://gerrit.wikimedia.org/r/560077 (owner: 10Libraryupgrader) [20:09:35] 10Upstream, 10phan: Phan should handle always-throw-function like ApiBase::dieWithError better - https://phabricator.wikimedia.org/T240141 (10Daimona) >>! In T240141#5765312, @Umherirrender wrote: > I am not a fan of hardcoded list, but adding support for an annotation maybe more complex and time consuming, so... [20:11:28] (03PS3) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/NewUserMessage] - 10https://gerrit.wikimedia.org/r/560096 (owner: 10Libraryupgrader) [20:12:44] (03CR) 10Brian Wolff: "Recheck" [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) (owner: 10BrandonXLF) [20:13:01] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/560071 (owner: 10Libraryupgrader) [20:13:55] (03CR) 10Umherirrender: [C: 03+1] Allow null for unused param of CirrusSearch\Search\Result [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/560929 (owner: 10Umherirrender) [20:15:32] (03CR) 10Umherirrender: [C: 03+2] "I have seen that also while changing that file and suprised that codesniffer have not found it" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/560939 (owner: 10Fomafix) [20:16:12] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "Erm, I'm sorry. Why does the Comment extension need to call this code? This method doesn't do much but calling Parser::parse(). If the Com" [extensions/Echo] (REL1_34) - 10https://gerrit.wikimedia.org/r/560382 (owner: 10Paladox) [20:16:40] (03PS1) 10Thiemo Kreuz (WMDE): Revert "Make method parseNonEditWikitext public" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/560940 [20:16:46] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Revert "Make method parseNonEditWikitext public" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/560940 (owner: 10Thiemo Kreuz (WMDE)) [20:17:25] (03CR) 10Umherirrender: [C: 03+1] Revert "Make method parseNonEditWikitext public" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/560940 (owner: 10Thiemo Kreuz (WMDE)) [20:18:19] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] "I disagree with this being merged. Unfortunately no ticket exists, it seems. See If69b170 for discussion." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/560940 (owner: 10Thiemo Kreuz (WMDE)) [20:18:45] (03PS3) 10DannyS712: Split hooks into separate file [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/560357 (https://phabricator.wikimedia.org/T241344) [20:19:26] (03CR) 10jerkins-bot: [V: 04-1] Split hooks into separate file [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/560357 (https://phabricator.wikimedia.org/T241344) (owner: 10DannyS712) [20:19:45] (03PS4) 10DannyS712: Split hooks into separate file [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/560357 (https://phabricator.wikimedia.org/T241344) [20:19:59] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Allow null for unused param of CirrusSearch\Search\Result [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/560929 (owner: 10Umherirrender) [20:20:35] 10Outreachy (Round 19): Outreachy Proposal: A system for releasing data dumps from a classifier detecting unsourced sentences in Wikipedia - https://phabricator.wikimedia.org/T241518 (10AikoChou) [20:21:52] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/560071 (owner: 10Libraryupgrader) [20:21:58] 10Outreachy (Round 19): Outreachy Proposal: A system for releasing data dumps from a classifier detecting unsourced sentences in Wikipedia - https://phabricator.wikimedia.org/T241518 (10AikoChou) [20:23:26] 10Commons-Mass-Description, 10Google-Code-in-2019: Support adding new description in a language if there's no description in currently selected language - https://phabricator.wikimedia.org/T196332 (10BubblySprout) a:03BubblySprout Claiming task for GCI 2019-20 [20:26:44] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/MiniInvite] - 10https://gerrit.wikimedia.org/r/560077 (owner: 10Libraryupgrader) [20:27:49] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Allow float for IDatabase::addQuotes [core] - 10https://gerrit.wikimedia.org/r/560938 (owner: 10Umherirrender) [20:29:14] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] Fix return type for MediaHandler::pageCount [core] - 10https://gerrit.wikimedia.org/r/560937 (owner: 10Umherirrender) [20:29:18] 10Developer-Advocacy (Oct-Dec 2019): Prepare and run two sessions on 2019-12-28 at 36C3 - https://phabricator.wikimedia.org/T239544 (10Aklapper) 05Open→03Resolved First talk had about 15-20 attendees; second talk had about 20-25 attendees with three questions/comments afterwards. [20:33:53] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/560108 (owner: 10Libraryupgrader) [20:35:35] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/560058 (owner: 10Libraryupgrader) [20:36:26] 10Magnus Sälgö: Europeana Entity <-> Wikidata Property 7704 - https://phabricator.wikimedia.org/T240290 (10Salgo60) [20:36:43] (03CR) 10Paladox: "> Patch Set 1: Code-Review+2" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/560940 (owner: 10Thiemo Kreuz (WMDE)) [20:37:00] 10Magnus Sälgö: Europeana Entity <-> Wikidata Property 7704 - https://phabricator.wikimedia.org/T240290 (10Salgo60) [20:39:42] (03Merged) 10jenkins-bot: Activate formula links [extensions/Math] - 10https://gerrit.wikimedia.org/r/560936 (https://phabricator.wikimedia.org/T239356) (owner: 10AndreG-P) [20:39:44] (03Merged) 10jenkins-bot: Remove bad tab in source code [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/560939 (owner: 10Fomafix) [20:39:47] (03Merged) 10jenkins-bot: Revert "Make method parseNonEditWikitext public" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/560940 (owner: 10Thiemo Kreuz (WMDE)) [20:39:50] (03Merged) 10jenkins-bot: Allow null for unused param of CirrusSearch\Search\Result [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/560929 (owner: 10Umherirrender) [20:41:35] (03PS1) 10Thiemo Kreuz (WMDE): Fix wrong File::getMetadata() return type [core] - 10https://gerrit.wikimedia.org/r/560941 [20:41:40] (03Merged) 10jenkins-bot: Allow float for IDatabase::addQuotes [core] - 10https://gerrit.wikimedia.org/r/560938 (owner: 10Umherirrender) [20:42:43] (03PS4) 10Thiemo Kreuz (WMDE): build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/560121 (owner: 10Libraryupgrader) [20:46:22] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/560058 (owner: 10Libraryupgrader) [20:47:17] (03PS1) 10Fomafix: Use $this->getConfig() instead of global variable [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/560942 [20:47:50] (03CR) 10Ammarpad: "recheck" [extensions/LDAPProvider] - 10https://gerrit.wikimedia.org/r/559951 (https://phabricator.wikimedia.org/T241279) (owner: 10M1cr0man) [20:48:30] (03CR) 10Paladox: "> > Patch Set 1: Code-Review+2" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/560940 (owner: 10Thiemo Kreuz (WMDE)) [20:50:37] (03CR) 10Umherirrender: [C: 03+2] "Thanks, have not think about faulty core" [core] - 10https://gerrit.wikimedia.org/r/560941 (owner: 10Thiemo Kreuz (WMDE)) [20:53:09] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] "This does not really count as a "self-merge" as I did not wrote any of this code. All this does is restoring the status quo as it was a fe" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/560940 (owner: 10Thiemo Kreuz (WMDE)) [20:53:12] (03CR) 10Umherirrender: [C: 03+2] Use $this->getConfig() instead of global variable [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/560942 (owner: 10Fomafix) [20:57:16] 10MediaWiki-Installer, 10CPT Initiatives (Abstract Schema), 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review, 10User-Ladsgroup: Migrate tables.sql to abstract schema - https://phabricator.wikimedia.org/T230428 (10daniel) [20:58:09] (03CR) 10Thiemo Kreuz (WMDE): New feature: Echo notifications for @username mentions in Comments (031 comment) [extensions/Comments] - 10https://gerrit.wikimedia.org/r/529182 (https://phabricator.wikimedia.org/T148933) (owner: 10Jack Phoenix) [20:59:24] (03PS2) 10Thiemo Kreuz (WMDE): Add missing parser tests for relevant responsive edge cases [extensions/Cite] - 10https://gerrit.wikimedia.org/r/560927 (https://phabricator.wikimedia.org/T241303) [21:00:21] (03CR) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 (031 comment) [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/560171 (owner: 10Libraryupgrader) [21:04:11] (03Merged) 10jenkins-bot: Fix wrong File::getMetadata() return type [core] - 10https://gerrit.wikimedia.org/r/560941 (owner: 10Thiemo Kreuz (WMDE)) [21:04:36] (03CR) 10Umherirrender: "recheck" [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/560127 (owner: 10Libraryupgrader) [21:05:52] (03Merged) 10jenkins-bot: Use $this->getConfig() instead of global variable [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/560942 (owner: 10Fomafix) [21:11:01] (03PS1) 10Umherirrender: Throw in ExtDistProvider::getProviderFor when config is false [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/560945 [21:11:42] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/560025 (owner: 10Libraryupgrader) [21:12:45] (03CR) 10jerkins-bot: [V: 04-1] Throw in ExtDistProvider::getProviderFor when config is false [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/560945 (owner: 10Umherirrender) [21:12:53] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] Use document.body instead of 'body' as jQuery selector [extensions/Flow] - 10https://gerrit.wikimedia.org/r/557876 (owner: 10Fomafix) [21:13:16] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] Use document.body instead of 'body' as jQuery selector [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/557866 (owner: 10Fomafix) [21:13:28] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] Use document.body instead of 'body' as jQuery selector [extensions/Echo] - 10https://gerrit.wikimedia.org/r/557880 (owner: 10Fomafix) [21:13:46] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/560025 (owner: 10Libraryupgrader) [21:14:02] (03CR) 10Fomafix: "> Does this mean we can turn no-global-selector back on in the eslint" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/557866 (owner: 10Fomafix) [21:14:49] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/560121 (owner: 10Libraryupgrader) [21:21:09] (03PS1) 10Umherirrender: Allow null on ApiQueryBase::addTimestampWhereRange [core] - 10https://gerrit.wikimedia.org/r/560946 [21:26:31] (03PS3) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/560007 (owner: 10Libraryupgrader) [21:27:59] (03CR) 10Legoktm: Add `MassMessageSkipBlockedUsers` configuration (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/533347 (https://phabricator.wikimedia.org/T231607) (owner: 10DannyS712) [21:30:55] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/560072 (owner: 10Libraryupgrader) [21:31:45] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560221 (owner: 10Libraryupgrader) [21:35:35] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/560322 (owner: 10Libraryupgrader) [21:36:41] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [skins/GreyStuff] - 10https://gerrit.wikimedia.org/r/560316 (owner: 10Libraryupgrader) [21:38:45] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/560007 (owner: 10Libraryupgrader) [21:41:17] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [skins/Anisa] - 10https://gerrit.wikimedia.org/r/560225 (owner: 10Libraryupgrader) [21:42:15] (03PS3) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/560072 (owner: 10Libraryupgrader) [21:47:48] 10Upstream, 10phan: Phan should handle always-throw-function like ApiBase::dieWithError better - https://phabricator.wikimedia.org/T240141 (10Umherirrender) [21:49:29] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/560137 (owner: 10Libraryupgrader) [21:53:23] (03Abandoned) 10Umherirrender: build: Updating dependencies [extensions/RecentActivityFeed] - 10https://gerrit.wikimedia.org/r/558797 (owner: 10Libraryupgrader) [21:54:50] (03CR) 10Brian Wolff: [C: 04-1] "Sorry, I should have noticed this earlier, but when testing right now I noticed: The link at the bottom of the image in the caption is alw" [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) (owner: 10BrandonXLF) [22:05:50] (03CR) 10Brian Wolff: [C: 04-1] "And then of course remove the line "$gallery->setShowBytes( $galleryFileSize );" so it doesn't duplicate the filename" [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) (owner: 10BrandonXLF) [22:06:28] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/560028 (owner: 10Libraryupgrader) [22:10:41] (03CR) 10Brian Wolff: [C: 04-1] "> And then of course remove the line "$gallery->setShowBytes(" [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) (owner: 10BrandonXLF) [22:11:09] Whoops, guess i should of thought of that earlier. [22:11:21] Its a bit of a lot to add on last minute to a gci task :S [22:11:27] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/560023 (owner: 10Libraryupgrader) [22:12:27] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/560023 (owner: 10Libraryupgrader) [22:16:50] (03PS1) 10Umherirrender: Allow null on CentralAuthUser::setEmailAuthenticationTimestamp [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/560950 [22:17:00] (03PS1) 10Umherirrender: Allow null on User::setEmailAuthenticationTimestamp [core] - 10https://gerrit.wikimedia.org/r/560951 [22:17:36] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/559974 (owner: 10Libraryupgrader) [22:28:23] (03PS1) 10Umherirrender: Allow null on DatabaseBlock::newFromTarget [core] - 10https://gerrit.wikimedia.org/r/560952 [22:29:39] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/559984 (owner: 10Libraryupgrader) [22:31:36] (03PS3) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/559984 (owner: 10Libraryupgrader) [22:32:54] (03PS3) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/560023 (owner: 10Libraryupgrader) [22:41:09] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/560000 (owner: 10Libraryupgrader) [22:45:03] (03PS1) 10Umherirrender: Fix doc for EditPage::scrolltop [core] - 10https://gerrit.wikimedia.org/r/560953 [22:45:31] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/560016 (owner: 10Libraryupgrader) [22:46:35] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/560000 (owner: 10Libraryupgrader) [22:54:25] (03CR) 10BrandonXLF: "> Patch Set 9:" [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) (owner: 10BrandonXLF) [23:02:15] (03PS1) 10Physikerwelt: Make max length of Contentmath configurable [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/560954 [23:02:43] (03CR) 10jerkins-bot: [V: 04-1] Make max length of Contentmath configurable [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/560954 (owner: 10Physikerwelt) [23:09:13] (03PS2) 10Physikerwelt: Make max length of Contentmath configurable [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/560954 [23:13:15] (03CR) 10Physikerwelt: [C: 03+2] Make max length of Contentmath configurable [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/560954 (owner: 10Physikerwelt) [23:13:45] (03Merged) 10jenkins-bot: Make max length of Contentmath configurable [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/560954 (owner: 10Physikerwelt) [23:14:14] (03PS1) 10Umherirrender: Allow strings on Globe::coordinatesAreValid [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/560955 [23:18:09] (03PS10) 10BrandonXLF: Use page image when in gallery mode [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) [23:18:33] (03PS2) 10Umherirrender: Allow strings on Globe::coordinatesAreValid [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/560955 [23:19:25] (03PS11) 10BrandonXLF: Use page image when in gallery mode [extensions/intersection] - 10https://gerrit.wikimedia.org/r/560871 (https://phabricator.wikimedia.org/T240108) [23:22:08] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/560037 (owner: 10Libraryupgrader) [23:28:30] (03CR) 10jerkins-bot: [V: 04-1] Allow strings on Globe::coordinatesAreValid [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/560955 (owner: 10Umherirrender) [23:30:11] (03PS3) 10Umherirrender: Allow strings on Globe::coordinatesAreValid [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/560955 [23:30:18] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/560037 (owner: 10Libraryupgrader) [23:35:13] 10MediaWiki-Codesniffer: Remove tabs in function signature - https://phabricator.wikimedia.org/T241520 (10Umherirrender) [23:35:26] (03CR) 10Umherirrender: [C: 03+2] "I have created T241520 to track this" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/560939 (owner: 10Fomafix) [23:37:08] (03CR) 10Umherirrender: "recheck" [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/560037 (owner: 10Libraryupgrader) [23:50:23] Hi all, may someone help me with the following problem; When running the following command: python manage.py makemessages. I am getting the error; Command Error:Can't find msguniq. Make sure you have GNU gettext tools 0.15 or newer installed. From looking online, I downloaded gettext tools and gettext runtime and extracted their bin files into [23:50:23] Program Files>gettext-utils>bin and added this path to Control Panel>System>Advanced>Environment Variables> System Variables. [23:50:34] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/560163 (owner: 10Libraryupgrader)