[00:01:33] (03PS2) 10DannyS712: Replace Title::isValidMoveTarget with MovePage::isValidMoveTarget [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/560352 (https://phabricator.wikimedia.org/T241339) [00:02:05] (03CR) 10jerkins-bot: [V: 04-1] Replace deprecated Title::moveTo with MovePage method [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/560350 (https://phabricator.wikimedia.org/T221949) (owner: 10DannyS712) [00:03:52] 10MediaWiki-General: PHP Notice: Constant MW_ENTRY_POINT already defined in /srv/mediawiki/w/thumb.php on line 28 - https://phabricator.wikimedia.org/T241340 (10Paladox) [00:04:14] (03CR) 10jerkins-bot: [V: 04-1] Replace Title::isValidMoveTarget with MovePage::isValidMoveTarget [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/560352 (https://phabricator.wikimedia.org/T241339) (owner: 10DannyS712) [00:04:52] 10MediaWiki-General, 10MW-1.35-release, 10Technical-Debt (Deprecation process): Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release - https://phabricator.wikimedia.org/T232864 (10DannyS712) [00:07:53] (03PS5) 10DannyS712: Replace deprecated Title::moveTo with MovePage method [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/560350 (https://phabricator.wikimedia.org/T221949) [00:10:51] (03CR) 10jerkins-bot: [V: 04-1] Replace deprecated Title::moveTo with MovePage method [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/560350 (https://phabricator.wikimedia.org/T221949) (owner: 10DannyS712) [00:10:54] (03PS3) 10DannyS712: Replace Title::isValidMoveTarget with MovePage::isValidMove [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/560352 (https://phabricator.wikimedia.org/T241339) [00:12:26] (03PS6) 10DannyS712: Replace deprecated Title::moveTo with MovePage method [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/560350 (https://phabricator.wikimedia.org/T221949) [00:17:06] (03PS1) 10Jack Phoenix: Fix stacking issue on Timeless with the "language changed to " message box [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/560353 (https://phabricator.wikimedia.org/T238834) [00:41:47] (03PS1) 10DannyS712: Drop `wgSkipSkin`, deprecated and unused [core] - 10https://gerrit.wikimedia.org/r/560354 (https://phabricator.wikimedia.org/T241342) [00:43:45] (03PS2) 10DannyS712: Drop `wgSkipSkin`, deprecated and unused [core] - 10https://gerrit.wikimedia.org/r/560354 (https://phabricator.wikimedia.org/T241342) [00:44:21] 10MediaWiki-General, 10MW-1.35-release, 10Technical-Debt (Deprecation process): Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release - https://phabricator.wikimedia.org/T232864 (10DannyS712) [00:47:05] (03PS1) 10DannyS712: Drop `wgProfileOnly`, deprecated and unused [core] - 10https://gerrit.wikimedia.org/r/560355 (https://phabricator.wikimedia.org/T241343) [00:48:59] (03PS2) 10DannyS712: Drop `wgProfileOnly`, deprecated and unused [core] - 10https://gerrit.wikimedia.org/r/560355 (https://phabricator.wikimedia.org/T241343) [00:49:21] 10MediaWiki-General, 10MW-1.35-release, 10Technical-Debt (Deprecation process): Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release - https://phabricator.wikimedia.org/T232864 (10DannyS712) [01:06:35] (03CR) 10DannyS712: Fix stacking issue on Timeless with the "language changed to " message box (031 comment) [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/560353 (https://phabricator.wikimedia.org/T238834) (owner: 10Jack Phoenix) [01:08:57] (03PS1) 10DannyS712: Split hooks into separate file [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/560357 (https://phabricator.wikimedia.org/T241344) [01:11:46] (03PS2) 10DannyS712: Split hooks into separate file [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/560357 (https://phabricator.wikimedia.org/T241344) [01:21:50] 10MediaWiki-extensions-Translate, 10WMF-JobQueue, 10Core Platform Team Workboards (Clinic Duty Team), 10User-DannyS712: Can't rename the translatable page mw:Global_templates/Draft_spec - https://phabricator.wikimedia.org/T239394 (10DannyS712) >>! In T239394#5706438, @Amire80 wrote: > Woah... Thanks. > >... [01:54:29] (03PS1) 10Paladox: Make method parseNonEditWikitext public [extensions/Echo] - 10https://gerrit.wikimedia.org/r/560358 [01:54:55] (03PS2) 10Paladox: Make method parseNonEditWikitext public [extensions/Echo] - 10https://gerrit.wikimedia.org/r/560358 [01:55:57] (03Restored) 10Zoranzoki21: Move some files into the directories [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/560091 (owner: 10Zoranzoki21) [01:56:09] (03CR) 10Zoranzoki21: "> Why did you abandon this? It seems like a good idea. The "/skins"" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/560091 (owner: 10Zoranzoki21) [01:56:25] (03CR) 10Zoranzoki21: "recheck" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/560091 (owner: 10Zoranzoki21) [01:57:43] 10WMUA-Community-Support: WMUA General Meeting / Загальні збори 2016 - https://phabricator.wikimedia.org/T146074 (10Aklapper) 05Open→03Invalid Closing this old task as WMUA currently does not use Wikimedia Phabricator to plan or track work. [01:57:45] 10WMUA-Community-Support: Montage and upload video from the Conflict resolution traning for ukwp community - https://phabricator.wikimedia.org/T136068 (10Aklapper) 05Open→03Invalid Closing this old task as WMUA currently does not use Wikimedia Phabricator to plan or track work. [01:57:47] 10WMUA-Community-Support: Create a learning pattern on the WMUA changing its Chair - https://phabricator.wikimedia.org/T129647 (10Aklapper) 05Open→03Invalid Closing this old task as WMUA currently does not use Wikimedia Phabricator to plan or track work. [01:57:49] 10WMUA-Community-Support: Wikimedia Ukraine/Members - https://phabricator.wikimedia.org/T129565 (10Aklapper) 05Open→03Invalid Closing this old task as WMUA currently does not use Wikimedia Phabricator to plan or track work. [01:57:51] 10WMUA-Community-Support: Translations related to Wikimedia Ukraine - https://phabricator.wikimedia.org/T129557 (10Aklapper) [01:57:53] 10WMUA-Community-Support: Wikimedia Ukraine/Bylaws - https://phabricator.wikimedia.org/T129560 (10Aklapper) 05Open→03Invalid Closing this old task as WMUA currently does not use Wikimedia Phabricator to plan or track work. [01:57:55] 10WMUA-Community-Support: Translations related to Wikimedia Ukraine - https://phabricator.wikimedia.org/T129557 (10Aklapper) [01:57:57] 10WMUA-Community-Support: Translations related to Wikimedia Ukraine - https://phabricator.wikimedia.org/T129557 (10Aklapper) [01:57:59] 10WMUA-Community-Support: Translate Grants:APG/Proposals/2015-2016 round1/Wikimedia Ukraine/Proposal form - https://phabricator.wikimedia.org/T129559 (10Aklapper) 05Open→03Invalid Closing this old task as WMUA currently does not use Wikimedia Phabricator to plan or track work. [01:58:01] 10WMUA-Community-Support: Translations related to Wikimedia Ukraine - https://phabricator.wikimedia.org/T129557 (10Aklapper) 05Open→03Invalid Closing this old task as WMUA currently does not use Wikimedia Phabricator to plan or track work. [01:59:19] (03PS2) 10Zoranzoki21: Move some files into the directories [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/560091 [02:01:16] (03CR) 10jerkins-bot: [V: 04-1] Move some files into the directories [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/560091 (owner: 10Zoranzoki21) [02:05:15] (03PS3) 10Zoranzoki21: Move some files into the directories [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/560091 [02:34:05] (03CR) 10Jack Phoenix: Fix stacking issue on Timeless with the "language changed to " message box (031 comment) [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/560353 (https://phabricator.wikimedia.org/T238834) (owner: 10Jack Phoenix) [03:05:52] 10MediaWiki-Watchlist, 10Core Platform Team, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), and 3 others: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10Maile66) Comment. Many pages I routinely watch remain on my wa... [03:40:07] 10MediaWiki-General, 10MediaWiki-Vagrant: Create ability to trivially spin up MediaWiki instance of a particular patch/diff - https://phabricator.wikimedia.org/T76245 (10MZMcBride) In the time since I wrote this ticket, I started and ended a job that had this type of betas infrastructure. It was great. When so... [03:59:50] 10MediaWiki-extensions-Other, 10Technical-Debt, 10ci-test-error: Replace or remove usage of removed jquery.ui.*" and "jquery.effects.*" modules - https://phabricator.wikimedia.org/T241335 (10Masumrezarock100) [04:59:29] 10Code-Review-Workgroup, 10Developer-Advocacy: Find out which Git/Gerrit code repositories deployed on WMF sites have no reviewers/watchers in Gerrit? - https://phabricator.wikimedia.org/T196985 (10Dzahn) > problem to solve beforehand might be to make reviewers read their Gerrit notifications (which might requ... [05:00:20] 10Code-Review-Workgroup, 10Developer-Advocacy: Find out which Git/Gerrit code repositories deployed on WMF sites have no reviewers/watchers in Gerrit? - https://phabricator.wikimedia.org/T196985 (10Dzahn) My personal way to handle it that i would recommend to others: disable/disregard all Gerrit emails but sta... [05:17:31] (03PS3) 10Brian Wolff: [WIP] Special page to add exceptions to CSP policy [core] - 10https://gerrit.wikimedia.org/r/557581 (https://phabricator.wikimedia.org/T208188) [05:25:37] (03PS4) 10Brian Wolff: [WIP] Special page to add exceptions to CSP policy [core] - 10https://gerrit.wikimedia.org/r/557581 (https://phabricator.wikimedia.org/T208188) [05:36:00] (03CR) 10DannyS712: [WIP] Special page to add exceptions to CSP policy (034 comments) [core] - 10https://gerrit.wikimedia.org/r/557581 (https://phabricator.wikimedia.org/T208188) (owner: 10Brian Wolff) [05:51:29] (03CR) 10Brian Wolff: "Thanks for taking a look :)" [core] - 10https://gerrit.wikimedia.org/r/557581 (https://phabricator.wikimedia.org/T208188) (owner: 10Brian Wolff) [06:42:28] 10MediaWiki-extensions-Translate: Empty space in diff on Special:ManageMessageGroups - https://phabricator.wikimedia.org/T241346 (10abi_) p:05Triage→03Low [06:46:16] 10MediaWiki-Watchlist, 10Core Platform Team, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), and 3 others: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10Stryn) Sounds like you have some filters enabled on your watchl... [07:34:10] 10Dumps-Generation, 10Patch-For-Review: audit public tables and make sure we dump them all - https://phabricator.wikimedia.org/T226167 (10ArielGlenn) Some rebuilds for the wb_terms migration are taking place; I'll check again in the third week of January to see if all of the cleanup is done. We might be able t... [07:45:02] 10Dumps-Generation, 10Patch-For-Review: audit public tables and make sure we dump them all - https://phabricator.wikimedia.org/T226167 (10ArielGlenn) [08:02:32] (03PS3) 10Legoktm: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/560123 (owner: 10Libraryupgrader) [08:02:43] 10Upstream, 10phan: Phan should handle always-throw-function like ApiBase::dieWithError better - https://phabricator.wikimedia.org/T240141 (10Legoktm) Came up at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ParserMigration/+/560123 again [08:15:53] 10ContentSecurityPolicy, 10Security-Team, 10TechCom, 10TechCom-RFC, and 2 others: RFC: Partial opt-out method for Content security policy - https://phabricator.wikimedia.org/T208188 (10DannyS712) Question: Why is this being done in a separate table rather than as a user preference (even if it is set using... [08:30:57] (03PS1) 10Samwilson: Don't show namespace for person lists [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/560370 (https://phabricator.wikimedia.org/T241172) [08:31:06] 04(no projects): upgrade cloud-vps openstack to Openstack version 'Pike' - https://phabricator.wikimedia.org/T241347 (10Andrew) [08:31:08] 04(no projects): upgrade cloud-vps openstack to Openstack version 'Pike' - https://phabricator.wikimedia.org/T241347 (10Andrew) [08:40:17] 10MediaWiki-General, 10MW-1.35-release, 10Technical-Debt (Deprecation process): Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release - https://phabricator.wikimedia.org/T232864 (10DannyS712) [08:42:53] 10Genealogy, 10Patch-For-Review: Allow configuring Genealogy to be used in name spaces other than the main space - https://phabricator.wikimedia.org/T241172 (10Samwilson) > there is only the detail added by the name space when linked to another biography. It would be good to omit it Done. Will make another re... [08:43:08] (03CR) 10Samwilson: [C: 03+2] Don't show namespace for person lists [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/560370 (https://phabricator.wikimedia.org/T241172) (owner: 10Samwilson) [08:45:28] Ebe123: hello [08:46:11] (03Merged) 10jenkins-bot: Don't show namespace for person lists [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/560370 (https://phabricator.wikimedia.org/T241172) (owner: 10Samwilson) [08:46:31] why r u awake so late ? [08:46:47] btw i found that a new lua task has been added [08:52:09] 10ChessBrowser, 10Technical-Debt: Pay off javascript technical debt - https://phabricator.wikimedia.org/T241086 (10DannyS712) [08:52:15] 10ChessBrowser, 10Technical-Debt: Pay off javascript technical debt - https://phabricator.wikimedia.org/T241086 (10DannyS712) [08:53:00] (03PS1) 10DannyS712: Technical debt: Re-enable `no-constructor-attributes` rule globally [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/560374 (https://phabricator.wikimedia.org/T241357) [09:00:32] 10Phabricator: Space request for Communications - https://phabricator.wikimedia.org/T241358 (10Qgil) [09:03:45] (03PS2) 10DannyS712: Technical debt: Re-enable `no-constructor-attributes` rule globally [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/560374 (https://phabricator.wikimedia.org/T241357) [09:13:23] (03CR) 10ArielGlenn: "The patch appears to add to nested in in the export schema, not which is already there. Am I reading so" [core] - 10https://gerrit.wikimedia.org/r/556344 (owner: 10Daniel Kinzler) [09:16:36] Hello.What is this? [09:23:43] (03PS1) 10PortalsBuilder: Assets build - 2019-12-23 09:23:40+00:00 [wikimedia/portals/deploy] - 10https://gerrit.wikimedia.org/r/560377 [09:26:05] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Avoid lost link for deleting pages which is later restored - https://phabricator.wikimedia.org/T75908 (10Graham87) It obviously hasn't ... the problem still occurred here: https://www.wikidata.org/w/index.php?title=... [09:26:43] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Avoid lost link for deleting pages which are later restored - https://phabricator.wikimedia.org/T75908 (10Graham87) [09:32:25] 10CRM (Jan-Mar-2020): This is a test CRM task - https://phabricator.wikimedia.org/T241360 (10Qgil) [09:33:57] 10CRM (Jan-Mar-2020): This is a test CRM task - https://phabricator.wikimedia.org/T241360 (10Qgil) p:05Triage→03Normal [09:35:44] (03PS10) 10Matěj Suchánek: Replace Linker::link usage with LinkRenderer in includes [core] - 10https://gerrit.wikimedia.org/r/534901 (https://phabricator.wikimedia.org/T149346) [09:37:20] 10CRM (Jan-Mar-2020): This is a test CRM task - https://phabricator.wikimedia.org/T241360 (10Qgil) [09:46:58] 10CRM (Jan-Mar-2020): This is a test CRM task - https://phabricator.wikimedia.org/T241360 (10Qgil) [09:49:29] (03CR) 10Umherirrender: [C: 03+2] Make method parseNonEditWikitext public [extensions/Echo] - 10https://gerrit.wikimedia.org/r/560358 (owner: 10Paladox) [09:51:29] (03PS1) 10Samwilson: Version number and author link [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/560379 [09:54:25] (03PS36) 10Vedmaka Wakalaka: Creates RestrictionStore service [core] - 10https://gerrit.wikimedia.org/r/549909 (https://phabricator.wikimedia.org/T218395) [09:58:20] (03CR) 10ArielGlenn: "This approach looks generally good though I have done no testing yet." [core] - 10https://gerrit.wikimedia.org/r/556346 (owner: 10Daniel Kinzler) [09:59:10] (03CR) 10Samwilson: [C: 03+2] Version number and author link [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/560379 (owner: 10Samwilson) [10:00:18] (03Merged) 10jenkins-bot: Make method parseNonEditWikitext public [extensions/Echo] - 10https://gerrit.wikimedia.org/r/560358 (owner: 10Paladox) [10:02:11] 10ContentTranslation, 10Language-Team (Language-2019-October-December): Enable Content translation as a default tool (out of beta) for newly created Wikipedias - https://phabricator.wikimedia.org/T234318 (10Pginer-WMF) 05Open→03Resolved [10:02:30] (03Merged) 10jenkins-bot: Version number and author link [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/560379 (owner: 10Samwilson) [10:05:33] 10Phabricator, 10DBA, 10Release-Engineering-Team-TODO, 10Documentation, and 2 others: Prepare a disaster recovery plan for failing over Phabricator - https://phabricator.wikimedia.org/T190572 (10Dzahn) Added steps for a fail-over to a new server on https://wikitech.wikimedia.org/wiki/Phabricator#Simple_fai... [10:09:06] (03CR) 10Umherirrender: [C: 03+2] "The visibility in Echo was changed with Id4fe59155d6e0fa2ef1ccf4dc46ee1f109265246 (Nov, 2018)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/560358 (owner: 10Paladox) [10:20:47] (03CR) 10Florianschmidtwelzow: [C: 04-1] "One little thing :) Thanks for your work on that! Looks much better with the shadow :)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/560192 (https://phabricator.wikimedia.org/T231205) (owner: 10N3rsti) [10:29:53] 10Genealogy: Allow configuring Genealogy to be used in name spaces other than the main space - https://phabricator.wikimedia.org/T241172 (10Samwilson) I've updated the version on the genealogy demo site to 1.9.2, and Miraheze is now updated to that version too (the PRs I sent were merged within seconds!). Let m... [10:52:07] 10ContentSecurityPolicy, 10Security-Team, 10TechCom, 10TechCom-RFC, and 2 others: RFC: Partial opt-out method for Content security policy - https://phabricator.wikimedia.org/T208188 (10Bawolff) >>! In T208188#5760085, @DannyS712 wrote: > Question: Why is this being done in a separate table rather than as a... [10:52:23] (03PS5) 10N3rsti: mobile.variables.less: added drawerShadow variable Drawer.less added shadow to navigation-drawer class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/560192 (https://phabricator.wikimedia.org/T231205) [10:56:42] (03CR) 10Ammarpad: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/560192 (https://phabricator.wikimedia.org/T231205) (owner: 10N3rsti) [11:03:47] (03PS1) 10Paladox: Make method parseNonEditWikitext public [extensions/Echo] (REL1_34) - 10https://gerrit.wikimedia.org/r/560382 [11:21:09] 10MediaWiki-Watchlist, 10Core Platform Team, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), and 3 others: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10Maile66) Someone mentioned to me that it might have to do with... [11:29:53] 10MediaWiki-API, 10Core Platform Team: API: action=parse with redirects=1 and pageid given leads to missingparam error - https://phabricator.wikimedia.org/T241362 (10hgzh) [11:43:50] (03CR) 10Daimona Eaytoy: [C: 03+1] "I'm tempted to +2, but I have a doubt. We know that phan cannot handle dieWithError, so I wonder: can phan tell whether the method returns" [core] - 10https://gerrit.wikimedia.org/r/560343 (owner: 10Umherirrender) [11:46:16] 10Upstream, 10phan: Phan should handle always-throw-function like ApiBase::dieWithError better - https://phabricator.wikimedia.org/T240141 (10Daimona) Memo: after this is fixed, we should merge https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/560343/ as well. [11:46:37] Urbanecm: Sorry, I’m doing https://codein.withgoogle.com/dashboard/task-instances/6323128544788480/ ,and I am trying to make a dependant, but when I commit it, git “reply nothing to commit, working tree clean”, where should I add “wmf-config/InitialiseSettings.php”? thank for your help. [11:46:41] (03CR) 10Daimona Eaytoy: [C: 03+2] "Thanks" [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/560123 (owner: 10Libraryupgrader) [11:49:55] (03CR) 10Daimona Eaytoy: Replace deprecated Title::moveTo with MovePage method (032 comments) [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/560350 (https://phabricator.wikimedia.org/T221949) (owner: 10DannyS712) [11:52:04] (03PS7) 10DannyS712: Replace deprecated Title::moveTo with MovePage method [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/560350 (https://phabricator.wikimedia.org/T221949) [11:52:17] (03CR) 10DannyS712: Replace deprecated Title::moveTo with MovePage method (032 comments) [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/560350 (https://phabricator.wikimedia.org/T221949) (owner: 10DannyS712) [11:52:36] Hi Subscriptshoe9, I see you uploaded https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/560380, which contains both images and the IS.php change, which is wrong due to our deployment rules. You need to manually revert the changes in IS.php first. [11:52:45] Let me know once done [11:53:35] (03CR) 10jerkins-bot: [V: 04-1] Replace deprecated Title::moveTo with MovePage method [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/560350 (https://phabricator.wikimedia.org/T221949) (owner: 10DannyS712) [11:53:59] (03CR) 10Matěj Suchánek: [C: 03+2] Avoid uncached Title::newFromId on special pages [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/547649 (owner: 10Umherirrender) [11:54:10] (03PS8) 10DannyS712: Replace deprecated Title::moveTo with MovePage method [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/560350 (https://phabricator.wikimedia.org/T221949) [11:54:29] OK, I revert the IS.php [11:55:06] (03CR) 10Matěj Suchánek: [C: 03+2] Run LinkBatch on special pages (031 comment) [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/547640 (owner: 10Umherirrender) [11:55:13] * I’ve reverted the IS.php [11:55:13] 10Magnus Sälgö: Check WD objects with more Europeana Entities - https://phabricator.wikimedia.org/T241363 (10Salgo60) [11:56:07] (03PS3) 10DannyS712: Replace deprecated Title::moveTo with MovePage method [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/560351 (https://phabricator.wikimedia.org/T221949) [11:56:38] Subscriptshoe9: I don't see any change at https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/560380. Could you please amend that commit? [11:57:26] OK, here it is https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/560380/ [11:57:35] 10MediaViewer, 10Structured-Data-Backlog, 10Browser-Support-Firefox, 10Patch-For-Review, and 2 others: After closing, browser sometimes scrolls to the top of the page in Firefox 70 - https://phabricator.wikimedia.org/T229484 (10AronManning) >>! In T229484#5670092, @dbarratt wrote: > This is driving me bonk... [11:58:02] (03CR) 10Matěj Suchánek: [C: 03+2] Don't use mFilter in ViewTestBatch [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/558016 (owner: 10Daimona Eaytoy) [11:58:43] (03CR) 10Matěj Suchánek: [C: 03+2] Ensure that a min/max arg count is available for all built-in functions [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/552543 (owner: 10Daimona Eaytoy) [11:58:59] 10Magnus Sälgö: Check WD objects with more Europeana Entities - https://phabricator.wikimedia.org/T241363 (10Salgo60) Bugreported to Europeana on page [[ https://www.europeana.eu/portal/en/explore/people/158238-wu-changshuo.html | people/158238-wu-changshuo.htm ]] l but got no ID number back from Europeana feels... [11:59:12] (03CR) 10Matěj Suchánek: [C: 03+2] Clarify error message for non-literals passed to set/set_var [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/552665 (https://phabricator.wikimedia.org/T238713) (owner: 10Daimona Eaytoy) [11:59:42] (03Merged) 10jenkins-bot: Avoid uncached Title::newFromId on special pages [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/547649 (owner: 10Umherirrender) [11:59:47] 10Magnus Sälgö: Check WD objects with more Europeana Entities - https://phabricator.wikimedia.org/T241363 (10Salgo60) [12:00:43] (03Merged) 10jenkins-bot: Run LinkBatch on special pages [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/547640 (owner: 10Umherirrender) [12:01:18] (03PS5) 10DannyS712: Hide partial block options when not applicable [core] - 10https://gerrit.wikimedia.org/r/537718 (https://phabricator.wikimedia.org/T217363) [12:03:01] Thanks Subscriptshoe9. Now, you need to checkout your patch locally. The best way how to do that is git review -d , where change number is the six digit number in the URL [12:03:12] (do not include <> in your command) [12:03:34] (03CR) 10Matěj Suchánek: [C: 03+2] i18n: Rename msg key for abusefilter-view-oldwarning [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/551818 (https://phabricator.wikimedia.org/T235590) (owner: 10Daimona Eaytoy) [12:04:23] Thank you, ok I’ve type this command in my terminal [12:06:12] (03CR) 10Matěj Suchánek: [C: 03+1] Add site name and language variables (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/558567 (https://phabricator.wikimedia.org/T240948) (owner: 10Daimona Eaytoy) [12:06:19] Subscriptshoe9: now, you need to create a new branch. In this new branch, you'll make the IS.php, commit, and send for review. [12:07:08] 10Upstream, 10phan: Phan should handle always-throw-function like ApiBase::dieWithError better - https://phabricator.wikimedia.org/T240141 (10Daimona) I've filed https://github.com/phan/phan/issues/3602. [12:09:37] Urbanecm: So the command is “git checkout -b bug/”? [12:09:52] Subscriptshoe9: git checkout -b [12:10:01] it doesn't have to follow any naming schema [12:10:24] fill in whatever indicates what the change is this about for you [12:10:45] OK [12:11:00] I’ve switch to a new branch [12:11:15] So now, re-make the IS.php changes and commit them :) [12:11:53] (03Merged) 10jenkins-bot: Don't use mFilter in ViewTestBatch [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/558016 (owner: 10Daimona Eaytoy) [12:11:58] (03Merged) 10jenkins-bot: Ensure that a min/max arg count is available for all built-in functions [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/552543 (owner: 10Daimona Eaytoy) [12:12:29] (03CR) 10DannyS712: "Will a follow-up patch add this to the release notes (documenting the deprecations, etc.)?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/549909 (https://phabricator.wikimedia.org/T218395) (owner: 10Vedmaka Wakalaka) [12:12:50] (03Merged) 10jenkins-bot: Clarify error message for non-literals passed to set/set_var [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/552665 (https://phabricator.wikimedia.org/T238713) (owner: 10Daimona Eaytoy) [12:13:04] (03CR) 10Daimona Eaytoy: [C: 03+2] Replace deprecated Title::moveTo with MovePage method (031 comment) [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/560350 (https://phabricator.wikimedia.org/T221949) (owner: 10DannyS712) [12:14:19] Subscriptshoe9: how is it going? [12:14:26] OK so I command “git add wmf-config/InitialiseSettings.php” [12:14:32] (03CR) 10Matěj Suchánek: [C: 03+1] Always evaluate the offset when retrieving array elements (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/548968 (https://phabricator.wikimedia.org/T237351) (owner: 10Daimona Eaytoy) [12:14:39] Subscriptshoe9: if you modified that file first, yes [12:14:58] and reply nothing, It is right or not? [12:15:17] Subscriptshoe9: usually, commands don't have an output unless erroring :-). [12:15:56] Subscriptshoe9: so, yes. Now, you just need to push for review :) [12:16:58] (03Merged) 10jenkins-bot: i18n: Rename msg key for abusefilter-view-oldwarning [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/551818 (https://phabricator.wikimedia.org/T235590) (owner: 10Daimona Eaytoy) [12:17:00] (03Merged) 10jenkins-bot: Replace deprecated Title::moveTo with MovePage method [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/560350 (https://phabricator.wikimedia.org/T221949) (owner: 10DannyS712) [12:17:52] So I should edit IS.php on local not remote? [12:18:00] Subscriptshoe9: yup [12:18:29] Opps I think I find the point where I am stuck on [12:18:35] thank for your help [12:18:36] What is it? [12:19:22] (03CR) 10Florianschmidtwelzow: [C: 03+2] mobile.variables.less: added drawerShadow variable Drawer.less added shadow to navigation-drawer class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/560192 (https://phabricator.wikimedia.org/T231205) (owner: 10N3rsti) [12:19:33] I command “git commit” with nothing change [12:19:40] i see :) [12:20:21] And now I am going to find where should I get IS.php [12:20:41] what do you mean, Subscriptshoe9 ? [12:21:24] In fact, I could not find IS.php at local [12:21:42] Urbanecm: [12:21:47] Subscriptshoe9: sorry for the confusion, IS.php is short for wmf-config/InitialiseSettings.php :-) [12:22:28] OK I found it [12:22:34] great [12:27:01] 10Desktop Improvements, 10TechCom-RFC, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): RFC: Where to implement Desktop Improvements project - https://phabricator.wikimedia.org/T234907 (10pmiazga) I just wanted to highlight that we need to take precautions while working on the Vector skin. Some popular 3rd part... [12:30:14] Urbanecm OK, I finished the commit [12:30:26] Subscriptshoe9: great. Now, push it for review :) [12:32:51] 10Inuka-Team (Kanban): Missing "goto" Section in article links pagination - https://phabricator.wikimedia.org/T241364 (10hueitan) [12:32:53] (03Merged) 10jenkins-bot: mobile.variables.less: added drawerShadow variable Drawer.less added shadow to navigation-drawer class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/560192 (https://phabricator.wikimedia.org/T231205) (owner: 10N3rsti) [12:33:07] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Missing "goto" Section in article links pagination - https://phabricator.wikimedia.org/T241364 (10hueitan) [12:33:09] Urbanecm: thank for your help and here it is:https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/560386/ [12:34:20] But It seems not a dependant from https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/560380/ ? [12:35:15] Subscriptshoe9: It depends on that commit, you can see that in "Relation chaim" section [12:35:40] however, when looking at https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/560380, it seems you named files cywikiquote-2.png, rather than cywikiquote-2x.png [12:35:42] 10MobileFrontend, 10Google-Code-in-2019, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2), 10good first task: Add shadow to nav menu drawer - https://phabricator.wikimedia.org/T231205 (10N3rsti) 05Open→03Resolved [12:35:43] could you rename them? [12:35:54] you'd need to git review -d the commit again [12:39:05] OK, give me a minuate [12:40:05] sure [12:40:12] (03PS3) 10Daniel Kinzler: XmlDumpWriter: fix blob address output in stubs [core] - 10https://gerrit.wikimedia.org/r/556344 [12:41:07] (03CR) 10Daniel Kinzler: "> Patch Set 2:" [core] - 10https://gerrit.wikimedia.org/r/556344 (owner: 10Daniel Kinzler) [12:42:14] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Patch-For-Review, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Edit fingerprint summaries are broken when only a single term is changed - https://phabricator.wikimedia.org/T241299 (10Addshore) [12:42:40] (03CR) 10Daniel Kinzler: [C: 03+2] User: better error message when getActorId fails. [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/559948 (https://phabricator.wikimedia.org/T211450) (owner: 10Paladox) [12:44:37] Urbanecm: OK here it is:https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/560388/ [12:45:48] Subscriptshoe9: you need to amend the previous commit, not upload a new one. Fetch the previous file commit with git review -d , move the files, do git commit -a --amend to alter the commit and send for review again [12:47:36] (03PS3) 10Abijeet Patro: Add support for keyboard events for the setlang dialog [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/559795 [12:48:30] I make these changes in a different way. First, I make a regular commit and then I run `git rebase -i origin/master` and squash the second commit. Feel free to do it with the commands whatever you want [12:50:25] (03Merged) 10jenkins-bot: User: better error message when getActorId fails. [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/559948 (https://phabricator.wikimedia.org/T211450) (owner: 10Paladox) [12:53:34] Urbanecm: i'm not sure if this is something you need to do or is done automatically, but are you able to get the latest version of flask-jsonlocale added to pypi? [12:56:32] IAmNetx: sure, I'll do a release soon [12:57:54] (03CR) 10Abijeet Patro: Add support for keyboard events for the setlang dialog (034 comments) [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/559795 (owner: 10Abijeet Patro) [12:58:47] Urbanecm OK, here it is https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/560380/ [13:01:23] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), 10Patch-For-Review, and 5 others: PHP Warning: preg_match(): Unknown modifier 'p' (from MwTimeIsoParser.php, API action=wbparsevalue) [8 story points] - https://phabricator.wikimedia.org/T237667 (10Addshore)... [13:01:30] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), 10User-Ladsgroup, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Alter rebuildItemTerms.php to allow passing of a a list of int item ids to process - https://phabricator.wikimedia.org/T240235 (10Addsh... [13:03:04] Subscriptshoe9: great. Could you now go to https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/560386 and press rebase? [13:04:07] Urbanecm OK, here it is [13:05:25] (03PS9) 10Addshore: Update datavalues/geo from 3.0.1 to 4.2.1 [vendor] - 10https://gerrit.wikimedia.org/r/550666 (https://phabricator.wikimedia.org/T215853) (owner: 10Rosalie Perside (WMDE)) [13:05:30] IAmNetx: you're making releasing easier for me :); done [13:05:32] (03CR) 10Addshore: "Added the depends-on" [vendor] - 10https://gerrit.wikimedia.org/r/550666 (https://phabricator.wikimedia.org/T215853) (owner: 10Rosalie Perside (WMDE)) [13:05:59] Urbanecm: thanks :) [13:06:06] my pleasure [13:06:56] Subscriptshoe9: okay, that should be it. I'd recommend to change commit message to just say "Add HD logos to IS.php" or something - it doesn't have to be prefixed with the uploading one [13:07:00] 10Social-Tools, 10SocialProfile: TypeError from line 873 of /srv/mediawiki/w/extensions/AbuseFilter/includes/AbuseFilterHooks.php: Argument 3 passed to AbuseFilterHooks::onUploadStashFile() must be of the type array, null given - https://phabricator.wikimedia.org/T241365 (10Paladox) [13:07:29] Subscriptshoe9: oh not, you lost the dependency :( [13:08:00] hit rebase, choose "Rebase on a specific change or ref" and fill in the change number of the file-uploading change [13:13:41] Urbanecm: Here it is, I’ve rebase it again and fix my commit https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/560386/ [13:14:11] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10I18n, 10Patch-For-Review, and 2 others: Localization of dates BCE on repo depends on precision - https://phabricator.wikimedia.org/T140541 (10Addshore) [13:14:19] Subscriptshoe9: nice! Could you just remove the first line (the one starting with "Upload") [13:14:36] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10I18n, 10Patch-For-Review, and 2 others: Localization of dates BCE on repo depends on precision - https://phabricator.wikimedia.org/T140541 (10Addshore) a:03matej_suchanek [13:14:51] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Patch-For-Review, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Edit fingerprint summaries are broken when only a single term is changed - https://phabricator.wikimedia.org/T241299 (10Addshore) a:03Ricordisamoa [13:15:02] Subscriptshoe9: for your future reference, have a look at https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines [13:15:09] Urbanecm: done [13:15:31] (03CR) 10Addshore: [C: 03+2] Catch bad params and throw error properly [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/560209 (https://phabricator.wikimedia.org/T229982) (owner: 10Ladsgroup) [13:16:08] (03CR) 10Abijeet Patro: [V: 03+1 C: 03+2] Use position:fixed instead of position:absolute [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/559775 (owner: 10Fomafix) [13:16:34] Subscriptshoe9: wonderful! I've asked jenkins, our automated software testing bot, to test your changes, but it should be good! [13:17:00] Subscriptshoe9: just the indentation, could you use tabs instead of spaces in IS.php? Thanks! [13:18:32] 10MediaWiki-API, 10Community-Tech, 10Core Platform Team, 10Technical-Debt: Add IP range support to list=usercontribs API - https://phabricator.wikimedia.org/T177150 (10WhitePhosphorus) [13:20:15] Urbanecm: Oh.. I used Xcode and Iost the indentation [13:21:27] Most IDEs have a way to autodetect indentation [13:22:53] OK now it should be work [13:24:41] great! let's see what jenkins says [13:27:13] I find a mistake, wait [13:28:50] Subscriptshoe9: seems we're missing a wgLogo entry - see jenkins's output [13:29:38] yes, I type the wrong filename in IS.php, I’ve fix it [13:30:45] Subscriptshoe9: you also need to add a wgLogo entry for cywikiquote [13:34:06] Urbanecm: pls review my task [13:35:22] Darth: mentors will review your task within 36 hours, be patient :P [13:36:21] yeah just asking if hes free to review right now [13:36:27] Urbanecm: OK, done [13:37:44] Subscriptshoe9: see Gerrit for my comment, could you please remove the trailing spaces? [13:39:54] Urbanecm: sorry for these spaces [13:39:58] Np :-) [13:41:06] Can anybody tell how to align a module to the right side of the page in wikipedia? [13:42:54] Specifically to the right side of contents table. [13:43:50] What do you mean, ComputerGuy ? [13:44:32] 10MediaWiki-API, 10Core Platform Team: API: action=parse with redirects=1 and pageid given leads to missingparam error - https://phabricator.wikimedia.org/T241362 (10SD0001) [13:47:02] 04(no projects): Tourist Places in Kerala - https://phabricator.wikimedia.org/T241366 (10Johnhardick) [13:47:37] Urbanecm: Thank you very much for teaching me to use git and gerrit, I'm sorry to take up so much of your time [13:48:05] Subscriptshoe9: almost done! Could you fix https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/560380's commit message, please? The first line would totally do :-) [13:48:09] No problem, I'm here to help you :) [13:48:43] (03CR) 10Abijeet Patro: [V: 04-1] "There are a few problems that I noticed while testing this on Firefox," [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/560353 (https://phabricator.wikimedia.org/T238834) (owner: 10Jack Phoenix) [13:49:08] Urbanecm: I need to embed the graphs from my sandbox to the wikiedia page. This one: https://codein.withgoogle.com/dashboard/task-instances/5091003157970944/ [13:49:22] *wikipedia [13:50:14] Hello Urbanecm! [13:50:26] hi alexunder, do I know you? 🙂 [13:50:28] (03Merged) 10jenkins-bot: Catch bad params and throw error properly [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/560209 (https://phabricator.wikimedia.org/T229982) (owner: 10Ladsgroup) [13:50:30] (03Merged) 10jenkins-bot: Use position:fixed instead of position:absolute [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/559775 (owner: 10Fomafix) [13:50:57] Subscriptshoe9: you also can remove the "Fix File Name" line – your commit adds the files with correct name, rather than fix the name :-). [13:51:36] Urbanecm, yes, i asked you to help with registration at the last week [13:52:13] Urbanecm: OK, done. [13:52:24] alexunder: i see [13:53:42] Subscriptshoe9: thanks! One more rebase, go to https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/560386, click "Rebase" and leave "Rebase on parent change" selected - that way, you'll not lose dependency information. [13:54:47] Urbanecm: Done,thanks [13:56:06] Subscriptshoe9: seems the dependency information got lost anyway? Could you go to https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/560386, hit rebase, choose Rebase on a specific change or ref and fill in the other change no, please? [13:56:36] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Growth-Team (Current Sprint), 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), 10Patch-For-Review: Newcomer tasks: do not refresh suggestions if user cancels difficulty filter - https://phabricator.wikimedia.org/T238172 (10RHo) Apologies but I am having a... [13:58:04] Urbanecm: sorry for miss the other change no. [13:58:23] no problem :) [14:00:39] Subscriptshoe9: looks good, thanks! Feel free to submit via GCI! [14:00:53] Thank you very much QwQ [14:01:10] Happy to help! [14:02:06] (03PS1) 10Yashvarshney02: Modified GCI Introduction File [sandbox] - 10https://gerrit.wikimedia.org/r/560391 [14:02:08] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [sandbox] - 10https://gerrit.wikimedia.org/r/560391 (owner: 10Yashvarshney02) [14:05:17] (03PS1) 10Paladox: Change ref_src_wiki column to a "text" from a "varchar" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/560392 [14:05:24] Urbanecm, could you help me: i doesn't understand how i could to do this task on my PC(https://phabricator.wikimedia.org/T182213), i can't find how to download this [14:05:35] (03PS2) 10Paladox: Change ref_src_wiki column to a "text" from a "varchar" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/560392 [14:06:13] alexunder: could you ask a more specific question, please? [14:07:33] Urbanecm, how i could download this? [14:07:45] (03CR) 10jerkins-bot: [V: 04-1] Change ref_src_wiki column to a "text" from a "varchar" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/560392 (owner: 10Paladox) [14:08:09] alexunder: how to download _what_? [14:10:15] Urbanecm, project how i think, message before i sent the link(https://phabricator.wikimedia.org/T182213) or how i should do this? [14:10:42] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Patch-For-Review, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Edit fingerprint summaries are broken when only a single term is changed - https://phabricator.wikimedia.org/T241299 (10Ladsgroup) Should we backport? {meme, src="shits-on-fire"} [14:13:48] Urbanecm: can u review my task ? :) [14:14:03] (03PS3) 10Paladox: Increase ref_src_wiki varchar to 255 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/560392 [14:14:25] Darth: please be patient. Your task is waiting in the queue for just 9 hours. Mentors have up to 36 hours to review your task, and also have other commitments besides GCI [14:14:40] oh ok [14:15:40] Ebe123: Hi! [14:15:45] Hello! [14:16:25] Can you say me how to align the graph to the right side of the page? [14:16:35] (03PS4) 10Paladox: Increase ref_src_wiki varchar to 255 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/560392 [14:16:54] Specifically to the right side of contents. [14:16:56] (03PS5) 10Paladox: Increase ref_src_wiki varchar size to 255 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/560392 [14:17:49] ComputerGuy, i think you could to use table for this [14:18:56] using a table is not a good design [14:20:04] (03CR) 10Ebe123: [C: 04-1] "Look at my comment. Making sure your patch doesn't show warnings is an important part of submitting patches." (031 comment) [sandbox] - 10https://gerrit.wikimedia.org/r/560391 (owner: 10Yashvarshney02) [14:20:20] (03PS4) 10Paladox: Split SQL files out [extensions/Flow] - 10https://gerrit.wikimedia.org/r/470946 [14:20:36] (03CR) 10Ebe123: [V: 03+2 C: 03+2] Modified GCI Introduction File [sandbox] - 10https://gerrit.wikimedia.org/r/560391 (owner: 10Yashvarshney02) [14:21:31] style="align: right;"? [14:22:18] what is meant by license here ? https://codein.withgoogle.com/tasks/6708351686148096/?sp-organization=6260468339965952&sp-is_beginner=False&sp-categories=2&sp-search=design [14:23:29] Darth: You can read https://en.wikipedia.org/wiki/License [14:24:04] Darth, about the 4:44am message, guess my computer went out of sleep-mode. I was still asleep though [14:24:22] (03PS2) 10Yashvarshney02: Modified GCI Introduction File [sandbox] - 10https://gerrit.wikimedia.org/r/560391 [14:24:28] ok :) [14:24:52] You could wrap the chart in a
HTML tag, with the style attribute, CG [14:25:09] ComputerGuy: can't find anything better than Ebe123 suggests [14:25:45] float: right also could help [14:26:39] 10MediaWiki-extensions-RandomImage: Error: 1176 Key 'page_random' doesn't exist in table 'image' - https://phabricator.wikimedia.org/T241368 (10Paladox) [14:27:27] (03PS1) 10Anomie: ApiParse: Fix handling of pageid + redirects when passed a non-redirect [core] - 10https://gerrit.wikimedia.org/r/560393 (https://phabricator.wikimedia.org/T241362) [14:27:39] 10MediaWiki-API, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review: API: action=parse with redirects=1 and pageid given leads to missingparam error - https://phabricator.wikimedia.org/T241362 (10Anomie) [14:29:09] Ebe123: Can you say me what is wrong here? I think I made some mistakes, it is not aligning. Link: https://en.wikipedia.org/wiki/User:ComputerGuy101/sandbox#Graphs [14:29:36] I tried it for GSoC [14:30:11] 10Phabricator: Space request for Communications - https://phabricator.wikimedia.org/T241358 (10Aklapper) p:05Triage→03Normal a:03Aklapper [14:30:12] ComputerGuy: I believe the correct CSS would be text-align: right [14:30:45] 10MediaWiki-API, 10Core Platform Team: When image info query fails allimages generator fails irrecoverably leaving no continuation token - https://phabricator.wikimedia.org/T241275 (10Anomie) [14:30:47] 10MediaWiki-API, 10Core Platform Team: Bad metadata for a single file errors out the complete imageinfo prop request - https://phabricator.wikimedia.org/T201205 (10Anomie) [14:31:27] (03PS1) 10Paladox: Remove usage of setEditSection in ParserOptions [extensions/News] - 10https://gerrit.wikimedia.org/r/560394 [14:31:49] 10MediaWiki-API: Bad metadata for a single file errors out the complete imageinfo prop request - https://phabricator.wikimedia.org/T201205 (10Anomie) [14:32:10] Urbanecm, i can't to fing how i could download code of this task https://phabricator.wikimedia.org/T182213 [14:32:14] Urbanecm: Thanks! It's working. Thank you Ebe123 for giving the idea. :-) I'll come back soon. [14:32:44] 10MediaWiki-API, 10Community-Tech, 10Technical-Debt: Add IP range support to list=usercontribs API - https://phabricator.wikimedia.org/T177150 (10Anomie) [14:32:52] yw ComputerGuy [14:33:06] (03CR) 10Ammarpad: [C: 03+2] Modified GCI Introduction File [sandbox] - 10https://gerrit.wikimedia.org/r/560391 (owner: 10Yashvarshney02) [14:33:17] 10MediaWiki-API, 10MediaWiki-extensions-CentralNotice, 10good first task: Don't enable API modules on wikis where they aren't used - https://phabricator.wikimedia.org/T47920 (10Anomie) [14:33:19] (03CR) 10Ammarpad: [V: 03+2 C: 03+2] Modified GCI Introduction File [sandbox] - 10https://gerrit.wikimedia.org/r/560391 (owner: 10Yashvarshney02) [14:34:01] (03PS2) 10Paladox: Remove usage of setEditSection in ParserOptions [extensions/News] - 10https://gerrit.wikimedia.org/r/560394 [14:34:20] (03CR) 10Paladox: Remove usage of setEditSection in ParserOptions (031 comment) [extensions/News] - 10https://gerrit.wikimedia.org/r/560394 (owner: 10Paladox) [14:34:35] Urbanecm: I started translating Tracker into Spanish, my native language. Do I need to send a path to enable the translation (add to LANGUAGES, etc)? [14:35:29] alcarazzam: Yup, adding to LANGUAGES should be enough. It can be merged as soon as Translatewiki.net exports the translations into Tracker [14:35:53] alexunder, there is no code in particular [14:36:22] GCI link? [14:37:09] (What I'd guess is the task is to fix the bug within an extension) [14:37:34] (03CR) 10Fomafix: [C: 04-1] "IE/Edge missing (-1)." (031 comment) [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/559795 (owner: 10Abijeet Patro) [14:40:39] Ebe123, how i could to work with this to fix this? GCI: https://codein.withgoogle.com/tasks/5342842885505024/?sp-organization=6260468339965952&sp-is_beginner=False&sp-search=php [14:40:42] 10Social-Tools, 10SocialProfile: TypeError from line 873 of /srv/mediawiki/w/extensions/AbuseFilter/includes/AbuseFilterHooks.php: Argument 3 passed to AbuseFilterHooks::onUploadStashFile() must be of the type array, null given - https://phabricator.wikimedia.org/T241365 (10Paladox) 05Open→03Declined Actua... [14:41:18] 10Genealogy: Allow configuring Genealogy to be used in name spaces other than the main space - https://phabricator.wikimedia.org/T241172 (10Hispano76) @Samwilson Thank you very much, I'll check it out. I'll let you know if there's a problem or I have suggestions. Greetings. [14:47:18] 04(no projects): Blame tool didn't find edit - https://phabricator.wikimedia.org/T241369 (10Macrakis) [14:47:28] Now that I look at it, the task would be better if we give specific extensions where these problems are found [14:48:13] (03CR) 10Paladox: "This is causing log spam for MediaWiki 1.34:" [core] - 10https://gerrit.wikimedia.org/r/533981 (owner: 10Tim Starling) [14:49:08] 10MediaWiki-Revision-backend, 10Technical-Debt: Remove support for wgLegacySchemaConversion and HistoryBlobCurStub - https://phabricator.wikimedia.org/T241312 (10Anomie) > given we already migrated another place to store content ({T183489}) That task was about finally migrating a relatively small amount of ol... [14:49:36] I'd look at another task for now [14:50:50] 10MediaWiki-General: PHP Notice: Constant MW_ENTRY_POINT already defined in /srv/mediawiki/w/thumb.php on line 28 - https://phabricator.wikimedia.org/T241340 (10Paladox) This is causing a lot of log spam. I guess it's because thumb_handler calls thumb.php? [14:53:30] Ebe123, ok, thank you! [14:56:50] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Select language to read an article - https://phabricator.wikimedia.org/T234628 (10hueitan) In `Change language (article)` section, follow the same pattern as iOS Wikipedia Apps, we show only the `Other Languages` due to the current API limitation without returning... [14:57:02] 10Who-Wrote-That, 10Community-Tech (Kanban-Q2-2019-20): WWT: Adjust Username Appearance [high priority] [medium] - https://phabricator.wikimedia.org/T240707 (10dom_walden) > **Acceptance Criteria:** > * Remove the display of the username/IP address from the information bar in WWT Done. > * Keep the highlight... [15:09:38] 10AbuseFilter, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07): Confusing error message for abusefilter-exception-variablevariable - https://phabricator.wikimedia.org/T238713 (10Daimona) 05Open→03Resolved [15:14:09] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/560401 (owner: 10L10n-bot) [15:16:04] (03CR) 10RhinosF1: "Can someone edit commit message to have https://phabricator.wikimedia.org/T232351 in" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/560392 (owner: 10Paladox) [15:17:46] (03CR) 10Addshore: [C: 03+2] Update datavalues/geo from 3.0.1 to 4.2.1 [vendor] - 10https://gerrit.wikimedia.org/r/550666 (https://phabricator.wikimedia.org/T215853) (owner: 10Rosalie Perside (WMDE)) [15:18:34] (03CR) 10RhinosF1: "> Patch Set 5:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/560392 (owner: 10Paladox) [15:19:26] (03PS6) 10Paladox: Increase ref_src_wiki varchar size to 255 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/560392 (https://phabricator.wikimedia.org/T232351) [15:20:00] 10MediaWiki-Vendor, 10Wikidata, 10wikidata-tech-focus, 10MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), and 3 others: Wikidata vendor version updates (Feb 2019) - https://phabricator.wikimedia.org/T215853 (10Addshore) Everything is merging now [15:20:17] (03CR) 10RhinosF1: [C: 03+1] Increase ref_src_wiki varchar size to 255 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/560392 (https://phabricator.wikimedia.org/T232351) (owner: 10Paladox) [15:22:25] 10Who-Wrote-That, 10Community-Tech (Kanban-Q2-2019-20): Who Wrote That? link is slightly bigger than you think - https://phabricator.wikimedia.org/T239842 (10dom_walden) >>! In T239842#5752904, @Samwilson wrote: >> I am seeing the WWT link on pages like the Main_Page or in other namespaces (e.g. User_talk). >... [15:26:06] 10MediaWiki-Vendor, 10Wikidata, 10wikidata-tech-focus, 10MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), and 3 others: Wikidata vendor version updates (Feb 2019) - https://phabricator.wikimedia.org/T215853 (10Addshore) I removed my +2 from the 4.2.1 geo patch, as Wikibase isn't yet using 4.2.1 of geo, so mw-vend... [15:34:10] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/560401 (owner: 10L10n-bot) [15:38:17] (03CR) 10jerkins-bot: [V: 04-1] Update datavalues/geo from 3.0.1 to 4.2.1 [vendor] - 10https://gerrit.wikimedia.org/r/550666 (https://phabricator.wikimedia.org/T215853) (owner: 10Rosalie Perside (WMDE)) [15:39:12] (03PS10) 10Addshore: Update datavalues/geo from 3.0.1 to 4.2.1 [vendor] - 10https://gerrit.wikimedia.org/r/550666 (https://phabricator.wikimedia.org/T215853) (owner: 10Rosalie Perside (WMDE)) [15:40:23] (03CR) 10Addshore: [C: 03+2] "This wont merge until both the depends-on are merged." [vendor] - 10https://gerrit.wikimedia.org/r/550666 (https://phabricator.wikimedia.org/T215853) (owner: 10Rosalie Perside (WMDE)) [15:45:20] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Empty state for Search when user's device is offline - https://phabricator.wikimedia.org/T241171 (10SBisson) a:03SBisson [15:47:36] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Article page menu - https://phabricator.wikimedia.org/T236266 (10SBisson) a:03hueitan This task is for the menu itself. The items will come one at a time as the features are being developed. I think this is done. [15:53:35] 10Code-Review-Workgroup, 10Developer-Advocacy: Find out which Git/Gerrit code repositories deployed on WMF sites have no reviewers/watchers in Gerrit? - https://phabricator.wikimedia.org/T196985 (10Aklapper) 05Open→03Declined Very good points, thanks. My underlying assumption that all/most people use mail... [15:57:32] 10MediaWiki-extensions-RandomImage: Error: 1176 Key 'page_random' doesn't exist in table 'image' - https://phabricator.wikimedia.org/T241368 (10Aklapper) The maintainer's user page ( https://www.mediawiki.org/wiki/User:Robchurch ) states "I am not currently involved in developing the MediaWiki software or extens... [15:59:00] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "You, Isarra and Jack, are very experienced developers. This is certainly neither the first commit message you write, nor the first time yo" [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/559458 (owner: 10Jack Phoenix) [16:03:48] (03CR) 10Daimona Eaytoy: Always evaluate the offset when retrieving array elements (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/548968 (https://phabricator.wikimedia.org/T237351) (owner: 10Daimona Eaytoy) [16:04:49] (03PS4) 10Daimona Eaytoy: Always evaluate the offset when retrieving array elements [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/548968 (https://phabricator.wikimedia.org/T237351) [16:06:34] (03CR) 10Daimona Eaytoy: Add site name and language variables (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/558567 (https://phabricator.wikimedia.org/T240948) (owner: 10Daimona Eaytoy) [16:06:57] (03PS5) 10Daimona Eaytoy: Add site name and language variables [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/558567 (https://phabricator.wikimedia.org/T240948) [16:17:06] (03PS1) 10Addshore: "wikimedia/assert": ">=0.1 <0.4" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/560411 [16:17:41] (03PS2) 10Thiemo Kreuz (WMDE): Fix incomplete QuestionGameUploadForm::show() [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/559456 (owner: 10Jack Phoenix) [16:17:47] (03CR) 10jerkins-bot: [V: 04-1] Fix incomplete QuestionGameUploadForm::show() [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/559456 (owner: 10Jack Phoenix) [16:18:51] (03CR) 10Ladsgroup: "wikimedia/assert": ">=0.1 <0.4" (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/560411 (owner: 10Addshore) [16:19:57] (03PS3) 10Thiemo Kreuz (WMDE): Rewrite hard to understand QuestionGameUploadForm::show() [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/559456 (owner: 10Jack Phoenix) [16:22:52] (03CR) 10Thiemo Kreuz (WMDE): "I tried to rebase this and learned the original bug was fixed in the meantime via Iea20400. I ended redoing this patch anyway. Now it remo" [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/559456 (owner: 10Jack Phoenix) [16:23:36] (03CR) 10TheDJ: [C: 03+1] "I have no objection to this. You @brion ?" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/560118 (https://phabricator.wikimedia.org/T240368) (owner: 10Thomas Jensen) [16:24:51] 10Wikidata-Termbox: Investigate Timeouts in production - https://phabricator.wikimedia.org/T230976 (10Aklapper) @Tarrow: No reply, hence adding #wikidata-termbox so this task is displayed on a workboard of an active project. [16:24:53] 10Wikidata-Termbox: Termbox service is logging timeouts mostly on codfw - https://phabricator.wikimedia.org/T229313 (10Aklapper) @Tarrow: No reply, hence adding #wikidata-termbox so this task is displayed on a workboard of an active project. [16:24:55] (03CR) 10Brion VIBBER: [C: 03+2] "looks good!" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/560118 (https://phabricator.wikimedia.org/T240368) (owner: 10Thomas Jensen) [16:28:59] (03PS2) 10Addshore: "wikimedia/assert": ">=0.1 <0.5" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/560411 [16:30:24] 10Desktop Improvements, 10TechCom-RFC, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): RFC: Where to implement Desktop Improvements project - https://phabricator.wikimedia.org/T234907 (10Bawolff) >>! In T234907#5760432, @pmiazga wrote: > I just wanted to highlight that we need to take precautions while working... [16:30:39] (03Merged) 10jenkins-bot: Update datavalues/geo from 3.0.1 to 4.2.1 [vendor] - 10https://gerrit.wikimedia.org/r/550666 (https://phabricator.wikimedia.org/T215853) (owner: 10Rosalie Perside (WMDE)) [16:31:23] 10OpenRefine, 10Wiki-Techstorm-2019: Import Publons journal IDs in Wikidata - https://phabricator.wikimedia.org/T238348 (10Aklapper) @Layka100: Hi! This task has been assigned to you a while ago. Could you maybe share an update? Do you still plan to work on this task, or [do you need any help](https://www.medi... [16:31:47] 10Wiki-Techstorm-2019: Import list of nationalities in Northern Saami into Wikidata - https://phabricator.wikimedia.org/T238923 (10Aklapper) @Mewasul: Hi! This task has been assigned to you a while ago. Could you maybe share an update? Do you still plan to work on this task, or [do you need any help](https://www... [16:32:42] 10Wiki-Techstorm-2019: Combine list of nationalities in English, Esperanto, and Northern Saami - https://phabricator.wikimedia.org/T238922 (10Aklapper) @Mewasul: Hi! This task has been assigned to you a while ago. Could you maybe share an update? Do you still plan to work on this task, or [do you need any help](... [16:36:30] (03CR) 10Ladsgroup: [C: 03+2] "wikimedia/assert": ">=0.1 <0.5" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/560411 (owner: 10Addshore) [16:37:58] 10Research: Literature review of external reuse of Wikimedia content - https://phabricator.wikimedia.org/T235780 (10Isaac) The full document is here (https://docs.google.com/document/d/1moL_JjZLJS-FlnEMrgeoqYmTgA6nqidQVjSn4JO1Jlg/edit#heading=h.bmvp8tvrk94e) but is currently internal until I ensure none of the d... [16:41:46] 10Developer-Advocacy (Oct-Dec 2019): Find workflow how to consistently follow up on new contributors claiming their first development task in Phab - https://phabricator.wikimedia.org/T227388 (10Aklapper) 05Open→03Resolved Went through the "USER ACCOUNTS WHO BECAME AN ASSIGNEE LAST WEEK AND HAD LESS THAN 5 TA... [16:42:12] (03CR) 10Daimona Eaytoy: [C: 03+2] "Thanks, I still find this useful. First, because if the intention is not to add the JS, then the method to be overridden is the one that a" [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/559456 (owner: 10Jack Phoenix) [16:42:17] (03Merged) 10jenkins-bot: WebVideoTranscodeJob: Clear transcode error timestamp on success [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/560118 (https://phabricator.wikimedia.org/T240368) (owner: 10Thomas Jensen) [16:42:19] (03Merged) 10jenkins-bot: "wikimedia/assert": ">=0.1 <0.5" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/560411 (owner: 10Addshore) [16:45:11] 10Research: Literature review of external reuse of Wikimedia content - https://phabricator.wikimedia.org/T235780 (10Isaac) [16:45:13] 10Research: Taxonomy of re-use and current knowledge of the effect on traffic to Wikimedia - https://phabricator.wikimedia.org/T235781 (10Isaac) 05Open→03Resolved High-level summary is below. The [[https://docs.google.com/document/d/1moL_JjZLJS-FlnEMrgeoqYmTgA6nqidQVjSn4JO1Jlg/edit#|doc]] has more examples a... [16:45:30] (03Merged) 10jenkins-bot: Rewrite hard to understand QuestionGameUploadForm::show() [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/559456 (owner: 10Jack Phoenix) [16:46:05] (03CR) 10Daimona Eaytoy: "FTR, something that I wanted to write a couple of days ago but forgot to." [core] - 10https://gerrit.wikimedia.org/r/559901 (https://phabricator.wikimedia.org/T21605) (owner: 10Ammarpad) [16:49:17] (03CR) 10Ori.livneh: Add option to override storeClass in rebuildLocalisationCache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/560342 (https://phabricator.wikimedia.org/T105683) (owner: 10Ladsgroup) [16:50:15] 10Phabricator, 10Security-Team: Cleanup S11 space and define its use more clearly - https://phabricator.wikimedia.org/T240384 (10chasemp) All S11 tasks moved or closed https://phabricator.wikimedia.org/maniphest/query/X3imiKkrWgl9/#R [16:51:47] (03CR) 10Jack Phoenix: [C: 03+2] "Tested on my MW 1.34rc1 against a remote wiki running 1.31.6 and this seems to be working as advertised, yay!" [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/559286 (https://phabricator.wikimedia.org/T228815) (owner: 10Skizzerz) [16:53:55] (03Merged) 10jenkins-bot: Make edit attribution actor-aware [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/559286 (https://phabricator.wikimedia.org/T228815) (owner: 10Skizzerz) [16:59:27] 10Phabricator, 10Security-Team: Create 'user affiliation' custom drop down field for forms - https://phabricator.wikimedia.org/T240999 (10chasemp) [16:59:39] 10Phabricator, 10Security-Team: Create 'user affiliation' custom drop down field for forms - https://phabricator.wikimedia.org/T240999 (10chasemp) [17:00:31] 10Phabricator, 10Security-Team: Create 'user affiliation' custom drop down field for forms - https://phabricator.wikimedia.org/T240999 (10chasemp) [17:01:39] 10Phabricator, 10Security-Team: Create 'user affiliation' custom drop down field for forms - https://phabricator.wikimedia.org/T240999 (10chasemp) [17:03:43] 10Phabricator, 10Security-Team: Create 'user affiliation' custom drop down field for forms - https://phabricator.wikimedia.org/T240999 (10chasemp) >>! In T240999#5749198, @Aklapper wrote: > I'd say most options listed above should have a "WMF" prefix and Community should be plural. Being picky, `Audiences` has... [17:05:25] 10Research: Identify data / questions that we can(not) answer regarding external reuse - https://phabricator.wikimedia.org/T235784 (10Isaac) 05Open→03Resolved In the course of the literature review, I identified the data that we have available to us and improvements that could be made to this data in order t... [17:05:27] 10Research: Literature review of external reuse of Wikimedia content - https://phabricator.wikimedia.org/T235780 (10Isaac) [17:06:32] 10Research: Literature review of external reuse of Wikimedia content - https://phabricator.wikimedia.org/T235780 (10Isaac) I will leave this task open while the external referer data subtask is still open, but I consider the literature review complete at this stage and ready for the next stages of sharing out, i... [17:07:00] 10Security-Team, 10Security: Security Issue Access Request for Pchelolo - https://phabricator.wikimedia.org/T241079 (10chasemp) >>! In T241079#5751988, @Aklapper wrote: > See https://www.mediawiki.org/wiki/Security/SOP/Access_to_Phabricator_Security_Issues for requirements. > > Not sure how much Security Team... [17:07:20] 10Security-Team, 10Security: Security Issue Access Request for Pchelolo - https://phabricator.wikimedia.org/T241079 (10chasemp) p:05Triage→03Normal [17:10:09] 10Research: Keep research.wikipedia.org landing page updated - https://phabricator.wikimedia.org/T219903 (10Isaac) [17:11:06] (03PS1) 10Octfx: Change method of setting and retrieving page props [extensions/WikiSEO] - 10https://gerrit.wikimedia.org/r/560414 [17:11:52] 10Security-Team, 10Security: Security Issue Access Request for Pchelolo - https://phabricator.wikimedia.org/T241079 (10chasemp) Clarifying note: we are talking about the WMF on-wiki account linked to your phab profile. The phab username has no enforced conventions. Some use WMF in the name and some do note.... [17:12:11] 10MediaWiki-API, 10Core Platform Team, 10Security-Team: ApiHelp on api.php should set OutputPage::disallowUserJs - https://phabricator.wikimedia.org/T132720 (10chasemp) [17:12:16] 10MediaWiki-ContentHandler, 10Security-Team, 10Patch-For-Review, 10User-Daniel: RawAction should set proper Content-Type header - https://phabricator.wikimedia.org/T178060 (10chasemp) [17:12:18] 10MediaWiki-Page-protection, 10Security-Team, 10JavaScript, 10Security: Only allow MediaWiki, Gadget, and User namespace pages to be treated as JS or CSS (no project namespace, etc.) - https://phabricator.wikimedia.org/T171563 (10chasemp) [17:12:20] 10MediaWiki-extensions-LoginNotify, 10Security-Team, 10Voice & Tone: Reword notification of failed logins to avoid unnecessary password changes - https://phabricator.wikimedia.org/T194385 (10chasemp) [17:12:24] 10MediaWiki-extensions-OAuth, 10Security-Team, 10Security: Require elevated session security for giving elevated permissions - https://phabricator.wikimedia.org/T194398 (10chasemp) [17:12:26] 10MediaWiki-Codesniffer, 10Security-Team, 10Security: Security related Static Analysis - https://phabricator.wikimedia.org/T192207 (10chasemp) [17:12:29] 10MediaWiki-Documentation, 10MediaWiki-General, 10MediaWiki-Vendor, 10Security-Team, and 3 others: Remove requirement for security review of well maintained third party libraries - https://phabricator.wikimedia.org/T192453 (10chasemp) [17:12:31] 10MediaWiki-extensions-OATHAuth, 10Security-Team, 10Trust-and-Safety, 10Wikimedia-Site-requests, 10Security: Allow all users on all wikis to use OATHAuth - https://phabricator.wikimedia.org/T166622 (10chasemp) [17:12:33] 10Security-Team, 10Wikimedia-General-or-Unknown, 10Documentation, 10Security: Add security.txt to Wikimedia sites? - https://phabricator.wikimedia.org/T187617 (10chasemp) [17:12:35] 10GitHub-Mirrors, 10Security-Team: Dealing with GitHub security alerts - https://phabricator.wikimedia.org/T180877 (10chasemp) [17:12:37] 10CheckUser, 10Security-Team, 10Stewards-and-global-tools, 10WMF-Legal, 10Privacy: Reveal email recipient's username in checkuser query results - https://phabricator.wikimedia.org/T189943 (10chasemp) [17:12:38] 10MediaWiki-Authentication-and-authorization, 10Growth-Team, 10Notifications, 10Security-Team, 10Security: Security checkup/reminder for verifying email and authentication details - https://phabricator.wikimedia.org/T184208 (10chasemp) [17:12:42] 10MediaWiki-User-preferences, 10Security-Team: Allow logged in users to disable MediaWiki:Common.js and MediaWiki:Common.css - https://phabricator.wikimedia.org/T177895 (10chasemp) [17:12:46] 10Security-Team, 10Trust-and-Safety, 10Wikimedia-General-or-Unknown: Spambots as IP addresses and as accounts again prolific within WMF wikis - https://phabricator.wikimedia.org/T174877 (10chasemp) [17:12:48] 10Security-Team, 10Goal: Become a CVE Numbering Authority (CNA) for MediaWiki and extensions - https://phabricator.wikimedia.org/T162171 (10chasemp) [17:12:50] 10MediaWiki-User-login-and-signup, 10Security-Team: Throttle IP when doing many successful login attemps - https://phabricator.wikimedia.org/T150580 (10chasemp) [17:12:52] 10Security-Team, 10Developer-Wishlist (2017), 10Documentation: Add examples of the three security review processes - https://phabricator.wikimedia.org/T156757 (10chasemp) [17:12:54] 10Security-Team, 10Wikimedia-Site-requests: Deploy EncryptedPassword to WMF - https://phabricator.wikimedia.org/T150647 (10chasemp) [17:12:56] 10MediaWiki-User-login-and-signup, 10Security-Team: Prevent user from continuing until they change their password - https://phabricator.wikimedia.org/T149743 (10chasemp) [17:12:58] 10Security-Team, 10Wikimedia-Site-requests: Enable $wgCaptchaDeleteOnSolve - https://phabricator.wikimedia.org/T150049 (10chasemp) [17:13:00] 10MediaWiki-User-login-and-signup, 10AntiSpoof, 10Security-Team: Create password policy using AntiSpoof - https://phabricator.wikimedia.org/T149588 (10chasemp) [17:13:04] (03CR) 10Octfx: "There are some reports that the pageprops are not getting written. I am guessing that there could be a problem with setting everything as " [extensions/WikiSEO] - 10https://gerrit.wikimedia.org/r/560414 (owner: 10Octfx) [17:13:09] (03CR) 10jerkins-bot: [V: 04-1] Change method of setting and retrieving page props [extensions/WikiSEO] - 10https://gerrit.wikimedia.org/r/560414 (owner: 10Octfx) [17:13:11] 10MediaWiki-Uploading, 10Multimedia, 10Security-Team, 10Wikimedia-SVG-rendering: SVG Upload should (optionally) allow the xhtml namespace - https://phabricator.wikimedia.org/T138783 (10chasemp) [17:13:14] 10MediaWiki-User-login-and-signup, 10Security-Team, 10Tracking-Neverending: Password/login related security issues (Tracking) - https://phabricator.wikimedia.org/T122248 (10chasemp) [17:13:16] 10MediaWiki-extensions-OATHAuth, 10Security-Team: Design research support for two step authentication - https://phabricator.wikimedia.org/T124445 (10chasemp) [17:13:19] 10Security-Team, 10Wikimedia-Site-requests: Implement results of enwiki Security review RfC - https://phabricator.wikimedia.org/T121186 (10chasemp) [17:13:21] 10Security-Team: Create preference to control using personal JS - https://phabricator.wikimedia.org/T120889 (10chasemp) [17:13:23] 10Security-Team: Create optional XSS filter step for the parser - https://phabricator.wikimedia.org/T120888 (10chasemp) [17:13:25] 10MediaWiki-User-management, 10Security-Team: Consider using "pepper" for our hashed passwords - https://phabricator.wikimedia.org/T119451 (10chasemp) [17:13:28] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-CentralAuth, 10Security-Team, 10Core Platform Team Legacy (Later), 10Services (later): Create password-authentication service for use by CentralAuth - https://phabricator.wikimedia.org/T120484 (10chasemp) [17:13:30] 10Developer-Advocacy, 10Security-Team: Credit security researchers that identify and disclose vulnerabilities - https://phabricator.wikimedia.org/T118131 (10chasemp) [17:13:34] 10MediaWiki-extensions-OAuth, 10Security-Team: Allow OAuth applications to be granted rights the user doesn't have - https://phabricator.wikimedia.org/T110249 (10chasemp) [17:13:36] 10Security-Team, 10Privacy: Privacy review of graphite and grafana data sets - https://phabricator.wikimedia.org/T109726 (10chasemp) [17:13:38] 10MediaWiki-extensions-OATHAuth, 10Security-Team: Improve user experience of Two-Factor process - https://phabricator.wikimedia.org/T100375 (10chasemp) [17:13:40] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-Email, 10MediaWiki-User-login-and-signup, 10Security-Team: Notify user by email when password changed - https://phabricator.wikimedia.org/T28227 (10chasemp) [17:19:09] 10MediaWiki-extensions-LoginNotify, 10Security-Team, 10Voice & Tone: Reword notification of failed logins to avoid unnecessary password changes - https://phabricator.wikimedia.org/T194385 (10chasemp) p:05Triage→03Normal [17:19:11] 10GitHub-Mirrors, 10Security-Team: Dealing with GitHub security alerts - https://phabricator.wikimedia.org/T180877 (10chasemp) p:05Triage→03Normal [17:19:14] 10MediaWiki-User-preferences, 10Security-Team: Allow logged in users to disable MediaWiki:Common.js and MediaWiki:Common.css - https://phabricator.wikimedia.org/T177895 (10chasemp) p:05Triage→03Normal [17:19:16] 10Security-Team, 10Trust-and-Safety, 10Wikimedia-General-or-Unknown: Spambots as IP addresses and as accounts again prolific within WMF wikis - https://phabricator.wikimedia.org/T174877 (10chasemp) p:05Triage→03Normal [17:19:18] 10MediaWiki-ContentHandler, 10Security-Team, 10Patch-For-Review, 10User-Daniel: RawAction should set proper Content-Type header - https://phabricator.wikimedia.org/T178060 (10chasemp) p:05Triage→03Normal [17:19:22] 10Security-Team, 10Goal: Become a CVE Numbering Authority (CNA) for MediaWiki and extensions - https://phabricator.wikimedia.org/T162171 (10chasemp) p:05Triage→03Normal [17:19:26] 10Security-Team, 10Developer-Wishlist (2017), 10Documentation: Add examples of the three security review processes - https://phabricator.wikimedia.org/T156757 (10chasemp) p:05Triage→03Normal [17:19:26] 10MediaWiki-User-login-and-signup, 10Security-Team: Throttle IP when doing many successful login attemps - https://phabricator.wikimedia.org/T150580 (10chasemp) p:05Triage→03Normal [17:19:28] 10Security-Team, 10Wikimedia-Site-requests: Deploy EncryptedPassword to WMF - https://phabricator.wikimedia.org/T150647 (10chasemp) p:05Triage→03Normal [17:19:35] 10MediaWiki-User-login-and-signup, 10Security-Team, 10Tracking-Neverending: Password/login related security issues (Tracking) - https://phabricator.wikimedia.org/T122248 (10chasemp) p:05Triage→03Normal [17:19:38] 10Security-Team: Create optional XSS filter step for the parser - https://phabricator.wikimedia.org/T120888 (10chasemp) p:05Triage→03Normal [17:19:40] 10Security-Team: Create preference to control using personal JS - https://phabricator.wikimedia.org/T120889 (10chasemp) p:05Triage→03Normal [17:19:42] 10MediaWiki-User-management, 10Security-Team: Consider using "pepper" for our hashed passwords - https://phabricator.wikimedia.org/T119451 (10chasemp) p:05Triage→03Normal [17:19:44] 10Developer-Advocacy, 10Security-Team: Credit security researchers that identify and disclose vulnerabilities - https://phabricator.wikimedia.org/T118131 (10chasemp) p:05Triage→03Normal [17:24:49] 10MediaWiki-General, 10Patch-For-Review, 10Technical-Debt (Deprecation process), 10User-DannyS712: Drop `$wgSkipSkin`, deprecated in 1.23 and unused - https://phabricator.wikimedia.org/T241342 (10Aklapper) Assuming this task is about #MediaWiki-General, hence adding project tag so others can find this task... [17:25:00] 10MediaWiki-General, 10Patch-For-Review, 10Technical-Debt (Deprecation process), 10User-DannyS712: Drop `$wgProfileOnly`, deprecated in 1.23 and unused - https://phabricator.wikimedia.org/T241343 (10Aklapper) Assuming this task is about #MediaWiki-General, hence adding project tag so others can find this t... [17:25:59] 10MediaWiki-General, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove Title::isValidMoveOperation(), ::moveTo(), and ::isValidMoveTarget() (deprecated in favor of MovePage's methods) - https://phabricator.wikimedia.org/T241341 (10Aklapper) Assuming this task is about #MediaWiki-General, henc... [17:26:41] 10MediaWiki-extensions-UserMerge, 10Patch-For-Review, 10Technical-Debt (Deprecation process), 10User-DannyS712: Remove uses of Title::isValidMoveTarget in favor of MovePage::isValidMoveTarget - https://phabricator.wikimedia.org/T241339 (10Aklapper) Assuming this task is about #MediaWiki-extensions-UserMerg... [17:28:45] 10Security-Team, 10Security: Security issue access for darthmon_wmde - https://phabricator.wikimedia.org/T238547 (10chasemp) >>! In T238547#5679298, @chasemp wrote: > Please enable 2fa as indicated in step 3 of the [[ https://www.mediawiki.org/wiki/Security/SOP/Access_to_Phabricator_Security_Issues | SOP ]]... [17:39:05] 10Phabricator, 10Security-Team: Create 'user affiliation' custom drop down field for forms - https://phabricator.wikimedia.org/T240999 (10chasemp) [17:40:17] 10Who-Wrote-That, 10Community-Tech (Kanban-Q2-2019-20): WWT: Good article badge comes over the WWT bar - https://phabricator.wikimedia.org/T234709 (10MusikAnimal) New solution at https://github.com/wikimedia/WhoWroteThat/pull/121 [17:40:36] 10Password-Reset-Update, 10Community-Tech (Kanban-Q2-2019-20): PRU: Address 'No Email Will Be Sent' Issue for Unconfirmed Users [small] - https://phabricator.wikimedia.org/T239938 (10MusikAnimal) a:05MusikAnimal→03None [17:47:00] 10OWC2020, 10Product-Analytics: Analyze number of productive article contributions made by "junior contributors" using talk page features - https://phabricator.wikimedia.org/T233890 (10kzimmerman) p:05Triage→03Normal @MNeisler to add links to existing queries that can be used by @Mayakp.wiki for this task [17:49:14] 10MediaWiki-Page-deletion, 10MediaWiki-Redirects, 10MediaWiki-User-management, 10Core Platform Team, and 3 others: Add user right to delete single revision redirects, regardless of target, during page moves - https://phabricator.wikimedia.org/T239277 (10DannyS712) [17:49:16] 10Product-Analytics (Kanban): [REQUEST] SDC metrics through Dec 31 2019 - https://phabricator.wikimedia.org/T241286 (10kzimmerman) a:03nettrom_WMF [17:51:40] 10Developer-Advocacy (Oct-Dec 2019), 10Google-Code-in-2019: Google Code-In 2019 Create a logo to represent Friends of the Docs - https://phabricator.wikimedia.org/T239637 (10Taniedits99) Here is my logo for the WikiMedia Foundation's Friends of The Docs {F31486792} [17:52:16] 10Better Use Of Data, 10Product-Analytics (Kanban): Data Quality Survey Presentation to Product team - https://phabricator.wikimedia.org/T241273 (10kzimmerman) p:05Triage→03Normal [17:53:44] 10Product-Analytics (Kanban): Board Metrics for December 2019 Meeting - https://phabricator.wikimedia.org/T238697 (10kzimmerman) 05Open→03Resolved [17:56:30] 10Product-Analytics, 10Epic: Document Outcomes from Product Analytics Offsite - https://phabricator.wikimedia.org/T237671 (10kzimmerman) [17:57:47] 10Better Use Of Data, 10Product-Analytics: Instrumentation Checklist Phab Form - https://phabricator.wikimedia.org/T226564 (10kzimmerman) [17:57:59] 10Product-Analytics (Kanban): Editing : QA Init events in EditAttemptSchema - https://phabricator.wikimedia.org/T238609 (10Mayakp.wiki) p:05High→03Low [17:58:01] 10Developer-Advocacy (Oct-Dec 2019), 10Google-Code-in-2019: Google Code-In 2019 Create a logo to represent Friends of the Docs - https://phabricator.wikimedia.org/T239637 (10Taniedits99) In my above upload I used certain logos like the logo of Wikimedia which all do not have a copyright and have a creative com... [17:58:36] 10Better Use Of Data, 10Product-Analytics: Instrumentation Checklist Phab Form - https://phabricator.wikimedia.org/T226564 (10kzimmerman) a:03kzimmerman To coordinate with Maya on QA checklist [17:58:57] 10Better Use Of Data, 10Product-Analytics: Instrumentation Checklist Phab Form - https://phabricator.wikimedia.org/T226564 (10kzimmerman) [17:58:59] 10Better Use Of Data, 10Product-Analytics (Kanban): QA-Instrumentation Checklist Phab Form - https://phabricator.wikimedia.org/T238449 (10kzimmerman) [17:59:08] 10Better Use Of Data, 10Epic, 10Product-Analytics (Kanban): Output 2.2: Data stewardship - https://phabricator.wikimedia.org/T213438 (10kzimmerman) [17:59:10] 10Better Use Of Data, 10Product-Analytics: Instrumentation Checklist Phab Form - https://phabricator.wikimedia.org/T226564 (10kzimmerman) [17:59:59] 10Readers-Web-Backlog (Needs Product Owner Decisions), 10Tracking-Neverending: [Tracking] Bugs related to desktop (Vector) print styles - https://phabricator.wikimedia.org/T241376 (10Jdlrobson) [18:02:29] 10Readers-Web-Backlog (Needs Product Owner Decisions), 10Tracking-Neverending: [Tracking] Bugs related to desktop (Vector) print styles - https://phabricator.wikimedia.org/T241376 (10Jdlrobson) [18:02:31] 10Readers-Web-Backlog (Tracking): Transform TOC into PDF outline on export - https://phabricator.wikimedia.org/T183104 (10Jdlrobson) [18:02:37] 10Design, 10UI-Standardization, 10Vector, 10Readers-Web-Backlog (Tracking), 10UI-Standardization-Kanban: Define and limit colors in new print styles - https://phabricator.wikimedia.org/T173023 (10Jdlrobson) [18:02:40] 10MediaWiki-extensions-ShortUrl, 10PDF-Rendering, 10Vector, 10Readers-Web-Backlog (Tracking): Display short url version of links on desktop and PDF print styles - https://phabricator.wikimedia.org/T172902 (10Jdlrobson) [18:02:44] 10Design, 10Vector, 10Readers-Web-Backlog (Tracking): Justify text in print styles? - https://phabricator.wikimedia.org/T171330 (10Jdlrobson) [18:02:50] 10Design, 10I18n, 10Readers-Web-Backlog (Needs Product Owner Decisions): Use Wikimedia Design Style Guide font choice of serif in print styles - https://phabricator.wikimedia.org/T169828 (10Jdlrobson) [18:02:56] 10Readers-Web-Backlog, 10Epic: [EPIC] Print styles - desktop - https://phabricator.wikimedia.org/T154965 (10Jdlrobson) I don't think an epic is useful but I've pulled out the remaining tasks into a tracking task to make them easier to find > T241376 [18:06:32] (03Abandoned) 10Jdlrobson: Navigating to notifications on desktop/tablet screens doesn't change address bar [extensions/Echo] - 10https://gerrit.wikimedia.org/r/556830 (https://phabricator.wikimedia.org/T225213) (owner: 10Jdlrobson) [18:07:58] (03CR) 10Jdlrobson: [C: 04-1] Hygiene: use the vectorConfig class as single vector config (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/551643 (owner: 10Pmiazga) [18:10:58] (03PS10) 10Jdlrobson: Drawer's no longer touch the body tag and have their own mask [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558256 (https://phabricator.wikimedia.org/T214049) [18:11:14] (03CR) 10jerkins-bot: [V: 04-1] Drawer's no longer touch the body tag and have their own mask [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558256 (https://phabricator.wikimedia.org/T214049) (owner: 10Jdlrobson) [18:13:12] (03PS11) 10Jdlrobson: Drawer's no longer touch the body tag and have their own mask [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558256 (https://phabricator.wikimedia.org/T214049) [18:13:27] (03CR) 10jerkins-bot: [V: 04-1] Drawer's no longer touch the body tag and have their own mask [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558256 (https://phabricator.wikimedia.org/T214049) (owner: 10Jdlrobson) [18:15:31] (03PS12) 10Jdlrobson: Drawer's no longer touch the body tag and have their own mask [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558256 (https://phabricator.wikimedia.org/T214049) [18:17:18] (03PS1) 10Reedy: Don't redefine MW_ENTRY_POINT in thumb.php if already defined [core] - 10https://gerrit.wikimedia.org/r/560418 (https://phabricator.wikimedia.org/T241340) [18:18:01] 10MobileFrontend, 10Google-Code-in-2019, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), 10Readers-Web-Backlog (Kanbanana-2019-20-Q2), 10good first task: Add shadow to nav menu drawer - https://phabricator.wikimedia.org/T231205 (10Jdlrobson) 05Resolved→03Open [18:19:20] (03PS2) 10Reedy: Don't redefine MW_ENTRY_POINT in thumb.php if already defined [core] - 10https://gerrit.wikimedia.org/r/560418 (https://phabricator.wikimedia.org/T241340) [18:19:40] 10MediaWiki-General, 10MW-1.34-release, 10Patch-For-Review: PHP Notice: Constant MW_ENTRY_POINT already defined in /srv/mediawiki/w/thumb.php on line 28 - https://phabricator.wikimedia.org/T241340 (10Reedy) [18:20:20] 10MobileFrontend, 10Google-Code-in-2019, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), 10Readers-Web-Backlog (Kanbanana-2019-20-Q2), 10good first task: Add shadow to nav menu drawer - https://phabricator.wikimedia.org/T231205 (10Jdlrobson) Seeing a regression from this change. I will revert. {F31486826} [18:20:34] (03PS1) 10Jdlrobson: Revert "mobile.variables.less: added drawerShadow variable Drawer.less added shadow to navigation-drawer class" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/560419 [18:20:43] (03CR) 10Jdlrobson: [C: 03+2] Revert "mobile.variables.less: added drawerShadow variable Drawer.less added shadow to navigation-drawer class" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/560419 (owner: 10Jdlrobson) [18:21:07] (03CR) 10Jdlrobson: "To be continued in January..." [core] - 10https://gerrit.wikimedia.org/r/549220 (https://phabricator.wikimedia.org/T169910) (owner: 10Jdlrobson) [18:22:45] (03PS9) 10Jdlrobson: Introducing ResourceLoaderSite module hooks [core] - 10https://gerrit.wikimedia.org/r/547643 (https://phabricator.wikimedia.org/T237050) [18:22:54] (03CR) 10Jdlrobson: "To be continued in January..." [core] - 10https://gerrit.wikimedia.org/r/547643 (https://phabricator.wikimedia.org/T237050) (owner: 10Jdlrobson) [18:24:38] (03PS13) 10Jdlrobson: Drawer's no longer touch the body tag and have their own mask [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558256 (https://phabricator.wikimedia.org/T214049) [18:25:19] 10MobileFrontend, 10Readers-Web-Backlog, 10MW-1.34-notes (1.34.0-wmf.15; 2019-07-23), 10Patch-For-Review: Every Drawer has a shield for catching clicks - https://phabricator.wikimedia.org/T214049 (10Jdlrobson) [18:34:51] (03Merged) 10jenkins-bot: Revert "mobile.variables.less: added drawerShadow variable Drawer.less added shadow to navigation-drawer class" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/560419 (owner: 10Jdlrobson) [18:37:34] (03CR) 10jerkins-bot: [V: 04-1] Drawer's no longer touch the body tag and have their own mask [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558256 (https://phabricator.wikimedia.org/T214049) (owner: 10Jdlrobson) [18:37:54] (03CR) 10Gergő Tisza: [C: 03+2] Don't redefine MW_ENTRY_POINT in thumb.php if already defined [core] - 10https://gerrit.wikimedia.org/r/560418 (https://phabricator.wikimedia.org/T241340) (owner: 10Reedy) [18:39:45] 10MediaViewer, 10Structured-Data-Backlog, 10Browser-Support-Firefox, 10Patch-For-Review, and 2 others: After closing, browser sometimes scrolls to the top of the page in Firefox 70 - https://phabricator.wikimedia.org/T229484 (10Geeklizzard) Hi, we're still getting reports of this issue in bugzilla.mozilla.... [18:44:17] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Epic, 10Growth-Team (Current Sprint), 10Product-Analytics (Kanban): Newcomer tasks: instrumentation - https://phabricator.wikimedia.org/T230068 (10nettrom_WMF) [18:44:42] (03CR) 10Anomie: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 (031 comment) [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/560120 (owner: 10Libraryupgrader) [18:45:35] 10MediaWiki-General, 10MW-1.34-release, 10Patch-For-Review: PHP Notice: Constant MW_ENTRY_POINT already defined in /srv/mediawiki/w/thumb.php on line 28 - https://phabricator.wikimedia.org/T241340 (10Reedy) Caused by b7ce7aacb0fb6803d9135f465e9cf6b48912883e / I24099f4cdd170de17afd6e1bbad67c9b204071fc [18:46:31] (03CR) 10Reedy: Add MW_REST_API and MW_ENTRY_POINT (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533981 (owner: 10Tim Starling) [18:46:44] (03PS1) 10Reedy: Don't redefine MW_ENTRY_POINT in thumb.php if already defined [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/560422 (https://phabricator.wikimedia.org/T241340) [18:47:22] (03CR) 10Reedy: [C: 03+2] Don't redefine MW_ENTRY_POINT in thumb.php if already defined [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/560422 (https://phabricator.wikimedia.org/T241340) (owner: 10Reedy) [18:51:41] (03CR) 10jerkins-bot: [V: 04-1] Don't redefine MW_ENTRY_POINT in thumb.php if already defined [core] - 10https://gerrit.wikimedia.org/r/560418 (https://phabricator.wikimedia.org/T241340) (owner: 10Reedy) [18:55:29] (03Merged) 10jenkins-bot: Don't redefine MW_ENTRY_POINT in thumb.php if already defined [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/560422 (https://phabricator.wikimedia.org/T241340) (owner: 10Reedy) [18:56:34] (03PS3) 10Ladsgroup: Add option to override storeClass in rebuildLocalisationCache [core] - 10https://gerrit.wikimedia.org/r/560342 (https://phabricator.wikimedia.org/T105683) [18:57:07] (03CR) 10Ladsgroup: Add option to override storeClass in rebuildLocalisationCache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/560342 (https://phabricator.wikimedia.org/T105683) (owner: 10Ladsgroup) [19:04:27] 10Advanced Mobile Contributions, 10MinervaNeue, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): [Bug] Simplified Talk Page Does Not Support Sections With Non-ascii Characters/Several ascii characters aren't supported either - https://phabricator.wikimedia.org/T238364 (10Nixinova) Useful l... [19:04:29] 10TimedMediaHandler-Transcode, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), 10Patch-For-Review: Transcoding job is reported as failed before it's completed - https://phabricator.wikimedia.org/T240368 (10TheDJ) @HebronNor https://github.com/wikimedia/mediawiki-extensions-TimedMediaHandler/blob/19bdb6794c0789a... [19:12:57] (03PS6) 10Jdlrobson: Make MobileFrontend dependency a soft one [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/559208 (https://phabricator.wikimedia.org/T171000) [19:12:59] (03CR) 10jerkins-bot: [V: 04-1] Make MobileFrontend dependency a soft one [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/559208 (https://phabricator.wikimedia.org/T171000) (owner: 10Jdlrobson) [19:13:36] (03PS14) 10Jdlrobson: Drawer's no longer touch the body tag and have their own mask [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558256 (https://phabricator.wikimedia.org/T214049) [19:14:26] (03PS7) 10Jdlrobson: Make MobileFrontend dependency a soft one [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/559208 (https://phabricator.wikimedia.org/T171000) [19:16:01] 10Developer-Advocacy (Oct-Dec 2019), 10Google-Code-in-2019: Google Code-In 2019 Create a logo to represent Friends of the Docs - https://phabricator.wikimedia.org/T239637 (10Taniedits99) In my revised upload I used certain logos like the logo of Wikimedia which all do not have a copyright and have a creative c... [19:16:24] (03PS8) 10Jdlrobson: Make MobileFrontend dependency a soft one [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/559208 (https://phabricator.wikimedia.org/T171000) [19:19:28] (03CR) 10Paladox: "recheck" [core] - 10https://gerrit.wikimedia.org/r/560418 (https://phabricator.wikimedia.org/T241340) (owner: 10Reedy) [19:19:32] (03CR) 10Paladox: "check gate" [core] - 10https://gerrit.wikimedia.org/r/560418 (https://phabricator.wikimedia.org/T241340) (owner: 10Reedy) [19:22:07] (03PS2) 10Reedy: User: Allow newSystemUser() to create over anonymous actors [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/560327 (https://phabricator.wikimedia.org/T236444) (owner: 10Paladox) [19:22:41] (03CR) 10Reedy: [C: 03+2] User: Allow newSystemUser() to create over anonymous actors [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/560327 (https://phabricator.wikimedia.org/T236444) (owner: 10Paladox) [19:22:45] (03CR) 10Ori.livneh: [C: 03+2] Add option to override storeClass in rebuildLocalisationCache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/560342 (https://phabricator.wikimedia.org/T105683) (owner: 10Ladsgroup) [19:24:26] 10WikibaseMediaInfo: Search suggestion does not allow middle mouse click to open search result in a new tab - https://phabricator.wikimedia.org/T241382 (10Raymond) [19:25:36] (03PS1) 10C. Scott Ananian: Try hard not to create new 1-byte strings during FST execution [libs/LangConv] - 10https://gerrit.wikimedia.org/r/560423 [19:25:38] (03PS1) 10C. Scott Ananian: Avoid O(N) substr and array_splice operations [libs/LangConv] - 10https://gerrit.wikimedia.org/r/560424 [19:25:40] (03PS1) 10C. Scott Ananian: Inline the $save method. [libs/LangConv] - 10https://gerrit.wikimedia.org/r/560425 [19:25:51] (03CR) 10jerkins-bot: [V: 04-1] Drawer's no longer touch the body tag and have their own mask [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558256 (https://phabricator.wikimedia.org/T214049) (owner: 10Jdlrobson) [19:30:03] (03CR) 10jerkins-bot: [V: 04-1] Make MobileFrontend dependency a soft one [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/559208 (https://phabricator.wikimedia.org/T171000) (owner: 10Jdlrobson) [19:30:51] (03Merged) 10jenkins-bot: User: Allow newSystemUser() to create over anonymous actors [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/560327 (https://phabricator.wikimedia.org/T236444) (owner: 10Paladox) [19:35:15] (03Merged) 10jenkins-bot: Add option to override storeClass in rebuildLocalisationCache [core] - 10https://gerrit.wikimedia.org/r/560342 (https://phabricator.wikimedia.org/T105683) (owner: 10Ladsgroup) [19:36:20] (03PS2) 10Octfx: Change method of setting and retrieving page props [extensions/WikiSEO] - 10https://gerrit.wikimedia.org/r/560414 [19:38:23] (03CR) 10Thiemo Kreuz (WMDE): build: Updating mediawiki/mediawiki-phan-config to 0.9.0 (031 comment) [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/560120 (owner: 10Libraryupgrader) [19:39:31] (03PS1) 10DannyS712: Follow up 9ef34a2f1d0: fix NewPagesPager "hide registered users" option [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/560427 (https://phabricator.wikimedia.org/T238483) [19:42:59] (03PS3) 10Octfx: Change method of setting and retrieving page props [extensions/WikiSEO] - 10https://gerrit.wikimedia.org/r/560414 [19:44:28] (03PS9) 10Jdlrobson: Make MobileFrontend dependency a soft one [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/559208 (https://phabricator.wikimedia.org/T171000) [19:45:30] (03PS15) 10Jdlrobson: Drawer's no longer touch the body tag and have their own mask [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558256 (https://phabricator.wikimedia.org/T214049) [19:51:46] (03CR) 10Thiemo Kreuz (WMDE): Remove usage of setEditSection in ParserOptions (032 comments) [extensions/News] - 10https://gerrit.wikimedia.org/r/560394 (owner: 10Paladox) [19:52:07] (03CR) 10Anomie: [C: 04-1] "Seems ok from a technical standpoint, but I think it would be better to fully implement the parameter as proposed in the associated task (" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/560048 (https://phabricator.wikimedia.org/T64698) (owner: 10SD0001) [19:53:16] (03PS3) 10Paladox: Remove usage of setEditSection in ParserOptions [extensions/News] - 10https://gerrit.wikimedia.org/r/560394 [19:53:25] (03CR) 10Paladox: Remove usage of setEditSection in ParserOptions (031 comment) [extensions/News] - 10https://gerrit.wikimedia.org/r/560394 (owner: 10Paladox) [19:53:27] (03CR) 10Isarra: "It really doesn't." [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/559458 (owner: 10Jack Phoenix) [19:54:12] (03PS5) 10Tpt: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/560136 (owner: 10Libraryupgrader) [19:56:29] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Autofixing PSR2.Files.EndFileNewline.NoneFound errors [extensions/SimpleFarm] - 10https://gerrit.wikimedia.org/r/559429 (owner: 10Legoktm) [19:56:44] (03CR) 10Isarra: "Yay! Thanks, guys!" [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/559286 (https://phabricator.wikimedia.org/T228815) (owner: 10Skizzerz) [19:56:52] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Autofixing Squiz.WhiteSpace.SuperfluousWhitespace.EndLine errors [extensions/SimpleFarm] - 10https://gerrit.wikimedia.org/r/559430 (owner: 10Legoktm) [19:57:20] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Update README.md [extensions/BreadCrumbs] - 10https://gerrit.wikimedia.org/r/560085 (owner: 10Zoranzoki21) [19:57:59] (03CR) 10jerkins-bot: [V: 04-1] Make MobileFrontend dependency a soft one [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/559208 (https://phabricator.wikimedia.org/T171000) (owner: 10Jdlrobson) [19:58:03] (03CR) 10jerkins-bot: [V: 04-1] Drawer's no longer touch the body tag and have their own mask [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558256 (https://phabricator.wikimedia.org/T214049) (owner: 10Jdlrobson) [19:58:12] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Autofixing MediaWiki.WhiteSpace.* errors [extensions/SimpleFarm] - 10https://gerrit.wikimedia.org/r/559428 (owner: 10Legoktm) [19:58:18] (03PS2) 10Thiemo Kreuz (WMDE): Autofixing MediaWiki.ExtraCharacters.ParenthesesAroundKeyword.ParenthesesAroundKeywords errors [extensions/SimpleFarm] - 10https://gerrit.wikimedia.org/r/559426 (owner: 10Legoktm) [19:58:23] (03CR) 10jerkins-bot: [V: 04-1] Autofixing MediaWiki.Usage.DirUsage.FunctionFound errors [extensions/SimpleFarm] - 10https://gerrit.wikimedia.org/r/559427 (owner: 10Legoktm) [19:58:25] (03CR) 10jerkins-bot: [V: 04-1] Autofixing MediaWiki.WhiteSpace.* errors [extensions/SimpleFarm] - 10https://gerrit.wikimedia.org/r/559428 (owner: 10Legoktm) [19:58:27] (03CR) 10jerkins-bot: [V: 04-1] Autofixing PSR2.Files.EndFileNewline.NoneFound errors [extensions/SimpleFarm] - 10https://gerrit.wikimedia.org/r/559429 (owner: 10Legoktm) [19:58:29] (03CR) 10jerkins-bot: [V: 04-1] Autofixing Squiz.WhiteSpace.SuperfluousWhitespace.EndLine errors [extensions/SimpleFarm] - 10https://gerrit.wikimedia.org/r/559430 (owner: 10Legoktm) [19:58:37] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Autofixing MediaWiki.ExtraCharacters.ParenthesesAroundKeyword.ParenthesesAroundKeywords errors [extensions/SimpleFarm] - 10https://gerrit.wikimedia.org/r/559426 (owner: 10Legoktm) [19:59:40] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Remove usage of setEditSection in ParserOptions [extensions/News] - 10https://gerrit.wikimedia.org/r/560394 (owner: 10Paladox) [20:00:27] (03Merged) 10jenkins-bot: Update README.md [extensions/BreadCrumbs] - 10https://gerrit.wikimedia.org/r/560085 (owner: 10Zoranzoki21) [20:00:29] (03CR) 10jerkins-bot: [V: 04-1] Autofixing MediaWiki.ExtraCharacters.ParenthesesAroundKeyword.ParenthesesAroundKeywords errors [extensions/SimpleFarm] - 10https://gerrit.wikimedia.org/r/559426 (owner: 10Legoktm) [20:00:47] 10OWC2020, 10Product-Analytics (Kanban): Analyze retention rate of Junior Contributors using talk page features - https://phabricator.wikimedia.org/T233889 (10ppelberg) 05Open→03Resolved It's great to be able to differentiate between contributors coming back to participate on talk pages in the "short" vs.... [20:00:49] 10OWC2020, 10Product-Analytics: Calculate baselines for project key results - https://phabricator.wikimedia.org/T233888 (10ppelberg) [20:03:30] (03Merged) 10jenkins-bot: Autofixing MediaWiki.ExtraCharacters.ParenthesesAroundKeyword.ParenthesesAroundKeywords errors [extensions/SimpleFarm] - 10https://gerrit.wikimedia.org/r/559426 (owner: 10Legoktm) [20:03:39] (03Merged) 10jenkins-bot: Remove usage of setEditSection in ParserOptions [extensions/News] - 10https://gerrit.wikimedia.org/r/560394 (owner: 10Paladox) [20:04:03] (03PS10) 10Jdlrobson: Make MobileFrontend dependency a soft one [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/559208 (https://phabricator.wikimedia.org/T171000) [20:06:49] (03PS2) 10C. Scott Ananian: Avoid O(N) substr and array_splice operations [libs/LangConv] - 10https://gerrit.wikimedia.org/r/560424 [20:06:51] (03PS2) 10C. Scott Ananian: Inline the $save method. [libs/LangConv] - 10https://gerrit.wikimedia.org/r/560425 [20:06:53] (03PS2) 10C. Scott Ananian: Try hard not to create new 1-byte strings during FST execution [libs/LangConv] - 10https://gerrit.wikimedia.org/r/560423 [20:07:26] (03CR) 10C. Scott Ananian: [C: 04-2] "Let's not merge this, it's not actually an optimization!" [libs/LangConv] - 10https://gerrit.wikimedia.org/r/560423 (owner: 10C. Scott Ananian) [20:08:07] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "I'm afraid there is not much value in continuing this conversation today. If you actually have a hard time understanding what I wrote, I s" [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/559458 (owner: 10Jack Phoenix) [20:08:47] (03PS16) 10Jdlrobson: Drawer's no longer touch the body tag and have their own mask [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558256 (https://phabricator.wikimedia.org/T214049) [20:13:17] 10Product-Analytics, 10Growth-Team (Current Sprint), 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), 10Patch-For-Review: Welcome survey: anonymize data after one year - https://phabricator.wikimedia.org/T208369 (10Tgr) [20:13:55] 10Product-Analytics, 10Growth-Team (Current Sprint), 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), 10Patch-For-Review: Welcome survey: anonymize data after one year - https://phabricator.wikimedia.org/T208369 (10Tgr) Doesn't really have a due date anymore since the job is now running every two weeks. [20:20:07] 10MediaWiki-extensions-DocBookExport, 10MediaWiki-extensions-Other, 10MediaWikiChat, 10Other-skins, 10ci-test-error: Remove or replace usage of removed ParserOptions::setEditSection - https://phabricator.wikimedia.org/T241334 (10Umherirrender) [20:29:35] (03CR) 10Reedy: [C: 04-1] "CR -1 for the commit summary, plus a question" (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/560392 (https://phabricator.wikimedia.org/T232351) (owner: 10Paladox) [20:30:05] (03CR) 10Reedy: "resubmit" [core] - 10https://gerrit.wikimedia.org/r/560418 (https://phabricator.wikimedia.org/T241340) (owner: 10Reedy) [20:30:21] (03PS1) 10Umherirrender: Allow int on ApiQueryGeneratorBase::setContinueEnumParameter [core] - 10https://gerrit.wikimedia.org/r/560430 [20:31:01] (03CR) 10Reedy: "You should've just fixed that and then CR+2'd it Ori ;P" [core] - 10https://gerrit.wikimedia.org/r/560342 (https://phabricator.wikimedia.org/T105683) (owner: 10Ladsgroup) [20:31:20] (03CR) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 (031 comment) [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/560120 (owner: 10Libraryupgrader) [20:31:25] (03CR) 10Reedy: "submit" [core] - 10https://gerrit.wikimedia.org/r/560418 (https://phabricator.wikimedia.org/T241340) (owner: 10Reedy) [20:31:44] (03CR) 10Reedy: "recheck" [core] - 10https://gerrit.wikimedia.org/r/560418 (https://phabricator.wikimedia.org/T241340) (owner: 10Reedy) [20:31:49] one of these might work [20:34:39] Reedy do you suggest setting the varchar as 64? [20:40:26] 10Readers-Web-Backlog (Needs Product Owner Decisions): [Tracking] Bugs related to desktop (Vector) print styles - https://phabricator.wikimedia.org/T241376 (10Aklapper) @Jdlrobson: Please do not create #tracking-neverending tasks (note the "neverending" in there). Either create (sub)projects (see https://www.med... [20:48:32] paladox: It seems a reasonable idea, and has a specific reason. Rather than arbitary 255, which a db can't be that long anway [20:48:42] ok [20:49:39] (03PS7) 10Paladox: Increase ref_src_wiki varchar size to 64 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/560392 (https://phabricator.wikimedia.org/T232351) [20:49:40] Reedy done [20:49:44] (03CR) 10Paladox: Increase ref_src_wiki varchar size to 64 (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/560392 (https://phabricator.wikimedia.org/T232351) (owner: 10Paladox) [20:52:08] (03CR) 10Paladox: "recheck gate" [core] - 10https://gerrit.wikimedia.org/r/560418 (https://phabricator.wikimedia.org/T241340) (owner: 10Reedy) [20:56:11] 10MobileFrontend, 10Google-Code-in-2019, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), 10Readers-Web-Backlog (Kanbanana-2019-20-Q2), 10good first task: Add shadow to nav menu drawer - https://phabricator.wikimedia.org/T231205 (10N3rsti) @Jdlrobson My GCI task was already approved, but I see that there is... [20:57:07] (03CR) 10Paladox: Increase ref_src_wiki varchar size to 64 (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/560392 (https://phabricator.wikimedia.org/T232351) (owner: 10Paladox) [20:58:27] 10MobileFrontend, 10Google-Code-in-2019, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), 10Readers-Web-Backlog (Kanbanana-2019-20-Q2), 10good first task: Add shadow to nav menu drawer - https://phabricator.wikimedia.org/T231205 (10Urbanecm) >>! In T231205#5761498, @N3rsti wrote: > @Jdlrobson My GCI task was... [21:01:37] (03CR) 10Reedy: [C: 03+2] Increase ref_src_wiki varchar size to 64 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/560392 (https://phabricator.wikimedia.org/T232351) (owner: 10Paladox) [21:03:04] (03PS1) 10Paladox: Remove usage of setEditSection in ParserOptions [extensions/News] (REL1_34) - 10https://gerrit.wikimedia.org/r/560433 [21:05:06] 10MobileFrontend, 10Google-Code-in-2019, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), 10Readers-Web-Backlog (Kanbanana-2019-20-Q2), 10good first task: Add shadow to nav menu drawer - https://phabricator.wikimedia.org/T231205 (10N3rsti) I tried to reconstruct this bug on devtools and I see this shadow on... [21:07:30] (03PS1) 10Paladox: Increase ref_src_wiki varchar size to 64 [extensions/Flow] (REL1_34) - 10https://gerrit.wikimedia.org/r/560434 (https://phabricator.wikimedia.org/T232351) [21:07:42] 10Magnus Sälgö: Check WD objects with more Europeana Entities - https://phabricator.wikimedia.org/T241363 (10Salgo60) [21:07:47] Reedy would you be able to +2 ^^ to please? :) [21:07:51] *too [21:09:20] (03PS1) 10C. Scott Ananian: Add `composer phpunit` so we can run unit tests w/o having lint-free code [libs/LangConv] - 10https://gerrit.wikimedia.org/r/560435 [21:09:22] (03PS1) 10C. Scott Ananian: Execute FST in depth-first order rather than breadth-first [libs/LangConv] - 10https://gerrit.wikimedia.org/r/560436 [21:09:24] (03PS1) 10C. Scott Ananian: Inline the $reset method [libs/LangConv] - 10https://gerrit.wikimedia.org/r/560437 [21:13:09] (03PS1) 10Paladox: Prefer DOM building to parsing HTML literals [extensions/Flow] (REL1_34) - 10https://gerrit.wikimedia.org/r/560438 [21:13:13] (03PS9) 10Aaron Schulz: rdbms: inject replLogger into Database and consolidate duplicated logging [core] - 10https://gerrit.wikimedia.org/r/542466 (https://phabricator.wikimedia.org/T235244) [21:13:29] (03PS2) 10Paladox: Increase ref_src_wiki varchar size to 64 [extensions/Flow] (REL1_34) - 10https://gerrit.wikimedia.org/r/560434 (https://phabricator.wikimedia.org/T232351) [21:14:05] (03CR) 10Paladox: "Requires dependant change because of https://integration.wikimedia.org/ci/job/mwgate-node10-docker/63414/console" [extensions/Flow] (REL1_34) - 10https://gerrit.wikimedia.org/r/560434 (https://phabricator.wikimedia.org/T232351) (owner: 10Paladox) [21:15:14] (03Merged) 10jenkins-bot: Increase ref_src_wiki varchar size to 64 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/560392 (https://phabricator.wikimedia.org/T232351) (owner: 10Paladox) [21:15:26] 10MobileFrontend, 10Google-Code-in-2019, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), 10Readers-Web-Backlog (Kanbanana-2019-20-Q2), 10good first task: Add shadow to nav menu drawer - https://phabricator.wikimedia.org/T231205 (10Masumrezarock100) >>! In T231205#5761513, @N3rsti wrote: > I tried to reconst... [21:25:06] 10MobileFrontend, 10Google-Code-in-2019, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), 10Readers-Web-Backlog (Kanbanana-2019-20-Q2), 10good first task: Add shadow to nav menu drawer - https://phabricator.wikimedia.org/T231205 (10IAmNetx) >>! In T231205#5761520, @Masumrezarock100 wrote: >>>! In T231205#576... [21:28:35] 10MobileFrontend, 10Google-Code-in-2019, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), 10Readers-Web-Backlog (Kanbanana-2019-20-Q2), 10good first task: Add shadow to nav menu drawer - https://phabricator.wikimedia.org/T231205 (10Masumrezarock100) >>! In T231205#5761525, @IAmNetx wrote: > It is probably al... [21:29:52] (03PS1) 10Gergő Tisza: mw.loader.require: use an error type not swallowed by jQuery.Promise [core] - 10https://gerrit.wikimedia.org/r/560439 [21:30:12] (03PS1) 10C. Scott Ananian: Inline the $emit method [libs/LangConv] - 10https://gerrit.wikimedia.org/r/560440 [21:32:05] (03CR) 10Anomie: "I'm skeptical that this is really the correct thing to do (and the same about I574d4e26). It may be more correct to document this as "stri" [core] - 10https://gerrit.wikimedia.org/r/560430 (owner: 10Umherirrender) [21:32:42] 10MediaWiki-Email, 10MediaWiki-Watchlist, 10Growth-Team: Enotif_body says you can contact a user in userspace, and it should probably link to the User_talk: namespace instead - https://phabricator.wikimedia.org/T241389 (10Whatamidoing-WMF) [21:33:33] 10Advanced Mobile Contributions, 10MinervaNeue, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): [Bug] Simplified Talk Page Does Not Support Sections With Non-ascii Characters/Several ascii characters aren't supported either - https://phabricator.wikimedia.org/T238364 (10Xaosflux) I just l... [21:40:49] (03PS1) 10N3rsti: mobile.variables.less: added drawerShadow variable Drawer.less fixed shadow in navigation-drawer class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/560442 (https://phabricator.wikimedia.org/T231205) [21:41:09] (03CR) 10N3rsti: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/560442 (https://phabricator.wikimedia.org/T231205) (owner: 10N3rsti) [21:48:09] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Growth-Team (Current Sprint): Newcomer tasks: ambassadors evaluate edits (2019-12-09) - https://phabricator.wikimedia.org/T240295 (10MMiller_WMF) [21:48:28] (03PS10) 10Aaron Schulz: rdbms: inject replLogger into Database and consolidate duplicated logging [core] - 10https://gerrit.wikimedia.org/r/542466 (https://phabricator.wikimedia.org/T235244) [21:48:35] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Growth-Team (Current Sprint): Newcomer tasks: ambassadors evaluate edits (2019-12-23) - https://phabricator.wikimedia.org/T241390 (10MMiller_WMF) [21:48:37] 10MediaWiki-User-login-and-signup, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review, 10User-TheSandDoctor: Add confirmation if account creation rationale/summary is an email address to prevent accidental self-outing - https://phabricator.wikimedia.org/T233068 (10Anomie) >>! In T233068... [21:48:39] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Growth-Team (Current Sprint): Newcomer tasks: ambassadors evaluate edits (2019-12-23) - https://phabricator.wikimedia.org/T241390 (10MMiller_WMF) [21:48:41] 10MobileFrontend, 10Google-Code-in-2019, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), 10Patch-For-Review, and 2 others: Add shadow to nav menu drawer - https://phabricator.wikimedia.org/T231205 (10N3rsti) It should be working now, it it's not, please let me know and I will try to fix it. [21:48:45] 10MediaWiki-API, 10Patch-For-Review: Make it possible to specify what to do on edit conflict on action=edit - https://phabricator.wikimedia.org/T64698 (10Anomie) My point was that those parameters are required for the conflict resolution to actually function. Unfortunately they weren't made required when the A... [21:48:47] 10MediaWiki-Email, 10MediaWiki-Watchlist, 10Growth-Team, 10User-DannyS712: Enotif_body says you can contact a user in userspace, and it should probably link to the User_talk: namespace instead - https://phabricator.wikimedia.org/T241389 (10DannyS712) a:03DannyS712 [21:48:53] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Growth-Team (Current Sprint): Newcomer tasks: ambassadors evaluate edits (2019-12-23) - https://phabricator.wikimedia.org/T241390 (10MMiller_WMF) Ready for @Urbanecm, @revi, @Dyolf77_WMF, @PPham. [21:49:26] 10TimedMediaHandler-Transcode, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), 10Patch-For-Review: Transcoding job is reported as failed before it's completed - https://phabricator.wikimedia.org/T240368 (10HebronNor) @TheDJ Thanks for the analysis :) I set that parameter to 0 because I was experiencing the symp... [21:49:52] (03PS1) 10DannyS712: EmailNotification: Link to editor's talk page, not user page [core] - 10https://gerrit.wikimedia.org/r/560443 (https://phabricator.wikimedia.org/T241389) [21:50:16] (03PS2) 10DannyS712: EmailNotification: Link to editor's talk page, not user page [core] - 10https://gerrit.wikimedia.org/r/560443 (https://phabricator.wikimedia.org/T241389) [21:50:45] 10GraphViz: Not compatible with MediaWiki 1.33 (img_description column doesn't exist) - https://phabricator.wikimedia.org/T226616 (10Hispano76) Is this extension compatible with version 1.34 or do you still have the same problem? [21:50:59] 10MediaWiki-Email, 10MediaWiki-Watchlist, 10Growth-Team, 10Patch-For-Review, 10User-DannyS712: Enotif_body says you can contact a user in userspace, and it should probably link to the User_talk: namespace instead - https://phabricator.wikimedia.org/T241389 (10DannyS712) @Whatamidoing-WMF pretty simple re... [21:55:21] (03CR) 10Anomie: [C: 03+2] "I'd rather have one somewhat-large patch than nine or so all doing the same thing to different files." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/559191 (owner: 10Umherirrender) [21:57:13] (03PS13) 10Aaron Schulz: filerepo: make LocalFile*Batch classes more robust [core] - 10https://gerrit.wikimedia.org/r/532096 (https://phabricator.wikimedia.org/T231086) [21:57:45] (03CR) 10jerkins-bot: [V: 04-1] filerepo: make LocalFile*Batch classes more robust [core] - 10https://gerrit.wikimedia.org/r/532096 (https://phabricator.wikimedia.org/T231086) (owner: 10Aaron Schulz) [22:00:40] (03Merged) 10jenkins-bot: Split all classes in own files [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/559191 (owner: 10Umherirrender) [22:00:46] (03CR) 10TheDJ: OverlayManager can handle encoded and unencoded hash fragments (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558232 (https://phabricator.wikimedia.org/T238364) (owner: 10Jdlrobson) [22:01:24] (03CR) 10Reedy: [C: 03+2] Don't redefine MW_ENTRY_POINT in thumb.php if already defined [core] - 10https://gerrit.wikimedia.org/r/560418 (https://phabricator.wikimedia.org/T241340) (owner: 10Reedy) [22:04:39] 10Advanced Mobile Contributions, 10MinervaNeue, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): [Bug] Simplified Talk Page Does Not Support Sections With Non-ascii Characters/Several ascii characters aren't supported either - https://phabricator.wikimedia.org/T238364 (10TheDJ) Safari rela... [22:06:03] 10Advanced Mobile Contributions, 10MinervaNeue, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): [Bug] Simplified Talk Page Does Not Support Sections With Non-ascii Characters/Several ascii characters aren't supported either - https://phabricator.wikimedia.org/T238364 (10TheDJ) i guess we... [22:10:30] (03CR) 10Urbanecm: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/560442 (https://phabricator.wikimedia.org/T231205) (owner: 10N3rsti) [22:11:07] 10VideoJS player: Video wider than visible screen on mobile - https://phabricator.wikimedia.org/T241392 (10HebronNor) [22:11:24] (03PS1) 10Paladox: Convert cuc_actiontext to 'text' [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/560444 [22:11:37] (03PS2) 10Paladox: Convert cuc_actiontext to 'text' [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/560444 [22:13:01] (03CR) 10jerkins-bot: [V: 04-1] Convert cuc_actiontext to 'text' [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/560444 (owner: 10Paladox) [22:15:23] (03Merged) 10jenkins-bot: Don't redefine MW_ENTRY_POINT in thumb.php if already defined [core] - 10https://gerrit.wikimedia.org/r/560418 (https://phabricator.wikimedia.org/T241340) (owner: 10Reedy) [22:16:39] (03PS3) 10Paladox: Convert cuc_actiontext to 'text' [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/560444 [22:17:48] (03CR) 10Anomie: "Seems ok other than the phpcs issues and the unmentioned revert indicated inline. Haven't tested." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/547696 (https://phabricator.wikimedia.org/T235188) (owner: 10Aaron Schulz) [22:18:09] (03CR) 10Reedy: "I'm guessing this is another "field is too short" but a task/context would help" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/560444 (owner: 10Paladox) [22:18:14] (03CR) 10Reedy: [C: 04-1] Convert cuc_actiontext to 'text' [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/560444 (owner: 10Paladox) [22:18:25] Reedy that was the task you filed :P [22:18:37] paladox: You haven't linked it though ;) [22:18:47] (03PS4) 10Paladox: Convert cuc_actiontext to 'text' [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/560444 (https://phabricator.wikimedia.org/T199323) [22:18:49] done [22:22:11] (03CR) 10Reedy: [C: 04-1] "Why use the text type?" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/560444 (https://phabricator.wikimedia.org/T199323) (owner: 10Paladox) [22:22:13] (03PS5) 10Paladox: Convert cuc_actiontext and cuc_agent to 'text' [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/560444 (https://phabricator.wikimedia.org/T199323) [22:22:45] (03CR) 10Paladox: "> Why use the text type?" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/560444 (https://phabricator.wikimedia.org/T199323) (owner: 10Paladox) [22:25:18] (03CR) 10Reedy: "Not sure. In english they don't seem very long" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/560444 (https://phabricator.wikimedia.org/T199323) (owner: 10Paladox) [22:25:50] (03CR) 10Aaron Schulz: [C: 03+2] Handle null from FileBackend::getFileList [core] - 10https://gerrit.wikimedia.org/r/553516 (owner: 10Umherirrender) [22:27:26] (03PS6) 10Aaron Schulz: services: Add specific RecursiveServiceDependencyException class [core] - 10https://gerrit.wikimedia.org/r/548535 [22:27:36] (03CR) 10Jdlrobson: [C: 04-1] "I think this code would be better in the Minerva repo. Sorry for not suggesting that earlier." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/560442 (https://phabricator.wikimedia.org/T231205) (owner: 10N3rsti) [22:27:43] (03CR) 10Paladox: "> Not sure. In english they don't seem very long" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/560444 (https://phabricator.wikimedia.org/T199323) (owner: 10Paladox) [22:28:52] (03CR) 10Umherirrender: "For log entries there should be another solution, see I38cf3088ff3c779d62efce63b2122d6991a44a14" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/560444 (https://phabricator.wikimedia.org/T199323) (owner: 10Paladox) [22:29:20] (03CR) 10Paladox: "recheck" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/542772 (owner: 10Umherirrender) [22:29:47] (03PS1) 10Umherirrender: Move test helper class StubConsumer to own file [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/560445 [22:31:26] 10Advanced Mobile Contributions, 10MinervaNeue, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): [Bug] Simplified Talk Page Does Not Support Sections With Non-ascii Characters/Several ascii characters aren't supported either - https://phabricator.wikimedia.org/T238364 (10Jdlrobson) >>! In... [22:32:10] 10MobileFrontend, 10Google-Code-in-2019, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), 10Patch-For-Review, and 2 others: Add shadow to nav menu drawer - https://phabricator.wikimedia.org/T231205 (10Jdlrobson) >>! In T231205#5761570, @N3rsti wrote: > It should be working now, it it's not, please let me know... [22:35:05] (03PS3) 10Paladox: Use LogFormatter to format action text on Special:CheckUser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/542772 (owner: 10Umherirrender) [22:35:35] 10#browser-support-print-media, 10Readers-Web-Backlog (Needs Product Owner Decisions): [Tracking] Bugs related to desktop (Vector) print styles - https://phabricator.wikimedia.org/T241376 (10Jdlrobson) > Tracking-Neverending The name is a bit misleading. Some tracking tasks are "neverending" e.g. #browser-supp... [22:38:08] (03CR) 10N3rsti: "You're right. I will fix it." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/560442 (https://phabricator.wikimedia.org/T231205) (owner: 10N3rsti) [22:39:19] 10NewcomerTasks Future Release , 10Growth-Team (Current Sprint): Newcomer tasks: evaluate link recommendation - https://phabricator.wikimedia.org/T241395 (10MMiller_WMF) [22:39:29] (03PS1) 10DannyS712: Add `pagetriage-curation` log to ActionFilteredLogs [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/560446 (https://phabricator.wikimedia.org/T241394) [22:40:13] (03Merged) 10jenkins-bot: Handle null from FileBackend::getFileList [core] - 10https://gerrit.wikimedia.org/r/553516 (owner: 10Umherirrender) [22:41:19] (03CR) 10jerkins-bot: [V: 04-1] services: Add specific RecursiveServiceDependencyException class [core] - 10https://gerrit.wikimedia.org/r/548535 (owner: 10Aaron Schulz) [22:42:58] (03PS1) 10Paladox: Remove space from strings [core] - 10https://gerrit.wikimedia.org/r/560447 [22:43:00] (03PS2) 10Paladox: Remove space from strings [core] - 10https://gerrit.wikimedia.org/r/560447 [22:43:02] Reedy ^ :) [22:45:15] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): The "Sections" view is broken when there are no sections - https://phabricator.wikimedia.org/T241159 (10hueitan) [22:45:43] 10NewcomerTasks Future Release , 10Growth-Team (Current Sprint): Newcomer tasks: evaluate link recommendation - https://phabricator.wikimedia.org/T241395 (10MMiller_WMF) [22:46:07] 10OWC2020: Unable to publish changes to an outdated beta.wmflabs.org talk page - https://phabricator.wikimedia.org/T241396 (10ppelberg) [22:46:38] (03PS2) 10DannyS712: Add `pagetriage-curation` log to ActionFilteredLogs [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/560446 (https://phabricator.wikimedia.org/T241394) [22:46:45] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): The "Sections" view is broken when there are no sections - https://phabricator.wikimedia.org/T241159 (10hueitan) a:03hueitan Currently, the "Sections" view always has the lead section as the first item, therefore this is fixed. [22:47:00] damn it [22:47:08] (03CR) 10Reedy: [C: 03+2] Remove space from strings [core] - 10https://gerrit.wikimedia.org/r/560447 (owner: 10Paladox) [22:47:16] 10MobileFrontend, 10Google-Code-in-2019, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), 10Patch-For-Review, and 2 others: Add shadow to nav menu drawer - https://phabricator.wikimedia.org/T231205 (10Jdlrobson) > (it's a little bit different, but it's not a big difference in my opinion), but if you want to ha... [22:47:20] (03CR) 10jerkins-bot: [V: 04-1] Use LogFormatter to format action text on Special:CheckUser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/542772 (owner: 10Umherirrender) [22:47:22] (03PS1) 10Reedy: Remove space from strings [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/560449 [22:48:39] (03CR) 10Reedy: [C: 03+2] Remove space from strings [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/560449 (owner: 10Reedy) [22:50:21] Reedy would you also be able to review https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/VisualEditor/+/560450/ too please? :) [22:50:29] tons of log spam [22:50:48] due to "Undefined index: If-Match" which that change adds a null check [22:51:44] Can you not just cherry pick the whole patch? [22:52:47] nope [22:52:50] due to the etag stuff [22:55:55] You could've still done it without breaking authorship [22:57:04] (03Merged) 10jenkins-bot: Remove space from strings [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/560449 (owner: 10Reedy) [22:57:18] oh [23:02:44] Reedy done https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/VisualEditor/+/560452/ [23:07:48] (03PS7) 10Aaron Schulz: services: Add specific RecursiveServiceDependencyException class [core] - 10https://gerrit.wikimedia.org/r/548535 [23:08:52] (03Merged) 10jenkins-bot: Remove space from strings [core] - 10https://gerrit.wikimedia.org/r/560447 (owner: 10Paladox) [23:09:04] (03PS6) 10Aaron Schulz: filebackend: check file sizes in addition to SHA-1 in FileOp [core] - 10https://gerrit.wikimedia.org/r/525035 [23:10:37] (03CR) 10Aaron Schulz: "It checked in various test methods inside FileBackendIntegrationTest after/before operations." [core] - 10https://gerrit.wikimedia.org/r/525035 (owner: 10Aaron Schulz) [23:20:00] 10WikiApiary: ParseError on page histories and Special:RecentChanges - https://phabricator.wikimedia.org/T241399 (10Ciencia_Al_Poder) [23:26:14] 10Social-Tools, 10SocialProfile: Error: 1054 Unknown column 'rc_user' in 'field list' - https://phabricator.wikimedia.org/T241401 (10Paladox) [23:26:28] 10Social-Tools, 10SocialProfile: Error: 1054 Unknown column 'rc_user' in 'field list' - https://phabricator.wikimedia.org/T241401 (10Paladox) [23:27:47] Reedy would you be able to +2 https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Flow/+/560434/ and the parent change too please? :) [23:28:06] Reedy also could you review https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/News/+/560433/ too please? [23:36:13] 10Advanced Mobile Contributions, 10MinervaNeue, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): [Bug] Simplified Talk Page Does Not Support Sections With Non-ascii Characters/Several ascii characters aren't supported either - https://phabricator.wikimedia.org/T238364 (10TheDJ) >>! In T238...