[00:00:56] 10Product-Analytics (Kanban): Onboarding Checklist for Shay Nowick - https://phabricator.wikimedia.org/T240739 (10SNowick_WMF) [00:01:24] Yeah I've trusted Gerrit emails more than GCI ones myself [00:03:58] (03CR) 10jerkins-bot: [V: 04-1] CtaDrawers no longer stay behind in DOM [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/558252 (https://phabricator.wikimedia.org/T214045) (owner: 10Jdlrobson) [00:05:33] (03PS1) 10Jdlrobson: Drawer's no longer touch the body tag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558256 (https://phabricator.wikimedia.org/T214647) [00:05:51] (03CR) 10Jdlrobson: "recheck" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/558252 (https://phabricator.wikimedia.org/T214045) (owner: 10Jdlrobson) [00:09:55] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558256 (https://phabricator.wikimedia.org/T214647) (owner: 10Jdlrobson) [00:10:03] IAmNetx, were you here when I was talking about all the GCI emails? [00:10:33] Ebe123: don't think so [00:10:44] Emails like "Hello Étienne Beaulé, Étienne Beaulé has just approved x task" [00:11:26] haha it wouldn't surprise me from some of the stuff I've heard about the site [00:11:45] Like how the timer turns from days to hours to just "seconds" ominously with no indicator of how long you have left [00:12:09] Also Urbanecm sometimes has to remind me to Approve or "More Work Needed" as the site didn't save it [00:12:26] GCI should join GCI as an organization [00:12:51] Google's implication with open-source is odd; GCI should itself be! [00:13:04] GCI doesn't qualify for GCI [00:13:11] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Growth-Team (Current Sprint), 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17): Newcomer tasks: do not refresh suggestions if user cancels difficulty filter - https://phabricator.wikimedia.org/T238172 (10Etonkovidova) @kostajh - all works as expected - click... [00:13:13] I remember one year a gci student found security vulnerabilities in the gci site [00:13:23] that was funny [00:13:24] Last year I believe [00:13:26] Oh I heard about that [00:13:40] Didn't they find an XSS thing with usernames or something? [00:15:16] Forget, but wouldn't surprise [00:15:59] I also get two emails when students submit their tasks, just to put pressure on me [00:16:21] Is it because you're an org admin? [00:16:51] Don't think so [00:16:58] Just a quirk [00:17:20] Oh, XSS was for literally every field on the website, including comments [00:17:21] (03Abandoned) 10Jdlrobson: Talk headings should work with ascii characters [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556840 (https://phabricator.wikimedia.org/T238364) (owner: 10Jdlrobson) [00:17:26] rofl [00:17:28] (03CR) 10jerkins-bot: [V: 04-1] Drawer's no longer touch the body tag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558256 (https://phabricator.wikimedia.org/T214647) (owner: 10Jdlrobson) [00:17:34] That's a good way to encourage your mentors to get reviewing quickly [00:17:39] Hold them ransom [00:18:32] Some sites like to escape user input, GCI on the other hand asks: What is life without a little risk? [00:19:01] Keeps the users on their toes so they don't get too comfortable with a stable site [00:19:11] They're just students interested in programming, what could they do? [00:19:16] Wonder if GCI is within google's bug bounty program. The prizes for that are more than the entirety of this contest I imagine [00:19:17] Then when it breaks completely they aren't too surprised, win-win [00:19:29] He won a bug bounty I'm pretty sure [00:20:31] (03CR) 10Jdlrobson: "recheck" [core] - 10https://gerrit.wikimedia.org/r/487168 (https://phabricator.wikimedia.org/T212521) (owner: 10Jdlrobson) [00:20:33] Where I'm from, the government's access to information system had incremental ids (including for private documents) [00:20:35] https://www.google.com/about/appsecurity/reward-program/index.html doesn't really mention it one way or another [00:21:16] (03PS2) 10Jdlrobson: Drawer's no longer touch the body tag [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558256 (https://phabricator.wikimedia.org/T214647) [00:22:14] 10Product-Analytics (Kanban): Onboarding Checklist for Shay Nowick - https://phabricator.wikimedia.org/T240739 (10SNowick_WMF) [00:23:28] "please do not try to sneak into Google offices, attempt phishing attacks against our employees, and so on." [00:23:37] Immediately followed by "please don't ddos us" [00:23:47] 10MediaWiki-User-management, 10Anti-Harassment, 10Wikimedia-Site-requests, 10Epic, 10User-notice: [Epic] Partial block rollout - https://phabricator.wikimedia.org/T218626 (10SQL) @Niharika - I noticed in the tech news today, that we should contact you if our wiki should be delayed for deployment. As we'r... [00:24:11] IAmNetx, I guess you're trying some social engineering to be let into their offices ;) [00:24:22] What with all the tasks you're doing here [00:25:02] Whaaat, I would never ;) [00:25:03] I mean, if you can DDoS google, given their network presence, that probably deserves some sort of prize [00:25:15] I am content with my digital certificate valued at $0 [00:25:29] If you can DDoS Google then you're going to jail [00:25:57] I guess https://xkcd.com/538/ is out of scope for their bountry program too [00:26:07] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558256 (https://phabricator.wikimedia.org/T214647) (owner: 10Jdlrobson) [00:26:08] lol, yep [00:26:24] You're either going to jail, or you're working for a nation-state [00:26:25] 10MediaWiki-User-management, 10Anti-Harassment, 10Wikimedia-Site-requests, 10Epic, 10User-notice: [Epic] Partial block rollout - https://phabricator.wikimedia.org/T218626 (10Xaosflux) In response to Tech/News/2019/51, am following up with User talk:NKohli (WMF) as to the current plan for English Wikipedi... [00:26:41] Haha I was thinking of that xkcd but I couldn't be bothered searching on mobile [00:26:43] Or both if you're discovered in the wrong place [00:26:47] Aye kidnapped by North Korea [00:37:01] (03PS21) 10Jdlrobson: Headless QUnit tests (oh my!) [core] - 10https://gerrit.wikimedia.org/r/487168 (https://phabricator.wikimedia.org/T212521) [00:38:52] 10Research: Research Showcase December 2019 - https://phabricator.wikimedia.org/T212366 (10JLaytonWMF) [00:41:26] Ebe123: Hi I’m 小過兒 on GCI, I tried to transcribe Twinkle, Twinkle, Little Star to LilyPond last night and here is my work [[:en:wiki:Special:diff/931047260]], would it be too easy or I should do more difficult one, and thank you for maintain this task. [00:43:07] You've already done it, so it counts [00:43:57] What I like to see is after the first one (simple), they become increasingly interesting [00:45:25] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/ImageTweaks] - 10https://gerrit.wikimedia.org/r/558263 (owner: 10Libraryupgrader) [00:45:49] OK, I would try my best [00:47:25] 10Wikimedia-General-or-Unknown, 10I18n: [[Wikimedia:Ia-upload-zip-file-too-large/en]] translation issue - https://phabricator.wikimedia.org/T240918 (10Verdy_p) [00:47:43] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [extensions/ImapAuthorization] - 10https://gerrit.wikimedia.org/r/558264 (owner: 10Libraryupgrader) [00:48:03] 10MediaWiki-extensions-Page_Forms, 10UI-Standardization: Convert Page Forms to use OOUI - https://phabricator.wikimedia.org/T192752 (10Volker_E) fyi, I've updated T91148. tl;dr: From user-experience perspective it's preferable to have separate date and time inputs and not one DateTimeInput widget. It's overly... [00:48:26] (03CR) 10jerkins-bot: [V: 04-1] Headless QUnit tests (oh my!) [core] - 10https://gerrit.wikimedia.org/r/487168 (https://phabricator.wikimedia.org/T212521) (owner: 10Jdlrobson) [00:48:45] 10Wikimedia-General-or-Unknown, 10I18n: [[Wikimedia:Ia-upload-zip-file-too-large/en]] translation issue - https://phabricator.wikimedia.org/T240918 (10Verdy_p) [00:50:05] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/487168 (https://phabricator.wikimedia.org/T212521) (owner: 10Jdlrobson) [00:50:55] (Like https://en.wikipedia.org/wiki/File:Song-stories-for-the-kindergarten_1896_twinkle-twinkle-little-star_sheet-music.gif exemplifies a progression in difficulty, might be good for a 3rd with the inclusion of piano and lyrics) [00:52:27] 10Internet-Archive, 10Wikimedia-General-or-Unknown, 10I18n: [[Wikimedia:Ia-upload-zip-file-too-large/en]] translation issue - https://phabricator.wikimedia.org/T240918 (10DannyS712) [00:53:06] 10Internet-Archive, 10Wikimedia-General-or-Unknown, 10I18n: [[Wikimedia:Ia-upload-zip-file-too-large/en]] translation issue - https://phabricator.wikimedia.org/T240918 (10Verdy_p) [00:53:55] OK, I would try to do with this [00:55:04] You can also take easier (shorter) things [00:55:40] Especially before incorporating many parts (piano, lyrics, voice) [00:59:44] Thanks for your suggest, I have some idea now [01:06:44] 10Machine vision, 10Structured-Data-Backlog (Current Work): Echo email notifications not bundling properly - https://phabricator.wikimedia.org/T240878 (10egardner) [01:07:09] (03PS2) 10Jdlrobson: CtaDrawers no longer stay behind in DOM [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/558252 (https://phabricator.wikimedia.org/T214045) [01:07:13] (03CR) 10Jdlrobson: "recheck" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/558252 (https://phabricator.wikimedia.org/T214045) (owner: 10Jdlrobson) [01:07:20] 10Machine vision, 10Structured-Data-Backlog (Current Work): Echo email notifications not bundling properly - https://phabricator.wikimedia.org/T240878 (10egardner) @Ramsey-WMF I'm able to reproduce this locally, but I don't understand why email notifications are not bundling; I've followed the instructions in... [01:09:56] (03PS22) 10Jdlrobson: Headless QUnit tests (oh my!) [core] - 10https://gerrit.wikimedia.org/r/487168 (https://phabricator.wikimedia.org/T212521) [01:11:38] (03PS1) 10Jack Phoenix: Remove unused disabledCr variable from the JavaScript file [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/558271 [01:13:35] (03CR) 10Pmiazga: "Some really minor nitpicks, code definitely looks like something we can merge and then follow-up with those improvements." (038 comments) [extensions/EventStreamConfig] - 10https://gerrit.wikimedia.org/r/545654 (https://phabricator.wikimedia.org/T233634) (owner: 10Ottomata) [01:14:47] (03CR) 10Jack Phoenix: [C: 03+2] Remove unused disabledCr variable from the JavaScript file [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/558271 (owner: 10Jack Phoenix) [01:19:02] 10MediaWiki-User-management, 10Anti-Harassment, 10Wikimedia-Site-requests, 10Epic, 10User-notice: [Epic] Partial block rollout - https://phabricator.wikimedia.org/T218626 (10Niharika) @Xaosflux @SQL Yep, we are excluding `enwiki` and other wikis where discussion has been stalled or is waiting on an RfC. [01:19:03] (03CR) 10VolkerE: Headless QUnit tests (oh my!) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/487168 (https://phabricator.wikimedia.org/T212521) (owner: 10Jdlrobson) [01:21:16] (03CR) 10jerkins-bot: [V: 04-1] Headless QUnit tests (oh my!) [core] - 10https://gerrit.wikimedia.org/r/487168 (https://phabricator.wikimedia.org/T212521) (owner: 10Jdlrobson) [01:22:21] 10Product-Analytics (Kanban): Onboarding Checklist for Shay Nowick - https://phabricator.wikimedia.org/T240739 (10SNowick_WMF) [01:22:48] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/487168 (https://phabricator.wikimedia.org/T212521) (owner: 10Jdlrobson) [01:24:47] 10MediaWiki-User-management, 10Anti-Harassment, 10Wikimedia-Site-requests, 10Epic, 10User-notice: [Epic] Partial block rollout - https://phabricator.wikimedia.org/T218626 (10Xaosflux) [01:25:43] 10MediaWiki-User-management, 10Anti-Harassment, 10Wikimedia-Site-requests, 10Epic, 10User-notice: [Epic] Partial block rollout - https://phabricator.wikimedia.org/T218626 (10Xaosflux) [01:46:25] (03CR) 10Eric Gardner: [C: 03+2] "Nice solution. Works properly in local testing. Good to go." [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/557116 (https://phabricator.wikimedia.org/T240510) (owner: 10Anne Tomasevich) [01:50:34] (03CR) 10Eric Gardner: [C: 03+2] Don't remove image on rerender during publish [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/558192 (https://phabricator.wikimedia.org/T240877) (owner: 10Anne Tomasevich) [01:57:45] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/558270 (owner: 10Libraryupgrader) [02:00:47] (03Merged) 10jenkins-bot: Remove unused disabledCr variable from the JavaScript file [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/558271 (owner: 10Jack Phoenix) [02:00:49] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/InlineCategorizer] - 10https://gerrit.wikimedia.org/r/558272 (owner: 10Libraryupgrader) [02:00:57] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.2, 10Growth-Team (Current Sprint): Variant tests: turn on help panel for homepage people - https://phabricator.wikimedia.org/T240920 (10MMiller_WMF) [02:03:12] 10NewcomerTasks 1.2, 10Epic, 10Growth-Team (Current Sprint): [EPIC] Growth: Newcomer tasks 1.2 (guidance) - https://phabricator.wikimedia.org/T239181 (10MMiller_WMF) [02:03:18] 10LibUp: Remove reportUnusedDisableDirectives when updating to eslint-config-wikimedia to 0.15.0 or higher - https://phabricator.wikimedia.org/T237166 (10Legoktm) p:05Triage→03High a:03Legoktm Sorry, missed when this was filed. Will fix it tonight. Removing it should be pretty trivial. [02:11:07] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Growth-Team (Current Sprint), 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17): Newcomer tasks: difficulty filter styling issues on mobile - https://phabricator.wikimedia.org/T238460 (10MMiller_WMF) 05Open→03Resolved Thank you! [02:11:10] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Growth-Team (Current Sprint), 10MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), 10Patch-For-Review: Newcomer tasks: implement difficulty filters - https://phabricator.wikimedia.org/T235042 (10MMiller_WMF) [02:12:07] 10NewcomerTasks Future Release , 10Growth-Team (Current Sprint), 10MW-1.35-notes (1.35.0-wmf.10; 2019-12-10): Variant tests: "initiation" test - https://phabricator.wikimedia.org/T238888 (10MMiller_WMF) This now goes into In Progress while the test runs, to be continued when it is time to analyze the results. [02:15:53] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17): Newcomer tasks: suggested edits initiation and overlays - https://phabricator.wikimedia.org/T232419 (10MMiller_WMF) Thanks. @Etonk... [02:15:55] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Growth-Team (Current Sprint): Newcomer tasks: ambassadors evaluate edits - https://phabricator.wikimedia.org/T240295 (10MMiller_WMF) 05Open→03Resolved Thank you! Looking across all the edits, it looks like about 90% are good faith and 80% are product... [02:15:57] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Epic, 10Growth-Team (Current Sprint): [EPIC] Growth: Newcomer tasks 1.0 - https://phabricator.wikimedia.org/T227728 (10MMiller_WMF) [02:18:29] 10Who-Wrote-That, 10Community-Tech (Kanban-Q2-2019-20): WWT: Adjust Username Appearance [high priority] [medium] - https://phabricator.wikimedia.org/T240707 (10MusikAnimal) a:03MusikAnimal [02:31:11] (03Merged) 10jenkins-bot: Don't show focus outline on suggestions unless user presses tab [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/557116 (https://phabricator.wikimedia.org/T240510) (owner: 10Anne Tomasevich) [02:40:47] (03Merged) 10jenkins-bot: Don't remove image on rerender during publish [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/558192 (https://phabricator.wikimedia.org/T240877) (owner: 10Anne Tomasevich) [03:30:24] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/558289 (owner: 10Libraryupgrader) [03:35:08] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/LDAPAuthorization] - 10https://gerrit.wikimedia.org/r/558290 (owner: 10Libraryupgrader) [03:37:16] (03PS1) 10Mholloway: Log entire Status in MachineVisionEntitySaveException [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/558291 [03:40:53] (03CR) 10Dmaza: [C: 03+2] Minor fixes to PreliminaryCheckServiceTest [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/558101 (owner: 10Tchanders) [03:50:44] 10WMSE-Magnus Sälgö: Workflow/version management when Europeana reference wrong person in Wikidata - https://phabricator.wikimedia.org/T240809 (10Salgo60) Added a note on the talk page of [[ https://www.wikidata.org/wiki/Wikidata_talk:WikiProject_sum_of_all_paintings#Europeana_Entity | WikiProject_sum_of_all_pai... [03:54:10] (03Merged) 10jenkins-bot: Minor fixes to PreliminaryCheckServiceTest [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/558101 (owner: 10Tchanders) [04:01:02] 10MediaWiki-User-management, 10Mobile: Block message does not transclude template for mobile editors when Reason field includes a template - https://phabricator.wikimedia.org/T240907 (10Ammarpad) [04:01:07] 10MediaWiki-User-management, 10MobileFrontend, 10Anti-Harassment, 10Readers-Web-Backlog (Tracking): Better handle block reasons on mobile (specifically templates and HTML comments) - https://phabricator.wikimedia.org/T189717 (10Ammarpad) [04:09:08] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Onboarding - https://phabricator.wikimedia.org/T236304 (10AMuigai) [04:14:41] (03CR) 10Dmaza: "Looking good. I'm yet to test it and look the query in detail." (036 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/558147 (owner: 10Tchanders) [04:25:40] 10MediaWiki-User-management, 10Anti-Harassment, 10Wikimedia-Site-requests, 10Epic, 10User-notice: [Epic] Partial block rollout - https://phabricator.wikimedia.org/T218626 (10SRuizR) [04:27:41] 04(no projects): Mobile editors not shown new messages banner - https://phabricator.wikimedia.org/T240889 (10Ammarpad) I believe, this is intentional. You're just seeing it odd because you're using the mobile version (for the first time?) judging by your comments on enwiki. The "you have new messages" banner i... [04:37:24] 10Wikimedia-Site-requests: Enable {{SHORTDESC: }} magic word on sr.wiki - https://phabricator.wikimedia.org/T240746 (10Dcljr) >>! In T240746#5744475, @Acamicamacaraca wrote: > @Dcljr Okay. You managed to disable that template, but what about 352,404 articles that is using this one — Шаблон:Кратак опис? > > If w... [04:41:43] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/LinkSuggest] - 10https://gerrit.wikimedia.org/r/558303 (owner: 10Libraryupgrader) [04:44:46] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/LinkSuggest2] - 10https://gerrit.wikimedia.org/r/558304 (owner: 10Libraryupgrader) [04:52:10] iatajara: hello [04:52:25] itajara: hello [04:52:41] Oh, I'm still itajara :) [04:52:46] \nick Ebe123 [04:53:00] I am Darth from GCI [04:53:00] 10Who-Wrote-That, 10Community-Tech (Kanban-Q2-2019-20): WWT: Adjust Username Appearance [high priority] [medium] - https://phabricator.wikimedia.org/T240707 (10MusikAnimal) PR https://github.com/wikimedia/WhoWroteThat/pull/124 [04:53:09] Sorry, working in LaTeX [04:53:21] ? [04:53:25] So yes, how's it going Darth? [04:53:45] Can u check my code ? [04:53:58] LaTeX is a typesetting language (like to write documents). The commands start with a backslash, unlike here with a slash [04:54:03] Link to code [04:55:37] https://en.wikipedia.org/wiki/Module:Sandbox/Sanrac/sometest [04:57:50] Yes, so there is a way to test for nil and give a default value [04:58:22] First of all, celcius is undefined, you can only use tonumber with frame.args.celsius [04:58:23] huh ? [04:58:38] hmm [04:58:56] Then, you can use "or" to specify a value if nil [04:59:11] i want it to be a number not a nil [05:00:50] (03PS4) 10Ammarpad: Allow blocked admin to restore their (deleted) talkpage if not blocked from it [core] - 10https://gerrit.wikimedia.org/r/555717 (https://phabricator.wikimedia.org/T238310) [05:04:09] Yes, so do "tonumber() or [05:04:18] " [05:04:48] before what ? [05:04:56] ? [05:05:05] cels = tonumber... [05:05:22] ohh i was trying to do it the other way round [05:05:49] celsius is undefined, you need to use frame.args.celsius anyways [05:06:12] can u explain what that command does ? [05:09:53] Hi [05:10:00] hi [05:10:22] Hello Unknown56 :) [05:10:45] :) [05:12:45] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/555717 (https://phabricator.wikimedia.org/T238310) (owner: 10Ammarpad) [05:14:12] what command? [05:14:34] frame.args.celsius [05:14:40] frame.args.celsius gives the "celsius" parameter from your invocations [05:14:51] so it's |celsius=... [05:15:01] ok got it [05:15:09] thx :) [05:15:27] btw i am still not able to convert celsius into a number [05:16:12] celsius is undefined, you must use frame.args.celsius [05:16:29] and you must assign it to cels [05:17:03] " cels = frame.args.celsius" i have already used this [05:17:30] cels = tonumber(...) [05:17:47] putting tonumber(celsius) beforehand means nothing [05:18:49] Unknown56: you should also define here `celsius = tonumber()` [05:19:05] 'cels = tonumber(frame.args.celsius)' i have tried this [05:19:43] You must also change fahr to use cels and not "celsius" [05:20:00] as "celsius" is undefined, but "cels" is defined [05:20:11] Yes :) [05:20:14] oh [05:20:57] oh thx got it now :) [05:21:33] so my mistake was to use celsius instead of cels [05:24:50] (03PS22) 10Fomafix: Remove deprecated language codes from Names.php [core] - 10https://gerrit.wikimedia.org/r/279087 (https://phabricator.wikimedia.org/T119076) (owner: 10Gerrit Patch Uploader) [05:35:36] (03CR) 10jerkins-bot: [V: 04-1] Remove deprecated language codes from Names.php [core] - 10https://gerrit.wikimedia.org/r/279087 (https://phabricator.wikimedia.org/T119076) (owner: 10Gerrit Patch Uploader) [05:37:33] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/279087 (https://phabricator.wikimedia.org/T119076) (owner: 10Gerrit Patch Uploader) [05:41:05] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/Link_Attributes] - 10https://gerrit.wikimedia.org/r/558306 (owner: 10Libraryupgrader) [05:42:17] 10Wikimedia-Site-requests: Enable {{SHORTDESC: }} magic word on sr.wiki - https://phabricator.wikimedia.org/T240746 (10DannyS712) >>! In T240746#5746729, @Dcljr wrote: >>>! In T240746#5744475, @Acamicamacaraca wrote: >> @Dcljr Okay. You managed to disable that template, but what about 352,404 articles that is us... [05:43:44] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/Linter] - 10https://gerrit.wikimedia.org/r/558308 (owner: 10Libraryupgrader) [05:50:43] (03PS23) 10Fomafix: Remove deprecated language codes from Names.php [core] - 10https://gerrit.wikimedia.org/r/279087 (https://phabricator.wikimedia.org/T119076) (owner: 10Gerrit Patch Uploader) [05:54:46] 10MediaWiki-Special-pages, 10Core Platform Team, 10Wikimedia-Rdbms, 10User-DannyS712, 10Wikimedia-production-error: Exception caught inside exception handler. - https://phabricator.wikimedia.org/T240924 (10DannyS712) [05:56:56] 10MediaWiki-Special-pages, 10Core Platform Team, 10Wikimedia-Rdbms, 10User-DannyS712, 10Wikimedia-production-error: Special:NewPages - Exception caught inside exception handler.when filtering using associated namespace - https://phabricator.wikimedia.org/T240924 (10DannyS712) [05:57:08] 10MediaWiki-Special-pages, 10Core Platform Team, 10Wikimedia-Rdbms, 10User-DannyS712, 10Wikimedia-production-error: Special:NewPages - Exception caught inside exception handler when filtering using associated namespace - https://phabricator.wikimedia.org/T240924 (10DannyS712) [05:57:48] (03PS2) 10Legoktm: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/Linter] - 10https://gerrit.wikimedia.org/r/558308 (owner: 10Libraryupgrader) [05:57:50] (03PS1) 10Legoktm: API: Use addWhereIDsFld since we're passing along a list of IDs [extensions/Linter] - 10https://gerrit.wikimedia.org/r/558317 [05:57:52] (03PS1) 10Legoktm: CategoryManager: Fix type annotations [extensions/Linter] - 10https://gerrit.wikimedia.org/r/558318 [06:00:40] (03CR) 10Samwilson: [C: 04-1] Add user preference info to basic info section (031 comment) [core] - 10https://gerrit.wikimedia.org/r/554654 (https://phabricator.wikimedia.org/T234952) (owner: 10HMonroy) [06:00:53] (03CR) 10jerkins-bot: [V: 04-1] API: Use addWhereIDsFld since we're passing along a list of IDs [extensions/Linter] - 10https://gerrit.wikimedia.org/r/558317 (owner: 10Legoktm) [06:01:02] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/Linter] - 10https://gerrit.wikimedia.org/r/558308 (owner: 10Libraryupgrader) [06:01:04] (03CR) 10jerkins-bot: [V: 04-1] CategoryManager: Fix type annotations [extensions/Linter] - 10https://gerrit.wikimedia.org/r/558318 (owner: 10Legoktm) [06:02:15] 10WMSE-FindingGLAMs-2018 (Campaign): Logout panel appears on wrong side of the screen - https://phabricator.wikimedia.org/T223088 (10Alicia_Fagerving_WMSE) [06:02:43] (03PS2) 10Legoktm: API: Use addWhereIDsFld since we're passing along a list of IDs [extensions/Linter] - 10https://gerrit.wikimedia.org/r/558317 [06:02:45] (03PS2) 10Legoktm: CategoryManager: Fix type annotations [extensions/Linter] - 10https://gerrit.wikimedia.org/r/558318 [06:02:47] (03PS3) 10Legoktm: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/Linter] - 10https://gerrit.wikimedia.org/r/558308 (owner: 10Libraryupgrader) [06:02:49] 10MediaWiki-Special-pages, 10Core Platform Team, 10Wikimedia-Rdbms, 10Beta-Cluster-reproducible, and 2 others: Special:NewPages - Exception caught inside exception handler when filtering using associated namespace - https://phabricator.wikimedia.org/T240924 (10DannyS712) https://en.wikipedia.beta.wmflabs.o... [06:04:06] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/279087 (https://phabricator.wikimedia.org/T119076) (owner: 10Gerrit Patch Uploader) [06:07:52] 10MediaWiki-Special-pages, 10Core Platform Team, 10MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), 10User-DannyS712: Special:NewPages - allow hiding pages created by users when non-users can create talk pages - https://phabricator.wikimedia.org/T238483 (10DannyS712) 05Resolved→03Open Doesn't actually work -... [06:08:32] (03PS1) 10DannyS712: NewPagesPager: Fix "hide registered users" option [core] - 10https://gerrit.wikimedia.org/r/558323 (https://phabricator.wikimedia.org/T238483) [06:09:39] (03PS2) 10DannyS712: NewPagesPager: Fix "hide registered users" option [core] - 10https://gerrit.wikimedia.org/r/558323 (https://phabricator.wikimedia.org/T238483) [06:12:18] (03PS3) 10DannyS712: Follow up 551328: NewPagesPager - fix "hide registered users" option [core] - 10https://gerrit.wikimedia.org/r/558323 (https://phabricator.wikimedia.org/T238483) [06:14:19] (03PS4) 10DannyS712: Follow up 9ef34a2f1d0: fix NewPagesPager "hide registered users" option [core] - 10https://gerrit.wikimedia.org/r/558323 (https://phabricator.wikimedia.org/T238483) [06:14:37] 10MediaWiki-extensions-Page_Forms, 10UI-Standardization: Convert Page Forms to use OOUI - https://phabricator.wikimedia.org/T192752 (10Samwilson) Thanks @Volker_E. That makes sense; most datetime pickers are pretty confusing. Will there be a timepicker of any sort in the future? Or just text fields? Does this... [06:15:33] o/ [06:16:35] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/LogEntry] - 10https://gerrit.wikimedia.org/r/558325 (owner: 10Libraryupgrader) [06:18:06] 10MediaWiki-extensions-Page_Forms, 10UI-Standardization: Convert Page Forms to use OOUI - https://phabricator.wikimedia.org/T192752 (10Volker_E) @Samwilson In my opinion, OOUI DateInputWidget and a normal text inputs for time and timezone (without jQuery UI?) would be the best option as we want to get rid of j... [06:21:40] hello [06:21:44] anyone? [06:22:05] hi TechneSiyam [06:22:06] 10MediaWiki-Special-pages, 10Core Platform Team, 10Wikimedia-Rdbms, 10Beta-Cluster-reproducible, and 2 others: Special:NewPages - Exception caught inside exception handler when filtering using associated namespace - https://phabricator.wikimedia.org/T240924 (10DannyS712) a:03DannyS712 [06:22:12] hey [06:22:29] I was confused about lilypond [06:22:45] do you know what is this? and how it works? [06:22:52] not too familiar with it [06:23:00] ebe123 would know, i believe [06:23:01] (03PS1) 10DannyS712: NewPagesPager: Fix namespace query conditions [core] - 10https://gerrit.wikimedia.org/r/558328 (https://phabricator.wikimedia.org/T240924) [06:23:44] i assume you've come across https://en.wikipedia.org/wiki/LilyPond [06:24:13] yes [06:24:18] right [06:24:49] is there something particular you're trying to do? [06:26:28] (03PS24) 10Fomafix: Remove deprecated language codes from Names.php [core] - 10https://gerrit.wikimedia.org/r/279087 (owner: 10Gerrit Patch Uploader) [06:26:36] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/558323 (https://phabricator.wikimedia.org/T238483) (owner: 10DannyS712) [06:26:47] (03PS2) 10DannyS712: NewPagesPager: Fix namespace query conditions [core] - 10https://gerrit.wikimedia.org/r/558328 (https://phabricator.wikimedia.org/T240924) [06:27:55] 10MediaWiki-Special-pages, 10Core Platform Team, 10Wikimedia-Rdbms, 10Beta-Cluster-reproducible, and 3 others: Special:NewPages - Exception caught inside exception handler when filtering using associated namespace - https://phabricator.wikimedia.org/T240924 (10DannyS712) Caused by (me) omitting a needed sp... [06:28:10] not now [06:28:19] i want to learn about it [06:28:34] shreyasminocha: i am curious about it [06:29:33] ah. the best person to ask would be Étienne, like i said [06:29:42] although the wikipedia page should be a good place to start [06:31:00] (03CR) 10Legoktm: "recheck" [extensions/HelpCommons] - 10https://gerrit.wikimedia.org/r/558230 (owner: 10Libraryupgrader) [06:35:41] (03PS2) 10Legoktm: build: Updating dependencies [extensions/ImageTweaks] - 10https://gerrit.wikimedia.org/r/558263 (owner: 10Libraryupgrader) [06:35:43] (03PS1) 10Legoktm: Update jquery.ui module dependencies [extensions/ImageTweaks] - 10https://gerrit.wikimedia.org/r/558333 [06:38:20] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/558328 (https://phabricator.wikimedia.org/T240924) (owner: 10DannyS712) [06:39:11] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/279087 (owner: 10Gerrit Patch Uploader) [06:40:03] (03PS2) 10Legoktm: build: Updating dependencies [extensions/Challenge] - 10https://gerrit.wikimedia.org/r/557710 (owner: 10Libraryupgrader) [06:40:05] (03PS1) 10Legoktm: Update jquery.ui dependencies module names [extensions/Challenge] - 10https://gerrit.wikimedia.org/r/558335 [06:41:40] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/Challenge] - 10https://gerrit.wikimedia.org/r/557710 (owner: 10Libraryupgrader) [06:41:42] (03CR) 10jerkins-bot: [V: 04-1] Update jquery.ui dependencies module names [extensions/Challenge] - 10https://gerrit.wikimedia.org/r/558335 (owner: 10Legoktm) [06:45:36] hello [06:46:27] hi darth [06:47:34] hey [06:48:58] oh my mentor is offline [06:49:03] i wanted to talk to him/her [06:49:42] So who all are from GCI ? [06:49:46] Darth: do you need help with something? [06:49:49] if you have a question you can ask here and someone who knows the answer could answer it :) [06:50:13] No i was just a little confused about my task [06:50:37] Would be difficult to explain [06:50:52] :) [06:50:52] Then you have to wait, we are all volunteers. [06:51:08] yeah [06:53:40] (03PS2) 10Legoktm: build: Updating mediawiki/minus-x to 0.3.2 [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/558293 (owner: 10Libraryupgrader) [06:54:15] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/minus-x to 0.3.2 [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/558293 (owner: 10Libraryupgrader) [06:54:43] Darth: Which mentor u want to talk to? [06:55:43] (03PS2) 10Legoktm: build: Updating mediawiki/minus-x to 0.3.2 [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/558336 (owner: 10Libraryupgrader) [06:56:02] Étienne [06:56:03] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/minus-x to 0.3.2 [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/558336 (owner: 10Libraryupgrader) [06:56:10] wikibugs: !ask [06:56:16] is any mentor here ? [06:56:21] Darth: !ask [06:56:43] ask if you are not sure about your task [06:56:54] i have submitted my task [06:57:20] but i think i mighthave made a mistake [06:57:21] Darth: Okay.Someone will review it then.Please wait for it [06:57:40] yeah i am waiting [06:58:02] taking a look [06:58:02] Darth: Oh..Then you have to mention about the task and what you think you have mistaken [06:58:04] (03CR) 10Robert Vogel: [V: 03+2 C: 03+2] Fix local login issue [extensions/LDAPAuthentication2] (REL1_31) - 10https://gerrit.wikimedia.org/r/557021 (owner: 10Robert Vogel) [06:58:11] (03CR) 10Robert Vogel: [V: 03+2 C: 03+2] Fix local login issue [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/556196 (owner: 10Robert Vogel) [06:59:49] Darth: what name do you use on the gci interface? [07:01:24] ๖ۣۜƊαrthǤαndαlf? [07:01:42] yes,how do u know ? [07:02:02] i'm a mentor [07:02:15] ohh [07:02:26] Lua Task 3? [07:02:35] yes [07:02:40] what're you having trouble with? [07:03:05] have u checked it ? [07:03:21] i am not sure if it is right [07:03:39] have you tried to make the changes Étienne requested? [07:03:43] it doesn [07:03:49] it doesn't seem to be the case* [07:04:18] this is the first time i have submitted the task [07:04:33] alright. do you want me to explain étienne's feedback? [07:05:18] ok [07:05:57] so one of the things they say is that you don't need to call tonumber for integers [07:06:06] ohh i didnt see she has replied [07:06:22] oh, he* has, yes [07:06:41] ohh he* [07:07:14] :) [07:08:01] still a question [07:08:19] sure [07:08:40] do i have to print both the conversion and the statements ? [07:09:19] yes, so something of the style "25 degrees Celsius is 77 degrees Fahrenheit. It is warm." [07:09:33] ok [07:09:53] 10Password-Reset-Update, 10Community-Tech (Kanban-Q2-2019-20): PRU: Enable PRU Functionality via UI in Test Wiki - https://phabricator.wikimedia.org/T240736 (10Samwilson) a:03Samwilson > Do you prefer that we have it up on testing on beta or test wiki? It's already enabled on beta. Do you want it enabled o... [07:12:54] (03PS1) 10Andrew Bogott: WMF Hack: remove the 'Interfaces' tab from the instance detail view [openstack/horizon/horizon] (train) - 10https://gerrit.wikimedia.org/r/558343 (https://phabricator.wikimedia.org/T239974) [07:12:56] (03PS1) 10Andrew Bogott: instance panel: remove several instance functions that we don't support [openstack/horizon/horizon] (train) - 10https://gerrit.wikimedia.org/r/558344 (https://phabricator.wikimedia.org/T239974) [07:13:08] 10Password-Reset-Update, 10Community-Tech (Kanban-Q2-2019-20), 10Patch-For-Review: PRU: Enable PRU Functionality via UI in Test Wiki - https://phabricator.wikimedia.org/T240736 (10Samwilson) (As well as test.wikipedia.org, I meant!) Anyway, the above patch enables it on both test wikis. [07:14:23] shreyasminocha: i edited it [07:14:42] (03PS2) 10Andrew Bogott: WMF Hack: remove several instance functions that we don't support [openstack/horizon/horizon] (train) - 10https://gerrit.wikimedia.org/r/558344 (https://phabricator.wikimedia.org/T239974) [07:15:25] (03CR) 10Andrew Bogott: [V: 03+2 C: 03+2] WMF Hack: remove the 'Interfaces' tab from the instance detail view [openstack/horizon/horizon] (train) - 10https://gerrit.wikimedia.org/r/558343 (https://phabricator.wikimedia.org/T239974) (owner: 10Andrew Bogott) [07:15:26] (03CR) 10Andrew Bogott: [V: 03+2 C: 03+2] WMF Hack: remove several instance functions that we don't support [openstack/horizon/horizon] (train) - 10https://gerrit.wikimedia.org/r/558344 (https://phabricator.wikimedia.org/T239974) (owner: 10Andrew Bogott) [07:15:32] 10Password-Reset-Update, 10Community-Tech (Kanban-Q2-2019-20), 10Patch-For-Review: PRU: Enable PRU Functionality via UI in Test Wiki - https://phabricator.wikimedia.org/T240736 (10ifried) @Samwilson Sorry, I should have clarified. I meant: Does @dom_walden prefer to have it available in the UI (i.e., not beh... [07:15:52] 10WMSE-FindingGLAMs-2018 (Campaign): Processing of Minor Grants applications - https://phabricator.wikimedia.org/T240819 (10Alicia_Fagerving_WMSE) [07:16:01] (03PS1) 10Andrew Bogott: Update horizon submodule [openstack/horizon/deploy] (train) - 10https://gerrit.wikimedia.org/r/558345 (https://phabricator.wikimedia.org/T239974) [07:16:13] Darth: a couple of things [07:16:28] hmm [07:16:40] (03CR) 10Andrew Bogott: [V: 03+2 C: 03+2] Update horizon submodule [openstack/horizon/deploy] (train) - 10https://gerrit.wikimedia.org/r/558345 (https://phabricator.wikimedia.org/T239974) (owner: 10Andrew Bogott) [07:17:01] first, you don't need to call tonumber on (cels*9/5)+32 [07:17:14] because the result of integer arithmetic is an integer [07:17:29] you only need tonumber when you're converting strings, for example, to integers [07:17:37] ohh ok [07:17:53] numbers* lua doesn't have a concept of integers. i meant numbers [07:18:09] second, there's still a bit of an issue with the output string [07:18:20] "41It is cold " [07:18:42] so what should it be ? [07:19:03] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Search screen carousel - https://phabricator.wikimedia.org/T236263 (10AMuigai) [07:19:04] and how do i add a space between them ? [07:19:05] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Article progress indicator - https://phabricator.wikimedia.org/T234627 (10AMuigai) [07:19:18] per step 3 of https://en.wikipedia.org/wiki/User:RexxS/GCI-2019-Task03, it should be something like `15 degrees Celsius is 59 degrees Fahrenheit.` followed be `It is warm/cold.` [07:20:03] you can concatenate (join) strings using lua's concat operator `..`, as you learnt in an earlier task [07:20:12] ok [07:20:17] will change it [07:20:20] so you could concatenate the different parts of the message and output that [07:20:28] cool. let must just update the gci interface [07:21:25] yeah gotta go for a while [07:21:31] will edit then [07:21:57] 👍 [07:22:00] 10Who-Wrote-That, 10Community-Tech (Kanban-Q2-2019-20): WWT: Prevent Info Bar from Blocking Revision Details Pop-up [don't take until we discuss] - https://phabricator.wikimedia.org/T240927 (10ifried) [07:23:14] 10Who-Wrote-That, 10Community-Tech (Kanban-Q2-2019-20): WWT: Prevent Info Bar from Blocking Revision Details Pop-up [don't take until we discuss] - https://phabricator.wikimedia.org/T240927 (10ifried) [07:24:47] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/MagicNoCache] - 10https://gerrit.wikimedia.org/r/558342 (owner: 10Libraryupgrader) [07:24:49] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/MagicNumberedHeadings] - 10https://gerrit.wikimedia.org/r/558346 (owner: 10Libraryupgrader) [07:28:13] Hello? [07:29:24] anyone? [07:29:36] TechneSiyam: what's up? [07:29:43] oh [07:29:56] IAmNetx: I was asking about some tasks [07:30:21] there are some tasks in GCI where they asking for video tutorials [07:31:04] IAmNetx: I want to know do I need to make a tutorial with my voice? [07:32:53] I'd imagine it'd make it easier to explain what they want you to explain with that task, but you could use subtitles or other on-screen text to explain as well [07:33:32] okay. [07:36:58] 10WMSE-FindingGLAMs-2018 (Campaign): Featured GLAMs on main page - https://phabricator.wikimedia.org/T223198 (10Alicia_Fagerving_WMSE) [07:37:08] 10WMSE-FindingGLAMs-2018 (Campaign): 'collection or exhibition size' should include qualifiers - https://phabricator.wikimedia.org/T223199 (10Alicia_Fagerving_WMSE) [07:37:50] shreyaminocha: i have corrected it now [07:38:09] shreyasminocha: [07:38:49] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Growth-Team (Current Sprint): Newcomer tasks: on mobile 'Suggested edits' activation will flash 'Start here' module and Homepage - https://phabricator.wikimedia.org/T238037 (10Tgr) (Patches are in {T238179}.) [07:42:28] (03CR) 10Ammarpad: Allow blocked admin to restore their (deleted) talkpage if not blocked from it (032 comments) [core] - 10https://gerrit.wikimedia.org/r/555717 (https://phabricator.wikimedia.org/T238310) (owner: 10Ammarpad) [07:43:48] 10Inuka-Team, 10Wikipedia-Previews: Setup CI for Wikipedia-Previews - https://phabricator.wikimedia.org/T240012 (10AMuigai) [07:45:16] Darth: left a comment there [07:45:35] yeah checked it now [07:46:43] i have done for 9 degrees [07:47:29] and if it is a blank or invalid then it will show error [07:47:42] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Offline mode - https://phabricator.wikimedia.org/T236897 (10AMuigai) [07:48:38] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/558357 (owner: 10Libraryupgrader) [07:49:53] i believe the task requires you to default to converting 0 celsius if it's blank or invalid [07:50:15] Darth [07:50:57] you would do that by slightly altering the line `cels = tonumber(frame.args.celsius or 0)` [07:51:00] i have done that [07:51:07] ohh [07:51:16] let me try [07:51:57] done it check it now [07:52:44] great, the code looks good to me. could you add a couple of lines to User:Sanrac/sandbox to test the blank and invalid cases? [07:53:25] done [07:55:26] thx [07:56:08] you're welcome [07:56:12] great work [07:56:35] thx :) [07:56:50] this is my first year in GCI [07:58:35] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/558359 (owner: 10Libraryupgrader) [08:02:26] (03PS1) 10Saintyinyin: this is my modify test [extensions/examples] - 10https://gerrit.wikimedia.org/r/558363 [08:02:28] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/examples] - 10https://gerrit.wikimedia.org/r/558363 (owner: 10Saintyinyin) [08:11:35] shreyasminocha: u here ? [08:11:43] i got a doubt [08:12:27] (03CR) 10Nikerabbit: [C: 03+2] Simplify Hooks section in extension.json [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/558030 (owner: 10Thiemo Kreuz (WMDE)) [08:13:59] 10MediaWiki-extensions-FlaggedRevs, 10Release-Engineering-Team, 10Regression: FlaggedRevs: Automatic user promotion stopped working on some wikis on June 24 - https://phabricator.wikimedia.org/T237191 (10Zache) Tested that flaggedrevs_promote is still updated ` MariaDB [dewiki_p]> select * from flaggedrev... [08:15:27] (03Merged) 10jenkins-bot: Simplify Hooks section in extension.json [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/558030 (owner: 10Thiemo Kreuz (WMDE)) [08:16:47] (03PS1) 10Saintyinyin: this is review change! [extensions/examples] - 10https://gerrit.wikimedia.org/r/558371 [08:24:53] (03PS2) 10Saintyinyin: this is my modify test [extensions/examples] - 10https://gerrit.wikimedia.org/r/558363 [08:28:40] Darth: yes, how can i help? [08:30:06] can u explain 6 point in lua task 4 ? [08:32:14] 6th point [08:36:43] i gtg rn so will not be able to read your reply [08:37:02] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Fix silly bug in fixOldLogEntries [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/558028 (https://phabricator.wikimedia.org/T228655) (owner: 10Daimona Eaytoy) [08:38:23] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Add missing int casts [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/557059 (owner: 10Umherirrender) [08:38:34] oh [08:40:25] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Remove unused property fromPageTitle from SpecialMobileWatchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558209 (owner: 10Umherirrender) [08:41:43] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Remove wrong default value from WebRequest::getVal call [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/557122 (owner: 10Umherirrender) [08:45:54] (03CR) 10Nikerabbit: [V: 03+1 C: 03+2] Use MassMessage to send notification to user's talkpage [extensions/TranslationNotifications] - 10https://gerrit.wikimedia.org/r/539490 (https://phabricator.wikimedia.org/T144780) (owner: 10Abijeet Patro) [08:49:42] (03Merged) 10jenkins-bot: Fix silly bug in fixOldLogEntries [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/558028 (https://phabricator.wikimedia.org/T228655) (owner: 10Daimona Eaytoy) [08:49:44] (03Merged) 10jenkins-bot: Add missing int casts [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/557059 (owner: 10Umherirrender) [08:53:26] (03Merged) 10jenkins-bot: Remove unused property fromPageTitle from SpecialMobileWatchlist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558209 (owner: 10Umherirrender) [08:54:52] (03PS1) 10ItSpiderman: Add RangeWidget [extensions/OOJSPlus] - 10https://gerrit.wikimedia.org/r/558385 [08:55:32] (03Merged) 10jenkins-bot: Remove wrong default value from WebRequest::getVal call [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/557122 (owner: 10Umherirrender) [08:55:34] (03Merged) 10jenkins-bot: Use MassMessage to send notification to user's talkpage [extensions/TranslationNotifications] - 10https://gerrit.wikimedia.org/r/539490 (https://phabricator.wikimedia.org/T144780) (owner: 10Abijeet Patro) [08:58:37] (03PS2) 10ItSpiderman: Add RangeWidget [extensions/OOJSPlus] - 10https://gerrit.wikimedia.org/r/558385 [09:01:44] 10WMSE-FindingGLAMs-2018 (Campaign): Example GLAMs should be real links - https://phabricator.wikimedia.org/T223589 (10Alicia_Fagerving_WMSE) [09:01:54] 10WMSE-FindingGLAMs-2018 (Campaign): Add a link to Campaign Talk page to report problems - https://phabricator.wikimedia.org/T223673 (10Alicia_Fagerving_WMSE) [09:05:05] (03CR) 10ItSpiderman: [C: 04-1] SecondaryDataUpdates hook (031 comment) [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557504 (owner: 10AlexPinchuk) [09:07:41] (03CR) 10Nikerabbit: [C: 03+2] Remove wrong default value from WebRequest::getVal call [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/557126 (owner: 10Umherirrender) [09:08:11] (03CR) 10Nikerabbit: [C: 03+2] Fix capitalization of class and method names [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/557875 (owner: 10Thiemo Kreuz (WMDE)) [09:09:07] (03CR) 10Nikerabbit: [C: 03+2] Update (missing) PHPDoc blocks [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/557870 (owner: 10Thiemo Kreuz (WMDE)) [09:10:26] (03Merged) 10jenkins-bot: Remove wrong default value from WebRequest::getVal call [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/557126 (owner: 10Umherirrender) [09:10:53] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/558395 (owner: 10L10n-bot) [09:10:59] (03Merged) 10jenkins-bot: Fix capitalization of class and method names [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/557875 (owner: 10Thiemo Kreuz (WMDE)) [09:11:48] (03CR) 10Nikerabbit: [C: 03+2] Remove some dead JavaScript code [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/557881 (owner: 10Thiemo Kreuz (WMDE)) [09:11:50] (03Merged) 10jenkins-bot: Update (missing) PHPDoc blocks [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/557870 (owner: 10Thiemo Kreuz (WMDE)) [09:12:54] (03CR) 10Nikerabbit: [C: 03+2] Remove dead code from LqtHooks class [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/558033 (owner: 10Thiemo Kreuz (WMDE)) [09:15:41] (03Merged) 10jenkins-bot: Remove some dead JavaScript code [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/557881 (owner: 10Thiemo Kreuz (WMDE)) [09:17:33] (03PS5) 10AlexPinchuk: SecondaryDataUpdates hook [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557504 [09:18:34] (03PS6) 10AlexPinchuk: SecondaryDataUpdates hook [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557504 [09:19:25] (03CR) 10ItSpiderman: [C: 03+2] SecondaryDataUpdates hook [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557504 (owner: 10AlexPinchuk) [09:19:29] (03PS1) 10ItSpiderman: SecondaryDataUpdates hook [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/558431 [09:19:32] (03CR) 10ItSpiderman: [C: 03+2] SecondaryDataUpdates hook [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/558431 (owner: 10ItSpiderman) [09:20:44] (03CR) 10jerkins-bot: [V: 04-1] SecondaryDataUpdates hook [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557504 (owner: 10AlexPinchuk) [09:21:01] 10MediaWiki-Special-pages, 10Core Platform Team, 10Wikimedia-Rdbms, 10Beta-Cluster-reproducible, and 3 others: Special:NewPages - Exception caught inside exception handler when filtering using associated namespace - https://phabricator.wikimedia.org/T240924 (10Aklapper) [09:21:04] 10SRE-tools: debmonitor: show OS release name in the host view - https://phabricator.wikimedia.org/T240193 (10hashar) I just felt it would give an extra information when one has a fleet of Jessie, Stretch, Buster servers. That might gives a lead as to why a machine as an old/new package. But I understand it is... [09:26:48] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive" [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/558395 (owner: 10L10n-bot) [09:27:18] (03CR) 10Aklapper: [C: 04-2] "Hi Saintyinyin! Congratulations to your patch in Wikimedia Gerrit, but this is not a place to play. Please abandon your changeset, as it s" [extensions/examples] - 10https://gerrit.wikimedia.org/r/558363 (owner: 10Saintyinyin) [09:27:25] (03CR) 10Aklapper: [C: 04-2] "Hi Saintyinyin! Congratulations to your patch in Wikimedia Gerrit, but this is not a place to play. Please abandon your changeset, as it s" [extensions/examples] - 10https://gerrit.wikimedia.org/r/558371 (owner: 10Saintyinyin) [09:30:54] (03PS2) 10Thiemo Kreuz (WMDE): Introduce ReferenceStack::appendText [extensions/Cite] - 10https://gerrit.wikimedia.org/r/558109 [09:31:20] (03CR) 10Thiemo Kreuz (WMDE): "I added assertions for all 3 code paths." (031 comment) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/558109 (owner: 10Thiemo Kreuz (WMDE)) [09:32:19] 10MediaWiki-User-management, 10Release-Engineering-Team, 10User-DannyS712: User rights validation is sometimes malfunctioning (with FlaggedRevs only?) - https://phabricator.wikimedia.org/T234743 (10Zache) Based on [[ https://www.mediawiki.org/wiki/Manual:$wgExtensionFunctions | Manual:$wgExtensionFunctions ]... [09:32:37] (03Merged) 10jenkins-bot: Remove dead code from LqtHooks class [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/558033 (owner: 10Thiemo Kreuz (WMDE)) [09:32:39] (03Merged) 10jenkins-bot: SecondaryDataUpdates hook [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/558431 (owner: 10ItSpiderman) [09:33:30] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/558109 (owner: 10Thiemo Kreuz (WMDE)) [09:34:24] 10WMSE-Development-Support-2019 (Automatic article quality assessment): The popup overlaps the post edit popup on Edge - https://phabricator.wikimedia.org/T240930 (10Sebastian_Berlin-WMSE) [09:34:54] 10InternetArchiveBot: Link was fine: https://als.wikipedia.org/w/index.php?title=Jakob_Joseph_Matthys&curid=63727&diff=940729&oldid=939655 - https://phabricator.wikimedia.org/T240931 (10Freigut) [09:35:00] 10InternetArchiveBot: Link was fine: https://als.wikipedia.org/w/index.php?title=Jakob_Joseph_Matthys&curid=63727&diff=940729&oldid=939655 - https://phabricator.wikimedia.org/T240931 (10Freigut) Link was fine: https://als.wikipedia.org/w/index.php?title=Jakob_Joseph_Matthys&curid=63727&diff=940729&oldid=939655 [09:36:23] 10Wikidata-Tainted-References-Sprint7: Add tests for referenceListChangeTracker - https://phabricator.wikimedia.org/T240349 (10Rosalie_WMDE) a:05Rosalie_WMDE→03None [09:42:25] 10docker-pkg: Make docker-pkg work on Macs again - https://phabricator.wikimedia.org/T225764 (10hashar) 05Open→03Resolved a:03kostajh In addition to `REQUESTS_CA_BUNDLE`, one can also set `CURL_CA_BUNDLE` if you have curl with the bundled certificates or `SSL_CERT_FILE` which is for OpenSSL ones. I don't... [09:44:02] (03CR) 10jerkins-bot: [V: 04-1] Introduce ReferenceStack::appendText [extensions/Cite] - 10https://gerrit.wikimedia.org/r/558109 (owner: 10Thiemo Kreuz (WMDE)) [09:45:36] Hey there! I'm Aaron. [09:46:34] Hi Aaron :) [09:46:44] I'm here to complete my GCI task. [09:47:01] That's why I'm on this channel. [09:47:20] Cool :) [09:47:55] What IRC client do you use? [09:48:03] Hexchat [09:50:10] Nice :) I used to use HexChat, but I found IRCCloud and it feels nicer to use to me [09:52:02] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/MsCalendar] - 10https://gerrit.wikimedia.org/r/558437 (owner: 10Libraryupgrader) [09:55:31] 04(no projects): Plan to upgrade our application object caching service (memcached) - https://phabricator.wikimedia.org/T240684 (10Aklapper) @jijiki: Sorry for my wrong guess. :) Which basket (project tag) should this be in, so someone could find this task when looking at the workboard? [09:57:55] welcome RedAlan1 :) [09:59:22] (03PS7) 10AlexPinchuk: SecondaryDataUpdates hook [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557504 [10:02:00] 04(no projects): Gerrit test instance is down - https://phabricator.wikimedia.org/T240933 (10Ammarpad) [10:06:56] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/558443 (owner: 10Libraryupgrader) [10:10:46] 10MediaWiki-General, 10Multimedia, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review, 10WorkType-NewFunctionality: Use IEC units (KiB, MiB, etc.) and not SI units (KB, MB) - https://phabricator.wikimedia.org/T54687 (10Verdy_p) >>! Dans T54687#574233, @Nikerabbit a écrit : > That may... [10:12:26] welcome :) [10:29:52] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10I18n: RTL text embedded in LTR reference displayed out of order in Android app - https://phabricator.wikimedia.org/T127406 (10Thryduulf) Confirming that this bug still exists in Android app 2.7.50305-r-2019-11-26 appearing exactly as it did in the 2018 s... [10:31:44] (03CR) 10Mvolz: [C: 03+1] "Is there any issue if I +2 this?" [services/zotero] - 10https://gerrit.wikimedia.org/r/554042 (owner: 10Mvolz) [10:38:40] 10GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: Special:CreateAccount no works when GrowthExperiments extension is installed - https://phabricator.wikimedia.org/T240903 (10kostajh) [10:39:20] 10WMSE-Magnus Sälgö: Workflow/version management when Europeana reference wrong person in Wikidata - https://phabricator.wikimedia.org/T240809 (10Salgo60) [10:40:38] (03CR) 10Vedmaka Wakalaka: Create UserGroupManager (0311 comments) [core] - 10https://gerrit.wikimedia.org/r/545690 (https://phabricator.wikimedia.org/T234921) (owner: 10Ppchelko) [10:43:34] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Article page menu - https://phabricator.wikimedia.org/T236266 (10hueitan) a:05hueitan→03None [10:50:01] (03PS1) 10Thiemo Kreuz (WMDE): Simplify Hooks section in extension.json [extensions/Popups] - 10https://gerrit.wikimedia.org/r/558460 [10:50:08] Well I guess my task has come to an end [10:50:23] 10Advanced Mobile Contributions, 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): Add History to article toolbar for all logged-in users - https://phabricator.wikimedia.org/T232652 (10ovasileva) === QA (beta cluster) - passed tested on: chrome desktop 79.0.3945.79,... [10:50:25] 10Advanced Mobile Contributions, 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): Add History to article toolbar for all logged-in users - https://phabricator.wikimedia.org/T232652 (10ovasileva) [10:50:26] Bye <3 [10:53:10] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/558460 (owner: 10Thiemo Kreuz (WMDE)) [10:53:20] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Select language to read an article - https://phabricator.wikimedia.org/T234628 (10hueitan) a:03hueitan [10:53:37] 10WMSE-Magnus Sälgö: Workflow/version management when Europeana reference wrong person in Wikidata - https://phabricator.wikimedia.org/T240809 (10Salgo60) [10:54:13] 10Advanced Mobile Contributions, 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): Add History to article toolbar for all logged-in users - https://phabricator.wikimedia.org/T232652 (10ovasileva) [10:54:22] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/NamespacePopups] - 10https://gerrit.wikimedia.org/r/558461 (owner: 10Libraryupgrader) [10:55:42] 10Advanced Mobile Contributions, 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): Add History to article toolbar for all logged-in users - https://phabricator.wikimedia.org/T232652 (10ovasileva) [10:56:25] 10Advanced Mobile Contributions, 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): Add History to article toolbar for all logged-in users - https://phabricator.wikimedia.org/T232652 (10ovasileva) [10:57:37] 10WMSE-Magnus Sälgö: Workflow/version management when Europeana reference wrong person in Wikidata - https://phabricator.wikimedia.org/T240809 (10Salgo60) [11:02:20] 10GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: Special:CreateAccount no works when GrowthExperiments extension is installed - https://phabricator.wikimedia.org/T240903 (10Zoranzoki21) >>! In T240903#5747150, @Ammarpad wrote: >>>! In T240903#5746170, @Zoranzoki21 wrote: >> @Aklapper... [11:02:56] (03PS1) 10Thiemo Kreuz (WMDE): Fix initial preferences for newly created user accounts [extensions/Popups] - 10https://gerrit.wikimedia.org/r/558464 (https://phabricator.wikimedia.org/T238991) [11:04:05] 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): Add article and discussion tabs to all logged-in users on mobile - https://phabricator.wikimedia.org/T232594 (10ovasileva) ==== QA Results - beta cluster - passed tested on: chrome desktop 79.0.3945.79, chrome mobile 78.0.3904.108... [11:04:10] 10GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: Special:CreateAccount no works when GrowthExperiments extension is installed - https://phabricator.wikimedia.org/T240903 (10kostajh) > Can you disable GrowthExperiments and post a screenshot of the Special:CreateAccount page here pl... [11:04:52] 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): Add article and discussion tabs to all logged-in users on mobile - https://phabricator.wikimedia.org/T232594 (10ovasileva) [11:06:06] (03CR) 10jerkins-bot: [V: 04-1] Fix initial preferences for newly created user accounts [extensions/Popups] - 10https://gerrit.wikimedia.org/r/558464 (https://phabricator.wikimedia.org/T238991) (owner: 10Thiemo Kreuz (WMDE)) [11:06:22] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/558464 (https://phabricator.wikimedia.org/T238991) (owner: 10Thiemo Kreuz (WMDE)) [11:06:34] 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): Add article and discussion tabs to all logged-in users on mobile - https://phabricator.wikimedia.org/T232594 (10ovasileva) [11:08:52] 10ContentTranslation, 10Language-Team (Language-2019-October-December), 10Patch-For-Review: Enable Content translation as a default tool (out of beta) for newly created Wikipedias - https://phabricator.wikimedia.org/T234318 (10KartikMistry) Deployed. [11:09:40] (03PS1) 10Mainframe98: Make TestAutoload{Classes,Namespaces} lazy-loaded attributes [core] - 10https://gerrit.wikimedia.org/r/558468 (https://phabricator.wikimedia.org/T196090) [11:09:52] 10MediaWiki-User-management: Allow users to be blocked from editing pages within a specific category - https://phabricator.wikimedia.org/T190349 (10Thryduulf) That could get unwieldy if lots of users are partially blocked from a given article/set of articles, something quite plausible in topic areas like Israel-... [11:10:55] 10Who-Wrote-That, 10Community-Tech (Kanban-Q2-2019-20): WWT: Prevent Info Bar from Blocking Revision Details Pop-up [don't take until we discuss] - https://phabricator.wikimedia.org/T240927 (10dom_walden) I believe this has/will be fixed here: T234709#5739746. [11:13:40] (03PS2) 10Thiemo Kreuz (WMDE): Fix initial preferences for newly created user accounts [extensions/Popups] - 10https://gerrit.wikimedia.org/r/558464 (https://phabricator.wikimedia.org/T238991) [11:14:22] (03CR) 10Vedmaka Wakalaka: Creates RestrictionStore service (033 comments) [core] - 10https://gerrit.wikimedia.org/r/549909 (https://phabricator.wikimedia.org/T218395) (owner: 10Vedmaka Wakalaka) [11:16:22] (03PS3) 10WhitePhosphorus: Fix a broken link in apisandbox-intro [core] - 10https://gerrit.wikimedia.org/r/551374 (https://phabricator.wikimedia.org/T236477) [11:17:01] (03PS2) 10Mainframe98: Make TestAutoload{Classes,Namespaces} lazy-loaded attributes [core] - 10https://gerrit.wikimedia.org/r/558468 (https://phabricator.wikimedia.org/T196090) [11:17:07] (03CR) 10jerkins-bot: [V: 04-1] Fix initial preferences for newly created user accounts [extensions/Popups] - 10https://gerrit.wikimedia.org/r/558464 (https://phabricator.wikimedia.org/T238991) (owner: 10Thiemo Kreuz (WMDE)) [11:17:19] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/558464 (https://phabricator.wikimedia.org/T238991) (owner: 10Thiemo Kreuz (WMDE)) [11:17:47] 10TimedMediaHandler: MP4 files are not listed as videos on special page - https://phabricator.wikimedia.org/T240837 (10HebronNor) Yeah, the Special:MediaStatistics already have that info, and more. Then maybe the audio and video counts can be removed? At least it confused me for a minute or two. [11:23:38] (03PS3) 10Thiemo Kreuz (WMDE): Fix initial preferences for newly created user accounts [extensions/Popups] - 10https://gerrit.wikimedia.org/r/558464 (https://phabricator.wikimedia.org/T238991) [11:23:42] 10MediaWiki-General, 10Documentation, 10Patch-For-Review, 10Technical-Debt: The "UserSetCookies" hook is listed in documentation as deprecated but doesn't emit deprecation warnings yet - https://phabricator.wikimedia.org/T232880 (10Jdforrester-WMF) p:05Triage→03Lowest [11:24:22] 10Wikimedia-Site-requests, 10Technical-Debt: Fix places where mw-config assumes "s4" means Commons - https://phabricator.wikimedia.org/T213096 (10Jdforrester-WMF) [11:24:57] 10MediaWiki-extensions-CodeReview, 10Release-Engineering-Team-TODO, 10Wikimedia-Site-requests, 10Release-Engineering-Team (Code Health), 10Technical-Debt: Undeploy CodeReview - https://phabricator.wikimedia.org/T116948 (10Jdforrester-WMF) p:05Triage→03Low [11:24:58] (03CR) 10Thiemo Kreuz (WMDE): Fix initial preferences for newly created user accounts (032 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/558464 (https://phabricator.wikimedia.org/T238991) (owner: 10Thiemo Kreuz (WMDE)) [11:25:18] 10Release, 10Train Deployments: 1.35.0-wmf.11 deployment blockers - https://phabricator.wikimedia.org/T233859 (10Jdforrester-WMF) p:05Triage→03High [11:25:42] 10Advanced Mobile Contributions, 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): Updates to user pages for all users - https://phabricator.wikimedia.org/T232653 (10ovasileva) == QA Results - beta cluster - passed == Anon * Ensure that the following items are in both... [11:26:14] 10Advanced Mobile Contributions, 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): Updates to user pages for all users - https://phabricator.wikimedia.org/T232653 (10ovasileva) [11:26:38] 10Advanced Mobile Contributions, 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): Updates to user pages for all users - https://phabricator.wikimedia.org/T232653 (10ovasileva) [11:27:12] 10Wikidata-Tainted-References-Sprint7, 10Patch-For-Review: Popper should close when pressing ESC button - https://phabricator.wikimedia.org/T240849 (10Rosalie_WMDE) [11:27:16] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/558464 (https://phabricator.wikimedia.org/T238991) (owner: 10Thiemo Kreuz (WMDE)) [11:29:29] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/558468 (https://phabricator.wikimedia.org/T196090) (owner: 10Mainframe98) [11:29:31] 10Wikidata-Tainted-References-Sprint7, 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17): Add and use correct X button asset - https://phabricator.wikimedia.org/T240476 (10Rosalie_WMDE) [11:30:20] 10Wikidata-Tainted-References-Sprint7: Fix spacing between popper and feedback link - https://phabricator.wikimedia.org/T240544 (10Rosalie_WMDE) [11:32:10] 10MediaWiki-extensions-TorBlock: VisualEditor does not show a block message for TorBlocks - https://phabricator.wikimedia.org/T240936 (10dom_walden) [11:34:12] (03CR) 10Catrope: [C: 03+2] resourceloader: Remove ResourceLoaderModule::safeFilemtime() [core] - 10https://gerrit.wikimedia.org/r/557620 (https://phabricator.wikimedia.org/T233059) (owner: 10Krinkle) [11:34:15] 10MediaWiki-extensions-TorBlock, 10VisualEditor: VisualEditor does not show a block message for TorBlocks - https://phabricator.wikimedia.org/T240936 (10dom_walden) [11:36:32] 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), 10Readers-Web-Backlog (Kanbanana-2019-20-Q2), 10Regression: Regression: Label is visible on Logout button for logged in users on all wikis (non-AMC) and contribution icon on user page - https://phabricator.wikimedia.org/T240644 (10ovasileva) still seeing the cont... [11:36:37] 10Product-Analytics (Kanban): Onboarding Checklist for Shay Nowick - https://phabricator.wikimedia.org/T240739 (10Peachey88) [11:38:36] 10GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: Special:CreateAccount no works when GrowthExperiments extension is installed - https://phabricator.wikimedia.org/T240903 (10Zoranzoki21) >>! In T240903#5747221, @kostajh wrote: >> Can you disable GrowthExperiments and post a screens... [11:39:05] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Select links within an article - https://phabricator.wikimedia.org/T234625 (10SBisson) Push back to dev to handle references [11:40:28] 10GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: Special:CreateAccount no works when GrowthExperiments extension is installed - https://phabricator.wikimedia.org/T240903 (10kostajh) Thanks for the screenshots and testing. Your wiki does not ask for email address on Special:CreateAccou... [11:46:26] (03Merged) 10jenkins-bot: resourceloader: Remove ResourceLoaderModule::safeFilemtime() [core] - 10https://gerrit.wikimedia.org/r/557620 (https://phabricator.wikimedia.org/T233059) (owner: 10Krinkle) [11:48:52] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Don't show popup links - https://phabricator.wikimedia.org/T240938 (10Jpita) [11:50:09] 10WMSE-Magnus Sälgö: Workflow/version management when Europeana reference wrong person in Wikidata - https://phabricator.wikimedia.org/T240809 (10Salgo60) [11:50:34] (03PS3) 10Catrope: resourceloader: Various optimisations in FileModule::getFileHashes() [core] - 10https://gerrit.wikimedia.org/r/557632 (https://phabricator.wikimedia.org/T233059) (owner: 10Krinkle) [11:53:54] (03PS4) 10Catrope: resourceloader: Various optimisations in FileModule::getFileHashes() [core] - 10https://gerrit.wikimedia.org/r/557632 (https://phabricator.wikimedia.org/T233059) (owner: 10Krinkle) [11:54:02] 10GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: Error in HTMLForm when GrowthExperiments extension installed and site does not ask for an email address on Special:CreateAccount - https://phabricator.wikimedia.org/T240903 (10Aklapper) [11:54:13] (03CR) 10Catrope: [C: 03+2] resourceloader: Various optimisations in FileModule::getFileHashes() [core] - 10https://gerrit.wikimedia.org/r/557632 (https://phabricator.wikimedia.org/T233059) (owner: 10Krinkle) [11:54:34] 10WMSE-Magnus Sälgö: Workflow/version management when Europeana reference wrong person in Wikidata - https://phabricator.wikimedia.org/T240809 (10Salgo60) [11:56:26] (03PS2) 10Catrope: resourceloader: Use FileContentsHasher batching in FileModule::getFileHashes [core] - 10https://gerrit.wikimedia.org/r/557635 (owner: 10Krinkle) [11:56:31] (03CR) 10Catrope: [C: 03+2] resourceloader: Use FileContentsHasher batching in FileModule::getFileHashes [core] - 10https://gerrit.wikimedia.org/r/557635 (owner: 10Krinkle) [11:57:57] (03PS1) 10Catrope: resourceloader: Fix typo in StartUpModule dummy output [core] - 10https://gerrit.wikimedia.org/r/558480 [12:00:52] 10GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: Error in HTMLForm when GrowthExperiments extension installed and site does not ask for an email address on Special:CreateAccount - https://phabricator.wikimedia.org/T240903 (10Zoranzoki21) a:03kostajh >>! In T240903#5747349, @kostajh... [12:07:45] (03Merged) 10jenkins-bot: resourceloader: Various optimisations in FileModule::getFileHashes() [core] - 10https://gerrit.wikimedia.org/r/557632 (https://phabricator.wikimedia.org/T233059) (owner: 10Krinkle) [12:09:26] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557632 (https://phabricator.wikimedia.org/T233059) (owner: 10Krinkle) [12:11:05] (03PS1) 10Jforrester: Include wmf/1.35.0-wmf.11 submodules and default settings [core] (wmf/1.35.0-wmf.11) - 10https://gerrit.wikimedia.org/r/558485 [12:11:19] (03PS3) 10Thiemo Kreuz (WMDE): Introduce ReferenceStack::appendText [extensions/Cite] - 10https://gerrit.wikimedia.org/r/558109 [12:11:21] (03PS1) 10Thiemo Kreuz (WMDE): Fix inconsistent error reporting for invisible content [extensions/Cite] - 10https://gerrit.wikimedia.org/r/558486 [12:11:43] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557635 (owner: 10Krinkle) [12:12:02] (03Merged) 10jenkins-bot: resourceloader: Use FileContentsHasher batching in FileModule::getFileHashes [core] - 10https://gerrit.wikimedia.org/r/557635 (owner: 10Krinkle) [12:12:38] (03CR) 10Jforrester: [C: 03+2] Include wmf/1.35.0-wmf.11 submodules and default settings [core] (wmf/1.35.0-wmf.11) - 10https://gerrit.wikimedia.org/r/558485 (owner: 10Jforrester) [12:12:38] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/558480 (owner: 10Catrope) [12:15:49] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/558109 (owner: 10Thiemo Kreuz (WMDE)) [12:15:51] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/558486 (owner: 10Thiemo Kreuz (WMDE)) [12:19:25] (03CR) 10Pmiazga: "recheck" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/556451 (owner: 10Pmiazga) [12:20:37] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Growth-Team (Current Sprint), 10MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), 10Patch-For-Review: Newcomer tasks: mobile module styling issues - https://phabricator.wikimedia.org/T238280 (10kostajh) OK, patches are up for everything except for E, which w... [12:22:02] (03CR) 10Esanders: "As part of this commit we should document which methods exist in both PHP & JS and which ones are language-specific helpers, to help keep " [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/556098 (owner: 10Catrope) [12:22:29] (03CR) 10Esanders: "Also this is great!" [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/556098 (owner: 10Catrope) [12:24:08] 10GrowthExperiments-Homepage, 10NewcomerTasks Future Release , 10Growth-Team (Current Sprint): Newcomer tasks: show skeleton screen while loading - https://phabricator.wikimedia.org/T238231 (10kostajh) a:03kostajh [12:24:13] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] (wmf/1.35.0-wmf.11) - 10https://gerrit.wikimedia.org/r/558485 (owner: 10Jforrester) [12:27:57] (03PS3) 10ItSpiderman: Add RangeWidget [extensions/OOJSPlus] - 10https://gerrit.wikimedia.org/r/558385 [12:29:25] 10WatchTranslations, 10Google-Code-in-2019: Clicking on login should direct people to where they were prior clicking - https://phabricator.wikimedia.org/T240940 (10Urbanecm) [12:32:49] (03Merged) 10jenkins-bot: Include wmf/1.35.0-wmf.11 submodules and default settings [core] (wmf/1.35.0-wmf.11) - 10https://gerrit.wikimedia.org/r/558485 (owner: 10Jforrester) [12:32:55] 10Security-Team-Reviews: Security Concept Review For new CI - https://phabricator.wikimedia.org/T240943 (10LarsWirzenius) [12:34:08] 10Security-Team-Reviews: Security Concept Review For new CI - https://phabricator.wikimedia.org/T240943 (10LarsWirzenius) [12:34:54] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/NaturalLanguageList] - 10https://gerrit.wikimedia.org/r/558492 (owner: 10Libraryupgrader) [12:35:53] (03CR) 10Daniel Kinzler: Replaces $user->removeWatch with WatchedItemStore service removeWatch calls Replaces $user->addWatch with WatchedItemStore service addWatchB (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/506885 (https://phabricator.wikimedia.org/T208766) (owner: 10Vedmaka Wakalaka) [12:37:11] 10WMSE-Magnus Sälgö: Workflow/version management when Europeana reference wrong person in Wikidata - https://phabricator.wikimedia.org/T240809 (10Salgo60) [12:39:46] (03CR) 10Daniel Kinzler: Replaces $user->removeWatch with WatchedItemStore service removeWatch calls Replaces $user->addWatch with WatchedItemStore service addWatchB (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/506885 (https://phabricator.wikimedia.org/T208766) (owner: 10Vedmaka Wakalaka) [12:41:30] 10MobileFrontend, 10Readers-Web-Backlog, 10Browser-Support-Firefox, 10Mobile: Wasted editing space in mobile source editing on Firefox - https://phabricator.wikimedia.org/T240883 (10Esanders) [12:43:33] (03PS11) 10Matěj Suchánek: Notify user when they are blocked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/421720 (https://phabricator.wikimedia.org/T100974) [12:44:04] 10WMSE-Magnus Sälgö: Workflow/version management when Europeana reference wrong person in Wikidata - https://phabricator.wikimedia.org/T240809 (10Salgo60) [12:44:19] (03PS2) 10Thiemo Kreuz (WMDE): Fix inconsistent error reporting for invisible content [extensions/Cite] - 10https://gerrit.wikimedia.org/r/558486 [12:47:23] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2019-October-December), 10Patch-For-Review, 10Technical-Debt, and 2 others: Use formatversion=2 in ext.translate.messagetable - https://phabricator.wikimedia.org/T158741 (10abi_) Did some general testing. Here are the things that I tested, As an... [12:48:08] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/421720 (https://phabricator.wikimedia.org/T100974) (owner: 10Matěj Suchánek) [12:48:21] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/558486 (owner: 10Thiemo Kreuz (WMDE)) [12:52:11] 10MobileFrontend, 10Readers-Web-Backlog, 10Browser-Support-Firefox, 10Mobile: Wasted editing space in mobile source editing on Firefox - https://phabricator.wikimedia.org/T240883 (10Esanders) [12:52:14] 10MobileFrontend, 10VisualEditor, 10Readers-Web-Backlog (Tracking): [Bug] On Firefox mobile editor textarea should auto-expand - https://phabricator.wikimedia.org/T214880 (10Esanders) [12:52:34] (03CR) 10Daimona Eaytoy: "ErrorException from line 333 of /workspace/src/includes/debug/MWDebug.php: PHP Deprecated: Use of LinkBegin hook" [extensions/HelpCommons] - 10https://gerrit.wikimedia.org/r/558230 (owner: 10Libraryupgrader) [12:53:52] (03CR) 10Jforrester: [C: 03+1] Make TestAutoload{Classes,Namespaces} lazy-loaded attributes [core] - 10https://gerrit.wikimedia.org/r/558468 (https://phabricator.wikimedia.org/T196090) (owner: 10Mainframe98) [12:57:02] 10Library-Card-Platform, 10good first task: Add a 'Back to partners' navigational button from partner signup pages - https://phabricator.wikimedia.org/T150012 (10Soumyaa1804) Thanks, @AVasanth_WMF! Here is the PR https://github.com/WikipediaLibrary/TWLight/pull/382. Please see if everything is fine. [12:57:47] (03CR) 10jerkins-bot: [V: 04-1] Notify user when they are blocked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/421720 (https://phabricator.wikimedia.org/T100974) (owner: 10Matěj Suchánek) [13:06:19] (03CR) 10Matěj Suchánek: "recheck" [core] - 10https://gerrit.wikimedia.org/r/463678 (https://phabricator.wikimedia.org/T205801) (owner: 10Urbanecm) [13:14:10] 10WMSE-Magnus Sälgö: Workflow/version management when Europeana reference wrong person in Wikidata - https://phabricator.wikimedia.org/T240809 (10Salgo60) [13:14:50] (03PS3) 10Tchanders: Reorganise preliminary check service for paginated results [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/558147 [13:15:11] (03CR) 10Tchanders: Reorganise preliminary check service for paginated results (036 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/558147 (owner: 10Tchanders) [13:19:24] (03CR) 10Jforrester: [C: 03+2] NewPagesPager: Fix namespace query conditions [core] - 10https://gerrit.wikimedia.org/r/558328 (https://phabricator.wikimedia.org/T240924) (owner: 10DannyS712) [13:20:16] (03CR) 10DCausse: [C: 03+2] Use setSuggestionQuery as the result is not yet rewritten [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/554603 (owner: 10EBernhardson) [13:20:22] (03CR) 10DCausse: [C: 03+2] Fix IndexLookupFallbackMethod unit tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/554814 (owner: 10DCausse) [13:20:37] (03CR) 10DCausse: [C: 03+2] Remove unreferenced metrics [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/554604 (owner: 10EBernhardson) [13:21:08] 10MediaWiki-extensions-LDAPProvider: LDAPProvider in MediaWiki 1.33.1 fails with "Fatal error: Exception thrown without a stack frame in Unknown on line 0" - https://phabricator.wikimedia.org/T240568 (10Pavche) Following steps from manuals: • https://tecadmin.net/install-php-debian-9-stretch/ • https://www.roseh... [13:22:14] (03PS1) 10Robert Vogel: Make PDF-Export handle style-tags from the body [extensions/BlueSpiceUEModulePDF] (REL1_31) - 10https://gerrit.wikimedia.org/r/558507 [13:22:47] (03CR) 10Catrope: "> Patch Set 3:" [core] - 10https://gerrit.wikimedia.org/r/556485 (https://phabricator.wikimedia.org/T239371) (owner: 10Catrope) [13:22:56] (03CR) 10jerkins-bot: [V: 04-1] Make PDF-Export handle style-tags from the body [extensions/BlueSpiceUEModulePDF] (REL1_31) - 10https://gerrit.wikimedia.org/r/558507 (owner: 10Robert Vogel) [13:23:57] (03PS4) 10Catrope: resourceloader: Allow packageFiles callbacks to return a file [core] - 10https://gerrit.wikimedia.org/r/556485 (https://phabricator.wikimedia.org/T239371) [13:26:25] (03CR) 10jerkins-bot: [V: 04-1] Reorganise preliminary check service for paginated results [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/558147 (owner: 10Tchanders) [13:26:45] 10AbuseFilter, 10Regression, 10TestMe: user_age is not available anymore for upload actions - https://phabricator.wikimedia.org/T92238 (10Daimona) 05Open→03Resolved a:03Daimona Calling resolved, since it seems to be working now. There's nothing we can do for old entries. [13:27:26] 10AbuseFilter, 10Stewards-and-global-tools: Add user-agent variable for abuse filtering - https://phabricator.wikimedia.org/T50623 (10Daimona) [13:27:40] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2019-October-December), 10Patch-For-Review, 10Technical-Debt, and 2 others: Use formatversion=2 in ext.translate.messagetable - https://phabricator.wikimedia.org/T158741 (10abi_) @Jpita - We'd like you to double check this change to ensure that ev... [13:28:58] (03PS1) 10Esanders: Use scroll blocking hack in Firefox [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558508 (https://phabricator.wikimedia.org/T214880) [13:29:17] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/NewUserNotif] - 10https://gerrit.wikimedia.org/r/558505 (owner: 10Libraryupgrader) [13:32:07] (03PS12) 10Matěj Suchánek: Notify user when they are blocked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/421720 (https://phabricator.wikimedia.org/T100974) [13:32:40] (03CR) 10DCausse: Return HtmlArmor for Search ResultSet snippets (032 comments) [core] - 10https://gerrit.wikimedia.org/r/556261 (owner: 10EBernhardson) [13:32:47] 10AbuseFilter, 10Patch-For-Review: Syntax validation should flag unused variables - https://phabricator.wikimedia.org/T237610 (10Daimona) a:03Nullzero [13:33:21] (03CR) 10MSantos: [C: 03+2] Log entire Status in MachineVisionEntitySaveException [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/558291 (owner: 10Mholloway) [13:33:46] 10Machine vision, 10Structured Data Engineering, 10MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), 10SDC-Statements (Machine-vision-depicts), 10Structured-Data-Backlog (Current Work): Add onboarding dialog to Suggested Tags page - https://phabricator.wikimedia.org/T233233 (10Edtadros) @Ramsey-WMF I made a new... [13:34:20] hello [13:35:29] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558508 (https://phabricator.wikimedia.org/T214880) (owner: 10Esanders) [13:35:38] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/421720 (https://phabricator.wikimedia.org/T100974) (owner: 10Matěj Suchánek) [13:35:49] shreyasminocha:hello , can u answer a question ? [13:35:50] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/556485 (https://phabricator.wikimedia.org/T239371) (owner: 10Catrope) [13:36:00] 10AbuseFilter, 10Stewards-and-global-tools, 10Privacy: abuse filter should be able to evaluate is IP in range for registered users - https://phabricator.wikimedia.org/T155553 (10Daimona) [13:36:09] hello Ebe [13:36:36] Darth: yeah, what's up? [13:36:52] i am not able to understand the 6th point [13:37:04] which i told earlier [13:37:16] (03PS4) 10Thiemo Kreuz (WMDE): Fix initial preferences for newly created user accounts [extensions/Popups] - 10https://gerrit.wikimedia.org/r/558464 (https://phabricator.wikimedia.org/T240947) [13:37:22] oh, i thought you said 4th last time? [13:37:39] mb [13:37:46] oh that may be a mitake [13:38:00] nvm. anyway, what particularly is confusing? [13:38:53] 'it will display in your user sandbox starts with 4 times table.' [13:38:53] 10AbuseFilter: Create variables for site language and server name - https://phabricator.wikimedia.org/T240948 (10Daimona) [13:39:27] "the heading it will display … starts with `4 times table`." [13:39:59] you're meant to prefix the table with a heading [13:40:00] oh [13:40:12] (03CR) 10Matěj Suchánek: Show correct protection detail on InfoAction (033 comments) [core] - 10https://gerrit.wikimedia.org/r/554106 (https://phabricator.wikimedia.org/T45283) (owner: 10Ammarpad) [13:40:31] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/558464 (https://phabricator.wikimedia.org/T240947) (owner: 10Thiemo Kreuz (WMDE)) [13:41:11] uhh didnt got it still [13:43:26] So before entering the loop, you must add a line for the heading (n times table) and concatenate after that in the loop [13:44:22] and that 4 will be the value that is provided by the user ? [13:44:39] the value of numb [13:44:48] (03Merged) 10jenkins-bot: NewPagesPager: Fix namespace query conditions [core] - 10https://gerrit.wikimedia.org/r/558328 (https://phabricator.wikimedia.org/T240924) (owner: 10DannyS712) [13:44:51] (03Merged) 10jenkins-bot: Use setSuggestionQuery as the result is not yet rewritten [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/554603 (owner: 10EBernhardson) [13:44:53] (03Merged) 10jenkins-bot: Fix IndexLookupFallbackMethod unit tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/554814 (owner: 10DCausse) [13:45:47] (03Merged) 10jenkins-bot: Remove unreferenced metrics [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/554604 (owner: 10EBernhardson) [13:45:53] Yes [13:45:58] (03CR) 10jerkins-bot: [V: 04-1] Notify user when they are blocked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/421720 (https://phabricator.wikimedia.org/T100974) (owner: 10Matěj Suchánek) [13:46:05] that's right [13:46:16] ok thx [13:50:21] (03Abandoned) 10Matěj Suchánek: Don't block partially blocked users from tagging revisions [core] - 10https://gerrit.wikimedia.org/r/517104 (https://phabricator.wikimedia.org/T221444) (owner: 10Matěj Suchánek) [13:51:58] (03PS13) 10Matěj Suchánek: Notify user when they are blocked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/421720 (https://phabricator.wikimedia.org/T100974) [13:55:04] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/421720 (https://phabricator.wikimedia.org/T100974) (owner: 10Matěj Suchánek) [13:55:16] (03PS1) 10Robert Vogel: Make Watchlist API store user context sensitive [extensions/BlueSpiceFoundation] (REL1_31) - 10https://gerrit.wikimedia.org/r/558517 [13:55:29] 10wikimedia.biterg.io, 10Developer-Advocacy (Oct-Dec 2019), 10Upstream: List Git/Gerrit repositories with 'worst' performance on unreviewed (CR0) changesets / changesets waiting for merge (CR1) - https://phabricator.wikimedia.org/T151488 (10Aklapper) 05Open→03Resolved a:03Aklapper Now that {T224755} is... [13:55:33] 10wikimedia.biterg.io, 10Epic: Visualization/data regressions after moving from korma.wmflabs.org to wikimedia.biterg.io - https://phabricator.wikimedia.org/T137997 (10Aklapper) [13:55:40] 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), 10Readers-Web-Backlog (Kanbanana-2019-20-Q2), 10Regression: Regression: Label is visible on Logout button for logged in users on all wikis (non-AMC) and contribution icon on user page - https://phabricator.wikimedia.org/T240644 (10Edtadros) a:05Edtadros→03ovas... [13:56:04] (03CR) 10jerkins-bot: [V: 04-1] Make Watchlist API store user context sensitive [extensions/BlueSpiceFoundation] (REL1_31) - 10https://gerrit.wikimedia.org/r/558517 (owner: 10Robert Vogel) [13:56:23] 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), 10Readers-Web-Backlog (Kanbanana-2019-20-Q2), 10Regression: Regression: Label is visible on Logout button for logged in users on all wikis (non-AMC) and contribution icon on user page - https://phabricator.wikimedia.org/T240644 (10Edtadros) [13:57:45] (03PS2) 10Robert Vogel: Make Watchlist API store user context sensitive [extensions/BlueSpiceFoundation] (REL1_31) - 10https://gerrit.wikimedia.org/r/558517 [13:58:00] 10wikimedia.biterg.io: Enable Discourse backend in wikimedia.biterg.io once a Wikimedia Discourse instance gets into production - https://phabricator.wikimedia.org/T186513 (10Aklapper) [13:58:02] (03PS1) 10Andrew Bogott: Update use of render_to_string() [openstack/horizon/wmf-puppet-dashboard] (train) - 10https://gerrit.wikimedia.org/r/558518 [13:58:18] (03PS1) 10Jforrester: NewPagesPager: Fix namespace query conditions [core] (wmf/1.35.0-wmf.11) - 10https://gerrit.wikimedia.org/r/558519 (https://phabricator.wikimedia.org/T240924) [13:58:20] (03PS6) 10Thiemo Kreuz (WMDE): Remove single use classes from the use section [extensions/Cite] - 10https://gerrit.wikimedia.org/r/556206 [13:58:40] (03CR) 10Andrew Bogott: [V: 03+2 C: 03+2] Update use of render_to_string() [openstack/horizon/wmf-puppet-dashboard] (train) - 10https://gerrit.wikimedia.org/r/558518 (owner: 10Andrew Bogott) [13:59:42] (03PS1) 10Andrew Bogott: Update wmf-puppet-dashboard submodule [openstack/horizon/deploy] (train) - 10https://gerrit.wikimedia.org/r/558520 [14:00:00] (03CR) 10Andrew Bogott: [V: 03+2 C: 03+2] Update wmf-puppet-dashboard submodule [openstack/horizon/deploy] (train) - 10https://gerrit.wikimedia.org/r/558520 (owner: 10Andrew Bogott) [14:00:52] (03PS2) 10Robert Vogel: Make PDF-Export handle style-tags from the body [extensions/BlueSpiceUEModulePDF] (REL1_31) - 10https://gerrit.wikimedia.org/r/558507 [14:01:55] (03CR) 10Awight: Fix initial preferences for newly created user accounts (032 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/558464 (https://phabricator.wikimedia.org/T240947) (owner: 10Thiemo Kreuz (WMDE)) [14:02:33] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/556206 (owner: 10Thiemo Kreuz (WMDE)) [14:02:35] (03CR) 10Awight: [C: 03+2] "I'd suggest also expanding the tests, to cover more of the matrix of possible interactions between settings." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/558464 (https://phabricator.wikimedia.org/T240947) (owner: 10Thiemo Kreuz (WMDE)) [14:03:02] 10AbuseFilter, 10Stewards-and-global-tools: Create variable for project name - https://phabricator.wikimedia.org/T97933 (10Bugreporter) [14:04:37] 10MediaWiki-Special-pages, 10Wikimedia-Rdbms, 10Beta-Cluster-reproducible, 10MW-1.35-notes (1.35.0-wmf.14; 2020-01-07), and 3 others: Special:NewPages - Exception caught inside exception handler when filtering using associated namespace - https://phabricator.wikimedia.org/T240924 (10Anomie) [14:05:55] (03CR) 10Thiemo Kreuz (WMDE): "I just realized there is a patch Ic74b453 from 2015 doing the exact same. I would like to use this as another argument why this change sho" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/558486 (owner: 10Thiemo Kreuz (WMDE)) [14:07:11] (03CR) 10Thiemo Kreuz (WMDE): "If we end merging I4a156aa, we can finally (4 years later) get this done. Sorry. It looks like nobody was aware of the proposal here." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/214099 (owner: 10Jackmcbarn) [14:10:29] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] (wmf/1.35.0-wmf.11) - 10https://gerrit.wikimedia.org/r/558519 (https://phabricator.wikimedia.org/T240924) (owner: 10Jforrester) [14:11:23] (03Abandoned) 10Thiemo Kreuz (WMDE): [WIP] Import "Reference Tooltips" gadget as real code [extensions/Cite] - 10https://gerrit.wikimedia.org/r/145041 (owner: 10Jforrester) [14:11:58] 10WMSE-Magnus Sälgö: Workflow/version management when Europeana reference wrong person in Wikidata - https://phabricator.wikimedia.org/T240809 (10Salgo60) [14:12:39] 10AbuseFilter: Abusefilter throttle did not work at dewiki - https://phabricator.wikimedia.org/T240951 (10Luke081515) [14:12:51] 10AbuseFilter: Abusefilter throttle did not work at dewiki - https://phabricator.wikimedia.org/T240951 (10Luke081515) p:05Triage→03High [14:13:25] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/279087 (owner: 10Gerrit Patch Uploader) [14:14:07] (03Abandoned) 10Thiemo Kreuz (WMDE): Handle nested references [extensions/Cite] - 10https://gerrit.wikimedia.org/r/279894 (https://phabricator.wikimedia.org/T127787) (owner: 10Cenarium) [14:15:41] 10MediaWiki-extensions-LDAPProvider: LDAPProvider in MediaWiki 1.33.1 fails with "Fatal error: Exception thrown without a stack frame in Unknown on line 0" - https://phabricator.wikimedia.org/T240568 (10Pavche) When I try to log via LDAP credentials then I get : **Internal error** ` [6bf5d36542ce35464c10ce36]... [14:15:46] (03Merged) 10jenkins-bot: Log entire Status in MachineVisionEntitySaveException [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/558291 (owner: 10Mholloway) [14:15:48] (03Merged) 10jenkins-bot: Fix initial preferences for newly created user accounts [extensions/Popups] - 10https://gerrit.wikimedia.org/r/558464 (https://phabricator.wikimedia.org/T240947) (owner: 10Thiemo Kreuz (WMDE)) [14:16:01] 10Inuka-Team (Kanban): encode search key when opening preview - https://phabricator.wikimedia.org/T240952 (10hueitan) [14:16:47] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): encode search key when opening preview - https://phabricator.wikimedia.org/T240952 (10hueitan) [14:21:45] 10MobileFrontend, 10Patch-For-Review, 10Readers-Web-Backlog (Tracking), 10VisualEditor (Current work): [Bug] On Firefox mobile editor textarea should auto-expand - https://phabricator.wikimedia.org/T214880 (10Esanders) [14:23:04] (03Abandoned) 10Thiemo Kreuz (WMDE): Register an error if the user input for references generates a malformed DOM [extensions/Cite] - 10https://gerrit.wikimedia.org/r/42880 (owner: 10Relwell) [14:23:27] (03CR) 10Daimona Eaytoy: [C: 04-1] Actually apply patch-afl_change_deleted_patrolled. (033 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/558199 (https://phabricator.wikimedia.org/T240895) (owner: 10Alexia) [14:26:30] hello [14:26:35] i am having a problem [14:26:52] yes [14:27:37] (03Abandoned) 10Thiemo Kreuz (WMDE): Made Changes as per Bug T36999 {{{foo}}} is working on the local machine....also added some changes after review by Bawolff [extensions/Cite] - 10https://gerrit.wikimedia.org/r/104794 (https://phabricator.wikimedia.org/T36999) (owner: 10AalekhN) [14:27:46] i am trying to do the 8th point [14:28:12] and instead of printing whole table it just prints the last result [14:28:32] like '10 times 4 equals 40' [14:28:49] this is the result [14:29:01] (03CR) 10Mholloway: [C: 03+2] Inform the user when a depicts statement already exists [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/556804 (owner: 10Mholloway) [14:29:04] 10wikimedia.biterg.io, 10Upstream: Provide equivalent of "SCR: Oldest open Gerrit changesets without code review" in Kibana - https://phabricator.wikimedia.org/T151560 (10Aklapper) [14:29:06] 10wikimedia.biterg.io: Allow to filter by Gerrit label 'code review' in the frontend - https://phabricator.wikimedia.org/T224755 (10Aklapper) [14:29:28] Are you concatenating correctly? [14:29:36] check my code ? [14:29:55] https://en.wikipedia.org/wiki/Module:Sandbox/Sanrac/sometest [14:30:10] 10MobileFrontend, 10Patch-For-Review, 10Readers-Web-Backlog (Tracking), 10VisualEditor (Current work): [Bug] On Firefox mobile editor textarea should auto-expand - https://phabricator.wikimedia.org/T214880 (10Esanders) VE had a similar issue with ContentEditable: T196839 [14:30:14] (03Abandoned) 10Thiemo Kreuz (WMDE): Make displaying reference group names optional [extensions/Cite] - 10https://gerrit.wikimedia.org/r/216698 (https://phabricator.wikimedia.org/T94410) (owner: 10Gerrit Patch Uploader) [14:30:42] (03CR) 10jerkins-bot: [V: 04-1] Inform the user when a depicts statement already exists [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/556804 (owner: 10Mholloway) [14:32:39] Yes, the problem is that instead of concatenating new lines, you're replacing them [14:32:54] should be msg = msg .. (...) [14:33:11] but then it will say that msg is a nil value [14:33:44] How about not having msg, and using out [14:33:49] so out = out .. [14:34:29] You should concatenate the number to out first, so that you can just return out rather than a list [14:35:01] hmm let me try [14:35:11] (03CR) 10Daimona Eaytoy: [C: 03+2] CategoryManager: Fix type annotations [extensions/Linter] - 10https://gerrit.wikimedia.org/r/558318 (owner: 10Legoktm) [14:36:08] (03CR) 10Daimona Eaytoy: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/Linter] - 10https://gerrit.wikimedia.org/r/558308 (owner: 10Libraryupgrader) [14:37:42] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Growth-Team (Current Sprint), 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17): Newcomer tasks: do not refresh suggestions if user cancels difficulty filter - https://phabricator.wikimedia.org/T238172 (10kostajh) a:05kostajh→03None Unassigning myself for... [14:38:41] 10wikimedia.biterg.io, 10Upstream: Provide equivalent of "SCR: Oldest open Gerrit changesets without code review" in Kibana - https://phabricator.wikimedia.org/T151560 (10Aklapper) We've got closer now https://wikimedia.biterg.io that {T224755} has been implemented. However, this does not exclude `Verified-1`... [14:39:55] 10MediaWiki-extensions-LDAPProvider: LDAPProvider in MediaWiki 1.33.1 fails with "Fatal error: Exception thrown without a stack frame in Unknown on line 0" - https://phabricator.wikimedia.org/T240568 (10CCicalese_WMF) You need to install the php-ldap package and restart apache. [14:40:31] (03PS1) 10Ankita2503: Modified [extensions/examples] - 10https://gerrit.wikimedia.org/r/558536 [14:40:54] done it now [14:41:14] Great! [14:42:29] now the first part is complete [14:42:42] time for second part [14:43:07] (03CR) 10Awight: [C: 03+2] Remove single use classes from the use section (031 comment) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/556206 (owner: 10Thiemo Kreuz (WMDE)) [14:43:26] (03PS2) 10Ankita2503: Amended Test Gerrit [extensions/examples] - 10https://gerrit.wikimedia.org/r/558536 [14:44:20] (03Abandoned) 10Ankita2503: Amended Test Gerrit [extensions/examples] - 10https://gerrit.wikimedia.org/r/558536 (owner: 10Ankita2503) [14:49:00] 10wikimedia.biterg.io: Results when querying for status_value in Gerrit can be surprising - https://phabricator.wikimedia.org/T240954 (10Aklapper) p:05Triage→03Low [14:49:03] (03PS4) 10Tchanders: Reorganise preliminary check service for paginated results [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/558147 [14:49:42] 10wikimedia.biterg.io: Results when querying for status_value in Gerrit can be surprising - https://phabricator.wikimedia.org/T240954 (10Aklapper) [14:51:17] 10wikimedia.biterg.io: Results when querying for status_value in Gerrit can be surprising - https://phabricator.wikimedia.org/T240954 (10Aklapper) Note that this might influence the item https://www.mediawiki.org/wiki/Community_metrics#Number_of_unreviewed_open_Gerrit_patchsets,_per_repository [14:52:18] (03PS8) 10Mholloway: Inform the user when a depicts statement already exists [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/556804 [14:53:24] Ebe123: pls explain what is '#friends' ? [14:53:40] it's the number of friends [14:53:47] (03CR) 10Mholloway: [C: 03+2] "Manually rebased, resubmitting." [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/556804 (owner: 10Mholloway) [14:53:51] Counts it automatically [14:54:07] (03PS1) 10Thiemo Kreuz (WMDE): Add parser tests for the responsive="…" feature [extensions/Cite] - 10https://gerrit.wikimedia.org/r/558541 [14:54:31] ok thx [14:54:53] (03Merged) 10jenkins-bot: Remove single use classes from the use section [extensions/Cite] - 10https://gerrit.wikimedia.org/r/556206 (owner: 10Thiemo Kreuz (WMDE)) [14:54:57] (03CR) 10Aklapper: "Hi Ankita and welcome! Please DO NOT test here. If you only want to play with Gerrit, please use http://gerrit-test.wmflabs.org/ instead o" [extensions/examples] - 10https://gerrit.wikimedia.org/r/558536 (owner: 10Ankita2503) [14:55:52] (03PS5) 10Mholloway: Add navigation link to sidebar [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/557127 (https://phabricator.wikimedia.org/T240646) [14:57:05] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/558541 (owner: 10Thiemo Kreuz (WMDE)) [14:57:13] (03CR) 10Thiemo Kreuz (WMDE): "I also tried to run these tests with an old version of the codebase, before we started the big rewrite. They all succeed, which proves we " [extensions/Cite] - 10https://gerrit.wikimedia.org/r/558541 (owner: 10Thiemo Kreuz (WMDE)) [14:57:30] (03CR) 10Anne Tomasevich: [C: 03+2] Add navigation link to sidebar [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/557127 (https://phabricator.wikimedia.org/T240646) (owner: 10Mholloway) [14:57:49] i have submitted it [14:57:55] :) [14:58:16] I see [14:58:34] I get emails with each comment and submission ;) [14:59:08] (03Abandoned) 10Thiemo Kreuz (WMDE): When wikitext is ending with a list, references are merged into that list. [extensions/Cite] - 10https://gerrit.wikimedia.org/r/308571 (owner: 10VitaliyFilippov) [15:00:38] afk for a while [15:00:59] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "I do support this addition, but … (see inline comment)." (031 comment) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/439450 (https://phabricator.wikimedia.org/T196828) (owner: 10Huji) [15:01:51] (03CR) 10jerkins-bot: [V: 04-1] Reorganise preliminary check service for paginated results [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/558147 (owner: 10Tchanders) [15:02:12] (03PS10) 10Awight: [WIP] Refactor follow edge case [extensions/Cite] - 10https://gerrit.wikimedia.org/r/553096 (https://phabricator.wikimedia.org/T240858) [15:02:14] 10AbuseFilter: Abusefilter throttle did not work at dewiki - https://phabricator.wikimedia.org/T240951 (10Bawolff) Just writing this down for reference as it was annoying to figure out, I think the memcached key in question is `dewiki:abusefilter:throttle:290:user,page:ce12284db0992734fd982f4a3ddd1f5f2b5c5408`... [15:02:16] (03PS2) 10ItSpiderman: [WIP] Extend table functions [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/556690 [15:02:42] (03Abandoned) 10Thiemo Kreuz (WMDE): [WIP][POC] Add refine parameter to references [extensions/Cite] - 10https://gerrit.wikimedia.org/r/530399 (https://phabricator.wikimedia.org/T228997) (owner: 10WMDE-Fisch) [15:04:52] 10MediaWiki-Special-pages: User defined CSS does not work on the page "Special:Preferences" - https://phabricator.wikimedia.org/T240956 (10Keyacom) [15:04:54] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/553096 (https://phabricator.wikimedia.org/T240858) (owner: 10Awight) [15:08:44] 10MediaWiki-ResourceLoader, 10MediaWiki-ServiceContainer, 10MediaWiki-extensions-Gadgets, 10Language-Team, and 5 others: Circular dependency when creating service! ContentLanguage - https://phabricator.wikimedia.org/T231866 (10Kghbln) I guess this is one of the very few bugs blocking the upcoming November... [15:09:57] (03PS1) 10Daimona Eaytoy: Rename generateStaticVars and related hook [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/558545 [15:14:48] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Refactor follow edge case [extensions/Cite] - 10https://gerrit.wikimedia.org/r/553096 (https://phabricator.wikimedia.org/T240858) (owner: 10Awight) [15:19:07] (03CR) 10Anomie: [C: 03+2] Fix a broken link in apisandbox-intro [core] - 10https://gerrit.wikimedia.org/r/551374 (https://phabricator.wikimedia.org/T236477) (owner: 10WhitePhosphorus) [15:20:15] Ebe123: can you review my task pls ? [15:21:17] (03PS1) 10Thiemo Kreuz (WMDE): Turn some tests into faster running "pure" unit tests [extensions/Popups] - 10https://gerrit.wikimedia.org/r/558548 [15:21:22] Little formatting thing: Please unindent function defs [15:21:23] (03PS2) 10Daimona Eaytoy: Rename generateStaticVars and related hook [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/558545 [15:21:37] So function p.timestable(frame) shouldn't be indented [15:22:38] But other than that, looks good [15:23:19] (03PS3) 10Daimona Eaytoy: Rename generateStaticVars and related hook [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/558545 [15:25:30] (03Merged) 10jenkins-bot: Inform the user when a depicts statement already exists [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/556804 (owner: 10Mholloway) [15:27:10] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/558548 (owner: 10Thiemo Kreuz (WMDE)) [15:28:03] (03PS5) 10Tchanders: Reorganise preliminary check service for paginated results [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/558147 [15:28:41] (03Merged) 10jenkins-bot: Add navigation link to sidebar [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/557127 (https://phabricator.wikimedia.org/T240646) (owner: 10Mholloway) [15:29:10] (03PS1) 10Thiemo Kreuz (WMDE): Add tests case for user preferences while in Beta mode [extensions/Popups] - 10https://gerrit.wikimedia.org/r/558553 (https://phabricator.wikimedia.org/T240947) [15:32:25] (03Merged) 10jenkins-bot: Fix a broken link in apisandbox-intro [core] - 10https://gerrit.wikimedia.org/r/551374 (https://phabricator.wikimedia.org/T236477) (owner: 10WhitePhosphorus) [15:32:35] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/558553 (https://phabricator.wikimedia.org/T240947) (owner: 10Thiemo Kreuz (WMDE)) [15:34:07] Darth, your --Task 4 comment and the line preceding and suceeding it shouldn't be indented [15:35:00] which means ? [15:35:33] got it [15:36:15] done now [15:36:25] Remove tabs on lines 21, 22, 23, and 33. Add a tab line 36 [15:36:53] Remove tab line 33, add tab line 36 [15:37:12] *37, not 36 [15:37:13] done [15:37:20] oh [15:37:29] Makes more sense? [15:37:51] yes [15:38:01] had checked indent on net [15:38:33] so is this how the code should be organised ? [15:39:47] (03CR) 10Tchanders: [C: 03+2] "Thanks!" [core] - 10https://gerrit.wikimedia.org/r/555717 (https://phabricator.wikimedia.org/T238310) (owner: 10Ammarpad) [15:44:27] yes [15:46:06] (03CR) 10Nikerabbit: [C: 04-1] Update setlang to display confirmation dialog to change language (031 comment) [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/551940 (https://phabricator.wikimedia.org/T63115) (owner: 10Abijeet Patro) [15:48:30] (03CR) 10Jforrester: [C: 03+2] NewPagesPager: Fix namespace query conditions [core] (wmf/1.35.0-wmf.11) - 10https://gerrit.wikimedia.org/r/558519 (https://phabricator.wikimedia.org/T240924) (owner: 10Jforrester) [15:48:44] (03PS1) 10Jforrester: NewPagesPager: Fix namespace query conditions [core] (wmf/1.35.0-wmf.10) - 10https://gerrit.wikimedia.org/r/558559 (https://phabricator.wikimedia.org/T240924) [15:49:22] Ebe123: wow i checked i am on the leaderboard! [15:49:30] Congratulations! [15:50:44] (03PS1) 10Jforrester: NewPagesPager: Fix namespace query conditions [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/558562 (https://phabricator.wikimedia.org/T240924) [15:51:00] (03CR) 10Jforrester: [C: 03+2] "Let's not have the release broken as-is." [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/558562 (https://phabricator.wikimedia.org/T240924) (owner: 10Jforrester) [15:51:08] (03CR) 10Jforrester: [C: 03+2] "a" [core] (wmf/1.35.0-wmf.10) - 10https://gerrit.wikimedia.org/r/558559 (https://phabricator.wikimedia.org/T240924) (owner: 10Jforrester) [15:51:49] (03Merged) 10jenkins-bot: Allow blocked admin to restore their (deleted) talkpage if not blocked from it [core] - 10https://gerrit.wikimedia.org/r/555717 (https://phabricator.wikimedia.org/T238310) (owner: 10Ammarpad) [15:59:02] (03PS1) 10Daimona Eaytoy: Add site name and language variables [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/558567 (https://phabricator.wikimedia.org/T240498) [15:59:44] (03Merged) 10jenkins-bot: NewPagesPager: Fix namespace query conditions [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/558562 (https://phabricator.wikimedia.org/T240924) (owner: 10Jforrester) [16:00:13] (03PS2) 10Daimona Eaytoy: Add site name and language variables [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/558567 (https://phabricator.wikimedia.org/T240498) [16:00:49] (03Merged) 10jenkins-bot: NewPagesPager: Fix namespace query conditions [core] (wmf/1.35.0-wmf.11) - 10https://gerrit.wikimedia.org/r/558519 (https://phabricator.wikimedia.org/T240924) (owner: 10Jforrester) [16:00:49] (03PS3) 10Daimona Eaytoy: Add site name and language variables [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/558567 (https://phabricator.wikimedia.org/T240498) [16:01:32] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/minus-x to 0.3.2 [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/558566 (owner: 10Libraryupgrader) [16:01:59] (03PS1) 10Mholloway: Log entire Status in MachineVisionEntitySaveException [extensions/MachineVision] (wmf/1.35.0-wmf.11) - 10https://gerrit.wikimedia.org/r/558568 [16:02:15] (03PS1) 10Mholloway: Log entire Status in MachineVisionEntitySaveException [extensions/MachineVision] (wmf/1.35.0-wmf.10) - 10https://gerrit.wikimedia.org/r/558569 [16:03:12] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/558562 (https://phabricator.wikimedia.org/T240924) (owner: 10Jforrester) [16:03:51] (03PS10) 10Reedy: Fixes shell edge-cases in Windows [core] - 10https://gerrit.wikimedia.org/r/471885 (https://phabricator.wikimedia.org/T183759) (owner: 10Juan Osorio (Microsoft)) [16:04:48] (03Merged) 10jenkins-bot: NewPagesPager: Fix namespace query conditions [core] (wmf/1.35.0-wmf.10) - 10https://gerrit.wikimedia.org/r/558559 (https://phabricator.wikimedia.org/T240924) (owner: 10Jforrester) [16:09:07] (03PS1) 10Kghbln: Switch configuration parameter setting to a working URL [extensions/Math] - 10https://gerrit.wikimedia.org/r/558573 (https://phabricator.wikimedia.org/T209563) [16:12:10] (03CR) 10Jforrester: [C: 03+2] Add string casts when using array_keys() with SQL query conditions [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/558217 (owner: 10Anomie) [16:12:26] (03CR) 10Jforrester: [C: 03+2] Add string casts when using array_keys() with SQL query conditions [core] - 10https://gerrit.wikimedia.org/r/558216 (owner: 10Anomie) [16:13:19] (03CR) 10Kghbln: "Also needs to be back-ported to REL1_34, 33 and 32 and 31. Not sure how to do this for 31." [extensions/Math] - 10https://gerrit.wikimedia.org/r/558573 (https://phabricator.wikimedia.org/T209563) (owner: 10Kghbln) [16:13:31] (03PS11) 10Reedy: Fixes shell edge-cases in Windows [core] - 10https://gerrit.wikimedia.org/r/471885 (https://phabricator.wikimedia.org/T183759) (owner: 10Juan Osorio (Microsoft)) [16:16:15] (03Merged) 10jenkins-bot: Add string casts when using array_keys() with SQL query conditions [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/558217 (owner: 10Anomie) [16:18:26] (03CR) 10jerkins-bot: [V: 04-1] Switch configuration parameter setting to a working URL [extensions/Math] - 10https://gerrit.wikimedia.org/r/558573 (https://phabricator.wikimedia.org/T209563) (owner: 10Kghbln) [16:24:14] (03PS1) 10Daniel Kinzler: [DNM] Remove compat code for pre-MCR schema. [core] - 10https://gerrit.wikimedia.org/r/558581 (https://phabricator.wikimedia.org/T198557) [16:25:21] (03Merged) 10jenkins-bot: Add string casts when using array_keys() with SQL query conditions [core] - 10https://gerrit.wikimedia.org/r/558216 (owner: 10Anomie) [16:25:45] (03PS1) 10Ostrzyciel: Editcount: support the actor table [extensions/Editcount] - 10https://gerrit.wikimedia.org/r/558582 (https://phabricator.wikimedia.org/T240893) [16:25:48] (03CR) 10jerkins-bot: [V: 04-1] Fixes shell edge-cases in Windows [core] - 10https://gerrit.wikimedia.org/r/471885 (https://phabricator.wikimedia.org/T183759) (owner: 10Juan Osorio (Microsoft)) [16:27:50] (03CR) 10Daniel Kinzler: "I just pushed a patch to remove the migration stage variable, see https://gerrit.wikimedia.org/r/c/mediawiki/core/+/558581" [core] - 10https://gerrit.wikimedia.org/r/552339 (https://phabricator.wikimedia.org/T161671) (owner: 10Anomie) [16:28:10] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [core] - 10https://gerrit.wikimedia.org/r/471885 (https://phabricator.wikimedia.org/T183759) (owner: 10Juan Osorio (Microsoft)) [16:31:50] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/minus-x to 0.3.2 [extensions/ORES] - 10https://gerrit.wikimedia.org/r/558584 (owner: 10Libraryupgrader) [16:35:17] (03CR) 10jerkins-bot: [V: 04-1] [DNM] Remove compat code for pre-MCR schema. [core] - 10https://gerrit.wikimedia.org/r/558581 (https://phabricator.wikimedia.org/T198557) (owner: 10Daniel Kinzler) [16:35:57] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/558581 (https://phabricator.wikimedia.org/T198557) (owner: 10Daniel Kinzler) [16:36:37] (03CR) 10Tchanders: Add Compare service to fetch compare data (032 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/555619 (https://phabricator.wikimedia.org/T238714) (owner: 10Dmaza) [16:38:33] (03PS1) 10Krinkle: objectcache: Add corruption debugger to MemcachedPeclBagOStuff::doGetMulti [core] - 10https://gerrit.wikimedia.org/r/558589 (https://phabricator.wikimedia.org/T239724) [16:40:57] (03CR) 10Krinkle: [C: 04-2] "Not for master" [core] - 10https://gerrit.wikimedia.org/r/558589 (https://phabricator.wikimedia.org/T239724) (owner: 10Krinkle) [16:41:00] (03CR) 10Jforrester: "Do you want to back-port this? If not, it won't reach production until the second week of January…" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/558464 (https://phabricator.wikimedia.org/T240947) (owner: 10Thiemo Kreuz (WMDE)) [16:41:16] (03PS1) 10Krinkle: objectcache: Add corruption debugger to MemcachedPeclBagOStuff::doGetMulti [core] (wmf/1.35.0-wmf.11) - 10https://gerrit.wikimedia.org/r/558593 (https://phabricator.wikimedia.org/T239724) [16:41:40] (03PS1) 10Krinkle: objectcache: Add corruption debugger to MemcachedPeclBagOStuff::doGetMulti [core] (wmf/1.35.0-wmf.10) - 10https://gerrit.wikimedia.org/r/558594 (https://phabricator.wikimedia.org/T239724) [16:42:29] (03PS39) 10Ottomata: Add StreamConfigs MW Service and ApiStreamConfigs [extensions/EventStreamConfig] - 10https://gerrit.wikimedia.org/r/545654 (https://phabricator.wikimedia.org/T233634) [16:42:31] (03CR) 10Ottomata: Add StreamConfigs MW Service and ApiStreamConfigs (038 comments) [extensions/EventStreamConfig] - 10https://gerrit.wikimedia.org/r/545654 (https://phabricator.wikimedia.org/T233634) (owner: 10Ottomata) [16:42:43] (03PS2) 10Krinkle: objectcache: Add corruption debugger to MemcachedPeclBagOStuff::doGetMulti [core] (wmf/1.35.0-wmf.10) - 10https://gerrit.wikimedia.org/r/558594 (https://phabricator.wikimedia.org/T239724) [16:45:18] (03CR) 10Nuria: Add site name and language variables (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/558567 (https://phabricator.wikimedia.org/T240498) (owner: 10Daimona Eaytoy) [16:46:19] (03PS1) 10Thiemo Kreuz (WMDE): Fix initial preferences for newly created user accounts [extensions/Popups] (wmf/1.35.0-wmf.11) - 10https://gerrit.wikimedia.org/r/558596 (https://phabricator.wikimedia.org/T240947) [16:49:58] (03PS4) 10Daimona Eaytoy: Add site name and language variables [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/558567 (https://phabricator.wikimedia.org/T240948) [16:50:04] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/Popups] (wmf/1.35.0-wmf.11) - 10https://gerrit.wikimedia.org/r/558596 (https://phabricator.wikimedia.org/T240947) (owner: 10Thiemo Kreuz (WMDE)) [16:53:09] (03PS2) 10Daimona Eaytoy: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/558359 (owner: 10Libraryupgrader) [16:53:25] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/558589 (https://phabricator.wikimedia.org/T239724) (owner: 10Krinkle) [17:06:17] (03PS1) 10Abijeet Patro: Use existing variables/functions [extensions/TranslationNotifications] - 10https://gerrit.wikimedia.org/r/558602 [17:07:14] (03CR) 10Abijeet Patro: "> Patch Set 21:" (032 comments) [extensions/TranslationNotifications] - 10https://gerrit.wikimedia.org/r/537575 (https://phabricator.wikimedia.org/T144780) (owner: 10Abijeet Patro) [17:21:06] (03PS19) 10Abijeet Patro: Update setlang to display confirmation dialog to change language [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/551940 (https://phabricator.wikimedia.org/T63115) [17:21:11] (03PS1) 10EBernhardson: Update ISearchResultSet snippet/HtmlArmor documentation [core] - 10https://gerrit.wikimedia.org/r/558607 [17:22:21] (03PS1) 10Ottomata: Stop mocha tests from hanging [services/eventstreams] - 10https://gerrit.wikimedia.org/r/558608 [17:22:27] (03CR) 10Abijeet Patro: Update setlang to display confirmation dialog to change language (031 comment) [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/551940 (https://phabricator.wikimedia.org/T63115) (owner: 10Abijeet Patro) [17:22:57] (03PS4) 10HMonroy: Add user preference info to basic info section [core] - 10https://gerrit.wikimedia.org/r/554654 (https://phabricator.wikimedia.org/T234952) [17:23:05] (03CR) 10jerkins-bot: [V: 04-1] Stop mocha tests from hanging [services/eventstreams] - 10https://gerrit.wikimedia.org/r/558608 (owner: 10Ottomata) [17:25:29] (03CR) 10HMonroy: Add user preference info to basic info section (031 comment) [core] - 10https://gerrit.wikimedia.org/r/554654 (https://phabricator.wikimedia.org/T234952) (owner: 10HMonroy) [17:26:08] (03CR) 10EBernhardson: Return HtmlArmor for Search ResultSet snippets (032 comments) [core] - 10https://gerrit.wikimedia.org/r/556261 (owner: 10EBernhardson) [17:28:21] (03PS1) 10Ottomata: Update to KafkaSSE 0.4.0 [services/eventstreams] - 10https://gerrit.wikimedia.org/r/558610 [17:29:05] (03CR) 10jerkins-bot: [V: 04-1] Update to KafkaSSE 0.4.0 [services/eventstreams] - 10https://gerrit.wikimedia.org/r/558610 (owner: 10Ottomata) [17:33:11] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/558607 (owner: 10EBernhardson) [17:34:52] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/554654 (https://phabricator.wikimedia.org/T234952) (owner: 10HMonroy) [17:38:42] (03CR) 10Fomafix: Update setlang to display confirmation dialog to change language (032 comments) [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/551940 (https://phabricator.wikimedia.org/T63115) (owner: 10Abijeet Patro) [17:41:15] (03CR) 10Anomie: [C: 03+1] Update ISearchResultSet snippet/HtmlArmor documentation (031 comment) [core] - 10https://gerrit.wikimedia.org/r/558607 (owner: 10EBernhardson) [17:47:18] (03PS1) 10Krinkle: selenium: Replace wdio-chromedriver with ./selenium.sh script [core] - 10https://gerrit.wikimedia.org/r/558617 [17:48:06] (03PS11) 10Jdlrobson: Add support for non-ascii/reserved characters in simplified talk page section ids [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/548945 (https://phabricator.wikimedia.org/T238364) (owner: 10Nray) [17:49:07] (03PS12) 10Jdlrobson: Add support for non-ascii/reserved characters in simplified talk page section ids [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/548945 (https://phabricator.wikimedia.org/T238364) (owner: 10Nray) [17:52:46] (03CR) 10Anomie: [C: 04-1] Creates RestrictionStore service (031 comment) [core] - 10https://gerrit.wikimedia.org/r/549909 (https://phabricator.wikimedia.org/T218395) (owner: 10Vedmaka Wakalaka) [17:53:27] Urbanecm, people complaining about not getting enough emails? [17:54:04] Ebe123: i was surprised that nothing is coming, so checked with google and they said email is buggy, so i sent an announcement to prevent others from wondering [17:55:17] Ah. I had a filter for GCI to send to a folder, so guess that's why I still get them ;) [17:55:31] * Urbanecm too, but they still went to spam [17:55:38] (03CR) 10jerkins-bot: [V: 04-1] Add support for non-ascii/reserved characters in simplified talk page section ids [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/548945 (https://phabricator.wikimedia.org/T238364) (owner: 10Nray) [17:57:23] (03PS4) 10Clarakosi: Add API-testing to core [core] - 10https://gerrit.wikimedia.org/r/556405 [17:59:30] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/558617 (owner: 10Krinkle) [18:05:07] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/minus-x to 0.3.2 [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/558624 (owner: 10Libraryupgrader) [18:09:15] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/556405 (owner: 10Clarakosi) [18:12:16] (03CR) 10Nikki Nikkhoui: Conditional request support for REST compare endpoint (031 comment) [core] - 10https://gerrit.wikimedia.org/r/542212 (https://phabricator.wikimedia.org/T231580) (owner: 10Ppchelko) [18:12:43] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Use existing variables/functions [extensions/TranslationNotifications] - 10https://gerrit.wikimedia.org/r/558602 (owner: 10Abijeet Patro) [18:14:26] (03CR) 10Ottomata: "recheck" [services/eventstreams] - 10https://gerrit.wikimedia.org/r/558610 (owner: 10Ottomata) [18:16:10] (03PS20) 10Abijeet Patro: Update setlang to display confirmation dialog to change language [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/551940 (https://phabricator.wikimedia.org/T63115) [18:17:54] (03CR) 10Abijeet Patro: Update setlang to display confirmation dialog to change language (032 comments) [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/551940 (https://phabricator.wikimedia.org/T63115) (owner: 10Abijeet Patro) [18:19:23] (03CR) 10Anomie: "From a technical perspective this seems ok, but it may not actually be needed." (031 comment) [extensions/Linter] - 10https://gerrit.wikimedia.org/r/558317 (owner: 10Legoktm) [18:20:24] (03PS1) 10Anomie: API: Update docs on addWhere() and related methods [core] - 10https://gerrit.wikimedia.org/r/558628 [18:22:04] (03PS2) 10EBernhardson: Update ISearchResultSet snippet/HtmlArmor documentation [core] - 10https://gerrit.wikimedia.org/r/558607 [18:22:19] (03CR) 10EBernhardson: Update ISearchResultSet snippet/HtmlArmor documentation (031 comment) [core] - 10https://gerrit.wikimedia.org/r/558607 (owner: 10EBernhardson) [18:22:55] (03PS1) 10Clarakosi: Update Supertest and bump version [tools/api-testing] - 10https://gerrit.wikimedia.org/r/558629 [18:24:01] (03CR) 10Mholloway: [C: 03+2] Log entire Status in MachineVisionEntitySaveException [extensions/MachineVision] (wmf/1.35.0-wmf.11) - 10https://gerrit.wikimedia.org/r/558568 (owner: 10Mholloway) [18:24:35] (03CR) 10Mholloway: [C: 03+2] Log entire Status in MachineVisionEntitySaveException [extensions/MachineVision] (wmf/1.35.0-wmf.10) - 10https://gerrit.wikimedia.org/r/558569 (owner: 10Mholloway) [18:26:26] (03CR) 10Fomafix: Update setlang to display confirmation dialog to change language (031 comment) [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/551940 (https://phabricator.wikimedia.org/T63115) (owner: 10Abijeet Patro) [18:31:15] (03Merged) 10jenkins-bot: Use existing variables/functions [extensions/TranslationNotifications] - 10https://gerrit.wikimedia.org/r/558602 (owner: 10Abijeet Patro) [18:33:03] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/PageCreationNotif] - 10https://gerrit.wikimedia.org/r/558632 (owner: 10Libraryupgrader) [18:33:53] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/558628 (owner: 10Anomie) [18:34:53] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/558607 (owner: 10EBernhardson) [18:38:20] (03PS2) 10Ottomata: Update to KafkaSSE 0.4.0 [services/eventstreams] - 10https://gerrit.wikimedia.org/r/558610 [18:38:33] (03CR) 10Jdlrobson: [C: 04-2] "sorry i messed up the rebase here.." [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/548945 (https://phabricator.wikimedia.org/T238364) (owner: 10Nray) [18:40:31] (03CR) 10Jdlrobson: [C: 04-1] "The test testShouldSendModuleToUser needs to be updated" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/556451 (owner: 10Pmiazga) [18:42:27] (03PS1) 10Reedy: media: Log and fail gracefully on invalid EXIF coordinates [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/558638 (https://phabricator.wikimedia.org/T226751) [18:42:39] (03PS1) 10Reedy: media: Log and fail gracefully on invalid EXIF coordinates [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/558639 (https://phabricator.wikimedia.org/T226751) [18:42:54] (03PS1) 10Reedy: media: Log and fail gracefully on invalid EXIF coordinates [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/558640 (https://phabricator.wikimedia.org/T226751) [18:43:07] (03PS1) 10Reedy: media: Log and fail gracefully on invalid EXIF coordinates [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/558641 (https://phabricator.wikimedia.org/T226751) [18:46:50] (03CR) 10jerkins-bot: [V: 04-1] media: Log and fail gracefully on invalid EXIF coordinates [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/558641 (https://phabricator.wikimedia.org/T226751) (owner: 10Reedy) [18:48:16] (03CR) 10jerkins-bot: [V: 04-1] media: Log and fail gracefully on invalid EXIF coordinates [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/558640 (https://phabricator.wikimedia.org/T226751) (owner: 10Reedy) [18:48:54] (03CR) 10jerkins-bot: [V: 04-1] media: Log and fail gracefully on invalid EXIF coordinates [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/558639 (https://phabricator.wikimedia.org/T226751) (owner: 10Reedy) [18:49:05] I guess none of that is a surprise [18:49:44] (03PS2) 10Reedy: media: Log and fail gracefully on invalid EXIF coordinates [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/558641 (https://phabricator.wikimedia.org/T226751) [18:49:46] (03PS2) 10Reedy: media: Log and fail gracefully on invalid EXIF coordinates [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/558640 (https://phabricator.wikimedia.org/T226751) [18:49:52] (03PS2) 10Reedy: media: Log and fail gracefully on invalid EXIF coordinates [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/558639 (https://phabricator.wikimedia.org/T226751) [18:53:40] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/558638 (https://phabricator.wikimedia.org/T226751) (owner: 10Reedy) [18:53:51] (03Merged) 10jenkins-bot: Log entire Status in MachineVisionEntitySaveException [extensions/MachineVision] (wmf/1.35.0-wmf.11) - 10https://gerrit.wikimedia.org/r/558568 (owner: 10Mholloway) [18:54:26] (03Merged) 10jenkins-bot: Log entire Status in MachineVisionEntitySaveException [extensions/MachineVision] (wmf/1.35.0-wmf.10) - 10https://gerrit.wikimedia.org/r/558569 (owner: 10Mholloway) [18:54:55] (03PS2) 10Reedy: Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/557319 (owner: 10SLF bot) [18:55:01] (03CR) 10Reedy: [C: 03+2] Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/557319 (owner: 10SLF bot) [18:56:20] (03Abandoned) 10Nray: Add support for non-ascii/reserved characters in simplified talk page section ids [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/548945 (https://phabricator.wikimedia.org/T238364) (owner: 10Nray) [18:57:36] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/558641 (https://phabricator.wikimedia.org/T226751) (owner: 10Reedy) [18:57:51] (03Merged) 10jenkins-bot: Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/557319 (owner: 10SLF bot) [18:59:08] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/558640 (https://phabricator.wikimedia.org/T226751) (owner: 10Reedy) [19:00:19] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/558639 (https://phabricator.wikimedia.org/T226751) (owner: 10Reedy) [19:00:55] (03CR) 10Reedy: [C: 03+2] media: Log and fail gracefully on invalid EXIF coordinates [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/558638 (https://phabricator.wikimedia.org/T226751) (owner: 10Reedy) [19:00:57] (03CR) 10Reedy: [C: 03+2] media: Log and fail gracefully on invalid EXIF coordinates [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/558639 (https://phabricator.wikimedia.org/T226751) (owner: 10Reedy) [19:01:01] (03CR) 10Reedy: [C: 03+2] media: Log and fail gracefully on invalid EXIF coordinates [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/558640 (https://phabricator.wikimedia.org/T226751) (owner: 10Reedy) [19:01:05] (03CR) 10Reedy: [C: 03+2] media: Log and fail gracefully on invalid EXIF coordinates [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/558641 (https://phabricator.wikimedia.org/T226751) (owner: 10Reedy) [19:01:42] (03PS23) 10Jdlrobson: Headless QUnit tests (oh my!) [core] - 10https://gerrit.wikimedia.org/r/487168 (https://phabricator.wikimedia.org/T212521) [19:02:42] (03CR) 10Ottomata: [C: 03+2] Update to KafkaSSE 0.4.0 [services/eventstreams] - 10https://gerrit.wikimedia.org/r/558610 (owner: 10Ottomata) [19:02:55] (03PS2) 10Ottomata: Stop mocha tests from hanging [services/eventstreams] - 10https://gerrit.wikimedia.org/r/558608 [19:05:00] Good evening everyone! [19:05:37] (03Merged) 10jenkins-bot: media: Log and fail gracefully on invalid EXIF coordinates [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/558641 (https://phabricator.wikimedia.org/T226751) (owner: 10Reedy) [19:05:53] Oh hi! [19:06:08] (03CR) 10jerkins-bot: [V: 04-1] Stop mocha tests from hanging [services/eventstreams] - 10https://gerrit.wikimedia.org/r/558608 (owner: 10Ottomata) [19:07:14] (03Merged) 10jenkins-bot: media: Log and fail gracefully on invalid EXIF coordinates [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/558640 (https://phabricator.wikimedia.org/T226751) (owner: 10Reedy) [19:07:53] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/minus-x to 0.3.2 [extensions/PagePopups] - 10https://gerrit.wikimedia.org/r/558647 (owner: 10Libraryupgrader) [19:08:05] (03Merged) 10jenkins-bot: media: Log and fail gracefully on invalid EXIF coordinates [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/558639 (https://phabricator.wikimedia.org/T226751) (owner: 10Reedy) [19:08:22] (03Merged) 10jenkins-bot: media: Log and fail gracefully on invalid EXIF coordinates [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/558638 (https://phabricator.wikimedia.org/T226751) (owner: 10Reedy) [19:10:53] (03PS1) 10Ammarpad: InfoAction: Fix code smell [core] - 10https://gerrit.wikimedia.org/r/558649 [19:11:45] (03PS3) 10Jdlrobson: CtaDrawers no longer stay behind in DOM [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/558252 (https://phabricator.wikimedia.org/T214045) [19:13:58] (03CR) 10Ammarpad: Show correct protection detail on InfoAction (032 comments) [core] - 10https://gerrit.wikimedia.org/r/554106 (https://phabricator.wikimedia.org/T45283) (owner: 10Ammarpad) [19:15:39] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/487168 (https://phabricator.wikimedia.org/T212521) (owner: 10Jdlrobson) [19:16:18] (03CR) 10Daniel Kinzler: [C: 03+2] Update Supertest and bump version [tools/api-testing] - 10https://gerrit.wikimedia.org/r/558629 (owner: 10Clarakosi) [19:16:35] (03PS1) 10Ottomata: Add wikimedia/common and mediawiki/client/error schemas [schemas/event/primary] - 10https://gerrit.wikimedia.org/r/558651 (https://phabricator.wikimedia.org/T240985) [19:17:30] (03CR) 10Ottomata: "First attempt at creating and using the new primary schema repo." [schemas/event/primary] - 10https://gerrit.wikimedia.org/r/558651 (https://phabricator.wikimedia.org/T240985) (owner: 10Ottomata) [19:18:10] (03Merged) 10jenkins-bot: Update Supertest and bump version [tools/api-testing] - 10https://gerrit.wikimedia.org/r/558629 (owner: 10Clarakosi) [19:22:29] (03CR) 10jerkins-bot: [V: 04-1] InfoAction: Fix code smell [core] - 10https://gerrit.wikimedia.org/r/558649 (owner: 10Ammarpad) [19:22:36] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/558649 (owner: 10Ammarpad) [19:25:20] (03CR) 10jerkins-bot: [V: 04-1] CtaDrawers no longer stay behind in DOM [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/558252 (https://phabricator.wikimedia.org/T214045) (owner: 10Jdlrobson) [19:29:17] (03PS5) 10Clarakosi: Add API-testing to core [core] - 10https://gerrit.wikimedia.org/r/556405 [19:29:49] (03CR) 10Pmiazga: CtaDrawers no longer stay behind in DOM (032 comments) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/558252 (https://phabricator.wikimedia.org/T214045) (owner: 10Jdlrobson) [19:30:51] (03PS3) 10Ottomata: Stop mocha tests from hanging [services/eventstreams] - 10https://gerrit.wikimedia.org/r/558608 [19:31:26] (03PS1) 10Antleite2001: first commit [extensions/examples] - 10https://gerrit.wikimedia.org/r/558655 [19:31:29] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/examples] - 10https://gerrit.wikimedia.org/r/558655 (owner: 10Antleite2001) [19:31:51] (03CR) 10jerkins-bot: [V: 04-1] Stop mocha tests from hanging [services/eventstreams] - 10https://gerrit.wikimedia.org/r/558608 (owner: 10Ottomata) [19:32:22] (03CR) 10Krinkle: "Last branch of dispersed comment thread at https://phabricator.wikimedia.org/T222222#5748857" [core] - 10https://gerrit.wikimedia.org/r/549220 (https://phabricator.wikimedia.org/T169910) (owner: 10Jdlrobson) [19:32:46] (03PS1) 10Jdlrobson: QA: Nested reference drawer test is flakey [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/558656 [19:32:48] (03PS1) 10Jdlrobson: QA: Move reference browser test to Node.js suite [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/558657 [19:33:33] Bonjour NicholasG04! [19:33:40] Je ne t'avais pas vu [19:34:11] (03CR) 10Krinkle: "CC-ing Legoktm for review as I'm not yet up to speed with how lazy attrs work or how to test it." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/558468 (https://phabricator.wikimedia.org/T196090) (owner: 10Mainframe98) [19:34:33] (03PS3) 10Krinkle: Make TestAutoload{Classes,Namespaces} lazy-loaded attributes [core] - 10https://gerrit.wikimedia.org/r/558468 (https://phabricator.wikimedia.org/T196090) (owner: 10Mainframe98) [19:34:35] Salut ! [19:35:44] Un croche n'est pas 'a crotchet' en anglais ?! [19:35:59] je suis désolé - le francais n'est pas ma langue maternelle Ebe123 [19:37:15] And I only know french and american note names ;) [19:37:22] But no [19:37:56] I realise that it's now a quaver ('8th note') - there'd therefore be 8.5 quavers! [19:37:56] What do we call half a quaver? [19:38:05] A semiquaver [19:38:15] Sounds official [19:38:20] Hahahaha [19:38:56] I only know quarter, eighth, etc. or croche, double croche, etc [19:38:59] I am again so sorry about the overlapping tasks - I saw that you'd released a new one so started trying it then realised - can't make the same mistake I did before which is why I didn't then answer the question until after my last one had been approved [19:39:26] C'est trop compliqué que les notes musiques sont différentes dans chaque langue... [19:39:28] I gave you extra work to make up for it [19:39:33] (03PS2) 10Ammarpad: InfoAction: Fix code smell [core] - 10https://gerrit.wikimedia.org/r/558649 [19:39:55] :) I am always happy to do more work. It's why I signed up to GCI! [19:40:04] What's a B♭ in German? [19:40:06] I love the variation in tasks offered [19:40:16] is that flat or sharp - it hasn't transmitted to my IRC client? [19:40:26] Flat; U+266D [19:40:28] Thanks [19:40:53] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/556405 (owner: 10Clarakosi) [19:40:54] Would it be 'H'? [19:41:29] Yep, weird regional names in music [19:41:41] I will do anything and everything I can to prove my worth to wikimedia and my passion for open source software. Of course I'll try my hardest to win ;p [19:42:04] So how is it that you are able to speak English and French fluently? I could only dream of such skill! [19:42:05] (03CR) 10Mainframe98: Make TestAutoload{Classes,Namespaces} lazy-loaded attributes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/558468 (https://phabricator.wikimedia.org/T196090) (owner: 10Mainframe98) [19:42:14] You're already in contention [19:42:27] so it's going well [19:42:38] Contention against whom, may I ask? [19:42:58] You're in top 20, so in contention to become a finalist [19:42:59] (03CR) 10Aklapper: [C: 04-2] "Hi Antelite. Please DO NOT test here. If you only want to play with Gerrit, please use http://gerrit-test.wmflabs.org/ instead of gerrit.w" [extensions/examples] - 10https://gerrit.wikimedia.org/r/558655 (owner: 10Antleite2001) [19:43:04] https://codein.withgoogle.com/organizations/wikimedia/ [19:43:19] Hahaha, I've seen the list [19:43:48] Rest assured that now the end of the school term is coming you will be receiving lots of completed tasks from me I hope! [19:44:14] r1 assured, I'll be creating new tasks [19:44:23] Haha, I'm excited to see them [19:44:36] (03PS4) 10Jdlrobson: CtaDrawers no longer stay behind in DOM [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/558252 (https://phabricator.wikimedia.org/T214045) [19:44:40] (03CR) 10Jdlrobson: CtaDrawers no longer stay behind in DOM (032 comments) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/558252 (https://phabricator.wikimedia.org/T214045) (owner: 10Jdlrobson) [19:44:47] When I have some free time I hope to finish and add in the markings to Hummel 1 then resubmit it :) [19:45:13] (03CR) 10jerkins-bot: [V: 04-1] QA: Move reference browser test to Node.js suite [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/558657 (owner: 10Jdlrobson) [19:45:15] Already approved, can't resubmit... [19:45:40] :C, I can upload it on real wikipedia though or maybe even count it for the II/III repeated tasks you uploaded! [19:45:43] (03CR) 10Krinkle: Make TestAutoload{Classes,Namespaces} lazy-loaded attributes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/558468 (https://phabricator.wikimedia.org/T196090) (owner: 10Mainframe98) [19:46:09] Sure [19:46:28] there's just too many tasks to do for GCI and not enough time [19:46:32] It's already teaching me so much though [19:46:50] I'd allow it for II if there is some good work done in ormentation and markings [19:46:57] (03CR) 10jerkins-bot: [V: 04-1] QA: Nested reference drawer test is flakey [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/558656 (owner: 10Jdlrobson) [19:47:16] I'm hoping to keep expanding on some of the skills with lua I've learnt and especially with LilyPond on wikimedia wikis and upload some proper scores when I've built the skills [19:47:22] I hope to impress you sir [19:47:22] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/558468 (https://phabricator.wikimedia.org/T196090) (owner: 10Mainframe98) [19:47:52] You already are, but no need to call me sir [19:47:52] (03CR) 10Krinkle: "Didn't see this before. I replied to another branch of this thread at https://phabricator.wikimedia.org/T222222#5748857" [core] - 10https://gerrit.wikimedia.org/r/539167 (https://phabricator.wikimedia.org/T217616) (owner: 10Jdlrobson) [19:48:01] :)) [19:48:19] (03CR) 10Jdlrobson: "This patch doesn't change the existing behaviour. The controversial patch has been pulled out into https://gerrit.wikimedia.org/r/#/c/medi" [core] - 10https://gerrit.wikimedia.org/r/549220 (https://phabricator.wikimedia.org/T169910) (owner: 10Jdlrobson) [19:48:50] (03CR) 10Krinkle: "(TLDR: Not unique to mw.org, affects all wikis.)" [core] - 10https://gerrit.wikimedia.org/r/539167 (https://phabricator.wikimedia.org/T217616) (owner: 10Jdlrobson) [19:50:25] How many people have actually completed a LilyPond task? [19:51:04] (03PS4) 10Mainframe98: Make TestAutoload{Classes,Namespaces} lazy-loaded attributes [core] - 10https://gerrit.wikimedia.org/r/558468 (https://phabricator.wikimedia.org/T196090) [19:51:09] (03PS2) 10Jdlrobson: QA: Move reference browser test to Node.js suite [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/558657 [19:51:22] (03PS2) 10Jdlrobson: QA: Nested reference drawer test is flakey [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/558656 [19:51:32] I didn't do it [19:52:11] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/558649 (owner: 10Ammarpad) [19:52:17] I did it, and am very glad I did [19:52:23] However I play the trumpet so for me it wasn't too difficult [19:52:30] How are you all doing in terms of tasks? [19:53:01] (03CR) 10Jdlrobson: "We can talk about this in more detail next year. Right now we can focus on https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/549220" [core] - 10https://gerrit.wikimedia.org/r/539167 (https://phabricator.wikimedia.org/T217616) (owner: 10Jdlrobson) [19:53:18] (03CR) 10Mainframe98: Make TestAutoload{Classes,Namespaces} lazy-loaded attributes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/558468 (https://phabricator.wikimedia.org/T196090) (owner: 10Mainframe98) [19:53:25] Firstly I'm trying to create a development environment for the app. It takes the longest time :( [19:54:05] I usually spend my downtime waiting for reviews setting up environments or researching different projects :P [19:54:19] I have a phobia of sheet music so I couldn't do LilyPond [19:55:22] A phobia of sheet music?! [19:55:25] That's a new one! [19:56:09] You're all are musicians, huh? [19:56:29] I don't understand anything in it. [19:58:10] I'm here to teach you LilyPond so that it isn't scary [19:58:52] Don't be intimidated by my tasks! [19:59:36] NicholasG04: No worries, there will also be enough tasks after GCI. We have thousands of them open in Phab. :P [20:00:03] And you'll not have to worry about working on many at the same time [20:00:25] IAmNetx, Crutishnyk come try some LY! [20:00:28] Ebe123: my music teacher from 4 years ago has permanently cursed me with music-phobia, no can do [20:00:47] Not a very good teacher then [20:00:52] What is LY? [20:00:57] LilyPond [20:01:02] Oh [20:01:11] Or LilYpond [20:01:31] LP has another meaning in music [20:01:54] I love my trumpet so much, yet alas that'll probably change as I have to get train-track braces soon :C [20:02:24] andre__ I'll be happy to keep going at some of the dev tasks post-GCI. I've been looking at Mr Urbanec's tracker ones with Flask that seem quite fun. Going to try some of them after completing the Lua ones! [20:02:34] (03CR) 10jerkins-bot: [V: 04-1] CtaDrawers no longer stay behind in DOM [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/558252 (https://phabricator.wikimedia.org/T214045) (owner: 10Jdlrobson) [20:02:36] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/558649 (owner: 10Ammarpad) [20:02:38] New robotics project; trumpet-playing robot [20:02:42] Haha [20:02:48] With simulated lungs too? [20:02:58] Hydraulic fingers and simulated lungs [20:02:59] Tracker *cries into hands* [20:03:08] You can bring it on the winner's trip to california with me Étienne ;) [20:03:12] (/s) [20:03:21] (03CR) 10Anomie: [DNM] Remove compat code for pre-MCR schema. (0334 comments) [core] - 10https://gerrit.wikimedia.org/r/558581 (https://phabricator.wikimedia.org/T198557) (owner: 10Daniel Kinzler) [20:03:22] Czech it, IAmNetx :) [20:03:23] IAmNetx you're worrying me lol [20:03:34] I can't believe the czech wikimedia community is clearly so big [20:03:42] I mean with the expenses they're charging..... lol [20:03:55] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/558468 (https://phabricator.wikimedia.org/T196090) (owner: 10Mainframe98) [20:03:56] Converted it to pound? [20:03:57] Unfortunately, I don't have enough time for trying new software and claiming new tasks. I need to get ready to end-term exams and to the final of the another contest [20:03:58] (03PS1) 10Mholloway: Extract more Status info for MachineVisionEntitySaveException [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/558663 [20:04:22] There are many weeks to go [20:04:35] I love getting globally renamed and the way I find out is coming home to several dozen emails https://i.imgur.com/wuhz0LH.png [20:04:39] That's unfortunate [20:04:46] Hahahha [20:05:06] hehe [20:05:17] Good evening, Martin [20:05:37] good evening NicholasG04 [20:05:41] (03CR) 10jerkins-bot: [V: 04-1] QA: Nested reference drawer test is flakey [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/558656 (owner: 10Jdlrobson) [20:05:51] ~55 emails, including the one buried at the bottom informing me that it was approved [20:06:02] I haven't tried any of your more creative looking Flask-JSONLocale/Tracker tasks yet.... super excited to! [20:06:06] Please tell me there is a task for not having that happen on Phabricator [20:06:23] Well I'm sure there's always a place for you to make one... [20:06:29] Lol [20:06:30] If there isn't create one ;) [20:07:07] Just got an email: "B#Minor has claimed Functional Programming 0: Setting up Score." [20:07:24] :O [20:07:35] I have competition from another musician [20:07:45] A lot of sharps; but could be simpler [20:08:13] NicholasG04: yay :) [20:08:14] Do let me know when the other functional programming ones come out [20:08:17] How many sharps would B# Minor have? [20:08:20] uh [20:08:21] Will do [20:08:31] is that even possible? [20:08:42] It's theoretically possible; good enough [20:08:47] Hahaha [20:09:01] like 9? [20:09:08] Which would mean 5 sharps and two doubles [20:09:12] I would guess [20:10:50] NicholasG04: would love to see you claim the tasks :-). [20:11:01] Correct [20:11:27] Mr Urbanec I certainly will be, just want to do Lua 6 first to get all of them done. Then I think I'll start with the nice and easy OAuth registration one [20:11:35] I already have an idea of how I can go a bit beyond expectations there! [20:11:43] Ebe123 yay! [20:11:56] Is this the key to winning GCI - get good at music? [20:12:08] je dois améliorer ! [20:12:31] B#,Cx,D#,E#,Fx,G#,A# [20:12:34] NicholasG04: there is no single key :-). i'd say it's "become a part of community" [20:13:05] Il y a plusieurs clefs avec plein de modes [20:14:01] Urbanecm: wikibugs can be a winner in the contest because of his participation in community lol [20:14:56] The hurricane that passed my town this year had a relevant name: Dorian [20:15:07] (03CR) 10Antleite2001: "Hi Aklapper" [extensions/examples] - 10https://gerrit.wikimedia.org/r/558655 (owner: 10Antleite2001) [20:15:43] (03CR) 10Daimona Eaytoy: [C: 04-1] "Ah, I'm sorry. I should've said that I had also sent a fix for this code, see Iea6889d5a6178fa5aae77355ef9162f93e23e21d." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/558649 (owner: 10Ammarpad) [20:15:48] Wikipedia is quite poor in helping to learn music theory; everything seems to be written for professionals [20:15:58] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/ParserFun] - 10https://gerrit.wikimedia.org/r/558668 (owner: 10Libraryupgrader) [20:16:36] What's best is the plane ticket for wikibugs would be cheap; either in the hold (robot) or sneak in (a bug) [20:16:44] Urbanecm - I recognise that of course, I was simply joking :) [20:16:56] Haha [20:17:27] I view Wikimedia as such an amazing organisation due to the values of sharing knowledge with everyone and what seems to be such an amazingly active community I never before realised existed [20:17:38] There also might be more Lua tasks coming out in the next weeks [20:17:49] (03PS4) 10Clarakosi: Do not merge: Testing api-testing with extension [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/558179 [20:17:50] For something that I've used so much during my life, it feels great to try and help in any little way possible [20:17:54] Last year there were like 9, I think [20:18:02] The Lua tasks have been fun - I had never used lua before so it's been a good introduction for me [20:18:20] I learned programming by working on MediaWiki [20:18:57] now time to wait for the acceptance of lua 5 whilst working some more on my transcriptions [20:19:12] I only learned about GCI when I was working and connected to IRC mid-contest, wondering what was this GCI everyone was talking about [20:19:22] That's cool [20:19:30] This is my first year doing it [20:19:42] GCI is the Lua rewrite of MediaWiki [20:19:43] I was browsing the organisations and couldn't find one which I was really passionate about until I found WikiMedia [20:19:56] It plays to my strengths and is so interesting for me [20:19:57] Then I passed my development work off to the students ;) [20:19:57] lol [20:20:09] Ebe123 a nice way to reduce your workload... for free?! [20:20:20] ce n'est pas sympa ! [20:20:22] Well, Google assumes the cost [20:20:29] c'est vrai [20:20:41] on peut gagner les 't-shirts', 'jackets' et bien sur le voyage aussi [20:20:43] And I do have to mentor the students [20:20:54] true [20:21:08] "mentor" [20:21:13] read: link students to stackoverflow [20:21:23] I've not done that (yet) [20:21:30] Étienne is too good of a mentor for that lol [20:21:41] I've heard with some mentors in other orgs it's just 'this is bad' and 'good work' [20:21:46] I link them to the LilyPond reference [20:21:52] NicholasG04: In some cases GCI mentors might "save some time", in some cases not. Hard to generalize. The hardest part as an org admin is to "teach" mentors how to write good task descriptions, to avoid disappointment on both sides (mentor and student) [20:22:01] Nah, that's too much [20:22:03] Interesting [20:22:33] I think GCI is a brilliant way to pick up new skills and engage in a community I hope to stick with for a while now! [20:22:40] Write down what I need from them and guide them when stuck. [20:22:46] Wasn't there an email sent around the other week because some of the orgs had tasks like "star our git repo" or "join our mailing list" [20:23:05] Yes [20:23:20] Ebe123 quand vous utilisez lilypond, est-ce que vous utilisez FrescoBaldi ou un autre EDI ? [20:23:27] Au naturel [20:23:30] Before Wikimedia I tried to do a OpenMRS task. I was banned in their forum( [20:23:32] vraiment ?! [20:23:34] comment ?! [20:23:37] Sublime Text [20:23:45] pour moi, ce ne serait pas possible [20:23:50] j'écris tous les notes bien sur [20:24:00] mais d'avoir la musique aussi est tres important pour moi [20:24:08] https://img.nicholasg.me/2SqVM.png [20:24:10] Crutishnyk, Really? How? [20:24:21] What did you do to deserve that? [20:24:34] Ebe123: Idk. [20:24:41] I've tried Frescobaldi and I like it; just I always have Sublime open [20:24:47] fair enough [20:24:59] And I know what I'm writing (until it doesn't want to compile) [20:25:15] I was stuck for about an hour on a bar check... [20:25:21] Then I realised I was being a total idiot [20:25:33] very embarrassing! [20:26:24] I used to use Sublime, then I used Visual Studio Code for the first time and it was like living in the future [20:26:31] There are two main problems with those "Star repo/mailing list" tasks, 1) It's just self-promotion without student benefit 2) more dangerous in more likely to expose PI [20:26:35] Then I tried to use vim and I couldn't escape so I'm kinda stuck with it now [20:26:37] NicholasG04: Welp, it's happening sometimes ¯\_(ツ)_/¯ [20:26:43] IAmNetx: hah [20:26:50] Yep! [20:27:07] https://upload.wikimedia.org/score/3/8/38f1gd0ruosad4se4oxby9dk28g2c0i/38f1gd0r.png [20:27:38] My student had some trouble with all the varying barlines, I understand the pain [20:27:54] (Source, https://en.wikipedia.org/wiki/Lincolnshire_Posy#III._“Rufford_Park_Poachers” [20:27:56] ) [20:29:22] (03PS6) 10Clarakosi: Add API-testing to core [core] - 10https://gerrit.wikimedia.org/r/556405 (https://phabricator.wikimedia.org/T236680) [20:29:27] (03CR) 10jerkins-bot: [V: 04-1] Do not merge: Testing api-testing with extension [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/558179 (owner: 10Clarakosi) [20:29:35] Oh, got 4 new snippets to add to my suggestions list (the other movements ;) ) [20:36:41] (03CR) 10Ammarpad: ">" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/558649 (owner: 10Ammarpad) [20:36:48] (03Abandoned) 10Ammarpad: InfoAction: Fix code smell [core] - 10https://gerrit.wikimedia.org/r/558649 (owner: 10Ammarpad) [20:39:05] (03CR) 10Clarakosi: "I think this is ready for review" [core] - 10https://gerrit.wikimedia.org/r/556405 (https://phabricator.wikimedia.org/T236680) (owner: 10Clarakosi) [20:41:46] (03PS8) 10Nikki Nikkhoui: GET Page Source Endpoint [core] - 10https://gerrit.wikimedia.org/r/555560 (https://phabricator.wikimedia.org/T229663) [20:43:48] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/556405 (https://phabricator.wikimedia.org/T236680) (owner: 10Clarakosi) [20:46:09] Ebe123 [20:46:15] Merci beaucoup pour vos commentaires ! [20:46:41] Pas besoin de "monsieur" [20:46:46] mais, mais [20:46:51] j'aime le faire [20:46:56] D'accord [20:47:11] parce que pour moi, vous méritez le respect [20:47:15] (03CR) 10MSantos: [C: 03+2] Extract more Status info for MachineVisionEntitySaveException [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/558663 (owner: 10Mholloway) [20:51:41] (03PS4) 10Jdlrobson: Drop InlineDiffFormatter and InlineDifferenceEngine [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/556811 (https://phabricator.wikimedia.org/T240622) [20:51:43] (03PS1) 10Jdlrobson: Deprecate InlineDiffFormatter and InlineDifferenceEngine [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558677 (https://phabricator.wikimedia.org/T240622) [20:53:10] (03PS4) 10Ottomata: Stop mocha tests from hanging [services/eventstreams] - 10https://gerrit.wikimedia.org/r/558608 [20:53:59] (03CR) 10Mholloway: [V: 03+2] Extract more Status info for MachineVisionEntitySaveException [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/558663 (owner: 10Mholloway) [20:55:39] (03PS1) 10Mholloway: Extract more Status info for MachineVisionEntitySaveException [extensions/MachineVision] (wmf/1.35.0-wmf.11) - 10https://gerrit.wikimedia.org/r/558678 [20:56:00] (03PS1) 10Mholloway: Extract more Status info for MachineVisionEntitySaveException [extensions/MachineVision] (wmf/1.35.0-wmf.10) - 10https://gerrit.wikimedia.org/r/558679 [20:56:08] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/555560 (https://phabricator.wikimedia.org/T229663) (owner: 10Nikki Nikkhoui) [20:56:20] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/556811 (https://phabricator.wikimedia.org/T240622) (owner: 10Jdlrobson) [20:57:09] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558677 (https://phabricator.wikimedia.org/T240622) (owner: 10Jdlrobson) [20:57:38] (03CR) 10Mholloway: [V: 03+2 C: 03+2] Extract more Status info for MachineVisionEntitySaveException [extensions/MachineVision] (wmf/1.35.0-wmf.11) - 10https://gerrit.wikimedia.org/r/558678 (owner: 10Mholloway) [20:57:49] (03PS5) 10Jdlrobson: CtaDrawers no longer stay behind in DOM [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/558252 (https://phabricator.wikimedia.org/T214045) [20:57:51] (03CR) 10Mholloway: [V: 03+2 C: 03+2] Extract more Status info for MachineVisionEntitySaveException [extensions/MachineVision] (wmf/1.35.0-wmf.10) - 10https://gerrit.wikimedia.org/r/558679 (owner: 10Mholloway) [20:58:42] (03Abandoned) 10Jdlrobson: QA: Nested reference drawer test is flakey [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/558656 (owner: 10Jdlrobson) [21:00:38] (03PS2) 10Ottomata: Add wikimedia/common and mediawiki/client/error schemas [schemas/event/primary] - 10https://gerrit.wikimedia.org/r/558651 (https://phabricator.wikimedia.org/T240985) [21:09:16] (03PS1) 10Reedy: Update RELEASE-NOTES [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/558681 [21:10:27] (03PS1) 10Reedy: Update RELEASE-NOTES [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/558683 [21:10:54] (03PS2) 10Aaron Schulz: objectcache: fix cache pollution during Multi* method preemptive refreshes [core] - 10https://gerrit.wikimedia.org/r/547696 (https://phabricator.wikimedia.org/T235188) [21:11:20] (03PS1) 10Reedy: Update RELEASE-NOTES [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/558684 [21:12:51] (03PS1) 10Reedy: Update RELEASE-NOTES [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/558686 [21:12:54] (03CR) 10Reedy: [C: 03+2] Update RELEASE-NOTES [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/558681 (owner: 10Reedy) [21:13:17] (03CR) 10Reedy: [C: 03+2] Update RELEASE-NOTES [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/558683 (owner: 10Reedy) [21:13:21] (03CR) 10Reedy: [C: 03+2] Update RELEASE-NOTES [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/558684 (owner: 10Reedy) [21:13:25] (03CR) 10Reedy: [C: 03+2] Update RELEASE-NOTES [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/558686 (owner: 10Reedy) [21:13:27] (03CR) 10Aezell: Add Compare service to fetch compare data (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/555619 (https://phabricator.wikimedia.org/T238714) (owner: 10Dmaza) [21:15:35] (03CR) 10Aezell: [C: 03+1] Add user preference info to basic info section [core] - 10https://gerrit.wikimedia.org/r/554654 (https://phabricator.wikimedia.org/T234952) (owner: 10HMonroy) [21:17:07] (03Merged) 10jenkins-bot: Update RELEASE-NOTES [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/558681 (owner: 10Reedy) [21:19:10] (03CR) 10Umherirrender: [V: 03+2] build: Updating grunt-banana-checker to 0.8.1 [extensions/ImapAuthorization] - 10https://gerrit.wikimedia.org/r/558264 (owner: 10Libraryupgrader) [21:19:10] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/558681 (owner: 10Reedy) [21:19:25] (03PS2) 10Umherirrender: build: Updating mediawiki/minus-x to 0.3.2 [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/558625 (owner: 10Libraryupgrader) [21:19:49] I have returned [21:20:16] (03Merged) 10jenkins-bot: Update RELEASE-NOTES [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/558684 (owner: 10Reedy) [21:20:26] (03CR) 10Umherirrender: [C: 03+2] build: Updating mediawiki/minus-x to 0.3.2 [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/558625 (owner: 10Libraryupgrader) [21:20:46] (03CR) 10Umherirrender: [V: 03+2] build: Updating mediawiki/minus-x to 0.3.2 [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/558624 (owner: 10Libraryupgrader) [21:21:25] Back to Lua 6! [21:21:25] (03PS2) 10Umherirrender: build: Updating mediawiki/minus-x to 0.3.2 [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/558616 (owner: 10Libraryupgrader) [21:21:29] (03CR) 10Umherirrender: [C: 03+2] build: Updating mediawiki/minus-x to 0.3.2 [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/558616 (owner: 10Libraryupgrader) [21:21:49] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/558683 (owner: 10Reedy) [21:22:18] (03CR) 10Umherirrender: [C: 03+2] "Resubmit" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/558584 (owner: 10Libraryupgrader) [21:22:42] (03CR) 10Umherirrender: [V: 03+2] build: Updating mediawiki/minus-x to 0.3.2 [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/558566 (owner: 10Libraryupgrader) [21:23:08] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/558684 (owner: 10Reedy) [21:23:19] (03Merged) 10jenkins-bot: Update RELEASE-NOTES [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/558686 (owner: 10Reedy) [21:23:38] (03PS2) 10Umherirrender: build: Updating dependencies [extensions/NewUserMessage] - 10https://gerrit.wikimedia.org/r/558503 (owner: 10Libraryupgrader) [21:23:42] (03CR) 10Umherirrender: [C: 03+2] build: Updating dependencies [extensions/NewUserMessage] - 10https://gerrit.wikimedia.org/r/558503 (owner: 10Libraryupgrader) [21:24:31] (03PS3) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/558359 (owner: 10Libraryupgrader) [21:24:35] (03CR) 10Umherirrender: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/558359 (owner: 10Libraryupgrader) [21:25:48] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/558686 (owner: 10Reedy) [21:28:04] (03CR) 10Umherirrender: [C: 03+2] API: Update docs on addWhere() and related methods [core] - 10https://gerrit.wikimedia.org/r/558628 (owner: 10Anomie) [21:28:54] (03PS3) 10Umherirrender: CategoryManager: Fix type annotations [extensions/Linter] - 10https://gerrit.wikimedia.org/r/558318 (owner: 10Legoktm) [21:28:59] (03CR) 10Umherirrender: [C: 03+2] CategoryManager: Fix type annotations [extensions/Linter] - 10https://gerrit.wikimedia.org/r/558318 (owner: 10Legoktm) [21:29:06] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [core] - 10https://gerrit.wikimedia.org/r/547696 (https://phabricator.wikimedia.org/T235188) (owner: 10Aaron Schulz) [21:29:32] (03Abandoned) 10Umherirrender: API: Use addWhereIDsFld since we're passing along a list of IDs [extensions/Linter] - 10https://gerrit.wikimedia.org/r/558317 (owner: 10Legoktm) [21:29:49] (03PS4) 10Umherirrender: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/Linter] - 10https://gerrit.wikimedia.org/r/558308 (owner: 10Libraryupgrader) [21:29:53] (03CR) 10Umherirrender: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/Linter] - 10https://gerrit.wikimedia.org/r/558308 (owner: 10Libraryupgrader) [21:30:21] (03CR) 10Umherirrender: [V: 03+2] build: Updating mediawiki/minus-x to 0.3.2 [extensions/PagePopups] - 10https://gerrit.wikimedia.org/r/558647 (owner: 10Libraryupgrader) [21:30:59] (03Abandoned) 10Umherirrender: Adjust type hints in api related classes [core] - 10https://gerrit.wikimedia.org/r/520062 (owner: 10Umherirrender) [21:32:06] (03CR) 10jerkins-bot: [V: 04-1] Fix wrong title links on Special:Undelete [core] - 10https://gerrit.wikimedia.org/r/554417 (https://phabricator.wikimedia.org/T196669) (owner: 10Ammarpad) [21:33:20] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [extensions/Linter] - 10https://gerrit.wikimedia.org/r/558308 (owner: 10Libraryupgrader) [21:33:39] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/554417 (https://phabricator.wikimedia.org/T196669) (owner: 10Ammarpad) [21:43:22] (03PS1) 10Reedy: Tests for an old PHP bug in parse_url [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/558690 (https://phabricator.wikimedia.org/T212067) [21:43:33] (03CR) 10Reedy: [C: 03+2] "Completeness" [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/558690 (https://phabricator.wikimedia.org/T212067) (owner: 10Reedy) [21:44:06] (03CR) 10Wugapodes: [C: 03+2] "+2 so that change 554214 can merge" [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/553828 (https://phabricator.wikimedia.org/T239438) (owner: 10Wugapodes) [21:45:15] (03CR) 10Daniel Kinzler: Add API-testing to core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/556405 (https://phabricator.wikimedia.org/T236680) (owner: 10Clarakosi) [21:46:58] (03CR) 10Daniel Kinzler: Add API-testing to core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/556405 (https://phabricator.wikimedia.org/T236680) (owner: 10Clarakosi) [21:51:07] (03Merged) 10jenkins-bot: Tests for an old PHP bug in parse_url [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/558690 (https://phabricator.wikimedia.org/T212067) (owner: 10Reedy) [21:52:48] (03CR) 10Umherirrender: [C: 03+2] Make UsersPager::requestedGroup public [core] - 10https://gerrit.wikimedia.org/r/558038 (owner: 10Daimona Eaytoy) [21:53:32] (03CR) 10Umherirrender: [C: 03+2] "Resubmit" [extensions/FilterListUsers] - 10https://gerrit.wikimedia.org/r/557827 (owner: 10Libraryupgrader) [21:55:01] (03PS1) 10EBernhardson: oozie: support kerberos auth [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/558691 [21:55:42] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/558690 (https://phabricator.wikimedia.org/T212067) (owner: 10Reedy) [21:58:21] (03PS2) 10EBernhardson: oozie: support kerberos auth [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/558691 [21:58:25] (03CR) 10EBernhardson: [C: 03+2] oozie: support kerberos auth [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/558691 (owner: 10EBernhardson) [21:59:32] (03Merged) 10jenkins-bot: oozie: support kerberos auth [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/558691 (owner: 10EBernhardson) [21:59:45] (03Merged) 10jenkins-bot: API: Update docs on addWhere() and related methods [core] - 10https://gerrit.wikimedia.org/r/558628 (owner: 10Anomie) [21:59:47] (03Merged) 10jenkins-bot: CategoryManager: Fix type annotations [extensions/Linter] - 10https://gerrit.wikimedia.org/r/558318 (owner: 10Legoktm) [22:03:11] (03CR) 10Umherirrender: "I would say that this does not fixed the confusion. When getting an array a loop is needed to build the output." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/557879 (owner: 10Daimona Eaytoy) [22:03:19] (03PS1) 10Zoranzoki21: Fix confirmtaion typo in bs-readconfirmation-api-error-cant-confirm [extensions/BlueSpiceReadConfirmation] - 10https://gerrit.wikimedia.org/r/558692 (https://phabricator.wikimedia.org/T201491) [22:03:41] (03CR) 10jerkins-bot: [V: 04-1] ChessBrowser: Add parser for PGN [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/553828 (https://phabricator.wikimedia.org/T239438) (owner: 10Wugapodes) [22:03:43] (03CR) 10jerkins-bot: [V: 04-1] ChessBrowser: Unit tests for PgnParser and related bug fixes [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [22:04:04] (03PS2) 10Zoranzoki21: Fix confirmtaion typo in bs-readconfirmation-api-error-cant-confirm [extensions/BlueSpiceReadConfirmation] - 10https://gerrit.wikimedia.org/r/558692 (https://phabricator.wikimedia.org/T201491) [22:10:42] Sent another for review :) [22:10:47] Logging off now! [22:10:51] Have a good evening, everyone. [22:14:40] (03Merged) 10jenkins-bot: Make UsersPager::requestedGroup public [core] - 10https://gerrit.wikimedia.org/r/558038 (owner: 10Daimona Eaytoy) [22:17:18] (03CR) 10DannyS712: [C: 04-1] ChessBrowser: Add parser for PGN (031 comment) [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/553828 (https://phabricator.wikimedia.org/T239438) (owner: 10Wugapodes) [22:17:46] (03CR) 10DannyS712: [C: 04-1] ChessBrowser: Unit tests for PgnParser and related bug fixes (031 comment) [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [22:21:21] (03PS9) 10Wugapodes: ChessBrowser: Add parser for PGN [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/553828 (https://phabricator.wikimedia.org/T239438) [22:21:51] (03CR) 10Wugapodes: "recheck" [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/553828 (https://phabricator.wikimedia.org/T239438) (owner: 10Wugapodes) [22:22:13] (03CR) 10DannyS712: [C: 03+1] ChessBrowser: Add parser for PGN [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/553828 (https://phabricator.wikimedia.org/T239438) (owner: 10Wugapodes) [22:23:13] (03CR) 10jerkins-bot: [V: 04-1] ChessBrowser: Add parser for PGN [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/553828 (https://phabricator.wikimedia.org/T239438) (owner: 10Wugapodes) [22:23:18] (03CR) 10DannyS712: [C: 03+1] "> recheck" [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/553828 (https://phabricator.wikimedia.org/T239438) (owner: 10Wugapodes) [22:25:31] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/minus-x to 0.3.2 [extensions/PhpTagsMaps] - 10https://gerrit.wikimedia.org/r/558699 (owner: 10Libraryupgrader) [22:26:34] (03CR) 10Krinkle: Add API-testing to core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/556405 (https://phabricator.wikimedia.org/T236680) (owner: 10Clarakosi) [22:28:42] (03CR) 10Krinkle: Add API-testing to core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/556405 (https://phabricator.wikimedia.org/T236680) (owner: 10Clarakosi) [22:30:31] (03CR) 10Krinkle: Add API-testing to core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/556405 (https://phabricator.wikimedia.org/T236680) (owner: 10Clarakosi) [22:31:25] (03PS1) 10EBernhardson: oozie: Correct query_clicks hive_principal [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/558708 [22:31:37] (03PS2) 10EBernhardson: oozie: Correct query_clicks hive_principal [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/558708 [22:31:48] (03CR) 10EBernhardson: [C: 03+2] oozie: Correct query_clicks hive_principal [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/558708 (owner: 10EBernhardson) [22:32:14] (03CR) 10Krinkle: "recheck" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/558179 (owner: 10Clarakosi) [22:32:52] (03Merged) 10jenkins-bot: oozie: Correct query_clicks hive_principal [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/558708 (owner: 10EBernhardson) [22:35:20] (03CR) 10Physikerwelt: [C: 03+2] "However wikibase tests are broken again" [extensions/Math] - 10https://gerrit.wikimedia.org/r/558573 (https://phabricator.wikimedia.org/T209563) (owner: 10Kghbln) [22:35:22] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/minus-x to 0.3.2 [extensions/PhpTagsStorage] - 10https://gerrit.wikimedia.org/r/558709 (owner: 10Libraryupgrader) [22:35:42] (03PS2) 10Physikerwelt: Switch configuration parameter setting to a working URL [extensions/Math] - 10https://gerrit.wikimedia.org/r/558573 (https://phabricator.wikimedia.org/T209563) (owner: 10Kghbln) [22:36:05] (03CR) 10Wugapodes: "I think it might just be easier to rebase the child change on master, edit the child's commit message to include the information here, and" [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/553828 (https://phabricator.wikimedia.org/T239438) (owner: 10Wugapodes) [22:37:15] (03CR) 10DannyS712: "> I think it might just be easier to rebase the child change on" [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/553828 (https://phabricator.wikimedia.org/T239438) (owner: 10Wugapodes) [22:39:37] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/PhpTagsWidgets] - 10https://gerrit.wikimedia.org/r/558710 (owner: 10Libraryupgrader) [22:41:22] (03CR) 10Nuria: Add wikimedia/common and mediawiki/client/error schemas (032 comments) [schemas/event/primary] - 10https://gerrit.wikimedia.org/r/558651 (https://phabricator.wikimedia.org/T240985) (owner: 10Ottomata) [22:45:54] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/PhpTagsWiki] - 10https://gerrit.wikimedia.org/r/558712 (owner: 10Libraryupgrader) [22:47:59] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/558713 (owner: 10Libraryupgrader) [22:48:03] (03PS23) 10Wugapodes: ChessBrowser: Unit tests for PgnParser and related bug fixes [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) [22:57:41] (03PS1) 10Reedy: Update james-heinrich/getid3 from 1.9.18 to 1.9.19 [vendor] - 10https://gerrit.wikimedia.org/r/558718 (https://phabricator.wikimedia.org/T239759) [23:02:53] (03PS1) 10Gergő Tisza: growthexperiments: update newcomer tasks config [vagrant] - 10https://gerrit.wikimedia.org/r/558720 [23:04:39] (03CR) 10Gergő Tisza: [C: 03+2] "Self-merge, will be needed for Outreachy." [vagrant] - 10https://gerrit.wikimedia.org/r/558720 (owner: 10Gergő Tisza) [23:05:40] (03Merged) 10jenkins-bot: growthexperiments: update newcomer tasks config [vagrant] - 10https://gerrit.wikimedia.org/r/558720 (owner: 10Gergő Tisza) [23:07:57] (03CR) 10VolkerE: [C: 04-1] "Naming is still off. See my comment on PS 3." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/549220 (https://phabricator.wikimedia.org/T169910) (owner: 10Jdlrobson) [23:10:57] (03PS1) 10Zoranzoki21: Merge few .txt files into the one README.md file [sandbox] - 10https://gerrit.wikimedia.org/r/558724 [23:10:59] (03CR) 10Zoranzoki21: [V: 03+2 C: 03+2] Merge few .txt files into the one README.md file [sandbox] - 10https://gerrit.wikimedia.org/r/558724 (owner: 10Zoranzoki21) [23:15:01] (03Abandoned) 10Nuria: Adding logging to help troubleshoot errors with mysql processor [eventlogging] - 10https://gerrit.wikimedia.org/r/497951 (https://phabricator.wikimedia.org/T218831) (owner: 10Nuria) [23:18:38] (03PS1) 10Zoranzoki21: Transition of MobileFrontend Gruntfile.js tasks to NPM scripts [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558727 (https://phabricator.wikimedia.org/T206069) [23:22:37] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558727 (https://phabricator.wikimedia.org/T206069) (owner: 10Zoranzoki21) [23:29:07] (03CR) 10Gergő Tisza: "(already merged but adding people for visibility)" [vagrant] - 10https://gerrit.wikimedia.org/r/558720 (owner: 10Gergő Tisza) [23:31:37] (03CR) 10Niedzielski: [C: 03+2] QA: Move reference browser test to Node.js suite [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/558657 (owner: 10Jdlrobson) [23:31:41] (03CR) 10jerkins-bot: [V: 04-1] Transition of MobileFrontend Gruntfile.js tasks to NPM scripts [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558727 (https://phabricator.wikimedia.org/T206069) (owner: 10Zoranzoki21) [23:36:34] (03CR) 10Jdlrobson: "I plan to abandon this before the xmas break as part of my xmas cleanup (can always be restored in new year), so if this is valuable pleas" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/545012 (owner: 10Jdlrobson) [23:37:16] (03Abandoned) 10Jdlrobson: WIP: Protection form built in OOUI [core] - 10https://gerrit.wikimedia.org/r/545417 (https://phabricator.wikimedia.org/T235424) (owner: 10Jdlrobson) [23:37:59] (03PS2) 10Jdlrobson: Use `section` tag for mobile sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/545643 [23:38:25] (03CR) 10Jdlrobson: "I plan to abandon this before the xmas break as part of my xmas cleanup (can always be restored in new year), so if this is valuable pleas" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/545643 (owner: 10Jdlrobson) [23:39:08] (03Abandoned) 10Jdlrobson: Echo notification badge returns to a bell when clicked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/541391 (owner: 10Jdlrobson) [23:40:26] (03CR) 10Nray: [C: 04-1] "I think it's best for the client to be explicit about what route they want OverlayManager to respond to and for OverlayManager to reject (" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558232 (https://phabricator.wikimedia.org/T238364) (owner: 10Jdlrobson) [23:41:14] (03CR) 10Jdlrobson: "I plan to abandon this before the xmas break as part of my xmas cleanup (can always be restored in new year), so if this is valuable pleas" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/550961 (owner: 10Jdlrobson) [23:41:40] (03Abandoned) 10Jdlrobson: Separate header generation from diff generation [core] - 10https://gerrit.wikimedia.org/r/547594 (https://phabricator.wikimedia.org/T117279) (owner: 10Jdlrobson) [23:41:58] (03PS3) 10Jdlrobson: Extra safeguarding for MobileFrontend specific functions [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/546751 [23:42:19] (03CR) 10jerkins-bot: [V: 04-1] Extra safeguarding for MobileFrontend specific functions [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/546751 (owner: 10Jdlrobson) [23:42:44] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/545643 (owner: 10Jdlrobson) [23:43:17] (03PS3) 10VolkerE: Use `section` tag for mobile sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/545643 (owner: 10Jdlrobson) [23:43:28] (03CR) 10Samwilson: [C: 03+2] Add user preference info to basic info section [core] - 10https://gerrit.wikimedia.org/r/554654 (https://phabricator.wikimedia.org/T234952) (owner: 10HMonroy) [23:43:32] (03CR) 10Jdlrobson: [C: 04-1] "Looks like jenkins has some complaints so even if this is working for you locally it might not be working for a new install. You can follo" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558727 (https://phabricator.wikimedia.org/T206069) (owner: 10Zoranzoki21) [23:44:13] (03CR) 10VolkerE: Use `section` tag for mobile sections (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/545643 (owner: 10Jdlrobson) [23:45:18] (03PS13) 10Jdlrobson: Add `legacy` and i18n features to ResourceLoaderSkinModule [core] - 10https://gerrit.wikimedia.org/r/549220 (https://phabricator.wikimedia.org/T169910) [23:46:38] (03CR) 10Jdlrobson: Add `legacy` and i18n features to ResourceLoaderSkinModule (032 comments) [core] - 10https://gerrit.wikimedia.org/r/549220 (https://phabricator.wikimedia.org/T169910) (owner: 10Jdlrobson) [23:47:30] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/545643 (owner: 10Jdlrobson) [23:47:44] (03PS4) 10Jdlrobson: Use `section` tag for mobile sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/545643 [23:48:38] (03PS1) 10EBernhardson: Update search-rewritten i18n message to clarify how it is used in practice [core] - 10https://gerrit.wikimedia.org/r/558734 (https://phabricator.wikimedia.org/T236296) [23:53:16] (03PS2) 10EBernhardson: Update search-rewritten i18n message to clarify how it is used in practice [core] - 10https://gerrit.wikimedia.org/r/558734 (https://phabricator.wikimedia.org/T236296) [23:53:57] (03CR) 10Jdlrobson: [C: 04-1] "> All the examples listed in T238364 except the 'abc123' one are invalid URIs and I think should be percent encoded when passed into Overl" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/558232 (https://phabricator.wikimedia.org/T238364) (owner: 10Jdlrobson) [23:54:51] (03Abandoned) 10Jdlrobson: POC: A fork within Vector (Spork skin) [skins/Vector] - 10https://gerrit.wikimedia.org/r/545349 (owner: 10Jdlrobson) [23:55:07] (03Abandoned) 10Jdlrobson: Mobile and desktop Echo are the same [extensions/Echo] - 10https://gerrit.wikimedia.org/r/542216 (https://phabricator.wikimedia.org/T226125) (owner: 10Jdlrobson) [23:55:15] (03PS3) 10Jdlrobson: Style improvements to Echo OOUI dialog in desktop Minerva [extensions/Echo] - 10https://gerrit.wikimedia.org/r/541992 [23:56:00] (03CR) 10Jdlrobson: "Kosta/Roan do you have bandwidth to review before the holiday's? I'm clearing out my gerrit queue so I'll abandon it if we can't (which wo" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/541992 (owner: 10Jdlrobson) [23:56:39] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/545643 (owner: 10Jdlrobson) [23:56:51] (03Abandoned) 10Jdlrobson: WIP: Split language styles out mediawiki.legacy.shared into mediawiki.languages.styles [core] - 10https://gerrit.wikimedia.org/r/541659 (https://phabricator.wikimedia.org/T217616) (owner: 10Jdlrobson) [23:58:19] (03CR) 10Jdlrobson: "Before the end of the year let me know if there's interest in separating MobileFrontend-dependent code from Minerva (and I'll fix it up) o" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/534892 (owner: 10Jdlrobson) [23:58:52] (03Abandoned) 10Jdlrobson: Basic storybook for Minerva [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/539424 (owner: 10Jdlrobson) [23:59:06] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/541992 (owner: 10Jdlrobson) [23:59:24] (03CR) 10jerkins-bot: [V: 04-1] Use `section` tag for mobile sections [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/545643 (owner: 10Jdlrobson) [23:59:38] (03CR) 10SonarQube Bot: [C: 03+1] "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/549220 (https://phabricator.wikimedia.org/T169910) (owner: 10Jdlrobson)