[00:00:36] (03PS4) 10Krinkle: Update some docs with more scalar types [core] - 10https://gerrit.wikimedia.org/r/555719 (owner: 10Daimona Eaytoy) [00:00:56] (03PS1) 10SLF bot: Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/557319 [00:01:42] (03CR) 10Zoranzoki21: "recheck" [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/557319 (owner: 10SLF bot) [00:02:10] (03PS5) 10Krinkle: Document more scalar types for BagOStuff::makeKey and Language::formatNum [core] - 10https://gerrit.wikimedia.org/r/555719 (owner: 10Daimona Eaytoy) [00:02:13] (03CR) 10Krinkle: [C: 03+2] Document more scalar types for BagOStuff::makeKey and Language::formatNum [core] - 10https://gerrit.wikimedia.org/r/555719 (owner: 10Daimona Eaytoy) [00:02:17] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [extensions/SimpleFarm] - 10https://gerrit.wikimedia.org/r/557316 (owner: 10Libraryupgrader) [00:07:33] (03CR) 10Zoranzoki21: [C: 04-1] "Commit message is wrong, I don't see change in .gitignore file..." [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/557321 (owner: 10Libraryupgrader) [00:08:03] (03PS2) 10Krinkle: Deprecate and stop using assertType(OrValue) [core] - 10https://gerrit.wikimedia.org/r/557080 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [00:08:09] (03CR) 10Krinkle: [C: 03+2] Deprecate and stop using assertType(OrValue) [core] - 10https://gerrit.wikimedia.org/r/557080 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [00:09:20] (03CR) 10Zoranzoki21: "Oh, it is somehow in file already, I'm removing my -1." [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/557321 (owner: 10Libraryupgrader) [00:09:42] (03CR) 10Krinkle: Manual fix of the remaining assertInternalType & Co. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/557087 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [00:10:08] (03PS3) 10Krinkle: Manual fix of the remaining assertInternalType & Co. [core] - 10https://gerrit.wikimedia.org/r/557087 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [00:14:02] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/555719 (owner: 10Daimona Eaytoy) [00:14:51] (03Merged) 10jenkins-bot: Document more scalar types for BagOStuff::makeKey and Language::formatNum [core] - 10https://gerrit.wikimedia.org/r/555719 (owner: 10Daimona Eaytoy) [00:18:42] 10WMSE-Magnus Sälgö: Europeana Entity <-> Wikidata Property 7704 - https://phabricator.wikimedia.org/T240290 (10Salgo60) [00:20:14] (03PS4) 10Krinkle: Manual fix of the remaining assertInternalType & Co. [core] - 10https://gerrit.wikimedia.org/r/557087 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [00:20:19] (03CR) 10Krinkle: [C: 03+2] Manual fix of the remaining assertInternalType & Co. [core] - 10https://gerrit.wikimedia.org/r/557087 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [00:20:43] (03Merged) 10jenkins-bot: Deprecate and stop using assertType(OrValue) [core] - 10https://gerrit.wikimedia.org/r/557080 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [00:20:46] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557080 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [00:20:56] 10ImageMetrics: ImageMetrics qunit test mw.imageMetrics.LoadingTimeLogger is failing - https://phabricator.wikimedia.org/T206290 (10Zoranzoki21) @Krinkle I don't see usage on https://wikiapiary.com/wiki/Extension:ImageMetrics maybe we should start with archiving? [00:22:35] 10ImageMetrics: ImageMetrics qunit test mw.imageMetrics.LoadingTimeLogger is failing - https://phabricator.wikimedia.org/T206290 (10Zoranzoki21) Too, extension isn't on WMF wikis since 2016: {T140952}. [00:22:48] (03PS8) 10Krinkle: Stop using assertContains with string haystack [core] - 10https://gerrit.wikimedia.org/r/557164 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [00:22:53] (03CR) 10Krinkle: [C: 03+2] Stop using assertContains with string haystack [core] - 10https://gerrit.wikimedia.org/r/557164 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [00:24:25] (03PS2) 10Krinkle: Fix most PHPUnit 8 compat issues in DBless tests [core] - 10https://gerrit.wikimedia.org/r/557208 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [00:24:29] (03CR) 10Krinkle: [C: 03+2] Fix most PHPUnit 8 compat issues in DBless tests [core] - 10https://gerrit.wikimedia.org/r/557208 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [00:27:52] (03PS2) 10Krinkle: Fixes for PHPUnit 8 compat in DB suite [core] - 10https://gerrit.wikimedia.org/r/557219 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [00:27:58] (03PS3) 10Krinkle: Fixes for PHPUnit 8 compat in DB suite [core] - 10https://gerrit.wikimedia.org/r/557219 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [00:28:01] (03CR) 10Krinkle: [C: 03+2] Fixes for PHPUnit 8 compat in DB suite [core] - 10https://gerrit.wikimedia.org/r/557219 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [00:33:00] (03Merged) 10jenkins-bot: Manual fix of the remaining assertInternalType & Co. [core] - 10https://gerrit.wikimedia.org/r/557087 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [00:33:02] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [extensions/SiteMetrics] - 10https://gerrit.wikimedia.org/r/557324 (owner: 10Libraryupgrader) [00:33:51] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557087 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [00:33:58] (03CR) 10Krinkle: [C: 03+1] Add a base class for parser transition (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/553794 (owner: 10Daimona Eaytoy) [00:38:07] (03Merged) 10jenkins-bot: Stop using assertContains with string haystack [core] - 10https://gerrit.wikimedia.org/r/557164 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [00:38:16] (03Merged) 10jenkins-bot: Fix most PHPUnit 8 compat issues in DBless tests [core] - 10https://gerrit.wikimedia.org/r/557208 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [00:40:14] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557164 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [00:41:24] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557208 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [00:43:19] (03Merged) 10jenkins-bot: Fixes for PHPUnit 8 compat in DB suite [core] - 10https://gerrit.wikimedia.org/r/557219 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [00:43:35] (03PS1) 10Zoranzoki21: TEST PATCH [extensions/SiteMetrics] - 10https://gerrit.wikimedia.org/r/557325 [00:43:56] (03PS2) 10Zoranzoki21: TEST PATCH [extensions/SiteMetrics] - 10https://gerrit.wikimedia.org/r/557325 [00:44:48] (03CR) 10jerkins-bot: [V: 04-1] TEST PATCH [extensions/SiteMetrics] - 10https://gerrit.wikimedia.org/r/557325 (owner: 10Zoranzoki21) [00:45:18] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557219 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [00:46:10] (03PS3) 10Zoranzoki21: TEST PATCH [extensions/SiteMetrics] - 10https://gerrit.wikimedia.org/r/557325 [00:46:15] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [extensions/SiteScout] - 10https://gerrit.wikimedia.org/r/557326 (owner: 10Libraryupgrader) [00:46:51] (03CR) 10Zoranzoki21: "recheck" [extensions/SiteScout] - 10https://gerrit.wikimedia.org/r/557326 (owner: 10Libraryupgrader) [00:47:40] (03CR) 10jerkins-bot: [V: 04-1] TEST PATCH [extensions/SiteMetrics] - 10https://gerrit.wikimedia.org/r/557325 (owner: 10Zoranzoki21) [00:49:17] (03Abandoned) 10Zoranzoki21: TEST PATCH [extensions/SiteMetrics] - 10https://gerrit.wikimedia.org/r/557325 (owner: 10Zoranzoki21) [00:49:20] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [extensions/SkinPerNamespace] - 10https://gerrit.wikimedia.org/r/557327 (owner: 10Libraryupgrader) [00:54:18] (03PS1) 10Zoranzoki21: Remove / from names of files in extension.json [extensions/Tabber] - 10https://gerrit.wikimedia.org/r/557332 [00:56:06] (03PS1) 10Zoranzoki21: Move tabber.js and tabber.css from js/ and css/ directories into the one directory resources/ [extensions/Tabber] - 10https://gerrit.wikimedia.org/r/557334 [00:57:01] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [extensions/SocialLogin] - 10https://gerrit.wikimedia.org/r/557333 (owner: 10Libraryupgrader) [00:59:08] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/557335 (owner: 10Libraryupgrader) [01:07:27] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [extensions/SoftwareVersion] - 10https://gerrit.wikimedia.org/r/557336 (owner: 10Libraryupgrader) [01:13:09] 10WMSE-Magnus Sälgö: Europeana Entity <-> Wikidata Property 7704 - https://phabricator.wikimedia.org/T240290 (10Salgo60) [01:16:33] 10WMSE-Magnus Sälgö: Europeana reference deleted Wikidata objects - task identify them but also Europeana need action - https://phabricator.wikimedia.org/T240738 (10Salgo60) [01:24:15] 10Wikimedia-Site-requests, 10Patch-For-Review: Non-free content on Ingush Wikipedia - https://phabricator.wikimedia.org/T239925 (10Base) @Ammarpad , might it have to do with inhwiki being listed in `commonsuploads.dblist` ? I assume that makes `commonsuploads` of `wgUploadNavigationUrl` being applied to it, do... [01:30:16] 10WMSE-Magnus Sälgö: Europeana Entity <-> Wikidata Property 7704 - https://phabricator.wikimedia.org/T240290 (10Salgo60) [01:34:39] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [extensions/SplitPrivateWiki] - 10https://gerrit.wikimedia.org/r/557348 (owner: 10Libraryupgrader) [01:37:13] 10Wikimedia-Site-requests, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): Create and use the Latin wikipedia (VICIPÆDIA) wordmark on mobile site - https://phabricator.wikimedia.org/T240728 (10Masumrezarock100) [01:37:56] 10Wikimedia-Site-requests, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): Create and use the Latin wikipedia (VICIPÆDIA) wordmark on mobile site - https://phabricator.wikimedia.org/T240728 (10Masumrezarock100) @Ammarpad can you do this? [01:43:06] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [extensions/StickToThatLanguage] - 10https://gerrit.wikimedia.org/r/557354 (owner: 10Libraryupgrader) [01:50:20] (03CR) 10DannyS712: [C: 03+1] ApiEditPage: Fix error message for edit conflicts [core] - 10https://gerrit.wikimedia.org/r/557035 (owner: 10Bartosz Dziewoński) [01:50:27] 10Wikimedia-Site-requests, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): Create and use the Latin wikipedia (VICIPÆDIA) wordmark on mobile site - https://phabricator.wikimedia.org/T240728 (10Ammarpad) a:03Ammarpad >>! In T240728#5742135, @Masumrezarock100 wrote: > @Ammarpad can you do this? Yes, sure [01:53:06] (03CR) 10DannyS712: [C: 03+1] Slightly rephrase blockedtext and autoblockedtext [core] - 10https://gerrit.wikimedia.org/r/556656 (owner: 10Amire80) [01:53:14] 10Wikimedia-Site-requests, 10Patch-For-Review: Non-free content on Ingush Wikipedia - https://phabricator.wikimedia.org/T239925 (10Ammarpad) >>! In T239925#5742122, @Base wrote: > @Ammarpad , might it have to do with inhwiki being listed in `commonsuploads.dblist` ? I assume that makes `commonsuploads` of `wgU... [01:54:44] 10Wikimedia-Site-requests, 10Patch-For-Review: Non-free content on Ingush Wikipedia - https://phabricator.wikimedia.org/T239925 (10Ammarpad) >>! In T239925#5728435, @Adam-Yourist wrote: > Here is this page https://inh.wikipedia.org/wiki/Гӏулакха:Загрузка . This is, for example, a page on the Russian Wikipedia... [01:55:18] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [extensions/Survey] - 10https://gerrit.wikimedia.org/r/557361 (owner: 10Libraryupgrader) [02:14:11] 10MediaWiki-General, 10Core Platform Team, 10Schema-change, 10User-DannyS712: Convert "user_newtalk" table to use actors - https://phabricator.wikimedia.org/T238168 (10DannyS712) a:03DannyS712 [02:14:34] (03PS1) 10DannyS712: [WIP] Migrate `user_newtalk` table to use actors [core] - 10https://gerrit.wikimedia.org/r/557370 [02:20:32] (03Abandoned) 10DannyS712: [WIP] Migrate `user_newtalk` table to use actors [core] - 10https://gerrit.wikimedia.org/r/557370 (owner: 10DannyS712) [02:22:02] 10MediaWiki-General, 10Core Platform Team, 10Schema-change, 10User-DannyS712: Convert "user_newtalk" table to use actors - https://phabricator.wikimedia.org/T238168 (10DannyS712) a:05DannyS712→03None [02:49:46] 10AbuseFilter, 10Patch-For-Review, 10Schema-change: Read from and write to `actor` table in AbuseFilter - https://phabricator.wikimedia.org/T188180 (10MBH) Will it be fixed for renamings before patch? Still not fixed for me, see T193504 [03:24:02] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/557395 (owner: 10Libraryupgrader) [03:40:39] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [extensions/UploadLogo] - 10https://gerrit.wikimedia.org/r/557403 (owner: 10Libraryupgrader) [03:58:33] 10WatchTranslations, 10Google-Code-in-2019: Hide delete button from "Create new component" page - https://phabricator.wikimedia.org/T240237 (10BrandonXLF) 05Open→03Resolved [04:01:43] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [extensions/UserPageViewTracker] - 10https://gerrit.wikimedia.org/r/557413 (owner: 10Libraryupgrader) [04:18:23] hello [04:18:29] anyone here ? [04:21:21] Ebe123 [04:21:33] .mention Ebe123 [04:22:04] .lastseen Ebe123 [04:22:30] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [extensions/VikiSemanticTitle] - 10https://gerrit.wikimedia.org/r/557417 (owner: 10Libraryupgrader) [04:22:39] Hi [04:23:33] hi [04:23:42] Hey Darth [04:23:58] (I'm not here 24/7, and it's 23h30 where I am) [04:24:40] (what happened to your Sanchit username?) [04:25:40] ooh ok [04:25:49] and i changed it [04:26:00] so u could recognise me from GCI [04:26:23] I have access to your previous tasks, so I was waiting for Sanchit [04:26:42] Especially that I approved your IRC task ;) [04:26:55] oh yeah i forgot that [04:27:19] i think i will be using this name now [04:27:31] or should i switch back ? [04:27:40] Doesn't matter [04:27:57] What's funny is I get an email when I approve tasks and when someone comments on one, but not when I comment on a task [04:28:12] ohh u changed too [04:28:15] Messages like: [04:28:18] Hi Étienne Beaulé, [04:28:18] Étienne Beaulé has approved Functional Programming 0: Setting up Score for ๖ۣۜƊαrthǤαndαlf. [04:29:03] lol it should not email u for your own doing [04:29:45] btw i wanted to know how i can come in the leaderboards ? [04:30:13] By doing more tasks. You need to have at least 5 tasks to be able to appear on the leaderboard [04:30:22] Try Lua task 3? [04:30:29] from a same organisation ? [04:30:33] Yes [04:30:35] yeah i will do that [04:30:49] just have to study for my exam [04:30:56] on monday [04:31:09] Don't worry, there's a lot of time left [04:31:29] yeah and then i will get a whole week for this [04:32:26] does the leaderboard represent the finalists ? [04:32:56] No, the leaderboard shows who can be a finalist [04:33:11] ok thx [04:33:23] So the mentors choose from those in the leaderboard the finalists/spares/etc. [04:33:44] how many tasks have others in leaderboard done ? [04:33:54] 5+ [04:35:04] ok bye gn [04:35:08] The idea is top 20 is a good cut-off from only taking number of tasks into consideration and the seriousness of the students in the competition [04:35:19] So don't worry about number of tasks [04:35:22] GN! [04:42:10] 10TechCom-RFC: Support PHP 7.4 preload - https://phabricator.wikimedia.org/T240775 (10Bawolff) Based on the description here, it sounds pretty impossible to use this with hetdeploy, so is this about third parties only? [05:00:54] Good mrng ! [05:02:03] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [extensions/WikEdDiff] - 10https://gerrit.wikimedia.org/r/557431 (owner: 10Libraryupgrader) [05:51:41] 10Android-app-Bugs, 10Mobile-Content-Service, 10Wikipedia-Android-App-Backlog: Map marker is misplaced when loading from MCS - https://phabricator.wikimedia.org/T176739 (10ABorbaWMF) Report from OTRS - https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=11258527 {F31476275} [05:54:32] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/WikiArticleFeeds] - 10https://gerrit.wikimedia.org/r/557432 (owner: 10Libraryupgrader) [06:24:19] (03PS1) 10DannyS712: Add `expectunusedtemplate` to filter Special:UnusedTemplates [core] - 10https://gerrit.wikimedia.org/r/557438 (https://phabricator.wikimedia.org/T184633) [06:29:34] (03PS2) 10DannyS712: Add `expectunusedtemplate` to filter Special:UnusedTemplates [core] - 10https://gerrit.wikimedia.org/r/557438 (https://phabricator.wikimedia.org/T184633) [06:35:56] (03PS5) 10DannyS712: SpecialUserrights: If a viewer lacks `hideuser`, ignore hidden users [core] - 10https://gerrit.wikimedia.org/r/556093 (https://phabricator.wikimedia.org/T232568) [06:41:09] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557438 (https://phabricator.wikimedia.org/T184633) (owner: 10DannyS712) [06:44:08] 10MediaWiki-Interface, 10MediaWiki-User-management, 10WorkType-NewFunctionality: Add a substitution parameter to Ipbreason-dropdown - https://phabricator.wikimedia.org/T21422 (10DannyS712) a:05DannyS712→03None This doesn't seem to be possible currently - the dropdown uses an `options-message`, and it is... [06:46:08] 10MediaWiki-API, 10Core Platform Team, 10User-DannyS712: Add module to get the list of all TrackingCategories - https://phabricator.wikimedia.org/T76290 (10DannyS712) @Anomie so to double check, just retrieve the name of the categories (as plain text)? [06:49:38] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/556093 (https://phabricator.wikimedia.org/T232568) (owner: 10DannyS712) [07:00:01] (03PS1) 10BryanDavis: Discard LdapAuthenticationPlugin->ldapconn after unbind [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/557444 (https://phabricator.wikimedia.org/T240734) [07:25:07] (03PS3) 10Ammarpad: Allow blocked admin to restore their talkpage if not blocked from it [core] - 10https://gerrit.wikimedia.org/r/555717 (https://phabricator.wikimedia.org/T238310) [07:29:52] (03CR) 10Ammarpad: Allow blocked admin to restore their talkpage if not blocked from it (032 comments) [core] - 10https://gerrit.wikimedia.org/r/555717 (https://phabricator.wikimedia.org/T238310) (owner: 10Ammarpad) [07:30:12] (03CR) 10Pwirth: [V: 03+2 C: 03+2] "re-poke" [extensions/BlueSpiceContextMenu] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557263 (owner: 10Robert Vogel) [07:31:39] (03CR) 10jerkins-bot: [V: 04-1] Fix missing covers for phpcs [extensions/BlueSpiceContextMenu] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557263 (owner: 10Robert Vogel) [07:36:08] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/555717 (https://phabricator.wikimedia.org/T238310) (owner: 10Ammarpad) [07:38:27] (03CR) 10Awight: Remove unchecked exception annotations (037 comments) [core] - 10https://gerrit.wikimedia.org/r/557194 (https://phabricator.wikimedia.org/T240672) (owner: 10Awight) [07:53:59] (03PS1) 10Pwirth: Fix missing public function doc for phpcs [extensions/BlueSpiceCategoryManager] (REL1_31) - 10https://gerrit.wikimedia.org/r/557454 [07:54:25] (03CR) 10Pwirth: [C: 03+2] Fix missing public function doc for phpcs [extensions/BlueSpiceCategoryManager] (REL1_31) - 10https://gerrit.wikimedia.org/r/557454 (owner: 10Pwirth) [07:54:49] (03Merged) 10jenkins-bot: Fix missing public function doc for phpcs [extensions/BlueSpiceCategoryManager] (REL1_31) - 10https://gerrit.wikimedia.org/r/557454 (owner: 10Pwirth) [08:02:45] (03PS1) 10Pwirth: Fix UnrecognizedAnnotation for phpcs [extensions/BlueSpiceAvatars] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557455 [08:03:10] (03PS1) 10Pwirth: Fix UnrecognizedAnnotation for phpcs [extensions/BlueSpiceAvatars] (REL1_31) - 10https://gerrit.wikimedia.org/r/557456 [08:03:13] (03CR) 10Pwirth: [C: 03+2] Fix UnrecognizedAnnotation for phpcs [extensions/BlueSpiceAvatars] (REL1_31) - 10https://gerrit.wikimedia.org/r/557456 (owner: 10Pwirth) [08:03:17] (03CR) 10Pwirth: [C: 03+2] Fix UnrecognizedAnnotation for phpcs [extensions/BlueSpiceAvatars] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557455 (owner: 10Pwirth) [08:06:02] (03Merged) 10jenkins-bot: Fix UnrecognizedAnnotation for phpcs [extensions/BlueSpiceAvatars] (REL1_31) - 10https://gerrit.wikimedia.org/r/557456 (owner: 10Pwirth) [08:06:04] (03CR) 10jerkins-bot: [V: 04-1] Fix UnrecognizedAnnotation for phpcs [extensions/BlueSpiceAvatars] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557455 (owner: 10Pwirth) [08:10:17] (03PS1) 10Pwirth: Fix missing docs, function scope declaration and lines to long for phpcs [extensions/BlueSpiceChecklist] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557457 [08:10:38] (03PS1) 10Pwirth: Fix missing docs, function scope declaration and lines to long for phpcs [extensions/BlueSpiceChecklist] (REL1_31) - 10https://gerrit.wikimedia.org/r/557458 [08:10:42] (03CR) 10Pwirth: [C: 03+2] Fix missing docs, function scope declaration and lines to long for phpcs [extensions/BlueSpiceChecklist] (REL1_31) - 10https://gerrit.wikimedia.org/r/557458 (owner: 10Pwirth) [08:10:47] (03CR) 10Pwirth: [C: 03+2] Fix missing docs, function scope declaration and lines to long for phpcs [extensions/BlueSpiceChecklist] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557457 (owner: 10Pwirth) [08:11:03] (03Merged) 10jenkins-bot: Fix missing docs, function scope declaration and lines to long for phpcs [extensions/BlueSpiceChecklist] (REL1_31) - 10https://gerrit.wikimedia.org/r/557458 (owner: 10Pwirth) [08:11:09] (03Merged) 10jenkins-bot: Fix missing docs, function scope declaration and lines to long for phpcs [extensions/BlueSpiceChecklist] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557457 (owner: 10Pwirth) [08:16:59] (03PS1) 10Amire80: Cleanup whitespace in i18n/api/en.json [extensions/Jade] - 10https://gerrit.wikimedia.org/r/557460 [08:18:23] (03PS1) 10Pwirth: Fix doc blocks, lines too long, assignments in controll structures for phpcs [extensions/BlueSpiceConfigManager] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557461 [08:19:02] (03CR) 10Pwirth: [C: 03+2] Fix doc blocks, lines too long, assignments in controll structures for phpcs [extensions/BlueSpiceConfigManager] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557461 (owner: 10Pwirth) [08:19:03] (03PS1) 10Pwirth: Fix doc blocks, lines too long, assignments in controll structures for phpcs [extensions/BlueSpiceConfigManager] (REL1_31) - 10https://gerrit.wikimedia.org/r/557462 [08:19:05] (03CR) 10Pwirth: [C: 03+2] Fix doc blocks, lines too long, assignments in controll structures for phpcs [extensions/BlueSpiceConfigManager] (REL1_31) - 10https://gerrit.wikimedia.org/r/557462 (owner: 10Pwirth) [08:19:07] (03CR) 10jerkins-bot: [V: 04-1] Fix doc blocks, lines too long, assignments in controll structures for phpcs [extensions/BlueSpiceConfigManager] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557461 (owner: 10Pwirth) [08:20:42] (03PS1) 10Pwirth: Fix missing doc blocks for phpcs [extensions/BlueSpiceCountThings] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557464 [08:20:45] (03Merged) 10jenkins-bot: Fix doc blocks, lines too long, assignments in controll structures for phpcs [extensions/BlueSpiceConfigManager] (REL1_31) - 10https://gerrit.wikimedia.org/r/557462 (owner: 10Pwirth) [08:20:53] (03CR) 10Pwirth: [C: 03+2] Fix missing doc blocks for phpcs [extensions/BlueSpiceCountThings] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557464 (owner: 10Pwirth) [08:22:49] (03PS1) 10Pwirth: Fix missing doc blocks for phpcs [extensions/BlueSpiceCountThings] (REL1_31) - 10https://gerrit.wikimedia.org/r/557465 [08:23:03] (03CR) 10Pwirth: [C: 03+2] Fix missing doc blocks for phpcs [extensions/BlueSpiceCountThings] (REL1_31) - 10https://gerrit.wikimedia.org/r/557465 (owner: 10Pwirth) [08:23:36] (03CR) 10jerkins-bot: [V: 04-1] Fix missing doc blocks for phpcs [extensions/BlueSpiceCountThings] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557464 (owner: 10Pwirth) [08:24:34] (03CR) 10jerkins-bot: [V: 04-1] Fix missing doc blocks for phpcs [extensions/BlueSpiceCountThings] (REL1_31) - 10https://gerrit.wikimedia.org/r/557465 (owner: 10Pwirth) [08:25:33] (03CR) 10Pwirth: [V: 03+2 C: 03+2] Fix missing doc blocks for phpcs [extensions/BlueSpiceCountThings] (REL1_31) - 10https://gerrit.wikimedia.org/r/557465 (owner: 10Pwirth) [08:25:45] (03CR) 10Pwirth: [V: 03+2 C: 03+2] Fix missing doc blocks for phpcs [extensions/BlueSpiceCountThings] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557464 (owner: 10Pwirth) [08:25:52] (03CR) 10Pwirth: [V: 03+2 C: 03+2] Fix UnrecognizedAnnotation for phpcs [extensions/BlueSpiceAvatars] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557455 (owner: 10Pwirth) [08:26:00] (03CR) 10Pwirth: [V: 03+2 C: 03+2] Fix doc blocks, lines too long, assignments in controll structures for phpcs [extensions/BlueSpiceConfigManager] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557461 (owner: 10Pwirth) [08:27:42] (03CR) 10DannyS712: [C: 03+1] "Looks good" [extensions/Jade] - 10https://gerrit.wikimedia.org/r/557460 (owner: 10Amire80) [08:45:48] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [extensions/googleAnalytics] - 10https://gerrit.wikimedia.org/r/557470 (owner: 10Libraryupgrader) [08:51:00] (03CR) 10Mainframe98: "Icb3014b8fe7d1c43e64a37e0bdaaffec18bb482f removed assertType, and PHPUnit 7 introduces even better assertions that fit perfectly within th" (0315 comments) [core] - 10https://gerrit.wikimedia.org/r/535280 (owner: 10Pmiazga) [08:59:18] (03CR) 10Raimond Spekking: [C: 03+2] Cleanup whitespace in i18n/api/en.json [extensions/Jade] - 10https://gerrit.wikimedia.org/r/557460 (owner: 10Amire80) [09:01:29] (03PS8) 10DannyS712: Convent series of single-statement ifs to loop [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/537580 [09:02:50] (03Merged) 10jenkins-bot: Cleanup whitespace in i18n/api/en.json [extensions/Jade] - 10https://gerrit.wikimedia.org/r/557460 (owner: 10Amire80) [09:03:01] 10MediaWiki-General, 10Core Platform Team, 10I18n, 10Patch-For-Review, 10User-DannyS712: Add target link to MediaWiki:Articleexists - https://phabricator.wikimedia.org/T184357 (10DannyS712) Would core platform team be willing to take a look at the provided patch? [09:04:06] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/537580 (owner: 10DannyS712) [09:09:35] 10Wiktionary: bug found in searching words on Minangkabau Wiktionary - https://phabricator.wikimedia.org/T240778 (10Harditaher) [09:11:22] 10Wikidocumentaries: Map tasks - https://phabricator.wikimedia.org/T213284 (10Susannaanas) [09:12:11] 10Wikidocumentaries: Map APIs - https://phabricator.wikimedia.org/T230182 (10Susannaanas) [09:22:30] 10MediaWiki-extensions-CentralAuth, 10GlobalRename, 10Operations: Global renames are really slow - https://phabricator.wikimedia.org/T240518 (10Urbanecm) I just spent a few hours going through Grafana and found https://grafana.wikimedia.org/d/000000400/jobqueue-eventbus?orgId=1&fullscreen&panelId=15&from=now... [09:23:19] 10MediaWiki-extensions-CentralAuth, 10GlobalRename, 10Operations: Job queue seems to be processed slowly than expected - https://phabricator.wikimedia.org/T240518 (10Urbanecm) [09:25:03] (03Abandoned) 10Ankita2503: Changed the version in controller file` [extensions/examples] - 10https://gerrit.wikimedia.org/r/556796 (owner: 10Ankita2503) [09:26:54] 10Wikidocumentaries: Map APIs - https://phabricator.wikimedia.org/T230182 (10Susannaanas) [09:28:11] 10Wikidocumentaries: Map APIs - https://phabricator.wikimedia.org/T230182 (10Susannaanas) [09:28:46] 10Wikidocumentaries: Map APIs - https://phabricator.wikimedia.org/T230182 (10Susannaanas) [09:30:13] 04(no projects): enwiki {{Infobox park}} has map marker placed wrong - https://phabricator.wikimedia.org/T240779 (10SilverbackNet) [09:34:48] 10Wiktionary, 10Discovery-Search (Current work): bug found in searching words on Minangkabau Wiktionary - https://phabricator.wikimedia.org/T240778 (10Amire80) This is similar to T27682, from nine years ago. A lot has changed since then in the search infrastructure, but search is still sometimes broken in new... [09:40:35] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Remove / from names of files in extension.json [extensions/Tabber] - 10https://gerrit.wikimedia.org/r/557332 (owner: 10Zoranzoki21) [09:43:07] 10Wikidocumentaries: Add new APIs - https://phabricator.wikimedia.org/T210302 (10Susannaanas) [09:43:09] 10Wikidocumentaries: Map APIs - https://phabricator.wikimedia.org/T230182 (10Susannaanas) [09:43:11] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] Fix documentation for exception thrown (031 comment) [core] - 10https://gerrit.wikimedia.org/r/557233 (owner: 10Awight) [09:43:45] (03Merged) 10jenkins-bot: Remove / from names of files in extension.json [extensions/Tabber] - 10https://gerrit.wikimedia.org/r/557332 (owner: 10Zoranzoki21) [09:43:55] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Cleanup: const access [core] - 10https://gerrit.wikimedia.org/r/557228 (owner: 10Awight) [09:44:58] 10MediaWiki-extensions-OAuth, 10I18n, 10Voice & Tone: [[MediaWiki:Mwoauth-consumer-developer-agreement/sv]] translation issue - https://phabricator.wikimedia.org/T230753 (10Amire80) 05Open→03Resolved a:03Amire80 Thanks for the question. It's app, software. I updated the documentation. [09:49:51] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] Document exceptions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/557196 (owner: 10Awight) [09:50:54] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Fix handling of filetimestamp request parameter [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/557129 (owner: 10Umherirrender) [09:52:56] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Use correct default on WebRequest::getArray [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/557124 (owner: 10Umherirrender) [09:53:26] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Use User::getBoolOption [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/557123 (owner: 10Umherirrender) [09:53:55] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Use WebRequest::getInt for limit parameter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/557119 (owner: 10Umherirrender) [09:54:27] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Remove wrong default value from WebRequest::getVal call [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/557121 (owner: 10Umherirrender) [09:55:39] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Use string default on WebRequest::getVal [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/557130 (owner: 10Umherirrender) [09:55:56] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Use WebRequest::getBool to have bool cast [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/557125 (owner: 10Umherirrender) [09:56:08] (03CR) 10Fomafix: Update setlang to display confirmation dialog to change language (031 comment) [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/551940 (https://phabricator.wikimedia.org/T63115) (owner: 10Abijeet Patro) [09:56:37] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Fix doc of WikiHiero::resizeGlyph [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/557112 (owner: 10Umherirrender) [09:57:25] (03Merged) 10jenkins-bot: Cleanup: const access [core] - 10https://gerrit.wikimedia.org/r/557228 (owner: 10Awight) [09:57:27] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/557491 (owner: 10Libraryupgrader) [09:57:29] (03Merged) 10jenkins-bot: Fix handling of filetimestamp request parameter [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/557129 (owner: 10Umherirrender) [09:57:33] (03Merged) 10jenkins-bot: Use correct default on WebRequest::getArray [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/557124 (owner: 10Umherirrender) [09:57:35] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Add missing float cast [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/557111 (owner: 10Umherirrender) [09:59:53] 10Wikidocumentaries: Wikimedia Commons API call - https://phabricator.wikimedia.org/T223679 (10Susannaanas) [10:01:26] (03PS1) 10Amire80: Remove an unnecessary < char from a message [extensions/Jade] - 10https://gerrit.wikimedia.org/r/557492 [10:02:15] (03PS1) 10Amire80: Add a missing period in a message [extensions/Jade] - 10https://gerrit.wikimedia.org/r/557493 [10:06:50] (03Merged) 10jenkins-bot: Use User::getBoolOption [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/557123 (owner: 10Umherirrender) [10:06:52] (03Merged) 10jenkins-bot: Use WebRequest::getInt for limit parameter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/557119 (owner: 10Umherirrender) [10:06:54] (03Merged) 10jenkins-bot: Remove wrong default value from WebRequest::getVal call [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/557121 (owner: 10Umherirrender) [10:06:56] (03Merged) 10jenkins-bot: Use string default on WebRequest::getVal [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/557130 (owner: 10Umherirrender) [10:06:58] (03Merged) 10jenkins-bot: Use WebRequest::getBool to have bool cast [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/557125 (owner: 10Umherirrender) [10:07:00] (03Merged) 10jenkins-bot: Fix doc of WikiHiero::resizeGlyph [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/557112 (owner: 10Umherirrender) [10:07:02] (03Merged) 10jenkins-bot: Add missing float cast [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/557111 (owner: 10Umherirrender) [10:14:40] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/557495 (owner: 10Libraryupgrader) [10:17:30] (03CR) 10Umherirrender: [C: 03+1] MessagesDe.php: Add aliases for special pages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/556227 (owner: 10Tobi 406) [10:20:17] (03PS1) 10Urbanecm: CheckUserLog: Make IPs links [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/557500 (https://phabricator.wikimedia.org/T240781) [10:21:02] (03CR) 10Umherirrender: "recheck" [extensions/WebToolsManager] - 10https://gerrit.wikimedia.org/r/557425 (owner: 10Libraryupgrader) [10:21:07] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/557499 (owner: 10Libraryupgrader) [10:21:26] (03CR) 10Umherirrender: "recheck" [skins/Material] - 10https://gerrit.wikimedia.org/r/557490 (owner: 10Libraryupgrader) [10:22:04] (03CR) 10Umherirrender: [V: 03+2] build: Updating grunt-banana-checker to 0.8.1 [extensions/SectionDisqus] - 10https://gerrit.wikimedia.org/r/557283 (owner: 10Libraryupgrader) [10:22:20] 10wikidiff2: Wikidiff2 makes apache2 crash - https://phabricator.wikimedia.org/T240620 (10Jona) I have used wikidiff2 from the source (wikidiff2-1.10.0.tar.gz) and I don't have the crash anymore. I will see if I can install the same setting on a test server. [10:22:58] (03CR) 10Umherirrender: [V: 03+2] build: Updating grunt-banana-checker to 0.8.1 [extensions/SelectCategory] - 10https://gerrit.wikimedia.org/r/557288 (owner: 10Libraryupgrader) [10:25:31] (03CR) 10Umherirrender: [C: 03+2] build: Updating npm dependencies [extensions/WebToolsManager] - 10https://gerrit.wikimedia.org/r/557425 (owner: 10Libraryupgrader) [10:25:36] (03CR) 10Umherirrender: [C: 03+2] build: Updating grunt-banana-checker to 0.8.1 [skins/Material] - 10https://gerrit.wikimedia.org/r/557490 (owner: 10Libraryupgrader) [10:25:54] (03CR) 10Umherirrender: [V: 03+2] build: Updating grunt-banana-checker to 0.8.1 [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/557499 (owner: 10Libraryupgrader) [10:26:25] (03CR) 10Umherirrender: [V: 03+2] build: Updating grunt-banana-checker to 0.8.1 [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/557491 (owner: 10Libraryupgrader) [10:28:11] (03CR) 10Umherirrender: [V: 03+2] build: Updating grunt-banana-checker to 0.8.1 [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/557313 (owner: 10Libraryupgrader) [10:28:44] (03CR) 10Umherirrender: [V: 03+2] build: Updating grunt-banana-checker to 0.8.1 [extensions/SimpleFarm] - 10https://gerrit.wikimedia.org/r/557316 (owner: 10Libraryupgrader) [10:29:36] (03CR) 10Umherirrender: [V: 03+2] build: Updating grunt-banana-checker to 0.8.1 [extensions/SiteMetrics] - 10https://gerrit.wikimedia.org/r/557324 (owner: 10Libraryupgrader) [10:30:02] (03CR) 10Umherirrender: [V: 03+2] build: Updating grunt-banana-checker to 0.8.1 [extensions/SiteScout] - 10https://gerrit.wikimedia.org/r/557326 (owner: 10Libraryupgrader) [10:30:39] (03CR) 10Umherirrender: [V: 03+2] build: Updating grunt-banana-checker to 0.8.1 [extensions/SkinPerNamespace] - 10https://gerrit.wikimedia.org/r/557327 (owner: 10Libraryupgrader) [10:31:03] (03CR) 10Umherirrender: [V: 03+2] build: Updating grunt-banana-checker to 0.8.1 [extensions/SocialLogin] - 10https://gerrit.wikimedia.org/r/557333 (owner: 10Libraryupgrader) [10:31:19] (03CR) 10Umherirrender: [V: 03+2] build: Updating grunt-banana-checker to 0.8.1 [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/557335 (owner: 10Libraryupgrader) [10:31:43] (03CR) 10Umherirrender: [V: 03+2] build: Updating grunt-banana-checker to 0.8.1 [extensions/SoftwareVersion] - 10https://gerrit.wikimedia.org/r/557336 (owner: 10Libraryupgrader) [10:31:53] (03CR) 10DannyS712: CheckUserLog: Make IPs links (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/557500 (https://phabricator.wikimedia.org/T240781) (owner: 10Urbanecm) [10:32:03] (03PS1) 10AlexPinchuk: SecondaryDataUpdates hook [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557504 [10:32:12] (03CR) 10Umherirrender: [V: 03+2] build: Updating grunt-banana-checker to 0.8.1 [extensions/SplitPrivateWiki] - 10https://gerrit.wikimedia.org/r/557348 (owner: 10Libraryupgrader) [10:32:35] (03CR) 10Umherirrender: [V: 03+2] build: Updating grunt-banana-checker to 0.8.1 [extensions/StickToThatLanguage] - 10https://gerrit.wikimedia.org/r/557354 (owner: 10Libraryupgrader) [10:32:37] (03PS2) 10Urbanecm: CheckUserLog: Make IPs links [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/557500 (https://phabricator.wikimedia.org/T240781) [10:32:41] (03CR) 10Urbanecm: CheckUserLog: Make IPs links (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/557500 (https://phabricator.wikimedia.org/T240781) (owner: 10Urbanecm) [10:32:47] (03PS2) 10AlexPinchuk: SecondaryDataUpdates hook [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557504 [10:32:52] (03CR) 10Umherirrender: [V: 03+2] build: Updating grunt-banana-checker to 0.8.1 [extensions/Survey] - 10https://gerrit.wikimedia.org/r/557361 (owner: 10Libraryupgrader) [10:33:27] (03CR) 10Umherirrender: [V: 03+2] build: Updating grunt-banana-checker to 0.8.1 [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/557395 (owner: 10Libraryupgrader) [10:33:49] (03CR) 10Umherirrender: [V: 03+2] build: Updating grunt-banana-checker to 0.8.1 [extensions/googleAnalytics] - 10https://gerrit.wikimedia.org/r/557470 (owner: 10Libraryupgrader) [10:34:00] (03CR) 10DannyS712: [C: 04-1] "The manual checking for system users should user `User::isSystemUser` instead (added in I73f25a10df2c28a69f612eb1db3e91b7125383d9)" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/479457 (https://phabricator.wikimedia.org/T211760) (owner: 10Melos) [10:34:28] (03CR) 10Umherirrender: [V: 03+2] build: Updating dependencies [extensions/WikiArticleFeeds] - 10https://gerrit.wikimedia.org/r/557432 (owner: 10Libraryupgrader) [10:34:51] (03CR) 10Umherirrender: [V: 03+2] build: Updating grunt-banana-checker to 0.8.1 [extensions/WikEdDiff] - 10https://gerrit.wikimedia.org/r/557431 (owner: 10Libraryupgrader) [10:35:16] (03CR) 10Umherirrender: [V: 03+2] build: Updating grunt-banana-checker to 0.8.1 [extensions/VikiSemanticTitle] - 10https://gerrit.wikimedia.org/r/557417 (owner: 10Libraryupgrader) [10:35:45] (03CR) 10Umherirrender: [V: 03+2] build: Updating grunt-banana-checker to 0.8.1 [extensions/UserPageViewTracker] - 10https://gerrit.wikimedia.org/r/557413 (owner: 10Libraryupgrader) [10:36:06] (03CR) 10Umherirrender: [V: 03+2] build: Updating grunt-banana-checker to 0.8.1 [extensions/UploadLogo] - 10https://gerrit.wikimedia.org/r/557403 (owner: 10Libraryupgrader) [10:38:32] (03PS1) 10Pwirth: Fix doc blocks and php4 style constructor for phpcs [extensions/BlueSpicePrivacy] - 10https://gerrit.wikimedia.org/r/557505 [10:40:18] (03CR) 10DannyS712: [C: 03+1] "Looks good" [extensions/Jade] - 10https://gerrit.wikimedia.org/r/557493 (owner: 10Amire80) [10:40:31] (03CR) 10DannyS712: [C: 03+1] "Looks good" [extensions/Jade] - 10https://gerrit.wikimedia.org/r/557492 (owner: 10Amire80) [10:45:50] (03CR) 10Urbanecm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/555772 (https://phabricator.wikimedia.org/T45463) (owner: 10Apap04) [10:48:30] (03CR) 10Urbanecm: [C: 03+1] Document message "echo-blacklist" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/557063 (owner: 10Raimond Spekking) [10:52:24] 10Cleanup: Clean up traces of archived extensions and skins - https://phabricator.wikimedia.org/T201251 (10Aklapper) This feels very related to T212994 about SVN extensions to be archived. [10:54:01] 10MediaWiki-Revision-backend, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review: Allow content blobs to be marked as broken in the content table - https://phabricator.wikimedia.org/T240686 (10DannyS712) [11:08:50] 10ContentTranslation: Too wide text goes under sidebar or translation column - https://phabricator.wikimedia.org/T240782 (10Nnvu) [11:09:08] 10MediaWiki-Documentation, 10Documentation: Formalise documentation about extensions hosted in Gerrit not being WMF responsibility - https://phabricator.wikimedia.org/T195767 (10Aklapper) @Reedy: Before anyone could "formalize documentation", you'd first have to define criteria which allow identifying code rep... [11:12:22] 10Wiktionary, 10Discovery-Search (Current work): "We could not complete your search due to a temporary problem." searching words on Minangkabau Wiktionary - https://phabricator.wikimedia.org/T240778 (10Aklapper) [11:12:28] 10Discovery-Search (Current work): "We could not complete your search due to a temporary problem." searching words on Minangkabau Wiktionary - https://phabricator.wikimedia.org/T240778 (10Aklapper) Removing #Wiktionary tag; please see its description: "Please do not report language specific tasks under this proj... [11:24:40] 10Cleanup: Empty Gerrit repository /mediawiki/extensions/PopupAlerts - https://phabricator.wikimedia.org/T240783 (10Aklapper) [11:24:44] 10Cleanup: Empty Gerrit repository /mediawiki/extensions/PreferencesMaster - https://phabricator.wikimedia.org/T240784 (10Aklapper) [11:24:46] 10Cleanup: Empty Gerrit repository /mediawiki/extensions/MusicBrainzAuth - https://phabricator.wikimedia.org/T240785 (10Aklapper) [11:26:53] 10Cleanup: Empty Gerrit repository /mediawiki/extensions/FileSystemImageServer - https://phabricator.wikimedia.org/T240786 (10Aklapper) [11:28:52] 10Cleanup: Empty Gerrit repository /mediawiki/extensions/ConfigurableCounters - https://phabricator.wikimedia.org/T240787 (10Aklapper) [11:31:41] 10Cleanup: Empty Gerrit repository /mediawiki/extensions/BlueSpiceMenues - https://phabricator.wikimedia.org/T240788 (10Aklapper) [11:48:33] 10Cleanup: Empty Gerrit repository /mediawiki/extensions/MusicBrainzAuth - https://phabricator.wikimedia.org/T240785 (10Legoktm) See https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MusicBrainzAuth/+/453928 it's blocked on a core patch for the tests, but I could probably disable that tbh. [11:56:41] 10Cleanup: Empty Gerrit repository /mediawiki/extensions/MusicBrainzAuth - https://phabricator.wikimedia.org/T240785 (10Aklapper) 05Open→03Invalid Ah, thanks. I should have taken a look at Gerrit I guess, sorry :-/ [12:06:50] (03PS1) 10Jack Phoenix: ShoutWiki changes -- extension registration support, modernization, etc. [extensions/AbuseFilterBypass] - 10https://gerrit.wikimedia.org/r/557518 [12:07:43] (03CR) 10Jack Phoenix: [V: 03+2 C: 03+2] ShoutWiki changes -- extension registration support, modernization, etc. [extensions/AbuseFilterBypass] - 10https://gerrit.wikimedia.org/r/557518 (owner: 10Jack Phoenix) [12:12:11] 10TechCom-RFC: Support PHP 7.4 preload - https://phabricator.wikimedia.org/T240775 (10Florian) @Bawolff Hot deploying is complicated, but it really depends on what you want to pre-load and what not. If you, e.g., focus on deploying config changes only, then you can exclude the configuration paths from pre-loadin... [12:18:37] 10Inuka-Team (Kanban): Responsive Styling - https://phabricator.wikimedia.org/T240790 (10hueitan) [12:18:52] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Responsive Styling - https://phabricator.wikimedia.org/T240790 (10hueitan) [12:20:14] (03PS3) 10Alcarazzam: docs: convert pageupdater and sitelist to markdown [core] - 10https://gerrit.wikimedia.org/r/555938 [12:21:18] (03CR) 10Alcarazzam: "> Uploaded patch set 3." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/555938 (owner: 10Alcarazzam) [12:30:57] 10TechCom-RFC: Support PHP 7.4 preload - https://phabricator.wikimedia.org/T240775 (10Bawolff) > What I see as the biggest "blocker" for this to be used on wmf infrastructure, would be the fact, that you can not preload separate files which define the same class names or functions (as they would conflict obvious... [12:39:09] 10OABot: Catch exception for Dissemin papers without expected author names - https://phabricator.wikimedia.org/T233715 (10Nemo_bis) [12:39:12] 10OABot: Fails on Pseudo-nitzschia australis - https://phabricator.wikimedia.org/T232350 (10Nemo_bis) [12:42:44] 10OABot: Catch exception for Dissemin papers without expected author names - https://phabricator.wikimedia.org/T233715 (10Nemo_bis) Yes, you are right. I was not being particular about the fix, I just lacked motivation as long as the queue of suggestions ran in the tens of thousands for months. Now I'm working o... [12:47:04] 10Discovery-Search, 10Wikimedia-General-or-Unknown: "We could not complete your search due to a temporary problem." searching words on Minangkabau Wiktionary - https://phabricator.wikimedia.org/T240778 (10Reedy) >>! In T240778#5742268, @Amire80 wrote: > This is similar to T27682, from nine years ago. A lot has... [13:03:06] (03PS1) 10Jack Phoenix: Convert to JSON i18n [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557520 [13:03:45] (03CR) 10Jack Phoenix: [V: 03+2 C: 03+2] Convert to JSON i18n [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557520 (owner: 10Jack Phoenix) [13:05:01] 10TechCom-RFC: Support PHP 7.4 preload - https://phabricator.wikimedia.org/T240775 (10Florian) You're right, even if the same name is used from another version of the same application, the preloading class "wins" and may result in incompatibilities of the application code :/ [13:05:09] (03PS1) 10Jack Phoenix: Add special page alias file to make special page name translatable [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557521 [13:05:33] Can anyone help me out with this? $ git review -R [13:05:34] remote: Unauthorized [13:05:34] fatal: Authentication failed for 'https://gerrit.wikimedia.org/r/sandbox/' [13:05:38] (03CR) 10Jack Phoenix: [V: 03+2 C: 03+2] Add special page alias file to make special page name translatable [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557521 (owner: 10Jack Phoenix) [13:06:32] 10MediaWiki-extensions-Translate, 10translatewiki.net, 10Language-Team (Language-2019-October-December), 10Patch-For-Review, 10User-abi_: Migrate existing projects to use the new Validator framework - https://phabricator.wikimedia.org/T224025 (10abi_) [13:06:54] ComputerGuy: Are you using the right password? The password for https gerrit access is not your normal password [13:06:56] Hello ComputerGuy [13:07:34] ComputerGuy: Recheck your user credentials username and password. [13:07:36] Most people use ssh instead of https (either is fine, just keep in mind most instructions are for ssh. Although I have no idea which protocol the gci instructions are for) [13:08:14] (03PS1) 10Jack Phoenix: Lots and lots of changes to make this undead extension work again... [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557522 [13:08:32] Anyways, for https you have to use the password listed in gerrit settings under "http password", which is different from your general gerrit password [13:08:42] bawolff: it just links to our MW.org tutorial, see https://codein.withgoogle.com/tasks/6593457234116608/ [13:09:16] Thank you bawolff. But one question? How to change the credentials? [13:10:26] Yeah, the instructions that gci links to is for ssh not https pushes, so there is possibly some confusion there [13:10:47] ComputerGuy: So for password you should be prompted [13:10:56] (03PS1) 10Urbanecm: Remove test.txt [sandbox] - 10https://gerrit.wikimedia.org/r/557524 [13:11:04] ComputerGuy: For username, I am not sure if this is the best way, but you can do: [13:11:06] (03Abandoned) 10Urbanecm: Remove test.txt [sandbox] - 10https://gerrit.wikimedia.org/r/557524 (owner: 10Urbanecm) [13:11:07] git config -e [13:11:13] Which edits your git config [13:11:28] There's a part that says url = [13:11:36] bawolff: shouldn't git prompt for username too? [13:11:37] under the header [13:11:39] [remote "origin"] [13:12:06] Change the url to be https://USERNAMEHERE@gerrit.wikimedia.org/r/sandbox/ [13:12:10] replacing USERNAMEHERE [13:12:36] with your gerrit shell name [13:13:13] Urbanecm: I have no idea actually, I haven't used https as the push method in a long time. I think it defaults to just your unix username on the current host [13:13:19] (03CR) 10Raimond Spekking: [C: 03+2] Remove an unnecessary < char from a message [extensions/Jade] - 10https://gerrit.wikimedia.org/r/557492 (owner: 10Amire80) [13:13:26] 10TechCom-RFC: Support PHP 7.4 preload - https://phabricator.wikimedia.org/T240775 (10Florian) > so is this about third parties only? To answer thi question: It seems, that with the current implementation of preloading in php, it is incompatible to the requirements and implementation of the wmf deployment, yes. [13:13:43] Ok bawolff, I will do it. [13:13:45] bawolff: I just checked, and it does prompt [13:14:05] not sure if this is what you meant bawolff? https://usercontent.irccloud-cdn.com/file/CiyuPHUH/image.png [13:14:22] ComputerGuy: Part of the confusion, is that tutorial is assuming you cloned with the command git clone ssh://YOURSHELLNAME@gerrit.wikimedia.org:29418/sandbox.git [13:15:19] Urbanecm: Hmm, that's not a syntax I've seen before. Usually I see the url username syntax which uses the @ sign [13:15:46] yeah, maybe my client messed up your instructions [13:15:47] https://usercontent.irccloud-cdn.com/file/tS6RlMiZ/image.png [13:16:09] Im now getting this one. No '.gitreview' file found in this repository. We don't know where [13:16:10] your gerrit is. [13:16:10] Please manually create a remote named "origin" or rename the default [13:16:10] one and try again. [13:16:46] Urbanecm: Oh, that's probably anti-phising. Its a common phising attack to make urls of the form https://somewhere.com@evil.com to trick people into thinking that somewhere.com is where they are going to [13:16:53] (03Merged) 10jenkins-bot: Remove an unnecessary < char from a message [extensions/Jade] - 10https://gerrit.wikimedia.org/r/557492 (owner: 10Amire80) [13:17:18] ComputerGuy: Can you put the contents of "git config -l" (no quotes) in a pastebin? [13:18:23] bawolff: interesting, never saw that before [13:19:25] Anyways to be clear, for anyone using irccloud, the syntax is https:// followed by username followed by an @ sign followed by the rest of the url (e.g. examples at https://en.wikipedia.org/wiki/Uniform_Resource_Identifier#Examples ) [13:19:44] (03PS2) 10Jack Phoenix: Lots and lots of changes to make this undead extension work again... [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557522 [13:20:54] (03CR) 10Jack Phoenix: [V: 03+2 C: 03+2] Lots and lots of changes to make this undead extension work again... [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557522 (owner: 10Jack Phoenix) [13:21:01] Urbanecm: Some web browsers stopped supporting it because it was basically only used for phising (also recording your password inside a url is bad for security, which it kind of encourage, as the full syntax is https:// : @ rest of url), so its kind of fallen out of favour [13:21:30] (03CR) 10Zoranzoki21: "Looks cool!" [core] - 10https://gerrit.wikimedia.org/r/555938 (owner: 10Alcarazzam) [13:21:34] (03CR) 10Zoranzoki21: "recheck" [core] - 10https://gerrit.wikimedia.org/r/555938 (owner: 10Alcarazzam) [13:24:18] ComputerGuy: Your DCC send didn't work for me. Just use https://dpaste.org/ [13:25:02] hmm, the dcc send said it was from ip 0.0.0.0, which is obviously not right, but not sure i'm doing something wrong because i've never actually used dcc [13:26:50] bawolff: https://dpaste.org/gj1G [13:27:07] Sorry I don't know how to use it. [13:27:27] (03PS1) 10Amire80: Make JSON whitespace consistent in API messages [extensions/Jade] - 10https://gerrit.wikimedia.org/r/557529 [13:27:42] ComputerGuy: Was that inside the directory where you cloned "sandbox"? [13:27:55] Yes [13:28:18] As that looks like the global config, but not the config for a git repo [13:28:57] I left this part out : https://dpaste.org/F8z5 [13:29:23] (03CR) 10Daimona Eaytoy: Add a base class for parser transition (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/553794 (owner: 10Daimona Eaytoy) [13:29:59] (03PS4) 10Daimona Eaytoy: Add a base class for parser transition [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/553794 [13:30:05] I didn't see that : in the terminal. When I pressed entered, it went on till (END) [13:30:27] (03PS13) 10Daimona Eaytoy: Upgrade to PHPUnit 8 [core] - 10https://gerrit.wikimedia.org/r/552312 (https://phabricator.wikimedia.org/T192167) [13:30:43] ah yeah, git likes piping through less. If you want it to not do that you can add "| cat" to the end of the command [13:30:51] ok, i think the line [13:30:54] remote.https://computer-guy@gerrit.wikimedia.org/r/sandbox/.url=https://gerrit.wikimedia.org/r/sandbox [13:30:59] should be [13:31:37] remote.origin.url=https://computer-guy@gerrit.wikimedia.org/r/sandbox/ [13:32:27] and [13:32:29] remote.https://computer-guy@gerrit.wikimedia.org/r/sandbox/.fetch=+refs/heads/*:refs/remotes/origin/* [13:32:32] should be [13:32:44] remote.origin.fetch=+refs/heads/*:refs/remotes/origin/* [13:33:09] Which you should be able to edit with git config -e [13:33:41] 10OABot: Catch exception for Dissemin papers without expected author names - https://phabricator.wikimedia.org/T233715 (10Nemo_bis) 05Open→03Resolved a:03Nemo_bis [13:36:45] bawolff: When I put "git config -e", I was able to see only this https://dpaste.org/FgFT [13:36:54] 10MediaWiki-extensions-Other, 10User-Zoranzoki21: Convert CreateAPage to use extension registration - https://phabricator.wikimedia.org/T240791 (10Zoranzoki21) [13:37:19] (03PS1) 10Zoranzoki21: Convert CreateAPage to use extension registration [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557533 (https://phabricator.wikimedia.org/T240791) [13:37:35] yeah, git config works in a slightly different format [13:37:39] Change [13:37:48] [remote "https://computer-guy@gerrit.wikimedia.org/r/sandbox/"] [13:37:49] to [13:37:56] [remote "origin"] [13:38:03] And then inside that section change [13:38:03] 10OABot: OAbot crashes and requires a restart - https://phabricator.wikimedia.org/T233437 (10Nemo_bis) 05Open→03Resolved a:03Nemo_bis The errors in the task description happened even after the fix for T216170. This has not happened in a while, although there was some usage. I'm tentatively considering it r... [13:38:10] url = https://gerrit.wikimedia.org/r/sandbox [13:38:12] to [13:38:22] url = https://computer-guy@gerrit.wikimedia.org/r/sandbox [13:38:38] and save [13:39:15] (03PS2) 10Daimona Eaytoy: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/557495 (owner: 10Libraryupgrader) [13:40:28] (03PS1) 10ComputerGuy: GCI: Google Code-In Task [sandbox] - 10https://gerrit.wikimedia.org/r/557534 [13:40:30] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [sandbox] - 10https://gerrit.wikimedia.org/r/557534 (owner: 10ComputerGuy) [13:41:22] Thank you bawolff! I did my first commit! [13:41:54] Yay! [13:41:58] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/552312 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [13:44:09] (03PS1) 10Zoranzoki21: Move some PHP files into the directories. [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557536 [13:44:46] Congrats! [13:45:10] :-) [13:45:25] (03CR) 10Ebe123: [V: 03+2 C: 03+2] GCI: Google Code-In Task [sandbox] - 10https://gerrit.wikimedia.org/r/557534 (owner: 10ComputerGuy) [13:50:34] (03CR) 10Jack Phoenix: [C: 04-2] "Thanks for the patch! Alas, I'm pretty sure the AJAX stuff ($wgAjaxExportList) won't work, as IIRC core *intentionally* decided _not_ to s" [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557533 (https://phabricator.wikimedia.org/T240791) (owner: 10Zoranzoki21) [13:52:08] (03PS1) 10Zoranzoki21: Create composer.json with default settings. [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557539 [13:53:00] (03PS1) 10Zoranzoki21: Auto-fix of errors found with first run of composer test [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557541 [13:55:06] (03PS14) 10Daimona Eaytoy: Upgrade to PHPUnit 8 [core] - 10https://gerrit.wikimedia.org/r/552312 (https://phabricator.wikimedia.org/T192167) [13:59:58] The more I see feedback on IRC from beginners about our Gerrit tutorial, the more I realize how horrible it is. [14:00:09] (03PS2) 10Zoranzoki21: Move some PHP files into the directories. [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557536 [14:00:14] * andre__ going to rewrite a bit, as every other year. sigh [14:01:28] All our tutorials are pretty horrible [14:01:34] (03PS2) 10Zoranzoki21: Create composer.json with default settings. [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557539 [14:01:46] They have too much detail about things that don't matter and not enough detail on the things that do [14:02:24] Also for most topics, there are like 5 different conflicting tutorials [14:03:11] I like the simple https://www.mediawiki.org/wiki/Gerrit/Tutorial/tl;dr [14:03:37] But it does assume everything is set-up [14:04:03] And everyone has a different idea of what's best (e.g. If it were up to me, I would kill all mention of git-review. I know everyone seems to love it, but i don't actually understand what it simplifies, and it seems more complex then just not using it) [14:04:23] And similarly, I would never mention vagrant ever again [14:04:34] bawolff, indeed. The current one mixes a How-To (get stuff done without understanding what you're doing), a Tutorial (explain one specific concept in depth), and an Essay (random historical background stuff that nobody needs) [14:05:50] There are still too many random "Note"s in there. I wonder whether to intent them, to make the basic stuff more readable. Well, I guess I'm going to continue later tonight, already edited that page for two hours now [14:06:08] Hmm, I have no idea how I'm supposed to do stuff without git-review, interesting :) [14:06:29] git push origin HEAD:refs/for/review [14:06:31] ! [14:06:31] Hello, I'm wm-bot. The database for this channel is published at http://wm-bot.wmflabs.org/db/%23mediawiki.htm More about WM-Bot: https://meta.wikimedia.org/wiki/wm-bot [14:06:46] Never knew [14:06:49] bawolff: uh! That makes sense, indeed [14:06:52] I mean, that's a bit of a mouthful, but just combine it with an alias, and you're all set [14:07:51] That's the beautiful thing about Gerrit tutorial questions from GCI folks: I learn where I've become blind already after years of git/gerrit... [14:08:22] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/552312 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [14:08:37] (03CR) 10Legoktm: [C: 03+2] build: Updating mediawiki/minus-x to 0.3.2 [wikimedia/textcat] - 10https://gerrit.wikimedia.org/r/557532 (owner: 10Libraryupgrader) [14:09:14] bawolff: how would i do git review -d ? [14:09:37] But yeah, if we make the instructions to basically be. Run `git config --global alias.submit 'git push origin HEAD:refs/for/master'` once, and then after that just do `git submit` anytime you want to submit something, i think it's simpler than git review [14:09:54] Urbanecm: For that I usually just copy the snippet from the gerrit interface [14:10:12] i see [14:10:15] which is needlessly complicated, but on the other hand, if I'm copying and pasting, what does it matter [14:11:13] So you end up with things (copied from the download button in top right) like [14:11:16] git fetch "ssh://bawolff@gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor" refs/changes/20/557420/3 && git checkout FETCH_HEAD [14:11:28] Which I'll give you the point, is pretty eww [14:11:52] yeah [14:12:42] I guess we could also make aliases for that too, the command is predictible [14:13:38] it's not, 557420 is clearly a commit id, 3 is patchset id, but what the hell is 20? [14:13:51] 20 is the last two digits of 557420 [14:14:11] although having to know what the patchset id is might be a bit annoying [14:14:21] And pretty soon we're probably reinventing git-review [14:14:28] true :D [14:14:53] * Urbanecm is thinking why does that have to have last two digits separately [14:15:02] are there some git-internal limits it is bypassing? [14:15:31] It might be filesystem related, some filesystems don't like having directories with massive number of files in it [14:15:42] MW does a similar thing with images [14:16:12] i see [14:17:43] Urbanecm: you might find https://github.com/legoktm/grr convenient [14:18:18] omg, a wild legoktm appears! :D [14:18:26] Hi! [14:18:29] ohai [14:18:45] legoktm: so that's the reinvention of git-review bawolff talked about earlier? :D [14:18:48] I kinda lost track of time -.- [14:19:09] Urbanecm: basically. It's the feature set I use, without any extra magic on top. [14:19:28] i see [14:19:51] The thing i kind of want, is basically a curses interface to gerrit, so I can stay in the command line when doing code review, and not switch back and forth between the web browser [14:20:23] bawolff: https://pypi.org/project/gertty/ [14:20:45] bawolff: can't you use ssh -p 29418 gerrit.wikimedia.org gerrit ? [14:20:51] 10Article-Recommendation, 10Google-Summer-of-Code (2019): Improve article recommendation pipeline - https://phabricator.wikimedia.org/T217655 (10Shivanshu1086) Hi, This is Shivanshu Bajpai from Galgotias University! How can I started contributing to this project!!? [14:21:16] bawolff: I sometimes do +2 patches that way [14:21:19] legoktm: Of course its packaged in debian :) This is precisely the type of thing debian people would want [14:21:26] Urbanecm: hmm, I haven't tried that [14:21:50] I've only used the gerrit ssh interface to ban users [14:22:09] I used to use it quite frequently when I would regularly be offline or on a bad network [14:23:19] I sometimes like to be offline when I work, its much easier to focus without a network [14:24:08] sometimes [14:24:27] but I need to sleep eventually, the sun is gonna come up soon -.- [14:24:29] good night! [14:24:48] good night legoktm [14:25:28] rofl http://ttygroup.org/gertty/index.html [14:25:41] legoktm: Yeah, I already did that am up for the day :P [14:26:51] 10Hashtags, 10Outreach-Programs-Projects, 10Google-Summer-of-Code (2019): Create a subpage for statistics and charts related to a hashtag search - https://phabricator.wikimedia.org/T186706 (10Shivanshu1086) Hi @Samwalton9! This is Shivanshu Bajpai. I am from Galgotias University. I would love to contribute t... [14:31:29] 10OABot: Do not suggest URLs redundant with DOI - https://phabricator.wikimedia.org/T228829 (10Nemo_bis) I'm refreshing the oabot suggestions after T233715 and T228632#5529941; when that's done, I'll re-assess how many redundant URLs get proposed nonetheless. It may take a few weeks. [14:32:43] 10OABot: Support access level parameters - https://phabricator.wikimedia.org/T228632 (10Nemo_bis) I'm refreshing the oabot suggestions after T233715 and T228632#5529941; when that's done, I'll see how many hdl-access and doi-access changes we end up proposing. We currently have some 1300 articles with `hdl-acces... [14:33:11] 10OABot: Ignore citation templates with chapter-url set - https://phabricator.wikimedia.org/T234522 (10Nemo_bis) I'm refreshing the oabot suggestions after T233715 and T228632#5529941; when that's done, I'll see how many of these chapter-url suggestions would be left and remove them manually. [14:34:36] 10OABot, 10Patch-For-Review: No click-through landing page - https://phabricator.wikimedia.org/T166280 (10Nemo_bis) 05Open→03Resolved a:03Nemo_bis Oh well, let's do it. [14:39:15] (03CR) 10Jack Phoenix: [V: 03+2 C: 03+2] Move some PHP files into the directories. [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557536 (owner: 10Zoranzoki21) [14:39:24] (03CR) 10Jack Phoenix: [V: 03+2 C: 03+2] Create composer.json with default settings. [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557539 (owner: 10Zoranzoki21) [14:42:08] bawolff that was showcased at gerrit's hackathon last month [14:42:18] gertty [14:42:33] well user submit the hackathon was during the week [14:42:39] *summit [14:42:48] paladox: cool, were you at the hackathon? [14:43:30] (03PS2) 10Zoranzoki21: Auto-fix of errors found with first run of composer test [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557541 [14:43:35] * bawolff has never been to a non-wikimedia hackathon [14:43:49] Nope, though i was in the channel [14:44:21] That's where it was showed that i am now on the gerrit frontend team as a non googler (user summit) :P [14:45:03] paladox: Congratulations :) [14:45:13] thanks! [14:45:32] My majour project now is adding support for file uploads in the UI :P [14:45:36] which i have working! [14:45:51] https://gerrit-review.googlesource.com/c/gerrit/+/248392 and https://gerrit-review.googlesource.com/c/gerrit/+/246332/ [14:47:07] technically you can already do it... but you will find the files will be corrupted so i had to introduce a new rest api so that you encode the file in base64 and server side decodes. [14:49:06] 10MediaWiki-API, 10Core Platform Team: Make ar_parent_id visible through the API - https://phabricator.wikimedia.org/T183376 (10Lahwaacz) MediaWiki 1.33.1 seems to provide non-zero "parentid" in these API queries. [14:49:28] 10MediaWiki-API, 10Core Platform Team: Make ar_parent_id visible through the API - https://phabricator.wikimedia.org/T183376 (10Lahwaacz) 05Open→03Resolved [14:49:49] Ah, so like https://tools.wmflabs.org/gerrit-patch-uploader/ but properly integrated [14:50:01] Sounds cool :) [14:50:42] yup [14:51:30] Cherry-picking in gerrit now does it with merge conflicts if you click continue :P [14:51:49] so no longer do you need to using git to fix the conflicts, you can do it all in the UI! [14:52:13] (03PS3) 10Jack Phoenix: Auto-fix of errors found with first run of composer test [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557541 (owner: 10Zoranzoki21) [14:52:30] (03CR) 10Jack Phoenix: [V: 03+2 C: 03+2] Auto-fix of errors found with first run of composer test [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557541 (owner: 10Zoranzoki21) [14:56:06] 10WatchTranslations, 10Google-Code-in-2019: Add explanatory footer to mails sent by the tool - https://phabricator.wikimedia.org/T240234 (10IAmNetx) a:03IAmNetx [14:56:44] will never not be momentarily terrified by those notifications [14:57:20] (03PS1) 10Jack Phoenix: Fix path to HTML templates and fix createplate selector's CSS class generation [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557560 [14:57:56] (03CR) 10Jack Phoenix: [V: 03+2 C: 03+2] Fix path to HTML templates and fix createplate selector's CSS class generation [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557560 (owner: 10Jack Phoenix) [14:58:00] (03PS5) 10Ammarpad: Show correct protection detail on InfoAction [core] - 10https://gerrit.wikimedia.org/r/554106 (https://phabricator.wikimedia.org/T45283) [14:58:04] IAmNetx: yes, that's one of the things I hate about irccloud [14:58:10] you can mute wikibugs totally [14:58:13] (by /ignore wikibugs) [14:58:19] but that way, its messages won't show [14:59:11] yeah, I just want a way I can make it so that I don't receive notifications from it (and channels don't show as unread) but ignoring just hides it completely [14:59:32] * Urbanecm wants that too [14:59:40] talked to irccloud, "considering for a future update" [15:00:06] 04(no projects): /sec-warning page: please add a helpful XML comment explaining why it's being delivered. - https://phabricator.wikimedia.org/T240794 (10DavidBrooks) [15:00:49] "it's on the roadmap" is usually code for "bottom of the todo list" [15:01:10] hehe [15:01:20] (03PS6) 10Ammarpad: Show correct protection detail on InfoAction [core] - 10https://gerrit.wikimedia.org/r/554106 (https://phabricator.wikimedia.org/T45283) [15:01:37] If you want something, gotta code it yourself basically [15:01:56] Ebe123: hard to do for non-opensource stuff [15:02:01] Or it's on the long, winding road-map [15:02:18] That's a big reason I'm a FOSS guy [15:02:51] Urbanecm, checking me out? [15:02:59] the desktop client is open-source, but it's an electron app so basically nothing you can do [15:03:04] wanted to see if you do have opensoure client :D [15:03:18] IAmNetx: yeah, just loads irccloud.com, right [15:03:22] Although pings from wikibugs is how i find out that jenkins-bot failed my patch [15:03:32] (03PS1) 10Zoranzoki21: Make composer test passing [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557561 [15:03:42] *jerkins-bot [15:04:11] ok, new feature request: allow using regex for specific users to determine whether or not you should receive a notification for it ;) [15:04:13] bawolff: that's cool, but...having irccloud ping me for each of the 50 tasks I submitted a bulk job for is not so funny [15:04:43] lol, no that doesn't sound fun [15:05:22] I imagine its like what happens to the operations folks who stalk the word "CRITICAL" when the site goes down ;) [15:05:49] hehe [15:08:09] (03PS2) 10Zoranzoki21: Make composer test passing [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557561 [15:08:22] 10KaiOS-Wikipedia-app, 10Inuka-Team (Kanban): Responsive Styling - https://phabricator.wikimedia.org/T240790 (10hueitan) a:03hueitan [15:12:57] (03CR) 10jerkins-bot: [V: 04-1] Show correct protection detail on InfoAction [core] - 10https://gerrit.wikimedia.org/r/554106 (https://phabricator.wikimedia.org/T45283) (owner: 10Ammarpad) [15:13:04] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/554106 (https://phabricator.wikimedia.org/T45283) (owner: 10Ammarpad) [15:19:34] (03PS2) 10Zoranzoki21: Move tabber.js and tabber.css from js/ and css/ directories into the one directory resources/ [extensions/Tabber] - 10https://gerrit.wikimedia.org/r/557334 [15:21:14] (03CR) 10Zoranzoki21: "kizule@kizule-laptop:~/Desktop/development/CreateAPage$ composer test" [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557561 (owner: 10Zoranzoki21) [15:24:32] (03PS7) 10Ammarpad: Show correct protection detail on InfoAction [core] - 10https://gerrit.wikimedia.org/r/554106 (https://phabricator.wikimedia.org/T45283) [15:24:38] (03CR) 10Ammarpad: Show correct protection detail on InfoAction (031 comment) [core] - 10https://gerrit.wikimedia.org/r/554106 (https://phabricator.wikimedia.org/T45283) (owner: 10Ammarpad) [15:28:35] (03PS1) 10Jack Phoenix: Remove a lot of code related to old toolbar stuff [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557568 [15:29:07] (03CR) 10Ammarpad: Show correct protection detail on InfoAction (031 comment) [core] - 10https://gerrit.wikimedia.org/r/554106 (https://phabricator.wikimedia.org/T45283) (owner: 10Ammarpad) [15:30:12] (03CR) 10Jack Phoenix: [V: 03+2 C: 03+2] Remove a lot of code related to old toolbar stuff [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557568 (owner: 10Jack Phoenix) [15:30:23] (03PS3) 10Zoranzoki21: Make composer test passing [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557561 [15:31:32] (03CR) 10Zoranzoki21: [C: 03+1] "I don't know why CI no runs tests..." [extensions/AnonPrivacy] - 10https://gerrit.wikimedia.org/r/557557 (owner: 10Libraryupgrader) [15:31:45] (03PS1) 10Jack Phoenix: Usability: when a CAPTCHA is required, it should not be required for merely *previewing* a page [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557570 [15:34:26] (03CR) 10Jack Phoenix: [C: 04-1] Make composer test passing (032 comments) [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557561 (owner: 10Zoranzoki21) [15:35:24] (03CR) 10Jack Phoenix: [V: 03+2 C: 03+2] Usability: when a CAPTCHA is required, it should not be required for merely *previewing* a page [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557570 (owner: 10Jack Phoenix) [15:36:08] (03CR) 10Zoranzoki21: Make composer test passing (031 comment) [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557561 (owner: 10Zoranzoki21) [15:38:37] What's the css class used to make that green "success" box that some special pages use? [15:38:42] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/554106 (https://phabricator.wikimedia.org/T45283) (owner: 10Ammarpad) [15:39:33] Ah, i see Special:Preferences uses mw-notify-success successbox [15:40:07] (03PS4) 10Zoranzoki21: Make composer test passing [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557561 [15:40:41] (03PS1) 10Jack Phoenix: Move extension description to the i18n file so that translators can translate it [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557572 [15:41:17] (03CR) 10Jack Phoenix: [V: 03+2 C: 03+2] Move extension description to the i18n file so that translators can translate it [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557572 (owner: 10Jack Phoenix) [15:43:59] (03CR) 10Jack Phoenix: [V: 03+2 C: 03+2] Make composer test passing [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557561 (owner: 10Zoranzoki21) [15:44:53] (03PS1) 10Zoranzoki21: Unification of qqq.json file [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557575 [15:45:32] (03PS2) 10Zoranzoki21: Unification of qqq.json file [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557575 [15:45:32] (03CR) 10Nikerabbit: "Docs were updated in https://www.mediawiki.org/w/index.php?title=Extension:LocalisationUpdate&type=revision&diff=3550552&oldid=3432041&dif" [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/551386 (https://phabricator.wikimedia.org/T238517) (owner: 10Lens0021) [15:47:06] (03CR) 10Jack Phoenix: [V: 03+2 C: 03+2] Unification of qqq.json file [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557575 (owner: 10Zoranzoki21) [15:50:51] I actually like the non-js version of successbox much better, but i guess that's no longer the way :( [15:54:26] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Avoid lost link for deleting pages which is later restored - https://phabricator.wikimedia.org/T75908 (10Graham87) Has this bug been fixed (or almost fixed) recently as a side effect of something else? I've done sev... [15:56:34] (03CR) 10Daimona Eaytoy: [C: 04-1] Show correct protection detail on InfoAction (036 comments) [core] - 10https://gerrit.wikimedia.org/r/554106 (https://phabricator.wikimedia.org/T45283) (owner: 10Ammarpad) [15:57:13] 10Hashtags, 10Outreach-Programs-Projects, 10Google-Summer-of-Code (2019): Create a subpage for statistics and charts related to a hashtag search - https://phabricator.wikimedia.org/T186706 (10Samwalton9) Hi @Shivanshu1086 - this project was for last year's Google Summer of Code and has been completed. You ca... [15:57:47] Especially because i can't get the js one to work [16:02:43] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/557571 (owner: 10Libraryupgrader) [16:02:45] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/Athena] - 10https://gerrit.wikimedia.org/r/557573 (owner: 10Libraryupgrader) [16:10:59] (03PS1) 10Brian Wolff: [WIP] Special page to add exceptions to CSP policy [core] - 10https://gerrit.wikimedia.org/r/557581 (https://phabricator.wikimedia.org/T208188) [16:11:19] 10Cleanup: Empty Gerrit repository /mediawiki/extensions/FileSystemImageServer - https://phabricator.wikimedia.org/T240786 (10Nikerabbit) I guess I should figure out how to import https://github.com/Nikerabbit/mediawiki-extensions-FileSystemImageServer to there. [16:13:08] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Special page to add exceptions to CSP policy [core] - 10https://gerrit.wikimedia.org/r/557581 (https://phabricator.wikimedia.org/T208188) (owner: 10Brian Wolff) [16:21:40] (03CR) 10Umherirrender: [C: 03+2] build: Updating mediawiki/minus-x to 0.3.2 [extensions/ArticleIndex] - 10https://gerrit.wikimedia.org/r/557566 (owner: 10Libraryupgrader) [16:23:00] (03CR) 10Umherirrender: [C: 03+2] "The bot is excluded from running the normal test queue, because it normally autocommmit to the gate-and-submit queue. But when doing more " [extensions/AnonPrivacy] - 10https://gerrit.wikimedia.org/r/557557 (owner: 10Libraryupgrader) [16:25:32] 10Article-Recommendation, 10Google-Summer-of-Code (2019): Improve article recommendation pipeline - https://phabricator.wikimedia.org/T217655 (10Aklapper) @Shivanshu1086: Hi, the codebase is at `research/article-recommender` [in Gerrit](https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker). See http... [16:25:41] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [core] - 10https://gerrit.wikimedia.org/r/557581 (https://phabricator.wikimedia.org/T208188) (owner: 10Brian Wolff) [16:30:33] (03PS1) 10Umherirrender: Fix doc of SearchIndexFieldDefinition::getIndexType [core] - 10https://gerrit.wikimedia.org/r/557587 [16:34:24] (03PS1) 10Zoranzoki21: Create Gruntfile.js, add npm tests and fix all errors [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557591 [16:38:05] (03PS2) 10Zoranzoki21: Create Gruntfile.js, add npm tests and fix all errors [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557591 [16:42:19] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557587 (owner: 10Umherirrender) [16:44:47] (03PS3) 10Zoranzoki21: Create Gruntfile.js, package.json and other needed files for npm tests [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557591 [16:45:50] (03CR) 10Zoranzoki21: "And tests pass, really :)" [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557591 (owner: 10Zoranzoki21) [16:46:18] 10MediaWiki-Special-pages, 10Wikimedia-Site-requests, 10User-Josve05a: Remove MediaWiki:Querypage-no-updates from recently restarted querypages - https://phabricator.wikimedia.org/T145942 (10Ammarpad) [16:46:22] 10MediaWiki-Special-pages, 10WikimediaMessages, 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), 10MW-1.35-notes (1.35.0-wmf.2; 2019-10-15), 10good first task: querypage-no-updates still shown on special pages on wmf wikis that update from cron - https://phabricator.wikimedia.org/T78711 (10Ammarpad) [16:48:01] (03PS1) 10Umherirrender: Add missing int cast [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/557597 [16:49:43] (03PS2) 10Umherirrender: build: Updating mediawiki/minus-x to 0.3.2 [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/557595 (owner: 10Libraryupgrader) [16:49:46] (03CR) 10Umherirrender: [C: 03+2] build: Updating mediawiki/minus-x to 0.3.2 [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/557595 (owner: 10Libraryupgrader) [16:56:54] 10Toolforge (Software install/update): Upgrade jq to v1.6 on bastion hosts - https://phabricator.wikimedia.org/T240796 (10RoySmith) [16:58:02] (03CR) 10Umherirrender: [V: 03+2] build: Updating dependencies [extensions/Athena] - 10https://gerrit.wikimedia.org/r/557573 (owner: 10Libraryupgrader) [17:00:08] (03PS4) 10Zoranzoki21: Create Gruntfile.js, package.json and other needed files for npm tests [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557591 [17:07:27] 10Hashtags, 10Outreach-Programs-Projects, 10Google-Summer-of-Code (2019): Create a subpage for statistics and charts related to a hashtag search - https://phabricator.wikimedia.org/T186706 (10Shivanshu1086) Thanks for the responding @Samwalton9 - It's all messed up or I am new to understand all this. Can you... [17:09:53] 10Hashtags, 10Outreach-Programs-Projects, 10Google-Summer-of-Code (2019): Create a subpage for statistics and charts related to a hashtag search - https://phabricator.wikimedia.org/T186706 (10Shivanshu1086) And as you said that this project is completed, so how can I talk to you personally? is this that Hash... [17:11:47] 10Hashtags, 10Outreach-Programs-Projects, 10Google-Summer-of-Code (2019): Create a subpage for statistics and charts related to a hashtag search - https://phabricator.wikimedia.org/T186706 (10Aklapper) @Shivanshu1806: Please see the links on the #Hashtags project page here: https://phabricator.wikimedia.org/... [17:13:55] (03CR) 10Jforrester: "recheck" [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557591 (owner: 10Zoranzoki21) [17:15:29] (03CR) 10jerkins-bot: [V: 04-1] Create Gruntfile.js, package.json and other needed files for npm tests [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557591 (owner: 10Zoranzoki21) [17:18:29] (03CR) 10Zoranzoki21: "18:15:22 1) ResourcesTest::testValidDependencies" [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557591 (owner: 10Zoranzoki21) [17:19:20] (03CR) 10Jack Phoenix: [C: 04-1] "Tested this and I was unable to quickly spot any breaking JS errors, so yay. :) That being said, the indentation in the JS file is outrigh" [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557591 (owner: 10Zoranzoki21) [17:41:24] (03PS1) 10Zoranzoki21: Fix dependency error from CI about jquery.ui [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557610 [17:42:58] (03CR) 10jerkins-bot: [V: 04-1] Fix dependency error from CI about jquery.ui [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557610 (owner: 10Zoranzoki21) [17:43:25] (03CR) 10Zoranzoki21: "recheck" [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557610 (owner: 10Zoranzoki21) [17:45:05] (03PS5) 10Zoranzoki21: Create Gruntfile.js, package.json and other needed files for npm tests [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557591 [17:46:04] (03CR) 10Zoranzoki21: "18:45:28 Running "banana:all" (banana) task" [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557591 (owner: 10Zoranzoki21) [17:46:41] (03CR) 10jerkins-bot: [V: 04-1] Create Gruntfile.js, package.json and other needed files for npm tests [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557591 (owner: 10Zoranzoki21) [17:48:37] (03CR) 10Robert Vogel: [C: 03+2] build: Updating dependencies [extensions/BlueSpiceContextMenu] - 10https://gerrit.wikimedia.org/r/557611 (owner: 10Libraryupgrader) [17:52:37] (03PS6) 10Zoranzoki21: Create Gruntfile.js, package.json and other needed files for npm tests [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557591 [17:54:09] (03CR) 10jerkins-bot: [V: 04-1] Create Gruntfile.js, package.json and other needed files for npm tests [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557591 (owner: 10Zoranzoki21) [17:55:20] (03CR) 10Nikerabbit: "This is being done in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TranslationNotifications/+/537575" [extensions/TranslationNotifications] - 10https://gerrit.wikimedia.org/r/553777 (https://phabricator.wikimedia.org/T129069) (owner: 10Umherirrender) [17:55:33] (03CR) 10Jforrester: [C: 03+2] Fix dependency error from CI about jquery.ui [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557610 (owner: 10Zoranzoki21) [17:58:06] (03Merged) 10jenkins-bot: Fix dependency error from CI about jquery.ui [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557610 (owner: 10Zoranzoki21) [17:58:08] (03CR) 10Jack Phoenix: [C: 03+2] Fix dependency error from CI about jquery.ui [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557610 (owner: 10Zoranzoki21) [18:01:59] 10Cleanup: Empty Gerrit repository /mediawiki/extensions/BlueSpiceMenues - https://phabricator.wikimedia.org/T240788 (10Osnard) Thanks for the hint. Looks like the planned extension never got green light for development. Please feel free to remove it. Sorry for the inconvenience. [18:06:33] (03PS7) 10Jforrester: Create Gruntfile.js, package.json and other needed files for npm tests [extensions/CreateAPage] - 10https://gerrit.wikimedia.org/r/557591 (owner: 10Zoranzoki21) [18:07:41] (03CR) 10Jforrester: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/557495 (owner: 10Libraryupgrader) [18:07:50] (03PS3) 10Jforrester: build: Updating mediawiki/mediawiki-phan-config to 0.9.0 [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/557495 (owner: 10Libraryupgrader) [18:07:56] (03CR) 10Jforrester: [C: 03+2] "…" [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/557495 (owner: 10Libraryupgrader) [18:11:13] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/BlueSpiceEditNotifyConnector] - 10https://gerrit.wikimedia.org/r/557618 (owner: 10Libraryupgrader) [18:16:04] (03PS1) 10Krinkle: resourceloader: Remove ResourceLoaderModule::safeFilemtime() [core] - 10https://gerrit.wikimedia.org/r/557620 [18:24:36] (03CR) 10Jforrester: [C: 03+1] "Unused, but not marked @internal; did we say we'd removed in the release notes? If not, we should." [core] - 10https://gerrit.wikimedia.org/r/557620 (owner: 10Krinkle) [18:27:04] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557620 (owner: 10Krinkle) [18:29:14] 10WatchTranslations, 10Google-Code-in-2019: Saving an edit with no change gives nonsense error message - https://phabricator.wikimedia.org/T240708 (10RetroCraft) a:03RetroCraft Claiming as part of Google Code-In 2019. [18:36:16] 10TechCom-RFC: Support PHP 7.4 preload - https://phabricator.wikimedia.org/T240775 (10Jdforrester-WMF) The model of MW-in-containers we're heading for will have each PHP process (within the container) running only one version of MW at a time ('hetdeploy' as it were will be done at a larger scale, with blue/green... [18:37:07] (03PS2) 10Brian Wolff: [WIP] Special page to add exceptions to CSP policy [core] - 10https://gerrit.wikimedia.org/r/557581 (https://phabricator.wikimedia.org/T208188) [18:37:38] (03CR) 10Jforrester: [C: 03+1] Add a base class for parser transition [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/553794 (owner: 10Daimona Eaytoy) [18:38:32] (03CR) 10Jforrester: [C: 03+2] Move tabber.js and tabber.css from js/ and css/ directories into the one directory resources/ [extensions/Tabber] - 10https://gerrit.wikimedia.org/r/557334 (owner: 10Zoranzoki21) [18:41:31] (03Merged) 10jenkins-bot: Move tabber.js and tabber.css from js/ and css/ directories into the one directory resources/ [extensions/Tabber] - 10https://gerrit.wikimedia.org/r/557334 (owner: 10Zoranzoki21) [18:48:08] 10Wikimedia-Site-requests: Holiday logo change request for ttwiki - https://phabricator.wikimedia.org/T240797 (10Jdforrester-WMF) [18:48:17] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557581 (https://phabricator.wikimedia.org/T208188) (owner: 10Brian Wolff) [18:48:22] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Special page to add exceptions to CSP policy [core] - 10https://gerrit.wikimedia.org/r/557581 (https://phabricator.wikimedia.org/T208188) (owner: 10Brian Wolff) [18:48:47] 10DiscussionTools, 10OWC2020, 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17), 10VisualEditor (Current work): One of the replies gets lost during a race condition - https://phabricator.wikimedia.org/T240643 (10Esanders) I think it is also not possible to edit conflict with yourself, you have to test with two a... [18:49:20] 10Wikimedia-Site-requests: Holiday logo change request for ttwiki - https://phabricator.wikimedia.org/T240797 (10Jdforrester-WMF) I'm not sure what using both logos means; please confirm which one you want when, and when you want it to run from and until. [18:50:45] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Fix doc of Language::sprintfDate [core] - 10https://gerrit.wikimedia.org/r/557107 (owner: 10Umherirrender) [18:53:26] 10MediaWiki-ResourceLoader, 10Performance-Team: Investigate cause of irregular 1s+ spikes on load.php latencies - https://phabricator.wikimedia.org/T233059 (10Krinkle) To start investigating this, I'm actually looking at a recent regression in overall backend timing for load.php first. Some general improvement... [18:54:01] (03PS2) 10Krinkle: resourceloader: Remove ResourceLoaderModule::safeFilemtime() [core] - 10https://gerrit.wikimedia.org/r/557620 (https://phabricator.wikimedia.org/T233059) [18:54:03] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] Add missing int casts (031 comment) [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/557059 (owner: 10Umherirrender) [18:54:31] (03CR) 10Krinkle: [C: 03+2] Add a base class for parser transition [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/553794 (owner: 10Daimona Eaytoy) [18:55:07] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Fix doc of LdapAuthenticationPlugin::printDebug [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/557057 (owner: 10Umherirrender) [18:56:30] (03PS3) 10Krinkle: API: Allow multiple values in 'user' and 'id' parameters to globaluserinfo [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/548966 (https://phabricator.wikimedia.org/T237505) (owner: 10Urbanecm) [18:56:36] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Do not call Skin::showEmailUser with a userid null [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/555998 (owner: 10Umherirrender) [18:59:06] (03CR) 10Krinkle: "This LGTM from a code quality and API usability perspective, but I'm not familiar with the CA code itself to know whether this safe and wi" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/548966 (https://phabricator.wikimedia.org/T237505) (owner: 10Urbanecm) [18:59:26] 10MediaWiki-extensions-CentralAuth, 10Anti-Harassment, 10Core Platform Team, 10Patch-For-Review, and 2 others: Globaluserinfo API module should allow getting data for more than one user at once - https://phabricator.wikimedia.org/T237505 (10Krinkle) [19:00:42] 10MediaWiki-extensions-CentralAuth, 10Anti-Harassment, 10Core Platform Team, 10Patch-For-Review, and 2 others: Globaluserinfo API module should allow getting data for more than one user at once - https://phabricator.wikimedia.org/T237505 (10Krinkle) >>! @Krinkle [wrote at Gerrit](https://gerrit.wikimedia.o... [19:01:16] (03CR) 10Krinkle: [C: 03+2] Use document.body instead of 'body' as jQuery selector [core] - 10https://gerrit.wikimedia.org/r/556978 (owner: 10Fomafix) [19:01:18] (03CR) 10Jforrester: [C: 03+2] Fix: Bail out of label fetching job if local file not found [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/557147 (https://phabricator.wikimedia.org/T240733) (owner: 10Mholloway) [19:04:40] (03PS6) 10Krinkle: registration: Implement lazy-loaded attributes [core] - 10https://gerrit.wikimedia.org/r/556790 (https://phabricator.wikimedia.org/T220994) (owner: 10Legoktm) [19:04:45] (03Merged) 10jenkins-bot: Fix doc of Language::sprintfDate [core] - 10https://gerrit.wikimedia.org/r/557107 (owner: 10Umherirrender) [19:04:53] (03PS7) 10Krinkle: registration: Implement lazy-loaded attributes [core] - 10https://gerrit.wikimedia.org/r/556790 (https://phabricator.wikimedia.org/T220994) (owner: 10Legoktm) [19:06:11] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] Use friends of WebRequest::getVal (034 comments) [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/557118 (owner: 10Umherirrender) [19:07:47] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Improve param docs [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/556768 (owner: 10Umherirrender) [19:08:13] (03CR) 10Krinkle: [C: 03+2] "LGTM. We might want to still cache these in APC still, but in a separate key? Maybe conditional on $wgDevelopmentWarnings or something mor" [core] - 10https://gerrit.wikimedia.org/r/556790 (https://phabricator.wikimedia.org/T220994) (owner: 10Legoktm) [19:08:37] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557620 (https://phabricator.wikimedia.org/T233059) (owner: 10Krinkle) [19:09:10] (03Merged) 10jenkins-bot: Add a base class for parser transition [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/553794 (owner: 10Daimona Eaytoy) [19:09:12] (03Merged) 10jenkins-bot: Fix doc of LdapAuthenticationPlugin::printDebug [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/557057 (owner: 10Umherirrender) [19:09:14] (03Merged) 10jenkins-bot: Do not call Skin::showEmailUser with a userid null [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/555998 (owner: 10Umherirrender) [19:10:06] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Fix doc of LoginNotify::generateUserCookieRecord [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/557058 (owner: 10Umherirrender) [19:10:49] (03CR) 10Jforrester: registration: Implement lazy-loaded attributes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/556790 (https://phabricator.wikimedia.org/T220994) (owner: 10Legoktm) [19:11:09] 10Wikimedia-Site-requests: Holiday logo change request for ttwiki - https://phabricator.wikimedia.org/T240797 (10Masumrezarock100) I believe this can easily be done using CSS. [19:12:36] 10Wikimedia-Site-requests: Holiday logo change request for ttwiki - https://phabricator.wikimedia.org/T240797 (10Jdforrester-WMF) >>! In T240797#5742669, @Masumrezarock100 wrote: > I believe this can easily be done using CSS. Easily and wrongly. It should not ever be done using CSS. [19:13:40] (03CR) 10Jforrester: "This should probably go in RELNOTs as it's likely to be mildly spammy, right?" [core] - 10https://gerrit.wikimedia.org/r/450176 (owner: 10Legoktm) [19:14:20] (03Merged) 10jenkins-bot: Use document.body instead of 'body' as jQuery selector [core] - 10https://gerrit.wikimedia.org/r/556978 (owner: 10Fomafix) [19:14:47] 10Wikimedia-Site-requests: Holiday logo change request for ttwiki - https://phabricator.wikimedia.org/T240797 (10Masumrezarock100) Well, @Ladsgroup did change [[https://www.wikidata.org/w/index.php?title=MediaWiki:Common.css&diff=1040831214|the logo of Wikidata temporarily using CSS]]. [19:15:16] 10Library-Card-Platform, 10good first task: Add a 'Back to partners' navigational button from partner signup pages - https://phabricator.wikimedia.org/T150012 (10Soumyaa1804) Hey, @Samwalton9! Can you please tag the template or link to the page which needs to be updated? [19:15:44] 10Wikimedia-Site-requests: Holiday logo change request for ttwiki - https://phabricator.wikimedia.org/T240797 (10Jdforrester-WMF) >>! In T240797#5742671, @Masumrezarock100 wrote: > Well, @Ladsgroup did change [[https://www.wikidata.org/w/index.php?title=MediaWiki:Common.css&diff=1040831214|the logo of Wikidata t... [19:16:21] 10Wikimedia-Site-requests: Holiday logo change request for ttwiki - https://phabricator.wikimedia.org/T240797 (10Masumrezarock100) I believe there are some open questions for @Derslek. [19:16:28] (03CR) 10Aaron Schulz: [C: 03+1] resourceloader: Fix WikiModule cache invalidation order in Title::invalidateCache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/548845 (owner: 10Krinkle) [19:18:01] (03PS1) 10Krinkle: resourceloader: Various optimisations in FileModule::getFileHashes() [core] - 10https://gerrit.wikimedia.org/r/557632 (https://phabricator.wikimedia.org/T233059) [19:18:03] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [core] - 10https://gerrit.wikimedia.org/r/556790 (https://phabricator.wikimedia.org/T220994) (owner: 10Legoktm) [19:18:05] (03CR) 10Jforrester: "C-1. ;-)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/557077 (owner: 10Krinkle) [19:19:40] 10MediaWiki-REST-API, 10Wikimedia-Site-requests, 10CPT Initiatives (Core REST API in PHP), 10Core Platform Team Workboards (Green), 10Story: Add $wgRightsSPDXId to production settings - https://phabricator.wikimedia.org/T240294 (10Jdforrester-WMF) 05Open→03Stalled >>! In T240294#5740006, @nnikkhoui w... [19:19:42] 10MediaWiki-REST-API, 10CPT Initiatives (Core REST API in PHP), 10Core Platform Team Workboards (Green), 10Patch-For-Review, 10Story: Contributor gets page source - https://phabricator.wikimedia.org/T229663 (10Jdforrester-WMF) [19:20:06] (03CR) 10Krinkle: API: Deprecate wgEnableOpenSearchSuggest and opensearch+suggest parameter (031 comment) [core] - 10https://gerrit.wikimedia.org/r/557077 (owner: 10Krinkle) [19:20:56] (03PS3) 10Krinkle: resourceloader: Fix WikiModule cache invalidation order in Title::invalidateCache [core] - 10https://gerrit.wikimedia.org/r/548845 [19:21:17] (03PS2) 10Krinkle: resourceloader: Various optimisations in FileModule::getFileHashes() [core] - 10https://gerrit.wikimedia.org/r/557632 (https://phabricator.wikimedia.org/T233059) [19:23:36] (03CR) 10Krinkle: "I see. Hm. in that case, do we need to support FilePath returned from versionCallback? I'm not sure in what case one would even have a ver" [core] - 10https://gerrit.wikimedia.org/r/556485 (https://phabricator.wikimedia.org/T239371) (owner: 10Catrope) [19:25:53] (03CR) 10Jforrester: API: Deprecate wgEnableOpenSearchSuggest and opensearch+suggest parameter (031 comment) [core] - 10https://gerrit.wikimedia.org/r/557077 (owner: 10Krinkle) [19:30:45] 10Space (Oct-Dec-2019): Editing the location field in the Events plugin deletes information previously input - https://phabricator.wikimedia.org/T231042 (10Samat) @elappen-WMF I tried it out and it worked well for me as well. Thank you for the development! [19:32:53] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/548845 (owner: 10Krinkle) [19:33:19] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557632 (https://phabricator.wikimedia.org/T233059) (owner: 10Krinkle) [19:36:32] (03Merged) 10jenkins-bot: Fix: Bail out of label fetching job if local file not found [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/557147 (https://phabricator.wikimedia.org/T240733) (owner: 10Mholloway) [19:36:34] (03Merged) 10jenkins-bot: Improve param docs [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/556768 (owner: 10Umherirrender) [19:36:38] (03Merged) 10jenkins-bot: registration: Implement lazy-loaded attributes [core] - 10https://gerrit.wikimedia.org/r/556790 (https://phabricator.wikimedia.org/T220994) (owner: 10Legoktm) [19:36:41] (03Merged) 10jenkins-bot: Fix doc of LoginNotify::generateUserCookieRecord [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/557058 (owner: 10Umherirrender) [19:38:26] (03PS1) 10Ephemeralwaves: Selenium: refactor TemplateWizard.js test [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/557634 (https://phabricator.wikimedia.org/T240766) [19:40:21] (03PS1) 10Krinkle: resourceloader: Use FileContentsHasher batching in FileModule::getFileHashes [core] - 10https://gerrit.wikimedia.org/r/557635 [19:56:07] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557635 (owner: 10Krinkle) [19:56:14] (03PS8) 10Ammarpad: Show correct protection detail on InfoAction [core] - 10https://gerrit.wikimedia.org/r/554106 (https://phabricator.wikimedia.org/T45283) [19:56:42] (03CR) 10Ammarpad: Show correct protection detail on InfoAction (036 comments) [core] - 10https://gerrit.wikimedia.org/r/554106 (https://phabricator.wikimedia.org/T45283) (owner: 10Ammarpad) [19:57:26] (03Abandoned) 10Ammarpad: Deprecate IE conditionals in OutputPage::addStyle() method [core] - 10https://gerrit.wikimedia.org/r/552956 (https://phabricator.wikimedia.org/T235353) (owner: 10Ammarpad) [19:59:41] 10MediaWiki-Interface, 10Patch-For-Review, 10Technical-Debt (Deprecation process): Deprecate IE conditionals in OutputPage::addStyle() - https://phabricator.wikimedia.org/T235353 (10Ammarpad) a:05Ammarpad→03None [20:06:28] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/BlueSpiceNSFileRepoConnector] - 10https://gerrit.wikimedia.org/r/557641 (owner: 10Libraryupgrader) [20:07:40] (03CR) 10jerkins-bot: [V: 04-1] Show correct protection detail on InfoAction [core] - 10https://gerrit.wikimedia.org/r/554106 (https://phabricator.wikimedia.org/T45283) (owner: 10Ammarpad) [20:07:44] 10MediaWiki-ResourceLoader, 10Performance-Team, 10VisualEditor, 10User-Ryasmeen: [testwiki] Transparency issue with Search drop down suggestions - https://phabricator.wikimedia.org/T239286 (10Krinkle) 05Open→03Resolved [20:07:48] 10MediaWiki-ResourceLoader, 10Performance-Team, 10VisualEditor, 10User-Ryasmeen: [testwiki] Transparency issue with Search drop down suggestions - https://phabricator.wikimedia.org/T239286 (10Krinkle) This still works correctly on en.wikipedia.org, thus likely ruling out a recent regression caused by a cha... [20:07:49] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/554106 (https://phabricator.wikimedia.org/T45283) (owner: 10Ammarpad) [20:08:56] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "I think this is not breaking anything, but leaving the code in a state that might be as confusing as before. Suggestions inline." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/557122 (owner: 10Umherirrender) [20:11:12] 10ArticleRatings, 10Patch-For-Review: Key "CanonicalNamespaceNames" not found in input sources in includes/config/ServiceOptions.php:52 - https://phabricator.wikimedia.org/T237032 (10Krinkle) [20:12:34] 10MobileFrontend, 10Readers-Web-Backlog, 10JavaScript, 10Technical-Debt: Dev: MobileFrontend should not use deprecated jquery.throttle-debounce - https://phabricator.wikimedia.org/T236427 (10Krinkle) [20:18:22] (03CR) 10Tpt: [C: 03+2] "Thank you!" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/557597 (owner: 10Umherirrender) [20:23:46] (03Merged) 10jenkins-bot: Add missing int cast [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/557597 (owner: 10Umherirrender) [20:29:19] 10ImageMetrics: ImageMetrics qunit test mw.imageMetrics.LoadingTimeLogger is failing - https://phabricator.wikimedia.org/T206290 (10Krinkle) Oh, I forgot about that. Okay, let's do that then. [20:29:30] 10MediaWiki-Watchlist, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10Performance-Team (Radar), 10User-notice: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10Dvorapa) p:05High→03Unbreak! Currently 4 days of s... [20:37:08] 10MediaWiki-Watchlist, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10Performance-Team (Radar), 10User-notice: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10Dvorapa) All seen: {F31476967} [20:38:37] 10ImageMetrics: Log file size in ImageMetrics - https://phabricator.wikimedia.org/T85779 (10Zoranzoki21) 05Open→03Declined Per {T240799}. [20:39:17] 10ImageMetrics: ImageMetrics qunit test mw.imageMetrics.LoadingTimeLogger is failing - https://phabricator.wikimedia.org/T206290 (10Zoranzoki21) 05Open→03Declined >>! In T206290#5742728, @Krinkle wrote: > I forgot about that! Okay, let's do that then. {T240799}. [20:39:50] 10MediaWiki-Watchlist, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10Performance-Team (Radar), 10User-notice: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10RhinosF1) Changing the priority isn’t going to make a... [20:39:56] 04(no projects): MediaWiki mail system for watchlist on it.wikipedia is delivering very slowly - https://phabricator.wikimedia.org/T240800 (10Ferdi2005) [20:41:51] (03CR) 10jerkins-bot: [V: 04-1] build: Updating dependencies [extensions/BlueSpicePageFormsConnector] - 10https://gerrit.wikimedia.org/r/557645 (owner: 10Libraryupgrader) [20:42:41] (03PS1) 10Zoranzoki21: Revert "Add role for ImageMetrics extension" [vagrant] - 10https://gerrit.wikimedia.org/r/557651 (https://phabricator.wikimedia.org/T240799) [20:42:47] (03PS2) 10Zoranzoki21: Revert "Add role for ImageMetrics extension" [vagrant] - 10https://gerrit.wikimedia.org/r/557651 (https://phabricator.wikimedia.org/T240799) [20:42:58] (03PS3) 10Zoranzoki21: Revert "Add role for ImageMetrics extension" [vagrant] - 10https://gerrit.wikimedia.org/r/557651 (https://phabricator.wikimedia.org/T240799) [20:50:32] 10Toolforge (Software install/update): Upgrade jq to v1.6 on bastion hosts - https://phabricator.wikimedia.org/T240796 (10JJMC89) [20:52:38] (03PS1) 10Zoranzoki21: Remove ImageMetrics extension [extensions] - 10https://gerrit.wikimedia.org/r/557656 (https://phabricator.wikimedia.org/T240799) [20:53:11] (03PS2) 10Zoranzoki21: Remove ImageMetrics extension [extensions] - 10https://gerrit.wikimedia.org/r/557656 (https://phabricator.wikimedia.org/T240799) [21:01:05] 10MediaWiki-extensions-General, 10Google-Code-in-2019, 10Patch-For-Review: Replace usage of jshint and/or jscs with eslint in MediaWiki extensions (clonable) - https://phabricator.wikimedia.org/T210365 (10Zoranzoki21) [21:06:42] 10MediaWiki-Page-editing: Move edit notices for pages out of the MediaWiki namespace and into a parser function on the page itself - https://phabricator.wikimedia.org/T124379 (10Pppery) [21:07:13] 10MediaWiki-Page-editing: Move edit notices for pages out of the MediaWiki namespace and into a parser function on the page itself - https://phabricator.wikimedia.org/T124379 (10Pppery) [21:12:29] Urbanecm: re translating the email that's sent, I considered it but wasn't sure how to really go about it as some of the translatable strings would need HTML to be in them, no? [21:16:42] 10WatchTranslations, 10Google-Code-in-2019: Saving an edit with no change gives nonsense error message - https://phabricator.wikimedia.org/T240708 (10Zoranzoki21) 05Open→03Resolved [21:17:27] IAmNetx: true. Let's ignore that for now then, I'll think about it more and maybe create second GCI task for that ;) [21:31:14] 10Commons-Mass-Description, 10Google-Code-in-2019: Use context processors instead of passing repetatively the same parameters - https://phabricator.wikimedia.org/T240138 (10BubblySprout) a:03BubblySprout I am claiming this task for Google Code-In 2019. [21:38:35] (03CR) 10BryanDavis: [C: 03+2] Revert "Add role for ImageMetrics extension" [vagrant] - 10https://gerrit.wikimedia.org/r/557651 (https://phabricator.wikimedia.org/T240799) (owner: 10Zoranzoki21) [21:39:25] (03Merged) 10jenkins-bot: Revert "Add role for ImageMetrics extension" [vagrant] - 10https://gerrit.wikimedia.org/r/557651 (https://phabricator.wikimedia.org/T240799) (owner: 10Zoranzoki21) [21:51:14] 10MediaWiki-Watchlist, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10Performance-Team (Radar), 10User-notice: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10Aklapper) p:05Unbreak!→03High It's highly annoying... [21:53:45] 10MediaWiki-Watchlist, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10Performance-Team (Radar), 10User-notice: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10Dvorapa) For me, half of Wikipedia is today down as I... [21:56:12] 10MediaWiki-Watchlist, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10Performance-Team (Radar), 10User-notice: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10IKhitron) Agree with unbreak now, of cource. [22:08:36] 10Wikimedia-Site-requests: Create 'Test custodians' user group for betawv - https://phabricator.wikimedia.org/T240438 (10RetroCraft) a:03RetroCraft Claiming as part of Google Code-In 2019. [22:26:48] 10MediaWiki-Watchlist, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10Performance-Team (Radar), 10User-notice: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10IKhitron) By the way, "pageviews does not work for yes... [22:28:48] 10MediaWiki-Watchlist, 10Core Platform Team, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), and 2 others: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10JJMC89) This has gotten much worse since 1.35.0-wmf.10 was depl... [22:33:02] 10MediaWiki-Watchlist, 10Core Platform Team, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), and 2 others: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10IKhitron) If our wiki watchlist get reset every 3-4 hours since... [22:40:08] 10WMSE-Magnus Sälgö: Europeana reference deleted Wikidata objects - task identify them but also Europeana need action - https://phabricator.wikimedia.org/T240738 (10Salgo60) [22:40:19] 10WMSE-Magnus Sälgö: Europeana reference deleted Wikidata objects - task identify them but also Europeana need action - https://phabricator.wikimedia.org/T240738 (10Salgo60) [22:51:50] 10Wikimedia-Site-requests, 10Patch-For-Review: Non-free content on Ingush Wikipedia - https://phabricator.wikimedia.org/T239925 (10Base) Ah, just noticed that the patchset is basically about excluding it from commonsuploads. So I assume uploads via were never disallowed on inhwiki, one just had to visit Specia... [22:56:25] (03CR) 10DannyS712: Add a new class representing single filters (035 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/480069 (https://phabricator.wikimedia.org/T213037) (owner: 10Daimona Eaytoy) [22:58:24] 10MediaWiki-extensions-FlaggedRevs, 10Release-Engineering-Team, 10Regression: FlaggedRevs: Automatic user promotion stopped working on some wikis on June 24 - https://phabricator.wikimedia.org/T237191 (10MGChecker) >>! In T237191#5741222, @Masumrezarock100 wrote: > Obviously not a single wiki issue. Auto-pro... [22:58:48] (03CR) 10DannyS712: Minor fixes for AbuseFilterFilter (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532961 (owner: 10Daimona Eaytoy) [23:02:40] (03CR) 10DannyS712: Emit a deprecation warning if the old parser is being used (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/555487 (https://phabricator.wikimedia.org/T239990) (owner: 10Daimona Eaytoy) [23:12:53] (03CR) 10DannyS712: Remove dependency on $wgRestrictionTypes (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539664 (owner: 10Daimona Eaytoy) [23:14:10] (03CR) 10DannyS712: [C: 04-1] "AbuseFilterViewEdit also needs to be updated" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/551818 (https://phabricator.wikimedia.org/T235590) (owner: 10Daimona Eaytoy) [23:16:44] 10WMSE-Magnus Sälgö: Europeana reference deleted Wikidata objects - task identify them but also Europeana need action - https://phabricator.wikimedia.org/T240738 (10Salgo60) [23:21:04] 10MediaWiki-User-management, 10User-Daimona, 10User-DannyS712: System users should be in a dedicated user group - https://phabricator.wikimedia.org/T212720 (10DannyS712) 05Open→03Resolved a:05Daimona→03DannyS712 Claiming per discussion that the separate group is unneeded in light of `User::isSystemUs... [23:22:17] 10MediaWiki-Watchlist, 10Core Platform Team, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), and 2 others: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10Victar) This has become considerably worse as of this week. [23:23:40] 10MediaWiki-extensions-FlaggedRevs, 10Release-Engineering-Team, 10Regression: FlaggedRevs: Automatic user promotion stopped working on some wikis on June 24 - https://phabricator.wikimedia.org/T237191 (10Masumrezarock100) >>! In T237191#5742879, @MGChecker wrote: > Around this date, the Wikimedia global Flag... [23:23:53] 10MediaWiki-User-management, 10Wikidata, 10Wikidata.org: Give a Confirmed right to new Wikidata users who are active and trusted on other projects - https://phabricator.wikimedia.org/T235155 (10DannyS712) @Amire80 what exactly is the actionable for this task? [23:25:35] 10WMSE-Magnus Sälgö: Europeana reference deleted Wikidata objects - task identify them but also Europeana need action - https://phabricator.wikimedia.org/T240738 (10Salgo60) [23:26:07] 10MediaWiki-extensions-FlaggedRevs, 10Code-Stewardship-Reviews, 10Release-Engineering-Team (Code Health): Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10DannyS712) The task specifies that there are no security bugs - T234736 is a security bug I filed in October [23:28:28] (03PS3) 10DannyS712: Allow aborting changing userrights using `ChangeUserGroups` hook [core] - 10https://gerrit.wikimedia.org/r/542662 (https://phabricator.wikimedia.org/T49338) [23:29:05] 10WMSE-Magnus Sälgö: Europeana reference deleted Wikidata objects - task identify them but also Europeana need action - https://phabricator.wikimedia.org/T240738 (10Salgo60) [23:33:06] 10MediaWiki-API, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review: list=blocks does not support IPv4 ranges - https://phabricator.wikimedia.org/T239527 (10DannyS712) Is this a duplicate of {T69203}? [23:35:37] 10Discovery-Search, 10Wikimedia-General-or-Unknown: "We could not complete your search due to a temporary problem." searching words on Minangkabau Wiktionary - https://phabricator.wikimedia.org/T240778 (10Reedy) Looking at the CirrusSearch log on mwlog1001 ` 2019-12-15 12:04:26 [XfYhSgpAICAAAKoT7DgAAABJ] mw13... [23:39:28] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/542662 (https://phabricator.wikimedia.org/T49338) (owner: 10DannyS712) [23:51:55] 10MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), 10MobileFrontend (MobileFrontend Special Pages), 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): Improve appearance of Special:MobileDiff when looking for invalid revision (Maybe because it's deleted) - https://phabricator.wikimedia.org/T224430 (... [23:55:42] (03PS22) 10DannyS712: Add namespace filter to Special:WantedPages [core] - 10https://gerrit.wikimedia.org/r/522602 (https://phabricator.wikimedia.org/T37758) [23:56:10] (03PS4) 10DannyS712: Include redirects by default in PageTriage feed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/537579 (https://phabricator.wikimedia.org/T42135) [23:57:45] (03PS14) 10DannyS712: API: Alter behaviour if state doesn't change instead of proceeding [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539624 (https://phabricator.wikimedia.org/T234074) [23:59:49] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/537579 (https://phabricator.wikimedia.org/T42135) (owner: 10DannyS712)