[00:06:34] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add `delete-redirect` right to delete single-rev redirects during page moves [core] - 10https://gerrit.wikimedia.org/r/554365 (owner: 10DannyS712) [00:08:04] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/554365 (owner: 10DannyS712) [00:11:02] (03PS21) 10DannyS712: [WIP] Add `delete-redirect` right to delete single-rev redirects during page moves [core] - 10https://gerrit.wikimedia.org/r/554365 [00:22:00] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/554365 (owner: 10DannyS712) [00:22:19] (03PS22) 10DannyS712: [WIP] Add `delete-redirect` right to delete single-rev redirects during page moves [core] - 10https://gerrit.wikimedia.org/r/554365 [00:22:27] (03CR) 10Ebe123: [C: 03+2] n3rsti.txt: created file with text [sandbox] - 10https://gerrit.wikimedia.org/r/557142 (owner: 10N3rsti) [00:26:42] (03PS1) 10DannyS712: Fix MediaWikiIntegrationTestCase::insertPage MWException text [core] - 10https://gerrit.wikimedia.org/r/557151 [00:27:58] (03PS2) 10DannyS712: Fix MediaWikiIntegrationTestCase MWException text for using pages [core] - 10https://gerrit.wikimedia.org/r/557151 [00:29:46] Hi, I want to do on https://phabricator.wikimedia.org/T240706 and when I click on URL to GCI task it shows me error about permission (You don't have permission....) [00:30:14] Can anyone check is something wrong? [00:30:33] might have been claimed, or not been published yet [00:31:18] Not published yet [00:33:07] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add `delete-redirect` right to delete single-rev redirects during page moves [core] - 10https://gerrit.wikimedia.org/r/554365 (owner: 10DannyS712) [00:33:28] Can anyone just publish it? :) [00:34:07] they publish tasks on a schedule iirc, you're probably gonna have to wait [00:34:31] There isn't really a schedule [00:34:55] Yes, I can publish it, but I'd much rather wait for Martin to confirm it's ready [00:35:57] Urbanecm added a comment.Fri, Dec 13, 20:31 [00:35:59] https://codein.withgoogle.com/tasks/5503328683819008/ [00:36:00] Urbanecm moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2019 board. [00:36:11] Ok, it should be ready already, if imported on site [00:36:27] "Imported" doesn't mean "ready" ;) [00:36:49] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/554365 (owner: 10DannyS712) [00:36:51] Ok, go for it Zoranzoki21 [00:37:33] I published it, as you're enthusiastic about it [00:39:11] Ty [00:40:02] (03PS23) 10DannyS712: [WIP] Add `delete-redirect` right to delete single-rev redirects during page moves [core] - 10https://gerrit.wikimedia.org/r/554365 [00:40:20] (03PS5) 10DannyS712: Expand watchlist-related tests for User class [core] - 10https://gerrit.wikimedia.org/r/553447 (https://phabricator.wikimedia.org/T233385) [00:41:48] (03CR) 10Zoranzoki21: [V: 03+2 C: 03+2] "LGTM!" [sandbox] - 10https://gerrit.wikimedia.org/r/557142 (owner: 10N3rsti) [00:42:04] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557151 (owner: 10DannyS712) [00:43:18] (03CR) 10Zoranzoki21: [V: 03+2 C: 03+2] "> Patch Set 1: Code-Review+2" [sandbox] - 10https://gerrit.wikimedia.org/r/557142 (owner: 10N3rsti) [00:44:11] (03PS1) 10VolkerE: Fix CSS selector in 'print.less' [skins/Vector] - 10https://gerrit.wikimedia.org/r/557153 [00:49:00] (03CR) 10Ebe123: "Doesn't really matter though if merged or not... Just forgot to press the button." [sandbox] - 10https://gerrit.wikimedia.org/r/557142 (owner: 10N3rsti) [00:51:52] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/554365 (owner: 10DannyS712) [00:52:26] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/553447 (https://phabricator.wikimedia.org/T233385) (owner: 10DannyS712) [00:56:52] (03CR) 10Nray: "Unfortunately, I don't think it's as easy as this." [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556840 (https://phabricator.wikimedia.org/T238364) (owner: 10Jdlrobson) [01:00:35] (03CR) 10DannyS712: [WIP] Add `delete-redirect` right to delete single-rev redirects during page moves (032 comments) [core] - 10https://gerrit.wikimedia.org/r/554365 (owner: 10DannyS712) [01:06:42] (03CR) 10Nray: "I think to have the most success with the encodeURIComponent route, you'd have to also use encodeURIComponent when setting window.location" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556840 (https://phabricator.wikimedia.org/T238364) (owner: 10Jdlrobson) [01:59:23] (03CR) 10MusikAnimal: [C: 03+2] Fix MediaWikiIntegrationTestCase MWException text for using pages [core] - 10https://gerrit.wikimedia.org/r/557151 (owner: 10DannyS712) [02:12:33] (03Merged) 10jenkins-bot: Fix MediaWikiIntegrationTestCase MWException text for using pages [core] - 10https://gerrit.wikimedia.org/r/557151 (owner: 10DannyS712) [02:28:31] (03PS8) 10DannyS712: ChessBrowser: Unit tests for PgnParser and related bug fixes [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [02:29:19] (03CR) 10DannyS712: "> Patch Set 8: Published edit on patch set 7." [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [02:29:59] (03PS9) 10DannyS712: ChessBrowser: Unit tests for PgnParser and related bug fixes [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [02:35:59] (03CR) 10jerkins-bot: [V: 04-1] ChessBrowser: Unit tests for PgnParser and related bug fixes [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [02:36:26] (03PS10) 10DannyS712: ChessBrowser: Unit tests for PgnParser and related bug fixes [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [02:41:55] (03CR) 10jerkins-bot: [V: 04-1] ChessBrowser: Unit tests for PgnParser and related bug fixes [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [02:54:15] (03PS11) 10DannyS712: ChessBrowser: Unit tests for PgnParser and related bug fixes [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [02:59:01] (03CR) 10jerkins-bot: [V: 04-1] ChessBrowser: Unit tests for PgnParser and related bug fixes [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [03:02:33] (03PS12) 10DannyS712: ChessBrowser: Unit tests for PgnParser and related bug fixes [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [03:07:30] (03CR) 10jerkins-bot: [V: 04-1] ChessBrowser: Unit tests for PgnParser and related bug fixes [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [03:13:05] (03PS13) 10DannyS712: ChessBrowser: Unit tests for PgnParser and related bug fixes [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [03:18:10] (03CR) 10jerkins-bot: [V: 04-1] ChessBrowser: Unit tests for PgnParser and related bug fixes [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [03:24:14] (03PS14) 10DannyS712: ChessBrowser: Unit tests for PgnParser and related bug fixes [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [03:25:41] (03CR) 10DannyS712: "I've gotten the majority of the errors. I suggest disabling `one-var`, `max-len`, `vars-on-top`, and `quote-props` for now; those rules ar" [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [03:26:24] (03CR) 10DannyS712: "> I've gotten the majority of the errors. I suggest disabling" [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [03:29:02] (03CR) 10jerkins-bot: [V: 04-1] ChessBrowser: Unit tests for PgnParser and related bug fixes [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [04:01:36] (03CR) 10DannyS712: MessagesDe.php: Add aliases for special pages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/556227 (owner: 10Tobi 406) [04:04:58] (03PS6) 10DannyS712: Add SpecialRedirectWithAction and related to release notes [core] - 10https://gerrit.wikimedia.org/r/554127 (https://phabricator.wikimedia.org/T13456) [04:13:20] (03PS1) 10DannyS712: Fix references to injection.txt to reference Injection.md [core] - 10https://gerrit.wikimedia.org/r/557157 [04:14:49] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/554127 (https://phabricator.wikimedia.org/T13456) (owner: 10DannyS712) [04:15:12] (03PS2) 10DannyS712: Fix references to injection.txt to reference Injection.md [core] - 10https://gerrit.wikimedia.org/r/557157 [04:18:54] (03CR) 10DannyS712: [C: 03+1] Avoid master connections for prop=info and intestactionsdetail=full [core] - 10https://gerrit.wikimedia.org/r/555603 (https://phabricator.wikimedia.org/T239451) (owner: 10Umherirrender) [04:23:15] (03CR) 10DannyS712: "Per Zoranzoki2, thank you for trying to contribute, but this isn't the place" [core] - 10https://gerrit.wikimedia.org/r/554976 (owner: 10Jeminbee) [04:26:22] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557157 (owner: 10DannyS712) [04:39:21] (03CR) 10DannyS712: Create UserGroupManager (034 comments) [core] - 10https://gerrit.wikimedia.org/r/545690 (https://phabricator.wikimedia.org/T234921) (owner: 10Ppchelko) [04:43:28] (03CR) 10DannyS712: ">" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/531571 (https://phabricator.wikimedia.org/T20520) (owner: 10DannyS712) [04:45:09] (03CR) 10DannyS712: [C: 04-1] "PermissionManager::$coreRights needs to be updated with `viewconfigurations` and `viewprivateconfigurations`" [core] - 10https://gerrit.wikimedia.org/r/327314 (owner: 10Florianschmidtwelzow) [04:46:04] (03CR) 10DannyS712: [C: 03+1] Change "articles" to "pages" in blockedtext-partial [core] - 10https://gerrit.wikimedia.org/r/544145 (owner: 10Amire80) [04:50:07] (03Abandoned) 10DannyS712: Expand overwriting redirects on moves, part 1 [core] - 10https://gerrit.wikimedia.org/r/538972 (https://phabricator.wikimedia.org/T232940) (owner: 10DannyS712) [04:52:03] (03PS15) 10Wugapodes: ChessBrowser: Unit tests for PgnParser and related bug fixes [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) [04:56:52] (03CR) 10jerkins-bot: [V: 04-1] ChessBrowser: Unit tests for PgnParser and related bug fixes [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [04:58:21] (03CR) 10DannyS712: "Recheck" [core] - 10https://gerrit.wikimedia.org/r/524397 (owner: 10Legoktm) [05:00:30] (03CR) 10DannyS712: [C: 04-1] "PermissionManager::$coreRights needs to be updated with `passwordreset`, and this is now 1.35" [core] - 10https://gerrit.wikimedia.org/r/506552 (owner: 10Gergő Tisza) [05:16:03] (03PS16) 10Wugapodes: ChessBrowser: Unit tests for PgnParser and related bug fixes [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) [05:20:58] (03CR) 10jerkins-bot: [V: 04-1] ChessBrowser: Unit tests for PgnParser and related bug fixes [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [05:34:18] (03PS17) 10Wugapodes: ChessBrowser: Unit tests for PgnParser and related bug fixes [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) [05:39:02] (03CR) 10jerkins-bot: [V: 04-1] ChessBrowser: Unit tests for PgnParser and related bug fixes [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [05:47:45] (03PS18) 10Wugapodes: ChessBrowser: Unit tests for PgnParser and related bug fixes [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) [05:54:19] (03CR) 10jerkins-bot: [V: 04-1] ChessBrowser: Unit tests for PgnParser and related bug fixes [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [06:39:09] (03PS19) 10Wugapodes: ChessBrowser: Unit tests for PgnParser and related bug fixes [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) [06:56:41] (03CR) 10Wugapodes: [C: 04-1] "JavaScript encounters runtime errors" [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [07:04:38] (03PS1) 10Legoktm: [WIP] Add sanity check test for domains.php [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/557160 (https://phabricator.wikimedia.org/T240743) [07:09:48] huh [07:11:05] (03PS2) 10Legoktm: Add sanity check test for domains.php [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/557160 (https://phabricator.wikimedia.org/T240743) [07:24:57] (03PS20) 10Wugapodes: ChessBrowser: Unit tests for PgnParser and related bug fixes [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) [07:25:46] (03CR) 10Wugapodes: [C: 04-1] "Game notation isn't showing up, but the ui builds at least" [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [07:58:23] (03PS4) 10Legoktm: registration: Implement lazy-loaded attributes [core] - 10https://gerrit.wikimedia.org/r/556790 (https://phabricator.wikimedia.org/T220994) [08:09:29] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [core] - 10https://gerrit.wikimedia.org/r/556790 (https://phabricator.wikimedia.org/T220994) (owner: 10Legoktm) [08:10:07] (03CR) 10jerkins-bot: [V: 04-1] registration: Implement lazy-loaded attributes [core] - 10https://gerrit.wikimedia.org/r/556790 (https://phabricator.wikimedia.org/T220994) (owner: 10Legoktm) [08:22:38] (03PS5) 10Legoktm: registration: Implement lazy-loaded attributes [core] - 10https://gerrit.wikimedia.org/r/556790 (https://phabricator.wikimedia.org/T220994) [08:33:37] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [core] - 10https://gerrit.wikimedia.org/r/556790 (https://phabricator.wikimedia.org/T220994) (owner: 10Legoktm) [09:50:49] (03PS1) 10Pwirth: Fix doc blocks and line too long for phpcs [extensions/BlueSpiceInsertCategory] - 10https://gerrit.wikimedia.org/r/557161 [09:53:26] (03PS3) 10Legoktm: EditPage: Use DeprecationHelper to hard-deprecate properties [core] - 10https://gerrit.wikimedia.org/r/450176 [09:53:42] (03CR) 10Legoktm: "> Patch Set 1: Code-Review-1" [core] - 10https://gerrit.wikimedia.org/r/450176 (owner: 10Legoktm) [09:54:03] (03PS4) 10Legoktm: EditPage: Use DeprecationHelper to hard-deprecate properties [core] - 10https://gerrit.wikimedia.org/r/450176 [10:06:07] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/450176 (owner: 10Legoktm) [10:15:27] (03PS1) 10Physikerwelt: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MathSearch [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/557162 [10:15:49] (03Abandoned) 10Physikerwelt: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MathSearch [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/557162 (owner: 10Physikerwelt) [10:15:53] (03PS21) 10Wugapodes: ChessBrowser: Unit tests for PgnParser and related bug fixes [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) [10:20:40] (03CR) 10jerkins-bot: [V: 04-1] ChessBrowser: Unit tests for PgnParser and related bug fixes [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [10:21:52] (03PS22) 10Wugapodes: ChessBrowser: Unit tests for PgnParser and related bug fixes [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) [10:29:13] (03PS1) 10Daimona Eaytoy: [WIP] Stop using assertContains with string haystack [core] - 10https://gerrit.wikimedia.org/r/557164 (https://phabricator.wikimedia.org/T192167) [10:29:21] (03CR) 10Wugapodes: [V: 03+2] "JavaScript works and browser works as intended" [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [10:29:47] (03CR) 10Wugapodes: [V: 03+1] "Works as intended" [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [10:34:47] (03PS2) 10Daimona Eaytoy: [WIP] Stop using assertContains with string haystack [core] - 10https://gerrit.wikimedia.org/r/557164 (https://phabricator.wikimedia.org/T192167) [10:40:14] (03PS3) 10Daimona Eaytoy: [WIP] Stop using assertContains with string haystack [core] - 10https://gerrit.wikimedia.org/r/557164 (https://phabricator.wikimedia.org/T192167) [10:46:42] (03PS4) 10Daimona Eaytoy: [WIP] Stop using assertContains with string haystack [core] - 10https://gerrit.wikimedia.org/r/557164 (https://phabricator.wikimedia.org/T192167) [10:46:48] (03CR) 10Legoktm: [C: 03+2] Autofix 94 PHPUnit 8 compat issues [core] - 10https://gerrit.wikimedia.org/r/557026 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [11:00:12] (03Merged) 10jenkins-bot: Autofix 94 PHPUnit 8 compat issues [core] - 10https://gerrit.wikimedia.org/r/557026 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [11:00:36] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557164 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [11:01:33] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Stop using assertContains with string haystack [core] - 10https://gerrit.wikimedia.org/r/557164 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [11:04:38] (03PS5) 10Daimona Eaytoy: [WIP] Stop using assertContains with string haystack [core] - 10https://gerrit.wikimedia.org/r/557164 (https://phabricator.wikimedia.org/T192167) [11:13:13] (03PS1) 10Pwirth: Fix doc blocks, missing covers and´line too long for phpcs [extensions/BlueSpiceInsertFile] - 10https://gerrit.wikimedia.org/r/557169 [11:18:40] (03PS1) 10Pwirth: Fix doc blocks for phpcs [extensions/BlueSpiceInsertLink] - 10https://gerrit.wikimedia.org/r/557171 [11:19:40] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Stop using assertContains with string haystack [core] - 10https://gerrit.wikimedia.org/r/557164 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [11:20:27] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557164 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [11:20:31] (03PS6) 10Daimona Eaytoy: [WIP] Stop using assertContains with string haystack [core] - 10https://gerrit.wikimedia.org/r/557164 (https://phabricator.wikimedia.org/T192167) [11:20:48] (03PS7) 10Daimona Eaytoy: Stop using assertContains with string haystack [core] - 10https://gerrit.wikimedia.org/r/557164 (https://phabricator.wikimedia.org/T192167) [11:21:00] (03PS12) 10Daimona Eaytoy: Upgrade to PHPUnit 8 [core] - 10https://gerrit.wikimedia.org/r/552312 (https://phabricator.wikimedia.org/T192167) [11:22:17] (03PS1) 10Pwirth: Fix comments and line too long for phpcs [extensions/BlueSpiceInsertMagic] - 10https://gerrit.wikimedia.org/r/557176 [11:25:55] (03PS1) 10Pwirth: Fix missing covers for phpcs [extensions/BlueSpiceInterWikiLinks] - 10https://gerrit.wikimedia.org/r/557177 [11:27:50] (03PS1) 10Physikerwelt: DB: Use atomic instead of transaction [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/557178 [11:32:51] (03PS1) 10Pwirth: Fix doc blocks and line too long for phpcs [extensions/BlueSpiceMultiUpload] - 10https://gerrit.wikimedia.org/r/557181 [11:38:42] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557164 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [11:40:05] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/552312 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [11:40:35] (03CR) 10Fomafix: [C: 03+2] "This error was introduced in 202205c0." [skins/Vector] - 10https://gerrit.wikimedia.org/r/557153 (owner: 10VolkerE) [11:54:13] (03Merged) 10jenkins-bot: Fix CSS selector in 'print.less' [skins/Vector] - 10https://gerrit.wikimedia.org/r/557153 (owner: 10VolkerE) [12:00:21] (03PS3) 10Robert Vogel: Fix BookMeta dialog - Modified bookmeta could not be saved [extensions/BlueSpiceBookshelfUI] (REL1_31) - 10https://gerrit.wikimedia.org/r/556155 (owner: 10Dvogel hallowelt) [12:00:50] (03CR) 10Robert Vogel: [C: 03+2] Fix BookMeta dialog - Modified bookmeta could not be saved [extensions/BlueSpiceBookshelfUI] (REL1_31) - 10https://gerrit.wikimedia.org/r/556155 (owner: 10Dvogel hallowelt) [12:00:51] (03PS1) 10Robert Vogel: Fix BookMeta dialog - Modified bookmeta could not be saved [extensions/BlueSpiceBookshelfUI] - 10https://gerrit.wikimedia.org/r/557190 [12:00:55] (03CR) 10Robert Vogel: [C: 03+2] Fix BookMeta dialog - Modified bookmeta could not be saved [extensions/BlueSpiceBookshelfUI] - 10https://gerrit.wikimedia.org/r/557190 (owner: 10Robert Vogel) [12:01:01] (03PS1) 10Robert Vogel: Fix BookMeta dialog - Modified bookmeta could not be saved [extensions/BlueSpiceBookshelfUI] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557192 [12:01:04] (03CR) 10Robert Vogel: [C: 03+2] Fix BookMeta dialog - Modified bookmeta could not be saved [extensions/BlueSpiceBookshelfUI] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557192 (owner: 10Robert Vogel) [12:01:14] (03CR) 10Robert Vogel: [V: 03+2 C: 03+2] Fix BookMeta dialog - Modified bookmeta could not be saved [extensions/BlueSpiceBookshelfUI] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557192 (owner: 10Robert Vogel) [12:01:41] (03PS2) 10Awight: [WIP] Remove unchecked errors from function signature [core] - 10https://gerrit.wikimedia.org/r/556724 (https://phabricator.wikimedia.org/T240672) [12:01:43] (03PS1) 10Awight: [DNM] Safe upgrade for a new sniff: configure to check nothing [core] - 10https://gerrit.wikimedia.org/r/557193 (https://phabricator.wikimedia.org/T240672) [12:01:45] (03PS1) 10Awight: Easy exceptions to remove [core] - 10https://gerrit.wikimedia.org/r/557194 (https://phabricator.wikimedia.org/T240672) [12:01:47] (03PS1) 10Awight: [WIP] Exception annotations that might make sense [core] - 10https://gerrit.wikimedia.org/r/557195 (https://phabricator.wikimedia.org/T240672) [12:01:49] (03PS1) 10Awight: [WIP] Questionable exceptions [core] - 10https://gerrit.wikimedia.org/r/557196 (https://phabricator.wikimedia.org/T240672) [12:02:03] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/557189 (owner: 10Libraryupgrader) [12:02:47] (03CR) 10Physikerwelt: [C: 03+2] DB: Use atomic instead of transaction [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/557178 (owner: 10Physikerwelt) [12:03:18] (03Merged) 10jenkins-bot: Fix BookMeta dialog - Modified bookmeta could not be saved [extensions/BlueSpiceBookshelfUI] (REL1_31) - 10https://gerrit.wikimedia.org/r/556155 (owner: 10Dvogel hallowelt) [12:05:15] (03PS1) 10Physikerwelt: Remove references to PNG rendering mode [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/557197 [12:06:47] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Remove unchecked errors from function signature [core] - 10https://gerrit.wikimedia.org/r/556724 (https://phabricator.wikimedia.org/T240672) (owner: 10Awight) [12:07:10] (03CR) 10jerkins-bot: [V: 04-1] [DNM] Safe upgrade for a new sniff: configure to check nothing [core] - 10https://gerrit.wikimedia.org/r/557193 (https://phabricator.wikimedia.org/T240672) (owner: 10Awight) [12:07:31] (03CR) 10jerkins-bot: [V: 04-1] Easy exceptions to remove [core] - 10https://gerrit.wikimedia.org/r/557194 (https://phabricator.wikimedia.org/T240672) (owner: 10Awight) [12:08:00] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Exception annotations that might make sense [core] - 10https://gerrit.wikimedia.org/r/557195 (https://phabricator.wikimedia.org/T240672) (owner: 10Awight) [12:08:22] (03Merged) 10jenkins-bot: Fix BookMeta dialog - Modified bookmeta could not be saved [extensions/BlueSpiceBookshelfUI] - 10https://gerrit.wikimedia.org/r/557190 (owner: 10Robert Vogel) [12:08:24] (03Merged) 10jenkins-bot: DB: Use atomic instead of transaction [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/557178 (owner: 10Physikerwelt) [12:08:49] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Questionable exceptions [core] - 10https://gerrit.wikimedia.org/r/557196 (https://phabricator.wikimedia.org/T240672) (owner: 10Awight) [12:22:43] (03PS1) 10Pwirth: Fic doc blocks, comments, globals, missing covers, line too long for phpcs [extensions/BlueSpiceNamespaceManager] - 10https://gerrit.wikimedia.org/r/557207 [12:24:00] (03PS1) 10Daimona Eaytoy: Fix most PHPUnit 8 compat issues in DBless tests [core] - 10https://gerrit.wikimedia.org/r/557208 (https://phabricator.wikimedia.org/T192167) [12:27:10] (03PS1) 10Pwirth: Fix use statements and doc blocks for phpcs [extensions/BlueSpicePageAccess] - 10https://gerrit.wikimedia.org/r/557209 [12:30:37] (03CR) 10Physikerwelt: [C: 03+2] Remove references to PNG rendering mode [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/557197 (owner: 10Physikerwelt) [12:31:06] (03Merged) 10jenkins-bot: Remove references to PNG rendering mode [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/557197 (owner: 10Physikerwelt) [12:32:45] (03PS1) 10Physikerwelt: Increase fault tolerance [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/557211 [12:33:11] (03CR) 10jerkins-bot: [V: 04-1] Increase fault tolerance [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/557211 (owner: 10Physikerwelt) [12:38:37] (03PS1) 10Pwirth: Fix doc blocks, assignments issues and line too long for phpcs [extensions/BlueSpicePageFormsConnector] - 10https://gerrit.wikimedia.org/r/557214 [12:40:39] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557208 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [12:42:23] (03PS1) 10Pwirth: Fix doc blocks for phpcs [extensions/BlueSpicePageTemplates] - 10https://gerrit.wikimedia.org/r/557216 [12:45:02] (03CR) 10jerkins-bot: [V: 04-1] Fix doc blocks for phpcs [extensions/BlueSpicePageTemplates] - 10https://gerrit.wikimedia.org/r/557216 (owner: 10Pwirth) [12:46:13] (03PS1) 10Daimona Eaytoy: Fixes for PHPUnit 8 compat in DB suite [core] - 10https://gerrit.wikimedia.org/r/557219 (https://phabricator.wikimedia.org/T192167) [12:51:15] (03PS2) 10Physikerwelt: Increase fault tolerance [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/557211 [12:52:22] (03PS1) 10Daimona Eaytoy: [DNM] Jenkins test [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/557221 [12:54:50] (03CR) 10jerkins-bot: [V: 04-1] [DNM] Jenkins test [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/557221 (owner: 10Daimona Eaytoy) [12:55:02] (03CR) 10Physikerwelt: [C: 03+2] Increase fault tolerance [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/557211 (owner: 10Physikerwelt) [12:55:26] (03Merged) 10jenkins-bot: Increase fault tolerance [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/557211 (owner: 10Physikerwelt) [12:58:32] (03CR) 10jerkins-bot: [V: 04-1] Fix doc blocks, assignments issues and line too long for phpcs [extensions/BlueSpicePageFormsConnector] - 10https://gerrit.wikimedia.org/r/557214 (owner: 10Pwirth) [12:59:30] (03PS2) 10Jack Phoenix: Expose OutputPage and ParserOutput objects to subscribers of the OpenGraphMetaHeaders hook [extensions/OpenGraphMeta] - 10https://gerrit.wikimedia.org/r/554031 [13:00:51] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/557222 (owner: 10Libraryupgrader) [13:04:22] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557219 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [13:12:39] (03PS1) 10Pwirth: Fix comments, doc blocks, use statements for phpcs [extensions/BlueSpicePermissionManager] - 10https://gerrit.wikimedia.org/r/557224 [13:15:42] (03CR) 10Pwirth: "recheck" [extensions/BlueSpicePageTemplates] - 10https://gerrit.wikimedia.org/r/557216 (owner: 10Pwirth) [13:15:49] (03CR) 10Pwirth: "recheck" [extensions/BlueSpicePageFormsConnector] - 10https://gerrit.wikimedia.org/r/557214 (owner: 10Pwirth) [13:20:29] (03CR) 10Physikerwelt: Add popup support for annotated math (032 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/527547 (https://phabricator.wikimedia.org/T208758) (owner: 10AndreG-P) [13:25:12] (03Abandoned) 10Awight: [DNM] Safe upgrade for a new sniff: configure to check nothing [core] - 10https://gerrit.wikimedia.org/r/557193 (https://phabricator.wikimedia.org/T240672) (owner: 10Awight) [13:33:12] (03PS1) 10Awight: Cleanup: const access [core] - 10https://gerrit.wikimedia.org/r/557228 [13:34:20] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [extensions/PagePopups] - 10https://gerrit.wikimedia.org/r/557227 (owner: 10Libraryupgrader) [13:42:08] (03PS1) 10Awight: Fix documentation for exception thrown [core] - 10https://gerrit.wikimedia.org/r/557233 [13:47:16] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557228 (owner: 10Awight) [13:53:42] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557233 (owner: 10Awight) [14:13:43] (03Abandoned) 10Awight: [WIP] Remove unchecked errors from function signature [core] - 10https://gerrit.wikimedia.org/r/556724 (https://phabricator.wikimedia.org/T240672) (owner: 10Awight) [14:15:13] (03Abandoned) 10Awight: [WIP] Exception annotations that might make sense [core] - 10https://gerrit.wikimedia.org/r/557195 (https://phabricator.wikimedia.org/T240672) (owner: 10Awight) [14:15:35] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [extensions/PhpTagsMaps] - 10https://gerrit.wikimedia.org/r/557244 (owner: 10Libraryupgrader) [14:16:18] (03PS2) 10Awight: Document exceptions [core] - 10https://gerrit.wikimedia.org/r/557196 [14:16:39] (03PS2) 10Awight: Remove unchecked exception annotations [core] - 10https://gerrit.wikimedia.org/r/557194 (https://phabricator.wikimedia.org/T240672) [14:20:22] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [extensions/PhpTagsStorage] - 10https://gerrit.wikimedia.org/r/557247 (owner: 10Libraryupgrader) [14:28:04] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557196 (owner: 10Awight) [14:29:39] (03CR) 10jerkins-bot: [V: 04-1] Remove unchecked exception annotations [core] - 10https://gerrit.wikimedia.org/r/557194 (https://phabricator.wikimedia.org/T240672) (owner: 10Awight) [14:31:13] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557194 (https://phabricator.wikimedia.org/T240672) (owner: 10Awight) [14:39:48] (03PS1) 10Devansh2002: Subject: GOOGLE CODE IN TASK DESCIPTION: Learn how to use Gerrit for code review, by submitting a patch. I have added a file with my username. the file a txt file. [sandbox] - 10https://gerrit.wikimedia.org/r/557254 [14:39:50] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [sandbox] - 10https://gerrit.wikimedia.org/r/557254 (owner: 10Devansh2002) [14:51:51] (03CR) 10Gopavasanth: "> Thank you for making your first contribution to Wikimedia! :) To" (032 comments) [sandbox] - 10https://gerrit.wikimedia.org/r/557254 (owner: 10Devansh2002) [15:02:33] (03CR) 10Awight: "This should include qunit and browser tests." [core] - 10https://gerrit.wikimedia.org/r/553376 (https://phabricator.wikimedia.org/T235189) (owner: 10Jason Linehan) [15:03:40] (03PS3) 10Awight: Remove unchecked exception annotations [core] - 10https://gerrit.wikimedia.org/r/557194 (https://phabricator.wikimedia.org/T240672) [15:06:05] (03PS2) 10Devansh2002: GOOGLE CODE IN TASK [sandbox] - 10https://gerrit.wikimedia.org/r/557254 [15:15:20] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557194 (https://phabricator.wikimedia.org/T240672) (owner: 10Awight) [15:16:22] (03CR) 10jerkins-bot: [V: 04-1] Remove unchecked exception annotations [core] - 10https://gerrit.wikimedia.org/r/557194 (https://phabricator.wikimedia.org/T240672) (owner: 10Awight) [15:20:11] (03CR) 10Ebe123: [V: 03+2 C: 03+2] GOOGLE CODE IN TASK [sandbox] - 10https://gerrit.wikimedia.org/r/557254 (owner: 10Devansh2002) [15:20:27] (03CR) 10Ebe123: GOOGLE CODE IN TASK [sandbox] - 10https://gerrit.wikimedia.org/r/557254 (owner: 10Devansh2002) [15:25:58] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [extensions/Polyglot] - 10https://gerrit.wikimedia.org/r/557251 (owner: 10Libraryupgrader) [15:28:39] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [extensions/PopcornEditor] - 10https://gerrit.wikimedia.org/r/557256 (owner: 10Libraryupgrader) [15:32:31] (03PS1) 10Jack Phoenix: Tiny i18n-related UI fix for MW 1.34+ [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/557260 [15:33:18] (03CR) 10jerkins-bot: [V: 04-1] Tiny i18n-related UI fix for MW 1.34+ [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/557260 (owner: 10Jack Phoenix) [15:36:04] (03PS1) 10Devansh2002: GOOGLE CODE IN TASK [sandbox] - 10https://gerrit.wikimedia.org/r/557261 [15:44:47] (03CR) 10Robert Vogel: [C: 03+2] Fix UnrecognizedAnnotation for phpcs [extensions/BlueSpiceAvatars] - 10https://gerrit.wikimedia.org/r/556874 (owner: 10Pwirth) [15:46:35] (03CR) 10Robert Vogel: [C: 03+2] Fix missing public function doc for phpcs [extensions/BlueSpiceCategoryManager] - 10https://gerrit.wikimedia.org/r/556875 (owner: 10Pwirth) [15:46:52] (03PS1) 10Robert Vogel: Fix missing public function doc for phpcs [extensions/BlueSpiceCategoryManager] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557262 [15:46:56] (03CR) 10Robert Vogel: [C: 03+2] Fix missing public function doc for phpcs [extensions/BlueSpiceCategoryManager] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557262 (owner: 10Robert Vogel) [15:47:20] James_F: around to review https://gerrit.wikimedia.org/r/c/mediawiki/extensions/NewUserMessage/+/556983 / https://codein.withgoogle.com/dashboard/task-instances/5232919421911040/? Close to 36 hours deadline :/ [15:47:22] (03Merged) 10jenkins-bot: Fix missing public function doc for phpcs [extensions/BlueSpiceCategoryManager] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557262 (owner: 10Robert Vogel) [15:47:30] (03Merged) 10jenkins-bot: Fix UnrecognizedAnnotation for phpcs [extensions/BlueSpiceAvatars] - 10https://gerrit.wikimedia.org/r/556874 (owner: 10Pwirth) [15:47:32] (03Merged) 10jenkins-bot: Fix missing public function doc for phpcs [extensions/BlueSpiceCategoryManager] - 10https://gerrit.wikimedia.org/r/556875 (owner: 10Pwirth) [15:48:17] (03CR) 10Robert Vogel: [C: 03+2] Fix missing docs, function scope declaration and lines to long for phpcs [extensions/BlueSpiceChecklist] - 10https://gerrit.wikimedia.org/r/556972 (owner: 10Pwirth) [15:48:42] (03Merged) 10jenkins-bot: Fix missing docs, function scope declaration and lines to long for phpcs [extensions/BlueSpiceChecklist] - 10https://gerrit.wikimedia.org/r/556972 (owner: 10Pwirth) [15:49:45] (03CR) 10Robert Vogel: [C: 03+2] Fix doc blocks, lines too long, assignments in controll structures for phpcs [extensions/BlueSpiceConfigManager] - 10https://gerrit.wikimedia.org/r/556975 (owner: 10Pwirth) [15:50:48] (03CR) 10Robert Vogel: [C: 03+2] Fix missing covers for phpcs [extensions/BlueSpiceContextMenu] - 10https://gerrit.wikimedia.org/r/556977 (owner: 10Pwirth) [15:50:53] (03PS1) 10Robert Vogel: Fix missing covers for phpcs [extensions/BlueSpiceContextMenu] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557263 [15:50:57] (03CR) 10Robert Vogel: [C: 03+2] Fix missing covers for phpcs [extensions/BlueSpiceContextMenu] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557263 (owner: 10Robert Vogel) [15:51:03] (03PS1) 10Robert Vogel: Fix missing covers for phpcs [extensions/BlueSpiceContextMenu] (REL1_31) - 10https://gerrit.wikimedia.org/r/557264 [15:51:08] (03CR) 10Robert Vogel: [C: 03+2] Fix missing covers for phpcs [extensions/BlueSpiceContextMenu] (REL1_31) - 10https://gerrit.wikimedia.org/r/557264 (owner: 10Robert Vogel) [15:51:42] (03CR) 10Robert Vogel: [C: 03+2] Fix missing doc blocks for phpcs [extensions/BlueSpiceCountThings] - 10https://gerrit.wikimedia.org/r/556979 (owner: 10Pwirth) [15:52:26] (03CR) 10jerkins-bot: [V: 04-1] Fix missing covers for phpcs [extensions/BlueSpiceContextMenu] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557263 (owner: 10Robert Vogel) [15:53:00] (03Merged) 10jenkins-bot: Fix doc blocks, lines too long, assignments in controll structures for phpcs [extensions/BlueSpiceConfigManager] - 10https://gerrit.wikimedia.org/r/556975 (owner: 10Pwirth) [15:53:50] (03Merged) 10jenkins-bot: Fix missing covers for phpcs [extensions/BlueSpiceContextMenu] - 10https://gerrit.wikimedia.org/r/556977 (owner: 10Pwirth) [15:54:20] (03Merged) 10jenkins-bot: Fix missing covers for phpcs [extensions/BlueSpiceContextMenu] (REL1_31) - 10https://gerrit.wikimedia.org/r/557264 (owner: 10Robert Vogel) [15:57:25] (03Merged) 10jenkins-bot: Fix missing doc blocks for phpcs [extensions/BlueSpiceCountThings] - 10https://gerrit.wikimedia.org/r/556979 (owner: 10Pwirth) [16:18:53] (03CR) 10Bartosz Dziewoński: mw.Api: Add helper method #getErrorMessage (038 comments) [core] - 10https://gerrit.wikimedia.org/r/556314 (https://phabricator.wikimedia.org/T240519) (owner: 10Bartosz Dziewoński) [16:19:06] (03PS5) 10Bartosz Dziewoński: mw.Api: Add helper method #getErrorMessage [core] - 10https://gerrit.wikimedia.org/r/556314 (https://phabricator.wikimedia.org/T240519) [16:23:46] (03Abandoned) 10Devansh2002: GOOGLE CODE IN TASK [sandbox] - 10https://gerrit.wikimedia.org/r/557261 (owner: 10Devansh2002) [16:28:33] (03PS1) 10Devansh2002: GOOGLE CODE IN TASK [sandbox] - 10https://gerrit.wikimedia.org/r/557265 [16:34:06] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/556314 (https://phabricator.wikimedia.org/T240519) (owner: 10Bartosz Dziewoński) [16:38:24] (03PS1) 10Jack Phoenix: Bring back the old API module [extensions/WhosOnline] - 10https://gerrit.wikimedia.org/r/557266 [16:45:00] (03PS1) 10Devansh2002: Revert "GOOGLE CODE IN TASK" [sandbox] - 10https://gerrit.wikimedia.org/r/557267 [16:45:07] (03Abandoned) 10Devansh2002: Revert "GOOGLE CODE IN TASK" [sandbox] - 10https://gerrit.wikimedia.org/r/557267 (owner: 10Devansh2002) [17:04:43] (03PS4) 10Bartosz Dziewoński: ReplyWidget: Handle save errors [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/556315 (https://phabricator.wikimedia.org/T240519) [17:06:12] (03PS5) 10Bartosz Dziewoński: ReplyWidget: Handle save errors [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/556315 (https://phabricator.wikimedia.org/T240519) [17:42:17] (03PS1) 10Amire80: Remove double space from a message [extensions/Jade] - 10https://gerrit.wikimedia.org/r/557271 [17:47:37] (03CR) 10Amire80: Implement Api modules (031 comment) [extensions/Jade] - 10https://gerrit.wikimedia.org/r/536659 (https://phabricator.wikimedia.org/T199834) (owner: 10Accraze) [18:26:52] (03CR) 10Apap04: [V: 03+2 C: 03+2] GOOGLE CODE IN TASK [sandbox] - 10https://gerrit.wikimedia.org/r/557254 (owner: 10Devansh2002) [18:29:52] (03CR) 10Jack Phoenix: [C: 04-2] "cc'ing Tgr and Anomie for some comments as to what'd be the best way to move forward with this. Also, in addition to the stuff I noted in " [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/483784 (owner: 10Jack Phoenix) [18:58:55] (03PS1) 10RetroCraft: GCI Gerrit tutorial task [sandbox] - 10https://gerrit.wikimedia.org/r/557273 [18:58:57] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [sandbox] - 10https://gerrit.wikimedia.org/r/557273 (owner: 10RetroCraft) [19:21:11] (03PS24) 10DannyS712: [WIP] Add `delete-redirect` right to delete single-rev redirects during page moves [core] - 10https://gerrit.wikimedia.org/r/554365 [19:30:39] (03PS1) 10TK-999: upload: Improve method documentation blocks [core] - 10https://gerrit.wikimedia.org/r/557276 [19:32:56] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/554365 (owner: 10DannyS712) [19:34:13] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add `delete-redirect` right to delete single-rev redirects during page moves [core] - 10https://gerrit.wikimedia.org/r/554365 (owner: 10DannyS712) [19:38:07] (03CR) 10Brian Wolff: [C: 03+2] build: Use ESLint instead of JSHint [extensions/NewUserMessage] - 10https://gerrit.wikimedia.org/r/556983 (https://phabricator.wikimedia.org/T195542) (owner: 10Majavah) [19:38:42] (03CR) 10Jforrester: [C: 03+1] "Sorry, yeah, I forgot about this." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/528155 (https://phabricator.wikimedia.org/T101615) (owner: 10Urbanecm) [19:41:14] (03Merged) 10jenkins-bot: build: Use ESLint instead of JSHint [extensions/NewUserMessage] - 10https://gerrit.wikimedia.org/r/556983 (https://phabricator.wikimedia.org/T195542) (owner: 10Majavah) [19:43:24] (03PS25) 10DannyS712: [WIP] Add `delete-redirect` right to delete single-rev redirects during page moves [core] - 10https://gerrit.wikimedia.org/r/554365 [19:44:43] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557276 (owner: 10TK-999) [19:54:49] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/554365 (owner: 10DannyS712) [19:57:49] (03PS26) 10DannyS712: [WIP] Add `delete-redirect` right to delete single-rev redirects during page moves [core] - 10https://gerrit.wikimedia.org/r/554365 [19:58:48] (03CR) 10Jforrester: [C: 03+2] upload: Improve method documentation blocks [core] - 10https://gerrit.wikimedia.org/r/557276 (owner: 10TK-999) [20:08:46] (03PS1) 10Jack Phoenix: Make the DB slave lag warning CSS classes (mw-lag-warn-normal, mw-lag-warn-high) greppable [core] - 10https://gerrit.wikimedia.org/r/557277 [20:11:58] (03Merged) 10jenkins-bot: upload: Improve method documentation blocks [core] - 10https://gerrit.wikimedia.org/r/557276 (owner: 10TK-999) [20:12:15] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/554365 (owner: 10DannyS712) [20:16:34] (03CR) 10Umherirrender: [C: 03+2] Remove double space from a message [extensions/Jade] - 10https://gerrit.wikimedia.org/r/557271 (owner: 10Amire80) [20:17:42] (03CR) 10Raimond Spekking: [C: 03+2] Change "articles" to "pages" in blockedtext-partial [core] - 10https://gerrit.wikimedia.org/r/544145 (owner: 10Amire80) [20:19:59] (03PS3) 10Jforrester: Follow-up 94582698c3: Fix references to injection.txt, now Injection.md [core] - 10https://gerrit.wikimedia.org/r/557157 (owner: 10DannyS712) [20:20:07] (03CR) 10Jforrester: [C: 03+2] Follow-up 94582698c3: Fix references to injection.txt, now Injection.md [core] - 10https://gerrit.wikimedia.org/r/557157 (owner: 10DannyS712) [20:20:52] (03Merged) 10jenkins-bot: Remove double space from a message [extensions/Jade] - 10https://gerrit.wikimedia.org/r/557271 (owner: 10Amire80) [20:22:05] (03CR) 10Umherirrender: [V: 03+2] "It seems the necessary package failed to install" [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/557189 (owner: 10Libraryupgrader) [20:22:57] (03CR) 10Umherirrender: [V: 03+2] build: Updating grunt-banana-checker to 0.8.1 [extensions/PGFTikZ] - 10https://gerrit.wikimedia.org/r/557222 (owner: 10Libraryupgrader) [20:22:59] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557277 (owner: 10Jack Phoenix) [20:23:24] (03CR) 10Umherirrender: [V: 03+2] build: Updating grunt-banana-checker to 0.8.1 [extensions/PagePopups] - 10https://gerrit.wikimedia.org/r/557227 (owner: 10Libraryupgrader) [20:23:39] (03CR) 10Umherirrender: "recheck" [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/557243 (owner: 10Libraryupgrader) [20:23:57] (03CR) 10Umherirrender: [V: 03+2] build: Updating grunt-banana-checker to 0.8.1 [extensions/PhpTagsMaps] - 10https://gerrit.wikimedia.org/r/557244 (owner: 10Libraryupgrader) [20:24:41] (03CR) 10Umherirrender: [V: 03+2] "Needs update for newer phpunit version" [extensions/PhpTagsStorage] - 10https://gerrit.wikimedia.org/r/557247 (owner: 10Libraryupgrader) [20:24:52] (03PS2) 10Legoktm: OutputPage: Make the DB replica lag warning CSS classes greppable [core] - 10https://gerrit.wikimedia.org/r/557277 (owner: 10Jack Phoenix) [20:25:00] (03CR) 10Legoktm: [C: 03+2] OutputPage: Make the DB replica lag warning CSS classes greppable [core] - 10https://gerrit.wikimedia.org/r/557277 (owner: 10Jack Phoenix) [20:25:13] (03CR) 10Umherirrender: [V: 03+2] build: Updating grunt-banana-checker to 0.8.1 [extensions/Polyglot] - 10https://gerrit.wikimedia.org/r/557251 (owner: 10Libraryupgrader) [20:25:38] (03CR) 10Umherirrender: [V: 03+2] build: Updating grunt-banana-checker to 0.8.1 [extensions/PopcornEditor] - 10https://gerrit.wikimedia.org/r/557256 (owner: 10Libraryupgrader) [20:26:37] (03CR) 10Umherirrender: [V: 03+2] "No jenkins here" [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/557243 (owner: 10Libraryupgrader) [20:29:22] (03Merged) 10jenkins-bot: Change "articles" to "pages" in blockedtext-partial [core] - 10https://gerrit.wikimedia.org/r/544145 (owner: 10Amire80) [20:31:04] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557157 (owner: 10DannyS712) [20:32:19] (03Merged) 10jenkins-bot: Follow-up 94582698c3: Fix references to injection.txt, now Injection.md [core] - 10https://gerrit.wikimedia.org/r/557157 (owner: 10DannyS712) [20:38:05] (03Merged) 10jenkins-bot: OutputPage: Make the DB replica lag warning CSS classes greppable [core] - 10https://gerrit.wikimedia.org/r/557277 (owner: 10Jack Phoenix) [20:39:05] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557277 (owner: 10Jack Phoenix) [21:07:01] (03PS3) 10Amire80: Slightly rephrase blockedtext and autoblockedtext [core] - 10https://gerrit.wikimedia.org/r/556656 [21:21:22] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/556656 (owner: 10Amire80) [21:36:53] (03PS1) 10Ephemeralwaves: Selenium: refactor TemplateWizard.js test [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/557278 (https://phabricator.wikimedia.org/T240766) [21:39:33] (03CR) 10Ephemeralwaves: Selenium: refactor TemplateWizard.js test (031 comment) [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/557278 (https://phabricator.wikimedia.org/T240766) (owner: 10Ephemeralwaves) [22:04:18] 10MediaWiki-extensions-FlaggedRevs, 10User-DannyS712: Special:ReviewedVersions - raw shown - https://phabricator.wikimedia.org/T240768 (10DannyS712) [22:05:47] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Link preview in edit mode don't work if [[xy|xx]] - https://phabricator.wikimedia.org/T240769 (10Janbery) [22:05:49] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Link preview in edit mode don't work if [[xy|xx]] - https://phabricator.wikimedia.org/T240769 (10Urbanecm) [22:09:15] 10MediaWiki-extensions-FlaggedRevs, 10User-DannyS712: Special:ReviewedPages - Special:ReviewedVersions links double escaped - https://phabricator.wikimedia.org/T240770 (10DannyS712) Same issue with double quotes - search for `FOX News previews Grafton Street restaurant and "voice collector" in Harvard Square,... [22:16:35] (03PS1) 10Urbanecm: docs: Tin is no longer the deployment host, using mwdebug1002 is discouradged [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/557279 [22:29:35] 10MediaWiki-Search, 10Discovery-Search, 10Readers-Web-Backlog, 10TextExtracts, 10Performance-Team (Radar): TextExtracts extension frequent slows down opensearch API by several seconds - https://phabricator.wikimedia.org/T240691 (10Krinkle) >>! In T240691#5740295, @Anomie wrote: >> As such, I would recomm... [22:45:13] 04(no projects): Create a wiki for Wikimedia User Group Nigeria - https://phabricator.wikimedia.org/T240771 (10Ammarpad) [22:45:32] 10Wiki-Setup: Create a wiki for Wikimedia User Group Nigeria - https://phabricator.wikimedia.org/T240771 (10Ammarpad) [22:47:23] 04(no projects): Prepare and check storage layer for ngwikimedia - https://phabricator.wikimedia.org/T240772 (10Ammarpad) [22:48:38] (03PS4) 10Awight: Remove unchecked exception annotations [core] - 10https://gerrit.wikimedia.org/r/557194 (https://phabricator.wikimedia.org/T240672) [22:49:05] 10Wiki-Setup: Create a wiki for Wikimedia User Group Nigeria - https://phabricator.wikimedia.org/T240771 (10Ammarpad) [22:49:09] 04(no projects): Prepare and check storage layer for ngwikimedia - https://phabricator.wikimedia.org/T240772 (10Ammarpad) [22:50:54] (03PS2) 10Pwirth: Fix doc blocks for phpcs [extensions/BlueSpicePageTemplates] - 10https://gerrit.wikimedia.org/r/557216 [22:51:39] (03CR) 10Pwirth: "recheck" [extensions/BlueSpicePageFormsConnector] - 10https://gerrit.wikimedia.org/r/557214 (owner: 10Pwirth) [22:53:47] (03CR) 10Pwirth: [V: 03+2] Fix missing covers for phpcs [extensions/BlueSpiceContextMenu] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/557263 (owner: 10Robert Vogel) [23:00:08] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557194 (https://phabricator.wikimedia.org/T240672) (owner: 10Awight) [23:01:18] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [extensions/SectionDisqus] - 10https://gerrit.wikimedia.org/r/557283 (owner: 10Libraryupgrader) [23:05:39] (03PS5) 10Awight: Remove unchecked exception annotations [core] - 10https://gerrit.wikimedia.org/r/557194 (https://phabricator.wikimedia.org/T240672) [23:08:26] 10MediaWiki-Search, 10Discovery-Search, 10Readers-Web-Backlog, 10TextExtracts, 10Performance-Team (Radar): TextExtracts extension frequent slows down opensearch API by several seconds - https://phabricator.wikimedia.org/T240691 (10Krinkle) >>! In T240691#5740295, @Anomie wrote: > As for the extracts spec... [23:16:11] (03CR) 10Legoktm: [C: 03+2] build: Updating grunt-banana-checker to 0.8.1 [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/557286 (owner: 10Libraryupgrader) [23:16:30] (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [extensions/SelectCategory] - 10https://gerrit.wikimedia.org/r/557288 (owner: 10Libraryupgrader) [23:17:09] (03CR) 10SonarQube Bot: "✔ Quality gate passed!" [core] - 10https://gerrit.wikimedia.org/r/557194 (https://phabricator.wikimedia.org/T240672) (owner: 10Awight) [23:18:11] 10wikimedia.biterg.io, 10Developer-Advocacy (Jan-Mar 2020), 10Documentation: Document and communicate recent functionality and data improvements on wikimedia.biterg.io - https://phabricator.wikimedia.org/T240591 (10Aklapper) > Cover some "How can I..." use cases Initial version at https://www.mediawiki.org/w... [23:19:04] 04(no projects): OAuth errors not rendered properly - https://phabricator.wikimedia.org/T240774 (10Ammarpad) [23:21:10] 10MediaWiki-extensions-OAuth: OAuth errors not rendered properly - https://phabricator.wikimedia.org/T240774 (10Ammarpad) [23:22:13] 10MediaWiki-extensions-OAuth: OAuth errors not rendered properly - https://phabricator.wikimedia.org/T240774 (10Ammarpad) [23:22:27] 10MediaWiki-Patrolling: Undo should auto-patrol reverted revisions, like a rollback does - https://phabricator.wikimedia.org/T16439 (10Krinkle) The rollback feature has as benefit that it can undo multiple edits at once, and it is does not allow for changing the new revision. It cleanly and automatically restore... [23:43:00] 10WMSE-Magnus Sälgö: Europeana Entity <-> Wikidata Property 7704 - https://phabricator.wikimedia.org/T240290 (10Salgo60) [23:43:50] 10WMSE-Magnus Sälgö: Europeana Entity <-> Wikidata Property 7704 - https://phabricator.wikimedia.org/T240290 (10Salgo60) [23:51:15] (03PS3) 10Zoranzoki21: GOOGLE CODE IN TASK [sandbox] - 10https://gerrit.wikimedia.org/r/557254 (owner: 10Devansh2002) [23:51:42] 10TechCom-RFC: Support PHP 7.4 preload - https://phabricator.wikimedia.org/T240775 (10Florian) [23:52:16] (03CR) 10Zoranzoki21: [V: 03+2] GOOGLE CODE IN TASK [sandbox] - 10https://gerrit.wikimedia.org/r/557254 (owner: 10Devansh2002) [23:52:54] (03CR) 10Zoranzoki21: [V: 03+2 C: 03+2] "Good to go!" [sandbox] - 10https://gerrit.wikimedia.org/r/557273 (owner: 10RetroCraft) [23:55:56] 10TechCom-RFC: Support PHP 7.4 preload - https://phabricator.wikimedia.org/T240775 (10Florian) Based on the script published in the original php RfC, I build a preload file for my local environment to see what's going on: ` (03CR) 10jerkins-bot: [V: 04-1] build: Updating grunt-banana-checker to 0.8.1 [extensions/SideBarMenu] - 10https://gerrit.wikimedia.org/r/557313 (owner: 10Libraryupgrader) [23:59:18] (03PS9) 10Krinkle: hygiene: refactor phpunit assertions [core] - 10https://gerrit.wikimedia.org/r/535280 (owner: 10Pmiazga) [23:59:55] (03CR) 10jerkins-bot: [V: 04-1] hygiene: refactor phpunit assertions [core] - 10https://gerrit.wikimedia.org/r/535280 (owner: 10Pmiazga)