[00:02:25] 10MediaWiki-extensions-FlaggedRevs, 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): Note about flagged revisions needs hide option - https://phabricator.wikimedia.org/T237246 (10Jdlrobson) @Zache those replication instructions are brilliant - one bit missing - the user has to h... [00:04:51] 10Readers-Web-Backlog (Kanbanana-2019-20-Q2), 10Regression: Regression: Label is visible on Logout button for logged in users on all wikis (non-AMC) - https://phabricator.wikimedia.org/T240644 (10Jdlrobson) [00:04:57] 10Readers-Web-Backlog (Kanbanana-2019-20-Q2), 10Regression: Regression: Label is visible on Logout button for logged in users on all wikis (non-AMC) - https://phabricator.wikimedia.org/T240644 (10Jdlrobson) p:05Triage→03High [00:05:18] (03PS1) 10Catrope: ResourceLoader: Fix infinite loop in RLQ processing [core] - 10https://gerrit.wikimedia.org/r/556835 [00:05:38] (03CR) 10Catrope: resourceloader: Remove redundant 'window' indirection (031 comment) [core] - 10https://gerrit.wikimedia.org/r/503706 (owner: 10Krinkle) [00:06:39] (03Merged) 10jenkins-bot: Live preview [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/554897 (owner: 10Esanders) [00:10:57] (03Abandoned) 10Jdlrobson: A language icon shows next to languages header [skins/Vector] - 10https://gerrit.wikimedia.org/r/479718 (https://phabricator.wikimedia.org/T211985) (owner: 10Jdlrobson) [00:13:05] 10MediaWiki-Page-protection: Privileged users see "view source" on cascade protected page - https://phabricator.wikimedia.org/T240532 (10Ammarpad) I cannot reproduce this. I am also interested in knowing where that colorful box comes from. {F31474194} [00:14:46] (03CR) 10Catrope: "Background: Thanks to Sam Wilson for tracking this down" [core] - 10https://gerrit.wikimedia.org/r/556835 (owner: 10Catrope) [00:14:47] 10Advanced Mobile Contributions, 10MinervaNeue, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): [Bug] Simplified Talk Page Does Not Support Sections With Non-ascii Characters/Several ascii characters aren't supported either - https://phabricator.wikimedia.org/T238364 (10Jdlrobson) I guess... [00:16:32] (03Restored) 10Jdlrobson: POC: Use display locking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/544236 (https://phabricator.wikimedia.org/T230941) (owner: 10Jdlrobson) [00:19:06] 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): Placeholder: Run display locking origin trial - https://phabricator.wikimedia.org/T239295 (10Jdlrobson) @gilles I'm a bit lost with what I need to do to https://gerrit.wikimedia.org/r/#/c/mediawiki/ext... [00:20:27] (03PS2) 10Jdlrobson: WIP: Use display locking for origin trial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/544236 (https://phabricator.wikimedia.org/T239295) [00:20:44] (03CR) 10jerkins-bot: [V: 04-1] WIP: Use display locking for origin trial [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/544236 (https://phabricator.wikimedia.org/T239295) (owner: 10Jdlrobson) [00:25:39] (03CR) 10Brian Wolff: [C: 03+2] Fix $wgNoCatShowCat configuration setting [extensions/NoCat] - 10https://gerrit.wikimedia.org/r/556825 (https://phabricator.wikimedia.org/T203733) (owner: 10Pppery) [00:28:32] (03Merged) 10jenkins-bot: Fix $wgNoCatShowCat configuration setting [extensions/NoCat] - 10https://gerrit.wikimedia.org/r/556825 (https://phabricator.wikimedia.org/T203733) (owner: 10Pppery) [00:31:04] (03Abandoned) 10Nray: Make toolbar on user talk page match toolbar on user page [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556294 (https://phabricator.wikimedia.org/T235681) (owner: 10Nray) [00:31:17] 10CheckUser, 10Anti-Harassment (The Letter Song), 10Patch-For-Review: CU 2.0: Fetch information to be displayed in Compare tab - https://phabricator.wikimedia.org/T238714 (10Niharika) >>! In T238714#5737570, @dmaza wrote: > So just to be clear, what goes inside the parenthesis in the IP column should be UA i... [00:31:28] (03Abandoned) 10Nray: Remove $userPageHelper param from UserNamespaceOverflowBuilder [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556508 (https://phabricator.wikimedia.org/T235681) (owner: 10Nray) [00:33:56] 10Trust-and-Safety, 10Privacy, 10Security: Set channel cmode +S for wikimedia private IRC-Channels - https://phabricator.wikimedia.org/T152926 (10Luke081515) [00:36:35] (03CR) 10Zoranzoki21: ChessBrowser: Unit tests for PgnParser and related bug fixes (031 comment) [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [00:36:49] 10MediaWiki-extensions-Gadgets, 10JavaScript: Run QUnit tests for gadgets and user scripts during edit preview - https://phabricator.wikimedia.org/T240647 (10Evad37) [00:37:01] (03CR) 10Zoranzoki21: [C: 04-1] "Please create .gitignore with including node_modules and vendor directories in it." [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [00:37:18] 10MediaWiki-extensions-Gadgets, 10JavaScript: Run QUnit tests for gadgets and user scripts during edit preview - https://phabricator.wikimedia.org/T240647 (10Evad37) [00:37:20] 10MediaWiki-extensions-Gadgets, 10JavaScript: Provide standard way to create/run QUnit tests for Gadgets and user scripts - https://phabricator.wikimedia.org/T39230 (10Evad37) [00:37:51] (03CR) 10Jforrester: "> Patch Set 7:" [extensions/ChessBrowser] - 10https://gerrit.wikimedia.org/r/554214 (https://phabricator.wikimedia.org/T239529) (owner: 10Wugapodes) [00:40:03] (03PS1) 10Jdrewniak: Prevent text from showing in main-menu logout button [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556838 (https://phabricator.wikimedia.org/T240644) [00:42:29] 10WatchTranslations: Add link to git repo in footer - https://phabricator.wikimedia.org/T240604 (10Arcayn) a:03Arcayn [00:44:35] (03PS1) 10Jdlrobson: Talk headings should work with ascii characters [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556840 (https://phabricator.wikimedia.org/T238364) [00:45:31] 10Advanced Mobile Contributions, 10MinervaNeue, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): [Bug] Simplified Talk Page Does Not Support Sections With Non-ascii Characters/Several ascii characters aren't supported either - https://phabricator.wikimedia.org/T238364 (10Jdlrobson) Looking... [00:45:47] (03CR) 10Jdlrobson: "See https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/556840 Talk headings should work with ascii characters" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/548945 (https://phabricator.wikimedia.org/T238364) (owner: 10Nray) [00:47:53] 10MediaWiki-extensions-CategoryTree, 10Google-Code-in-2019: $wgCategoryTreeMaxDepth broken (Something wrong with how extension registration merges values?) - https://phabricator.wikimedia.org/T240623 (10Bawolff) [00:48:02] (03CR) 10Jdlrobson: [C: 03+2] "Note: Could also put it on the span." [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556838 (https://phabricator.wikimedia.org/T240644) (owner: 10Jdrewniak) [00:48:36] 10Advanced Mobile Contributions, 10MinervaNeue, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): [Bug] Simplified Talk Page Does Not Support Sections With Non-ascii Characters/Several ascii characters aren't supported either - https://phabricator.wikimedia.org/T238364 (10Jdlrobson) p:05No... [00:50:50] 10WatchTranslations, 10Google-Code-in-2019: Add preference to choose interface language - https://phabricator.wikimedia.org/T240320 (10Arcayn) a:03Arcayn [00:51:12] 10MediaWiki-extensions-CategoryTree, 10Google-Code-in-2019: $wgCategoryTreeMaxDepth broken (Incorrect merge method used in extension.json) - https://phabricator.wikimedia.org/T240623 (10Bawolff) [00:53:14] 10MediaWiki-extensions-Other, 10Google-Code-in-2019, 10Patch-For-Review, 10good first task: Replace usage of ParserOutputHook in Extension:NoCat with OutputPageParserOutput hook - https://phabricator.wikimedia.org/T203733 (10Bawolff) 05Open→03Resolved Looks good. [00:56:22] (03CR) 10Jdlrobson: [C: 04-2] "variable @font-size-body is undefined in file" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/555015 (owner: 10VolkerE) [00:57:13] (03CR) 10jerkins-bot: [V: 04-1] Talk headings should work with ascii characters [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556840 (https://phabricator.wikimedia.org/T238364) (owner: 10Jdlrobson) [00:59:02] (03PS1) 10Zoranzoki21: Remove jshint and update package.json [extensions/DoubleWiki] - 10https://gerrit.wikimedia.org/r/556842 (https://phabricator.wikimedia.org/T195542) [01:00:08] 10MediaWiki-extensions-WikibaseClient, 10SDC General, 10Wikibase-Lua, 10Wikidata, 10Structured-Data-Backlog (Current Work): Structured Data on Commons entities returned by mw.wikibase.getEntity lua function differ based on language of the viewer - https://phabricator.wikimedia.org/T238484 (10nettrom_WMF)... [01:00:33] (03Merged) 10jenkins-bot: Prevent text from showing in main-menu logout button [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556838 (https://phabricator.wikimedia.org/T240644) (owner: 10Jdrewniak) [01:00:49] (03PS2) 10Zoranzoki21: Remove jshint and update package.json [extensions/DoubleWiki] - 10https://gerrit.wikimedia.org/r/556842 (https://phabricator.wikimedia.org/T195542) [01:00:51] (03PS1) 10Nray: Don't pass unescaped html into Section [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556843 (https://phabricator.wikimedia.org/T240487) [01:02:24] 10MediaWiki-Search, 10Commons, 10Discovery, 10Structured Data Engineering, and 3 others: Make it possible to bypass automatic redirection to exact matches in commons - https://phabricator.wikimedia.org/T235263 (10Josve05a) Umm...what?! > "What this means in practice is that, for common search terms, the... [01:02:28] (03CR) 10Jforrester: [C: 03+2] Remove jshint and update package.json [extensions/DoubleWiki] - 10https://gerrit.wikimedia.org/r/556842 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [01:04:48] (03PS4) 10Jdlrobson: Add `@font-size-root` var [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/555015 (owner: 10VolkerE) [01:05:02] (03Merged) 10jenkins-bot: Remove jshint and update package.json [extensions/DoubleWiki] - 10https://gerrit.wikimedia.org/r/556842 (https://phabricator.wikimedia.org/T195542) (owner: 10Zoranzoki21) [01:07:27] 10CheckUser: CU 2.0: Filtering from data in Preliminary check, Compare and Timeline tabs - https://phabricator.wikimedia.org/T240530 (10Niharika) >>! In T240530#5737310, @dmaza wrote: >> Which icon is better — trash, cross, funnel? > AFAIK a funnel is generally understood as "filter". I agree. The problem with... [01:08:52] 10Anti-Harassment (The Letter Song), 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17): Introduce a temporary banner on Special:Block to inform users about upcoming partial blocks deploy - https://phabricator.wikimedia.org/T240300 (10Niharika) @dmaza Do we need to do something special to trigger translations? I can... [01:09:20] (03CR) 10Jforrester: "recheck" [extensions/Farmer] - 10https://gerrit.wikimedia.org/r/544582 (owner: 10Libraryupgrader) [01:09:28] (03PS1) 10Zoranzoki21: [DNM] TEST [extensions/Farmer] - 10https://gerrit.wikimedia.org/r/556849 [01:10:38] (03PS2) 10Jdlrobson: Talk headings should work with ascii characters [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556840 (https://phabricator.wikimedia.org/T238364) [01:11:18] (03CR) 10Krinkle: resourceloader: Remove redundant 'window' indirection (031 comment) [core] - 10https://gerrit.wikimedia.org/r/503706 (owner: 10Krinkle) [01:11:48] (03PS2) 10Krinkle: resourceloader: Fix infinite loop in RLQ processing [core] - 10https://gerrit.wikimedia.org/r/556835 (owner: 10Catrope) [01:11:50] 10MobileFrontend, 10Desktop Improvements, 10Multi-Content-Revisions, 10Patch-For-Review, and 3 others: [Technical debt payoff] Remove InlineDiffFormatter and InlineDifferenceEngine from MobileFrontend - https://phabricator.wikimedia.org/T240622 (10Jdlrobson) @tgr I assume you mean the PHP version of the di... [01:11:53] (03CR) 10Krinkle: [C: 03+2] resourceloader: Fix infinite loop in RLQ processing [core] - 10https://gerrit.wikimedia.org/r/556835 (owner: 10Catrope) [01:12:42] (03Abandoned) 10Zoranzoki21: [DNM] TEST [extensions/Farmer] - 10https://gerrit.wikimedia.org/r/556849 (owner: 10Zoranzoki21) [01:13:08] (03CR) 10Jdlrobson: "I think mediawiki.org is a special case - and should be resolved by using MediaWiki:Common.css." [core] - 10https://gerrit.wikimedia.org/r/539167 (https://phabricator.wikimedia.org/T217616) (owner: 10Jdlrobson) [01:17:00] (03CR) 10jerkins-bot: [V: 04-1] Add `@font-size-root` var [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/555015 (owner: 10VolkerE) [01:17:25] 10WatchTranslations, 10Google-Code-in-2019: Order languages meaningfully - https://phabricator.wikimedia.org/T237455 (10Arcayn) 05Open→03Resolved Closing as patch was merged [01:23:59] (03Merged) 10jenkins-bot: resourceloader: Fix infinite loop in RLQ processing [core] - 10https://gerrit.wikimedia.org/r/556835 (owner: 10Catrope) [01:27:11] (03PS5) 10VolkerE: Add `@font-size-root` var and rename `@font-size-body-mobile` [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/555015 [01:31:58] 10MediaWiki-extensions-Linter, 10Parsoid, 10User-notice: Temporarily disable wikitext linting updates to help resolve some cluster overload scenarios - https://phabricator.wikimedia.org/T240057 (10ssastry) If we are going to clear the database, we should wait till Jan 2020 to embark on this. Let us not go in... [01:35:01] (03PS6) 10VolkerE: Add `@font-size-root` var and rename `@font-size-body-mobile` [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/555015 [01:42:18] (03PS3) 10VolkerE: Storybook: Images should be relative uris [extensions/Popups] - 10https://gerrit.wikimedia.org/r/556824 (https://phabricator.wikimedia.org/T236589) (owner: 10Jdlrobson) [01:46:32] 10MediaWiki-extensions-FlaggedRevs, 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): Note about flagged revisions needs hide option - https://phabricator.wikimedia.org/T237246 (10XanonymusX) >>! In T237246#5738156, @Jdlrobson wrote: > I'm seeing this now, but it's not hideable,... [01:50:14] 10ContentTranslation: ContentTranslation shows JS not enabled error - https://phabricator.wikimedia.org/T240480 (10Volker_E) Current routing doesn't take adding `safemode=1` into account. But only user script https://en.wikipedia.org/wiki/User:Volker_E._(WMF)/dark-mode.js seems to actually be the source of the i... [01:53:33] 10WatchTranslations: Fix ongoing form validation issues - https://phabricator.wikimedia.org/T240650 (10Arcayn) [01:53:54] 10WatchTranslations: Fix ongoing form validation issues - https://phabricator.wikimedia.org/T240650 (10Arcayn) p:05Triage→03Normal [01:57:23] 10MediaWiki-extensions-Other, 10Google-Code-in-2019: Replace usage of ParserOutputHook in Extension:NoCat with OutputPageParserOutput hook - https://phabricator.wikimedia.org/T203733 (10Pppery) [01:57:29] 10MediaWiki-extensions-Translate, 10Patch-For-Review: Title in Extension:Translate cannot be converted - https://phabricator.wikimedia.org/T230681 (10A2093064) a:03A2093064 [02:00:05] (03CR) 10VolkerE: [C: 03+2] Storybook: Images should be relative uris [extensions/Popups] - 10https://gerrit.wikimedia.org/r/556824 (https://phabricator.wikimedia.org/T236589) (owner: 10Jdlrobson) [02:05:35] (03Merged) 10jenkins-bot: Storybook: Images should be relative uris [extensions/Popups] - 10https://gerrit.wikimedia.org/r/556824 (https://phabricator.wikimedia.org/T236589) (owner: 10Jdlrobson) [02:50:36] 10MobileFrontend, 10Advanced Mobile Contributions: Link text appears over icons in mobile view - https://phabricator.wikimedia.org/T240651 (10Wugapodes) [03:04:32] 10MediaWiki-extensions-Page_Forms, 10UI-Standardization: Convert Page Forms to use OOUI - https://phabricator.wikimedia.org/T192752 (10Samwilson) Nope, no reason! :) I figured the datetime one would be more complicated, and so tried it first. The date one should be pretty straight forward I think. [03:07:02] 10MobileFrontend, 10Advanced Mobile Contributions: Link text appears over icons in mobile view - https://phabricator.wikimedia.org/T240651 (10Ammarpad) I cannot reproduce this on Android phone. There was a regression similar to what you described (T240644) but that one is on //non//-AMC mode and affects only t... [03:20:16] 10MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), 10Structured-Data-Backlog (Current Work): Implement MediaInfo-specific Lua library - https://phabricator.wikimedia.org/T236692 (10Jarekt) I do not like idea of different libraries. Some of the information to be stored, like dates or copyright info, might be exactly... [03:25:40] (03CR) 10Krinkle: Add more logging to getWithSetCallback() (032 comments) [core] - 10https://gerrit.wikimedia.org/r/551360 (https://phabricator.wikimedia.org/T238197) (owner: 10Tim Starling) [03:26:58] 10Anti-Harassment (The Letter Song), 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17): Introduce a temporary banner on Special:Block to inform users about upcoming partial blocks deploy - https://phabricator.wikimedia.org/T240300 (10dmaza) I don't think so. The messages are ready to be translated. I just did `es` :... [03:28:20] (03PS1) 10Krinkle: debug: Move global after early return in LegacyLogger::log() [core] - 10https://gerrit.wikimedia.org/r/556858 [03:29:35] 10CheckUser: CU 2.0: Filtering from data in Preliminary check, Compare and Timeline tabs - https://phabricator.wikimedia.org/T240530 (10dmaza) Actually you are right. A cross makes more sense here since we are excluding from the search in this case [03:32:56] (03PS2) 10Nray: Use .html() instead of .text() when passing talk section title into Section [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556843 (https://phabricator.wikimedia.org/T240487) [03:35:07] 10MobileFrontend, 10Advanced Mobile Contributions: Link text appears over icons in mobile view - https://phabricator.wikimedia.org/T240651 (10Wugapodes) So it seems related to my custom css (w:User:Wugapodes/minerva.css), however it only changes link colors and was working yesterday. Has the interface been edi... [03:45:30] (03CR) 10jerkins-bot: [V: 04-1] Use .html() instead of .text() when passing talk section title into Section [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556843 (https://phabricator.wikimedia.org/T240487) (owner: 10Nray) [03:50:27] (03PS3) 10Samwilson: Standardize information on Password Reset success page [core] - 10https://gerrit.wikimedia.org/r/556102 (https://phabricator.wikimedia.org/T238961) [04:01:18] On branch master [04:01:18] nothing to commit, working tree clean [04:01:18] sir i am getting this on my git status command how do i rectify it [04:13:37] Hi [04:15:28] 10Password-Reset-Update, 10Community-Tech (Kanban-Q2-2019-20), 10Patch-For-Review: PRU: Improve Security & Standardize Experience for Password Reset [medium] - https://phabricator.wikimedia.org/T238961 (10Samwilson) > The Help page should perhaps be Help:Password_Reset, since this mirrors Special:PasswordRes... [04:17:37] (03CR) 10Aklapper: [C: 04-1] "Hi Ankita, thanks for your patch. Is this a "real" bug fix? If it is, please provide a link to more information / a bug report about this " [extensions/examples] - 10https://gerrit.wikimedia.org/r/556796 (owner: 10Ankita2503) [04:23:25] 10Readers-Web-Backlog: [Bug] Banner causes misalignment in article - https://phabricator.wikimedia.org/T240641 (10Aklapper) > Could be the difference in text volume, but as a user I would expect the banner to adapt. I assume the donation banner gets inserted next to the intro text and before the ToC. Where wou... [04:23:50] 10MediaWiki-Page-protection: Privileged users see "view source" on cascade protected page - https://phabricator.wikimedia.org/T240532 (10Aklapper) 05Open→03Stalled [04:30:11] 04(no projects): Hardcoded background style in table.vertical-navbox element breaks user CSS - https://phabricator.wikimedia.org/T240652 (10Tossrock) [04:30:13] 10wikidiff2: Wikidiff2 makes apache2 crash - https://phabricator.wikimedia.org/T240620 (10Aklapper) Hi @Jona, thanks for taking the time to report this. This means you are running MediaWiki 1:1.31.5-1ppa1~bionic1 ? > When I call this URL : https://MyMediawikiDoma.in/index.php?title=MyArticle&type=revision&diff=... [04:30:23] 10Machine vision, 10Structured Data Engineering, 10Structured-Data-Backlog: MachineVision should not put out at MediaWiki\Extension\MachineVision\MachineVisionEntitySaveException fatal on an edit conflict - https://phabricator.wikimedia.org/T240616 (10Aklapper) [04:31:09] 10MobileFrontend, 10Advanced Mobile Contributions: Link text partially appears over icons in mobile view - https://phabricator.wikimedia.org/T240651 (10Masumrezarock100) [04:32:51] 10Phabricator, 10Security-Team: Create generic security-team request for service intake mechanism - https://phabricator.wikimedia.org/T240492 (10Aklapper) (Let's please add #Phabricator to Phab configuration tasks (e.g. Phab forms) so they can be ever again in the future when searching for Phab things. Thanks :) [04:34:52] 10Developer-Advocacy, 10Documentation: Wikimedia Tech Talk February 2020 - TBA - https://phabricator.wikimedia.org/T240603 (10Aklapper) [04:40:54] 10MobileFrontend, 10Advanced Mobile Contributions: Link text partially appears over icons in mobile view - https://phabricator.wikimedia.org/T240651 (10Masumrezarock100) I am experiencing the same problem but only for the Contributors link. If I go to [[https://meta.m.wikimedia.org/wiki/User:Masumrezarock100]]... [04:41:38] 10Advanced Mobile Contributions, 10Readers-Web-Backlog: Link text partially appears over icons in mobile view - https://phabricator.wikimedia.org/T240651 (10Masumrezarock100) [04:41:57] 10Advanced Mobile Contributions, 10MinervaNeue, 10Readers-Web-Backlog: Link text partially appears over icons in mobile view - https://phabricator.wikimedia.org/T240651 (10Masumrezarock100) [04:49:15] 04(no projects): Hardcoded background style in table.vertical-navbox element breaks user CSS - https://phabricator.wikimedia.org/T240652 (10Aklapper) 05Open→03Invalid Hi @Tossrock, thanks for taking the time to report this and welcome to Wikimedia Phabricator! It looks like that class is used in https://e... [04:49:29] 10Design, 10VisualEditor, 10VisualEditor-Tables: Be able to set table cell background (and other formatting options) - https://phabricator.wikimedia.org/T54180 (10Whatamidoing-WMF) This was requested again at https://www.mediawiki.org/wiki/Topic:Vcflv3wnvk90yycr by @Guarapiranga. I think that this or simila... [04:57:04] 10MediaWiki-extensions-FlaggedRevs, 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): Note about flagged revisions needs hide option - https://phabricator.wikimedia.org/T237246 (10Masumrezarock100) >>! In T237246#5738156, @Jdlrobson wrote: > I'm seeing this now, but it's not hide... [05:02:45] 10Machine vision, 10Epic, 10MW-1.35-notes (1.35.0-wmf.8; 2019-11-26), 10Patch-For-Review: Improve test coverage for the MachineVision extension - https://phabricator.wikimedia.org/T236827 (10Mholloway) [05:19:01] everyone is so quiet lol [05:19:34] 10Library-Card-Platform, 10good first task: Allow coordinators to see unavailable partners they are assigned to - https://phabricator.wikimedia.org/T215273 (10AVasanth_WMF) We've recently implemented a robust code formatter – [[ https://github.com/psf/black | Black ]], which is causing your code to fail since... [05:22:46] 10Library-Card-Platform, 10good first task: Allow coordinators to see unavailable partners they are assigned to - https://phabricator.wikimedia.org/T215273 (10AVasanth_WMF) @Samwalton9 shouldn't coordinators be able to see the not available partner on the browse partner page too? Or am I missing something? [05:30:50] hello,,,,anyone? [05:37:42] !ask | TechneSiyam [05:37:43] TechneSiyam: Please feel free to ask your question: if anybody who knows the answer is around, they will surely reply. Don't ask for help or for attention before actually asking your question, that's just a waste of time – both yours and everybody else's. :) [05:39:07] no question... [05:39:11] just checking [06:22:05] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Browser-Support-Android-Google-Chrome, 10Browser-Support-Apple-Safari, and 3 others: Raise MW JS requirement to include ES6 Promise (drop IE11, Safari 5-6, and Android 4.1-4.3) - https://phabricator.wikimedia.org/T237688 (10Izno) IE11 is still some 3% of to... [06:25:20] 10MediaWiki-ResourceLoader, 10Performance-Team, 10JavaScript: Raise Grade A JavaScript requirement from ES5 (2009) to ES6 (2015) - https://phabricator.wikimedia.org/T178356 (10Izno) I left this comment on the Promises task; not sure if it might be better suited for here. >>! In T237688#5738492, @Izno wrote:... [06:29:49] 04(no projects): Upload wizard: error message 'unknown error: "$1" ' and upload does fail. - https://phabricator.wikimedia.org/T240653 (10C.Suthorn) [06:35:44] 10Phabricator: Merge the Phabricator Priority values "Low" and "Lowest" - https://phabricator.wikimedia.org/T228759 (10Aklapper) >>! In T228759#5690705, @Jdforrester-WMF wrote: > I've found the differentiation between Low and Lowest very useful when working as a product owner, when there are dozens or hundreds o... [06:37:41] 10Phabricator: Merge the Phabricator Priority values "Low" and "Lowest" - https://phabricator.wikimedia.org/T228759 (10Aklapper) >>! In T228759#5699339, @Lydia_Pintscher wrote: > Yes this is the same for me. Looking at the project tag with the most open tasks (#Wikidata) and ignoring open tasks with "Needs Tria... [06:38:54] 10UploadWizard: Upload wizard: error message 'unknown error: "$1" ' and upload does fail. - https://phabricator.wikimedia.org/T240653 (10Aklapper) @C.Suthorn: Assuming this task is about #UploadWizard, hence adding project tag so others can find this task when searching for tasks under that project. Also, please... [06:39:53] 10UploadWizard: Upload wizard: error message 'unknown error: "$1" ' and upload does fail. - https://phabricator.wikimedia.org/T240653 (10Aklapper) > See also: commons:com:Forum#Upload wizzard Is that https://commons.wikimedia.org/wiki/Commons:Forum#Upload-wizzard ? [06:40:34] 10UploadWizard: Upload wizard: error message 'unknown error: "$1" ' and upload does fail. - https://phabricator.wikimedia.org/T240653 (10Aklapper) {T208186} might be related. [06:48:28] Hi all! I'm Daylen (IRL and on enwiki). At the moment, I'm participating in Google's Code-in program, through its partnership with the Wikimedia Foundation. One of our tasks was to join this IRC chat! I've used Thunderbird as my email client for years and never realized that it had this functionality until now. I'm hoping to complete some simple bug fixes on Phabricator during this time. More details at https://www.me [06:53:43] Hi Daylen and welcome here! :) [06:54:29] Thank you, andre_! [06:55:05] This channel might still be a bit more calm around this time of the day, mostly bots like wikibugs reporting activity in Phab or in Gerrit, not too many humans active :) [06:56:50] What dates and times would you say it's most active? Since it's built-into my email client, I'll likely just keep it always on unless if I'm doing work requiring complete focus. [07:04:33] 10UploadWizard: Upload wizard: error message 'unknown error: "$1" ' and upload does fail. - https://phabricator.wikimedia.org/T240653 (10Masumrezarock100) [07:30:39] Daylen, I'd say usually around the office hours (10-18h) of UTC and UTC-6 [07:31:39] Thanks for the info! Also, how do you mention users in IRC? [07:32:31] No specific way - You could just mention their name, it's up to the user if their client is configured to create some ping or highlight or whatever [07:33:13] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/556866 (owner: 10L10n-bot) [07:36:21] 👍 [07:36:50] 04(no projects): Hardcoded background style in table.vertical-navbox element breaks user CSS - https://phabricator.wikimedia.org/T240652 (10Tossrock) Thank you for your quick and in-depth response, I will look into having this fixed on Wikipedia. [07:44:16] 10MediaWiki-extensions-EditNotify: Older Extension:New_User_Email_Notification (NewUserNotif) interferes with newer, modern Extension:EditNotify - https://phabricator.wikimedia.org/T240391 (10Wikinaut) @Yaron_Koren I found an issue only with EditNotify: with the following settings and _without_ having the extens... [07:48:41] (03PS1) 10Samwilson: Permit symfony/console version 5 [tools/minus-x] - 10https://gerrit.wikimedia.org/r/556873 [07:55:50] 👋 Good night fellow Wikimedians! ^Daylen in Vancouver [08:06:53] (03PS1) 10Pwirth: Fix UnrecognizedAnnotation for phpcs [extensions/BlueSpiceAvatars] - 10https://gerrit.wikimedia.org/r/556874 [08:07:35] 10MediaWiki-extensions-EditNotify: Bug/Suggestion for improvement: Extension:EditNotify cannot be restricted to page creations in certain namespaces. It always notifies about any page creation. - https://phabricator.wikimedia.org/T240656 (10Wikinaut) [08:11:53] 10Datasets-Archiving, 10Dumps-Generation, 10Internet-Archive: Produce dumps of commons thumbnail URLs - https://phabricator.wikimedia.org/T240520 (10ArielGlenn) The idea is to let people download thumbs that already exist, when grabbing bulk thumbs as a sample set for research; asking MW to generate thumbs t... [08:14:19] (03PS1) 10Pwirth: Fix missing public function doc for phpcs [extensions/BlueSpiceCategoryManager] - 10https://gerrit.wikimedia.org/r/556875 [08:16:31] (03CR) 10DCausse: [C: 03+2] Return HtmlArmor for Search ResultSet snippets [core] - 10https://gerrit.wikimedia.org/r/556261 (owner: 10EBernhardson) [08:27:40] (03Merged) 10jenkins-bot: Return HtmlArmor for Search ResultSet snippets [core] - 10https://gerrit.wikimedia.org/r/556261 (owner: 10EBernhardson) [08:31:04] 10MediaWiki-extensions-EditNotify: EditNotify cannot be restricted to page creations in certain namespaces. It always notifies about any page creation. - https://phabricator.wikimedia.org/T240656 (10Aklapper) [08:31:20] (03PS1) 10Pwirth: Fix missing docs, function scope declaration and lines to long for phpcs [extensions/BlueSpiceChecklist] - 10https://gerrit.wikimedia.org/r/556972 [08:37:59] 10Library-Card-Platform, 10good first task: Allow coordinators to see unavailable partners they are assigned to - https://phabricator.wikimedia.org/T215273 (10HAKSOAT) Thanks @AVasanth_WMF The tests now pass [08:39:56] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/556935 (owner: 10L10n-bot) [08:40:16] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/556944 (owner: 10L10n-bot) [08:40:32] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/556947 (owner: 10L10n-bot) [08:40:48] 10MediaWiki-Page-protection: Privileged users see "view source" on cascade protected page - https://phabricator.wikimedia.org/T240532 (10Keyacom) >>! In T240532#5738180, @Ammarpad wrote: > I cannot reproduce this. I am also interested in knowing where that colorful box comes from. > {F31474194} The screenshot i... [08:41:21] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/556963 (owner: 10L10n-bot) [08:42:53] (03CR) 10Fomafix: languages: Simplify Language::firstChar() even further (031 comment) [core] - 10https://gerrit.wikimedia.org/r/556632 (owner: 10Thiemo Kreuz (WMDE)) [08:52:06] 10WMNO-General: Apply Fritt Ord 28.2.2020: festivals summer 2020 - https://phabricator.wikimedia.org/T240661 (10WMNOastrid) [08:55:52] 10WMNO-General: General assembly 14.3.2020 - https://phabricator.wikimedia.org/T240662 (10WMNOastrid) [08:56:07] (03PS1) 10Pwirth: Fix doc blocks, lines too long, assignments in controll structures for phpcs [extensions/BlueSpiceConfigManager] - 10https://gerrit.wikimedia.org/r/556975 [08:59:26] (03PS1) 10Pwirth: Fix missing covers for phpcs [extensions/BlueSpiceContextMenu] - 10https://gerrit.wikimedia.org/r/556977 [09:00:40] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/556963 (owner: 10L10n-bot) [09:01:21] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive" [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/556947 (owner: 10L10n-bot) [09:01:42] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/556944 (owner: 10L10n-bot) [09:01:59] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/556935 (owner: 10L10n-bot) [09:02:28] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive" [core] - 10https://gerrit.wikimedia.org/r/556866 (owner: 10L10n-bot) [09:09:01] 10Developer-Advocacy: Find a good way to get numbers how much work @aklapper is doing in Phabricator - https://phabricator.wikimedia.org/T233415 (10Aklapper) [09:09:49] 10Developer-Advocacy: Find a good way to get numbers how much work @aklapper is doing in Phabricator - https://phabricator.wikimedia.org/T233415 (10Aklapper) `96786` is the offset for Oct1st. = 6539 interactions in Q3/2019. [09:11:41] (03PS1) 10Fomafix: Use document.body instead of 'body' as jQuery selector [core] - 10https://gerrit.wikimedia.org/r/556978 [09:17:02] 10wikidiff2: Wikidiff2 makes apache2 crash - https://phabricator.wikimedia.org/T240620 (10Jona) Hi @Aklapper , thank you for taking time to look for a solution. > This means you are running MediaWiki 1:1.31.5-1ppa1~bionic1 ? Yes I anonymized the URL. I am very cautious when publishing things online. The real U... [09:24:15] 10LuaSandbox: Can't build on mac os 10.13.2 - https://phabricator.wikimedia.org/T240664 (10Edvardasmiksta) [09:24:19] 10MediaWiki-extensions-Graph: Error: URL hostname is not whitelisted: wikiraw:///Fertility-csv - https://phabricator.wikimedia.org/T145944 (10SumanGadhawal) could you please share how we can adjusted data source paths to wikiraw:///file-csv I am getting same error too However, I keep getting "Error: URL hostna... [09:30:31] (03CR) 10Robert Vogel: [C: 04-1] "Can we have some unit tests here, please?" [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/556697 (owner: 10ItSpiderman) [09:35:49] (03CR) 10WMDE-Fisch: "Hehe, sure. I was to slow I guess ^^'" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/556675 (owner: 10WMDE-Fisch) [09:35:53] (03Abandoned) 10WMDE-Fisch: build: Update linters [extensions/Echo] - 10https://gerrit.wikimedia.org/r/556675 (owner: 10WMDE-Fisch) [09:38:35] 10Page-Previews, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): Identify Page-Previews product people - https://phabricator.wikimedia.org/T239357 (10ovasileva) Hi @Physikerwelt - apologies for the late reply. I think the change proposed in {T208758} is interesting, but I did have a few questions. Firstly, wha... [09:43:26] 10MediaWiki-Recent-changes, 10UI-Standardization, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), 10User-Jdlrobson: RecentChanges should be fully skinnable - use pseudo elements for separating elements - https://phabricator.wikimedia.org/T219348 (10ovasileva) [09:43:31] 10MediaWiki-Interface, 10MediaWiki-Page-History, 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, and 7 others: Stray semicolons in RecentChanges, Watchlist, History and Contributions interface - https://phabricator.wikimedia.org/T233649 (10ovasileva) 05Open→03Resolved :) [09:43:54] (03PS1) 10Pwirth: Fix missing doc blocks for phpcs [extensions/BlueSpiceCountThings] - 10https://gerrit.wikimedia.org/r/556979 [09:48:37] 10Advanced Mobile Contributions, 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): Updates to user pages for all users - https://phabricator.wikimedia.org/T232653 (10ovasileva) > @ovasileva @alexhollender Please verify that the screenshots above reflect the current AC of this ticket (everythi... [09:49:39] (03CR) 10Pwirth: [C: 04-1] Special page for Bookshelf (031 comment) [extensions/BlueSpiceBookshelfUI] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/554216 (owner: 10AlexPinchuk) [09:59:19] (03PS2) 10Thiemo Kreuz (WMDE): languages: Simplify Language::firstChar() even further [core] - 10https://gerrit.wikimedia.org/r/556632 [10:02:29] (03PS14) 10AlexPinchuk: Special page for Bookshelf [extensions/BlueSpiceBookshelfUI] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/554216 [10:07:54] (03PS1) 10Majavah: build: Use ESLint instead of JSHint [extensions/NewUserMessage] - 10https://gerrit.wikimedia.org/r/556983 (https://phabricator.wikimedia.org/T195542) [10:08:48] 10Anti-Harassment (The Letter Song), 10MW-1.35-notes (1.35.0-wmf.11; 2019-12-17): Introduce a temporary banner on Special:Block to inform users about upcoming partial blocks deploy - https://phabricator.wikimedia.org/T240300 (10dom_walden) I could only test this on my local versions, as I cannot change the set... [10:10:05] 10wikidiff2: Wikidiff2 makes apache2 crash - https://phabricator.wikimedia.org/T240620 (10Aklapper) I don't know how each debug package on Debian is called. Whatever is needed to not see only `libphp7.2.so` or `wikidiff2.so` in the stacktrace :) [10:10:28] 10LuaSandbox: Can't build on mac os 10.13.2 - https://phabricator.wikimedia.org/T240664 (10Aklapper) [10:10:41] 10TimedMediaHandler-Transcode: Transcoding job is reported as failed before it's completed - https://phabricator.wikimedia.org/T240368 (10HebronNor) @brion After running a bunch of transcoding jobs, without browsing the video page (`File:xxx.mp4`) during the ongoing transcode; I have no errors. So it seems prett... [10:13:01] (03CR) 10Pwirth: [C: 04-1] Special page for Bookshelf (031 comment) [extensions/BlueSpiceBookshelfUI] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/554216 (owner: 10AlexPinchuk) [10:16:49] 10LuaSandbox: Can't build on Mac OS 10.13.2 as "timer_t" is not available on Mac OS - https://phabricator.wikimedia.org/T240664 (10Aklapper) [10:17:18] 10LuaSandbox: Can't build on Mac OS 10.13.2 as "timer_t" is not available on Mac OS - https://phabricator.wikimedia.org/T240664 (10Aklapper) Hi @Edvardasmiksta, thanks for taking the time to report this and welcome to Wikimedia Phabricator! `timer_t` is part of the POSIX standard but it is missing from Mac OS.... [10:21:27] 10MediaWiki-Authentication-and-authorization: Since 1.17, you can't override page permission errors by a hook - https://phabricator.wikimedia.org/T36856 (10Aklapper) p:05Normal→03Low [10:23:16] 10LuaSandbox: Can't build on Mac OS 10.13.2 as "timer_t" is not available on Mac OS - https://phabricator.wikimedia.org/T240664 (10Edvardasmiksta) Hi, yes thank you i'm aware of that. But how can i install luasandbox on mac? in documentation mac is supported only real time will be used for time. [[ https://www.... [10:23:18] 10MediaWiki-extensions-LDAPProvider: LDAPProvider in MediaWiki 1.33.1 fails with "Fatal error: Exception thrown without a stack frame in Unknown on line 0" - https://phabricator.wikimedia.org/T240568 (10Pavche) When debugging is enabled in WikiMedia: `Parse error: syntax error, unexpected 'const' (T_CONST), exp... [10:24:57] (03PS15) 10AlexPinchuk: Special page for Bookshelf [extensions/BlueSpiceBookshelfUI] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/554216 [10:25:11] Hi [10:25:16] I am here for GCI [10:27:33] Hi Vijay [10:27:39] Hmm [10:27:43] (03CR) 10Pwirth: [C: 03+1] Special page for Bookshelf [extensions/BlueSpiceBookshelfUI] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/554216 (owner: 10AlexPinchuk) [10:27:43] Welcome! [10:27:48] (03PS1) 10Pwirth: Special page for Bookshelf [extensions/BlueSpiceBookshelfUI] - 10https://gerrit.wikimedia.org/r/556986 [10:27:59] Thanks. [10:28:00] 10LuaSandbox: Can't build on Mac OS 10.13.2 as "timer_t" is not available on Mac OS - https://phabricator.wikimedia.org/T240664 (10Aklapper) Someone needs to provide a patch that fixes the issue. :) If you like to provide a patch, you are very welcome to use [[ https://www.mediawiki.org/wiki/Developer_access | d... [10:28:10] Starting my GCI with wikimidea :smile: [10:28:49] welcome Vijay ! [10:28:51] (03CR) 10jerkins-bot: [V: 04-1] Special page for Bookshelf [extensions/BlueSpiceBookshelfUI] - 10https://gerrit.wikimedia.org/r/556986 (owner: 10Pwirth) [10:28:58] Thanks andre__ [10:29:09] Awesome! [10:29:13] Vijay: which IRC client did you install? [10:29:45] Weechat [10:29:58] Please use an open source IRC client to complete this GCI task. :) [10:30:07] Welcome Vijay [10:30:10] oh can u name some? [10:30:31] That's interesting because it identifies as a web client... [10:30:47] oh [10:30:50] (03PS2) 10Pwirth: Special page for Bookshelf [extensions/BlueSpiceBookshelfUI] - 10https://gerrit.wikimedia.org/r/556986 [10:30:58] (03PS16) 10Pwirth: Special page for Bookshelf [extensions/BlueSpiceBookshelfUI] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/554216 (owner: 10AlexPinchuk) [10:31:16] But WeeChat would be open source, as its code is on https://github.com/weechat [10:31:17] weird [10:31:38] hmm [10:32:24] 10MediaWiki-extensions-CLDR, 10Wikidata, 10I18n, 10Upstream: "hollandsk" to "nederlandsk" - https://phabricator.wikimedia.org/T157809 (10Aklapper) Uhm, I am sorry to hear that. :( Thanks for the quick reply here. [10:32:29] Oops. My bad. Weechat is open source. [10:32:44] haha [10:33:01] np :) [10:35:12] hello gg here I am here for GCI [10:35:55] Welcome! [10:37:39] (03PS1) 10DCausse: Bump to restify to 8.5.0 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/556987 [10:40:22] Vijay, devtech I think your nicks are already taken. :/ [10:40:37] I dont know [10:40:42] I did put my nick name in GCI [10:40:50] 10MediaWiki-API, 10Core Platform Team, 10Patch-For-Review, 10Privacy, 10User-Michael: Expose own IP address in API - https://phabricator.wikimedia.org/T240565 (10Lucas_Werkmeister_WMDE) > It seems a bit fragile to require the client to know that for this type of block, users ip is relavent info. MediaWi... [10:42:07] You might have to choose a different nick and register it. See https://freenode.net/kb/answer/registration [10:42:36] This is my GCI nick. [10:43:16] 10Wikidata-Tainted-References-Sprint6, 10Wikidata-Tainted-References-Sprint7: Add browser tests for the tainted icon - https://phabricator.wikimedia.org/T237968 (10Tarrow) PR is merged [10:43:17] (03CR) 10Pwirth: [C: 03+2] Special page for Bookshelf [extensions/BlueSpiceBookshelfUI] - 10https://gerrit.wikimedia.org/r/556986 (owner: 10Pwirth) [10:43:22] Vijay: That's alright. You can mention your registered nick while submitting the task. :) [10:43:27] (03CR) 10Pwirth: [V: 03+2 C: 03+2] Special page for Bookshelf [extensions/BlueSpiceBookshelfUI] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/554216 (owner: 10AlexPinchuk) [10:44:39] techie_gg: You can register this nickname. :) [10:45:03] ok [10:46:04] (03Merged) 10jenkins-bot: Special page for Bookshelf [extensions/BlueSpiceBookshelfUI] - 10https://gerrit.wikimedia.org/r/556986 (owner: 10Pwirth) [10:59:40] 10Page-Previews, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): Identify Page-Previews product people - https://phabricator.wikimedia.org/T239357 (10Physikerwelt) @ovasileva ## Some background information: In a first step, this feature will be only available to select formulae. The Wikidata ID will not be di... [11:01:25] 10Wikidata-Tainted-References-Sprint7: Make popper reusable - https://phabricator.wikimedia.org/T240669 (10Tarrow) [11:03:32] (03PS1) 10Awight: Cleanup: Explicit public access [core] - 10https://gerrit.wikimedia.org/r/556991 [11:03:38] (03CR) 10SonarQube Bot: [C: 04-1] "testing" [core] - 10https://gerrit.wikimedia.org/r/519448 (https://phabricator.wikimedia.org/T87781) (owner: 10Kosta Harlan) [11:07:21] (03PS1) 10Gilles: Add gilles' key [pgp-public-keys] - 10https://gerrit.wikimedia.org/r/556993 [11:07:37] (03CR) 10SonarQube Bot: [C: 04-1] "testing" [core] - 10https://gerrit.wikimedia.org/r/519448 (https://phabricator.wikimedia.org/T87781) (owner: 10Kosta Harlan) [11:08:28] 10MediaWiki-API, 10Core Platform Team, 10Patch-For-Review, 10Privacy, 10User-Michael: Expose own IP address in API - https://phabricator.wikimedia.org/T240565 (10Lucas_Werkmeister_WMDE) > but for intestactions there is no way to define a format There is – it obeys the overall `errorformat`. (But if the... [11:08:47] (03CR) 10SonarQube Bot: [C: 04-1] "❌ Quality gate failed" [core] - 10https://gerrit.wikimedia.org/r/519448 (https://phabricator.wikimedia.org/T87781) (owner: 10Kosta Harlan) [11:11:35] 10Wikidata-Tainted-References-Sprint7: Make popper reusable - https://phabricator.wikimedia.org/T240669 (10hoo) I just talked to @Tarrow about this, and for now it should be enough to use that new component directly in App.vue, but if that turns out to bloat App.vue to much we will revisit this. Potential furth... [11:16:07] 10Security-Team: Set Security Issue Task Type as default for Security reporting - https://phabricator.wikimedia.org/T240605 (10Aklapper) I'm a bit confused here. The task both says "includes updating the link from form 2 to form 75" and "Update form 2 to say legacy and link to form 48"? [11:19:17] 10Who-Wrote-That, 10Community-Tech (Kanban-Q2-2019-20): Who Wrote That? link is slightly bigger than you think - https://phabricator.wikimedia.org/T239842 (10dom_walden) @Samwilson I am seeing the WWT link on pages like the Main_Page or in other namespaces (e.g. User_talk). In the HTML it looks like: ` 10WatchTranslations, 10Patch-For-Review: Add link to git repo in footer - https://phabricator.wikimedia.org/T240604 (10Urbanecm) 05Open→03Resolved [11:28:09] (03PS1) 10Dvogel hallowelt: [WIP] Replace cookies with local storage to reduce load [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/556997 [11:30:36] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/556987 (owner: 10DCausse) [11:30:55] (03PS2) 10Dvogel hallowelt: Fix BookMeta dialog - Modified bookmeta could not be saved [extensions/BlueSpiceBookshelfUI] (REL1_31) - 10https://gerrit.wikimedia.org/r/556155 [11:33:22] 10Library-Card-Platform-Proxy: Redesign partner pages - https://phabricator.wikimedia.org/T230523 (10Samwalton9) a:05Samwalton9→03None [11:35:57] 10WatchTranslations, 10Google-Code-in-2019: Organize list of message groups by aggregate groups - https://phabricator.wikimedia.org/T240240 (10Urbanecm) [11:36:12] 10Wikispeech-STTS, 10Wikispeech-Text-to-Speech, 10Wikispeech-jobrunner (Sprint): Run automatic checks on Go code - https://phabricator.wikimedia.org/T238308 (10NikolajLindberg) Almost done, but a few minor things need some more attention. [11:38:26] 10MediaWiki-extensions-FlaggedRevs, 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): Note about flagged revisions needs hide option - https://phabricator.wikimedia.org/T237246 (10XanonymusX) Oh, I see, looks like the box is limited to non-English messages. With English as my use... [11:41:17] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/556987 (owner: 10DCausse) [11:43:24] (03CR) 10SonarQube Bot: [C: 04-1] "❌ Quality gate failed\n\n\n* ✔ reliability rating\n* ✔ security rating\n* ✔ maintainability rating\n* ❌ coverage (0.0 is less than 80)" [core] - 10https://gerrit.wikimedia.org/r/519448 (https://phabricator.wikimedia.org/T87781) (owner: 10Kosta Harlan) [11:45:38] 10Who-Wrote-That, 10Community-Tech (Kanban-Q2-2019-20): WWT: Good article badge comes over the WWT bar - https://phabricator.wikimedia.org/T234709 (10dom_walden) The WWT toolbar appears above article badges. I did not extensively test whether the toolbar now interferes with other UI elements. However, it is o... [11:49:28] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/556830 (https://phabricator.wikimedia.org/T225213) (owner: 10Jdlrobson) [11:51:53] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/556987 (owner: 10DCausse) [11:56:38] 10Wikilink-Tool: Load page content via ajax - https://phabricator.wikimedia.org/T233954 (10Samwalton9) 05Open→03Declined May not be the ideal solution. [11:58:08] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10Technical-Debt: Clean up unchecked exceptions - https://phabricator.wikimedia.org/T240672 (10awight) [11:58:49] 10Wikilink-Tool: Wikipedia Library program page doesn't load due to expensive db queries - https://phabricator.wikimedia.org/T240673 (10Samwalton9) [11:58:52] 10Wikilink-Tool: Wikipedia Library program page doesn't load due to expensive db queries - https://phabricator.wikimedia.org/T240673 (10Samwalton9) p:05Triage→03High [11:59:48] 10MediaWiki-Codesniffer, 10MediaWiki-General, 10Technical-Debt: Clean up unchecked exceptions - https://phabricator.wikimedia.org/T240672 (10awight) [11:59:54] 10MediaWiki-General, 10MediaWiki-extensions-General, 10Patch-For-Review, 10Technical-Debt: Remove unchecked calls to Title::getTalkPage from extensions - https://phabricator.wikimedia.org/T172146 (10awight) [12:02:04] (03PS1) 10Jon Harald Søby: Add PLURAL to new messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/556999 [12:02:29] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/556987 (owner: 10DCausse) [12:06:41] 10ContentTranslation, 10Language-Team (Language-2019-October-December), 10MW-1.35-notes (1.35.0-wmf.10; 2019-12-10): Reference by name shown as missing despite successful adaptation - https://phabricator.wikimedia.org/T236615 (10Pginer-WMF) >>! In T236615#5735595, @Jpita wrote: > https://ca.wikipedia.org/wik... [12:08:44] 10Research: Schedule regular office hours for Wikimedia-Research - https://phabricator.wikimedia.org/T235445 (10MGerlach) Posted on [[ https://discuss-space.wmflabs.org/t/new-office-hours-for-wmf-research-analytics-starting-in-januray-2020/2647 | discuss-space ]] [12:09:50] 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): Placeholder: Run display locking origin trial - https://phabricator.wikimedia.org/T239295 (10Gilles) Yeah the origin trial token header can act as the feature flag for something l... [12:11:50] 10Developer-Advocacy (Oct-Dec 2019): Find a good way to get numbers how much work @aklapper is doing in Phabricator - https://phabricator.wikimedia.org/T233415 (10Aklapper) 05Open→03Resolved Also documented that on my internal WMF Continuity page: * XX tickets about Phab and project tags resolved: //[Search... [12:13:04] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/556987 (owner: 10DCausse) [12:14:37] (03PS2) 10Dvogel hallowelt: Make 'Duplicator' link available at all namespaces [extensions/BlueSpiceDistributionConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/553711 [12:16:20] (03PS3) 10Dvogel hallowelt: [WIP] Make 'Duplicator' link available at all namespaces [extensions/BlueSpiceDistributionConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/553711 [12:17:56] Hi ComputerGuy [12:18:00] how are you doing? [12:18:04] Hello! [12:18:11] Doing great! [12:18:32] I'm trying to figure out what that error means. [12:18:48] ComputerGuy: let me know if you're at the end of your guesses :-) [12:21:03] kostajh: around? [12:21:17] Urbanecm: hi, what's up [12:22:09] kostajh: I'm reading your comment at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/530105/122/includes/ChangeMentor.php#120. I agree we should try to fix it before merging, however, I don't have any idea how. [12:22:23] (03PS2) 10Robert Vogel: Fix local login issue [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/556196 [12:22:31] Even if I delete that block of code, any other validation failure would display the checkbox [12:22:53] * kostajh looks [12:22:54] (03PS3) 10Robert Vogel: Fix local login issue [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/556196 [12:23:39] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/556987 (owner: 10DCausse) [12:23:56] (03CR) 10jerkins-bot: [V: 04-1] Fix local login issue [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/556196 (owner: 10Robert Vogel) [12:24:11] Urbanecm: what's the intention behind the checkbox? Did Marshall ask for that? [12:24:49] kostajh: yes. They (Rita+Marshall) want the software to warn users if (and only if) they attempt to claim a mentee that was claimed before, but allow them to do that if they want [12:24:53] a confirmation step was proposed [12:28:09] 10MediaWiki-extensions-WikibaseRepository, 10Wikibase-DataModel-Serialization, 10Wikidata, 10Patch-For-Review, and 2 others: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array [] - https://phabricator.wikimedia.org/T138104 (10Pablo-WMDE) It appears the installations configure... [12:29:53] 10MediaWiki-extensions-WikibaseRepository, 10Wikibase-DataModel-Serialization, 10Wikidata, 10Patch-For-Review, and 2 others: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array [] - https://phabricator.wikimedia.org/T138104 (10Ladsgroup) >>! In T138104#5739073, @Pablo-WMDE wro... [12:30:52] (03PS3) 10Thiemo Kreuz (WMDE): Remove single use classes from the use section [extensions/Cite] - 10https://gerrit.wikimedia.org/r/556206 [12:32:39] Urbanecm: hm. I can try to think about it a little later. [12:32:52] kostajh: that'd be cool. [12:32:59] I'll have a look at the rest of your reviews [12:34:15] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/556987 (owner: 10DCausse) [12:35:23] (03PS5) 10Thiemo Kreuz (WMDE): [WIP] Several unrelated code cleanups [extensions/Cite] - 10https://gerrit.wikimedia.org/r/555956 [12:37:16] 10Wikidata-Termbox: EntityInitializer: remove work-around for incorrect empty object serialization - https://phabricator.wikimedia.org/T240674 (10Pablo-WMDE) [12:38:54] Urbanecm: I'm not able to find the cause of error. I first thought it was something with symbols. So, I tried other symbols but they didn't produce errors. [12:39:25] ComputerGuy: I have to go now, could you note that in the GCI task, I'll get back to you later [12:39:42] Got it. [12:39:48] 10Developer-Advocacy (Jan-Mar 2020): Publish some Phabricator (and/or Gerrit) end-of-year stats for 2019 to wikitech-l@ - https://phabricator.wikimedia.org/T240564 (10Aklapper) [12:40:46] (03CR) 10jerkins-bot: [V: 04-1] Remove single use classes from the use section [extensions/Cite] - 10https://gerrit.wikimedia.org/r/556206 (owner: 10Thiemo Kreuz (WMDE)) [12:44:26] 10Developer-Advocacy (Jan-Mar 2020): Publish some Phabricator (and/or Gerrit) end-of-year stats for 2019 to wikitech-l@ - https://phabricator.wikimedia.org/T240564 (10Aklapper) [12:44:50] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/556987 (owner: 10DCausse) [12:44:59] (03PS4) 10Dvogel hallowelt: [WIP] Make 'Duplicator' link available at all namespaces [extensions/BlueSpiceDistributionConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/553711 [12:46:15] 10WMSE-Magnus Sälgö: Europeana Entity <-> Wikidata Property 7704 - https://phabricator.wikimedia.org/T240290 (10Salgo60) [12:51:35] 10Developer-Advocacy (Jan-Mar 2020): Publish some Phabricator (and/or Gerrit) end-of-year stats for 2019 to wikitech-l@ - https://phabricator.wikimedia.org/T240564 (10Aklapper) [12:52:19] 10Gender-Support: Wikidata Humans and Gender Data Tools - https://phabricator.wikimedia.org/T230184 (10notafish) I was looking at @Envlh 's site and remarked that the color is green for the masculine side and yellow for the feminine side. I just realized that it's the same for @Maximilianklein's tool. Green is... [12:52:37] (03PS5) 10Dvogel hallowelt: [WIP] Make 'Duplicator' link available at all namespaces [extensions/BlueSpiceDistributionConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/553711 [12:53:48] 10VideoCutTool, 10Toolforge-standards-committee (Maintainer needed): Co-maintainers needed for VideoCutTool. - https://phabricator.wikimedia.org/T237998 (10eranroz) 05Open→03Resolved a:03eranroz Thanks! moving the task to resolved. [12:54:40] (03PS20) 10Daniel Kinzler: Make dump tests based on fixture files. [core] - 10https://gerrit.wikimedia.org/r/554919 (https://phabricator.wikimedia.org/T240213) [12:55:25] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/556987 (owner: 10DCausse) [12:57:59] 10Developer-Advocacy (Jan-Mar 2020): Publish some Phabricator (and/or Gerrit) end-of-year stats for 2019 to wikitech-l@ - https://phabricator.wikimedia.org/T240564 (10Aklapper) 05Open→03Stalled [12:58:47] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.30x-O-Ontbijtkoek): [EPIC] Suggested edits V4 - https://phabricator.wikimedia.org/T239690 (10schoenbaechler) [13:02:24] 10MW-1.35-notes (1.35.0-wmf.10; 2019-12-10), 10Structured-Data-Backlog (Current Work): Implement MediaInfo-specific Lua library - https://phabricator.wikimedia.org/T236692 (10Multichill) Break info at https://commons.wikimedia.org/wiki/Module_talk:Wikidata_label#Lua_error_in_Module:Wikidata_label_at_line_24:_a... [13:05:33] 10MediaWiki-extensions-WikibaseRepository, 10Wikibase-DataModel-Serialization, 10Wikidata, 10Patch-For-Review, and 2 others: Do not serialize empty containers (descriptions/aliases/sitelinks) as empty array [] - https://phabricator.wikimedia.org/T138104 (10Pablo-WMDE) As always I admire the courageous beha... [13:06:38] (03PS1) 10Pwirth: Fix \SkinTemplate is expected when actual \QuickTemplates is used [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/557005 [13:08:29] (03PS21) 10Daniel Kinzler: Make dump tests based on fixture files. [core] - 10https://gerrit.wikimedia.org/r/554919 (https://phabricator.wikimedia.org/T240213) [13:09:47] 10Developer-Advocacy (Jan-Mar 2020): Publish some Phabricator (and/or Gerrit) end-of-year stats for 2019 to wikitech-l@ - https://phabricator.wikimedia.org/T240564 (10Aklapper) [13:15:18] 10WMSE-Magnus Sälgö: Europeana Entity <-> Wikidata Property 7704 - https://phabricator.wikimedia.org/T240290 (10Salgo60) [13:18:06] (03PS22) 10Daniel Kinzler: Make dump tests based on fixture files. [core] - 10https://gerrit.wikimedia.org/r/554919 (https://phabricator.wikimedia.org/T240213) [13:20:15] 10WMSE-Magnus Sälgö: Europeana Entity <-> Wikidata Property 7704 - https://phabricator.wikimedia.org/T240290 (10Salgo60) [13:21:37] (03PS1) 10Pwirth: Fix \SkinTemplate is expected when actual \QuickTemplates is used [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/557009 [13:21:48] (03PS1) 10Pwirth: Fix \SkinTemplate is expected when actual \QuickTemplates is used [extensions/BlueSpiceBookshelfUI] - 10https://gerrit.wikimedia.org/r/557010 [13:22:04] (03PS1) 10Pwirth: Fix \SkinTemplate is expected when actual \QuickTemplates is used [extensions/BlueSpiceExpiry] - 10https://gerrit.wikimedia.org/r/557011 [13:22:21] (03CR) 10jerkins-bot: [V: 04-1] Fix \SkinTemplate is expected when actual \QuickTemplates is used [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/557009 (owner: 10Pwirth) [13:22:25] (03PS1) 10Pwirth: Fix \SkinTemplate is expected when actual \QuickTemplates is used [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/557012 [13:22:40] (03PS1) 10Pwirth: Fix \SkinTemplate is expected when actual \QuickTemplates is used [extensions/BlueSpicePagesVisited] - 10https://gerrit.wikimedia.org/r/557013 [13:22:59] (03PS23) 10Daniel Kinzler: Make dump tests based on fixture files. [core] - 10https://gerrit.wikimedia.org/r/554919 (https://phabricator.wikimedia.org/T240213) [13:23:15] (03PS1) 10Pwirth: Fix \SkinTemplate is expected when actual \QuickTemplates is used [extensions/BlueSpiceSmartList] - 10https://gerrit.wikimedia.org/r/557014 [13:23:30] (03PS1) 10Pwirth: Fix \SkinTemplate is expected when actual \QuickTemplates is used [extensions/BlueSpiceUserSidebar] - 10https://gerrit.wikimedia.org/r/557015 [13:23:46] (03PS1) 10Pwirth: Fix \SkinTemplate is expected when actual \QuickTemplates is used [extensions/BlueSpiceWatchList] - 10https://gerrit.wikimedia.org/r/557016 [13:27:39] 10Developer-Advocacy (Jan-Mar 2020): Fill in Phab/Gerrit 2019/Q4 data for Technical Community Newsletter in January 2020 - https://phabricator.wikimedia.org/T240589 (10Aklapper) [13:27:43] 10MediaWiki-extensions-EditNotify: EditNotify cannot be restricted to page creations in certain namespaces. It always notifies about any page creation. - https://phabricator.wikimedia.org/T240656 (10Yaron_Koren) So is T240391 incorrect? What's the impact that the NewUserNotif extension has, if any? [13:27:52] 10Developer-Advocacy (Jan-Mar 2020): Fill in Phab/Gerrit 2019/Q4 data for Technical Community Newsletter in January 2020 - https://phabricator.wikimedia.org/T240589 (10Aklapper) [13:29:48] (03CR) 10Pwirth: Fix \SkinTemplate is expected when actual \QuickTemplates is used (031 comment) [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/557005 (owner: 10Pwirth) [13:30:12] 10Developer-Advocacy (Jan-Mar 2020): Publish some Phabricator (and/or Gerrit) end-of-year stats for 2019 to wikitech-l@ - https://phabricator.wikimedia.org/T240564 (10Aklapper) [13:30:50] 10Developer-Advocacy (Jan-Mar 2020): Publish some Phabricator (and/or Gerrit) end-of-year stats for 2019 to wikitech-l@ - https://phabricator.wikimedia.org/T240564 (10Aklapper) [13:30:59] (03PS2) 10Pwirth: Fix \SkinTemplate is expected when actual \QuickTemplates is used [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/557009 [13:31:19] 10SyntaxHighlight, 10VisualEditor (Current work): Syntax highlighting moves cursor out from the actual writing place when using New Wikitext Mode at euwiki - https://phabricator.wikimedia.org/T238678 (10matmarex) a:03matmarex > @JTannerWMF moved this task from **To Triage** to **Freezer **on the **VisualEdit... [13:31:45] 10Phabricator, 10Developer-Advocacy (Jan-Mar 2020): Decrease issues with assignee field set for years without progress (aka cookie licking) - https://phabricator.wikimedia.org/T228575 (10Aklapper) [13:32:32] (03PS1) 10Bartosz Dziewoński: VE: Update padding to match VisualEditor changes [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/557018 (https://phabricator.wikimedia.org/T238678) [13:33:11] 10WMSE-Magnus Sälgö: Europeana Entity <-> Wikidata Property 7704 - https://phabricator.wikimedia.org/T240290 (10Salgo60) [13:33:33] 10MediaWiki-extensions-CodeMirror, 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Cursor off by several lines where the text is edited in new wikitext mode - https://phabricator.wikimedia.org/T212680 (10matmarex) >>! In T212680#5621186, @Jolek wrote: > Same problem on french wikipedia. It occur... [13:34:27] 10MediaWiki-extensions-Translate, 10translatewiki.net, 10Language-Team (Language-2019-October-December), 10Patch-For-Review, 10User-abi_: Migrate a few projects to the new Validator framework - https://phabricator.wikimedia.org/T224025 (10abi_) [13:36:55] 10MediaWiki-extensions-EditNotify: EditNotify cannot be restricted to page creations in certain namespaces. It always notifies about any page creation. - https://phabricator.wikimedia.org/T240656 (10Wikinaut) https://phabricator.wikimedia.org/T240391 is valid, as then - when you have also NewUserNotif active - t... [13:37:00] (03CR) 10jerkins-bot: [V: 04-1] VE: Update padding to match VisualEditor changes [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/557018 (https://phabricator.wikimedia.org/T238678) (owner: 10Bartosz Dziewoński) [13:37:25] (03CR) 10jerkins-bot: [V: 04-1] Make dump tests based on fixture files. [core] - 10https://gerrit.wikimedia.org/r/554919 (https://phabricator.wikimedia.org/T240213) (owner: 10Daniel Kinzler) [13:39:04] 10Wikimedia-General-or-Unknown: number of uploads in graphite - https://phabricator.wikimedia.org/T69116 (10fgiunchedi) 05Open→03Resolved a:03fgiunchedi Resolving as we're using metrics from swift to plot original uploads: https://grafana.wikimedia.org/d/OPgmB1Eiz/swift?orgId=1&from=now-3h&to=now-1m&var-DC... [13:41:14] (03CR) 10Addshore: [C: 03+2] Cleanup: Explicit public access [core] - 10https://gerrit.wikimedia.org/r/556991 (owner: 10Awight) [13:48:57] 10WMSE-Magnus Sälgö: Europeana Entity <-> Wikidata Property 7704 - https://phabricator.wikimedia.org/T240290 (10Salgo60) [13:51:12] (03PS24) 10Daniel Kinzler: Make dump tests based on fixture files. [core] - 10https://gerrit.wikimedia.org/r/554919 (https://phabricator.wikimedia.org/T240213) [13:52:57] (03CR) 10Sbisson: [C: 03+2] Add PLURAL to new messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/556999 (owner: 10Jon Harald Søby) [13:53:18] (03Merged) 10jenkins-bot: Cleanup: Explicit public access [core] - 10https://gerrit.wikimedia.org/r/556991 (owner: 10Awight) [13:55:35] (03PS1) 10Pwirth: Fix doc blocks, comments, replace usage of deprecated globals for phpcs [extensions/BlueSpiceCustomMenu] - 10https://gerrit.wikimedia.org/r/557019 [14:05:04] (03CR) 10jerkins-bot: [V: 04-1] Make dump tests based on fixture files. [core] - 10https://gerrit.wikimedia.org/r/554919 (https://phabricator.wikimedia.org/T240213) (owner: 10Daniel Kinzler) [14:05:58] (03Merged) 10jenkins-bot: Add PLURAL to new messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/556999 (owner: 10Jon Harald Søby) [14:12:55] (03PS1) 10Robert Vogel: Fix local login issue [extensions/LDAPAuthentication2] (REL1_31) - 10https://gerrit.wikimedia.org/r/557021 [14:14:08] (03CR) 10jerkins-bot: [V: 04-1] Fix local login issue [extensions/LDAPAuthentication2] (REL1_31) - 10https://gerrit.wikimedia.org/r/557021 (owner: 10Robert Vogel) [14:14:50] (03CR) 10Daimona Eaytoy: [C: 04-1] build: Upgrade phan (038 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/555686 (owner: 10Daimona Eaytoy) [14:21:14] (03PS2) 10Robert Vogel: Fix local login issue [extensions/LDAPAuthentication2] (REL1_31) - 10https://gerrit.wikimedia.org/r/557021 [14:22:12] (03CR) 10jerkins-bot: [V: 04-1] Fix local login issue [extensions/LDAPAuthentication2] (REL1_31) - 10https://gerrit.wikimedia.org/r/557021 (owner: 10Robert Vogel) [14:25:12] (03PS6) 10Daimona Eaytoy: build: Upgrade phan [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/555686 [14:25:30] (03CR) 10Daimona Eaytoy: build: Upgrade phan (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/555686 (owner: 10Daimona Eaytoy) [14:27:03] (03PS1) 10Pwirth: Fix covers, doc blocks, line too long, function visibility for phpcs [extensions/BlueSpiceDashboards] - 10https://gerrit.wikimedia.org/r/557025 [14:30:08] (03PS1) 10Daimona Eaytoy: Autofix 94 PHPUnit 8 compat issues [core] - 10https://gerrit.wikimedia.org/r/557026 (https://phabricator.wikimedia.org/T192167) [14:31:13] (03PS7) 10Daimona Eaytoy: Upgrade to PHPUnit 8 [core] - 10https://gerrit.wikimedia.org/r/552312 (https://phabricator.wikimedia.org/T192167) [14:32:39] (03PS1) 10Pcoombe: Third set of English fundraising banners for portal [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/557027 (https://phabricator.wikimedia.org/T234467) [14:33:15] (03PS1) 10Pwirth: Fix line too long for phpcs [extensions/BlueSpiceEmoticons] - 10https://gerrit.wikimedia.org/r/557028 [14:37:26] (03PS3) 10Bartosz Dziewoński: ReplyWidget: Handle save errors [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/556315 (https://phabricator.wikimedia.org/T240519) [14:37:29] (03PS1) 10Bartosz Dziewoński: Correct typos to fix edit conflict detection [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/557030 (https://phabricator.wikimedia.org/T240643) [14:39:51] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/555686 (owner: 10Daimona Eaytoy) [14:44:59] (03CR) 10jerkins-bot: [V: 04-1] Upgrade to PHPUnit 8 [core] - 10https://gerrit.wikimedia.org/r/552312 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [14:47:07] (03PS1) 10Bartosz Dziewoński: ApiEditPage: Fix error message for edit conflicts [core] - 10https://gerrit.wikimedia.org/r/557035 [14:49:07] (03PS1) 10Pwirth: Fix global prefix and doc blocks for phpcs [extensions/BlueSpiceExtendedFilelist] - 10https://gerrit.wikimedia.org/r/557037 [14:54:06] (03PS2) 10Bartosz Dziewoński: VE: Update padding to match VisualEditor changes [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/557018 (https://phabricator.wikimedia.org/T238678) [14:57:00] (03PS7) 10Daimona Eaytoy: build: Upgrade phan [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/555686 [14:57:18] (03PS8) 10Daimona Eaytoy: build: Upgrade phan [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/555686 [15:02:21] (03PS1) 10Pwirth: Fix covers and doc blocks for phpcs [extensions/BlueSpiceGroupManager] - 10https://gerrit.wikimedia.org/r/557042 [15:02:25] (03PS1) 10Ejegg: Update Smash-Pig library [vendor] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/557043 [15:03:13] (03CR) 10Ejegg: [C: 03+2] Update Smash-Pig library [vendor] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/557043 (owner: 10Ejegg) [15:03:18] (03Abandoned) 10Bartosz Dziewoński: Reduce code duplication around Article::showMissingArticle() [core] - 10https://gerrit.wikimedia.org/r/481941 (owner: 10Bartosz Dziewoński) [15:03:38] (03Merged) 10jenkins-bot: Update Smash-Pig library [vendor] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/557043 (owner: 10Ejegg) [15:06:26] (03PS1) 10Ejegg: update vendor submodule [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/557044 [15:09:51] (03CR) 10jerkins-bot: [V: 04-1] update vendor submodule [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/557044 (owner: 10Ejegg) [15:23:19] (03PS13) 10Esanders: Option to integrate VisualEditor instead of textarea [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/552146 (owner: 10Bartosz Dziewoński) [15:25:30] (03PS8) 10Daimona Eaytoy: Upgrade to PHPUnit 8 [core] - 10https://gerrit.wikimedia.org/r/552312 (https://phabricator.wikimedia.org/T192167) [15:28:23] (03CR) 10Awight: [WIP] Several unrelated code cleanups (031 comment) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/555956 (owner: 10Thiemo Kreuz (WMDE)) [15:29:50] (03CR) 10Esanders: [C: 03+2] Correct typos to fix edit conflict detection [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/557030 (https://phabricator.wikimedia.org/T240643) (owner: 10Bartosz Dziewoński) [15:34:42] (03PS1) 10Yaron Koren: Use hooks to improve saving of categories in _pageData [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/557045 [15:41:05] (03Merged) 10jenkins-bot: Correct typos to fix edit conflict detection [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/557030 (https://phabricator.wikimedia.org/T240643) (owner: 10Bartosz Dziewoński) [15:42:51] (03CR) 10Bartosz Dziewoński: "I think it's still actively used?" [core] - 10https://gerrit.wikimedia.org/r/555579 (owner: 10Jdlrobson) [15:46:37] (03CR) 10Anomie: Standardize information on Password Reset success page (031 comment) [core] - 10https://gerrit.wikimedia.org/r/556102 (https://phabricator.wikimedia.org/T238961) (owner: 10Samwilson) [15:47:31] (03PS14) 10Jason Linehan: Adds module to instrument client runtime errors. [core] - 10https://gerrit.wikimedia.org/r/553376 (https://phabricator.wikimedia.org/T235189) [15:48:33] (03PS2) 10Ejegg: update vendor submodule [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/557044 [15:49:31] (03PS25) 10Daniel Kinzler: Make dump tests based on fixture files. [core] - 10https://gerrit.wikimedia.org/r/554919 (https://phabricator.wikimedia.org/T240213) [15:52:40] (03PS17) 10Abijeet Patro: Update setlang to display confirmation dialog to change language [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/551940 (https://phabricator.wikimedia.org/T63115) [15:53:56] (03PS26) 10Daniel Kinzler: Make dump tests based on fixture files. [core] - 10https://gerrit.wikimedia.org/r/554919 (https://phabricator.wikimedia.org/T240213) [15:55:05] (03CR) 10Ejegg: [C: 03+2] update vendor submodule [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/557044 (owner: 10Ejegg) [15:58:10] (03CR) 10Abijeet Patro: Update setlang to display confirmation dialog to change language (033 comments) [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/551940 (https://phabricator.wikimedia.org/T63115) (owner: 10Abijeet Patro) [15:58:40] (03PS1) 10Sohom Datta: Change vscode file config in .gitignore [extensions/ProtectionIndicator] - 10https://gerrit.wikimedia.org/r/557054 [15:58:44] (03CR) 10jerkins-bot: [V: 04-1] Adds module to instrument client runtime errors. [core] - 10https://gerrit.wikimedia.org/r/553376 (https://phabricator.wikimedia.org/T235189) (owner: 10Jason Linehan) [15:59:27] (03CR) 10Sohom Datta: [C: 03+2] Change vscode file config in .gitignore [extensions/ProtectionIndicator] - 10https://gerrit.wikimedia.org/r/557054 (owner: 10Sohom Datta) [16:00:12] (03Merged) 10jenkins-bot: update vendor submodule [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/557044 (owner: 10Ejegg) [16:00:30] (03CR) 10Jason Linehan: "Still need to throw in a couple config variables, will do that next. Have we covered everything about what fields we want to send/not send" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/553376 (https://phabricator.wikimedia.org/T235189) (owner: 10Jason Linehan) [16:01:51] (03PS1) 10Umherirrender: Split classes in PageStabilityForm.php [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/557055 [16:01:56] (03PS15) 10Jason Linehan: Adds module to instrument client runtime errors. [core] - 10https://gerrit.wikimedia.org/r/553376 (https://phabricator.wikimedia.org/T235189) [16:04:42] (03PS1) 10Umherirrender: Split classes in WatchTopicListener.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/557056 [16:10:32] (03PS1) 10Umherirrender: Fix doc of LdapAuthenticationPlugin::printDebug [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/557057 [16:13:34] Daylen: hello! [16:13:55] hi Urbanecm :) [16:13:56] (03CR) 10jerkins-bot: [V: 04-1] Adds module to instrument client runtime errors. [core] - 10https://gerrit.wikimedia.org/r/553376 (https://phabricator.wikimedia.org/T235189) (owner: 10Jason Linehan) [16:14:02] hi Gopa [16:14:18] (03Merged) 10jenkins-bot: Change vscode file config in .gitignore [extensions/ProtectionIndicator] - 10https://gerrit.wikimedia.org/r/557054 (owner: 10Sohom Datta) [16:16:24] (03PS1) 10Umherirrender: Fix doc of LoginNotify::generateUserCookieRecord [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/557058 [16:18:19] (03PS1) 10Umherirrender: Add missing int casts [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/557059 [16:18:49] Hello? [16:19:23] !ask | TechneSiyam [16:19:23] TechneSiyam: Please feel free to ask your question: if anybody who knows the answer is around, they will surely reply. Don't ask for help or for attention before actually asking your question, that's just a waste of time – both yours and everybody else's. :) [16:19:28] Hi TechneSiyam [16:19:47] (TechneSiyam) How to upload as a new patchset and not as a new review? [16:19:55] And whats the difference? [16:20:07] See https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change_.28your_own_or_someone_else.27s.29 [16:20:17] The difference is that a new patchset is in the same URL, so you have the old comments attached as well; keep the history [16:20:57] Same as a task in Phab: You still have all comments and all progress on the same patchset, and you can diff from one patchset to another, and you keep the reviewers etc :) [16:23:57] So I use git commit --amend and not git review? [16:26:19] Ebe123: any answer? [16:26:20] (03PS1) 10Anomie: Tests for an old PHP bug in parse_url [core] - 10https://gerrit.wikimedia.org/r/557062 (https://phabricator.wikimedia.org/T212067) [16:26:28] Both [16:26:33] TechneSiyam, no, see the link I posted [16:26:43] git commit --amend (--all) and git review [16:28:36] Ebe123:Okay.is --all important? [16:28:44] (03PS1) 10Raimond Spekking: Document message "echo-blacklist" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/557063 [16:28:56] If you want to skip staging, yes [16:29:15] andre__:yeah i saw the link..but didn't understand..so i am asking here :( [16:30:30] TechneSiyam, in that case I'd love to understand which sentence is unclear, to improve the documentation :) [16:33:32] https://www.irccloud.com/pastebin/MoraBMtN/ [16:33:59] andre__: I wasn't sure if I have to use git review...Because I misunderstood Ebe123's sentence....Where he told me to upload in a new patchset inspite of a new review...and I thought i dont need git review :( [16:35:18] TechneSiyam: I have prepared a short and quick notes for you to avoid duplicate patch-sets above, Please go throgh this once, and feel free to ask us if you dont understand any thing here. [16:37:38] reposting the above Image URL: https://ibb.co/0tBZw8Z [16:37:38] As the above msg doesnt went as a hyperlink. [16:47:53] (03PS4) 10Anomie: Add league/oauth2-server for mediawiki/extensions/OAuth [vendor] - 10https://gerrit.wikimedia.org/r/552303 [16:48:14] (03CR) 10Anomie: "recheck" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/545283 (https://phabricator.wikimedia.org/T229508) (owner: 10ItSpiderman) [16:48:55] (03CR) 10Anomie: "recheck" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/550847 (https://phabricator.wikimedia.org/T229501) (owner: 10ItSpiderman) [16:52:52] (03CR) 10Matthias Mullie: [C: 03+2] Re-instate automatic redirect from search box in some cases [core] - 10https://gerrit.wikimedia.org/r/556660 (https://phabricator.wikimedia.org/T240260) (owner: 10Cparle) [16:53:00] (03CR) 10Esanders: [C: 03+2] VE: Update padding to match VisualEditor changes [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/557018 (https://phabricator.wikimedia.org/T238678) (owner: 10Bartosz Dziewoński) [16:59:48] (03CR) 10Anomie: [C: 03+1] "One question, otherwise +2." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/556509 (https://phabricator.wikimedia.org/T233342) (owner: 10Krinkle) [17:00:14] (03PS1) 10Daniel Kinzler: BlobStore: suppoer "known bad" addresses. [core] - 10https://gerrit.wikimedia.org/r/557068 (https://phabricator.wikimedia.org/T240686) [17:01:56] (03PS2) 10Daniel Kinzler: BlobStore: support "known bad" addresses. [core] - 10https://gerrit.wikimedia.org/r/557068 (https://phabricator.wikimedia.org/T240686) [17:06:37] (03Merged) 10jenkins-bot: Re-instate automatic redirect from search box in some cases [core] - 10https://gerrit.wikimedia.org/r/556660 (https://phabricator.wikimedia.org/T240260) (owner: 10Cparle) [17:06:41] (03Merged) 10jenkins-bot: VE: Update padding to match VisualEditor changes [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/557018 (https://phabricator.wikimedia.org/T238678) (owner: 10Bartosz Dziewoński) [17:07:13] (03CR) 10Anomie: "Seems generally ok at first glance, a few nitpicks inline. Haven't checked behavior of callers or tested." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/557068 (https://phabricator.wikimedia.org/T240686) (owner: 10Daniel Kinzler) [17:08:26] (03PS2) 10Yaron Koren: Use hooks to improve saving of categories in _pageData [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/557045 [17:09:31] (03CR) 10jerkins-bot: [V: 04-1] Use hooks to improve saving of categories in _pageData [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/557045 (owner: 10Yaron Koren) [17:13:13] (03CR) 10Reedy: [C: 03+2] Tests for an old PHP bug in parse_url [core] - 10https://gerrit.wikimedia.org/r/557062 (https://phabricator.wikimedia.org/T212067) (owner: 10Anomie) [17:16:17] (03PS3) 10Yaron Koren: Use hooks to improve saving of categories in _pageData [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/557045 [17:20:27] (03CR) 10Yaron Koren: [C: 03+2] Use hooks to improve saving of categories in _pageData [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/557045 (owner: 10Yaron Koren) [17:21:04] (03CR) 10Pmiazga: Adds module to instrument client runtime errors. (037 comments) [core] - 10https://gerrit.wikimedia.org/r/553376 (https://phabricator.wikimedia.org/T235189) (owner: 10Jason Linehan) [17:25:58] (03Merged) 10jenkins-bot: Tests for an old PHP bug in parse_url [core] - 10https://gerrit.wikimedia.org/r/557062 (https://phabricator.wikimedia.org/T212067) (owner: 10Anomie) [17:26:00] (03Merged) 10jenkins-bot: Use hooks to improve saving of categories in _pageData [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/557045 (owner: 10Yaron Koren) [17:30:51] (03CR) 10Pmiazga: "sorry, I noticed I commented on old patch but some comments still apply." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/553376 (https://phabricator.wikimedia.org/T235189) (owner: 10Jason Linehan) [17:32:57] (03PS4) 10Tobi 406: MessagesDe.php: Add aliases for special pages [core] - 10https://gerrit.wikimedia.org/r/556227 [17:38:02] Hello, Urbanecm! [17:38:12] Hi Daylen [17:43:04] (03PS1) 10Krinkle: API: Deprecate wgEnableOpenSearchSuggest and opensearch+suggest parameter [core] - 10https://gerrit.wikimedia.org/r/557077 [17:43:53] (03CR) 10Krinkle: "This was prompted by the otherwise unrelated T240691." [core] - 10https://gerrit.wikimedia.org/r/557077 (owner: 10Krinkle) [17:46:52] (03CR) 10Krinkle: exception: Remove ErrorException workaround in handleFatalError() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/556509 (https://phabricator.wikimedia.org/T233342) (owner: 10Krinkle) [17:47:12] (03PS1) 10Daimona Eaytoy: Deprecate and stop using assertType(OrValue) [core] - 10https://gerrit.wikimedia.org/r/557080 (https://phabricator.wikimedia.org/T192167) [17:47:46] (03CR) 10Krinkle: exception: Remove ErrorException workaround in handleFatalError() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/556509 (https://phabricator.wikimedia.org/T233342) (owner: 10Krinkle) [17:48:32] (03PS9) 10Daimona Eaytoy: Upgrade to PHPUnit 8 [core] - 10https://gerrit.wikimedia.org/r/552312 (https://phabricator.wikimedia.org/T192167) [17:50:57] (03PS3) 10Daniel Kinzler: BlobStore: support "known bad" addresses. [core] - 10https://gerrit.wikimedia.org/r/557068 (https://phabricator.wikimedia.org/T240686) [17:51:09] (03CR) 10Daniel Kinzler: BlobStore: support "known bad" addresses. (033 comments) [core] - 10https://gerrit.wikimedia.org/r/557068 (https://phabricator.wikimedia.org/T240686) (owner: 10Daniel Kinzler) [18:05:17] (03CR) 10Anomie: BlobStore: support "known bad" addresses. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/557068 (https://phabricator.wikimedia.org/T240686) (owner: 10Daniel Kinzler) [18:06:34] (03CR) 10Jdlrobson: [C: 03+2] Add `@font-size-root` var and rename `@font-size-body-mobile` [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/555015 (owner: 10VolkerE) [18:08:29] (03CR) 10Pmiazga: Hygiene: use the vectorConfig class as single vector config (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/551643 (owner: 10Pmiazga) [18:10:56] (03CR) 10Anomie: [C: 03+1] "One request for a comment, otherwise looks good to me." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/557077 (owner: 10Krinkle) [18:11:50] (03PS2) 10Krinkle: API: Deprecate wgEnableOpenSearchSuggest and opensearch+suggest parameter [core] - 10https://gerrit.wikimedia.org/r/557077 [18:11:52] (03CR) 10Anomie: [C: 03+2] "Ok." [core] - 10https://gerrit.wikimedia.org/r/556509 (https://phabricator.wikimedia.org/T233342) (owner: 10Krinkle) [18:13:32] (03CR) 10Anomie: [C: 03+2] API: Deprecate wgEnableOpenSearchSuggest and opensearch+suggest parameter [core] - 10https://gerrit.wikimedia.org/r/557077 (owner: 10Krinkle) [18:16:12] (03PS4) 10Esanders: Add beforeunload handlers [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/556204 (https://phabricator.wikimedia.org/T240259) [18:16:14] (03PS3) 10Esanders: Prompt users when pressing 'cancel' with content in the widget [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/556210 (https://phabricator.wikimedia.org/T240271) [18:20:15] (03Merged) 10jenkins-bot: Add `@font-size-root` var and rename `@font-size-body-mobile` [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/555015 (owner: 10VolkerE) [18:22:14] (03PS1) 10Daimona Eaytoy: Manual fix of the remaining assertInternalType & Co. [core] - 10https://gerrit.wikimedia.org/r/557087 (https://phabricator.wikimedia.org/T192167) [18:22:43] (03PS10) 10Daimona Eaytoy: Upgrade to PHPUnit 8 [core] - 10https://gerrit.wikimedia.org/r/552312 (https://phabricator.wikimedia.org/T192167) [18:24:42] (03PS1) 10Brian Wolff: Allow tiff files to be uploaded that identify can't find alpha [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/557089 (https://phabricator.wikimedia.org/T240455) [18:25:45] (03Merged) 10jenkins-bot: exception: Remove ErrorException workaround in handleFatalError() [core] - 10https://gerrit.wikimedia.org/r/556509 (https://phabricator.wikimedia.org/T233342) (owner: 10Krinkle) [18:26:09] (03Merged) 10jenkins-bot: API: Deprecate wgEnableOpenSearchSuggest and opensearch+suggest parameter [core] - 10https://gerrit.wikimedia.org/r/557077 (owner: 10Krinkle) [18:37:09] (03CR) 10jerkins-bot: [V: 04-1] Manual fix of the remaining assertInternalType & Co. [core] - 10https://gerrit.wikimedia.org/r/557087 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [18:37:19] (03CR) 10jerkins-bot: [V: 04-1] Upgrade to PHPUnit 8 [core] - 10https://gerrit.wikimedia.org/r/552312 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [18:37:33] (03CR) 10Jdlrobson: [C: 04-1] "See https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/549220/10" [core] - 10https://gerrit.wikimedia.org/r/555579 (owner: 10Jdlrobson) [18:43:49] (03PS2) 10Daimona Eaytoy: Manual fix of the remaining assertInternalType & Co. [core] - 10https://gerrit.wikimedia.org/r/557087 (https://phabricator.wikimedia.org/T192167) [18:43:57] (03PS11) 10Daimona Eaytoy: Upgrade to PHPUnit 8 [core] - 10https://gerrit.wikimedia.org/r/552312 (https://phabricator.wikimedia.org/T192167) [18:48:55] (03CR) 10DLynch: [C: 03+2] Add beforeunload handlers [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/556204 (https://phabricator.wikimedia.org/T240259) (owner: 10Esanders) [18:49:03] (03CR) 10DLynch: [C: 03+2] Prompt users when pressing 'cancel' with content in the widget [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/556210 (https://phabricator.wikimedia.org/T240271) (owner: 10Esanders) [18:49:55] (03PS3) 10Jdlrobson: Use mobile-friendly warningbox class [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/394126 [18:56:15] (03PS61) 10Daimona Eaytoy: Add a maintenance script to clean afl_var_dump [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482499 (https://phabricator.wikimedia.org/T213006) [18:56:22] (03PS34) 10Daimona Eaytoy: Start using new format for var dumps [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482500 (https://phabricator.wikimedia.org/T213006) [18:56:55] (03CR) 10jerkins-bot: [V: 04-1] Add a maintenance script to clean afl_var_dump [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482499 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [18:57:38] (03PS4) 10Dmaza: Add Compare service to fetch compare data [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/555619 (https://phabricator.wikimedia.org/T238714) [18:57:52] (03PS62) 10Daimona Eaytoy: Add a maintenance script to clean afl_var_dump [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482499 (https://phabricator.wikimedia.org/T213006) [18:58:18] (03PS4) 10Jdlrobson: Use mobile-friendly warningbox class [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/394126 [18:59:11] (03PS70) 10Daimona Eaytoy: Split afl_filter in afl_filter_id and afl_global [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/459818 (https://phabricator.wikimedia.org/T220791) [19:00:40] (03Merged) 10jenkins-bot: Add beforeunload handlers [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/556204 (https://phabricator.wikimedia.org/T240259) (owner: 10Esanders) [19:00:42] (03Merged) 10jenkins-bot: Prompt users when pressing 'cancel' with content in the widget [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/556210 (https://phabricator.wikimedia.org/T240271) (owner: 10Esanders) [19:02:46] (03CR) 10Nray: Make toolbar on user talk page match toolbar on user page (033 comments) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556294 (https://phabricator.wikimedia.org/T235681) (owner: 10Nray) [19:09:54] (03CR) 10jerkins-bot: [V: 04-1] Add a maintenance script to clean afl_var_dump [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482499 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [19:11:04] (03PS3) 10Jdlrobson: Use .html() instead of .text() when passing talk section title into Section [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556843 (https://phabricator.wikimedia.org/T240487) (owner: 10Nray) [19:11:54] (03CR) 10Dmaza: Add Compare service to fetch compare data (033 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/555619 (https://phabricator.wikimedia.org/T238714) (owner: 10Dmaza) [19:12:18] (03PS19) 10Nray: Resemble AMC mode for all users on user pages & user talk pages [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556223 (https://phabricator.wikimedia.org/T232653) [19:13:02] (03PS11) 10Daimona Eaytoy: Remove outdated config settings [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/539701 [19:13:13] (03PS11) 10Daimona Eaytoy: Add UnusedSuppressionPlugin limited to our warnings [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/523108 (https://phabricator.wikimedia.org/T203344) [19:14:17] (03CR) 10Nray: "linting errors should be fixed now, but tests will still be broken. I need to switch gears to the other work discussed over slack. @Jdlrob" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556223 (https://phabricator.wikimedia.org/T232653) (owner: 10Nray) [19:14:28] (03CR) 10Jdlrobson: [C: 03+2] Use .html() instead of .text() when passing talk section title into Section [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556843 (https://phabricator.wikimedia.org/T240487) (owner: 10Nray) [19:22:43] (03CR) 10Umherirrender: [C: 03+1] MessagesDe.php: Add aliases for special pages [core] - 10https://gerrit.wikimedia.org/r/556227 (owner: 10Tobi 406) [19:26:08] (03CR) 10jerkins-bot: [V: 04-1] Resemble AMC mode for all users on user pages & user talk pages [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556223 (https://phabricator.wikimedia.org/T232653) (owner: 10Nray) [19:27:52] (03Merged) 10jenkins-bot: Use .html() instead of .text() when passing talk section title into Section [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556843 (https://phabricator.wikimedia.org/T240487) (owner: 10Nray) [19:33:38] (03PS20) 10Jdlrobson: Resemble AMC mode for all users on user pages & user talk pages [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556223 (https://phabricator.wikimedia.org/T232653) (owner: 10Nray) [19:35:06] (03PS1) 10SBassett: Use .html() instead of .text() when passing talk section title into Section [skins/MinervaNeue] (wmf/1.35.0-wmf.10) - 10https://gerrit.wikimedia.org/r/557097 (https://phabricator.wikimedia.org/T240487) [19:35:45] (03CR) 10jerkins-bot: [V: 04-1] MessagesDe.php: Add aliases for special pages [core] - 10https://gerrit.wikimedia.org/r/556227 (owner: 10Tobi 406) [19:44:20] (03PS11) 10Jdlrobson: Remove references from the DOM on close and manage body classes [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/553163 (https://phabricator.wikimedia.org/T214045) [19:47:11] (03CR) 10jerkins-bot: [V: 04-1] Resemble AMC mode for all users on user pages & user talk pages [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556223 (https://phabricator.wikimedia.org/T232653) (owner: 10Nray) [19:48:51] (03CR) 10SBassett: [C: 03+2] Use .html() instead of .text() when passing talk section title into Section [skins/MinervaNeue] (wmf/1.35.0-wmf.10) - 10https://gerrit.wikimedia.org/r/557097 (https://phabricator.wikimedia.org/T240487) (owner: 10SBassett) [19:52:37] (03PS1) 10Pmiazga: Add History icon and Article/Talk tabs to default loggedin experience [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/557100 (https://phabricator.wikimedia.org/T232594) [19:57:23] (03PS21) 10Jdlrobson: Resemble AMC mode for all users on user pages & user talk pages [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556223 (https://phabricator.wikimedia.org/T232653) (owner: 10Nray) [19:58:23] (03CR) 10Jdlrobson: [C: 03+1] "waiting on jenkins but looks +2able" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/557100 (https://phabricator.wikimedia.org/T232594) (owner: 10Pmiazga) [20:01:34] (03Merged) 10jenkins-bot: Use .html() instead of .text() when passing talk section title into Section [skins/MinervaNeue] (wmf/1.35.0-wmf.10) - 10https://gerrit.wikimedia.org/r/557097 (https://phabricator.wikimedia.org/T240487) (owner: 10SBassett) [20:05:53] (03CR) 10Ottomata: [C: 03+2] Set WMF specific event field values if they are not set by client [eventgate-wikimedia] - 10https://gerrit.wikimedia.org/r/556484 (https://phabricator.wikimedia.org/T240477) (owner: 10Ottomata) [20:06:00] (03CR) 10jerkins-bot: [V: 04-1] Add History icon and Article/Talk tabs to default loggedin experience [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/557100 (https://phabricator.wikimedia.org/T232594) (owner: 10Pmiazga) [20:10:10] (03PS7) 10Mholloway: Inform the user when a depicts statement already exists [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/556804 [20:11:16] (03CR) 10jerkins-bot: [V: 04-1] Resemble AMC mode for all users on user pages & user talk pages [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556223 (https://phabricator.wikimedia.org/T232653) (owner: 10Nray) [20:11:51] (03CR) 10Catrope: [C: 04-1] "The reason the tests fail is because the jqueryMsg test harness has some hacky code that loads the mediawiki.language module multiple time" [core] - 10https://gerrit.wikimedia.org/r/487101 (owner: 10Catrope) [20:12:39] (03CR) 10Mholloway: "> Also, Michael, do you think it's worth trying to include the" [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/556804 (owner: 10Mholloway) [20:16:45] (03PS22) 10Jdlrobson: Resemble AMC mode for all users on user pages & user talk pages [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556223 (https://phabricator.wikimedia.org/T232653) (owner: 10Nray) [20:17:16] (03CR) 10Mholloway: "PS - For testing this locally you will probably want to hard-code $depictsPropertyId to 'P180' rather than using your local setting. P1, f" [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/556804 (owner: 10Mholloway) [20:17:51] (03CR) 10Mholloway: "This is referring to L238 of ApiReviewImageLabels." [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/556804 (owner: 10Mholloway) [20:20:36] (03CR) 10Niedzielski: [C: 03+2] Remove references from the DOM on close and manage body classes [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/553163 (https://phabricator.wikimedia.org/T214045) (owner: 10Jdlrobson) [20:24:56] (03PS2) 10Jdlrobson: Add History icon and Article/Talk tabs to default loggedin experience [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/557100 (https://phabricator.wikimedia.org/T232594) (owner: 10Pmiazga) [20:30:41] (03PS1) 10Umherirrender: Fix doc of Language::sprintfDate [core] - 10https://gerrit.wikimedia.org/r/557107 [20:33:16] (03PS1) 10Umherirrender: Use string as prefix for http_build_query [extensions/XAnalytics] - 10https://gerrit.wikimedia.org/r/557109 [20:34:20] (03Merged) 10jenkins-bot: Remove references from the DOM on close and manage body classes [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/553163 (https://phabricator.wikimedia.org/T214045) (owner: 10Jdlrobson) [20:43:06] (03CR) 10Nray: [C: 03+1] "thanks for fixing the tests Jon!" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556223 (https://phabricator.wikimedia.org/T232653) (owner: 10Nray) [20:46:20] (03CR) 10Pmiazga: Resemble AMC mode for all users on user pages & user talk pages (034 comments) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556223 (https://phabricator.wikimedia.org/T232653) (owner: 10Nray) [20:46:28] (03CR) 10jerkins-bot: [V: 04-1] Add History icon and Article/Talk tabs to default loggedin experience [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/557100 (https://phabricator.wikimedia.org/T232594) (owner: 10Pmiazga) [20:49:15] (03PS1) 10Umherirrender: Add missing float cast [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/557111 [20:53:13] (03PS1) 10Umherirrender: Fix doc of WikiHiero::resizeGlyph [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/557112 [21:04:39] (03PS3) 10Jdlrobson: Add History icon and Article/Talk tabs to default loggedin experience [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/557100 (https://phabricator.wikimedia.org/T232594) (owner: 10Pmiazga) [21:04:44] (03CR) 10Jdlrobson: [C: 03+2] Add History icon and Article/Talk tabs to default loggedin experience [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/557100 (https://phabricator.wikimedia.org/T232594) (owner: 10Pmiazga) [21:07:34] (03CR) 10Jdlrobson: [C: 03+1] "piotr feel free to +2 if you think this is the right approach!" (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556223 (https://phabricator.wikimedia.org/T232653) (owner: 10Nray) [21:07:44] (03PS6) 10Jdlrobson: Remove haspageactions from MinervaTemplate templateData [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/555584 (https://phabricator.wikimedia.org/T232653) (owner: 10Nray) [21:08:23] (03PS7) 10Jdlrobson: Remove haspageactions from MinervaTemplate templateData [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/555584 (https://phabricator.wikimedia.org/T232653) (owner: 10Nray) [21:08:25] (03CR) 10Jdlrobson: [C: 03+2] Remove haspageactions from MinervaTemplate templateData [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/555584 (https://phabricator.wikimedia.org/T232653) (owner: 10Nray) [21:13:00] (03PS1) 10Anne Tomasevich: Don't show focus outline on suggestions unless user presses tab [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/557116 (https://phabricator.wikimedia.org/T240510) [21:14:33] (03CR) 10Umherirrender: build: Upgrade phan (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/555686 (owner: 10Daimona Eaytoy) [21:15:16] (03PS2) 10Anne Tomasevich: Don't show focus outline on suggestions unless user presses tab [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/557116 (https://phabricator.wikimedia.org/T240510) [21:18:38] (03Merged) 10jenkins-bot: Add History icon and Article/Talk tabs to default loggedin experience [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/557100 (https://phabricator.wikimedia.org/T232594) (owner: 10Pmiazga) [21:22:40] (03Merged) 10jenkins-bot: Remove haspageactions from MinervaTemplate templateData [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/555584 (https://phabricator.wikimedia.org/T232653) (owner: 10Nray) [21:23:32] (03PS1) 10Umherirrender: Use friends of WebRequest::getVal [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/557118 [21:23:55] (03CR) 10Anne Tomasevich: [C: 03+1] "Nice, thanks for making that update! Works for me." [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/556804 (owner: 10Mholloway) [21:24:36] (03CR) 10VolkerE: [C: 03+2] Use mobile-friendly warningbox class [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/394126 (owner: 10Jdlrobson) [21:29:19] (03PS1) 10Umherirrender: Use WebRequest::getInt for limit parameter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/557119 [21:30:00] (03Merged) 10jenkins-bot: Use mobile-friendly warningbox class [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/394126 (owner: 10Jdlrobson) [21:32:17] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/557119 (owner: 10Umherirrender) [21:35:00] (03CR) 10Daimona Eaytoy: build: Upgrade phan (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/555686 (owner: 10Daimona Eaytoy) [21:36:51] (03PS1) 10Umherirrender: Use correct default on WebRequest::getVal [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/557121 [21:36:53] (03PS9) 10Daimona Eaytoy: build: Upgrade phan [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/555686 [21:40:09] (03PS1) 10Umherirrender: Use correct default on WebRequest::getVal [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/557122 [21:42:14] (03PS1) 10Umherirrender: Use User::getBoolOption [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/557123 [21:44:00] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/557122 (owner: 10Umherirrender) [21:44:10] (03PS1) 10Umherirrender: Use correct default on WebRequest::getArray [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/557124 [21:45:10] (03CR) 10jerkins-bot: [V: 04-1] Don't show focus outline on suggestions unless user presses tab [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/557116 (https://phabricator.wikimedia.org/T240510) (owner: 10Anne Tomasevich) [21:45:32] (03PS1) 10Umherirrender: Use WebRequest::getBool to have bool cast [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/557125 [21:47:21] (03PS1) 10Umherirrender: Use correct default on WebRequest::getVal [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/557126 [21:47:29] (03PS1) 10Mholloway: Add navigation link to sidebar [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/557127 (https://phabricator.wikimedia.org/T240646) [21:48:41] (03CR) 10jerkins-bot: [V: 04-1] Add navigation link to sidebar [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/557127 (https://phabricator.wikimedia.org/T240646) (owner: 10Mholloway) [21:49:52] (03PS2) 10Mholloway: Add navigation link to sidebar [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/557127 (https://phabricator.wikimedia.org/T240646) [21:51:49] (03PS1) 10Umherirrender: Fix handling of filetimestamp request parameter [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/557129 [21:52:40] (03PS1) 10Umherirrender: Use string default on WebRequest::getVal [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/557130 [21:54:30] (03CR) 10Mholloway: [C: 04-1] "I suppose this should be behind a config variable." [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/557127 (https://phabricator.wikimedia.org/T240646) (owner: 10Mholloway) [21:55:50] (03CR) 10jerkins-bot: [V: 04-1] Use User::getBoolOption [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/557123 (owner: 10Umherirrender) [21:57:43] (03PS14) 10Esanders: Option to integrate VisualEditor instead of textarea [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/552146 (owner: 10Bartosz Dziewoński) [21:57:56] (03PS2) 10Umherirrender: Remove wrong default value from WebRequest::getVal call [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/557126 [21:59:05] (03PS2) 10Umherirrender: Use correct default on WebRequest::getArray [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/557124 [21:59:51] (03PS2) 10Umherirrender: Remove wrong default value from WebRequest::getVal call [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/557122 [21:59:58] (03PS3) 10Anne Tomasevich: Don't show focus outline on suggestions unless user presses tab [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/557116 (https://phabricator.wikimedia.org/T240510) [22:00:46] (03PS2) 10Umherirrender: Remove wrong default value from WebRequest::getVal call [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/557121 [22:01:19] (03CR) 10Umherirrender: "recheck" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/557123 (owner: 10Umherirrender) [22:01:39] (03CR) 10Umherirrender: [C: 03+1] "recheck" [core] - 10https://gerrit.wikimedia.org/r/556227 (owner: 10Tobi 406) [22:02:42] (03PS23) 10Nray: Resemble AMC mode for all users on user pages & user talk pages [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556223 (https://phabricator.wikimedia.org/T232653) [22:03:02] (03CR) 10jerkins-bot: [V: 04-1] Resemble AMC mode for all users on user pages & user talk pages [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556223 (https://phabricator.wikimedia.org/T232653) (owner: 10Nray) [22:05:08] (03CR) 10SonarQube Bot: "❌ Quality gate failed" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/557122 (owner: 10Umherirrender) [22:09:44] (03PS1) 10Zoranzoki21: Remove "hi (copy)" directory [sandbox] - 10https://gerrit.wikimedia.org/r/557135 [22:10:05] (03PS3) 10Mholloway: Add navigation link to sidebar [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/557127 (https://phabricator.wikimedia.org/T240646) [22:10:07] (03CR) 10Zoranzoki21: [V: 03+2 C: 03+2] Remove "hi (copy)" directory [sandbox] - 10https://gerrit.wikimedia.org/r/557135 (owner: 10Zoranzoki21) [22:10:47] (03PS4) 10Mholloway: Add navigation link to sidebar [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/557127 (https://phabricator.wikimedia.org/T240646) [22:10:57] (03PS24) 10Jdlrobson: Resemble AMC mode for all users on user pages & user talk pages [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556223 (https://phabricator.wikimedia.org/T232653) (owner: 10Nray) [22:11:02] (03PS1) 10Zoranzoki21: Move BubblySprout.txt into the gci/ directory [sandbox] - 10https://gerrit.wikimedia.org/r/557136 [22:11:16] (03CR) 10Zoranzoki21: [V: 03+2 C: 03+2] Move BubblySprout.txt into the gci/ directory [sandbox] - 10https://gerrit.wikimedia.org/r/557136 (owner: 10Zoranzoki21) [22:13:17] (03PS15) 10Esanders: Option to integrate VisualEditor instead of textarea [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/552146 (owner: 10Bartosz Dziewoński) [22:24:48] (03CR) 10Halfak: [C: 03+2] Implement Api modules [extensions/Jade] - 10https://gerrit.wikimedia.org/r/536659 (https://phabricator.wikimedia.org/T199834) (owner: 10Accraze) [22:25:59] (03CR) 10Nuria: Adds module to instrument client runtime errors. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/553376 (https://phabricator.wikimedia.org/T235189) (owner: 10Jason Linehan) [22:26:19] (03CR) 10Halfak: [C: 03+2] "Nice work! I think this looks good from my view and I think it's good that we get this in beta." [extensions/Jade] - 10https://gerrit.wikimedia.org/r/536659 (https://phabricator.wikimedia.org/T199834) (owner: 10Accraze) [22:27:44] (03CR) 10Nray: Resemble AMC mode for all users on user pages & user talk pages (032 comments) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556223 (https://phabricator.wikimedia.org/T232653) (owner: 10Nray) [22:28:18] (03Merged) 10jenkins-bot: Implement Api modules [extensions/Jade] - 10https://gerrit.wikimedia.org/r/536659 (https://phabricator.wikimedia.org/T199834) (owner: 10Accraze) [22:36:40] (03CR) 10Jdlrobson: [C: 03+2] Resemble AMC mode for all users on user pages & user talk pages [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556223 (https://phabricator.wikimedia.org/T232653) (owner: 10Nray) [22:44:34] (03PS1) 10N3rsti: n3rsti.txt: created file with text [sandbox] - 10https://gerrit.wikimedia.org/r/557142 [22:44:36] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [sandbox] - 10https://gerrit.wikimedia.org/r/557142 (owner: 10N3rsti) [22:48:32] (03Merged) 10jenkins-bot: Resemble AMC mode for all users on user pages & user talk pages [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556223 (https://phabricator.wikimedia.org/T232653) (owner: 10Nray) [22:50:31] (03PS1) 10DLynch: ReplyWidget: calling undefined clear method [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/557143 (https://phabricator.wikimedia.org/T240729) [22:52:23] (03CR) 10Esanders: [C: 03+2] ReplyWidget: calling undefined clear method [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/557143 (https://phabricator.wikimedia.org/T240729) (owner: 10DLynch) [22:52:30] (03CR) 10Pmiazga: [C: 03+2] Resemble AMC mode for all users on user pages & user talk pages (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556223 (https://phabricator.wikimedia.org/T232653) (owner: 10Nray) [22:57:56] (03CR) 10Nray: Resemble AMC mode for all users on user pages & user talk pages (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/556223 (https://phabricator.wikimedia.org/T232653) (owner: 10Nray) [22:59:14] (03Merged) 10jenkins-bot: ReplyWidget: calling undefined clear method [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/557143 (https://phabricator.wikimedia.org/T240729) (owner: 10DLynch) [23:06:33] (03PS1) 10Octfx: Fix search action url in schema.org [extensions/WikiSEO] - 10https://gerrit.wikimedia.org/r/557145 [23:08:12] (03PS1) 10Octfx: Bump bugfix version [extensions/WikiSEO] - 10https://gerrit.wikimedia.org/r/557146 [23:08:32] (03CR) 10Octfx: [C: 03+2] Bump bugfix version [extensions/WikiSEO] - 10https://gerrit.wikimedia.org/r/557146 (owner: 10Octfx) [23:09:40] (03PS16) 10Esanders: Option to integrate VisualEditor instead of textarea [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/552146 (owner: 10Bartosz Dziewoński) [23:12:28] (03CR) 10Octfx: [C: 03+2] Fix search action url in schema.org [extensions/WikiSEO] - 10https://gerrit.wikimedia.org/r/557145 (owner: 10Octfx) [23:24:39] (03PS1) 10Mholloway: Fix: Bail out of label fetching job if local file not found [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/557147 (https://phabricator.wikimedia.org/T240733) [23:25:47] (03CR) 10jerkins-bot: [V: 04-1] Fix: Bail out of label fetching job if local file not found [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/557147 (https://phabricator.wikimedia.org/T240733) (owner: 10Mholloway) [23:27:50] (03PS2) 10Mholloway: Fix: Bail out of label fetching job if local file not found [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/557147 (https://phabricator.wikimedia.org/T240733) [23:30:03] (03PS17) 10Esanders: Option to integrate VisualEditor instead of textarea [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/552146 (owner: 10Bartosz Dziewoński) [23:36:46] (03PS18) 10DannyS712: [WIP] Add `delete-redirect` right to delete single-rev redirects during page moves [core] - 10https://gerrit.wikimedia.org/r/554365 [23:47:59] (03PS19) 10DannyS712: [WIP] Add `delete-redirect` right to delete single-rev redirects during page moves [core] - 10https://gerrit.wikimedia.org/r/554365 [23:53:30] (03PS20) 10DannyS712: [WIP] Add `delete-redirect` right to delete single-rev redirects during page moves [core] - 10https://gerrit.wikimedia.org/r/554365