[00:03:16] (03PS12) 10AlexPinchuk: [WIP] SnapshotStatistics: phase 2 [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/542448 [00:04:31] 10GrowthExperiments, 10Growth-Team (Current Sprint): Texts in Czech are too long to display well - https://phabricator.wikimedia.org/T236910 (10Catrope) Rita's CSS tweaks: https://codepen.io/reets/pen/eYYEwXr [00:04:36] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Growth-Team (Current Sprint), 10MW-1.35-notes (1.35.0-wmf.5; 2019-11-05): Newcomer tasks: implement difficulty filters - https://phabricator.wikimedia.org/T235042 (10Etonkovidova) [00:07:49] (03CR) 10Jforrester: [C: 03+2] build: Add mediawiki/mediawiki-phan-config [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/540202 (https://phabricator.wikimedia.org/T224770) (owner: 10Umherirrender) [00:07:56] (03CR) 10Catrope: [C: 03+2] build: Update linters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/547053 (owner: 10Esanders) [00:09:05] (03PS13) 10AlexPinchuk: SnapshotStatistics: phase 2 [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/542448 [00:09:24] 10Wikimedia-Site-requests: Change the lzh Wikipedia logo - https://phabricator.wikimedia.org/T236905 (10WAN233) >>! In T236905#5619902, @Aklapper wrote: >> Per the discussion as follows: >> https://zh.wikipedia.org/wiki/維基大典:會館#賀大典萬文 > > @WAN233: That page does not exist. Did you mean https://zh-classical.wikip... [00:10:37] (03PS4) 10Gergő Tisza: Allow injecting a message localizer into Status [core] - 10https://gerrit.wikimedia.org/r/547305 [00:11:20] (03Merged) 10jenkins-bot: build: Add mediawiki/mediawiki-phan-config [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/540202 (https://phabricator.wikimedia.org/T224770) (owner: 10Umherirrender) [00:12:42] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Growth-Team (Current Sprint), 10MW-1.35-notes (1.35.0-wmf.5; 2019-11-05): Newcomer tasks: implement difficulty filters - https://phabricator.wikimedia.org/T235042 (10Etonkovidova) @MMiller_WMF - the following items from the specs were marked with a re... [00:20:51] (03Merged) 10jenkins-bot: build: Update linters [extensions/Flow] - 10https://gerrit.wikimedia.org/r/547053 (owner: 10Esanders) [00:31:10] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Growth-Team (Current Sprint), 10MW-1.35-notes (1.35.0-wmf.5; 2019-11-05): Newcomer tasks: implement difficulty filters - https://phabricator.wikimedia.org/T235042 (10Etonkovidova) Two questions @MMiller_WMF Based on [[ https://docs.google.com/spread... [00:36:58] (03CR) 10MaxSem: Allow injecting a message localizer into Status (032 comments) [core] - 10https://gerrit.wikimedia.org/r/547305 (owner: 10Gergő Tisza) [00:37:24] (03CR) 10Jforrester: Xml: Simplify isWellFormedXmlFragment() and add tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/547069 (owner: 10MaxSem) [00:37:43] (03CR) 10Jforrester: [C: 03+2] Shell: Declare constants visibility [core] - 10https://gerrit.wikimedia.org/r/546786 (owner: 10MaxSem) [00:38:18] 10Wikimedia-Site-requests: Change the lzh Wikipedia logo - https://phabricator.wikimedia.org/T236905 (10Ammarpad) a:03Ammarpad [00:38:28] (03CR) 10Jforrester: Shell\Result: declare types, enable strict types (032 comments) [core] - 10https://gerrit.wikimedia.org/r/546787 (owner: 10MaxSem) [00:40:16] 10Who-Wrote-That, 10Community-Tech (Kanban-Q2-2019-20): WWT: Implement Opacity for Templates [medium] - https://phabricator.wikimedia.org/T235130 (10MusikAnimal) PR ready for review: https://github.com/wikimedia/WhoWroteThat/pull/83 [00:41:51] (03CR) 10Catrope: [C: 03+2] Allow injecting a message localizer into Status [core] - 10https://gerrit.wikimedia.org/r/547305 (owner: 10Gergő Tisza) [00:42:14] 10Release, 10Train Deployments: 1.35.0-wmf.4 deployment blockers - https://phabricator.wikimedia.org/T233852 (10Jdforrester-WMF) [00:42:18] (03PS2) 10MaxSem: Xml: Simplify isWellFormedXmlFragment() and add tests [core] - 10https://gerrit.wikimedia.org/r/547069 [00:42:20] (03PS2) 10MaxSem: Remove PhpXmlBugTester [core] - 10https://gerrit.wikimedia.org/r/547070 [00:42:44] (03CR) 10MaxSem: Xml: Simplify isWellFormedXmlFragment() and add tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/547069 (owner: 10MaxSem) [00:43:00] (03CR) 10Jforrester: [C: 03+1] "Is there any chance anyone is relying on it having a doctype?" [core] - 10https://gerrit.wikimedia.org/r/547069 (owner: 10MaxSem) [00:44:44] (03PS3) 10Jforrester: Remove PhpXmlBugTester [core] - 10https://gerrit.wikimedia.org/r/547070 (owner: 10MaxSem) [00:44:59] (03CR) 10MaxSem: "That's why I'm adding tests." [core] - 10https://gerrit.wikimedia.org/r/547069 (owner: 10MaxSem) [00:46:35] (03CR) 10Jforrester: [C: 03+1] "I'm also OK with this intent and outcome." [core] - 10https://gerrit.wikimedia.org/r/546914 (https://phabricator.wikimedia.org/T236778) (owner: 10Daniel Kinzler) [00:50:11] (03CR) 10Jforrester: [C: 03+2] "…" [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/547326 (https://phabricator.wikimedia.org/T30798) (owner: 10Jforrester) [00:50:32] (03Merged) 10jenkins-bot: Shell: Declare constants visibility [core] - 10https://gerrit.wikimedia.org/r/546786 (owner: 10MaxSem) [00:50:51] 10Editing Design, 10Patch-For-Review, 10VisualEditor (Current work): Mobile VE toolbar doesn't stay onscreen on iOS 13 when keyboard is open - https://phabricator.wikimedia.org/T233470 (10matmarex) I feel that making it work as desired with the selection handles will be difficult, so before we try diving int... [00:54:18] (03Merged) 10jenkins-bot: Allow injecting a message localizer into Status [core] - 10https://gerrit.wikimedia.org/r/547305 (owner: 10Gergő Tisza) [00:57:27] (03CR) 10Jforrester: [C: 03+2] Remove PhpXmlBugTester [core] - 10https://gerrit.wikimedia.org/r/547070 (owner: 10MaxSem) [00:57:54] (03Merged) 10jenkins-bot: Disable $wgServer autodetection to prevent cache poisoning attacks [core] (REL1_34) - 10https://gerrit.wikimedia.org/r/547326 (https://phabricator.wikimedia.org/T30798) (owner: 10Jforrester) [00:58:50] (03PS3) 10Jforrester: Shell\Result: declare types, enable strict types [core] - 10https://gerrit.wikimedia.org/r/546787 (owner: 10MaxSem) [01:05:02] (03CR) 10Jforrester: [C: 03+2] Shell\Result: declare types, enable strict types [core] - 10https://gerrit.wikimedia.org/r/546787 (owner: 10MaxSem) [01:08:14] (03Merged) 10jenkins-bot: Remove PhpXmlBugTester [core] - 10https://gerrit.wikimedia.org/r/547070 (owner: 10MaxSem) [01:08:29] (03Abandoned) 10Jforrester: IndexPage: Silently bail on the query if it's asking for too many rows in miser mode [core] - 10https://gerrit.wikimedia.org/r/540687 (owner: 10Jforrester) [01:15:54] (03Merged) 10jenkins-bot: Shell\Result: declare types, enable strict types [core] - 10https://gerrit.wikimedia.org/r/546787 (owner: 10MaxSem) [01:16:39] (03PS3) 10Jforrester: Shell: Add more types [core] - 10https://gerrit.wikimedia.org/r/546788 (owner: 10MaxSem) [01:17:05] (03CR) 10Jforrester: [C: 03+2] Shell: Add more types [core] - 10https://gerrit.wikimedia.org/r/546788 (owner: 10MaxSem) [01:22:14] 10GrowthExperiments-Homepage, 10GrowthExperiments-NewcomerTasks, 10Growth-Team (Current Sprint): Newcomer tasks: hidden preference - https://phabricator.wikimedia.org/T236968 (10Masumrezarock100) How much hidden are we talking about here? Can those preferences at least be enabled using API? [01:30:00] (03Merged) 10jenkins-bot: Shell: Add more types [core] - 10https://gerrit.wikimedia.org/r/546788 (owner: 10MaxSem) [01:36:24] 10MediaWiki-extensions-Translate, 10good first bug: Make page name as title when removing page from translation - https://phabricator.wikimedia.org/T236935 (10Ammarpad) a:03Ammarpad [02:27:31] (03CR) 10Bartosz Dziewoński: [C: 03+2] Replace deprecated easy-deflate.deflate with mediawiki.deflate [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/547282 (owner: 10Esanders) [02:37:03] 10CPT Initiatives (Core REST API in PHP), 10Core Platform Team Workboards (Green): Investigate Monitoring Kask Availability via Integration Tests - https://phabricator.wikimedia.org/T235567 (10WDoranWMF) [02:40:32] (03Merged) 10jenkins-bot: Replace deprecated easy-deflate.deflate with mediawiki.deflate [extensions/ContentTranslation] - 10https://gerrit.wikimedia.org/r/547282 (owner: 10Esanders) [02:45:06] (03CR) 10Bartosz Dziewoński: [C: 03+2] eslint: Inline or remove rule exceptions [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/547194 (owner: 10Esanders) [02:45:10] (03CR) 10Bartosz Dziewoński: [C: 03+2] Replace hex2dec with parseInt(.., 16) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/547193 (owner: 10Esanders) [02:45:13] (03CR) 10Bartosz Dziewoński: [C: 03+2] build: Update linters [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/547189 (owner: 10Esanders) [02:58:42] (03Merged) 10jenkins-bot: build: Update linters [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/547189 (owner: 10Esanders) [02:58:44] (03Merged) 10jenkins-bot: Replace hex2dec with parseInt(.., 16) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/547193 (owner: 10Esanders) [02:58:46] (03Merged) 10jenkins-bot: eslint: Inline or remove rule exceptions [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/547194 (owner: 10Esanders) [03:25:18] 10MediaWiki-Cache, 10MediaWiki-Parser, 10Core Platform Team Workboards (Clinic Duty Team): Invalid magic word error on updating to MediaWiki 1.33.1 - https://phabricator.wikimedia.org/T235512 (10charitwo) I would say core code breaking a wiki is a large priority, especially if you skip throwing the exception... [03:29:54] (03PS4) 10Dmaza: Remove blocker dependency for System and Composite blocks [core] - 10https://gerrit.wikimedia.org/r/540940 (https://phabricator.wikimedia.org/T227892) [03:32:17] (03CR) 10Dmaza: Remove blocker dependency for System and Composite blocks (038 comments) [core] - 10https://gerrit.wikimedia.org/r/540940 (https://phabricator.wikimedia.org/T227892) (owner: 10Dmaza) [03:35:10] (03CR) 10MaxSem: [C: 03+1] "I would actually argue that the trait should be kept for a while, in case more third party extensions need updates. Just remove it from th" [core] - 10https://gerrit.wikimedia.org/r/546456 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [03:40:25] (03CR) 10jerkins-bot: [V: 04-1] Remove blocker dependency for System and Composite blocks [core] - 10https://gerrit.wikimedia.org/r/540940 (https://phabricator.wikimedia.org/T227892) (owner: 10Dmaza) [03:42:18] (03CR) 10Dmaza: [C: 03+1] Allow block message drawer to handle different block creators [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/546991 (https://phabricator.wikimedia.org/T236814) (owner: 10Tchanders) [03:46:52] (03PS8) 10MaxSem: GlobalFunctions: Start using parameters and return types [core] - 10https://gerrit.wikimedia.org/r/546782 [03:51:59] (03PS5) 10Dmaza: Remove blocker dependency for System and Composite blocks [core] - 10https://gerrit.wikimedia.org/r/540940 (https://phabricator.wikimedia.org/T227892) [03:54:21] (03PS9) 10SBassett: PHP-Security-Tools [wikimedia/security/tooling] - 10https://gerrit.wikimedia.org/r/539205 (https://phabricator.wikimedia.org/T221477) [03:55:54] 10MediaWiki-Vagrant: Vagrant eventbus role can't be installed because of node_version - https://phabricator.wikimedia.org/T236975 (10DLynch) [03:57:39] 10MediaWiki-Vagrant: Vagrant eventbus role can't be installed because of node_version - https://phabricator.wikimedia.org/T236975 (10DLynch) This is probably a regression of T218238, which indicated that it was going to be making eventgate optional for cases which don't strictly require it. [04:05:27] (03CR) 10jerkins-bot: [V: 04-1] Remove blocker dependency for System and Composite blocks [core] - 10https://gerrit.wikimedia.org/r/540940 (https://phabricator.wikimedia.org/T227892) (owner: 10Dmaza) [04:35:34] 04(no projects): Benevity import taking a long time with large files - https://phabricator.wikimedia.org/T236977 (10RLewis) [04:45:23] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2019-October-December), 10MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), 10Unplanned-Sprint-Work, 10User-DannyS712: PageTranslation: `tpt-duplicate` message should have an error class - https://phabricator.wikimedia.org/T236005 (10DannyS712) 05Open... [04:49:41] (03CR) 10Santhosh: Developer productivity improvements, docker support (034 comments) [services/cxserver] - 10https://gerrit.wikimedia.org/r/543029 (owner: 10Santhosh) [05:00:45] (03PS1) 10MaxSem: auth: Set constant visibility [core] - 10https://gerrit.wikimedia.org/r/547375 [05:01:08] (03Abandoned) 10MaxSem: Set constant visibility, part 2 [core] - 10https://gerrit.wikimedia.org/r/543249 (owner: 10MaxSem) [05:12:54] 10WMSE-Magnus Sälgö: POC WikiTree categories: Connect Swedish Church Parishes in Wikidata to categories in a wiki at a community of genealogists called WikiTree - https://phabricator.wikimedia.org/T236340 (10Salgo60) [05:18:10] 10MediaWiki Language Extension Bundle, 10Language-Team (Language-2019-October-December): Test MLEB 2019.10 - https://phabricator.wikimedia.org/T236978 (10KartikMistry) [05:19:13] 10CX-deployments, 10Language-Team (Language-2019-October-December): Update apertium-apy - https://phabricator.wikimedia.org/T236080 (10KartikMistry) p:05Triage→03Low [05:19:32] 10CX-deployments, 10Language-Team (Language-2019-October-December): Package apertium-anaphora, apertium-recursive and apertium-all-dev - https://phabricator.wikimedia.org/T234181 (10KartikMistry) p:05Triage→03Low [05:19:49] 10CX-deployments, 10Language-Team (Language-2019-October-December): Update to new cg3, lttoolbox, apertium, apertium-lex-tools and apertium-separable packages - https://phabricator.wikimedia.org/T234182 (10KartikMistry) p:05Triage→03Normal [05:20:13] 10CX-deployments, 10Language-Team (Language-2019-October-December): Update hfst to 3.15.1 - https://phabricator.wikimedia.org/T233697 (10KartikMistry) p:05Triage→03Normal [05:20:31] 10CX-deployments, 10Language-Team (Language-2019-October-December): Package apertium-anaphora, apertium-recursive and apertium-all-dev - https://phabricator.wikimedia.org/T234181 (10KartikMistry) [05:20:50] 10CX-deployments, 10Language-Team (Language-2019-October-December): Update to new cg3, lttoolbox, apertium, apertium-lex-tools and apertium-separable packages - https://phabricator.wikimedia.org/T234182 (10KartikMistry) [05:21:09] 10CX-deployments, 10Language-Team (Language-2019-October-December): Update apertium-apy - https://phabricator.wikimedia.org/T236080 (10KartikMistry) [05:31:54] 10MediaWiki-DjVu, 10Commons, 10Multimedia, 10ProofreadPage, 10Wikisource: Proofread Page extension on Wikisource is displaying wrong pages; purge on Commons file fails - https://phabricator.wikimedia.org/T215558 (10Ankry) >>! In T215558#5621892, @Hsarrazin wrote: > On frwikisource, we repaired dozens of... [05:41:14] 10CPT Initiatives (Session Management Service (CDP2)), 10Core Platform Team Workboards (Green): Document and communicate potentially breaking session storage serialization change - https://phabricator.wikimedia.org/T233537 (10WDoranWMF) @BPirkle @daniel @Anomie and I discussed the approach to transitioning fro... [05:46:02] 10Community-Tech (Kanban-Q2-2019-20), 10E-Book-Export-Reliability: Investigate uptime of WS Export - https://phabricator.wikimedia.org/T236391 (10Samwilson) I wonder if uptimerobot is actually responsible for more visits to the wsexport homepage than anyone else — most users probably come via direct export lin... [05:47:10] 10Dumps-Generation: index.html page for adds/changes dumps is out of date - https://phabricator.wikimedia.org/T236875 (10ArielGlenn) Odds are this is the naughty change: https://gerrit.wikimedia.org/r/#/c/operations/dumps/+/505623/ Investigating. [06:32:08] 10MediaWiki-Containers, 10Wikibase-Containers, 10Wikidata: Sendmail not working. mail() function required in wikibase docker image - https://phabricator.wikimedia.org/T206517 (10Addshore) In https://www.mediawiki.org/wiki/Manual:$wgSMTP#Details I see > This setting requires PEAR's Mail package to be ins... [06:32:15] 10MediaWiki-Containers, 10Wikibase-Containers, 10Wikidata: Sendmail not working. mail() function required in wikibase docker image - https://phabricator.wikimedia.org/T206517 (10Addshore) p:05Triage→03Low [06:44:14] 10Dumps-Generation, 10Patch-For-Review: index.html page for adds/changes dumps is out of date - https://phabricator.wikimedia.org/T236875 (10ArielGlenn) Now that these run again (patch tested manually), the links generated are wrong. There's a path used that is not relative to the incrementals directory so tha... [06:59:09] 10WMSE-Magnus Sälgö: POC WikiTree categories: Connect Swedish Church Parishes in Wikidata to categories in a wiki at a community of genealogists called WikiTree - https://phabricator.wikimedia.org/T236340 (10Salgo60) - [[ https://w.wiki/B74 | Graves Categories list ]] {F30936760} - Wikidata also contains coo... [07:02:10] (03PS2) 10MaxSem: Make deprecated methods fail in unit tests. [core] - 10https://gerrit.wikimedia.org/r/546914 (https://phabricator.wikimedia.org/T236778) (owner: 10Daniel Kinzler) [07:03:44] (03CR) 10MaxSem: [C: 03+2] "We already fail integration tests for the same reason, I don't see why shouldn't we do the same for unit." [core] - 10https://gerrit.wikimedia.org/r/546914 (https://phabricator.wikimedia.org/T236778) (owner: 10Daniel Kinzler) [07:05:51] 10MediaWiki-General, 10UniversalLanguageSelector, 10Performance-Team (Radar), 10Readers-Web-Backlog (Tracking): ext.uls.interlanguage should set targets to mobile and desktop but not ship on Minerva - https://phabricator.wikimedia.org/T236943 (10Nikerabbit) Thanks. I was asking about skins because we don't... [07:16:27] (03Merged) 10jenkins-bot: Make deprecated methods fail in unit tests. [core] - 10https://gerrit.wikimedia.org/r/546914 (https://phabricator.wikimedia.org/T236778) (owner: 10Daniel Kinzler) [07:21:02] 10Dumps-Generation, 10Patch-For-Review: index.html page for adds/changes dumps is out of date and the paths are wrong in the links too - https://phabricator.wikimedia.org/T236875 (10ArielGlenn) [07:25:29] (03CR) 10Robert Vogel: [C: 03+2] Fix custom menu header not getting overwritten consistently. [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/547258 (owner: 10Pwirth) [07:25:35] (03PS1) 10Robert Vogel: Fix custom menu header not getting overwritten consistently. [skins/BlueSpiceCalumma] (REL1_31) - 10https://gerrit.wikimedia.org/r/547380 [07:25:40] (03CR) 10Robert Vogel: [C: 03+2] Fix custom menu header not getting overwritten consistently. [skins/BlueSpiceCalumma] (REL1_31) - 10https://gerrit.wikimedia.org/r/547380 (owner: 10Robert Vogel) [07:25:43] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2019-October-December): PHP Fatal error: Can't inherit abstract function on marking page for translation in PHP 7.1.33 - https://phabricator.wikimedia.org/T236956 (10abi_) 05Open→03Resolved I've tested this patch locally on a vagrant box with PHP... [07:25:45] (03PS1) 10Robert Vogel: Fix custom menu header not getting overwritten consistently. [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547381 [07:25:47] (03CR) 10Robert Vogel: [C: 03+2] Fix custom menu header not getting overwritten consistently. [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547381 (owner: 10Robert Vogel) [07:26:00] 10MediaWiki-extensions-Nuke, 10Commons, 10Multimedia, 10SRE-swift-storage: Double-deletion on Commons - https://phabricator.wikimedia.org/T173825 (10kolbert) Triple deletion here : https://commons.wikimedia.org/w/index.php?title=File:Catie_trophy.jpg&action=edit&redlink=1 [07:26:17] (03PS2) 10Robert Vogel: Only list pages wikitext or legacy content model. ERM:14681 [extensions/BlueSpiceWatchList] - 10https://gerrit.wikimedia.org/r/547255 (owner: 10Pwirth) [07:26:40] (03CR) 10Robert Vogel: [C: 03+2] Only list pages wikitext or legacy content model. ERM:14681 [extensions/BlueSpiceWatchList] - 10https://gerrit.wikimedia.org/r/547255 (owner: 10Pwirth) [07:26:48] (03PS1) 10Robert Vogel: Only list pages wikitext or legacy content model. ERM:14681 [extensions/BlueSpiceWatchList] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547382 [07:26:50] (03CR) 10Robert Vogel: [C: 03+2] Only list pages wikitext or legacy content model. ERM:14681 [extensions/BlueSpiceWatchList] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547382 (owner: 10Robert Vogel) [07:26:57] (03PS1) 10Robert Vogel: Only list pages wikitext or legacy content model. ERM:14681 [extensions/BlueSpiceWatchList] (REL1_31) - 10https://gerrit.wikimedia.org/r/547383 [07:27:00] (03CR) 10Robert Vogel: [C: 03+2] Only list pages wikitext or legacy content model. ERM:14681 [extensions/BlueSpiceWatchList] (REL1_31) - 10https://gerrit.wikimedia.org/r/547383 (owner: 10Robert Vogel) [07:27:38] (03CR) 10Robert Vogel: [C: 03+2] Fix call to undefined function when no target given in whatlinkshere mode [extensions/BlueSpiceSmartList] - 10https://gerrit.wikimedia.org/r/547234 (owner: 10Pwirth) [07:27:47] (03PS1) 10Robert Vogel: Fix call to undefined function when no target given in whatlinkshere mode [extensions/BlueSpiceSmartList] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547384 [07:27:49] (03CR) 10Robert Vogel: [C: 03+2] Fix call to undefined function when no target given in whatlinkshere mode [extensions/BlueSpiceSmartList] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547384 (owner: 10Robert Vogel) [07:27:55] (03PS1) 10Robert Vogel: Fix call to undefined function when no target given in whatlinkshere mode [extensions/BlueSpiceSmartList] (REL1_31) - 10https://gerrit.wikimedia.org/r/547385 [07:27:58] (03CR) 10Robert Vogel: [C: 03+2] Fix call to undefined function when no target given in whatlinkshere mode [extensions/BlueSpiceSmartList] (REL1_31) - 10https://gerrit.wikimedia.org/r/547385 (owner: 10Robert Vogel) [07:28:39] (03Merged) 10jenkins-bot: Fix custom menu header not getting overwritten consistently. [skins/BlueSpiceCalumma] (REL1_31) - 10https://gerrit.wikimedia.org/r/547380 (owner: 10Robert Vogel) [07:28:41] (03CR) 10jerkins-bot: [V: 04-1] Fix custom menu header not getting overwritten consistently. [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547381 (owner: 10Robert Vogel) [07:28:43] (03CR) 10jerkins-bot: [V: 04-1] Only list pages wikitext or legacy content model. ERM:14681 [extensions/BlueSpiceWatchList] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547382 (owner: 10Robert Vogel) [07:29:10] (03CR) 10Robert Vogel: [C: 03+2] Only list pages wikitext or legacy content model. ERM:14681 [extensions/BlueSpiceSmartList] - 10https://gerrit.wikimedia.org/r/547232 (owner: 10Pwirth) [07:29:16] (03Merged) 10jenkins-bot: Fix custom menu header not getting overwritten consistently. [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/547258 (owner: 10Pwirth) [07:29:21] (03PS1) 10Robert Vogel: Only list pages wikitext or legacy content model. ERM:14681 [extensions/BlueSpiceSmartList] (REL1_31) - 10https://gerrit.wikimedia.org/r/547386 [07:29:23] (03CR) 10Robert Vogel: [C: 03+2] Only list pages wikitext or legacy content model. ERM:14681 [extensions/BlueSpiceSmartList] (REL1_31) - 10https://gerrit.wikimedia.org/r/547386 (owner: 10Robert Vogel) [07:29:26] (03PS1) 10Robert Vogel: Only list pages wikitext or legacy content model. ERM:14681 [extensions/BlueSpiceSmartList] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547387 [07:29:29] (03CR) 10Robert Vogel: [C: 03+2] Only list pages wikitext or legacy content model. ERM:14681 [extensions/BlueSpiceSmartList] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547387 (owner: 10Robert Vogel) [07:30:21] (03Merged) 10jenkins-bot: Only list pages wikitext or legacy content model. ERM:14681 [extensions/BlueSpiceWatchList] - 10https://gerrit.wikimedia.org/r/547255 (owner: 10Pwirth) [07:30:23] (03Merged) 10jenkins-bot: Fix call to undefined function when no target given in whatlinkshere mode [extensions/BlueSpiceSmartList] - 10https://gerrit.wikimedia.org/r/547234 (owner: 10Pwirth) [07:30:28] (03Merged) 10jenkins-bot: Only list pages wikitext or legacy content model. ERM:14681 [extensions/BlueSpiceWatchList] (REL1_31) - 10https://gerrit.wikimedia.org/r/547383 (owner: 10Robert Vogel) [07:30:30] (03Merged) 10jenkins-bot: Fix call to undefined function when no target given in whatlinkshere mode [extensions/BlueSpiceSmartList] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547384 (owner: 10Robert Vogel) [07:30:32] (03Merged) 10jenkins-bot: Only list pages wikitext or legacy content model. ERM:14681 [extensions/BlueSpiceSmartList] - 10https://gerrit.wikimedia.org/r/547232 (owner: 10Pwirth) [07:30:41] (03CR) 10jerkins-bot: [V: 04-1] Fix call to undefined function when no target given in whatlinkshere mode [extensions/BlueSpiceSmartList] (REL1_31) - 10https://gerrit.wikimedia.org/r/547385 (owner: 10Robert Vogel) [07:30:48] (03Merged) 10jenkins-bot: Only list pages wikitext or legacy content model. ERM:14681 [extensions/BlueSpiceSmartList] (REL1_31) - 10https://gerrit.wikimedia.org/r/547386 (owner: 10Robert Vogel) [07:30:51] (03Merged) 10jenkins-bot: Only list pages wikitext or legacy content model. ERM:14681 [extensions/BlueSpiceSmartList] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547387 (owner: 10Robert Vogel) [07:30:53] (03CR) 10Robert Vogel: [C: 04-2] "This will need a change in https://github.com/hallowelt/mediawiki/blob/REL1_31/settings.d/001-BlueSpiceDistribution.php#L20" [extensions/BlueSpiceDistributionConnector] - 10https://gerrit.wikimedia.org/r/545252 (owner: 10Pwirth) [07:31:09] (03CR) 10Robert Vogel: [C: 03+2] Add gruntfile, package, license. Fix messages and activate tests. ERM:16866 [extensions/BlueSpiceReminder] - 10https://gerrit.wikimedia.org/r/544187 (owner: 10Pwirth) [07:31:40] (03PS1) 10Robert Vogel: Add gruntfile, package, license. Fix messages and activate tests. ERM:16866 [extensions/BlueSpiceReminder] (REL1_31) - 10https://gerrit.wikimedia.org/r/547388 [07:31:43] (03CR) 10Robert Vogel: [C: 03+2] Add gruntfile, package, license. Fix messages and activate tests. ERM:16866 [extensions/BlueSpiceReminder] (REL1_31) - 10https://gerrit.wikimedia.org/r/547388 (owner: 10Robert Vogel) [07:31:50] (03PS1) 10Robert Vogel: Add gruntfile, package, license. Fix messages and activate tests. ERM:16866 [extensions/BlueSpiceReminder] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547389 [07:31:52] (03CR) 10Robert Vogel: [C: 03+2] Add gruntfile, package, license. Fix messages and activate tests. ERM:16866 [extensions/BlueSpiceReminder] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547389 (owner: 10Robert Vogel) [07:32:26] (03CR) 10Robert Vogel: "recheck" [extensions/BlueSpiceExpiry] - 10https://gerrit.wikimedia.org/r/544634 (owner: 10Pwirth) [07:34:21] (03Merged) 10jenkins-bot: Add gruntfile, package, license. Fix messages and activate tests. ERM:16866 [extensions/BlueSpiceReminder] (REL1_31) - 10https://gerrit.wikimedia.org/r/547388 (owner: 10Robert Vogel) [07:34:23] (03CR) 10jerkins-bot: [V: 04-1] Add gruntfile, package, license. Fix messages and activate tests. ERM:16866 [extensions/BlueSpiceReminder] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547389 (owner: 10Robert Vogel) [07:34:28] (03Merged) 10jenkins-bot: Add gruntfile, package, license. Fix messages and activate tests. ERM:16866 [extensions/BlueSpiceReminder] - 10https://gerrit.wikimedia.org/r/544187 (owner: 10Pwirth) [07:35:48] (03PS4) 10Pwirth: Add package, gruntfile, CODE_OF_CONDUCT Fix messages and activate tests [extensions/BlueSpiceUEModuleTable2Excel] - 10https://gerrit.wikimedia.org/r/546927 [07:36:34] (03CR) 10Pwirth: "> Oh, I forgot to I can't edit patch set.. Can you create sr-ec.json" [extensions/BlueSpiceUEModuleTable2Excel] - 10https://gerrit.wikimedia.org/r/546927 (owner: 10Pwirth) [07:37:27] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/547390 (owner: 10L10n-bot) [07:38:09] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceExportTables] - 10https://gerrit.wikimedia.org/r/546935 (owner: 10Pwirth) [07:39:11] 10MediaWiki-extensions-Translate: Page allowed for translation to priority language, without reason, only shows "Reason:" when translation - https://phabricator.wikimedia.org/T236980 (10abi_) [07:39:34] 10MediaWiki-extensions-Translate: Page allowed for translation to priority language, without reason, only shows "Reason:" when translation - https://phabricator.wikimedia.org/T236980 (10abi_) p:05Triage→03Lowest [07:39:58] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/545543 (owner: 10Pwirth) [07:40:05] 10MediaWiki-extensions-Translate: Page allowed for translation to priority language, without reason, only shows "Reason:" when translating - https://phabricator.wikimedia.org/T236980 (10abi_) [07:43:03] (03CR) 10Pwirth: [V: 03+2] Only list pages wikitext or legacy content model. ERM:14681 [extensions/BlueSpiceWatchList] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547382 (owner: 10Robert Vogel) [07:43:06] 10MediaWiki Language Extension Bundle, 10Language-Team (Language-2019-October-December): Test MLEB 2019.10 - https://phabricator.wikimedia.org/T236978 (10abi_) 05Open→03Resolved I've tested the latest Translate / ULS extensions with, 1. PHP 7.3 + Mediawiki master (Tested on https://language-translate.wmfl... [07:43:09] 10MediaWiki Language Extension Bundle, 10Language-Team (Language-2019-October-December): Release MLEB 2019.10 - https://phabricator.wikimedia.org/T236167 (10abi_) [07:43:10] (03CR) 10Pwirth: [V: 03+2] Fix custom menu header not getting overwritten consistently. [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547381 (owner: 10Robert Vogel) [07:43:18] (03CR) 10Pwirth: [V: 03+2] Add gruntfile, package, license. Fix messages and activate tests. ERM:16866 [extensions/BlueSpiceReminder] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547389 (owner: 10Robert Vogel) [07:43:47] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceSmartList] (REL1_31) - 10https://gerrit.wikimedia.org/r/547385 (owner: 10Robert Vogel) [07:44:18] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/542448 (owner: 10AlexPinchuk) [07:44:56] 10MediaWiki Language Extension Bundle, 10Language-Team (Language-2019-October-December): Release MLEB 2019.10 - https://phabricator.wikimedia.org/T236167 (10abi_) [07:47:25] 10MediaWiki Language Extension Bundle: Decide minimum supported PHP version for next MLEB release - https://phabricator.wikimedia.org/T235249 (10abi_) 05Open→03Resolved a:03abi_ As per discussion with Niklas, we've decided to keep the minimum PHP version for the current MLEB release as 7.1 and planning to... [07:47:27] 10MediaWiki Language Extension Bundle, 10Language-Team (Language-2019-October-December): Release MLEB 2019.10 - https://phabricator.wikimedia.org/T236167 (10abi_) [07:47:34] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceExpiry] - 10https://gerrit.wikimedia.org/r/544634 (owner: 10Pwirth) [07:48:15] (03CR) 10Pwirth: [C: 03+2] "re-poke" [extensions/BlueSpiceSmartList] (REL1_31) - 10https://gerrit.wikimedia.org/r/547385 (owner: 10Robert Vogel) [07:48:38] (03Merged) 10jenkins-bot: Fix call to undefined function when no target given in whatlinkshere mode [extensions/BlueSpiceSmartList] (REL1_31) - 10https://gerrit.wikimedia.org/r/547385 (owner: 10Robert Vogel) [07:49:51] 10MediaWiki Language Extension Bundle, 10Language-Team (Language-2019-October-December): Release MLEB 2019.10 - https://phabricator.wikimedia.org/T236167 (10abi_) [07:49:52] 10MediaWiki-extensions-Translate, 10MediaWiki Language Extension Bundle, 10Language-Team (Language-2019-October-December), 10MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), 10Technical-Debt: Replace usage of deprecated Title::isValidMoveOperation in SpecialPageTranslat... - https://phabricator.wikimedia.org/T230327 [07:56:12] 10MediaWiki-extensions-Translate, 10MediaWiki Language Extension Bundle, 10Language-Team (Language-2019-October-December): PHP Fatal error: Can't inherit abstract function on marking page for translation in PHP 7.1.33 - https://phabricator.wikimedia.org/T236956 (10Nikerabbit) [07:57:09] (03PS1) 10KartikMistry: Update version before MLEB release [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/547399 [07:58:27] (03PS1) 10KartikMistry: Update version before MLEB release [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/547401 [07:59:40] 10MediaWiki-extensions-Translate, 10MediaWiki Language Extension Bundle, 10Language-Team (Language-2019-October-December): PHP Fatal error: Can't inherit abstract function on marking page for translation in PHP 7.1.33 - https://phabricator.wikimedia.org/T236956 (10abi_) [07:59:42] 10MediaWiki Language Extension Bundle, 10Language-Team (Language-2019-October-December), 10Patch-For-Review: Release MLEB 2019.10 - https://phabricator.wikimedia.org/T236167 (10abi_) [08:03:35] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive" [core] - 10https://gerrit.wikimedia.org/r/547390 (owner: 10L10n-bot) [08:05:13] (03PS1) 10Pwirth: Fix waring due to unnecessary use statements. [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/547402 [08:12:06] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Community-consensus-needed, 10good first bug, 10patch-welcome: Add monolingual language code "sa-Sidd" and "pi-Sidd" - https://phabricator.wikimedia.org/T230881 (10jhsoby) I think it makes sense, but would like to hear what @Amire80 says as well. :-) [08:13:26] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Community-consensus-needed, 10good first bug, 10patch-welcome: Add monolingual language code "sa-Sidd" and "pi-Sidd" - https://phabricator.wikimedia.org/T230881 (10Amire80) Fine with me. [08:13:31] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Add monolingual language code "tok" (Toki Pona) - https://phabricator.wikimedia.org/T236938 (10jhsoby) 05Open→03Declined As long as it's not an official ISO 639-3 code, this will be declined. Feel free to re-open if the application to the SIL is succes... [08:13:34] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Tracking-Neverending: new monolingual language code requests for Wikidata (tracking) - https://phabricator.wikimedia.org/T144272 (10jhsoby) [08:14:20] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10good first bug, 10patch-welcome: Add monolingual language code "sa-Sidd" and "pi-Sidd" - https://phabricator.wikimedia.org/T230881 (10jhsoby) [08:15:22] 10MediaWiki-extensions-Translate, 10MediaWiki Language Extension Bundle, 10Language-Team (Language-2019-October-December), 10MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), 10Technical-Debt: Replace usage of deprecated Title::isValidMoveOperation in SpecialPageTranslat... - https://phabricator.wikimedia.org/T230327 [08:15:24] 10MediaWiki Language Extension Bundle, 10Language-Team (Language-2019-October-December): Release MLEB 2019.10 - https://phabricator.wikimedia.org/T236167 (10abi_) [08:16:03] (03CR) 10KartikMistry: [C: 03+2] Update version before MLEB release [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/547401 (owner: 10KartikMistry) [08:17:31] 10MediaWiki-extensions-LiquidThreads, 10affects-translatewiki.net: Exception doing lazy updates: Exception: synchroniseArticleData called on null article - https://phabricator.wikimedia.org/T236982 (10Nikerabbit) [08:19:06] (03Merged) 10jenkins-bot: Update version before MLEB release [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/547401 (owner: 10KartikMistry) [08:20:07] (03CR) 10KartikMistry: [C: 03+2] Update version before MLEB release [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/547399 (owner: 10KartikMistry) [08:22:32] 10Dumps-Generation, 10Patch-For-Review: index.html page for adds/changes dumps is out of date and the paths are wrong in the links too - https://phabricator.wikimedia.org/T236875 (10ArielGlenn) Fixed that in code and with a manual run. Will merge and deploy, and tomorrow's run should be ok. [08:26:58] (03PS1) 10Mglaser: Fix documentation link [extensions/BlueSpiceChecklist] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547417 [08:28:54] (03PS2) 10Mglaser: Fix documentation link [extensions/BlueSpiceChecklist] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547417 [08:30:29] (03PS1) 10Mglaser: Fix documentation link [extensions/BlueSpiceCustomMenu] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547470 [08:30:49] (03Merged) 10jenkins-bot: Update version before MLEB release [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/547399 (owner: 10KartikMistry) [08:32:06] 10Wikistorm-2019: #Museum voor Wereldculturen: Clean up copyright statuses on their WM Commons collection - https://phabricator.wikimedia.org/T236175 (10MichellevL_WMNL) Opschoning lijkt me goed, er zijn ook erg veel foto’s onder CC geplaatst die PD zijn, én foto’s zonder fotograaf, daar had Hans Muller een oplo... [08:32:09] (03PS1) 10Mglaser: Fix documentation link [extensions/BlueSpicePrivacy] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547472 [08:34:00] (03PS1) 10Mglaser: Fix documentation link [extensions/BlueSpiceWatchList] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547473 [08:40:00] 10MobileFrontend, 10Anti-Harassment (The Letter Song), 10Patch-For-Review, 10Readers-Web-Backlog (Tracking): Improve blocker information on mobile block error message drawer - https://phabricator.wikimedia.org/T236814 (10Niharika) @Tchanders Thanks for the proposed mocks. I have a clarifying question about... [08:41:17] (03CR) 10Mglaser: [C: 03+2] Fix broken url whenever the attachments area gets created from special page. [extensions/BlueSpiceSocialWikiPage] - 10https://gerrit.wikimedia.org/r/546958 (owner: 10Pwirth) [08:41:23] (03PS1) 10Mglaser: Fix broken url whenever the attachments area gets created from special page. [extensions/BlueSpiceSocialWikiPage] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547474 [08:41:28] (03CR) 10Mglaser: [C: 03+2] Fix broken url whenever the attachments area gets created from special page. [extensions/BlueSpiceSocialWikiPage] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547474 (owner: 10Mglaser) [08:41:33] (03PS1) 10Mglaser: Fix broken url whenever the attachments area gets created from special page. [extensions/BlueSpiceSocialWikiPage] (REL1_31) - 10https://gerrit.wikimedia.org/r/547475 [08:41:37] (03CR) 10Mglaser: [C: 03+2] Fix broken url whenever the attachments area gets created from special page. [extensions/BlueSpiceSocialWikiPage] (REL1_31) - 10https://gerrit.wikimedia.org/r/547475 (owner: 10Mglaser) [08:43:05] (03CR) 10jerkins-bot: [V: 04-1] Fix broken url whenever the attachments area gets created from special page. [extensions/BlueSpiceSocialWikiPage] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547474 (owner: 10Mglaser) [08:43:36] (03CR) 10jerkins-bot: [V: 04-1] Fix broken url whenever the attachments area gets created from special page. [extensions/BlueSpiceSocialWikiPage] (REL1_31) - 10https://gerrit.wikimedia.org/r/547475 (owner: 10Mglaser) [08:43:49] (03PS5) 10Thiemo Kreuz (WMDE): Add license information for Extension:Contributors [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/498026 (https://phabricator.wikimedia.org/T123943) (owner: 10Jeropbrendawm) [08:43:54] (03CR) 10Pwirth: [V: 03+2] Fix broken url whenever the attachments area gets created from special page. [extensions/BlueSpiceSocialWikiPage] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547474 (owner: 10Mglaser) [08:44:32] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceSocialWikiPage] (REL1_31) - 10https://gerrit.wikimedia.org/r/547475 (owner: 10Mglaser) [08:45:04] (03CR) 10jerkins-bot: [V: 04-1] Fix broken url whenever the attachments area gets created from special page. [extensions/BlueSpiceSocialWikiPage] (REL1_31) - 10https://gerrit.wikimedia.org/r/547475 (owner: 10Mglaser) [08:45:06] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Add license information for Extension:Contributors [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/498026 (https://phabricator.wikimedia.org/T123943) (owner: 10Jeropbrendawm) [08:46:25] (03Merged) 10jenkins-bot: Fix broken url whenever the attachments area gets created from special page. [extensions/BlueSpiceSocialWikiPage] - 10https://gerrit.wikimedia.org/r/546958 (owner: 10Pwirth) [08:46:39] 10MobileFrontend, 10Anti-Harassment (The Letter Song), 10Patch-For-Review, 10Readers-Web-Backlog (Tracking): Improve blocker information on mobile block error message drawer - https://phabricator.wikimedia.org/T236814 (10Tchanders) @Niharika It can be a username but it's not guaranteed to be. In this examp... [08:48:09] (03Merged) 10jenkins-bot: Add license information for Extension:Contributors [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/498026 (https://phabricator.wikimedia.org/T123943) (owner: 10Jeropbrendawm) [08:48:11] (03CR) 10Robert Vogel: [C: 03+2] Fix waring due to unnecessary use statements. [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/547402 (owner: 10Pwirth) [08:48:16] (03PS1) 10Robert Vogel: Fix waring due to unnecessary use statements. [extensions/BlueSpiceFoundation] (REL1_31) - 10https://gerrit.wikimedia.org/r/547476 [08:48:22] (03CR) 10Robert Vogel: [C: 03+2] Fix waring due to unnecessary use statements. [extensions/BlueSpiceFoundation] (REL1_31) - 10https://gerrit.wikimedia.org/r/547476 (owner: 10Robert Vogel) [08:48:27] (03PS1) 10Robert Vogel: Fix waring due to unnecessary use statements. [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547477 [08:48:30] (03CR) 10Robert Vogel: [C: 03+2] Fix waring due to unnecessary use statements. [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547477 (owner: 10Robert Vogel) [08:50:45] (03CR) 10Robert Vogel: [C: 03+2] Fix documentation link [extensions/BlueSpiceChecklist] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547417 (owner: 10Mglaser) [08:50:57] (03Merged) 10jenkins-bot: Fix waring due to unnecessary use statements. [extensions/BlueSpiceFoundation] (REL1_31) - 10https://gerrit.wikimedia.org/r/547476 (owner: 10Robert Vogel) [08:50:59] (03CR) 10jerkins-bot: [V: 04-1] Fix waring due to unnecessary use statements. [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547477 (owner: 10Robert Vogel) [08:51:17] (03CR) 10Robert Vogel: [C: 03+2] Fix documentation link [extensions/BlueSpiceCustomMenu] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547470 (owner: 10Mglaser) [08:51:19] (03Merged) 10jenkins-bot: Fix documentation link [extensions/BlueSpiceChecklist] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547417 (owner: 10Mglaser) [08:51:21] (03CR) 10Pwirth: [C: 03+1] "awaiting i18n review" [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/542448 (owner: 10AlexPinchuk) [08:51:30] (03CR) 10Robert Vogel: [C: 03+2] Fix documentation link [extensions/BlueSpicePrivacy] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547472 (owner: 10Mglaser) [08:51:34] (03PS1) 10Robert Vogel: Fix documentation link [extensions/BlueSpicePrivacy] (REL1_31) - 10https://gerrit.wikimedia.org/r/547478 [08:51:37] (03CR) 10Robert Vogel: [C: 03+2] Fix documentation link [extensions/BlueSpicePrivacy] (REL1_31) - 10https://gerrit.wikimedia.org/r/547478 (owner: 10Robert Vogel) [08:51:44] (03PS1) 10Robert Vogel: Fix documentation link [extensions/BlueSpicePrivacy] - 10https://gerrit.wikimedia.org/r/547479 [08:51:48] (03CR) 10Robert Vogel: [C: 03+2] Fix documentation link [extensions/BlueSpicePrivacy] - 10https://gerrit.wikimedia.org/r/547479 (owner: 10Robert Vogel) [08:51:55] (03Merged) 10jenkins-bot: Fix waring due to unnecessary use statements. [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/547402 (owner: 10Pwirth) [08:52:10] (03CR) 10Robert Vogel: [C: 03+2] Fix documentation link [extensions/BlueSpiceWatchList] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547473 (owner: 10Mglaser) [08:52:40] (03CR) 10jerkins-bot: [V: 04-1] Fix documentation link [extensions/BlueSpiceCustomMenu] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547470 (owner: 10Mglaser) [08:53:31] (03CR) 10jerkins-bot: [V: 04-1] Fix documentation link [extensions/BlueSpicePrivacy] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547472 (owner: 10Mglaser) [08:53:56] (03CR) 10Robert Vogel: [V: 03+2 C: 03+2] Fix waring due to unnecessary use statements. [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547477 (owner: 10Robert Vogel) [08:54:11] (03Merged) 10jenkins-bot: Fix documentation link [extensions/BlueSpicePrivacy] - 10https://gerrit.wikimedia.org/r/547479 (owner: 10Robert Vogel) [08:54:38] (03Merged) 10jenkins-bot: Fix documentation link [extensions/BlueSpicePrivacy] (REL1_31) - 10https://gerrit.wikimedia.org/r/547478 (owner: 10Robert Vogel) [08:54:50] (03CR) 10jerkins-bot: [V: 04-1] Fix documentation link [extensions/BlueSpiceWatchList] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547473 (owner: 10Mglaser) [09:02:30] (03PS14) 10AlexPinchuk: SnapshotStatistics: phase 2 [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/542448 [09:04:37] (03CR) 10Raimond Spekking: [C: 03+1] "i18n review" [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/542448 (owner: 10AlexPinchuk) [09:05:06] (03CR) 10Pwirth: [C: 03+2] SnapshotStatistics: phase 2 [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/542448 (owner: 10AlexPinchuk) [09:05:15] (03PS1) 10Pwirth: SnapshotStatistics: phase 2 [extensions/BlueSpiceExtendedStatistics] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547480 [09:05:21] (03CR) 10Pwirth: [V: 03+2 C: 03+2] SnapshotStatistics: phase 2 [extensions/BlueSpiceExtendedStatistics] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547480 (owner: 10Pwirth) [09:05:39] (03Merged) 10jenkins-bot: SnapshotStatistics: phase 2 [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/542448 (owner: 10AlexPinchuk) [09:06:36] (03CR) 10Pwirth: [V: 03+2] Fix broken url whenever the attachments area gets created from special page. [extensions/BlueSpiceSocialWikiPage] (REL1_31) - 10https://gerrit.wikimedia.org/r/547475 (owner: 10Mglaser) [09:11:01] (03CR) 10Mglaser: [V: 03+2] Fix documentation link [extensions/BlueSpiceWatchList] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547473 (owner: 10Mglaser) [09:16:37] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10Operations, and 8 others: Picture from Commons not found from Singapore - https://phabricator.wikimedia.org/T231086 (10fgiunchedi) >>! In T231086#5619797, @aaron wrote: >>>! In T231086#5601608, @fgiunchedi wrote: >> swiftrepl is puppetized now to run... [09:16:43] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Community-consensus-needed: Add monolingual language code tnq (Taíno) and car (Kalinago) - https://phabricator.wikimedia.org/T220284 (10jhsoby) For the record, I'm fine with adding these. However I believe the correct language code for Kalinago is [`cr... [09:16:54] (03PS1) 10Mglaser: Fix documentation link [extensions/BlueSpiceWatchList] (REL1_31) - 10https://gerrit.wikimedia.org/r/547482 [09:18:09] 10CommRel-Specialists-Support (Oct-Dec-2019): Translation Outreach for Community Wishlist Survey 2020 - https://phabricator.wikimedia.org/T236326 (10Trizek-WMF) Thank you for the proposal, but [[https://meta.wikimedia.org/wiki/Wikidata_MassMessage_tool|this tool already exists]]. I've generated a list from it: P... [09:18:10] (03PS1) 10Mglaser: Fix documentation link [extensions/BlueSpiceWatchList] - 10https://gerrit.wikimedia.org/r/547483 [09:19:51] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.1, 10Growth-Team (Current Sprint): Newcomer tasks: evaluate topic matching prototypes - https://phabricator.wikimedia.org/T234272 (10Trizek-WMF) 05Open→03Resolved All subtasks done. [09:19:53] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.1, 10Growth-Team (Current Sprint): Newcomer tasks: prototype topic matching - https://phabricator.wikimedia.org/T231506 (10Trizek-WMF) [09:20:44] (03PS1) 10Mglaser: Fix documentation link [extensions/BlueSpiceChecklist] (REL1_31) - 10https://gerrit.wikimedia.org/r/547485 [09:21:42] 10Wikidata-Tainted-References-Sprint4: [4h timebox] Investigate wrapping OOUI component in Web Component - https://phabricator.wikimedia.org/T236673 (10hoo) a:03hoo [09:21:50] (03PS1) 10Mglaser: Fix documentation link [extensions/BlueSpiceChecklist] - 10https://gerrit.wikimedia.org/r/547486 [09:22:19] (03PS13) 10ItSpiderman: Move OAuth2 functionality to OAuth(1) - client registration [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/543853 (https://phabricator.wikimedia.org/T229505) [09:22:27] 10MediaViewer, 10Browser-Support-Firefox: Closing an image returns you to the top of the page, not where you were before clicking on the picture in Firefox - https://phabricator.wikimedia.org/T236967 (10Peachey88) [09:22:29] (03CR) 10DCausse: Move bulk content for update after ElasticaWrite (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/546285 (https://phabricator.wikimedia.org/T236186) (owner: 10EBernhardson) [09:22:31] (03CR) 10Pwirth: [C: 03+2] Fix documentation link [extensions/BlueSpiceWatchList] - 10https://gerrit.wikimedia.org/r/547483 (owner: 10Mglaser) [09:22:33] (03CR) 10Pwirth: [C: 03+2] Fix documentation link [extensions/BlueSpiceWatchList] (REL1_31) - 10https://gerrit.wikimedia.org/r/547482 (owner: 10Mglaser) [09:23:31] (03CR) 10Mglaser: [V: 03+2] Fix documentation link [extensions/BlueSpiceCustomMenu] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547470 (owner: 10Mglaser) [09:23:35] (03CR) 10jerkins-bot: [V: 04-1] Move OAuth2 functionality to OAuth(1) - client registration [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/543853 (https://phabricator.wikimedia.org/T229505) (owner: 10ItSpiderman) [09:23:40] (03PS3) 10Tpt: Add page navigation tabs in correct order skin-side and remove js requirement for Vector tab icons [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/533327 (https://phabricator.wikimedia.org/T231250) (owner: 10Isarra) [09:24:08] 10MediaWiki-General: Create Default MainStash Solution - https://phabricator.wikimedia.org/T228307 (10Aklapper) @EvanProdromou: Assuming this task is about #MediaWiki-General, hence adding project tag so others can find this task when searching for tasks under that project or looking at that project workboard. [09:25:14] (03Merged) 10jenkins-bot: Fix documentation link [extensions/BlueSpiceWatchList] (REL1_31) - 10https://gerrit.wikimedia.org/r/547482 (owner: 10Mglaser) [09:25:19] (03PS1) 10Mglaser: Fix documentation link [extensions/BlueSpiceCustomMenu] (REL1_31) - 10https://gerrit.wikimedia.org/r/547487 [09:26:04] (03Merged) 10jenkins-bot: Fix documentation link [extensions/BlueSpiceWatchList] - 10https://gerrit.wikimedia.org/r/547483 (owner: 10Mglaser) [09:26:31] (03PS1) 10Mglaser: Fix documentation link [extensions/BlueSpiceCustomMenu] - 10https://gerrit.wikimedia.org/r/547488 [09:26:56] (03CR) 10Tpt: [C: 03+2] "@Isarra I allowed myself to rebase your change to merge it. I hope it was fine for you." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/533327 (https://phabricator.wikimedia.org/T231250) (owner: 10Isarra) [09:27:05] (03CR) 10Mglaser: [V: 03+2] Fix documentation link [extensions/BlueSpicePrivacy] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547472 (owner: 10Mglaser) [09:27:07] 10WikiApiary: Edit Count graphs cannot be changed to show other time frame than default 2 month although other options offered - https://phabricator.wikimedia.org/T236919 (10Aklapper) [09:31:14] (03CR) 10Pwirth: [C: 03+2] Fix documentation link [extensions/BlueSpiceCustomMenu] - 10https://gerrit.wikimedia.org/r/547488 (owner: 10Mglaser) [09:31:16] (03CR) 10Pwirth: [C: 03+2] Fix documentation link [extensions/BlueSpiceChecklist] (REL1_31) - 10https://gerrit.wikimedia.org/r/547485 (owner: 10Mglaser) [09:31:18] (03CR) 10Pwirth: [C: 03+2] Fix documentation link [extensions/BlueSpiceChecklist] - 10https://gerrit.wikimedia.org/r/547486 (owner: 10Mglaser) [09:31:20] (03CR) 10Pwirth: [C: 03+2] Fix documentation link [extensions/BlueSpiceCustomMenu] (REL1_31) - 10https://gerrit.wikimedia.org/r/547487 (owner: 10Mglaser) [09:31:22] 10Wikidata-Tainted-References-Sprint4: [4h timebox] Investigate wrapping OOUI component in Web Component - https://phabricator.wikimedia.org/T236673 (10hoo) Apparently we [[ https://caniuse.com/#feat=custom-elementsv1 | can't yet use webcomponents in all supported browsers ]], so this is not the way to go. [09:31:42] (03Merged) 10jenkins-bot: Fix documentation link [extensions/BlueSpiceChecklist] (REL1_31) - 10https://gerrit.wikimedia.org/r/547485 (owner: 10Mglaser) [09:32:18] (03Merged) 10jenkins-bot: Add page navigation tabs in correct order skin-side and remove js requirement for Vector tab icons [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/533327 (https://phabricator.wikimedia.org/T231250) (owner: 10Isarra) [09:33:49] (03Merged) 10jenkins-bot: Fix documentation link [extensions/BlueSpiceCustomMenu] (REL1_31) - 10https://gerrit.wikimedia.org/r/547487 (owner: 10Mglaser) [09:34:46] (03Merged) 10jenkins-bot: Fix documentation link [extensions/BlueSpiceCustomMenu] - 10https://gerrit.wikimedia.org/r/547488 (owner: 10Mglaser) [09:34:48] (03Merged) 10jenkins-bot: Fix documentation link [extensions/BlueSpiceChecklist] - 10https://gerrit.wikimedia.org/r/547486 (owner: 10Mglaser) [09:35:12] (03PS1) 10Tpt: Makes sure that Vector default background does not override the navigation arrows [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/547490 (https://phabricator.wikimedia.org/T236969) [09:35:54] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Tracking-Neverending: new monolingual language code requests for Wikidata (tracking) - https://phabricator.wikimedia.org/T144272 (10Lydia_Pintscher) [09:35:57] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Add monolingual language code lcm - https://phabricator.wikimedia.org/T234761 (10Lydia_Pintscher) 05Stalled→03Resolved \o/ [09:36:53] 10GrowthExperiments-Homepage, 10GrowthExperiments-NewcomerTasks, 10Growth-Team (Current Sprint): Newcomer tasks: hidden preference - https://phabricator.wikimedia.org/T236968 (10Trizek-WMF) We can make it public, as a sort-of Beta feature : {F30937321} [09:46:18] (03CR) 10Jon Harald Søby: [C: 03+1] Makes sure that Vector default background does not override the navigation arrows [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/547490 (https://phabricator.wikimedia.org/T236969) (owner: 10Tpt) [09:47:42] (03CR) 10Tpt: [C: 03+2] "Reviewed by Jon (thank you!)" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/547490 (https://phabricator.wikimedia.org/T236969) (owner: 10Tpt) [09:55:44] (03PS1) 10Tpt: Add page navigation tabs in correct order skin-side and remove js requirement for Vector tab icons [extensions/ProofreadPage] (wmf/1.35.0-wmf.4) - 10https://gerrit.wikimedia.org/r/547495 (https://phabricator.wikimedia.org/T231250) [10:01:29] (03Merged) 10jenkins-bot: Makes sure that Vector default background does not override the navigation arrows [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/547490 (https://phabricator.wikimedia.org/T236969) (owner: 10Tpt) [10:02:21] (03CR) 10DCausse: Perform model upload from bulk daemon (032 comments) [search/MjoLniR] - 10https://gerrit.wikimedia.org/r/535732 (owner: 10EBernhardson) [10:02:23] 10MediaWiki-User-management, 10MediaWiki-extensions-CentralAuth, 10Stewards-and-global-tools, 10Anti-Harassment (The Letter Song), and 3 others: Special:CentralAuth should provide the same blocking information as Special:BlockList does - https://phabricator.wikimedia.org/T200938 (10dom_walden) Special:Cent... [10:06:19] 10MediaViewer, 10Browser-Support-Firefox: Closing an image returns you to the top of the page, not where you were before clicking on the picture in Firefox - https://phabricator.wikimedia.org/T236967 (10Aklapper) [10:06:21] 10MediaViewer, 10Regression: Browser view goes up to the top of the page when user exits Media Viewer - https://phabricator.wikimedia.org/T236520 (10Aklapper) [10:06:56] 10MediaViewer, 10Browser-Support-Firefox, 10Regression: In Firefox 70, view goes up to the top of the page when user exits Media Viewer - https://phabricator.wikimedia.org/T236520 (10Aklapper) [10:07:58] (03PS1) 10Tpt: Makes sure that Vector default background does not override the navigation arrows [extensions/ProofreadPage] (wmf/1.35.0-wmf.4) - 10https://gerrit.wikimedia.org/r/547498 (https://phabricator.wikimedia.org/T236969) [10:11:41] 10Wikimedia-Site-requests: Lift IP cap for edit-a-thon at Bard College Nov. 11, 2019 - https://phabricator.wikimedia.org/T236955 (10Aklapper) @EditingOedipa: Thanks for creating this ticket. Please provide all [[ https://meta.wikimedia.org/wiki/Mass_account_creation#Requesting_temporary_lift_of_IP_cap | required... [10:22:34] 10WMSE-Magnus Sälgö: Property Alvin P6821 created and need to be matched - https://phabricator.wikimedia.org/T225522 (10Salgo60) [10:28:29] 10WMSE-Magnus Sälgö: Property Alvin P6821 created and need to be matched - https://phabricator.wikimedia.org/T225522 (10Salgo60) [10:29:41] 10MediaWiki-Special-pages, 10Core Platform Team Workboards (Clinic Duty Team), 10Performance Issue, 10Security, and 3 others: Some Special:Contributions requests cause "Error: 0" from database or WMFTimeoutException - https://phabricator.wikimedia.org/T234450 (10MER-C) Why not make the higher limits a priv... [10:36:34] (03CR) 10Isarra: "Of course! I noticed you even fixed some (new?) stuff in vector for this, too! Thanks!" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/533327 (https://phabricator.wikimedia.org/T231250) (owner: 10Isarra) [10:37:19] (03CR) 10Jack Phoenix: [C: 03+2] Clean up ProofreadPage page tabs a bit [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533328 (https://phabricator.wikimedia.org/T231250) (owner: 10Isarra) [10:37:21] (03PS1) 10Pwirth: Fix only 25 results being shown in aggregated statistics [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/547502 [10:49:08] 10MediaViewer, 10Browser-Support-Firefox, 10Regression: In Firefox 70, view goes up to the top of the page when user exits Media Viewer - https://phabricator.wikimedia.org/T236520 (10Thryduulf) From the merged task, this occurs in Firefox 70 on Windows 7, Windows 10 and Xubuntu Linux 18.04. It doesn't occur... [10:54:13] 10MediaWiki Language Extension Bundle, 10Language-Team (Language-2019-October-December): Release MLEB 2019.10 - https://phabricator.wikimedia.org/T236167 (10KartikMistry) [11:00:02] 10MediaWiki-Containers, 10Wikibase-Containers, 10Wikidata: Sendmail not working. mail() function required in wikibase docker image - https://phabricator.wikimedia.org/T206517 (10Phaebz) Ah, thanks for pointer and reference. > So, if in T206517#5559725 you were trying with the docker images then there might... [11:02:00] 10MediaWiki-Change-tagging, 10MediaWiki-User-management, 10Anti-Harassment: When sitewide blocked, cannot edit tags on own User_talk, even if allowed to edit own User_talk - https://phabricator.wikimedia.org/T236996 (10dom_walden) [11:10:01] 10MediaWiki-Special-pages, 10Patch-For-Review, 10Wikimedia-database-error: Numeric page titles can cause query page reports to stop updating - https://phabricator.wikimedia.org/T181658 (10TK-999) Still an issue with 1.33 [11:10:11] (03CR) 10Urbanecm: [C: 03+2] "SWAT" [extensions/ProofreadPage] (wmf/1.35.0-wmf.4) - 10https://gerrit.wikimedia.org/r/547495 (https://phabricator.wikimedia.org/T231250) (owner: 10Tpt) [11:10:18] (03CR) 10Urbanecm: [C: 03+2] "SWAT" [extensions/ProofreadPage] (wmf/1.35.0-wmf.4) - 10https://gerrit.wikimedia.org/r/547498 (https://phabricator.wikimedia.org/T236969) (owner: 10Tpt) [11:11:27] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2019-October-December), 10MW-1.35-notes (1.35.0-wmf.4; 2019-10-29), 10User-abi_: Support renames in Special:ManageMessageGroups - https://phabricator.wikimedia.org/T196601 (10abi_) This patch has been deployed on Translatewiki.net and we're (Raimo... [11:14:44] 10MediaWiki-Vagrant: npm::install: Maximum call stack size exceeded - https://phabricator.wikimedia.org/T166953 (10TammyGuido) Thanx for sharing these tips. I think all professionals should do monthly assessments to prevent some mistakes and learn new info. I recommend you [[ https://ca.edubirdie.com/coursework-... [11:15:07] 10MediaWiki-extensions-Translate, 10UI-Standardization, 10Language-Team (Language-2019-October-December), 10MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), 10UI-Standardization-Kanban: Horizontal rule element underneath “Translate this page” should be removed - https://phabricator.wikimedia.org/T220841 (10abi_... [11:15:54] (03Merged) 10jenkins-bot: Add page navigation tabs in correct order skin-side and remove js requirement for Vector tab icons [extensions/ProofreadPage] (wmf/1.35.0-wmf.4) - 10https://gerrit.wikimedia.org/r/547495 (https://phabricator.wikimedia.org/T231250) (owner: 10Tpt) [11:15:56] (03Merged) 10jenkins-bot: Clean up ProofreadPage page tabs a bit [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533328 (https://phabricator.wikimedia.org/T231250) (owner: 10Isarra) [11:16:02] (03Merged) 10jenkins-bot: Makes sure that Vector default background does not override the navigation arrows [extensions/ProofreadPage] (wmf/1.35.0-wmf.4) - 10https://gerrit.wikimedia.org/r/547498 (https://phabricator.wikimedia.org/T236969) (owner: 10Tpt) [11:17:38] (03CR) 10MSantos: [C: 04-1] Tag reverted computer-aided tagging revisions (031 comment) [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/547323 (https://phabricator.wikimedia.org/T231032) (owner: 10Mholloway) [11:20:16] (03PS6) 10Dmaza: Remove blocker dependency for System and Composite blocks [core] - 10https://gerrit.wikimedia.org/r/540940 (https://phabricator.wikimedia.org/T227892) [11:21:28] 10MediaWiki-Watchlist, 10Growth-Team: impossibility to edit or reset very long watchlist - https://phabricator.wikimedia.org/T236957 (10Aklapper) Pretty much {T41510}, I guess? Wondering whether to merge into that task... [11:28:19] 10MediaWiki-extensions-Translate: Paginate group getting through Translate API for performance purposes - https://phabricator.wikimedia.org/T236904 (10Pols12) >>! In T236904#5619674, @Nikerabbit wrote: > For Special:AggregateGroups I suggest to use {T90511}. > > We could dedicate this ticket to optimizing the m... [11:30:45] (03PS1) 10Tchanders: Stop passing in 'byText' option for system and composite blocks [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/547507 [11:33:10] 10Anti-Harassment: System and composite block messages on mobile contain confusing information - https://phabricator.wikimedia.org/T225939 (10dom_walden) @Tchanders I am finding on beta and test that the "Details" link in mobile block messages has an empty href. Experimenting locally, it seems to first happen w... [11:33:46] (03CR) 10Mainframe98: Add LinkBatchFactory to inject services into LinkBatch (031 comment) [core] - 10https://gerrit.wikimedia.org/r/544296 (owner: 10Mainframe98) [11:33:53] (03PS3) 10Mainframe98: Add LinkBatchFactory to inject services into LinkBatch [core] - 10https://gerrit.wikimedia.org/r/544296 [11:34:19] (03CR) 10Tchanders: [C: 04-1] "Looks good - just the version numbers and TitlePermissionTest." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/540940 (https://phabricator.wikimedia.org/T227892) (owner: 10Dmaza) [11:39:13] (03CR) 10Dmaza: [C: 03+2] Stop passing in 'byText' option for system and composite blocks [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/547507 (owner: 10Tchanders) [11:41:51] 10CX-boost, 10CX-out-of-beta, 10Language-Team (Language-2019-October-December): Request for ContentTranslation to be enabled by default on sq.wikipedia - https://phabricator.wikimedia.org/T236064 (10Pginer-WMF) @Arianit, Content translation has been enabled by default in Albanian. I posted [[ https://sq.wiki... [11:43:44] (03CR) 10jerkins-bot: [V: 04-1] Add LinkBatchFactory to inject services into LinkBatch [core] - 10https://gerrit.wikimedia.org/r/544296 (owner: 10Mainframe98) [11:45:54] (03PS7) 10Dmaza: Remove blocker dependency for System and Composite blocks [core] - 10https://gerrit.wikimedia.org/r/540940 (https://phabricator.wikimedia.org/T227892) [11:48:50] (03CR) 10Tchanders: [C: 03+1] Remove blocker dependency for System and Composite blocks [core] - 10https://gerrit.wikimedia.org/r/540940 (https://phabricator.wikimedia.org/T227892) (owner: 10Dmaza) [11:50:28] 10MediaWiki-extensions-Graph, 10RESTBase-API, 10wikitech.wikimedia.org: 404 for wikitech chart from rest_v1/page/graph/png - https://phabricator.wikimedia.org/T236998 (10Addshore) [11:54:46] (03PS1) 10ItSpiderman: Move OAuth2 functionality to OAuth(1) - database updates [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/547511 [11:57:09] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10good first bug, 10patch-welcome: Add monolingual language code "sa-Sidd" and "pi-Sidd" - https://phabricator.wikimedia.org/T230881 (10Mbch331) a:03Mbch331 [11:57:19] (03CR) 10ItSpiderman: [C: 03+2] Fix only 25 results being shown in aggregated statistics [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/547502 (owner: 10Pwirth) [11:57:27] (03PS1) 10ItSpiderman: Fix only 25 results being shown in aggregated statistics [extensions/BlueSpiceExtendedStatistics] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547512 [11:57:30] (03CR) 10ItSpiderman: [C: 03+2] Fix only 25 results being shown in aggregated statistics [extensions/BlueSpiceExtendedStatistics] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547512 (owner: 10ItSpiderman) [11:57:53] (03Merged) 10jenkins-bot: Fix only 25 results being shown in aggregated statistics [extensions/BlueSpiceExtendedStatistics] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547512 (owner: 10ItSpiderman) [11:59:57] (03PS14) 10ItSpiderman: Move OAuth2 functionality to OAuth(1) - client registration [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/543853 (https://phabricator.wikimedia.org/T229505) [12:00:41] (03Merged) 10jenkins-bot: Fix only 25 results being shown in aggregated statistics [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/547502 (owner: 10Pwirth) [12:01:28] (03CR) 10jerkins-bot: [V: 04-1] Move OAuth2 functionality to OAuth(1) - client registration [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/543853 (https://phabricator.wikimedia.org/T229505) (owner: 10ItSpiderman) [12:02:54] (03PS15) 10ItSpiderman: Move OAuth2 functionality to OAuth(1) - client registration [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/543853 (https://phabricator.wikimedia.org/T229505) [12:05:12] 10Wikidata-Tainted-References-Sprint4: Wire Open Action to TaintedIcon click - https://phabricator.wikimedia.org/T236888 (10hoo) a:03hoo [12:05:22] (03CR) 10jerkins-bot: [V: 04-1] Move OAuth2 functionality to OAuth(1) - client registration [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/543853 (https://phabricator.wikimedia.org/T229505) (owner: 10ItSpiderman) [12:07:03] (03PS1) 10Dmaza: Remove commented out code from PermissionManagerTest [core] - 10https://gerrit.wikimedia.org/r/547513 [12:07:55] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2019-October-December), 10Patch-For-Review: Error message with HTML entity insertables as params should display the entity as text - https://phabricator.wikimedia.org/T231942 (10abi_) Tested the patch by Niklas locally, and it works well. See screen... [12:12:29] (03CR) 10Eric Gardner: "Recheck" [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/546917 (https://phabricator.wikimedia.org/T231102) (owner: 10Eric Gardner) [12:15:34] (03PS1) 10Urbanecm: Move admin interface code to separate file [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547514 [12:15:36] (03PS1) 10Urbanecm: Add basic news frontend [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547515 [12:15:38] (03PS1) 10Urbanecm: Load scripts only when non-admin [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547516 [12:15:40] (03PS1) 10Urbanecm: Display success notice only once [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547517 [12:15:47] (03CR) 10Urbanecm: [C: 03+2] Move admin interface code to separate file [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547514 (owner: 10Urbanecm) [12:15:51] (03CR) 10Urbanecm: [C: 03+2] Add basic news frontend [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547515 (owner: 10Urbanecm) [12:15:56] (03CR) 10Urbanecm: [C: 03+2] Load scripts only when non-admin [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547516 (owner: 10Urbanecm) [12:16:02] (03CR) 10Urbanecm: [C: 03+2] Display success notice only once [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547517 (owner: 10Urbanecm) [12:16:05] (03Merged) 10jenkins-bot: Move admin interface code to separate file [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547514 (owner: 10Urbanecm) [12:16:09] (03Merged) 10jenkins-bot: Add basic news frontend [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547515 (owner: 10Urbanecm) [12:16:16] (03Merged) 10jenkins-bot: Load scripts only when non-admin [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547516 (owner: 10Urbanecm) [12:16:19] (03Merged) 10jenkins-bot: Display success notice only once [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547517 (owner: 10Urbanecm) [12:20:32] (03PS1) 10Urbanecm: Display published date and order by date of publishing [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547518 [12:20:45] (03CR) 10Urbanecm: [C: 03+2] Display published date and order by date of publishing [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547518 (owner: 10Urbanecm) [12:21:02] 10Editing Design, 10Patch-For-Review, 10VisualEditor (Current work): Mobile VE toolbar doesn't stay onscreen on iOS 13 when keyboard is open - https://phabricator.wikimedia.org/T233470 (10Esanders) This is much better! [12:21:04] (03Merged) 10jenkins-bot: Display published date and order by date of publishing [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547518 (owner: 10Urbanecm) [12:21:47] (03PS4) 10TK-999: Do not insert page titles into querycache.qc_value [core] - 10https://gerrit.wikimedia.org/r/419441 (https://phabricator.wikimedia.org/T181658) [12:21:59] 10MobileFrontend, 10Anti-Harassment (The Letter Song), 10Patch-For-Review, 10Readers-Web-Backlog (Tracking): Improve blocker information on mobile block error message drawer - https://phabricator.wikimedia.org/T236814 (10Niharika) >>! In T236814#5622434, @Tchanders wrote: > @Niharika It can be a username b... [12:22:06] (03PS16) 10ItSpiderman: Move OAuth2 functionality to OAuth(1) - client registration [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/543853 (https://phabricator.wikimedia.org/T229505) [12:22:36] 10MediaWiki-Special-pages, 10Patch-For-Review, 10Wikimedia-database-error: Numeric page titles can cause query page reports to stop updating - https://phabricator.wikimedia.org/T181658 (10TK-999) I've rebased the existing patchset, sorry about the undue delay incurred. [12:23:14] (03CR) 10jerkins-bot: [V: 04-1] Move OAuth2 functionality to OAuth(1) - client registration [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/543853 (https://phabricator.wikimedia.org/T229505) (owner: 10ItSpiderman) [12:28:15] (03PS1) 10Urbanecm: Display list of news at subpage [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547520 [12:28:17] (03PS1) 10Urbanecm: Codestyle [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547521 [12:28:26] (03CR) 10Urbanecm: [C: 03+2] Display list of news at subpage [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547520 (owner: 10Urbanecm) [12:28:28] (03PS17) 10ItSpiderman: Move OAuth2 functionality to OAuth(1) - client registration [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/543853 (https://phabricator.wikimedia.org/T229505) [12:28:31] (03CR) 10Urbanecm: [C: 03+2] Codestyle [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547521 (owner: 10Urbanecm) [12:28:43] (03Merged) 10jenkins-bot: Display list of news at subpage [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547520 (owner: 10Urbanecm) [12:28:50] (03Merged) 10jenkins-bot: Codestyle [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547521 (owner: 10Urbanecm) [12:29:27] 10Library-Card-Platform, 10Google-Code-in-2019, 10good first bug: Add more links to activity feed - https://phabricator.wikimedia.org/T218857 (10Nicks-bro) a:03Nicks-bro [12:29:30] (03PS4) 10Jon Harald Søby: Add default index template and data config [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/539689 (https://phabricator.wikimedia.org/T60062) [12:29:46] (03CR) 10jerkins-bot: [V: 04-1] Move OAuth2 functionality to OAuth(1) - client registration [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/543853 (https://phabricator.wikimedia.org/T229505) (owner: 10ItSpiderman) [12:29:48] 10MediaWiki-extensions-Translate: Paginate group getting through Translate API for performance purposes - https://phabricator.wikimedia.org/T236904 (10Nikerabbit) I can confirm https://meta.wikimedia.org/w/api.php?action=query&format=json&meta=messagegroups&mgformat=tree&mgprop=id%7Clabel%7Cicon%7Cpriority%7Cpri... [12:30:17] (03PS5) 10Jon Harald Søby: Add default index template and data config [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/539689 (https://phabricator.wikimedia.org/T60062) [12:31:58] (03CR) 10Jon Harald Søby: "I have tested this with Vagrant, and it works fine (for me at least)." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/539689 (https://phabricator.wikimedia.org/T60062) (owner: 10Jon Harald Søby) [12:35:33] 10Wikimedia-General-or-Unknown, 10I18n: [[Wikimedia:Wikipedia-ios-reading-list-sync-enabled-panel-title]] translation issue - https://phabricator.wikimedia.org/T237003 (10Luky001) [12:39:58] (03CR) 10TK-999: "Thanks for the review and sorry for the undue delay." [core] - 10https://gerrit.wikimedia.org/r/419441 (https://phabricator.wikimedia.org/T181658) (owner: 10TK-999) [12:43:12] (03PS18) 10ItSpiderman: Move OAuth2 functionality to OAuth(1) - client registration [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/543853 (https://phabricator.wikimedia.org/T229505) [12:43:52] (03PS1) 10Pwirth: Prevent assignments from deleted or invalid titles being created [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/547524 [12:44:29] (03CR) 10jerkins-bot: [V: 04-1] Move OAuth2 functionality to OAuth(1) - client registration [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/543853 (https://phabricator.wikimedia.org/T229505) (owner: 10ItSpiderman) [12:47:35] (03CR) 10Daimona Eaytoy: Shell\Result: declare types, enable strict types (031 comment) [core] - 10https://gerrit.wikimedia.org/r/546787 (owner: 10MaxSem) [12:54:22] (03PS19) 10ItSpiderman: Move OAuth2 functionality to OAuth(1) - client registration [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/543853 (https://phabricator.wikimedia.org/T229505) [12:54:33] (03CR) 10Dmaza: [C: 03+2] Save autoblock reasons with unexpanded templates [core] - 10https://gerrit.wikimedia.org/r/547211 (https://phabricator.wikimedia.org/T236501) (owner: 10Tchanders) [12:55:26] (03CR) 10Daimona Eaytoy: "> Ok, Lingo 3.1 has been released and 3.2 development started." [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/545141 (owner: 10Libraryupgrader) [12:57:17] (03CR) 10Dmaza: [C: 03+2] Allow block message drawer to handle different block creators [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/546991 (https://phabricator.wikimedia.org/T236814) (owner: 10Tchanders) [12:58:36] (03CR) 10jerkins-bot: [V: 04-1] Move OAuth2 functionality to OAuth(1) - client registration [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/543853 (https://phabricator.wikimedia.org/T229505) (owner: 10ItSpiderman) [12:59:25] (03PS1) 10Urbanecm: Rename classes for programs [wikimedia-cz/web-theme] - 10https://gerrit.wikimedia.org/r/547526 [12:59:35] (03CR) 10Daimona Eaytoy: "The patch itself is fine. My only concern is whether other code is passing the wrong type, like AF does. The AF one was fortunately caught" [core] - 10https://gerrit.wikimedia.org/r/546782 (owner: 10MaxSem) [13:00:18] (03CR) 10Urbanecm: [C: 03+2] Rename classes for programs [wikimedia-cz/web-theme] - 10https://gerrit.wikimedia.org/r/547526 (owner: 10Urbanecm) [13:00:34] (03Merged) 10jenkins-bot: Rename classes for programs [wikimedia-cz/web-theme] - 10https://gerrit.wikimedia.org/r/547526 (owner: 10Urbanecm) [13:05:16] (03CR) 10Daimona Eaytoy: [C: 04-1] "> For starters, there were no extension unit tests until 1.17." [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/546777 (https://phabricator.wikimedia.org/T235990) (owner: 10MaxSem) [13:11:59] (03Merged) 10jenkins-bot: Save autoblock reasons with unexpanded templates [core] - 10https://gerrit.wikimedia.org/r/547211 (https://phabricator.wikimedia.org/T236501) (owner: 10Tchanders) [13:12:02] (03Merged) 10jenkins-bot: Allow block message drawer to handle different block creators [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/546991 (https://phabricator.wikimedia.org/T236814) (owner: 10Tchanders) [13:12:04] (03CR) 10Daimona Eaytoy: [C: 04-1] "> I would actually argue that the trait should be kept for a while," [core] - 10https://gerrit.wikimedia.org/r/546456 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [13:12:06] (03Merged) 10jenkins-bot: Stop passing in 'byText' option for system and composite blocks [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/547507 (owner: 10Tchanders) [13:15:59] (03PS1) 10WMDE-Fisch: Count edit conflicts combined with user edits [core] - 10https://gerrit.wikimedia.org/r/547531 (https://phabricator.wikimedia.org/T236886) [13:42:37] (03PS1) 10Addshore: Remove old pcache metric compat from ParserCache.php [core] - 10https://gerrit.wikimedia.org/r/547533 (https://phabricator.wikimedia.org/T235724) [13:49:22] (03CR) 10Krinkle: "If the main concern is with having to remove one line from ext repo tests, perhaps we could keep the trait as an empty trait." [core] - 10https://gerrit.wikimedia.org/r/546456 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [13:59:51] (03PS7) 10ItSpiderman: Move OAuth2 functionality to OAuth(1) - oauth2 workflow [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/544919 (https://phabricator.wikimedia.org/T229508) [14:02:48] (03CR) 10Tchanders: [C: 03+2] Remove blocker dependency for System and Composite blocks [core] - 10https://gerrit.wikimedia.org/r/540940 (https://phabricator.wikimedia.org/T227892) (owner: 10Dmaza) [14:04:25] (03CR) 10jerkins-bot: [V: 04-1] Move OAuth2 functionality to OAuth(1) - oauth2 workflow [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/544919 (https://phabricator.wikimedia.org/T229508) (owner: 10ItSpiderman) [14:12:42] (03CR) 10Nikerabbit: "Is this backwards compatible? If I remember correctly, return type hints can be added when they don't exist, but not so for parameter type" [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/547260 (owner: 10Fomafix) [14:12:52] (03Merged) 10jenkins-bot: Remove blocker dependency for System and Composite blocks [core] - 10https://gerrit.wikimedia.org/r/540940 (https://phabricator.wikimedia.org/T227892) (owner: 10Dmaza) [14:24:20] (03Abandoned) 10Tchanders: WIP Remove requirement for blocker on a SystemBlock to be a User [core] - 10https://gerrit.wikimedia.org/r/531517 (https://phabricator.wikimedia.org/T227005) (owner: 10Tchanders) [14:31:24] (03CR) 10Alexandros Kosiaris: [C: 04-1] Developer productivity improvements, docker support (032 comments) [services/cxserver] - 10https://gerrit.wikimedia.org/r/543029 (owner: 10Santhosh) [14:33:24] (03CR) 10Alexandros Kosiaris: [C: 04-1] Developer productivity improvements, docker support (032 comments) [services/cxserver] - 10https://gerrit.wikimedia.org/r/543029 (owner: 10Santhosh) [14:37:03] (03CR) 10Ladsgroup: [C: 03+2] Remove old pcache metric compat from ParserCache.php [core] - 10https://gerrit.wikimedia.org/r/547533 (https://phabricator.wikimedia.org/T235724) (owner: 10Addshore) [14:39:15] (03PS10) 10Milimetric: Add background queue with simple interface [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/524575 (https://phabricator.wikimedia.org/T225578) [14:40:00] (03PS1) 10ItSpiderman: Make sure non-accessible external file location wont break the crawling [extensions/BlueSpiceExtendedSearch] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547544 [14:40:34] (03CR) 10Milimetric: "thanks for the review - commented inline about the visibility support, I'll change the related WikimediaEvents refactor once this lands." (033 comments) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/524575 (https://phabricator.wikimedia.org/T225578) (owner: 10Milimetric) [14:48:42] (03Merged) 10jenkins-bot: Remove old pcache metric compat from ParserCache.php [core] - 10https://gerrit.wikimedia.org/r/547533 (https://phabricator.wikimedia.org/T235724) (owner: 10Addshore) [14:56:08] (03PS1) 10ItSpiderman: Change message to be gender-neutral [extensions/BlueSpicePrivacy] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547548 [15:09:33] (03PS4) 10Esanders: Fix opening/closing widgets multiple times [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/547278 [15:09:35] (03PS10) 10Esanders: Implement basic saving [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/545616 [15:16:05] (03PS1) 10Freephile: initial commit [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547554 [15:20:27] (03PS1) 10Mholloway: Use internal HTTP request abstractions to make Google requests [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/547555 (https://phabricator.wikimedia.org/T236843) [15:21:51] (03PS1) 10Jgleeson: Update DonationInterface submodule [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/547556 [15:22:49] (03CR) 10Mglaser: [C: 03+1] "ok, waiting for i18n review" [extensions/BlueSpicePrivacy] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547548 (owner: 10ItSpiderman) [15:23:00] (03CR) 10Jgleeson: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/547556 (owner: 10Jgleeson) [15:24:25] (03CR) 10Anomie: "This looks good so far. I see the current versions of Ief476502 and Iee89247f still have schema changes that need to be included here thou" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/547511 (owner: 10ItSpiderman) [15:25:32] (03PS11) 10Esanders: Implement basic saving [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/545616 [15:27:14] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/547556 (owner: 10Jgleeson) [15:32:41] (03PS2) 10Mholloway: Use internal HTTP request abstractions to make Google requests [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/547555 (https://phabricator.wikimedia.org/T236843) [15:36:23] (03CR) 10MarcoAurelio: "recheck" [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547554 (owner: 10Freephile) [15:37:26] (03CR) 10Tchanders: Remove commented out code from PermissionManagerTest (032 comments) [core] - 10https://gerrit.wikimedia.org/r/547513 (owner: 10Dmaza) [15:39:54] (03PS10) 10Nray: Remove obsolete 'mobile-frontend-talk-' messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/546228 (https://phabricator.wikimedia.org/T230695) [15:42:07] (03CR) 10Krinkle: "LGTM, will do a full review next week." (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/524575 (https://phabricator.wikimedia.org/T225578) (owner: 10Milimetric) [15:42:38] (03CR) 10jerkins-bot: [V: 04-1] initial commit [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547554 (owner: 10Freephile) [15:47:11] (03PS29) 10Nray: Render talk page as a tab instead of an overlay [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/540441 (https://phabricator.wikimedia.org/T230695) (owner: 10Jdlrobson) [15:47:13] (03PS18) 10Nray: Remove eventbus usage in talk.js [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/545945 (https://phabricator.wikimedia.org/T230695) [15:47:19] (03CR) 10jerkins-bot: [V: 04-1] Remove obsolete 'mobile-frontend-talk-' messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/546228 (https://phabricator.wikimedia.org/T230695) (owner: 10Nray) [15:47:37] (03CR) 10Nray: [C: 04-1] "I need to run new changes by Alex" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/540441 (https://phabricator.wikimedia.org/T230695) (owner: 10Jdlrobson) [15:47:39] (03CR) 10MarcoAurelio: "Looks like jenkins complains because there's no .eslintrc.json file to run the eslint tests. Maybe a simple file such as the one mentioned" [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547554 (owner: 10Freephile) [15:53:55] (03PS1) 10Paladox: Use wgContentNamespaces in AreHooks::onRegisterExtension [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/547564 [15:54:26] (03PS2) 10Paladox: Use wgContentNamespaces in AreHooks::onRegisterExtension [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/547564 [15:55:38] (03CR) 10Nray: [C: 04-1] "...also found a bug with "read as wiki page" appearing on talk history page" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/540441 (https://phabricator.wikimedia.org/T230695) (owner: 10Jdlrobson) [15:56:17] (03CR) 10jerkins-bot: [V: 04-1] Use wgContentNamespaces in AreHooks::onRegisterExtension [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/547564 (owner: 10Paladox) [15:57:12] (03PS1) 10Urbanecm: No limit for list of news block [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547565 [15:58:24] (03CR) 10SBassett: [C: 03+2] "I'd like to get these merged. Tests are passing after Daimona's updates, so I assume we're ok now. If not, there's always revert :)" [extensions/AbuseFilter] (REL1_31) - 10https://gerrit.wikimedia.org/r/546752 (https://phabricator.wikimedia.org/T104807) (owner: 10SBassett) [15:58:30] (03CR) 10SBassett: [C: 03+2] "I'd like to get these merged. Tests are passing after Daimona's updates, so I assume we're ok now. If not, there's always revert :)" [extensions/AbuseFilter] (REL1_32) - 10https://gerrit.wikimedia.org/r/546753 (https://phabricator.wikimedia.org/T104807) (owner: 10SBassett) [15:59:06] (03CR) 10Urbanecm: [C: 03+2] No limit for list of news block [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547565 (owner: 10Urbanecm) [15:59:15] (03CR) 10Paladox: "recheck" [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/544452 (owner: 10Libraryupgrader) [15:59:25] (03Merged) 10jenkins-bot: No limit for list of news block [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547565 (owner: 10Urbanecm) [15:59:47] (03CR) 10jerkins-bot: [V: 04-1] Render talk page as a tab instead of an overlay [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/540441 (https://phabricator.wikimedia.org/T230695) (owner: 10Jdlrobson) [16:00:45] (03CR) 10jerkins-bot: [V: 04-1] Remove eventbus usage in talk.js [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/545945 (https://phabricator.wikimedia.org/T230695) (owner: 10Nray) [16:01:24] (03Merged) 10jenkins-bot: SECURITY: Check visibility for each version in ViewDiff [extensions/AbuseFilter] (REL1_31) - 10https://gerrit.wikimedia.org/r/546752 (https://phabricator.wikimedia.org/T104807) (owner: 10SBassett) [16:02:04] (03Merged) 10jenkins-bot: SECURITY: Check visibility for each version in ViewDiff [extensions/AbuseFilter] (REL1_32) - 10https://gerrit.wikimedia.org/r/546753 (https://phabricator.wikimedia.org/T104807) (owner: 10SBassett) [16:06:13] (03CR) 10Mholloway: "Adding Aaron S. and Scott B. as reviewers since this is a substantial change to code in review (security) or recently reviewed (performanc" [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/547555 (https://phabricator.wikimedia.org/T236843) (owner: 10Mholloway) [16:06:18] (03PS2) 10MarcoAurelio: initial commit [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547554 (owner: 10Freephile) [16:06:45] (03PS3) 10Paladox: Use wgContentNamespaces in AreHooks::onRegisterExtension [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/547564 [16:07:05] (03PS4) 10Paladox: Convert callback to use ExtensionFunctions [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/547564 [16:07:24] (03PS5) 10Paladox: Convert callback to use ExtensionFunctions [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/547564 (https://phabricator.wikimedia.org/T237032) [16:08:02] (03CR) 10jerkins-bot: [V: 04-1] Convert callback to use ExtensionFunctions [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/547564 (https://phabricator.wikimedia.org/T237032) (owner: 10Paladox) [16:08:57] (03PS6) 10Paladox: Convert callback to use ExtensionFunctions [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/547564 (https://phabricator.wikimedia.org/T237032) [16:09:45] (03CR) 10jerkins-bot: [V: 04-1] Convert callback to use ExtensionFunctions [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/547564 (https://phabricator.wikimedia.org/T237032) (owner: 10Paladox) [16:10:51] (03PS7) 10Paladox: Convert callback to use ExtensionFunctions [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/547564 (https://phabricator.wikimedia.org/T237032) [16:11:23] (03CR) 10jerkins-bot: [V: 04-1] initial commit [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547554 (owner: 10Freephile) [16:12:13] (03CR) 10Anomie: "Looks like this patch is very close to being good. (:" (034 comments) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/543853 (https://phabricator.wikimedia.org/T229505) (owner: 10ItSpiderman) [16:12:47] (03CR) 10jerkins-bot: [V: 04-1] Convert callback to use ExtensionFunctions [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/547564 (https://phabricator.wikimedia.org/T237032) (owner: 10Paladox) [16:16:21] (03CR) 10Aezell: [C: 03+1] Set block parameters on GlobalBlock object to fix error message [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/547346 (https://phabricator.wikimedia.org/T233996) (owner: 10Tchanders) [16:17:18] (03CR) 10Paladox: Convert callback to use ExtensionFunctions (031 comment) [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/547564 (https://phabricator.wikimedia.org/T237032) (owner: 10Paladox) [16:25:12] (03PS1) 10Pcoombe: Remove France fundraising banners from portal [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/547570 (https://phabricator.wikimedia.org/T234466) [16:25:35] (03PS1) 10Mholloway: Add the apps-suggested-edits tag to edits made through the feature [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/547571 [16:35:13] (03CR) 10Fomafix: "The type hint `string` is supported since PHP 7.0 (https://www.php.net/manual/en/functions.arguments.php#functions.arguments.type-declarat" [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/547260 (owner: 10Fomafix) [16:37:56] (03PS3) 10Mholloway: [DNM] Various performance review tweaks and comments [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/546141 (https://phabricator.wikimedia.org/T230813) (owner: 10Aaron Schulz) [16:38:24] (03CR) 10Mholloway: "Rebased, will address comments in revisions to follow." [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/546141 (https://phabricator.wikimedia.org/T230813) (owner: 10Aaron Schulz) [16:42:46] (03CR) 10Alex Paskulin: [C: 03+1] "This looks good to me. We can always re-enable these settings locally if we want to see these warnings. Interestingly, according to the Do" [core] - 10https://gerrit.wikimedia.org/r/547036 (owner: 10Krinkle) [16:49:29] (03PS3) 10MarcoAurelio: initial commit [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547554 (owner: 10Freephile) [16:49:45] (03PS1) 10DCausse: Don't use ::role::eventbus::enable_eventgate from cirrussearch [vagrant] - 10https://gerrit.wikimedia.org/r/547575 [16:50:59] (03PS2) 10Mholloway: Add the apps-suggested-edits tag to edits made through the feature [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/547571 [16:51:14] (03CR) 10Daimona Eaytoy: "@SBassett could you please take a look at this one, too?" [extensions/AbuseFilter] (REL1_33) - 10https://gerrit.wikimedia.org/r/546881 (owner: 10Daimona Eaytoy) [16:54:18] (03PS3) 10Mholloway: Add the apps-suggested-edits tag to edits made through the feature [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/547571 [16:55:13] (03CR) 10Nikerabbit: "I just noticed ULSMessageLoader does not extend any class, so it cannot break anything." [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/547260 (owner: 10Fomafix) [16:55:18] (03CR) 10MarcoAurelio: [C: 03+2] initial commit [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547554 (owner: 10Freephile) [17:00:47] (03Merged) 10jenkins-bot: initial commit [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547554 (owner: 10Freephile) [17:01:50] (03CR) 10Fomafix: "See the Jenkins for PS1 without this dependency. https://integration.wikimedia.org/ci/job/wmf-quibble-core-vendor-mysql-php72-docker/9415/" [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/547260 (owner: 10Fomafix) [17:04:11] (03PS1) 10Urbanecm: Support wmcz-new-id in list news module [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547577 [17:04:13] (03PS1) 10Urbanecm: Indent [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547578 [17:04:15] (03PS1) 10Urbanecm: Create table for tags [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547579 [17:04:17] (03CR) 10Urbanecm: [C: 03+2] Support wmcz-new-id in list news module [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547577 (owner: 10Urbanecm) [17:04:22] (03CR) 10Urbanecm: [C: 03+2] Indent [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547578 (owner: 10Urbanecm) [17:04:26] (03CR) 10Urbanecm: [C: 03+2] Create table for tags [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547579 (owner: 10Urbanecm) [17:04:42] (03Merged) 10jenkins-bot: Support wmcz-new-id in list news module [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547577 (owner: 10Urbanecm) [17:04:48] (03Merged) 10jenkins-bot: Indent [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547578 (owner: 10Urbanecm) [17:04:50] (03Merged) 10jenkins-bot: Create table for tags [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547579 (owner: 10Urbanecm) [17:05:45] 10MediaWiki-General, 10Core Platform Team, 10CPT Initiatives (API Integration Tests), 10Code-Health: Create a suite of end-to-end API test for MediaWiki core - https://phabricator.wikimedia.org/T219873 (10CCicalese_WMF) [17:05:48] 10CPT Initiatives (Core REST API in PHP): Testing for Core REST API - https://phabricator.wikimedia.org/T234995 (10WDoranWMF) [17:06:48] (03PS1) 10Pwirth: Add phpcs. ERM:16866 [extensions/BlueSpiceReminder] - 10https://gerrit.wikimedia.org/r/547580 [17:07:07] 10MobileFrontend, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2), 10Regression: Regression: Scroll position lost when closing reference preview - https://phabricator.wikimedia.org/T237015 (10Jdlrobson) [17:08:09] (03Merged) 10jenkins-bot: SECURITY: Check visibility for each version in ViewDiff [extensions/AbuseFilter] (REL1_33) - 10https://gerrit.wikimedia.org/r/546881 (owner: 10Daimona Eaytoy) [17:14:29] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Note this is technically a breaking change, because these methods throw a very different exception now." [core] - 10https://gerrit.wikimedia.org/r/547074 (owner: 10Fomafix) [17:15:37] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Where do these warnings surface?" [core] - 10https://gerrit.wikimedia.org/r/547036 (owner: 10Krinkle) [17:18:29] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] Count edit conflicts combined with user edits [core] - 10https://gerrit.wikimedia.org/r/547531 (https://phabricator.wikimedia.org/T236886) (owner: 10WMDE-Fisch) [17:18:36] (03CR) 10jerkins-bot: [V: 04-1] Add the apps-suggested-edits tag to edits made through the feature [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/547571 (owner: 10Mholloway) [17:20:01] (03PS4) 10Mholloway: Add the apps-suggested-edits tag to edits made through the feature [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/547571 [17:20:06] (03PS21) 10EBernhardson: Perform model upload from bulk daemon [search/MjoLniR] - 10https://gerrit.wikimedia.org/r/535732 [17:20:15] (03CR) 10Tpt: "Thank you! I just have a (maybe dumb) question" (031 comment) [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/539689 (https://phabricator.wikimedia.org/T60062) (owner: 10Jon Harald Søby) [17:22:45] (03CR) 10jerkins-bot: [V: 04-1] Perform model upload from bulk daemon [search/MjoLniR] - 10https://gerrit.wikimedia.org/r/535732 (owner: 10EBernhardson) [17:25:28] (03PS22) 10EBernhardson: Perform model upload from bulk daemon [search/MjoLniR] - 10https://gerrit.wikimedia.org/r/535732 [17:26:05] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Patch-For-Review, 10good first bug: Add monolingual language code "sa-Sidd" and "pi-Sidd" - https://phabricator.wikimedia.org/T230881 (10Mbch331) [17:26:41] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Patch-For-Review: Add monolingual language code bdr - https://phabricator.wikimedia.org/T234330 (10Mbch331) [17:28:26] 10MediaWiki-extensions-GettingStarted, 10Growth-Team: Make Getting Started temporarily suppress the VE dialog by adding "vehidebetadialog" to the query string - https://phabricator.wikimedia.org/T235812 (10phuedx) >>! In T235812#5623776, @marcella wrote: > @phuedx could you clarify what your concerns about thi... [17:30:05] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: Wikimedia Technical Conference 2019 Session: Front-end modernization and standardization - https://phabricator.wikimedia.org/T234649 (10Mooeypoo) [17:30:56] 10MediaWiki-ResourceLoader, 10Performance-Team: ResourceLoader replaces "true" to "0" and causes "SyntaxError: identifier starts immediately after numeric literal" - https://phabricator.wikimedia.org/T237042 (10Bugreporter) [17:36:29] 10Wikidata-Tainted-References-Sprint4: Fix TaintedIcon alignment style - https://phabricator.wikimedia.org/T236890 (10Tarrow) I turned out something like this: {F30938321} by messing with wikibase styles and removing the top padding from the open/close link [17:36:30] 10MediaWiki-ResourceLoader, 10Performance-Team: ResourceLoader replaces "true" to "!0" and causes "SyntaxError: identifier starts immediately after numeric literal" - https://phabricator.wikimedia.org/T237042 (10matmarex) [17:36:48] 10MediaWiki-ResourceLoader, 10Performance-Team: ResourceLoader replaces "true" to "!0" and causes "SyntaxError: identifier starts immediately after numeric literal" - https://phabricator.wikimedia.org/T237042 (10Lucas_Werkmeister_WMDE) Likewise, `false` turns into `!0`, and `!0.toString()` is also a syntax error. [17:37:17] 10MediaWiki-extensions-WikimediaMaintenance, 10phan: Add phan to WikimediaMaintenance extension - https://phabricator.wikimedia.org/T224770 (10Umherirrender) 05Open→03Resolved [17:37:40] 10Wikimedia-Portals: Update Module:Project portal/views.json - https://phabricator.wikimedia.org/T235965 (10MarcoAurelio) >>! In T235965#5624040, @Pcoombe wrote: > @MarcoAurelio I ran into the same problem with primordials today. You need to use node v11.15.0, I used the "n" solution here to get it: https://stac... [17:38:15] 10MediaWiki-extensions-General, 10Continuous-Integration-Config: Add phan to MediaWiki extensions and skins for static analysis [cloneable] - https://phabricator.wikimedia.org/T179554 (10Umherirrender) [17:38:36] 10MediaWiki-REST-API, 10wikidiff2, 10CPT Initiatives (Core REST API in PHP), 10Core Platform Team Workboards (Green): Deploy latest version of wikidiff2 to production - https://phabricator.wikimedia.org/T236963 (10eprodromou) @Tsevener we're working to get review on the patch. [17:40:19] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Patch-For-Review: Add monolingual language code tnq (Taíno) and car (Kalinago) - https://phabricator.wikimedia.org/T220284 (10Mbch331) a:03Mbch331 [17:41:50] (03PS3) 10Jdlrobson: WIP: Inline diffs in core [core] - 10https://gerrit.wikimedia.org/r/547057 [17:41:52] (03PS1) 10Jdlrobson: Separate header generation from diff generation [core] - 10https://gerrit.wikimedia.org/r/547594 (https://phabricator.wikimedia.org/T117279) [17:42:09] (03PS1) 10MarcoAurelio: Add a basic .gitignore file [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547595 [17:42:32] (03PS2) 10MarcoAurelio: Add a basic .gitignore file [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547595 [17:42:37] (03PS4) 10Jdlrobson: WIP: Inline diffs in core [core] - 10https://gerrit.wikimedia.org/r/547057 [17:43:36] (03PS5) 10Jdlrobson: WIP: Inline diffs in core [core] - 10https://gerrit.wikimedia.org/r/547057 [17:46:25] (03CR) 10Krinkle: "When running maintenance/mwdocgen.php, and in the output for https://integration.wikimedia.org/ci/job/mediawiki-core-doxygen-docker/" [core] - 10https://gerrit.wikimedia.org/r/547036 (owner: 10Krinkle) [17:46:56] (03PS6) 10Jdlrobson: WIP: Inline diffs in core [core] - 10https://gerrit.wikimedia.org/r/547057 [17:48:06] (03PS7) 10Jdlrobson: WIP: Inline diffs in core [core] - 10https://gerrit.wikimedia.org/r/547057 [17:48:14] 10MediaWiki-ResourceLoader, 10Performance-Team: ResourceLoader replaces "true" to "!0" and causes "SyntaxError: identifier starts immediately after numeric literal" - https://phabricator.wikimedia.org/T237042 (10Lucas_Werkmeister_WMDE) Short reproducer: ` $ php maintenance/eval.php <<< "echo JavaScriptMinifie... [17:49:02] (03PS8) 10Jdlrobson: WIP: Inline diffs in core [core] - 10https://gerrit.wikimedia.org/r/547057 [17:49:18] (03PS3) 10MarcoAurelio: Add a basic .gitignore file [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547595 [17:49:43] (03PS9) 10Jdlrobson: WIP: Inline diffs in core [core] - 10https://gerrit.wikimedia.org/r/547057 [17:50:10] (03PS1) 10MarcoAurelio: Remove duplicate COPYING file [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547601 [17:50:24] (03PS2) 10MarcoAurelio: Remove duplicate COPYING file [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547601 [17:50:48] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Performance-Team (Radar): Wikibase: Batch HTMLCacheUpdateJobs across changes - https://phabricator.wikimedia.org/T178806 (10Krinkle) [17:54:56] (03PS4) 10Mholloway: [DNM] Various performance review tweaks and comments [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/546141 (https://phabricator.wikimedia.org/T230813) (owner: 10Aaron Schulz) [17:55:57] 10CPT Initiatives (Core REST API in PHP), 10Core Platform Team Workboards (User Stories), 10Story: API developer creates automated documentation - https://phabricator.wikimedia.org/T236113 (10apaskulin) Always happy to discuss this! Here are my notes: ### Endpoint elements **Name** Example: Get page histor... [17:57:56] (03CR) 10jerkins-bot: [V: 04-1] Separate header generation from diff generation [core] - 10https://gerrit.wikimedia.org/r/547594 (https://phabricator.wikimedia.org/T117279) (owner: 10Jdlrobson) [17:59:27] (03CR) 10Anomie: [C: 03+2] auth: Set constant visibility [core] - 10https://gerrit.wikimedia.org/r/547375 (owner: 10MaxSem) [17:59:47] (03CR) 10Dmaza: Remove commented out code from PermissionManagerTest (032 comments) [core] - 10https://gerrit.wikimedia.org/r/547513 (owner: 10Dmaza) [18:00:36] (03PS1) 10Urbanecm: Add tag management interface [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547608 [18:00:38] (03PS1) 10Urbanecm: Allow users to delete tags [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547609 [18:00:40] (03PS1) 10Urbanecm: Allow users to delete news [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547610 [18:00:42] (03PS1) 10Urbanecm: Better interface for new management [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547611 [18:00:44] (03PS1) 10Urbanecm: Standardize interfaces for management [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547612 [18:00:47] (03PS1) 10Urbanecm: Add tags into news management [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547613 [18:03:48] (03CR) 10jerkins-bot: [V: 04-1] WIP: Inline diffs in core [core] - 10https://gerrit.wikimedia.org/r/547057 (owner: 10Jdlrobson) [18:03:55] (03PS7) 10Alex Paskulin: docs: Convert class-level documentation files to Markdown [core] - 10https://gerrit.wikimedia.org/r/539439 (https://phabricator.wikimedia.org/T87796) [18:05:04] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/547604 (owner: 10L10n-bot) [18:05:08] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/547605 (owner: 10L10n-bot) [18:05:20] 10MediaWiki-REST-API, 10CPT Initiatives (Core REST API in PHP), 10Core Platform Team Workboards (Green): Keep edit counts in separate database table and update on edit - https://phabricator.wikimedia.org/T237043 (10eprodromou) [18:05:21] (03CR) 10Alex Paskulin: "Updated the syntax of the exclude pattern in the Doxyfile, and it now works correctly in my local setup." [core] - 10https://gerrit.wikimedia.org/r/539439 (https://phabricator.wikimedia.org/T87796) (owner: 10Alex Paskulin) [18:05:24] (03CR) 10Sharvaniharan: [C: 03+1] Add the apps-suggested-edits tag to edits made through the feature (031 comment) [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/547571 (owner: 10Mholloway) [18:06:10] (03PS2) 10Umherirrender: Add public visibility to some language function [core] - 10https://gerrit.wikimedia.org/r/542536 [18:06:41] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [wikimedia/iegreview] - 10https://gerrit.wikimedia.org/r/547604 (owner: 10L10n-bot) [18:07:07] (03CR) 10Umherirrender: "Rebased" [core] - 10https://gerrit.wikimedia.org/r/542536 (owner: 10Umherirrender) [18:07:17] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/547605 (owner: 10L10n-bot) [18:09:15] 10MediaWiki-REST-API, 10CPT Initiatives (Core REST API in PHP), 10Core Platform Team Workboards (Green): Pass section headers to wikidiff2 to get section header diffs - https://phabricator.wikimedia.org/T236964 (10eprodromou) @Tsevener I think we'll need some help understanding exactly what data needs to be... [18:10:16] (03PS5) 10Umherirrender: Allow to inject PermissionManager into SpecialPage [core] - 10https://gerrit.wikimedia.org/r/541863 [18:10:19] 10MediaWiki-Change-tagging, 10MediaWiki-User-management, 10Anti-Harassment: When sitewide blocked, cannot edit tags on own User_talk, even if allowed to edit own User_talk - https://phabricator.wikimedia.org/T236996 (10Niharika) [18:10:33] (03CR) 10Umherirrender: "Rebased" [core] - 10https://gerrit.wikimedia.org/r/541863 (owner: 10Umherirrender) [18:10:45] (03Merged) 10jenkins-bot: auth: Set constant visibility [core] - 10https://gerrit.wikimedia.org/r/547375 (owner: 10MaxSem) [18:13:55] (03CR) 10jerkins-bot: [V: 04-1] docs: Convert class-level documentation files to Markdown [core] - 10https://gerrit.wikimedia.org/r/539439 (https://phabricator.wikimedia.org/T87796) (owner: 10Alex Paskulin) [18:16:55] (03PS5) 10Mholloway: [DNM] Various performance review tweaks and comments [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/546141 (https://phabricator.wikimedia.org/T230813) (owner: 10Aaron Schulz) [18:18:09] (03PS2) 10Umherirrender: Remove duplicate private property from NotificationDeleteJob [extensions/Echo] - 10https://gerrit.wikimedia.org/r/514515 (owner: 10Thiemo Kreuz (WMDE)) [18:18:12] (03CR) 10Umherirrender: [C: 03+2] Remove duplicate private property from NotificationDeleteJob [extensions/Echo] - 10https://gerrit.wikimedia.org/r/514515 (owner: 10Thiemo Kreuz (WMDE)) [18:18:14] (03CR) 10jerkins-bot: [V: 04-1] [DNM] Various performance review tweaks and comments [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/546141 (https://phabricator.wikimedia.org/T230813) (owner: 10Aaron Schulz) [18:19:53] (03CR) 10Anomie: [C: 03+2] Hard deprecate User::isEveryoneAllowed [core] - 10https://gerrit.wikimedia.org/r/547064 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [18:20:17] (03PS4) 10Nikki Nikkhoui: Alert user to create local config file if non-existent [tools/api-testing] - 10https://gerrit.wikimedia.org/r/547321 (https://phabricator.wikimedia.org/T236521) [18:20:54] (03CR) 10Nikki Nikkhoui: Alert user to create local config file if non-existent (034 comments) [tools/api-testing] - 10https://gerrit.wikimedia.org/r/547321 (https://phabricator.wikimedia.org/T236521) (owner: 10Nikki Nikkhoui) [18:22:37] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2019-October-December), 10Patch-For-Review: Paginate group getting through Translate API for performance purposes - https://phabricator.wikimedia.org/T236904 (10Nikerabbit) a:03Nikerabbit [18:22:47] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2019-October-December), 10Patch-For-Review, 10Unplanned-Sprint-Work: Paginate group getting through Translate API for performance purposes - https://phabricator.wikimedia.org/T236904 (10Nikerabbit) [18:23:31] (03CR) 10Nikki Nikkhoui: Alert user to create local config file if non-existent (031 comment) [tools/api-testing] - 10https://gerrit.wikimedia.org/r/547321 (https://phabricator.wikimedia.org/T236521) (owner: 10Nikki Nikkhoui) [18:25:22] (03CR) 10Ppchelko: "> Patch Set 4:" (031 comment) [tools/api-testing] - 10https://gerrit.wikimedia.org/r/547321 (https://phabricator.wikimedia.org/T236521) (owner: 10Nikki Nikkhoui) [18:27:29] 10CPT Initiatives (Core REST API in PHP), 10Core Platform Team Workboards (User Stories), 10Story: Reader searches for a topic - https://phabricator.wikimedia.org/T230844 (10nnikkhoui) a:05eprodromou→03nnikkhoui [18:30:18] (03PS11) 10Umherirrender: Show edit links in Special:DisambiguationPageLinks only if user can edit [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/463679 (https://phabricator.wikimedia.org/T205796) (owner: 10Urbanecm) [18:30:21] (03CR) 10Umherirrender: [C: 03+2] Show edit links in Special:DisambiguationPageLinks only if user can edit [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/463679 (https://phabricator.wikimedia.org/T205796) (owner: 10Urbanecm) [18:30:37] (03Merged) 10jenkins-bot: Remove duplicate private property from NotificationDeleteJob [extensions/Echo] - 10https://gerrit.wikimedia.org/r/514515 (owner: 10Thiemo Kreuz (WMDE)) [18:31:08] 10MediaWiki-extensions-Disambiguator, 10Patch-For-Review, 10good first bug: Edit links in Special:DisambiguationPageLinks should only be shown if user can edit - https://phabricator.wikimedia.org/T205796 (10Umherirrender) 05Open→03Resolved a:03Urbanecm [18:32:40] (03Merged) 10jenkins-bot: Hard deprecate User::isEveryoneAllowed [core] - 10https://gerrit.wikimedia.org/r/547064 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [18:34:18] 10WMSE-Magnus Sälgö: Ask the Swedish National Archives to deliver some usable metadata - https://phabricator.wikimedia.org/T236883 (10Salgo60) [18:35:32] (03Merged) 10jenkins-bot: Show edit links in Special:DisambiguationPageLinks only if user can edit [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/463679 (https://phabricator.wikimedia.org/T205796) (owner: 10Urbanecm) [18:38:15] 10WMSE-Magnus Sälgö: Ask the Swedish National Archives to deliver some usable metadata - https://phabricator.wikimedia.org/T236883 (10Salgo60) [18:38:38] 10GrowthExperiments, 10Growth-Team (Current Sprint): Get task types and their difficulties from the tasktypes API instead of hardcoding them in JS - https://phabricator.wikimedia.org/T236805 (10Tgr) [18:39:05] 10Gerrit-Privilege-Requests: +2 for NavinoEvans on labs/tools/awmd-stats.git - https://phabricator.wikimedia.org/T236088 (10MarcoAurelio) @samuelguebo or @D3r1ck01 are the only ones that can add you at https://gerrit.wikimedia.org/r/#/admin/groups/1506,members so pinging them here for action. [18:39:08] 10netbox: read-only user netbox permissions regression - https://phabricator.wikimedia.org/T229710 (10bd808) Seems to be caused by https://netbox.readthedocs.io/en/stable/release-notes/version-2.6/#view-permissions-323 [18:39:16] 10GrowthExperiments, 10Growth-Team (Current Sprint): Get task types and their difficulties from the tasktypes API instead of hardcoding them in JS - https://phabricator.wikimedia.org/T236805 (10Tgr) a:05Tgr→03None Moving back to ready for development for the frontend part. [18:40:31] (03CR) 10Jon Harald Søby: ">" (031 comment) [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/539689 (https://phabricator.wikimedia.org/T60062) (owner: 10Jon Harald Søby) [18:40:48] 10Gerrit-Privilege-Requests: +2 for NavinoEvans on labs/tools/lsa.git - https://phabricator.wikimedia.org/T230647 (10MarcoAurelio) Only @Eugene233 can action this request per https://gerrit.wikimedia.org/r/#/admin/groups/1604,members. [18:41:12] (03CR) 10Freephile: [C: 03+2] Add a basic .gitignore file [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547595 (owner: 10MarcoAurelio) [18:41:32] 10Epic, 10Product-Analytics (Kanban), 10VisualEditor (Current work): QA new bucketing patch - https://phabricator.wikimedia.org/T236338 (10ppelberg) >>! In T236338#5613269, @ppelberg wrote: > Quick update: this patch should be ready for QA this Thursday, 31-October. Correction: this patch will be ready for... [18:41:39] 10ArticleRatings, 10ci-test-error: quibble-vendor-mysql-php72-docker for ArticleRatings failing - https://phabricator.wikimedia.org/T236494 (10Daimona) >Maybe these lines are the relevants: > >14:40:23 Syncing... >14:40:24 rsync: failed to set times on "/cache/.": Operation not permitted (1) >14:40:44 rsync er... [18:45:00] (03CR) 10Mholloway: Add the apps-suggested-edits tag to edits made through the feature (031 comment) [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/547571 (owner: 10Mholloway) [18:46:21] (03Merged) 10jenkins-bot: Add a basic .gitignore file [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547595 (owner: 10MarcoAurelio) [18:48:16] 10Editing Design, 10Patch-For-Review, 10VisualEditor (Current work): Mobile VE toolbar doesn't stay onscreen on iOS 13 when keyboard is open - https://phabricator.wikimedia.org/T233470 (10matmarex) >>! In T233470#5622004, @matmarex wrote: > Anyway, I changed some things, and it helped a bit (with this patch,... [18:49:32] 10Editing Design, 10Patch-For-Review, 10VisualEditor (Current work): Mobile VE toolbar doesn't stay onscreen on iOS 13 when keyboard is open - https://phabricator.wikimedia.org/T233470 (10matmarex) Also, someone should test on iOS 12 and verify that the changes I made here don't cause anything crazy to happen. [18:51:13] 10Product-Analytics, 10Performance-Team (Radar): Create a dashboard of key user-centric metrics - https://phabricator.wikimedia.org/T99060 (10Krinkle) @Neil_P._Quinn_WMF There are ideas in this task that the Performance Team was thinking would be useful to track and correlate with Web Performance metrics. For... [18:51:17] 10MediaWiki-extensions-Translate, 10translatewiki.net, 10Language-Team (Language-2019-October-December): MessageIndex is not updated after running autoimport - https://phabricator.wikimedia.org/T224112 (10Nikerabbit) a:03Nikerabbit The code properly inserts `MessageIndexRebuildJob`. I started thinking what... [18:53:36] (03CR) 10Anomie: "> Thank you for the review! It's a WIP and I didn't wanna assign you yet, but reviewer-bot had it's own opinion.. Sorry if it felt prematu" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/545690 (https://phabricator.wikimedia.org/T234921) (owner: 10Ppchelko) [18:57:09] (03CR) 10Jforrester: "recheck" [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/546161 (owner: 10Reedy) [18:57:18] 10AbuseFilter, 10Patch-For-Review: Array appending causes a crash - https://phabricator.wikimedia.org/T236870 (10Nullzero) > Actually, it should stay in that directory, which contains *everything* related to parsing (e.g. also data types, parsing exceptions etc.) To be picky, the precise meaning for parsing (... [18:59:26] (03PS1) 10Jdlrobson: Hygiene: transparent-shield is an unused class [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/547622 [18:59:28] (03PS1) 10Jdlrobson: Do not jump to the top of the page when the reference drawer is closed [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/547623 (https://phabricator.wikimedia.org/T237015) [18:59:52] (03CR) 10jerkins-bot: [V: 04-1] Hygiene: transparent-shield is an unused class [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/547622 (owner: 10Jdlrobson) [18:59:54] (03CR) 10Urbanecm: [C: 03+2] Add tag management interface [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547608 (owner: 10Urbanecm) [18:59:58] (03CR) 10Urbanecm: [C: 03+2] Allow users to delete tags [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547609 (owner: 10Urbanecm) [19:00:01] (03CR) 10jerkins-bot: [V: 04-1] Do not jump to the top of the page when the reference drawer is closed [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/547623 (https://phabricator.wikimedia.org/T237015) (owner: 10Jdlrobson) [19:00:03] (03CR) 10Urbanecm: [C: 03+2] Allow users to delete news [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547610 (owner: 10Urbanecm) [19:00:07] (03CR) 10Urbanecm: [C: 03+2] Better interface for new management [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547611 (owner: 10Urbanecm) [19:00:12] (03CR) 10Urbanecm: [C: 03+2] Standardize interfaces for management [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547612 (owner: 10Urbanecm) [19:00:17] (03CR) 10Urbanecm: [C: 03+2] Add tags into news management [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547613 (owner: 10Urbanecm) [19:00:19] (03Merged) 10jenkins-bot: Add tag management interface [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547608 (owner: 10Urbanecm) [19:00:24] (03Merged) 10jenkins-bot: Allow users to delete tags [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547609 (owner: 10Urbanecm) [19:00:26] (03Merged) 10jenkins-bot: Allow users to delete news [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547610 (owner: 10Urbanecm) [19:00:30] (03Merged) 10jenkins-bot: Better interface for new management [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547611 (owner: 10Urbanecm) [19:00:32] (03Merged) 10jenkins-bot: Standardize interfaces for management [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547612 (owner: 10Urbanecm) [19:00:38] (03Merged) 10jenkins-bot: Add tags into news management [wikimedia-cz/web-plugin] - 10https://gerrit.wikimedia.org/r/547613 (owner: 10Urbanecm) [19:01:07] (03PS2) 10Jdlrobson: Hygiene: transparent-shield is an unused class [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/547622 [19:01:09] (03PS2) 10Jdlrobson: Do not jump to the top of the page when the reference drawer is closed [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/547623 (https://phabricator.wikimedia.org/T237015) [19:01:11] (03PS20) 10Jdlrobson: Main menu works without JavaScript using `:target` selector [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/539974 (https://phabricator.wikimedia.org/T147893) [19:01:13] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Use type hints for TypeError exception [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/547260 (owner: 10Fomafix) [19:02:12] (03PS1) 10MarcoAurelio: build: Add mediawiki/mediawiki-codesniffer [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547624 [19:02:14] (03PS1) 10MarcoAurelio: Autofixing Generic.Arrays.DisallowLongArraySyntax.Found errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547625 [19:02:16] (03PS1) 10MarcoAurelio: Autofixing Generic.Files.LineEndings.InvalidEOLChar errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547626 [19:02:18] (03PS1) 10MarcoAurelio: Autofixing Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547627 [19:02:20] (03PS1) 10MarcoAurelio: Autofixing MediaWiki.WhiteSpace.* errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547628 [19:02:22] (03PS1) 10MarcoAurelio: Autofixing PSR2.Files.EndFileNewline.NoneFound errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547629 [19:02:24] (03PS1) 10MarcoAurelio: Autofixing PSR2.Methods.FunctionClosingBrace.SpacingBeforeClose errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547630 [19:02:26] (03PS1) 10MarcoAurelio: Autofixing Squiz.Classes.SelfMemberReference.NotUsed errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547631 [19:02:28] (03PS1) 10MarcoAurelio: Autofixing Squiz.Functions.* errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547632 [19:02:32] (03PS1) 10MarcoAurelio: Autofixing Squiz.WhiteSpace.SuperfluousWhitespace.EndLine errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547633 [19:02:36] 10CPT Initiatives (Core REST API in PHP), 10Core Platform Team Workboards (User Stories), 10Story: Reader searches for a topic - https://phabricator.wikimedia.org/T230844 (10Pchelolo) > Let's start with the snippet that appears on the Web UI for search results. :) Replicating this would be quite [[ https://... [19:02:51] 10MediaWiki-Special-pages, 10UI-Standardization, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2), 10UI-Standardization-Kanban: Special:Contributions – add 'pinning' functionality to collapsible form? - https://phabricator.wikimedia.org/T234569 (10Jdlrobson) a:05ovasileva→03Volker_E Any mocks for how the p... [19:04:04] 10AbuseFilter, 10Patch-For-Review: Array appending causes a crash - https://phabricator.wikimedia.org/T236870 (10Daimona) >>! In T236870#5624414, @Nullzero wrote: >> Actually, it should stay in that directory, which contains *everything* related to parsing (e.g. also data types, parsing exceptions etc.) > > T... [19:04:46] (03CR) 10Jforrester: "recheck" [vendor] - 10https://gerrit.wikimedia.org/r/547215 (owner: 10Reedy) [19:07:21] (03PS2) 10Jforrester: Add vendor libraries for WebAuthn [vendor] - 10https://gerrit.wikimedia.org/r/547215 (owner: 10Reedy) [19:10:56] (03CR) 10Jforrester: [C: 03+2] build: Add mediawiki/mediawiki-codesniffer [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547624 (owner: 10MarcoAurelio) [19:11:11] (03CR) 10Jforrester: [C: 03+2] Autofixing Generic.Arrays.DisallowLongArraySyntax.Found errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547625 (owner: 10MarcoAurelio) [19:11:21] (03CR) 10Jforrester: [C: 03+2] Autofixing Generic.Files.LineEndings.InvalidEOLChar errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547626 (owner: 10MarcoAurelio) [19:11:32] (03CR) 10jerkins-bot: [V: 04-1] Hygiene: transparent-shield is an unused class [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/547622 (owner: 10Jdlrobson) [19:11:35] (03CR) 10Jforrester: [C: 03+2] Autofixing Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547627 (owner: 10MarcoAurelio) [19:11:42] (03CR) 10Jforrester: [C: 03+2] Autofixing MediaWiki.WhiteSpace.* errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547628 (owner: 10MarcoAurelio) [19:11:50] (03CR) 10Jforrester: [C: 03+2] Autofixing PSR2.Files.EndFileNewline.NoneFound errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547629 (owner: 10MarcoAurelio) [19:11:56] (03CR) 10Jforrester: [C: 03+2] Autofixing PSR2.Methods.FunctionClosingBrace.SpacingBeforeClose errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547630 (owner: 10MarcoAurelio) [19:12:07] (03CR) 10Jforrester: [C: 03+2] Autofixing Squiz.Classes.SelfMemberReference.NotUsed errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547631 (owner: 10MarcoAurelio) [19:12:10] (03Merged) 10jenkins-bot: Use type hints for TypeError exception [extensions/UniversalLanguageSelector] - 10https://gerrit.wikimedia.org/r/547260 (owner: 10Fomafix) [19:12:13] (03CR) 10Jforrester: [C: 03+2] Autofixing Squiz.Functions.* errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547632 (owner: 10MarcoAurelio) [19:12:20] (03CR) 10Jforrester: [C: 03+2] Autofixing Squiz.WhiteSpace.SuperfluousWhitespace.EndLine errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547633 (owner: 10MarcoAurelio) [19:12:42] (03CR) 10Jforrester: [C: 03+2] Remove duplicate COPYING file [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547601 (owner: 10MarcoAurelio) [19:13:11] (03CR) 10Thiemo Kreuz (WMDE): "Looks like these are two different versions. This patch happens to keep the one that does *not* match the license named in extension.json." (033 comments) [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547601 (owner: 10MarcoAurelio) [19:13:27] (03Merged) 10jenkins-bot: build: Add mediawiki/mediawiki-codesniffer [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547624 (owner: 10MarcoAurelio) [19:13:45] (03CR) 10Anomie: Do not insert page titles into querycache.qc_value (031 comment) [core] - 10https://gerrit.wikimedia.org/r/419441 (https://phabricator.wikimedia.org/T181658) (owner: 10TK-999) [19:14:08] (03Merged) 10jenkins-bot: Autofixing Generic.Arrays.DisallowLongArraySyntax.Found errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547625 (owner: 10MarcoAurelio) [19:14:21] (03Merged) 10jenkins-bot: Autofixing Generic.Files.LineEndings.InvalidEOLChar errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547626 (owner: 10MarcoAurelio) [19:14:31] (03CR) 10jerkins-bot: [V: 04-1] Do not jump to the top of the page when the reference drawer is closed [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/547623 (https://phabricator.wikimedia.org/T237015) (owner: 10Jdlrobson) [19:14:33] (03PS2) 10Thiemo Kreuz (WMDE): Autofixing Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547627 (owner: 10MarcoAurelio) [19:14:41] (03CR) 10jerkins-bot: [V: 04-1] Autofixing MediaWiki.WhiteSpace.* errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547628 (owner: 10MarcoAurelio) [19:14:43] (03CR) 10jerkins-bot: [V: 04-1] Autofixing PSR2.Files.EndFileNewline.NoneFound errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547629 (owner: 10MarcoAurelio) [19:14:45] (03CR) 10jerkins-bot: [V: 04-1] Autofixing PSR2.Methods.FunctionClosingBrace.SpacingBeforeClose errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547630 (owner: 10MarcoAurelio) [19:14:47] (03CR) 10jerkins-bot: [V: 04-1] Autofixing Squiz.Classes.SelfMemberReference.NotUsed errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547631 (owner: 10MarcoAurelio) [19:14:49] (03CR) 10jerkins-bot: [V: 04-1] Autofixing Squiz.Functions.* errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547632 (owner: 10MarcoAurelio) [19:14:51] (03CR) 10jerkins-bot: [V: 04-1] Autofixing Squiz.WhiteSpace.SuperfluousWhitespace.EndLine errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547633 (owner: 10MarcoAurelio) [19:15:07] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] "That auto-fix was weird, leaving a strange mixture of tabs and spaces behind. I ended fixing the entire file. It's very short." [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547627 (owner: 10MarcoAurelio) [19:15:46] (03CR) 10Jforrester: "> Patch Set 2: Code-Review+2" [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547627 (owner: 10MarcoAurelio) [19:17:44] (03Merged) 10jenkins-bot: Remove duplicate COPYING file [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547601 (owner: 10MarcoAurelio) [19:18:27] (03Merged) 10jenkins-bot: Autofixing Generic.WhiteSpace.DisallowSpaceIndent.SpacesUsed errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547627 (owner: 10MarcoAurelio) [19:19:51] (03CR) 10jerkins-bot: [V: 04-1] Add vendor libraries for WebAuthn [vendor] - 10https://gerrit.wikimedia.org/r/547215 (owner: 10Reedy) [19:20:37] (03PS2) 10Thiemo Kreuz (WMDE): Autofixing MediaWiki.WhiteSpace.* errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547628 (owner: 10MarcoAurelio) [19:21:06] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] "Rebased." [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547628 (owner: 10MarcoAurelio) [19:21:18] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Autofixing PSR2.Files.EndFileNewline.NoneFound errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547629 (owner: 10MarcoAurelio) [19:21:31] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Autofixing PSR2.Methods.FunctionClosingBrace.SpacingBeforeClose errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547630 (owner: 10MarcoAurelio) [19:21:38] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Autofixing Squiz.Classes.SelfMemberReference.NotUsed errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547631 (owner: 10MarcoAurelio) [19:21:43] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Autofixing Squiz.Functions.* errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547632 (owner: 10MarcoAurelio) [19:21:48] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Autofixing Squiz.WhiteSpace.SuperfluousWhitespace.EndLine errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547633 (owner: 10MarcoAurelio) [19:22:01] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Patch-For-Review, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Add monolingual language code tnq (Taíno) and car (Kalinago) - https://phabricator.wikimedia.org/T220284 (10Lydia_Pintscher) [19:22:23] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Patch-For-Review, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), 10good first bug: Add monolingual language code "sa-Sidd" and "pi-Sidd" - https://phabricator.wikimedia.org/T230881 (10Lydia_Pintscher) [19:22:40] (03CR) 10Krinkle: "Looks like it hit a temporary Gerrit unavailable issue." [core] - 10https://gerrit.wikimedia.org/r/539439 (https://phabricator.wikimedia.org/T87796) (owner: 10Alex Paskulin) [19:22:43] (03CR) 10Krinkle: "recheck" [core] - 10https://gerrit.wikimedia.org/r/539439 (https://phabricator.wikimedia.org/T87796) (owner: 10Alex Paskulin) [19:22:47] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Patch-For-Review, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Add monolingual language code bdr - https://phabricator.wikimedia.org/T234330 (10Lydia_Pintscher) [19:23:10] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Autofixing Squiz.WhiteSpace.SuperfluousWhitespace.EndLine errors (032 comments) [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547633 (owner: 10MarcoAurelio) [19:23:50] (03Merged) 10jenkins-bot: Autofixing MediaWiki.WhiteSpace.* errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547628 (owner: 10MarcoAurelio) [19:24:08] (03PS21) 10Jdlrobson: Main menu works without JavaScript using `:target` selector [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/539974 (https://phabricator.wikimedia.org/T147893) [19:24:34] (03PS1) 10MarcoAurelio: Remove duplicates on composer.json [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547635 [19:25:15] (03PS2) 10MarcoAurelio: Remove duplicates on composer.json [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547635 [19:25:32] (03PS2) 10Thiemo Kreuz (WMDE): Autofixing PSR2.Files.EndFileNewline.NoneFound errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547629 (owner: 10MarcoAurelio) [19:27:21] (03PS5) 10TK-999: Do not insert page titles into querycache.qc_value [core] - 10https://gerrit.wikimedia.org/r/419441 (https://phabricator.wikimedia.org/T181658) [19:28:27] (03PS3) 10Thiemo Kreuz (WMDE): Autofixing PSR2.Files.EndFileNewline.NoneFound errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547629 (owner: 10MarcoAurelio) [19:28:29] (03PS2) 10Thiemo Kreuz (WMDE): Autofixing PSR2.Methods.FunctionClosingBrace.SpacingBeforeClose errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547630 (owner: 10MarcoAurelio) [19:28:31] (03PS2) 10Thiemo Kreuz (WMDE): Autofixing Squiz.Classes.SelfMemberReference.NotUsed errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547631 (owner: 10MarcoAurelio) [19:28:33] (03PS2) 10Thiemo Kreuz (WMDE): Autofixing Squiz.Functions.* errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547632 (owner: 10MarcoAurelio) [19:28:35] (03PS2) 10Thiemo Kreuz (WMDE): Autofixing Squiz.WhiteSpace.SuperfluousWhitespace.EndLine errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547633 (owner: 10MarcoAurelio) [19:29:09] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Autofixing Squiz.Functions.* errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547632 (owner: 10MarcoAurelio) [19:29:17] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Autofixing Squiz.Classes.SelfMemberReference.NotUsed errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547631 (owner: 10MarcoAurelio) [19:29:31] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Autofixing PSR2.Methods.FunctionClosingBrace.SpacingBeforeClose errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547630 (owner: 10MarcoAurelio) [19:29:42] (03CR) 10Sharvaniharan: [C: 03+2] Add the apps-suggested-edits tag to edits made through the feature [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/547571 (owner: 10Mholloway) [19:29:44] 10WMSE-Riksarkivet-NAD: SBL ORCID - https://phabricator.wikimedia.org/T224089 (10Salgo60) [19:29:49] 10CPT Initiatives (Core REST API in PHP), 10Core Platform Team Workboards (Green), 10MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), 10Patch-For-Review: REST: Add 'from' and 'to' parameters to historycount endpoint. - https://phabricator.wikimedia.org/T235666 (10BPirkle) Not sure if I should review https://gerri... [19:32:34] (03PS22) 10Jdlrobson: Main menu works without JavaScript using `:target` selector [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/539974 (https://phabricator.wikimedia.org/T147893) [19:33:04] (03CR) 10Jdlrobson: "recheck" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/547622 (owner: 10Jdlrobson) [19:34:02] (03CR) 10Jdlrobson: "recheck" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/547623 (https://phabricator.wikimedia.org/T237015) (owner: 10Jdlrobson) [19:34:49] (03Merged) 10jenkins-bot: Autofixing PSR2.Files.EndFileNewline.NoneFound errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547629 (owner: 10MarcoAurelio) [19:34:51] (03Merged) 10jenkins-bot: Autofixing PSR2.Methods.FunctionClosingBrace.SpacingBeforeClose errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547630 (owner: 10MarcoAurelio) [19:34:53] (03Merged) 10jenkins-bot: Autofixing Squiz.Classes.SelfMemberReference.NotUsed errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547631 (owner: 10MarcoAurelio) [19:34:55] (03Merged) 10jenkins-bot: Autofixing Squiz.Functions.* errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547632 (owner: 10MarcoAurelio) [19:35:30] 10CirrusSearch, 10Discovery-Search: Suggest multiple terms in phrase suggester - https://phabricator.wikimedia.org/T235800 (10EBernhardson) p:05Triage→03Normal [19:36:34] (03CR) 10TK-999: "> Patch Set 4:" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/419441 (https://phabricator.wikimedia.org/T181658) (owner: 10TK-999) [19:36:58] 10Outreachy (Round 19): Your first task: classify sample statements using Citation Needed Models - https://phabricator.wikimedia.org/T234519 (10Toluwani7) I want to add here if a windows user faces similar issues. I couldn't load tensorflow from requirement.txt. I had this error, "ERROR: Could not find a versi... [19:37:28] (03Merged) 10jenkins-bot: Autofixing Squiz.WhiteSpace.SuperfluousWhitespace.EndLine errors [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547633 (owner: 10MarcoAurelio) [19:38:18] (03PS1) 10Umherirrender: Do not query pageimages for special pages and not-existing titles [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/547637 [19:40:18] (03PS3) 10MarcoAurelio: Remove duplicates on composer.json [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547635 [19:41:02] (03CR) 10jerkins-bot: [V: 04-1] Do not insert page titles into querycache.qc_value [core] - 10https://gerrit.wikimedia.org/r/419441 (https://phabricator.wikimedia.org/T181658) (owner: 10TK-999) [19:41:25] (03PS1) 10Umherirrender: Run LinkBatch on special pages [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/547640 [19:42:21] (03CR) 10jerkins-bot: [V: 04-1] Do not query pageimages for special pages and not-existing titles [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/547637 (owner: 10Umherirrender) [19:43:26] (03CR) 10Jforrester: "Thank you for all your work. :-)" [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547633 (owner: 10MarcoAurelio) [19:43:28] (03PS2) 10Umherirrender: Do not query pageimages for special pages and not-existing titles [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/547637 [19:43:35] (03CR) 10Jforrester: [C: 03+2] Remove duplicates on composer.json [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547635 (owner: 10MarcoAurelio) [19:45:11] (03CR) 10TK-999: "recheck" [core] - 10https://gerrit.wikimedia.org/r/419441 (https://phabricator.wikimedia.org/T181658) (owner: 10TK-999) [19:45:34] (03CR) 10MarcoAurelio: [C: 03+2] "Re +2 after un-WIP." [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/544298 (owner: 10Duncancrane) [19:45:36] (03PS30) 10Nray: Render talk page as a tab instead of an overlay [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/540441 (https://phabricator.wikimedia.org/T230695) (owner: 10Jdlrobson) [19:45:38] (03PS19) 10Nray: Remove eventbus usage in talk.js [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/545945 (https://phabricator.wikimedia.org/T230695) [19:46:16] (03CR) 10Nray: [C: 04-1] "I still need to fix above bug/have another design review with alex" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/540441 (https://phabricator.wikimedia.org/T230695) (owner: 10Jdlrobson) [19:47:33] (03PS1) 10Tchanders: Fix block message drawer to link correctly to Special:BlockList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/547641 (https://phabricator.wikimedia.org/T225939) [19:47:33] (03CR) 10Ladsgroup: "> Patch Set 3:" [core] - 10https://gerrit.wikimedia.org/r/540585 (https://phabricator.wikimedia.org/T230419) (owner: 10Ladsgroup) [19:47:49] 10MediaWiki-General, 10MediaWiki-Page-Diffs, 10Release-Engineering-Team-TODO (201910), 10ci-test-error: DifferenceEngineTest and ApiComparePagesTest failures when intl is installed - https://phabricator.wikimedia.org/T237049 (10Jdforrester-WMF) p:05Triage→03High [19:49:28] 10CommRel-Specialists-Support (Oct-Dec-2019): Translation Outreach for Community Wishlist Survey 2020 - https://phabricator.wikimedia.org/T236326 (10MusikAnimal) >>! In T236326#5622520, @Trizek-WMF wrote: > Thank you for the proposal, but [[https://meta.wikimedia.org/wiki/Wikidata_MassMessage_tool|this tool alre... [19:49:45] 10MediaWiki-General, 10MediaWiki-Page-Diffs, 10Patch-For-Review, 10Release-Engineering-Team-TODO (201910), 10ci-test-error: DifferenceEngineTest and ApiComparePagesTest failures when intl is installed - https://phabricator.wikimedia.org/T237049 (10Jdforrester-WMF) [19:51:42] 10MediaWiki-General, 10MediaWiki-Interface, 10Performance-Team, 10Readers-Web-Backlog (Tracking): The `site` module should be explictly disabled on mobile rather than abuse the targets system - https://phabricator.wikimedia.org/T237050 (10Jdlrobson) [19:52:38] 10Anti-Harassment (The Letter Song), 10Patch-For-Review: System and composite block messages on mobile contain confusing information - https://phabricator.wikimedia.org/T225939 (10Tchanders) > 1. Block message reports the blocking user as "MediaWiki default", which may be confusing Fixed by https://gerrit.wik... [19:53:09] (03CR) 10Jforrester: "recheck" [core] - 10https://gerrit.wikimedia.org/r/419441 (https://phabricator.wikimedia.org/T181658) (owner: 10TK-999) [19:53:23] 10MediaWiki-General, 10MediaWiki-Interface, 10Performance-Team, 10Readers-Web-Backlog (Tracking): The `site` module should be explictly disabled on mobile rather than abuse the targets system - https://phabricator.wikimedia.org/T237050 (10Jdlrobson) [19:53:47] (03CR) 10Jforrester: "recheck" [core] - 10https://gerrit.wikimedia.org/r/539439 (https://phabricator.wikimedia.org/T87796) (owner: 10Alex Paskulin) [19:54:00] (03CR) 10Anomie: "The modules seem generally structurally sound now. Thanks for fixing all the modules based on the comments on the first one! (:" (037 comments) [extensions/Jade] - 10https://gerrit.wikimedia.org/r/536659 (https://phabricator.wikimedia.org/T199834) (owner: 10Accraze) [19:54:11] 10MediaWiki-General, 10MediaWiki-Interface, 10Performance-Team (Radar), 10Readers-Web-Backlog (Tracking): The `site` module should be explictly disabled on mobile rather than abuse the targets system - https://phabricator.wikimedia.org/T237050 (10Krinkle) [19:54:30] (03PS1) 10Jdlrobson: Introducing SkinDefaultModules hook [core] - 10https://gerrit.wikimedia.org/r/547643 (https://phabricator.wikimedia.org/T237050) [19:54:52] 10MediaWiki-General, 10Performance-Team (Radar), 10Readers-Web-Backlog (Tracking): Fix the most common "Module not loadable on target mobile" warnings (Oct 2019) - https://phabricator.wikimedia.org/T235712 (10Jdlrobson) [19:55:03] 10MediaWiki-General, 10MediaWiki-Interface, 10Patch-For-Review, 10Performance-Team (Radar), 10Readers-Web-Backlog (Tracking): The `site` and `site.styles` module should be explictly disabled on mobile rather than abuse the targets system - https://phabricator.wikimedia.org/T237050 (10Jdlrobson) [19:56:49] (03CR) 10jerkins-bot: [V: 04-1] Render talk page as a tab instead of an overlay [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/540441 (https://phabricator.wikimedia.org/T230695) (owner: 10Jdlrobson) [19:56:51] (03CR) 10jerkins-bot: [V: 04-1] Remove eventbus usage in talk.js [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/545945 (https://phabricator.wikimedia.org/T230695) (owner: 10Nray) [19:57:00] 10MediaWiki-General, 10VisualEditor, 10Performance-Team (Radar), 10Readers-Web-Backlog (Tracking): The ext.visualEditor.desktopArticleTarget.init and ext.visualEditor.desktopArticleTarget.noscript modules should be slimmed down and not rely on the target system - https://phabricator.wikimedia.org/T236944 (1... [19:58:03] (03CR) 10Anomie: [C: 03+1] "This patch looks good, virtual +2." [core] - 10https://gerrit.wikimedia.org/r/419441 (https://phabricator.wikimedia.org/T181658) (owner: 10TK-999) [19:58:41] (03CR) 10Jforrester: "> Patch Set 5: Code-Review+1" [core] - 10https://gerrit.wikimedia.org/r/419441 (https://phabricator.wikimedia.org/T181658) (owner: 10TK-999) [20:02:59] (03Merged) 10jenkins-bot: Add the apps-suggested-edits tag to edits made through the feature [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/547571 (owner: 10Mholloway) [20:03:01] (03Merged) 10jenkins-bot: Remove duplicates on composer.json [extensions/XSL] - 10https://gerrit.wikimedia.org/r/547635 (owner: 10MarcoAurelio) [20:03:03] (03Merged) 10jenkins-bot: fixes for handling
 tags and tables [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/544298 (owner: 10Duncancrane)
[20:07:16] 	 (03CR) 10jerkins-bot: [V: 04-1] Introducing SkinDefaultModules hook [core] - 10https://gerrit.wikimedia.org/r/547643 (https://phabricator.wikimedia.org/T237050) (owner: 10Jdlrobson)
[20:12:48] 	 (03PS2) 10Jdlrobson: Introducing SkinDefaultModules hook [core] - 10https://gerrit.wikimedia.org/r/547643 (https://phabricator.wikimedia.org/T237050)
[20:15:37] 	 10Accessibility, 10MediaWiki-Parser, 10Parsing-Team, 10TechCom-RFC, 10Wikipedia-Android-App-Backlog: [RFC] Use 
for media - https://phabricator.wikimedia.org/T118517 (10Krinkle) 05Stalled→03Resolved Closing as resolved. The direction of using `
` for block images was approved in 2015 i... [20:15:41] 10Accessibility, 10MediaWiki-Interface, 10MediaWiki-Parser, 10Parsing-Team, 10Patch-For-Review: Use figure and figcaption HTML5 elements when possible - https://phabricator.wikimedia.org/T51097 (10Krinkle) [20:15:45] 10Accessibility, 10MediaWiki-Interface, 10Tracking-Neverending: Use semantic HTML (tracking) - https://phabricator.wikimedia.org/T12467 (10Krinkle) [20:15:55] 10Accessibility, 10MediaWiki-Parser, 10Parsing-Team, 10Wikipedia-Android-App-Backlog, 10TechCom-RFC (TechCom-Approved): [RFC] Use
for media - https://phabricator.wikimedia.org/T118517 (10Krinkle) [20:16:53] 10Accessibility, 10MediaWiki-Parser, 10Parsing-Team, 10Wikipedia-Android-App-Backlog, 10TechCom-RFC (TechCom-Approved): [RFC] Use
for media - https://phabricator.wikimedia.org/T118517 (10Krinkle) [20:16:56] 10MediaWiki-General, 10MediaWiki-Page-Diffs, 10Release-Engineering-Team-TODO (201910), 10ci-test-error: DifferenceEngineTest and ApiComparePagesTest failures when intl is installed - https://phabricator.wikimedia.org/T237049 (10Anomie) ` 15:34:43 Failed asserting that two arrays are equal. 15:34:43 --- E... [20:17:00] 10GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: Get task types and their difficulties from the tasktypes API instead of hardcoding them in JS - https://phabricator.wikimedia.org/T236805 (10Tgr) [20:18:53] 10MediaWiki-REST-API, 10CPT Initiatives (Core REST API in PHP), 10Core Platform Team Workboards (Green): Keep edit counts in separate database table and update on edit - https://phabricator.wikimedia.org/T237043 (10BPirkle) A few thoughts for (eventual) discussion: - Do we want this to be more generic tha... [20:18:53] 10GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: Get task types and their difficulties from the tasktypes API instead of hardcoding them in JS - https://phabricator.wikimedia.org/T236805 (10Tgr) @Etonkovidova The task does not involve user-visible changes so this is just a heads-up th... [20:19:38] 10Research: Article Topic NYU Fall 2019 Capstone Project - https://phabricator.wikimedia.org/T233646 (10Isaac) Progress: * Pushed back comparison of attention to tf-idf weights to this week. * Label-specific scores make sense: labels with low numbers of training samples are hard. labels like History and Society... [20:22:02] 10MediaWiki-REST-API, 10CPT Initiatives (Core REST API in PHP), 10Core Platform Team Workboards (Green): Keep edit counts in separate database table and update on edit - https://phabricator.wikimedia.org/T237043 (10BPirkle) Okay, one more thought - we might be able to backfill the pages with the largest numb... [20:24:39] (03CR) 10Krinkle: Introducing SkinDefaultModules hook (031 comment) [core] - 10https://gerrit.wikimedia.org/r/547643 (https://phabricator.wikimedia.org/T237050) (owner: 10Jdlrobson) [20:30:46] (03CR) 10Anomie: [C: 03+1] "Script itself seems fine. Output could probably use some work, right now when I run it locally to delete a tag it just prints an unexplain" [core] - 10https://gerrit.wikimedia.org/r/542796 (https://phabricator.wikimedia.org/T75181) (owner: 10MaxSem) [20:31:57] (03CR) 10Tchanders: Remove commented out code from PermissionManagerTest (032 comments) [core] - 10https://gerrit.wikimedia.org/r/547513 (owner: 10Dmaza) [20:32:57] (03PS5) 10Esanders: Fix opening/closing widgets multiple times [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/547278 [20:32:59] (03PS12) 10Esanders: Implement basic saving [extensions/DiscussionTools] - 10https://gerrit.wikimedia.org/r/545616 [20:35:05] 10Product-Analytics: Add namespace field to pageviews_hourly in Superset and Turnilo - https://phabricator.wikimedia.org/T237053 (10MNeisler) [20:38:04] 10Desktop Improvements, 10Readers-Web-Backlog (Design): Build opt-out toggle for desktop improvements project - https://phabricator.wikimedia.org/T236176 (10alexhollender) [20:38:56] 10Product-Analytics: Add namespace field to pageviews_hourly in Superset and Turnilo - https://phabricator.wikimedia.org/T237053 (10MNeisler) [20:39:12] 10Desktop Improvements, 10Readers-Web-Backlog (Design): Build opt-out toggle for desktop improvements project - https://phabricator.wikimedia.org/T236176 (10alexhollender) >>! In T236176#5595572, @ovasileva wrote: > @alexhollender - seems like we have two options for logged-in users at least - display a modal... [20:40:31] 10Editing Design, 10Patch-For-Review, 10VisualEditor (Current work): Mobile VE toolbar doesn't stay onscreen on iOS 13 when keyboard is open - https://phabricator.wikimedia.org/T233470 (10Esanders) Did a brief test on iOS 12.4 on crossbrowsertesting, and it seemed to work: {F30939803} [20:41:17] 10GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: Get task types and their difficulties from the tasktypes API instead of hardcoding them in JS - https://phabricator.wikimedia.org/T236805 (10Etonkovidova) 05Open→03Resolved a:03Etonkovidova >>! In T236805#5624659, @Tgr wrote: > @E... [20:42:30] 10Product-Analytics: Add namespace field to pageviews_hourly in Superset and Turnilo - https://phabricator.wikimedia.org/T237053 (10MNeisler) Please see edits_hourly in Superspet (and [[ https://github.com/wikimedia/analytics-refinery/blob/master/oozie/edit/hourly/edit_hourly.hql | edits_hourl.hql ]] file) for r... [20:44:11] 10Matrix: Write OAuth 1.0 auth plugin for Synapse (Matrix) - https://phabricator.wikimedia.org/T230536 (10Tobias1984) I am still working on setting up a development environment for Synapse, but would like to work on this. I also got some help on the The suggestion was to look at these two pull requests: OpenI... [20:48:04] 10MediaWiki-User-preferences, 10Core Platform Team, 10Availability, 10Wikimedia-production-error: SpecialChangeEmail causes "MWException: CAS update failed on user_touched" from User.php - https://phabricator.wikimedia.org/T226337 (10WDoranWMF) @Krinkle I'm moving this to our icebox, I'm concerned we won't... [20:49:18] (03CR) 10Raimond Spekking: [C: 03+1] "i18n review" [extensions/BlueSpicePrivacy] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547548 (owner: 10ItSpiderman) [20:54:26] (03CR) 10MSantos: [C: 03+2] Use internal HTTP request abstractions to make Google requests [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/547555 (https://phabricator.wikimedia.org/T236843) (owner: 10Mholloway) [20:59:57] 10Password-Reset-Update, 10Community-Tech (Kanban-Q2-2019-20), 10MW-1.35-notes (1.35.0-wmf.4; 2019-10-29): Password Reset: Update Preference to Require both username & email address [medium] - https://phabricator.wikimedia.org/T234401 (10ifried) 05Open→03Resolved This looks good. I'm marking this work as... [21:00:52] 10MediaWiki-General, 10Operations, 10serviceops-radar, 10Performance-Team (Radar), and 2 others: Use a multi-dc aware store for ObjectCache's MainStash if needed. - https://phabricator.wikimedia.org/T212129 (10Eevans) [21:02:23] 10CPT Initiatives (Core REST API in PHP), 10Core Platform Team Workboards (Green), 10MW-1.35-notes (1.35.0-wmf.3; 2019-10-22), 10Patch-For-Review: REST: Add 'from' and 'to' parameters to historycount endpoint. - https://phabricator.wikimedia.org/T235666 (10Pchelolo) yeah, @BPirkle I have decided to pause h... [21:02:23] 10MediaWiki-extensions-ThrottleOverride: Throttle Override - https://phabricator.wikimedia.org/T237054 (10m.hekmat) [21:03:10] 10NewcomerTasks 1.0 , 10Growth-Team (Current Sprint): Newcomer tasks: create test pages on beta enwiki - https://phabricator.wikimedia.org/T236823 (10Tgr) I followed @Etonkovidova's advice and took a simpler approach: * went to Special:Export on cswiki, added some maintenance templates (`Kdy?`, `Kdo?`, `Pravop... [21:03:58] 10MediaWiki-General, 10Operations, 10serviceops-radar, 10Performance-Team (Radar), and 2 others: Use a multi-dc aware store for ObjectCache's MainStash if needed. - https://phabricator.wikimedia.org/T212129 (10Eevans) [21:04:14] (03PS1) 10Umherirrender: Avoid uncached Title::newFromId on Special:DisambiguationPageLinks [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/547649 [21:05:24] 10AbuseFilter, 10Wikimedia-production-error: AbuseFilterVariableHolder::getVar: requested unset variable moved_from_namespace in strict mode, filter: 809 - https://phabricator.wikimedia.org/T236771 (10Urbanecm) Makes sens,e thanks! [21:07:11] (03PS2) 10Umherirrender: Avoid uncached Title::newFromId on special pages [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/547649 [21:12:36] 10Editing Design, 10Patch-For-Review, 10VisualEditor (Current work): Mobile VE toolbar doesn't stay onscreen on iOS 13 when keyboard is open - https://phabricator.wikimedia.org/T233470 (10ppelberg) >>! In T233470#5623703, @Esanders wrote: > Yes, I put this on the prototype for testing... Cool. Thanks, Ed. E... [21:12:42] 10Desktop Improvements, 10Performance-Team (Radar), 10Readers-Web-Backlog (Kanbanana-2019-20-Q2), 10Spike: [SPIKE, 16hrs] We should not need 164kb of JS and 4.89b of CSS to render a blank page in safemode - https://phabricator.wikimedia.org/T235797 (10Jdlrobson) [21:12:52] 10Desktop Improvements, 10Performance-Team (Radar), 10Readers-Web-Backlog (Kanbanana-2019-20-Q2), 10Spike: [SPIKE, 16hrs] We should not need 164kb of JS and 4.89kb of CSS (gzipped) to render a blank page in safemode - https://phabricator.wikimedia.org/T235797 (10Jdlrobson) [21:17:04] (03PS1) 10Umherirrender: Optimize ApiQueryPageImages::getTitles [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/547652 [21:18:18] (03CR) 10jerkins-bot: [V: 04-1] Optimize ApiQueryPageImages::getTitles [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/547652 (owner: 10Umherirrender) [21:18:41] 10MediaWiki-General, 10VisualEditor, 10Performance-Team (Radar), 10Readers-Web-Backlog (Tracking): The ext.visualEditor.desktopArticleTarget.init and ext.visualEditor.desktopArticleTarget.noscript modules should be slimmed down and not rely on the target system - https://phabricator.wikimedia.org/T236944 (1... [21:18:52] 10MediaWiki-General, 10Desktop Improvements, 10VisualEditor, 10Performance-Team (Radar), 10Readers-Web-Backlog (Tracking): The ext.visualEditor.desktopArticleTarget.init and ext.visualEditor.desktopArticleTarget.noscript modules should be slimmed down and not rel... - https://phabricator.wikimedia.org/T236944 [21:21:41] 10Epic, 10Product-Analytics (Kanban), 10VisualEditor (Current work): QA new bucketing patch - https://phabricator.wikimedia.org/T236338 (10Mayakp.wiki) Thanks @ppelberg for the update. [21:22:38] 10MediaWiki-General, 10Desktop Improvements, 10VisualEditor, 10Performance-Team (Radar), 10Readers-Web-Backlog (Tracking): The ext.visualEditor.desktopArticleTarget.init and ext.visualEditor.desktopArticleTarget.noscript modules should be slimmed down and not rel... - https://phabricator.wikimedia.org/T236944 [21:22:57] 10Better Use Of Data, 10Product-Analytics (Kanban): Data Quality Survey Analysis and Presentation - https://phabricator.wikimedia.org/T235802 (10Mayakp.wiki) [21:23:42] (03Merged) 10jenkins-bot: Use internal HTTP request abstractions to make Google requests [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/547555 (https://phabricator.wikimedia.org/T236843) (owner: 10Mholloway) [21:24:12] (03PS1) 10Gergő Tisza: Status: improve typehints [core] - 10https://gerrit.wikimedia.org/r/547656 [21:24:19] (03CR) 10Urbanecm: Return a DNULL in VariableHolder::getVar with GET_STRICT (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/538598 (https://phabricator.wikimedia.org/T230256) (owner: 10Daimona Eaytoy) [21:25:21] (03CR) 10Gergő Tisza: Allow injecting a message localizer into Status (031 comment) [core] - 10https://gerrit.wikimedia.org/r/547305 (owner: 10Gergő Tisza) [21:26:32] 10NewcomerTasks 1.0 , 10Growth-Team (Current Sprint), 10Patch-For-Review: Newcomer tasks: create test pages on beta enwiki - https://phabricator.wikimedia.org/T236823 (10Urbanecm) Wouldn't it make sense to request beta cswiki for the purpose of our experiments? [21:29:25] 10Who-Wrote-That, 10Community-Tech (Kanban-Q2-2019-20): Enable WWT to be turned on and off remotely - https://phabricator.wikimedia.org/T234874 (10ifried) 05Open→03Resolved [21:30:22] 10Who-Wrote-That, 10Community-Tech (Kanban-Q2-2019-20): WWT: Handle behavior with VisualEditor - https://phabricator.wikimedia.org/T231508 (10ifried) [21:30:45] (03PS1) 10Esanders: build: Update linters [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/547658 [21:30:59] (03CR) 10jerkins-bot: [V: 04-1] build: Update linters [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/547658 (owner: 10Esanders) [21:31:17] 10MediaWiki-General: Throttle Override - https://phabricator.wikimedia.org/T237054 (10MarcoAurelio) It looks you're hitting the MediaWiki implicit rate limits rather than ThrottleOverride. If this is happening to you in a Wikimedia project, you're definitely hitting the MediaWiki rate limits as ThrottleOverride... [21:32:48] 10MediaWiki-General: Throttle Override - https://phabricator.wikimedia.org/T237054 (10m.hekmat) I'm just trying to send emails to users. I go to user's page and click on "Email this user" option to send them an email. [21:34:28] 10Design, 10BetaFeatures: Usability: Primary button (save) on beta features page has lower visual weight (=attention) than other, secondary widgets, like checkboxes - https://phabricator.wikimedia.org/T161288 (10awight) [21:34:47] 10MediaWiki-General: Throttle Override - https://phabricator.wikimedia.org/T237054 (10MarcoAurelio) >>! In T237054#5624841, @m.hekmat wrote: > I'm just trying to send emails to users. I go to user's page and click on "Email this user" option to send them an email. @m.hekmat You're definitely hitting the MediaWi... [21:36:38] (03PS31) 10Nray: Render talk page as a tab instead of an overlay [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/540441 (https://phabricator.wikimedia.org/T230695) (owner: 10Jdlrobson) [21:36:40] (03PS20) 10Nray: Remove eventbus usage in talk.js [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/545945 (https://phabricator.wikimedia.org/T230695) [21:37:13] 10Who-Wrote-That, 10Community-Tech (Kanban-Q2-2019-20): WWT: Support Hidden Contributor Names - https://phabricator.wikimedia.org/T232215 (10ifried) This is working as expected (I also tested it), so I'm marking this work as Done. @dom_walden Thanks for pointing out that the hover effect doesn't apply to hidd... [21:37:30] 10Who-Wrote-That, 10Community-Tech (Kanban-Q2-2019-20): WWT: Support Hidden Contributor Names - https://phabricator.wikimedia.org/T232215 (10ifried) 05Open→03Resolved [21:37:48] (03PS1) 10Esanders: build: Update eslint-config-wikimedia [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/547659 [21:38:20] (03Merged) 10jenkins-bot: Status: improve typehints [core] - 10https://gerrit.wikimedia.org/r/547656 (owner: 10Gergő Tisza) [21:38:47] 10Editing Design, 10Editing QA, 10Patch-For-Review, 10VisualEditor (Current work): Mobile VE toolbar doesn't stay onscreen on iOS 13 when keyboard is open - https://phabricator.wikimedia.org/T233470 (10ppelberg) [21:39:08] (03PS2) 10Umherirrender: Optimize ApiQueryPageImages::getTitles [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/547652 [21:40:36] 10Editing Design, 10Editing QA, 10Patch-For-Review, 10VisualEditor (Current work): Mobile VE toolbar doesn't stay onscreen on iOS 13 when keyboard is open - https://phabricator.wikimedia.org/T233470 (10ppelberg) Just chatted with @Ryasmeen, she thinks she'll be able to test this patch on both iOS 12 and iO... [21:40:59] (03PS2) 10Esanders: build: Update eslint-config-wikimedia [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/547659 [21:41:17] (03PS1) 10HMonroy: Fix curation next button becoming disabled [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/547661 (https://phabricator.wikimedia.org/T232093) [21:41:29] 10Password-Reset-Update, 10Community-Tech (Kanban-Q2-2019-20): Enable password reset improvements in betalabs - https://phabricator.wikimedia.org/T234861 (10ifried) 05Open→03Resolved It's available on staging. I'm marking this work as done. [21:43:44] (03PS1) 10Esanders: build: Update linters [skins/Vector] - 10https://gerrit.wikimedia.org/r/547662 [21:44:26] (03CR) 10Jforrester: [C: 03+2] build: Update linters [skins/Vector] - 10https://gerrit.wikimedia.org/r/547662 (owner: 10Esanders) [21:46:11] 10Password-Reset-Update, 10Community-Tech (Kanban-Q2-2019-20): Password Reset: Inform Users of Preference on Special:PasswordReset [small] - https://phabricator.wikimedia.org/T232512 (10ifried) @MaxSem @dom_walden I just tested this on https://en.wikipedia.beta.wmflabs.org/. It appears that the message is disp... [21:46:28] (03CR) 10Jforrester: "recheck" [core] - 10https://gerrit.wikimedia.org/r/419441 (https://phabricator.wikimedia.org/T181658) (owner: 10TK-999) [21:47:55] (03CR) 10jerkins-bot: [V: 04-1] Remove eventbus usage in talk.js [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/545945 (https://phabricator.wikimedia.org/T230695) (owner: 10Nray) [21:47:57] (03PS1) 10Esanders: build: Update linters [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/547664 [21:48:00] 10Password-Reset-Update, 10Community-Tech (Kanban-Q2-2019-20), 10MW-1.34-notes, 10MW-1.35-notes (1.35.0-wmf.1; 2019-10-08): Turn the PasswordReset class into a service - https://phabricator.wikimedia.org/T232694 (10ifried) 05Open→03Resolved There's nothing for me to test here, so I'm marking this work... [21:48:02] 10Password-Reset-Update, 10Community-Tech (Kanban-Q2-2019-20): Password Reset: Inform Users of Preference on Special:PasswordReset [small] - https://phabricator.wikimedia.org/T232512 (10ifried) [21:48:26] 10MediaWiki-Special-pages, 10UI-Standardization, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2), 10UI-Standardization-Kanban: Special:Contributions – add 'pinning' functionality to collapsible form? - https://phabricator.wikimedia.org/T234569 (10Izno) The revision slider has a pin today. In Timeless today (w... [21:48:49] 10BetaFeatures: Usability: BetaFeatures Save button bar does all the bad floating things - https://phabricator.wikimedia.org/T237057 (10awight) [21:48:58] (03CR) 10jerkins-bot: [V: 04-1] Render talk page as a tab instead of an overlay [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/540441 (https://phabricator.wikimedia.org/T230695) (owner: 10Jdlrobson) [21:50:07] 10Advanced Mobile Contributions, 10MW-1.35-notes (1.35.0-wmf.5; 2019-11-05), 10Patch-For-Review, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2): Render talk page as a tab (rather than a modal) - https://phabricator.wikimedia.org/T230695 (10nray) Status update: Alex has design review approved latest changes,... [21:50:38] (03PS3) 10Umherirrender: Avoid uncached Title::newFromId on special pages [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/547649 [21:51:52] (03CR) 10jerkins-bot: [V: 04-1] build: Update eslint-config-wikimedia [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/547659 (owner: 10Esanders) [21:54:55] (03CR) 10Alexandros Kosiaris: [C: 04-1] Developer productivity improvements, docker support (031 comment) [services/cxserver] - 10https://gerrit.wikimedia.org/r/543029 (owner: 10Santhosh) [21:56:40] (03Merged) 10jenkins-bot: build: Update linters [skins/Vector] - 10https://gerrit.wikimedia.org/r/547662 (owner: 10Esanders) [21:59:41] (03PS32) 10Nray: Render talk page as a tab instead of an overlay [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/540441 (https://phabricator.wikimedia.org/T230695) (owner: 10Jdlrobson) [21:59:43] (03PS21) 10Nray: Remove eventbus usage in talk.js [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/545945 (https://phabricator.wikimedia.org/T230695) [22:10:30] (03CR) 10jerkins-bot: [V: 04-1] Render talk page as a tab instead of an overlay [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/540441 (https://phabricator.wikimedia.org/T230695) (owner: 10Jdlrobson) [22:10:42] (03CR) 10jerkins-bot: [V: 04-1] Remove eventbus usage in talk.js [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/545945 (https://phabricator.wikimedia.org/T230695) (owner: 10Nray) [22:14:08] (03PS1) 10Bartosz Dziewoński: Adjust file/image button tooltip to match VisualEditor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/547670 (https://phabricator.wikimedia.org/T223775) [22:15:18] (03CR) 10DLynch: [C: 03+2] Adjust file/image button tooltip to match VisualEditor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/547670 (https://phabricator.wikimedia.org/T223775) (owner: 10Bartosz Dziewoński) [22:21:46] (03CR) 10Ppchelko: "Last thing to be decided - whether to have MAX for all the counts. See https://phabricator.wikimedia.org/T235572#5621346" [core] - 10https://gerrit.wikimedia.org/r/543718 (https://phabricator.wikimedia.org/T235666) (owner: 10Ppchelko) [22:24:45] (03Merged) 10jenkins-bot: Adjust file/image button tooltip to match VisualEditor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/547670 (https://phabricator.wikimedia.org/T223775) (owner: 10Bartosz Dziewoński) [22:25:12] (03CR) 10MaxSem: [C: 03+2] "I'm not demanding tests because wfGetDB(). This code needs refactoring." [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/547637 (owner: 10Umherirrender) [22:28:10] (03Merged) 10jenkins-bot: Do not query pageimages for special pages and not-existing titles [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/547637 (owner: 10Umherirrender) [22:32:13] (03PS11) 10Sharvaniharan: Api provisions for revert count Bug: T234955 [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/546312 (https://phabricator.wikimedia.org/T234955) [22:37:10] (03PS1) 10Jdlrobson: Do not try to load MMV on the mobile domain. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/547672 (https://phabricator.wikimedia.org/T235712) [22:38:46] (03PS1) 10Jdlrobson: Enable special page modules for search [core] - 10https://gerrit.wikimedia.org/r/547673 [22:38:48] (03PS1) 10Jdlrobson: Load noscript module on mobile [core] - 10https://gerrit.wikimedia.org/r/547674 (https://phabricator.wikimedia.org/T235712) [22:39:07] (03PS2) 10Jdlrobson: Load noscript module on mobile [core] - 10https://gerrit.wikimedia.org/r/547674 (https://phabricator.wikimedia.org/T235712) [22:40:00] (03PS33) 10Nray: Render talk page as a tab instead of an overlay [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/540441 (https://phabricator.wikimedia.org/T230695) (owner: 10Jdlrobson) [22:40:02] (03PS22) 10Nray: Remove eventbus usage in talk.js [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/545945 (https://phabricator.wikimedia.org/T230695) [22:41:04] (03CR) 10jerkins-bot: [V: 04-1] Do not try to load MMV on the mobile domain. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/547672 (https://phabricator.wikimedia.org/T235712) (owner: 10Jdlrobson) [22:42:56] (03PS2) 10Jdlrobson: Do not try to load MMV on the mobile domain. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/547672 (https://phabricator.wikimedia.org/T235712) [22:46:57] (03CR) 10jerkins-bot: [V: 04-1] Do not try to load MMV on the mobile domain. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/547672 (https://phabricator.wikimedia.org/T235712) (owner: 10Jdlrobson) [22:48:59] (03CR) 10Jdlrobson: [C: 04-1] "> In light of T212482, I think this hook is too powerful and would be hard to maintain long-term." [core] - 10https://gerrit.wikimedia.org/r/547643 (https://phabricator.wikimedia.org/T237050) (owner: 10Jdlrobson) [22:51:05] (03PS3) 10Jdlrobson: Do not try to load MMV on the mobile domain. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/547672 (https://phabricator.wikimedia.org/T235712) [22:52:40] (03CR) 10jerkins-bot: [V: 04-1] Remove eventbus usage in talk.js [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/545945 (https://phabricator.wikimedia.org/T230695) (owner: 10Nray) [22:53:11] (03CR) 10jerkins-bot: [V: 04-1] Enable special page modules for search [core] - 10https://gerrit.wikimedia.org/r/547673 (owner: 10Jdlrobson) [22:53:35] (03CR) 10jerkins-bot: [V: 04-1] Render talk page as a tab instead of an overlay [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/540441 (https://phabricator.wikimedia.org/T230695) (owner: 10Jdlrobson) [22:54:26] (03CR) 10jerkins-bot: [V: 04-1] Do not try to load MMV on the mobile domain. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/547672 (https://phabricator.wikimedia.org/T235712) (owner: 10Jdlrobson) [22:54:52] (03CR) 10jerkins-bot: [V: 04-1] Load noscript module on mobile [core] - 10https://gerrit.wikimedia.org/r/547674 (https://phabricator.wikimedia.org/T235712) (owner: 10Jdlrobson) [22:56:46] (03CR) 10jerkins-bot: [V: 04-1] Api provisions for revert count Bug: T234955 [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/546312 (https://phabricator.wikimedia.org/T234955) (owner: 10Sharvaniharan) [23:00:50] (03PS34) 10Nray: Render talk page as a tab instead of an overlay [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/540441 (https://phabricator.wikimedia.org/T230695) (owner: 10Jdlrobson) [23:00:52] (03PS23) 10Nray: Remove eventbus usage in talk.js [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/545945 (https://phabricator.wikimedia.org/T230695) [23:08:16] (03PS3) 10Jdlrobson: Optimize ApiQueryPageImages::getTitles [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/547652 (https://phabricator.wikimedia.org/T237068) (owner: 10Umherirrender) [23:08:58] (03PS3) 10Jdlrobson: build: Update eslint-config-wikimedia [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/547659 (owner: 10Esanders) [23:10:14] (03PS1) 10Ppchelko: REST History Counts: Limit the number of edits to count [core] - 10https://gerrit.wikimedia.org/r/547682 (https://phabricator.wikimedia.org/T235666) [23:16:43] (03CR) 10Mglaser: [C: 03+2] Change message to be gender-neutral [extensions/BlueSpicePrivacy] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547548 (owner: 10ItSpiderman) [23:16:50] (03PS1) 10Mglaser: Change message to be gender-neutral [extensions/BlueSpicePrivacy] (REL1_31) - 10https://gerrit.wikimedia.org/r/547683 [23:16:55] (03CR) 10Mglaser: [C: 03+2] Change message to be gender-neutral [extensions/BlueSpicePrivacy] (REL1_31) - 10https://gerrit.wikimedia.org/r/547683 (owner: 10Mglaser) [23:17:01] (03PS1) 10Mglaser: Change message to be gender-neutral [extensions/BlueSpicePrivacy] - 10https://gerrit.wikimedia.org/r/547684 [23:17:09] (03CR) 10Mglaser: [C: 03+2] Change message to be gender-neutral [extensions/BlueSpicePrivacy] - 10https://gerrit.wikimedia.org/r/547684 (owner: 10Mglaser) [23:18:01] (03CR) 10jerkins-bot: [V: 04-1] Change message to be gender-neutral [extensions/BlueSpicePrivacy] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/547548 (owner: 10ItSpiderman) [23:19:28] (03PS4) 10Jdlrobson: Do not try to load MMV on the mobile domain. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/547672 (https://phabricator.wikimedia.org/T235712) [23:19:32] (03Merged) 10jenkins-bot: Change message to be gender-neutral [extensions/BlueSpicePrivacy] - 10https://gerrit.wikimedia.org/r/547684 (owner: 10Mglaser) [23:19:34] (03Merged) 10jenkins-bot: Change message to be gender-neutral [extensions/BlueSpicePrivacy] (REL1_31) - 10https://gerrit.wikimedia.org/r/547683 (owner: 10Mglaser) [23:19:39] (03PS5) 10Jdlrobson: Do not try to load MMV on the mobile domain. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/547672 (https://phabricator.wikimedia.org/T235712) [23:20:01] (03PS2) 10Jdlrobson: Enable special page modules for search [core] - 10https://gerrit.wikimedia.org/r/547673 [23:23:37] (03CR) 10Jdlrobson: [C: 03+2] Remove obsolete 'mobile-frontend-talk-' messages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/546228 (https://phabricator.wikimedia.org/T230695) (owner: 10Nray) [23:26:34] (03CR) 10Bartosz Dziewoński: "Caused T236460" [core] - 10https://gerrit.wikimedia.org/r/540965 (owner: 10Esanders) [23:28:27] (03PS1) 10Bartosz Dziewoński: mw.widgets.UsersMultiselectWidget: Fix property name [core] - 10https://gerrit.wikimedia.org/r/547685 (https://phabricator.wikimedia.org/T236460) [23:30:08] (03PS1) 10Nikki Nikkhoui: Param validation example in Example extension [extensions/examples] - 10https://gerrit.wikimedia.org/r/547687 (https://phabricator.wikimedia.org/T237069) [23:31:46] (03CR) 10jerkins-bot: [V: 04-1] Param validation example in Example extension [extensions/examples] - 10https://gerrit.wikimedia.org/r/547687 (https://phabricator.wikimedia.org/T237069) (owner: 10Nikki Nikkhoui) [23:31:49] (03PS2) 10Nikki Nikkhoui: Param validation example in Example extension [extensions/examples] - 10https://gerrit.wikimedia.org/r/547687 (https://phabricator.wikimedia.org/T237069) [23:32:27] (03CR) 10jerkins-bot: [V: 04-1] Param validation example in Example extension [extensions/examples] - 10https://gerrit.wikimedia.org/r/547687 (https://phabricator.wikimedia.org/T237069) (owner: 10Nikki Nikkhoui) [23:34:10] (03PS3) 10Nikki Nikkhoui: Param validation example in Example extension [extensions/examples] - 10https://gerrit.wikimedia.org/r/547687 (https://phabricator.wikimedia.org/T237069) [23:34:16] (03PS12) 10Sharvaniharan: Api provisions for revert count Bug: T234955 [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/546312 (https://phabricator.wikimedia.org/T234955) [23:34:49] (03CR) 10jerkins-bot: [V: 04-1] Param validation example in Example extension [extensions/examples] - 10https://gerrit.wikimedia.org/r/547687 (https://phabricator.wikimedia.org/T237069) (owner: 10Nikki Nikkhoui) [23:36:02] (03PS1) 10Mholloway: [WIP] Performance: Execute labeling requests in a Job, not a DeferredUpdate [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/547688 (https://phabricator.wikimedia.org/T230813) [23:37:17] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Performance: Execute labeling requests in a Job, not a DeferredUpdate [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/547688 (https://phabricator.wikimedia.org/T230813) (owner: 10Mholloway) [23:37:33] (03CR) 10Jdlrobson: Render talk page as a tab instead of an overlay (036 comments) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/540441 (https://phabricator.wikimedia.org/T230695) (owner: 10Jdlrobson) [23:38:12] (03PS2) 10Mholloway: [WIP] Performance: Execute labeling requests in a Job, not a DeferredUpdate [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/547688 (https://phabricator.wikimedia.org/T230813) [23:39:40] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Performance: Execute labeling requests in a Job, not a DeferredUpdate [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/547688 (https://phabricator.wikimedia.org/T230813) (owner: 10Mholloway) [23:39:53] (03CR) 10Ppchelko: "I've also replaced some of the `selectField` with `selectRowCount`, but didn't find a way do do that together with DISTINCT." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/547682 (https://phabricator.wikimedia.org/T235666) (owner: 10Ppchelko) [23:43:29] (03PS3) 10Mholloway: [WIP] Performance: Execute labeling requests in a Job, not a DeferredUpdate [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/547688 (https://phabricator.wikimedia.org/T230813) [23:48:19] (03PS6) 10Mholloway: [DNM] Various performance review tweaks and comments [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/546141 (https://phabricator.wikimedia.org/T230813) (owner: 10Aaron Schulz) [23:49:54] (03CR) 10Mholloway: "fixed lint errors and rebased" (031 comment) [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/546141 (https://phabricator.wikimedia.org/T230813) (owner: 10Aaron Schulz) [23:53:47] (03PS4) 10Nikki Nikkhoui: Param validation example in Example extension [extensions/examples] - 10https://gerrit.wikimedia.org/r/547687 (https://phabricator.wikimedia.org/T237069)