[00:01:57] (03PS8) 10DannyS712: API: Alter behaviour if state doesn't change instead of proceeding [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539624 (https://phabricator.wikimedia.org/T234074) [00:01:59] 04(no projects): "Content" equivalent of pageviews daily or edits_hourly available to use in Turnilo and Superset - https://phabricator.wikimedia.org/T234701 (10JKatzWMF) [00:03:05] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: support tracking indirect module dependency paths via BagOStuff [core] - 10https://gerrit.wikimedia.org/r/519741 (https://phabricator.wikimedia.org/T113916) (owner: 10Aaron Schulz) [00:06:40] (03CR) 10jerkins-bot: [V: 04-1] API: Alter behaviour if state doesn't change instead of proceeding [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539624 (https://phabricator.wikimedia.org/T234074) (owner: 10DannyS712) [00:11:07] (03PS9) 10DannyS712: API: Alter behaviour if state doesn't change instead of proceeding [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539624 (https://phabricator.wikimedia.org/T234074) [00:15:05] (03CR) 10MaxSem: [C: 03+2] tests: Add type hints to ApiFormatBaseTest [core] - 10https://gerrit.wikimedia.org/r/539321 (owner: 10Thiemo Kreuz (WMDE)) [00:18:52] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: support tracking indirect module dependency paths via BagOStuff [core] - 10https://gerrit.wikimedia.org/r/519741 (https://phabricator.wikimedia.org/T113916) (owner: 10Aaron Schulz) [00:21:47] (03PS23) 10Accraze: Implement Api modules [extensions/Jade] - 10https://gerrit.wikimedia.org/r/536659 (https://phabricator.wikimedia.org/T199834) [00:25:16] (03CR) 10jerkins-bot: [V: 04-1] Implement Api modules [extensions/Jade] - 10https://gerrit.wikimedia.org/r/536659 (https://phabricator.wikimedia.org/T199834) (owner: 10Accraze) [00:30:13] (03Merged) 10jenkins-bot: tests: Add type hints to ApiFormatBaseTest [core] - 10https://gerrit.wikimedia.org/r/539321 (owner: 10Thiemo Kreuz (WMDE)) [00:31:24] (03PS24) 10Accraze: Implement Api modules [extensions/Jade] - 10https://gerrit.wikimedia.org/r/536659 (https://phabricator.wikimedia.org/T199834) [00:33:17] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), 10Mobile: [regression- mobile] Homepage - Start model displays broken layout - https://phabricator.wikimedia.org/T234380 (10Etonkovidova) Works in betalabs. [00:34:52] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/539321 (owner: 10Thiemo Kreuz (WMDE)) [00:35:43] (03CR) 10jerkins-bot: [V: 04-1] Implement Api modules [extensions/Jade] - 10https://gerrit.wikimedia.org/r/536659 (https://phabricator.wikimedia.org/T199834) (owner: 10Accraze) [00:38:13] 10MediaWiki-General, 10Performance-Team, 10Readers-Web-Backlog, 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01): Audit use of @embed and remove where not needed (2019) - https://phabricator.wikimedia.org/T121730 (10Krinkle) 05Open→03Resolved As of about 1.5 day ago, this is deployed on all Wikipedias (Thu... [00:38:15] (03CR) 10MaxSem: "Needs a rebase because hhvm_wikidiff2.cpp has been deleted. I'm unsure about passing array as a string." [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/539906 (https://phabricator.wikimedia.org/T234096) (owner: 10Tsevener) [00:38:23] 10MediaWiki-General, 10Performance-Team, 10Readers-Web-Backlog, 10Performance-Team-publish: Audit use of @embed and remove where not needed (2019) - https://phabricator.wikimedia.org/T121730 (10Krinkle) [00:44:09] (03PS25) 10Accraze: Implement Api modules [extensions/Jade] - 10https://gerrit.wikimedia.org/r/536659 (https://phabricator.wikimedia.org/T199834) [00:44:35] (03PS14) 10Krinkle: Preload links via LinkBatch in WikitextContent::fillParserOutput() [core] - 10https://gerrit.wikimedia.org/r/496744 (owner: 10Aaron Schulz) [00:45:16] (03CR) 10jerkins-bot: [V: 04-1] Implement Api modules [extensions/Jade] - 10https://gerrit.wikimedia.org/r/536659 (https://phabricator.wikimedia.org/T199834) (owner: 10Accraze) [00:50:10] (03PS1) 10MaxSem: PHPUnit4And6Compat tweaks [core] - 10https://gerrit.wikimedia.org/r/540980 [00:55:53] (03CR) 10Krinkle: PHPUnit4And6Compat tweaks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/540980 (owner: 10MaxSem) [00:56:43] (03PS26) 10Accraze: Implement Api modules [extensions/Jade] - 10https://gerrit.wikimedia.org/r/536659 (https://phabricator.wikimedia.org/T199834) [00:57:48] (03CR) 10jerkins-bot: [V: 04-1] Implement Api modules [extensions/Jade] - 10https://gerrit.wikimedia.org/r/536659 (https://phabricator.wikimedia.org/T199834) (owner: 10Accraze) [00:58:14] (03CR) 10MaxSem: PHPUnit4And6Compat tweaks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/540980 (owner: 10MaxSem) [01:01:59] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: Wikimedia Technical Conference 2019 Session: Front-end modernization and standardization - https://phabricator.wikimedia.org/T234649 (10kaldari) [01:06:27] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: Wikimedia Technical Conference 2019 Session: 3rd Party MediaWiki development and support - https://phabricator.wikimedia.org/T234651 (10kaldari) [01:08:21] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: Wikimedia Technical Conference 2019 Session: Learning how WMDE updated their internal processes - https://phabricator.wikimedia.org/T234652 (10kaldari) [01:10:02] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: Wikimedia Technical Conference 2019 Session: Componentization and sharing with the open source community - https://phabricator.wikimedia.org/T234654 (10kaldari) [01:10:23] 10Password-Reset-Update, 10Community-Tech (Kanban-Q2-2019-20), 10Patch-For-Review: Update Temporary Password Email with Preference Info [x-small] - https://phabricator.wikimedia.org/T233969 (10MaxSem) Ready for review. [01:11:13] (03CR) 10jerkins-bot: [V: 04-1] Implement Api modules [extensions/Jade] - 10https://gerrit.wikimedia.org/r/536659 (https://phabricator.wikimedia.org/T199834) (owner: 10Accraze) [01:12:44] (03CR) 10Mooeypoo: [C: 04-1] "A couple of comments inline. Also, this needs to be tested before merge." (033 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/530649 (https://phabricator.wikimedia.org/T148353) (owner: 10DannyS712) [01:14:23] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: Wikimedia Technical Conference 2019 Session: Componentization and sharing with the open source community - https://phabricator.wikimedia.org/T234654 (10kaldari) [01:14:49] (03CR) 10MaxSem: "@ArielGlenn, my thoughts were that since there's no more Zend/HHVM separation, this parameter can be used to run the script with different" [vagrant] - 10https://gerrit.wikimedia.org/r/540502 (https://phabricator.wikimedia.org/T192166) (owner: 10MaxSem) [01:16:14] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: Wikimedia Technical Conference 2019 Session: Standardizing best practices - https://phabricator.wikimedia.org/T234653 (10kaldari) [01:23:03] (03CR) 10Catrope: [C: 04-1] "First stab at a review, I'll have to come back to this after the weekend and look at it in more detail" (039 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540224 (https://phabricator.wikimedia.org/T221007) (owner: 10Jdlrobson) [01:24:45] (03CR) 10Mooeypoo: [C: 04-1] "I tried to test whether .on would work (I suspect not) and the patch crashed for me in two places." (032 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/530649 (https://phabricator.wikimedia.org/T148353) (owner: 10DannyS712) [01:41:51] (03PS1) 10MaxSem: Fix PHPUnit 4 rudiments [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/540982 [01:44:54] (03CR) 10jerkins-bot: [V: 04-1] Fix PHPUnit 4 rudiments [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/540982 (owner: 10MaxSem) [01:45:18] (03CR) 10jerkins-bot: [V: 04-1] Fix PHPUnit 4 rudiments [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/540982 (owner: 10MaxSem) [01:53:23] (03PS5) 10DannyS712: Partially revert "bug39208 - Add auto review to tagging/deletion" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/530649 (https://phabricator.wikimedia.org/T148353) [01:58:08] (03CR) 10jerkins-bot: [V: 04-1] Partially revert "bug39208 - Add auto review to tagging/deletion" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/530649 (https://phabricator.wikimedia.org/T148353) (owner: 10DannyS712) [01:58:17] (03PS27) 10Accraze: Implement Api modules [extensions/Jade] - 10https://gerrit.wikimedia.org/r/536659 (https://phabricator.wikimedia.org/T199834) [02:02:35] (03CR) 10jerkins-bot: [V: 04-1] Implement Api modules [extensions/Jade] - 10https://gerrit.wikimedia.org/r/536659 (https://phabricator.wikimedia.org/T199834) (owner: 10Accraze) [02:07:50] (03PS1) 10Krinkle: rdbms: Restore debug toolbar "Queries" feature [core] - 10https://gerrit.wikimedia.org/r/540983 [02:08:37] (03CR) 10Krinkle: rdbms: Restore debug toolbar "Queries" feature (031 comment) [core] - 10https://gerrit.wikimedia.org/r/540983 (owner: 10Krinkle) [02:08:55] (03PS15) 10Krinkle: Preload links via LinkBatch in WikitextContent::fillParserOutput() [core] - 10https://gerrit.wikimedia.org/r/496744 (owner: 10Aaron Schulz) [02:10:32] (03PS1) 10MaxSem: Fix old PHPUnit rudiments [extensions/ORES] - 10https://gerrit.wikimedia.org/r/540984 [02:11:45] (03CR) 10jerkins-bot: [V: 04-1] Implement Api modules [extensions/Jade] - 10https://gerrit.wikimedia.org/r/536659 (https://phabricator.wikimedia.org/T199834) (owner: 10Accraze) [02:14:35] (03PS28) 10Accraze: Implement Api modules [extensions/Jade] - 10https://gerrit.wikimedia.org/r/536659 (https://phabricator.wikimedia.org/T199834) [02:17:12] (03PS2) 10MaxSem: Fix PHPUnit 4 rudiments [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/540982 [02:17:38] (03CR) 10Krinkle: [C: 04-1] "I've compared before/after in two scenarios:" [core] - 10https://gerrit.wikimedia.org/r/496744 (owner: 10Aaron Schulz) [02:18:10] (03CR) 10Krinkle: [C: 03+2] Fix old PHPUnit rudiments [extensions/ORES] - 10https://gerrit.wikimedia.org/r/540984 (owner: 10MaxSem) [02:18:18] (03CR) 10jerkins-bot: [V: 04-1] Implement Api modules [extensions/Jade] - 10https://gerrit.wikimedia.org/r/536659 (https://phabricator.wikimedia.org/T199834) (owner: 10Accraze) [02:20:17] (03CR) 10Krinkle: [C: 03+2] Begin cleaning up PHPUnit 4 code from tests [core] - 10https://gerrit.wikimedia.org/r/540698 (https://phabricator.wikimedia.org/T192167) (owner: 10MaxSem) [02:20:34] (03CR) 10Krinkle: PHPUnit4And6Compat tweaks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/540980 (owner: 10MaxSem) [02:20:37] (03CR) 10Krinkle: [C: 04-1] PHPUnit4And6Compat tweaks [core] - 10https://gerrit.wikimedia.org/r/540980 (owner: 10MaxSem) [02:20:44] (03CR) 10Krinkle: [C: 03+2] Fix PHPUnit 4 rudiments [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/540982 (owner: 10MaxSem) [02:21:09] (03PS3) 10Krinkle: NamespaceInfo: use array constants now that we can [core] - 10https://gerrit.wikimedia.org/r/540696 (owner: 10MaxSem) [02:21:13] (03Merged) 10jenkins-bot: Fix old PHPUnit rudiments [extensions/ORES] - 10https://gerrit.wikimedia.org/r/540984 (owner: 10MaxSem) [02:22:24] (03CR) 10Krinkle: NamespaceInfo: use array constants now that we can (031 comment) [core] - 10https://gerrit.wikimedia.org/r/540696 (owner: 10MaxSem) [02:24:46] (03CR) 10Krinkle: Tracking for Reference Previews interactions (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/538641 (https://phabricator.wikimedia.org/T214493) (owner: 10Awight) [02:25:31] (03CR) 10MaxSem: NamespaceInfo: use array constants now that we can (031 comment) [core] - 10https://gerrit.wikimedia.org/r/540696 (owner: 10MaxSem) [02:26:45] (03CR) 10Krinkle: [C: 04-1] Baseline reference interaction tracking (031 comment) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/538261 (https://phabricator.wikimedia.org/T231529) (owner: 10Awight) [02:28:18] (03PS29) 10Accraze: Implement Api modules [extensions/Jade] - 10https://gerrit.wikimedia.org/r/536659 (https://phabricator.wikimedia.org/T199834) [02:28:55] (03PS2) 10MaxSem: PHPUnit4And6Compat tweaks [core] - 10https://gerrit.wikimedia.org/r/540980 [02:29:27] (03CR) 10MaxSem: PHPUnit4And6Compat tweaks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/540980 (owner: 10MaxSem) [02:32:02] (03PS6) 10DannyS712: Partially revert "bug39208 - Add auto review to tagging/deletion" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/530649 (https://phabricator.wikimedia.org/T148353) [02:33:18] (03CR) 10jerkins-bot: [V: 04-1] Implement Api modules [extensions/Jade] - 10https://gerrit.wikimedia.org/r/536659 (https://phabricator.wikimedia.org/T199834) (owner: 10Accraze) [02:34:59] (03Merged) 10jenkins-bot: Begin cleaning up PHPUnit 4 code from tests [core] - 10https://gerrit.wikimedia.org/r/540698 (https://phabricator.wikimedia.org/T192167) (owner: 10MaxSem) [02:35:02] (03Merged) 10jenkins-bot: Fix PHPUnit 4 rudiments [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/540982 (owner: 10MaxSem) [02:35:22] 10MediaWiki-Internationalization, 10Core Platform Team, 10Language-Team, 10MW-1.35-release, 10Performance-Team (Radar): Use disk-based LCStore by default in MediaWiki 1.34 - https://phabricator.wikimedia.org/T218207 (10Krinkle) [02:35:26] 10MediaWiki-Internationalization, 10Core Platform Team, 10Language-Team, 10MW-1.35-release, 10Performance-Team (Radar): Use disk-based LCStore by default in MediaWiki 1.35 - https://phabricator.wikimedia.org/T218207 (10Krinkle) [02:36:25] 10MediaWiki-Internationalization, 10Core Platform Team, 10Language-Team, 10MW-1.35-release, 10Performance-Team (Radar): Use disk-based LCStore by default in MediaWiki 1.35 - https://phabricator.wikimedia.org/T218207 (10Krinkle) Updating title to reflect priority from CPT (thirty-party wikis will remain o... [02:39:26] (03PS30) 10Accraze: Implement Api modules [extensions/Jade] - 10https://gerrit.wikimedia.org/r/536659 (https://phabricator.wikimedia.org/T199834) [02:39:40] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/540698 (https://phabricator.wikimedia.org/T192167) (owner: 10MaxSem) [02:40:09] 10MediaWiki-Internationalization, 10Core Platform Team, 10Language-Team, 10MW-1.35-release, 10Performance-Team (Radar): Use disk-based LCStore by default in MediaWiki 1.35 - https://phabricator.wikimedia.org/T218207 (10Krinkle) [02:43:04] (03CR) 10Krinkle: [C: 03+2] PHPUnit4And6Compat tweaks [core] - 10https://gerrit.wikimedia.org/r/540980 (owner: 10MaxSem) [02:58:26] (03Merged) 10jenkins-bot: PHPUnit4And6Compat tweaks [core] - 10https://gerrit.wikimedia.org/r/540980 (owner: 10MaxSem) [03:03:09] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/540980 (owner: 10MaxSem) [03:05:01] (03CR) 10Dmaza: [C: 03+1] Introduce a formatter service for block errors [core] - 10https://gerrit.wikimedia.org/r/528918 (https://phabricator.wikimedia.org/T227174) (owner: 10Tchanders) [03:26:34] 10MinervaNeue, 10MobileFrontend (MobileFrontend and MinervaNeue architecture): Skin Minerva Neue: do not manually assign fonts - https://phabricator.wikimedia.org/T234703 (10fireattack) [03:27:13] 10MinervaNeue, 10MobileFrontend (MobileFrontend and MinervaNeue architecture): Skin Minerva Neue: do not manually assign fonts - https://phabricator.wikimedia.org/T234703 (10fireattack) [03:27:53] 10MinervaNeue, 10MobileFrontend (MobileFrontend and MinervaNeue architecture): Skin Minerva Neue: do not manually assign fonts - https://phabricator.wikimedia.org/T234703 (10fireattack) [03:37:57] 10Design, 10MediaWiki-Interface, 10Readers-Web-Backlog, 10TechCom-RFC, and 2 others: RFC: Section header "share" link - https://phabricator.wikimedia.org/T18691 (10Graham87) I'm a screen reader user who commented waaaaaay above. If a link *had* to be added, adding it after the "edit" link would be best. Ho... [03:45:04] (03CR) 10Dbarratt: [C: 04-1] "A bunch of nit-picks you can ignore, but I did have a few legit questions. I don't see why you need more than one public method in the ser" (0310 comments) [core] - 10https://gerrit.wikimedia.org/r/528918 (https://phabricator.wikimedia.org/T227174) (owner: 10Tchanders) [03:55:33] (03PS1) 10MaxSem: Drop old PHPUnit rudiments [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540986 [04:00:17] (03PS1) 10MaxSem: Fix old PHPUnit rudiments [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/540987 [04:07:48] (03CR) 10Dbarratt: [C: 04-1] Allow user, language and IP to be passed to UserBlockedError (033 comments) [core] - 10https://gerrit.wikimedia.org/r/538452 (https://phabricator.wikimedia.org/T234406) (owner: 10Tchanders) [04:09:48] (03CR) 10Dbarratt: [C: 04-1] Allow user, language and IP to be passed to UserBlockedError (031 comment) [core] - 10https://gerrit.wikimedia.org/r/538452 (https://phabricator.wikimedia.org/T234406) (owner: 10Tchanders) [04:26:37] 10MediaWiki-User-management, 10Anti-Harassment (The Letter Song): Clear block cookie when tracking block, not when checking block - https://phabricator.wikimedia.org/T233595 (10dbarratt) @Tchanders Is there a patch for this? (sorry I went to this in the opposite direction) [04:55:52] (03PS1) 10MaxSem: Cleanup of old PHPUnit usage, part 2 [core] - 10https://gerrit.wikimedia.org/r/540988 (https://phabricator.wikimedia.org/T192167) [05:21:40] (03PS1) 10MaxSem: Cleanup of old PHPUnit usage, part 2 [core] - 10https://gerrit.wikimedia.org/r/540989 (https://phabricator.wikimedia.org/T192167) [05:25:35] (03PS2) 10MaxSem: Cleanup of old PHPUnit usage, part 3 [core] - 10https://gerrit.wikimedia.org/r/540989 (https://phabricator.wikimedia.org/T192167) [05:36:26] 10MediaWiki-General: The TemplateParser do an unnecessary HTML entity encoding - https://phabricator.wikimedia.org/T234705 (10Fomafix) [05:37:02] (03CR) 10Fomafix: [C: 04-1] "I reported the HTML encoding issue in T234705." [core] - 10https://gerrit.wikimedia.org/r/540876 (owner: 10Fomafix) [05:39:19] (03CR) 10jerkins-bot: [V: 04-1] Cleanup of old PHPUnit usage, part 3 [core] - 10https://gerrit.wikimedia.org/r/540989 (https://phabricator.wikimedia.org/T192167) (owner: 10MaxSem) [05:54:43] (03CR) 10jerkins-bot: [V: 04-1] Cleanup of old PHPUnit usage, part 3 [core] - 10https://gerrit.wikimedia.org/r/540989 (https://phabricator.wikimedia.org/T192167) (owner: 10MaxSem) [06:04:58] (03CR) 10jerkins-bot: [V: 04-1] Cleanup of old PHPUnit usage, part 3 [core] - 10https://gerrit.wikimedia.org/r/540989 (https://phabricator.wikimedia.org/T192167) (owner: 10MaxSem) [06:25:47] 10MediaWiki-extensions-Nuke: Mass delete shows deleted pages - https://phabricator.wikimedia.org/T234422 (10Seb35) Nuke does not permanently delete pages, but only delete them in the normal way (i.e. admins can still access and restore them). If you want to permanently delete pages, you have to install and use... [06:40:57] 10WMEE: Send a welcome mail with final instructions - https://phabricator.wikimedia.org/T234527 (10tramm) 05Open→03Resolved I got the mail, so closing the issue! [06:40:59] 10WMEE: WikiNEM tasks - https://phabricator.wikimedia.org/T231723 (10tramm) [06:41:54] 10WMSE-Riksarkivet-TORA: P777 Swedish civil parish code/ATA code need care - https://phabricator.wikimedia.org/T227554 (10Salgo60) Pattern that CSN be used by Ksamsök to make the rdf file easier to understand https://twitter.com/datapatterns/status/1180369625663578113?s=21 {F30555318} {F30555321,width = 600} [06:52:50] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "I'm happy with this now and would merge it. But since I added quite some changes in patch sets 3 and 4, I don't think I should be the one " [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/535297 (owner: 10MaxSem) [06:53:30] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Drop old PHPUnit rudiments [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540986 (owner: 10MaxSem) [06:54:00] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Fix old PHPUnit rudiments [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/540987 (owner: 10MaxSem) [06:58:32] (03PS2) 10Thiemo Kreuz (WMDE): revisionlist: Fix bad type hints in RevisionListBase [core] - 10https://gerrit.wikimedia.org/r/540939 [06:59:33] (03CR) 10Thiemo Kreuz (WMDE): "Thanks for the notice! I was aware this would conflict. I rebased it now. Should be ready to go." [core] - 10https://gerrit.wikimedia.org/r/540939 (owner: 10Thiemo Kreuz (WMDE)) [07:00:49] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Cleanup mocking ResultWrapper (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/540903 (owner: 10Umherirrender) [07:01:02] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Fix type hinting for single row [extensions/BlueSpicePageVersion] - 10https://gerrit.wikimedia.org/r/540907 (owner: 10Umherirrender) [07:01:04] (03PS3) 10MaxSem: Cleanup of old PHPUnit usage, part 3 [core] - 10https://gerrit.wikimedia.org/r/540989 (https://phabricator.wikimedia.org/T192167) [07:03:01] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Swap one WebRequest::getIntOrNull by WebRequest::getInt [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/540942 (owner: 10Umherirrender) [07:04:06] (03CR) 10Awight: Return section titles in JSON formatter (031 comment) [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/539906 (https://phabricator.wikimedia.org/T234096) (owner: 10Tsevener) [07:05:00] (03Merged) 10jenkins-bot: Drop old PHPUnit rudiments [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540986 (owner: 10MaxSem) [07:05:02] (03Merged) 10jenkins-bot: Fix old PHPUnit rudiments [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/540987 (owner: 10MaxSem) [07:05:03] (03Merged) 10jenkins-bot: Fix type hinting for single row [extensions/BlueSpicePageVersion] - 10https://gerrit.wikimedia.org/r/540907 (owner: 10Umherirrender) [07:07:59] (03Merged) 10jenkins-bot: Swap one WebRequest::getIntOrNull by WebRequest::getInt [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/540942 (owner: 10Umherirrender) [07:11:43] (03CR) 10jerkins-bot: [V: 04-1] revisionlist: Fix bad type hints in RevisionListBase [core] - 10https://gerrit.wikimedia.org/r/540939 (owner: 10Thiemo Kreuz (WMDE)) [07:18:40] (03CR) 10Umherirrender: NamespaceInfo: use array constants now that we can (031 comment) [core] - 10https://gerrit.wikimedia.org/r/540696 (owner: 10MaxSem) [07:18:42] (03CR) 10Umherirrender: "check php" [core] - 10https://gerrit.wikimedia.org/r/540696 (owner: 10MaxSem) [07:19:18] (03CR) 10Umherirrender: "[It seems there is no php7.0 in "check php"]" [core] - 10https://gerrit.wikimedia.org/r/540696 (owner: 10MaxSem) [07:21:57] (03CR) 10jerkins-bot: [V: 04-1] revisionlist: Fix bad type hints in RevisionListBase [core] - 10https://gerrit.wikimedia.org/r/540939 (owner: 10Thiemo Kreuz (WMDE)) [07:25:02] (03CR) 10Umherirrender: "Why this missed composer.json?" [core] - 10https://gerrit.wikimedia.org/r/516829 (https://phabricator.wikimedia.org/T216165) (owner: 10Jforrester) [07:25:31] (03CR) 10Umherirrender: NamespaceInfo: use array constants now that we can (031 comment) [core] - 10https://gerrit.wikimedia.org/r/540696 (owner: 10MaxSem) [07:27:12] (03PS4) 10MaxSem: NamespaceInfo: use array constants now that we can [core] - 10https://gerrit.wikimedia.org/r/540696 [07:27:14] (03PS1) 10MaxSem: tests: Nuke everything HHVM-related [core] - 10https://gerrit.wikimedia.org/r/540991 [07:27:46] 10InternetArchiveBot (v2.0): Deploy Internet Archive bot on Telugu Wikipedia (te.wikipedia.org) - https://phabricator.wikimedia.org/T219962 (10Arjunaraoc) @Cyberpower678 , Request your response to the update on the feedback and for speedy deployment. [07:33:40] (03CR) 10Umherirrender: tests: Nuke everything HHVM-related (031 comment) [core] - 10https://gerrit.wikimedia.org/r/540991 (owner: 10MaxSem) [07:36:08] (03CR) 10Umherirrender: revisionlist: Fix bad type hints in RevisionListBase (031 comment) [core] - 10https://gerrit.wikimedia.org/r/540939 (owner: 10Thiemo Kreuz (WMDE)) [07:36:52] (03PS2) 10MaxSem: tests: Nuke everything HHVM-related [core] - 10https://gerrit.wikimedia.org/r/540991 [07:42:40] (03PS1) 10Fomafix: resourceloader: Add array type hints [core] - 10https://gerrit.wikimedia.org/r/540992 [07:45:26] 10MediaWiki-Debug-Logger: $wgDebugToolbar not showing SQL queries - https://phabricator.wikimedia.org/T231742 (10Mainframe98) [07:45:39] (03CR) 10Mainframe98: "Looks like T231742 was created for this by Bawolff." [core] - 10https://gerrit.wikimedia.org/r/540983 (owner: 10Krinkle) [07:47:46] (03CR) 10MaxSem: tests: Nuke everything HHVM-related (031 comment) [core] - 10https://gerrit.wikimedia.org/r/540991 (owner: 10MaxSem) [07:52:22] (03PS3) 10Thiemo Kreuz (WMDE): revisionlist: Fix bad type hints in RevisionListBase [core] - 10https://gerrit.wikimedia.org/r/540939 [07:55:47] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Add array type hints [core] - 10https://gerrit.wikimedia.org/r/540992 (owner: 10Fomafix) [08:03:24] (03PS2) 10Fomafix: resourceloader: Add array type hints [core] - 10https://gerrit.wikimedia.org/r/540992 [08:05:39] (03CR) 10jerkins-bot: [V: 04-1] revisionlist: Fix bad type hints in RevisionListBase [core] - 10https://gerrit.wikimedia.org/r/540939 (owner: 10Thiemo Kreuz (WMDE)) [08:11:04] (03PS4) 10Umherirrender: revisionlist: Fix bad type hints in RevisionListBase [core] - 10https://gerrit.wikimedia.org/r/540939 (owner: 10Thiemo Kreuz (WMDE)) [08:11:26] (03CR) 10Umherirrender: "Removed phan suppression which seems unneeded with this fix" [core] - 10https://gerrit.wikimedia.org/r/540939 (owner: 10Thiemo Kreuz (WMDE)) [08:18:44] (03CR) 10MaxSem: "Because at that point we still had to support HHVM, also one Docker image used during build is still running 7.0, James is working on bump" [core] - 10https://gerrit.wikimedia.org/r/516829 (https://phabricator.wikimedia.org/T216165) (owner: 10Jforrester) [08:21:12] (03PS1) 10MaxSem: Remove more HHVM hacks [core] - 10https://gerrit.wikimedia.org/r/540993 [08:21:59] 10WMSE-Riksarkivet-NAD: Connect LOD Tora church parishes and administrative parishes with Wikidata - https://phabricator.wikimedia.org/T233275 (10Salgo60) [08:24:33] (03CR) 10Umherirrender: [C: 03+2] revisionlist: Fix bad type hints in RevisionListBase [core] - 10https://gerrit.wikimedia.org/r/540939 (owner: 10Thiemo Kreuz (WMDE)) [08:27:14] (03PS1) 10MaxSem: rest: make SimpleHandler abstract now that HHVM is dead [core] - 10https://gerrit.wikimedia.org/r/540994 [08:27:16] (03PS1) 10MaxSem: MovePageFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540995 [08:35:52] (03CR) 10jerkins-bot: [V: 04-1] Remove more HHVM hacks [core] - 10https://gerrit.wikimedia.org/r/540993 (owner: 10MaxSem) [08:40:05] (03Merged) 10jenkins-bot: revisionlist: Fix bad type hints in RevisionListBase [core] - 10https://gerrit.wikimedia.org/r/540939 (owner: 10Thiemo Kreuz (WMDE)) [08:41:26] (03CR) 10jerkins-bot: [V: 04-1] rest: make SimpleHandler abstract now that HHVM is dead [core] - 10https://gerrit.wikimedia.org/r/540994 (owner: 10MaxSem) [08:41:38] (03CR) 10jerkins-bot: [V: 04-1] MovePageFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540995 (owner: 10MaxSem) [08:41:55] (03PS2) 10MaxSem: Remove more HHVM hacks [core] - 10https://gerrit.wikimedia.org/r/540993 [08:41:57] (03PS2) 10MaxSem: rest: make SimpleHandler abstract now that HHVM is dead [core] - 10https://gerrit.wikimedia.org/r/540994 [08:41:59] (03PS2) 10MaxSem: MovePageFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540995 [08:44:35] (03PS3) 10Umherirrender: tests: Remove problematic (bool) casts from UserTest [core] - 10https://gerrit.wikimedia.org/r/539873 (owner: 10Thiemo Kreuz (WMDE)) [08:44:38] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/540939 (owner: 10Thiemo Kreuz (WMDE)) [08:44:40] (03CR) 10Umherirrender: [C: 03+2] tests: Remove problematic (bool) casts from UserTest [core] - 10https://gerrit.wikimedia.org/r/539873 (owner: 10Thiemo Kreuz (WMDE)) [08:51:37] (03PS1) 10MaxSem: BlobStoreFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540997 [08:52:46] (03CR) 10jerkins-bot: [V: 04-1] rest: make SimpleHandler abstract now that HHVM is dead [core] - 10https://gerrit.wikimedia.org/r/540994 (owner: 10MaxSem) [08:56:12] (03CR) 10Daimona Eaytoy: "> According to this search: https://codesearch.wmflabs.org/search/?q=(extends%7Cimplements)%5B%5E%5C%7B%5D%2BMessageLocalizer&i=nope&files" [core] - 10https://gerrit.wikimedia.org/r/439305 (https://phabricator.wikimedia.org/T191666) (owner: 10Umherirrender) [08:57:09] (03Merged) 10jenkins-bot: tests: Remove problematic (bool) casts from UserTest [core] - 10https://gerrit.wikimedia.org/r/539873 (owner: 10Thiemo Kreuz (WMDE)) [08:57:12] (03CR) 10jenkins-bot: tests: Remove problematic (bool) casts from UserTest [core] - 10https://gerrit.wikimedia.org/r/539873 (owner: 10Thiemo Kreuz (WMDE)) [08:58:54] (03CR) 10jerkins-bot: [V: 04-1] MovePageFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540995 (owner: 10MaxSem) [08:59:29] (03CR) 10jerkins-bot: [V: 04-1] Remove more HHVM hacks [core] - 10https://gerrit.wikimedia.org/r/540993 (owner: 10MaxSem) [09:00:41] (03CR) 10jerkins-bot: [V: 04-1] rest: make SimpleHandler abstract now that HHVM is dead [core] - 10https://gerrit.wikimedia.org/r/540994 (owner: 10MaxSem) [09:00:56] 04(no projects): Problem with decimal separator in numbers - https://phabricator.wikimedia.org/T234680 (10Aklapper) @Antohabio: Does it work with `\xc2\xa0` instead of `\u{00A0}`? In general, this might be a support question and not (yet) a bug report. :) [09:02:37] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/539873 (owner: 10Thiemo Kreuz (WMDE)) [09:02:44] (03PS3) 10MaxSem: Remove more HHVM hacks [core] - 10https://gerrit.wikimedia.org/r/540993 [09:02:47] (03PS3) 10MaxSem: rest: make SimpleHandler abstract now that HHVM is dead [core] - 10https://gerrit.wikimedia.org/r/540994 [09:02:49] (03PS3) 10MaxSem: MovePageFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540995 [09:02:51] (03PS2) 10MaxSem: BlobStoreFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540997 [09:05:37] (03CR) 10jerkins-bot: [V: 04-1] BlobStoreFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540997 (owner: 10MaxSem) [09:05:43] (03CR) 10jerkins-bot: [V: 04-1] BlobStoreFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540997 (owner: 10MaxSem) [09:05:45] (03CR) 10jerkins-bot: [V: 04-1] BlobStoreFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540997 (owner: 10MaxSem) [09:17:44] (03CR) 10jenkins-bot: tests: Remove problematic (bool) casts from UserTest [core] - 10https://gerrit.wikimedia.org/r/539873 (owner: 10Thiemo Kreuz (WMDE)) [09:19:05] 10AbuseFilter: Syntax checker fails to account for scoping - https://phabricator.wikimedia.org/T234690 (10Daimona) Heh, this is mostly working as intended... The parser hoists any variable it finds in skipped branches. This was introduced for T214674, because some filters were doing: ` condition_that_can_be_fal... [09:19:27] (03CR) 10Daimona Eaytoy: Log deprecated vars in the cached phase in the new parser (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/540383 (https://phabricator.wikimedia.org/T234427) (owner: 10Daimona Eaytoy) [09:19:53] (03PS5) 10Daimona Eaytoy: Log deprecated vars in the cached phase in the new parser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/540383 (https://phabricator.wikimedia.org/T234427) [09:20:37] (03PS6) 10Daimona Eaytoy: Log deprecated vars in the cached phase in the new parser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/540383 (https://phabricator.wikimedia.org/T234427) [09:20:45] (03CR) 10jerkins-bot: [V: 04-1] Remove more HHVM hacks [core] - 10https://gerrit.wikimedia.org/r/540993 (owner: 10MaxSem) [09:20:53] (03CR) 10jenkins-bot: tests: Remove problematic (bool) casts from UserTest [core] - 10https://gerrit.wikimedia.org/r/539873 (owner: 10Thiemo Kreuz (WMDE)) [09:20:58] (03PS7) 10Daimona Eaytoy: Log deprecated vars in the cached phase in the new parser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/540383 (https://phabricator.wikimedia.org/T234427) [09:21:00] (03CR) 10jerkins-bot: [V: 04-1] rest: make SimpleHandler abstract now that HHVM is dead [core] - 10https://gerrit.wikimedia.org/r/540994 (owner: 10MaxSem) [09:21:25] (03CR) 10jerkins-bot: [V: 04-1] BlobStoreFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540997 (owner: 10MaxSem) [09:21:44] (03CR) 10jerkins-bot: [V: 04-1] MovePageFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540995 (owner: 10MaxSem) [09:23:24] (03CR) 10Mobrovac: "As stated in PS1, I wonder if setting the variable's default value to $wgMainStash would be more appropriate than null" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540729 (https://phabricator.wikimedia.org/T222851) (owner: 10Catrope) [09:23:36] (03CR) 10Daimona Eaytoy: [C: 03+2] Cleanup of old PHPUnit usage, part 2 [core] - 10https://gerrit.wikimedia.org/r/540988 (https://phabricator.wikimedia.org/T192167) (owner: 10MaxSem) [09:26:09] (03CR) 10Mobrovac: "What is the performance implication of TTL-ing records? Will that cause full-table scans? If so, isn't it cheaper to keep the data around " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/540975 (https://phabricator.wikimedia.org/T222851) (owner: 10Catrope) [09:26:55] (03PS68) 10Daimona Eaytoy: Add a new class representing single filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/480069 (https://phabricator.wikimedia.org/T213037) [09:28:46] (03PS69) 10Daimona Eaytoy: Add a new class representing single filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/480069 (https://phabricator.wikimedia.org/T213037) [09:29:52] (03CR) 10Daimona Eaytoy: Hard-deprecate AbuseFilter::checkAllFilters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539703 (owner: 10Daimona Eaytoy) [09:30:02] 10WMSE-Riksarkivet-NAD: Create a regex for TORA P4820 - https://phabricator.wikimedia.org/T234706 (10Salgo60) [09:30:15] 10WMSE-Riksarkivet-NAD: Create a regexp for TORA P4820 - https://phabricator.wikimedia.org/T234706 (10Salgo60) [09:31:03] (03CR) 10jerkins-bot: [V: 04-1] Add a new class representing single filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/480069 (https://phabricator.wikimedia.org/T213037) (owner: 10Daimona Eaytoy) [09:32:57] (03CR) 10jerkins-bot: [V: 04-1] rest: make SimpleHandler abstract now that HHVM is dead [core] - 10https://gerrit.wikimedia.org/r/540994 (owner: 10MaxSem) [09:33:28] (03CR) 10jerkins-bot: [V: 04-1] Remove more HHVM hacks [core] - 10https://gerrit.wikimedia.org/r/540993 (owner: 10MaxSem) [09:36:24] 10Product-Analytics: Measure % of edits and pvs coming from users without JS - https://phabricator.wikimedia.org/T234695 (10Aklapper) [09:36:32] 04(no projects): Problem with decimal separator in numbers - https://phabricator.wikimedia.org/T234680 (10Aklapper) 05Open→03Stalled [09:36:38] (03CR) 10Daimona Eaytoy: "2.2.13 was released" [tools/phan] - 10https://gerrit.wikimedia.org/r/536651 (https://phabricator.wikimedia.org/T232949) (owner: 10Daimona Eaytoy) [09:36:52] 10Product-Analytics: "Content" equivalent of pageviews daily or edits_hourly available to use in Turnilo and Superset - https://phabricator.wikimedia.org/T234701 (10Aklapper) [09:37:09] (03CR) 10Umherirrender: "But when subclassing a class which implements MessageLocalzier, than it is very unlike that this subclass overrides msg() from the parent " [core] - 10https://gerrit.wikimedia.org/r/439305 (https://phabricator.wikimedia.org/T191666) (owner: 10Umherirrender) [09:37:36] (03Merged) 10jenkins-bot: Cleanup of old PHPUnit usage, part 2 [core] - 10https://gerrit.wikimedia.org/r/540988 (https://phabricator.wikimedia.org/T192167) (owner: 10MaxSem) [09:37:47] (03CR) 10jerkins-bot: [V: 04-1] Remove more HHVM hacks [core] - 10https://gerrit.wikimedia.org/r/540993 (owner: 10MaxSem) [09:37:58] (03CR) 10jerkins-bot: [V: 04-1] MovePageFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540995 (owner: 10MaxSem) [09:38:13] (03CR) 10jerkins-bot: [V: 04-1] BlobStoreFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540997 (owner: 10MaxSem) [09:38:48] (03CR) 10Daimona Eaytoy: "> But when subclassing a class which implements MessageLocalzier," [core] - 10https://gerrit.wikimedia.org/r/439305 (https://phabricator.wikimedia.org/T191666) (owner: 10Umherirrender) [09:40:08] (03PS1) 10Daimona Eaytoy: Use varargs for IContextSource::msg [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/540998 [09:40:36] (03PS2) 10Daimona Eaytoy: Use varargs for IContextSource::msg [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/540998 [09:42:18] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/540988 (https://phabricator.wikimedia.org/T192167) (owner: 10MaxSem) [09:42:34] (03CR) 10jerkins-bot: [V: 04-1] BlobStoreFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540997 (owner: 10MaxSem) [09:43:33] (03CR) 10Daimona Eaytoy: [C: 03+1] "Can be merged as soon as I71e1c527e29bbffe4f32b6e5eedbc49efed0c2a5 is merged." [core] - 10https://gerrit.wikimedia.org/r/439305 (https://phabricator.wikimedia.org/T191666) (owner: 10Umherirrender) [09:44:33] 10AbuseFilter, 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), 10MW-1.34-release, 10MW-1.35-notes (1.35.0-wmf.1; 2019-10-08): Hard-deprecate use of disabled variables - https://phabricator.wikimedia.org/T234048 (10Daimona) 05Open→03Resolved [09:48:38] (03CR) 10Daimona Eaytoy: [C: 03+2] NamespaceInfo: use array constants now that we can [core] - 10https://gerrit.wikimedia.org/r/540696 (owner: 10MaxSem) [09:52:03] (03CR) 10jerkins-bot: [V: 04-1] MovePageFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540995 (owner: 10MaxSem) [09:56:42] (03CR) 10Daimona Eaytoy: tests: Nuke everything HHVM-related (031 comment) [core] - 10https://gerrit.wikimedia.org/r/540991 (owner: 10MaxSem) [09:58:12] (03CR) 10jerkins-bot: [V: 04-1] Add a new class representing single filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/480069 (https://phabricator.wikimedia.org/T213037) (owner: 10Daimona Eaytoy) [10:02:50] (03CR) 10Daimona Eaytoy: Remove more HHVM hacks (032 comments) [core] - 10https://gerrit.wikimedia.org/r/540993 (owner: 10MaxSem) [10:03:54] (03PS3) 10Umherirrender: Use varargs for IContextSource::msg [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/540998 (owner: 10Daimona Eaytoy) [10:04:10] (03CR) 10Umherirrender: [C: 03+1] "Changed to use ...$params, than it looks similar to I7a029b75141b6682bc567ea65bc8744beb6dc93d" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/540998 (owner: 10Daimona Eaytoy) [10:04:35] (03Merged) 10jenkins-bot: NamespaceInfo: use array constants now that we can [core] - 10https://gerrit.wikimedia.org/r/540696 (owner: 10MaxSem) [10:04:40] (03CR) 10Daimona Eaytoy: [C: 03+1] "> Changed to use ...$params, than it looks similar to" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/540998 (owner: 10Daimona Eaytoy) [10:06:09] (03PS1) 10Daimona Eaytoy: Really require PHP 7.2+ [tools/phan] - 10https://gerrit.wikimedia.org/r/540999 [10:06:22] (03PS2) 10Daimona Eaytoy: Really require PHP 7.2+ [tools/phan] - 10https://gerrit.wikimedia.org/r/540999 [10:06:40] 10Phabricator: Some users can't add the fr-tech private task form to their task selection menu. - https://phabricator.wikimedia.org/T229628 (10Aklapper) 05Resolved→03Declined > I don't have the capacity to help other people use developer tools and many people see that as too complicated to attempt. If it is... [10:06:47] (03CR) 10jerkins-bot: [V: 04-1] Really require PHP 7.2+ [tools/phan] - 10https://gerrit.wikimedia.org/r/540999 (owner: 10Daimona Eaytoy) [10:09:16] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/540696 (owner: 10MaxSem) [10:11:15] 10MediaWiki-API, 10Core Platform Team Workboards (Clinic Duty Team): API sometimes does not return consistent data (sha1 does not match content) - https://phabricator.wikimedia.org/T234530 (10Wurgl) okay, the empty data seems to be solvable, I got the following response from the API: (showing just the relevant... [10:17:10] (03PS3) 10Daimona Eaytoy: Really require PHP 7.2+ [tools/phan] - 10https://gerrit.wikimedia.org/r/540999 [10:17:35] (03CR) 10jerkins-bot: [V: 04-1] Really require PHP 7.2+ [tools/phan] - 10https://gerrit.wikimedia.org/r/540999 (owner: 10Daimona Eaytoy) [10:25:33] 10MediaWiki-Core-Testing, 10MediaWiki-General, 10phan: Support phan in MediaWiki's default composer.json - https://phabricator.wikimedia.org/T220589 (10Daimona) 05Stalled→03Open Can be worked on now. For what concerns php-ast, we only need to make sure that phan will use the fallback parser if php-ast is... [10:25:50] 10MediaWiki-General: Bump symfony libraries when we no longer need hhvm support - https://phabricator.wikimedia.org/T196206 (10Daimona) 05Stalled→03Open [10:36:26] 10AbuseFilter: Allow hiding all abusefilter hits in a specific time range - https://phabricator.wikimedia.org/T234707 (10Bugreporter) [10:41:52] 10AbuseFilter: Allow hiding all abusefilter hits in a specific time range - https://phabricator.wikimedia.org/T234707 (10Bugreporter) [10:44:13] 10Phabricator, 10Operations, 10Traffic: Access Forbidden to Phabricator at WikiArabia 2019 (Morocco) - https://phabricator.wikimedia.org/T234598 (10Aklapper) [10:47:02] 10MediaWiki-General, 10MediaWiki-Parser: The TemplateParser do an unnecessary HTML entity encoding - https://phabricator.wikimedia.org/T234705 (10Aklapper) [10:50:18] 10MediaWiki-extensions-OATHAuth, 10MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), 10Wikimedia-production-error: Error trying to enable 2FA on testwiki: "Call to a member function getSecret() on a non-object (array)" - https://phabricator.wikimedia.org/T231786 (10SD0001) 05Resolved→03Open @Reedy, @ItSpiderman... [10:50:20] 10MediaWiki-extensions-OATHAuth, 10CPT Initiatives (Two-Factor Authentication (TEC1)), 10Core Platform Team Workboards (Contractor Workboard): SO878 Step 3: Finalize settings and user experience - https://phabricator.wikimedia.org/T218214 (10SD0001) [10:52:06] 10MediaWiki-extensions-FlaggedRevs, 10Code-Stewardship-Reviews, 10Release-Engineering-Team (Code Health): Code stewardship review: FlaggedRevs - https://phabricator.wikimedia.org/T185664 (10Aklapper) @MBH: "Members" on Phab don't mean much, especially when [people have never changed a single line of code in... [11:11:49] 10MediaWiki-Interface, 10MediaWiki-Search, 10Discovery-Search, 10Browser-Support-Android-Google-Chrome, 10Browser-Support-Google-Chrome: Special:Search's search bar improperly responding to highlighting words on Google Chrome - https://phabricator.wikimedia.org/T234170 (10Amorymeltzer) Borked in Chrome b... [11:33:01] (03PS1) 10MarcoAurelio: Manually adding missing extensions [extensions] - 10https://gerrit.wikimedia.org/r/541002 (https://phabricator.wikimedia.org/T234700) [11:33:17] (03CR) 10MarcoAurelio: [V: 03+2 C: 03+2] Manually adding missing extensions [extensions] - 10https://gerrit.wikimedia.org/r/541002 (https://phabricator.wikimedia.org/T234700) (owner: 10MarcoAurelio) [11:34:14] 04(no projects): Video player does not stop playing when closing the window - https://phabricator.wikimedia.org/T234708 (10Der_Keks) [11:47:44] (03CR) 10D3r1ck01: [C: 03+1] "lgtm!" [core] - 10https://gerrit.wikimedia.org/r/538576 (owner: 10Thiemo Kreuz (WMDE)) [12:07:49] (03Abandoned) 10Reedy: Only test on hhvm 3.18 [tools/cookiecutter-library] - 10https://gerrit.wikimedia.org/r/490228 (owner: 10Reedy) [12:09:35] 10Who-Wrote-That: Good article badge comes over the WWT bar - https://phabricator.wikimedia.org/T234709 (10Prtksxna) [12:17:39] 10Design, 10MediaWiki-Special-pages, 10UI-Standardization, 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Tracking): Convert Special:WhatLinksHere to OOUI - https://phabricator.wikimedia.org/T117754 (10matej_suchanek) a:05Sethakill→03None [12:21:33] 10TimedMediaHandler: Video player does not stop playing when closing the window - https://phabricator.wikimedia.org/T234708 (10Aklapper) Hi @Der_Keks, thanks for taking the time to report this! Providing a test case is welcome so others don't have to find one. :) Using Firefox 69 on https://de.wikipedia.org/w... [12:22:05] 10TimedMediaHandler, 10Regression: Video player continues to play the video's audio after closing the popup window - https://phabricator.wikimedia.org/T234708 (10Aklapper) [12:22:24] 10Design, 10UI-Standardization, 10Mobile, 10Patch-For-Review, 10Readers-Web-Backlog (Design): Mobile version Star for Watchlist not consistent - https://phabricator.wikimedia.org/T234550 (10Waddie96) That looks rather good, thank you [12:25:09] 10MediaWiki-Patrolling: Russian Wikinews has sudden patrolling problem - https://phabricator.wikimedia.org/T234715 (10ssr) [12:28:19] (03PS15) 10Fomafix: Strip additional special Unicode characters from title [core] - 10https://gerrit.wikimedia.org/r/493162 (https://phabricator.wikimedia.org/T121979) [12:28:30] (03PS1) 10Reedy: extensions is hard to spell [core] - 10https://gerrit.wikimedia.org/r/541004 [12:30:36] (03CR) 10Fomafix: [C: 03+2] extensions is hard to spell [core] - 10https://gerrit.wikimedia.org/r/541004 (owner: 10Reedy) [12:31:15] 10Anti-Harassment, 10Wikimedia-Site-requests: Enable Partial Blocks on Dutch Wikipedia - https://phabricator.wikimedia.org/T234685 (10Majavah) a:03Majavah [12:41:22] (03PS1) 10Daimona Eaytoy: Move phan/phan to composer require [tools/phan] - 10https://gerrit.wikimedia.org/r/541006 (https://phabricator.wikimedia.org/T220589) [12:41:28] (03CR) 10jerkins-bot: [V: 04-1] Move phan/phan to composer require [tools/phan] - 10https://gerrit.wikimedia.org/r/541006 (https://phabricator.wikimedia.org/T220589) (owner: 10Daimona Eaytoy) [12:41:45] (03CR) 10jerkins-bot: [V: 04-1] Strip additional special Unicode characters from title [core] - 10https://gerrit.wikimedia.org/r/493162 (https://phabricator.wikimedia.org/T121979) (owner: 10Fomafix) [12:42:23] (03Merged) 10jenkins-bot: extensions is hard to spell [core] - 10https://gerrit.wikimedia.org/r/541004 (owner: 10Reedy) [12:42:26] (03PS1) 10D3r1ck01: MWHttpRequest: Avoid usage of deprecated Http class methods [core] - 10https://gerrit.wikimedia.org/r/541007 [12:44:11] 10MediaWiki-Patrolling: Russian Wikinews has sudden patrolling problem - https://phabricator.wikimedia.org/T234715 (10Aklapper) [12:44:57] 10Anti-Harassment, 10Wikimedia-Site-requests: Enable Partial Blocks on Dutch Wikipedia - https://phabricator.wikimedia.org/T234685 (10Majavah) [12:45:45] (03CR) 10D3r1ck01: "will redo this when I have the time." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/536739 (owner: 10D3r1ck01) [12:45:50] (03Abandoned) 10D3r1ck01: Rename ExtMobileFrontend.php to MobileFrontend.php like other extensions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/536739 (owner: 10D3r1ck01) [12:46:01] (03Abandoned) 10D3r1ck01: specials: Fix broken table view for the Special:Version page [core] - 10https://gerrit.wikimedia.org/r/532712 (https://phabricator.wikimedia.org/T231323) (owner: 10D3r1ck01) [12:47:13] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/541004 (owner: 10Reedy) [12:47:26] (03Abandoned) 10D3r1ck01: Avoid usage of deprecated CommentStore::getStore() method [core] - 10https://gerrit.wikimedia.org/r/507274 (owner: 10D3r1ck01) [12:48:07] 10MediaWiki-extensions-OATHAuth, 10CPT Initiatives (Two-Factor Authentication (TEC1)), 10Core Platform Team Workboards (Contractor Workboard): SO878 Step 3: Finalize settings and user experience - https://phabricator.wikimedia.org/T218214 (10Reedy) [12:48:09] 10MediaWiki-extensions-OATHAuth, 10MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), 10Wikimedia-production-error: Error trying to enable 2FA on testwiki: "Call to a member function getSecret() on a non-object (array)" - https://phabricator.wikimedia.org/T231786 (10Reedy) 05Open→03Resolved >>! In T231786#554893... [12:48:14] 10MediaWiki-Patrolling: Russian Wikinews has sudden patrolling problem - https://phabricator.wikimedia.org/T234715 (10Aklapper) Hmm, what do these templates do exactly and how is this problem related to the patrolling code in the MediaWiki software? It sounds like there are two different and separate steps: >... [12:52:54] (03CR) 10jenkins-bot: extensions is hard to spell [core] - 10https://gerrit.wikimedia.org/r/541004 (owner: 10Reedy) [12:56:37] (03CR) 10jerkins-bot: [V: 04-1] Strip additional special Unicode characters from title [core] - 10https://gerrit.wikimedia.org/r/493162 (https://phabricator.wikimedia.org/T121979) (owner: 10Fomafix) [12:56:39] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/541007 (owner: 10D3r1ck01) [12:59:00] 10MediaWiki-General: Bump symfony libraries when we no longer need hhvm support - https://phabricator.wikimedia.org/T196206 (10Reedy) p:05Low→03Normal [13:12:24] 10MediaWiki-Core-Testing, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), 10Patch-For-Review, 10phan: Butcher the list of phan suppressions in MW core - https://phabricator.wikimedia.org/T231636 (10Daimona) 05Stalled→03Open [13:14:07] (03CR) 10jerkins-bot: [V: 04-1] Strip additional special Unicode characters from title [core] - 10https://gerrit.wikimedia.org/r/493162 (https://phabricator.wikimedia.org/T121979) (owner: 10Fomafix) [13:32:45] 10MediaWiki-Core-Testing, 10Code-Health-Metrics, 10Code-Health: Provide an alternative way to use MediaWikiUnitTestCase for tests not in unit/ - https://phabricator.wikimedia.org/T234721 (10Daimona) [13:34:06] 10Anti-Harassment, 10Wikimedia-Site-requests, 10Patch-For-Review: Enable Partial Blocks on Dutch Wikipedia - https://phabricator.wikimedia.org/T234685 (10Urbanecm) p:05Triage→03Normal [13:34:32] 10MediaWiki-Core-Testing, 10MediaWiki-General, 10Patch-For-Review, 10phan: Support phan in MediaWiki's default composer.json - https://phabricator.wikimedia.org/T220589 (10Daimona) a:03Daimona [13:44:23] (03CR) 10Daimona Eaytoy: [C: 03+2] Cleanup of old PHPUnit usage, part 3 [core] - 10https://gerrit.wikimedia.org/r/540989 (https://phabricator.wikimedia.org/T192167) (owner: 10MaxSem) [13:57:06] (03Merged) 10jenkins-bot: Cleanup of old PHPUnit usage, part 3 [core] - 10https://gerrit.wikimedia.org/r/540989 (https://phabricator.wikimedia.org/T192167) (owner: 10MaxSem) [14:01:47] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/540989 (https://phabricator.wikimedia.org/T192167) (owner: 10MaxSem) [14:06:11] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.1, 10Growth-Team (Current Sprint): Newcomer tasks: evaluate topic matching prototypes - https://phabricator.wikimedia.org/T234272 (10Urbanecm) >>! In T234272#5544385, @Urbanecm wrote: > Hello, I've noticed that for cs/Arts at least, it gives different results e... [14:06:50] 10Wikipedia-Android-App-Backlog: Wikipedia mobile app talk page link links to incorrect page when outside mainspace - https://phabricator.wikimedia.org/T234722 (10Monniasza) [14:12:27] 10MediaWiki-Patrolling: Russian Wikinews has sudden patrolling problem - https://phabricator.wikimedia.org/T234715 (10ssr) Patrolling is needed for several other things like approving non-editor edits to articles and to comments — there are "Комментарии:" space for comments like here https://ru.wikinews.org/wiki... [14:14:30] (03CR) 10Pwirth: [C: 03+2] Use varargs for IContextSource::msg [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/540998 (owner: 10Daimona Eaytoy) [14:15:05] (03CR) 10Pwirth: [C: 03+2] Allow operations on Title in page store [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/540839 (owner: 10ItSpiderman) [14:15:11] (03PS1) 10Pwirth: Allow operations on Title in page store [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/541013 [14:15:15] (03CR) 10Pwirth: [V: 03+2 C: 03+2] Allow operations on Title in page store [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/541013 (owner: 10Pwirth) [14:17:55] (03CR) 10Pwirth: [C: 03+2] Add category store [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/540859 (owner: 10ItSpiderman) [14:18:00] (03PS1) 10Pwirth: Add category store [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/541014 [14:18:05] (03CR) 10Pwirth: [V: 03+2 C: 03+2] Add category store [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/541014 (owner: 10Pwirth) [14:19:39] (03Merged) 10jenkins-bot: Use varargs for IContextSource::msg [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/540998 (owner: 10Daimona Eaytoy) [14:19:41] (03Merged) 10jenkins-bot: Allow operations on Title in page store [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/540839 (owner: 10ItSpiderman) [14:20:58] (03Merged) 10jenkins-bot: Add category store [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/540859 (owner: 10ItSpiderman) [14:24:36] 10Wikipedia-Android-App-Backlog: Wikipedia mobile app talk page link links to incorrect page when outside mainspace - https://phabricator.wikimedia.org/T234722 (10Ammarpad) [14:32:44] 10MediaWiki-Patrolling: Russian Wikinews has sudden patrolling problem - https://phabricator.wikimedia.org/T234715 (10ssr) Also there is this: "unpublished" articles should not appear in these side boxes: https://ru.wikinews.org/wiki/Фонд_Викимедиа_зарегистрировал_ячейку_в_Санкт-Петербурге — boxes with violet he... [14:40:56] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.1, 10Growth-Team (Current Sprint): Newcomer tasks: evaluate topic matching prototypes (ar) - https://phabricator.wikimedia.org/T234348 (10Dyolf77_WMF) >>! In T234348#5542089, @MMiller_WMF wrote: > @Dyolf77_WMF -- I wanted to let you know that the ORES prototype... [14:45:56] 10MediaWiki-User-management, 10MediaWiki-extensions-FlaggedRevs, 10Release-Engineering-Team, 10User-DannyS712: Pending changes: autoreview randomly fails - https://phabricator.wikimedia.org/T233561 (10Neolexx) Since Sep.23 (this bag open by en-wiki user) it seems that there is not any progress. At ru-wiki... [14:46:47] (03PS7) 10BPirkle: Add filter options to Core REST API page history handler [core] - 10https://gerrit.wikimedia.org/r/540002 (https://phabricator.wikimedia.org/T231597) [15:00:56] 10MediaWiki-User-management, 10MediaWiki-extensions-FlaggedRevs, 10Release-Engineering-Team, 10User-DannyS712: Pending changes: autoreview randomly fails - https://phabricator.wikimedia.org/T233561 (10Neolexx) >>! In T233561#5544804, @Neolexx wrote: > [[https://ru.wikipedia.org/wiki/Википедия:Форум/Техниче... [15:16:11] 10MediaWiki-Patrolling: Russian Wikinews has sudden patrolling problem - https://phabricator.wikimedia.org/T234715 (10Aklapper) > "Publication" should mean only combination of {{yes}} and a patrol. Does that imply that there is no problem with MediaWiki's Patrolling in this task, but "only" with "publication" i... [15:22:45] 10MediaWiki-Patrolling: Russian Wikinews has sudden patrolling problem - https://phabricator.wikimedia.org/T234715 (10DannyS712) Potentially related: {T233561} [15:27:00] (03PS3) 10Krinkle: resourceloader: Add array type hints [core] - 10https://gerrit.wikimedia.org/r/540992 (owner: 10Fomafix) [15:27:24] (03CR) 10Krinkle: [C: 03+2] "Thanks!" [core] - 10https://gerrit.wikimedia.org/r/540992 (owner: 10Fomafix) [15:34:20] 10Anti-Harassment (The Letter Song): Refactor ApiMain to use OutputPage::sendCacheControl - https://phabricator.wikimedia.org/T233597 (10dbarratt) [15:34:25] 10MediaWiki-User-management, 10Anti-Harassment (The Letter Song), 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review: Add block cookie for browser-based API edits (including VisualEditor & MobileFrontend) - https://phabricator.wikimedia.org/T196575 (10dbarratt) [15:35:55] 10MediaWiki-User-management, 10Anti-Harassment (The Letter Song), 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review: Add block cookie for browser-based API edits (including VisualEditor & MobileFrontend) - https://phabricator.wikimedia.org/T196575 (10dbarratt) [15:36:00] 10MediaWiki-User-management, 10Trust-and-Safety, 10Anti-Harassment (AHT Sprint 21/22), 10Patch-For-Review: Add cookie when blocking anonymous users - https://phabricator.wikimedia.org/T152462 (10dbarratt) [15:36:04] 10MediaWiki-User-management, 10Trust-and-Safety, 10Anti-Harassment (AHT Sprint 21/22), 10Patch-For-Review: Add cookie when blocking anonymous users - https://phabricator.wikimedia.org/T152462 (10dbarratt) [15:36:06] 10MediaWiki-User-management, 10Anti-Harassment (The Letter Song), 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review: Add block cookie for browser-based API edits (including VisualEditor & MobileFrontend) - https://phabricator.wikimedia.org/T196575 (10dbarratt) [15:40:49] (03PS1) 10Daimona Eaytoy: Replace setExpectedException with single arg [core] - 10https://gerrit.wikimedia.org/r/541018 (https://phabricator.wikimedia.org/T192167) [15:42:31] (03Merged) 10jenkins-bot: resourceloader: Add array type hints [core] - 10https://gerrit.wikimedia.org/r/540992 (owner: 10Fomafix) [15:43:44] (03PS1) 10Daimona Eaytoy: Replace setExpectedException with two args [core] - 10https://gerrit.wikimedia.org/r/541019 (https://phabricator.wikimedia.org/T192167) [15:46:57] (03PS1) 10Daimona Eaytoy: Replace getMock with createMock [core] - 10https://gerrit.wikimedia.org/r/541020 (https://phabricator.wikimedia.org/T192167) [15:47:10] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/540992 (owner: 10Fomafix) [15:48:29] (03CR) 10Ladsgroup: [C: 03+2] Cleanup use of Wikimedia\Rdbms\ResultWrapper [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/540902 (owner: 10Umherirrender) [15:50:55] (03PS2) 10Dbarratt: Add block cookie for API edits [core] - 10https://gerrit.wikimedia.org/r/528596 (https://phabricator.wikimedia.org/T196575) [15:53:16] (03Merged) 10jenkins-bot: Cleanup use of Wikimedia\Rdbms\ResultWrapper [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/540902 (owner: 10Umherirrender) [15:54:58] (03PS1) 10TK-999: PPFrame: Use explicit varargs in method parameters [core] - 10https://gerrit.wikimedia.org/r/541021 (https://phabricator.wikimedia.org/T231710) [15:55:35] (03CR) 10jenkins-bot: resourceloader: Add array type hints [core] - 10https://gerrit.wikimedia.org/r/540992 (owner: 10Fomafix) [15:57:28] (03CR) 10Daimona Eaytoy: [C: 04-1] PPFrame: Use explicit varargs in method parameters (031 comment) [core] - 10https://gerrit.wikimedia.org/r/541021 (https://phabricator.wikimedia.org/T231710) (owner: 10TK-999) [15:57:30] (03CR) 10TK-999: [C: 03+1] Replace setExpectedException with single arg [core] - 10https://gerrit.wikimedia.org/r/541018 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [15:58:01] (03CR) 10jerkins-bot: [V: 04-1] Replace setExpectedException with two args [core] - 10https://gerrit.wikimedia.org/r/541019 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [15:59:15] (03CR) 10Ladsgroup: [C: 03+2] selenium: Fix more inefficient MWBot use and simplify wdio-mediawiki Api [core] - 10https://gerrit.wikimedia.org/r/540004 (https://phabricator.wikimedia.org/T234002) (owner: 10Krinkle) [15:59:38] (03PS2) 10TK-999: PPFrame: Use explicit varargs in method parameters [core] - 10https://gerrit.wikimedia.org/r/541021 (https://phabricator.wikimedia.org/T231710) [15:59:55] (03CR) 10TK-999: PPFrame: Use explicit varargs in method parameters (031 comment) [core] - 10https://gerrit.wikimedia.org/r/541021 (https://phabricator.wikimedia.org/T231710) (owner: 10TK-999) [16:01:09] (03PS1) 10Aaron Schulz: Make OutputHandler::emitContentLength() handle HTTP 1.1 requests [core] - 10https://gerrit.wikimedia.org/r/541022 [16:02:54] (03CR) 10Daimona Eaytoy: Add block cookie for API edits (031 comment) [core] - 10https://gerrit.wikimedia.org/r/528596 (https://phabricator.wikimedia.org/T196575) (owner: 10Dbarratt) [16:04:06] (03PS1) 10TK-999: PermissionManager: Use explicit varargs in method parameters [core] - 10https://gerrit.wikimedia.org/r/541023 (https://phabricator.wikimedia.org/T231710) [16:04:46] (03CR) 10Daimona Eaytoy: [C: 04-1] PPFrame: Use explicit varargs in method parameters (031 comment) [core] - 10https://gerrit.wikimedia.org/r/541021 (https://phabricator.wikimedia.org/T231710) (owner: 10TK-999) [16:05:54] (03CR) 10Daimona Eaytoy: [C: 03+1] PermissionManager: Use explicit varargs in method parameters [core] - 10https://gerrit.wikimedia.org/r/541023 (https://phabricator.wikimedia.org/T231710) (owner: 10TK-999) [16:06:32] (03CR) 10jerkins-bot: [V: 04-1] Add block cookie for API edits [core] - 10https://gerrit.wikimedia.org/r/528596 (https://phabricator.wikimedia.org/T196575) (owner: 10Dbarratt) [16:06:37] (03PS3) 10TK-999: PPFrame: Use explicit varargs in method parameters [core] - 10https://gerrit.wikimedia.org/r/541021 (https://phabricator.wikimedia.org/T231710) [16:06:45] (03CR) 10jerkins-bot: [V: 04-1] Replace setExpectedException with two args [core] - 10https://gerrit.wikimedia.org/r/541019 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [16:07:04] (03CR) 10Daimona Eaytoy: [C: 03+1] PPFrame: Use explicit varargs in method parameters [core] - 10https://gerrit.wikimedia.org/r/541021 (https://phabricator.wikimedia.org/T231710) (owner: 10TK-999) [16:08:24] (03CR) 10jenkins-bot: resourceloader: Add array type hints [core] - 10https://gerrit.wikimedia.org/r/540992 (owner: 10Fomafix) [16:11:04] (03PS10) 10BPirkle: Core REST API handler for GET page history [core] - 10https://gerrit.wikimedia.org/r/538133 (https://phabricator.wikimedia.org/T231558) [16:11:47] (03CR) 10TK-999: PPFrame: Use explicit varargs in method parameters (031 comment) [core] - 10https://gerrit.wikimedia.org/r/541021 (https://phabricator.wikimedia.org/T231710) (owner: 10TK-999) [16:14:11] (03PS2) 10Daimona Eaytoy: Replace setExpectedException with two args [core] - 10https://gerrit.wikimedia.org/r/541019 (https://phabricator.wikimedia.org/T192167) [16:14:38] (03Merged) 10jenkins-bot: selenium: Fix more inefficient MWBot use and simplify wdio-mediawiki Api [core] - 10https://gerrit.wikimedia.org/r/540004 (https://phabricator.wikimedia.org/T234002) (owner: 10Krinkle) [16:15:54] 10MediaWiki-Core-Testing, 10Code-Health-Metrics, 10Code-Health: Provide an alternative way to use MediaWikiUnitTestCase for tests not in unit/ - https://phabricator.wikimedia.org/T234721 (10Daimona) p:05Triage→03High [16:16:22] (03CR) 10jerkins-bot: [V: 04-1] Add block cookie for API edits [core] - 10https://gerrit.wikimedia.org/r/528596 (https://phabricator.wikimedia.org/T196575) (owner: 10Dbarratt) [16:17:19] (03CR) 10Daimona Eaytoy: [C: 03+2] PermissionManager: Use explicit varargs in method parameters [core] - 10https://gerrit.wikimedia.org/r/541023 (https://phabricator.wikimedia.org/T231710) (owner: 10TK-999) [16:18:54] (03CR) 10Daimona Eaytoy: [C: 03+2] PPFrame: Use explicit varargs in method parameters [core] - 10https://gerrit.wikimedia.org/r/541021 (https://phabricator.wikimedia.org/T231710) (owner: 10TK-999) [16:20:42] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/540004 (https://phabricator.wikimedia.org/T234002) (owner: 10Krinkle) [16:23:42] (03Abandoned) 10Dbarratt: Add block cookie for API edits [core] - 10https://gerrit.wikimedia.org/r/528596 (https://phabricator.wikimedia.org/T196575) (owner: 10Dbarratt) [16:28:26] (03PS1) 10TK-999: BaseTemplate: Use explicit varargs in method parameters [core] - 10https://gerrit.wikimedia.org/r/541024 (https://phabricator.wikimedia.org/T231710) [16:29:28] (03Merged) 10jenkins-bot: PermissionManager: Use explicit varargs in method parameters [core] - 10https://gerrit.wikimedia.org/r/541023 (https://phabricator.wikimedia.org/T231710) (owner: 10TK-999) [16:30:21] (03PS8) 10BPirkle: Add filter options to Core REST API page history handler [core] - 10https://gerrit.wikimedia.org/r/540002 (https://phabricator.wikimedia.org/T231597) [16:31:42] (03Merged) 10jenkins-bot: PPFrame: Use explicit varargs in method parameters [core] - 10https://gerrit.wikimedia.org/r/541021 (https://phabricator.wikimedia.org/T231710) (owner: 10TK-999) [16:32:33] (03CR) 10Daimona Eaytoy: [C: 03+1] "(I've verified that nothing is overriding this method)" [core] - 10https://gerrit.wikimedia.org/r/541024 (https://phabricator.wikimedia.org/T231710) (owner: 10TK-999) [16:34:02] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/541023 (https://phabricator.wikimedia.org/T231710) (owner: 10TK-999) [16:36:00] (03CR) 10Daimona Eaytoy: [C: 03+1] "I see that you've documented the message params as string|string[]." [core] - 10https://gerrit.wikimedia.org/r/439305 (https://phabricator.wikimedia.org/T191666) (owner: 10Umherirrender) [16:38:24] 10MediaWiki-General, 10Beta-Cluster-reproducible: PHP fatal error: syntax error, unexpected T_CONST, expecting T_VARIABLE - https://phabricator.wikimedia.org/T234723 (10Mholloway) [16:38:57] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/541021 (https://phabricator.wikimedia.org/T231710) (owner: 10TK-999) [16:40:35] (03CR) 10Mholloway: "I think this caused https://phabricator.wikimedia.org/T234723." [core] - 10https://gerrit.wikimedia.org/r/540696 (owner: 10MaxSem) [16:40:58] (03CR) 10jenkins-bot: PermissionManager: Use explicit varargs in method parameters [core] - 10https://gerrit.wikimedia.org/r/541023 (https://phabricator.wikimedia.org/T231710) (owner: 10TK-999) [16:41:46] 10MediaWiki-General, 10Beta-Cluster-reproducible: PHP fatal error: syntax error, unexpected T_CONST, expecting T_VARIABLE - https://phabricator.wikimedia.org/T234723 (10Daimona) It's definitely culprit, but... WTF? That error can only happen on HHVM, and we're not running on HHVM anymore, right??? [16:46:24] 04(no projects): Problem with decimal separator in numbers - https://phabricator.wikimedia.org/T234680 (10Antohabio) >>! In T234680#5548882, @Aklapper wrote: > @Antohabio: Does it work with `\xc2\xa0` instead of `\u{00A0}`? No, this not working. `\u{00A0}` I copied from Russian language files. [16:46:45] (03PS20) 10Fomafix: resourceloader: Add parameter 'dir' to loader URLs [core] - 10https://gerrit.wikimedia.org/r/518688 (https://phabricator.wikimedia.org/T225845) [16:48:35] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: move Wikidata section to the top of Special:SpecialPages - https://phabricator.wikimedia.org/T47607 (10Uzume) @jeblad: This seems like a problem: * https://gerrit.wikimedia.org/r/51826 Merged {rEWBA0e1ead00bb01d1438d87f05cb93212a5d7c0412c} * https://gerrit... [16:52:26] 10MediaWiki-General, 10Beta-Cluster-reproducible: PHP fatal error: syntax error, unexpected T_CONST, expecting T_VARIABLE - https://phabricator.wikimedia.org/T234723 (10Mholloway) Interestingly, for me, requests from Chromium are served with PHP7.2 and are fine, but all other clients (FF, curl, MCS) are served... [16:53:54] 10MediaWiki-General, 10Beta-Cluster-reproducible: PHP fatal error: syntax error, unexpected T_CONST, expecting T_VARIABLE - https://phabricator.wikimedia.org/T234723 (10Mainframe98) >>! In T234723#5549250, @Daimona wrote: > It's definitely culprit, but... WTF? That error can only happen on HHVM, and we're not... [16:55:43] (03PS1) 10TK-999: MWExceptionHandler: Remove HHVM-specific behavior [core] - 10https://gerrit.wikimedia.org/r/541025 [16:56:40] (03CR) 10Daimona Eaytoy: [C: 03+2] BaseTemplate: Use explicit varargs in method parameters [core] - 10https://gerrit.wikimedia.org/r/541024 (https://phabricator.wikimedia.org/T231710) (owner: 10TK-999) [16:57:57] 10MediaWiki-General, 10Beta-Cluster-reproducible: PHP fatal error: syntax error, unexpected T_CONST, expecting T_VARIABLE - https://phabricator.wikimedia.org/T234723 (10Krenair) >>! In T234723#5549250, @Daimona wrote: > It's definitely culprit, but... WTF? That error can only happen on HHVM, and we're not runn... [16:58:21] 10MediaWiki-General, 10Beta-Cluster-reproducible: PHP fatal error: syntax error, unexpected T_CONST, expecting T_VARIABLE - https://phabricator.wikimedia.org/T234723 (10Krenair) a:03Krenair [16:58:54] (03CR) 10MaxSem: tests: Nuke everything HHVM-related (031 comment) [core] - 10https://gerrit.wikimedia.org/r/540991 (owner: 10MaxSem) [16:59:12] (03PS2) 10TK-999: MWExceptionHandler: Remove HHVM-specific behavior [core] - 10https://gerrit.wikimedia.org/r/541025 [17:00:32] (03CR) 10Daimona Eaytoy: tests: Nuke everything HHVM-related (031 comment) [core] - 10https://gerrit.wikimedia.org/r/540991 (owner: 10MaxSem) [17:02:09] 10MediaWiki-Patrolling: Russian Wikinews has sudden patrolling problem - https://phabricator.wikimedia.org/T234715 (10ssr) >>! In T234715#5549197, @Aklapper wrote: >> "Publication" should mean only combination of {{yes}} and a patrol. > > Does that imply that there is no problem with MediaWiki's Patrolling in t... [17:03:15] 10MediaWiki-General, 10Beta-Cluster-reproducible: PHP fatal error: syntax error, unexpected T_CONST, expecting T_VARIABLE - https://phabricator.wikimedia.org/T234723 (10Krenair) added ` profile::mediawiki::vhost_feature_flags: php72_only: true ` to deployment-mediawiki-09, like we did with deployment-mediawi... [17:04:55] 10MediaWiki-General, 10Beta-Cluster-reproducible: PHP fatal error: syntax error, unexpected T_CONST, expecting T_VARIABLE - https://phabricator.wikimedia.org/T234723 (10Krenair) shinken seems happy: ` RECOVERY - App Server Main HTTP Response on deployment-mediawiki-09 is OK: HTTP OK: HTTP/1.1 200 O... [17:05:03] 10MediaWiki-General, 10Beta-Cluster-reproducible: PHP fatal error: syntax error, unexpected T_CONST, expecting T_VARIABLE - https://phabricator.wikimedia.org/T234723 (10Mholloway) Looking good here. [17:16:53] (03Merged) 10jenkins-bot: BaseTemplate: Use explicit varargs in method parameters [core] - 10https://gerrit.wikimedia.org/r/541024 (https://phabricator.wikimedia.org/T231710) (owner: 10TK-999) [17:21:59] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/541024 (https://phabricator.wikimedia.org/T231710) (owner: 10TK-999) [17:22:15] 10MediaWiki-Patrolling: Russian Wikinews has sudden patrolling problem - https://phabricator.wikimedia.org/T234715 (10ssr) I just can now add that patrolling also affects comments https://ru.wikinews.org/wiki/Комментарии:Фонд_Викимедиа_зарегистрировал_ячейку_в_Санкт-Петербурге It is connected in a complicated w... [17:24:04] (03PS1) 10Daimona Eaytoy: Align arg counting between the parsers [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/541028 (https://phabricator.wikimedia.org/T156095) [17:43:51] (03PS11) 10Umherirrender: Use varargs for MessageLocalizer::msg and similar [core] - 10https://gerrit.wikimedia.org/r/439305 (https://phabricator.wikimedia.org/T191666) [17:44:15] (03CR) 10Umherirrender: "mixed sounds good, I have changed it" [core] - 10https://gerrit.wikimedia.org/r/439305 (https://phabricator.wikimedia.org/T191666) (owner: 10Umherirrender) [17:44:28] (03CR) 10jerkins-bot: [V: 04-1] Use varargs for MessageLocalizer::msg and similar [core] - 10https://gerrit.wikimedia.org/r/439305 (https://phabricator.wikimedia.org/T191666) (owner: 10Umherirrender) [17:44:40] (03PS3) 10MaxSem: tests: Nuke everything HHVM-related [core] - 10https://gerrit.wikimedia.org/r/540991 [17:44:42] (03PS4) 10MaxSem: Remove more HHVM hacks [core] - 10https://gerrit.wikimedia.org/r/540993 [17:44:44] (03PS4) 10MaxSem: rest: make SimpleHandler abstract now that HHVM is dead [core] - 10https://gerrit.wikimedia.org/r/540994 [17:44:46] (03PS4) 10MaxSem: MovePageFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540995 [17:44:48] (03PS3) 10MaxSem: BlobStoreFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540997 [17:44:50] (03CR) 10jerkins-bot: [V: 04-1] Use varargs for MessageLocalizer::msg and similar [core] - 10https://gerrit.wikimedia.org/r/439305 (https://phabricator.wikimedia.org/T191666) (owner: 10Umherirrender) [17:44:53] (03CR) 10Daimona Eaytoy: [C: 03+2] "> mixed sounds good, I have changed it" [core] - 10https://gerrit.wikimedia.org/r/439305 (https://phabricator.wikimedia.org/T191666) (owner: 10Umherirrender) [17:45:01] (03CR) 10MaxSem: tests: Nuke everything HHVM-related (031 comment) [core] - 10https://gerrit.wikimedia.org/r/540991 (owner: 10MaxSem) [17:45:13] (03CR) 10MaxSem: Remove more HHVM hacks (032 comments) [core] - 10https://gerrit.wikimedia.org/r/540993 (owner: 10MaxSem) [17:47:07] (03CR) 10Daimona Eaytoy: tests: Nuke everything HHVM-related (031 comment) [core] - 10https://gerrit.wikimedia.org/r/540991 (owner: 10MaxSem) [17:47:19] (03PS12) 10Umherirrender: Use varargs for MessageLocalizer::msg and similar [core] - 10https://gerrit.wikimedia.org/r/439305 (https://phabricator.wikimedia.org/T191666) [17:47:23] (03CR) 10Daimona Eaytoy: [C: 03+2] "> > mixed sounds good, I have changed it" [core] - 10https://gerrit.wikimedia.org/r/439305 (https://phabricator.wikimedia.org/T191666) (owner: 10Umherirrender) [17:47:29] (03CR) 10jerkins-bot: [V: 04-1] phan: Remove suppression for PhanParamTooMany [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/540821 (owner: 10Umherirrender) [17:47:31] (03CR) 10jerkins-bot: [V: 04-1] phan: Remove suppression for PhanParamTooMany [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/540823 (owner: 10Umherirrender) [17:47:33] (03CR) 10jerkins-bot: [V: 04-1] phan: Remove suppression for PhanParamTooMany [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/540820 (owner: 10Umherirrender) [17:47:35] (03CR) 10jerkins-bot: [V: 04-1] phan: Remove suppression for PhanParamTooMany [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/540829 (owner: 10Umherirrender) [17:47:37] (03CR) 10jerkins-bot: [V: 04-1] phan: Remove suppression for PhanParamTooMany [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/540818 (owner: 10Umherirrender) [17:47:39] (03CR) 10jerkins-bot: [V: 04-1] phan: Remove suppression for PhanParamTooMany [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/540817 (owner: 10Umherirrender) [17:47:56] (03PS13) 10Umherirrender: Use varargs for MessageLocalizer::msg and similar [core] - 10https://gerrit.wikimedia.org/r/439305 (https://phabricator.wikimedia.org/T191666) [17:47:59] (03CR) 10Daimona Eaytoy: Use varargs for MessageLocalizer::msg and similar (031 comment) [core] - 10https://gerrit.wikimedia.org/r/439305 (https://phabricator.wikimedia.org/T191666) (owner: 10Umherirrender) [17:48:02] (03CR) 10Umherirrender: "Rebased" [core] - 10https://gerrit.wikimedia.org/r/439305 (https://phabricator.wikimedia.org/T191666) (owner: 10Umherirrender) [17:48:34] (03CR) 10Daimona Eaytoy: [C: 03+2] "> Rebased" [core] - 10https://gerrit.wikimedia.org/r/439305 (https://phabricator.wikimedia.org/T191666) (owner: 10Umherirrender) [17:48:36] (03CR) 10Umherirrender: Use varargs for MessageLocalizer::msg and similar (031 comment) [core] - 10https://gerrit.wikimedia.org/r/439305 (https://phabricator.wikimedia.org/T191666) (owner: 10Umherirrender) [17:48:54] (03PS1) 10Fomafix: PHPVersionCheck: Use Content-Type: text/plain on text output [core] - 10https://gerrit.wikimedia.org/r/541031 [17:49:39] (03CR) 10Daimona Eaytoy: Remove more HHVM hacks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/540993 (owner: 10MaxSem) [17:49:41] (03CR) 10Umherirrender: "Yah, there was no need for If78bd1556c862a472afe3646fd362b3c6baefbe0 to merge as own patch set, because the same code change was already h" [core] - 10https://gerrit.wikimedia.org/r/439305 (https://phabricator.wikimedia.org/T191666) (owner: 10Umherirrender) [17:54:30] 10MediaWiki-Patrolling: Russian Wikinews has sudden patrolling problem - https://phabricator.wikimedia.org/T234715 (10ssr) Oh, yes, feel free to make test edits if you like. As long as it's not late night here (Moscow time), I will try to help with it as I can [18:04:11] (03CR) 10jerkins-bot: [V: 04-1] MovePageFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540995 (owner: 10MaxSem) [18:06:32] (03CR) 10jerkins-bot: [V: 04-1] BlobStoreFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540997 (owner: 10MaxSem) [18:14:00] (03Merged) 10jenkins-bot: Use varargs for MessageLocalizer::msg and similar [core] - 10https://gerrit.wikimedia.org/r/439305 (https://phabricator.wikimedia.org/T191666) (owner: 10Umherirrender) [18:14:03] (03Merged) 10jenkins-bot: phan: Remove suppression for PhanParamTooMany [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/540818 (owner: 10Umherirrender) [18:15:12] (03PS6) 10Umherirrender: phan: Remove suppression for PhanParamTooMany [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540828 [18:16:53] (03PS1) 10Borjianamin: Fix [extensions/examples] - 10https://gerrit.wikimedia.org/r/541033 [18:17:06] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/examples] - 10https://gerrit.wikimedia.org/r/541033 (owner: 10Borjianamin) [18:18:05] (03Merged) 10jenkins-bot: phan: Remove suppression for PhanParamTooMany [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/540817 (owner: 10Umherirrender) [18:18:47] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/439305 (https://phabricator.wikimedia.org/T191666) (owner: 10Umherirrender) [18:19:10] (03Merged) 10jenkins-bot: phan: Remove suppression for PhanParamTooMany [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/540829 (owner: 10Umherirrender) [18:19:50] (03PS2) 10Borjianamin: Fix Make it bbetter [extensions/examples] - 10https://gerrit.wikimedia.org/r/541033 [18:20:39] (03PS1) 10Borjianamin: WHY? [extensions/examples] - 10https://gerrit.wikimedia.org/r/541034 [18:22:02] (03PS2) 10Borjianamin: WHY? Hi [extensions/examples] - 10https://gerrit.wikimedia.org/r/541034 [18:23:20] (03CR) 10Daimona Eaytoy: [C: 03+2] phan: Remove suppression for PhanParamTooMany [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540828 (owner: 10Umherirrender) [18:25:53] (03CR) 10jerkins-bot: [V: 04-1] BlobStoreFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540997 (owner: 10MaxSem) [18:26:33] (03Merged) 10jenkins-bot: phan: Remove suppression for PhanParamTooMany [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/540823 (owner: 10Umherirrender) [18:26:35] (03Merged) 10jenkins-bot: phan: Remove suppression for PhanParamTooMany [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/540820 (owner: 10Umherirrender) [18:27:29] (03CR) 10jerkins-bot: [V: 04-1] MovePageFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540995 (owner: 10MaxSem) [18:28:28] (03CR) 10jerkins-bot: [V: 04-1] BlobStoreFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540997 (owner: 10MaxSem) [18:29:37] (03Merged) 10jenkins-bot: phan: Remove suppression for PhanParamTooMany [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/540821 (owner: 10Umherirrender) [18:30:59] (03CR) 10jenkins-bot: Use varargs for MessageLocalizer::msg and similar [core] - 10https://gerrit.wikimedia.org/r/439305 (https://phabricator.wikimedia.org/T191666) (owner: 10Umherirrender) [18:32:44] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Good for me. :-)" [core] - 10https://gerrit.wikimedia.org/r/541031 (owner: 10Fomafix) [18:34:13] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Pass ignore option for insert as array to IDatabase->insert [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/540862 (owner: 10Umherirrender) [18:37:06] (03Merged) 10jenkins-bot: phan: Remove suppression for PhanParamTooMany [extensions/Flow] - 10https://gerrit.wikimedia.org/r/540828 (owner: 10Umherirrender) [18:39:02] (03CR) 10jenkins-bot: Use varargs for MessageLocalizer::msg and similar [core] - 10https://gerrit.wikimedia.org/r/439305 (https://phabricator.wikimedia.org/T191666) (owner: 10Umherirrender) [18:39:05] (03Merged) 10jenkins-bot: Pass ignore option for insert as array to IDatabase->insert [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/540862 (owner: 10Umherirrender) [18:41:03] (03CR) 10jerkins-bot: [V: 04-1] MovePageFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540995 (owner: 10MaxSem) [18:45:01] 10MediaWiki-Parser, 10OWC2020, 10Patch-For-Review: Use a parser function to encapsulate signatures - https://phabricator.wikimedia.org/T230653 (10Izno) Some thoughts, some of which are in the gist of the above discussion and some of which are new points. Take care to consider most of the content of [[https:... [18:54:09] 10WMSE-Riksarkivet-NAD: Create a regexp for TORA P4820 - https://phabricator.wikimedia.org/T234706 (10Salgo60) [18:57:22] 10MediaWiki-Patrolling: Russian Wikinews has sudden patrolling problem - https://phabricator.wikimedia.org/T234715 (10Neolexx) >>! In T234715#5549200, @DannyS712 wrote: > Potentially related: {T233561} I don't see so far how it could be related. Unless we group by the criterion "something strange all suddenly s... [19:01:57] (03PS2) 10Fomafix: PHPVersionCheck: Use Content-Type: text/plain on text output [core] - 10https://gerrit.wikimedia.org/r/541031 [19:15:02] (03CR) 10Krinkle: [C: 03+2] Replace setExpectedException with single arg [core] - 10https://gerrit.wikimedia.org/r/541018 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [19:22:16] (03CR) 10Krinkle: [C: 04-1] PHPVersionCheck: Use Content-Type: text/plain on text output (032 comments) [core] - 10https://gerrit.wikimedia.org/r/541031 (owner: 10Fomafix) [19:23:07] 10MediaWiki-Parser: New syntax for multiline list items / talk page comments - https://phabricator.wikimedia.org/T230683 (10Izno) I agree entirely with Anomie in T230683#5434186. His shot at a mockup is a bit reddit-ish too, which seems to be accepted elsewhere.... > If they are willing to use new markup for ta... [19:23:42] (03CR) 10Krinkle: [C: 04-1] PHPVersionCheck: Use Content-Type: text/plain on text output (031 comment) [core] - 10https://gerrit.wikimedia.org/r/541031 (owner: 10Fomafix) [19:25:48] (03CR) 10Krinkle: [C: 03+1] Use mustache template in img_auth.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/540876 (owner: 10Fomafix) [19:26:16] 10MediaWiki-HTML-Templating: The TemplateParser do an unnecessary HTML entity encoding - https://phabricator.wikimedia.org/T234705 (10Krinkle) [19:27:51] (03Merged) 10jenkins-bot: Replace setExpectedException with single arg [core] - 10https://gerrit.wikimedia.org/r/541018 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [19:30:09] (03PS1) 10Ladsgroup: Clean up most of b/c for phpunit4 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/541036 [19:31:15] (03PS1) 10Ladsgroup: Clean up most of b/c for phpunit4 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/541037 [19:32:33] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/541018 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [19:33:41] (03PS1) 10Ladsgroup: Clean up most of b/c for phpunit4 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/541039 [19:34:11] (03CR) 10jerkins-bot: [V: 04-1] Clean up most of b/c for phpunit4 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/541037 (owner: 10Ladsgroup) [19:36:50] (03CR) 10jerkins-bot: [V: 04-1] Clean up most of b/c for phpunit4 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/541037 (owner: 10Ladsgroup) [19:39:10] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/541036 (owner: 10Ladsgroup) [19:42:01] 10MediaWiki-Parser, 10OWC2020: Syntax for list item attributes - https://phabricator.wikimedia.org/T230658 (10Izno) Syntax for attributes is something I made a task for at {T202083} which I closed duplicate of the problem I was looking to solve in that context. General gist I suggested was similar to the table... [19:52:57] (03PS4) 10MaxSem: BlobStoreFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540997 [19:55:18] (03PS5) 10MaxSem: MovePageFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540995 [19:56:03] (03PS5) 10MaxSem: rest: make SimpleHandler abstract now that HHVM is dead [core] - 10https://gerrit.wikimedia.org/r/540994 [19:57:43] (03PS4) 10MaxSem: tests: Nuke everything HHVM-related [core] - 10https://gerrit.wikimedia.org/r/540991 [19:57:45] (03PS5) 10MaxSem: Remove more HHVM hacks [core] - 10https://gerrit.wikimedia.org/r/540993 [19:59:09] 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-CentralAuth: Reload the page automatically instead of showing centralauth-centralautologin-logged-in - https://phabricator.wikimedia.org/T234724 (10Amire80) [20:02:46] (03PS1) 10MaxSem: BlockManager: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/541041 [20:07:18] (03CR) 10Daimona Eaytoy: [C: 03+2] tests: Nuke everything HHVM-related [core] - 10https://gerrit.wikimedia.org/r/540991 (owner: 10MaxSem) [20:07:32] (03PS6) 10MaxSem: Remove more HHVM hacks [core] - 10https://gerrit.wikimedia.org/r/540993 [20:08:10] (03CR) 10MaxSem: Remove more HHVM hacks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/540993 (owner: 10MaxSem) [20:09:32] (03CR) 10jerkins-bot: [V: 04-1] BlobStoreFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540997 (owner: 10MaxSem) [20:13:50] (03CR) 10MaxSem: [C: 03+2] Clean up most of b/c for phpunit4 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/541036 (owner: 10Ladsgroup) [20:15:39] (03CR) 10MaxSem: [C: 03+2] Clean up most of b/c for phpunit4 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/541039 (owner: 10Ladsgroup) [20:15:49] (03CR) 10jerkins-bot: [V: 04-1] BlockManager: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/541041 (owner: 10MaxSem) [20:16:02] (03CR) 10jerkins-bot: [V: 04-1] BlobStoreFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540997 (owner: 10MaxSem) [20:17:46] 10Design, 10MonoBook, 10CSS, 10Readers-Web-Backlog (Design): Something strange with a:visited link color in Monobook skin - https://phabricator.wikimedia.org/T191401 (10Izno) a:05Mustafa.fatal→03None [20:18:07] 10MediaWiki-General: WikiHiero does not display in mobile version of Wikipedia - https://phabricator.wikimedia.org/T234725 (10A._Parrot) [20:21:21] (03CR) 10jerkins-bot: [V: 04-1] BlobStoreFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540997 (owner: 10MaxSem) [20:21:30] (03Merged) 10jenkins-bot: tests: Nuke everything HHVM-related [core] - 10https://gerrit.wikimedia.org/r/540991 (owner: 10MaxSem) [20:21:53] 10Browser-Support-Firefox, 10CSS, 10Patch-For-Review, 10Regression: Advanced search looks all bunched into right hand column on enwikipedia - https://phabricator.wikimedia.org/T176499 (10Izno) This looks to have been resolved @Legoktm @Volker_E ? [20:22:41] (03CR) 10Daimona Eaytoy: "I added this comment referring to run() (see comment above). Looking at it again, if the signature can strongly vary between subclasses, i" [core] - 10https://gerrit.wikimedia.org/r/540994 (owner: 10MaxSem) [20:23:57] (03CR) 10Daimona Eaytoy: Remove more HHVM hacks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/540993 (owner: 10MaxSem) [20:24:33] (03CR) 10jenkins-bot: tests: Nuke everything HHVM-related [core] - 10https://gerrit.wikimedia.org/r/540991 (owner: 10MaxSem) [20:24:36] (03CR) 10Fomafix: PHPVersionCheck: Use Content-Type: text/plain on text output (033 comments) [core] - 10https://gerrit.wikimedia.org/r/541031 (owner: 10Fomafix) [20:26:31] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/540991 (owner: 10MaxSem) [20:28:12] (03CR) 10jerkins-bot: [V: 04-1] BlockManager: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/541041 (owner: 10MaxSem) [20:31:51] (03CR) 10jerkins-bot: [V: 04-1] BlockManager: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/541041 (owner: 10MaxSem) [20:35:30] 10MediaWiki-extensions-Nuke: Titles with non-DB-normalised keys are not recognised - https://phabricator.wikimedia.org/T234726 (10Seb35) [20:35:52] (03CR) 10jenkins-bot: tests: Nuke everything HHVM-related [core] - 10https://gerrit.wikimedia.org/r/540991 (owner: 10MaxSem) [20:41:02] 10MediaWiki-Patrolling: Russian Wikinews has sudden patrolling problem - https://phabricator.wikimedia.org/T234715 (10ssr) Well, I have updates now. The problem is in DynamicPageList extension. ( {{yes}} template may be ignored now ) DynamicPageList extension directly influences "publication" process. By def... [20:48:08] (03Merged) 10jenkins-bot: Clean up most of b/c for phpunit4 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/541036 (owner: 10Ladsgroup) [20:48:10] (03Merged) 10jenkins-bot: Clean up most of b/c for phpunit4 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/541039 (owner: 10Ladsgroup) [20:50:20] 10MediaWiki-Patrolling: Russian Wikinews has sudden patrolling problem - https://phabricator.wikimedia.org/T234715 (10ssr) Local DynamicPageList description https://ru.wikinews.org/wiki/Викиновости:DynamicPageList Local DynamicPageList example: https://ru.wikinews.org/wiki/Шаблон:Последние_новости_по_теме [21:01:52] (03PS2) 10Fomafix: Use Mustache template in img_auth.php [core] - 10https://gerrit.wikimedia.org/r/540876 [21:01:57] (03CR) 10Fomafix: [C: 04-1] Use Mustache template in img_auth.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/540876 (owner: 10Fomafix) [21:04:50] 10MediaWiki-extensions-Scribunto, 10CodeEditor: Links to lines of modules in Scribunto error popup do not work - https://phabricator.wikimedia.org/T234729 (10Erutuon) [21:06:14] 10MediaWiki-extensions-Scribunto, 10CodeEditor: Links to lines of modules in Scribunto error popup do not work - https://phabricator.wikimedia.org/T234729 (10Erutuon) [21:09:35] 04(no projects): Elliott to estimate old tasks - https://phabricator.wikimedia.org/T234730 (10DStrine) [21:17:58] (03CR) 10Pppery: "This seems to me like a change that needs some discussion before being implemented." [core] - 10https://gerrit.wikimedia.org/r/538972 (https://phabricator.wikimedia.org/T232940) (owner: 10DannyS712) [21:20:38] 10Phabricator: Reset 2FA for Phabricator account `Apap04` - https://phabricator.wikimedia.org/T234233 (10Apap04) @bd808 Done. [21:41:20] (03PS3) 10BPirkle: Core REST API handler for GET Page Revision [core] - 10https://gerrit.wikimedia.org/r/537221 (https://phabricator.wikimedia.org/T231588) [21:42:35] (03PS5) 10MaxSem: BlobStoreFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540997 [21:43:09] 10MediaWiki-Page-editing: Highlighted area moves while scrolling the old wikitext editor on desktop site via iOS/iPadOS - https://phabricator.wikimedia.org/T234482 (10gh87) I tested the similar issue at [[https://abcnews.go.com/Politics/wireStory/warren-dismisses-top-staffer-inappropriate-behavior-66083576|one o... [21:44:22] (03PS7) 10MaxSem: Remove more HHVM hacks [core] - 10https://gerrit.wikimedia.org/r/540993 [21:44:30] (03CR) 10MaxSem: Remove more HHVM hacks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/540993 (owner: 10MaxSem) [21:44:31] 10MediaWiki-Page-editing: Highlighted area moves while scrolling the old wikitext editor on desktop site via iOS/iPadOS - https://phabricator.wikimedia.org/T234482 (10gh87) [21:47:21] (03CR) 10MaxSem: [C: 03+2] Drop strings for wgExternalDiffEngine, deprecated in 1.27 and 1.32 [core] - 10https://gerrit.wikimedia.org/r/520328 (owner: 10Jforrester) [21:51:43] 10MobileFrontend, 10I18n, 10RTL: N'Ko (nqo) is shown as LTR in the list of languages on mobile web - https://phabricator.wikimedia.org/T234731 (10Amire80) [21:52:03] (03PS1) 10Amire80: Add nqo to rtlLanguages.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/541044 (https://phabricator.wikimedia.org/T234731) [21:53:31] (03CR) 10DannyS712: "> This seems to me like a change that needs some discussion before" [core] - 10https://gerrit.wikimedia.org/r/538972 (https://phabricator.wikimedia.org/T232940) (owner: 10DannyS712) [21:55:58] (03Abandoned) 10Ladsgroup: WHY? Hi [extensions/examples] - 10https://gerrit.wikimedia.org/r/541034 (owner: 10Borjianamin) [21:56:18] (03Abandoned) 10Ladsgroup: Fix Make it bbetter [extensions/examples] - 10https://gerrit.wikimedia.org/r/541033 (owner: 10Borjianamin) [22:01:16] 10Wikimedia-Site-requests: Enable on/off switch for MediaWiki extensions - https://phabricator.wikimedia.org/T234732 (10Klein) [22:01:17] (03CR) 10Daimona Eaytoy: Remove more HHVM hacks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/540993 (owner: 10MaxSem) [22:02:02] 10Phabricator: Reset 2FA for Phabricator account `Apap04` - https://phabricator.wikimedia.org/T234233 (10bd808) >>! In T234233#5549465, @Apap04 wrote: > @bd808 Done. ` $ ssh bastion.wmflabs.org $ ls -lh ~apap04/2fa-reset-request.txt -rw-r--r-- 1 apap04 wikidev 56 Oct 5 21:19 /home/apap04/2fa-reset-request.txt... [22:02:47] (03CR) 10MaxSem: [C: 03+2] Add nqo to rtlLanguages.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/541044 (https://phabricator.wikimedia.org/T234731) (owner: 10Amire80) [22:06:46] 10MediaWiki-Special-pages, 10UI-Standardization: User field in OOUI Special:Contributions is very short - https://phabricator.wikimedia.org/T234733 (10Izno) [22:07:24] 10MediaWiki-Special-pages, 10UI-Standardization, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2), 10UI-Standardization-Kanban, and 2 others: Convert Special:Contributions to OOUI - https://phabricator.wikimedia.org/T117736 (10Izno) I added {T234733} as a post-rollout subtask. [22:08:03] 10MediaWiki-Special-pages, 10UI-Standardization, 10Readers-Web-Backlog, 10UI-Standardization-Kanban: Special:Contributions – add 'pinning' functionality to collapsible form? - https://phabricator.wikimedia.org/T234569 (10Izno) [22:08:08] 10MediaWiki-Special-pages, 10UI-Standardization, 10Readers-Web-Backlog (Kanbanana-2019-20-Q2), 10UI-Standardization-Kanban, and 2 others: Convert Special:Contributions to OOUI - https://phabricator.wikimedia.org/T117736 (10Izno) [22:11:48] (03PS2) 10Ladsgroup: Clean up most of b/c for phpunit4 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/541037 [22:12:46] 10MediaWiki-Special-pages, 10UI-Standardization: User field in OOUI Special:Contributions is very short - https://phabricator.wikimedia.org/T234733 (10Izno) [22:14:20] (03Merged) 10jenkins-bot: Drop strings for wgExternalDiffEngine, deprecated in 1.27 and 1.32 [core] - 10https://gerrit.wikimedia.org/r/520328 (owner: 10Jforrester) [22:14:49] 10MediaWiki-Special-pages, 10UI-Standardization, 10Readers-Web-Backlog, 10UI-Standardization-Kanban: Special:Contributions – add 'pinning' functionality to collapsible form? - https://phabricator.wikimedia.org/T234569 (10Izno) [22:15:09] (03PS1) 10Ladsgroup: Clean up most of b/c for phpunit4 [core] - 10https://gerrit.wikimedia.org/r/541045 [22:16:57] (03Merged) 10jenkins-bot: Add nqo to rtlLanguages.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/541044 (https://phabricator.wikimedia.org/T234731) (owner: 10Amire80) [22:19:10] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/520328 (owner: 10Jforrester) [22:30:22] 10Outreachy (Round 19): Your second task: classify statements within an article - https://phabricator.wikimedia.org/T234606 (10Achillesheel02) Hi @Samwalton9 , Which section takes precedence? I noticed there's different levels and was wondering about which one to use. [22:34:53] 10MediaWiki-Page-editing: Highlighted area moves while scrolling on iOS/iPadOS - https://phabricator.wikimedia.org/T234482 (10gh87) [22:37:19] 04(no projects): Add Mediawiki-Vagrant infopage for bcmath - https://phabricator.wikimedia.org/T234734 (10jeblad) [22:37:52] 10MediaWiki-Vagrant: Add Mediawiki-Vagrant infopage for bcmath - https://phabricator.wikimedia.org/T234734 (10jeblad) [22:46:27] 10MediaWiki-Configuration: Enable on/off switch for MediaWiki extensions - https://phabricator.wikimedia.org/T234732 (10Bugreporter) [22:46:50] 10MediaWiki-Configuration: Enable on/off switch for MediaWiki extensions - https://phabricator.wikimedia.org/T234732 (10Bugreporter) [22:46:53] 10MediaWiki-Configuration, 10Core Platform Team: Graphical configuration interface - https://phabricator.wikimedia.org/T388 (10Bugreporter) [23:23:05] 10MobileFrontend, 10I18n, 10MW-1.35-notes (1.35.0-wmf.1; 2019-10-08), 10RTL: N'Ko (nqo) is shown as LTR in the list of languages on mobile web - https://phabricator.wikimedia.org/T234731 (10Huji) 05Open→03Resolved a:03Huji [23:29:19] (03CR) 10MaxSem: [C: 03+2] Replace setExpectedException with two args [core] - 10https://gerrit.wikimedia.org/r/541019 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [23:30:52] (03CR) 10MaxSem: [C: 03+2] Replace getMock with createMock [core] - 10https://gerrit.wikimedia.org/r/541020 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [23:31:10] (03PS1) 10John Erling Blad: Added infopage for BCmath [vagrant] - 10https://gerrit.wikimedia.org/r/541048 (https://phabricator.wikimedia.org/T234734) [23:37:27] 10MediaWiki-Special-pages, 10UI-Standardization: User field in OOUI Special:Contributions is very short - https://phabricator.wikimedia.org/T234733 (10Ammarpad) The user name field is already of the same width as the namespace selector. Chrome 77.0.3865.90/macOS {F30561102} [23:39:18] (03PS1) 10MaxSem: tests: Use ::class to get class name [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/541049 [23:39:20] (03PS1) 10MaxSem: ApiMobileViewTest: Remove check for an ancient PHPUnit version [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/541050 [23:41:03] (03Merged) 10jenkins-bot: Replace setExpectedException with two args [core] - 10https://gerrit.wikimedia.org/r/541019 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [23:45:46] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/541019 (https://phabricator.wikimedia.org/T192167) (owner: 10Daimona Eaytoy) [23:46:39] 10UI-Standardization, 10CheckUser, 10good first bug: CheckUser should not hardcode parentheses in the HTML - https://phabricator.wikimedia.org/T223872 (10Ammarpad) [23:49:20] (03PS1) 10MaxSem: Convert Bugzilla links to Phabricator [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/541052 [23:52:27] (03PS8) 10Krinkle: Remove more HHVM hacks [core] - 10https://gerrit.wikimedia.org/r/540993 (owner: 10MaxSem) [23:53:30] (03CR) 10Krinkle: Remove more HHVM hacks (032 comments) [core] - 10https://gerrit.wikimedia.org/r/540993 (owner: 10MaxSem) [23:56:08] (03CR) 10Krinkle: Remove more HHVM hacks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/540993 (owner: 10MaxSem) [23:56:53] (03CR) 10MaxSem: [C: 03+2] Clean up most of b/c for phpunit4 [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/541037 (owner: 10Ladsgroup) [23:56:55] (03PS9) 10Krinkle: Remove more HHVM hacks [core] - 10https://gerrit.wikimedia.org/r/540993 (owner: 10MaxSem) [23:56:57] (03CR) 10Krinkle: [C: 03+1] Remove more HHVM hacks [core] - 10https://gerrit.wikimedia.org/r/540993 (owner: 10MaxSem) [23:57:23] (03PS6) 10Krinkle: BlobStoreFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540997 (owner: 10MaxSem) [23:57:46] (03CR) 10Krinkle: BlobStoreFactory: make $constructorOptions a constant (031 comment) [core] - 10https://gerrit.wikimedia.org/r/540997 (owner: 10MaxSem) [23:57:49] (03CR) 10Krinkle: [C: 03+1] BlobStoreFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540997 (owner: 10MaxSem) [23:58:03] (03CR) 10Krinkle: [C: 03+2] MovePageFactory: make $constructorOptions a constant [core] - 10https://gerrit.wikimedia.org/r/540995 (owner: 10MaxSem) [23:58:36] (03CR) 10Krinkle: [C: 03+1] rest: make SimpleHandler abstract now that HHVM is dead [core] - 10https://gerrit.wikimedia.org/r/540994 (owner: 10MaxSem) [23:58:38] (03CR) 10Krinkle: [C: 03+2] tests: Use ::class to get class name [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/541049 (owner: 10MaxSem) [23:58:41] (03CR) 10Krinkle: [C: 03+2] ApiMobileViewTest: Remove check for an ancient PHPUnit version [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/541050 (owner: 10MaxSem)