[00:04:13] 10GrowthExperiments, 10Product-Analytics, 10Growth-Team (Current Sprint): Deploy Help Panel to Basque Wikipedia - https://phabricator.wikimedia.org/T233065 (10MMiller_WMF) @Theklan -- would you be willing to turn on the help panel for your own account (or make a new account), and try out all its capabilities... [00:08:56] (03Merged) 10jenkins-bot: Improve print LESS variable setting and handling [skins/Vector] - 10https://gerrit.wikimedia.org/r/539415 (owner: 10VolkerE) [00:26:02] 10OWC2020: On-wiki communication research - https://phabricator.wikimedia.org/T233882 (10ppelberg) === 27-Sep === Researching... - //[What is fundamental to all kinds of conversations and discussions](https://docs.google.com/document/d/1LIPMnnYjxwzxMXLkyYKyVfHjRgQoDa9TXH5lhCFeKiY/edit#heading=h.a837vglr557x)//... [00:27:34] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01): Newcomer tasks: welcome survey changes - https://phabricator.wikimedia.org/T232400 (10MMiller_WMF) @Etonkovidova -- the shortened version of the Thank you page is supposed to be... [00:33:34] 10Design, 10Community-Tech, 10Dark-Mode: Dark mode content SVG image handling - https://phabricator.wikimedia.org/T234111 (10Volker_E) [00:40:57] 10Design, 10Community-Tech, 10Dark-Mode: Dark mode content SVG image handling - https://phabricator.wikimedia.org/T234111 (10Volker_E) [00:41:55] 10Design, 10Community-Tech, 10Dark-Mode: Dark mode content SVG image handling - https://phabricator.wikimedia.org/T234111 (10Volker_E) Added the [[ https://en.wikipedia.org/wiki/User:Volker_E._(WMF)/dark-mode.css | two proposed rules to dark-mode.css ]]. [00:42:12] 10Design, 10Community-Tech, 10Dark-Mode: Dark mode content SVG image handling - https://phabricator.wikimedia.org/T234111 (10Volker_E) a:03alexhollender [00:58:18] (03CR) 10Catrope: [C: 03+2] resourceloader: Add $modules parameter to makeVersionQuery() [core] - 10https://gerrit.wikimedia.org/r/539375 (https://phabricator.wikimedia.org/T233343) (owner: 10Krinkle) [01:03:38] (03CR) 10Catrope: [C: 04-1] "Looks good, thanks for doing this! Some minor -1s inline, all about the commit message or code comments." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/539364 (https://phabricator.wikimedia.org/T233343) (owner: 10Krinkle) [01:04:25] (03PS7) 10Accraze: Implement api modules [extensions/Jade] - 10https://gerrit.wikimedia.org/r/536659 (https://phabricator.wikimedia.org/T199834) [01:04:36] (03CR) 10jerkins-bot: [V: 04-1] Implement api modules [extensions/Jade] - 10https://gerrit.wikimedia.org/r/536659 (https://phabricator.wikimedia.org/T199834) (owner: 10Accraze) [01:04:38] (03CR) 10jerkins-bot: [V: 04-1] Implement api modules [extensions/Jade] - 10https://gerrit.wikimedia.org/r/536659 (https://phabricator.wikimedia.org/T199834) (owner: 10Accraze) [01:05:04] 10Design, 10Dark-Mode: Dark mode content SVG image handling - https://phabricator.wikimedia.org/T234111 (10Volker_E) [01:06:47] (03PS12) 10Krinkle: resourceloader: Add version to ResourceLoaderImage urls for long-cache [core] - 10https://gerrit.wikimedia.org/r/539364 (https://phabricator.wikimedia.org/T233343) [01:06:49] (03CR) 10Krinkle: resourceloader: Add version to ResourceLoaderImage urls for long-cache (033 comments) [core] - 10https://gerrit.wikimedia.org/r/539364 (https://phabricator.wikimedia.org/T233343) (owner: 10Krinkle) [01:07:03] (03PS5) 10Krinkle: maintenance: Enable gzip in router.php for static files [core] - 10https://gerrit.wikimedia.org/r/539427 (https://phabricator.wikimedia.org/T233992) [01:07:11] (03PS23) 10Krinkle: resources: Remove `@embed` where it may do more harm than good [core] - 10https://gerrit.wikimedia.org/r/525840 (https://phabricator.wikimedia.org/T121730) [01:07:58] 10Design, 10Dark-Mode, 10Epic: Investigate elements that MAY need special handling in Dark Mode - https://phabricator.wikimedia.org/T222111 (10Volker_E) [01:08:59] 10Design, 10Dark-Mode: Dark mode content SVG image handling - https://phabricator.wikimedia.org/T234111 (10Volker_E) [01:25:33] (03CR) 10Krinkle: "LGTM, testing out now" (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/539443 (https://phabricator.wikimedia.org/T4013) (owner: 10VolkerE) [01:27:04] (03Merged) 10jenkins-bot: resourceloader: Add $modules parameter to makeVersionQuery() [core] - 10https://gerrit.wikimedia.org/r/539375 (https://phabricator.wikimedia.org/T233343) (owner: 10Krinkle) [01:28:14] (03CR) 10Krinkle: [C: 04-1] "merge conflict" [skins/Vector] - 10https://gerrit.wikimedia.org/r/539443 (https://phabricator.wikimedia.org/T4013) (owner: 10VolkerE) [01:31:46] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/539375 (https://phabricator.wikimedia.org/T233343) (owner: 10Krinkle) [01:34:47] (03PS1) 10Mholloway: Fix: Use templated request for MediaWiki page requests [services/wikifeeds] - 10https://gerrit.wikimedia.org/r/539642 (https://phabricator.wikimedia.org/T170455) [01:38:04] (03CR) 10VolkerE: [C: 03+2] Remove @embed page load delays (and misc optimisations) [skins/Vector] - 10https://gerrit.wikimedia.org/r/528480 (https://phabricator.wikimedia.org/T121730) (owner: 10Krinkle) [01:39:45] (03PS4) 10Krinkle: [WIP] build: Upgrade from webdriver v4 to v5 [core] - 10https://gerrit.wikimedia.org/r/539441 (https://phabricator.wikimedia.org/T234002) [01:40:00] (03PS5) 10Krinkle: [WIP] build: Upgrade from webdriver v4 to v5 [core] - 10https://gerrit.wikimedia.org/r/539441 (https://phabricator.wikimedia.org/T234002) [01:43:39] (03PS18) 10Krinkle: Drop strings for wgExternalDiffEngine, deprecated in 1.27 and 1.32 [core] - 10https://gerrit.wikimedia.org/r/520328 (owner: 10Jforrester) [01:44:12] (03CR) 10jerkins-bot: [V: 04-1] Drop strings for wgExternalDiffEngine, deprecated in 1.27 and 1.32 [core] - 10https://gerrit.wikimedia.org/r/520328 (owner: 10Jforrester) [01:44:33] (03CR) 10jerkins-bot: [V: 04-1] Drop strings for wgExternalDiffEngine, deprecated in 1.27 and 1.32 [core] - 10https://gerrit.wikimedia.org/r/520328 (owner: 10Jforrester) [01:44:52] (03CR) 10jerkins-bot: [V: 04-1] Drop strings for wgExternalDiffEngine, deprecated in 1.27 and 1.32 [core] - 10https://gerrit.wikimedia.org/r/520328 (owner: 10Jforrester) [01:44:58] (03CR) 10jerkins-bot: [V: 04-1] Drop strings for wgExternalDiffEngine, deprecated in 1.27 and 1.32 [core] - 10https://gerrit.wikimedia.org/r/520328 (owner: 10Jforrester) [01:46:25] (03PS19) 10Krinkle: Drop strings for wgExternalDiffEngine, deprecated in 1.27 and 1.32 [core] - 10https://gerrit.wikimedia.org/r/520328 (owner: 10Jforrester) [01:46:47] (03CR) 10Krinkle: "Resolved merged conflict with DifferenceEngineTest.php." [core] - 10https://gerrit.wikimedia.org/r/520328 (owner: 10Jforrester) [01:46:52] (03CR) 10Krinkle: [C: 03+1] Drop strings for wgExternalDiffEngine, deprecated in 1.27 and 1.32 [core] - 10https://gerrit.wikimedia.org/r/520328 (owner: 10Jforrester) [01:47:04] (03CR) 10jerkins-bot: [V: 04-1] [WIP] build: Upgrade from webdriver v4 to v5 [core] - 10https://gerrit.wikimedia.org/r/539441 (https://phabricator.wikimedia.org/T234002) (owner: 10Krinkle) [01:48:32] 10Design, 10Community-Tech, 10Dark-Mode: MathML SVG fallback image rendering - https://phabricator.wikimedia.org/T234112 (10Volker_E) [01:52:31] (03CR) 10jenkins-bot: resourceloader: Add $modules parameter to makeVersionQuery() [core] - 10https://gerrit.wikimedia.org/r/539375 (https://phabricator.wikimedia.org/T233343) (owner: 10Krinkle) [01:53:11] (03PS6) 10Krinkle: [WIP] build: Upgrade from webdriver v4 to v5 [core] - 10https://gerrit.wikimedia.org/r/539441 (https://phabricator.wikimedia.org/T234002) [01:54:01] 10Design, 10Dark-Mode: Dark mode content SVG image handling - https://phabricator.wikimedia.org/T234111 (10Volker_E) Related: T234112 [01:54:32] 10Design, 10Dark-Mode: MathML SVG fallback image rendering - https://phabricator.wikimedia.org/T234112 (10Volker_E) 05Open→03Resolved p:05Triage→03Normal a:05alexhollender→03Volker_E [01:54:34] 10Design, 10Dark-Mode, 10Epic: Investigate elements that MAY need special handling in Dark Mode - https://phabricator.wikimedia.org/T222111 (10Volker_E) [01:54:54] 10Design, 10Dark-Mode: MathML SVG fallback image rendering - https://phabricator.wikimedia.org/T234112 (10Volker_E) Added in https://en.wikipedia.org/wiki/User:Volker_E._(WMF)/dark-mode.css [01:56:51] (03Abandoned) 10Krinkle: Fix MathMathMLCli returning undefined properties [extensions/Math] (REL1_32) - 10https://gerrit.wikimedia.org/r/483678 (https://phabricator.wikimedia.org/T200493) (owner: 10Paladox) [01:58:05] (03CR) 10Krinkle: Prepare 1.32.4 (031 comment) [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/538399 (owner: 10Reedy) [02:01:00] (03PS17) 10Krinkle: block: Allow cookie-block tracking from any uncached web request [core] - 10https://gerrit.wikimedia.org/r/534933 (https://phabricator.wikimedia.org/T196575) [02:01:31] 10MediaWiki-Debug-Logger, 10Performance-Team, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-release, 10MW-1.35-release: Remove ProfilerOutputDb feature from MediaWiki core - https://phabricator.wikimedia.org/T231366 (10Krinkle) [02:06:39] (03Merged) 10jenkins-bot: Remove @embed page load delays (and misc optimisations) [skins/Vector] - 10https://gerrit.wikimedia.org/r/528480 (https://phabricator.wikimedia.org/T121730) (owner: 10Krinkle) [02:18:02] (03PS1) 10SBassett: SECURITY: Do not show oversighted comments in Special:CheckUser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/539643 (https://phabricator.wikimedia.org/T207094) [02:20:19] (03PS1) 10SBassett: SECURITY: Do not show oversighted comments in Special:CheckUser [extensions/CheckUser] (REL1_31) - 10https://gerrit.wikimedia.org/r/539644 (https://phabricator.wikimedia.org/T207094) [02:20:31] (03PS1) 10SBassett: SECURITY: Do not show oversighted comments in Special:CheckUser [extensions/CheckUser] (REL1_32) - 10https://gerrit.wikimedia.org/r/539645 (https://phabricator.wikimedia.org/T207094) [02:20:45] (03PS1) 10SBassett: SECURITY: Do not show oversighted comments in Special:CheckUser [extensions/CheckUser] (REL1_33) - 10https://gerrit.wikimedia.org/r/539646 (https://phabricator.wikimedia.org/T207094) [02:26:32] 10WMSE-Riksarkivet-TORA: Property Alvin P6821 created and need to be matched - https://phabricator.wikimedia.org/T225522 (10Salgo60) [02:54:13] 10MediaWiki-Comment-backend, 10Editing-team, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review, and 2 others: The "Prompt me when entering a blank edit summary" wrongly triggers for undo edits - https://phabricator.wikimedia.org/T10912 (10DannyS712) @Anomie I don't know if you saw my r... [03:18:57] (03Abandoned) 10Krinkle: resourceloader: Debugging in WikiModule for T229433 [core] - 10https://gerrit.wikimedia.org/r/526704 (https://phabricator.wikimedia.org/T229433) (owner: 10Krinkle) [03:20:09] (03PS5) 10Krinkle: Avoid using "enqueue" mode for deferred updates in doPostOutputShutdown() [core] - 10https://gerrit.wikimedia.org/r/538362 (https://phabricator.wikimedia.org/T206283) (owner: 10Aaron Schulz) [03:20:56] (03PS6) 10Krinkle: Avoid using "enqueue" mode for deferred updates in doPostOutputShutdown [core] - 10https://gerrit.wikimedia.org/r/538362 (https://phabricator.wikimedia.org/T206283) (owner: 10Aaron Schulz) [03:28:46] (03CR) 10Krinkle: [C: 03+1] Avoid using "enqueue" mode for deferred updates in doPostOutputShutdown (031 comment) [core] - 10https://gerrit.wikimedia.org/r/538362 (https://phabricator.wikimedia.org/T206283) (owner: 10Aaron Schulz) [04:09:39] (03CR) 10Reedy: Split down patch-comment-table.sql (031 comment) [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/539569 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [04:10:03] (03PS4) 10Reedy: Split down patch-comment-table.sql [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/539569 (https://phabricator.wikimedia.org/T227662) [04:14:13] (03CR) 10jerkins-bot: [V: 04-1] Split down patch-comment-table.sql [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/539569 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [04:15:21] (03PS5) 10Reedy: Split down patch-comment-table.sql [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/539569 (https://phabricator.wikimedia.org/T227662) [04:20:57] (03PS3) 10Reedy: Fix double dot in filename [core] - 10https://gerrit.wikimedia.org/r/539571 [04:21:05] (03CR) 10Reedy: Fix double dot in filename [core] - 10https://gerrit.wikimedia.org/r/539571 (owner: 10Reedy) [04:21:08] (03CR) 10Reedy: [C: 03+2] "DIAF HHVM" [core] - 10https://gerrit.wikimedia.org/r/539571 (owner: 10Reedy) [04:26:42] 10Wikimedia-Site-requests: Lift IP cap on 2019-10-02 for Wikipedia course - cs.wikipedia - https://phabricator.wikimedia.org/T234113 (10Vojtech.Vesely) [04:29:48] (03CR) 10VolkerE: [C: 04-1] MainMenu is a controller not a View and server rendered (033 comments) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/534888 (owner: 10Jdlrobson) [04:38:27] 10MediaWiki-extensions-General, 10Google-Code-in-2019: Update extension.json files to manifest_version 2 to use description instead of @globalname documentation - https://phabricator.wikimedia.org/T234114 (10Reedy) [04:39:11] 10MediaWiki-extensions-General, 10Google-Code-in-2019, 10Technical-Debt: Update extension.json files to manifest_version 2 to use description instead of @globalname documentation - https://phabricator.wikimedia.org/T234114 (10Reedy) [04:42:15] (03PS3) 10VolkerE: Unify LESS variable naming scheme for `@line-height-*` variables [skins/Vector] - 10https://gerrit.wikimedia.org/r/539443 (https://phabricator.wikimedia.org/T4013) [04:42:21] 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10ConfirmEdit (CAPTCHA extension), 10Parsoid, and 8 others: Missing detailed license info on enwiki - https://phabricator.wikimedia.org/T234086 (10Reedy) [04:44:40] (03CR) 10VolkerE: Unify LESS variable naming scheme for `@line-height-*` variables (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/539443 (https://phabricator.wikimedia.org/T4013) (owner: 10VolkerE) [04:47:26] (03Merged) 10jenkins-bot: Fix double dot in filename [core] - 10https://gerrit.wikimedia.org/r/539571 (owner: 10Reedy) [04:48:18] 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10ConfirmEdit (CAPTCHA extension), 10Parsoid, and 8 others: Missing detailed license info on enwiki - https://phabricator.wikimedia.org/T234086 (10Reedy) [04:51:55] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/539571 (owner: 10Reedy) [04:56:18] 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10ConfirmEdit (CAPTCHA extension), 10Parsoid, and 8 others: Missing detailed license info on enwiki - https://phabricator.wikimedia.org/T234086 (10Reedy) [04:57:05] 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10ConfirmEdit (CAPTCHA extension), 10Parsoid, and 8 others: Missing detailed license info on enwiki - https://phabricator.wikimedia.org/T234086 (10Reedy) [05:01:57] 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10ConfirmEdit (CAPTCHA extension), 10Parsoid, and 8 others: Missing detailed license info on enwiki - https://phabricator.wikimedia.org/T234086 (10Reedy) >>! In T234086#5530794, @Isarra wrote: > Dumb question, but why exactly do we need to manually inclu... [05:05:04] (03CR) 10Reedy: [C: 03+2] Split down patch-comment-table.sql [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/539569 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [05:05:08] (03CR) 10Reedy: [C: 03+2] Split down patch-comment-table.sql [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/539568 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [05:05:44] (03CR) 10Reedy: [C: 03+2] Split down patch-comment-table.sql [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/539566 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [05:10:13] (03Merged) 10jenkins-bot: Split down patch-comment-table.sql [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/539569 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [05:12:26] (03CR) 10jenkins-bot: Fix double dot in filename [core] - 10https://gerrit.wikimedia.org/r/539571 (owner: 10Reedy) [05:14:27] (03Merged) 10jenkins-bot: Split down patch-comment-table.sql [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/539566 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [05:14:53] (03Merged) 10jenkins-bot: Split down patch-comment-table.sql [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/539568 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [05:24:47] 10WMSE-Riksarkivet-TORA: Property Alvin P6821 created and need to be matched - https://phabricator.wikimedia.org/T225522 (10Salgo60) [05:29:06] (03CR) 10jenkins-bot: Split down patch-comment-table.sql [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/539569 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [05:31:41] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: WMTC19: Themes/Focus Areas Proposals - https://phabricator.wikimedia.org/T234085 (10Bmueller) [05:45:22] (03PS1) 10VolkerE: Unify heading font size variable naming [skins/Vector] - 10https://gerrit.wikimedia.org/r/539648 [05:45:24] (03CR) 10jenkins-bot: Split down patch-comment-table.sql [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/539566 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [05:59:36] (03PS1) 10TheSandDoctor: AccountCreation: Add user confirmation if reason is email address [core] - 10https://gerrit.wikimedia.org/r/539649 (https://phabricator.wikimedia.org/T233068) [06:00:10] (03CR) 10jenkins-bot: Split down patch-comment-table.sql [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/539568 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [06:11:15] 10MediaWiki-extensions-Other: Memento needs 'editToken' replaced with 'csrfToken' - https://phabricator.wikimedia.org/T233554 (10TheSandDoctor) 05Stalled→03Invalid @Masumrezarock100 Well...I went to fix it today and just realized that there is actually nothing that needs fixing here.....it is "mw.user.tokens... [06:11:17] 10MediaWiki-ResourceLoader, 10Performance-Team, 10MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), 10Technical-Debt (Deprecation), 10User-TheSandDoctor: Remove 'editToken' from mw.user.tokens (deprecated for 'csrfToken') - https://phabricator.wikimedia.org/T233442 (10TheSandDoctor) [06:19:12] 10MediaWiki-Configuration, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10MW-1.35-release, 10Technical-Debt (Deprecation), and 2 others: Deprecate and remove ExtensionRegistry::load() - https://phabricator.wikimedia.org/T220996 (10TheSandDoctor) a:03TheSandDoctor I will claim this as I do intend to work o... [06:27:29] (03PS1) 10VolkerE: Unify LESS variable naming scheme for `@margin-*`/`@padding-*` variables [skins/Vector] - 10https://gerrit.wikimedia.org/r/539650 [06:29:08] 10MediaWiki-extensions-CentralAuth, 10User-TheSandDoctor: CentralAuth: Alphabetize qqq.json authors - https://phabricator.wikimedia.org/T234117 (10TheSandDoctor) [06:29:19] 10MediaWiki-extensions-CentralAuth, 10User-TheSandDoctor: CentralAuth: Alphabetize qqq.json authors - https://phabricator.wikimedia.org/T234117 (10TheSandDoctor) a:03TheSandDoctor [06:34:39] (03PS1) 10TheSandDoctor: CentralAuth: Alphabetize qqq authors [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/539651 (https://phabricator.wikimedia.org/T234117) [06:35:20] 10MediaWiki-extensions-CentralAuth, 10Patch-For-Review, 10User-TheSandDoctor: CentralAuth: Alphabetize qqq.json authors - https://phabricator.wikimedia.org/T234117 (10TheSandDoctor) [06:36:11] 10MediaWiki-extensions-CentralAuth, 10Patch-For-Review, 10User-TheSandDoctor: CentralAuth: Alphabetize qqq.json authors - https://phabricator.wikimedia.org/T234117 (10TheSandDoctor) p:05Triage→03Low [06:38:00] 10MediaWiki-extensions-CentralAuth, 10GlobalRename, 10User-TheSandDoctor: Restore usage of 'local wiki' field - https://phabricator.wikimedia.org/T217099 (10TheSandDoctor) [06:39:14] 10MediaWiki-User-management, 10User-TheSandDoctor: Allow user rights to be activated later - https://phabricator.wikimedia.org/T232928 (10TheSandDoctor) [07:09:56] 10WMSE-Riksarkivet-NAD: Connect LOD Tora church parishes and administrative parishes with Wikidata - https://phabricator.wikimedia.org/T233275 (10Salgo60) [07:27:14] 10WMSE-Riksarkivet-NAD: Connect LOD Tora church parishes and administrative parishes with Wikidata - https://phabricator.wikimedia.org/T233275 (10Salgo60) @Lydia_Pintscher feels like no one is managing [[ https://www.wikidata.org/wiki/Wikidata:SPARQL_federation_input#Incoming_nominations | Wikidata:SPARQL_feder... [07:35:37] (03PS1) 10VolkerE: Unify LESS variable naming scheme for `@border-*` variables [skins/Vector] - 10https://gerrit.wikimedia.org/r/539652 [07:56:22] (03PS12) 10Fomafix: resourceloader: Avoid HTML encoding in output of load.php [core] - 10https://gerrit.wikimedia.org/r/526385 (https://phabricator.wikimedia.org/T229311) [08:41:10] 10Accessibility, 10Vector, 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), 10Readers-Web-Backlog (Tracking): Remove `tabindex="1"` from #simpleSearch - https://phabricator.wikimedia.org/T226148 (10Schnark) Is the dependency on `jquery.tabIndex` used anywhere else? If not, this can be removed, too. [08:46:58] 10WMEE: Wikimedia uus veebileht üles, koguda kasutajate tagasiside ja siis täiendada kuni esialgse rahuloluni - https://phabricator.wikimedia.org/T204043 (10tramm) Nüüd töötavad ka vana veebi ümbersuunamised uue veebi artiklitele kujul: https://wikimediaeesti.wordpress.com/2018/05/02/autorioiguse-kuum-kartul/ -... [09:21:37] 10ContentTranslation, 10CommRel-Specialists-Support (Jul-Sep-2019), 10Language-Team (Language-2019-July-September): Specialist support for communication with small wikis about translation - https://phabricator.wikimedia.org/T227013 (10Elitre) I've also messaged 15 translators from Tagalog, and announced the... [09:29:17] 10WMEE: OKEE seisukoht teksti- ja andmekaeve teemal - https://phabricator.wikimedia.org/T231714 (10tramm) 05Open→03Declined Ilmselt pole vaja teha enam, vähemalt mitte otseselt. [09:29:19] 10WMEE: Autoriõiguse direktiivist tulenevate muudatuste kirjutamine Eesti seadustesse - https://phabricator.wikimedia.org/T231713 (10tramm) [09:31:14] 10WMEE: Autoriõiguse direktiivist tulenevate muudatuste kirjutamine Eesti seadustesse - https://phabricator.wikimedia.org/T231713 (10tramm) [09:31:51] 10MediaWiki-Codesniffer, 10Code-Health: Checkup code passing $this by reference with a temporary variable - https://phabricator.wikimedia.org/T234118 (10Daimona) [09:32:33] 10WMEE: Autoriõiguse direktiivist tulenevate muudatuste kirjutamine Eesti seadustesse - https://phabricator.wikimedia.org/T231713 (10tramm) Järgmine koosolek 18.10, teemadeks: * Teoste ja muu materjali kasutamine digitaalse ja piiriülese õppetegevuse jaoks (artikkel 5) ja kultuuripärandi säilitamine (artikkel 6... [09:45:02] 10MediaWiki-Codesniffer, 10Code-Health: Checkup code passing $this by reference with a temporary variable - https://phabricator.wikimedia.org/T234118 (10Daimona) Note that we should first change the hook handlers and remove the references there. [09:46:59] (03PS1) 10Daimona Eaytoy: Remove redundant reference from EditPage hook handler [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/539654 (https://phabricator.wikimedia.org/T234118) [09:47:28] (03PS2) 10Daimona Eaytoy: Remove redundant reference from EditPage hook handler [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/539654 (https://phabricator.wikimedia.org/T234118) [10:00:01] (03PS1) 10Daimona Eaytoy: Remove redundant reference from EditPage hook handler [extensions/BlueSpiceSaferEdit] - 10https://gerrit.wikimedia.org/r/539655 (https://phabricator.wikimedia.org/T234118) [10:00:24] (03PS2) 10Daimona Eaytoy: Remove redundant reference from EditPage hook handler [extensions/BlueSpiceSaferEdit] - 10https://gerrit.wikimedia.org/r/539655 (https://phabricator.wikimedia.org/T234118) [10:01:54] (03PS1) 10Daimona Eaytoy: Remove redundant reference from EditPage hook handler [extensions/Checkpoint] - 10https://gerrit.wikimedia.org/r/539656 (https://phabricator.wikimedia.org/T234118) [10:02:26] (03PS2) 10Daimona Eaytoy: Remove redundant reference from EditPage hook handler [extensions/Checkpoint] - 10https://gerrit.wikimedia.org/r/539656 (https://phabricator.wikimedia.org/T234118) [10:04:19] (03PS1) 10Daimona Eaytoy: Remove redundant reference from EditPage hook handler [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/539657 (https://phabricator.wikimedia.org/T234118) [10:04:51] (03PS2) 10Daimona Eaytoy: Remove redundant reference from EditPage hook handler [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/539657 (https://phabricator.wikimedia.org/T234118) [10:06:00] (03CR) 10jerkins-bot: [V: 04-1] Remove redundant reference from EditPage hook handler [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/539657 (https://phabricator.wikimedia.org/T234118) (owner: 10Daimona Eaytoy) [10:06:34] (03CR) 10jerkins-bot: [V: 04-1] Remove redundant reference from EditPage hook handler [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/539657 (https://phabricator.wikimedia.org/T234118) (owner: 10Daimona Eaytoy) [10:09:02] (03PS1) 10Daimona Eaytoy: Remove redundant reference from EditPage hook handler [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/539658 (https://phabricator.wikimedia.org/T234118) [10:09:50] (03PS2) 10Daimona Eaytoy: Remove redundant reference from EditPage hook handler [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/539658 (https://phabricator.wikimedia.org/T234118) [10:10:47] (03PS1) 10Daimona Eaytoy: Remove redundant reference from EditPage hook handler [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/539659 (https://phabricator.wikimedia.org/T234118) [10:10:57] (03PS2) 10Daimona Eaytoy: Remove redundant reference from EditPage hook handler [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/539659 (https://phabricator.wikimedia.org/T234118) [10:11:55] (03PS1) 10Daimona Eaytoy: Remove redundant reference from EditPage hook handler [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/539660 (https://phabricator.wikimedia.org/T234118) [10:12:15] (03PS2) 10Daimona Eaytoy: Remove redundant reference from EditPage hook handler [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/539660 (https://phabricator.wikimedia.org/T234118) [10:14:40] 10MediaWiki-Codesniffer, 10Code-Health, 10Patch-For-Review: Checkup code passing $this by reference with a temporary variable - https://phabricator.wikimedia.org/T234118 (10Daimona) ===EditPage=== No hook needs the reference. **Progress:** [] ApprovedRevs - https://gerrit.wikimedia.org/r/539654 [x] Article... [10:20:49] 10Office-IT: Google group for #Wikimedia-Site-requests - https://phabricator.wikimedia.org/T232946 (10MarcoAurelio) @JGulingan Thanks for your reply. Regarding tha name I propose `sitereq-l@wikimedia.org` (I keep the `l` on purpose so it's clear it's a mailing list). This is a personal proposal of course and if... [10:30:07] 10MediaWiki-extensions-OAuth, 10Core Platform Team, 10Wikimedia-Rdbms, 10Wikimedia-database-error: Database error after installing OAuth extension on wikismadebythepins.ml/community - https://phabricator.wikimedia.org/T234120 (10AndreiJirohOnDevsCentral) [10:31:58] 10WMF-Legal, 10Wikimedia-Site-requests, 10Patch-For-Review: Patroller right changes to ro.wp - https://phabricator.wikimedia.org/T234051 (10MarcoAurelio) `deleterevision` is a core #mediawiki-revision-deletion functionality to redact and unredact logs and history entries. I agree this falls within [[ https:/... [10:32:20] 10ConfirmEdit (CAPTCHA extension): reCAPTCHA v3 Request - https://phabricator.wikimedia.org/T234025 (10AndreiJirohOnDevsCentral) >>! In T234025#5529019, @Aklapper wrote: > Hi @AndreiJirohOnDevsCentral, thanks for taking the time to report this and welcome to Wikimedia Phabricator! > This has been already reques... [10:36:18] 10MediaWiki-extensions-FlaggedRevs: Arrange pages in Special:UnreviewedPages chronologically - https://phabricator.wikimedia.org/T186141 (10Tgr) [10:36:21] 10MediaWiki-extensions-FlaggedRevs: Allow for sorting Special:UnreviewedPages by time since creation - https://phabricator.wikimedia.org/T45857 (10Tgr) [10:37:08] 10MediaWiki-extensions-FlaggedRevs, 10User-Tgr: Allow for sorting Special:UnreviewedPages by time since creation - https://phabricator.wikimedia.org/T45857 (10Tgr) [10:47:46] 10WMEE: Autoriõiguse direktiivist tulenevate muudatuste kirjutamine Eesti seadustesse - https://phabricator.wikimedia.org/T231713 (10Puik) Mina plaanin osaleda vähemalt hommikusel arutelul (kell 10–12), ehk ka pärastlõunasel (13–15). [10:50:23] 10MediaWiki-User-management, 10MediaWiki-extensions-FlaggedRevs: FlaggedRevs permissions on Hungarian Wikipedia are occasionally missing - https://phabricator.wikimedia.org/T234121 (10Tgr) [10:56:16] 10MediaWiki-extensions-CentralAuth, 10Patch-For-Review, 10User-TheSandDoctor: CentralAuth: Alphabetize qqq.json authors - https://phabricator.wikimedia.org/T234117 (10MarcoAurelio) I think L10n-Bot will keep adding new translators to the bottom so this would be a temporary fix. I agree however that the list... [10:58:41] 10Phabricator: ArgumentCountError on Phabricator - https://phabricator.wikimedia.org/T233998 (10mmodell) @epriestley: Thanks for the heads up! Indeed I tweaked the way that subtypes work slightly, to make it more extensible. I'd love it if we could upstream some of that but I don't know how much extensibility yo... [11:00:38] 10Phabricator: ArgumentCountError on Phabricator - https://phabricator.wikimedia.org/T233998 (10mmodell) The local hack was to implement custom rendering of the subtype tag on workboards - "deadline" tasks render a due date on workboards and change the color of the tag as the deadline approaches. In order to imp... [11:02:03] 04(no projects): Regressive bugs in admin tools - https://phabricator.wikimedia.org/T232980 (10Aklapper) 05Stalled→03Declined > Please file separate tasks with a list of clear steps to reproduce each issue, so someone else can try to follow these steps and reproduce, and each of these problems can be proper... [11:04:35] (03CR) 10MarcoAurelio: "recheck" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/539651 (https://phabricator.wikimedia.org/T234117) (owner: 10TheSandDoctor) [11:14:12] 10Talk Pages: Section edit link missing when long section title doesn't wrap before viewport right margin - https://phabricator.wikimedia.org/T234109 (10Aklapper) [11:17:04] 10MediaWiki-Email, 10Growth-Team: [euwiki] Email subject header displays transcluded template (due to typo in translated name of variable) - https://phabricator.wikimedia.org/T234093 (10Aklapper) 05Open→03Invalid [11:18:55] (03CR) 10Huji: [C: 03+1] SECURITY: Do not show oversighted comments in Special:CheckUser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/539643 (https://phabricator.wikimedia.org/T207094) (owner: 10SBassett) [11:18:57] (03CR) 10Huji: [C: 03+1] SECURITY: Do not show oversighted comments in Special:CheckUser [extensions/CheckUser] (REL1_33) - 10https://gerrit.wikimedia.org/r/539646 (https://phabricator.wikimedia.org/T207094) (owner: 10SBassett) [11:18:59] (03CR) 10Huji: [C: 03+1] SECURITY: Do not show oversighted comments in Special:CheckUser [extensions/CheckUser] (REL1_32) - 10https://gerrit.wikimedia.org/r/539645 (https://phabricator.wikimedia.org/T207094) (owner: 10SBassett) [11:19:10] 10Phabricator, 10User-DannyS712: Add DannyS712 to #triagers - https://phabricator.wikimedia.org/T234081 (10Aklapper) 05Open→03Resolved a:03Aklapper Done [11:20:18] 10MediaWiki-extensions-WikimediaEvents, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01): EditorJourney records revision IDs for diffs - https://phabricator.wikimedia.org/T234084 (10Aklapper) @nettrom_WMF: Assuming this task is about #mediawiki-extensions-wikimediaevents, hence add... [11:24:17] 10Android-app-Bugs, 10ConfirmEdit (CAPTCHA extension), 10Wikipedia-Android-App-Backlog: Broken design of captcha-page when publishing on Android - https://phabricator.wikimedia.org/T234122 (10Der_Keks) [11:27:18] 10MediaWiki-extensions-OAuth: Database error after installing OAuth extension on wikismadebythepins.ml/community - https://phabricator.wikimedia.org/T234120 (10Aklapper) 05Open→03Stalled Hi @AndreiJirohOnDevsCentral, thanks for taking the time to report this! Please provide a stacktrace: https://www.mediaw... [11:35:54] (03PS1) 10Fomafix: resourceloader: Drop name/state support in makeLoaderStateScript [core] - 10https://gerrit.wikimedia.org/r/539662 [11:36:00] (03CR) 10Fomafix: resourceloader: Add $context to static functions in ResourceLoader (033 comments) [core] - 10https://gerrit.wikimedia.org/r/535266 (https://phabricator.wikimedia.org/T229311) (owner: 10Fomafix) [11:37:35] (03PS2) 10Fomafix: resourceloader: Drop name/state support in makeLoaderStateScript [core] - 10https://gerrit.wikimedia.org/r/539662 [11:53:19] 10Gerrit-Privilege-Requests: Requesting access for SemanticACL extension - https://phabricator.wikimedia.org/T234124 (10Tinss) [11:56:55] 10MediaWiki-Codesniffer, 10Code-Health, 10Patch-For-Review: Checkup code passing $this by reference with a temporary variable - https://phabricator.wikimedia.org/T234118 (10Daimona) [11:59:14] (03CR) 10MarcoAurelio: [C: 03+2] docs: Fix typo on Doxygen main page [core] - 10https://gerrit.wikimedia.org/r/539543 (owner: 10Alex Paskulin) [12:09:13] 10Developer-Advocacy (Jul-Sep 2019): Dedicated Google Code-in (GCI) communication channel for students, mentors and admins? - https://phabricator.wikimedia.org/T200782 (10Aklapper) Ah, interesting stuff I don't know much about, thanks @bd808! I've brought this up in the group itself: > Filip: well looks like it... [12:10:33] 10MediaWiki-extensions-OATHAuth, 10I18n: 'oathauth-module-invalid' lacks i18n en/qqq.json keys - https://phabricator.wikimedia.org/T228269 (10MarcoAurelio) Hi @ItSpiderman - Which wording shall we use for this new key? Thanks. [12:15:03] 10MediaWiki-Codesniffer, 10Patch-For-Review: Create optional sniff to require documenting private methods - https://phabricator.wikimedia.org/T233838 (10Daimona) a:03Daimona [12:16:03] 04(no projects): Draft golang security best practices documentation - https://phabricator.wikimedia.org/T227008 (10Aklapper) Yes. I wonder what @chasemp's exact intention was behind restricting that [12:20:54] 10MediaWiki-Codesniffer, 10Upstream: Add sniff to ensure use of spaces (not tabs) between variable and assignment operator - https://phabricator.wikimedia.org/T232265 (10Daimona) AFAICS, the rules enforcing spaces before/after operands are in Squiz.WhiteSpace.OperatorSpacing, which means that they should be ch... [12:24:45] (03Merged) 10jenkins-bot: docs: Fix typo on Doxygen main page [core] - 10https://gerrit.wikimedia.org/r/539543 (owner: 10Alex Paskulin) [12:29:20] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/539543 (owner: 10Alex Paskulin) [12:42:35] (03CR) 10Daimona Eaytoy: [C: 04-2] "Let's wait for T234052" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/459818 (https://phabricator.wikimedia.org/T220791) (owner: 10Daimona Eaytoy) [12:43:07] 10WMEE: Autoriõiguse direktiivist tulenevate muudatuste kirjutamine Eesti seadustesse - https://phabricator.wikimedia.org/T231713 (10Pseudacorus) Uurin, kas saan töölt vabaks, olen huvitatud. [12:43:19] 10Hashtags, 10Product-Analytics: Discuss edit hashtag support with major bot/tool/gadget creators - https://phabricator.wikimedia.org/T123636 (10Esanders) Hi @Sophivorus , we recently added a property to the ArticleTarget for doing just this: `ve.init.target.saveFields.wpChangeTags = value` Currently these v... [12:44:46] 10Hashtags, 10Product-Analytics: Discuss edit hashtag support with major bot/tool/gadget creators - https://phabricator.wikimedia.org/T123636 (10Samwalton9) Just to clarify, this task is about the #hashtags tool and hashtags in edit summaries, not the MediaWiki Tag system :) [12:54:17] (03CR) 10jenkins-bot: docs: Fix typo on Doxygen main page [core] - 10https://gerrit.wikimedia.org/r/539543 (owner: 10Alex Paskulin) [12:57:52] (03CR) 10MarcoAurelio: [C: 03+2] "https://doc.wikimedia.org/mediawiki-core/master/php/ still displays the typos though." [core] - 10https://gerrit.wikimedia.org/r/539543 (owner: 10Alex Paskulin) [13:02:15] 10WMSE-Riksarkivet-NAD: Connect LOD Tora church parishes and administrative parishes with Wikidata - https://phabricator.wikimedia.org/T233275 (10Salgo60) [13:02:44] (03CR) 10Daimona Eaytoy: [C: 04-1] API: Alter behaviour if state doesn't change instead of proceeding (038 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539624 (https://phabricator.wikimedia.org/T234074) (owner: 10DannyS712) [13:05:42] (03PS3) 10Daimona Eaytoy: Remove redundant reference from EditPage hook handler [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/539657 (https://phabricator.wikimedia.org/T234118) [13:14:33] 10MediaWiki-Maintenance-scripts, 10Core Platform Team Workboards (Clinic Duty Team): Unable to upgrade wiki family of 2 wikis from 1.32.0 to 1.33.0 due to DB structure being different than the upgrade.php expects - https://phabricator.wikimedia.org/T234027 (10Jukeboksi) Big thank you to everyone that has helpe... [13:19:47] 10GlobalBlocking: Possibly wrong global block error in Special:PasswordReset - https://phabricator.wikimedia.org/T234125 (10Tpt) [13:20:56] (03PS1) 10Daimona Eaytoy: Remove dependency on $wgRestrictionTypes [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539664 [13:22:08] (03PS2) 10Daimona Eaytoy: Remove dependency on $wgRestrictionTypes [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539664 [13:43:01] 10MediaWiki-Maintenance-scripts, 10Core Platform Team Workboards (Clinic Duty Team): Unable to upgrade wiki family of 2 wikis from 1.32.0 to 1.33.0 due to DB structure being different than the upgrade.php expects - https://phabricator.wikimedia.org/T234027 (10Jukeboksi) Looking at the grants makes me think tha... [13:44:27] (03PS1) 10Daimona Eaytoy: Resolve a couple of todos in AbuseFilterRunner [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539666 [14:11:25] 10MediaWiki-General, 10phan: Document Article subclasses with different type from Article::newPage in a way phan can understand it - https://phabricator.wikimedia.org/T223848 (10Daimona) 05Open→03Resolved a:03Umherirrender Fixed in https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/519756/. [14:26:56] 10MediaWiki-extensions-Cargo: Cannot respecify unique String fields - https://phabricator.wikimedia.org/T234130 (10HertzDevil) [14:40:50] 10MediaWiki-Installer, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01): Update.php failure when upgrading from 1.32.1 to 1.33 - https://phabricator.wikimedia.org/T227662 (10Reedy) [14:41:06] 10MediaWiki-Installer, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01): Update.php failure when upgrading from 1.32.1 to 1.33 - https://phabricator.wikimedia.org/T227662 (10Reedy) patch-actor-table.sql next... [14:44:55] (03PS3) 10Fomafix: resourceloader: Simplify makeLoaderStateScript and makeLoaderSourcesScript [core] - 10https://gerrit.wikimedia.org/r/539662 [14:54:24] (03PS1) 10Reedy: [WIP] Split down patch-actor-table.sql [core] - 10https://gerrit.wikimedia.org/r/539668 (https://phabricator.wikimedia.org/T227662) [14:56:46] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Split down patch-actor-table.sql [core] - 10https://gerrit.wikimedia.org/r/539668 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [15:02:19] (03PS2) 10Reedy: [WIP] Split down patch-actor-table.sql [core] - 10https://gerrit.wikimedia.org/r/539668 (https://phabricator.wikimedia.org/T227662) [15:04:37] (03PS3) 10Reedy: [WIP] Split down patch-actor-table.sql [core] - 10https://gerrit.wikimedia.org/r/539668 (https://phabricator.wikimedia.org/T227662) [15:04:40] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Split down patch-actor-table.sql [core] - 10https://gerrit.wikimedia.org/r/539668 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [15:05:41] (03PS1) 10Zoranzoki21: docs: Fix Introduction.md file [core] - 10https://gerrit.wikimedia.org/r/539669 [15:06:13] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Simplify makeLoaderStateScript and makeLoaderSourcesScript [core] - 10https://gerrit.wikimedia.org/r/539662 (owner: 10Fomafix) [15:06:31] (03PS2) 10Zoranzoki21: docs: Fix Introduction.md file [core] - 10https://gerrit.wikimedia.org/r/539669 [15:06:38] (03PS3) 10Zoranzoki21: docs: Fix Introduction.md file [core] - 10https://gerrit.wikimedia.org/r/539669 [15:07:50] (03PS4) 10Reedy: [WIP] Split down patch-actor-table.sql [core] - 10https://gerrit.wikimedia.org/r/539668 (https://phabricator.wikimedia.org/T227662) [15:07:52] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Simplify makeLoaderStateScript and makeLoaderSourcesScript [core] - 10https://gerrit.wikimedia.org/r/539662 (owner: 10Fomafix) [15:09:06] (03Abandoned) 10Zoranzoki21: docs: Fix Introduction.md file [core] - 10https://gerrit.wikimedia.org/r/539669 (owner: 10Zoranzoki21) [15:12:53] (03PS4) 10Fomafix: resourceloader: Simplify makeLoaderStateScript and makeLoaderSourcesScript [core] - 10https://gerrit.wikimedia.org/r/539662 [15:13:50] (03PS2) 10Reedy: Prepare 1.33.1 [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/538402 [15:13:58] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Simplify makeLoaderStateScript and makeLoaderSourcesScript [core] - 10https://gerrit.wikimedia.org/r/539662 (owner: 10Fomafix) [15:14:41] (03PS2) 10Reedy: Prepare 1.32.4 [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/538399 [15:15:09] (03PS2) 10Reedy: Prepare 1.31.4 [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/538396 [15:28:13] (03PS30) 10Daimona Eaytoy: Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006) [15:29:05] (03CR) 10jerkins-bot: [V: 04-1] Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [15:29:22] (03CR) 10jerkins-bot: [V: 04-1] Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [15:29:31] (03CR) 10Reedy: [C: 04-1] "Hang on, it times it on the machine being idle? Not since the last auth action in the tab?" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/535793 (https://phabricator.wikimedia.org/T218211) (owner: 10ItSpiderman) [15:33:43] (03PS5) 10Reedy: Split down patch-actor-table.sql [core] - 10https://gerrit.wikimedia.org/r/539668 (https://phabricator.wikimedia.org/T227662) [15:34:03] (03CR) 10Reedy: "Little bit simpler than the comment patch, as revision_actor_temp hasn't been dropped yet" [core] - 10https://gerrit.wikimedia.org/r/539668 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [15:42:06] (03CR) 10Reedy: [C: 03+1] "+1 for this patch. Just need to work out the dependant :)" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/536014 (https://phabricator.wikimedia.org/T232008) (owner: 10ItSpiderman) [16:01:06] (03PS5) 10Reedy: Ask user to reauthenticate before changing 2FA method [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/535793 (https://phabricator.wikimedia.org/T218211) (owner: 10ItSpiderman) [16:05:04] (03PS6) 10Reedy: Ask user to reauthenticate before changing 2FA method [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/535793 (https://phabricator.wikimedia.org/T218211) (owner: 10ItSpiderman) [16:05:06] (03PS10) 10Reedy: Add warning page before method gets disabled [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/536014 (https://phabricator.wikimedia.org/T232008) (owner: 10ItSpiderman) [16:05:08] (03PS6) 10Reedy: Do not store proper objects in session data [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/538154 (https://phabricator.wikimedia.org/T233146) (owner: 10ItSpiderman) [16:05:31] (03PS11) 10Reedy: Add warning page before method gets disabled [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/536014 (https://phabricator.wikimedia.org/T232008) (owner: 10ItSpiderman) [16:05:58] (03CR) 10Reedy: [C: 03+2] "Let's get this merged and sort the patch that was under it later" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/536014 (https://phabricator.wikimedia.org/T232008) (owner: 10ItSpiderman) [16:06:18] (03CR) 10Reedy: [C: 03+2] Update the module to implement new interface methods [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/536013 (https://phabricator.wikimedia.org/T232008) (owner: 10ItSpiderman) [16:08:14] (03CR) 10jerkins-bot: [V: 04-1] Do not store proper objects in session data [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/538154 (https://phabricator.wikimedia.org/T233146) (owner: 10ItSpiderman) [16:08:22] (03CR) 10jerkins-bot: [V: 04-1] Add warning page before method gets disabled [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/536014 (https://phabricator.wikimedia.org/T232008) (owner: 10ItSpiderman) [16:08:37] (03CR) 10jerkins-bot: [V: 04-1] Add warning page before method gets disabled [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/536014 (https://phabricator.wikimedia.org/T232008) (owner: 10ItSpiderman) [16:09:17] (03Merged) 10jenkins-bot: Update the module to implement new interface methods [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/536013 (https://phabricator.wikimedia.org/T232008) (owner: 10ItSpiderman) [16:09:58] (03CR) 10jerkins-bot: [V: 04-1] Add warning page before method gets disabled [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/536014 (https://phabricator.wikimedia.org/T232008) (owner: 10ItSpiderman) [16:19:54] (03PS1) 10Zoranzoki21: composer.json: Add process-timeout and set it to 0 [core] - 10https://gerrit.wikimedia.org/r/539670 [16:20:10] 10WMEE: Võistkondlik 24h artiklivõistlus - https://phabricator.wikimedia.org/T231202 (10Lmk2K18) Võistlus lükkub edasi 2.-3. novembrile! [16:20:26] (03PS2) 10Zoranzoki21: composer.json: Add process-timeout and set it to 0 [core] - 10https://gerrit.wikimedia.org/r/539670 [16:20:36] (03PS12) 10Reedy: Add warning page before method gets disabled [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/536014 (https://phabricator.wikimedia.org/T232008) (owner: 10ItSpiderman) [16:20:55] (03CR) 10Reedy: [C: 03+2] Add warning page before method gets disabled [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/536014 (https://phabricator.wikimedia.org/T232008) (owner: 10ItSpiderman) [16:21:23] (03CR) 10Reedy: [C: 04-1] "Why?" [core] - 10https://gerrit.wikimedia.org/r/539670 (owner: 10Zoranzoki21) [16:22:27] (03CR) 10Zoranzoki21: "> Why?" [core] - 10https://gerrit.wikimedia.org/r/539670 (owner: 10Zoranzoki21) [16:22:43] (03PS13) 10Reedy: Add warning page before method gets disabled [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/536014 (https://phabricator.wikimedia.org/T232008) (owner: 10ItSpiderman) [16:22:47] (03CR) 10Reedy: [C: 03+2] Add warning page before method gets disabled [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/536014 (https://phabricator.wikimedia.org/T232008) (owner: 10ItSpiderman) [16:27:15] (03CR) 10Skizzerz: [C: 03+2] Remove redundant reference from EditPage hook handler [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/539659 (https://phabricator.wikimedia.org/T234118) (owner: 10Daimona Eaytoy) [16:27:30] (03Merged) 10jenkins-bot: Add warning page before method gets disabled [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/536014 (https://phabricator.wikimedia.org/T232008) (owner: 10ItSpiderman) [16:29:22] (03CR) 10Skizzerz: [C: 03+2] Remove redundant reference from EditPage hook handler [extensions/Checkpoint] - 10https://gerrit.wikimedia.org/r/539656 (https://phabricator.wikimedia.org/T234118) (owner: 10Daimona Eaytoy) [16:29:29] (03Merged) 10jenkins-bot: Remove redundant reference from EditPage hook handler [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/539659 (https://phabricator.wikimedia.org/T234118) (owner: 10Daimona Eaytoy) [16:33:01] (03Merged) 10jenkins-bot: Remove redundant reference from EditPage hook handler [extensions/Checkpoint] - 10https://gerrit.wikimedia.org/r/539656 (https://phabricator.wikimedia.org/T234118) (owner: 10Daimona Eaytoy) [16:39:24] 10MediaWiki-Page-editing, 10Core Platform Team, 10Editing-team: Add a hook, called before a page edit is saved, offering the PSTed content of the edit - https://phabricator.wikimedia.org/T234132 (10Daimona) [16:39:55] 10WMSE-Riksarkivet-TORA: Define TORA as an endpoint in Wikidata - https://phabricator.wikimedia.org/T200066 (10Salgo60) [16:39:57] 10WMSE-Riksarkivet-NAD: Connect LOD Tora church parishes and administrative parishes with Wikidata - https://phabricator.wikimedia.org/T233275 (10Salgo60) [16:51:45] (03CR) 10Daimona Eaytoy: [C: 03+2] build: Update linters [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/538253 (owner: 10Esanders) [17:00:57] (03CR) 10Daimona Eaytoy: [C: 04-1] "The typehint in the interface can be replaced with "EchoAbstractEntity"." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/531304 (owner: 10D3r1ck01) [17:04:05] (03CR) 10Daimona Eaytoy: [C: 03+1] Use splat operator in signature, not func_get_args [core] - 10https://gerrit.wikimedia.org/r/495728 (owner: 10Michael Große) [17:12:45] (03PS1) 10Reedy: Bump version 0.4.2 [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/539671 [17:13:02] (03CR) 10Reedy: [C: 03+2] Bump version 0.4.2 [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/539671 (owner: 10Reedy) [17:14:57] (03CR) 10Reedy: [C: 03+2] Bump version 0.4.2 [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/539671 (owner: 10Reedy) [17:15:09] (03PS1) 10Reedy: Require OATHAuth >= 0.4.2 [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/539672 [17:16:19] (03CR) 10jerkins-bot: [V: 04-1] Require OATHAuth >= 0.4.2 [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/539672 (owner: 10Reedy) [17:18:20] (03Merged) 10jenkins-bot: Bump version 0.4.2 [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/539671 (owner: 10Reedy) [17:18:30] (03PS2) 10Reedy: Require OATHAuth >= 0.4.2 [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/539672 [17:18:33] (03CR) 10Reedy: [C: 03+2] Require OATHAuth >= 0.4.2 [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/539672 (owner: 10Reedy) [17:21:11] (03Merged) 10jenkins-bot: Require OATHAuth >= 0.4.2 [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/539672 (owner: 10Reedy) [17:28:28] (03PS1) 10Vedmaka Wakalaka: Fixes $egArraysExpansionEscapeTemplates default value in extension.json [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/539673 [17:57:04] (03PS2) 10Krinkle: Hard-deprecate requesting disabled variables [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539545 (https://phabricator.wikimedia.org/T234048) (owner: 10Daimona Eaytoy) [17:57:07] (03CR) 10Krinkle: [C: 03+2] Hard-deprecate requesting disabled variables [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539545 (https://phabricator.wikimedia.org/T234048) (owner: 10Daimona Eaytoy) [18:02:32] (03PS6) 10Krinkle: Use splat operator in signature, not func_get_args [core] - 10https://gerrit.wikimedia.org/r/495728 (owner: 10Michael Große) [18:02:53] (03CR) 10Krinkle: "including at least one non-digit character in the commit hash so that it is detected by Gerrit as commit hash instead of change number." [core] - 10https://gerrit.wikimedia.org/r/495728 (owner: 10Michael Große) [18:03:42] (03CR) 10Krinkle: "check php" [core] - 10https://gerrit.wikimedia.org/r/495728 (owner: 10Michael Große) [18:05:04] (03CR) 10Krinkle: "We are still testing and supporting HHVM at this moment. We've only switched the lighter 'test patchset' pipeline from testing only hhvm t" [core] - 10https://gerrit.wikimedia.org/r/495728 (owner: 10Michael Große) [18:08:01] 04(no projects): Trying to get pywikibot running by following documentation fails - https://phabricator.wikimedia.org/T234135 (10Seppl2013) [18:08:27] 04(no projects): Trying to get pywikibot running by following documentation fails - https://phabricator.wikimedia.org/T234135 (10Seppl2013) [18:08:40] 04(no projects): Trying to get pywikibot running by following documentation fails - https://phabricator.wikimedia.org/T234135 (10Seppl2013) [18:14:45] (03CR) 10Raimond Spekking: [C: 04-1] "This patch is technically OK but does not make sense, because new translators of an extension are added to the end of the list automatical" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/539651 (https://phabricator.wikimedia.org/T234117) (owner: 10TheSandDoctor) [18:20:34] (03PS1) 10Zoranzoki21: Revert "LiquidThreads: Alphabetize qqq.json authors" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/539675 [18:20:36] (03PS2) 10Zoranzoki21: Revert "LiquidThreads: Alphabetize qqq.json authors" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/539675 [18:21:17] (03CR) 10Zoranzoki21: "Comment of Raimond Spekking in 539651:" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/539675 (owner: 10Zoranzoki21) [18:25:35] (03Merged) 10jenkins-bot: Hard-deprecate requesting disabled variables [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539545 (https://phabricator.wikimedia.org/T234048) (owner: 10Daimona Eaytoy) [18:26:46] (03PS5) 10Krinkle: resourceloader: Simplify makeLoaderStateScript and makeLoaderSourcesScript [core] - 10https://gerrit.wikimedia.org/r/539662 (owner: 10Fomafix) [18:26:47] (03CR) 10Krinkle: [C: 03+1] resourceloader: Simplify makeLoaderStateScript and makeLoaderSourcesScript [core] - 10https://gerrit.wikimedia.org/r/539662 (owner: 10Fomafix) [18:27:07] (03CR) 10Zoranzoki21: "Libraryupgrader should update this, right?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/538253 (owner: 10Esanders) [18:31:08] (03CR) 10MarcoAurelio: [C: 03+2] "It's displaying correctly now. I guess the update isn't as automated/quick as I thought it'd be." [core] - 10https://gerrit.wikimedia.org/r/539543 (owner: 10Alex Paskulin) [18:33:19] (03CR) 10Krinkle: "For core it runs hourly [1], for others it is part of postmerge." [core] - 10https://gerrit.wikimedia.org/r/539543 (owner: 10Alex Paskulin) [18:33:39] (03CR) 10jenkins-bot: Hard-deprecate requesting disabled variables [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539545 (https://phabricator.wikimedia.org/T234048) (owner: 10Daimona Eaytoy) [18:34:14] (03CR) 10Daimona Eaytoy: [C: 03+2] "> Libraryupgrader should update this, right?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/538253 (owner: 10Esanders) [18:42:27] (03CR) 10Zoranzoki21: "> > Libraryupgrader should update this, right?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/538253 (owner: 10Esanders) [18:51:36] (03PS6) 10Krinkle: Make max-age configurable for logged-out users [core] - 10https://gerrit.wikimedia.org/r/532378 (https://phabricator.wikimedia.org/T231184) (owner: 10Gilles) [18:52:50] 04(no projects): Structured Disscussion aka Flow - https://phabricator.wikimedia.org/T234137 (10Aklapper) [18:54:16] (03CR) 10Krinkle: Make max-age configurable for logged-out users (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532378 (https://phabricator.wikimedia.org/T231184) (owner: 10Gilles) [18:55:44] 04(no projects): Structured Disscussion aka Flow - https://phabricator.wikimedia.org/T234137 (10Masumrezarock100) >>! In T234137#5531850, @AlgoLove wrote: > I encountered issues installing Structured discussions and its dependencies the errors I encountered including updating the database schema. You should as... [18:56:39] (03CR) 10Krinkle: [C: 04-1] "Yeah, we can split it on the caller end, and then let the lib handle it from there" [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/522989 (https://phabricator.wikimedia.org/T218074) (owner: 10Daimona Eaytoy) [18:58:37] 10MediaWiki-User-management, 10Core Platform Team, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review, 10User-DannyS712: Add option to prevent users from removing themselves from a user group - https://phabricator.wikimedia.org/T44072 (10Krinkle) Okay, I understand. I assumed you want... [18:59:31] 10MediaWiki-extensions-DocBookExport: DocBookExport to PDF fails on table - https://phabricator.wikimedia.org/T234139 (10Bgoldenl) [19:01:09] 10MediaWiki-extensions-DocBookExport: DocBookExport to PDF fails on table - https://phabricator.wikimedia.org/T234139 (10Bgoldenl) [19:01:47] (03CR) 10Krinkle: mediawiki.Title: Remove unused signature from newFromUserInput (031 comment) [core] - 10https://gerrit.wikimedia.org/r/510445 (owner: 10Thiemo Kreuz (WMDE)) [19:02:36] (03CR) 10Krinkle: "on-wiki usage:" [core] - 10https://gerrit.wikimedia.org/r/510445 (owner: 10Thiemo Kreuz (WMDE)) [19:02:51] 10AbuseFilter: PHP notice about AbuseFilter: The group permissions "abusefilter-private-log" and "abusefilter-private" have been renamed - https://phabricator.wikimedia.org/T234140 (10Zoranzoki21) [19:04:00] 10MediaWiki-extensions-DocBookExport: DocBookExport to PDF fails on table - https://phabricator.wikimedia.org/T234139 (10Bgoldenl) [19:05:10] (03PS3) 10Krinkle: StringUtils: Clarify that isValidRegex is for PCRE regexps [core] - 10https://gerrit.wikimedia.org/r/537973 (owner: 10Daimona Eaytoy) [19:05:22] 10MediaWiki-extensions-DocBookExport: DocBookExport to PDF fails on table - https://phabricator.wikimedia.org/T234139 (10Bgoldenl) [19:05:35] (03PS4) 10Krinkle: StringUtils: Clarify that isValidRegex is for PCRE regexps [core] - 10https://gerrit.wikimedia.org/r/537973 (owner: 10Daimona Eaytoy) [19:05:48] (03CR) 10Krinkle: [C: 03+2] StringUtils: Clarify that isValidRegex is for PCRE regexps [core] - 10https://gerrit.wikimedia.org/r/537973 (owner: 10Daimona Eaytoy) [19:05:50] 10MediaWiki-extensions-DocBookExport: DocBookExport to PDF fails on table - https://phabricator.wikimedia.org/T234139 (10Bgoldenl) [19:05:55] 10MediaWiki-Core-Testing: MediaWiki tests fails when run on Toolforge - https://phabricator.wikimedia.org/T234141 (10Zoranzoki21) [19:07:20] (03CR) 10Umherirrender: "But a revert does not make sense either. It is just a list, it is okay to avoid new patch sets, but revert seems overkill too, because it " [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/539675 (owner: 10Zoranzoki21) [19:09:24] (03CR) 10Krinkle: [C: 03+1] mediawiki.Title: Remove unused signature from newFromUserInput (031 comment) [core] - 10https://gerrit.wikimedia.org/r/510445 (owner: 10Thiemo Kreuz (WMDE)) [19:09:30] (03Abandoned) 10Krinkle: mediawiki.Title.newFromUserInput(): Remove dead code for second param [core] - 10https://gerrit.wikimedia.org/r/533089 (owner: 10Krinkle) [19:10:01] (03CR) 10Umherirrender: "Special:MyLanguage is only helpful when the wiki page is linked in the frontend. For backend I would expect english comments and english p" [core] - 10https://gerrit.wikimedia.org/r/534545 (https://phabricator.wikimedia.org/T232057) (owner: 10DannyS712) [19:10:25] 10MediaWiki-extensions-DocBookExport: DocBookExport to PDF fails on table - https://phabricator.wikimedia.org/T234139 (10Aklapper) Not sure why this task was assigned to Nischayn22? Removing assignee. [19:10:32] 10MediaWiki-extensions-DocBookExport: DocBookExport to PDF fails on table - https://phabricator.wikimedia.org/T234139 (10Aklapper) a:05Nischayn22→03None [19:11:33] (03PS1) 10Krinkle: Update StringUtils::isValidRegex() call to isValidPCRERegex() [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539677 [19:12:09] (03PS2) 10Krinkle: Update StringUtils::isValidRegex() call to isValidPCRERegex() [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539677 [19:12:11] (03PS3) 10Krinkle: Update StringUtils::isValidRegex() call to isValidPCRERegex() [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539677 [19:15:04] 10AbuseFilter: PHP notice about AbuseFilter: The group permissions "abusefilter-private-log" and "abusefilter-private" have been renamed - https://phabricator.wikimedia.org/T234140 (10MarcoAurelio) This is caused by c7ccb68. The permissions indeed have changed their naming. [19:15:50] 10MediaWiki-Core-Testing: MediaWiki tests fails when run on Toolforge - https://phabricator.wikimedia.org/T234141 (10Krinkle) There warning is unrelated to Toolforge and would be good to address first. It might solve the rest as well. More about that on the parent task. [19:16:16] 10AbuseFilter: PHP notice about AbuseFilter: The group permissions "abusefilter-private-log" and "abusefilter-private" have been renamed - https://phabricator.wikimedia.org/T234140 (10Krinkle) @Zoranzoki21 This means you need to update your LocalSettings.php file. [19:16:34] 10MediaWiki-Core-Testing: MediaWiki tests fails when run on Toolforge - https://phabricator.wikimedia.org/T234141 (10Zoranzoki21) >>! In T234141#5531911, @Krinkle wrote: > There warning is unrelated to Toolforge and would be good to address first. It might solve the rest as well. More about that on the parent ta... [19:18:30] 10AbuseFilter: PHP notice about AbuseFilter: The group permissions "abusefilter-private-log" and "abusefilter-private" have been renamed - https://phabricator.wikimedia.org/T234140 (10Zoranzoki21) What I should update here correctly? `lang=bash // AbuseFilter wfLoadExtension( 'AbuseFilter' ); $wgGroupPermissio... [19:20:18] 10MediaWiki-Gerrit-Group-Requests: +2 in mediawiki/* for Zoranzoki21 - https://phabricator.wikimedia.org/T231758 (10Zoranzoki21) 05Open→03Declined I don't see support, so I will close this task. [19:20:49] 10AbuseFilter: PHP notice about AbuseFilter: The group permissions "abusefilter-private-log" and "abusefilter-private" have been renamed - https://phabricator.wikimedia.org/T234140 (10MarcoAurelio) `$wgGroupPermissions['sysop']['abusefilter-privatedetails'] = true;` [19:21:27] 10AbuseFilter: PHP notice about AbuseFilter: The group permissions "abusefilter-private-log" and "abusefilter-private" have been renamed - https://phabricator.wikimedia.org/T234140 (10Zoranzoki21) 05Open→03Invalid [19:21:49] 10MediaWiki-extensions-DocBookExport: DocBookExport to PDF fails on table - https://phabricator.wikimedia.org/T234139 (10Aklapper) 05Open→03Stalled @Bgoldenl: Looking at http://guidelines.beefimprovement.org/index.php/Special:Version you seem to use the `git master` branch of https://gerrit.wikimedia.org/g/m... [19:22:23] 10MediaWiki-extensions-DocBookExport: DocBookExport to PDF fails on table: "DocBookExportAPI.php: Call to a member function exists() on null" - https://phabricator.wikimedia.org/T234139 (10Aklapper) [19:22:48] 10AbuseFilter: PHP notice about AbuseFilter: The group permissions "abusefilter-private-log" and "abusefilter-private" have been renamed - https://phabricator.wikimedia.org/T234140 (10Zoranzoki21) Tnx, fixed. [19:24:17] (03CR) 10Krinkle: "Looks good from a quick scan. There's a danger here though, in that it's very important to never set client max-age to anything other than" [core] - 10https://gerrit.wikimedia.org/r/536315 (https://phabricator.wikimedia.org/T196575) (owner: 10Dbarratt) [19:24:43] 10MediaWiki-Core-Testing: MediaWiki tests fails when run on Toolforge - https://phabricator.wikimedia.org/T234141 (10Zoranzoki21) [19:24:44] (03PS1) 10Umherirrender: Change @phan-property to @property [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/539678 [19:26:06] 10MediaWiki-Core-Testing: MediaWiki tests fails when run on Toolforge - https://phabricator.wikimedia.org/T234141 (10Krinkle) [19:26:08] 10AbuseFilter: PHP notice about AbuseFilter: The group permissions "abusefilter-private-log" and "abusefilter-private" have been renamed - https://phabricator.wikimedia.org/T234140 (10Krinkle) [19:26:17] 10MediaWiki-Core-Testing: MediaWiki tests fails when run on Toolforge - https://phabricator.wikimedia.org/T234141 (10Zoranzoki21) [19:26:19] 10MediaWiki-Core-Testing: MediaWiki tests fails when run on Toolforge - https://phabricator.wikimedia.org/T234141 (10Krinkle) [19:26:21] 10AbuseFilter: PHP notice about AbuseFilter: The group permissions "abusefilter-private-log" and "abusefilter-private" have been renamed - https://phabricator.wikimedia.org/T234140 (10Krinkle) [19:29:08] (03Merged) 10jenkins-bot: StringUtils: Clarify that isValidRegex is for PCRE regexps [core] - 10https://gerrit.wikimedia.org/r/537973 (owner: 10Daimona Eaytoy) [19:29:42] 10MediaWiki-Core-Testing: MediaWiki tests fails when run on Toolforge - https://phabricator.wikimedia.org/T234141 (10Krinkle) I believe these tests fail because the site language is set to `sr` instead of `en`. These tests are not related to language, but they are including some localised text and the test is fo... [19:29:54] (03CR) 10jenkins-bot: StringUtils: Clarify that isValidRegex is for PCRE regexps [core] - 10https://gerrit.wikimedia.org/r/537973 (owner: 10Daimona Eaytoy) [19:30:50] 10MediaWiki-Core-Testing, 10patch-welcome: MediaWiki OutputPageTest fails when run with lang=sr on Toolforge - https://phabricator.wikimedia.org/T234141 (10Krinkle) [19:30:53] 10MediaWiki-Core-Testing, 10patch-welcome: MediaWiki OutputPageTest fails when run with lang=sr on Toolforge - https://phabricator.wikimedia.org/T234141 (10Krinkle) [19:30:55] 10MediaWiki-Core-Testing, 10patch-welcome: MediaWiki OutputPageTest fails when run with lang=sr on Toolforge - https://phabricator.wikimedia.org/T234141 (10Zoranzoki21) >>! In T234141#5531931, @Krinkle wrote: > I believe these tests fail because the site language is set to `sr` instead of `en`. These tests are... [19:30:58] 10AbuseFilter: PHP notice about AbuseFilter: The group permissions "abusefilter-private-log" and "abusefilter-private" have been renamed - https://phabricator.wikimedia.org/T234140 (10Daimona) As a side note, that permission allows access to private user data (user agent and IP), and it's a bit concerning to se... [19:32:04] (03CR) 10Daimona Eaytoy: "I can update the name tomorrow, unless this is causing test failures elsewhere." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539677 (owner: 10Krinkle) [19:32:52] (03CR) 10Daimona Eaytoy: [C: 03+2] "> I can update the name tomorrow, unless this is causing test" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539677 (owner: 10Krinkle) [19:33:21] 10AbuseFilter: PHP notice about AbuseFilter: The group permissions "abusefilter-private-log" and "abusefilter-private" have been renamed - https://phabricator.wikimedia.org/T234140 (10Zoranzoki21) >>! In T234140#5531940, @Daimona wrote: > As a side note, that permission allows access to private user data (user... [19:33:49] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/537973 (owner: 10Daimona Eaytoy) [19:34:05] (03CR) 10Krinkle: "Yeah, sorry about the confusion. The revert was just me using it as a lazy way to create a commit that changed the same file and get a ref" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539677 (owner: 10Krinkle) [19:34:37] (03CR) 10jenkins-bot: StringUtils: Clarify that isValidRegex is for PCRE regexps [core] - 10https://gerrit.wikimedia.org/r/537973 (owner: 10Daimona Eaytoy) [19:35:46] (03CR) 10Krinkle: [C: 03+2] resourceloader: Remove support for $context === null in getContentObj [core] - 10https://gerrit.wikimedia.org/r/538564 (owner: 10Fomafix) [19:36:13] (03CR) 10Krinkle: [C: 03+2] "Confirmed in Logstash." [core] - 10https://gerrit.wikimedia.org/r/538564 (owner: 10Fomafix) [19:37:00] (03CR) 10jerkins-bot: [V: 04-1] Update StringUtils::isValidRegex() call to isValidPCRERegex() [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539677 (owner: 10Krinkle) [19:37:02] (03CR) 10Krinkle: [C: 03+2] resourceloader: Simplify makeLoaderStateScript and makeLoaderSourcesScript [core] - 10https://gerrit.wikimedia.org/r/539662 (owner: 10Fomafix) [19:38:16] (03CR) 10Krinkle: "Hm. I guess it's lagged. Lemme try that again..." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539677 (owner: 10Krinkle) [19:38:16] (03CR) 10Krinkle: "recheck" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539677 (owner: 10Krinkle) [19:38:46] 10ConfirmEdit (CAPTCHA extension): Implement support for new Google ReCaptcha v3 - https://phabricator.wikimedia.org/T208829 (10Florian) a:03Florian [19:41:37] (03CR) 10Umherirrender: "not a blocker" (034 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/539643 (https://phabricator.wikimedia.org/T207094) (owner: 10SBassett) [19:42:00] 10MediaWiki-extensions-OAuth: Database error after installing OAuth extension on wikismadebythepins.ml/community - https://phabricator.wikimedia.org/T234120 (10Zoranzoki21) Do you installed extension correctly per documentation: https://www.mediawiki.org/wiki/Extension:OAuth? [19:54:31] (03CR) 10jenkins-bot: StringUtils: Clarify that isValidRegex is for PCRE regexps [core] - 10https://gerrit.wikimedia.org/r/537973 (owner: 10Daimona Eaytoy) [19:54:50] (03PS1) 10Florianschmidtwelzow: Add v3 as possible version for ReCaptcha [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/539679 (https://phabricator.wikimedia.org/T208829) [19:55:39] (03Merged) 10jenkins-bot: Update StringUtils::isValidRegex() call to isValidPCRERegex() [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539677 (owner: 10Krinkle) [19:55:59] (03CR) 10jerkins-bot: [V: 04-1] Add v3 as possible version for ReCaptcha [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/539679 (https://phabricator.wikimedia.org/T208829) (owner: 10Florianschmidtwelzow) [19:56:32] (03CR) 10Florianschmidtwelzow: [C: 03+2] Remove redundant reference from EditPage hook handler [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/539657 (https://phabricator.wikimedia.org/T234118) (owner: 10Daimona Eaytoy) [19:57:52] (03CR) 10Catrope: [C: 03+2] resourceloader: Add version to ResourceLoaderImage urls for long-cache [core] - 10https://gerrit.wikimedia.org/r/539364 (https://phabricator.wikimedia.org/T233343) (owner: 10Krinkle) [19:57:57] (03CR) 10jerkins-bot: [V: 04-1] Add v3 as possible version for ReCaptcha [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/539679 (https://phabricator.wikimedia.org/T208829) (owner: 10Florianschmidtwelzow) [20:00:14] (03PS2) 10Florianschmidtwelzow: Add v3 as possible version for ReCaptcha [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/539679 (https://phabricator.wikimedia.org/T208829) [20:00:30] (03Merged) 10jenkins-bot: resourceloader: Remove support for $context === null in getContentObj [core] - 10https://gerrit.wikimedia.org/r/538564 (owner: 10Fomafix) [20:01:31] (03CR) 10jerkins-bot: [V: 04-1] Add v3 as possible version for ReCaptcha [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/539679 (https://phabricator.wikimedia.org/T208829) (owner: 10Florianschmidtwelzow) [20:02:22] (03Merged) 10jenkins-bot: resourceloader: Simplify makeLoaderStateScript and makeLoaderSourcesScript [core] - 10https://gerrit.wikimedia.org/r/539662 (owner: 10Fomafix) [20:03:54] (03CR) 10jerkins-bot: [V: 04-1] Add v3 as possible version for ReCaptcha [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/539679 (https://phabricator.wikimedia.org/T208829) (owner: 10Florianschmidtwelzow) [20:03:58] (03CR) 10jenkins-bot: Update StringUtils::isValidRegex() call to isValidPCRERegex() [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539677 (owner: 10Krinkle) [20:05:19] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/538564 (owner: 10Fomafix) [20:06:29] (03PS3) 10Florianschmidtwelzow: Add v3 as possible version for ReCaptcha [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/539679 (https://phabricator.wikimedia.org/T208829) [20:06:49] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/539662 (owner: 10Fomafix) [20:07:42] (03CR) 10jerkins-bot: [V: 04-1] Add v3 as possible version for ReCaptcha [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/539679 (https://phabricator.wikimedia.org/T208829) (owner: 10Florianschmidtwelzow) [20:07:58] (03PS4) 10Florianschmidtwelzow: Add v3 as possible version for ReCaptcha [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/539679 (https://phabricator.wikimedia.org/T208829) [20:15:53] (03CR) 10Florianschmidtwelzow: [C: 04-1] "There're also many more "hardcoded" urls, e.g.:" (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/447924 (owner: 10Paladox) [20:19:12] (03Merged) 10jenkins-bot: Remove redundant reference from EditPage hook handler [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/539657 (https://phabricator.wikimedia.org/T234118) (owner: 10Daimona Eaytoy) [20:20:54] (03Merged) 10jenkins-bot: resourceloader: Add version to ResourceLoaderImage urls for long-cache [core] - 10https://gerrit.wikimedia.org/r/539364 (https://phabricator.wikimedia.org/T233343) (owner: 10Krinkle) [20:21:13] (03CR) 10jenkins-bot: Remove redundant reference from EditPage hook handler [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/539657 (https://phabricator.wikimedia.org/T234118) (owner: 10Daimona Eaytoy) [20:23:04] (03CR) 10jenkins-bot: resourceloader: Remove support for $context === null in getContentObj [core] - 10https://gerrit.wikimedia.org/r/538564 (owner: 10Fomafix) [20:23:53] 10LogoFunctions: $wgNamespaceLogos sets logos on wrong namespaces - https://phabricator.wikimedia.org/T234098 (10Umherirrender) Possible a regression from the addition of extension.json - https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/LogoFunctions/+/509154/ There is no merge strategy on the config, wh... [20:25:19] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/539364 (https://phabricator.wikimedia.org/T233343) (owner: 10Krinkle) [20:28:21] 10GlobalBlocking: Possibly wrong global block error in Special:PasswordReset - https://phabricator.wikimedia.org/T234125 (10Umherirrender) Maybe not the user is blocked, but the IP used by the user. Global blocks can also prevent login. The user can visit `Special:MyContributions` logged out to see if there is... [20:45:59] (03CR) 10jenkins-bot: resourceloader: Simplify makeLoaderStateScript and makeLoaderSourcesScript [core] - 10https://gerrit.wikimedia.org/r/539662 (owner: 10Fomafix) [21:03:50] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01): Newcomer tasks: welcome survey changes - https://phabricator.wikimedia.org/T232400 (10RHo) >>! In T232400#5531240, @MMiller_WMF wrote: > @RHo can speak to whether the "Please se... [21:08:58] (03CR) 10jenkins-bot: resourceloader: Add version to ResourceLoaderImage urls for long-cache [core] - 10https://gerrit.wikimedia.org/r/539364 (https://phabricator.wikimedia.org/T233343) (owner: 10Krinkle) [21:21:03] (03CR) 10Esanders: "yes" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/538253 (owner: 10Esanders) [21:27:37] (03PS1) 10Umherirrender: Use IMaintainableDatabase in RcParamsTypeCheck [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/539682 [21:29:11] (03PS1) 10Umherirrender: Remove unused var from CreateHumanReadableProjectNameFiles [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/539683 [21:32:56] (03CR) 10Krinkle: [C: 03+2] eslint: Enable no-proxy rule (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/538252 (owner: 10Esanders) [21:34:37] (03CR) 10Krinkle: Use IMaintainableDatabase in RcParamsTypeCheck (031 comment) [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/539682 (owner: 10Umherirrender) [21:35:00] (03CR) 10Krinkle: [C: 03+2] Remove unused var from CreateHumanReadableProjectNameFiles [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/539683 (owner: 10Umherirrender) [21:35:09] (03CR) 10Krinkle: [C: 04-1] Use IMaintainableDatabase in RcParamsTypeCheck [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/539682 (owner: 10Umherirrender) [21:37:15] (03Merged) 10jenkins-bot: eslint: Enable no-proxy rule [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/538252 (owner: 10Esanders) [21:37:17] (03Merged) 10jenkins-bot: build: Update linters [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/538253 (owner: 10Esanders) [21:38:29] (03Merged) 10jenkins-bot: Remove unused var from CreateHumanReadableProjectNameFiles [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/539683 (owner: 10Umherirrender) [21:38:45] (03PS1) 10Umherirrender: Use ExternalStoreFactory in renameWiki.php [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/539684 [21:41:34] (03CR) 10jenkins-bot: eslint: Enable no-proxy rule [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/538252 (owner: 10Esanders) [21:41:36] (03CR) 10jenkins-bot: build: Update linters [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/538253 (owner: 10Esanders) [21:46:31] (03PS2) 10Umherirrender: Use IMaintainableDatabase in RcParamsTypeCheck [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/539682 [21:46:46] (03CR) 10Umherirrender: Use IMaintainableDatabase in RcParamsTypeCheck (031 comment) [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/539682 (owner: 10Umherirrender) [21:56:31] 10Spanish-Sites: "Could not open JPA EntityManager for transaction" error appears when using Replacer tool on Spanish Wikipedia - https://phabricator.wikimedia.org/T234145 (10Agusbou2015) [22:00:56] (03CR) 10Krinkle: [C: 04-1] Use IMaintainableDatabase in RcParamsTypeCheck (031 comment) [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/539682 (owner: 10Umherirrender) [23:01:20] (03PS5) 10DannyS712: API: Alter behaviour if state doesn't change instead of proceeding [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539624 (https://phabricator.wikimedia.org/T234074) [23:02:05] (03CR) 10DannyS712: API: Alter behaviour if state doesn't change instead of proceeding (035 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539624 (https://phabricator.wikimedia.org/T234074) (owner: 10DannyS712) [23:17:41] (03Abandoned) 10Krinkle: Remove obsolete `.vectorMenu ul` selector [skins/Vector] (wmf/1.34.0-wmf.23) - 10https://gerrit.wikimedia.org/r/537770 (owner: 10Krinkle) [23:21:51] (03CR) 10Krinkle: "Net diff:" [skins/Vector] - 10https://gerrit.wikimedia.org/r/539443 (https://phabricator.wikimedia.org/T4013) (owner: 10VolkerE) [23:23:13] (03CR) 10Krinkle: [C: 03+2] "And visually identical" [skins/Vector] - 10https://gerrit.wikimedia.org/r/539443 (https://phabricator.wikimedia.org/T4013) (owner: 10VolkerE) [23:54:48] (03Merged) 10jenkins-bot: Unify LESS variable naming scheme for `@line-height-*` variables [skins/Vector] - 10https://gerrit.wikimedia.org/r/539443 (https://phabricator.wikimedia.org/T4013) (owner: 10VolkerE)