[00:01:52] (03CR) 10jenkins-bot: Fix alignment of bytes indicator on mobile diff page. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/539423 (owner: 10Jdrewniak) [00:01:53] (03PS4) 10Jdrewniak: Refactor "last-modified" bar to use flexbox layout. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/539310 (https://phabricator.wikimedia.org/T233172) [00:03:15] (03PS5) 10Jdrewniak: Refactor "last-modified" bar to use flexbox layout. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/539310 (https://phabricator.wikimedia.org/T233172) [00:05:27] (03CR) 10jenkins-bot: Add a run mode to $wgDisableQueryPageUpdate [core] - 10https://gerrit.wikimedia.org/r/530870 (https://phabricator.wikimedia.org/T78711) (owner: 10Umherirrender) [00:05:44] (03CR) 10Krinkle: Add optional serialization_type and hmac_key param values to RESTBagOStuff (031 comment) [core] - 10https://gerrit.wikimedia.org/r/539382 (https://phabricator.wikimedia.org/T233963) (owner: 10BPirkle) [00:07:22] 04(no projects): Unhandled Exception ("ArgumentCountError") when loading Phabricator - https://phabricator.wikimedia.org/T233999 (10Agusbou2015) [00:07:27] 10Phabricator: ArgumentCountError on Phabricator - https://phabricator.wikimedia.org/T233998 (10Agusbou2015) [00:13:34] (03Merged) 10jenkins-bot: filebackend: avoid use of wfWikiId() in FileBackendGroup [core] - 10https://gerrit.wikimedia.org/r/520703 (owner: 10Aaron Schulz) [00:13:42] (03Merged) 10jenkins-bot: objectcache: fully respect "pcTTL" in WANObjectCache instead of using INF when >= 0 [core] - 10https://gerrit.wikimedia.org/r/538851 (owner: 10Aaron Schulz) [00:13:45] (03CR) 10jerkins-bot: [V: 04-1] tests: Replace PHPUnit's loose assertEquals(null) with assertNull() [core] - 10https://gerrit.wikimedia.org/r/537440 (owner: 10Thiemo Kreuz (WMDE)) [00:16:41] (03PS3) 10Jdlrobson: Vertically align the page issues icon with the text [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/538710 (https://phabricator.wikimedia.org/T232837) [00:18:31] (03CR) 10BPirkle: Add optional serialization_type and hmac_key param values to RESTBagOStuff (031 comment) [core] - 10https://gerrit.wikimedia.org/r/539382 (https://phabricator.wikimedia.org/T233963) (owner: 10BPirkle) [00:18:38] (03CR) 10Jdlrobson: [C: 03+2] Refactor "last-modified" bar to use flexbox layout. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/539310 (https://phabricator.wikimedia.org/T233172) (owner: 10Jdrewniak) [00:19:04] (03PS4) 10Jdlrobson: Vertically align the page issues icon with the text [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/538710 (https://phabricator.wikimedia.org/T232837) [00:19:24] (03CR) 10jerkins-bot: [V: 04-1] Baseline reference interaction tracking [extensions/Cite] - 10https://gerrit.wikimedia.org/r/538261 (https://phabricator.wikimedia.org/T231529) (owner: 10Awight) [00:20:43] (03CR) 10jerkins-bot: [V: 04-1] tests: Replace PHPUnit's loose assertEquals(null) with assertNull() [core] - 10https://gerrit.wikimedia.org/r/537440 (owner: 10Thiemo Kreuz (WMDE)) [00:21:14] 10Advanced Mobile Contributions, 10MinervaNeue, 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), 10Mobile, and 2 others: [ICONS] reference drawer icon and alignment - https://phabricator.wikimedia.org/T233152 (10Jdlrobson) a:05Jdrewniak→03alexhollender [00:21:15] 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Display core version of watchlist page for AMC users - https://phabricator.wikimedia.org/T225127 (10Jdlrobson) a:05Jdrewniak→03alexhollender [00:21:30] 10Advanced Mobile Contributions, 10MinervaNeue, 10MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), 10Mobile, and 3 others: [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency - https://phabricator.wikimedia.org/T229440 (10Jdlrobson) a:03alexhollender [00:22:35] 10Patch-For-Review, 10VisualEditor (Current work): Wrong hyperlink in link dialog in VisualEditor - https://phabricator.wikimedia.org/T233628 (10ti_infotrad) OK so the change describe by the diff below seems to work, at least for me... In file modules\ve-mw\ui\contextitemsve.ui.MWInternalLinkContextItem.js `... [00:23:16] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Product-Analytics, 10Growth-Team (Current Sprint): Newcomer tasks: instrumentation - https://phabricator.wikimedia.org/T230068 (10nettrom_WMF) p:05Triage→03Normal [00:23:28] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Product-Analytics, 10Growth-Team (Current Sprint): Newcomer tasks: instrumentation - https://phabricator.wikimedia.org/T230068 (10nettrom_WMF) a:03nettrom_WMF [00:23:46] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Product-Analytics, 10Growth-Team (Current Sprint): Newcomer tasks: instrumentation - https://phabricator.wikimedia.org/T230068 (10nettrom_WMF) [00:24:28] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Product-Analytics, 10Growth-Team (Current Sprint): Newcomer tasks: instrumentation - https://phabricator.wikimedia.org/T230068 (10nettrom_WMF) The draft measurement plan is being worked on, so I've claimed this task, updated tags, and moved it to the ri... [00:24:41] 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Display core version of watchlist page for AMC users - https://phabricator.wikimedia.org/T225127 (10Jdlrobson) [00:25:19] (03Merged) 10jenkins-bot: Align LESS color variables to naming scheme, combine and cleanup [skins/Vector] - 10https://gerrit.wikimedia.org/r/539420 (owner: 10VolkerE) [00:25:23] (03Merged) 10jenkins-bot: Update LESS variable naming scheme for `@font-family*` variables [skins/Vector] - 10https://gerrit.wikimedia.org/r/539431 (owner: 10VolkerE) [00:25:25] (03Merged) 10jenkins-bot: Update outdated storybook assets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/539430 (owner: 10Jdlrobson) [00:25:45] 10MobileFrontend, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), 10good first bug: Rollback link on mobile should be styled on Special:Watchlist, Special:RecentChanges and Special:Contributions - https://phabricator.wikimedia.org/T232284 (10Jdlrobson) [00:25:47] 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Display core version of watchlist page for AMC users - https://phabricator.wikimedia.org/T225127 (10Jdlrobson) One more FOUC: {F30478524} Issue 2: {F30478530} Issue 3 Text... [00:28:32] (03CR) 10jenkins-bot: Add .pipeline/ with dev image variant [core] - 10https://gerrit.wikimedia.org/r/525972 (https://phabricator.wikimedia.org/T218360) (owner: 10Brennen Bearnes) [00:29:49] (03CR) 10Jdrewniak: [C: 03+2] Vertically align the page issues icon with the text [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/538710 (https://phabricator.wikimedia.org/T232837) (owner: 10Jdlrobson) [00:32:06] wikimedia/mediawiki#25699 (master - e75daac jenkins-bot): The build has errored. - https://travis-ci.org/wikimedia/mediawiki/builds/590201875 [00:32:13] (03CR) 10jenkins-bot: Update outdated storybook assets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/539430 (owner: 10Jdlrobson) [00:32:32] 10OWC2020, 10Product-Analytics: Analyze "junior contributor" talk page participation - https://phabricator.wikimedia.org/T233261 (10MNeisler) Here's an updated chart showing year over year changes in the number of distinct junior contributors contributing to talk pages from August 2014 through August 2019. {F3... [00:42:28] (03CR) 10jerkins-bot: [V: 04-1] Remove @embed page load delays (and misc optimisations) [skins/Vector] - 10https://gerrit.wikimedia.org/r/528480 (https://phabricator.wikimedia.org/T121730) (owner: 10Krinkle) [00:43:39] (03CR) 10BPirkle: "tests added" [core] - 10https://gerrit.wikimedia.org/r/539382 (https://phabricator.wikimedia.org/T233963) (owner: 10BPirkle) [00:45:08] (03CR) 10jerkins-bot: [V: 04-1] Vertically align the page issues icon with the text [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/538710 (https://phabricator.wikimedia.org/T232837) (owner: 10Jdlrobson) [00:47:31] (03Merged) 10jenkins-bot: Refactor "last-modified" bar to use flexbox layout. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/539310 (https://phabricator.wikimedia.org/T233172) (owner: 10Jdrewniak) [00:50:55] (03CR) 10jenkins-bot: Refactor "last-modified" bar to use flexbox layout. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/539310 (https://phabricator.wikimedia.org/T233172) (owner: 10Jdrewniak) [00:54:09] 10Phabricator: ArgumentCountError on Phabricator - https://phabricator.wikimedia.org/T233998 (10mmodell) 05Open→03Resolved a:03mmodell [00:54:11] (03CR) 10jenkins-bot: objectcache: fully respect "pcTTL" in WANObjectCache instead of using INF when >= 0 [core] - 10https://gerrit.wikimedia.org/r/538851 (owner: 10Aaron Schulz) [00:54:38] (03CR) 10Tim Starling: [C: 04-1] "Looks good to me. This can be merged after the inline comments are addressed." (035 comments) [core] - 10https://gerrit.wikimedia.org/r/538314 (https://phabricator.wikimedia.org/T198343) (owner: 10Ppchelko) [00:55:03] (03CR) 10jerkins-bot: [V: 04-1] Vertically align the page issues icon with the text [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/538710 (https://phabricator.wikimedia.org/T232837) (owner: 10Jdlrobson) [01:02:33] (03PS1) 10Tim Starling: In recompressTracked.php, fix the names of things related to child processes [core] - 10https://gerrit.wikimedia.org/r/539438 [01:08:02] (03PS1) 10Alex Paskulin: docs: Convert class-level documentation files to Markdown [core] - 10https://gerrit.wikimedia.org/r/539439 (https://phabricator.wikimedia.org/T87796) [01:11:33] (03CR) 10Nray: [C: 04-1] "FWIW, I'm not sure if this is any better or desirable and its definitely more confusing, but I had some initial success with the regex:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/539213 (https://phabricator.wikimedia.org/T232690) (owner: 10Jdlrobson) [01:11:35] (03PS2) 10VolkerE: Unify LESS variable naming scheme for `@font-size-*` variables [skins/Vector] - 10https://gerrit.wikimedia.org/r/539434 [01:14:20] (03PS6) 10Accraze: Implement api modules [extensions/Jade] - 10https://gerrit.wikimedia.org/r/536659 (https://phabricator.wikimedia.org/T199834) [01:14:26] (03CR) 10jerkins-bot: [V: 04-1] Implement api modules [extensions/Jade] - 10https://gerrit.wikimedia.org/r/536659 (https://phabricator.wikimedia.org/T199834) (owner: 10Accraze) [01:14:28] (03CR) 10jerkins-bot: [V: 04-1] Implement api modules [extensions/Jade] - 10https://gerrit.wikimedia.org/r/536659 (https://phabricator.wikimedia.org/T199834) (owner: 10Accraze) [01:15:50] (03CR) 10jenkins-bot: filebackend: avoid use of wfWikiId() in FileBackendGroup [core] - 10https://gerrit.wikimedia.org/r/520703 (owner: 10Aaron Schulz) [01:29:25] (03CR) 10jerkins-bot: [V: 04-1] docs: Convert class-level documentation files to Markdown [core] - 10https://gerrit.wikimedia.org/r/539439 (https://phabricator.wikimedia.org/T87796) (owner: 10Alex Paskulin) [01:30:42] 10MediaWiki-Documentation, 10MediaWiki-File-management, 10Documentation, 10Patch-For-Review, 10good first bug: Add includes/filebackend/README as generated documentation page - https://phabricator.wikimedia.org/T87796 (10apaskulin) With Markdown support enabled in Doxygen, we have the option to generate... [01:31:49] (03CR) 10jerkins-bot: [V: 04-1] docs: Convert class-level documentation files to Markdown [core] - 10https://gerrit.wikimedia.org/r/539439 (https://phabricator.wikimedia.org/T87796) (owner: 10Alex Paskulin) [01:37:40] (03PS2) 10Alex Paskulin: (WIP) docs: Convert class-level documentation files to Markdown [core] - 10https://gerrit.wikimedia.org/r/539439 (https://phabricator.wikimedia.org/T87796) [01:46:24] (03CR) 10VolkerE: Unify LESS variable naming scheme for `@font-size-*` variables (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/539434 (owner: 10VolkerE) [01:49:52] (03CR) 10Tim Starling: [C: 04-1] "The main reason I avoid end() in new code is because it separates (copies) the array if the reference count is >1." [core] - 10https://gerrit.wikimedia.org/r/499468 (owner: 10Thiemo Kreuz (WMDE)) [01:53:21] (03PS3) 10VolkerE: Unify LESS variable naming scheme for `@font-size-*` variables [skins/Vector] - 10https://gerrit.wikimedia.org/r/539434 [01:55:33] (03PS1) 10VolkerE: Replace fixed value with mediawiki.ui variable [skins/Vector] - 10https://gerrit.wikimedia.org/r/539440 [02:19:48] (03CR) 10Krinkle: [C: 03+2] In recompressTracked.php, fix the names of things related to child processes [core] - 10https://gerrit.wikimedia.org/r/539438 (owner: 10Tim Starling) [02:21:49] (03CR) 10Krinkle: [C: 03+2] Unify LESS variable naming scheme for `@font-size-*` variables [skins/Vector] - 10https://gerrit.wikimedia.org/r/539434 (owner: 10VolkerE) [02:22:39] (03CR) 10Krinkle: [C: 03+2] Replace fixed value with mediawiki.ui variable [skins/Vector] - 10https://gerrit.wikimedia.org/r/539440 (owner: 10VolkerE) [02:24:35] 10Password-Reset-Update, 10Community-Tech (Kanban (Q1 2019-20)): Update Temporary Password Email with Preference Info [x-small] - https://phabricator.wikimedia.org/T233969 (10MaxSem) a:03MaxSem //password reset preference// does not explain what preference is this, can we clarify this? [02:42:04] 10Password-Reset-Update: Two-factor login, turning off credetials - https://phabricator.wikimedia.org/T234001 (10jeblad) [02:44:08] 10Password-Reset-Update: Two-factor login, turning off credetials - https://phabricator.wikimedia.org/T234001 (10jeblad) [02:48:19] (03Merged) 10jenkins-bot: In recompressTracked.php, fix the names of things related to child processes [core] - 10https://gerrit.wikimedia.org/r/539438 (owner: 10Tim Starling) [02:49:02] (03Merged) 10jenkins-bot: Unify LESS variable naming scheme for `@font-size-*` variables [skins/Vector] - 10https://gerrit.wikimedia.org/r/539434 (owner: 10VolkerE) [02:49:41] 10MediaWiki-extensions-OATHAuth: Two-factor login, turning off credetials - https://phabricator.wikimedia.org/T234001 (10AntiCompositeNumber) [02:50:38] 10Phabricator, 10Wikimedia-Logstash, 10observability, 10Release-Engineering-Team-TODO (201909): Improve error reporting / integration between Kibana and Phabricator - https://phabricator.wikimedia.org/T185155 (10mmodell) 05Open→03Resolved [02:50:40] 10Wikimedia-Logstash, 10observability: Automatically log fatals/exceptions into Phabricator with stack traces - https://phabricator.wikimedia.org/T70820 (10mmodell) [02:50:53] (03Merged) 10jenkins-bot: Replace fixed value with mediawiki.ui variable [skins/Vector] - 10https://gerrit.wikimedia.org/r/539440 (owner: 10VolkerE) [02:56:26] 10WMSE-Riksarkivet-TORA: Möte Digisam 14:00 - https://phabricator.wikimedia.org/T233911 (10Salgo60) 05Open→03Resolved a:03Salgo60 Spoke 2 hours no actions.... [03:03:24] (03CR) 10Tim Starling: [C: 04-1] objectcache: make incr() and incrWithInit() atomic in APCUBagOStuff (031 comment) [core] - 10https://gerrit.wikimedia.org/r/524078 (owner: 10Aaron Schulz) [03:07:47] 10MediaWiki-Core-Testing: Make MediaWiki Wdio tests less slow (Sept 2019) - https://phabricator.wikimedia.org/T234002 (10Krinkle) [03:07:57] 10MediaWiki-Core-Testing: Make MediaWiki Wdio tests less slow (Sept 2019) - https://phabricator.wikimedia.org/T234002 (10Krinkle) [03:08:00] 10MediaWiki-Core-Testing, 10Release-Engineering-Team-TODO, 10Code-Health, 10Continuous-Integration-Config, and 4 others: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Krinkle) [03:12:34] (03CR) 10jenkins-bot: In recompressTracked.php, fix the names of things related to child processes [core] - 10https://gerrit.wikimedia.org/r/539438 (owner: 10Tim Starling) [03:24:39] 10MediaWiki-extensions-OATHAuth: Two-factor login, turning off credetials - https://phabricator.wikimedia.org/T234001 (10jeblad) [03:25:35] (03PS1) 10Krinkle: [WIP] build: Upgrade from webdriver v4 to v5 [core] - 10https://gerrit.wikimedia.org/r/539441 (https://phabricator.wikimedia.org/T234002) [03:31:21] (03CR) 10jerkins-bot: [V: 04-1] [WIP] build: Upgrade from webdriver v4 to v5 [core] - 10https://gerrit.wikimedia.org/r/539441 (https://phabricator.wikimedia.org/T234002) (owner: 10Krinkle) [03:35:52] 10MediaWiki-extensions-OATHAuth: Two-factor login, turning off credetials - https://phabricator.wikimedia.org/T234001 (10jeblad) 05Open→03Invalid I've might have disabled 2fa previously due to problems with a bot, not quite sure, but seems to remember something like that. Perhaps I forgot to save the new scr... [03:41:14] 10MediaWiki-extensions-OATHAuth: 2fa, add timestamp to scratch codes - https://phabricator.wikimedia.org/T234004 (10jeblad) [03:46:33] 10Wikimedia-Site-requests, 10Chinese-Sites: Enable Flagged Revisions (for trial run purpose) at the Chinese Wikipedia - https://phabricator.wikimedia.org/T221933 (10Shizhao) @Hamishcn **abandoned** [03:48:55] 10MediaWiki-API, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review, 10Wikimedia-production-error (Shared Build Failure): Flaky test: ApiMainTest::testAddRequestedFieldsCurTimestamp - https://phabricator.wikimedia.org/T233752 (10Krinkle) I see. Note that the workload depends on the repo... [03:49:29] (03CR) 10jerkins-bot: [V: 04-1] [WIP] build: Upgrade from webdriver v4 to v5 [core] - 10https://gerrit.wikimedia.org/r/539441 (https://phabricator.wikimedia.org/T234002) (owner: 10Krinkle) [03:50:21] 10MediaWiki-extensions-OATHAuth: 2fa, add timestamp to scratch codes - https://phabricator.wikimedia.org/T234004 (10jeblad) [03:52:02] (03PS2) 10Krinkle: [WIP] build: Upgrade from webdriver v4 to v5 [core] - 10https://gerrit.wikimedia.org/r/539441 (https://phabricator.wikimedia.org/T234002) [03:52:27] (03CR) 10Krinkle: "Fails in CI because Quibble starts chromedriver manually instead of using the selenium.sh script, and wdio v5 can/wants to start its own c" [core] - 10https://gerrit.wikimedia.org/r/539441 (https://phabricator.wikimedia.org/T234002) (owner: 10Krinkle) [03:57:43] (03CR) 10jerkins-bot: [V: 04-1] [WIP] build: Upgrade from webdriver v4 to v5 [core] - 10https://gerrit.wikimedia.org/r/539441 (https://phabricator.wikimedia.org/T234002) (owner: 10Krinkle) [04:01:38] 10MediaWiki-Page-History, 10Wikidata, 10User-DannyS712: Collapsed history issue on wikidata - https://phabricator.wikimedia.org/T234005 (10DannyS712) [04:11:08] 10Language-Team (Language-2019-July-September): Recreate Language team's test instances - https://phabricator.wikimedia.org/T233297 (10KartikMistry) [04:15:21] (03CR) 10jerkins-bot: [V: 04-1] [WIP] build: Upgrade from webdriver v4 to v5 [core] - 10https://gerrit.wikimedia.org/r/539441 (https://phabricator.wikimedia.org/T234002) (owner: 10Krinkle) [04:19:26] 10Password-Reset-Update, 10Community-Tech (Kanban (Q1 2019-20)): Update Temporary Password Email with Preference Info [x-small] - https://phabricator.wikimedia.org/T233969 (10ifried) @MaxSem Great point. The current language may be too vague. Prateek and I came up with the wording right before estimation, and... [04:33:58] (03PS1) 10VolkerE: Unify LESS variable naming scheme for `@line-height-*` variables [skins/Vector] - 10https://gerrit.wikimedia.org/r/539443 (https://phabricator.wikimedia.org/T4013) [04:37:00] 10MediaWiki-Special-pages, 10Commons, 10User-DannyS712: Extraneous space on commons' listusers - https://phabricator.wikimedia.org/T234006 (10DannyS712) [04:41:36] 10Research: Give a talk about the The Role of Wikipedia in the AI Ecosystem at Catholic University of Chile - https://phabricator.wikimedia.org/T234007 (10diego) [04:45:45] 10Research: Give a talk about the Research Team at Wikimedia Chile - https://phabricator.wikimedia.org/T234008 (10diego) [04:45:56] 10Research: Give a talk about the Research Team at Wikimedia Chile - https://phabricator.wikimedia.org/T234008 (10diego) 05Open→03Resolved [04:46:22] 10Research: Give a talk about the The Role of Wikipedia in the AI Ecosystem at Catholic University of Chile - https://phabricator.wikimedia.org/T234007 (10diego) [[https://commons.wikimedia.org/wiki/File:The_role_of_Wikipedia_on_AI_(Wikimania,_2019).pdf | Slides]] [04:46:22] (03PS1) 10Fomafix: resourceloader: Add type hints for type ResourceLoaderContext [core] - 10https://gerrit.wikimedia.org/r/539444 [04:46:37] 10Research: Give a talk about the The Role of Wikipedia in the AI Ecosystem at Catholic University of Chile - https://phabricator.wikimedia.org/T234007 (10diego) 05Open→03Resolved [04:47:01] 10Research: Give a talk about the The Role of Wikipedia in the AI Ecosystem at Catholic University of Chile - https://phabricator.wikimedia.org/T234007 (10diego) [04:59:17] (03PS1) 10Arshia Md: Added Extension Name [extensions/Echo] - 10https://gerrit.wikimedia.org/r/539448 [05:00:57] (03PS1) 10Haritha Mattupalli: Added Extension name [extensions/Echo] - 10https://gerrit.wikimedia.org/r/539450 [05:14:28] (03PS1) 10Lalitha Nimmaraju: About this README [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/539451 [05:30:32] 10MediaWiki-extensions-Lockdown, 10Page-Issue-Warnings: MW 1.31: Lockdown fails to open something from /mediawiki/includes/cache/localisation/LocalisationCache.php - https://phabricator.wikimedia.org/T234010 (10Stefahn) [06:35:56] (03CR) 10Samwilson: [C: 03+1] "Works in my testing." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/535725 (https://phabricator.wikimedia.org/T231357) (owner: 10MaxSem) [06:49:39] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/539454 (owner: 10L10n-bot) [07:02:22] 10ContentTranslation, 10Language-Team (Language-2019-July-September): CX2: Uncaught TypeError: Cannot read property 'element' of null at VeCeCXTransclusionInlineNode.ve.ce.View.initialize (ve.ce.View.js?9c8a2:109) - https://phabricator.wikimedia.org/T205429 (10Petar.petkovic) >>! In T205429#5527148, @Jpita wro... [07:14:00] 10Structured Data Engineering, 10Structured-Data-Backlog (Current Work): Links to Wikidata Q-items don't open in a new tab - https://phabricator.wikimedia.org/T233267 (10matthiasmullie) a:03matthiasmullie [07:24:25] 10MediaWiki-extensions-OATHAuth: Two-factor login, turning off credentials - https://phabricator.wikimedia.org/T234001 (10Aklapper) [07:25:05] 10MediaWiki-extensions-Lockdown: MW 1.31: Lockdown fails to open something from /mediawiki/includes/cache/localisation/LocalisationCache.php - https://phabricator.wikimedia.org/T234010 (10Aklapper) Removing #page-issue-warnings per its description. [07:25:49] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/539489 (owner: 10L10n-bot) [07:26:51] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/539489 (owner: 10L10n-bot) [07:27:59] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Babel] - 10https://gerrit.wikimedia.org/r/539464 (owner: 10L10n-bot) [07:28:48] 10MediaWiki-Page-deletion, 10MediaWiki-Special-pages, 10Core Platform Team, 10User-DannyS712: Convert deletion from action page to new `Special:Delete` - https://phabricator.wikimedia.org/T233987 (10Aklapper) [07:29:31] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/539470 (owner: 10L10n-bot) [07:29:31] 10CheckUser, 10Anti-Harassment (The Letter Song), 10Patch-For-Review: Add SQLite Schema - https://phabricator.wikimedia.org/T233983 (10Aklapper) [07:32:48] 10MediaWiki-extensions-Page_Forms: Allow hiding columns on Special:MultiPageEdit to make the view clearer - https://phabricator.wikimedia.org/T233914 (10Nicolas_NALLET) a:03Yaron_Koren [07:34:49] 10Wikidata-Trailblazing-Exploration: Eliminate Browser Tests Flakiness - https://phabricator.wikimedia.org/T234012 (10alaa_wmde) [07:34:59] 10Wikidata-Trailblazing-Exploration: Eliminate Browser Tests Flakiness - https://phabricator.wikimedia.org/T234012 (10alaa_wmde) [07:35:21] 10Wikidata-Trailblazing-Exploration: Eliminate Browser Tests Flakiness - https://phabricator.wikimedia.org/T234012 (10alaa_wmde) [07:35:32] 10Wikidata-Trailblazing-Exploration: Eliminate Browser Tests Flakiness - https://phabricator.wikimedia.org/T234012 (10alaa_wmde) [07:35:39] 10Wikidata-Trailblazing-Exploration: Eliminate Browser Tests Flakiness - https://phabricator.wikimedia.org/T234012 (10alaa_wmde) [07:36:36] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/539481 (owner: 10L10n-bot) [07:38:49] 10Wikidata-Trailblazing-Exploration: Eliminate Browser Tests Flakiness - https://phabricator.wikimedia.org/T234012 (10alaa_wmde) [07:39:51] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/539469 (owner: 10L10n-bot) [07:40:22] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539482 (owner: 10L10n-bot) [07:42:57] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/539483 (owner: 10L10n-bot) [07:46:25] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/539478 (owner: 10L10n-bot) [07:49:02] 10Who-Wrote-That, 10Community-Tech (Kanban (Q1 2019-20)): Spike: Investigate Errors Upon First Load in WWT [8 hours] - https://phabricator.wikimedia.org/T232232 (10Samwilson) This issue is proving annoying to work on, because failing on the first load seems to be much less frequent now than it was a couple of... [07:51:50] (03PS1) 10Pwirth: Add Hook for legacy extension that used to modify store data directly. [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/539492 [07:53:49] (03CR) 10Nikerabbit: [C: 03+1] "This stops the logspam in translatewiki.net" [core] - 10https://gerrit.wikimedia.org/r/539215 (https://phabricator.wikimedia.org/T230690) (owner: 10Krinkle) [07:53:51] (03PS14) 10Pwirth: Add assigned pages data collector and modern page assignments store [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/534446 [07:57:47] (03CR) 10Awight: "recheck" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/538261 (https://phabricator.wikimedia.org/T231529) (owner: 10Awight) [08:01:38] 10ContentTranslation, 10Language-Team (Language-2019-July-September): Changing MT engines from Google to Yandex throws error on console - https://phabricator.wikimedia.org/T233964 (10Pginer-WMF) p:05Triage→03Normal The impact seems to be just the javascript error, which is worth fixing, but there is no oth... [08:02:49] (03CR) 10Awight: "Also, in this repo there seems to be a tradition of pushing a tag like "1.9.0", once this is merged. I don't know who does that or whethe" [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/539435 (owner: 10Tim Starling) [08:21:03] 10ContentTranslation, 10Language-Team (Language-2019-July-September): CX2: Uncaught TypeError: Cannot read property 'element' of null at VeCeCXTransclusionInlineNode.ve.ce.View.initialize (ve.ce.View.js?9c8a2:109) - https://phabricator.wikimedia.org/T205429 (10Pginer-WMF) >>! In T205429#5528664, @Petar.petkovi... [08:24:12] 10WMSE-Wikispeech-Speech-Data-Collector-2019: Communicate start of new WIkispeech project - https://phabricator.wikimedia.org/T234015 (10Lokal_Profil) [08:24:23] 10WMSE-Wikispeech-Speech-Data-Collector-2019: Communicate start of new WIkispeech project - https://phabricator.wikimedia.org/T234015 (10Lokal_Profil) [08:24:33] 10WMSE-Wikispeech-Speech-Data-Collector-2019: Communicate start of new Wikispeech project - https://phabricator.wikimedia.org/T234015 (10Lokal_Profil) [08:24:42] (03PS15) 10Pwirth: Add assigned pages data collector and modern page assignments store [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/534446 [08:27:37] 10MediaWiki-API, 10MediaWiki-Core-Testing, 10Core Platform Team, 10Test-Coverage: Coverage of ApiQuerySiteinfoTest:testContinuation takes 50+ seconds - https://phabricator.wikimedia.org/T234016 (10hashar) [08:28:21] 10Space (Jul-Sep-2019): Success criteria to move Wikimedia Space to production servers - https://phabricator.wikimedia.org/T227308 (10Qgil) p:05Normal→03High I plan to wrap up this task next week [08:36:18] (03PS2) 10Thiemo Kreuz (WMDE): special.version.css: Replace problematic BIDI attribute with dir [core] - 10https://gerrit.wikimedia.org/r/539124 (https://phabricator.wikimedia.org/T231323) [08:36:55] 10MediaWiki-Logging, 10Regression: Protect log entries offer link to change protection only to unprivileged users - https://phabricator.wikimedia.org/T234017 (10Schnark) [08:44:29] (03PS5) 10Daniel Kinzler: [EXPERIMENTAL] RevisionStore: Introduce getSlotRowsForBatch [core] - 10https://gerrit.wikimedia.org/r/539324 (https://phabricator.wikimedia.org/T228675) [08:46:24] 10Design, 10MediaWiki-Special-pages, 10Patch-For-Review, 10Upstream, 10User-D3r1ck01: In Brave browser, Special:Version does not wrap value in Version column; overlaps with License column - https://phabricator.wikimedia.org/T231323 (10thiemowmde) I tested it and found that `isolate` does have the same pr... [08:48:37] (03Abandoned) 10Daniel Kinzler: Remove usage of Revision::GetQueryInfo() with 'text' flag [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/504797 (https://phabricator.wikimedia.org/T233358) (owner: 10BPirkle) [08:50:26] (03CR) 10Daniel Kinzler: "@Krinkle I abandoned this because another patch was already merged, see I53e218d8d268060b0b81c5c9bab24b7f5a37917a. IT also contains compat" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/504797 (https://phabricator.wikimedia.org/T233358) (owner: 10BPirkle) [08:50:51] (03PS1) 10Hashar: Speed up ApiQuerySiteinfoTest:testContinuation [core] - 10https://gerrit.wikimedia.org/r/539494 (https://phabricator.wikimedia.org/T234016) [08:53:52] (03PS1) 10Daniel Kinzler: Remove backwards compatible code. [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/539495 [08:58:25] (03PS6) 10Daniel Kinzler: [EXPERIMENTAL] RevisionStore: Introduce getSlotRowsForBatch [core] - 10https://gerrit.wikimedia.org/r/539324 (https://phabricator.wikimedia.org/T228675) [09:08:19] 10PostgreSQL: SiteConfiguration.php - Error "no such wiki" when running runJobs.php - https://phabricator.wikimedia.org/T234022 (10RacingRalf) [09:08:32] (03CR) 10Effie Mouzeli: "I will try to package it on Monday (I am off for the rest of the week), unless this is urgent in which case I will give it priority" [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/539435 (owner: 10Tim Starling) [09:17:30] 10MediaWiki-extensions-GlobalPreferences, 10Advanced Mobile Contributions, 10Community-Tech, 10Readers-Web-Backlog: Add an option in the global preferences to enable Advanced Contributions mode globally - https://phabricator.wikimedia.org/T233802 (10ovasileva) p:05Triage→03Low @Masumrezarock100 - agree... [09:17:53] 10MediaWiki-Page-History: New page history filter looks strange on zh-yue wiki - https://phabricator.wikimedia.org/T234023 (10A2093064) [09:20:09] 04(no projects): Regressive bugs in admin tools - https://phabricator.wikimedia.org/T232980 (10Aklapper) > When I block a user, I am currently getting: '"$1" has been blocked' . Ie. actually $1 not the user name. Cannot reproduce on https://test2.wikipedia.org/wiki/Special:Block/Username : ` Block succeeded U... [09:22:51] 10MediaWiki-Maintenance-scripts, 10PostgreSQL: SiteConfiguration.php - Error "no such wiki" when running runJobs.php - https://phabricator.wikimedia.org/T234022 (10Aklapper) [09:25:12] (03CR) 10Thiemo Kreuz (WMDE): "Generally fine, just one question." (032 comments) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/538261 (https://phabricator.wikimedia.org/T231529) (owner: 10Awight) [09:25:52] 10MediaWiki-Page-History: New page history filter dropdown on zh-yue wiki shows truncated "Expand" string - https://phabricator.wikimedia.org/T234023 (10Aklapper) [09:28:02] 10MediaWiki-Page-History: New page history filter dropdown on zh-yue wiki shows truncated "Expand" label string - https://phabricator.wikimedia.org/T234023 (10Aklapper) [09:30:36] (03PS4) 10Mobrovac: Remove MySQL index aliasing for user_newtalk indexes [core] - 10https://gerrit.wikimedia.org/r/537694 (https://phabricator.wikimedia.org/T233240) (owner: 10Anomie) [09:32:09] 10MediaWiki-Page-History: New page history filter dropdown on zh-yue wiki shows truncated "Expand" label string; "Filter revisions" string on other side - https://phabricator.wikimedia.org/T234023 (10Aklapper) [09:33:59] 10MediaWiki-Page-History, 10Reading-Web-Local-Wiki-Issues: New page history filter dropdown on zh-yue wiki shows truncated "Expand" label string; "Filter revisions" string on other side - https://phabricator.wikimedia.org/T234023 (10Aklapper) 05Open→03Invalid This problem happens due to ` /* Styling for J... [09:34:40] 10MediaWiki-Maintenance-scripts, 10PostgreSQL: SiteConfiguration.php - Error "no such wiki" when running runJobs.php - https://phabricator.wikimedia.org/T234022 (10RacingRalf) Just installed a new wiki to test my assumption: > $wgDBname = "wikidb" > $wgDBmwschema = "wikischema" Error: > No such wiki 'wikidb... [09:35:16] 10MediaWiki-Page-History, 10Reading-Web-Local-Wiki-Issues: New page history filter dropdown on zh-yue wiki shows truncated "Expand" label string; "Filter revisions" string on other side - https://phabricator.wikimedia.org/T234023 (10Schnark) This is caused by local CSS: ` lang=css .mw-collapsible-toggle {... [09:37:12] 10CX-boost, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.23; 2019-09-17): Gray interlanguage link dialog is misplaced - https://phabricator.wikimedia.org/T224880 (10Pginer-WMF) [09:37:30] 10CX-boost, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.23; 2019-09-17): CX puts unnecessary burden on many page views - https://phabricator.wikimedia.org/T230230 (10Pginer-WMF) [09:41:57] 10MediaWiki-Page-History, 10Reading-Web-Local-Wiki-Issues: New page history filter dropdown on zh-yue wiki shows truncated "Expand" label string; "Filter revisions" string on other side - https://phabricator.wikimedia.org/T234023 (10A2093064) Thank you! I have asked the local IA for help. [09:48:07] (03CR) 10Mobrovac: [C: 03+2] Remove usage of deprecated User methods. [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/539416 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [09:51:55] (03PS7) 10Awight: Tracking for Reference Previews interactions [extensions/Popups] - 10https://gerrit.wikimedia.org/r/538641 (https://phabricator.wikimedia.org/T214493) [09:53:59] (03CR) 10Daniel Kinzler: "Finding so far: these tests also fail for me when I run them in isolation on master. Somehow, they only seem to pass when run together wit" [core] - 10https://gerrit.wikimedia.org/r/538977 (https://phabricator.wikimedia.org/T214308) (owner: 10Clarakosi) [09:58:29] (03CR) 10jerkins-bot: [V: 04-1] Tracking for Reference Previews interactions [extensions/Popups] - 10https://gerrit.wikimedia.org/r/538641 (https://phabricator.wikimedia.org/T214493) (owner: 10Awight) [09:59:11] (03CR) 10jerkins-bot: [V: 04-1] Tracking for Reference Previews interactions [extensions/Popups] - 10https://gerrit.wikimedia.org/r/538641 (https://phabricator.wikimedia.org/T214493) (owner: 10Awight) [09:59:44] (03PS18) 10Awight: Baseline reference interaction tracking [extensions/Cite] - 10https://gerrit.wikimedia.org/r/538261 (https://phabricator.wikimedia.org/T231529) [10:03:34] (03CR) 10Daniel Kinzler: "Narrowed it down:" [core] - 10https://gerrit.wikimedia.org/r/538977 (https://phabricator.wikimedia.org/T214308) (owner: 10Clarakosi) [10:06:20] -win 18 [10:06:35] EKEZBOARD [10:07:19] (03PS5) 10Awight: Collect metrics for logged-in users as well as anons [extensions/Popups] - 10https://gerrit.wikimedia.org/r/539140 (https://phabricator.wikimedia.org/T214493) [10:10:53] 10ConfirmEdit (CAPTCHA extension): reCAPTCHA v3 Request - https://phabricator.wikimedia.org/T234025 (10AndreiJirohOnDevsCentral) [10:12:55] 10MediaWiki-Core-Testing, 10Browser-Tests, 10Patch-For-Review: Make MediaWiki Wdio tests less slow (Sept 2019) - https://phabricator.wikimedia.org/T234002 (10hashar) [10:13:36] (03Merged) 10jenkins-bot: Remove usage of deprecated User methods. [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/539416 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [10:16:06] 10MediaWiki-Core-Testing, 10Browser-Tests, 10Patch-For-Review, 10Release-Engineering-Team (Unit & Int & System Tooling): Make MediaWiki Wdio tests less slow (Sept 2019) - https://phabricator.wikimedia.org/T234002 (10zeljkofilipin) [10:16:12] (03CR) 10jenkins-bot: Remove usage of deprecated User methods. [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/539416 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [10:16:45] 10MediaWiki-Core-Testing, 10Browser-Tests, 10Patch-For-Review, 10Release-Engineering-Team (Unit & Int & System Tooling), 10User-zeljkofilipin: Make MediaWiki Wdio tests less slow (Sept 2019) - https://phabricator.wikimedia.org/T234002 (10zeljkofilipin) [10:16:50] 10ConfirmEdit (CAPTCHA extension): reCAPTCHA v3 Request - https://phabricator.wikimedia.org/T234025 (10Aklapper) Hi @AndreiJirohOnDevsCentral, thanks for taking the time to report this and welcome to Wikimedia Phabricator! This has been already requested, so I'm merging this task. See https://www.mediawiki.org/... [10:16:56] 10ConfirmEdit (CAPTCHA extension): reCAPTCHA v3 Request - https://phabricator.wikimedia.org/T234025 (10Aklapper) [10:16:58] 10ConfirmEdit (CAPTCHA extension): Implement support for new Google ReCaptcha v3 - https://phabricator.wikimedia.org/T208829 (10Aklapper) [10:17:10] 10MediaWiki-Core-Testing, 10Browser-Tests, 10Continuous-Integration-Config, 10Patch-For-Review, and 2 others: Make MediaWiki Wdio tests less slow (Sept 2019) - https://phabricator.wikimedia.org/T234002 (10hashar) [10:17:39] (03PS3) 10Zfilipin: [WIP] build: Upgrade from webdriver v4 to v5 [core] - 10https://gerrit.wikimedia.org/r/539441 (https://phabricator.wikimedia.org/T234002) (owner: 10Krinkle) [10:19:09] (03PS8) 10Awight: Tracking for Reference Previews interactions [extensions/Popups] - 10https://gerrit.wikimedia.org/r/538641 (https://phabricator.wikimedia.org/T214493) [10:19:20] (03CR) 10Zfilipin: "PS3 adds related phab task to the commit message." [core] - 10https://gerrit.wikimedia.org/r/539441 (https://phabricator.wikimedia.org/T234002) (owner: 10Krinkle) [10:19:42] (03CR) 10Awight: [C: 03+2] Update version to 1.9.0 [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/539435 (owner: 10Tim Starling) [10:20:59] (03Merged) 10jenkins-bot: Update version to 1.9.0 [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/539435 (owner: 10Tim Starling) [10:21:22] 10Advanced Mobile Contributions, 10Readers-Web-Backlog: Deploy AMC contextual hooks modal - https://phabricator.wikimedia.org/T234026 (10ovasileva) [10:21:35] 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Deploy AMC contextual hooks modal - https://phabricator.wikimedia.org/T234026 (10ovasileva) [10:21:41] 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Deploy AMC contextual hooks modal - https://phabricator.wikimedia.org/T234026 (10ovasileva) p:05Triage→03High [10:21:55] 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Deploy AMC contextual hooks modal - https://phabricator.wikimedia.org/T234026 (10ovasileva) [10:21:59] 10Advanced Mobile Contributions, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): AMC Outreach - contextual hooks via new Drawer (showing AMC optin drawer within workflows) - https://phabricator.wikimedia.org/T226069 (10ovasileva) [10:24:12] (03CR) 10jerkins-bot: [V: 04-1] [WIP] build: Upgrade from webdriver v4 to v5 [core] - 10https://gerrit.wikimedia.org/r/539441 (https://phabricator.wikimedia.org/T234002) (owner: 10Krinkle) [10:24:59] (03CR) 10jerkins-bot: [V: 04-1] Tracking for Reference Previews interactions [extensions/Popups] - 10https://gerrit.wikimedia.org/r/538641 (https://phabricator.wikimedia.org/T214493) (owner: 10Awight) [10:27:34] 04(no projects): Unable to upgrade wiki family of 2 wikis from 1.32.0 to 1.33.0 due to DB structure being different than the upgrade.php expects - https://phabricator.wikimedia.org/T234027 (10Jukeboksi) [10:28:01] (03CR) 10Mobrovac: [C: 03+2] Remove MySQL index aliasing for user_newtalk indexes [core] - 10https://gerrit.wikimedia.org/r/537694 (https://phabricator.wikimedia.org/T233240) (owner: 10Anomie) [10:33:33] 10MediaWiki-Core-Testing, 10Quibble, 10Release-Engineering-Team-TODO, 10Continuous-Integration-Config, 10Performance-Team (Radar): Investigate speed of MediaWiki logging setup under Quibble - https://phabricator.wikimedia.org/T234028 (10hashar) [10:38:19] 10CommRel-Design, 10CommRel-Specialists-Support (Jul-Sep-2019): Library Bundle logo for The Wikipedia Library - https://phabricator.wikimedia.org/T228647 (10Samwalton9) Thanks! I think it can go straight up :) [10:38:59] 10MediaWiki-Core-Testing, 10Quibble, 10Release-Engineering-Team-TODO, 10Continuous-Integration-Config, 10Performance-Team (Radar): Investigate speed of MediaWiki logging setup under Quibble - https://phabricator.wikimedia.org/T234028 (10hashar) [10:40:16] 10Developer-Advocacy (Jul-Sep 2019): Dedicated Google Code-in (GCI) communication channel for students, mentors and admins? - https://phabricator.wikimedia.org/T200782 (10Aklapper) 05Open→03Resolved I think until someone brings up new pro and con arguments that Telegram channel is our status quo. It's a less... [10:40:57] (03CR) 10jerkins-bot: [V: 04-1] [WIP] build: Upgrade from webdriver v4 to v5 [core] - 10https://gerrit.wikimedia.org/r/539441 (https://phabricator.wikimedia.org/T234002) (owner: 10Krinkle) [10:52:37] 10Library-Card-Platform: Sending via batch edit doesn't create authorizations - https://phabricator.wikimedia.org/T234029 (10Samwalton9) [10:54:20] 10Wikidata-Trailblazing-Exploration: Eliminate Wikidata Browser Tests Flakiness - https://phabricator.wikimedia.org/T234012 (10Lucas_Werkmeister_WMDE) [10:56:00] (03Merged) 10jenkins-bot: Remove MySQL index aliasing for user_newtalk indexes [core] - 10https://gerrit.wikimedia.org/r/537694 (https://phabricator.wikimedia.org/T233240) (owner: 10Anomie) [10:57:31] 10Developer-Advocacy (Oct-Dec 2019): Intro to Phab video: Play with local Vagrant instance of Phab and with lipsum to generate tasks - https://phabricator.wikimedia.org/T226061 (10Aklapper) p:05Normal→03Low [10:58:05] (03PS1) 10Bhofmann: Fix fatal on page move when wrong list context given [extensions/BlueSpiceSocialTags] - 10https://gerrit.wikimedia.org/r/539509 [10:58:16] 10MediaWiki-Core-Testing, 10Release-Engineering-Team-TODO, 10Patch-For-Review, 10Release-Engineering-Team (Unit & Int & System Tooling), 10User-zeljkofilipin: Upgrade webdriverio to version 5 - https://phabricator.wikimedia.org/T213268 (10Pablo-WMDE) WMDE action on this topic: * [[ https://gerrit.wikimed... [10:58:59] (03PS2) 10Bhofmann: Fix fatal on page move when wrong list context given [extensions/BlueSpiceSocialTags] - 10https://gerrit.wikimedia.org/r/539509 [10:59:39] 10MediaWiki-Core-Testing, 10Quibble, 10Release-Engineering-Team-TODO, 10Continuous-Integration-Config, 10Performance-Team (Radar): Investigate speed of MediaWiki logging setup under Quibble - https://phabricator.wikimedia.org/T234028 (10hashar) It takes one second to write 100 000 lines: ` lang=php use M... [11:01:49] 10Library-Card-Platform: Some authorizations aren't recording authorizer - https://phabricator.wikimedia.org/T233508 (10Samwalton9) [11:02:10] 10Library-Card-Platform: Some authorizations aren't recording authorizer - https://phabricator.wikimedia.org/T233508 (10Samwalton9) p:05High→03Normal This information isn't actually used anywhere at the moment so I don't think we care too much for now. [11:02:51] (03PS9) 10Awight: Tracking for Reference Previews interactions [extensions/Popups] - 10https://gerrit.wikimedia.org/r/538641 (https://phabricator.wikimedia.org/T214493) [11:08:55] 10Library-Card-Platform-Proxy: Allow users to 'return' their proxy-based access - https://phabricator.wikimedia.org/T169201 (10Samwalton9) [11:09:27] 10Library-Card-Platform-Proxy: Allow users to 'return' their proxy-based access - https://phabricator.wikimedia.org/T169201 (10Samwalton9) [11:13:32] (03CR) 10Pwirth: [C: 03+2] Fix fatal on page move when wrong list context given [extensions/BlueSpiceSocialTags] - 10https://gerrit.wikimedia.org/r/539509 (owner: 10Bhofmann) [11:13:37] (03PS1) 10Pwirth: Fix fatal on page move when wrong list context given [extensions/BlueSpiceSocialTags] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/539510 [11:13:41] (03CR) 10Pwirth: [V: 03+2 C: 03+2] Fix fatal on page move when wrong list context given [extensions/BlueSpiceSocialTags] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/539510 (owner: 10Pwirth) [11:19:39] 10MediaWiki-Core-Testing, 10Quibble, 10Release-Engineering-Team-TODO, 10Continuous-Integration-Config, 10Performance-Team (Radar): Investigate speed of MediaWiki logging setup under Quibble - https://phabricator.wikimedia.org/T234028 (10hashar) p:05Triage→03Low [11:20:49] (03CR) 10jenkins-bot: Remove MySQL index aliasing for user_newtalk indexes [core] - 10https://gerrit.wikimedia.org/r/537694 (https://phabricator.wikimedia.org/T233240) (owner: 10Anomie) [11:25:03] 10MediaWiki-General, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), 10Schema-change, 10User-Marostegui: Remove MySQL aliasing for user_newtalk indexes - https://phabricator.wikimedia.org/T233240 (10mobrovac) 05Open→03Resolved [11:27:50] 10MediaWiki-Core-Testing, 10Performance-Team, 10Wikimedia-Rdbms, 10Core Platform Team Workboards (Purple): PageUpdaterTest fails when run in isolation due to setTempTableOnlyMode() being called with wrong domain. - https://phabricator.wikimedia.org/T234031 (10daniel) [11:28:40] 10Library-Card-Platform: Sending via batch edit doesn't create authorizations - https://phabricator.wikimedia.org/T234029 (10Samwalton9) p:05Triage→03High [11:29:08] (03PS1) 10Daniel Kinzler: MWTestCase: include table prefix in domain for temp table only mode. [core] - 10https://gerrit.wikimedia.org/r/539514 (https://phabricator.wikimedia.org/T234031) [11:30:08] 10Library-Card-Platform: When users delete their data, handle Authorizations properly too - https://phabricator.wikimedia.org/T234033 (10Samwalton9) [11:30:11] 10Library-Card-Platform: When users delete their data, handle Authorizations properly too - https://phabricator.wikimedia.org/T234033 (10Samwalton9) p:05Triage→03High [11:31:27] (03PS10) 10Daniel Kinzler: Force usage of MCR aware database schema [core] - 10https://gerrit.wikimedia.org/r/538977 (https://phabricator.wikimedia.org/T214308) (owner: 10Clarakosi) [11:32:54] (03CR) 10Daniel Kinzler: "Found it. See T234031 for an analysis. I rebased this on top of my fix, should work now." [core] - 10https://gerrit.wikimedia.org/r/538977 (https://phabricator.wikimedia.org/T214308) (owner: 10Clarakosi) [11:33:44] 10Wikimedia Design Style Guide: “This is for everyone” imagery – issues with universality and icon guidelines alignment - https://phabricator.wikimedia.org/T228764 (10schoenbaechler) Hey @Volker_E ! Worked on the visuals based on our [[ https://phabricator.wikimedia.org/T228764#5502361 | last conversation ]]. A... [11:36:02] (03CR) 10Mobrovac: [C: 03+2] API: Use ConvertibleTimestamp::setFakeTime for testing curtimestamp [core] - 10https://gerrit.wikimedia.org/r/539362 (https://phabricator.wikimedia.org/T233752) (owner: 10Anomie) [11:37:38] 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Purple), 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), and 2 others: Remove direct access to the text table from the Translate extension. - https://phabricator.wikimedia.org/T228675 (10d... [11:37:40] 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Purple), 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), 10Multi-Content-Revisions (Tech Debt), 10Patch-For-Review: Create batch access interface for page content - https://phabricator.wikimedia.org/T228988 (10daniel) [11:37:57] 10Multi-Content-Revisions, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03): Create batch access interface for BlobStore - https://phabricator.wikimedia.org/T230834 (10daniel) [11:38:01] 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Purple), 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), and 2 others: Remove direct access to the text table from the Translate extension. - https://phabricator.wikimedia.org/T228675 (10d... [11:40:20] (03CR) 10Hashar: "From the result of mwcore-phpunit-coverage-patch:" [core] - 10https://gerrit.wikimedia.org/r/539494 (https://phabricator.wikimedia.org/T234016) (owner: 10Hashar) [11:40:58] (03Merged) 10jenkins-bot: Fix fatal on page move when wrong list context given [extensions/BlueSpiceSocialTags] - 10https://gerrit.wikimedia.org/r/539509 (owner: 10Bhofmann) [11:43:51] 10Library-Card-Platform: 'Link' authorization method partners aren't recording authorizer when authorizations are created. - https://phabricator.wikimedia.org/T233508 (10Samwalton9) [11:46:01] (03CR) 10Huji: [C: 03+1] "LGTM. However, when I tried installing CheckUser on a test wiki using SQLite *without* this patch, it worked just fine. How could that be?" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/539405 (https://phabricator.wikimedia.org/T233983) (owner: 10Dbarratt) [11:46:02] 10CPT Initiatives (MCR Schema Migration), 10MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), 10Multi-Content-Revisions (Tech Debt): Create low level batch access interface for page content - https://phabricator.wikimedia.org/T234034 (10daniel) [11:48:03] (03PS7) 10Daniel Kinzler: [EXPERIMENTAL] RevisionStore: Introduce getSlotRowsForBatch [core] - 10https://gerrit.wikimedia.org/r/539324 (https://phabricator.wikimedia.org/T228675) [12:01:49] 10MediaWiki-extensions-GlobalPreferences, 10Advanced Mobile Contributions, 10Community-Tech, 10Readers-Web-Backlog: Add an option in the global preferences to enable Advanced Contributions mode globally - https://phabricator.wikimedia.org/T233802 (10Masumrezarock100) Good to know! [12:02:00] (03Merged) 10jenkins-bot: API: Use ConvertibleTimestamp::setFakeTime for testing curtimestamp [core] - 10https://gerrit.wikimedia.org/r/539362 (https://phabricator.wikimedia.org/T233752) (owner: 10Anomie) [12:04:21] 10CX-boost, 10CX-out-of-beta, 10Language-Team (Language-2019-July-September), 10Patch-For-Review: Enable Content Translation in Tagalog Wikipedia as a default tool - https://phabricator.wikimedia.org/T233006 (10KartikMistry) a:03KartikMistry [12:04:53] 10CX-boost, 10CX-out-of-beta, 10Language-Team (Language-2019-July-September), 10Patch-For-Review: Enable Content Translation in Central Bikol Wikipedia as a default tool - https://phabricator.wikimedia.org/T233007 (10KartikMistry) a:03KartikMistry [12:05:18] 10CX-boost, 10CX-out-of-beta, 10Language-Team (Language-2019-July-September), 10Patch-For-Review: Enable Content Translation in Tagalog Wikipedia as a default tool - https://phabricator.wikimedia.org/T233006 (10KartikMistry) [12:05:44] 10CX-deployments, 10Language-Team (Language-2019-July-September): Recreate Language team's test instances - https://phabricator.wikimedia.org/T233297 (10KartikMistry) [12:12:32] 10MediaWiki-API, 10Core Platform Team Workboards (Clinic Duty Team), 10Wikimedia-production-error (Shared Build Failure): Flaky test: ApiMainTest::testAddRequestedFieldsCurTimestamp - https://phabricator.wikimedia.org/T233752 (10mobrovac) 05Open→03Resolved a:03Anomie [12:14:57] 10WMSE-Riksarkivet-NAD: Connect LOD Tora church parishes and administrative parishes with Wikidata - https://phabricator.wikimedia.org/T233275 (10Salgo60) [12:21:35] 10MediaWiki-Page-History, 10Wikidata, 10User-DannyS712: Collapsed history issue on wikidata - https://phabricator.wikimedia.org/T234005 (10Ammarpad) [12:27:38] (03CR) 10jenkins-bot: API: Use ConvertibleTimestamp::setFakeTime for testing curtimestamp [core] - 10https://gerrit.wikimedia.org/r/539362 (https://phabricator.wikimedia.org/T233752) (owner: 10Anomie) [12:30:45] (03Restored) 10Zfilipin: WIP Write documentation on Selenium tests in Node.js [core] - 10https://gerrit.wikimedia.org/r/345378 (https://phabricator.wikimedia.org/T161103) (owner: 10Zfilipin) [12:30:56] (03PS2) 10Zfilipin: WIP Write documentation on Selenium tests in Node.js [core] - 10https://gerrit.wikimedia.org/r/345378 (https://phabricator.wikimedia.org/T161103) [12:32:23] 10GrowthExperiments, 10CommRel-Specialists-Support (Jul-Sep-2019), 10Growth-Team (Current Sprint): Growth: training for how to help newcomers - https://phabricator.wikimedia.org/T224633 (10JTannerWMF) [12:33:51] 10MediaWiki-Page-History, 10Wikidata, 10User-DannyS712: Collapsed history issue on wikidata - https://phabricator.wikimedia.org/T234005 (10Ammarpad) 05Open→03Invalid This is also caused by the styling in [[https://www.wikidata.org/wiki/MediaWiki:Common.css|local MediaWiki:Common.css]], same as T234023 [12:39:00] (03CR) 10Jdrewniak: [C: 04-1] Vertically align the page issues icon with the text (032 comments) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/538710 (https://phabricator.wikimedia.org/T232837) (owner: 10Jdlrobson) [12:40:44] 10MediaWiki-Page-deletion: Cannot delete pages in 1.32.0: Fatal error: Uncaught RuntimeException: Transaction callbacks are still pending - https://phabricator.wikimedia.org/T231290 (10Aklapper) 05Stalled→03Open [12:42:45] 10MediaWiki-Page-deletion: Cannot delete pages in 1.32.0: Fatal error: Uncaught RuntimeException: Transaction callbacks are still pending - https://phabricator.wikimedia.org/T231290 (10Aklapper) 05Open→03Stalled Please always make sure to run a supported software version, for your own safety. 1.32.0 is an ou... [12:43:12] (03PS29) 10Pwirth: [WIP] Snapshot factory, entities, triggerhandler and api. ERM:14344 [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/525092 [12:44:29] (03PS3) 10Zfilipin: WIP Example code for Selenium/Node.js/Core page [core] - 10https://gerrit.wikimedia.org/r/345378 (https://phabricator.wikimedia.org/T232598) [12:46:39] 10MediaWiki-Page-editing, 10MediaWiki-Patrolling: Click on red link opens VisualEditor instead of default WikiEditor - https://phabricator.wikimedia.org/T231364 (10Aklapper) 05Open→03Invalid "Visual editing" is enabled, hence I don't think there is a bug here [12:49:00] 10MediaWiki-Cache, 10MediaWiki-File-management, 10Commons, 10Multimedia, 10media-storage: Caching issues when moving files - https://phabricator.wikimedia.org/T226473 (10Aklapper) 05Open→03Declined Unfortunately closing this report as no further information has been provided and as T226473#5282106 mi... [12:54:49] 10Phabricator: Some users can't add the fr-tech private task form to their task selection menu. - https://phabricator.wikimedia.org/T229628 (10DStrine) 05Declined→03Open [12:56:42] (03PS8) 10Daniel Kinzler: RevisionStore: Introduce getSlotRowsForBatch [core] - 10https://gerrit.wikimedia.org/r/539324 (https://phabricator.wikimedia.org/T228675) [12:56:49] 10Phabricator: Some users can't add the fr-tech private task form to their task selection menu. - https://phabricator.wikimedia.org/T229628 (10DStrine) >>! In T229628#5461717, @mmodell wrote: > My suggestion, if searching for `wmf-fr` or `-fr` still doesn't work, then try this: > > 1. Go to [[ /favorites/menu/c... [12:58:00] (03PS9) 10Daniel Kinzler: RevisionStore: Introduce getContentBlobsForBatch [core] - 10https://gerrit.wikimedia.org/r/539324 (https://phabricator.wikimedia.org/T228675) [13:05:51] 10MediaWiki-Uploading, 10Multimedia, 10Thumbor, 10media-storage: Thumbnails missing for uploaded file on shnwiki, says "Unauthorized" error - https://phabricator.wikimedia.org/T216325 (10fgiunchedi) 05Open→03Resolved a:03fgiunchedi Thumbnails work for me on that wiki now, resolving [13:08:54] 10MediaWiki-Page-Diffs, 10Growth-Team, 10Notifications: Undefined property: Diff::$edits in includes/diff/DiffFormatter.php - https://phabricator.wikimedia.org/T234040 (10Tgr) [13:09:36] 10MediaWiki-Page-History, 10Reading-Web-Local-Wiki-Issues: New page history filter dropdown on zh-yue wiki shows truncated "Expand" label string; "Filter revisions" string on other side - https://phabricator.wikimedia.org/T234023 (10shinjiman) 05Invalid→03Resolved Updated the CSS style sheets and seen as r... [13:10:16] 10MediaWiki-Page-History, 10Reading-Web-Local-Wiki-Issues: New page history filter dropdown on zh-yue wiki shows truncated "Expand" label string; "Filter revisions" string on other side - https://phabricator.wikimedia.org/T234023 (10shinjiman) 05Resolved→03Invalid [13:17:18] (03CR) 10Anomie: [C: 03+2] "Interesting that the code coverage thing is so badly affected by the test." [core] - 10https://gerrit.wikimedia.org/r/539494 (https://phabricator.wikimedia.org/T234016) (owner: 10Hashar) [13:18:00] 10MediaWiki-API, 10MediaWiki-Core-Testing, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review, 10Test-Coverage: Coverage of ApiQuerySiteinfoTest:testContinuation takes 50+ seconds - https://phabricator.wikimedia.org/T234016 (10Anomie) [13:18:02] 10MediaWiki-Maintenance-scripts, 10Core Platform Team Workboards (Clinic Duty Team): Unable to upgrade wiki family of 2 wikis from 1.32.0 to 1.33.0 due to DB structure being different than the upgrade.php expects - https://phabricator.wikimedia.org/T234027 (10daniel) pinging @anomie to have a look [13:19:43] (03CR) 10jerkins-bot: [V: 04-1] RevisionStore: Introduce getContentBlobsForBatch [core] - 10https://gerrit.wikimedia.org/r/539324 (https://phabricator.wikimedia.org/T228675) (owner: 10Daniel Kinzler) [13:20:24] (03CR) 10Umherirrender: "Just a year to land ;-)" [core] - 10https://gerrit.wikimedia.org/r/462122 (owner: 10Umherirrender) [13:20:27] 10MediaWiki-Logging, 10Regression: Protect log entries offer link to change protection only to unprivileged users - https://phabricator.wikimedia.org/T234017 (10Ammarpad) p:05Triage→03Normal a:03Ammarpad [13:22:15] (03CR) 10jerkins-bot: [V: 04-1] RevisionStore: Introduce getContentBlobsForBatch [core] - 10https://gerrit.wikimedia.org/r/539324 (https://phabricator.wikimedia.org/T228675) (owner: 10Daniel Kinzler) [13:23:39] 10MediaWiki-API, 10MediaWiki-Core-Testing, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review, 10Test-Coverage: Coverage of ApiQuerySiteinfoTest:testContinuation takes 50+ seconds - https://phabricator.wikimedia.org/T234016 (10hashar) p:05Triage→03Normal [13:30:36] 10MediaWiki-Page-Diffs, 10Parsoid: Undefined property: Diff::$edits in includes/diff/DiffFormatter.php - https://phabricator.wikimedia.org/T234040 (10Tgr) Ok, apparently this is a namespace conflict: MediaWiki and phpspec (used by Parsoid) both have an un-namespaced `Diff` class, and the phpspec one is loaded... [13:37:40] 10MediaWiki-Page-Diffs, 10Parsoid: Undefined property: Diff::$edits in includes/diff/DiffFormatter.php - https://phabricator.wikimedia.org/T234040 (10Tgr) Upstream report: [[https://github.com/phpspec/phpspec/issues/1262|phpspec/phpspec#1262]] [13:40:53] 10MediaWiki-Page-Diffs, 10Parsoid: Undefined property: Diff::$edits in includes/diff/DiffFormatter.php - https://phabricator.wikimedia.org/T234040 (10Tgr) On Vagrant, this breaks the GrowthExperiments question poster functionality (probably among other things) because the question poster triggers the Echo noti... [13:41:48] (03Abandoned) 10Zfilipin: WIP Example code for Selenium/Node.js/Core page [core] - 10https://gerrit.wikimedia.org/r/345378 (https://phabricator.wikimedia.org/T232598) (owner: 10Zfilipin) [13:42:25] (03Merged) 10jenkins-bot: Speed up ApiQuerySiteinfoTest:testContinuation [core] - 10https://gerrit.wikimedia.org/r/539494 (https://phabricator.wikimedia.org/T234016) (owner: 10Hashar) [13:47:42] (03PS1) 10Ammarpad: Fix permission check on protection log [core] - 10https://gerrit.wikimedia.org/r/539536 (https://phabricator.wikimedia.org/T234017) [13:48:21] (03CR) 10Daimona Eaytoy: [C: 03+2] "According to [1], the compatibility policy is "release branches", so OK." [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/539495 (owner: 10Daniel Kinzler) [13:49:03] (03PS2) 10MGerlach: get alpahabetical order correct adding mgerlach to team members [research/landing-page] - 10https://gerrit.wikimedia.org/r/539149 [13:49:53] 10MediaWiki-API, 10MediaWiki-Core-Testing, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review, 10Test-Coverage: Coverage of ApiQuerySiteinfoTest:testContinuation takes 50+ seconds - https://phabricator.wikimedia.org/T234016 (10Anomie) 05Open→03Resolved a:03hashar [13:55:42] (03CR) 10Anomie: Remove Revision::getRevisionText and gated pre-MCR schema access (031 comment) [core] - 10https://gerrit.wikimedia.org/r/538314 (https://phabricator.wikimedia.org/T198343) (owner: 10Ppchelko) [13:55:59] (03PS1) 10ItSpiderman: [WIP] Update for 3.1 [extensions/WebDAV] - 10https://gerrit.wikimedia.org/r/539538 [13:56:28] (03PS10) 10Daniel Kinzler: RevisionStore: Introduce getContentBlobsForBatch [core] - 10https://gerrit.wikimedia.org/r/539324 (https://phabricator.wikimedia.org/T228675) [13:56:36] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Update for 3.1 [extensions/WebDAV] - 10https://gerrit.wikimedia.org/r/539538 (owner: 10ItSpiderman) [13:59:46] 10ISA: Add participant/country tables to campaign page on mobile - https://phabricator.wikimedia.org/T232839 (10Seantime) a:03Seantime [14:02:20] (03CR) 10Isaac Johnson: [V: 03+2 C: 03+2] "Looks great -- thanks for making changes!" [research/landing-page] - 10https://gerrit.wikimedia.org/r/539149 (owner: 10MGerlach) [14:02:28] (03CR) 10Anomie: Remove Revision::getRevisionText and gated pre-MCR schema access (031 comment) [core] - 10https://gerrit.wikimedia.org/r/538314 (https://phabricator.wikimedia.org/T198343) (owner: 10Ppchelko) [14:03:38] (03PS2) 10Ammarpad: Fix permission check on protection log [core] - 10https://gerrit.wikimedia.org/r/539536 (https://phabricator.wikimedia.org/T234017) [14:06:07] 10MediaWiki-API, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), 10Wikimedia-production-error (Shared Build Failure): Flaky test: ApiMainTest::testAddRequestedFieldsCurTimestamp - https://phabricator.wikimedia.org/T233752 (10Anomie) >>! In T233752#5528530, @... [14:07:32] (03CR) 10jenkins-bot: Speed up ApiQuerySiteinfoTest:testContinuation [core] - 10https://gerrit.wikimedia.org/r/539494 (https://phabricator.wikimedia.org/T234016) (owner: 10Hashar) [14:08:15] 10MediaWiki-General, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), 10Schema-change, 10User-Marostegui: Remove MySQL aliasing for user_newtalk indexes - https://phabricator.wikimedia.org/T233240 (10Anomie) @Marostegui: The patch for this rename is merged... [14:08:55] 10DC-Ops, 10decommission: decommission elastic1017 - https://phabricator.wikimedia.org/T234045 (10MoritzMuehlenhoff) [14:11:50] (03Merged) 10jenkins-bot: Remove backwards compatible code. [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/539495 (owner: 10Daniel Kinzler) [14:14:04] (03CR) 10jenkins-bot: Remove backwards compatible code. [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/539495 (owner: 10Daniel Kinzler) [14:16:26] 10MediaWiki-Page-Diffs, 10Parsoid: Undefined property: Diff::$edits in includes/diff/DiffFormatter.php - https://phabricator.wikimedia.org/T234040 (10ssastry) We should get rid of phpspec since that was a short-lived experiment and looks like we've only used phpunit since. Do you want to port over those two te... [14:16:50] 10MediaWiki-Page-Diffs, 10Parsoid-PHP: Undefined property: Diff::$edits in includes/diff/DiffFormatter.php - https://phabricator.wikimedia.org/T234040 (10ssastry) [14:19:19] (03CR) 10Krinkle: [C: 03+2] MWTestCase: include table prefix in domain for temp table only mode. [core] - 10https://gerrit.wikimedia.org/r/539514 (https://phabricator.wikimedia.org/T234031) (owner: 10Daniel Kinzler) [14:24:30] 10OWC2020: Create metric definitions - https://phabricator.wikimedia.org/T234046 (10ppelberg) [14:24:59] (03CR) 10jerkins-bot: [V: 04-1] Fix permission check on protection log [core] - 10https://gerrit.wikimedia.org/r/539536 (https://phabricator.wikimedia.org/T234017) (owner: 10Ammarpad) [14:25:02] 10OWC2020: Calculate baselines for project key results - https://phabricator.wikimedia.org/T233888 (10ppelberg) [14:25:21] 10OWC2020: Calculate baselines for project key results - https://phabricator.wikimedia.org/T233888 (10ppelberg) Updating task description to indicate where metric definitions are being written: T234046 [14:26:07] 10OWC2020: Create metric definitions - https://phabricator.wikimedia.org/T234046 (10ppelberg) [14:26:08] 10OWC2020: Calculate baselines for project key results - https://phabricator.wikimedia.org/T233888 (10ppelberg) [14:27:32] (03CR) 10jerkins-bot: [V: 04-1] Fix permission check on protection log [core] - 10https://gerrit.wikimedia.org/r/539536 (https://phabricator.wikimedia.org/T234017) (owner: 10Ammarpad) [14:28:43] (03CR) 10Anomie: Add optional serialization_type and hmac_key param values to RESTBagOStuff (032 comments) [core] - 10https://gerrit.wikimedia.org/r/539382 (https://phabricator.wikimedia.org/T233963) (owner: 10BPirkle) [14:31:51] 10Phabricator: Some users can't add the fr-tech private task form to their task selection menu. - https://phabricator.wikimedia.org/T229628 (10Aklapper) 05Open→03Stalled @DStrine: Can you please follow T229628#5464270 and provide web browser developer tools output? [14:38:35] (03PS2) 10Daimona Eaytoy: Return a DNULL in VariableHolder::getVar with GET_STRICT [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/538598 (https://phabricator.wikimedia.org/T230256) [14:44:18] 10MediaWiki-Maintenance-scripts, 10Core Platform Team Workboards (Clinic Duty Team): Unable to upgrade wiki family of 2 wikis from 1.32.0 to 1.33.0 due to DB structure being different than the upgrade.php expects - https://phabricator.wikimedia.org/T234027 (10Anomie) > It is quite possible that I unwittingly b... [14:44:35] (03PS3) 10Ammarpad: Fix permission check on protection log [core] - 10https://gerrit.wikimedia.org/r/539536 (https://phabricator.wikimedia.org/T234017) [14:44:59] 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Purple), 10MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), 10Multi-Content-Revisions (Tech Debt), 10Patch-For-Review: Create low level batch access interface for page content - https://phabricator.wikimedia.org/T234034 (10daniel) [14:47:03] (03CR) 10Ppchelko: [C: 04-1] "Oh, sorry about that. Some comments inlined." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/539536 (https://phabricator.wikimedia.org/T234017) (owner: 10Ammarpad) [14:47:08] (03CR) 10Daniel Kinzler: Fix permission check on protection log (031 comment) [core] - 10https://gerrit.wikimedia.org/r/539536 (https://phabricator.wikimedia.org/T234017) (owner: 10Ammarpad) [14:47:14] (03Merged) 10jenkins-bot: MWTestCase: include table prefix in domain for temp table only mode. [core] - 10https://gerrit.wikimedia.org/r/539514 (https://phabricator.wikimedia.org/T234031) (owner: 10Daniel Kinzler) [14:48:26] (03PS1) 10Alex Paskulin: docs: Fix typo on Doxygen main page [core] - 10https://gerrit.wikimedia.org/r/539543 [14:49:28] (03CR) 10Anomie: [C: 03+2] "Bad me for forgetting to finish reviewing this. Let's get it done, seems to work in some cursory testing." [core] - 10https://gerrit.wikimedia.org/r/530374 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [14:50:42] 10AbuseFilter, 10MW-1.34-release: Hard-deprecate use of disabled variables - https://phabricator.wikimedia.org/T234048 (10Daimona) [14:51:00] 10AbuseFilter, 10MW-1.34-release: Hard-deprecate use of disabled variables - https://phabricator.wikimedia.org/T234048 (10Daimona) a:03Daimona [14:51:55] (03CR) 10Ppchelko: [C: 04-1] Fix permission check on protection log (031 comment) [core] - 10https://gerrit.wikimedia.org/r/539536 (https://phabricator.wikimedia.org/T234017) (owner: 10Ammarpad) [14:56:04] (03PS1) 10Daimona Eaytoy: Hard-deprecate requesting disabled variables [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539545 (https://phabricator.wikimedia.org/T234048) [14:57:03] 04(no projects): Visual Editor Installation - https://phabricator.wikimedia.org/T234049 (10Okcken73) [14:58:29] (03CR) 10Daniel Kinzler: [C: 03+2] Force usage of MCR aware database schema [core] - 10https://gerrit.wikimedia.org/r/538977 (https://phabricator.wikimedia.org/T214308) (owner: 10Clarakosi) [14:58:52] 10MinervaNeue, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), 10Wikimedia-production-error: Feature MinervaTalkAtTop is not defined during logout - https://phabricator.wikimedia.org/T233982 (10Jdlrobson) [15:04:11] 10MediaWiki-Page-editing, 10MW-1.34-release, 10Technical-Debt (Deprecation): Remove $wgTitle fallback from EditPage in MW1.34 - https://phabricator.wikimedia.org/T176526 (10Daimona) Apparently, the main source of warnings is [[https://gerrit.wikimedia.org/g/mediawiki/extensions/CodeEditor/+/d00963af561d864ab... [15:05:45] 10MediaWiki-Page-deletion, 10MediaWiki-Special-pages, 10Community-consensus-needed, 10User-DannyS712: Allow editing of own comments in deletion log - https://phabricator.wikimedia.org/T218872 (10Ammarpad) There should be a clear community consensus first before even moving ahead with this task and many sim... [15:06:04] (03CR) 10jerkins-bot: [V: 04-1] Fix permission check on protection log [core] - 10https://gerrit.wikimedia.org/r/539536 (https://phabricator.wikimedia.org/T234017) (owner: 10Ammarpad) [15:08:41] (03CR) 10jerkins-bot: [V: 04-1] Fix permission check on protection log [core] - 10https://gerrit.wikimedia.org/r/539536 (https://phabricator.wikimedia.org/T234017) (owner: 10Ammarpad) [15:11:59] 10Wikimedia-Site-requests: Patroller right changes to ro.wp - https://phabricator.wikimedia.org/T234051 (10Strainu) [15:12:46] (03CR) 10jenkins-bot: MWTestCase: include table prefix in domain for temp table only mode. [core] - 10https://gerrit.wikimedia.org/r/539514 (https://phabricator.wikimedia.org/T234031) (owner: 10Daniel Kinzler) [15:14:03] (03PS1) 10DCausse: WIP: add missing words fetch subpase [search/extra] - 10https://gerrit.wikimedia.org/r/539549 [15:14:59] (03CR) 10jerkins-bot: [V: 04-1] WIP: add missing words fetch subpase [search/extra] - 10https://gerrit.wikimedia.org/r/539549 (owner: 10DCausse) [15:15:01] (03CR) 10Daimona Eaytoy: "> Ping me if @Huji or someone doesn't merge soon enough." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/537361 (https://phabricator.wikimedia.org/T220791) (owner: 10Daimona Eaytoy) [15:16:03] 10phan: Create a phan plugin to handle the Assert library - https://phabricator.wikimedia.org/T226266 (10Umherirrender) I am not sure if `@phan-assert` on the lib code would be read by phan https://github.com/phan/phan/wiki/Annotating-Your-Source-Code#assertions * Assert::precondition @phan-assert-true-conditi... [15:17:21] 10MediaWiki-Page-deletion, 10MediaWiki-Special-pages, 10Community-consensus-needed, 10User-DannyS712: Allow editing of own comments in deletion log - https://phabricator.wikimedia.org/T218872 (10Scott) >>! In T218872#5528015, @DannyS712 wrote: > To clarify, are you asking to > > # Create a new (null) entr... [15:17:32] (03CR) 10Anomie: [C: 03+2] Add new schemas for splitting afl_filter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/537361 (https://phabricator.wikimedia.org/T220791) (owner: 10Daimona Eaytoy) [15:17:50] (03PS1) 10Yaron Koren: More error checking for cargoRecreateData.php [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/539552 [15:18:15] (03Merged) 10jenkins-bot: Split down patch-comment-table.sql [core] - 10https://gerrit.wikimedia.org/r/530374 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [15:18:22] (03PS4) 10Ammarpad: Fix permission check on protection log [core] - 10https://gerrit.wikimedia.org/r/539536 (https://phabricator.wikimedia.org/T234017) [15:18:44] (03PS2) 10Yaron Koren: More error checking for cargoRecreateData.php [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/539552 [15:19:59] (03CR) 10Ppchelko: [C: 03+1] "It would be cool to have a test for that. I'll try making one." [core] - 10https://gerrit.wikimedia.org/r/539536 (https://phabricator.wikimedia.org/T234017) (owner: 10Ammarpad) [15:21:27] (03CR) 10jerkins-bot: [V: 04-1] Force usage of MCR aware database schema [core] - 10https://gerrit.wikimedia.org/r/538977 (https://phabricator.wikimedia.org/T214308) (owner: 10Clarakosi) [15:21:44] (03CR) 10Ammarpad: "> It would be cool to have a test for that. I'll try making one." [core] - 10https://gerrit.wikimedia.org/r/539536 (https://phabricator.wikimedia.org/T234017) (owner: 10Ammarpad) [15:22:29] (03CR) 10Yaron Koren: [C: 03+2] More error checking for cargoRecreateData.php [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/539552 (owner: 10Yaron Koren) [15:22:49] (03CR) 10Ammarpad: Fix permission check on protection log (031 comment) [core] - 10https://gerrit.wikimedia.org/r/539536 (https://phabricator.wikimedia.org/T234017) (owner: 10Ammarpad) [15:25:51] 10phan: Create a phan plugin to handle the Assert library - https://phabricator.wikimedia.org/T226266 (10Daimona) >>! In T226266#5529819, @Umherirrender wrote: > I am not sure if `@phan-assert` on the lib code would be read by phan Interesting idea! I tested your examples, and they work! > * Assert::precondit... [15:27:16] (03PS1) 10Daimona Eaytoy: Use @phan-assert annotations [libs/Assert] - 10https://gerrit.wikimedia.org/r/539557 (https://phabricator.wikimedia.org/T226266) [15:28:04] (03PS5) 10BPirkle: Add optional serialization_type and hmac_key param values to RESTBagOStuff [core] - 10https://gerrit.wikimedia.org/r/539382 (https://phabricator.wikimedia.org/T233963) [15:28:07] 10Office-IT: Google group for #Wikimedia-Site-requests - https://phabricator.wikimedia.org/T232946 (10JGulingan) Hi everyone, You can create a google group with external people as members. The owner will have to edit the permission settings to public. Best, Jo [15:28:12] (03PS2) 10Daimona Eaytoy: Use @phan-assert annotations [libs/Assert] - 10https://gerrit.wikimedia.org/r/539557 (https://phabricator.wikimedia.org/T226266) [15:29:06] (03CR) 10jerkins-bot: [V: 04-1] Use @phan-assert annotations [libs/Assert] - 10https://gerrit.wikimedia.org/r/539557 (https://phabricator.wikimedia.org/T226266) (owner: 10Daimona Eaytoy) [15:29:54] (03PS12) 10Fomafix: resourceloader: Add $context to static functions in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/535266 (https://phabricator.wikimedia.org/T229311) [15:30:05] 10Office-IT: Google group for #Wikimedia-Site-requests - https://phabricator.wikimedia.org/T232946 (10Urbanecm) Well, how? Note there's @wikimedia.org google group requested. [15:32:04] 10MediaWiki-Page-deletion, 10MediaWiki-Special-pages, 10Core Platform Team, 10Community-consensus-needed, 10User-DannyS712: Allow editing of own comments in deletion log - https://phabricator.wikimedia.org/T218872 (10DannyS712) Tagging #core_platform_team as a feature request to review. As for community... [15:33:43] (03CR) 10BPirkle: Add optional serialization_type and hmac_key param values to RESTBagOStuff (032 comments) [core] - 10https://gerrit.wikimedia.org/r/539382 (https://phabricator.wikimedia.org/T233963) (owner: 10BPirkle) [15:36:29] (03CR) 10Ppchelko: "> Patch Set 5:" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/538314 (https://phabricator.wikimedia.org/T198343) (owner: 10Ppchelko) [15:37:01] (03PS6) 10Ppchelko: Remove Revision::getRevisionText and gated pre-MCR schema access [core] - 10https://gerrit.wikimedia.org/r/538314 (https://phabricator.wikimedia.org/T198343) [15:37:53] (03CR) 10Nray: [C: 04-1] "> FWIW, I'm not sure if this is any better or desirable and its" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/539213 (https://phabricator.wikimedia.org/T232690) (owner: 10Jdlrobson) [15:38:00] 10Wikimedia-Site-requests, 10Patch-For-Review: Patroller right changes to ro.wp - https://phabricator.wikimedia.org/T234051 (10DannyS712) Umm, is this okay from a legal perspective? Allowing patrollers to undelete page revisions would require them to undergo community scrutiny, per WMF's stance on granting acc... [15:38:02] 10Office-IT: Google group for #Wikimedia-Site-requests - https://phabricator.wikimedia.org/T232946 (10JGulingan) I can create the google group, what should the name be? We also need to have someone from the Foundation as the owner of the group and point person. [15:40:22] 10Patch-For-Review, 10phan: Create a phan plugin to handle the Assert library - https://phabricator.wikimedia.org/T226266 (10Umherirrender) The wiki page says > This can be used in combination with Phan's template support. [15:41:14] (03Merged) 10jenkins-bot: Add new schemas for splitting afl_filter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/537361 (https://phabricator.wikimedia.org/T220791) (owner: 10Daimona Eaytoy) [15:41:17] (03Merged) 10jenkins-bot: More error checking for cargoRecreateData.php [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/539552 (owner: 10Yaron Koren) [15:42:29] 10AbuseFilter, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review, 10Schema-change: afl_filter should be split in afl_filter_id and afl_global - https://phabricator.wikimedia.org/T220791 (10Daimona) [15:42:44] (03CR) 10jenkins-bot: More error checking for cargoRecreateData.php [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/539552 (owner: 10Yaron Koren) [15:43:33] (03PS1) 10Sophivorus: Full support for citation template aliases [wikipedia/gadgets/ProveIt] - 10https://gerrit.wikimedia.org/r/539558 [15:44:08] (03CR) 10jenkins-bot: Split down patch-comment-table.sql [core] - 10https://gerrit.wikimedia.org/r/530374 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [15:44:28] (03CR) 10Sophivorus: [V: 03+2 C: 03+2] Full support for citation template aliases [wikipedia/gadgets/ProveIt] - 10https://gerrit.wikimedia.org/r/539558 (owner: 10Sophivorus) [15:46:29] (03CR) 10Ppchelko: [C: 03+1] RevisionStore: Introduce getContentBlobsForBatch [core] - 10https://gerrit.wikimedia.org/r/539324 (https://phabricator.wikimedia.org/T228675) (owner: 10Daniel Kinzler) [15:46:56] (03CR) 10Daimona Eaytoy: "> Main test build failed." [libs/Assert] - 10https://gerrit.wikimedia.org/r/539557 (https://phabricator.wikimedia.org/T226266) (owner: 10Daimona Eaytoy) [15:47:34] (03PS1) 10Jon Harald Søby: Add default Proofreadpage_index_template message [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/539560 (https://phabricator.wikimedia.org/T60062) [15:47:36] (03PS3) 10Daimona Eaytoy: Hard-deprecate too many params [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/537116 (https://phabricator.wikimedia.org/T230803) [15:47:38] (03PS3) 10Daimona Eaytoy: Hard-deprecate empty operands [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/537074 (https://phabricator.wikimedia.org/T156096) [15:48:45] (03PS6) 10Daimona Eaytoy: Also parse numbers with the new syntax and hard-deprecate the old one [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/534903 (https://phabricator.wikimedia.org/T212730) [15:48:48] (03PS7) 10Daimona Eaytoy: Also parse numbers with the new syntax and hard-deprecate the old one [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/534903 (https://phabricator.wikimedia.org/T212730) [15:51:09] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Add $context to static functions in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/535266 (https://phabricator.wikimedia.org/T229311) (owner: 10Fomafix) [15:52:39] (03CR) 10jerkins-bot: [V: 04-1] Add default Proofreadpage_index_template message [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/539560 (https://phabricator.wikimedia.org/T60062) (owner: 10Jon Harald Søby) [15:53:00] 10AbuseFilter, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10MW-1.34-release, 10Patch-For-Review: The parser should keep a list of variadic functions, and strictly check the amount of parameters for the other functions - https://phabricator.wikimedia.org/T230803 (10Daimona) [15:53:07] (03CR) 10jenkins-bot: Add new schemas for splitting afl_filter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/537361 (https://phabricator.wikimedia.org/T220791) (owner: 10Daimona Eaytoy) [15:53:55] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Add $context to static functions in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/535266 (https://phabricator.wikimedia.org/T229311) (owner: 10Fomafix) [15:53:57] (03PS4) 10Daimona Eaytoy: Hard-deprecate too many params [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/537116 (https://phabricator.wikimedia.org/T230803) [15:54:20] 10MediaWiki-Codesniffer, 10Patch-For-Review: Position of boolean operators inside an if condition - https://phabricator.wikimedia.org/T116561 (10Umherirrender) The new PSR12.ControlStructures.BooleanOperatorPlacement from release 3.5.0 sounds a bit like this https://github.com/squizlabs/PHP_CodeSniffer/releas... [15:54:40] (03PS8) 10Daimona Eaytoy: Also parse numbers with the new syntax and hard-deprecate the old one [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/534903 (https://phabricator.wikimedia.org/T212730) [15:55:50] 10OABot: Support access level parameters - https://phabricator.wikimedia.org/T228632 (10Nemo_bis) Example [addition of doi-access=free](https://en.wikipedia.org/w/index.php?title=Activated_carbon&diff=prev&oldid=918219422) after deploying 724ccb4e30a037c01ddeec6d4e6ffa0612a02edd [15:59:47] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Add $context to static functions in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/535266 (https://phabricator.wikimedia.org/T229311) (owner: 10Fomafix) [16:04:11] (03PS13) 10Fomafix: resourceloader: Add $context to static functions in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/535266 (https://phabricator.wikimedia.org/T229311) [16:12:29] (03PS1) 10Reedy: Split down patch-comment-table.sql [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/539566 (https://phabricator.wikimedia.org/T227662) [16:13:47] 10MediaWiki-Page-Diffs, 10Parsoid-PHP: Undefined property: Diff::$edits in includes/diff/DiffFormatter.php - https://phabricator.wikimedia.org/T234040 (10ssastry) p:05Triage→03Normal [16:15:55] 10AbuseFilter, 10Core Platform Team, 10MW-1.34-release: Review new AbuseFilter hard deprecations ahead of 1.34 release - https://phabricator.wikimedia.org/T234058 (10Daimona) [16:17:20] (03PS1) 10Reedy: Split down patch-comment-table.sql [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/539568 (https://phabricator.wikimedia.org/T227662) [16:18:30] (03PS1) 10Reedy: Split down patch-comment-table.sql [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/539569 (https://phabricator.wikimedia.org/T227662) [16:19:14] (03CR) 10jerkins-bot: [V: 04-1] Split down patch-comment-table.sql [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/539568 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [16:19:25] (03Abandoned) 10Krinkle: Revert "Add settings to use a particular layout even at higher resolutions" [skins/Timeless] (wmf/1.34.0-wmf.22) - 10https://gerrit.wikimedia.org/r/535630 (owner: 10Krinkle) [16:20:25] (03CR) 10jerkins-bot: [V: 04-1] Split down patch-comment-table.sql [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/539569 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [16:20:55] (03CR) 10jerkins-bot: [V: 04-1] Split down patch-comment-table.sql [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/539566 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [16:22:06] (03PS1) 10Daimona Eaytoy: [DNM] Jenkins test [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539570 [16:22:24] (03PS2) 10Daimona Eaytoy: [DNM] Jenkins test [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539570 [16:22:35] (03PS1) 10Reedy: Fix double dot in filename [core] - 10https://gerrit.wikimedia.org/r/539571 [16:22:55] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Growth-Team (Current Sprint): Newcomer tasks: suggested edits module - https://phabricator.wikimedia.org/T232423 (10kostajh) > No protected articles should be shown, at any level of protection. We can get this article via the API when using search as a g... [16:22:56] (03CR) 10Reedy: "I'm amused this passed CI on master, but not on release branches" [core] - 10https://gerrit.wikimedia.org/r/530374 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [16:23:17] (03CR) 10Reedy: [C: 03+2] "Trivial self merge followup to fix stupid filename error" [core] - 10https://gerrit.wikimedia.org/r/539571 (owner: 10Reedy) [16:23:18] 10Wikidata-Bridge: Exhibit native behavior on key+click on bridge - https://phabricator.wikimedia.org/T234060 (10Pablo-WMDE) [16:23:21] 10MediaWiki-extensions-Page_Forms, 10User-TheSandDoctor: PageForms needs 'editToken' replaced with 'csrfToken' - https://phabricator.wikimedia.org/T233557 (10Zoranzoki21) 05Open→03Resolved [16:23:23] 10MediaWiki-ResourceLoader, 10Performance-Team, 10MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), 10Technical-Debt (Deprecation), 10User-TheSandDoctor: Remove 'editToken' from mw.user.tokens (deprecated for 'csrfToken') - https://phabricator.wikimedia.org/T233442 (10Zoranzoki21) [16:23:25] (03CR) 10jerkins-bot: [V: 04-1] Split down patch-comment-table.sql [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/539566 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [16:23:38] (03CR) 10jenkins-bot: Remove @embed where it needlessly delays loading of the UI [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/532098 (https://phabricator.wikimedia.org/T121730) (owner: 10Krinkle) [16:23:42] 10Wikidata-Bridge: Exhibit native behavior on key+click on bridge link - https://phabricator.wikimedia.org/T234060 (10Pablo-WMDE) [16:23:44] (03PS2) 10Reedy: Split down patch-comment-table.sql [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/539566 (https://phabricator.wikimedia.org/T227662) [16:23:50] (03Abandoned) 10Daimona Eaytoy: [DNM] Jenkins test [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539570 (owner: 10Daimona Eaytoy) [16:23:57] (03CR) 10Krinkle: resourceloader: Add $context to static functions in ResourceLoader (031 comment) [core] - 10https://gerrit.wikimedia.org/r/535266 (https://phabricator.wikimedia.org/T229311) (owner: 10Fomafix) [16:24:03] (03PS2) 10Reedy: Split down patch-comment-table.sql [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/539568 (https://phabricator.wikimedia.org/T227662) [16:24:11] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.1, 10CommRel-Specialists-Support (Jul-Sep-2019), 10Growth-Team (Current Sprint): Newcomer tasks: article configurations for topics - https://phabricator.wikimedia.org/T233465 (10MMiller_WMF) [16:24:21] (03PS1) 10Daimona Eaytoy: [DNM] Jenkins test [core] - 10https://gerrit.wikimedia.org/r/539572 [16:24:37] (03PS2) 10Reedy: Split down patch-comment-table.sql [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/539569 (https://phabricator.wikimedia.org/T227662) [16:24:53] (03PS2) 10Daimona Eaytoy: [DNM] Jenkins test [core] - 10https://gerrit.wikimedia.org/r/539572 [16:25:31] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.1, 10Growth-Team (Current Sprint): Newcomer tasks: prototype task selection - https://phabricator.wikimedia.org/T231506 (10MMiller_WMF) @kostajh -- the ambassadors are finished listing articles, so I think we should be good to populate the prototype with what's... [16:25:42] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Add $context to static functions in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/535266 (https://phabricator.wikimedia.org/T229311) (owner: 10Fomafix) [16:26:22] (03PS14) 10Krinkle: resourceloader: Add $context to static functions in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/535266 (https://phabricator.wikimedia.org/T229311) (owner: 10Fomafix) [16:26:56] (03CR) 10Krinkle: [C: 03+1] "Oops, was gonna make a minor edit before landing, but has a failing test. I'll get back to this later today." [core] - 10https://gerrit.wikimedia.org/r/535266 (https://phabricator.wikimedia.org/T229311) (owner: 10Fomafix) [16:27:20] (03PS1) 10Alex Paskulin: docs: README updates [services/kask] - 10https://gerrit.wikimedia.org/r/539573 [16:28:32] 10MediaWiki-Codesniffer, 10Patch-For-Review: Position of boolean operators inside an if condition - https://phabricator.wikimedia.org/T116561 (10Krinkle) [16:28:59] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Growth-Team (Current Sprint): Newcomer tasks: suggested edits module - https://phabricator.wikimedia.org/T232423 (10MMiller_WMF) @kostajh -- thanks for reading closely. The reason I wrote "templates and categories" is because I have seen a couple cases i... [16:29:33] (03CR) 10jerkins-bot: [V: 04-1] Split down patch-comment-table.sql [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/539569 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [16:31:06] 10MediaWiki-Codesniffer: Create optional sniff to require documenting private methods - https://phabricator.wikimedia.org/T233838 (10Krinkle) [16:31:14] 10MediaWiki-Codesniffer: Create optional sniff to require documenting private methods - https://phabricator.wikimedia.org/T233838 (10Krinkle) p:05Triage→03Normal [16:31:23] (03CR) 10jerkins-bot: [V: 04-1] Split down patch-comment-table.sql [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/539566 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [16:31:37] (03CR) 10jerkins-bot: [V: 04-1] Split down patch-comment-table.sql [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/539568 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [16:31:38] (03CR) 10Alex Paskulin: "Hi Clara," [services/kask] - 10https://gerrit.wikimedia.org/r/539573 (owner: 10Alex Paskulin) [16:32:17] 10MediaWiki-Codesniffer: Create optional sniff to require documenting private methods - https://phabricator.wikimedia.org/T233838 (10Krinkle) Accepting, on the assumption that there isn't a built-in rule already that can be enabled through `phpcs.xml`. We'd ship a rule for it, but leave it out of the default pre... [16:32:43] 10MediaWiki-Codesniffer: Add a sniff to disallow @internal and @since on the same documented member - https://phabricator.wikimedia.org/T229454 (10Krinkle) p:05Triage→03Normal [16:35:44] (03CR) 10Fomafix: resourceloader: Add $context to static functions in ResourceLoader (031 comment) [core] - 10https://gerrit.wikimedia.org/r/535266 (https://phabricator.wikimedia.org/T229311) (owner: 10Fomafix) [16:36:30] (03PS15) 10Fomafix: resourceloader: Add $context to static functions in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/535266 (https://phabricator.wikimedia.org/T229311) [16:36:32] (03CR) 10Anomie: Remove Revision::getRevisionText and gated pre-MCR schema access (031 comment) [core] - 10https://gerrit.wikimedia.org/r/538314 (https://phabricator.wikimedia.org/T198343) (owner: 10Ppchelko) [16:36:53] (03CR) 10jerkins-bot: [V: 04-1] Split down patch-comment-table.sql [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/539566 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [16:37:33] (03CR) 10jerkins-bot: [V: 04-1] Split down patch-comment-table.sql [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/539568 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [16:37:41] (03PS2) 10Fomafix: resourceloader: Require $context in getDeprecationInformation [core] - 10https://gerrit.wikimedia.org/r/538584 [16:37:50] (03CR) 10jerkins-bot: [V: 04-1] Split down patch-comment-table.sql [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/539569 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [16:38:03] (03CR) 10Krinkle: Baseline reference interaction tracking (031 comment) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/538261 (https://phabricator.wikimedia.org/T231529) (owner: 10Awight) [16:38:07] (03CR) 10Krinkle: [C: 04-1] Baseline reference interaction tracking [extensions/Cite] - 10https://gerrit.wikimedia.org/r/538261 (https://phabricator.wikimedia.org/T231529) (owner: 10Awight) [16:38:49] (03PS5) 10Ppchelko: Fix permission check on protection log [core] - 10https://gerrit.wikimedia.org/r/539536 (https://phabricator.wikimedia.org/T234017) (owner: 10Ammarpad) [16:39:29] (03CR) 10Ppchelko: "I've updated the patch to include a simple regression test." [core] - 10https://gerrit.wikimedia.org/r/539536 (https://phabricator.wikimedia.org/T234017) (owner: 10Ammarpad) [16:39:35] (03CR) 10Ppchelko: [C: 03+1] Fix permission check on protection log [core] - 10https://gerrit.wikimedia.org/r/539536 (https://phabricator.wikimedia.org/T234017) (owner: 10Ammarpad) [16:40:15] (03PS7) 10Ppchelko: Remove Revision::getRevisionText and gated pre-MCR schema access [core] - 10https://gerrit.wikimedia.org/r/538314 (https://phabricator.wikimedia.org/T198343) [16:40:18] (03CR) 10Ppchelko: Remove Revision::getRevisionText and gated pre-MCR schema access (031 comment) [core] - 10https://gerrit.wikimedia.org/r/538314 (https://phabricator.wikimedia.org/T198343) (owner: 10Ppchelko) [16:40:59] (03CR) 10Daniel Kinzler: [C: 03+2] "Forgot to hit +2 again. Sorry about that." [core] - 10https://gerrit.wikimedia.org/r/538977 (https://phabricator.wikimedia.org/T214308) (owner: 10Clarakosi) [16:41:03] (03CR) 10Daimona Eaytoy: [C: 03+1] "> > - mediawiki-core-php72-phan-docker https://integration.wikimedia.org/ci/job/mediawiki-core-php72-phan-docker/7054/console" [core] - 10https://gerrit.wikimedia.org/r/434973 (https://phabricator.wikimedia.org/T192166) (owner: 10Jforrester) [16:42:31] (03CR) 10Daniel Kinzler: [C: 03+2] Fix permission check on protection log [core] - 10https://gerrit.wikimedia.org/r/539536 (https://phabricator.wikimedia.org/T234017) (owner: 10Ammarpad) [16:43:35] 10MediaWiki-Logging, 10Patch-For-Review, 10Regression: Protect log entries offer link to change protection only to unprivileged users - https://phabricator.wikimedia.org/T234017 (10Pchelolo) 05Open→03Resolved [16:43:38] (03CR) 10Krinkle: [C: 04-1] Baseline reference interaction tracking (031 comment) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/538261 (https://phabricator.wikimedia.org/T231529) (owner: 10Awight) [16:43:40] (03PS2) 10Reedy: Fix double dot in filename [core] - 10https://gerrit.wikimedia.org/r/539571 [16:43:47] 10MediaWiki-Core-Testing, 10Performance-Team, 10Wikimedia-Rdbms, 10Core Platform Team Workboards (Purple), 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01): PageUpdaterTest fails when run in isolation due to setTempTableOnlyMode() being called with wrong domain. - https://phabricator.wikimedia.org/T234031 (10d... [16:43:56] (03PS3) 10Reedy: Split down patch-comment-table.sql [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/539566 (https://phabricator.wikimedia.org/T227662) [16:44:16] (03PS3) 10Reedy: Split down patch-comment-table.sql [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/539568 (https://phabricator.wikimedia.org/T227662) [16:44:54] (03PS3) 10Reedy: Split down patch-comment-table.sql [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/539569 (https://phabricator.wikimedia.org/T227662) [16:45:17] 10MediaWiki-Page-protection: Split 'protect' right in two distinct permissions (instead of using '$wgCascadingRestrictionLevels') - https://phabricator.wikimedia.org/T71607 (10Ammarpad) @Xaosflux what's stalling this? [16:47:01] (03CR) 10Reedy: [C: 03+2] "Same reason" [core] - 10https://gerrit.wikimedia.org/r/539571 (owner: 10Reedy) [16:48:59] (03PS1) 10Nray: Fix Recent Changes Comment alignment on deleted pages [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/539577 (https://phabricator.wikimedia.org/T232955) [16:49:23] (03CR) 10Krinkle: Baseline reference interaction tracking (031 comment) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/538261 (https://phabricator.wikimedia.org/T231529) (owner: 10Awight) [16:49:41] (03CR) 10jerkins-bot: [V: 04-1] [DNM] Jenkins test [core] - 10https://gerrit.wikimedia.org/r/539572 (owner: 10Daimona Eaytoy) [16:50:51] (03PS2) 10Krinkle: rdbms: Remove obsolete comment in LoadBalancerSingle [core] - 10https://gerrit.wikimedia.org/r/539353 (owner: 10Lucas Werkmeister (WMDE)) [16:51:26] (03CR) 10Krinkle: [C: 03+2] "(removed Change-Ids per git commit-msg conventions, commit hashes are resolvable everywhere change Ids are, but not vice-versa)." [core] - 10https://gerrit.wikimedia.org/r/539353 (owner: 10Lucas Werkmeister (WMDE)) [16:51:29] (03CR) 10jerkins-bot: [V: 04-1] [DNM] Jenkins test [core] - 10https://gerrit.wikimedia.org/r/539572 (owner: 10Daimona Eaytoy) [16:51:57] 10Wikidata-Bridge: Exhibit native behavior on key+click on bridge link - https://phabricator.wikimedia.org/T234060 (10Lydia_Pintscher) Ohhhh yes. It annoys the heck out of me every time another website does this :D So ack from my side. [16:53:00] (03CR) 10Daniel Kinzler: [C: 03+2] Remove Revision::getRevisionText and gated pre-MCR schema access [core] - 10https://gerrit.wikimedia.org/r/538314 (https://phabricator.wikimedia.org/T198343) (owner: 10Ppchelko) [16:53:47] (03PS2) 10Ppchelko: Remove dependency on pre-MCR database schema [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/538688 (https://phabricator.wikimedia.org/T233353) [16:53:54] (03CR) 10Ppchelko: Remove dependency on pre-MCR database schema (031 comment) [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/538688 (https://phabricator.wikimedia.org/T233353) (owner: 10Ppchelko) [16:54:11] 10AbuseFilter: Endless loop between forceeditsummary and Abusefilter warnings - https://phabricator.wikimedia.org/T132869 (10DannyS712) Still an issues - https://mr.wikipedia.org/wiki/%E0%A4%B5%E0%A4%BF%E0%A4%B6%E0%A5%87%E0%A4%B7:%E0%A4%B8%E0%A4%82%E0%A4%AA%E0%A4%BE%E0%A4%A6%E0%A4%A8%E0%A4%97%E0%A4%BE%E0%A4%B3%E... [16:55:15] (03CR) 10Lucas Werkmeister (WMDE): "well, on Gerrit the commit hash redirects me to a search page that also includes this commit (because it mentions the hash), whereas the c" [core] - 10https://gerrit.wikimedia.org/r/539353 (owner: 10Lucas Werkmeister (WMDE)) [16:55:34] (03PS1) 10Daimona Eaytoy: Simplify a query in AFComputedVariable [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/539578 [16:56:00] 10MediaWiki-General, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), 10Schema-change, 10User-Marostegui: Remove MySQL aliasing for user_newtalk indexes - https://phabricator.wikimedia.org/T233240 (10Marostegui) >>! In T233240#5529624, @Anomie wrote: > @Mar... [16:57:20] (03CR) 10Lucas Werkmeister (WMDE): [C: 03+1] Remove dependency on pre-MCR database schema (031 comment) [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/538688 (https://phabricator.wikimedia.org/T233353) (owner: 10Ppchelko) [16:58:53] (03PS6) 10Ppchelko: Fix permission check on protection log [core] - 10https://gerrit.wikimedia.org/r/539536 (https://phabricator.wikimedia.org/T234017) (owner: 10Ammarpad) [16:59:31] (03CR) 10Ppchelko: "PS6 fixes phpcs warning in PS5 about unused use statement." [core] - 10https://gerrit.wikimedia.org/r/539536 (https://phabricator.wikimedia.org/T234017) (owner: 10Ammarpad) [16:59:51] (03CR) 10Daniel Kinzler: "nitpics, nitpics..." (031 comment) [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/538688 (https://phabricator.wikimedia.org/T233353) (owner: 10Ppchelko) [17:00:32] (03CR) 10Daniel Kinzler: [C: 03+2] Fix permission check on protection log [core] - 10https://gerrit.wikimedia.org/r/539536 (https://phabricator.wikimedia.org/T234017) (owner: 10Ammarpad) [17:00:44] (03PS3) 10Ppchelko: Remove dependency on pre-MCR database schema [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/538688 (https://phabricator.wikimedia.org/T233353) [17:01:59] (03PS4) 10Ppchelko: Remove dependency on pre-MCR database schema [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/538688 (https://phabricator.wikimedia.org/T233353) [17:02:33] (03CR) 10Clarakosi: "Small nits below but otherwise look good!" (033 comments) [services/kask] - 10https://gerrit.wikimedia.org/r/539573 (owner: 10Alex Paskulin) [17:02:54] (03CR) 10Ppchelko: Remove dependency on pre-MCR database schema (032 comments) [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/538688 (https://phabricator.wikimedia.org/T233353) (owner: 10Ppchelko) [17:03:21] 10MediaWiki-General, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), 10Schema-change, 10User-Marostegui: Remove MySQL aliasing for user_newtalk indexes - https://phabricator.wikimedia.org/T233240 (10Anomie) Ok, created {T234066}. [17:03:53] (03CR) 10Lucas Werkmeister (WMDE): [C: 03+2] "\o/" [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/538688 (https://phabricator.wikimedia.org/T233353) (owner: 10Ppchelko) [17:04:11] (03CR) 10jerkins-bot: [V: 04-1] Split down patch-comment-table.sql [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/539569 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [17:04:52] (03CR) 10Krinkle: [C: 03+2] "Aye, good point. I hadn't realised that. I won't do it again then, sorry about that." [core] - 10https://gerrit.wikimedia.org/r/539353 (owner: 10Lucas Werkmeister (WMDE)) [17:05:40] 10CheckUser: Backwards output on Checkuser for new accounts - https://phabricator.wikimedia.org/T162491 (10Jpgordon) >>! In T162491#5527349, @Niharika wrote: > @Jpgordon I cannot replicate this bug. Can you confirm if it is fixed now? Confirmed; I don't see it happening this way anymore. [17:06:14] (03PS9) 10Krinkle: Remove @embed page load delays (and misc optimisations) [skins/Vector] - 10https://gerrit.wikimedia.org/r/528480 (https://phabricator.wikimedia.org/T121730) [17:06:25] (03CR) 10Krinkle: "Rebased to resolve conflict with less variable renames from yesterday." [skins/Vector] - 10https://gerrit.wikimedia.org/r/528480 (https://phabricator.wikimedia.org/T121730) (owner: 10Krinkle) [17:06:48] (03CR) 10Lucas Werkmeister (WMDE): "Okay, then I’ll keep following my own little convention in other changes – thanks for understanding :)" [core] - 10https://gerrit.wikimedia.org/r/539353 (owner: 10Lucas Werkmeister (WMDE)) [17:08:25] (03CR) 10jerkins-bot: [V: 04-1] [DNM] Drop HHVM support from MediaWiki [core] - 10https://gerrit.wikimedia.org/r/434973 (https://phabricator.wikimedia.org/T192166) (owner: 10Jforrester) [17:11:56] (03PS2) 10Alex Paskulin: docs: README updates [services/kask] - 10https://gerrit.wikimedia.org/r/539573 [17:11:58] 10ProveIt-Gadget: Bad template names - https://phabricator.wikimedia.org/T148235 (10Sophivorus) 05Open→03Resolved a:03Sophivorus Fixed! See https://ru.wikipedia.org/w/index.php?title=Богомоловые&action=edit for proof and add other "strange" templates to https://ru.wikipedia.org/wiki/MediaWiki:Gadget-ProveI... [17:12:05] 10Wikidata-Bridge: Consider svgo use (via cssnano) - https://phabricator.wikimedia.org/T234070 (10Pablo-WMDE) [17:15:17] 10WMF-Legal, 10Wikimedia-Site-requests, 10Patch-For-Review: Patroller right changes to ro.wp - https://phabricator.wikimedia.org/T234051 (10Urbanecm) Could #wmf-legal comment on this, please? [17:15:23] (03CR) 10jerkins-bot: [V: 04-1] Split down patch-comment-table.sql [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/539569 (https://phabricator.wikimedia.org/T227662) (owner: 10Reedy) [17:15:26] (03PS2) 10VolkerE: Unify LESS variable naming scheme for `@line-height-*` variables [skins/Vector] - 10https://gerrit.wikimedia.org/r/539443 (https://phabricator.wikimedia.org/T4013) [17:15:38] 10GrowthExperiments, 10Product-Analytics, 10Growth-Team (Current Sprint): Deploy welcome survey to Basque Wikipedia - https://phabricator.wikimedia.org/T233063 (10nettrom_WMF) p:05Triage→03Normal [17:15:56] 10WMF-Legal, 10Wikimedia-Site-requests, 10Patch-For-Review: Patroller right changes to ro.wp - https://phabricator.wikimedia.org/T234051 (10DannyS712) 05Open→03Stalled [17:16:27] 10GrowthExperiments, 10Product-Analytics, 10Growth-Team (Current Sprint): Welcome survey: modifications to the "Getting started with editing" box - https://phabricator.wikimedia.org/T232406 (10nettrom_WMF) p:05Triage→03Normal [17:16:57] (03Abandoned) 10Mischanix: PageValues: addIdentifierQuotes needs a database [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/538948 (owner: 10Mischanix) [17:17:25] 10WMF-Legal, 10Wikimedia-Site-requests, 10Patch-For-Review: Patroller right changes to ro.wp - https://phabricator.wikimedia.org/T234051 (10Urbanecm) p:05Triage→03Low [17:20:35] 10ProveIt-Gadget, 10Browser-Support-Internet-Explorer: ProveIt init doesn't work with Internet Explorer or in older browsers - https://phabricator.wikimedia.org/T171938 (10Sophivorus) 05Open→03Declined The latest ProveIt version crucially relies on the "atob" JavaScript method (https://developer.mozilla.or... [17:21:03] 10Who-Wrote-That, 10Community-Tech (Kanban (Q1 2019-20)): WWT: Original article HTML not necessarily preserved (was: Images have their links changed from Commons to local) [medium] - https://phabricator.wikimedia.org/T231424 (10MusikAnimal) PR merged, not sure if we are still investigating the issue with Minia... [17:22:05] 10ProveIt-Gadget: Templates without template data should be available in the ProveIt interface - https://phabricator.wikimedia.org/T233842 (10Sophivorus) 05Open→03Resolved a:03Sophivorus [17:22:46] (03PS1) 10DannyS712: Don't show option to enqueue main page [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539584 (https://phabricator.wikimedia.org/T234073) [17:24:34] (03PS2) 10DannyS712: Don't show option to enqueue main page [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539584 (https://phabricator.wikimedia.org/T234073) [17:25:08] 10Design, 10ProveIt-Gadget: Visually distinguish raw references - https://phabricator.wikimedia.org/T149081 (10Sophivorus) 05Open→03Declined Given that there already is a visual distinction for raw references (namely, that they don't start with a big bold "Cite whatever") I'm closing this task unless furth... [17:25:28] 10CheckUser: Backwards output on Checkuser for new accounts - https://phabricator.wikimedia.org/T162491 (10Huji) 05Open→03Invalid [17:34:44] (03CR) 10Krinkle: [C: 03+2] resourceloader: Add type hints for type ResourceLoaderContext [core] - 10https://gerrit.wikimedia.org/r/539444 (owner: 10Fomafix) [17:35:32] (03PS1) 10Robert Vogel: Add "overrides" configuration for ExtensionAttributeBasedRegistry [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/539586 [17:36:17] (03CR) 10Jdlrobson: Vertically align the page issues icon with the text (032 comments) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/538710 (https://phabricator.wikimedia.org/T232837) (owner: 10Jdlrobson) [17:39:25] (03PS5) 10Jdlrobson: Vertically align the page issues icon with the text [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/538710 (https://phabricator.wikimedia.org/T232837) [17:41:44] (03PS6) 10Jdlrobson: Vertically align the page issues icon with the text [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/538710 (https://phabricator.wikimedia.org/T232837) [17:42:32] (03CR) 10Krinkle: [C: 03+2] resourceloader: Add $context to static functions in ResourceLoader (031 comment) [core] - 10https://gerrit.wikimedia.org/r/535266 (https://phabricator.wikimedia.org/T229311) (owner: 10Fomafix) [17:45:32] (03PS1) 10Brennen Bearnes: .pipeline/config.yaml: rename dev stage to publish [core] - 10https://gerrit.wikimedia.org/r/539589 (https://phabricator.wikimedia.org/T218360) [17:46:11] (03CR) 10Thcipriani: [C: 03+1] pipeline: Fix execution configuration [services/kartotherian] - 10https://gerrit.wikimedia.org/r/539209 (https://phabricator.wikimedia.org/T233316) (owner: 10Dduvall) [17:50:07] (03CR) 10MusikAnimal: [C: 03+2] "Thank you for this! We will try to get this deployed ASAP, which might have to be Monday." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539584 (https://phabricator.wikimedia.org/T234073) (owner: 10DannyS712) [17:51:49] 04(no projects): user-SwedishMuseum - https://phabricator.wikimedia.org/T234078 (10SwedishMuseum) [17:52:38] (03Merged) 10jenkins-bot: Force usage of MCR aware database schema [core] - 10https://gerrit.wikimedia.org/r/538977 (https://phabricator.wikimedia.org/T214308) (owner: 10Clarakosi) [17:54:38] 10Design, 10MediaWiki-extensions-WikibaseRepository, 10WMDE-Design, 10Wikidata, 10Wikidata-Campsite: Highlight individual statements when selecting them in the URL - https://phabricator.wikimedia.org/T234079 (10Lucas_Werkmeister_WMDE) [17:56:21] (03CR) 10Jdlrobson: [C: 03+1] "According to 9c1e1abc the float was added to avoid clutter with the rollback links on SpecialContributions. Can you confirm this doesn't " [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/539577 (https://phabricator.wikimedia.org/T232955) (owner: 10Nray) [17:57:00] (03Abandoned) 10Daimona Eaytoy: [DNM] Jenkins test [core] - 10https://gerrit.wikimedia.org/r/539572 (owner: 10Daimona Eaytoy) [17:57:39] (03PS1) 10Urbanecm: Revert "Add autoritywiki to separate" [wikimedia-cz/mediawiki-config] - 10https://gerrit.wikimedia.org/r/539590 [17:57:41] (03PS1) 10Urbanecm: Allow sysops to grant nonmember [wikimedia-cz/mediawiki-config] - 10https://gerrit.wikimedia.org/r/539591 [17:57:48] 10TechCom, 10Core Platform Team Legacy (Watching / External), 10HHVM, 10Patch-For-Review: Drop HHVM support from MediaWiki - https://phabricator.wikimedia.org/T192166 (10Daimona) [17:57:53] 10Phabricator: ArgumentCountError on Phabricator - https://phabricator.wikimedia.org/T233998 (10epriestley) Ignore me if I have no clue what's going on, but I added another call to this method in , which may need adjustment if you've tweaked it (which I //think// is what's... [17:57:55] (03CR) 10Urbanecm: [C: 03+2] Revert "Add autoritywiki to separate" [wikimedia-cz/mediawiki-config] - 10https://gerrit.wikimedia.org/r/539590 (owner: 10Urbanecm) [17:57:57] (03CR) 10Urbanecm: [C: 03+2] Allow sysops to grant nonmember [wikimedia-cz/mediawiki-config] - 10https://gerrit.wikimedia.org/r/539591 (owner: 10Urbanecm) [17:58:06] (03PS2) 10Robert Vogel: Add "overrides" configuration for ExtensionAttributeBasedRegistry [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/539586 [17:58:14] (03Merged) 10jenkins-bot: Revert "Add autoritywiki to separate" [wikimedia-cz/mediawiki-config] - 10https://gerrit.wikimedia.org/r/539590 (owner: 10Urbanecm) [17:58:16] (03Merged) 10jenkins-bot: Allow sysops to grant nonmember [wikimedia-cz/mediawiki-config] - 10https://gerrit.wikimedia.org/r/539591 (owner: 10Urbanecm) [17:58:23] 10Phabricator: ArgumentCountError on Phabricator - https://phabricator.wikimedia.org/T233998 (10epriestley) (That change is from 5 seconds ago so this would just be something to keep an eye on for the next deployment.) [17:58:55] 10Design, 10MediaWiki-extensions-WikibaseRepository, 10WMDE-Design, 10Wikidata, and 2 others: Highlight individual statements when selecting them in the URL - https://phabricator.wikimedia.org/T234079 (10Lucas_Werkmeister_WMDE) The change linked above implements this; here’s what it looks like if the state... [17:59:14] 10Design, 10MediaWiki-extensions-WikibaseRepository, 10WMDE-Design, 10Wikidata, and 4 others: Highlight statement(s) when using "#P" in URL - https://phabricator.wikimedia.org/T178745 (10Lucas_Werkmeister_WMDE) > So should we create a separate Phabricator task for that, if this one is now done? Done (T234... [17:59:21] 10Design, 10MediaWiki-extensions-WikibaseRepository, 10WMDE-Design, 10Wikidata, and 4 others: Highlight statement(s) when using "#P" in URL - https://phabricator.wikimedia.org/T178745 (10Lucas_Werkmeister_WMDE) [18:00:00] 10Events Team, 10CommRel-Specialists-Support (Jul-Sep-2019): Events Portal Creation on Wikis - https://phabricator.wikimedia.org/T224681 (10Elitre) @elappen-WMF is the integration between the Space calendar and the wikis something we should/could request? (I couldn't find an existing task around it). [18:01:50] 10GrowthExperiments-HelpModule, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.23; 2019-09-17), 10Patch-For-Review: Homepage: remove question-asking from help module - https://phabricator.wikimedia.org/T232548 (10kostajh) 05Resolved→03Open Re-opening because... [18:01:53] (03CR) 10Tpt: [C: 04-1] "You should add help for each message in the qqq.json file to fix the jenkin-bot problem." [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/539560 (https://phabricator.wikimedia.org/T60062) (owner: 10Jon Harald Søby) [18:01:56] 10GrowthExperiments-HelpModule, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Patch-For-Review: Homepage: help module - https://phabricator.wikimedia.org/T215986 (10kostajh) [18:03:24] (03PS1) 10Sophivorus: Minor fix for when the user prefered language is not available [wikipedia/gadgets/ProveIt] - 10https://gerrit.wikimedia.org/r/539593 [18:03:46] (03CR) 10Sophivorus: [V: 03+2 C: 03+2] Minor fix for when the user prefered language is not available [wikipedia/gadgets/ProveIt] - 10https://gerrit.wikimedia.org/r/539593 (owner: 10Sophivorus) [18:05:51] (03CR) 10jerkins-bot: [V: 04-1] Fix double dot in filename [core] - 10https://gerrit.wikimedia.org/r/539571 (owner: 10Reedy) [18:06:11] (03PS1) 10Jdlrobson: Style rollback link on RecentChanges, Contributions and Watchlist [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/539595 (https://phabricator.wikimedia.org/T232284) [18:07:47] (03CR) 10jerkins-bot: [V: 04-1] Vertically align the page issues icon with the text [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/538710 (https://phabricator.wikimedia.org/T232837) (owner: 10Jdlrobson) [18:08:19] (03PS5) 10Jdlrobson: Restrict the MobileFormatter to certain pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/539213 (https://phabricator.wikimedia.org/T232690) [18:11:49] (03CR) 10Jdlrobson: Restrict the MobileFormatter to certain pages (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/539213 (https://phabricator.wikimedia.org/T232690) (owner: 10Jdlrobson) [18:12:01] 10Space (Jul-Sep-2019): Commissioned Discuss Space features Sept-Dec 2019 - https://phabricator.wikimedia.org/T231606 (10elappen-WMF) [18:12:06] 10Space: Cant log into discuss space in discourse Android app, 503 - https://phabricator.wikimedia.org/T227035 (10elappen-WMF) [18:12:06] (03CR) 10Thcipriani: [C: 03+2] .pipeline/config.yaml: rename dev stage to publish [core] - 10https://gerrit.wikimedia.org/r/539589 (https://phabricator.wikimedia.org/T218360) (owner: 10Brennen Bearnes) [18:12:31] (03CR) 10Clarakosi: [C: 03+2] "Nice!" [services/kask] - 10https://gerrit.wikimedia.org/r/539573 (owner: 10Alex Paskulin) [18:13:15] (03Merged) 10jenkins-bot: docs: README updates [services/kask] - 10https://gerrit.wikimedia.org/r/539573 (owner: 10Alex Paskulin) [18:13:46] (03PS7) 10Jdlrobson: Vertically align the page issues icon with the text [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/538710 (https://phabricator.wikimedia.org/T232837) [18:14:33] (03CR) 10PipelineBot: "pipeline-dashboard: service-pipeline-test-and-publish" [services/kask] - 10https://gerrit.wikimedia.org/r/539573 (owner: 10Alex Paskulin) [18:14:35] (03CR) 10jenkins-bot: docs: README updates [services/kask] - 10https://gerrit.wikimedia.org/r/539573 (owner: 10Alex Paskulin) [18:15:16] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/539392 (owner: 10L10n-bot) [18:16:11] (03PS11) 10Ppchelko: RevisionStore: Introduce getContentBlobsForBatch [core] - 10https://gerrit.wikimedia.org/r/539324 (https://phabricator.wikimedia.org/T228675) (owner: 10Daniel Kinzler) [18:16:16] 10MediaWiki-General, 10WorkType-NewFunctionality: MediaWiki needs more easter eggs - https://phabricator.wikimedia.org/T22281 (10DannyS712) >>! In T22281#4904929, @Legoktm wrote: >>>! In T22281#4904867, @Sunpriat wrote: >> This is visible to many. > > The text you complained about on T214555 should never be s... [18:16:34] (03CR) 10Ppchelko: "PS11 is a manual rebase." [core] - 10https://gerrit.wikimedia.org/r/539324 (https://phabricator.wikimedia.org/T228675) (owner: 10Daniel Kinzler) [18:17:26] (03CR) 10Jdlrobson: "> I don't think this is the right approach. In the old approach, list-style-type depended on the content language (and even could support " [core] - 10https://gerrit.wikimedia.org/r/539167 (https://phabricator.wikimedia.org/T217616) (owner: 10Jdlrobson) [18:20:14] (03CR) 10jenkins-bot: Force usage of MCR aware database schema [core] - 10https://gerrit.wikimedia.org/r/538977 (https://phabricator.wikimedia.org/T214308) (owner: 10Clarakosi) [18:22:54] 10MobileFrontend, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), 10good first bug: Rollback link on mobile should be styled on Special:Watchlist, Special:RecentChanges and Special:Contributions - https://phabricator.wikimedia.org/T232284 (10Jdlrobson) after above change: {F30... [18:23:06] 10Growth-Team (Current Sprint): EditorJourney records revision IDs for diffs - https://phabricator.wikimedia.org/T234084 (10nettrom_WMF) [18:23:55] 10Hashtags, 10Product-Analytics: Discuss edit hashtag support with major bot/tool/gadget creators - https://phabricator.wikimedia.org/T123636 (10Whatamidoing-WMF) Are you trying to do something like what @Reedy did with AWB in {T111663}? Also, I think ProveIt is on the list at {T185382}. [18:25:07] 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Epics), 10Epic, 10MW-1.34-release: Make SCHEMA_COMPAT_NEW the default MCR migration schema - https://phabricator.wikimedia.org/T231673 (10Clarakosi) [18:25:09] 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Purple), 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), 10MW-1.34-release, and 2 others: Force usage of MCR aware database schema - https://phabricator.wikimedia.org/T214308 (10Clarakosi) 05Open→03Resolved a:03Clarakosi [18:25:41] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: WMTC19: Themes/Focus Areas Proposals - https://phabricator.wikimedia.org/T234085 (10Rfarrand) [18:26:23] 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10ConfirmEdit (CAPTCHA extension), 10Parsoid, and 8 others: Missing licenses on enwiki - https://phabricator.wikimedia.org/T234086 (10DannyS712) [18:26:53] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: Theme: Local Development and onboarding - https://phabricator.wikimedia.org/T234087 (10Rfarrand) [18:27:29] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: Theme: Testing - https://phabricator.wikimedia.org/T234088 (10Rfarrand) [18:28:27] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: Theme: Deploying and Hosting - https://phabricator.wikimedia.org/T234089 (10Rfarrand) [18:29:02] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: Theme: Standardization Decisions - https://phabricator.wikimedia.org/T234090 (10Rfarrand) [18:29:34] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: Theme: People and Processes - https://phabricator.wikimedia.org/T234091 (10Rfarrand) [18:30:33] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: Theme: Deploying and Hosting - https://phabricator.wikimedia.org/T234089 (10Rfarrand) [18:30:51] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: Theme: Standardization Decisions - https://phabricator.wikimedia.org/T234090 (10Rfarrand) [18:31:01] 10MediaWiki-extensions-Page_Forms, 10Patch-For-Review, 10User-Nikerabbit: "values from namespace=Category" always lists all namespaces when $wgPageFormsUseDisplayTitle is true - https://phabricator.wikimedia.org/T208019 (10Nikerabbit) 05Open→03Resolved a:03Nikerabbit [18:31:10] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: Theme: People and Processes - https://phabricator.wikimedia.org/T234091 (10Rfarrand) [18:32:49] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: Theme: People and Processes - https://phabricator.wikimedia.org/T234091 (10Rfarrand) p:05Triage→03Normal [18:33:06] (03CR) 10Mathew.onipe: [C: 03+1] "Thanks a lot for this!" [services/kartotherian] - 10https://gerrit.wikimedia.org/r/539209 (https://phabricator.wikimedia.org/T233316) (owner: 10Dduvall) [18:33:16] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: WMTC19: Themes/Focus Areas Proposals - https://phabricator.wikimedia.org/T234085 (10Rfarrand) p:05Triage→03Normal [18:33:31] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: Theme: Local Development and onboarding - https://phabricator.wikimedia.org/T234087 (10Rfarrand) p:05Triage→03Normal [18:33:45] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: Theme: Testing - https://phabricator.wikimedia.org/T234088 (10Rfarrand) p:05Triage→03Normal [18:33:49] (03CR) 10Krinkle: [C: 03+2] tests: Replace PHPUnit's loose assertEquals(null) with assertNull() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/537440 (owner: 10Thiemo Kreuz (WMDE)) [18:33:57] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: Theme: Deploying and Hosting - https://phabricator.wikimedia.org/T234089 (10Rfarrand) p:05Triage→03Normal [18:34:03] (03PS2) 10Nray: Fix Recent Changes Comment alignment on deleted pages [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/539577 (https://phabricator.wikimedia.org/T232955) [18:34:12] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: Theme: Standardization Decisions - https://phabricator.wikimedia.org/T234090 (10Rfarrand) p:05Triage→03Normal [18:34:34] (03PS1) 10DannyS712: Fix typo in skin.json ResourceModuleSkinStyles [skins/Vector] - 10https://gerrit.wikimedia.org/r/539600 (https://phabricator.wikimedia.org/T234003) [18:35:04] (03PS2) 10DannyS712: Fix typo in skin.json ResourceModuleSkinStyles [skins/Vector] - 10https://gerrit.wikimedia.org/r/539600 (https://phabricator.wikimedia.org/T234003) [18:35:42] 10MobileFrontend, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), 10good first bug: Rollback link on mobile should be styled on Special:Watchlist, Special:RecentChanges and Special:Contributions - https://phabricator.wikimedia.org/T232284 (10Masumrezarock100) >>! In T232284#55... [18:35:48] (03CR) 10Nray: "I ended up targeting the deletion comment selector more because it has padding that needs to be removed to be aligned correctly in mobile " [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/539577 (https://phabricator.wikimedia.org/T232955) (owner: 10Nray) [18:35:50] (03Merged) 10jenkins-bot: rdbms: Remove obsolete comment in LoadBalancerSingle [core] - 10https://gerrit.wikimedia.org/r/539353 (owner: 10Lucas Werkmeister (WMDE)) [18:37:40] (03CR) 10Krinkle: [C: 04-1] "-1 to clear from review dash. Ping or amend to clear once we know more from what remains in Wikibase use case so we can review further if " [core] - 10https://gerrit.wikimedia.org/r/537461 (owner: 10Lucas Werkmeister (WMDE)) [18:37:52] 10Design, 10MediaWiki-Special-pages, 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Needs Product Owner Decisions): Should Special:Contributions be converted to a table - https://phabricator.wikimedia.org/T121389 (10Jdlrobson) [18:37:57] (03PS1) 10Sophivorus: Minor fix to the parameter labels [wikipedia/gadgets/ProveIt] - 10https://gerrit.wikimedia.org/r/539601 [18:38:14] (03Merged) 10jenkins-bot: Remove Revision::getRevisionText and gated pre-MCR schema access [core] - 10https://gerrit.wikimedia.org/r/538314 (https://phabricator.wikimedia.org/T198343) (owner: 10Ppchelko) [18:38:15] (03CR) 10Sophivorus: [V: 03+2 C: 03+2] Minor fix to the parameter labels [wikipedia/gadgets/ProveIt] - 10https://gerrit.wikimedia.org/r/539601 (owner: 10Sophivorus) [18:38:23] (03Merged) 10jenkins-bot: Fix permission check on protection log [core] - 10https://gerrit.wikimedia.org/r/539536 (https://phabricator.wikimedia.org/T234017) (owner: 10Ammarpad) [18:38:26] (03Merged) 10jenkins-bot: Remove dependency on pre-MCR database schema [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/538688 (https://phabricator.wikimedia.org/T233353) (owner: 10Ppchelko) [18:38:38] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: Theme: Local Development and onboarding - https://phabricator.wikimedia.org/T234087 (10Rfarrand) a:05Rfarrand→03josephine_l [18:39:14] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: Theme: Deploying and Hosting - https://phabricator.wikimedia.org/T234089 (10Rfarrand) a:05Rfarrand→03WMDE-leszek [18:39:38] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: Theme: Standardization Decisions - https://phabricator.wikimedia.org/T234090 (10Rfarrand) a:05Rfarrand→03kaldari [18:39:55] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: Theme: People and Processes - https://phabricator.wikimedia.org/T234091 (10Rfarrand) a:05Rfarrand→03Bmueller [18:40:42] 10CommRel-Design, 10CommRel-Specialists-Support (Jul-Sep-2019): Library Bundle logo for The Wikipedia Library - https://phabricator.wikimedia.org/T228647 (10hdothiduc) Great, here it is: https://commons.wikimedia.org/wiki/File:Wikipedia_Library_Bundle_icon.svg Let me know if you need anything else from me or... [18:40:48] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: WMTC19: Themes/Focus Areas Proposals - https://phabricator.wikimedia.org/T234085 (10Rfarrand) [18:41:01] (03CR) 10jerkins-bot: [V: 04-1] Vertically align the page issues icon with the text [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/538710 (https://phabricator.wikimedia.org/T232837) (owner: 10Jdlrobson) [18:41:01] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: WMTC19: Themes/Focus Areas Proposals - https://phabricator.wikimedia.org/T234085 (10Rfarrand) [18:41:03] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/539353 (owner: 10Lucas Werkmeister (WMDE)) [18:41:06] (03CR) 10Jdlrobson: [C: 03+2] Fix Recent Changes Comment alignment on deleted pages [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/539577 (https://phabricator.wikimedia.org/T232955) (owner: 10Nray) [18:41:42] (03PS8) 10Jdlrobson: Vertically align the page issues icon with the text [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/538710 (https://phabricator.wikimedia.org/T232837) [18:42:01] (03CR) 10Jdlrobson: [C: 03+2] build: Lower default Karma logLevel during local development [core] - 10https://gerrit.wikimedia.org/r/538921 (owner: 10Krinkle) [18:42:57] 10International-Developer-Events, 10Wikimedia-Technical-Conference-2019: WMTC19: Themes/Focus Areas Proposals - https://phabricator.wikimedia.org/T234085 (10Rfarrand) [18:43:04] 10Map-of-monuments: Add unittests to Map of Monuments - https://phabricator.wikimedia.org/T207229 (10Urbanecm) a:05Urbanecm→03None [18:43:34] 10MobileFrontend, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), 10good first bug: Rollback link on mobile should be styled on Special:Watchlist, Special:RecentChanges and Special:Contributions - https://phabricator.wikimedia.org/T232284 (10Jdlrobson) This is out of scope for... [18:43:43] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/538314 (https://phabricator.wikimedia.org/T198343) (owner: 10Ppchelko) [18:43:53] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/539536 (https://phabricator.wikimedia.org/T234017) (owner: 10Ammarpad) [18:43:58] (03CR) 10Jdlrobson: [C: 03+2] "Thanks Danny" [skins/Vector] - 10https://gerrit.wikimedia.org/r/539600 (https://phabricator.wikimedia.org/T234003) (owner: 10DannyS712) [18:44:29] (03CR) 10Ppchelko: [C: 03+1] RevisionStore: Introduce getContentBlobsForBatch [core] - 10https://gerrit.wikimedia.org/r/539324 (https://phabricator.wikimedia.org/T228675) (owner: 10Daniel Kinzler) [18:44:35] (03CR) 10jenkins-bot: Remove dependency on pre-MCR database schema [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/538688 (https://phabricator.wikimedia.org/T233353) (owner: 10Ppchelko) [18:45:02] (03PS17) 10Jdlrobson: MainMenu is a controller not a View and server rendered [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/534888 [18:45:06] 10Design, 10MediaWiki-extensions-WikibaseRepository, 10WMDE-Design, 10Wikidata, and 2 others: Highlight individual statements when selecting them in the URL - https://phabricator.wikimedia.org/T234079 (10abian) Thanks for the task, @Lucas_Werkmeister_WMDE! Note that, when you load the page with the hash,... [18:46:35] (03CR) 10Nray: [C: 03+2] Restrict the MobileFormatter to certain pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/539213 (https://phabricator.wikimedia.org/T232690) (owner: 10Jdlrobson) [18:51:39] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Campsite, 10Patch-For-Review: The Wikibase web interface shows non-functional sitelink groups - https://phabricator.wikimedia.org/T232248 (10Addshore) [18:51:55] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Campsite, 10Patch-For-Review: The Wikibase web interface shows non-functional sitelink groups - https://phabricator.wikimedia.org/T232248 (10Addshore) p:05Triage→03Low [18:53:23] (03PS1) 10Kosta Harlan: Expand getMockMessage methods [core] - 10https://gerrit.wikimedia.org/r/539604 [18:54:33] (03PS1) 10Jdlrobson: Curtail use of mw.mobileFrontend in Minerva [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/539605 [18:58:10] (03PS1) 10DannyS712: Don't allow enqueueing main page via API [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539606 (https://phabricator.wikimedia.org/T234073) [18:59:44] 10Events Team, 10CommRel-Specialists-Support (Jul-Sep-2019): Events Portal Creation on Wikis - https://phabricator.wikimedia.org/T224681 (10elappen-WMF) Because the calendar is just based on the feed of events, it would fall under this task: {T215053}. Once the extension is finished, people will be able to cre... [19:01:55] 10Design, 10MediaWiki-extensions-WikibaseRepository, 10WMDE-Design, 10Wikidata, and 2 others: Highlight individual statements when selecting them in the URL - https://phabricator.wikimedia.org/T234079 (10Lydia_Pintscher) 👍 [19:02:14] (03PS1) 10Ppchelko: Hard deprecate Revision::getRevisionText() method [core] - 10https://gerrit.wikimedia.org/r/539607 (https://phabricator.wikimedia.org/T198343) [19:02:19] (03PS2) 10DannyS712: Don't allow enqueueing main page via API [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539606 (https://phabricator.wikimedia.org/T234073) [19:03:27] (03PS1) 10Urbanecm: Migrate separate.dblist into sul.dblist [wikimedia-cz/mediawiki-config] - 10https://gerrit.wikimedia.org/r/539608 [19:05:10] 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10ConfirmEdit (CAPTCHA extension), 10Parsoid, and 8 others: Missing licenses on enwiki - https://phabricator.wikimedia.org/T234086 (10ssastry) [19:05:46] (03CR) 10jenkins-bot: rdbms: Remove obsolete comment in LoadBalancerSingle [core] - 10https://gerrit.wikimedia.org/r/539353 (owner: 10Lucas Werkmeister (WMDE)) [19:06:28] (03PS13) 10Jdlrobson: Dev: Reorganise action menu code [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/534892 [19:06:30] (03PS13) 10Jdlrobson: POC: Minerva desktop runs desktop code not MobileFrontend code. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/495305 (https://phabricator.wikimedia.org/T171000) [19:07:01] (03CR) 10Urbanecm: [C: 03+2] Migrate separate.dblist into sul.dblist [wikimedia-cz/mediawiki-config] - 10https://gerrit.wikimedia.org/r/539608 (owner: 10Urbanecm) [19:07:05] (03PS1) 10Ppchelko: Remove tests that were skipped for MCR-enabled schema [core] - 10https://gerrit.wikimedia.org/r/539609 (https://phabricator.wikimedia.org/T214308) [19:07:25] (03Merged) 10jenkins-bot: Migrate separate.dblist into sul.dblist [wikimedia-cz/mediawiki-config] - 10https://gerrit.wikimedia.org/r/539608 (owner: 10Urbanecm) [19:07:54] (03PS2) 10Ppchelko: Remove tests that were skipped for MCR-enabled schema [core] - 10https://gerrit.wikimedia.org/r/539609 (https://phabricator.wikimedia.org/T214308) [19:09:35] (03PS1) 10Urbanecm: Force central logging of user rights at innerwiki [wikimedia-cz/mediawiki-config] - 10https://gerrit.wikimedia.org/r/539610 [19:09:54] (03CR) 10Urbanecm: [C: 03+2] Force central logging of user rights at innerwiki [wikimedia-cz/mediawiki-config] - 10https://gerrit.wikimedia.org/r/539610 (owner: 10Urbanecm) [19:10:24] (03Merged) 10jenkins-bot: Force central logging of user rights at innerwiki [wikimedia-cz/mediawiki-config] - 10https://gerrit.wikimedia.org/r/539610 (owner: 10Urbanecm) [19:11:11] (03PS2) 10Ppchelko: Hard deprecate Revision::getRevisionText() method [core] - 10https://gerrit.wikimedia.org/r/539607 (https://phabricator.wikimedia.org/T198343) [19:13:09] 10Hashtags, 10Product-Analytics: Discuss edit hashtag support with major bot/tool/gadget creators - https://phabricator.wikimedia.org/T123636 (10Sophivorus) >>! In T123636#5530540, @Whatamidoing-WMF wrote: > Are you trying to do something like what @Reedy did with AWB in {T111663}? Also, I think ProveIt is on... [19:17:41] (03CR) 10Thiemo Kreuz (WMDE): tests: Replace PHPUnit's loose assertEquals(null) with assertNull() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/537440 (owner: 10Thiemo Kreuz (WMDE)) [19:17:49] (03PS6) 10Thiemo Kreuz (WMDE): tests: Replace PHPUnit's loose assertEquals(null) with assertNull() [core] - 10https://gerrit.wikimedia.org/r/537440 [19:18:35] 10ProveIt-Gadget, 10I18n: Bot for update localized files on Commons - https://phabricator.wikimedia.org/T214199 (10Sophivorus) 05Open→03Resolved a:03Sophivorus The bot is no longer needed since it turns out to be possible to get the latest translations directly from Gerrit/Gitiles [19:23:29] 10WMF-Legal, 10Wikimedia-Site-requests, 10Patch-For-Review: Patroller right changes to ro.wp - https://phabricator.wikimedia.org/T234051 (10Strainu) @DannyS712 I can't find any such policy on meta. Could you please provide a link with the mentioned requirements? [19:24:18] 10ProveIt-Gadget, 10I18n, 10Tracking-Neverending: Localization of the ProveIt gadget - https://phabricator.wikimedia.org/T148335 (10Sophivorus) 05Open→03Resolved a:03Sophivorus Localization (that is, translation to particular languages) of the ProveIt gadget is being done through translatewiki.net The... [19:24:24] 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10ConfirmEdit (CAPTCHA extension), 10Parsoid, and 8 others: Missing licenses on enwiki - https://phabricator.wikimedia.org/T234086 (10Isarra) Dumb question, but why exactly do we need to manually include the license with every extension when for the most... [19:25:10] (03PS12) 10Ppchelko: Convert FileBackendGroup to service [core] - 10https://gerrit.wikimedia.org/r/531486 (owner: 10simetrical) [19:27:20] 10ProveIt-Gadget: Hebrew localization - https://phabricator.wikimedia.org/T148907 (10Sophivorus) 05Open→03Resolved a:03Sophivorus ProveIt is already localized (translated) to Hebrew. It's not enabled on the Hebrew Wikipedia yet, but it's up to the Hebrew community to do it. This task was useful because Heb... [19:27:22] 10ProveIt-Gadget: Support for right-to-left languages - https://phabricator.wikimedia.org/T148339 (10Sophivorus) [19:27:42] (03CR) 10jerkins-bot: [V: 04-1] Convert FileBackendGroup to service [core] - 10https://gerrit.wikimedia.org/r/531486 (owner: 10simetrical) [19:28:05] (03CR) 10jerkins-bot: [V: 04-1] Convert FileBackendGroup to service [core] - 10https://gerrit.wikimedia.org/r/531486 (owner: 10simetrical) [19:28:29] 10MediaWiki-extensions-CollaborationKit: CreateCollaborationHub: creating pages when user language doesn't match wiki language results in breakages - https://phabricator.wikimedia.org/T223185 (10Isarra) Example: https://test.wikipedia.org/wiki/Wikipedia:Test_collab Per https://test.wikipedia.org/wiki/Special:Pr... [19:28:40] (03CR) 10jenkins-bot: Fix permission check on protection log [core] - 10https://gerrit.wikimedia.org/r/539536 (https://phabricator.wikimedia.org/T234017) (owner: 10Ammarpad) [19:29:15] (03CR) 10jerkins-bot: [V: 04-1] Dev: Reorganise action menu code [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/534892 (owner: 10Jdlrobson) [19:29:36] 10ProveIt-Gadget: Support for right-to-left languages - https://phabricator.wikimedia.org/T148339 (10Sophivorus) p:05Normal→03High Basic RTL support is already in place. But more careful support and attention to detail is still needed. [19:32:32] (03CR) 10jerkins-bot: [V: 04-1] Remove tests that were skipped for MCR-enabled schema [core] - 10https://gerrit.wikimedia.org/r/539609 (https://phabricator.wikimedia.org/T214308) (owner: 10Ppchelko) [19:33:58] (03CR) 10jerkins-bot: [V: 04-1] Remove tests that were skipped for MCR-enabled schema [core] - 10https://gerrit.wikimedia.org/r/539609 (https://phabricator.wikimedia.org/T214308) (owner: 10Ppchelko) [19:35:03] (03CR) 10jerkins-bot: [V: 04-1] POC: Minerva desktop runs desktop code not MobileFrontend code. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/495305 (https://phabricator.wikimedia.org/T171000) (owner: 10Jdlrobson) [19:35:10] 10WMF-Legal, 10Wikimedia-Site-requests, 10Patch-For-Review: Patroller right changes to ro.wp - https://phabricator.wikimedia.org/T234051 (10DannyS712) See, eg, `...For legal reasons, we require RFA or an RFA-identical process for access to certain tools (deleted revisions among them). I thank Robert for the... [19:35:22] 10MediaWiki-extensions-Translate, 10MediaWiki-extensions-TranslationNotifications, 10XTools, 10User-DannyS712: Create translation statistics view - https://phabricator.wikimedia.org/T233161 (10MusikAnimal) This is a fun idea! I take it this for #xtools ? Is all of the data already available to us (on the d... [19:35:47] 10WMF-Legal, 10Wikimedia-Site-requests, 10Patch-For-Review: Patroller right changes to ro.wp - https://phabricator.wikimedia.org/T234051 (10Urbanecm) I've emailed Wikimedia Legal directly, we'll see what they'll say. [19:36:48] (03CR) 10jerkins-bot: [V: 04-1] Remove tests that were skipped for MCR-enabled schema [core] - 10https://gerrit.wikimedia.org/r/539609 (https://phabricator.wikimedia.org/T214308) (owner: 10Ppchelko) [19:39:04] (03PS13) 10Ppchelko: Convert FileBackendGroup to service [core] - 10https://gerrit.wikimedia.org/r/531486 (owner: 10simetrical) [19:39:57] (03PS3) 10Ppchelko: Remove tests that were skipped for MCR-enabled schema [core] - 10https://gerrit.wikimedia.org/r/539609 (https://phabricator.wikimedia.org/T214308) [19:40:18] 10Map-of-monuments: With all countries, Map of Monuments is very slow - https://phabricator.wikimedia.org/T234095 (10Urbanecm) [19:42:01] (03CR) 10jerkins-bot: [V: 04-1] Convert FileBackendGroup to service [core] - 10https://gerrit.wikimedia.org/r/531486 (owner: 10simetrical) [19:44:38] 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10ConfirmEdit (CAPTCHA extension), 10Parsoid, and 8 others: Missing licenses on enwiki - https://phabricator.wikimedia.org/T234086 (10MGChecker) Actually, there are enough extensions where there is no clear license information whatsoever, or the license... [19:45:50] (03CR) 10jerkins-bot: [V: 04-1] MainMenu is a controller not a View and server rendered [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/534888 (owner: 10Jdlrobson) [19:48:01] (03CR) 10Thiemo Kreuz (WMDE): "I don't really understand why this helper method is in the *unit* test base class. Do we plan to add similar methods for all kinds of mock" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/539604 (owner: 10Kosta Harlan) [19:49:37] 10MediaWiki-Special-pages: Optionally exclude subpages from Special:Allpages and Special:Prefixindex - https://phabricator.wikimedia.org/T9184 (10DannyS712) See also {T41659} [19:49:39] 10MediaWiki-Special-pages: Switch to filter out subpages from Special:UncategorizedPages - https://phabricator.wikimedia.org/T41659 (10DannyS712) See also {T9184} [19:52:51] 10MediaWiki-Special-pages: SpecialPages should be added to $wgNamespacesWithSubpages - https://phabricator.wikimedia.org/T71622 (10DannyS712) a:05Parent5446→03None Removing per lack of action The `Special` namespace should support subpages, so that, eg, https://en.wikipedia.org/wiki/Special:Version/License... [19:54:27] (03PS2) 10Jdlrobson: Curtail use of mw.mobileFrontend in Minerva [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/539605 [19:54:57] (03CR) 10jenkins-bot: Remove Revision::getRevisionText and gated pre-MCR schema access [core] - 10https://gerrit.wikimedia.org/r/538314 (https://phabricator.wikimedia.org/T198343) (owner: 10Ppchelko) [20:01:17] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "What a magnificent commit message. I do fully agree with everything being said." [core] - 10https://gerrit.wikimedia.org/r/525840 (https://phabricator.wikimedia.org/T121730) (owner: 10Krinkle) [20:01:40] 10LogoFunctions: $wgNamespaceLogos sets logos on wrong namespaces - https://phabricator.wikimedia.org/T234098 (10Isarra) [20:03:47] (03CR) 10jerkins-bot: [V: 04-1] Convert FileBackendGroup to service [core] - 10https://gerrit.wikimedia.org/r/531486 (owner: 10simetrical) [20:04:06] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Makes a lot of sense to me. I might merge this soon if nobody objects. Thanks a lot for working on this!" [skins/Vector] - 10https://gerrit.wikimedia.org/r/528480 (https://phabricator.wikimedia.org/T121730) (owner: 10Krinkle) [20:07:02] 10MediaWiki-Special-pages, 10UI-Standardization, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), and 3 others: Convert Special:Contributions to OOUI - https://phabricator.wikimedia.org/T117736 (10Johan) OK, made it shorter for ease of translation but tried to keep your explana... [20:11:56] (03CR) 10jerkins-bot: [V: 04-1] Convert FileBackendGroup to service [core] - 10https://gerrit.wikimedia.org/r/531486 (owner: 10simetrical) [20:14:22] 10Research: Make recommendations regarding understanding the gender balance of our editor population - https://phabricator.wikimedia.org/T234099 (10Isaac) [20:15:52] 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10ConfirmEdit (CAPTCHA extension), 10Parsoid, and 8 others: Missing licenses on enwiki - https://phabricator.wikimedia.org/T234086 (10Nikerabbit) ULS has clear license information. Core doesn't seem to support multiple licenses. [20:16:55] (03PS1) 10Robert Vogel: Add "overrides" configuration for ExtensionAttributeBasedRegistry [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/539616 [20:18:27] 10Phabricator, 10Operations, 10Traffic, 10Release-Engineering-Team (Development services), and 2 others: Prepare Phame to support heavy traffic for a Tech Department blog - https://phabricator.wikimedia.org/T226044 (10greg) >>! In T226044#5527864, @CDanis wrote: > Just curious -- what's the expected timefr... [20:19:23] 10MediaWiki-Core-Testing, 10MediaWiki-ResourceLoader, 10Performance-Team, 10patch-welcome: MediaWiki structure tests do not validate ResourceLoaderImageModule "images" file existence - https://phabricator.wikimedia.org/T231430 (10hashar) [20:19:36] (03CR) 10jerkins-bot: [V: 04-1] Curtail use of mw.mobileFrontend in Minerva [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/539605 (owner: 10Jdlrobson) [20:22:14] (03Merged) 10jenkins-bot: resourceloader: Add type hints for type ResourceLoaderContext [core] - 10https://gerrit.wikimedia.org/r/539444 (owner: 10Fomafix) [20:24:15] 10GrowthExperiments, 10Product-Analytics, 10Growth-Team (Current Sprint): Deploy EditorJourney to Basque Wikipedia - https://phabricator.wikimedia.org/T232061 (10nettrom_WMF) [20:25:20] 10MediaWiki-Core-Testing, 10MediaWiki-ResourceLoader, 10Performance-Team, 10User-DannyS712: Skins: Tests should ensure that `ResourceModuleSkinStyles` all exist - https://phabricator.wikimedia.org/T234092 (10hashar) That is probably very similar to T231430. The test should be written in `mediawiki/core` a... [20:25:44] 10MediaWiki-Core-Testing, 10MediaWiki-ResourceLoader, 10Performance-Team, 10patch-welcome: MediaWiki structure tests do not validate ResourceLoaderImageModule "images" file existence - https://phabricator.wikimedia.org/T231430 (10hashar) A similar one: {T234092} [20:26:44] 10GrowthExperiments, 10Growth-Team (Current Sprint): Deploy Growth features to Basque Wikipedia - https://phabricator.wikimedia.org/T232060 (10nettrom_WMF) [20:26:46] 10GrowthExperiments, 10Product-Analytics, 10Growth-Team (Current Sprint): Deploy EditorJourney to Basque Wikipedia - https://phabricator.wikimedia.org/T232061 (10nettrom_WMF) 05Open→03Resolved Verified that the obfuscated namespaces are indeed obfuscated, and that the others are not. We don't have any da... [20:27:33] (03CR) 10Krinkle: selenium: Support passing args to 'npm run selenium' (032 comments) [core] - 10https://gerrit.wikimedia.org/r/538307 (owner: 10Krinkle) [20:27:44] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/539444 (owner: 10Fomafix) [20:32:17] 10MediaWiki-Core-Testing, 10MediaWiki-ResourceLoader, 10Performance-Team, 10User-DannyS712, 10patch-welcome: Skins: Tests should ensure that `ResourceModuleSkinStyles` all exist - https://phabricator.wikimedia.org/T234092 (10Krinkle) p:05Triage→03Normal There is already a structure test for the exist... [20:33:14] 10MediaWiki-Core-Testing, 10MediaWiki-ResourceLoader, 10Performance-Team, 10User-DannyS712, 10patch-welcome: Structure test for resource module should also validate conditional skin styles and language scripts - https://phabricator.wikimedia.org/T234092 (10Krinkle) [20:39:59] 10CPT Initiatives (OAuth 2.0), 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review: Admin removes client - https://phabricator.wikimedia.org/T229506 (10kchapman) [20:40:18] 10CPT Initiatives (OAuth 2.0), 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review: Admin adds new client - https://phabricator.wikimedia.org/T229505 (10kchapman) [20:46:14] (03CR) 10jenkins-bot: resourceloader: Add type hints for type ResourceLoaderContext [core] - 10https://gerrit.wikimedia.org/r/539444 (owner: 10Fomafix) [20:48:20] (03Merged) 10jenkins-bot: resourceloader: Add $context to static functions in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/535266 (https://phabricator.wikimedia.org/T229311) (owner: 10Fomafix) [20:48:23] (03Merged) 10jenkins-bot: Call getDeprecationInformation with $context [extensions/ExtJSBase] - 10https://gerrit.wikimedia.org/r/535909 (owner: 10Fomafix) [20:48:25] (03Merged) 10jenkins-bot: Don't show option to enqueue main page [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539584 (https://phabricator.wikimedia.org/T234073) (owner: 10DannyS712) [20:48:53] 10ProveIt-Gadget: Fix minor lint issues in ProveIt CSS - https://phabricator.wikimedia.org/T234101 (10Sophivorus) [20:49:03] 10ProveIt-Gadget: Fix minor lint issues in ProveIt CSS - https://phabricator.wikimedia.org/T234101 (10Sophivorus) p:05Triage→03Normal [20:51:25] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: In the news and On this day cards are not available in Ukrainian on the Android Wikipedia app - https://phabricator.wikimedia.org/T234102 (10Amire80) [20:53:31] (03CR) 10jenkins-bot: Don't show option to enqueue main page [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539584 (https://phabricator.wikimedia.org/T234073) (owner: 10DannyS712) [20:53:49] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/535266 (https://phabricator.wikimedia.org/T229311) (owner: 10Fomafix) [20:58:24] (03PS3) 10Krinkle: selenium: Support passing args to 'npm run selenium' [core] - 10https://gerrit.wikimedia.org/r/538307 [20:58:37] (03Merged) 10jenkins-bot: .pipeline/config.yaml: rename dev stage to publish [core] - 10https://gerrit.wikimedia.org/r/539589 (https://phabricator.wikimedia.org/T218360) (owner: 10Brennen Bearnes) [20:58:41] (03Merged) 10jenkins-bot: Fix Recent Changes Comment alignment on deleted pages [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/539577 (https://phabricator.wikimedia.org/T232955) (owner: 10Nray) [20:58:43] (03CR) 10jerkins-bot: [V: 04-1] build: Lower default Karma logLevel during local development [core] - 10https://gerrit.wikimedia.org/r/538921 (owner: 10Krinkle) [20:58:46] (03Merged) 10jenkins-bot: Fix typo in skin.json ResourceModuleSkinStyles [skins/Vector] - 10https://gerrit.wikimedia.org/r/539600 (https://phabricator.wikimedia.org/T234003) (owner: 10DannyS712) [20:58:48] (03Merged) 10jenkins-bot: Restrict the MobileFormatter to certain pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/539213 (https://phabricator.wikimedia.org/T232690) (owner: 10Jdlrobson) [20:59:22] (03CR) 10Krinkle: "Updated to incorporate the fixes. I've kept it intentionally minimal because this will get copied around and would get very robotic if we " [core] - 10https://gerrit.wikimedia.org/r/538307 (owner: 10Krinkle) [20:59:34] (03CR) 10DannyS712: "> Starting gate-and-submit jobs." [skins/Vector] - 10https://gerrit.wikimedia.org/r/539600 (https://phabricator.wikimedia.org/T234003) (owner: 10DannyS712) [20:59:54] (03CR) 10DannyS712: "> > Starting gate-and-submit jobs." [skins/Vector] - 10https://gerrit.wikimedia.org/r/539600 (https://phabricator.wikimedia.org/T234003) (owner: 10DannyS712) [21:01:38] 10MediaWiki-Core-Testing, 10MediaWiki-ResourceLoader, 10Performance-Team, 10patch-welcome: Structure test to validate existence of ResourceLoaderImageModule "images" files - https://phabricator.wikimedia.org/T231430 (10Krinkle) [21:03:02] (03CR) 10Daniel Kinzler: [C: 03+2] Remove tests that were skipped for MCR-enabled schema [core] - 10https://gerrit.wikimedia.org/r/539609 (https://phabricator.wikimedia.org/T214308) (owner: 10Ppchelko) [21:03:36] (03CR) 10jenkins-bot: Fix Recent Changes Comment alignment on deleted pages [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/539577 (https://phabricator.wikimedia.org/T232955) (owner: 10Nray) [21:04:36] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/539589 (https://phabricator.wikimedia.org/T218360) (owner: 10Brennen Bearnes) [21:09:05] 10Developer-Advocacy (Jul-Sep 2019): Dedicated Google Code-in (GCI) communication channel for students, mentors and admins? - https://phabricator.wikimedia.org/T200782 (10bd808) @Aklapper On Telegram, `@wikimediagci` is a [[https://telegram.org/faq_channels#q-what-39s-a-channel|channel]] which means that is a me... [21:10:44] (03CR) 10jenkins-bot: resourceloader: Add $context to static functions in ResourceLoader [core] - 10https://gerrit.wikimedia.org/r/535266 (https://phabricator.wikimedia.org/T229311) (owner: 10Fomafix) [21:13:53] 10WMF-Legal, 10Wikimedia-Site-requests, 10Patch-For-Review: Patroller right changes to ro.wp - https://phabricator.wikimedia.org/T234051 (10Strainu) As far as I understand from [[https://www.mediawiki.org/wiki/Manual:User_rights|docs]] and [[https://phabricator.wikimedia.org/source/mediawiki/browse/master/in... [21:14:32] (03PS6) 10BPirkle: Add optional serialization_type and hmac_key param values to RESTBagOStuff [core] - 10https://gerrit.wikimedia.org/r/539382 (https://phabricator.wikimedia.org/T233963) [21:14:36] (03PS1) 10DannyS712: API: Don't log (un)reviewing if state doesn't change [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539624 (https://phabricator.wikimedia.org/T234074) [21:17:46] (03CR) 10jenkins-bot: Restrict the MobileFormatter to certain pages [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/539213 (https://phabricator.wikimedia.org/T232690) (owner: 10Jdlrobson) [21:21:52] (03PS2) 10DannyS712: API: Don't log (un)reviewing if state doesn't change [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539624 (https://phabricator.wikimedia.org/T234074) [21:27:20] 10GrowthExperiments-Homepage, 10NewcomerTasks 1.0 , 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01): Newcomer tasks: welcome survey changes - https://phabricator.wikimedia.org/T232400 (10Etonkovidova) The text changes are in place. For @MMiller_WMF review. (1) On betalabs I se... [21:28:22] 10MobileFrontend, 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): [AMC] Summary in recent changes misaligned - https://phabricator.wikimedia.org/T232955 (10Zoranzoki21) {F30486913} Much better 🙂 [21:31:45] (03CR) 10jenkins-bot: .pipeline/config.yaml: rename dev stage to publish [core] - 10https://gerrit.wikimedia.org/r/539589 (https://phabricator.wikimedia.org/T218360) (owner: 10Brennen Bearnes) [21:32:50] 10Wikimedia-General-or-Unknown: The usual WMF HTTP 500 error page is not displayed in the case of unhandled exceptions - https://phabricator.wikimedia.org/T112845 (10Krinkle) 05Open→03Declined A lot has changed in 2015. For the most part cases like these are covered, and they do always return HTTP 500 now.... [21:32:54] 10MediaWiki-Special-pages, 10Patch-For-Review, 10Regression, 10Wikimedia-production-error: Special:WhatLinksHere with "Media" namespace URLs throws an exception (HTTP 500) - https://phabricator.wikimedia.org/T110878 (10Krinkle) [21:33:27] 10WMF-Legal, 10Wikimedia-Site-requests, 10Patch-For-Review: Patroller right changes to ro.wp - https://phabricator.wikimedia.org/T234051 (10Strainu) [21:33:37] 10WMF-Legal, 10Wikimedia-Site-requests, 10Patch-For-Review: Patroller right changes to ro.wp - https://phabricator.wikimedia.org/T234051 (10Strainu) [21:34:43] (03Merged) 10jenkins-bot: Remove tests that were skipped for MCR-enabled schema [core] - 10https://gerrit.wikimedia.org/r/539609 (https://phabricator.wikimedia.org/T214308) (owner: 10Ppchelko) [21:39:38] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/539609 (https://phabricator.wikimedia.org/T214308) (owner: 10Ppchelko) [21:41:48] (03CR) 10BPirkle: Add optional serialization_type and hmac_key param values to RESTBagOStuff (031 comment) [core] - 10https://gerrit.wikimedia.org/r/539382 (https://phabricator.wikimedia.org/T233963) (owner: 10BPirkle) [21:50:35] 10Thumbor: HTTP 500 error when generating 6000px wide thumbnail of a 6912px wide and 12.5MB JPEG file - https://phabricator.wikimedia.org/T38166 (10Zoranzoki21) This is same as T200313, closing as duplicate. [21:50:43] 10Thumbor: HTTP 500 error when generating 6000px wide thumbnail of a 6912px wide and 12.5MB JPEG file - https://phabricator.wikimedia.org/T38166 (10Zoranzoki21) [21:51:31] (03PS3) 10DannyS712: API: Don't log (un)reviewing if state doesn't change [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539624 (https://phabricator.wikimedia.org/T234074) [21:51:33] 10Mathe für Nicht-Freaks: Artikel "Existenz einer Fortsetzung: äußere Maße und Messbarkeit" - https://phabricator.wikimedia.org/T234105 (10Weltkaefer) [21:52:23] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10UploadWizard, and 2 others: Uploadstash errors (tracking) - https://phabricator.wikimedia.org/T85568 (10Krinkle) [21:52:46] (03CR) 10jerkins-bot: [V: 04-1] API: Don't log (un)reviewing if state doesn't change [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539624 (https://phabricator.wikimedia.org/T234074) (owner: 10DannyS712) [21:54:41] 10Mathe für Nicht-Freaks: Artikel "Inhalte auf Mengenringen" - https://phabricator.wikimedia.org/T234106 (10Weltkaefer) [21:55:34] (03CR) 10jerkins-bot: [V: 04-1] API: Don't log (un)reviewing if state doesn't change [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539624 (https://phabricator.wikimedia.org/T234074) (owner: 10DannyS712) [21:57:25] (03PS4) 10DannyS712: API: Alter behaviour if state doesn't change instead of proceeding [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/539624 (https://phabricator.wikimedia.org/T234074) [21:58:13] (03CR) 10jenkins-bot: Remove tests that were skipped for MCR-enabled schema [core] - 10https://gerrit.wikimedia.org/r/539609 (https://phabricator.wikimedia.org/T214308) (owner: 10Ppchelko) [21:59:59] (03CR) 10Krinkle: [C: 03+2] ""wdio: Chrome failed to start"" [core] - 10https://gerrit.wikimedia.org/r/538921 (owner: 10Krinkle) [22:00:10] (03CR) 10Krinkle: [C: 03+2] build: Lower default Karma logLevel during local development [core] - 10https://gerrit.wikimedia.org/r/538921 (owner: 10Krinkle) [22:03:43] 10Mathe für Nicht-Freaks: Artikel "Stetige Inhalte auf Sigma-Ringen" - https://phabricator.wikimedia.org/T234107 (10Weltkaefer) [22:09:03] 10GrowthExperiments, 10Product-Analytics, 10Growth-Team (Current Sprint): Deploy Help Panel to Basque Wikipedia - https://phabricator.wikimedia.org/T233065 (10nettrom_WMF) [22:09:32] (03CR) 10Krinkle: selenium: Only load 'sauce' service when needed (031 comment) [core] - 10https://gerrit.wikimedia.org/r/538309 (owner: 10Krinkle) [22:12:10] (03PS1) 10Krinkle: selenium: Restore sauce user/key configuration for wdio [core] - 10https://gerrit.wikimedia.org/r/539632 [22:12:18] (03CR) 10Krinkle: "Ref https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/539632" [core] - 10https://gerrit.wikimedia.org/r/538309 (owner: 10Krinkle) [22:13:10] 10GrowthExperiments, 10Product-Analytics, 10Growth-Team (Current Sprint): Deploy Help Panel to Basque Wikipedia - https://phabricator.wikimedia.org/T233065 (10nettrom_WMF) @Mayakp.wiki has led the QA work on this, thanks for helping out! Data is flowing in and users are opening the Help Panel, but so far th... [22:13:50] (03CR) 10Krinkle: [C: 03+2] tests: Replace PHPUnit's loose assertEquals(null) with assertNull() [core] - 10https://gerrit.wikimedia.org/r/537440 (owner: 10Thiemo Kreuz (WMDE)) [22:16:17] (03CR) 10Krinkle: "might have something to do with "has" and "Object." being used nearby. Brings back memory of code reviews upstream jquery that were basica" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/538926 (owner: 10Fomafix) [22:18:29] (03PS3) 10Krinkle: startup: Use Object.create( null ) instead of {} for packageExports [core] - 10https://gerrit.wikimedia.org/r/538926 (owner: 10Fomafix) [22:18:53] (03PS2) 10Krinkle: Mark mediawiki.page.watch.ajax as targetable to mobile [core] - 10https://gerrit.wikimedia.org/r/539355 (owner: 10Jdlrobson) [22:19:08] (03CR) 10Krinkle: [C: 03+1] "de-based from parent (presumed unintentional)." [core] - 10https://gerrit.wikimedia.org/r/539355 (owner: 10Jdlrobson) [22:19:11] 10MediaWiki-extensions-Other, 10User-TheSandDoctor: Memento needs 'editToken' replaced with 'csrfToken' - https://phabricator.wikimedia.org/T233554 (10TheSandDoctor) 05Open→03Stalled [22:19:14] 10MediaWiki-ResourceLoader, 10Performance-Team, 10MW-1.34-notes (1.34.0-wmf.24; 2019-09-24), 10Technical-Debt (Deprecation), 10User-TheSandDoctor: Remove 'editToken' from mw.user.tokens (deprecated for 'csrfToken') - https://phabricator.wikimedia.org/T233442 (10TheSandDoctor) [22:23:55] (03Merged) 10jenkins-bot: build: Lower default Karma logLevel during local development [core] - 10https://gerrit.wikimedia.org/r/538921 (owner: 10Krinkle) [22:23:59] (03PS4) 10SBassett: PHP-Security-Tools [wikimedia/security/tooling] - 10https://gerrit.wikimedia.org/r/539205 (https://phabricator.wikimedia.org/T221477) [22:26:09] (03CR) 10Krinkle: Parser: Add Title type hints (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533002 (owner: 10Fomafix) [22:28:51] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/538921 (owner: 10Krinkle) [22:37:50] (03CR) 10Krinkle: "There appears to be some variability, not exactly sure why. Possibly due to date headers, which can always vary by 1 or 2 bytes." [core] - 10https://gerrit.wikimedia.org/r/538926 (owner: 10Fomafix) [22:38:47] (03PS4) 10Krinkle: startup: Use Object.create( null ) instead of {} for packageExports [core] - 10https://gerrit.wikimedia.org/r/538926 (owner: 10Fomafix) [22:43:14] (03Merged) 10jenkins-bot: tests: Replace PHPUnit's loose assertEquals(null) with assertNull() [core] - 10https://gerrit.wikimedia.org/r/537440 (owner: 10Thiemo Kreuz (WMDE)) [22:48:11] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/537440 (owner: 10Thiemo Kreuz (WMDE)) [22:48:22] (03CR) 10jenkins-bot: build: Lower default Karma logLevel during local development [core] - 10https://gerrit.wikimedia.org/r/538921 (owner: 10Krinkle) [22:51:58] 10MediaWiki-extensions-Other, 10User-TheSandDoctor: Memento needs 'editToken' replaced with 'csrfToken' - https://phabricator.wikimedia.org/T233554 (10Masumrezarock100) @TheSandDoctor maybe you can pull a request on GitHub. [23:05:19] 10MobileFrontend, 10MW-1.34-notes (1.34.0-wmf.25; 2019-10-01), 10Performance-Team (Radar), 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Skip Expensive MobileFormatter Transformations On Pages With Extremely High Image/Heading counts - https://phabricator.wikimedia.org/T232690 (10Jdlrobson) [23:08:03] (03CR) 10PipelineBot: "pipeline-dashboard: mediawiki-pipeline-publish" [core] - 10https://gerrit.wikimedia.org/r/539355 (owner: 10Jdlrobson) [23:12:10] (03PS2) 10VolkerE: Improve print LESS variable setting and handling [skins/Vector] - 10https://gerrit.wikimedia.org/r/539415 [23:12:12] (03CR) 10jenkins-bot: tests: Replace PHPUnit's loose assertEquals(null) with assertNull() [core] - 10https://gerrit.wikimedia.org/r/537440 (owner: 10Thiemo Kreuz (WMDE)) [23:27:48] (03CR) 10Krinkle: "Okay, so I did a very basic memory measure using window.performance.memory in Chrome." [core] - 10https://gerrit.wikimedia.org/r/538926 (owner: 10Fomafix) [23:36:51] (03CR) 10jenkins-bot: Mark mediawiki.page.watch.ajax as targetable to mobile [core] - 10https://gerrit.wikimedia.org/r/539355 (owner: 10Jdlrobson) [23:41:03] (03CR) 10VolkerE: [C: 03+2] "Per @Krinkle above." [skins/Vector] - 10https://gerrit.wikimedia.org/r/539415 (owner: 10VolkerE)