[00:00:54] (03PS1) 10SLF bot: Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/536753 [00:01:21] (03CR) 10Reedy: [C: 03+2] Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/536753 (owner: 10SLF bot) [00:06:50] (03Merged) 10jenkins-bot: Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/536753 (owner: 10SLF bot) [00:08:27] (03CR) 10jenkins-bot: Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/536753 (owner: 10SLF bot) [00:09:47] (03CR) 10jenkins-bot: Integrate module 'jquery.checkboxShiftClick' into 'mediawiki.page.ready' [core] - 10https://gerrit.wikimedia.org/r/536543 (https://phabricator.wikimedia.org/T232688) (owner: 10Fomafix) [00:21:07] 04(no projects): Showing "No change in size" wrongly in Minerva diff page on Wikimedia Commons - https://phabricator.wikimedia.org/T232941 (10Masumrezarock100) [00:23:10] 10MobileFrontend, 10MinervaNeue: Showing "No change in size" wrongly in Minerva diff page on Wikimedia Commons - https://phabricator.wikimedia.org/T232941 (10Reedy) [00:25:39] 10MobileFrontend, 10MinervaNeue: Showing "No change in size" wrongly in Minerva diff page on Wikimedia Commons - https://phabricator.wikimedia.org/T232941 (10Masumrezarock100) [00:27:43] 10MobileFrontend, 10MinervaNeue: Showing "No change in size" wrongly in Minerva diff page on Wikimedia Commons - https://phabricator.wikimedia.org/T232941 (10Masumrezarock100) [00:31:48] 10MobileFrontend, 10MinervaNeue: Showing "No change in size" wrongly on Minerva diff pages on Wikimedia Commons - https://phabricator.wikimedia.org/T232941 (10Masumrezarock100) [00:39:33] (03CR) 10Jack Phoenix: "Tiny nitpicks inline, basically documentation/code style things. Actual code looks fine and seems to work across a wide array of skins I t" (037 comments) [extensions/LogoFunctions] - 10https://gerrit.wikimedia.org/r/536718 (https://phabricator.wikimedia.org/T208342) (owner: 10Isarra) [00:46:10] 10MobileFrontend, 10MinervaNeue: Showing "No change in size" wrongly on Minerva diff pages on Wikimedia Commons - https://phabricator.wikimedia.org/T232941 (10Masumrezarock100) Note: This bug is not present on the diff pages on English Wikipedia. It is showing as usual. (eg, https://en.m.wikipedia.org/wiki/Spe... [00:48:56] 10MediaWiki-History-and-Diffs, 10MobileFrontend, 10MinervaNeue, 10Mobile: Showing "No change in size" wrongly on Minerva diff pages on Wikimedia Commons - https://phabricator.wikimedia.org/T232941 (10Masumrezarock100) [01:01:37] 10ParserFunctions: Wrong subst-if output - https://phabricator.wikimedia.org/T232714 (10A2093064) 05Open→03Invalid @Dinoguy1000 Thanks for the information. It seems that "yes" is the expected result. So I closed this task. [02:06:10] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Performance-Team (Radar): Reduce module registration overhead from CentralNotice - https://phabricator.wikimedia.org/T221805 (10Krinkle) [02:18:28] (03PS6) 10Isarra: Reimplement extension using plain CSS smashed onto the page [extensions/LogoFunctions] - 10https://gerrit.wikimedia.org/r/536718 (https://phabricator.wikimedia.org/T208342) [02:42:28] 10InternetArchiveBot: IABot makes edits that cause new errors in edited articles - https://phabricator.wikimedia.org/T232922 (10Mikeblas) Considering the "ARIA News 28 Oct" reference in the "ARIA Music Awards of 2014" article, there was previously no duplicate reference. This can be seen by viewing [[ https://e... [04:09:03] (03PS1) 10DannyS712: Allow Blockautopromote duration to be configured for wikis. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536755 (https://phabricator.wikimedia.org/T231756) [04:20:29] (03PS2) 10DannyS712: Allow Blockautopromote duration to be configured for wikis. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536755 (https://phabricator.wikimedia.org/T231756) [04:22:30] (03CR) 10jerkins-bot: [V: 04-1] Allow Blockautopromote duration to be configured for wikis. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536755 (https://phabricator.wikimedia.org/T231756) (owner: 10DannyS712) [04:23:02] (03CR) 10DannyS712: [C: 03+1] "> > I tried to modify the commit message to be clearer, and to note" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536662 (https://phabricator.wikimedia.org/T232881) (owner: 10Daimona Eaytoy) [04:26:28] 10Readers-Web-Backlog, 10Wikimedia-production-error: Logout button on mobile web misaligned - https://phabricator.wikimedia.org/T232943 (10Force_Radical) [04:31:20] (03CR) 10jerkins-bot: [V: 04-1] Allow Blockautopromote duration to be configured for wikis. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536755 (https://phabricator.wikimedia.org/T231756) (owner: 10DannyS712) [04:36:07] (03PS3) 10DannyS712: Allow Blockautopromote duration to be configured for wikis. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536755 (https://phabricator.wikimedia.org/T231756) [04:37:11] (03PS4) 10DannyS712: Allow Blockautopromote duration to be configured for wikis. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536755 (https://phabricator.wikimedia.org/T231756) [04:55:35] (03CR) 10jerkins-bot: [V: 04-1] Allow Blockautopromote duration to be configured for wikis. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536755 (https://phabricator.wikimedia.org/T231756) (owner: 10DannyS712) [05:03:10] (03CR) 10DannyS712: "Tests are failing due to failing tests with CentralAuth, fixing separately" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536755 (https://phabricator.wikimedia.org/T231756) (owner: 10DannyS712) [05:05:50] 10MediaWiki-extensions-CentralAuth, 10AbuseFilter, 10User-DannyS712: CentralAuth hooks function `onAbuseFilterShouldFilterAction` should be static - https://phabricator.wikimedia.org/T232945 (10DannyS712) [05:06:14] (03PS1) 10DannyS712: Make `onAbuseFilterShouldFilterAction` static [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/536756 (https://phabricator.wikimedia.org/T212082) [05:06:47] (03PS2) 10DannyS712: Make `onAbuseFilterShouldFilterAction` static [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/536756 (https://phabricator.wikimedia.org/T212082) [05:06:52] (03PS3) 10DannyS712: Make `onAbuseFilterShouldFilterAction` static [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/536756 (https://phabricator.wikimedia.org/T212082) [05:07:30] 10MediaWiki-extensions-CentralAuth, 10AbuseFilter, 10GlobalRename, 10Patch-For-Review, 10User-DannyS712: CentralAuth hooks function `onAbuseFilterShouldFilterAction` should be static - https://phabricator.wikimedia.org/T232945 (10DannyS712) [05:27:08] (03CR) 10Robert Vogel: [C: 03+2] addCategory fix [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/536735 (owner: 10AlexPinchuk) [05:27:17] (03PS1) 10Robert Vogel: addCategory fix [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/536757 [05:27:21] (03CR) 10Robert Vogel: [C: 03+2] addCategory fix [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/536757 (owner: 10Robert Vogel) [05:27:40] (03CR) 10Robert Vogel: [C: 03+2] addCategory fix [extensions/BlueSpiceCategoryManager] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/536749 (owner: 10AlexPinchuk) [05:27:47] (03PS1) 10Robert Vogel: addCategory fix [extensions/BlueSpiceCategoryManager] - 10https://gerrit.wikimedia.org/r/536758 [05:27:50] (03CR) 10Robert Vogel: [C: 03+2] addCategory fix [extensions/BlueSpiceCategoryManager] - 10https://gerrit.wikimedia.org/r/536758 (owner: 10Robert Vogel) [05:31:38] (03Merged) 10jenkins-bot: addCategory fix [extensions/BlueSpiceCategoryManager] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/536749 (owner: 10AlexPinchuk) [05:31:55] (03Merged) 10jenkins-bot: addCategory fix [extensions/BlueSpiceCategoryManager] - 10https://gerrit.wikimedia.org/r/536758 (owner: 10Robert Vogel) [05:32:39] (03CR) 10jerkins-bot: [V: 04-1] addCategory fix [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/536757 (owner: 10Robert Vogel) [05:33:16] (03CR) 10jerkins-bot: [V: 04-1] addCategory fix [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/536757 (owner: 10Robert Vogel) [05:33:18] (03CR) 10jerkins-bot: [V: 04-1] addCategory fix [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/536735 (owner: 10AlexPinchuk) [05:43:43] 10InternetArchiveBot: IABot makes edits that cause new errors in edited articles - https://phabricator.wikimedia.org/T232922 (10Cirdan) This is now at least the third bug introduced by the "fix" of T224344. Can we please revert that change and let IABot deal with dead links only? Fixing strange parser behavior i... [05:47:29] (03PS3) 10Isarra: Align form stuff better [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/536366 (https://phabricator.wikimedia.org/T214105) [05:49:49] (03PS3) 10Isarra: Properly register tracking categories in extension.json [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/536665 [05:50:08] (03PS4) 10Isarra: Reuse skin toc styles and simplify hubpage and subpage tocs [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/536368 (https://phabricator.wikimedia.org/T214123) [06:08:12] (03PS3) 10Isarra: Render unnecessarily large 2x logos to ensure we support unnecessarily high-res devices [skins/Timeless] - 10https://gerrit.wikimedia.org/r/536331 (https://phabricator.wikimedia.org/T232540) [06:09:01] (03CR) 10Isarra: [C: 03+2] Reuse skin toc styles and simplify hubpage and subpage tocs [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/536368 (https://phabricator.wikimedia.org/T214123) (owner: 10Isarra) [06:09:19] (03CR) 10Isarra: [C: 03+2] Properly register tracking categories in extension.json [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/536665 (owner: 10Isarra) [06:09:33] (03CR) 10Isarra: [C: 03+2] Align form stuff better [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/536366 (https://phabricator.wikimedia.org/T214105) (owner: 10Isarra) [06:19:02] (03Merged) 10jenkins-bot: Reuse skin toc styles and simplify hubpage and subpage tocs [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/536368 (https://phabricator.wikimedia.org/T214123) (owner: 10Isarra) [06:19:04] (03Merged) 10jenkins-bot: Properly register tracking categories in extension.json [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/536665 (owner: 10Isarra) [06:22:41] (03CR) 10jenkins-bot: Reuse skin toc styles and simplify hubpage and subpage tocs [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/536368 (https://phabricator.wikimedia.org/T214123) (owner: 10Isarra) [06:24:30] (03CR) 10jenkins-bot: Properly register tracking categories in extension.json [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/536665 (owner: 10Isarra) [06:28:11] (03Merged) 10jenkins-bot: Align form stuff better [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/536366 (https://phabricator.wikimedia.org/T214105) (owner: 10Isarra) [06:30:37] (03CR) 10jenkins-bot: Align form stuff better [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/536366 (https://phabricator.wikimedia.org/T214105) (owner: 10Isarra) [06:32:45] (03Abandoned) 10MaxSem: Disable Argon2 support by default [core] - 10https://gerrit.wikimedia.org/r/520154 (owner: 10MaxSem) [06:33:11] (03CR) 10MaxSem: [C: 04-1] "I need to verify one thing..." [core] - 10https://gerrit.wikimedia.org/r/536730 (https://phabricator.wikimedia.org/T232694) (owner: 10MaxSem) [06:37:17] (03CR) 10MaxSem: [C: 03+2] Revision: Inject Logger instead of LoggerSpi [core] - 10https://gerrit.wikimedia.org/r/535332 (owner: 10Krinkle) [06:59:20] (03Merged) 10jenkins-bot: Revision: Inject Logger instead of LoggerSpi [core] - 10https://gerrit.wikimedia.org/r/535332 (owner: 10Krinkle) [07:08:36] (03CR) 10jenkins-bot: Revision: Inject Logger instead of LoggerSpi [core] - 10https://gerrit.wikimedia.org/r/535332 (owner: 10Krinkle) [07:29:35] 10InternetArchiveBot: IABot makes edits that cause new errors in edited articles - https://phabricator.wikimedia.org/T232922 (10Cyberpower678) The deduping has been disabled. [07:41:05] (03PS5) 10AlexPinchuk: addCategory fix [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/536735 [07:58:52] (03CR) 10Daimona Eaytoy: [C: 03+2] "Dang, thanks" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/536756 (https://phabricator.wikimedia.org/T212082) (owner: 10DannyS712) [07:59:27] 10MediaWiki-extensions-CentralAuth, 10AbuseFilter, 10GlobalRename, 10Stewards-and-global-tools, and 3 others: Do not block page moves with AbuseFilter on LocalRenameJob page moves - https://phabricator.wikimedia.org/T212082 (10Daimona) [07:59:38] 10MediaWiki-extensions-CentralAuth, 10AbuseFilter, 10GlobalRename, 10User-DannyS712: CentralAuth hooks function `onAbuseFilterShouldFilterAction` should be static - https://phabricator.wikimedia.org/T232945 (10Daimona) 05Open→03Resolved [08:00:51] 10Accessibility, 10Continuous-Integration-Config, 10Upstream: Red-green in PHPUnit code coverage are hard to read - https://phabricator.wikimedia.org/T232915 (10Daimona) CC @Legoktm per comments at https://github.com/sebastianbergmann/php-code-coverage/issues/556. [08:03:24] (03Merged) 10jenkins-bot: Make `onAbuseFilterShouldFilterAction` static [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/536756 (https://phabricator.wikimedia.org/T212082) (owner: 10DannyS712) [08:05:39] (03CR) 10jenkins-bot: Make `onAbuseFilterShouldFilterAction` static [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/536756 (https://phabricator.wikimedia.org/T212082) (owner: 10DannyS712) [08:13:35] 10InternetArchiveBot: IABot makes edits that cause new errors in edited articles - https://phabricator.wikimedia.org/T232922 (10Cirdan) Thank you! [08:15:27] (03CR) 10AlexPinchuk: "recheck" [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/536735 (owner: 10AlexPinchuk) [08:15:32] (03CR) 10Daimona Eaytoy: [C: 04-1] Allow Blockautopromote duration to be configured for wikis. (034 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536755 (https://phabricator.wikimedia.org/T231756) (owner: 10DannyS712) [08:15:40] 10MediaWiki-extensions-WikimediaBadges, 10Wikidata, 10Wikimedia-Interwiki-links: Update the code behind the Wikimedia Commons link in the sidebar to use P910 and P1754 instead of P373 - https://phabricator.wikimedia.org/T232927 (10matej_suchanek) [08:16:12] (03CR) 10Daimona Eaytoy: [C: 03+2] "Failure was T232945, retrying" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/535169 (https://phabricator.wikimedia.org/T156096) (owner: 10Daimona Eaytoy) [08:19:08] (03CR) 10Daimona Eaytoy: "> > > I tried to modify the commit message to be clearer, and to note" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536662 (https://phabricator.wikimedia.org/T232881) (owner: 10Daimona Eaytoy) [08:21:20] (03CR) 10Daimona Eaytoy: [C: 04-1] "I've marked the unresolved comments from PS9. LGTM other than those" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/517740 (https://phabricator.wikimedia.org/T231636) (owner: 10Umherirrender) [08:26:59] (03PS4) 10Daimona Eaytoy: phan: Disable enable_class_alias_support [core] - 10https://gerrit.wikimedia.org/r/536327 (owner: 10Umherirrender) [08:27:42] (03CR) 10Daimona Eaytoy: [C: 03+2] "> Patch Set 4: Published edit on patch set 3." [core] - 10https://gerrit.wikimedia.org/r/536327 (owner: 10Umherirrender) [08:28:46] (03CR) 10Matěj Suchánek: "recheck" [core] - 10https://gerrit.wikimedia.org/r/406586 (https://phabricator.wikimedia.org/T152346) (owner: 10Matěj Suchánek) [08:36:40] (03Merged) 10jenkins-bot: Throw AFPUserVisibleExceptions for empty operands in CachingParser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/535169 (https://phabricator.wikimedia.org/T156096) (owner: 10Daimona Eaytoy) [08:36:57] (03CR) 10Umherirrender: "Sorry, I missed to publish my comments" (035 comments) [core] - 10https://gerrit.wikimedia.org/r/517740 (https://phabricator.wikimedia.org/T231636) (owner: 10Umherirrender) [08:40:32] 10Readers-Web-Backlog, 10Wikimedia-production-error: Logout button on mobile web misaligned - https://phabricator.wikimedia.org/T232943 (10Masumrezarock100) True, I've noticed it as well. Here's the screenshot of a page from Wikimedia Commons. {F30355655} [08:42:12] (03CR) 10jenkins-bot: Throw AFPUserVisibleExceptions for empty operands in CachingParser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/535169 (https://phabricator.wikimedia.org/T156096) (owner: 10Daimona Eaytoy) [08:49:57] (03CR) 10jerkins-bot: [V: 04-1] Separate log action for moves suppressing redirects [core] - 10https://gerrit.wikimedia.org/r/406586 (https://phabricator.wikimedia.org/T152346) (owner: 10Matěj Suchánek) [08:51:34] (03Merged) 10jenkins-bot: phan: Disable enable_class_alias_support [core] - 10https://gerrit.wikimedia.org/r/536327 (owner: 10Umherirrender) [08:52:53] (03PS3) 10Matěj Suchánek: Separate log action for moves suppressing redirects [core] - 10https://gerrit.wikimedia.org/r/406586 (https://phabricator.wikimedia.org/T152346) [08:54:17] (03CR) 10DannyS712: [C: 03+1] ""done"?" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536662 (https://phabricator.wikimedia.org/T232881) (owner: 10Daimona Eaytoy) [08:57:04] (03PS5) 10DannyS712: Allow Blockautopromote duration to be configured for wikis. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536755 (https://phabricator.wikimedia.org/T231756) [08:59:06] (03PS1) 10Daimona Eaytoy: title: Improve docs of get*URL() [core] - 10https://gerrit.wikimedia.org/r/536759 [09:03:55] (03CR) 10Daimona Eaytoy: [C: 04-1] phan: Enable PhanTypeMismatchArgument issue (033 comments) [core] - 10https://gerrit.wikimedia.org/r/517740 (https://phabricator.wikimedia.org/T231636) (owner: 10Umherirrender) [09:11:18] (03CR) 10jenkins-bot: phan: Disable enable_class_alias_support [core] - 10https://gerrit.wikimedia.org/r/536327 (owner: 10Umherirrender) [09:12:20] (03CR) 10jerkins-bot: [V: 04-1] Separate log action for moves suppressing redirects [core] - 10https://gerrit.wikimedia.org/r/406586 (https://phabricator.wikimedia.org/T152346) (owner: 10Matěj Suchánek) [09:12:49] (03PS1) 10Daimona Eaytoy: export: Align docs of close(Rename/Reopen) methods [core] - 10https://gerrit.wikimedia.org/r/536760 [09:12:51] (03CR) 10jerkins-bot: [V: 04-1] Separate log action for moves suppressing redirects [core] - 10https://gerrit.wikimedia.org/r/406586 (https://phabricator.wikimedia.org/T152346) (owner: 10Matěj Suchánek) [09:13:52] (03CR) 10Daimona Eaytoy: [C: 04-1] "I sent Ica9929fd50f31d8d5f0e29f7c60364086ea39ae5 for the export ones, it was another easy one :)" [core] - 10https://gerrit.wikimedia.org/r/517740 (https://phabricator.wikimedia.org/T231636) (owner: 10Umherirrender) [09:15:04] (03CR) 10Daimona Eaytoy: "> "done"?" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536662 (https://phabricator.wikimedia.org/T232881) (owner: 10Daimona Eaytoy) [09:20:38] (03CR) 10jenkins-bot: phan: Disable enable_class_alias_support [core] - 10https://gerrit.wikimedia.org/r/536327 (owner: 10Umherirrender) [09:28:23] (03CR) 10DannyS712: [C: 03+1] "Looks good to me" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/459818 (https://phabricator.wikimedia.org/T220791) (owner: 10Daimona Eaytoy) [09:36:55] (03PS5) 10D3r1ck01: OutputPage: Add visibility to various methods & do some micro-optimizations [core] - 10https://gerrit.wikimedia.org/r/536733 [09:39:00] (03CR) 10D3r1ck01: OutputPage: Add visibility to various methods & do some micro-optimizations (031 comment) [core] - 10https://gerrit.wikimedia.org/r/536733 (owner: 10D3r1ck01) [09:51:39] 10Wikimedia-Site-requests: Syncronize wmgExtraLanguageNames languages between Wikidata and Wikimedia Commons - https://phabricator.wikimedia.org/T230480 (104nn1l2) a:034nn1l2 [09:52:19] (03PS3) 10D3r1ck01: Rename ExtMobileFrontend.php to MobileFrontend.php like other extensions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/536739 [09:57:11] (03PS4) 10Aaron Schulz: filebackend: reduce unnecessary stat calls in FileBackend some cases [core] - 10https://gerrit.wikimedia.org/r/535682 [09:57:35] (03CR) 10Aaron Schulz: [C: 03+2] actions: Rename Doxygen group from "Action done on pages" to "Actions" [core] - 10https://gerrit.wikimedia.org/r/536709 (https://phabricator.wikimedia.org/T232104) (owner: 10Krinkle) [09:58:12] (03CR) 10jerkins-bot: [V: 04-1] filebackend: reduce unnecessary stat calls in FileBackend some cases [core] - 10https://gerrit.wikimedia.org/r/535682 (owner: 10Aaron Schulz) [09:58:44] (03CR) 10jerkins-bot: [V: 04-1] filebackend: reduce unnecessary stat calls in FileBackend some cases [core] - 10https://gerrit.wikimedia.org/r/535682 (owner: 10Aaron Schulz) [09:59:14] (03CR) 10jerkins-bot: [V: 04-1] filebackend: reduce unnecessary stat calls in FileBackend some cases [core] - 10https://gerrit.wikimedia.org/r/535682 (owner: 10Aaron Schulz) [09:59:23] (03CR) 10jerkins-bot: [V: 04-1] filebackend: reduce unnecessary stat calls in FileBackend some cases [core] - 10https://gerrit.wikimedia.org/r/535682 (owner: 10Aaron Schulz) [10:10:59] 10ContentTranslation, 10Language-Team (Language-2019-July-September): CX2: Uncaught TypeError: Cannot read property 'element' of null at VeCeCXTransclusionInlineNode.ve.ce.View.initialize (ve.ce.View.js?9c8a2:109) - https://phabricator.wikimedia.org/T205429 (10Petar.petkovic) I've tried reproducing this. Start... [10:11:24] (03CR) 10jerkins-bot: [V: 04-1] Rename ExtMobileFrontend.php to MobileFrontend.php like other extensions [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/536739 (owner: 10D3r1ck01) [10:13:18] 10MobileFrontend, 10MinervaNeue: Logout button on mobile web misaligned - https://phabricator.wikimedia.org/T232943 (10Aklapper) Removing #wikimedia-production-error (see its description) and #Readers-Web-Backlog (it's up to teams what they would like to have on their list) tags. Assuming this is about #mobile... [10:17:55] (03PS1) 10Iijima Yun: clientpool: Use PHP constants in SquidPurgeClient [core] - 10https://gerrit.wikimedia.org/r/536761 (https://phabricator.wikimedia.org/T29658) [10:18:20] 10Office-IT: Google group for #Wikimedia-Site-requests - https://phabricator.wikimedia.org/T232946 (10MarcoAurelio) [10:19:27] (03Merged) 10jenkins-bot: actions: Rename Doxygen group from "Action done on pages" to "Actions" [core] - 10https://gerrit.wikimedia.org/r/536709 (https://phabricator.wikimedia.org/T232104) (owner: 10Krinkle) [10:26:01] 10MediaWiki-User-login-and-signup, 10Technical-Debt (Deprecation): Deprecate and remove User::isSafeToLoad - https://phabricator.wikimedia.org/T128394 (10Tgr) >>! In T128394#5493527, @Krinkle wrote: > The main problem right now is our "current RequestContext" isn't explicitly instantiated, rather it magically... [10:33:49] (03CR) 10jenkins-bot: actions: Rename Doxygen group from "Action done on pages" to "Actions" [core] - 10https://gerrit.wikimedia.org/r/536709 (https://phabricator.wikimedia.org/T232104) (owner: 10Krinkle) [10:35:58] 10MediaWiki-User-preferences: Wiki user Preferences/User profile/Email options should, but currently not, conditioned on site settings - https://phabricator.wikimedia.org/T232937 (10Aklapper) Hi @Whelkmy, thanks for taking the time to report this and welcome to Wikimedia Phabricator! It would be very welcome i... [10:46:25] 10Design, 10Growth-Team, 10Notifications, 10WorkType-NewFunctionality: Let cross-wiki users set preferences for what types of notifications they see where - https://phabricator.wikimedia.org/T117670 (10Tacsipacsi) Use case #4 is possible with the Preferences option. Use case #2 is now also possible thanks... [10:56:23] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/536739 (owner: 10D3r1ck01) [10:58:31] 10MobileFrontend, 10Readers-Web-Backlog: Box for username/IP address in Special:Contributions doesn't fit in page on mobile - https://phabricator.wikimedia.org/T232926 (10Zoranzoki21) [11:02:10] 10MobileFrontend, 10MinervaNeue, 10User-Zoranzoki21: Logout button on mobile web misaligned - https://phabricator.wikimedia.org/T232943 (10Zoranzoki21) a:03Zoranzoki21 [11:03:25] (03CR) 10Matěj Suchánek: [C: 03+1] Prevent blocked users from using /revert (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536737 (https://phabricator.wikimedia.org/T232916) (owner: 10Daimona Eaytoy) [11:04:45] 10MobileFrontend, 10MinervaNeue, 10User-Zoranzoki21: Logout button on mobile web misaligned - https://phabricator.wikimedia.org/T232943 (10Zoranzoki21) I think this is good, right? {F30358858} Patch coming soon. [11:05:36] (03CR) 10Matěj Suchánek: [C: 03+2] Don't show the form for restoring autopromotion to unprivileged users [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536662 (https://phabricator.wikimedia.org/T232881) (owner: 10Daimona Eaytoy) [11:09:48] 10MobileFrontend, 10MinervaNeue, 10User-Zoranzoki21: Logout button on mobile web misaligned - https://phabricator.wikimedia.org/T232943 (10Zoranzoki21) BTW, I changed in console property in .mw-ui-icon:before which was top: 0 to top: initial but I can't find correct file where I should change this. Anyone to... [11:15:51] (03CR) 10Ladsgroup: [C: 03+2] mediawiki.page.ready: Avoid duplicate DOM query on logout click [core] - 10https://gerrit.wikimedia.org/r/536725 (owner: 10Krinkle) [11:19:11] (03CR) 10Ladsgroup: [C: 03+1] mediawiki.page.ready: Convert to packageFiles, remove jquery.checkboxShiftClick [core] - 10https://gerrit.wikimedia.org/r/536717 (owner: 10Krinkle) [11:21:09] (03CR) 10Daimona Eaytoy: Prevent blocked users from using /revert (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536737 (https://phabricator.wikimedia.org/T232916) (owner: 10Daimona Eaytoy) [11:21:21] (03PS2) 10Daimona Eaytoy: Prevent blocked users from using /revert [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536737 (https://phabricator.wikimedia.org/T232916) [11:21:55] 10MobileFrontend, 10MinervaNeue, 10User-Zoranzoki21: Logout button on mobile web misaligned - https://phabricator.wikimedia.org/T232943 (10Masumrezarock100) >>! In T232943#5493880, @Zoranzoki21 wrote: > I think this is good, right? > {F30358858} > > Patch coming soon. Yeah it is good. [11:22:30] (03CR) 10Matěj Suchánek: Split afl_filter in afl_filter_id and afl_global (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/459818 (https://phabricator.wikimedia.org/T220791) (owner: 10Daimona Eaytoy) [11:26:20] (03Merged) 10jenkins-bot: Don't show the form for restoring autopromotion to unprivileged users [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536662 (https://phabricator.wikimedia.org/T232881) (owner: 10Daimona Eaytoy) [11:27:30] 10MobileFrontend, 10MinervaNeue, 10Readers-Web-Backlog (Design): Logout button on mobile web misaligned - https://phabricator.wikimedia.org/T232943 (10Zoranzoki21) a:05Zoranzoki21→03None I will unassign this task from me because I can't make patch, but I will be still subscribed. [11:32:07] (03CR) 10jenkins-bot: Don't show the form for restoring autopromotion to unprivileged users [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536662 (https://phabricator.wikimedia.org/T232881) (owner: 10Daimona Eaytoy) [11:32:28] 10MediaWiki-General, 10CPT Initiatives (MCR), 10Documentation, 10Technical-Debt, 10User-Zoranzoki21: The "RevisionInsertComplete" hook is listed in documentation as deprecated but doesn't emit deprecation warnings yet - https://phabricator.wikimedia.org/T232877 (10Zoranzoki21) a:03Zoranzoki21 @Jdforres... [11:35:52] (03CR) 10Daimona Eaytoy: Split afl_filter in afl_filter_id and afl_global (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/459818 (https://phabricator.wikimedia.org/T220791) (owner: 10Daimona Eaytoy) [11:41:26] (03PS55) 10Daimona Eaytoy: Split afl_filter in afl_filter_id and afl_global [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/459818 (https://phabricator.wikimedia.org/T220791) [11:43:02] (03CR) 10Matěj Suchánek: [C: 03+2] Prevent blocked users from using /revert [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536737 (https://phabricator.wikimedia.org/T232916) (owner: 10Daimona Eaytoy) [11:43:42] 10AbuseFilter, 10MW-1.34-notes (1.34.0-wmf.23; 2019-09-17): The CachingParser doesn't report syntax errors in skipped branches - https://phabricator.wikimedia.org/T232498 (10Daimona) 05Open→03Resolved [11:43:54] 10AbuseFilter, 10MW-1.34-notes (1.34.0-wmf.23; 2019-09-17): Rewrite the code for hoisting variables in skipped branches for CachingParser - https://phabricator.wikimedia.org/T230982 (10Daimona) 05Open→03Resolved [11:58:53] (03CR) 10Matěj Suchánek: Split afl_filter in afl_filter_id and afl_global (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/459818 (https://phabricator.wikimedia.org/T220791) (owner: 10Daimona Eaytoy) [12:01:18] 10OOUI: CheckboxMultiSelectInputWidget doesn't disable when infusing a disabled HTMLMultiSelectField - https://phabricator.wikimedia.org/T190417 (10Mainframe98) [12:07:44] (03Merged) 10jenkins-bot: Prevent blocked users from using /revert [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536737 (https://phabricator.wikimedia.org/T232916) (owner: 10Daimona Eaytoy) [12:10:43] 10AbuseFilter: Prevent blocked users from using Special:AbuseFilter/revert - https://phabricator.wikimedia.org/T232916 (10Daimona) 05Open→03Resolved [12:13:08] (03CR) 10jenkins-bot: Prevent blocked users from using /revert [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536737 (https://phabricator.wikimedia.org/T232916) (owner: 10Daimona Eaytoy) [12:15:36] (03CR) 10Daimona Eaytoy: [C: 04-1] Split afl_filter in afl_filter_id and afl_global (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/459818 (https://phabricator.wikimedia.org/T220791) (owner: 10Daimona Eaytoy) [12:19:44] (03CR) 10Zoranzoki21: "..." [core] - 10https://gerrit.wikimedia.org/r/536725 (owner: 10Krinkle) [12:21:59] (03CR) 10Zoranzoki21: "recheck" [core] - 10https://gerrit.wikimedia.org/r/536761 (https://phabricator.wikimedia.org/T29658) (owner: 10Iijima Yun) [12:23:08] (03CR) 10Mainframe98: "Alright! Tests are green (until the merge conflict decides to crash the party); that leaves us with the rather ugly optional special page " [core] - 10https://gerrit.wikimedia.org/r/535657 (https://phabricator.wikimedia.org/T232506) (owner: 10Mainframe98) [12:52:22] 10MediaWiki-extensions-Translate, 10Technical-Debt, 10User-D3r1ck01, 10good first bug: Use of ObjectCache::getMainWANInstance was deprecated in MediaWiki 1.28 - https://phabricator.wikimedia.org/T228378 (10Zoranzoki21) 05Open→03Resolved a:03D3r1ck01 Done in https://gerrit.wikimedia.org/r/plugins/giti... [12:59:22] (03PS1) 10Zoranzoki21: Remove two functions deprecated in 1.28 from objectcache [core] - 10https://gerrit.wikimedia.org/r/536765 [13:00:21] (03PS2) 10Zoranzoki21: Remove two functions deprecated in 1.28 from objectcache [core] - 10https://gerrit.wikimedia.org/r/536765 [13:01:49] (03CR) 10Matěj Suchánek: Split afl_filter in afl_filter_id and afl_global (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/459818 (https://phabricator.wikimedia.org/T220791) (owner: 10Daimona Eaytoy) [13:07:47] 10Office-IT: Google group for #Wikimedia-Site-requests - https://phabricator.wikimedia.org/T232946 (10Aklapper) As far as I understand WMF Office-IT's internal documentation, Google Groups are available only to @wikimedia.org account holders. Is the main motivation to ask for a Google Group that searching archiv... [13:09:16] 10Office-IT: Google group for #Wikimedia-Site-requests - https://phabricator.wikimedia.org/T232946 (10Krenair) That was my understanding too until {T215940} happened. [13:11:20] (03CR) 10Luca Mauri: "> Main test build failed." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/507821 (https://phabricator.wikimedia.org/T221149) (owner: 10Luca Mauri) [13:15:26] (03CR) 10Daimona Eaytoy: [C: 04-1] Split afl_filter in afl_filter_id and afl_global (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/459818 (https://phabricator.wikimedia.org/T220791) (owner: 10Daimona Eaytoy) [13:23:43] (03PS1) 10Daimona Eaytoy: Update docblocks for methods potentially returning null [core] - 10https://gerrit.wikimedia.org/r/536767 [13:25:39] 10InternetArchiveBot: IABot makes edits that cause new errors in edited articles - https://phabricator.wikimedia.org/T232922 (10Cyberpower678) @Mikeblas I honestly don't know if this is worth fixing in IABot now. I don't even know what reflist is doing to trigger this error. And I can't program IABot to predic... [13:26:58] (03CR) 10Krinkle: "@Zoranzoki21 Parent commit is not yet approved, they will go together." [core] - 10https://gerrit.wikimedia.org/r/536725 (owner: 10Krinkle) [13:28:08] 10InternetArchiveBot (v2.0): IABot 2.0 removes reference from section - https://phabricator.wikimedia.org/T232805 (10Cyberpower678) 05Open→03Resolved [13:28:20] 10InternetArchiveBot (v2.0): IABot 2.0 removes reference with group= parameter - https://phabricator.wikimedia.org/T231749 (10Cyberpower678) 05Open→03Resolved [13:32:10] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10good first bug, 10patch-welcome: Add monolingual language code nan-hani, cdo-hani, hak-hans, hak-hant - https://phabricator.wikimedia.org/T180771 (10Zoranzoki21) @jhsoby Do you want to do on this? I ask because I saw to you working on these task usua... [13:34:23] 10MediaWiki-Installer, 10MediaWiki-Releasing, 10Epic: Expand the set of bundled extensions and skins to achieve a default MediaWiki experience that's comparable to Wikimedia sites - https://phabricator.wikimedia.org/T178349 (10Peachey88) [13:38:40] 10Office-IT: Google group for #Wikimedia-Site-requests - https://phabricator.wikimedia.org/T232946 (10Aklapper) Uh nice. In that case Office-IT may want to update their WMF internal officewiki documentation. :) [13:45:27] (03CR) 10Zoranzoki21: "> @Zoranzoki21 Parent commit is not yet approved, they will go" [core] - 10https://gerrit.wikimedia.org/r/536725 (owner: 10Krinkle) [13:50:47] (03PS1) 10Zoranzoki21: Add aliases for some languages [extensions/ShortUrl] - 10https://gerrit.wikimedia.org/r/536768 [13:52:38] 10Developer-Advocacy (Jul-Sep 2019): Create a Tech Contributors Map to document major audiences and their goals - https://phabricator.wikimedia.org/T212904 (10Aklapper) p:05Triage→03High [13:54:03] (03PS1) 10Daimona Eaytoy: Fix using null for a non-nullable argument [core] - 10https://gerrit.wikimedia.org/r/536769 [14:01:43] (03CR) 10Reedy: [C: 04-1] "Needs RELEASE-NOTES" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/536765 (owner: 10Zoranzoki21) [14:10:39] (03CR) 10Notartom: "Maybe I'm doing something wrong? But searching for "Test", both with and without this config change (and Sphinx restarted after each modif" [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/470792 (owner: 10Edward Chernenko) [14:22:19] (03CR) 10Reedy: [C: 04-1] Rename ExtMobileFrontend.php to MobileFrontend.php like other extensions (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/536739 (owner: 10D3r1ck01) [14:22:46] 10Wikimedia-Site-requests, 10Patch-For-Review: Syncronize wmgExtraLanguageNames languages between Wikidata and Wikimedia Commons - https://phabricator.wikimedia.org/T230480 (104nn1l2) @Zoranzoki21 @Zache @Urbanecm After making the patch, I noticed that `nys` was added to MediaWiki in January 2018 T182305. It... [14:26:23] (03CR) 10Reedy: [C: 04-1] Rename ExtMobileFrontend.php to MobileFrontend.php like other extensions (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/536739 (owner: 10D3r1ck01) [14:27:51] (03CR) 10Reedy: [C: 04-1] "And of course, phan-seccheck is still failing..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/536739 (owner: 10D3r1ck01) [14:29:40] 10InternetArchiveBot: IABot makes edits that cause new errors in edited articles - https://phabricator.wikimedia.org/T232922 (10Mikeblas) [[ https://en.wikipedia.org/w/index.php?title=Abasy&type=revision&diff=915762255&oldid=900532431&diffmode=source | This IABot edit to the Abasy article ]] shows a slightly dif... [14:31:09] 10TemplateStyles: Option to override CSS flipping - https://phabricator.wikimedia.org/T212986 (10Tacsipacsi) 05Open→03Declined In the past months I came up with a much safer idea: instead of passing a language/directionality to TemplateStyles, I included the whole template output in a tag with `dir` attribut... [14:34:01] (03PS3) 10Zoranzoki21: Remove getMainWANInstance and getMainStashInstance functions from objectcache as it is deprecated in i.28 [core] - 10https://gerrit.wikimedia.org/r/536765 [14:34:36] (03PS4) 10Zoranzoki21: Remove getMainWANInstance and getMainStashInstance functions from objectcache as it is deprecated in 1.28 [core] - 10https://gerrit.wikimedia.org/r/536765 [14:35:42] (03CR) 10Reedy: Remove getMainWANInstance and getMainStashInstance functions from objectcache as it is deprecated in 1.28 (033 comments) [core] - 10https://gerrit.wikimedia.org/r/536765 (owner: 10Zoranzoki21) [14:37:44] 10InternetArchiveBot: IABot makes edits that cause new errors in edited articles - https://phabricator.wikimedia.org/T232922 (10Cyberpower678) That's also not feasible. There's no way for IABot to even know that the edit is unpredictable to begin with them. The solution is to try and establish why the bot only... [14:38:07] 10MobileFrontend, 10MinervaNeue, 10Readers-Web-Backlog (Design): Logout button on mobile web misaligned - https://phabricator.wikimedia.org/T232943 (10Masumrezarock100) I am sure FR could solve this easily. But unfortunately he is not allowed to contribute to Gerrit anymore. [14:40:29] (03CR) 10Reedy: [C: 04-1] Remove getMainWANInstance and getMainStashInstance functions from objectcache as it is deprecated in 1.28 [core] - 10https://gerrit.wikimedia.org/r/536765 (owner: 10Zoranzoki21) [14:40:44] (03PS5) 10Zoranzoki21: Remove getMainWANInstance and getMainStashInstance functions from objectcache as they were deprecated in 1.28 [core] - 10https://gerrit.wikimedia.org/r/536765 [14:41:49] 10MobileFrontend, 10MinervaNeue, 10Readers-Web-Backlog (Design): Logout button on mobile web misaligned - https://phabricator.wikimedia.org/T232943 (10Zoranzoki21) >>! In T232943#5493989, @Masumrezarock100 wrote: > I am sure FR could solve this easily. But unfortunately he is not allowed to contribute to Ger... [14:42:35] (03PS1) 10Daimona Eaytoy: docs: Avoid some scalar juggling [core] - 10https://gerrit.wikimedia.org/r/536771 [14:56:18] 10InternetArchiveBot: IABot makes edits that cause new errors in edited articles - https://phabricator.wikimedia.org/T232922 (10Mikeblas) Why can't IABot know that there are multiple definitions of the reference it's about to change? [14:56:31] 10MediaWiki-Parser, 10OWC2020, 10Parsoid: Parser support for talk pages - https://phabricator.wikimedia.org/T230654 (10Esanders) [14:59:51] (03CR) 10jerkins-bot: [V: 04-1] Remove getMainWANInstance and getMainStashInstance functions from objectcache as they were deprecated in 1.28 [core] - 10https://gerrit.wikimedia.org/r/536765 (owner: 10Zoranzoki21) [15:01:15] (03CR) 10Edward Chernenko: "1) Can you find the page "Cats and dogs" by query "Cats dogs"? I remember having this problem when using a two-word query." [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/470792 (owner: 10Edward Chernenko) [15:01:51] 10MediaWiki-Parser, 10OWC2020: Use a parser function to encapsulate signatures - https://phabricator.wikimedia.org/T230653 (10Esanders) [15:09:58] (03CR) 10Krinkle: "Yes. There is no problem :)" [core] - 10https://gerrit.wikimedia.org/r/536725 (owner: 10Krinkle) [15:10:33] 10MediaWiki-extensions-CollaborationKit, 10MW-1.34-notes (1.34.0-wmf.23; 2019-09-17): CollaborationKit EditPage styles too strong - https://phabricator.wikimedia.org/T214105 (10Isarra) 05Open→03Resolved a:03Isarra [15:10:37] 10MediaWiki-extensions-CollaborationKit, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14): Redesign CollaborationKit with more skin-agnostic styles (consistent with mediawiki.skinning.interface styles) - https://phabricator.wikimedia.org/T192327 (10Isarra) [15:11:34] (03CR) 10Krinkle: docs: Avoid some scalar juggling (031 comment) [core] - 10https://gerrit.wikimedia.org/r/536771 (owner: 10Daimona Eaytoy) [15:12:13] 10InternetArchiveBot: IABot makes edits that cause new errors in edited articles - https://phabricator.wikimedia.org/T232922 (10Cyberpower678) "Indeed, it might be best if IABot didn't edit articles where it can't predict the outcome of its own edits." <-- I'm referring to that. IABot can't know when an edit it... [15:12:22] (03CR) 10Krinkle: docs: Avoid some scalar juggling (031 comment) [core] - 10https://gerrit.wikimedia.org/r/536771 (owner: 10Daimona Eaytoy) [15:12:55] (03PS1) 10Daimona Eaytoy: Avoid scalar juggling, part 2 [core] - 10https://gerrit.wikimedia.org/r/536772 [15:13:51] (03CR) 10Krinkle: Update docblocks for methods potentially returning null (031 comment) [core] - 10https://gerrit.wikimedia.org/r/536767 (owner: 10Daimona Eaytoy) [15:14:56] (03CR) 10Daimona Eaytoy: docs: Avoid some scalar juggling (032 comments) [core] - 10https://gerrit.wikimedia.org/r/536771 (owner: 10Daimona Eaytoy) [15:15:16] (03PS2) 10Daimona Eaytoy: docs: Avoid some scalar juggling [core] - 10https://gerrit.wikimedia.org/r/536771 [15:15:31] (03CR) 10Krinkle: Update docblocks for methods potentially returning null (031 comment) [core] - 10https://gerrit.wikimedia.org/r/536767 (owner: 10Daimona Eaytoy) [15:16:23] (03CR) 10Krinkle: Update docblocks for methods potentially returning null (031 comment) [core] - 10https://gerrit.wikimedia.org/r/536767 (owner: 10Daimona Eaytoy) [15:16:56] (03CR) 10Krinkle: Update docblocks for methods potentially returning null (031 comment) [core] - 10https://gerrit.wikimedia.org/r/536767 (owner: 10Daimona Eaytoy) [15:17:05] (03CR) 10Krinkle: [C: 04-1] "2 nits, otherwise LGTM." [core] - 10https://gerrit.wikimedia.org/r/536767 (owner: 10Daimona Eaytoy) [15:18:40] 10InternetArchiveBot: IABot makes edits that cause new errors in edited articles - https://phabricator.wikimedia.org/T232922 (10Cyberpower678) >>! In T232922#5493994, @Mikeblas wrote: > Why can't IABot know that there are multiple definitions of the reference it's about to change? > > It also seems possible for... [15:18:57] (03PS6) 10Reedy: Remove getMainWANInstance and getMainStashInstance functions from ObjectCache as they were deprecated in 1.28 [core] - 10https://gerrit.wikimedia.org/r/536765 (owner: 10Zoranzoki21) [15:22:11] (03CR) 10Daimona Eaytoy: Update docblocks for methods potentially returning null (034 comments) [core] - 10https://gerrit.wikimedia.org/r/536767 (owner: 10Daimona Eaytoy) [15:22:19] (03CR) 10Zoranzoki21: "Thanks Reedy, can you come on IRC? I have few questions, IRC is easier for communication." [core] - 10https://gerrit.wikimedia.org/r/536765 (owner: 10Zoranzoki21) [15:22:45] (03PS2) 10Daimona Eaytoy: Update docblocks for methods potentially returning null [core] - 10https://gerrit.wikimedia.org/r/536767 [15:28:49] 10phan: Strengthen phan's default config - https://phabricator.wikimedia.org/T232949 (10Daimona) [15:29:09] 10MediaWiki-Core-Testing, 10phan: Phan should warn if wfDeprecated() is called with non-string parameters - https://phabricator.wikimedia.org/T232651 (10Daimona) [15:29:11] 10phan: Strengthen phan's default config - https://phabricator.wikimedia.org/T232949 (10Daimona) [15:32:08] 10InternetArchiveBot (v2.0): Add `abruf` as default alternative to `zugriff` for {{Internetquelle}} - https://phabricator.wikimedia.org/T232950 (10Cirdan) [15:32:30] 10InternetArchiveBot: IABot makes edits that cause new errors in edited articles - https://phabricator.wikimedia.org/T232922 (10Mikeblas) If its behavior can't be fixed, then it shouldn't exercise that behavior -- that is, it should not longer make changes to any reference, since it can't know if it is making th... [15:40:42] 10InternetArchiveBot: IABot makes edits that cause new errors in edited articles - https://phabricator.wikimedia.org/T232922 (10Cyberpower678) The error rate is still very, very low from what I'm seeing. I'm not using that as a reason to dismiss your concerns, I just need to look at what's happening. I'm not f... [15:46:41] (03CR) 10Reedy: [C: 03+2] Remove getMainWANInstance and getMainStashInstance functions from ObjectCache as they were deprecated in 1.28 [core] - 10https://gerrit.wikimedia.org/r/536765 (owner: 10Zoranzoki21) [15:48:45] 10InternetArchiveBot: IABot makes edits that cause new errors in edited articles - https://phabricator.wikimedia.org/T232922 (10Mikeblas) Unfortunately, no metrics of the bot's activity are visible to me. Since we know that it's not checking it's own work, how are measuring its error rate? [15:50:16] (03PS1) 10Daimona Eaytoy: Allow parsers to return extra info [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536773 [15:53:41] (03CR) 10Krinkle: "@Daimona Can you pick me on IRC today?" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536773 (owner: 10Daimona Eaytoy) [15:56:50] 10InternetArchiveBot: IABot makes edits that cause new errors in edited articles - https://phabricator.wikimedia.org/T232922 (10Cyberpower678) https://en.wikipedia.org/wiki/Category:Pages_with_duplicate_reference_names Errors are populated here, which given the edit rate of the bot, and based off of a random sa... [15:59:27] (03CR) 10Krinkle: [C: 03+2] Update docblocks for methods potentially returning null [core] - 10https://gerrit.wikimedia.org/r/536767 (owner: 10Daimona Eaytoy) [16:00:26] 10InternetArchiveBot: IABot makes edits that cause new errors in edited articles - https://phabricator.wikimedia.org/T232922 (10Cyberpower678) Okay, https://en.wikipedia.org/w/index.php?title=Miss_Suwanna_of_Siam&diff=785393610&oldid=749515529 reveals something interesting. All three references were modified id... [16:02:54] 10InternetArchiveBot: bot adds dead link template inside cs1|2 templates - https://phabricator.wikimedia.org/T231545 (10czar) Missing context above, but this is the ticket for getting iabot to handle the recent CS1 change from |dead-url= to the new |url-access= param, yes? [16:03:51] 10ContentTranslation, 10Language-Team (Language-2019-July-September): Content Translation substituted a template with TemplateStyles - https://phabricator.wikimedia.org/T232674 (10Amire80) Another example: A translation of [[ https://en.wikipedia.org/w/index.php?oldid=911620086 | Eva Marian Hubback ]] from En... [16:07:07] (03PS3) 10Ladsgroup: Add config for serving main Page from the domain root [core] - 10https://gerrit.wikimedia.org/r/520139 (https://phabricator.wikimedia.org/T120085) [16:07:18] (03CR) 10Ladsgroup: Add config for serving main Page from the domain root (031 comment) [core] - 10https://gerrit.wikimedia.org/r/520139 (https://phabricator.wikimedia.org/T120085) (owner: 10Ladsgroup) [16:08:13] (03CR) 10Jack Phoenix: [C: 03+2] Use Html to generate output, add per-speaker classes to dialogue blocks [extensions/Screenplay] - 10https://gerrit.wikimedia.org/r/536721 (https://phabricator.wikimedia.org/T232642) (owner: 10Isarra) [16:08:33] (03CR) 10Jack Phoenix: [C: 03+2] "It works, so let's ship it!" [extensions/LogoFunctions] - 10https://gerrit.wikimedia.org/r/536718 (https://phabricator.wikimedia.org/T208342) (owner: 10Isarra) [16:09:12] (03CR) 10Jack Phoenix: [C: 03+2] "<3" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/536331 (https://phabricator.wikimedia.org/T232540) (owner: 10Isarra) [16:09:14] (03CR) 10jerkins-bot: [V: 04-1] Allow parsers to return extra info [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536773 (owner: 10Daimona Eaytoy) [16:09:27] 10InternetArchiveBot: Permission error - https://phabricator.wikimedia.org/T232951 (10Brown_Chocolate) [16:10:10] (03Merged) 10jenkins-bot: Remove getMainWANInstance and getMainStashInstance functions from ObjectCache as they were deprecated in 1.28 [core] - 10https://gerrit.wikimedia.org/r/536765 (owner: 10Zoranzoki21) [16:13:28] 10InternetArchiveBot: Permission error - https://phabricator.wikimedia.org/T232951 (10Cyberpower678) I see nothing to indicate you should be hitting a barrier. Please make sure the interface is set to the English Wikipedia. Please also report what username you are using. I found "Brown Chocolate" which is a m... [16:14:12] 10InternetArchiveBot: IABot makes edits that cause new errors in edited articles - https://phabricator.wikimedia.org/T232922 (10Cyberpower678) p:05Triage→03High [16:17:29] (03CR) 10jerkins-bot: [V: 04-1] Add config for serving main Page from the domain root [core] - 10https://gerrit.wikimedia.org/r/520139 (https://phabricator.wikimedia.org/T120085) (owner: 10Ladsgroup) [16:18:29] (03PS6) 10Krinkle: OutputPage: Add visibility to various methods & do some micro-optimizations [core] - 10https://gerrit.wikimedia.org/r/536733 (owner: 10D3r1ck01) [16:18:34] (03CR) 10Krinkle: [C: 03+2] OutputPage: Add visibility to various methods & do some micro-optimizations [core] - 10https://gerrit.wikimedia.org/r/536733 (owner: 10D3r1ck01) [16:22:43] 10Language-Team: Precise and concise documentation on adding a new language to Wikidata - https://phabricator.wikimedia.org/T223665 (10Yupik) [16:24:14] 10InternetArchiveBot: bot adds dead link template inside cs1|2 templates - https://phabricator.wikimedia.org/T231545 (10Trappist_the_monk) no. `|url-access=` has nothing to do with `|dead-url=`. Perhaps you mean `|url-status=`? regardless, IABot converted this: `{{cite book|chapterurl=http://csis.org/files/m... [16:27:38] (03Merged) 10jenkins-bot: Update docblocks for methods potentially returning null [core] - 10https://gerrit.wikimedia.org/r/536767 (owner: 10Daimona Eaytoy) [16:27:41] (03Merged) 10jenkins-bot: Use Html to generate output, add per-speaker classes to dialogue blocks [extensions/Screenplay] - 10https://gerrit.wikimedia.org/r/536721 (https://phabricator.wikimedia.org/T232642) (owner: 10Isarra) [16:27:43] (03Merged) 10jenkins-bot: Reimplement extension using plain CSS smashed onto the page [extensions/LogoFunctions] - 10https://gerrit.wikimedia.org/r/536718 (https://phabricator.wikimedia.org/T208342) (owner: 10Isarra) [16:27:45] (03Merged) 10jenkins-bot: Render unnecessarily large 2x logos to ensure we support unnecessarily high-res devices [skins/Timeless] - 10https://gerrit.wikimedia.org/r/536331 (https://phabricator.wikimedia.org/T232540) (owner: 10Isarra) [16:30:35] (03CR) 10jenkins-bot: Remove getMainWANInstance and getMainStashInstance functions from ObjectCache as they were deprecated in 1.28 [core] - 10https://gerrit.wikimedia.org/r/536765 (owner: 10Zoranzoki21) [16:31:11] 10LogoFunctions, 10Patch-For-Review: LogoFunctions: Restore StampLogo functionality - https://phabricator.wikimedia.org/T232905 (10Isarra) 05Open→03Resolved a:03Isarra [16:31:15] 10Timeless, 10Patch-For-Review: Custom logo handler results in insufficiently high-res logos for mobile devices - https://phabricator.wikimedia.org/T232540 (10Isarra) 05Open→03Resolved a:03Isarra [16:31:25] 10LogoFunctions, 10Uncyclomedia, 10Patch-For-Review: LogoFunctions: Restore custom functionality for defined logos for namespaces - https://phabricator.wikimedia.org/T220058 (10Isarra) 05Open→03Resolved [16:31:34] 10LogoFunctions, 10Uncyclomedia, 10Patch-For-Review: Extension:LogoFunctions.php doesn't set the page logo as of MediaWiki 1.31.x - https://phabricator.wikimedia.org/T208342 (10Isarra) 05Open→03Resolved a:03Isarra [16:31:40] 10MediaWiki-extensions-Screenplay, 10Patch-For-Review: Add per-speaker classes to dialogue blocks - https://phabricator.wikimedia.org/T232642 (10Isarra) 05Open→03Resolved a:03Isarra [16:32:41] (03PS2) 10Daimona Eaytoy: Allow parsers to return extra info [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536773 [16:33:17] 10LogoFunctions: Support using namespace constants for setting namespace logos - https://phabricator.wikimedia.org/T232952 (10Isarra) [16:34:39] (03PS1) 10Daimona Eaytoy: [WIP] Namespace-ize parser-related classes [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536774 [16:37:14] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Namespace-ize parser-related classes [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536774 (owner: 10Daimona Eaytoy) [16:38:43] 10Wikimedia-Site-requests, 10Patch-For-Review: Syncronize wmgExtraLanguageNames languages between Wikidata and Wikimedia Commons - https://phabricator.wikimedia.org/T230480 (10Zache) I would amend the patch and edit the task description to include removing the redundant `nys`. [16:41:25] (03Merged) 10jenkins-bot: OutputPage: Add visibility to various methods & do some micro-optimizations [core] - 10https://gerrit.wikimedia.org/r/536733 (owner: 10D3r1ck01) [16:42:00] 10MobileFrontend, 10MinervaNeue, 10Readers-Web-Backlog (Design): Logout button on mobile web misaligned - https://phabricator.wikimedia.org/T232943 (10Force_Radical) Nope, I am allowed to contribute it seems... That was a major mixup .... >>! In T232943#5493989, @Masumrezarock100 wrote: > I am sure FR could... [16:43:06] (03CR) 10jerkins-bot: [V: 04-1] Add config for serving main Page from the domain root [core] - 10https://gerrit.wikimedia.org/r/520139 (https://phabricator.wikimedia.org/T120085) (owner: 10Ladsgroup) [16:46:03] 10MediaWiki-ResourceLoader, 10Performance-Team: How to use Babel.js with MediaWiki Javascript - https://phabricator.wikimedia.org/T232285 (10Machineghost) 05Resolved→03Open > According to https://www.mediawiki.org/wiki/Compatibility#Browser_support_matrix , IE versions 6-10 are under "Basic (Grade C)" whic... [16:48:55] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Namespace-ize parser-related classes [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536774 (owner: 10Daimona Eaytoy) [16:49:33] (03CR) 10jenkins-bot: Update docblocks for methods potentially returning null [core] - 10https://gerrit.wikimedia.org/r/536767 (owner: 10Daimona Eaytoy) [16:50:57] (03CR) 10jerkins-bot: [V: 04-1] Allow parsers to return extra info [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536773 (owner: 10Daimona Eaytoy) [16:52:15] 10MediaWiki-ResourceLoader, 10Performance-Team: How to use Babel.js with MediaWiki Javascript - https://phabricator.wikimedia.org/T232285 (10Machineghost) > According to https://www.mediawiki.org/wiki/Compatibility#Browser_support_matrix , IE versions 6-10 are under "Basic (Grade C)" which already means that "... [16:54:51] 10MediaWiki-ResourceLoader, 10Performance-Team: How to use Babel.js with MediaWiki Javascript - https://phabricator.wikimedia.org/T232285 (10Machineghost) >>! In T232285#5494110, @Machineghost wrote: >> According to https://www.mediawiki.org/wiki/Compatibility#Browser_support_matrix , IE versions 6-10 are unde... [17:06:55] (03CR) 10jenkins-bot: OutputPage: Add visibility to various methods & do some micro-optimizations [core] - 10https://gerrit.wikimedia.org/r/536733 (owner: 10D3r1ck01) [17:08:45] 10MediaWiki-User-preferences: Wiki user Preferences/User profile/Email options should, but currently not, conditioned on site settings - https://phabricator.wikimedia.org/T232937 (10Whelkmy) As for the version, by the first line of https://git.archlinux.org/vhosts/wiki.archlinux.org.git/tree/LocalSettings.archli... [17:17:15] 10MediaWiki-ResourceLoader, 10Performance-Team: How to use Babel.js with MediaWiki Javascript - https://phabricator.wikimedia.org/T232285 (10Aklapper) 05Open→03Declined Maintainers do not plan to implement this proposal as written, as explained in previous comments. It has also been explained how you could... [17:22:12] 04(no projects): MediaWiki Should Have a Stated Principle of Accommodating as Many People As Possible - https://phabricator.wikimedia.org/T232953 (10Machineghost) [17:22:28] 04(no projects): MediaWiki Should Have a Stated Principle of Accommodating as Many People As Possible - https://phabricator.wikimedia.org/T232953 (10Machineghost) [17:23:34] 04(no projects): MediaWiki Should Have a Stated Principle of Accommodating as Many People As Possible - https://phabricator.wikimedia.org/T232953 (10Machineghost) [17:24:10] 04(no projects): MediaWiki Should Have a Stated Principle of Accommodating as Many People As Possible - https://phabricator.wikimedia.org/T232953 (10Machineghost) [17:24:25] 10MediaWiki-ResourceLoader, 10Performance-Team: How to use Babel.js with MediaWiki Javascript - https://phabricator.wikimedia.org/T232285 (10Machineghost) I will re-open if I can get https://phabricator.wikimedia.org/T232953 through. [17:25:02] 04(no projects): MediaWiki Should Have a Stated Principle of Accommodating as Many People As Possible - https://phabricator.wikimedia.org/T232953 (10Machineghost) [17:27:00] 04(no projects): MediaWiki Should Have a Stated Principle of Accommodating as Many People As Possible - https://phabricator.wikimedia.org/T232953 (10Machineghost) I should note that there are some within the MediaWiki organization who believe this should instead state: > for everyone with a modern web browser... [17:28:06] (03CR) 10Svemir Brkic: "You mention that you restarted sphinx after each change, but have you reindexed the wiki as well? It's been a while, but the way I remembe" [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/470792 (owner: 10Edward Chernenko) [17:28:23] 10MediaWiki-General: Problem with ./images/.htaccess (images and thumbnails disappear) - solution is to comment out "Options +FollowSymLinks" - https://phabricator.wikimedia.org/T100821 (10Aklapper) a:05LoopZilla→03None [17:29:06] 10MediaWiki-ResourceLoader, 10Performance-Team: How to use Babel.js with MediaWiki Javascript - https://phabricator.wikimedia.org/T232285 (10Reedy) You're making it sound like we're preventing people from viewing/reading MediaWiki instances... Which we're not. What necessary function is broken? [17:29:11] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: wikibase.entityPage.entityLoaded.js runs on the main page and produces invalid request - https://phabricator.wikimedia.org/T232459 (10Lydia_Pintscher) @Addshore and @alaa_wmde: Could you have a look and check if this is serious? [17:30:44] 04(no projects): MediaWiki Should Have a Stated Principle of Accommodating as Many People As Possible - https://phabricator.wikimedia.org/T232953 (10Machineghost) [17:31:00] 04(no projects): MediaWiki Should Have a Stated Principle of Accommodating as Many People As Possible - https://phabricator.wikimedia.org/T232953 (10Machineghost) [17:31:38] 10MediaWiki-General: MediaWiki Should Have a Stated Principle of Accommodating as Many People As Possible - https://phabricator.wikimedia.org/T232953 (10Reedy) [17:35:56] 04(no projects): [AMC] Summary in recent changes misaligned - https://phabricator.wikimedia.org/T232955 (10Zoranzoki21) [17:37:31] (03CR) 10Svemir Brkic: "I might be able to do some testing myself these days, but right now I am not convinced this change is needed." [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/470792 (owner: 10Edward Chernenko) [17:41:15] (03CR) 10Svemir Brkic: [C: 03+2] "Thanks - I am setting up a test environment to try this myself (did not use a recent version of MW until recently)" [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/517711 (https://phabricator.wikimedia.org/T127177) (owner: 10Thijs) [17:41:47] (03PS3) 10Daimona Eaytoy: Allow parsers to return extra info [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536773 [17:41:52] (03PS2) 10Daimona Eaytoy: [WIP] Namespace-ize parser-related classes [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536774 [17:42:16] 04(no projects): [AMC] Summary in recent changes misaligned - https://phabricator.wikimedia.org/T232955 (10Zoranzoki21) [17:42:32] 04(no projects): [AMC] Summary in recent changes misaligned - https://phabricator.wikimedia.org/T232955 (10Zoranzoki21) [17:43:05] 10MobileFrontend, 10Readers-Web-Backlog: [AMC] Summary in recent changes misaligned - https://phabricator.wikimedia.org/T232955 (10Zoranzoki21) [17:44:38] (03CR) 10jerkins-bot: [V: 04-1] Allow parsers to return extra info [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536773 (owner: 10Daimona Eaytoy) [17:45:23] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Namespace-ize parser-related classes [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536774 (owner: 10Daimona Eaytoy) [17:45:47] 10MediaWiki-ResourceLoader, 10Performance-Team: How to use Babel.js with MediaWiki Javascript - https://phabricator.wikimedia.org/T232285 (10Krinkle) @Machineghost I believe we agree in principle, but there may be some misunderstandings. Please consider the following and let me know if this makes sense. * We... [17:47:00] (03Merged) 10jenkins-bot: Fix soundex suggestion: replace page_counter with page_len. [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/517711 (https://phabricator.wikimedia.org/T127177) (owner: 10Thijs) [17:49:27] 10Lingua Libre: Add href to “Check your uploads on Wikimedia Commons” button - https://phabricator.wikimedia.org/T232956 (10LucasWerkmeister) [17:56:42] 10MediaWiki-History-and-Diffs, 10MobileFrontend, 10MinervaNeue, 10Mobile: Showing "No change in size" wrongly on Minerva diff pages on sites where AMC mode is not enabled - https://phabricator.wikimedia.org/T232941 (10Masumrezarock100) [17:57:09] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Namespace-ize parser-related classes [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536774 (owner: 10Daimona Eaytoy) [17:58:37] 10MediaWiki-History-and-Diffs, 10MinervaNeue, 10Readers-Web-Backlog, 10Mobile: Showing "No change in size" wrongly on Minerva diff pages on sites where AMC mode is not enabled - https://phabricator.wikimedia.org/T232941 (10Masumrezarock100) [18:01:51] 10MobileFrontend, 10MinervaNeue, 10Readers-Web-Backlog (Design): Logout button on mobile web misaligned - https://phabricator.wikimedia.org/T232943 (10Masumrezarock100) >>! In T232943#5494099, @Force_Radical wrote: > Nope, I am allowed to contribute it seems... That was a major mixup .... Good to hear. :) W... [18:13:00] 10AbuseFilter: AbuseFilterCachingParser fails to parse filters with trailing comma in function calls (works in old parser) - https://phabricator.wikimedia.org/T153251 (10Daimona) [18:13:48] (03PS4) 10Daimona Eaytoy: Allow parsers to return extra info [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536773 [18:13:57] (03PS3) 10Daimona Eaytoy: [WIP] Namespace-ize parser-related classes [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536774 [18:15:55] (03CR) 10Raimond Spekking: [C: 03+1] "formally +1 but I have no knowledge about the language" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/535295 (owner: 10Zoranzoki21) [18:17:07] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Namespace-ize parser-related classes [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536774 (owner: 10Daimona Eaytoy) [18:18:47] 10MobileFrontend, 10Readers-Web-Backlog: [AMC] Summary in recent changes misaligned - https://phabricator.wikimedia.org/T232955 (10Masumrezarock100) @Zoranzoki21 Is it happening when AMC mode is enabled or not enabled? [18:18:49] 10MobileFrontend, 10MinervaNeue, 10Readers-Web-Backlog (Design): Logout button on mobile web misaligned - https://phabricator.wikimedia.org/T232943 (10Force_Radical) Possibly caused by [[ https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/535284 | this commit ]]. I don't think we need to do anyth... [18:21:30] (03CR) 10Zoranzoki21: "> formally +1 but I have no knowledge about the language" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/535295 (owner: 10Zoranzoki21) [18:21:33] 10MediaWiki-ResourceLoader, 10Performance-Team: How to use Babel.js with MediaWiki Javascript - https://phabricator.wikimedia.org/T232285 (10Aklapper) a:05Krinkle→03None [18:24:17] 10MobileFrontend, 10MinervaNeue, 10Readers-Web-Backlog (Design): Logout button on mobile web misaligned - https://phabricator.wikimedia.org/T232943 (10Force_Radical) 05Open→03Invalid Per above, the bug doesn't exist in the deployment clusters and thus will probably be fixed when the new mediawiki version... [18:25:43] 10MediaWiki-General: MediaWiki Should Have a Stated Principle of Accommodating as Many People As Possible - https://phabricator.wikimedia.org/T232953 (10Aklapper) 05Open→03Declined You probably meant the [Wikimedia movement](https://meta.wikimedia.org/wiki/Wikimedia_movement) when you wrote "MediaWiki organi... [18:25:56] (03CR) 10Mglaser: "recheck" [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/536735 (owner: 10AlexPinchuk) [18:30:46] 10Advanced Mobile Contributions, 10MinervaNeue (3rd party support), 10Readers-Web-Backlog (Design): Allow configuration of the Minerva menu - https://phabricator.wikimedia.org/T65459 (10Masumrezarock100) I have no idea why this [[https://phabricator.wikimedia.org/tag/wmf-deploy-2016-01-12_(1.27.0-wmf.10)/|MW... [18:30:55] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Namespace-ize parser-related classes [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536774 (owner: 10Daimona Eaytoy) [18:32:23] (03CR) 10jerkins-bot: [V: 04-1] Allow parsers to return extra info [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536773 (owner: 10Daimona Eaytoy) [18:39:26] 10MediaWiki-ResourceLoader, 10Performance-Team: How to use Babel.js with MediaWiki Javascript - https://phabricator.wikimedia.org/T232285 (10Machineghost) >What necessary function is broken? The "broken function" is //not// necessary. MediaWiki is designed to work without Javascript. But does that mean that... [18:39:36] 10MediaWiki-User-preferences, 10MediaWiki-extensions-Linter: User preferences: Check raw signature for linter errors - https://phabricator.wikimedia.org/T140606 (10Jonesey95) This is still a problem. Please implement a solution that checks custom signatures for Linter errors. [[ https://en.wikipedia.org/w/inde... [18:39:49] 10MediaWiki-User-preferences: Wiki user Preferences/User profile/Email options should, but currently not, conditioned on site settings - https://phabricator.wikimedia.org/T232937 (10Lahwaacz) The version is 1.33.0, see https://wiki.archlinux.org/index.php/Special:Version Everything else is clearly stated in the... [18:41:24] 10MediaWiki-General: MediaWiki Should Have a Stated Principle of Accommodating as Many People As Possible - https://phabricator.wikimedia.org/T232953 (10Machineghost) I just want to be clear: you're rejecting the principle that MediaWiki is for everyone because ... of a very specific interpretation (that saying... [18:45:07] 10Wikimedia-Rdbms, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), 10PHP 7.2 support, and 2 others: LBFactoryMulti.php: PHP Notice: Undefined index: - https://phabricator.wikimedia.org/T232613 (10Daimona) >>! In T232613#5493984, @Stashbot wrote: > {nav icon=... [18:50:33] (03PS1) 10Reedy: RecentChangesUpdateJob: Fix GROUP BY [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/536776 (https://phabricator.wikimedia.org/T230618) [18:50:43] (03CR) 10Reedy: [C: 03+2] RecentChangesUpdateJob: Fix GROUP BY [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/536776 (https://phabricator.wikimedia.org/T230618) (owner: 10Reedy) [18:51:07] (03PS1) 10Reedy: ActiveUsersPager: Fix outer GROUP BY [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/536777 (https://phabricator.wikimedia.org/T230618) [18:51:14] (03CR) 10Reedy: [C: 03+2] ActiveUsersPager: Fix outer GROUP BY [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/536777 (https://phabricator.wikimedia.org/T230618) (owner: 10Reedy) [18:51:26] 10MediaWiki-Vagrant: Vagrant password should not expire - https://phabricator.wikimedia.org/T228580 (10Tgr) [18:51:49] 10MediaWiki-Vagrant: Vagrant ssh password should not expire - https://phabricator.wikimedia.org/T228580 (10Reedy) [18:52:32] 10MediaWiki-General: MediaWiki Should Have a Stated Principle of Accommodating as Many People As Possible - https://phabricator.wikimedia.org/T232953 (10Aklapper) 05Declined→03Invalid My previous comment referred to the //technical// context of T232285, a task which you created. I'm going change the status... [18:57:13] 10MobileFrontend, 10Readers-Web-Backlog: [AMC] Summary in recent changes misaligned - https://phabricator.wikimedia.org/T232955 (10Zoranzoki21) >>! In T232955#5494222, @Masumrezarock100 wrote: > @Zoranzoki21 Is it happening when AMC mode is enabled or not enabled? It is with enabled AMC mode, so I set in tit... [18:59:36] 10MediaWiki-General: MediaWiki Should Have a Stated Principle of Accommodating as Many People As Possible - https://phabricator.wikimedia.org/T232953 (10Machineghost) So then, is the criteria for what counts as a "MediaWiki Principle" whether or not one Internet stranger can disagree with your interpretation of... [18:59:42] (03Merged) 10jenkins-bot: RecentChangesUpdateJob: Fix GROUP BY [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/536776 (https://phabricator.wikimedia.org/T230618) (owner: 10Reedy) [18:59:49] (03Merged) 10jenkins-bot: ActiveUsersPager: Fix outer GROUP BY [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/536777 (https://phabricator.wikimedia.org/T230618) (owner: 10Reedy) [19:00:43] 10MediaWiki-General: MediaWiki Should Have a Stated Principle of Accommodating as Many People As Possible - https://phabricator.wikimedia.org/T232953 (10Machineghost) Well, it really seemed to me that changing the principles of an organization might warrant some institutional thought (eg. in the form of a ticket... [19:01:09] (03CR) 10Reedy: clientpool: Use PHP constants in SquidPurgeClient (031 comment) [core] - 10https://gerrit.wikimedia.org/r/536761 (https://phabricator.wikimedia.org/T29658) (owner: 10Iijima Yun) [19:03:10] (03CR) 10jenkins-bot: ActiveUsersPager: Fix outer GROUP BY [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/536777 (https://phabricator.wikimedia.org/T230618) (owner: 10Reedy) [19:07:13] (03CR) 10Iijima Yun: "MSG_EOR only applies to SOCK_SEQPACKET sockets, and results in an error on BSD systems when used with SOCK_STREAM." [core] - 10https://gerrit.wikimedia.org/r/536761 (https://phabricator.wikimedia.org/T29658) (owner: 10Iijima Yun) [19:08:35] (03CR) 10jenkins-bot: RecentChangesUpdateJob: Fix GROUP BY [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/536776 (https://phabricator.wikimedia.org/T230618) (owner: 10Reedy) [19:08:49] (03CR) 10Zoranzoki21: "uh oh.." [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/536735 (owner: 10AlexPinchuk) [19:08:54] (03CR) 10Zoranzoki21: "recheck" [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/536735 (owner: 10AlexPinchuk) [19:14:10] (03CR) 10jenkins-bot: RecentChangesUpdateJob: Fix GROUP BY [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/536776 (https://phabricator.wikimedia.org/T230618) (owner: 10Reedy) [19:15:20] (03CR) 10Zoranzoki21: [C: 03+1] "poke Jenkins" [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/536735 (owner: 10AlexPinchuk) [19:15:50] (03CR) 10Zoranzoki21: "No works.. I reported on #wikimedia-operations" [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/536735 (owner: 10AlexPinchuk) [19:17:06] (03PS12) 10Aaron Schulz: filebackend: optimize 'create', 'store', and 'copy' in FSFileBackend [core] - 10https://gerrit.wikimedia.org/r/534931 [19:17:08] (03PS8) 10Aaron Schulz: [WIP] filebackend: add xattr_* method support to FSFileBackend [core] - 10https://gerrit.wikimedia.org/r/533719 [19:19:15] (03CR) 10Paladox: "recheck" [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/536735 (owner: 10AlexPinchuk) [19:21:23] (03CR) 10Svemir Brkic: [C: 03+2] Display soundex suggestion page title with proper formatting. [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/517712 (owner: 10Thijs) [19:24:27] (03PS1) 10Zoranzoki21: TEST DNM [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/536778 [19:24:29] (03CR) 10Svemir Brkic: [C: 03+2] Sample sphinx.conf for use with Postgres [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/252746 (owner: 10Greg Sabino Mullane) [19:24:54] (03Abandoned) 10Zoranzoki21: TEST DNM [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/536778 (owner: 10Zoranzoki21) [19:26:20] (03Merged) 10jenkins-bot: Display soundex suggestion page title with proper formatting. [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/517712 (owner: 10Thijs) [19:28:00] (03CR) 10jenkins-bot: ActiveUsersPager: Fix outer GROUP BY [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/536777 (https://phabricator.wikimedia.org/T230618) (owner: 10Reedy) [19:28:42] (03Merged) 10jenkins-bot: Sample sphinx.conf for use with Postgres [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/252746 (owner: 10Greg Sabino Mullane) [19:32:14] (03Abandoned) 10FR30799386: Changing sidebar link behaviour [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/495951 (https://phabricator.wikimedia.org/T158513) (owner: 10FR30799386) [19:34:33] (03PS2) 10Iijima Yun: clientpool: Use PHP constants in SquidPurgeClient [core] - 10https://gerrit.wikimedia.org/r/536761 (https://phabricator.wikimedia.org/T29658) [19:37:11] (03CR) 10Aaron Schulz: [C: 03+2] resourceloader: Add Doxygen group and improve overall docs [core] - 10https://gerrit.wikimedia.org/r/536727 (owner: 10Krinkle) [19:37:16] (03CR) 10jerkins-bot: [V: 04-1] [WIP] filebackend: add xattr_* method support to FSFileBackend [core] - 10https://gerrit.wikimedia.org/r/533719 (owner: 10Aaron Schulz) [19:37:28] (03PS1) 10FR30799386: Changing sidebar link behaviour [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/536779 (https://phabricator.wikimedia.org/T158513) [19:38:06] (03CR) 10Aaron Schulz: "Rebased" [core] - 10https://gerrit.wikimedia.org/r/534931 (owner: 10Aaron Schulz) [19:40:57] (03PS1) 10Svemir Brkic: Remove deprecated attributes from sample sphinx configuration [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/536780 [19:41:29] (03PS1) 10Gergő Tisza: Pin monolog version to avoid conflict with MediaWiki core [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/536781 [19:43:32] 10AbuseFilter, 10Core Platform Team, 10Patch-For-Review, 10Schema-change: afl_filter should be split in afl_filter_id and afl_global - https://phabricator.wikimedia.org/T220791 (10Daimona) So, @matej_suchanek noted that there's a big trouble in the patch. We have a variable with the migration stage for the... [19:45:59] (03CR) 10FR30799386: "@KostaHarlan Would it be possible to review the changes I made based your feedback in the old patch ?" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/536779 (https://phabricator.wikimedia.org/T158513) (owner: 10FR30799386) [19:49:21] 10Wikimedia-Rdbms, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), 10PHP 7.2 support, and 2 others: LBFactoryMulti.php: PHP Notice: Undefined index: - https://phabricator.wikimedia.org/T232613 (10Joe) As can be seen [[ https://logstash.wikimedia.org/goto/ce7... [19:51:28] 10MobileFrontend, 10Advanced Mobile Contributions, 10Readers-Web-Backlog: [AMC] Summary in recent changes misaligned - https://phabricator.wikimedia.org/T232955 (10Masumrezarock100) >>! In T232955#5494259, @Zoranzoki21 wrote: > It is with enabled AMC mode, so I set in title of task already to you know it. S... [19:58:40] (03PS1) 10Aaron Schulz: filerepo: make FileRepo::store/storeBatch() accept FSFile as similar methods already do [core] - 10https://gerrit.wikimedia.org/r/536782 [19:58:51] (03Merged) 10jenkins-bot: resourceloader: Add Doxygen group and improve overall docs [core] - 10https://gerrit.wikimedia.org/r/536727 (owner: 10Krinkle) [20:13:16] (03PS1) 10Reedy: Add RELEASE-NOTES for last two commits [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/536783 [20:13:41] (03CR) 10Reedy: [C: 03+2] Add RELEASE-NOTES for last two commits [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/536783 (owner: 10Reedy) [20:16:21] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Interface overlaps on Android app - https://phabricator.wikimedia.org/T232959 (10Kvardek_du) [20:18:37] (03CR) 10jerkins-bot: [V: 04-1] filerepo: make FileRepo::store/storeBatch() accept FSFile as similar methods already do [core] - 10https://gerrit.wikimedia.org/r/536782 (owner: 10Aaron Schulz) [20:18:45] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Interface overlaps on Android app - https://phabricator.wikimedia.org/T232959 (10Kvardek_du) [20:22:17] (03Merged) 10jenkins-bot: Add RELEASE-NOTES for last two commits [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/536783 (owner: 10Reedy) [20:22:47] 10MediaWiki-General: MediaWiki Should Have a Stated Principle of Accommodating as Many People As Possible - https://phabricator.wikimedia.org/T232953 (10Aklapper) >>! In T232953#5494260, @Machineghost wrote: > By that logic I disagree with the Principle: >> the platform for the Wikimedia movement. Feel free to... [20:23:07] (03CR) 10jenkins-bot: resourceloader: Add Doxygen group and improve overall docs [core] - 10https://gerrit.wikimedia.org/r/536727 (owner: 10Krinkle) [20:24:46] (03CR) 10jenkins-bot: Add RELEASE-NOTES for last two commits [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/536783 (owner: 10Reedy) [20:34:22] (03CR) 10Krinkle: docs: Avoid some scalar juggling (031 comment) [core] - 10https://gerrit.wikimedia.org/r/536771 (owner: 10Daimona Eaytoy) [20:34:28] (03CR) 10Krinkle: [C: 03+2] docs: Avoid some scalar juggling [core] - 10https://gerrit.wikimedia.org/r/536771 (owner: 10Daimona Eaytoy) [20:36:20] (03PS1) 10Jack Phoenix: Added option to specify "Various authors" as author in extension credits using "..." as the _only_ author name [core] - 10https://gerrit.wikimedia.org/r/536784 [20:37:04] (03CR) 10jenkins-bot: Add RELEASE-NOTES for last two commits [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/536783 (owner: 10Reedy) [20:44:30] (03CR) 10Krinkle: Fix using null for a non-nullable argument (031 comment) [core] - 10https://gerrit.wikimedia.org/r/536769 (owner: 10Daimona Eaytoy) [20:49:38] 10MediaWiki-General, 10CPT Initiatives (MCR), 10Documentation, 10Technical-Debt, 10User-Zoranzoki21: The "RevisionInsertComplete" hook is listed in documentation as deprecated but doesn't emit deprecation warnings yet - https://phabricator.wikimedia.org/T232877 (10Reedy) Have you looked at the code for H... [20:50:46] 10MediaWiki-General, 10CPT Initiatives (MCR), 10Documentation, 10Technical-Debt, 10User-Zoranzoki21: The "RevisionInsertComplete" hook is listed in documentation as deprecated but doesn't emit deprecation warnings yet - https://phabricator.wikimedia.org/T232877 (10Zoranzoki21) >>! In T232877#5494309, @Re... [20:51:12] 10MediaWiki-General, 10CPT Initiatives (MCR), 10Documentation, 10Technical-Debt, 10User-Zoranzoki21: The "RevisionInsertComplete" hook is listed in documentation as deprecated but doesn't emit deprecation warnings yet - https://phabricator.wikimedia.org/T232877 (10Reedy) >>! In T232877#5494310, @Zoranzok... [20:51:13] (03CR) 10Svemir Brkic: [V: 04-1 C: 04-2] "I have confirmed that this change is not needed by testing in both MW 1.19 and sphinxsearch 2.0.4, as well as with MW 1.33 and sphinxsearc" [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/470792 (owner: 10Edward Chernenko) [20:52:26] (03CR) 10Jdrewniak: [C: 03+2] Add fundraising messages for Japan [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/534838 (https://phabricator.wikimedia.org/T231839) (owner: 10Pcoombe) [20:52:31] (03PS1) 10Aaron Schulz: objectcache: remove references to recently removed methods [core] - 10https://gerrit.wikimedia.org/r/536785 [20:52:50] (03PS5) 10Aaron Schulz: filebackend: reduce hashing I/O in SwiftFileBackend::doStoreInternal() [core] - 10https://gerrit.wikimedia.org/r/534976 [20:53:10] (03Merged) 10jenkins-bot: Add fundraising messages for Japan [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/534838 (https://phabricator.wikimedia.org/T231839) (owner: 10Pcoombe) [21:00:27] (03CR) 10Svemir Brkic: [V: 04-1 C: 04-2] "And to clarify my testing procedure:" [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/470792 (owner: 10Edward Chernenko) [21:03:56] 10MediaWiki-Gerrit-Group-Requests: +2 in mediawiki/* for Zoranzoki21 - https://phabricator.wikimedia.org/T231758 (10Bawolff) Im sorry, i dont mean to be harsh, but you are very far away from the expected level of familarity with mw code and quite frankly skill, expected of someone with +2 rights [21:04:59] 10Phabricator, 10Developer-Advocacy: Decrease issue with assignee field set for years without progress (aka cookie licking) - https://phabricator.wikimedia.org/T228575 (10Aklapper) Something like this, I guess?: ` Hi. You receive this message as you have open tasks in Wikimedia Phabricator which have been ass... [21:13:58] (03PS1) 10Mglaser: Update contributors' list [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/536786 [21:16:09] 10MediaWiki-Gerrit-Group-Requests: +2 in mediawiki/* for Zoranzoki21 - https://phabricator.wikimedia.org/T231758 (10Bawolff) >>! In T231758#5490195, @Zoranzoki21 wrote: > Done all requested. Note: afaict no email was ever sent to wikitech-l. If you want to continue to persue this request, you will need to do that [21:22:39] 10MediaWiki-extensions-SphinxSearch: SphinxSearch Extension incompatible with MediaWiki 1.32 due to missing abstract methods - https://phabricator.wikimedia.org/T213675 (10svemir) I have working patch for this, though it could be improved some more. I am confused by two things: 1. gerrit vs. phabricator - which... [21:23:56] 10MediaWiki-extensions-SphinxSearch: SphinxSearch Extension incompatible with MediaWiki 1.32 due to missing abstract methods - https://phabricator.wikimedia.org/T213675 (10svemir) a:03svemir [21:26:27] 10MediaWiki-Gerrit-Group-Requests: +2 in mediawiki/* for Zoranzoki21 - https://phabricator.wikimedia.org/T231758 (10Zoranzoki21) >>! In T231758#5494344, @Bawolff wrote: >>>! In T231758#5490195, @Zoranzoki21 wrote: >> Done all requested. > > Note: afaict no email was ever sent to wikitech-l. If you want to conti... [21:27:54] 10Design, 10Wikimedia-Portals: Unify the display of all Wikimedia portals - https://phabricator.wikimedia.org/T230593 (10Iniquity) @Volker_E can you help with this? Or leave a review at least? :) [21:28:22] 10WMEE: Juhatuse koosolek strateegia täpsustamiseks ja aastaplaani 2020 koostamiseks - https://phabricator.wikimedia.org/T231524 (10tramm) 05Open→03Resolved Toimus, protokollitud siin: * https://ee.wikimedia.org/wiki/2019.9:_T%C3%B6%C3%B6korraldus_ja_laia_joonega_j%C3%A4rgmise_aasta_plaanist_(9._september_2... [21:28:36] (03PS1) 10Svemir Brkic: Update extension wfor MW 1.32+ [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/536787 (https://phabricator.wikimedia.org/T213675) [21:31:37] (03PS2) 10Svemir Brkic: Update extension for MW 1.32+ [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/536787 (https://phabricator.wikimedia.org/T213675) [21:31:58] 10MediaWiki-Gerrit-Group-Requests: +2 in mediawiki/* for Zoranzoki21 - https://phabricator.wikimedia.org/T231758 (10Aklapper) There is no such email in the archives (and I have not seen one either): https://lists.wikimedia.org/pipermail/wikitech-l/2019-September/thread.html [21:32:33] 10MediaWiki-Gerrit-Group-Requests: +2 in mediawiki/* for Zoranzoki21 - https://phabricator.wikimedia.org/T231758 (10Zoranzoki21) >>! In T231758#5494359, @Aklapper wrote: > There is no such email in the archives (and I have not seen one either): https://lists.wikimedia.org/pipermail/wikitech-l/2019-September/thre... [21:32:52] (03PS1) 10Gergő Tisza: Avoid mentioning real names on wikis which do not use it [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/536788 (https://phabricator.wikimedia.org/T151515) [21:37:36] 10MediaWiki-Gerrit-Group-Requests: +2 in mediawiki/* for Zoranzoki21 - https://phabricator.wikimedia.org/T231758 (10Zoranzoki21) OK, I sent it right now again: {F30362666} It is here :) https://lists.wikimedia.org/pipermail/wikitech-l/2019-September/092536.html [21:49:26] (03CR) 10Gergő Tisza: [C: 03+1] "Nice!" [core] - 10https://gerrit.wikimedia.org/r/535657 (https://phabricator.wikimedia.org/T232506) (owner: 10Mainframe98) [22:03:28] (03PS1) 10DannyS712: Show link to test filter to all users who can use it [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536789 (https://phabricator.wikimedia.org/T232962) [22:03:59] (03PS2) 10DannyS712: Show link to test filter to all users who can use it [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/536789 (https://phabricator.wikimedia.org/T232962) [22:06:47] 10MediaWiki-extensions-SphinxSearch: Convert SphinxSearch to use extension registration - https://phabricator.wikimedia.org/T200513 (10svemir) a:05ntavares→03svemir Since there was no activity on this for over a year, I will take it over and submit the patch on gerrit. [22:09:26] 10MediaWiki-History-and-Diffs, 10Project-Admins: Split #MediaWiki-History-or-Diffs into #MediaWiki-Page-History and #MediaWiki-Page-Diffs - https://phabricator.wikimedia.org/T209651 (10Aklapper) [22:09:40] 10MediaWiki-History-and-Diffs, 10Project-Admins: Split #MediaWiki-History-or-Diffs into #MediaWiki-Page-History and #MediaWiki-Page-Diffs - https://phabricator.wikimedia.org/T209651 (10Aklapper) p:05Triage→03Low a:03Aklapper [22:25:51] 10WMEE: Särkide kunstiline kavand (meile arutamiseks hiljem sisendiks teostajale) - https://phabricator.wikimedia.org/T232637 (10mari-liis) Visandid särgidisainiks. {F30363487} {F30363488} {F30363490} {F30363489} {F30363486} [22:26:51] 10AbuseFilter: Have createuser variables include the email address (to potentially block re-registering) - https://phabricator.wikimedia.org/T47722 (10DannyS712) I suggest treating the email address similar to other sensitive data (like IPs) and require `abusefilter-privatedetails` to view it [22:41:36] 10MediaWiki-API, 10AbuseFilter, 10Core Platform Team, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), and 2 others: AbuseFilter should have an edit API - https://phabricator.wikimedia.org/T213037 (10DannyS712) 05Open→03Stalled Awaiting merge of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Abuse... [22:43:40] (03PS1) 10Svemir Brkic: Add extension registration to SphinxSearch [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/536790 (https://phabricator.wikimedia.org/T200513) [22:52:29] 10MediaWiki-extensions-SphinxSearch: page_counter removed from MW 1.25 - https://phabricator.wikimedia.org/T127177 (10svemir) 05Open→03Resolved a:03svemir This has been fixed with https://gerrit.wikimedia.org/r/517711 [22:53:31] 10MediaWiki-extensions-SphinxSearch, 10Patch-For-Review: SphinxMWSearch.php orders by page_counter, which was removed from page table in 1.25 - https://phabricator.wikimedia.org/T146995 (10svemir) This has been fixed with https://gerrit.wikimedia.org/r/517711 but i will take a look at the HitCounter patch as w... [23:07:52] (03Abandoned) 10Edward Chernenko: Example sphinx.conf: replace underscores with spaces in indexed titles [extensions/SphinxSearch] - 10https://gerrit.wikimedia.org/r/470792 (owner: 10Edward Chernenko) [23:12:33] (03PS1) 10Gergő Tisza: [WIP] JSON schema for Sentry [event-schemas] - 10https://gerrit.wikimedia.org/r/536791 [23:13:01] (03CR) 10jerkins-bot: [V: 04-1] [WIP] JSON schema for Sentry [event-schemas] - 10https://gerrit.wikimedia.org/r/536791 (owner: 10Gergő Tisza) [23:13:06] (03Abandoned) 10Gergő Tisza: [WIP] JSON schema for Sentry [event-schemas] - 10https://gerrit.wikimedia.org/r/536791 (owner: 10Gergő Tisza) [23:23:47] (03PS1) 10Gergő Tisza: Simple JS error logging schema [event-schemas] - 10https://gerrit.wikimedia.org/r/536792 (https://phabricator.wikimedia.org/T229442) [23:24:19] (03CR) 10jerkins-bot: [V: 04-1] Simple JS error logging schema [event-schemas] - 10https://gerrit.wikimedia.org/r/536792 (https://phabricator.wikimedia.org/T229442) (owner: 10Gergő Tisza) [23:32:40] (03PS2) 10Gergő Tisza: Simple JS error logging schema [event-schemas] - 10https://gerrit.wikimedia.org/r/536792 (https://phabricator.wikimedia.org/T229442) [23:33:11] (03CR) 10jerkins-bot: [V: 04-1] Simple JS error logging schema [event-schemas] - 10https://gerrit.wikimedia.org/r/536792 (https://phabricator.wikimedia.org/T229442) (owner: 10Gergő Tisza) [23:36:23] (03PS3) 10Gergő Tisza: Simple JS error logging schema [event-schemas] - 10https://gerrit.wikimedia.org/r/536792 (https://phabricator.wikimedia.org/T229442) [23:36:53] (03CR) 10jerkins-bot: [V: 04-1] Simple JS error logging schema [event-schemas] - 10https://gerrit.wikimedia.org/r/536792 (https://phabricator.wikimedia.org/T229442) (owner: 10Gergő Tisza) [23:54:51] (03CR) 10Gergő Tisza: "Ugh. I guess schema titles have to be unique, regardless of the path part of the name?" [event-schemas] - 10https://gerrit.wikimedia.org/r/536792 (https://phabricator.wikimedia.org/T229442) (owner: 10Gergő Tisza) [23:58:27] (03PS4) 10Gergő Tisza: Simple JS error logging schema [event-schemas] - 10https://gerrit.wikimedia.org/r/536792 (https://phabricator.wikimedia.org/T229442) [23:58:53] (03CR) 10jerkins-bot: [V: 04-1] Simple JS error logging schema [event-schemas] - 10https://gerrit.wikimedia.org/r/536792 (https://phabricator.wikimedia.org/T229442) (owner: 10Gergő Tisza)