[12:13:19] (03PS1) 10Samwilson: First draft [extensions/Discourse] - 10https://gerrit.wikimedia.org/r/534905 [12:14:48] (03PS2) 10Samwilson: First draft [extensions/Discourse] - 10https://gerrit.wikimedia.org/r/534905 (https://phabricator.wikimedia.org/T215053) [12:16:14] (03PS2) 10Daimona Eaytoy: Parse numbers with the new syntax, too [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/534903 (https://phabricator.wikimedia.org/T212730) [12:18:47] (03CR) 10jerkins-bot: [V: 04-1] Parse numbers with the new syntax, too [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/534903 (https://phabricator.wikimedia.org/T212730) (owner: 10Daimona Eaytoy) [12:20:00] (03CR) 10jerkins-bot: [V: 04-1] Parse numbers with the new syntax, too [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/534903 (https://phabricator.wikimedia.org/T212730) (owner: 10Daimona Eaytoy) [12:21:38] (03PS3) 10Samwilson: First draft [extensions/Discourse] - 10https://gerrit.wikimedia.org/r/534905 (https://phabricator.wikimedia.org/T215053) [12:50:00] (03PS3) 10Daimona Eaytoy: Parse numbers with the new syntax, too [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/534903 (https://phabricator.wikimedia.org/T212730) [13:07:28] (03PS1) 10Daimona Eaytoy: Suppress PhanUndeclaredProperty for code using custom properties [core] - 10https://gerrit.wikimedia.org/r/534907 [13:07:45] (03PS5) 10Daimona Eaytoy: Unsuppress another phan issue, part 9 [core] - 10https://gerrit.wikimedia.org/r/533895 (https://phabricator.wikimedia.org/T231636) [13:26:50] (03CR) 10jerkins-bot: [V: 04-1] Suppress PhanUndeclaredProperty for code using custom properties [core] - 10https://gerrit.wikimedia.org/r/534907 (owner: 10Daimona Eaytoy) [13:31:52] (03CR) 10jerkins-bot: [V: 04-1] Suppress PhanUndeclaredProperty for code using custom properties [core] - 10https://gerrit.wikimedia.org/r/534907 (owner: 10Daimona Eaytoy) [13:34:35] (03PS1) 10Daimona Eaytoy: auth: Use phan templates for getRequestByClass [core] - 10https://gerrit.wikimedia.org/r/534910 [13:35:38] (03PS6) 10Daimona Eaytoy: Unsuppress another phan issue, part 9 [core] - 10https://gerrit.wikimedia.org/r/533895 (https://phabricator.wikimedia.org/T231636) [13:38:30] (03PS7) 10Daimona Eaytoy: Unsuppress another phan issue, part 9 [core] - 10https://gerrit.wikimedia.org/r/533895 (https://phabricator.wikimedia.org/T231636) [13:48:30] (03PS1) 10Daimona Eaytoy: Remove two dead properties [core] - 10https://gerrit.wikimedia.org/r/534911 [13:49:39] (03PS2) 10Daimona Eaytoy: Suppress PhanUndeclaredProperty for code using custom properties [core] - 10https://gerrit.wikimedia.org/r/534907 [13:50:16] (03PS2) 10Daimona Eaytoy: auth: Use phan templates for getRequestByClass [core] - 10https://gerrit.wikimedia.org/r/534910 [13:50:26] (03PS2) 10Daimona Eaytoy: Remove two dead properties [core] - 10https://gerrit.wikimedia.org/r/534911 [13:52:05] (03PS3) 10Daimona Eaytoy: auth: Use phan templates for getRequestByClass [core] - 10https://gerrit.wikimedia.org/r/534910 [13:52:19] (03PS3) 10Daimona Eaytoy: Remove two dead properties [core] - 10https://gerrit.wikimedia.org/r/534911 [13:52:36] (03PS8) 10Daimona Eaytoy: Unsuppress another phan issue, part 9 [core] - 10https://gerrit.wikimedia.org/r/533895 (https://phabricator.wikimedia.org/T231636) [13:54:54] (03PS1) 10Daimona Eaytoy: Simplify maintenance/dumpUploads [core] - 10https://gerrit.wikimedia.org/r/534912 [13:57:52] (03PS3) 10Daimona Eaytoy: Suppress PhanUndeclaredProperty for custom properties and phan bugs [core] - 10https://gerrit.wikimedia.org/r/534907 [14:00:47] (03PS4) 10Daimona Eaytoy: Suppress PhanUndeclaredProperty for custom properties and phan bugs [core] - 10https://gerrit.wikimedia.org/r/534907 [14:02:02] (03PS5) 10Daimona Eaytoy: Suppress PhanUndeclaredProperty for custom properties and phan bugs [core] - 10https://gerrit.wikimedia.org/r/534907 [14:05:08] (03PS4) 10Daimona Eaytoy: Remove three dead properties [core] - 10https://gerrit.wikimedia.org/r/534911 [14:06:24] (03PS6) 10Daimona Eaytoy: Suppress PhanUndeclaredProperty for custom properties and phan bugs [core] - 10https://gerrit.wikimedia.org/r/534907 [14:07:31] (03PS2) 10Daimona Eaytoy: Simplify maintenance/dumpUploads [core] - 10https://gerrit.wikimedia.org/r/534912 [14:14:03] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress another phan issue, part 9 [core] - 10https://gerrit.wikimedia.org/r/533895 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [14:15:15] (03PS1) 10Artrix: Fix the settings icon [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/534913 [14:16:44] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress another phan issue, part 9 [core] - 10https://gerrit.wikimedia.org/r/533895 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [14:18:01] (03CR) 10jerkins-bot: [V: 04-1] auth: Use phan templates for getRequestByClass [core] - 10https://gerrit.wikimedia.org/r/534910 (owner: 10Daimona Eaytoy) [14:21:48] (03PS1) 10Daimona Eaytoy: Add a dedicated Exception for SessionOverflow [core] - 10https://gerrit.wikimedia.org/r/534914 [14:26:13] (03CR) 10jerkins-bot: [V: 04-1] Remove three dead properties [core] - 10https://gerrit.wikimedia.org/r/534911 (owner: 10Daimona Eaytoy) [14:26:32] (03CR) 10jerkins-bot: [V: 04-1] Suppress PhanUndeclaredProperty for custom properties and phan bugs [core] - 10https://gerrit.wikimedia.org/r/534907 (owner: 10Daimona Eaytoy) [14:28:18] (03CR) 10jerkins-bot: [V: 04-1] Simplify maintenance/dumpUploads [core] - 10https://gerrit.wikimedia.org/r/534912 (owner: 10Daimona Eaytoy) [14:31:12] (03CR) 10jerkins-bot: [V: 04-1] Suppress PhanUndeclaredProperty for custom properties and phan bugs [core] - 10https://gerrit.wikimedia.org/r/534907 (owner: 10Daimona Eaytoy) [14:38:49] (03PS1) 10Daimona Eaytoy: Better docs to make phan happy [core] - 10https://gerrit.wikimedia.org/r/534915 [14:40:49] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress another phan issue, part 9 [core] - 10https://gerrit.wikimedia.org/r/533895 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [14:46:39] (03PS8) 10Mainframe98: Use ObjectFactory to create API modules [core] - 10https://gerrit.wikimedia.org/r/534788 (https://phabricator.wikimedia.org/T222388) [14:47:24] (03PS4) 10Daimona Eaytoy: auth: Use phan templates for getRequestByClass [core] - 10https://gerrit.wikimedia.org/r/534910 [14:47:38] (03PS5) 10Daimona Eaytoy: Remove three dead properties [core] - 10https://gerrit.wikimedia.org/r/534911 [14:48:04] (03PS3) 10Daimona Eaytoy: Simplify maintenance/dumpUploads [core] - 10https://gerrit.wikimedia.org/r/534912 [14:48:06] (03CR) 10jerkins-bot: [V: 04-1] Add a dedicated Exception for SessionOverflow [core] - 10https://gerrit.wikimedia.org/r/534914 (owner: 10Daimona Eaytoy) [14:48:24] (03PS2) 10Daimona Eaytoy: Add a dedicated Exception for SessionOverflow [core] - 10https://gerrit.wikimedia.org/r/534914 [14:49:35] (03PS6) 10Mainframe98: Support the creation of special pages with services injected [core] - 10https://gerrit.wikimedia.org/r/534770 (https://phabricator.wikimedia.org/T222388) [14:56:46] (03CR) 10Mainframe98: "check php" [core] - 10https://gerrit.wikimedia.org/r/534770 (https://phabricator.wikimedia.org/T222388) (owner: 10Mainframe98) [15:00:12] (03CR) 10jerkins-bot: [V: 04-1] Better docs to make phan happy [core] - 10https://gerrit.wikimedia.org/r/534915 (owner: 10Daimona Eaytoy) [15:03:02] (03CR) 10Mholloway: [C: 03+2] Add linters and apply automated fixes to JS and LESS files [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/534700 (owner: 10Eric Gardner) [15:09:51] (03PS5) 10Daimona Eaytoy: auth: Use phan templates for getRequestByClass [core] - 10https://gerrit.wikimedia.org/r/534910 [15:13:24] I'm surprised that no test job appears on https://integration.wikimedia.org/zuul/ for newly sent patch https://gerrit.wikimedia.org/r/#/c/pywikibot/core/+/534916/, any idea? [15:15:20] Framawiki it'll likley be because they have not been whitelisted in zuul [15:16:53] paladox: hi, but there is no +1 for not whitelisted accounts? (as opposite of +2 for verified ones)? [15:17:41] By the looks of things the pywiki bot tests use the tests only whitelisted users are allowed to run. [15:18:18] the test pipeline is for whitelisted users only. There use to be a checks pipeline but that was removed. (that was for non whitelisted users) [15:18:55] the checks pipeline was removed globally for all repos or only for pwb? [15:19:22] it was removed from zuul [15:19:33] well the config (not zuul source code) [15:20:42] ok that explain, thanks! [15:29:21] (03CR) 10jerkins-bot: [V: 04-1] auth: Use phan templates for getRequestByClass [core] - 10https://gerrit.wikimedia.org/r/534910 (owner: 10Daimona Eaytoy) [15:30:47] (03PS3) 10Krinkle: resourceloader: Add $conf parameter to the 'ResourceLoaderGetConfigVars' hook [core] - 10https://gerrit.wikimedia.org/r/534843 (owner: 10Jack Phoenix) [15:33:27] (03CR) 10Krinkle: [C: 03+1] "LGTM. Somewhat related: May I ask what kinds of variables WikiHow exports through here? Long-term this is a hook I may be looking to depre" [core] - 10https://gerrit.wikimedia.org/r/534843 (owner: 10Jack Phoenix) [15:34:25] (03PS11) 10Krinkle: Deprecate mediawiki.RegExp; move only function to mw.util [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) (owner: 10Jforrester) [15:34:45] (03Merged) 10jenkins-bot: Add linters and apply automated fixes to JS and LESS files [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/534700 (owner: 10Eric Gardner) [15:39:26] (03PS6) 10Daimona Eaytoy: Remove dead properties [core] - 10https://gerrit.wikimedia.org/r/534911 [15:40:26] (03PS6) 10Daimona Eaytoy: auth: Use phan templates for getRequestByClass [core] - 10https://gerrit.wikimedia.org/r/534910 [15:40:34] (03PS7) 10Daimona Eaytoy: Remove dead properties [core] - 10https://gerrit.wikimedia.org/r/534911 [15:40:45] (03PS4) 10Daimona Eaytoy: Simplify maintenance/dumpUploads [core] - 10https://gerrit.wikimedia.org/r/534912 [15:40:54] (03PS3) 10Daimona Eaytoy: Add a dedicated Exception for SessionOverflow [core] - 10https://gerrit.wikimedia.org/r/534914 [15:41:04] (03PS2) 10Daimona Eaytoy: Better docs to make phan happy [core] - 10https://gerrit.wikimedia.org/r/534915 [15:45:22] (03PS8) 10Daimona Eaytoy: Remove dead properties [core] - 10https://gerrit.wikimedia.org/r/534911 [15:46:56] (03PS1) 10Daimona Eaytoy: Change single-scope properties to local variables [core] - 10https://gerrit.wikimedia.org/r/534920 [15:50:44] (03CR) 10Daimona Eaytoy: "FTR, I'm splitting this into small patches, starting with https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/534910/. They're in a depend" [core] - 10https://gerrit.wikimedia.org/r/533895 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [15:52:30] (03CR) 10Krinkle: [C: 03+2] Deprecate mediawiki.RegExp; move only function to mw.util [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) (owner: 10Jforrester) [15:59:54] (03PS3) 10Daimona Eaytoy: Add isValidExplicitRange function [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/522989 (https://phabricator.wikimedia.org/T218074) [16:03:10] (03CR) 10Krinkle: Remove dead properties (031 comment) [core] - 10https://gerrit.wikimedia.org/r/534911 (owner: 10Daimona Eaytoy) [16:09:56] (03CR) 10Krinkle: [C: 04-1] "LGTM, but the " - " seems like user interface that shouldn't be in the library. Can we require AbuseFilter to take those as 2nd and 3rd pa" [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/522989 (https://phabricator.wikimedia.org/T218074) (owner: 10Daimona Eaytoy) [16:17:26] (03PS9) 10Daimona Eaytoy: Remove dead properties [core] - 10https://gerrit.wikimedia.org/r/534911 [16:17:42] (03CR) 10Daimona Eaytoy: Remove dead properties (031 comment) [core] - 10https://gerrit.wikimedia.org/r/534911 (owner: 10Daimona Eaytoy) [16:20:44] (03CR) 10Daimona Eaytoy: "> LGTM, but the " - " seems like user interface that shouldn't be in" [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/522989 (https://phabricator.wikimedia.org/T218074) (owner: 10Daimona Eaytoy) [16:22:00] (03Merged) 10jenkins-bot: Deprecate mediawiki.RegExp; move only function to mw.util [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) (owner: 10Jforrester) [16:34:22] (03CR) 10Krinkle: [C: 04-1] "Yeah keeping compat is fine. Perhaps AF can additionally support them as separate parameters going forward and " *- *" split them for comp" [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/522989 (https://phabricator.wikimedia.org/T218074) (owner: 10Daimona Eaytoy) [16:35:04] (03PS10) 10Krinkle: Remove dead properties [core] - 10https://gerrit.wikimedia.org/r/534911 (owner: 10Daimona Eaytoy) [16:37:25] (03CR) 10jenkins-bot: Deprecate mediawiki.RegExp; move only function to mw.util [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) (owner: 10Jforrester) [16:38:17] (03CR) 10Krinkle: [C: 03+2] Remove dead properties [core] - 10https://gerrit.wikimedia.org/r/534911 (owner: 10Daimona Eaytoy) [16:39:53] (03PS5) 10Krinkle: Simplify maintenance/dumpUploads [core] - 10https://gerrit.wikimedia.org/r/534912 (owner: 10Daimona Eaytoy) [16:39:58] (03CR) 10Krinkle: [C: 03+2] Simplify maintenance/dumpUploads [core] - 10https://gerrit.wikimedia.org/r/534912 (owner: 10Daimona Eaytoy) [16:40:07] (03CR) 10Matěj Suchánek: "Random idea: is it necessary to verify we don't allow invalid digits, eg. 8 or 9 in octals etc.?" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/534903 (https://phabricator.wikimedia.org/T212730) (owner: 10Daimona Eaytoy) [16:40:34] (03PS2) 10Fomafix: Remove redundant closures in module 'mediawiki.util' [core] - 10https://gerrit.wikimedia.org/r/534762 (https://phabricator.wikimedia.org/T50886) [16:41:39] (03PS6) 10Fomafix: Remove redundant closure for all modules with packageFiles [core] - 10https://gerrit.wikimedia.org/r/512519 (https://phabricator.wikimedia.org/T50886) [16:44:25] (03CR) 10Daimona Eaytoy: "> Yeah keeping compat is fine. Perhaps AF can additionally support" [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/522989 (https://phabricator.wikimedia.org/T218074) (owner: 10Daimona Eaytoy) [16:47:22] (03PS3) 10Krinkle: Better docs to make phan happy [core] - 10https://gerrit.wikimedia.org/r/534915 (owner: 10Daimona Eaytoy) [16:48:28] (03CR) 10jerkins-bot: [V: 04-1] Remove redundant closure for all modules with packageFiles [core] - 10https://gerrit.wikimedia.org/r/512519 (https://phabricator.wikimedia.org/T50886) (owner: 10Fomafix) [16:49:50] (03CR) 10jerkins-bot: [V: 04-1] Remove redundant closure for all modules with packageFiles [core] - 10https://gerrit.wikimedia.org/r/512519 (https://phabricator.wikimedia.org/T50886) (owner: 10Fomafix) [16:52:14] (03PS1) 10TK-999: LinkCache: Use an injected ILoadBalancer instance [core] - 10https://gerrit.wikimedia.org/r/534924 [16:53:22] (03CR) 10Fomafix: "Fresnel: -34 B" [core] - 10https://gerrit.wikimedia.org/r/534762 (https://phabricator.wikimedia.org/T50886) (owner: 10Fomafix) [16:54:08] (03CR) 10Krinkle: [C: 04-1] "Yeah the code method supports it as user-input for Special:Block, although I'm unsure if that was ever properly exposed or tested. The log" [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/522989 (https://phabricator.wikimedia.org/T218074) (owner: 10Daimona Eaytoy) [16:54:30] (03CR) 10jerkins-bot: [V: 04-1] LinkCache: Use an injected ILoadBalancer instance [core] - 10https://gerrit.wikimedia.org/r/534924 (owner: 10TK-999) [16:55:51] (03PS3) 10Krinkle: mediawiki.util: Remove redundant file closures [core] - 10https://gerrit.wikimedia.org/r/534762 (https://phabricator.wikimedia.org/T50886) (owner: 10Fomafix) [16:55:54] (03CR) 10Krinkle: [C: 03+2] mediawiki.util: Remove redundant file closures [core] - 10https://gerrit.wikimedia.org/r/534762 (https://phabricator.wikimedia.org/T50886) (owner: 10Fomafix) [16:57:02] (03CR) 10Daimona Eaytoy: "> Random idea: is it necessary to verify we don't allow invalid" (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/534903 (https://phabricator.wikimedia.org/T212730) (owner: 10Daimona Eaytoy) [16:58:14] (03CR) 10Daimona Eaytoy: "> Yeah the code method supports it as user-input for Special:Block," [libs/IPUtils] - 10https://gerrit.wikimedia.org/r/522989 (https://phabricator.wikimedia.org/T218074) (owner: 10Daimona Eaytoy) [16:58:22] (03CR) 10Krinkle: [C: 03+1] Better docs to make phan happy [core] - 10https://gerrit.wikimedia.org/r/534915 (owner: 10Daimona Eaytoy) [16:58:34] (03PS2) 10Krinkle: Change single-scope properties to local variables [core] - 10https://gerrit.wikimedia.org/r/534920 (owner: 10Daimona Eaytoy) [16:59:31] (03PS3) 10Krinkle: Simplify some code by changing single-scope properties to local variables [core] - 10https://gerrit.wikimedia.org/r/534920 (owner: 10Daimona Eaytoy) [17:01:18] (03PS2) 10TK-999: LinkCache: Use an injected ILoadBalancer instance [core] - 10https://gerrit.wikimedia.org/r/534924 [17:01:58] (03Merged) 10jenkins-bot: Remove dead properties [core] - 10https://gerrit.wikimedia.org/r/534911 (owner: 10Daimona Eaytoy) [17:04:00] (03CR) 10jerkins-bot: [V: 04-1] Remove redundant closure for all modules with packageFiles [core] - 10https://gerrit.wikimedia.org/r/512519 (https://phabricator.wikimedia.org/T50886) (owner: 10Fomafix) [17:04:52] (03CR) 10Krinkle: [C: 03+2] Simplify some code by changing single-scope properties to local variables [core] - 10https://gerrit.wikimedia.org/r/534920 (owner: 10Daimona Eaytoy) [17:12:33] (03CR) 10Krinkle: [C: 03+2] Better docs to make phan happy [core] - 10https://gerrit.wikimedia.org/r/534915 (owner: 10Daimona Eaytoy) [17:13:25] (03Merged) 10jenkins-bot: Simplify maintenance/dumpUploads [core] - 10https://gerrit.wikimedia.org/r/534912 (owner: 10Daimona Eaytoy) [17:16:13] (03CR) 10jerkins-bot: [V: 04-1] LinkCache: Use an injected ILoadBalancer instance [core] - 10https://gerrit.wikimedia.org/r/534924 (owner: 10TK-999) [17:19:34] (03CR) 10Krinkle: [C: 03+1] ChangesListSpecialPage: Cache the change tag list and its summary (031 comment) [core] - 10https://gerrit.wikimedia.org/r/525882 (https://phabricator.wikimedia.org/T223260) (owner: 10Catrope) [17:20:00] (03Merged) 10jenkins-bot: mediawiki.util: Remove redundant file closures [core] - 10https://gerrit.wikimedia.org/r/534762 (https://phabricator.wikimedia.org/T50886) (owner: 10Fomafix) [17:20:21] (03CR) 10jenkins-bot: Remove dead properties [core] - 10https://gerrit.wikimedia.org/r/534911 (owner: 10Daimona Eaytoy) [17:20:34] (03CR) 10jerkins-bot: [V: 04-1] LinkCache: Use an injected ILoadBalancer instance [core] - 10https://gerrit.wikimedia.org/r/534924 (owner: 10TK-999) [17:21:46] (03CR) 10Krinkle: [C: 03+2] Remove mapping from jQuery to $ in closure [extensions/InlineCategorizer] - 10https://gerrit.wikimedia.org/r/534116 (owner: 10Fomafix) [17:25:32] (03CR) 10Krinkle: SkinMetrolook: Call parent::__construct in constructor (031 comment) [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/509624 (owner: 10Fomafix) [17:28:45] (03CR) 10Krinkle: "There are relatively few use cases for a user-generated regex to be executed in production. Something that should generally be taken very " [core] - 10https://gerrit.wikimedia.org/r/458203 (owner: 10Daimona Eaytoy) [17:29:07] (03PS3) 10Krinkle: Use quickUserCan to decide whether to display the rollback link [core] - 10https://gerrit.wikimedia.org/r/503276 (owner: 10Daimona Eaytoy) [17:36:07] (03Merged) 10jenkins-bot: Better docs to make phan happy [core] - 10https://gerrit.wikimedia.org/r/534915 (owner: 10Daimona Eaytoy) [17:36:07] (03CR) 10Krinkle: "Would you prefer a unified check for all of these that shows less information than before (e.g. the config vars, before expansion)." [core] - 10https://gerrit.wikimedia.org/r/533701 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [17:37:16] (03CR) 10jenkins-bot: Simplify maintenance/dumpUploads [core] - 10https://gerrit.wikimedia.org/r/534912 (owner: 10Daimona Eaytoy) [17:42:14] (03Merged) 10jenkins-bot: Simplify some code by changing single-scope properties to local variables [core] - 10https://gerrit.wikimedia.org/r/534920 (owner: 10Daimona Eaytoy) [17:42:16] (03Merged) 10jenkins-bot: Remove mapping from jQuery to $ in closure [extensions/InlineCategorizer] - 10https://gerrit.wikimedia.org/r/534116 (owner: 10Fomafix) [17:44:49] (03CR) 10Daimona Eaytoy: "> There are relatively few use cases for a user-generated regex to be" [core] - 10https://gerrit.wikimedia.org/r/458203 (owner: 10Daimona Eaytoy) [17:44:59] (03PS4) 10Daimona Eaytoy: Add an utility function to tell if a string is a valid regex [core] - 10https://gerrit.wikimedia.org/r/458203 [17:48:58] (03PS5) 10Daimona Eaytoy: Add an utility function to tell if a string is a valid regex [core] - 10https://gerrit.wikimedia.org/r/458203 [17:50:16] (03CR) 10Krinkle: [C: 03+1] "LGTM. Will hold off on landing until we have a patch that uses it (to avoid unused code). But no blockers." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/458203 (owner: 10Daimona Eaytoy) [17:52:10] (03PS6) 10Daimona Eaytoy: Add an utility function to tell if a string is a valid regex [core] - 10https://gerrit.wikimedia.org/r/458203 [17:52:31] (03CR) 10Daimona Eaytoy: ">" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/458203 (owner: 10Daimona Eaytoy) [17:54:44] (03CR) 10jerkins-bot: [V: 04-1] Use quickUserCan to decide whether to display the rollback link [core] - 10https://gerrit.wikimedia.org/r/503276 (owner: 10Daimona Eaytoy) [17:56:44] (03CR) 10jenkins-bot: mediawiki.util: Remove redundant file closures [core] - 10https://gerrit.wikimedia.org/r/534762 (https://phabricator.wikimedia.org/T50886) (owner: 10Fomafix) [18:08:27] (03PS4) 10Krinkle: DifferenceEngine: Use quickUserCan for display of rollback link [core] - 10https://gerrit.wikimedia.org/r/503276 (https://phabricator.wikimedia.org/T232258) (owner: 10Daimona Eaytoy) [18:09:28] (03PS5) 10Daimona Eaytoy: DifferenceEngine: Use quickUserCan for display of rollback link [core] - 10https://gerrit.wikimedia.org/r/503276 (https://phabricator.wikimedia.org/T232258) [18:09:41] (03CR) 10Krinkle: [C: 03+1] Add a dedicated Exception for SessionOverflow [core] - 10https://gerrit.wikimedia.org/r/534914 (owner: 10Daimona Eaytoy) [18:10:21] (03CR) 10jenkins-bot: Better docs to make phan happy [core] - 10https://gerrit.wikimedia.org/r/534915 (owner: 10Daimona Eaytoy) [18:11:22] (03PS1) 10Daimona Eaytoy: Use StringUtils::isValidRegex [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/534925 [18:11:37] (03CR) 10jerkins-bot: [V: 04-1] Add an utility function to tell if a string is a valid regex [core] - 10https://gerrit.wikimedia.org/r/458203 (owner: 10Daimona Eaytoy) [18:13:36] (03PS2) 10Daimona Eaytoy: Use StringUtils::isValidRegex [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/534925 [18:15:23] (03PS7) 10Daimona Eaytoy: Add an utility function to tell if a string is a valid regex [core] - 10https://gerrit.wikimedia.org/r/458203 [18:15:29] (03CR) 10jerkins-bot: [V: 04-1] Use StringUtils::isValidRegex [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/534925 (owner: 10Daimona Eaytoy) [18:15:31] (03CR) 10jerkins-bot: [V: 04-1] Use StringUtils::isValidRegex [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/534925 (owner: 10Daimona Eaytoy) [18:15:43] (03CR) 10Daimona Eaytoy: ">" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/458203 (owner: 10Daimona Eaytoy) [18:19:36] (03CR) 10Matěj Suchánek: "> > Random idea: is it necessary to verify we don't allow invalid" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/534903 (https://phabricator.wikimedia.org/T212730) (owner: 10Daimona Eaytoy) [18:21:58] (03PS1) 10Gerrit Patch Uploader: [1] I meet an exception with long tweet on MediaWiki 1.32 and Extension:TweetANew. Because $wgLang->mb_substr() not work in MediaWiki 1.32. And mbstring library required since MediaWiki 1.27. https://www.mediawiki.org/wiki/Manual:Installation_requirements#PHP [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/534926 [18:22:00] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/534926 (owner: 10Gerrit Patch Uploader) [18:22:44] (03CR) 10Daimona Eaytoy: [C: 04-1] "> > > Random idea: is it necessary to verify we don't allow invalid" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/534903 (https://phabricator.wikimedia.org/T212730) (owner: 10Daimona Eaytoy) [18:28:38] (03CR) 10jenkins-bot: Simplify some code by changing single-scope properties to local variables [core] - 10https://gerrit.wikimedia.org/r/534920 (owner: 10Daimona Eaytoy) [18:52:48] (03PS8) 10Krinkle: StringUtils: Add a utility for checking if a string is a valid regex [core] - 10https://gerrit.wikimedia.org/r/458203 (owner: 10Daimona Eaytoy) [18:52:51] (03CR) 10Krinkle: [C: 03+1] StringUtils: Add a utility for checking if a string is a valid regex [core] - 10https://gerrit.wikimedia.org/r/458203 (owner: 10Daimona Eaytoy) [18:53:13] (03CR) 10Krinkle: [C: 03+1] "@Daniel/@Tim: Would this be okay to ship in core?" [core] - 10https://gerrit.wikimedia.org/r/458203 (owner: 10Daimona Eaytoy) [19:16:07] (03CR) 10Krinkle: [C: 03+1] Allow dangling commas in variargs (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/534842 (https://phabricator.wikimedia.org/T153251) (owner: 10Daimona Eaytoy) [19:24:48] (03CR) 10Krinkle: "Interesting feature :)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/534910 (owner: 10Daimona Eaytoy) [19:38:36] (03CR) 10Jforrester: [C: 03+1] DifferenceEngine: Use quickUserCan for display of rollback link [core] - 10https://gerrit.wikimedia.org/r/503276 (https://phabricator.wikimedia.org/T232258) (owner: 10Daimona Eaytoy) [19:41:32] (03CR) 10Jforrester: [C: 03+2] Use getter to get user block in SpecialContact [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/534820 (owner: 10Tchanders) [19:43:37] (03CR) 10Jforrester: [C: 03+2] Get GenderCache from MediaWikiServices [extensions/OnlineStatusBar] - 10https://gerrit.wikimedia.org/r/530958 (owner: 10Umherirrender) [19:46:02] (03PS3) 10Jforrester: Remove entry point check for files that only contain classes [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/528852 (https://phabricator.wikimedia.org/T230026) (owner: 10Umherirrender) [19:46:31] (03CR) 10Jforrester: [C: 03+2] Remove entry point check for files that only contain classes [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/528852 (https://phabricator.wikimedia.org/T230026) (owner: 10Umherirrender) [19:46:54] (03Merged) 10jenkins-bot: Use getter to get user block in SpecialContact [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/534820 (owner: 10Tchanders) [19:47:45] (03Merged) 10jenkins-bot: Get GenderCache from MediaWikiServices [extensions/OnlineStatusBar] - 10https://gerrit.wikimedia.org/r/530958 (owner: 10Umherirrender) [19:50:44] (03Merged) 10jenkins-bot: Remove entry point check for files that only contain classes [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/528852 (https://phabricator.wikimedia.org/T230026) (owner: 10Umherirrender) [19:51:19] (03CR) 10Jforrester: [C: 03+2] languages: Add NS_CATEGORY and #REDIRECT for hyw [core] - 10https://gerrit.wikimedia.org/r/532089 (https://phabricator.wikimedia.org/T229656) (owner: 10Ladsgroup) [20:09:30] (03PS4) 10Zoranzoki21: Convert OnlineStatusBar to use extension registration [extensions/OnlineStatusBar] - 10https://gerrit.wikimedia.org/r/503686 (https://phabricator.wikimedia.org/T220014) [20:11:38] (03CR) 10Zoranzoki21: "Cool!" [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/534926 (owner: 10Gerrit Patch Uploader) [20:11:49] (03CR) 10Zoranzoki21: "recheck" [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/534926 (owner: 10Gerrit Patch Uploader) [20:12:55] (03CR) 10jerkins-bot: [V: 04-1] [1] I meet an exception with long tweet on MediaWiki 1.32 and Extension:TweetANew. Because $wgLang->mb_substr() not work in MediaWiki 1.32. And mbstring library required since MediaWiki 1.27. https://www.mediawiki.org/wiki/Manual:Installation_requirements#PHP [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/534926 (owner: 10Gerrit Patch Uploader) [20:16:44] (03PS2) 10Zoranzoki21: Remove getBody from TablePager as it is deprected since 1.24 [core] - 10https://gerrit.wikimedia.org/r/519671 [20:17:26] (03PS3) 10Zoranzoki21: Remove uses of 'cols' and 'rows' preferences from TinyMCE extension [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/488431 (https://phabricator.wikimedia.org/T155153) [20:17:28] (03PS4) 10Zoranzoki21: Remove uses of 'cols' and 'rows' preferences from TinyMCE extension [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/488431 (https://phabricator.wikimedia.org/T155153) [20:19:33] (03PS12) 10Zoranzoki21: Convert Survey to use extension registration [extensions/Survey] - 10https://gerrit.wikimedia.org/r/424865 (https://phabricator.wikimedia.org/T191728) [20:20:29] (03CR) 10jerkins-bot: [V: 04-1] languages: Add NS_CATEGORY and #REDIRECT for hyw [core] - 10https://gerrit.wikimedia.org/r/532089 (https://phabricator.wikimedia.org/T229656) (owner: 10Ladsgroup) [20:21:59] (03CR) 10jerkins-bot: [V: 04-1] Convert Survey to use extension registration [extensions/Survey] - 10https://gerrit.wikimedia.org/r/424865 (https://phabricator.wikimedia.org/T191728) (owner: 10Zoranzoki21) [20:24:24] (03PS10) 10Zoranzoki21: Convert TweetANew to use extension registration [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/460752 (https://phabricator.wikimedia.org/T204338) [20:24:53] (03PS10) 10Zoranzoki21: Convert Duplicator to use extension registration [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/481949 (https://phabricator.wikimedia.org/T212044) [20:25:54] (03PS4) 10Zoranzoki21: Convert ExtraLanguageLink to extension registration [extensions/ExtraLanguageLink] - 10https://gerrit.wikimedia.org/r/481970 (https://phabricator.wikimedia.org/T204117) [20:25:56] (03CR) 10jerkins-bot: [V: 04-1] Convert TweetANew to use extension registration [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/460752 (https://phabricator.wikimedia.org/T204338) (owner: 10Zoranzoki21) [20:26:36] (03PS3) 10Zoranzoki21: Remove uses of 'cols' and 'rows' preferences from Form extension [extensions/Form] - 10https://gerrit.wikimedia.org/r/488429 (https://phabricator.wikimedia.org/T155153) [20:26:57] (03PS3) 10Zoranzoki21: Remove uses of 'cols' and 'rows' preferences from SecureHTML extension [extensions/SecureHTML] - 10https://gerrit.wikimedia.org/r/488430 (https://phabricator.wikimedia.org/T155153) [20:27:47] (03PS4) 10Zoranzoki21: Remove PHP entry point [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/501933 (https://phabricator.wikimedia.org/T140007) [20:28:59] (03PS3) 10Zoranzoki21: Add config-sidebar message in RawHtmlMessages at DefaultSettings.php [core] - 10https://gerrit.wikimedia.org/r/509579 (https://phabricator.wikimedia.org/T223000) [20:31:30] (03Abandoned) 10Zoranzoki21: Fix entites typos [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/532855 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [20:31:51] (03PS2) 10Zoranzoki21: Fully implemented GRAMMAR in Serbian [core] - 10https://gerrit.wikimedia.org/r/533544 (https://phabricator.wikimedia.org/T35546) [20:32:21] (03PS3) 10Zoranzoki21: Full implementation of GRAMMAR in Serbian [core] - 10https://gerrit.wikimedia.org/r/533544 (https://phabricator.wikimedia.org/T35546) [20:38:00] (03PS2) 10Mooeypoo: HTMLFormField: Add getOOUIStyles() for early-loading styles when needed [core] - 10https://gerrit.wikimedia.org/r/534886 [20:44:29] (03Abandoned) 10Zoranzoki21: Split maintenance/storage/recompressTracked.php to have one class in one file [core] - 10https://gerrit.wikimedia.org/r/506919 (owner: 10Zoranzoki21) [20:52:29] (03CR) 10jerkins-bot: [V: 04-1] Full implementation of GRAMMAR in Serbian [core] - 10https://gerrit.wikimedia.org/r/533544 (https://phabricator.wikimedia.org/T35546) (owner: 10Zoranzoki21) [21:04:07] (03CR) 10Jack Phoenix: "> LGTM. Somewhat related: May I ask what kinds of variables WikiHow" [core] - 10https://gerrit.wikimedia.org/r/534843 (owner: 10Jack Phoenix) [21:59:12] (03PS1) 10Aaron Schulz: filebackend: optimize the chmod() calls in FSFileBackend [core] - 10https://gerrit.wikimedia.org/r/534928 [21:59:14] (03PS1) 10Aaron Schulz: filebackend: optimize 'delete' for FSFileBackend to avoid is_file() calls [core] - 10https://gerrit.wikimedia.org/r/534929 [21:59:15] (03PS1) 10Aaron Schulz: filebackend: optimize 'move' in FSFileBackend to avoid is_file() calls [core] - 10https://gerrit.wikimedia.org/r/534930 [21:59:18] (03PS1) 10Aaron Schulz: filebackend: optimize 'create', 'store', and 'copy' in FSFileBackend [core] - 10https://gerrit.wikimedia.org/r/534931 [22:02:18] (03PS2) 10Aaron Schulz: filebackend: optimize the chmod() calls in FSFileBackend [core] - 10https://gerrit.wikimedia.org/r/534928 [22:06:47] (03PS2) 10Aaron Schulz: filebackend: optimize 'delete' for FSFileBackend to avoid is_file() calls [core] - 10https://gerrit.wikimedia.org/r/534929 [22:07:03] (03PS2) 10Aaron Schulz: filebackend: optimize 'move' in FSFileBackend to avoid is_file() calls [core] - 10https://gerrit.wikimedia.org/r/534930 [22:07:25] (03CR) 10jerkins-bot: [V: 04-1] filebackend: optimize 'move' in FSFileBackend to avoid is_file() calls [core] - 10https://gerrit.wikimedia.org/r/534930 (owner: 10Aaron Schulz) [22:07:28] (03CR) 10jerkins-bot: [V: 04-1] filebackend: optimize 'create', 'store', and 'copy' in FSFileBackend [core] - 10https://gerrit.wikimedia.org/r/534931 (owner: 10Aaron Schulz) [22:07:29] (03CR) 10jerkins-bot: [V: 04-1] filebackend: optimize 'move' in FSFileBackend to avoid is_file() calls [core] - 10https://gerrit.wikimedia.org/r/534930 (owner: 10Aaron Schulz) [22:07:33] (03CR) 10jerkins-bot: [V: 04-1] filebackend: optimize 'create', 'store', and 'copy' in FSFileBackend [core] - 10https://gerrit.wikimedia.org/r/534931 (owner: 10Aaron Schulz) [22:07:33] (03CR) 10jerkins-bot: [V: 04-1] filebackend: optimize 'create', 'store', and 'copy' in FSFileBackend [core] - 10https://gerrit.wikimedia.org/r/534931 (owner: 10Aaron Schulz) [22:07:35] (03CR) 10jerkins-bot: [V: 04-1] filebackend: optimize 'move' in FSFileBackend to avoid is_file() calls [core] - 10https://gerrit.wikimedia.org/r/534930 (owner: 10Aaron Schulz) [22:07:38] (03CR) 10jerkins-bot: [V: 04-1] filebackend: optimize 'create', 'store', and 'copy' in FSFileBackend [core] - 10https://gerrit.wikimedia.org/r/534931 (owner: 10Aaron Schulz) [22:14:42] (03CR) 10jerkins-bot: [V: 04-1] filebackend: optimize 'delete' for FSFileBackend to avoid is_file() calls [core] - 10https://gerrit.wikimedia.org/r/534929 (owner: 10Aaron Schulz) [22:14:44] (03CR) 10jerkins-bot: [V: 04-1] filebackend: optimize 'delete' for FSFileBackend to avoid is_file() calls [core] - 10https://gerrit.wikimedia.org/r/534929 (owner: 10Aaron Schulz) [22:19:07] (03PS3) 10Aaron Schulz: filebackend: optimize 'move' in FSFileBackend to avoid is_file() calls [core] - 10https://gerrit.wikimedia.org/r/534930 [22:19:19] (03PS2) 10Aaron Schulz: filebackend: optimize 'create', 'store', and 'copy' in FSFileBackend [core] - 10https://gerrit.wikimedia.org/r/534931 [22:30:46] (03PS2) 10Aaron Schulz: filebackend: rename and simplify header sanitizing methods in SwiftFileBackend [core] - 10https://gerrit.wikimedia.org/r/534031 [23:45:13] (03PS1) 10Krinkle: block: Allow cookie-block tracking from any uncached web request [core] - 10https://gerrit.wikimedia.org/r/534933 [23:52:03] (03CR) 10Krinkle: [C: 03+2] filebackend: optimize the chmod() calls in FSFileBackend [core] - 10https://gerrit.wikimedia.org/r/534928 (owner: 10Aaron Schulz) [23:53:35] (03PS2) 10Krinkle: block: Allow cookie-block tracking from any uncached web request [core] - 10https://gerrit.wikimedia.org/r/534933