[00:02:21] 04(no projects): Regression in first paint? - https://phabricator.wikimedia.org/T232174 (10Jdlrobson) [00:04:20] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Proposal: Provide a single-module registration mechanism for skin modules in ResourceLoader - https://phabricator.wikimedia.org/T232148 (10Krinkle) @Isarra That's an interesting idea. Roan had the same idea a few weeks back. Unfortunately, that's not compatib... [00:04:36] (03PS3) 10Jforrester: Deprecate mediawiki.RegExp and jquery.accessKeyLabel; move into mw.util [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) [00:04:58] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10TemplateData, 10VisualEditor: TemplateData - https://phabricator.wikimedia.org/T232168 (10Krinkle) a:05Krinkle→03None [00:06:26] (03PS2) 10Jdlrobson: Dev: parseBlockInfo moved off of EditorOverlayBase [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/534670 [00:07:21] (03Merged) 10jenkins-bot: Prevent all users from having a password in the blacklist [core] - 10https://gerrit.wikimedia.org/r/477487 (https://phabricator.wikimedia.org/T151425) (owner: 10Reedy) [00:07:23] (03Merged) 10jenkins-bot: Fix for handling of "group by" and "having" in #cargo_compound_query [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/534709 (owner: 10Yaron Koren) [00:08:19] (03CR) 10jerkins-bot: [V: 04-1] WIP: MainMenu is a controller not a View and server rendered [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/534711 (owner: 10Jdlrobson) [00:09:08] 10Core Platform Team, 10CPT Initiatives (Core REST API in PHP): Enable cross-origin resource sharing - https://phabricator.wikimedia.org/T232176 (10dbarratt) [00:09:20] 10Core Platform Team, 10CPT Initiatives (Core REST API in PHP): Enable cross-origin resource sharing (CORS) - https://phabricator.wikimedia.org/T232176 (10dbarratt) [00:09:43] (03CR) 10jenkins-bot: Fix for handling of "group by" and "having" in #cargo_compound_query [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/534709 (owner: 10Yaron Koren) [00:10:41] (03CR) 10Bartosz Dziewoński: [C: 04-1] "The jquery.accessKeyLabel change would be the exact opposite of what we did some years ago: https://gerrit.wikimedia.org/r/c/mediawiki/cor" [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) (owner: 10Jforrester) [00:10:46] (03PS1) 10Ammarpad: Remove unneeded CSS for thanks toast link [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/534712 (https://phabricator.wikimedia.org/T232102) [00:10:51] (03CR) 10Bartosz Dziewoński: Deprecate mediawiki.RegExp and jquery.accessKeyLabel; move into mw.util [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) (owner: 10Jforrester) [00:11:10] (03CR) 10Bartosz Dziewoński: "(didn't mean to -1)" [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) (owner: 10Jforrester) [00:14:43] (03CR) 10jerkins-bot: [V: 04-1] Deprecate mediawiki.RegExp and jquery.accessKeyLabel; move into mw.util [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) (owner: 10Jforrester) [00:15:51] (03CR) 10jerkins-bot: [V: 04-1] Remove unneeded CSS for thanks toast link [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/534712 (https://phabricator.wikimedia.org/T232102) (owner: 10Ammarpad) [00:16:11] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10TemplateData, 10VisualEditor: TemplateData - https://phabricator.wikimedia.org/T232168 (10AlgorithmGG) Thanks for responding @AKlapper To be honest I followed the instructions in the Template wizard found below. https://www.mediawiki.org/wiki/Help... [00:21:08] (03CR) 10jerkins-bot: [V: 04-1] Deprecate mediawiki.RegExp and jquery.accessKeyLabel; move into mw.util [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) (owner: 10Jforrester) [00:21:18] (03PS7) 10Eric Gardner: Add linters and apply automated fixes to JS and LESS files [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/534700 [00:21:20] 10MediaWiki-extensions-Cargo: cargo_compound_query: "group by" and "having" fields are swapped - https://phabricator.wikimedia.org/T232116 (10Yaron_Koren) 05Open→03Resolved a:03Yaron_Koren Wow! It looks like that bug has been in place for a long time. Sorry about that. I just checked in a fix - hopefully i... [00:21:39] 10Who-Wrote-That, 10Community-Tech (Kanban (Q1 2019-20)): Image thumbnails show "undefined" as the author - https://phabricator.wikimedia.org/T231959 (10ifried) [00:22:11] (03Merged) 10jenkins-bot: Toggler: Don't use `float` on indicator to avoid "stacking" with floated images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/534705 (https://phabricator.wikimedia.org/T232167) (owner: 10Bartosz Dziewoński) [00:23:19] (03CR) 10jerkins-bot: [V: 04-1] Dev: Access OverlayManager via singleton method not M.define [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/534710 (owner: 10Jdlrobson) [00:23:59] (03CR) 10jenkins-bot: Prevent all users from having a password in the blacklist [core] - 10https://gerrit.wikimedia.org/r/477487 (https://phabricator.wikimedia.org/T151425) (owner: 10Reedy) [00:26:36] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10TemplateData, 10VisualEditor: TemplateData - https://phabricator.wikimedia.org/T232168 (10Samwilson) Which wiki are you using it on, and which template are you trying to insert? If it's English Wikipedia, then most infoboxes have templatedata defi... [00:27:20] (03CR) 10jenkins-bot: Toggler: Don't use `float` on indicator to avoid "stacking" with floated images [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/534705 (https://phabricator.wikimedia.org/T232167) (owner: 10Bartosz Dziewoński) [00:29:22] (03CR) 10jerkins-bot: [V: 04-1] Dev: Access OverlayManager via singleton method not M.define [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/534710 (owner: 10Jdlrobson) [00:30:32] (03CR) 10Jdlrobson: [C: 04-1] "You'll need to remove the reference in extension.json too!" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/534712 (https://phabricator.wikimedia.org/T232102) (owner: 10Ammarpad) [00:31:13] (03CR) 10Jdlrobson: "recheck" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/534710 (owner: 10Jdlrobson) [00:35:11] (03PS1) 10Krinkle: mediawiki.util: Move to its own resources/src/ directory [core] - 10https://gerrit.wikimedia.org/r/534713 [00:35:54] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10TemplateData, 10VisualEditor: TemplateData - https://phabricator.wikimedia.org/T232168 (10AlgorithmGG) Hi @Samwilson I am using the latest stable version I am comfortable doing it. I used the stable version of TemplateData, when that failed I used... [00:37:47] (03CR) 10VolkerE: "Given the many files touched, it might be simpler to split ESLint and stylelint specific rules." [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/534700 (owner: 10Eric Gardner) [00:39:55] (03CR) 10Krinkle: "Keeping it in its own file would be file, and might make it easier to find and maintain. Rebase on https://gerrit.wikimedia.org/r/#/c/medi" [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) (owner: 10Jforrester) [00:40:06] (03CR) 10Krinkle: "would be fine*" [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) (owner: 10Jforrester) [00:40:14] o/ for real. [00:44:50] (03CR) 10Samwilson: Add a preference to require email for password resets (031 comment) [core] - 10https://gerrit.wikimedia.org/r/534552 (https://phabricator.wikimedia.org/T231495) (owner: 10MaxSem) [00:49:56] 10MediaWiki-Internationalization, 10Wikisource: Wrongly attributed canonical namespaces on nap.source - https://phabricator.wikimedia.org/T231880 (10Dcljr) >>! In T231880#5467424, @Ruthven wrote: > While we're at it, would it be possible to add a new namespace for Wikiprojects? Something like: > > "104": {... [00:51:24] (03PS4) 10VolkerE: Update MobileFrontend icons to WikimediaUI theme equivalents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/534529 (https://phabricator.wikimedia.org/T231613) (owner: 10Jdlrobson) [00:52:33] (03PS1) 10Tim Starling: Fix the more obvious XSS vulnerabilities and the CI test failures [extensions/RelatedLinks] - 10https://gerrit.wikimedia.org/r/534714 [00:54:02] 10MediaWiki-extensions-CentralNotice, 10Fr-Q2-2019-cleanup-list, 10Fundraising-Backlog: Banner preview: fix banner editor for users without CN admin rights - https://phabricator.wikimedia.org/T230857 (10AndyRussG) [00:54:30] (03PS2) 10Ammarpad: Remove unneeded CSS for thanks toast link [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/534712 (https://phabricator.wikimedia.org/T232102) [00:54:46] (03PS1) 10Samwilson: Prevent all notification badges from obscuring clicks on toolbar icons [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/534715 (https://phabricator.wikimedia.org/T207452) [00:55:11] (03CR) 10Ammarpad: "> You'll need to remove the reference in extension.json too!" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/534712 (https://phabricator.wikimedia.org/T232102) (owner: 10Ammarpad) [00:55:27] (03PS5) 10VolkerE: Update MobileFrontend icons to WikimediaUI theme equivalents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/534529 (https://phabricator.wikimedia.org/T231613) (owner: 10Jdlrobson) [00:56:46] 10MediaWiki-extensions-CentralNotice, 10Fr-Q2-2019-cleanup-list, 10Fundraising-Backlog: Replace hacky check for choiceData staleness with a real check, and send back data on how often it happens - https://phabricator.wikimedia.org/T229365 (10AndyRussG) [00:56:51] (03CR) 10Huji: [C: 03+2] Use DB_MASTER to read back election after creation [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/534467 (https://phabricator.wikimedia.org/T209804) (owner: 10Anomie) [00:57:51] 10MediaWiki-extensions-SecurePoll, 10Core Platform Team Workboards (Clinic Duty Team): Can't create election: SecurePollContentHandler::makeContentFromElection() must be an instance of SecurePoll_Election, bool given - https://phabricator.wikimedia.org/T209804 (10Huji) 05Open→03Resolved [00:58:16] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: CentralNotice: Don't show live preview section for users without CN rights - https://phabricator.wikimedia.org/T226961 (10AndyRussG) See also {T230857}. [00:58:45] 10MediaWiki-extensions-CentralNotice, 10Fr-Q2-2019-cleanup-list, 10Fundraising-Backlog: CentralNotice alerts: Document new CN Hook - https://phabricator.wikimedia.org/T224700 (10AndyRussG) [00:59:16] 10MediaWiki-extensions-CentralNotice, 10Fr-Q2-2019-cleanup-list, 10Fundraising-Backlog, 10Security: CentralNotice alerts: Specific alerts config for production monitoring - https://phabricator.wikimedia.org/T224931 (10AndyRussG) [00:59:45] (03CR) 10jerkins-bot: [V: 04-1] Dev: Access OverlayManager via singleton method not M.define [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/534710 (owner: 10Jdlrobson) [01:00:01] 10MediaWiki-extensions-CentralNotice, 10Fr-Q2-2019-cleanup-list, 10Fundraising-Backlog, 10Security: CentralNotice alerts: Add error handling - https://phabricator.wikimedia.org/T224699 (10AndyRussG) [01:00:32] 10MediaWiki-extensions-CentralNotice, 10Fr-Q2-2019-cleanup-list, 10Fundraising-Backlog: CentralNotice: Re-create automatic browser tests on node selenium - https://phabricator.wikimedia.org/T223634 (10AndyRussG) [01:01:12] 10MediaWiki-extensions-CentralNotice, 10Fr-Q2-2019-cleanup-list, 10Fundraising-Backlog, 10Performance-Team (Radar): CentralNotice: Remove bannerController RL modules - https://phabricator.wikimedia.org/T224034 (10AndyRussG) [01:01:56] 10MediaWiki-extensions-CentralNotice, 10Fr-Q2-2019-cleanup-list, 10Fundraising-Backlog: CentralNotice: fix freegeoipLookup module and maybe integrate into other modules, or just remove it - https://phabricator.wikimedia.org/T224038 (10AndyRussG) [01:02:25] 10MediaWiki-extensions-CentralNotice, 10Fr-Q2-2019-cleanup-list, 10Fundraising-Backlog: Create Grafana graphs for CentralNotice impression rates for active campaigns - https://phabricator.wikimedia.org/T223932 (10AndyRussG) [01:02:26] (03Merged) 10jenkins-bot: Use DB_MASTER to read back election after creation [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/534467 (https://phabricator.wikimedia.org/T209804) (owner: 10Anomie) [01:03:20] (03CR) 10MusikAnimal: [C: 04-1] "So sorry! I figured you knew I was talking about both "pagetriage-enqueue-" messages." (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/529444 (https://phabricator.wikimedia.org/T207485) (owner: 10MaxSem) [01:11:15] (03CR) 10jenkins-bot: Make OAuth work with the REST API [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/534425 (owner: 10Tim Starling) [01:14:13] (03CR) 10jerkins-bot: [V: 04-1] Remove unneeded CSS for thanks toast link [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/534712 (https://phabricator.wikimedia.org/T232102) (owner: 10Ammarpad) [01:14:46] (03CR) 10jerkins-bot: [V: 04-1] Update MobileFrontend icons to WikimediaUI theme equivalents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/534529 (https://phabricator.wikimedia.org/T231613) (owner: 10Jdlrobson) [01:21:00] (03CR) 10Jdlrobson: [C: 04-1] "Just realised that actually this patch needs to merge now. However there is one cache implication i need to take care of here - i need to " [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533358 (owner: 10Jdlrobson) [01:21:08] (03PS5) 10Jdlrobson: MobileFrontend is now managing the toggling code. Remove. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533358 [01:22:20] (03CR) 10Tim Starling: [C: 03+2] libs/Message: Improve documentation [core] - 10https://gerrit.wikimedia.org/r/533331 (owner: 10Anomie) [01:27:17] (03CR) 10Tim Starling: [C: 03+2] lib/Message: Support MessageValue as a parameter [core] - 10https://gerrit.wikimedia.org/r/533580 (owner: 10Anomie) [01:38:06] (03CR) 10Jforrester: [C: 03+2] mediawiki.util: Move to its own resources/src/ directory [core] - 10https://gerrit.wikimedia.org/r/534713 (owner: 10Krinkle) [01:42:43] (03CR) 10jerkins-bot: [V: 04-1] MobileFrontend is now managing the toggling code. Remove. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533358 (owner: 10Jdlrobson) [01:45:29] (03Merged) 10jenkins-bot: libs/Message: Improve documentation [core] - 10https://gerrit.wikimedia.org/r/533331 (owner: 10Anomie) [01:48:25] 10Google-Summer-of-Code (2019): GSoC Proposal[2019]: Develop a tool for event organizers to track developer activity - https://phabricator.wikimedia.org/T220254 (10Rammanojpotla) Okay @Aklapper, will add it there soon. Thanks for informing. [01:49:37] 10CommRel-Design, 10Community comms and outreach, 10CommRel-Specialists-Support (Jul-Sep-2019): Communication rollout for Learning Days @ Wikimania 2019 - https://phabricator.wikimedia.org/T222288 (10DMccurdy) @Elitre Yes, all done. we can close this! Thank you! [01:51:40] 10CommRel-Design, 10CommRel-Specialists-Support (Jul-Sep-2019): Support design of Community Growth Framework - https://phabricator.wikimedia.org/T224173 (10DMccurdy) @hdothiduc The team is meeting tomorrow to plan out next steps. I'll send you an update after that. But I imagine it will be creating the interac... [01:51:59] (03Merged) 10jenkins-bot: lib/Message: Support MessageValue as a parameter [core] - 10https://gerrit.wikimedia.org/r/533580 (owner: 10Anomie) [01:53:08] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: Investigate error tracking and alerts for in-banner JS - https://phabricator.wikimedia.org/T215842 (10AndyRussG) >>! In T215842#4945525, @Jdlrobson wrote: > I wrote a blog post about this here if you are interested: > https://medium.com/freely-sharin... [01:55:00] 10MediaWiki-extensions-CentralNotice, 10Fr-Q2-2019-cleanup-list, 10Fundraising-Backlog, 10Patch-For-Review: CentralNotice: Remove unused code for banner preview in banner editor - https://phabricator.wikimedia.org/T161907 (10AndyRussG) [01:57:08] 10MediaWiki-extensions-CentralNotice, 10Fr-Q2-2019-cleanup-list, 10Fundraising-Backlog, 10good first bug: Clone button for CN campaigns - https://phabricator.wikimedia.org/T91078 (10AndyRussG) [02:00:55] (03Merged) 10jenkins-bot: mediawiki.util: Move to its own resources/src/ directory [core] - 10https://gerrit.wikimedia.org/r/534713 (owner: 10Krinkle) [02:02:51] (03CR) 10jenkins-bot: libs/Message: Improve documentation [core] - 10https://gerrit.wikimedia.org/r/533331 (owner: 10Anomie) [02:03:11] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/534719 [02:03:29] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/534719 (owner: 10Ejegg) [02:08:26] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/534719 (owner: 10Ejegg) [02:11:31] (03CR) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/534719 (owner: 10Ejegg) [02:18:23] (03CR) 10jenkins-bot: lib/Message: Support MessageValue as a parameter [core] - 10https://gerrit.wikimedia.org/r/533580 (owner: 10Anomie) [02:33:42] (03CR) 10jenkins-bot: mediawiki.util: Move to its own resources/src/ directory [core] - 10https://gerrit.wikimedia.org/r/534713 (owner: 10Krinkle) [02:33:48] (03PS6) 10Jdlrobson: MobileFrontend is now managing the toggling code. Remove. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533358 [02:34:34] (03CR) 10Jdlrobson: [C: 03+1] "okay this needs to go in with next train otherwise we'll be loading this code twice. Bartosz can you take a look Friday?" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533358 (owner: 10Jdlrobson) [02:36:20] (03CR) 10jerkins-bot: [V: 04-1] MobileFrontend is now managing the toggling code. Remove. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533358 (owner: 10Jdlrobson) [02:40:58] (03PS7) 10Jdlrobson: MobileFrontend is now managing the toggling code. Remove. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533358 [02:53:26] (03CR) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/534719 (owner: 10Ejegg) [02:54:42] 10MediaWiki-extensions-CentralNotice, 10Fr-CentralNotice-Translation-Bugs, 10Fr-Q2-2019-cleanup-list, 10Fundraising-Backlog: CentralNotice: When fetching banner settings, pull translation metadata only when necessary - https://phabricator.wikimedia.org/T205118 (10AndyRussG) [03:03:25] (03CR) 10jerkins-bot: [V: 04-1] MobileFrontend is now managing the toggling code. Remove. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533358 (owner: 10Jdlrobson) [03:03:34] 10MediaWiki-extensions-CentralNotice, 10Fr-CentralNotice-Translation-Bugs, 10Fr-Q2-2019-cleanup-list, 10Fundraising-Backlog: Fix CentralNotice rebuilding of Translate message cache - https://phabricator.wikimedia.org/T205483 (10AndyRussG) [03:36:01] (03CR) 10DannyS712: Split afl_filter in afl_filter_id and afl_global (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/459818 (https://phabricator.wikimedia.org/T220791) (owner: 10Daimona Eaytoy) [03:48:12] (03CR) 10DannyS712: "I know that this is still a work in progress, but some thoughts" (036 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/534454 (owner: 10Daimona Eaytoy) [03:57:18] (03CR) 10DannyS712: Avoid keeping superfluous row properties (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/493703 (owner: 10Daimona Eaytoy) [04:11:11] 10MediaWiki-extensions-CentralNotice, 10Fr-CentralNotice-Translation-Bugs, 10Fr-Q2-2019-cleanup-list, 10Fundraising-Backlog, and 3 others: CentralNotice must not query master on GET request (page views) - https://phabricator.wikimedia.org/T216287 (10AndyRussG) [04:12:39] 10MediaWiki-extensions-CentralNotice, 10Fr-Q2-2019-cleanup-list, 10Fundraising-Backlog: Consider not displaying protection log entries in RecentChanges caused by CentralNotice actions - https://phabricator.wikimedia.org/T210101 (10AndyRussG) [04:19:13] 10CX-boost, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), 10Patch-For-Review: Surface the article the user is trying to create when suggesting to translate - https://phabricator.wikimedia.org/T216500 (10santhosh) >>! In T216500#5440713, @Petar.petkovic wrote:... [04:33:43] (03CR) 10Tim Starling: [C: 03+2] rest: Use ParamValidator library, add BodyValidator [core] - 10https://gerrit.wikimedia.org/r/517076 (https://phabricator.wikimedia.org/T223239) (owner: 10Anomie) [04:43:50] (03PS3) 10Aaron Schulz: [WIP] filebackend: add xattr_* method support to FSFileBackend [core] - 10https://gerrit.wikimedia.org/r/533719 [04:44:35] 10Who-Wrote-That, 10Community-Tech (Kanban (Q1 2019-20)): [BUG] Article content removed the second time a user closes the tool - https://phabricator.wikimedia.org/T231417 (10Samwilson) a:03Samwilson This bug was annoying me while working on T231359, so: https://github.com/wikimedia/WhoWroteThat/pull/46 [04:49:44] 10Wikimedia-User-Group-Basque: The Great Basque Redesign - https://phabricator.wikimedia.org/T223228 (10Urbanecm) [04:50:39] (03PS7) 10Aaron Schulz: [WIP] Remove MediaWikiServices dependency from MultiHttpClient [core] - 10https://gerrit.wikimedia.org/r/533983 [04:56:11] (03Merged) 10jenkins-bot: rest: Use ParamValidator library, add BodyValidator [core] - 10https://gerrit.wikimedia.org/r/517076 (https://phabricator.wikimedia.org/T223239) (owner: 10Anomie) [05:03:31] (03PS5) 10Aaron Schulz: filebackend: check file sizes in addition to SHA-1 in FileOp [core] - 10https://gerrit.wikimedia.org/r/525035 [05:03:34] (03PS1) 10Mholloway: Repository: Update getTitlesWithUnreviewedLabels to behave like a queue [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/534724 [05:04:38] (03CR) 10jerkins-bot: [V: 04-1] [WIP] filebackend: add xattr_* method support to FSFileBackend [core] - 10https://gerrit.wikimedia.org/r/533719 (owner: 10Aaron Schulz) [05:07:14] (03CR) 10jerkins-bot: [V: 04-1] [WIP] filebackend: add xattr_* method support to FSFileBackend [core] - 10https://gerrit.wikimedia.org/r/533719 (owner: 10Aaron Schulz) [05:12:44] (03PS4) 10Aaron Schulz: [WIP] filebackend: add xattr_* method support to FSFileBackend [core] - 10https://gerrit.wikimedia.org/r/533719 [05:13:08] (03PS1) 10Mooeypoo: Initial commit, set up the repo [extensions/WebToolsManager] - 10https://gerrit.wikimedia.org/r/534727 [05:14:54] (03CR) 10Jforrester: [V: 03+2 C: 03+2] Initial commit, set up the repo [extensions/WebToolsManager] - 10https://gerrit.wikimedia.org/r/534727 (owner: 10Mooeypoo) [05:20:24] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/534731 (owner: 10L10n-bot) [05:20:49] (03CR) 10jenkins-bot: rest: Use ParamValidator library, add BodyValidator [core] - 10https://gerrit.wikimedia.org/r/517076 (https://phabricator.wikimedia.org/T223239) (owner: 10Anomie) [05:31:04] 10Who-Wrote-That, 10Community-Tech (Kanban (Q1 2019-20)): Update Exit Functionality of WWT - https://phabricator.wikimedia.org/T231359 (10Samwilson) PR: https://github.com/wikimedia/WhoWroteThat/pull/47 The link text of 'Close Who Wrote That?' with a tooltip of 'Deactivate Who Wrote That?' might be redundant,... [06:22:19] 10Technical-Tool-Request: Create a Generic List-building tool that can meet and exceed the applications of Pagepile - https://phabricator.wikimedia.org/T231891 (10Magnus) >>! In T231891#5469814, @LucasWerkmeister wrote: >> == Minimum viable product == >> * Import from various sources >> * All sources offered i... [06:23:20] 10Technical-Tool-Request: Create a Generic List-building tool that can meet and exceed the applications of Pagepile - https://phabricator.wikimedia.org/T231891 (10Magnus) >>! In T231891#5468418, @Astinson wrote: >>>! In T231891#5467967, @Magnus wrote: >> Started some design notes of such a product: https://meta.... [06:24:42] 10Technical-Tool-Request: Create a Generic List-building tool that can meet and exceed the applications of Pagepile - https://phabricator.wikimedia.org/T231891 (10Magnus) >>! In T231891#5468371, @Astinson wrote: >>>! In T231891#5467967, @Magnus wrote: >> Started some design notes of such a product: https://meta.... [06:28:43] 10Timeless: Clicking on the "context menu icon" on an alert message shows the message below the alert window - https://phabricator.wikimedia.org/T175832 (10Kaartic) Given that it's been a very long time since I filed this, I don't remember what I actually meant to note as a bug. I should have at least attached a... [06:33:28] (03PS1) 10Tim Starling: Update to version 1.0.0 [php/excimer] - 10https://gerrit.wikimedia.org/r/534737 [06:35:37] (03CR) 10Robert Vogel: "recheck" [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/531537 (owner: 10Robert Vogel) [06:36:11] (03CR) 10Robert Vogel: [C: 03+2] Prevent render of empty dropdown menu. ERM:16010 [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/534618 (owner: 10Pwirth) [06:36:16] (03PS1) 10Robert Vogel: Prevent render of empty dropdown menu. ERM:16010 [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534738 [06:36:19] (03CR) 10Robert Vogel: [C: 03+2] Prevent render of empty dropdown menu. ERM:16010 [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534738 (owner: 10Robert Vogel) [06:39:40] 10MediaWiki-Configuration: Phase out right-related globals - https://phabricator.wikimedia.org/T20807 (10Mainframe98) [06:39:42] 10MediaWiki-User-management, 10Patch-For-Review, 10Technical-Debt (Deprecation), 10User-DannyS712: Deprecate `wgSysopEmailBans` - https://phabricator.wikimedia.org/T232169 (10Mainframe98) [06:40:58] (03Merged) 10jenkins-bot: Prevent render of empty dropdown menu. ERM:16010 [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534738 (owner: 10Robert Vogel) [06:41:23] (03Merged) 10jenkins-bot: Prevent render of empty dropdown menu. ERM:16010 [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/534618 (owner: 10Pwirth) [06:52:04] (03CR) 10DCausse: [C: 03+2] build: Upgrade wdio-cucumber-framework to one that works [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/525612 (https://phabricator.wikimedia.org/T229033) (owner: 10Jforrester) [06:57:42] (03PS1) 10ItSpiderman: Require bluespice OOJS widgets [extensions/BlueSpiceConfigManager] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534748 [06:57:56] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/534744 (owner: 10L10n-bot) [07:00:16] 10MediaWiki-Configuration, 10User-DannyS712: Phase out right-related globals - https://phabricator.wikimedia.org/T20807 (10DannyS712) a:03DannyS712 [07:01:20] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade wdio-cucumber-framework to one that works [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/525612 (https://phabricator.wikimedia.org/T229033) (owner: 10Jforrester) [07:01:57] 10MediaWiki-User-management, 10Patch-For-Review, 10Technical-Debt (Deprecation), 10User-DannyS712: Deprecate `wgSysopEmailBans` - https://phabricator.wikimedia.org/T232169 (10DannyS712) Hopefully this will be merged into 1.34 before the version is cut, and then it can be hard deprecated (i.e. removed) in a... [07:04:42] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10TemplateData, 10VisualEditor: TemplateData - https://phabricator.wikimedia.org/T232168 (10Aklapper) Hi @AlgorithmGG, please answer all my questions that I asked in T232168#5470065. Thanks! [07:10:39] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/534739 (owner: 10L10n-bot) [07:14:41] 10CX-boost, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), 10Patch-For-Review: Surface the article the user is trying to create when suggesting to translate - https://phabricator.wikimedia.org/T216500 (10Pginer-WMF) >>! In T216500#5470357, @santhosh wrote: >>>!... [07:26:47] (03PS1) 10ItSpiderman: Trim unnecessary slashes [extensions/BlueSpiceExtendedSearch] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534752 [07:29:32] (03CR) 10Raimond Spekking: Localisation updates from https://translatewiki.net. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/534739 (owner: 10L10n-bot) [07:30:31] (03CR) 10Robert Vogel: [C: 03+2] Trim unnecessary slashes [extensions/BlueSpiceExtendedSearch] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534752 (owner: 10ItSpiderman) [07:30:38] (03PS1) 10Robert Vogel: Trim unnecessary slashes [extensions/BlueSpiceExtendedSearch] (REL1_31) - 10https://gerrit.wikimedia.org/r/534753 [07:30:41] (03CR) 10Robert Vogel: [C: 03+2] Trim unnecessary slashes [extensions/BlueSpiceExtendedSearch] (REL1_31) - 10https://gerrit.wikimedia.org/r/534753 (owner: 10Robert Vogel) [07:30:49] (03PS2) 10Robert Vogel: Trim unnecessary slashes [extensions/BlueSpiceExtendedSearch] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534752 (owner: 10ItSpiderman) [07:31:03] (03PS1) 10Robert Vogel: Trim unnecessary slashes [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/534754 [07:31:06] (03CR) 10Robert Vogel: [C: 03+2] Trim unnecessary slashes [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/534754 (owner: 10Robert Vogel) [07:31:23] (03CR) 10Robert Vogel: [C: 03+2] Require bluespice OOJS widgets [extensions/BlueSpiceConfigManager] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534748 (owner: 10ItSpiderman) [07:31:30] (03PS1) 10Robert Vogel: Require bluespice OOJS widgets [extensions/BlueSpiceConfigManager] (REL1_31) - 10https://gerrit.wikimedia.org/r/534755 [07:31:33] (03CR) 10Robert Vogel: [C: 03+2] Require bluespice OOJS widgets [extensions/BlueSpiceConfigManager] (REL1_31) - 10https://gerrit.wikimedia.org/r/534755 (owner: 10Robert Vogel) [07:31:40] (03PS1) 10Robert Vogel: Require bluespice OOJS widgets [extensions/BlueSpiceConfigManager] - 10https://gerrit.wikimedia.org/r/534756 [07:31:43] (03CR) 10Robert Vogel: [C: 03+2] Require bluespice OOJS widgets [extensions/BlueSpiceConfigManager] - 10https://gerrit.wikimedia.org/r/534756 (owner: 10Robert Vogel) [07:34:17] (03CR) 10Robert Vogel: "Are you sure that this is sufficient? ERM16246 doesn't say anything about not-logged-in, it is about not-allowed-to-edit" [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534693 (owner: 10AlexPinchuk) [07:34:54] (03CR) 10Robert Vogel: "Nevermind." [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534693 (owner: 10AlexPinchuk) [07:34:58] (03CR) 10Robert Vogel: [C: 03+2] Disabled edit button if edit actions is not possible [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534693 (owner: 10AlexPinchuk) [07:35:04] (03PS1) 10Robert Vogel: Disabled edit button if edit actions is not possible [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/534757 [07:35:08] (03CR) 10Robert Vogel: [C: 03+2] Disabled edit button if edit actions is not possible [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/534757 (owner: 10Robert Vogel) [07:35:23] (03CR) 10Robert Vogel: [C: 03+2] Add NamespaceInfo service to decorator for MW1.34 [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/534606 (owner: 10Pwirth) [07:36:53] (03CR) 10jerkins-bot: [V: 04-1] Trim unnecessary slashes [extensions/BlueSpiceExtendedSearch] (REL1_31) - 10https://gerrit.wikimedia.org/r/534753 (owner: 10Robert Vogel) [07:37:19] 10ISA: Add url link on participant user name in the campaign page - https://phabricator.wikimedia.org/T232185 (10Anthere) [07:41:47] (03CR) 10jerkins-bot: [V: 04-1] Trim unnecessary slashes [extensions/BlueSpiceExtendedSearch] (REL1_31) - 10https://gerrit.wikimedia.org/r/534753 (owner: 10Robert Vogel) [07:43:39] (03Merged) 10jenkins-bot: Require bluespice OOJS widgets [extensions/BlueSpiceConfigManager] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534748 (owner: 10ItSpiderman) [07:43:41] (03Merged) 10jenkins-bot: Require bluespice OOJS widgets [extensions/BlueSpiceConfigManager] (REL1_31) - 10https://gerrit.wikimedia.org/r/534755 (owner: 10Robert Vogel) [07:44:17] (03Merged) 10jenkins-bot: Disabled edit button if edit actions is not possible [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534693 (owner: 10AlexPinchuk) [07:47:01] (03Merged) 10jenkins-bot: Trim unnecessary slashes [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/534754 (owner: 10Robert Vogel) [07:47:03] (03Merged) 10jenkins-bot: Require bluespice OOJS widgets [extensions/BlueSpiceConfigManager] - 10https://gerrit.wikimedia.org/r/534756 (owner: 10Robert Vogel) [07:47:05] (03Merged) 10jenkins-bot: Disabled edit button if edit actions is not possible [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/534757 (owner: 10Robert Vogel) [07:47:07] (03Merged) 10jenkins-bot: Add NamespaceInfo service to decorator for MW1.34 [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/534606 (owner: 10Pwirth) [07:48:11] (03PS1) 10ItSpiderman: Allow two-line results in AC [extensions/BlueSpiceExtendedSearch] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534761 [07:51:40] (03PS1) 10Fomafix: Remove redundant closure for module 'mediawiki.util' [core] - 10https://gerrit.wikimedia.org/r/534762 (https://phabricator.wikimedia.org/T50886) [07:55:33] (03CR) 10Fomafix: "Fresnel: -17 B" [core] - 10https://gerrit.wikimedia.org/r/534762 (https://phabricator.wikimedia.org/T50886) (owner: 10Fomafix) [07:58:06] (03PS1) 10Pwirth: Add phpcs [extensions/BlueSpiceSocialProfile] - 10https://gerrit.wikimedia.org/r/534763 [08:04:52] 10MediaWiki-extensions-Other, 10Google-Code-in-2019, 10good first bug: Extension:NoCat isn't setting up ParserOutputHook properly - https://phabricator.wikimedia.org/T203733 (10Aklapper) [08:10:11] (03CR) 10Jcrespo: "You know I am always a bit skeptical about internal hidden states/application-driven weight changes, as it removes control from the operat" [core] - 10https://gerrit.wikimedia.org/r/394430 (https://phabricator.wikimedia.org/T180918) (owner: 10Aaron Schulz) [08:11:44] 10Wikimania-Hackathon-2019, 10Developer-Advocacy (Jul-Sep 2019): Wikimania Hackathon Phabricator session(s) - https://phabricator.wikimedia.org/T219418 (10Aklapper) Hmm, I don't see the Hackathon Main session listed under Videos on https://wikimania.wikimedia.org/wiki/2019:Video#Szymborska :( [08:13:11] (03CR) 10Pwirth: [C: 04-1] Add phpcs [extensions/BlueSpiceSocialProfile] - 10https://gerrit.wikimedia.org/r/534763 (owner: 10Pwirth) [08:25:29] (03PS1) 10Matěj Suchánek: Improve experience on Special:GlobalUsers [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/534765 [08:27:09] 10MediaWiki-General, 10CPT Initiatives (MCR), 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.32-release, and 4 others: Failed to access name from slot_roles using id = 1 - https://phabricator.wikimedia.org/T224949 (10daniel) p:05Normal→03High @Jdforrester-WMF I'd prefer for this to make it... [08:28:24] (03PS4) 10Noa wmde: Add a reminder for blank user summary when saving an editted Schema text [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/534602 (https://phabricator.wikimedia.org/T230399) [08:29:02] (03CR) 10jerkins-bot: [V: 04-1] Improve experience on Special:GlobalUsers [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/534765 (owner: 10Matěj Suchánek) [08:35:04] (03PS1) 10Matěj Suchánek: Fix phan warning [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/534767 [08:35:04] (03PS2) 10Matěj Suchánek: Improve experience on Special:GlobalUsers [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/534765 [08:39:31] (03PS3) 10Matěj Suchánek: Improve experience on Special:GlobalUsers [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/534765 [08:40:40] 10WMSE-FindingGLAMs-2018 (Events): Global metrics for FindingGLAMs presentation at Wikimania - https://phabricator.wikimedia.org/T232186 (10Alicia_Fagerving_WMSE) [08:46:13] 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Epics), 10Epic, 10MW-1.35-release: [Epic] Remove support for writing to the pre-MCR schema - https://phabricator.wikimedia.org/T231674 (10daniel) [08:46:39] (03PS1) 10Dvogel hallowelt: Page header: add class=btn and role=button to page-breadcrumbs and page-namespaces [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534768 [08:48:13] (03CR) 10Daimona Eaytoy: [C: 03+2] "Thanks. As an aside, while fixing the docblock of SessionManager::singleton to make phan pass, I didn't get what it was about. Why should " [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/534767 (owner: 10Matěj Suchánek) [08:49:48] (03CR) 10Daimona Eaytoy: [C: 03+1] docs: Factor out MWDoxygenFilter from mwdoc-filter.php with tests [core] - 10https://gerrit.wikimedia.org/r/534643 (https://phabricator.wikimedia.org/T232104) (owner: 10Krinkle) [08:53:28] (03Merged) 10jenkins-bot: Fix phan warning [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/534767 (owner: 10Matěj Suchánek) [08:55:45] (03CR) 10jenkins-bot: Fix phan warning [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/534767 (owner: 10Matěj Suchánek) [08:57:48] 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Epics), 10Epic, 10MW-1.34-release: Make SCHEMA_COMPAT_NEW the default MCR migration schema - https://phabricator.wikimedia.org/T231673 (10daniel) >>! In T231673#5469781, @Jdforrester-WMF wrote: > Hey there, should this be moved to 1... [09:01:32] (03CR) 10Noa wmde: "This change is ready for review." [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/534602 (https://phabricator.wikimedia.org/T230399) (owner: 10Noa wmde) [09:02:16] (03PS1) 10Dvogel hallowelt: Fix getFlyoutTitleMessage and getFlyoutIntroMessage. [extensions/BlueSpiceArticleInfo] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534769 [09:04:44] 04(no projects): "Proxy mode" for third-party proxies - https://phabricator.wikimedia.org/T232188 (10CristianCantoro) [09:08:20] 10MediaWiki-History-and-Diffs: Desktop diff-view lacks user-rights, edit-count functionality included in mobile version - https://phabricator.wikimedia.org/T187011 (10Aklapper) [09:08:40] 10MediaWiki-extensions-Scribunto, 10Wikidata, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Patch-For-Review, and 2 others: LuaWikibaseEntityLibraryTest: CI failing en masse - https://phabricator.wikimedia.org/T231799 (10Pablo-WMDE) p:05Unbreak!→03Normal Is anyone still working on this? E.g. https://g... [09:09:16] 10CommRel-Specialists-Support (Jul-Sep-2019), 10Growth-Team (Current Sprint): Find a new ambassador for Vietnamese Wikipedia - https://phabricator.wikimedia.org/T228973 (10Trizek-WMF) p:05Low→03Normal It took me time to start working on this, because of Wikimania and vacation. But I have a new contact. Mee... [09:09:48] 10AbuseFilter: AbuseFilterCachingParser fails to parse filters with trailing comma in function calls (works in old parser) - https://phabricator.wikimedia.org/T153251 (10Daimona) Given the high amount of affected filters, I'd like to wait a bit. We could also tolerate dangling commas in variadic functions. I'd l... [09:14:12] (03PS16) 10Daimona Eaytoy: Avoid keeping superfluous row properties [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/493703 [09:14:14] (03CR) 10Daimona Eaytoy: Avoid keeping superfluous row properties (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/493703 (owner: 10Daimona Eaytoy) [09:18:55] 10CX-out-of-beta, 10Language-Team (Language-2019-July-September): Test out-of-beta experience - https://phabricator.wikimedia.org/T229405 (10santhosh) we removed this dialog, and have new dialog with translation suggestion. https://phabricator.wikimedia.org/T216500 overrides this ticket [09:20:49] (03PS3) 10Daniel Kinzler: LocalFile: avoid hard failures on non-existing files. [core] - 10https://gerrit.wikimedia.org/r/533482 (https://phabricator.wikimedia.org/T221812) [09:23:04] (03CR) 10Daniel Kinzler: "> BTW, it needs a release notes entry in the API section if we do include the" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533482 (https://phabricator.wikimedia.org/T221812) (owner: 10Daniel Kinzler) [09:23:32] 10CommRel-Design, 10Community comms and outreach, 10CommRel-Specialists-Support (Jul-Sep-2019): Communication rollout for Learning Days @ Wikimania 2019 - https://phabricator.wikimedia.org/T222288 (10Aklapper) 05Stalled→03Resolved [09:26:17] (03PS1) 10Mainframe98: Support the creation of special pages with services injected [core] - 10https://gerrit.wikimedia.org/r/534770 (https://phabricator.wikimedia.org/T222388) [09:29:04] 04(no projects): "Proxy mode" for third-party proxies (to disable login or editing buttons) - https://phabricator.wikimedia.org/T232188 (10Aklapper) [09:29:39] 10MediaWiki-General: "Proxy mode" for third-party proxies (to disable login or editing buttons) - https://phabricator.wikimedia.org/T232188 (10Aklapper) > There are many other small quirks, such as the fact that [[Special:Random]] redirects automatically to the main domain (wikipedia.org), maybe I should file a... [09:29:41] (03PS2) 10Mainframe98: Support the creation of special pages with services injected [core] - 10https://gerrit.wikimedia.org/r/534770 (https://phabricator.wikimedia.org/T222388) [09:30:01] (03CR) 10Daimona Eaytoy: [C: 04-1] Split afl_filter in afl_filter_id and afl_global (038 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/459818 (https://phabricator.wikimedia.org/T220791) (owner: 10Daimona Eaytoy) [09:32:51] 10Performance-Team (Radar): Okay to use `user_properties` table for high frequency/volume options? - https://phabricator.wikimedia.org/T231044 (10Marostegui) Removing the DBA tag as there is nothing else for us here - but I will remain subscribed just in case. [09:33:07] 10CX-boost, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), 10Patch-For-Review: Surface the article the user is trying to create when suggesting to translate - https://phabricator.wikimedia.org/T216500 (10santhosh) // If replacing the suggestion cards by the bu... [09:34:34] (03PS1) 10Robert Vogel: Add `change` event to `bs.ui.widget.TextInputMWVisualEditor` [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534772 [09:38:54] (03PS2) 10Robert Vogel: Add `change` event to `bs.ui.widget.TextInputMWVisualEditor` [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534772 [09:39:52] (03CR) 10Robert Vogel: [C: 03+2] Fix getFlyoutTitleMessage and getFlyoutIntroMessage. [extensions/BlueSpiceArticleInfo] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534769 (owner: 10Dvogel hallowelt) [09:40:08] (03PS1) 10Robert Vogel: Fix getFlyoutTitleMessage and getFlyoutIntroMessage. [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/534773 [09:40:13] (03CR) 10Robert Vogel: [C: 03+2] Fix getFlyoutTitleMessage and getFlyoutIntroMessage. [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/534773 (owner: 10Robert Vogel) [09:41:10] (03CR) 10Daimona Eaytoy: [C: 03+2] "Tested and confirmed" [core] - 10https://gerrit.wikimedia.org/r/520312 (owner: 10Umherirrender) [09:44:35] (03Merged) 10jenkins-bot: Fix getFlyoutTitleMessage and getFlyoutIntroMessage. [extensions/BlueSpiceArticleInfo] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534769 (owner: 10Dvogel hallowelt) [09:45:08] 10MediaWiki-extensions-Cargo: Virtual field name cannot be used in strings - https://phabricator.wikimedia.org/T232190 (10HertzDevil) [09:45:15] (03CR) 10Daimona Eaytoy: [C: 03+2] "(ref T226124)" [core] - 10https://gerrit.wikimedia.org/r/534503 (owner: 10Umherirrender) [09:46:00] (03PS1) 10Kosta Harlan: Unit tests: Whitelist global so LoggerFactory doesn't explode [core] - 10https://gerrit.wikimedia.org/r/534774 (https://phabricator.wikimedia.org/T87781) [09:46:27] (03CR) 10jerkins-bot: [V: 04-1] LocalFile: avoid hard failures on non-existing files. [core] - 10https://gerrit.wikimedia.org/r/533482 (https://phabricator.wikimedia.org/T221812) (owner: 10Daniel Kinzler) [09:47:44] (03Merged) 10jenkins-bot: Fix getFlyoutTitleMessage and getFlyoutIntroMessage. [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/534773 (owner: 10Robert Vogel) [09:48:04] (03CR) 10Daimona Eaytoy: [C: 03+1] Work with LocalFile in FileDeleteForm [core] - 10https://gerrit.wikimedia.org/r/534508 (owner: 10Umherirrender) [09:48:06] (03CR) 10Kosta Harlan: "Not sure I am in favor of this, but posting for discussion after chatting with David." [core] - 10https://gerrit.wikimedia.org/r/534774 (https://phabricator.wikimedia.org/T87781) (owner: 10Kosta Harlan) [09:48:14] 10CommRel-Design, 10CommRel-Specialists-Support (Jul-Sep-2019): Library Bundle logo for The Wikipedia Library - https://phabricator.wikimedia.org/T228647 (10Samwalton9) We really like these! And yes, now that you've pointed out the distinction it sounds like this would be more of an icon than a logo :) I thin... [09:49:02] (03CR) 10Robert Vogel: [C: 03+2] Add phpcs [extensions/BlueSpiceSocialProfile] - 10https://gerrit.wikimedia.org/r/534763 (owner: 10Pwirth) [09:49:04] (03PS1) 10Robert Vogel: Add phpcs [extensions/BlueSpiceSocialProfile] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534775 [09:49:07] (03CR) 10Robert Vogel: [C: 03+2] Add phpcs [extensions/BlueSpiceSocialProfile] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534775 (owner: 10Robert Vogel) [09:49:45] (03CR) 10Robert Vogel: [C: 03+2] Page header: add class=btn and role=button to page-breadcrumbs and page-namespaces [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534768 (owner: 10Dvogel hallowelt) [09:49:47] (03PS1) 10Robert Vogel: Page header: add class=btn and role=button to page-breadcrumbs and page-namespaces [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/534776 [09:49:53] (03CR) 10Robert Vogel: [C: 03+2] Page header: add class=btn and role=button to page-breadcrumbs and page-namespaces [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/534776 (owner: 10Robert Vogel) [09:51:23] (03CR) 10Daimona Eaytoy: [C: 03+1] Avoid Database::tableName in WikiExporter (031 comment) [core] - 10https://gerrit.wikimedia.org/r/534478 (owner: 10Umherirrender) [09:51:48] (03CR) 10Robert Vogel: [C: 03+2] Allow two-line results in AC [extensions/BlueSpiceExtendedSearch] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534761 (owner: 10ItSpiderman) [09:51:56] (03PS1) 10Robert Vogel: Allow two-line results in AC [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/534777 [09:51:58] (03CR) 10Robert Vogel: [C: 03+2] Allow two-line results in AC [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/534777 (owner: 10Robert Vogel) [09:53:25] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534772 (owner: 10Robert Vogel) [09:54:32] (03PS10) 10Matěj Suchánek: Show edit links in Special:DisambiguationPageLinks only if user can edit [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/463679 (https://phabricator.wikimedia.org/T205796) (owner: 10Urbanecm) [09:55:02] (03CR) 10Matěj Suchánek: Show edit links in Special:DisambiguationPageLinks only if user can edit (032 comments) [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/463679 (https://phabricator.wikimedia.org/T205796) (owner: 10Urbanecm) [09:55:06] (03PS4) 10Daniel Kinzler: LocalFile: avoid hard failures on non-existing files. [core] - 10https://gerrit.wikimedia.org/r/533482 (https://phabricator.wikimedia.org/T221812) [09:56:05] (03Merged) 10jenkins-bot: Add phpcs [extensions/BlueSpiceSocialProfile] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534775 (owner: 10Robert Vogel) [09:56:07] (03Merged) 10jenkins-bot: Page header: add class=btn and role=button to page-breadcrumbs and page-namespaces [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534768 (owner: 10Dvogel hallowelt) [09:57:58] (03CR) 10Daniel Kinzler: "Cool, I like it!" [core] - 10https://gerrit.wikimedia.org/r/534770 (https://phabricator.wikimedia.org/T222388) (owner: 10Mainframe98) [09:58:07] (03CR) 10Pwirth: "recheck" [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/531537 (owner: 10Robert Vogel) [09:59:28] (03Merged) 10jenkins-bot: Allow two-line results in AC [extensions/BlueSpiceExtendedSearch] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534761 (owner: 10ItSpiderman) [10:00:35] 10CX-boost, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), 10Patch-For-Review: Surface the article the user is trying to create when suggesting to translate - https://phabricator.wikimedia.org/T216500 (10Pginer-WMF) >>! In T216500#5470747, @santhosh wrote: > //... [10:02:23] 10GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: GrowthExperiments should log exceptions on the exception channel - https://phabricator.wikimedia.org/T230798 (10kostajh) a:03kostajh > As an aside, the code catches Exception and Error subclasses; it would be slightly more correct to... [10:02:53] (03CR) 10Daimona Eaytoy: "> (6 comments)" (034 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/534454 (owner: 10Daimona Eaytoy) [10:03:22] 10GrowthExperiments, 10Growth-Team (Current Sprint): Deploy EditorJourney to Basque Wikipedia - https://phabricator.wikimedia.org/T232061 (10kostajh) a:03kostajh [10:04:43] (03Merged) 10jenkins-bot: Fix use of argument perfLogFilename in convertLinks.php [core] - 10https://gerrit.wikimedia.org/r/520312 (owner: 10Umherirrender) [10:08:04] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10TemplateData, 10VisualEditor: TemplateData - https://phabricator.wikimedia.org/T232168 (10AlgorithmGG) @Aklapper Sorry I missed the question? [10:08:22] (03Merged) 10jenkins-bot: Pass Title to IndexPager::buildPrevNextNavigation [core] - 10https://gerrit.wikimedia.org/r/534503 (owner: 10Umherirrender) [10:08:24] (03Merged) 10jenkins-bot: Add phpcs [extensions/BlueSpiceSocialProfile] - 10https://gerrit.wikimedia.org/r/534763 (owner: 10Pwirth) [10:08:26] (03Merged) 10jenkins-bot: Page header: add class=btn and role=button to page-breadcrumbs and page-namespaces [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/534776 (owner: 10Robert Vogel) [10:08:28] (03Merged) 10jenkins-bot: Allow two-line results in AC [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/534777 (owner: 10Robert Vogel) [10:09:20] 10ISA: Current user images improved not working - https://phabricator.wikimedia.org/T232192 (10Eugene233) [10:12:19] (03PS5) 10Kosta Harlan: Add unit test example [extensions/BoilerPlate] - 10https://gerrit.wikimedia.org/r/534615 (https://phabricator.wikimedia.org/T97105) [10:20:34] (03PS5) 10Fomafix: Remove redundant closure for all modules with packageFiles [core] - 10https://gerrit.wikimedia.org/r/512519 (https://phabricator.wikimedia.org/T50886) [10:20:36] (03CR) 10jenkins-bot: Fix use of argument perfLogFilename in convertLinks.php [core] - 10https://gerrit.wikimedia.org/r/520312 (owner: 10Umherirrender) [10:23:31] (03PS3) 10Mainframe98: Support the creation of special pages with services injected [core] - 10https://gerrit.wikimedia.org/r/534770 (https://phabricator.wikimedia.org/T222388) [10:26:39] (03CR) 10jerkins-bot: [V: 04-1] Remove redundant closure for all modules with packageFiles [core] - 10https://gerrit.wikimedia.org/r/512519 (https://phabricator.wikimedia.org/T50886) (owner: 10Fomafix) [10:28:53] (03CR) 10ItSpiderman: Add `change` event to `bs.ui.widget.TextInputMWVisualEditor` (031 comment) [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534772 (owner: 10Robert Vogel) [10:35:11] (03CR) 10jenkins-bot: Pass Title to IndexPager::buildPrevNextNavigation [core] - 10https://gerrit.wikimedia.org/r/534503 (owner: 10Umherirrender) [10:35:50] 10GrowthExperiments, 10Growth-Team (Current Sprint): Deploy EditorJourney to Basque Wikipedia - https://phabricator.wikimedia.org/T232061 (10kostajh) @Theklan @Trizek-WMF @MMiller_WMF the sensitive namespaces are identified as `0, 1, 2, 6, 7, 104`. I wanted to double check this: - 2 (User) is sensitive but 3... [10:36:47] 10MediaWiki-extensions-Scribunto, 10Wikidata, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Patch-For-Review, and 2 others: LuaWikibaseEntityLibraryTest: CI failing en masse - https://phabricator.wikimedia.org/T231799 (10Lucas_Werkmeister_WMDE) Well, https://gerrit.wikimedia.org/r/533944 showed that https... [10:37:04] (03CR) 10Daniel Kinzler: [C: 03+1] "This is nice and straight forward, I'm inclined to just merge it." [core] - 10https://gerrit.wikimedia.org/r/534770 (https://phabricator.wikimedia.org/T222388) (owner: 10Mainframe98) [10:39:23] (03PS1) 10ItSpiderman: Include AC in percentageBoost in post processing [extensions/BlueSpiceExtendedSearch] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534782 [10:40:10] (03CR) 10jerkins-bot: [V: 04-1] Remove redundant closure for all modules with packageFiles [core] - 10https://gerrit.wikimedia.org/r/512519 (https://phabricator.wikimedia.org/T50886) (owner: 10Fomafix) [10:46:40] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10TemplateData, 10VisualEditor: TemplateData - https://phabricator.wikimedia.org/T232168 (10Aklapper) @AlgorithmGG: > Which exact MediaWiki version and which TemplateData and TemplateWizard versions is this about? [10:47:28] (03CR) 10Awight: [C: 03+2] "Great idea to do this! Looks really helpful and demonstrates key techniques." (032 comments) [extensions/BoilerPlate] - 10https://gerrit.wikimedia.org/r/534615 (https://phabricator.wikimedia.org/T97105) (owner: 10Kosta Harlan) [10:48:16] 10Structured Data Engineering, 10Structured-Data-Backlog: Write selenium tests for QA checklist "Add/Edit/Remove Structured data on file page" section - https://phabricator.wikimedia.org/T227278 (10matthiasmullie) [10:49:02] 04(no projects): Emails from @mw1270.eqiad.wmnet addresses in special:Contact/stewards - https://phabricator.wikimedia.org/T232199 (10Vituzzu) [10:49:47] 10Structured Data Engineering, 10Structured-Data-Backlog: Write selenium tests for QA checklist "Add Structured data during file upload with Upload Wizard" section - https://phabricator.wikimedia.org/T232200 (10matthiasmullie) [10:50:08] 10MediaWiki-extensions-ContactPage, 10Stewards-and-global-tools: Emails from @mw1270.eqiad.wmnet addresses in special:Contact/stewards - https://phabricator.wikimedia.org/T232199 (10Krenair) [10:50:21] 10MediaWiki-extensions-ContactPage, 10Stewards-and-global-tools: Emails from @mw1270.eqiad.wmnet addresses in special:Contact/stewards - https://phabricator.wikimedia.org/T232199 (10Krenair) [10:51:17] 10Structured Data Engineering, 10Structured-Data-Backlog: Write selenium tests for QA checklist "Check page/file history AND recent changes" section - https://phabricator.wikimedia.org/T232201 (10matthiasmullie) [10:51:20] 10media-storage: Export timings metrics for swift container-sync - https://phabricator.wikimedia.org/T222887 (10fgiunchedi) [10:51:30] 10media-storage, 10observability: Export timings metrics for swift container-sync - https://phabricator.wikimedia.org/T222887 (10fgiunchedi) [10:51:56] 10wikimedia.biterg.io: Offer "Avg. Time Open (Days)" average value for Gerrit patchsets per affiliation/organization - https://phabricator.wikimedia.org/T224760 (10Aklapper) We're running into inconsistencies in Gerrit data in this task which distort the results: * Looking at https://gerrit.wikimedia.org/r/#/c/... [10:52:14] (03Merged) 10jenkins-bot: Add unit test example [extensions/BoilerPlate] - 10https://gerrit.wikimedia.org/r/534615 (https://phabricator.wikimedia.org/T97105) (owner: 10Kosta Harlan) [10:52:21] 10Structured Data Engineering, 10Structured-Data-Backlog: Write selenium tests for QA checklist "Check that watchlists work properly" section - https://phabricator.wikimedia.org/T232203 (10matthiasmullie) [10:52:34] 10Structured Data Engineering, 10Structured-Data-Backlog: Write selenium tests for QA checklist "Check page/file history AND recent changes" section - https://phabricator.wikimedia.org/T232201 (10matthiasmullie) [10:52:41] 10Structured Data Engineering, 10Structured-Data-Backlog: Write selenium tests for QA checklist "Add Structured data during file upload with Upload Wizard" section - https://phabricator.wikimedia.org/T232200 (10matthiasmullie) [10:52:52] 10Structured Data Engineering, 10Structured-Data-Backlog: Write selenium tests for QA checklist "Add/Edit/Remove Structured data on file page" section - https://phabricator.wikimedia.org/T227278 (10matthiasmullie) [10:53:27] 10AbuseFilter: Filter is slower than expected - https://phabricator.wikimedia.org/T232053 (10MohammadtheEditor) @Daimona I agree that 2ms on its own isn't slow, but considering Persian Wikipedia has over 150 active filters, the numbers add up, the main reason this issue is being worked on locally is the concern... [10:54:11] 10Structured Data Engineering, 10Structured-Data-Backlog: Write selenium tests for QA checklist "Check that diffs between past revisions/edits works" section - https://phabricator.wikimedia.org/T232204 (10matthiasmullie) [10:55:13] (03CR) 10Ladsgroup: "Anyone to merge this?" [core] - 10https://gerrit.wikimedia.org/r/532089 (https://phabricator.wikimedia.org/T229656) (owner: 10Ladsgroup) [10:55:24] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10TemplateData, 10VisualEditor: TemplateData - https://phabricator.wikimedia.org/T232168 (10AlgorithmGG) @Aklapper the stable version of mediawiki 1.33.0 TemplateData version 0.1.2 (7ffe97a) TemplateWizard version 0.1.0 (096f34e) what versions shoul... [10:55:26] 10Structured Data Engineering, 10Structured-Data-Backlog: Write selenium tests for QA checklist "Check that Search works properly" section - https://phabricator.wikimedia.org/T232205 (10matthiasmullie) [10:56:18] 10Structured Data Engineering, 10Structured-Data-Backlog: Write selenium tests for QA checklist "Check that general Commons functionality is still intact" section - https://phabricator.wikimedia.org/T232206 (10matthiasmullie) [10:57:05] 10Structured Data Engineering, 10Structured-Data-Backlog: Write selenium tests for QA checklist "Check UI design integrity" section - https://phabricator.wikimedia.org/T232207 (10matthiasmullie) [10:57:59] 10Structured Data Engineering, 10Structured-Data-Backlog: Write selenium tests for QA checklist "Check Language support beyond English" section - https://phabricator.wikimedia.org/T232208 (10matthiasmullie) [11:01:12] 10Structured Data Engineering, 10Structured-Data-Backlog (Current Work): Write selenium tests for QA checklist "Add/Edit/Remove Structured data on file page" section - https://phabricator.wikimedia.org/T227278 (10matthiasmullie) I've spun this off into multiple tickets - one per "category" - and I'm pulling th... [11:03:02] 10Structured Data Engineering, 10Structured-Data-Backlog (Current Work): Write selenium tests for QA checklist "Add/Edit/Remove Structured data on file page" section - https://phabricator.wikimedia.org/T227278 (10matthiasmullie) a:05matthiasmullie→03None And unassigning myself - I don't want to claim this.... [11:05:23] 10OABot: Increase maximum number of connections for oabot - https://phabricator.wikimedia.org/T232210 (10Nemo_bis) [11:06:45] (03PS3) 10Robert Vogel: Add `change` event to `bs.ui.widget.TextInputMWVisualEditor` [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534772 [11:06:57] (03CR) 10Robert Vogel: Add `change` event to `bs.ui.widget.TextInputMWVisualEditor` (031 comment) [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534772 (owner: 10Robert Vogel) [11:08:05] (03CR) 10ItSpiderman: [C: 03+2] Add `change` event to `bs.ui.widget.TextInputMWVisualEditor` [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534772 (owner: 10Robert Vogel) [11:08:05] (03PS1) 10ItSpiderman: Add `change` event to `bs.ui.widget.TextInputMWVisualEditor` [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/534784 [11:08:16] (03CR) 10ItSpiderman: [C: 03+2] Add `change` event to `bs.ui.widget.TextInputMWVisualEditor` [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/534784 (owner: 10ItSpiderman) [11:11:25] (03PS1) 10Dvogel hallowelt: Add edit button for mobile view. [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534785 [11:12:23] 10wikimedia.biterg.io: Offer "Avg. Time Open (Days)" average value for Gerrit patchsets per affiliation/organization - https://phabricator.wikimedia.org/T224760 (10Aklapper) We also need to provide input on how to visualize this. Input very welcome. Currently the visualization proposal can be seen in https://wik... [11:14:37] (03Merged) 10jenkins-bot: Add `change` event to `bs.ui.widget.TextInputMWVisualEditor` [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534772 (owner: 10Robert Vogel) [11:15:14] (03CR) 10jerkins-bot: [V: 04-1] Add `change` event to `bs.ui.widget.TextInputMWVisualEditor` [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/534784 (owner: 10ItSpiderman) [11:15:48] (03CR) 10Kosta Harlan: [C: 03+2] Discover unit tests in "Unit" directory [core] - 10https://gerrit.wikimedia.org/r/534407 (owner: 10Ladsgroup) [11:20:12] 10OABot: Increase maximum number of connections for oabot - https://phabricator.wikimedia.org/T232210 (10Lucas_Werkmeister_WMDE) I think you’re running out of concurrent connections because you’re not closing sessions correctly: `lang=python def get(cls, wiki, user): session = get_session()()... [11:23:11] 10MediaWiki-Internationalization, 10Wikisource: Wrongly attributed canonical namespaces on nap.source - https://phabricator.wikimedia.org/T231880 (10Ruthven) @Dcljr Thanks, but never mind: I never liked too much the bureaucracy, and we're doing fine with the virtual namespace //Wikisource:Prugetto// ; see: ht... [11:23:26] 10MediaWiki-extensions-RSS, 10Developer-Advocacy, 10Discourse: A template to show discourse-mediawiki.wmflabs.org feeds - https://phabricator.wikimedia.org/T185075 (10Samwilson) [11:23:28] 10Discourse, 10Wikimedia-Site-requests, 10Patch-For-Review: Whitelist discourse-mediawiki.wmflabs.org for Extension:RSS in MediaWiki.org - https://phabricator.wikimedia.org/T185087 (10Samwilson) 05Stalled→03Declined Yes. I think a custom Discourse extension is the way to go. [11:25:15] 10OABot: Increase maximum number of connections for oabot - https://phabricator.wikimedia.org/T232210 (10Nemo_bis) p:05Triage→03Normal a:03Nemo_bis Right, thank you! https://github.com/dissemin/oabot/pull/54 [11:28:09] 10MediaWiki-extension-requests, 10Discourse: Write an extension for displaying Discourse feeds on mediawiki.org - https://phabricator.wikimedia.org/T215053 (10Samwilson) I've created a repo request at https://www.mediawiki.org/wiki/Gerrit/New_repositories/Requests Other than `latest` posts (optionally by tag... [11:28:15] 10OABot: OAbot runs out of database connections - https://phabricator.wikimedia.org/T232210 (10Nemo_bis) 05Open→03Resolved [11:31:54] (03PS7) 10AlexPinchuk: Mobile button, breadcrumbs, categories, edit-button, watch button panels removed from printable page [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534451 [11:35:12] (03Abandoned) 10Dvogel hallowelt: [WIP] Page header: Use 'Main Page' as portal page for each namespace [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/525070 (owner: 10Dvogel hallowelt) [11:35:55] 10GrowthExperiments, 10Growth-Team (Current Sprint): Deploy Growth features to Basque Wikipedia - https://phabricator.wikimedia.org/T232060 (10kostajh) a:03kostajh > we should deploy the same way we did for Arabic Wikipedia. @MMiller_WMF to clarify, does this mean WelcomeSurvey should run as an A/B experime... [11:36:24] (03PS2) 10Dvogel hallowelt: Add edit button for mobile view. [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534785 [11:38:17] 10OABot: OAbot runs out of database connections - https://phabricator.wikimedia.org/T232210 (10Nemo_bis) Ok, users seem to be doing fine now. Will do followup changes in separate patches. It's been years since I last looked at this class ^_^ and we were thinking of redoing the database/caching part entirely... [11:38:32] (03Merged) 10jenkins-bot: Discover unit tests in "Unit" directory [core] - 10https://gerrit.wikimedia.org/r/534407 (owner: 10Ladsgroup) [11:40:03] 10MediaWiki-extension-requests, 10Discourse, 10Space: Write an extension for displaying Discourse feeds on mediawiki.org - https://phabricator.wikimedia.org/T215053 (10Qgil) [11:41:34] 10MediaWiki-extensions-WikibaseRepository, 10Math, 10Wikidata, 10Wikidata-Campsite, and 2 others: Make it possible to query for math values - https://phabricator.wikimedia.org/T195765 (10Lea_Lacroix_WMDE) [11:41:47] (03PS1) 10ItSpiderman: Another fix for save dialog preview position [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534787 [11:42:38] 10MediaWiki-extensions-WikibaseRepository, 10Math, 10Wikidata, 10Wikidata-Campsite, and 2 others: Make it possible to query for math values - https://phabricator.wikimedia.org/T195765 (10Lea_Lacroix_WMDE) Hey @Lucas_Werkmeister_WMDE, I tried to reorganize the task desc a bit with our usual template. Would... [11:46:32] 10MediaWiki-extensions-WikibaseRepository, 10Math, 10Wikidata, 10Wikidata-Campsite, and 2 others: Make it possible to query for math values - https://phabricator.wikimedia.org/T195765 (10Lea_Lacroix_WMDE) [11:47:42] 10MediaWiki-extensions-WikibaseRepository, 10Math, 10Wikidata, 10Wikidata-Campsite, and 2 others: Make it possible to query for math values - https://phabricator.wikimedia.org/T195765 (10Lucas_Werkmeister_WMDE) [11:48:53] (03PS1) 10Mainframe98: [POC] Use ObjectFactory to create API modules [core] - 10https://gerrit.wikimedia.org/r/534788 (https://phabricator.wikimedia.org/T222388) [11:52:19] 10MediaWiki-API, 10CPT Initiatives (API Integration Tests), 10Core Platform Team Workboards (Purple), 10Patch-For-Review, 10Performance-Team (Radar): Enable API integration tests to ensure that GET requests will always see the effect of previous POST requests. - https://phabricator.wikimedia.org/T230211 (... [11:52:34] 10GrowthExperiments, 10Wikimedia-User-Group-Basque, 10Growth-Team (Current Sprint): Prepare for Growth experiments at Basque Wikipedia - https://phabricator.wikimedia.org/T223619 (10kostajh) @Theklan ` https://eu.wikipedia.org/wiki/Laguntza:Ikusizko_Editorea https://eu.wikipedia.org/wiki/Wikipedia:... [11:52:43] 10Design, 10MediaWiki-extensions-WikibaseRepository, 10WMDE-Design, 10Wikidata: Make statement groups clickable and append property IDs to the URLs - https://phabricator.wikimedia.org/T218402 (10alaa_wmde) [11:52:51] 10Design, 10MediaWiki-extensions-WikibaseRepository, 10WMDE-Design, 10Wikidata, and 5 others: Highlight statement(s) when using "#P" in URL - https://phabricator.wikimedia.org/T178745 (10alaa_wmde) 05Open→03Resolved [11:53:25] (03CR) 10jerkins-bot: [V: 04-1] [POC] Use ObjectFactory to create API modules [core] - 10https://gerrit.wikimedia.org/r/534788 (https://phabricator.wikimedia.org/T222388) (owner: 10Mainframe98) [11:57:33] (03PS2) 10Mainframe98: [POC] Use ObjectFactory to create API modules [core] - 10https://gerrit.wikimedia.org/r/534788 (https://phabricator.wikimedia.org/T222388) [11:58:27] (03PS4) 10Daniel Kinzler: Add support for MediaWiki-Chronology-Protection header. [tools/api-testing] - 10https://gerrit.wikimedia.org/r/530631 (https://phabricator.wikimedia.org/T230211) [11:59:51] 10AbuseFilter: Filter is slower than expected - https://phabricator.wikimedia.org/T232053 (10Daimona) You could use `page_id === 0`, if you need a quick and mostly-reliable solution. `page_age` would be more reliable, but it'd still require a DB query. Please tell me if you have other questions and/or want to kn... [12:00:21] 10netbox: Netbox: move it to dedicated Ganeti VMs - https://phabricator.wikimedia.org/T223291 (10MoritzMuehlenhoff) >>! In T223291#5467969, @akosiaris wrote: >> Also adding @akosiaris for input as he initially wrote these classes. > > The initial intention was for $includes to be an array indeed. So I favor b)... [12:01:58] 10MediaWiki-extensions-Scribunto, 10Wikidata, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Patch-For-Review, and 2 others: LuaWikibaseEntityLibraryTest: CI failing en masse - https://phabricator.wikimedia.org/T231799 (10alaa_wmde) a:05Lucas_Werkmeister_WMDE→03None Per: > Edit: I’m not currently worki... [12:03:11] (03PS4) 10Dvogel hallowelt: Fix html template for screenreader [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533496 (owner: 10JenyaPunchenko) [12:03:57] (03CR) 10jenkins-bot: Discover unit tests in "Unit" directory [core] - 10https://gerrit.wikimedia.org/r/534407 (owner: 10Ladsgroup) [12:04:13] 10Design, 10MediaWiki-extensions-WikibaseRepository, 10WMDE-Design, 10Wikidata, and 5 others: Highlight statement(s) when using "#P" in URL - https://phabricator.wikimedia.org/T178745 (10Lucas_Werkmeister_WMDE) >>! In T178745#5467875, @abian wrote: > The highlighting of statement groups ("properties") is n... [12:04:39] (03PS1) 10Pwirth: Fix button text for diff and history link. ERM:14971 [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/534791 [12:05:37] 10MediaWiki-API, 10CPT Initiatives (API Integration Tests), 10Core Platform Team Workboards (Purple), 10Patch-For-Review, 10Performance-Team (Radar): Enable API integration tests to ensure that GET requests will always see the effect of previous POST requests. - https://phabricator.wikimedia.org/T230211 (... [12:06:47] (03CR) 10jerkins-bot: [V: 04-1] [POC] Use ObjectFactory to create API modules [core] - 10https://gerrit.wikimedia.org/r/534788 (https://phabricator.wikimedia.org/T222388) (owner: 10Mainframe98) [12:11:11] (03PS3) 10Mainframe98: [POC] Use ObjectFactory to create API modules [core] - 10https://gerrit.wikimedia.org/r/534788 (https://phabricator.wikimedia.org/T222388) [12:11:48] 10GrowthExperiments, 10Wikimedia-User-Group-Basque, 10Growth-Team (Current Sprint): Prepare for Growth experiments at Basque Wikipedia - https://phabricator.wikimedia.org/T223619 (10kostajh) @Theklan here is the work-in-progress patch https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/534789/1/wm... [12:13:46] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Spike: [Spike, 8hrs] Investigate using display locking when expanding/collapsing sections - https://phabricator.wikimedia.org/T230941 (10ovasileva) >>! In T230941#5469563, @Jdlrobson wrote: > @ovasileva could you provide... [12:14:41] (03CR) 10Ladsgroup: [C: 04-1] Add a reminder for blank user summary when saving an editted Schema text (031 comment) [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/534602 (https://phabricator.wikimedia.org/T230399) (owner: 10Noa wmde) [12:16:02] 10MediaWiki-General: "Proxy mode" for third-party proxies (to disable login or editing buttons) - https://phabricator.wikimedia.org/T232188 (10CristianCantoro) [12:16:28] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10GrowthExperiments-NewcomerTasks, 10Growth-Team (Current Sprint): Newcomer tasks: prototype task selection - https://phabricator.wikimedia.org/T231506 (10Pginer-WMF) >>! In T231506#5466835, @MMiller_WMF wrote: > * If a user has any edits, it takes the mos... [12:18:49] 10CPT Initiatives (API Integration Tests), 10Core Platform Team Workboards (Purple): Create a MediaWiki extension for generating a Mocha config that runs tests for all enabled extensions - https://phabricator.wikimedia.org/T231910 (10Clarakosi) a:03Clarakosi [12:19:31] 10Design, 10OOUI, 10VisualEditor: Remove borders from toolbars in WMUI - https://phabricator.wikimedia.org/T232003 (10Esanders) I don't think the action toolbar tools (on the right) need borders, see other page-level toolbars (top rows): >>! In T231815#5459454, @Esanders wrote: > Comparative analysis: > >... [12:21:40] (03CR) 10jerkins-bot: [V: 04-1] [POC] Use ObjectFactory to create API modules [core] - 10https://gerrit.wikimedia.org/r/534788 (https://phabricator.wikimedia.org/T222388) (owner: 10Mainframe98) [12:22:02] (03PS1) 10Dvogel hallowelt: Add screenreader compatibility for PageHeader [extensions/BlueSpiceInsertCategory] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534792 [12:23:15] 10Design, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review: Consider removing toolbar borders - https://phabricator.wikimedia.org/T231815 (10Esanders) Updated the prototype with more compact dropdown indicators (75%): 320px: {F30236814,width=100%} 360px: {F30236816,width=100%} [12:24:22] (03CR) 10Esanders: [C: 03+2] VE: Scroll past infobox after showing anon editor warning [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/534675 (https://phabricator.wikimedia.org/T231848) (owner: 10Bartosz Dziewoński) [12:24:44] 10wikimedia.biterg.io: Allow to filter by Gerrit label 'code review' in the frontend - https://phabricator.wikimedia.org/T224755 (10Aklapper) Reporting progress on the backend here: Looking at https://wikimedia.biterg.io/goto/326470f410eaa0a5fa1808e56ad037ac (`url:"https://gerrit.wikimedia.org/r/533713"`), compa... [12:25:08] (03CR) 10Mainframe98: "Right now this sorta works; it appears that some extensions manually create an ApiModuleManager instance. These would need to be fixed bef" [core] - 10https://gerrit.wikimedia.org/r/534788 (https://phabricator.wikimedia.org/T222388) (owner: 10Mainframe98) [12:26:20] 04(no projects): [[Special:Random]] when used in a proxied website redirects to the main domain wikipedia.org - https://phabricator.wikimedia.org/T232213 (10CristianCantoro) [12:27:18] 10MediaWiki-General: "Proxy mode" for third-party proxies (to disable login or editing buttons) - https://phabricator.wikimedia.org/T232188 (10CristianCantoro) >>! In T232188#5470736, @Aklapper wrote: >> There are many other small quirks, such as the fact that [[Special:Random]] redirects automatically to the ma... [12:27:31] (03PS1) 10Tchanders: Deprecate GetBlockedStatus hook [core] - 10https://gerrit.wikimedia.org/r/534793 (https://phabricator.wikimedia.org/T229035) [12:28:28] (03CR) 10Mainframe98: mediawiki.util: Move to its own resources/src/ directory (031 comment) [core] - 10https://gerrit.wikimedia.org/r/534713 (owner: 10Krinkle) [12:29:31] (03CR) 10jerkins-bot: [V: 04-1] [POC] Use ObjectFactory to create API modules [core] - 10https://gerrit.wikimedia.org/r/534788 (https://phabricator.wikimedia.org/T222388) (owner: 10Mainframe98) [12:30:27] (03CR) 10jerkins-bot: [V: 04-1] [POC] Use ObjectFactory to create API modules [core] - 10https://gerrit.wikimedia.org/r/534788 (https://phabricator.wikimedia.org/T222388) (owner: 10Mainframe98) [12:30:54] 10MediaWiki-User-management, 10Anti-Harassment, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Patch-For-Review: Deprecate 'GetBlockedStatus' hook and reduce visibility of User::mBlock, User::mBlockedBy and User::mHideName - https://phabricator.wikimedia.org/T229035 (10Tchanders) [12:30:59] 10MediaWiki-History-and-Diffs, 10Wikidata: Undo links disappeared from Wikidata diffs - https://phabricator.wikimedia.org/T232214 (10Mormegil) [12:31:05] (03CR) 10Esanders: [C: 04-2] "Per Krinkle on task, would need evaluation from Parsing team before being merged." [core] - 10https://gerrit.wikimedia.org/r/508295 (https://phabricator.wikimedia.org/T4085) (owner: 10Dvorapa) [12:31:21] (03PS1) 10Pwirth: Add oldid link and url to recent changes store [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/534794 [12:31:30] 04(no projects): [[Special:Random]] when used in a proxied website redirects to the main domain wikipedia.org - https://phabricator.wikimedia.org/T232213 (10Reedy) >I could reproduce this bug on multiple browsers and I have no reason to believe this is a client-related issue, nor I think this is a configuration... [12:31:55] 10MediaWiki-User-management, 10Anti-Harassment (The Letter Song), 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Patch-For-Review: Deprecate 'GetBlockedStatus' hook and reduce visibility of User::mBlock, User::mBlockedBy and User::mHideName - https://phabricator.wikimedia.org/T229035 (10Tchanders) [12:32:27] 10MediaWiki-User-management, 10Anti-Harassment (The Letter Song), 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Patch-For-Review: Deprecate 'GetBlockedStatus' hook and reduce visibility of User::mBlock, User::mBlockedBy and User::mHideName - https://phabricator.wikimedia.org/T229035 (10Tchanders) a:03Tch... [12:32:33] (03PS1) 10Pwirth: Use old to link to correct revision of the change. ERM14971 [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/534795 [12:35:28] 10Browser-Support-Google-Chrome: Unexpected line breaks in MediaWiki pages in Chrome 76 (does not happen in Chrome 75) - https://phabricator.wikimedia.org/T232066 (10Aklapper) [12:35:33] 10Browser-Support-Google-Chrome: Unexpected line breaks in MediaWiki pages in Chrome 76 (does not happen in Chrome 75) - https://phabricator.wikimedia.org/T232066 (10Aklapper) I also tried with Chromium version 76 now and I can now reproduce the problem: {F30236826} So this really looks like a Chromium problem... [12:37:13] 04(no projects): [[Special:Random]] when used in a proxied website redirects to the main domain wikipedia.org - https://phabricator.wikimedia.org/T232213 (10Reedy) [12:39:04] (03CR) 10Fomafix: "A first improvement would be to escape only '<' and not '>' and '&'. Escaping of '<' should be sufficient to escape the critical ' 10MediaWiki-API, 10CPT Initiatives (API Integration Tests), 10Core Platform Team Workboards (Purple), 10Patch-For-Review, 10Performance-Team (Radar): Enable API integration tests to ensure that GET requests will always see the effect of previous POST requests. - https://phabricator.wikimedia.org/T230211 (... [12:43:03] (03PS1) 10Dvogel hallowelt: Add screenreader compatibility for Logo [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534796 [12:48:10] (03Merged) 10jenkins-bot: VE: Scroll past infobox after showing anon editor warning [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/534675 (https://phabricator.wikimedia.org/T231848) (owner: 10Bartosz Dziewoński) [12:49:39] 10MediaWiki-extensions-ContactPage, 10Mail, 10Stewards-and-global-tools: Emails from @mw1270.eqiad.wmnet addresses in special:Contact/stewards - https://phabricator.wikimedia.org/T232199 (10Aklapper) [12:49:45] (03CR) 10Pwirth: "recheck" [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533496 (owner: 10JenyaPunchenko) [12:50:01] (03CR) 10Pwirth: "recheck" [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534796 (owner: 10Dvogel hallowelt) [12:50:14] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceInsertCategory] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534792 (owner: 10Dvogel hallowelt) [12:50:58] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceExtendedSearch] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534752 (owner: 10ItSpiderman) [12:54:36] (03CR) 10jenkins-bot: VE: Scroll past infobox after showing anon editor warning [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/534675 (https://phabricator.wikimedia.org/T231848) (owner: 10Bartosz Dziewoński) [13:02:31] 10MediaWiki-Internationalization, 10Patch-For-Review: Silesian (szl) namespaces correction - https://phabricator.wikimedia.org/T230829 (10Aklapper) @Uostofchuodnego: Congratulations! :) You may want to check https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines for better formatting of the commit mes... [13:04:13] (03PS1) 10Dvogel hallowelt: Add screenreader compatibility to search box html template. [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534799 [13:06:07] 10AbuseFilter: Filter is slower than expected - https://phabricator.wikimedia.org/T232053 (10Huji) @matej_suchanek @Daimona thanks for the quick response. What is your thought on Filter 198? Do you think `ccnorm()` is the culprit? (We can obviously make that the last rule if so.) Also, where in the AF parser co... [13:06:40] 04(no projects): [[Special:Random]] when used in a proxied website redirects to the main domain wikipedia.org - https://phabricator.wikimedia.org/T232213 (10CristianCantoro) >>! In T232213#5471202, @Reedy wrote: >>I could reproduce this bug on multiple browsers and I have no reason to believe this is a client-r... [13:07:33] (03PS1) 10Dvogel hallowelt: Add screenreader compatibility for searchbox [extensions/BlueSpiceExtendedSearch] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534800 [13:08:34] 04(no projects): [[Special:Random]] when used in a proxied website redirects to the main domain wikipedia.org - https://phabricator.wikimedia.org/T232213 (10Reedy) https://github.com/caddyserver/caddy/issues/1011 looks a lot like the issue you're experiencing [13:11:56] (03PS1) 10Pwirth: Fix removal of dirty flag when save failed due to errors [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/534801 [13:13:36] (03CR) 10Pwirth: "recheck" [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534451 (owner: 10AlexPinchuk) [13:13:53] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceExtendedSearch] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534800 (owner: 10Dvogel hallowelt) [13:14:23] (03CR) 10Pwirth: "recheck" [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534799 (owner: 10Dvogel hallowelt) [13:32:50] (03PS1) 10Yaron Koren: Fix for #cargo_compound_query with deferred formats [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/534806 [13:33:12] (03PS8) 10Bartosz Dziewoński: MobileFrontend is now managing the toggling code. Remove. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533358 (owner: 10Jdlrobson) [13:33:48] 10ISA: [Bug] Campaign not counting the right number of items, possibly .tif? - https://phabricator.wikimedia.org/T232038 (10NavinoEvans) >>! In T232038#5469106, @Multichill wrote: >>>! In T232038#5468740, @Keegan wrote: >>>>! In T232038#5468615, @Astinson wrote: >>> Yeah, you should be able to use one of the JPG... [13:33:49] (03PS2) 10Yaron Koren: Fix for #cargo_compound_query with deferred formats [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/534806 [13:35:50] 10ISA: Current user images improved not working - https://phabricator.wikimedia.org/T232192 (10NavinoEvans) [13:37:53] (03PS1) 10Robert Vogel: [WIP] Add variables for `config` and `data` dir [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534807 [13:38:16] (03PS5) 10Noa wmde: Add a reminder for blank user summary when saving an editted Schema text [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/534602 (https://phabricator.wikimedia.org/T230399) [13:42:17] 10AbuseFilter: Filter is slower than expected - https://phabricator.wikimedia.org/T232053 (10Daimona) >>! In T232053#5471241, @Huji wrote: > @matej_suchanek @Daimona thanks for the quick response. What is your thought on Filter 198? Do you think `ccnorm()` is the culprit? (We can obviously make that the last rul... [13:42:53] 10MobileFrontend, 10Timeless, 10MW-1.34-notes (1.34.0-wmf.22; 2019-09-10): Section toggle indicators sometimes appear in weird places on mobile Timeless - https://phabricator.wikimedia.org/T232167 (10matmarex) 05Open→03Resolved [13:45:18] 10Editing QA, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10VisualEditor (Current work): VisualEditor/NWE does not handle 'preloadparams' with explicit indexes - https://phabricator.wikimedia.org/T231382 (10matmarex) [13:45:20] 10Editing QA, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10VisualEditor (Current work): VisualEditor should use errorformat=html and maybe drop some of our custom error messages in favor of default ones - https://phabricator.wikimedia.org/T229532 (10matmarex) [13:46:05] (03PS1) 10Pwirth: Fix fatal in VersionViewer when 0 given as oldid [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/534808 [13:48:10] (03PS1) 10Robert Vogel: Remove legacy shim and allow for modern setup [extensions/BlueSpiceSMWConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534809 [13:48:32] (03CR) 10Yaron Koren: [C: 03+2] Fix for #cargo_compound_query with deferred formats [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/534806 (owner: 10Yaron Koren) [13:49:41] 10Core Platform Team, 10CPT Initiatives (Core REST API in PHP): Enable cross-origin resource sharing (CORS) - https://phabricator.wikimedia.org/T232176 (10Anomie) Seems like effectively a duplicate of {T210790} to me. I'm not going to unilaterally close this as such, but such a close is my recommendation as,... [13:49:45] 10MediaWiki-History-and-Diffs, 10Wikidata: Undo links disappeared from Wikidata diffs - https://phabricator.wikimedia.org/T232214 (10Lucas_Werkmeister_WMDE) > My personal suspect: rMW6906a7728cf5447d30da6c7a51add936f469978a#change-op58PNimx6Sc Can confirm, reverting that commit makes the undo appear again on... [13:50:12] (03PS9) 10Bartosz Dziewoński: MobileFrontend is now managing the toggling code. Remove. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533358 (owner: 10Jdlrobson) [13:51:00] (03CR) 10Bartosz Dziewoński: [C: 03+2] "Please ignore PS8, I messed something up. PS9 updates Selenium tests to wait on a module that is actually being loaded." [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533358 (owner: 10Jdlrobson) [13:51:18] 10MediaWiki-History-and-Diffs, 10Wikidata: Undo links disappeared from Wikidata diffs - https://phabricator.wikimedia.org/T232214 (10Lucas_Werkmeister_WMDE) [13:51:54] (03PS2) 10Pwirth: Fix fatal in VersionViewer when invalid revision given as oldid [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/534808 [13:53:33] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceSMWConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534809 (owner: 10Robert Vogel) [13:54:18] (03Merged) 10jenkins-bot: Fix for #cargo_compound_query with deferred formats [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/534806 (owner: 10Yaron Koren) [13:54:25] 10MediaWiki-History-and-Diffs, 10Wikidata: Undo links disappeared from Wikidata diffs - https://phabricator.wikimedia.org/T232214 (10daniel) My rationale for suppressing the undo link when direct editing is disabled was that action=edit is for direct editing. But Wikibase overrides the action handle specifica... [13:55:25] 10MediaWiki-Maintenance-scripts, 10Core Platform Team: errors when I run "rebuildImages.php" (MW 1.30) - https://phabricator.wikimedia.org/T232145 (10Anomie) 05Open→03Declined >>! In T232145#5469471, @Aklapper wrote: > @Revansx: Please note that MediaWiki 1.30.0 is an old, insecure, unsupported version. Us... [13:55:49] 10MediaWiki-History-and-Diffs, 10Wikidata: Undo links disappeared from Wikidata diffs - https://phabricator.wikimedia.org/T232214 (10Lucas_Werkmeister_WMDE) >>! In T232214#5471317, @daniel wrote: > My rationale for suppressing the undo link when direct editing is disabled was that action=edit is for direct edi... [13:56:58] 10Core Platform Team, 10CPT Initiatives (Core REST API in PHP): Enable cross-origin resource sharing (CORS) - https://phabricator.wikimedia.org/T232176 (10dbarratt) I created this task as per requested in https://www.mediawiki.org/wiki/Topic:V5y8azvepfpwyfdx [13:57:49] (03CR) 10Robert Vogel: [C: 03+2] Fix fatal in VersionViewer when invalid revision given as oldid [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/534808 (owner: 10Pwirth) [13:57:53] (03PS1) 10Robert Vogel: Fix fatal in VersionViewer when invalid revision given as oldid [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534810 [13:57:56] (03CR) 10Robert Vogel: [C: 03+2] Fix fatal in VersionViewer when invalid revision given as oldid [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534810 (owner: 10Robert Vogel) [13:58:12] (03CR) 10Robert Vogel: [C: 03+2] Fix removal of dirty flag when save failed due to errors [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/534801 (owner: 10Pwirth) [13:58:17] (03PS1) 10Robert Vogel: Fix removal of dirty flag when save failed due to errors [extensions/BlueSpiceSocial] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534811 [13:58:20] (03CR) 10Robert Vogel: [C: 03+2] Fix removal of dirty flag when save failed due to errors [extensions/BlueSpiceSocial] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534811 (owner: 10Robert Vogel) [13:58:23] 10MediaWiki-extensions-ContactPage, 10Mail, 10Stewards-and-global-tools: Emails from @mw1270.eqiad.wmnet addresses in special:Contact/stewards - https://phabricator.wikimedia.org/T232199 (10Reedy) I presume it's from `apache@mw[number].eqiad.wmnet`? As that sounds like it's taking the default for `$wgPasswo... [13:58:47] (03CR) 10jenkins-bot: Fix for #cargo_compound_query with deferred formats [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/534806 (owner: 10Yaron Koren) [13:59:35] 10MediaWiki-Email, 10MediaWiki-extensions-ContactPage, 10Mail, 10Stewards-and-global-tools: Emails from @mw1270.eqiad.wmnet addresses in special:Contact/stewards - https://phabricator.wikimedia.org/T232199 (10Reedy) [14:01:03] (03PS1) 10Daniel Kinzler: DifferenceEngine: show undo links for non-text content [core] - 10https://gerrit.wikimedia.org/r/534812 (https://phabricator.wikimedia.org/T232214) [14:01:18] 10CX-boost, 10CX-out-of-beta, 10Language-Team (Language-2019-July-September): Enable Content Translation in selected small Wikipedias as a default tool - https://phabricator.wikimedia.org/T225302 (10Jpita) [14:01:20] 10CX-boost, 10CX-out-of-beta, 10Language-Team (Language-2019-July-September): Enable Content Translation in Javanese Wikipedia as a default tool - https://phabricator.wikimedia.org/T231207 (10Jpita) 05Open→03Resolved [14:04:29] (03Merged) 10jenkins-bot: Fix fatal in VersionViewer when invalid revision given as oldid [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534810 (owner: 10Robert Vogel) [14:06:02] 10MediaWiki-Email, 10MediaWiki-extensions-ContactPage, 10Mail, 10Stewards-and-global-tools: Emails from @mw1270.eqiad.wmnet addresses in special:Contact/stewards - https://phabricator.wikimedia.org/T232199 (10Vituzzu) It's a different string. Namely in this case is a wrongly encoded Cyrillic string. This t... [14:06:40] (03PS2) 10Jdrewniak: Remove "large" icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/534607 (https://phabricator.wikimedia.org/T231683) [14:06:46] (03CR) 10Lucas Werkmeister (WMDE): [C: 03+1] DifferenceEngine: show undo links for non-text content [core] - 10https://gerrit.wikimedia.org/r/534812 (https://phabricator.wikimedia.org/T232214) (owner: 10Daniel Kinzler) [14:06:57] 10MediaWiki-Special-pages, 10Growth-Team, 10StructuredDiscussions: User contribs, filtered by calendar period, contains edits on Flow pages outside of this period - https://phabricator.wikimedia.org/T196227 (10Aklapper) [14:08:28] 10Who-Wrote-That, 10Community-Tech (Kanban (Q1 2019-20)): IP contributions are prefixed with 0| and the links are broken - https://phabricator.wikimedia.org/T231960 (10dom_walden) IP addresses display correctly in the revision details popup. The "talk" and "contribs" links are correct. For IPs, it should be n... [14:08:40] (03PS8) 10Robert Vogel: Improve print stylings [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534451 (owner: 10AlexPinchuk) [14:09:23] (03CR) 10Robert Vogel: [C: 03+2] Improve print stylings [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534451 (owner: 10AlexPinchuk) [14:09:25] (03Merged) 10jenkins-bot: Fix removal of dirty flag when save failed due to errors [extensions/BlueSpiceSocial] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534811 (owner: 10Robert Vogel) [14:09:40] (03PS1) 10Robert Vogel: Improve print stylings [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/534815 [14:09:46] (03CR) 10Robert Vogel: [C: 03+2] Improve print stylings [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/534815 (owner: 10Robert Vogel) [14:10:18] (03PS1) 10Robert Vogel: Improve print stylings [skins/BlueSpiceCalumma] (REL1_31) - 10https://gerrit.wikimedia.org/r/534816 [14:10:33] (03CR) 10Robert Vogel: [C: 03+2] Improve print stylings [skins/BlueSpiceCalumma] (REL1_31) - 10https://gerrit.wikimedia.org/r/534816 (owner: 10Robert Vogel) [14:11:25] (03CR) 10jerkins-bot: [V: 04-1] Improve print stylings [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534451 (owner: 10AlexPinchuk) [14:12:34] (03CR) 10jerkins-bot: [V: 04-1] Improve print stylings [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/534815 (owner: 10Robert Vogel) [14:13:14] (03CR) 10jerkins-bot: [V: 04-1] Improve print stylings [skins/BlueSpiceCalumma] (REL1_31) - 10https://gerrit.wikimedia.org/r/534816 (owner: 10Robert Vogel) [14:13:27] (03CR) 10Alaa Sarhan: [C: 03+2] "Thanks for the quick fix!" [core] - 10https://gerrit.wikimedia.org/r/534812 (https://phabricator.wikimedia.org/T232214) (owner: 10Daniel Kinzler) [14:13:29] (03CR) 10jerkins-bot: [V: 04-1] Improve print stylings [skins/BlueSpiceCalumma] (REL1_31) - 10https://gerrit.wikimedia.org/r/534816 (owner: 10Robert Vogel) [14:15:52] 10MediaWiki-extensions-Cargo: Deferred display formats fail with cargo_compound_query - https://phabricator.wikimedia.org/T232127 (10Yaron_Koren) 05Open→03Resolved a:03Yaron_Koren Sorry about that! This was a bug from January. I just checked in a fix for it; hopefully it will get to you soon. [14:15:57] 10MediaWiki-General, 10MediaWiki-extension-requests: Feature/extension suggestion for links to sections that are missing/renamed - https://phabricator.wikimedia.org/T203130 (10Aklapper) Also see T10928#137749 and {T18561} (which is another approach). Removing #mediawiki-history-and-diffs as this is not related... [14:16:53] (03PS9) 10AlexPinchuk: Improve print stylings [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534451 [14:17:38] (03CR) 10Daimona Eaytoy: phan: Enable PhanTypeMismatchArgument issue (031 comment) [core] - 10https://gerrit.wikimedia.org/r/517740 (https://phabricator.wikimedia.org/T231636) (owner: 10Umherirrender) [14:18:06] 10MediaWiki-Documentation, 10Core Platform Team, 10Performance-Team, 10MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), 10Patch-For-Review: Get MediaWiki generated docs in shape for easier reading/writing of Markdown files - https://phabricator.wikimedia.org/T232104 (10hashar) >>! In T232104#5468320, @Krinkle... [14:21:07] (03CR) 10Ottomata: "Not sure what's going on with test/event schema." [event-schemas] - 10https://gerrit.wikimedia.org/r/534702 (https://phabricator.wikimedia.org/T206814) (owner: 10Ppchelko) [14:22:15] (03Merged) 10jenkins-bot: MobileFrontend is now managing the toggling code. Remove. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533358 (owner: 10Jdlrobson) [14:22:17] (03Merged) 10jenkins-bot: Fix fatal in VersionViewer when invalid revision given as oldid [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/534808 (owner: 10Pwirth) [14:22:19] (03Merged) 10jenkins-bot: Fix removal of dirty flag when save failed due to errors [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/534801 (owner: 10Pwirth) [14:22:21] (03CR) 10jerkins-bot: [V: 04-1] Improve print stylings [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/534815 (owner: 10Robert Vogel) [14:25:02] (03CR) 10Anomie: [C: 03+1] "Looks good to me too." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/534770 (https://phabricator.wikimedia.org/T222388) (owner: 10Mainframe98) [14:26:01] 10MediaWiki-History-and-Diffs: The text "(No difference)" no longer appears when comparing two revisions on a page with no net changes between them on en-wiki - https://phabricator.wikimedia.org/T219880 (10Aklapper) 05Stalled→03Declined As nobody has managed to properly reproduce I'm going to close this task... [14:26:16] (03CR) 10jenkins-bot: MobileFrontend is now managing the toggling code. Remove. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533358 (owner: 10Jdlrobson) [14:30:19] (03CR) 10Jdrewniak: Remove "large" icons (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/534607 (https://phabricator.wikimedia.org/T231683) (owner: 10Jdrewniak) [14:30:45] 10MediaWiki-Page-editing, 10MediaWiki-Patrolling: Click on red link opens VisualEditor instead of default WikiEditor - https://phabricator.wikimedia.org/T231364 (10Aklapper) [14:32:24] 10MediaWiki-History-and-Diffs: The text "(No difference)" no longer appears when comparing two revisions on a page with no net changes between them on en-wiki - https://phabricator.wikimedia.org/T219880 (10Aklapper) Ah. Just found T228761 which has an explanation for this, so I am merging this task into {T228761}. [14:32:30] 10MediaWiki-History-and-Diffs: The text "(No difference)" no longer appears when comparing two revisions on a page with no net changes between them on en-wiki - https://phabricator.wikimedia.org/T219880 (10Aklapper) [14:32:32] 10MediaWiki-History-and-Diffs: Empty diff does not show "(No difference)" when it's retrieved from cache - https://phabricator.wikimedia.org/T228761 (10Aklapper) [14:33:39] (03PS2) 10AlexPinchuk: Improve print stylings [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/534815 (owner: 10Robert Vogel) [14:39:25] (03CR) 10Daniel Kinzler: [V: 03+2 C: 03+2] Add Anonymous Edit test [tools/api-testing] - 10https://gerrit.wikimedia.org/r/529951 (https://phabricator.wikimedia.org/T229853) (owner: 10Clarakosi) [14:41:09] (03CR) 10Daniel Kinzler: [V: 03+2 C: 03+2] Clean up test/Edit.js a bit. [tools/api-testing] - 10https://gerrit.wikimedia.org/r/530174 (owner: 10Daniel Kinzler) [14:41:34] (03PS2) 10Daniel Kinzler: Clean up test/Edit.js a bit. [tools/api-testing] - 10https://gerrit.wikimedia.org/r/530174 [14:42:23] (03CR) 10Daniel Kinzler: [V: 03+2 C: 03+2] Clean up test/Edit.js a bit. [tools/api-testing] - 10https://gerrit.wikimedia.org/r/530174 (owner: 10Daniel Kinzler) [14:42:30] (03CR) 10Ppchelko: "> Patch Set 2:" [event-schemas] - 10https://gerrit.wikimedia.org/r/534702 (https://phabricator.wikimedia.org/T206814) (owner: 10Ppchelko) [14:46:39] 10Who-Wrote-That, 10Community-Tech (Kanban (Q1 2019-20)): Handle WWT behavior with VisualEditor - https://phabricator.wikimedia.org/T231508 (10ifried) [14:48:23] 10MediaWiki-General, 10Performance-Team, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), 10Patch-For-Review: Audit and simplify MediaWiki initialisation code (Spring 2018) - https://phabricator.wikimedia.org/T189966 (10Krinkle) [14:48:35] 04(no projects): [[Special:Random]] when used in a proxied website redirects to the main domain wikipedia.org - https://phabricator.wikimedia.org/T232213 (10CristianCantoro) >>! In T232213#5471251, @Reedy wrote: > https://github.com/caddyserver/caddy/issues/1011 looks a lot like the issue you're experiencing T... [14:50:07] (03PS4) 10Daniel Kinzler: Trigger jobs when needed [tools/api-testing] - 10https://gerrit.wikimedia.org/r/530642 [14:50:18] (03PS3) 10Daniel Kinzler: Add Reparse dependent pages test [tools/api-testing] - 10https://gerrit.wikimedia.org/r/534530 (owner: 10Clarakosi) [14:50:46] (03CR) 10Krinkle: docs: Fix Doxygen parsing of @var descriptions with $var names (031 comment) [core] - 10https://gerrit.wikimedia.org/r/534649 (owner: 10Krinkle) [14:53:11] (03PS1) 10Tchanders: Use getter to get user block in SpecialContact [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/534820 [14:54:56] (03PS4) 10Mainframe98: Support the creation of special pages with services injected [core] - 10https://gerrit.wikimedia.org/r/534770 (https://phabricator.wikimedia.org/T222388) [14:55:46] (03CR) 10Mainframe98: "I've added the deprecation to the release notes, also with a note about the support for the creation of special pages that need services." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/534770 (https://phabricator.wikimedia.org/T222388) (owner: 10Mainframe98) [14:56:09] (03Merged) 10jenkins-bot: DifferenceEngine: show undo links for non-text content [core] - 10https://gerrit.wikimedia.org/r/534812 (https://phabricator.wikimedia.org/T232214) (owner: 10Daniel Kinzler) [14:57:57] (03PS1) 10Tchanders: Use getter to get block in SpecialRenameuser [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/534821 [14:59:11] (03CR) 10Krinkle: "@Legoktm @Simetrical Do one of you know what might be the issue here?" [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534533 (https://phabricator.wikimedia.org/T231929) (owner: 10Krinkle) [14:59:41] 10MediaWiki-User-management, 10Anti-Harassment (The Letter Song), 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Patch-For-Review: Deprecate 'GetBlockedStatus' hook and reduce visibility of User::mBlock, User::mBlockedBy and User::mHideName - https://phabricator.wikimedia.org/T229035 (10Tchanders) [14:59:52] (03CR) 10Clarakosi: [C: 04-1] "One small request below but otherwise LGTM" (031 comment) [tools/api-testing] - 10https://gerrit.wikimedia.org/r/530642 (owner: 10Daniel Kinzler) [15:01:04] (03CR) 10jerkins-bot: [V: 04-1] Use getter to get block in SpecialRenameuser [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/534821 (owner: 10Tchanders) [15:01:36] (03CR) 10Krinkle: [C: 04-1] "Okay, I think that can work. Let's amend encodeJsonForScript as needed, and then use that here?" [core] - 10https://gerrit.wikimedia.org/r/526385 (https://phabricator.wikimedia.org/T229311) (owner: 10Fomafix) [15:01:41] 10ContentTranslation, 10Language-Team (Language-2019-July-September): Infobox Presse écrite should not be translated to a table - https://phabricator.wikimedia.org/T232218 (10Jpita) [15:02:58] (03CR) 10Krinkle: [C: 03+2] Unit tests: Whitelist global so LoggerFactory doesn't explode [core] - 10https://gerrit.wikimedia.org/r/534774 (https://phabricator.wikimedia.org/T87781) (owner: 10Kosta Harlan) [15:03:36] (03CR) 10Ottomata: "> > I wonder if we could move tests like these into jsonschema-tools after all, and use them both as tests in jsonschema-tools, but also" [event-schemas] - 10https://gerrit.wikimedia.org/r/534702 (https://phabricator.wikimedia.org/T206814) (owner: 10Ppchelko) [15:03:51] 10MediaWiki-History-and-Diffs, 10Wikidata, 10MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), 10Patch-For-Review: Undo links disappeared from Wikidata diffs - https://phabricator.wikimedia.org/T232214 (10Lucas_Werkmeister_WMDE) This probably isn’t serious enough for a backport / Friday deployment, right? I haven... [15:07:00] (03PS1) 10Krinkle: docs: Remove GENERATE_MAN support from Doxyfile [core] - 10https://gerrit.wikimedia.org/r/534822 (https://phabricator.wikimedia.org/T232104) [15:07:30] (03CR) 10Anomie: [C: 04-1] "Overall this is a good start, thanks for taking it on." (037 comments) [core] - 10https://gerrit.wikimedia.org/r/534788 (https://phabricator.wikimedia.org/T222388) (owner: 10Mainframe98) [15:08:07] 10MediaWiki-API, 10MediaWiki-ServiceContainer, 10MediaWiki-Special-pages, 10TechCom, and 4 others: Create a mechanism for SpecialPages and API modules to have dependencies injected into them - https://phabricator.wikimedia.org/T222388 (10Anomie) [15:09:50] 10MediaWiki-History-and-Diffs, 10Wikidata, 10MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), 10Patch-For-Review: Undo links disappeared from Wikidata diffs - https://phabricator.wikimedia.org/T232214 (10Lucas_Werkmeister_WMDE) Undo links are back on Beta Wikidata now ([random diff](https://wikidata.beta.wmflabs... [15:10:30] 10Timeless: Clicking on the "context menu icon" on an alert message shows the message below the alert window - https://phabricator.wikimedia.org/T175832 (10Isarra) 05Open→03Invalid >>! In T175832#5470442, @Kaartic wrote: > Given that it's been a very long time since I filed this, I don't remember what I actu... [15:11:28] 10Advanced Mobile Contributions, 10MinervaNeue, 10MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), 10Mobile, and 3 others: Replace 24x24px SVGs in MF/Minerva - https://phabricator.wikimedia.org/T231613 (10alexhollender) [15:11:37] (03PS1) 10Krinkle: WIP: Debug ConfigFactory problem in CI [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534823 [15:12:22] (03CR) 10jenkins-bot: DifferenceEngine: show undo links for non-text content [core] - 10https://gerrit.wikimedia.org/r/534812 (https://phabricator.wikimedia.org/T232214) (owner: 10Daniel Kinzler) [15:12:24] (03CR) 10Krinkle: [C: 03+2] Improve various PHP method doc blocks [core] - 10https://gerrit.wikimedia.org/r/534385 (owner: 10Daimona Eaytoy) [15:13:03] (03CR) 10Ppchelko: "> Patch Set 2:" [event-schemas] - 10https://gerrit.wikimedia.org/r/534702 (https://phabricator.wikimedia.org/T206814) (owner: 10Ppchelko) [15:13:22] (03PS5) 10Clarakosi: Allow xdebug to be triggered from API tests [tools/api-testing] - 10https://gerrit.wikimedia.org/r/529937 (owner: 10Daniel Kinzler) [15:13:53] (03CR) 10jerkins-bot: [V: 04-1] WIP: Debug ConfigFactory problem in CI [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534823 (owner: 10Krinkle) [15:14:51] (03CR) 10Clarakosi: [V: 03+2 C: 03+2] Allow xdebug to be triggered from API tests [tools/api-testing] - 10https://gerrit.wikimedia.org/r/529937 (owner: 10Daniel Kinzler) [15:15:53] (03PS2) 10Krinkle: WIP: Debug ConfigFactory problem in CI [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534823 [15:17:34] (03CR) 10jerkins-bot: [V: 04-1] WIP: Debug ConfigFactory problem in CI [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534823 (owner: 10Krinkle) [15:19:48] (03CR) 10Krinkle: Provide command to adjust phpunit.xml for code coverage (031 comment) [core] - 10https://gerrit.wikimedia.org/r/526421 (https://phabricator.wikimedia.org/T100294) (owner: 10Kosta Harlan) [15:20:35] (03CR) 10Daniel Kinzler: Add Reparse dependent pages test (031 comment) [tools/api-testing] - 10https://gerrit.wikimedia.org/r/534530 (owner: 10Clarakosi) [15:20:58] (03PS3) 10Krinkle: WIP: Debug ConfigFactory problem in CI [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534823 [15:24:37] 10AbuseFilter: Filter is slower than expected - https://phabricator.wikimedia.org/T232053 (10Huji) 05Open→03Resolved a:03Huji Understood. I am going to mark this as resolved for now (the purpose of the task was to figure out ways that could potentially make the filters faster, and we have achieved that). [15:25:20] 10Utilities-mwdumper: MWDumper loads titles but revisions aren't accessible - https://phabricator.wikimedia.org/T231224 (10Uziel302) "each revision must have a "main" slot that corresponds to what is without MCR the singular page content." (Requests for comment/Multi-Content Revisions) Since those tables are ne... [15:25:54] 10Research: Understanding patrolling on Wikipedia - https://phabricator.wikimedia.org/T228817 (10Capt_Swing) [15:27:03] 10Research: Understanding patrolling on Wikipedia - https://phabricator.wikimedia.org/T228817 (10Capt_Swing) 05Open→03Resolved [15:27:04] (03PS4) 10Clarakosi: Add Reparse dependent pages test [tools/api-testing] - 10https://gerrit.wikimedia.org/r/534530 [15:27:13] 10Research: Review literature on patrolling workflows - https://phabricator.wikimedia.org/T229878 (10Capt_Swing) 05Open→03Resolved [15:27:19] (03Merged) 10jenkins-bot: Unit tests: Whitelist global so LoggerFactory doesn't explode [core] - 10https://gerrit.wikimedia.org/r/534774 (https://phabricator.wikimedia.org/T87781) (owner: 10Kosta Harlan) [15:28:05] (03CR) 10Clarakosi: Add Reparse dependent pages test (031 comment) [tools/api-testing] - 10https://gerrit.wikimedia.org/r/534530 (owner: 10Clarakosi) [15:28:19] 10CommRel-Specialists-Support (Jul-Sep-2019), 10VisualEditor (Current work): VE mobile default: community outreach - https://phabricator.wikimedia.org/T221200 (10ppelberg) 05Open→03Resolved Community outreach is completed. The message that was sent, who and where it was sent and any conversations that resu... [15:28:20] 10VisualEditor (Current work): VE mobile default: identify wikis for trial - https://phabricator.wikimedia.org/T221188 (10ppelberg) [15:29:32] (03PS1) 10Krinkle: mediawiki.util: Merge 'jquery.accessKeyLabel' into this module [core] - 10https://gerrit.wikimedia.org/r/534829 (https://phabricator.wikimedia.org/T218339) [15:30:08] (03CR) 10Krinkle: "Factored that part of the change out into https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/534829/" [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) (owner: 10Jforrester) [15:30:39] (03CR) 10jerkins-bot: [V: 04-1] WIP: Debug ConfigFactory problem in CI [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534823 (owner: 10Krinkle) [15:31:39] (03PS1) 10Yaron Koren: Add "Modify query" feature to Special:CargoQuery [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/534830 [15:33:52] (03CR) 10Krinkle: "Debugging continues at https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/GlobalCssJs/+/534823/" [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534533 (https://phabricator.wikimedia.org/T231929) (owner: 10Krinkle) [15:36:24] (03Merged) 10jenkins-bot: Improve various PHP method doc blocks [core] - 10https://gerrit.wikimedia.org/r/534385 (owner: 10Daimona Eaytoy) [15:40:33] (03PS4) 10Mainframe98: [POC] Use ObjectFactory to create API modules [core] - 10https://gerrit.wikimedia.org/r/534788 (https://phabricator.wikimedia.org/T222388) [15:41:48] (03CR) 10Mholloway: [C: 03+1] "I'm inclined to +2 as-is just to kickstart getting this cleaned up, unless you feel strongly about splitting it up, Volker." [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/534700 (owner: 10Eric Gardner) [15:46:13] (03PS1) 10Krinkle: Switch plain PHPUnit TestCase to MediaWikiIntegrationTestCase [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534834 [15:46:22] (03Abandoned) 10Krinkle: WIP: Debug ConfigFactory problem in CI [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534823 (owner: 10Krinkle) [15:46:26] (03CR) 10jenkins-bot: Unit tests: Whitelist global so LoggerFactory doesn't explode [core] - 10https://gerrit.wikimedia.org/r/534774 (https://phabricator.wikimedia.org/T87781) (owner: 10Kosta Harlan) [15:46:45] (03CR) 10jerkins-bot: [V: 04-1] Switch plain PHPUnit TestCase to MediaWikiIntegrationTestCase [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534834 (owner: 10Krinkle) [15:48:58] (03CR) 10Mainframe98: [POC] Use ObjectFactory to create API modules (036 comments) [core] - 10https://gerrit.wikimedia.org/r/534788 (https://phabricator.wikimedia.org/T222388) (owner: 10Mainframe98) [15:49:12] (03PS1) 10Krinkle: Update jquery.accessKeyLabel -> mediawiki.util [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/534835 (https://phabricator.wikimedia.org/T218339) [15:49:19] (03CR) 10Hashar: [C: 04-2] "Looks good :] I will check all extensions/skins currently defining a requirement in their registration file and ensure CI currently injec" [core] - 10https://gerrit.wikimedia.org/r/534641 (https://phabricator.wikimedia.org/T225512) (owner: 10Anomie) [15:49:45] 10ContentTranslation, 10Language-Team (Language-2019-July-September): 500 error while translating table - https://phabricator.wikimedia.org/T232219 (10Jpita) [15:50:20] 10MediaWiki-History-and-Diffs, 10wikidiff2: Empty reversed diffs - https://phabricator.wikimedia.org/T63306 (10Aklapper) [15:50:24] (03CR) 10jerkins-bot: [V: 04-1] Switch plain PHPUnit TestCase to MediaWikiIntegrationTestCase [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534834 (owner: 10Krinkle) [15:51:26] 10MediaWiki-Revision-backend: Allow 'naming' of a single revision to add a subtitle / annotate - https://phabricator.wikimedia.org/T52985 (10Aklapper) [15:52:14] 10MediaWiki-Revision-backend, 10Wikimedia-database-error: Over-reliance on timestamps can lead to incorrect counts - https://phabricator.wikimedia.org/T61609 (10Aklapper) [15:53:58] 10MediaWiki-Comment-backend: Link to old name in edit summary of page move should have redirect=no - https://phabricator.wikimedia.org/T12710 (10Aklapper) [15:54:00] 10MediaWiki-Comment-backend, 10MediaWiki-Page-editing: Provide a default edit summary when restoring an old revision of page - https://phabricator.wikimedia.org/T6765 (10Aklapper) [15:54:03] 10MediaWiki-Comment-backend, 10MediaWiki-Parser, 10Patch-For-Review: Linkify plain external links in revision editsummary and log reason - https://phabricator.wikimedia.org/T16892 (10Aklapper) [15:54:23] (03PS2) 10Krinkle: Switch plain PHPUnit TestCase to MediaWikiIntegrationTestCase [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534834 [15:54:32] (03PS3) 10Krinkle: Hooks: Restructure onBeforePageDisplay() to avoid early return [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534532 (https://phabricator.wikimedia.org/T231929) [15:54:35] (03PS4) 10Krinkle: Hooks: Only register/load ext.globalCssJs.site for UseGlobalSiteCssJs [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534533 (https://phabricator.wikimedia.org/T231929) [15:58:10] (03PS5) 10Mainframe98: [POC] Use ObjectFactory to create API modules [core] - 10https://gerrit.wikimedia.org/r/534788 (https://phabricator.wikimedia.org/T222388) [16:00:01] (03CR) 10VolkerE: "No, it's more a question if you feel comfortable packing it into one and a bit cleaner commit history, but that's philosophical." [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/534700 (owner: 10Eric Gardner) [16:00:06] 10MediaWiki-extensions-UrlShortener, 10Security-Team, 10Wikimedia-Site-requests: Add *.wmflabs.org to w.wiki shortener - https://phabricator.wikimedia.org/T231518 (10Vojtech.dostal) I would love if we could use a URL shortener for Wmflabs [16:03:15] (03CR) 10Jforrester: "Don't you need to update tests/qunit/QUnitTestResources.php to use the new file name and tests/qunit/suites/resources/jquery/jquery.access" [core] - 10https://gerrit.wikimedia.org/r/534829 (https://phabricator.wikimedia.org/T218339) (owner: 10Krinkle) [16:06:59] (03PS1) 10Pcoombe: Add fundraising messages for Japan [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/534838 (https://phabricator.wikimedia.org/T231839) [16:07:10] (03CR) 10jenkins-bot: Improve various PHP method doc blocks [core] - 10https://gerrit.wikimedia.org/r/534385 (owner: 10Daimona Eaytoy) [16:09:57] (03CR) 10VolkerE: "I'd be deliberate and forgo with Bartosz proposal to include complete PHP uppercase mapping…" [core] - 10https://gerrit.wikimedia.org/r/507793 (owner: 10Esanders) [16:14:33] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Proposal: Provide a single-module registration mechanism for skin modules in ResourceLoader - https://phabricator.wikimedia.org/T232148 (10Isarra) > @Isarra That's an interesting idea. Roan had the same idea a few weeks back. Unfortunately, that's not compati... [16:15:16] (03CR) 10Anomie: LocalFile: avoid hard failures on non-existing files. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/533482 (https://phabricator.wikimedia.org/T221812) (owner: 10Daniel Kinzler) [16:15:21] 10OWC2020: Define objectives and key result(s) for project - https://phabricator.wikimedia.org/T232221 (10ppelberg) [16:15:44] 10OWC2020: Define objectives and key result(s) for project - https://phabricator.wikimedia.org/T232221 (10ppelberg) [16:22:26] (03PS3) 10VolkerE: Remove unneeded CSS for thanks toast link [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/534712 (https://phabricator.wikimedia.org/T232102) (owner: 10Ammarpad) [16:22:47] (03PS4) 10Jforrester: Deprecate mediawiki.RegExp; move only function to mw.util [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) [16:22:51] (03CR) 10Ppchelko: LocalFile: avoid hard failures on non-existing files. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533482 (https://phabricator.wikimedia.org/T221812) (owner: 10Daniel Kinzler) [16:23:28] (03PS4) 10VolkerE: Remove unneeded CSS for thanks toast link [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/534712 (https://phabricator.wikimedia.org/T232102) (owner: 10Ammarpad) [16:25:38] (03CR) 10Anomie: [C: 03+2] Update to version 1.0.0 [php/excimer] - 10https://gerrit.wikimedia.org/r/534737 (owner: 10Tim Starling) [16:27:13] (03Merged) 10jenkins-bot: Update to version 1.0.0 [php/excimer] - 10https://gerrit.wikimedia.org/r/534737 (owner: 10Tim Starling) [16:27:17] (03PS1) 10Yaron Koren: Small fixes and improvements to Special:CargoQuery [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/534840 [16:29:06] 10Advanced Mobile Contributions, 10MinervaNeue, 10MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), 10Mobile, and 3 others: Replace 24x24px SVGs in MF/Minerva - https://phabricator.wikimedia.org/T231613 (10alexhollender) [16:29:53] (03CR) 10jerkins-bot: [V: 04-1] Switch plain PHPUnit TestCase to MediaWikiIntegrationTestCase [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534834 (owner: 10Krinkle) [16:30:56] (03PS1) 10Daimona Eaytoy: Allow dangling commas in variargs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/534842 (https://phabricator.wikimedia.org/T153251) [16:31:28] (03CR) 10Daniel Kinzler: [POC] Use ObjectFactory to create API modules (031 comment) [core] - 10https://gerrit.wikimedia.org/r/534788 (https://phabricator.wikimedia.org/T222388) (owner: 10Mainframe98) [16:31:56] (03CR) 10jerkins-bot: [V: 04-1] Hooks: Restructure onBeforePageDisplay() to avoid early return [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534532 (https://phabricator.wikimedia.org/T231929) (owner: 10Krinkle) [16:32:53] (03CR) 10Jforrester: [C: 03+2] docs: Remove GENERATE_MAN support from Doxyfile [core] - 10https://gerrit.wikimedia.org/r/534822 (https://phabricator.wikimedia.org/T232104) (owner: 10Krinkle) [16:34:08] (03PS2) 10Yaron Koren: Small fixes and improvements to Special:CargoQuery [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/534840 [16:34:20] 10DC-Ops, 10SRE-tools, 10Patch-For-Review: Host decommission improvements - https://phabricator.wikimedia.org/T231066 (10Volans) @wiki_willy the related patch above should already help a lot, but as you know I'm off those days and I cannot give it the necessary testing for merging it, but if anyone else want... [16:35:56] (03CR) 10jerkins-bot: [V: 04-1] Hooks: Only register/load ext.globalCssJs.site for UseGlobalSiteCssJs [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534533 (https://phabricator.wikimedia.org/T231929) (owner: 10Krinkle) [16:36:02] (03CR) 10Mholloway: "Since it sounds like a missing inbound X-Client-IP indicates a bug upstream, it would be good to log when an inbound request is missing X-" [services/kartotherian] - 10https://gerrit.wikimedia.org/r/534235 (https://phabricator.wikimedia.org/T200594) (owner: 10MSantos) [16:38:24] (03PS1) 10Jack Phoenix: Pass the existing $conf object to the 'ResourceLoaderGetConfigVars' hook [core] - 10https://gerrit.wikimedia.org/r/534843 [16:39:27] (03CR) 10Jforrester: mediawiki.util: Move to its own resources/src/ directory (031 comment) [core] - 10https://gerrit.wikimedia.org/r/534713 (owner: 10Krinkle) [16:39:50] (03PS2) 10Krinkle: mediawiki.util: Merge 'jquery.accessKeyLabel' into this module [core] - 10https://gerrit.wikimedia.org/r/534829 (https://phabricator.wikimedia.org/T218339) [16:41:04] (03CR) 10Krinkle: "Thanks, I've removed the loading of the deprecated alias there." [core] - 10https://gerrit.wikimedia.org/r/534829 (https://phabricator.wikimedia.org/T218339) (owner: 10Krinkle) [16:41:49] (03CR) 10Jforrester: [C: 03+2] "Thanks." [core] - 10https://gerrit.wikimedia.org/r/534829 (https://phabricator.wikimedia.org/T218339) (owner: 10Krinkle) [16:42:08] (03CR) 10jerkins-bot: [V: 04-1] Deprecate mediawiki.RegExp; move only function to mw.util [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) (owner: 10Jforrester) [16:43:19] (03PS1) 10Daniel Kinzler: SpecialRunJobs: optional output stats, including queue size [core] - 10https://gerrit.wikimedia.org/r/534844 (https://phabricator.wikimedia.org/T231822) [16:43:35] 10CPT Initiatives (API Integration Tests), 10Core Platform Team Workboards (Purple), 10Patch-For-Review: API integration tests need a way to flush the job queue. - https://phabricator.wikimedia.org/T231822 (10daniel) a:03daniel [16:43:43] 10Readers-Web-Backlog: Replace user icon in Minerva/MF - https://phabricator.wikimedia.org/T232223 (10alexhollender) [16:43:52] (03CR) 10jerkins-bot: [V: 04-1] Hooks: Restructure onBeforePageDisplay() to avoid early return [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534532 (https://phabricator.wikimedia.org/T231929) (owner: 10Krinkle) [16:43:57] 10Readers-Web-Backlog: Replace alternate user icon in Minerva/MF - https://phabricator.wikimedia.org/T232223 (10alexhollender) [16:44:10] (03CR) 10jerkins-bot: [V: 04-1] Switch plain PHPUnit TestCase to MediaWikiIntegrationTestCase [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534834 (owner: 10Krinkle) [16:44:21] (03CR) 10Yaron Koren: [C: 03+2] Small fixes and improvements to Special:CargoQuery [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/534840 (owner: 10Yaron Koren) [16:44:45] 10Readers-Web-Backlog: Replace alternate user icon in Minerva/MF - https://phabricator.wikimedia.org/T232223 (10alexhollender) I don't think this needs to be done in conjunction with the current icon work. [16:45:08] 10Readers-Web-Backlog: Replace alternate user icon in Minerva/MF - https://phabricator.wikimedia.org/T232223 (10alexhollender) [16:48:32] (03CR) 10Anomie: SpecialRunJobs: optional output stats, including queue size (031 comment) [core] - 10https://gerrit.wikimedia.org/r/534844 (https://phabricator.wikimedia.org/T231822) (owner: 10Daniel Kinzler) [16:50:16] (03PS5) 10Daniel Kinzler: Trigger jobs when needed [tools/api-testing] - 10https://gerrit.wikimedia.org/r/530642 (https://phabricator.wikimedia.org/T231822) [16:51:28] (03CR) 10Daniel Kinzler: Add Reparse dependent pages test (031 comment) [tools/api-testing] - 10https://gerrit.wikimedia.org/r/534530 (owner: 10Clarakosi) [16:51:40] (03PS6) 10Daniel Kinzler: Trigger jobs when needed [tools/api-testing] - 10https://gerrit.wikimedia.org/r/530642 (https://phabricator.wikimedia.org/T231822) [16:52:30] 10MediaWiki-REST-API, 10CPT Initiatives (Parsoid REST API in PHP (CDP2)): REST API Router - https://phabricator.wikimedia.org/T219959 (10Anomie) [16:52:32] 10MediaWiki-REST-API, 10CPT Initiatives (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Workboards (Green), 10MW-1.34-notes (1.34.0-wmf.22; 2019-09-10), 10Patch-For-Review: REST API Parameter Validation - https://phabricator.wikimedia.org/T223239 (10Anomie) 05Open→03Resolved I think this task... [16:55:02] (03CR) 10Anomie: [C: 03+1] "Seems sane. I don't have a dev environment set up to test it at the moment. Ping me if review on this becomes urgent." [php/excimer] - 10https://gerrit.wikimedia.org/r/530242 (owner: 10Tim Starling) [16:55:14] (03CR) 10Raimond Spekking: [C: 03+1] "i18n review" [extensions/BlueSpiceInsertCategory] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534792 (owner: 10Dvogel hallowelt) [16:55:41] 10Structured Data Engineering, 10Structured-Data-Backlog, 10UploadWizard, 10SDC-Statements (Campaigns-jogging): Incorrect suggested statements appearing for a campaign - https://phabricator.wikimedia.org/T232101 (10Ramsey-WMF) p:05Triage→03Normal Confirmed. But this is weird because I'm pretty sure I t... [16:56:13] (03CR) 10Raimond Spekking: [C: 03+1] "i18n review" [extensions/BlueSpiceExtendedSearch] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/534800 (owner: 10Dvogel hallowelt) [16:56:32] 10MediaWiki-API, 10Core Platform Team, 10Documentation, 10good first bug: API: Purpose of "batchcomplete" property and implementation - https://phabricator.wikimedia.org/T84977 (10Dalba) [16:57:14] (03CR) 10Anomie: [C: 03+2] Stop mangling $_GET and provide WebRequest::getQueryValuesOnly() [core] - 10https://gerrit.wikimedia.org/r/533982 (owner: 10Tim Starling) [16:59:49] (03CR) 10Anomie: "This wasn't merged by Jenkins because its dependencies weren't merged yet. I just merged Ic469577f so this is no longer broken by trying t" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/534425 (owner: 10Tim Starling) [16:59:55] (03PS1) 10DCausse: [WIP] Convert to unit tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/534845 [17:00:16] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Convert to unit tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/534845 (owner: 10DCausse) [17:00:32] (03CR) 10jerkins-bot: [V: 04-1] Hooks: Only register/load ext.globalCssJs.site for UseGlobalSiteCssJs [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534533 (https://phabricator.wikimedia.org/T231929) (owner: 10Krinkle) [17:00:35] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Convert to unit tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/534845 (owner: 10DCausse) [17:00:43] (03CR) 10jerkins-bot: [V: 04-1] Deprecate mediawiki.RegExp; move only function to mw.util [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) (owner: 10Jforrester) [17:01:50] 10Structured Data Engineering, 10Structured-Data-Backlog, 10UploadWizard, 10SDC-Statements (Campaigns-jogging): Incorrect suggested statements appearing for a campaign - https://phabricator.wikimedia.org/T232101 (10Cparle) Yeah, same here - it's been introduced recently [17:02:02] (03CR) 10Anomie: [C: 03+2] "No second opinions forthcoming, so I'll just +2 this in time for 1.34." [core] - 10https://gerrit.wikimedia.org/r/523975 (https://phabricator.wikimedia.org/T217855) (owner: 10星耀晨曦) [17:02:04] (03CR) 10jerkins-bot: [V: 04-1] Deprecate mediawiki.RegExp; move only function to mw.util [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) (owner: 10Jforrester) [17:04:41] 10MediaWiki-Special-pages, 10MediaWiki-User-management, 10Office-IT, 10Wikimedia-Site-requests, 10User-Urbanecm: Uncheck "Automatically block the last IP address" by default on Special:Block on officewiki - https://phabricator.wikimedia.org/T231943 (10DannyS712) >>! In T231943#5471685, @eliza wrote: > Wh... [17:05:26] (03Merged) 10jenkins-bot: docs: Remove GENERATE_MAN support from Doxyfile [core] - 10https://gerrit.wikimedia.org/r/534822 (https://phabricator.wikimedia.org/T232104) (owner: 10Krinkle) [17:08:10] (03Merged) 10jenkins-bot: mediawiki.util: Merge 'jquery.accessKeyLabel' into this module [core] - 10https://gerrit.wikimedia.org/r/534829 (https://phabricator.wikimedia.org/T218339) (owner: 10Krinkle) [17:08:12] (03Merged) 10jenkins-bot: Small fixes and improvements to Special:CargoQuery [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/534840 (owner: 10Yaron Koren) [17:08:52] (03PS2) 10Yaron Koren: Add "Modify query" feature to Special:CargoQuery [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/534830 [17:08:58] (03CR) 10jerkins-bot: [V: 04-1] Add "Modify query" feature to Special:CargoQuery [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/534830 (owner: 10Yaron Koren) [17:09:00] (03CR) 10jerkins-bot: [V: 04-1] Add "Modify query" feature to Special:CargoQuery [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/534830 (owner: 10Yaron Koren) [17:09:41] (03CR) 10Ottomata: "A reason it will be nice to have in jsonschema-tools, is because jsonschema-tools already knows about a bunch of the configs you are hardc" [event-schemas] - 10https://gerrit.wikimedia.org/r/534702 (https://phabricator.wikimedia.org/T206814) (owner: 10Ppchelko) [17:10:36] (03Abandoned) 10Yaron Koren: Add "Modify query" feature to Special:CargoQuery [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/534830 (owner: 10Yaron Koren) [17:10:39] 10MediaWiki-Installer, 10MediaWiki-Releasing, 10MW-1.34-release: Bundle TextExtracts with MediaWiki - https://phabricator.wikimedia.org/T229127 (10Jdforrester-WMF) [17:11:55] 10CommRel-Specialists-Support: CL support for adding wiki-specific CSS for styling citations output in Parsoid HTML - https://phabricator.wikimedia.org/T166895 (10ssastry) 05Open→03Stalled We have to resolve what direction we want to go with this. This will get clearer as we start the parser integration proc... [17:14:48] (03CR) 10jenkins-bot: mediawiki.util: Merge 'jquery.accessKeyLabel' into this module [core] - 10https://gerrit.wikimedia.org/r/534829 (https://phabricator.wikimedia.org/T218339) (owner: 10Krinkle) [17:14:50] (03CR) 10jerkins-bot: [V: 04-1] Deprecate mediawiki.RegExp; move only function to mw.util [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) (owner: 10Jforrester) [17:15:54] (03PS5) 10Jforrester: Deprecate mediawiki.RegExp; move only function to mw.util [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) [17:16:20] (03CR) 10Jforrester: [C: 03+2] docs: Factor out MWDoxygenFilter from mwdoc-filter.php with tests [core] - 10https://gerrit.wikimedia.org/r/534643 (https://phabricator.wikimedia.org/T232104) (owner: 10Krinkle) [17:16:46] (03CR) 10Jforrester: [C: 03+2] Update jquery.accessKeyLabel -> mediawiki.util [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/534835 (https://phabricator.wikimedia.org/T218339) (owner: 10Krinkle) [17:18:33] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Proposal: Provide a single-module registration mechanism for skin modules in ResourceLoader - https://phabricator.wikimedia.org/T232148 (10Krinkle) I'm sorry that my comment discouraged you, this was not my intention. The emphasis and tone of words are someti... [17:20:48] (03CR) 10Krinkle: [C: 03+1] Deprecate mediawiki.RegExp; move only function to mw.util (031 comment) [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) (owner: 10Jforrester) [17:23:09] (03CR) 10Anomie: [POC] Use ObjectFactory to create API modules (031 comment) [core] - 10https://gerrit.wikimedia.org/r/534788 (https://phabricator.wikimedia.org/T222388) (owner: 10Mainframe98) [17:23:46] (03CR) 10Anomie: [POC] Use ObjectFactory to create API modules (031 comment) [core] - 10https://gerrit.wikimedia.org/r/534788 (https://phabricator.wikimedia.org/T222388) (owner: 10Mainframe98) [17:26:09] (03PS6) 10Jforrester: Deprecate mediawiki.RegExp; move only function to mw.util [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) [17:26:38] (03CR) 10Jforrester: Deprecate mediawiki.RegExp; move only function to mw.util (031 comment) [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) (owner: 10Jforrester) [17:27:24] (03CR) 10Krinkle: "Will we allow multiple consecutive comma's? Would be good to test for either way (to fail or to be tolerated)." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/534842 (https://phabricator.wikimedia.org/T153251) (owner: 10Daimona Eaytoy) [17:28:12] (03CR) 10Jforrester: [C: 04-1] Deprecate mediawiki.RegExp; move only function to mw.util (031 comment) [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) (owner: 10Jforrester) [17:28:50] (03CR) 10Krinkle: Deprecate mediawiki.RegExp; move only function to mw.util (031 comment) [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) (owner: 10Jforrester) [17:29:10] (03PS7) 10Krinkle: Deprecate mediawiki.RegExp; move only function to mw.util [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) (owner: 10Jforrester) [17:30:09] (03CR) 10Jforrester: Deprecate mediawiki.RegExp; move only function to mw.util (031 comment) [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) (owner: 10Jforrester) [17:30:28] (03CR) 10Krinkle: [C: 04-1] Deprecate mediawiki.RegExp; move only function to mw.util (031 comment) [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) (owner: 10Jforrester) [17:30:42] (03CR) 10Daimona Eaytoy: [C: 04-1] "> Will we allow multiple consecutive comma's? Would be good to test" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/534842 (https://phabricator.wikimedia.org/T153251) (owner: 10Daimona Eaytoy) [17:31:31] (03PS1) 10Dbarratt: Allow users to be hidden from lists, without being blocked [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/534849 (https://phabricator.wikimedia.org/T228950) [17:33:20] (03PS8) 10Jforrester: Deprecate mediawiki.RegExp; move only function to mw.util [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) [17:33:37] 10MediaWiki-API, 10Core Platform Team, 10Documentation, 10good first bug: API: Purpose of "batchcomplete" property and implementation - https://phabricator.wikimedia.org/T84977 (10Dalba) https://www.mediawiki.org/wiki/API:Query#Example_5:_Batchcomplete mentions https://en.wikipedia.org/w/api.php?action=que... [17:34:14] 10Design, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review: Consider removing toolbar borders - https://phabricator.wikimedia.org/T231815 (10iamjessklein) What would it look like if we: 1. remove the chevron's completely from the type dropdown? 2. replace the VE/Wikitext dropdown ic... [17:35:15] 10MediaWiki-API, 10Core Platform Team Workboards (Clinic Duty Team), 10Documentation, 10good first bug: API: Purpose of "batchcomplete" property and implementation - https://phabricator.wikimedia.org/T84977 (10Anomie) [17:36:15] (03PS6) 10Mainframe98: [POC] Use ObjectFactory to create API modules [core] - 10https://gerrit.wikimedia.org/r/534788 (https://phabricator.wikimedia.org/T222388) [17:36:21] (03CR) 10jenkins-bot: Small fixes and improvements to Special:CargoQuery [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/534840 (owner: 10Yaron Koren) [17:36:24] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar): [EPIC] Suggested edits V3 - https://phabricator.wikimedia.org/T228845 (10schoenbaechler) [17:38:31] (03Merged) 10jenkins-bot: Stop mangling $_GET and provide WebRequest::getQueryValuesOnly() [core] - 10https://gerrit.wikimedia.org/r/533982 (owner: 10Tim Starling) [17:38:41] (03Merged) 10jenkins-bot: Fix installation failure due to unexpected dbpath under CLI installation [core] - 10https://gerrit.wikimedia.org/r/523975 (https://phabricator.wikimedia.org/T217855) (owner: 10星耀晨曦) [17:39:28] 10MediaWiki-API, 10MediaWiki-ServiceContainer, 10MediaWiki-Special-pages, 10TechCom, and 4 others: Create a mechanism for SpecialPages and API modules to have dependencies injected into them - https://phabricator.wikimedia.org/T222388 (10dbarratt) @Mainframe98 would you mind updating the task description?... [17:40:06] 10MediaWiki-Installer, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-release, 10Patch-For-Review: Default dbpath for install.php (dbtype sqlite) no longer works. (Writes to root of disk) - https://phabricator.wikimedia.org/T217855 (10Jdforrester-WMF) 05Open→03Resolved [17:40:16] (03PS3) 10Jdlrobson: Remove "large" icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/534607 (https://phabricator.wikimedia.org/T231683) (owner: 10Jdrewniak) [17:40:19] (03CR) 10Jdlrobson: [C: 03+2] Remove "large" icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/534607 (https://phabricator.wikimedia.org/T231683) (owner: 10Jdrewniak) [17:42:29] (03CR) 10VolkerE: [C: 03+2] "Thanks Ammarpad. PS 3 only removes obsolete packages, now that there are no CSS/LESS files any more and therefore resolves CI error of try" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/534712 (https://phabricator.wikimedia.org/T232102) (owner: 10Ammarpad) [17:42:53] (03CR) 10Clarakosi: [V: 04-1 C: 04-1] "Minor spelling errors and one question below." (034 comments) [tools/api-testing] - 10https://gerrit.wikimedia.org/r/530642 (https://phabricator.wikimedia.org/T231822) (owner: 10Daniel Kinzler) [17:43:16] (03PS3) 10Krinkle: Switch plain PHPUnit TestCase to MediaWikiIntegrationTestCase [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534834 [17:43:20] (03PS4) 10Krinkle: Hooks: Restructure onBeforePageDisplay() to avoid early return [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534532 (https://phabricator.wikimedia.org/T231929) [17:43:23] (03PS5) 10Krinkle: Hooks: Only register/load ext.globalCssJs.site for UseGlobalSiteCssJs [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534533 (https://phabricator.wikimedia.org/T231929) [17:44:20] (03CR) 10jerkins-bot: [V: 04-1] Deprecate mediawiki.RegExp; move only function to mw.util [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) (owner: 10Jforrester) [17:49:19] (03CR) 10jerkins-bot: [V: 04-1] Deprecate mediawiki.RegExp; move only function to mw.util [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) (owner: 10Jforrester) [17:49:23] (03CR) 10jenkins-bot: docs: Remove GENERATE_MAN support from Doxyfile [core] - 10https://gerrit.wikimedia.org/r/534822 (https://phabricator.wikimedia.org/T232104) (owner: 10Krinkle) [17:51:54] (03PS8) 10Mholloway: Add linters and apply automated fixes to JS and LESS files [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/534700 (owner: 10Eric Gardner) [17:52:51] (03CR) 10Krinkle: "Warning: /src/maintenance/jsduck/categories.json No class found matching a pattern 'mw.RegExp' in categories file" [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) (owner: 10Jforrester) [17:54:30] 10MediaWiki-Internationalization, 10Core Platform Team, 10Language-Team, 10Performance-Team, and 3 others: Use disk-based LCStore by default in MediaWiki 1.34 - https://phabricator.wikimedia.org/T218207 (10WDoranWMF) [17:55:19] (03CR) 10Mholloway: "I picked this up and made a couple of minor fixes since Eric is out today." [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/534700 (owner: 10Eric Gardner) [17:55:23] 10MediaWiki-Internationalization, 10Core Platform Team, 10Language-Team, 10Performance-Team, and 3 others: Use disk-based LCStore by default in MediaWiki 1.34 - https://phabricator.wikimedia.org/T218207 (10WDoranWMF) p:05Normal→03High I'm moving the priority up a little for the PMs to make a decision,... [17:57:48] (03PS4) 10Jdlrobson: Remove "large" icons [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/534607 (https://phabricator.wikimedia.org/T231683) (owner: 10Jdrewniak) [17:57:50] (03PS6) 10Jdlrobson: Update MobileFrontend icons to WikimediaUI theme equivalents [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/534529 (https://phabricator.wikimedia.org/T231613) [17:58:42] (03CR) 10jerkins-bot: [V: 04-1] Switch plain PHPUnit TestCase to MediaWikiIntegrationTestCase [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534834 (owner: 10Krinkle) [17:59:32] (03CR) 10VolkerE: [C: 03+1] Add linters and apply automated fixes to JS and LESS files [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/534700 (owner: 10Eric Gardner) [17:59:34] (03CR) 10jerkins-bot: [V: 04-1] Hooks: Restructure onBeforePageDisplay() to avoid early return [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534532 (https://phabricator.wikimedia.org/T231929) (owner: 10Krinkle) [18:00:20] (03CR) 10jerkins-bot: [V: 04-1] Switch plain PHPUnit TestCase to MediaWikiIntegrationTestCase [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534834 (owner: 10Krinkle) [18:00:27] (03CR) 10jerkins-bot: [V: 04-1] Hooks: Restructure onBeforePageDisplay() to avoid early return [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534532 (https://phabricator.wikimedia.org/T231929) (owner: 10Krinkle) [18:00:29] (03CR) 10jerkins-bot: [V: 04-1] Hooks: Only register/load ext.globalCssJs.site for UseGlobalSiteCssJs [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534533 (https://phabricator.wikimedia.org/T231929) (owner: 10Krinkle) [18:01:05] 10MediaWiki-API, 10Core Platform Team Workboards (Clinic Duty Team), 10Documentation, 10good first bug: API: Purpose of "batchcomplete" property and implementation - https://phabricator.wikimedia.org/T84977 (10Anomie) >>! In T84977#5058817, @Krinkle wrote: > But it still seems confusing to me on write-requ... [18:01:08] (03PS9) 10Jforrester: Deprecate mediawiki.RegExp; move only function to mw.util [core] - 10https://gerrit.wikimedia.org/r/534695 (https://phabricator.wikimedia.org/T218339) [18:01:32] (03PS4) 10Krinkle: Switch plain PHPUnit TestCase to MediaWikiIntegrationTestCase [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/534834 [18:03:36] (03PS10) 10Jdlrobson: Remove all the icon hacks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533111 (https://phabricator.wikimedia.org/T229440) [18:04:34] (03CR) 10jenkins-bot: mediawiki.util: Merge 'jquery.accessKeyLabel' into this module [core] - 10https://gerrit.wikimedia.org/r/534829 (https://phabricator.wikimedia.org/T218339) (owner: 10Krinkle) [18:05:45] (03Merged) 10jenkins-bot: docs: Factor out MWDoxygenFilter from mwdoc-filter.php with tests [core] - 10https://gerrit.wikimedia.org/r/534643 (https://phabricator.wikimedia.org/T232104) (owner: 10Krinkle) [18:06:01] (03Merged) 10jenkins-bot: docs: Fix Doxygen parsing of @var descriptions with $var names [core] - 10https://gerrit.wikimedia.org/r/534649 (owner: 10Krinkle) [18:06:03] (03Merged) 10jenkins-bot: Update jquery.accessKeyLabel -> mediawiki.util [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/534835 (https://phabricator.wikimedia.org/T218339) (owner: 10Krinkle) [18:06:05] (03PS11) 10Jdlrobson: Remove all the icon hacks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533111 (https://phabricator.wikimedia.org/T229440) [18:06:46] (03CR) 10Ammarpad: "> Thanks Ammarpad. PS 3 only removes obsolete packages, now that" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/534712 (https://phabricator.wikimedia.org/T232102) (owner: 10Ammarpad) [18:06:53] (03CR) 10Jack Phoenix: [C: 03+2] "I'm still not 100% sure if this is all that's needed, but based on testing, this certainly fixes stuff under MW 1.33+ and doesn't break an" [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/526506 (owner: 10Paladox) [18:07:22] 10WMEE: Veebisaidi kujundusmoodulite valiku otsustamine - https://phabricator.wikimedia.org/T232130 (10tramm) Püüdsin uuendada [Accesspress](https://accesspressthemes.com/) 3.1 peale, aga selle peale läks suurem osa saidil olevat funktsionaalsust mingist otsast katki. Võtsin 3.1 töötava "Revolution Slideri" ja j... [18:08:27] (03PS19) 10Jdlrobson: Remove the mw-ui-icon hacks and overrides [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531558 (https://phabricator.wikimedia.org/T229440) [18:09:19] (03CR) 10Clarakosi: [C: 04-1] "Oh nvm. It's failing because it depends on Ibb38490afc" [tools/api-testing] - 10https://gerrit.wikimedia.org/r/530642 (https://phabricator.wikimedia.org/T231822) (owner: 10Daniel Kinzler)