[00:00:25] 10Internet-Archive, 10Wikimedia-Site-requests: Server side upload request for Yann - https://phabricator.wikimedia.org/T231737 (10Urbanecm) [00:00:47] 10MediaWiki-General, 10MediaWiki-Parser, 10Core Platform Team, 10User-DannyS712: Magic word to suppress breadcrumb links in subpages - https://phabricator.wikimedia.org/T231692 (10Aklapper) Sounds also related to {T24289} [00:00:51] (03PS1) 10SLF bot: Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/533726 [00:03:11] 10Phabricator, 10Documentation: Document workboard column triggers - https://phabricator.wikimedia.org/T227300 (10epriestley) > if you use the 'move on workboard' option it does nothing. That is what I missed. Is that the intended behaviour? For now, it's expected, yes. I'm potentially open to changing it, bu... [00:08:06] 10MediaWiki-Maintenance-scripts: importImages.php has typo in error message - https://phabricator.wikimedia.org/T231739 (10Urbanecm) [00:08:23] 10MediaWiki-Maintenance-scripts: importImages.php has typo in error message - https://phabricator.wikimedia.org/T231739 (10Urbanecm) 05Open→03Invalid My terminal issue, sorry... [00:11:28] 10Phabricator: Phabricator: Simplify the multifactor auth reset procedure - https://phabricator.wikimedia.org/T231667 (10Urbanecm) >>! In T231667#5455918, @Tgr wrote: > (Using Phabricator OAuth for logging into other systems complicates things a bit, but it's only supposed to be temporary.) [offtopic] Why and w... [00:11:37] 10Wikimedia Australia: Clarification of regions of Western Australia maps for identification of regions for scope of usage by Wiki Club West - https://phabricator.wikimedia.org/T231410 (10Aklapper) @JarrahTree: Assuming this task is about #Wikimedia_Australia, hence adding project tag so others can find this tas... [00:12:14] 10Wikimedia Australia: Perth localities and contexts - before events and after the fact for articles - Wiki Club West context - https://phabricator.wikimedia.org/T231415 (10Aklapper) @JarrahTree: Assuming this task is about #Wikimedia_Australia, hence adding project tag so others can find this task when searchin... [00:12:26] 10Wikimedia Australia: Wiki Club West and other Wiki Clubs in Australia context and locations of activity within domain of Wikimedia Australia - https://phabricator.wikimedia.org/T231414 (10Aklapper) @JarrahTree: Assuming this task is about #Wikimedia_Australia, hence adding project tag so others can find this... [00:18:54] (03CR) 10jenkins-bot: Fix method/function names case mismatch in core files [core] - 10https://gerrit.wikimedia.org/r/533712 (owner: 10D3r1ck01) [00:21:25] 04(no projects): Package OGVKit for CocoaPods (iOS Ogg Vorbis/Theora playback library) - https://phabricator.wikimedia.org/T91689 (10Aklapper) @LGoTo, @brion: Can you please associate at least one active [[ https://phabricator.wikimedia.org/project/query/G9vp6zKs.IfE/#R | project ]] with this task (via the {nav... [00:25:12] (03CR) 10Brian Wolff: [C: 04-1] "This just changes the function name. It does not change it to the new hook type." [extensions/NoCat] - 10https://gerrit.wikimedia.org/r/487364 (https://phabricator.wikimedia.org/T203733) (owner: 10Zoranzoki21) [01:16:24] 10Phabricator: Merge the Phabricator Priority values "Low" and "Lowest" - https://phabricator.wikimedia.org/T228759 (10Aklapper) > I tried to explain above. If that's not sufficient, could you ask please? I don't see where (and don't understand what the exact question is). In general, we can have 0 ≤ x ≤ ∞ of di... [01:18:12] (03CR) 10Legoktm: [C: 04-1] "We want the user preference to be respected throughout the entire UI." [core] - 10https://gerrit.wikimedia.org/r/533238 (owner: 10Krinkle) [01:18:51] (03CR) 10Legoktm: [C: 03+2] Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/533726 (owner: 10SLF bot) [01:19:12] (03Abandoned) 10Legoktm: Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/532112 (owner: 10SLF bot) [01:20:34] 10MediaWiki-extensions-EducationProgram: Cleaning up after EducationProgram - https://phabricator.wikimedia.org/T200391 (10MaxBioHazard) @D3r1ck01 Will Educational Program namespaces be deleted in projects where EP was installed? For example, ruwiki, EP namespaces still exist (but its localization already gone). [01:23:56] (03Merged) 10jenkins-bot: Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/533726 (owner: 10SLF bot) [01:25:52] (03CR) 10jenkins-bot: Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/533726 (owner: 10SLF bot) [02:12:45] 04(no projects): Page views - https://phabricator.wikimedia.org/T231741 (10Onceinawhile) [02:15:05] 04(no projects): Page views - https://phabricator.wikimedia.org/T231741 (10Peachey88) [02:16:03] 10MediaWiki-User-preferences: Turn off by default "Warn me when I leave an edit page with unsaved changes" option - https://phabricator.wikimedia.org/T231126 (10SerDIDG) This is bad idea, because notification appears not only on page leave but also on close tab or browser window. No one browser of 2019 saves the... [02:30:52] 10MediaWiki-User-preferences: Turn off by default "Warn me when I leave an edit page with unsaved changes" option - https://phabricator.wikimedia.org/T231126 (10MaxBioHazard) I checked last release versions of Chrome, Firefox, Opera, IE11, Edge and Android 6 default browser; all of it saves changes in text field... [02:43:49] 10MediaWiki-User-preferences: Turn off by default "Warn me when I leave an edit page with unsaved changes" option - https://phabricator.wikimedia.org/T231126 (10SerDIDG) > Wrong. Chrome saves changes in text fields content even on PC cold reset (electricity turning off). Nope, you must enable "continue where yo... [05:12:46] 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Clinic Duty Team), 10Multi-Content-Revisions (Tech Debt), 10Patch-For-Review: Create batch access interface for page content - https://phabricator.wikimedia.org/T228988 (10ArielGlenn) >>! In T228988#5453499, @daniel wrote: > Marking... [06:41:27] 10MediaWiki-extensions-EducationProgram: Document clear method for users to access historical data from the education extension - https://phabricator.wikimedia.org/T188407 (10Piotrus) Correct. I am not impressed by how this was handled. First my course pages were deleted, with no sufficient warning (no email /... [07:05:17] 10MediaWiki-extensions-EducationProgram: Document clear method for users to access historical data from the education extension - https://phabricator.wikimedia.org/T188407 (10Piotrus) PS. Actually, just today I was updating a syllabus for a class I will be teaching 2morrow and I noticed it contained a link to a... [07:25:44] 10MediaWiki-extensions-EducationProgram: Document clear method for users to access historical data from the education extension - https://phabricator.wikimedia.org/T188407 (10Piotrus) See red links for https://en.wikipedia.org/wiki/Wikipedia:School_and_university_projects/User:Piotrus/Educational_projects for br... [07:39:31] (03CR) 10simetrical: LanguageFactory to replace Language::factory() (034 comments) [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [07:40:52] (03CR) 10simetrical: "Since our convention is to keep these services in variables that are named after the service, I'm in favor of shorter names as well, in ge" [core] - 10https://gerrit.wikimedia.org/r/532232 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [07:55:17] 10WMEE: Poolaasta vahearuanne WMF-ile - https://phabricator.wikimedia.org/T225355 (10reosarevok) 05Open→03Resolved See sai juba ammu tagasi tehtud. [07:58:53] 10MediaWiki-Debug-Logger: $wgDebugConsole not showing SQL queries - https://phabricator.wikimedia.org/T231742 (10Bawolff) [08:03:52] 10wikimediafoundation.org: There should be a complete and up-to-date public staff list - https://phabricator.wikimedia.org/T231483 (10Nemo_bis) One difference between your excellent structured https://meta.wikimedia.org/wiki/Template:WMF_Staff and our old https://meta.wikimedia.org/wiki/Wikimedia_Foundation_staf... [08:11:35] (03CR) 10MaxSem: "Would "LanguageNames" be a better name for this class?" [core] - 10https://gerrit.wikimedia.org/r/532680 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [08:23:39] (03CR) 10simetrical: "> Patch Set 7:" [core] - 10https://gerrit.wikimedia.org/r/532680 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [08:32:41] (03PS8) 10simetrical: Make LocalisationCache a service [core] - 10https://gerrit.wikimedia.org/r/532679 (https://phabricator.wikimedia.org/T231220) [08:32:41] (03PS8) 10simetrical: Split some Language methods to LanguageNameUtils [core] - 10https://gerrit.wikimedia.org/r/532680 (https://phabricator.wikimedia.org/T201405) [08:32:41] (03PS16) 10simetrical: New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 (https://phabricator.wikimedia.org/T201405) [08:32:43] (03PS16) 10simetrical: Make grammar transform cache an instance member [core] - 10https://gerrit.wikimedia.org/r/532240 (https://phabricator.wikimedia.org/T201405) [08:32:45] (03PS35) 10simetrical: LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) [08:32:47] (03PS13) 10simetrical: Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 [08:32:49] (03PS8) 10simetrical: Cache nonexistence of grammar transformations [core] - 10https://gerrit.wikimedia.org/r/532241 [08:36:31] 10MediaWiki-ResourceLoader, 10Performance-Team, 10JavaScript: mw.config wgRevisionId return 0 with diffonly=1 - https://phabricator.wikimedia.org/T231744 (10A2093064) [08:39:11] (03CR) 10Daimona Eaytoy: "> I meant like this:" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/529917 (https://phabricator.wikimedia.org/T212082) (owner: 10Daimona Eaytoy) [08:40:27] (03CR) 10Daimona Eaytoy: [C: 03+2] Remove unneeded redeclaration of mPage in Article subclasses [core] - 10https://gerrit.wikimedia.org/r/519756 (owner: 10Umherirrender) [08:40:50] (03PS1) 10Brian Wolff: Better randomness for Special:RandomInCat and no more subcats [core] - 10https://gerrit.wikimedia.org/r/533728 (https://phabricator.wikimedia.org/T200703) [08:42:34] (03CR) 10Daimona Eaytoy: [C: 03+2] Unpack arrays on variadic arguments [core] - 10https://gerrit.wikimedia.org/r/519758 (owner: 10Umherirrender) [08:43:05] 10Wiki-Loves-Monuments-Sources, 10Wiki-Loves-Monuments (2018): Get Malaysia into the monuments database - https://phabricator.wikimedia.org/T173783 (10JeanFred) Harvest is running. The Unknown fields report is already available: https://commons.wikimedia.org/wiki/Commons:Monuments_database/Unknown_fields/monum... [08:43:12] (03CR) 10simetrical: Also set $wgContLang in MWITC::setContentLang() (032 comments) [core] - 10https://gerrit.wikimedia.org/r/533510 (https://phabricator.wikimedia.org/T231630) (owner: 10Lucas Werkmeister (WMDE)) [08:43:52] (03PS1) 10simetrical: Reset $wgContLang consistently for tests [core] - 10https://gerrit.wikimedia.org/r/533729 [08:44:15] (03CR) 10simetrical: "https://gerrit.wikimedia.org/r/c/mediawiki/core/+/533729" [core] - 10https://gerrit.wikimedia.org/r/533510 (https://phabricator.wikimedia.org/T231630) (owner: 10Lucas Werkmeister (WMDE)) [08:46:18] 10MediaWiki-Categories, 10Patch-For-Review: Special:RandomInCategory does not return all pages with equal probability - https://phabricator.wikimedia.org/T200703 (10Bawolff) >>! In T200703#5456947, @gerritbot wrote: > Change 533728 had a related patch set uploaded (by Brian Wolff; owner: Brian Wolff): > [media... [08:50:27] (03CR) 10simetrical: "> Patch Set 5:" [core] - 10https://gerrit.wikimedia.org/r/533067 (https://phabricator.wikimedia.org/T231419) (owner: 10Daimona Eaytoy) [08:53:31] 10MediaWiki-Core-Testing, 10Patch-For-Review: MediaWikiTestCaseTrait::creatNoOpMock should permit calling destructors - https://phabricator.wikimedia.org/T231656 (10Simetrical) Is this actually causing problems? MovePage did have it because __destruct would actually get called, but now it seems it doesn't. Why... [08:54:47] (03CR) 10simetrical: "I'm in favor if it's needed, but I'd be interested to know if it actually causes problems in practice." [core] - 10https://gerrit.wikimedia.org/r/533543 (https://phabricator.wikimedia.org/T231656) (owner: 10Mainframe98) [08:55:44] 10MediaWiki-Core-Testing, 10Patch-For-Review: MediaWikiTestCaseTrait::creatNoOpMock should permit calling destructors - https://phabricator.wikimedia.org/T231656 (10Mainframe98) I tried mocking the Language class, and all the tests that used `creatNoOpMock()` to mock Language failed until I added the exception... [09:00:18] (03CR) 10Daimona Eaytoy: "> Why wouldn't it impact CI? Does CI not make any use of opcode" [core] - 10https://gerrit.wikimedia.org/r/533067 (https://phabricator.wikimedia.org/T231419) (owner: 10Daimona Eaytoy) [09:00:26] (03CR) 10jerkins-bot: [V: 04-1] Cache nonexistence of grammar transformations [core] - 10https://gerrit.wikimedia.org/r/532241 (owner: 10simetrical) [09:00:48] (03CR) 10jerkins-bot: [V: 04-1] Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [09:01:05] 10MediaWiki-Core-Testing: Wrap file access so it can be mocked - https://phabricator.wikimedia.org/T231159 (10Simetrical) It is not part of the contract of a cache to cache something, insofar as caches by definition are for things that can be regenerated, and therefore are not designed to guarantee persistency.... [09:06:04] (03Merged) 10jenkins-bot: Remove unneeded redeclaration of mPage in Article subclasses [core] - 10https://gerrit.wikimedia.org/r/519756 (owner: 10Umherirrender) [09:07:13] (03Merged) 10jenkins-bot: Unpack arrays on variadic arguments [core] - 10https://gerrit.wikimedia.org/r/519758 (owner: 10Umherirrender) [09:08:06] 10MediaWiki-API, 10MediaWiki-extensions-General, 10Core Platform Team, 10Discovery: Add equivalent to Special:RandomInCategory to the API (either in the existing list=random or its own module) - https://phabricator.wikimedia.org/T63840 (10Bawolff) So roughly what needs to be done here: * Decide whether to... [09:08:11] (03CR) 10jerkins-bot: [V: 04-1] Cache nonexistence of grammar transformations [core] - 10https://gerrit.wikimedia.org/r/532241 (owner: 10simetrical) [09:08:37] (03CR) 10jerkins-bot: [V: 04-1] Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [09:08:53] 10MediaWiki-API, 10Core Platform Team: Add equivalent to Special:RandomInCategory to the API (either in the existing list=random or its own module) - https://phabricator.wikimedia.org/T63840 (10Bawolff) [09:10:12] 10MediaWiki-Core-Testing, 10Patch-For-Review: MediaWikiTestCaseTrait::creatNoOpMock should permit calling destructors - https://phabricator.wikimedia.org/T231656 (10Mainframe98) To give an example: ` Using PHP 7.2.13-1+0~20181207100540.13+stretch~1.gbpf57305 PHPUnit 6.5.14 by Sebastian Bergmann and contributor... [09:14:59] (03CR) 10jerkins-bot: [V: 04-1] Cache nonexistence of grammar transformations [core] - 10https://gerrit.wikimedia.org/r/532241 (owner: 10simetrical) [09:21:56] (03CR) 10jenkins-bot: Remove unneeded redeclaration of mPage in Article subclasses [core] - 10https://gerrit.wikimedia.org/r/519756 (owner: 10Umherirrender) [09:23:55] (03PS1) 10Daimona Eaytoy: Upgrade phan-config to 0.7.0 [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533730 [09:25:55] (03CR) 10jerkins-bot: [V: 04-1] Upgrade phan-config to 0.7.0 [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533730 (owner: 10Daimona Eaytoy) [09:26:35] (03CR) 10simetrical: "I've continued here also to explore a possibly somewhat different implementation strategy. You and reviewers can look at my patch as well " [core] - 10https://gerrit.wikimedia.org/r/533227 (owner: 10simetrical) [09:26:36] 10wikimediafoundation.org: There should be a complete and up-to-date public staff list - https://phabricator.wikimedia.org/T231483 (10Aklapper) > I'd recommend redirecting the current wikimediafoundation.org staff page to m:Wikimedia Foundation staff and contractors I don't think that any other organization with... [09:26:56] 10WMEE: Vabatahtlike kampaania - https://phabricator.wikimedia.org/T220333 (10kruusamagi) Kunagi sai kokku pandud ka see: https://ee.wikimedia.org/wiki/Vabatahtlikud (äkki aitab) Näide, kuhu oleks vabatahtlikke vaja: teadusfoto võistlus -- 2-4 inimest, kes moodustaksid turundustiimi [09:30:27] (03PS2) 10Daimona Eaytoy: Upgrade phan-config to 0.7.0 [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533730 [09:31:02] 10WMEE: Vabatahtlike kampaania - https://phabricator.wikimedia.org/T220333 (10Pseudacorus) Vajame inimesi, kes aitaksid vabu tekste Vikitekstidesse tuua. Ülesandeks digiteerimine ja vikivormindusse viimine. [09:31:18] 10phan: Upgrade phan/phan for our config - https://phabricator.wikimedia.org/T228257 (10Daimona) 05Open→03Resolved [[https://gerrit.wikimedia.org/g/mediawiki/tools/phan/+/refs/tags/0.7.0|0.7.0]] released, and [[https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/533730/|tested]]. [09:32:26] (03CR) 10jerkins-bot: [V: 04-1] Upgrade phan-config to 0.7.0 [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533730 (owner: 10Daimona Eaytoy) [09:33:22] !class OutputPage [09:33:22] See https://doc.wikimedia.org/mediawiki-core/master/php/classOutputPage.html [09:34:50] !class Article [09:34:50] See https://doc.wikimedia.org/mediawiki-core/master/php/classArticle.html [09:35:56] (03CR) 10jenkins-bot: Unpack arrays on variadic arguments [core] - 10https://gerrit.wikimedia.org/r/519758 (owner: 10Umherirrender) [09:36:39] 10WMEE: Vabatahtlike kampaania - https://phabricator.wikimedia.org/T220333 (10reosarevok) Isegi leidmisega oleks vist abi vaja: kui keegi tahab detektiiv olla, saab proovida leida tekste, mis veel puudu, aga mis on vabad :) [09:37:06] (03CR) 10simetrical: [C: 03+1] Calling Title::resetArticleID() now clears the Title cache (032 comments) [core] - 10https://gerrit.wikimedia.org/r/474726 (https://phabricator.wikimedia.org/T206498) (owner: 10Jason Linehan) [09:38:02] (03PS1) 10Daimona Eaytoy: Restore PHP5.6 requirement [tools/phan] - 10https://gerrit.wikimedia.org/r/533731 (https://phabricator.wikimedia.org/T228257) [09:38:47] 10MediaWiki-Special-pages, 10Performance, 10User-DannyS712, 10Wikimedia-production-error: Time out when querying new pages: WMFTimeoutException - https://phabricator.wikimedia.org/T231711 (10Aklapper) ` exception.message the execution time limit of 60 seconds was exceeded exception.trace #0 /srv/me... [09:39:18] (03CR) 10Daimona Eaytoy: [C: 03+2] "To hotfix the 0.7.0 release. Considering this a "(partial) revert of a recently merged commit"." [tools/phan] - 10https://gerrit.wikimedia.org/r/533731 (https://phabricator.wikimedia.org/T228257) (owner: 10Daimona Eaytoy) [09:39:49] (03Merged) 10jenkins-bot: Restore PHP5.6 requirement [tools/phan] - 10https://gerrit.wikimedia.org/r/533731 (https://phabricator.wikimedia.org/T228257) (owner: 10Daimona Eaytoy) [09:41:48] (03CR) 10simetrical: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase (032 comments) [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [09:42:30] (03PS3) 10Daimona Eaytoy: Upgrade phan-config to 0.7.1 [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533730 [09:43:47] 10phan: Upgrade phan/phan for our config - https://phabricator.wikimedia.org/T228257 (10Daimona) ...Re-released as 0.7.1. As I wrote on gerrit, I just realized that mediawiki-phan-config is in require-dev (unlike phan/phan for mediawiki-phan-config itself, or taint-check, both being in "extra"), and thus HHVM jo... [09:44:51] (03CR) 10simetrical: "> Patch Set 2: Code-Review-1" [core] - 10https://gerrit.wikimedia.org/r/533238 (owner: 10Krinkle) [09:46:20] (03CR) 10simetrical: "To clarify, the reason we want this change to happen is because getLinkRenderer() might be called by things that are not generating links " [core] - 10https://gerrit.wikimedia.org/r/533238 (owner: 10Krinkle) [09:48:41] (03PS8) 10Daimona Eaytoy: Unsuppress more phan issues (part 5) [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) [09:48:52] (03PS9) 10Daimona Eaytoy: Unsuppress phan issues part 6 [core] - 10https://gerrit.wikimedia.org/r/533567 (https://phabricator.wikimedia.org/T231636) [09:50:58] 10MediaWiki-History-and-Diffs, 10MediaWiki-ResourceLoader, 10Performance-Team, 10JavaScript: mw.config wgRevisionId return 0 with diffonly=1 - https://phabricator.wikimedia.org/T231744 (10Nirmos) [09:51:54] (03PS7) 10Daimona Eaytoy: Unsuppress another phan issue (part 7) [core] - 10https://gerrit.wikimedia.org/r/533703 (https://phabricator.wikimedia.org/T231636) [09:53:41] (03CR) 10jerkins-bot: [V: 04-1] Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [09:55:41] (03CR) 10simetrical: [C: 03+1] Permit destructors in MediaWikiTestCaseTrait::createNoOpMock [core] - 10https://gerrit.wikimedia.org/r/533543 (https://phabricator.wikimedia.org/T231656) (owner: 10Mainframe98) [09:56:52] (03PS14) 10simetrical: Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 [09:56:54] (03PS9) 10simetrical: Cache nonexistence of grammar transformations [core] - 10https://gerrit.wikimedia.org/r/532241 [09:59:42] 10MediaViewer: Cannot open images in Media Viewer if the file name is in Georgian script (due to additional nonsense prefix byte) - https://phabricator.wikimedia.org/T231575 (10Aklapper) [09:59:47] 10MediaViewer: Cannot open images in Media Viewer if the file name is in Georgian script (due to additional nonsense prefix byte) - https://phabricator.wikimedia.org/T231575 (10Aklapper) URL goes to https://ru.wikipedia.org/wiki/Роинашвили,_Александр_Соломонович#/media/Файл:Ალექსანდრე_როინაშვილი2.jpg Note the `Ა... [10:02:50] 10Phabricator: Preview shows that I'd remove other subscribers on a ticket - https://phabricator.wikimedia.org/T231543 (10Aklapper) [10:07:47] (03PS1) 10Pwirth: Init commit [extensions/BlueSpiceSocialTopics] - 10https://gerrit.wikimedia.org/r/533732 [10:09:14] (03PS15) 10simetrical: FileJournal tests [core] - 10https://gerrit.wikimedia.org/r/531698 [10:18:03] (03PS1) 10Pwirth: Init commit [extensions/BlueSpiceSocialWatch] - 10https://gerrit.wikimedia.org/r/533733 [10:18:27] 10WMEE: Vabatahtlike kampaania - https://phabricator.wikimedia.org/T220333 (10Pseudacorus) Ma võin nimekirja teha, kui vaja. [10:21:28] (03CR) 10jerkins-bot: [V: 04-1] Init commit [extensions/BlueSpiceSocialWatch] - 10https://gerrit.wikimedia.org/r/533733 (owner: 10Pwirth) [10:23:43] (03PS2) 10Pwirth: Init commit [extensions/BlueSpiceSocialWatch] - 10https://gerrit.wikimedia.org/r/533733 [10:25:41] 10MediaWiki-extensions-EducationProgram: Cleaning up after EducationProgram - https://phabricator.wikimedia.org/T200391 (10D3r1ck01) >>! In T200391#5456871, @MBH wrote: > @D3r1ck01 Will Educational Program namespaces be deleted in projects where EP was installed? For example, ruwiki, EP namespaces still exist (b... [10:29:04] 10MediaWiki-extensions-EducationProgram, 10Cleanup, 10Repository-Admins: Archive EducationProgram - https://phabricator.wikimedia.org/T214457 (10D3r1ck01) [10:29:40] 10MediaWiki-extensions-EducationProgram: Cleaning up after EducationProgram - https://phabricator.wikimedia.org/T200391 (10MaxBioHazard) @D3r1ck01 It's off-topic, but maybe you know answer. Will "Topic" namespace from cancelled Flow extension be deleted in projects, that were use it, too? [10:36:04] 10MediaWiki-extensions-EducationProgram: Cleaning up after EducationProgram - https://phabricator.wikimedia.org/T200391 (10D3r1ck01) >>! In T200391#5457007, @MBH wrote: > @D3r1ck01 It's off-topic, but maybe you know answer. Will "Topic" namespace from cancelled Flow extension be deleted in projects, that were us... [10:37:26] (03Abandoned) 10Zoranzoki21: Replaced no_catfakecategories hook to OutputPageParserOutput [extensions/NoCat] - 10https://gerrit.wikimedia.org/r/487364 (https://phabricator.wikimedia.org/T203733) (owner: 10Zoranzoki21) [10:37:38] 10MediaWiki-extensions-Other, 10good first bug: Extension:NoCat isn't setting up ParserOutputHook properly - https://phabricator.wikimedia.org/T203733 (10Zoranzoki21) a:05Zoranzoki21→03None [10:50:12] (03PS1) 10simetrical: Unit tests for DBFileJournal [core] - 10https://gerrit.wikimedia.org/r/533734 [10:58:27] 10Wikimedia Australia: Clarification of regions of Western Australia maps for identification of regions for scope of usage by Wiki Club West - https://phabricator.wikimedia.org/T231410 (10JarrahTree) It was really required for #Wiki Club West *as a part of* Wikimedia Australia, I have had no contact with editor... [11:01:20] 10Wikimedia Australia: Perth localities and contexts - before events and after the fact for articles - Wiki Club West context - https://phabricator.wikimedia.org/T231415 (10JarrahTree) No it is not about WMAU, but specific Wiki Club West material, there is no expectation that other states have wiki clubs as orga... [11:07:51] (03CR) 10D3r1ck01: [C: 04-1] Ensure user is not null before passing to CentralAuth (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/532970 (https://phabricator.wikimedia.org/T231333) (owner: 10Kosta Harlan) [11:09:37] 10Phabricator: Unnecessary port's two points in linked MW account link in External Accounts - https://phabricator.wikimedia.org/T231745 (10Framawiki) [11:31:00] 04(no projects): Wikipedia page crashes in error after first letter of an edit summary is selected - https://phabricator.wikimedia.org/T231746 (10Moson81) [11:33:45] 10MediaWiki-Page-editing: Wikipedia page crashes in error after first letter of an edit summary is selected - https://phabricator.wikimedia.org/T231746 (10Zoranzoki21) Hi @Moson81 and welcome to Phabricator! You assigned this task to you, do you really want to fix in code this problem? [11:35:35] 10MediaWiki-Page-editing: Wikipedia page crashes in error after first letter of an edit summary is selected - https://phabricator.wikimedia.org/T231746 (10Moson81) I do not know how to fix it. I ask if it's possible to fix this problem. [11:44:56] 10MediaWiki-extensions-EducationProgram: Cleaning up after EducationProgram - https://phabricator.wikimedia.org/T200391 (10MaxBioHazard) @D3r1ck01 It "is still very valid and is highly used" not in big wikis like enwiki, commons, ruwiki, where it recognized as unusable disaster, which makes using history, revert... [11:46:21] 10MediaWiki-Page-editing: Wikipedia page crashes in error after first letter of an edit summary is selected - https://phabricator.wikimedia.org/T231746 (10Moson81) I have taken some screenshots of the problem: https://commons.wikimedia.org/wiki/File:SummaryProblem1.jpg and https://commons.wikimedia.org/wiki/File... [11:47:13] 10BlueSpice, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, 10Patch-For-Review: Archive "BlueSpiceUserPreferences" extension - https://phabricator.wikimedia.org/T197898 (10Zoranzoki21) [11:47:30] (03CR) 10Daimona Eaytoy: "Another note: we already have MediaWikiPHPUnitTestListener. I'm unsure if that's also used for unit tests, though. If it is, then we could" [core] - 10https://gerrit.wikimedia.org/r/533067 (https://phabricator.wikimedia.org/T231419) (owner: 10Daimona Eaytoy) [11:55:59] (03CR) 10Huji: [C: 03+1] "Other than the comment I made, LGTM." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533728 (https://phabricator.wikimedia.org/T200703) (owner: 10Brian Wolff) [11:56:02] 10MediaWiki-Page-editing: Wikipedia page crashes in error after first letter of an edit summary is selected - https://phabricator.wikimedia.org/T231746 (10Moson81) a:05Moson81→03None [11:56:20] 10I18n, 10Voice & Tone: [[MediaWiki:Mwoauth-consumer-developer-agreement/sv]] translation issue - https://phabricator.wikimedia.org/T230753 (10MarcoAurelio) [11:58:27] 10MediaWiki-extensions-OATHAuth, 10I18n: [[MediaWiki:Logentry-oath-disable-other/en]] translation issue - https://phabricator.wikimedia.org/T230749 (10MarcoAurelio) AIUI: - `$1` is the person disabling the two-factor authentication. - `$2` is the user whose 2FA is being disabled, parsed there for `GENDER`... [12:02:14] 10MediaWiki-History-and-Diffs: Wikipedia page crashes in error after first letter of an edit summary is selected - https://phabricator.wikimedia.org/T231746 (10Zoranzoki21) Hmm, yes. I can reproduce this. When user want to select edit summary, if he select first letter it can't select nothing in summary. If he s... [12:06:41] 10MediaWiki-extensions-EducationProgram: Cleaning up after EducationProgram - https://phabricator.wikimedia.org/T200391 (10Reedy) Talking about Flow is off topic, please move it to another task [12:09:14] !class PoolWorkArticleView [12:09:14] See https://doc.wikimedia.org/mediawiki-core/master/php/classPoolWorkArticleView.html [12:10:49] (03PS1) 10Zoranzoki21: Test [core] - 10https://gerrit.wikimedia.org/r/533736 [12:11:34] (03Abandoned) 10Zoranzoki21: Test [core] - 10https://gerrit.wikimedia.org/r/533736 (owner: 10Zoranzoki21) [12:14:11] (03PS1) 10D3r1ck01: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/533737 [12:24:32] 10MediaWiki-extensions-Babel, 10Operations: Two user pages on meta can't be rendered: "request has exceeded memory limit" - https://phabricator.wikimedia.org/T231522 (10Aklapper) [12:26:03] 10MediaWiki-extensions-BlockAndNuke: When partial unlock, it is not visible that this was only partial unblock - https://phabricator.wikimedia.org/T231523 (10Aklapper) @Helgo13: Which exact MediaWiki version and BlockAndNuke version do you use? [12:27:55] 10MediaWiki-Internationalization, 10Wikimedia-Rdbms: TransactionProfiler should not apply to using LCStoreDB - https://phabricator.wikimedia.org/T97693 (10Aklapper) [12:38:34] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/533737 (owner: 10D3r1ck01) [12:43:03] 10MediaWiki-extensions-Scribunto: The global word -frame- is very probably not global and stops the development of the Module:Centralizer - https://phabricator.wikimedia.org/T231521 (10Aklapper) 05Open→03Stalled Hi Rical. As requested before, please always provide [[ https://www.mediawiki.org/wiki/How_to_rep... [12:46:53] (03CR) 10MarcoAurelio: "check php" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/533737 (owner: 10D3r1ck01) [12:46:55] (03PS1) 10Daimona Eaytoy: Unsuppress phan issues, part 8 [core] - 10https://gerrit.wikimedia.org/r/533739 (https://phabricator.wikimedia.org/T231636) [12:48:10] 10MediaWiki-Special-pages, 10Patch-For-Review, 10Vuln-Misconfiguration: dispatchUser() in SpecialRedirect.php should use a 302 http status code instead of a 301 to avoid certain caching issues - https://phabricator.wikimedia.org/T231386 (10Aklapper) [12:49:46] (03PS2) 10Daimona Eaytoy: Unsuppress phan issues, part 8 [core] - 10https://gerrit.wikimedia.org/r/533739 (https://phabricator.wikimedia.org/T231636) [12:50:57] 10MediaWiki-History-and-Diffs: Wikipedia page crashes in error after first letter of an edit summary is selected - https://phabricator.wikimedia.org/T231746 (10Aklapper) 05Open→03Stalled Hi, thanks for taking the time to report this and welcome! Please see https://www.mediawiki.org/wiki/How_to_report_a_bug... [12:53:31] 10Phabricator: Unnecessary port's two points in linked MW account link in External Accounts - https://phabricator.wikimedia.org/T231745 (10Aklapper) [12:53:33] 10Phabricator: MediaWiki OAuth panel could be more clear in Phabricator - https://phabricator.wikimedia.org/T91584 (10Aklapper) [12:54:20] (03PS1) 10D3r1ck01: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/533740 [12:56:07] (03CR) 10jerkins-bot: [V: 04-1] Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/533740 (owner: 10D3r1ck01) [12:56:48] (03CR) 10Daniel Kinzler: [C: 03+2] FileJournal tests [core] - 10https://gerrit.wikimedia.org/r/531698 (owner: 10simetrical) [12:57:21] 04(no projects): Perth localities and contexts - before events and after the fact for articles - Wiki Club West context - https://phabricator.wikimedia.org/T231415 (10Aklapper) @JarrahTree: Ah, thanks. Which project tag should be associated here? [12:57:55] (03PS2) 10D3r1ck01: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/533740 [12:58:41] (03CR) 10Daniel Kinzler: Unit tests for DBFileJournal (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533734 (owner: 10simetrical) [13:03:41] (03PS1) 10D3r1ck01: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533741 [13:05:20] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/533740 (owner: 10D3r1ck01) [13:11:20] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress phan issues, part 8 [core] - 10https://gerrit.wikimedia.org/r/533739 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [13:13:58] (03PS1) 10D3r1ck01: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/533742 [13:16:01] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Epics), 10Epic, 10MW-1.35-release: Remove the ability to write pre-MCR fields, limit the ability to read pre-MCR fields to migration scripts - https://phabricator.wikimedia.org/T231674 (10daniel) [13:17:02] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Epics), 10Epic, 10MW-1.35-release: Remove the ability to write pre-MCR fields, limit the ability to read pre-MCR fields to migration scripts - https://phabricator.wikimedia.org/T231674 (10daniel) [13:17:04] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Epics), 10Epic, 10MW-1.34-release: Make SCHEMA_COMPAT_NEW the default MCR migration schema - https://phabricator.wikimedia.org/T231673 (10daniel) [13:17:06] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Epics), 10Epic: Stop writing to pre-MCR fields in WMF production - https://phabricator.wikimedia.org/T231672 (10daniel) [13:17:18] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Epics), 10Epic: Ensure all direct or indirect access to pre-MCR fields is gated with the MCR migration stage - https://phabricator.wikimedia.org/T231671 (10daniel) [13:17:20] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Epics), 10Epic: Stop writing to pre-MCR fields in WMF production - https://phabricator.wikimedia.org/T231672 (10daniel) [13:17:22] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Epics), 10Epic, 10MW-1.34-release: Make SCHEMA_COMPAT_NEW the default MCR migration schema - https://phabricator.wikimedia.org/T231673 (10daniel) [13:26:04] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533741 (owner: 10D3r1ck01) [13:26:12] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/533742 (owner: 10D3r1ck01) [13:40:24] (03CR) 10Zoranzoki21: "check php" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/533737 (owner: 10D3r1ck01) [13:41:53] 10MediaWiki-Page-deletion: Cannot delete pages: Fatal error: Uncaught RuntimeException - https://phabricator.wikimedia.org/T231290 (10Aklapper) [13:46:52] 10MediaWiki-Page-deletion: Cannot delete pages: Fatal error: Uncaught RuntimeException - https://phabricator.wikimedia.org/T231290 (10Aklapper) 05Open→03Stalled @Katznew: Hi. Which exact version of MediaWiki are you using? [13:50:34] (03PS1) 10D3r1ck01: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/533743 [13:51:03] (03CR) 10Daimona Eaytoy: "recheck" [core] - 10https://gerrit.wikimedia.org/r/533739 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [13:56:27] (03PS1) 10D3r1ck01: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/533744 [14:00:24] (03PS1) 10D3r1ck01: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/533745 [14:00:58] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/533744 (owner: 10D3r1ck01) [14:01:09] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/533743 (owner: 10D3r1ck01) [14:01:47] (03CR) 10jerkins-bot: [V: 04-1] Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/533745 (owner: 10D3r1ck01) [14:01:52] (03PS1) 10Daimona Eaytoy: Upgrade phan config to 0.7.1 [core] - 10https://gerrit.wikimedia.org/r/533746 (https://phabricator.wikimedia.org/T231636) [14:02:17] 10InternetArchiveBot (v2.0): IABot 2.0 removes reference with group= parameter - https://phabricator.wikimedia.org/T231749 (10Cirdan) [14:05:21] (03PS3) 10Daimona Eaytoy: Unsuppress phan issues, part 8 [core] - 10https://gerrit.wikimedia.org/r/533739 (https://phabricator.wikimedia.org/T231636) [14:05:23] (03CR) 10jerkins-bot: [V: 04-1] Upgrade phan config to 0.7.1 [core] - 10https://gerrit.wikimedia.org/r/533746 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [14:05:25] (03CR) 10jerkins-bot: [V: 04-1] Upgrade phan config to 0.7.1 [core] - 10https://gerrit.wikimedia.org/r/533746 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [14:05:28] (03CR) 10jerkins-bot: [V: 04-1] Upgrade phan config to 0.7.1 [core] - 10https://gerrit.wikimedia.org/r/533746 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [14:05:30] (03CR) 10jerkins-bot: [V: 04-1] Upgrade phan config to 0.7.1 [core] - 10https://gerrit.wikimedia.org/r/533746 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [14:12:16] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress phan issues, part 8 [core] - 10https://gerrit.wikimedia.org/r/533739 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [14:12:52] 10MediaWiki-Page-deletion: Cannot delete pages: Fatal error: Uncaught RuntimeException - https://phabricator.wikimedia.org/T231290 (10Ciencia_Al_Poder) The real error may be masked by the unhelpful "Uncommited db writes" {T85762} [14:16:39] (03CR) 10Krinkle: Avoid usage of deprecated $wgContLang global (dep in 1.32) (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/533740 (owner: 10D3r1ck01) [14:17:53] (03PS2) 10Krinkle: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533741 (owner: 10D3r1ck01) [14:18:10] (03CR) 10Krinkle: [C: 03+2] Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533741 (owner: 10D3r1ck01) [14:18:55] 10Wikimedia-Site-requests: (enwikisource) Abuse filter changes request: add abusefilter actions block + autoconfirmed to see abusefilter-log-detail - https://phabricator.wikimedia.org/T231750 (10Billinghurst) [14:21:22] (03PS2) 10Krinkle: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/533737 (owner: 10D3r1ck01) [14:21:25] (03CR) 10Krinkle: [C: 03+2] Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/533737 (owner: 10D3r1ck01) [14:22:37] (03CR) 10Krinkle: Unsuppress more phan issues (part 5) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [14:23:52] 10MediaWiki-History-and-Diffs: First letter of an edit summary can't be selected - https://phabricator.wikimedia.org/T231746 (10Zoranzoki21) 05Stalled→03Open [14:24:23] (03CR) 10Krinkle: [C: 03+2] Unsuppress more phan issues (part 5) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [14:25:12] (03CR) 10Krinkle: Avoid usage of deprecated $wgContLang global (dep in 1.32) (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/533744 (owner: 10D3r1ck01) [14:25:54] (03CR) 10Daimona Eaytoy: Unsuppress more phan issues (part 5) (032 comments) [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [14:27:53] (03CR) 10Krinkle: [C: 04-1] "Adding the extra abstraction is nice, but I defer to Anomie for how that should look. I've left a suggestion for what I think might be bet" (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/533743 (owner: 10D3r1ck01) [14:31:48] (03CR) 10Krinkle: Unsuppress phan issues part 6 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533567 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [14:38:23] (03CR) 10Krinkle: [C: 03+2] Unsuppress phan issues part 6 [core] - 10https://gerrit.wikimedia.org/r/533567 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [14:38:45] (03PS2) 10Daimona Eaytoy: Upgrade phan config to 0.7.1 [core] - 10https://gerrit.wikimedia.org/r/533746 (https://phabricator.wikimedia.org/T231636) [14:42:55] (03Merged) 10jenkins-bot: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533741 (owner: 10D3r1ck01) [14:47:49] (03CR) 10Krinkle: Unsuppress another phan issue (part 7) (036 comments) [core] - 10https://gerrit.wikimedia.org/r/533703 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [14:48:09] (03CR) 10Krinkle: "(reviewed until maintenance/archives/upgradeLogging.php only)" [core] - 10https://gerrit.wikimedia.org/r/533703 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [14:48:12] (03CR) 10D3r1ck01: Avoid usage of deprecated $wgContLang global (dep in 1.32) (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/533740 (owner: 10D3r1ck01) [14:49:00] (03Merged) 10jenkins-bot: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/533737 (owner: 10D3r1ck01) [14:49:02] (03CR) 10Krinkle: [C: 03+2] Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/533725 (owner: 10D3r1ck01) [14:49:39] 10MediaWiki-History-and-Diffs, 10JavaScript: mw.config wgRevisionId return 0 with diffonly=1 - https://phabricator.wikimedia.org/T231744 (10Krinkle) [14:51:21] (03CR) 10jenkins-bot: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533741 (owner: 10D3r1ck01) [14:51:36] 10MediaWiki-History-and-Diffs, 10JavaScript: mw.config wgRevisionId return 0 with diffonly=1 - https://phabricator.wikimedia.org/T231744 (10Krinkle) This is not an issue with the `mw.config` system but rather with how the Diff system decides to export values to it. The values it exports are making it through w... [14:51:38] 10MediaWiki-extensions-SecurePoll: Can't create election: SecurePollContentHandler::makeContentFromElection() must be an instance of SecurePoll_Election, bool given - https://phabricator.wikimedia.org/T209804 (10SoWhy) Still happening on test-wiki, any updates on this? [14:51:41] (03CR) 10Krinkle: [C: 03+2] Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/533742 (owner: 10D3r1ck01) [14:52:32] (03CR) 10D3r1ck01: Avoid usage of deprecated $wgContLang global (dep in 1.32) (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/533744 (owner: 10D3r1ck01) [14:52:33] (03CR) 10Krinkle: Avoid usage of deprecated $wgContLang global (dep in 1.32) (031 comment) [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/533745 (owner: 10D3r1ck01) [14:52:35] (03Merged) 10jenkins-bot: Unsuppress more phan issues (part 5) [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [14:52:37] (03CR) 10Krinkle: [C: 04-1] Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/533740 (owner: 10D3r1ck01) [14:53:30] (03CR) 10Krinkle: [C: 04-1] Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/533744 (owner: 10D3r1ck01) [14:55:27] (03CR) 10Daimona Eaytoy: Unsuppress another phan issue (part 7) (033 comments) [core] - 10https://gerrit.wikimedia.org/r/533703 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [14:55:42] (03PS19) 10Krinkle: Avoid usage of deprecated setTags() method, use addTags() instead [core] - 10https://gerrit.wikimedia.org/r/521178 (owner: 10D3r1ck01) [14:55:43] (03PS3) 10D3r1ck01: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/533740 [14:55:45] (03CR) 10Krinkle: "Removed redundant handling of null in setTags." [core] - 10https://gerrit.wikimedia.org/r/521178 (owner: 10D3r1ck01) [14:55:47] (03CR) 10Krinkle: [C: 03+2] "I know it took a while. Thank you for seeing it through." [core] - 10https://gerrit.wikimedia.org/r/521178 (owner: 10D3r1ck01) [14:56:41] (03PS2) 10D3r1ck01: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/533744 [14:56:43] (03CR) 10D3r1ck01: Avoid usage of deprecated $wgContLang global (dep in 1.32) (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/533744 (owner: 10D3r1ck01) [14:56:45] (03CR) 10D3r1ck01: Avoid usage of deprecated $wgContLang global (dep in 1.32) (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/533740 (owner: 10D3r1ck01) [14:59:36] (03CR) 10jenkins-bot: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/533737 (owner: 10D3r1ck01) [14:59:59] (03PS2) 10D3r1ck01: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/533745 [15:01:12] (03CR) 10D3r1ck01: "> Removed redundant handling of null in setTags." [core] - 10https://gerrit.wikimedia.org/r/521178 (owner: 10D3r1ck01) [15:02:49] 10MediaWiki-extensions-TorBlock, 10MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), 10Patch-For-Review: TorBlock maintenance failures on labweb hosts - https://phabricator.wikimedia.org/T228465 (10Ciencia_Al_Poder) If loadExitNodes.php is obsolete now, from what I understand, it would be great if the change gets d... [15:04:02] (03CR) 10jerkins-bot: [V: 04-1] Upgrade phan config to 0.7.1 [core] - 10https://gerrit.wikimedia.org/r/533746 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [15:04:14] (03CR) 10D3r1ck01: "This change is ready for review." (031 comment) [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/533745 (owner: 10D3r1ck01) [15:05:40] \quit [15:07:51] (03CR) 10jenkins-bot: Unsuppress more phan issues (part 5) [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [15:09:03] (03Merged) 10jenkins-bot: Unsuppress phan issues part 6 [core] - 10https://gerrit.wikimedia.org/r/533567 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [15:09:05] (03Merged) 10jenkins-bot: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/533725 (owner: 10D3r1ck01) [15:09:07] (03Merged) 10jenkins-bot: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/533742 (owner: 10D3r1ck01) [15:13:28] (03CR) 10jenkins-bot: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/533742 (owner: 10D3r1ck01) [15:21:17] (03PS1) 10D3r1ck01: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/533748 [15:23:05] (03CR) 10jerkins-bot: [V: 04-1] Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/533748 (owner: 10D3r1ck01) [15:23:27] (03CR) 10jenkins-bot: Unsuppress phan issues part 6 [core] - 10https://gerrit.wikimedia.org/r/533567 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [15:24:35] (03PS2) 10D3r1ck01: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/533748 [15:25:07] (03Merged) 10jenkins-bot: Avoid usage of deprecated setTags() method, use addTags() instead [core] - 10https://gerrit.wikimedia.org/r/521178 (owner: 10D3r1ck01) [15:36:28] (03CR) 10jerkins-bot: [V: 04-1] Upgrade phan config to 0.7.1 [core] - 10https://gerrit.wikimedia.org/r/533746 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [15:40:21] (03CR) 10jenkins-bot: Avoid usage of deprecated setTags() method, use addTags() instead [core] - 10https://gerrit.wikimedia.org/r/521178 (owner: 10D3r1ck01) [15:40:46] (03PS1) 10Mainframe98: Permit case independent unit test directories [core] - 10https://gerrit.wikimedia.org/r/533749 [15:43:04] (03Abandoned) 10Mainframe98: Permit case independent unit test directories [core] - 10https://gerrit.wikimedia.org/r/533749 (owner: 10Mainframe98) [15:43:10] (03CR) 10jenkins-bot: Permit case independent unit test directories [core] - 10https://gerrit.wikimedia.org/r/533749 (owner: 10Mainframe98) [15:45:18] 10ISA: Depicts selector too big - https://phabricator.wikimedia.org/T231751 (10Astinson) [15:46:06] (03PS1) 10Mainframe98: Permit case independent unit test directories [core] - 10https://gerrit.wikimedia.org/r/533750 [15:50:13] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/533748 (owner: 10D3r1ck01) [15:56:31] (03CR) 10Raimond Spekking: [C: 03+1] "i18n review" [extensions/BlueSpiceSocialWatch] - 10https://gerrit.wikimedia.org/r/533733 (owner: 10Pwirth) [15:58:14] (03CR) 10Raimond Spekking: [C: 03+1] "i18n review" [extensions/BlueSpiceSocialTopics] - 10https://gerrit.wikimedia.org/r/533732 (owner: 10Pwirth) [15:59:14] 10MediaWiki-extensions-DeletePagesForGood: Use ordinary deletion prior to doing further cleanup - https://phabricator.wikimedia.org/T231752 (10GeoffreyT2000) [15:59:32] (03CR) 10Raimond Spekking: [C: 03+1] "i18n review" [extensions/BlueSpiceSocialTags] - 10https://gerrit.wikimedia.org/r/533717 (owner: 10Pwirth) [16:00:20] (03CR) 10Raimond Spekking: [C: 03+1] "i18n review" [extensions/BlueSpiceSocialTimelineUpdate] - 10https://gerrit.wikimedia.org/r/533715 (owner: 10Pwirth) [16:07:52] 10MediaWiki-extensions-DeletePagesForGood: Use ordinary deletion prior to doing further cleanup - https://phabricator.wikimedia.org/T231752 (10GeoffreyT2000) [16:07:54] (03PS1) 10Pwirth: Init commit [extensions/BlueSpiceSocialWikiPage] - 10https://gerrit.wikimedia.org/r/533751 [16:10:18] 04(no projects): Downloading the original SVG of a file on Commons serves a truncated stream - https://phabricator.wikimedia.org/T231753 (10Yorwba) [16:11:16] (03CR) 10jerkins-bot: [V: 04-1] Init commit [extensions/BlueSpiceSocialWikiPage] - 10https://gerrit.wikimedia.org/r/533751 (owner: 10Pwirth) [16:26:04] 04(no projects): Request to add a warning for broken/orphaned reference names before saving edit - https://phabricator.wikimedia.org/T231754 (10Secundus_Zephyrus) [16:28:53] 10MediaWiki-extensions-EducationProgram: Cleaning up after EducationProgram - https://phabricator.wikimedia.org/T200391 (10AfroThundr3007730) >>! In T200391#5457005, @D3r1ck01 wrote: >>>! In T200391#5456871, @MBH wrote: >> @D3r1ck01 Will Educational Program namespaces be deleted in projects where EP was installe... [16:50:23] (03PS3) 10Daimona Eaytoy: Upgrade phan config to 0.7.1 [core] - 10https://gerrit.wikimedia.org/r/533746 (https://phabricator.wikimedia.org/T231636) [16:58:02] (03PS1) 10Aaron Schulz: Remove unused variable in MultiHttpClient CURLOPT_READFUNCTION callback [core] - 10https://gerrit.wikimedia.org/r/533753 [17:06:22] 10MediaWiki-extensions-CLDR, 10Wikidata, 10I18n: Labels for languages missing in Wikidata - https://phabricator.wikimedia.org/T231748 (10Bugreporter) > Brazilian Portuguese -> Braziliaans-Portugees This should be fixed in CLDR, as pt-br exists in CLDR but does not have a Dutch name > Belarusian (Taraškievica... [17:07:04] 10WMEE: et.wiki 200 000 artiklit logo - https://phabricator.wikimedia.org/T212634 (10kruusamagi) Logo läks vikisse üles üles üsna pea pärast 200 tuhande artikli täitumist ehk 12. august 2019, kell 22:22‎. Erilogo sai maha võetud 30. august 2019, kell 17:01‎. [17:08:38] 10WMEE Content: Riigikogu liikmete pildid Wikimedia Commonsisse - https://phabricator.wikimedia.org/T222553 (10kruusamagi) 05Open→03Resolved https://commons.wikimedia.org/wiki/Category:XIV_Riigikogu [17:11:18] 10MediaWiki-extensions-CLDR, 10translatewiki.net: Local language name should be translatable in translatewiki - https://phabricator.wikimedia.org/T231755 (10Bugreporter) [17:13:22] 10MediaWiki-extensions-CLDR, 10translatewiki.net: Local language name should be translatable in translatewiki - https://phabricator.wikimedia.org/T231755 (10Bugreporter) [17:13:44] (03CR) 10jerkins-bot: [V: 04-1] Upgrade phan config to 0.7.1 [core] - 10https://gerrit.wikimedia.org/r/533746 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [17:16:55] (03PS2) 10Umherirrender: Call getMessage when outputting exceptions in sql.php [core] - 10https://gerrit.wikimedia.org/r/520805 [17:18:30] 10AbuseFilter, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27): Blockautopromote entries have hardcoded and localised duration in the DB - https://phabricator.wikimedia.org/T231131 (10Urbanecm) 05Open→03Stalled [17:21:57] (03PS4) 10Daimona Eaytoy: Upgrade phan config to 0.7.1 [core] - 10https://gerrit.wikimedia.org/r/533746 (https://phabricator.wikimedia.org/T231636) [17:22:50] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Epic, 10Tracking-Neverending: [Epic] data quality and trust - https://phabricator.wikimedia.org/T76230 (10Bugreporter) [17:23:58] 10AbuseFilter, 10Wikimedia-maintenance-script-run: Run fixFirstBlockAutopromoteEntries in production - https://phabricator.wikimedia.org/T231137 (10Urbanecm) [17:24:27] 10AbuseFilter, 10Wikimedia-maintenance-script-run: Run fixFirstBlockAutopromoteEntries in production - https://phabricator.wikimedia.org/T231137 (10Urbanecm) [17:24:53] 10AbuseFilter, 10Wikimedia-maintenance-script-run: Run fixFirstBlockAutopromoteEntries in production - https://phabricator.wikimedia.org/T231137 (10Daimona) [17:26:43] (03CR) 10Daimona Eaytoy: Call getMessage when outputting exceptions in sql.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/520805 (owner: 10Umherirrender) [17:31:25] (03PS1) 10Framawiki: Specify that opens a new discussion topic [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533754 [17:32:33] (03CR) 10Umherirrender: Call getMessage when outputting exceptions in sql.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/520805 (owner: 10Umherirrender) [17:35:26] 10AbuseFilter, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27): Blockautopromote entries have hardcoded and localised duration in the DB - https://phabricator.wikimedia.org/T231131 (10Urbanecm) [17:38:30] 10AbuseFilter: Blockautopromote duration should be configurable - https://phabricator.wikimedia.org/T231756 (10Bugreporter) [17:38:47] 10MediaWiki-Page-editing: Request to add a warning for broken/orphaned reference names before saving edit - https://phabricator.wikimedia.org/T231754 (10Zoranzoki21) [17:44:09] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Story: [Story] nudge when editing a statement to check reference - https://phabricator.wikimedia.org/T76232 (10Lydia_Pintscher) 05Open→03Invalid We'll be tackling this now in #tainted_references. I'm closing this ticket in favor of the ones there. [17:44:12] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Epic, 10Tracking-Neverending: [Epic] data quality and trust - https://phabricator.wikimedia.org/T76230 (10Lydia_Pintscher) [17:44:14] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Epic, 10Tracking-Neverending: [Epic] Redesign Item UI for Wikidata repo - https://phabricator.wikimedia.org/T54136 (10Lydia_Pintscher) [17:45:31] (03Abandoned) 10Umherirrender: Return false from FormattedRCFeed::notify [core] - 10https://gerrit.wikimedia.org/r/517723 (owner: 10Umherirrender) [17:47:12] (03CR) 10Umherirrender: [C: 03+1] Use the correct object in onSpecialSearchSetupEngine [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/512499 (https://phabricator.wikimedia.org/T224353) (owner: 10Reedy) [17:52:12] (03PS4) 10Umherirrender: Adjust type hints in api related classes [core] - 10https://gerrit.wikimedia.org/r/520062 [17:52:25] (03CR) 10Umherirrender: "Rebased" [core] - 10https://gerrit.wikimedia.org/r/520062 (owner: 10Umherirrender) [17:52:59] (03PS2) 10Umherirrender: Fix use of argument perfLogFilename in convertLinks.php [core] - 10https://gerrit.wikimedia.org/r/520312 [17:53:23] (03PS2) 10Umherirrender: Fix instance of Preprocessor in PreprocessDump maintenance script [core] - 10https://gerrit.wikimedia.org/r/520936 [18:00:15] (03CR) 10Umherirrender: Avoid usage of deprecated $wgContLang global (dep in 1.32) (031 comment) [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/533745 (owner: 10D3r1ck01) [18:00:22] (03CR) 10Umherirrender: [C: 03+1] Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/533744 (owner: 10D3r1ck01) [18:02:46] (03CR) 10D3r1ck01: [C: 03+1] "lgtm!" [core] - 10https://gerrit.wikimedia.org/r/533753 (owner: 10Aaron Schulz) [18:03:55] (03CR) 10Umherirrender: [C: 04-1] Avoid usage of deprecated $wgContLang global (dep in 1.32) (031 comment) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/533748 (owner: 10D3r1ck01) [18:06:34] (03CR) 10D3r1ck01: Avoid usage of deprecated $wgContLang global (dep in 1.32) (031 comment) [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/533745 (owner: 10D3r1ck01) [18:07:35] (03PS3) 10D3r1ck01: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/533745 [18:09:20] 04(no projects): Repeated errors while undeleting a file - https://phabricator.wikimedia.org/T231757 (10Yann) [18:11:08] (03PS3) 10D3r1ck01: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/533748 [18:11:43] (03CR) 10Umherirrender: [C: 04-1] Avoid usage of deprecated $wgContLang global (dep in 1.32) (032 comments) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/533740 (owner: 10D3r1ck01) [18:12:20] (03CR) 10D3r1ck01: Avoid usage of deprecated $wgContLang global (dep in 1.32) (031 comment) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/533748 (owner: 10D3r1ck01) [18:12:54] 10MediaWiki-File-management, 10Commons, 10Operations: Repeated errors while undeleting a file - https://phabricator.wikimedia.org/T231757 (10Zoranzoki21) @Urbanecm Oh, this is really weird. We get similar reports. Did I add the correct tags? [18:14:22] (03CR) 10Umherirrender: [C: 03+1] Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/533745 (owner: 10D3r1ck01) [18:14:51] (03CR) 10Daimona Eaytoy: [C: 03+1] "Haven't tested" [core] - 10https://gerrit.wikimedia.org/r/519769 (owner: 10Umherirrender) [18:15:36] (03CR) 10Umherirrender: [C: 03+1] Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/533748 (owner: 10D3r1ck01) [18:16:09] 10Repository-Admins: +2 in mediawiki/* for Zoranzoki21 - https://phabricator.wikimedia.org/T231758 (10Zoranzoki21) [18:16:16] (03CR) 10Daimona Eaytoy: Call getMessage when outputting exceptions in sql.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/520805 (owner: 10Umherirrender) [18:16:45] 10MediaWiki-File-management, 10Commons, 10Operations: Repeated errors while undeleting a file - https://phabricator.wikimedia.org/T231757 (10Yann) The expected content is https://commons.wikimedia.org/wiki/User:Yann/%E0%A4%B6%E0%A4%BF%E0%A4%B2%E0%A5%8D%E0%A4%AA%E0%A4%95%E0%A4%BE%E0%A4%B0_%E0%A4%9A%E0%A4%B0%E... [18:17:16] (03CR) 10Umherirrender: "Link renderer is now a property in Pager, since I082152b64141f1a9a4085bba23fe81a99ec8d886" [core] - 10https://gerrit.wikimedia.org/r/530974 (owner: 10Umherirrender) [18:17:38] 10MediaWiki-File-management, 10Commons, 10Operations, 10Wikimedia-production-error: Repeated errors while undeleting a file - https://phabricator.wikimedia.org/T231757 (10Zoranzoki21) ` MediaWiki internal error. Original exception: [XWwLHwpAAD8AAC1WrNIAAACN] 2019-09-01 18:17:03: Fatal exception of type "W... [18:18:05] 10Phabricator: Phabricator: Simplify the multifactor auth reset procedure - https://phabricator.wikimedia.org/T231667 (10Tgr) Phab helper tools are not really "other systems". When used as authentication for other systems (e.g. Wikimedia Space), it's hard to judge how sensitive an account is; it could be a compl... [18:19:44] (03CR) 10D3r1ck01: Avoid usage of deprecated $wgContLang global (dep in 1.32) (032 comments) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/533740 (owner: 10D3r1ck01) [18:20:06] (03CR) 10Daimona Eaytoy: [C: 03+1] "Haven't tested. Has this code ever worked?" [core] - 10https://gerrit.wikimedia.org/r/520936 (owner: 10Umherirrender) [18:20:10] (03PS4) 10D3r1ck01: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/533740 [18:22:15] (03CR) 10Daimona Eaytoy: "Note that I already did PhanTypeMismatchReturn as part of T231636, before seeing this patch. However, feel free to reinstate your version " [core] - 10https://gerrit.wikimedia.org/r/517740 (owner: 10Umherirrender) [18:28:12] 04(no projects): Feature request: Gadget to hide imperial units - https://phabricator.wikimedia.org/T231759 (10Ake) [18:28:48] (03PS4) 10Krinkle: registration: Avoid redundant LBYL check in ExtensionRegistry::queue() [core] - 10https://gerrit.wikimedia.org/r/533713 (https://phabricator.wikimedia.org/T187154) [18:28:54] (03PS11) 10Daimona Eaytoy: Minor fixes for AbuseFilterFilter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532961 [18:29:37] 10MediaWiki-API, 10AbuseFilter, 10Core Platform Team, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), and 2 others: AbuseFilter should have an edit API - https://phabricator.wikimedia.org/T213037 (10Daimona) So, I think this should be coded on top of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Abu... [18:32:55] (03PS4) 10Umherirrender: Use the existing link renderer in the special page pagers [core] - 10https://gerrit.wikimedia.org/r/530974 [18:33:30] (03CR) 10Umherirrender: "Rebased and simplified due to I082152b64141f1a9a4085bba23fe81a99ec8d886" [core] - 10https://gerrit.wikimedia.org/r/530974 (owner: 10Umherirrender) [18:35:14] 10BlueSpice, 10I18n: Message key "blog" exists twice: BlueSpiceBlog and BlueSpiceSocialBlog - https://phabricator.wikimedia.org/T231722 (10Zoranzoki21) [18:35:34] (03PS9) 10Daimona Eaytoy: Add a 'strict' option to VariableHolder::getVar [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/529598 (https://phabricator.wikimedia.org/T230256) [18:35:55] (03CR) 10jenkins-bot: build: Updating eslint-config-wikimedia to 0.14.1 [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/533755 (owner: 10Libraryupgrader) [18:39:22] (03PS3) 10Umherirrender: Simplify NewFilesPager::getQueryInfo [core] - 10https://gerrit.wikimedia.org/r/530952 (https://phabricator.wikimedia.org/T227608) [18:39:40] (03CR) 10Umherirrender: "Rebased (remove of newbie feature was the conflict)" [core] - 10https://gerrit.wikimedia.org/r/530952 (https://phabricator.wikimedia.org/T227608) (owner: 10Umherirrender) [18:41:13] (03PS50) 10Daimona Eaytoy: Split afl_filter in afl_filter_id and afl_global [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/459818 (https://phabricator.wikimedia.org/T220791) [18:42:22] (03CR) 10Umherirrender: [C: 03+1] Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/533740 (owner: 10D3r1ck01) [18:43:40] (03PS3) 10Umherirrender: Add string cast when outputting exceptions in sql.php [core] - 10https://gerrit.wikimedia.org/r/520805 [18:43:47] (03CR) 10jerkins-bot: [V: 04-1] Split afl_filter in afl_filter_id and afl_global [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/459818 (https://phabricator.wikimedia.org/T220791) (owner: 10Daimona Eaytoy) [18:43:51] (03CR) 10Umherirrender: Add string cast when outputting exceptions in sql.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/520805 (owner: 10Umherirrender) [18:44:10] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Patch-For-Review: Opening mentorship module on mobile throws JS error if it lists a question that's more than 30 days old - https://phabricator.wikimedia.org/T231701 (10kostajh) Moving to current sprint, since we've reverted the (resolved) task... [18:45:34] (03PS11) 10Daimona Eaytoy: Refactor data load in ViewEdit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/493692 [18:45:39] (03PS6) 10D3r1ck01: [parser][edit] Introduce IParser interface with `getOutput()` method [core] - 10https://gerrit.wikimedia.org/r/531314 [18:45:47] (03PS13) 10Daimona Eaytoy: Avoid keeping superfluous row properties [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/493703 [18:46:20] (03CR) 10Daimona Eaytoy: [C: 03+2] "Thanks!" [core] - 10https://gerrit.wikimedia.org/r/520805 (owner: 10Umherirrender) [18:47:08] 10Gadgets, 10Indic-TechCom: Feature request: Gadget to hide imperial units - https://phabricator.wikimedia.org/T231759 (10Zoranzoki21) @Jayprakash12345 Can we make this? [18:49:24] (03CR) 10Daniel Kinzler: "Should I46d10ab7b87c2 depend on this now?" [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [18:49:43] (03PS2) 10Umherirrender: Avoid multiply calls to MediaWikiServices::getInstance() in one function [core] - 10https://gerrit.wikimedia.org/r/530961 [18:49:57] (03CR) 10Umherirrender: "Rebased" [core] - 10https://gerrit.wikimedia.org/r/530961 (owner: 10Umherirrender) [18:54:40] (03CR) 10jerkins-bot: [V: 04-1] Avoid keeping superfluous row properties [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/493703 (owner: 10Daimona Eaytoy) [18:55:32] (03PS3) 10Umherirrender: Use Maintenance::getConfig in some maintenance scripts [core] - 10https://gerrit.wikimedia.org/r/530884 [18:56:07] (03CR) 10Umherirrender: "Rebased" [core] - 10https://gerrit.wikimedia.org/r/530884 (owner: 10Umherirrender) [18:56:27] (03CR) 10Kosta Harlan: "> Patch Set 17:" [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [18:57:35] (03CR) 10jerkins-bot: [V: 04-1] Split afl_filter in afl_filter_id and afl_global [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/459818 (https://phabricator.wikimedia.org/T220791) (owner: 10Daimona Eaytoy) [19:01:14] (03CR) 10Krinkle: [C: 03+2] Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/533744 (owner: 10D3r1ck01) [19:01:48] (03PS4) 10Krinkle: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/533745 (owner: 10D3r1ck01) [19:01:52] (03CR) 10Krinkle: [C: 03+2] Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/533745 (owner: 10D3r1ck01) [19:02:12] (03CR) 10Krinkle: [C: 03+2] Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/533748 (owner: 10D3r1ck01) [19:02:48] (03CR) 10Krinkle: [C: 03+2] Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/533740 (owner: 10D3r1ck01) [19:03:01] (03CR) 10Kosta Harlan: "> Patch Set 17:" [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [19:05:36] (03CR) 10Krinkle: "How is that AbuseFilter doesn't fail here like it does on mine? Is it not resetting them correctly?" [core] - 10https://gerrit.wikimedia.org/r/533227 (owner: 10simetrical) [19:06:27] (03CR) 10Krinkle: "Oh it's disabling all that matters on HHVM, which is the main php favour we use for the test pipeline." [core] - 10https://gerrit.wikimedia.org/r/533227 (owner: 10simetrical) [19:06:31] (03CR) 10Krinkle: "check php" [core] - 10https://gerrit.wikimedia.org/r/533227 (owner: 10simetrical) [19:07:16] (03CR) 10Umherirrender: Unsuppress phan issues, part 8 (033 comments) [core] - 10https://gerrit.wikimedia.org/r/533739 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [19:08:07] (03PS18) 10Krinkle: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) [19:08:16] (03CR) 10jerkins-bot: [V: 04-1] Refactor data load in ViewEdit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/493692 (owner: 10Daimona Eaytoy) [19:08:58] 10Design, 10MediaWiki-extensions-WikibaseRepository, 10WMDE-Design, 10Wikidata, and 4 others: Highlight statement(s) when using "#P" in URL - https://phabricator.wikimedia.org/T178745 (10Lydia_Pintscher) [19:10:05] 10Indic-TechCom: Feature request: Gadget to hide imperial units - https://phabricator.wikimedia.org/T231759 (10Nirmos) This would be trivial if appropriate HTML was added to https://en.wikipedia.org/wiki/Template:Convert and extremely unreliable as things currently stand (you would basically have to run a regex... [19:10:12] (03CR) 10Umherirrender: "What about using annotations like @method for the correct type?" [core] - 10https://gerrit.wikimedia.org/r/533355 (owner: 10Aaron Schulz) [19:10:27] (03PS1) 10Kosta Harlan: Move non-unit tests back into default (integration) directory [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533757 [19:12:07] (03Merged) 10jenkins-bot: Add string cast when outputting exceptions in sql.php [core] - 10https://gerrit.wikimedia.org/r/520805 (owner: 10Umherirrender) [19:13:23] (03CR) 10Daimona Eaytoy: [C: 04-1] "> What about using annotations like @method for the correct type?" [core] - 10https://gerrit.wikimedia.org/r/533355 (owner: 10Aaron Schulz) [19:14:03] (03PS2) 10Kosta Harlan: Move non-unit tests back into default (integration) directory [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533757 [19:15:14] 10Design, 10MediaWiki-Special-pages, 10Patch-For-Review, 10Upstream, 10User-D3r1ck01: Special:Version does not wrap value in Version column; overlaps with License column - https://phabricator.wikimedia.org/T231323 (10Aklapper) [19:15:17] (03Merged) 10jenkins-bot: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/533744 (owner: 10D3r1ck01) [19:15:22] (03PS10) 10Umherirrender: Fix use of GenderCache in ApiPageSet::processTitlesArray [core] - 10https://gerrit.wikimedia.org/r/462120 [19:16:03] (03PS11) 10Umherirrender: Fix use of GenderCache in ApiPageSet::processTitlesArray [core] - 10https://gerrit.wikimedia.org/r/462120 [19:16:08] (03Merged) 10jenkins-bot: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/533745 (owner: 10D3r1ck01) [19:16:19] 10Design, 10MediaWiki-Special-pages, 10Patch-For-Review, 10Upstream, 10User-D3r1ck01: In Brave browser, Special:Version does not wrap value in Version column; overlaps with License column - https://phabricator.wikimedia.org/T231323 (10Aklapper) [19:16:37] (03Merged) 10jenkins-bot: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/533748 (owner: 10D3r1ck01) [19:17:16] (03CR) 10Umherirrender: "Rebased" [core] - 10https://gerrit.wikimedia.org/r/462120 (owner: 10Umherirrender) [19:18:06] (03CR) 10jerkins-bot: [V: 04-1] Move non-unit tests back into default (integration) directory [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533757 (owner: 10Kosta Harlan) [19:19:05] (03Merged) 10jenkins-bot: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/533740 (owner: 10D3r1ck01) [19:19:15] (03CR) 10jenkins-bot: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/533744 (owner: 10D3r1ck01) [19:19:18] (03PS3) 10Kosta Harlan: Move non-unit tests back into default (integration) directory [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533757 [19:20:34] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [19:21:47] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [19:22:00] (03CR) 10Daimona Eaytoy: "I've quickly read the patch about unsetting globals. Isn't it only failing for AbuseFilterTest? Or are the parser tests broken as well?" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533757 (owner: 10Kosta Harlan) [19:22:37] (03CR) 10Kosta Harlan: "> Patch Set 3:" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533757 (owner: 10Kosta Harlan) [19:25:58] (03CR) 10jerkins-bot: [V: 04-1] Move non-unit tests back into default (integration) directory [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533757 (owner: 10Kosta Harlan) [19:26:56] 10Gerrit-Privilege-Requests: +2 in mediawiki/* for Zoranzoki21 - https://phabricator.wikimedia.org/T231758 (10Aklapper) @Zoranzoki21: This seems to be for #Gerrit-Privilege-Requests instead? See https://phabricator.wikimedia.org/project/profile/85/ :) [19:27:57] (03CR) 10jenkins-bot: Add string cast when outputting exceptions in sql.php [core] - 10https://gerrit.wikimedia.org/r/520805 (owner: 10Umherirrender) [19:28:07] 10MediaWiki-Internationalization, 10MediaWiki-extensions-Scribunto, 10I18n: Allow users to code in localized programming languages - https://phabricator.wikimedia.org/T150417 (10Yair_rand) Okay, I know this was closed as declined, but the problems mentioned seem really easy to solve. Variable naming conflict... [19:29:06] (03PS19) 10Krinkle: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) [19:29:58] (03CR) 10Krinkle: "I've applied the setUpBeforeClass optimisation from Simetrical, as well as to add stricter restoration of Autoloader related stuff by maki" [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [19:31:37] (03CR) 10Krinkle: [C: 03+1] Unit tests: Remove duplicated code in ExtensionRegistry [core] - 10https://gerrit.wikimedia.org/r/530809 (https://phabricator.wikimedia.org/T226911) (owner: 10Kosta Harlan) [19:32:20] (03PS4) 10Krinkle: Move non-unit tests back into default (integration) directory [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533757 (owner: 10Kosta Harlan) [19:32:42] (03CR) 10Daimona Eaytoy: "> > Patch Set 3:" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533757 (owner: 10Kosta Harlan) [19:33:19] (03CR) 10Krinkle: [C: 03+2] Unit tests: Remove duplicated code in ExtensionRegistry [core] - 10https://gerrit.wikimedia.org/r/530809 (https://phabricator.wikimedia.org/T226911) (owner: 10Kosta Harlan) [19:34:52] 10MediaWiki-File-management, 10Commons, 10Operations, 10Wikimedia-production-error: Repeated errors while undeleting a file - https://phabricator.wikimedia.org/T231757 (10Urbanecm) Posting tracebacks from logstash for posterity, this is T231276 basically. This one is for `XWwIjgpAICgAAI1nf8IAAABD`, but `XW... [19:35:20] (03CR) 10Krinkle: "Once this passes, I'll remove the Depends-On and land it first. Then rebase the core patch on top of that (inverse, because this change wo" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533757 (owner: 10Kosta Harlan) [19:36:28] (03PS4) 10Umherirrender: phan: Enable PhanTypeMismatchReturn and PhanTypeMismatchArgument issue [core] - 10https://gerrit.wikimedia.org/r/517740 (https://phabricator.wikimedia.org/T231636) [19:36:38] 10MediaWiki-Page-editing: Request to add a warning for broken/orphaned reference names before saving edit - https://phabricator.wikimedia.org/T231754 (10Aklapper) Hi @Secundus_Zephyrus, thanks for taking the time to report this and welcome to Wikimedia Phabricator! Is this the same as {T68233}? (Also see {T9243... [19:36:59] (03CR) 10Umherirrender: "Rebased, still WIP, waiting for some extra patch set to be merged, before this passed" [core] - 10https://gerrit.wikimedia.org/r/517740 (https://phabricator.wikimedia.org/T231636) (owner: 10Umherirrender) [19:37:19] 10Gerrit-Privilege-Requests: +2 in mediawiki/* for Zoranzoki21 - https://phabricator.wikimedia.org/T231758 (10Zoranzoki21) >>! In T231758#5457381, @Aklapper wrote: > @Zoranzoki21: This seems to be for #Gerrit-Privilege-Requests instead? See https://phabricator.wikimedia.org/project/profile/85/ :) Oh wow, thanks! [19:37:30] 10Gerrit-Privilege-Requests: +2 in mediawiki/* for Zoranzoki21 - https://phabricator.wikimedia.org/T231758 (10Krinkle) [19:37:59] (03CR) 10jerkins-bot: [V: 04-1] Move non-unit tests back into default (integration) directory [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533757 (owner: 10Kosta Harlan) [19:39:02] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [19:39:06] 10Gerrit-Privilege-Requests: +2 in mediawiki/* for Zoranzoki21 - https://phabricator.wikimedia.org/T231758 (10Krinkle) > many patches got unsettled so we have to recheck it all. And I want to help with that, not to go to IRC and query @Jdforrester-WMF or @Reedy to recheck patches. This sounds like you are askin... [19:39:37] 10Gerrit-Privilege-Requests: +2 in mediawiki/* for Zoranzoki21 - https://phabricator.wikimedia.org/T231758 (10Krinkle) [19:40:24] 10MediaWiki-Core-Testing, 10Patch-For-Review, 10phan: Phan should object to @return that doesn't have a return - https://phabricator.wikimedia.org/T223082 (10Umherirrender) 05Open→03Resolved Fixed by patch sets for T231636 [19:40:57] (03PS5) 10Umherirrender: phan: Enable PhanTypeMismatchArgument issue [core] - 10https://gerrit.wikimedia.org/r/517740 (https://phabricator.wikimedia.org/T231636) [19:41:10] (03PS5) 10Kosta Harlan: Move non-unit tests back into default (integration) directory [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533757 [19:41:41] 10Wiki-Loves-Monuments-Sources, 10Wiki-Loves-Monuments (2018): Get Malaysia into the monuments database - https://phabricator.wikimedia.org/T173783 (10JeanFred) Harvest done. 309 monuments. Queryable via the API at https://tools.wmflabs.org/heritage/api/api.php?action=search&srcountry=my&srlang=&srname=&sradd... [19:42:59] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [19:43:07] 10Monumental, 10Wiki-Loves-Monuments (2019): Portugal appearing as "not participating in Wiki Loves Monuments 2019" at WLM map - https://phabricator.wikimedia.org/T231760 (10JeanFred) [19:45:58] !task T140490 [19:45:59] https://phabricator.wikimedia.org/TT140490 [19:45:59] T140490: Search magnifying glass and placeholder text mashed together in Opera Mini extreme mode (all resolutions) - https://phabricator.wikimedia.org/T140490 [19:47:51] (03CR) 10jerkins-bot: [V: 04-1] Move non-unit tests back into default (integration) directory [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533757 (owner: 10Kosta Harlan) [19:49:09] (03CR) 10Umherirrender: "As expected the most issues are "gone"/not longer part of the diff, because this was a squashed patch set. Still the phan-var annotations " [core] - 10https://gerrit.wikimedia.org/r/517740 (https://phabricator.wikimedia.org/T231636) (owner: 10Umherirrender) [19:49:47] (03CR) 10Krinkle: "check php" [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [19:50:09] 10Gerrit-Privilege-Requests: +2 in mediawiki/* for Zoranzoki21 - https://phabricator.wikimedia.org/T231758 (10Zoranzoki21) >>! In T231758#5457395, @Krinkle wrote: >> many patches got unsettled so we have to recheck it all. And I want to help with that, not to go to IRC and query @Jdforrester-WMF or @Reedy to rec... [19:50:30] 10MediaWiki-Parser: Incorrectly located line break after a minus sign - https://phabricator.wikimedia.org/T230623 (10Aklapper) 05Stalled→03Declined Unfortunately closing this report as no further information has been provided. @Michael_Hardy: After you have provided the information asked for and if this sti... [19:54:04] (03PS6) 10Kosta Harlan: Move non-unit tests back into default (integration) directory [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533757 [19:54:20] (03CR) 10Umherirrender: Better randomness for Special:RandomInCat and no more subcats (033 comments) [core] - 10https://gerrit.wikimedia.org/r/533728 (https://phabricator.wikimedia.org/T200703) (owner: 10Brian Wolff) [19:56:19] (03Merged) 10jenkins-bot: Unit tests: Remove duplicated code in ExtensionRegistry [core] - 10https://gerrit.wikimedia.org/r/530809 (https://phabricator.wikimedia.org/T226911) (owner: 10Kosta Harlan) [19:57:31] (03PS7) 10Krinkle: Move non-unit tests back into default (integration) directory [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533757 (owner: 10Kosta Harlan) [19:57:49] (03PS20) 10Krinkle: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) [19:57:53] (03CR) 10Krinkle: "check php" [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [19:58:06] 10MediaWiki-Core-Testing, 10MediaWiki-General, 10phan: Support phan in MediaWiki's default composer.json - https://phabricator.wikimedia.org/T220589 (10Daimona) 05Open→03Stalled [19:59:34] 10Wiki-Loves-Monuments (2019): Switch Portugal to Wikidata at the Monuments Database - https://phabricator.wikimedia.org/T231727 (10Lokal_Profil) [19:59:50] 10MediaWiki-History-and-Diffs: First letter of an edit summary can't be selected - https://phabricator.wikimedia.org/T231746 (10Aklapper) Thanks for the clarification. From Firefox 68 on https://cs.wikipedia.org/w/index.php?title=Galerie_Rudolfinum&action=history (please always provide links!): {F30190760} Th... [20:00:28] 10Design, 10MediaWiki-History-and-Diffs: Cannot select first letter (bracket) of edit summary due to being a pseudo element in CSS - https://phabricator.wikimedia.org/T231746 (10Aklapper) [20:00:48] 10MediaWiki-History-and-Diffs, 10CSS: Cannot select first letter (bracket) of edit summary due to being a pseudo element in CSS - https://phabricator.wikimedia.org/T231746 (10Aklapper) [20:02:18] (03CR) 10jerkins-bot: [V: 04-1] phan: Enable PhanTypeMismatchArgument issue [core] - 10https://gerrit.wikimedia.org/r/517740 (https://phabricator.wikimedia.org/T231636) (owner: 10Umherirrender) [20:03:19] (03CR) 10Umherirrender: [V: 03+2] build: Updating eslint-utils to 1.4.2 [extensions/examples] - 10https://gerrit.wikimedia.org/r/532003 (owner: 10Libraryupgrader) [20:03:50] (03CR) 10jenkins-bot: build: Updating eslint-utils to 1.4.2 [extensions/examples] - 10https://gerrit.wikimedia.org/r/532003 (owner: 10Libraryupgrader) [20:04:05] 10wikidiff2, 10Core Platform Team Workboards (User Stories): Deploy Updated wikidiff2 C++ Engine - https://phabricator.wikimedia.org/T231586 (10Aklapper) [20:04:37] 10MediaWiki-extensions-OATHAuth, 10I18n: [[MediaWiki:Logentry-oath-disable-other/en]] translation issue - https://phabricator.wikimedia.org/T230749 (10Skalman) 05Open→03Resolved a:03Skalman @MarcoAurelio, thank you! I've added this description to the [[ https://translatewiki.net/wiki/MediaWiki:Logentry-o... [20:04:42] (03CR) 10Umherirrender: [V: 03+2] Update JavaScript code according to coding conventions [extensions/UploadLogo] - 10https://gerrit.wikimedia.org/r/533209 (owner: 10Fomafix) [20:07:14] (03CR) 10Umherirrender: [C: 03+2] Fix typo (availabe -> available) [extensions/Farmer] - 10https://gerrit.wikimedia.org/r/532826 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [20:07:37] (03PS3) 10Umherirrender: Fix typo (availabe -> available) [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/532825 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [20:07:41] (03CR) 10Umherirrender: [C: 03+2] Fix typo (availabe -> available) [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/532825 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [20:07:43] (03CR) 10Krinkle: "Confirmed "Warning: Invalid argument supplied for foreach() in /workspace/src/tests/phpunit/MediaWikiUnitTestCase.php on line 66" is speci" [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [20:08:17] (03PS21) 10Krinkle: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) [20:08:20] (03CR) 10Umherirrender: "recheck" [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/530990 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [20:11:37] (03CR) 10jenkins-bot: Unit tests: Remove duplicated code in ExtensionRegistry [core] - 10https://gerrit.wikimedia.org/r/530809 (https://phabricator.wikimedia.org/T226911) (owner: 10Kosta Harlan) [20:14:25] (03CR) 10Krinkle: "I had a `$key !== "GLOBALS"` filter in my code originally, but removed it to match your patch. I don't recall why I had that, but I've con" [core] - 10https://gerrit.wikimedia.org/r/533227 (owner: 10simetrical) [20:14:47] (03CR) 10jerkins-bot: [V: 04-1] Fix typos in code (paramters -> parameters) [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/530990 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [20:15:07] 10Wiki-Loves-Monuments (2019): Switch Portugal to Wikidata at the Monuments Database - https://phabricator.wikimedia.org/T231727 (10Lokal_Profil) Thanks. The following should work as our sparql string: https://w.wiki/7ke Could you also add information about: * the id-template you use on Commons (and any paramet... [20:22:55] (03CR) 10Zoranzoki21: [C: 03+1] "Not sure why Jenkins vote with -1 but this is ok." [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/530990 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [20:24:04] (03CR) 10Krinkle: "Check the full build output, and expand sections as needed to find the problem." [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/530990 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [20:25:39] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [20:25:52] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [20:25:54] (03CR) 10D3r1ck01: [C: 03+1] "absolutely makes sense. thanks!" [core] - 10https://gerrit.wikimedia.org/r/530961 (owner: 10Umherirrender) [20:29:45] !class Sanitizer [20:29:45] See https://doc.wikimedia.org/mediawiki-core/master/php/classSanitizer.html [20:31:07] !class Html [20:31:07] See https://doc.wikimedia.org/mediawiki-core/master/php/classHtml.html [20:32:08] 10MediaWiki-File-management, 10Commons, 10Multimedia: Provide practical thumbnail URL - https://phabricator.wikimedia.org/T231454 (10Aklapper) @simon04: Is this the same as {T139294} and/or {T66214}? [20:33:00] (03CR) 10Krinkle: [C: 03+2] Move non-unit tests back into default (integration) directory [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533757 (owner: 10Kosta Harlan) [20:34:29] 10Wikimedia-Site-requests: Allow sysop to grant transwiki-rights on nnwiki - https://phabricator.wikimedia.org/T231761 (10jeblad) [20:34:36] (03PS1) 10Krinkle: WIP: MediaWikiIntegrationTestCase [core] - 10https://gerrit.wikimedia.org/r/533765 [20:34:55] 10Wikimedia-Site-requests: Allow sysop to grant transwiki-rights on nnwiki - https://phabricator.wikimedia.org/T231761 (10jeblad) [20:35:10] !class BaseTemplate [20:35:10] See https://doc.wikimedia.org/mediawiki-core/master/php/classBaseTemplate.html [20:35:11] 10Wikimedia-Site-requests: Allow sysop to grant transwiki-rights on nnwiki - https://phabricator.wikimedia.org/T231761 (10jeblad) 05Open→03Stalled Hold the execution until discussion is finished at [[ https://nn.wikipedia.org/wiki/Wikipedia:Samfunnshuset#Sl%C3%A5_p%C3%A5_transwiki | w:nn:Wikipedia:Samfunnshu... [20:35:46] (03PS2) 10Krinkle: WIP: MediaWikiIntegrationTestCase [core] - 10https://gerrit.wikimedia.org/r/533765 [20:35:48] Vulpix: u ok hun? [20:35:57] (03Merged) 10jenkins-bot: Fix typo (availabe -> available) [extensions/Farmer] - 10https://gerrit.wikimedia.org/r/532826 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [20:35:59] (03Merged) 10jenkins-bot: Fix typo (availabe -> available) [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/532825 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [20:36:52] Reedy: Yes, just doing some develompent work, and this is a handy way to get to the documentation until T218233 is fixed [20:36:53] T218233: Doxygen search.php no longer works on doc.wikimedia.org - https://phabricator.wikimedia.org/T218233 [20:37:11] Manipulate the URL when you know the class name? ;) [20:37:26] 10Wiki-Loves-Monuments (2019): Switch Portugal to Wikidata at the Monuments Database - https://phabricator.wikimedia.org/T231727 (10Darwinius) Thanks, the sparql query seems to be OK. id-template: MonumentIDPortugal (https://commons.wikimedia.org/wiki/Template:MonumentIDPortugal), expects Qid (wikidata) Base ca... [20:39:44] (03CR) 10DannyS712: "Recheck" [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/530990 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [20:40:39] (03CR) 10Zoranzoki21: [C: 03+1] "> Check the full build output, and expand sections as needed to find" [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/530990 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [20:40:56] 10Gerrit-Privilege-Requests: +2 in mediawiki/* for Zoranzoki21 - https://phabricator.wikimedia.org/T231758 (10Krinkle) [20:41:07] 04(no projects): displays during preprocessing - https://phabricator.wikimedia.org/T231377 (10Aklapper) 05Open→03Stalled @Force_majeure: What to see where, and what do you expect to happen instead? I don't see any image on the links above: {F30191570} If these are not the steps to reproduce, t... [20:41:10] (03CR) 10DannyS712: "The error comes from:" [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/530990 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [20:41:29] (03CR) 10jerkins-bot: [V: 04-1] Fix typos in code (paramters -> parameters) [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/530990 (https://phabricator.wikimedia.org/T201491) (owner: 10DannyS712) [20:43:09] (03CR) 10Krinkle: "The idea of having interface for Parser seems fine, although I don't see a clear problem that it is meant to solve? What is currently hard" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/531314 (owner: 10D3r1ck01) [20:43:24] (03PS2) 10Tchanders: Allow CompositeBlock::appliesToRight to return null when unsure [core] - 10https://gerrit.wikimedia.org/r/533575 (https://phabricator.wikimedia.org/T229417) [20:43:57] (03CR) 10Krinkle: "Test case: AFPDataTest" [core] - 10https://gerrit.wikimedia.org/r/533765 (owner: 10Krinkle) [20:45:07] 10TechCom, 10TechCom-RFC: RFC Process: 2019 amendments - https://phabricator.wikimedia.org/T216308 (10RhinosF1) [20:45:19] (03CR) 10Tchanders: Allow CompositeBlock::appliesToRight to return null when unsure (033 comments) [core] - 10https://gerrit.wikimedia.org/r/533575 (https://phabricator.wikimedia.org/T229417) (owner: 10Tchanders) [20:45:58] 10WMEE (This week): WIKINEM plaanid paika - https://phabricator.wikimedia.org/T231723 (10kruusamagi) Last meeting: Ivo + Märt (August 31) Situation update: * Looking for participants from Estonia (original thoughts are written down and now contacting people to confirm). * Getting ready to announce the start of... [20:46:19] (03CR) 10Krinkle: [C: 04-1] "The core patch is possibly failing due to this adding a failure, not uncovering an existing one:" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533757 (owner: 10Kosta Harlan) [20:46:50] (03CR) 10jerkins-bot: [V: 04-1] WIP: MediaWikiIntegrationTestCase [core] - 10https://gerrit.wikimedia.org/r/533765 (owner: 10Krinkle) [20:52:06] 04(no projects): Mulformed password in Forgot Password - https://phabricator.wikimedia.org/T231329 (10Aklapper) 05Open→03Stalled Hi @Abhijit2019, thanks for taking the time to report this and welcome to Wikimedia Phabricator! What makes you think that the password is "malformed" exactly? Please see https:... [20:55:06] (03CR) 10jerkins-bot: [V: 04-1] WIP: MediaWikiIntegrationTestCase [core] - 10https://gerrit.wikimedia.org/r/533765 (owner: 10Krinkle) [20:55:08] (03CR) 10jerkins-bot: [V: 04-1] WIP: MediaWikiIntegrationTestCase [core] - 10https://gerrit.wikimedia.org/r/533765 (owner: 10Krinkle) [20:57:59] (03CR) 10Krinkle: "@Legoktm: Do you mean there is no use case at all for using a LinkRenderer on index.php without the user's sub threshold applying? Here's " [core] - 10https://gerrit.wikimedia.org/r/533238 (owner: 10Krinkle) [21:00:38] (03CR) 10Mooeypoo: [C: 03+2] Allow CompositeBlock::appliesToRight to return null when unsure [core] - 10https://gerrit.wikimedia.org/r/533575 (https://phabricator.wikimedia.org/T229417) (owner: 10Tchanders) [21:03:45] (03PS3) 10Krinkle: WIP: MediaWikiIntegrationTestCase [core] - 10https://gerrit.wikimedia.org/r/533765 [21:09:46] (03CR) 10Krinkle: "File "/LocalSettings.php" could not be found. Test case AFPDataTest extends MediaWikiIntegrationTestCase which requires a working MediaWik" [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [21:11:20] (03PS22) 10Krinkle: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) [21:13:44] (03CR) 10jerkins-bot: [V: 04-1] WIP: MediaWikiIntegrationTestCase [core] - 10https://gerrit.wikimedia.org/r/533765 (owner: 10Krinkle) [21:15:03] (03CR) 10jerkins-bot: [V: 04-1] WIP: MediaWikiIntegrationTestCase [core] - 10https://gerrit.wikimedia.org/r/533765 (owner: 10Krinkle) [21:19:08] 04(no projects): Feature request: Gadget to hide imperial units - https://phabricator.wikimedia.org/T231759 (10Reedy) [21:19:18] (03CR) 10jerkins-bot: [V: 04-1] WIP: MediaWikiIntegrationTestCase [core] - 10https://gerrit.wikimedia.org/r/533765 (owner: 10Krinkle) [21:20:23] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [21:21:13] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [21:21:50] (03PS1) 10Pikne: Correct special page alias for Estonian [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/533766 [21:22:58] (03CR) 10Krinkle: "check php" [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [21:25:21] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [21:26:13] (03PS2) 10Pikne: Correct special page alias for Estonian [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/533766 [21:27:55] (03PS1) 10Krinkle: WIP: Switch LanguagesHelperTest back to IntegrationTestCase [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533767 [21:28:21] (03PS23) 10Krinkle: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) [21:29:06] (03PS4) 10Krinkle: phpunit: Add more info to LocalSettings.php error in MediaWikiIntegrationTestCase [core] - 10https://gerrit.wikimedia.org/r/533765 [21:29:24] (03CR) 10Krinkle: "check php" [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [21:30:31] (03Merged) 10jenkins-bot: Allow CompositeBlock::appliesToRight to return null when unsure [core] - 10https://gerrit.wikimedia.org/r/533575 (https://phabricator.wikimedia.org/T229417) (owner: 10Tchanders) [21:31:52] (03PS1) 10DannyS712: Rename `blog` key to avoid conflict with BlueSpiceBlog [extensions/BlueSpiceSocialBlog] - 10https://gerrit.wikimedia.org/r/533768 (https://phabricator.wikimedia.org/T231722) [21:32:47] (03CR) 10Krinkle: "Or maybe avoid the double-purpose method and give the method a different name? getLocalFile for example. We could go deeper and find out w" [core] - 10https://gerrit.wikimedia.org/r/533355 (owner: 10Aaron Schulz) [21:33:50] (03CR) 10Krinkle: [C: 04-1] "afaik it is meant to return $len?" [core] - 10https://gerrit.wikimedia.org/r/533753 (owner: 10Aaron Schulz) [21:34:12] (03PS2) 10DannyS712: Remove `blog` message, conflicts with BlueSpiceBlog and appears to be unused. [extensions/BlueSpiceSocialBlog] - 10https://gerrit.wikimedia.org/r/533768 (https://phabricator.wikimedia.org/T231722) [21:35:57] (03CR) 10Krinkle: "Have any other return values been changed on purpose?" [core] - 10https://gerrit.wikimedia.org/r/533622 (owner: 10Aaron Schulz) [21:38:15] 10MediaWiki-History-and-Diffs, 10MediaWiki-Page-editing: Click on red link opens VisualEditor instead of default WikiEditor - https://phabricator.wikimedia.org/T231364 (10Aklapper) What are your settings on https://sr.wikipedia.org/wiki/Посебно:Подешавања#mw-prefsection-betafeatures ? For me both `Visual editi... [21:39:02] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [21:39:18] (03PS3) 10DannyS712: Rename `blog` special page, message conflicts with BlueSpiceBlog [extensions/BlueSpiceSocialBlog] - 10https://gerrit.wikimedia.org/r/533768 (https://phabricator.wikimedia.org/T231722) [21:40:16] (03CR) 10Krinkle: Unsuppress another phan issue (part 7) (032 comments) [core] - 10https://gerrit.wikimedia.org/r/533703 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [21:40:44] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [21:41:24] (03PS2) 10Krinkle: WIP: Switch LanguagesHelperTest back to IntegrationTestCase [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533767 [21:41:31] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [21:41:33] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [21:42:02] (03CR) 10Krinkle: "recheck" [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [21:42:10] (03PS24) 10Krinkle: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) [21:42:14] (03CR) 10Krinkle: "check php" [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [21:42:47] (03CR) 10jerkins-bot: [V: 04-1] Rename `blog` special page, message conflicts with BlueSpiceBlog [extensions/BlueSpiceSocialBlog] - 10https://gerrit.wikimedia.org/r/533768 (https://phabricator.wikimedia.org/T231722) (owner: 10DannyS712) [21:43:13] 10MediaWiki-History-and-Diffs, 10MediaWiki-Page-editing: Click on red link opens VisualEditor instead of default WikiEditor - https://phabricator.wikimedia.org/T231364 (10Zoranzoki21) New wikitext mode is switched off for me, Visual editing is enabled. [21:44:26] (03PS4) 10DannyS712: Rename `blog` special page, message conflicts with BlueSpiceBlog [extensions/BlueSpiceSocialBlog] - 10https://gerrit.wikimedia.org/r/533768 (https://phabricator.wikimedia.org/T231722) [21:46:30] 10MediaWiki-File-management, 10Commons, 10Multimedia: Provide practical thumbnail URL - https://phabricator.wikimedia.org/T231454 (10simon04) [21:46:45] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10Operations, and 10 others: Define an official thumb API - https://phabricator.wikimedia.org/T66214 (10simon04) [21:47:05] (03CR) 10jenkins-bot: Allow CompositeBlock::appliesToRight to return null when unsure [core] - 10https://gerrit.wikimedia.org/r/533575 (https://phabricator.wikimedia.org/T229417) (owner: 10Tchanders) [21:47:08] (03CR) 10jerkins-bot: [V: 04-1] Rename `blog` special page, message conflicts with BlueSpiceBlog [extensions/BlueSpiceSocialBlog] - 10https://gerrit.wikimedia.org/r/533768 (https://phabricator.wikimedia.org/T231722) (owner: 10DannyS712) [21:51:15] (03CR) 10Krinkle: [C: 04-1] "Q" [core] - 10https://gerrit.wikimedia.org/r/524956 (owner: 10Aaron Schulz) [21:51:48] (03Abandoned) 10DannyS712: Rename `blog` special page, message conflicts with BlueSpiceBlog [extensions/BlueSpiceSocialBlog] - 10https://gerrit.wikimedia.org/r/533768 (https://phabricator.wikimedia.org/T231722) (owner: 10DannyS712) [21:52:14] 10BlueSpice, 10I18n: Message key "blog" exists twice: BlueSpiceBlog and BlueSpiceSocialBlog - https://phabricator.wikimedia.org/T231722 (10DannyS712) a:05DannyS712→03None [21:52:16] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [21:52:35] (03CR) 10Krinkle: [C: 03+2] filebackend: improve FileBackendMultiWrite consistencyCheck()/resyncFiles() [core] - 10https://gerrit.wikimedia.org/r/533143 (https://phabricator.wikimedia.org/T231086) (owner: 10Aaron Schulz) [21:54:25] (03CR) 10Krinkle: Clean up DeferredUpdates transactions and push failed updates as jobs (031 comment) [core] - 10https://gerrit.wikimedia.org/r/522234 (https://phabricator.wikimedia.org/T206283) (owner: 10Aaron Schulz) [21:55:29] (03PS7) 10Krinkle: objectcache: add "sessionConsistencyWindow" option to ReplicatedBagOStuff [core] - 10https://gerrit.wikimedia.org/r/524659 (owner: 10Aaron Schulz) [21:55:38] (03CR) 10Krinkle: [C: 03+2] objectcache: add "sessionConsistencyWindow" option to ReplicatedBagOStuff [core] - 10https://gerrit.wikimedia.org/r/524659 (owner: 10Aaron Schulz) [21:55:49] (03PS4) 10Krinkle: rdbms: clean up use of ATTACH queries in DatabaseSqlite [core] - 10https://gerrit.wikimedia.org/r/532435 (owner: 10Aaron Schulz) [21:56:03] (03CR) 10Krinkle: [C: 03+2] rdbms: clean up use of ATTACH queries in DatabaseSqlite [core] - 10https://gerrit.wikimedia.org/r/532435 (owner: 10Aaron Schulz) [21:57:17] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [21:58:29] (03PS3) 10Krinkle: WIP: Switch LanguagesHelperTest back to IntegrationTestCase [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533767 [21:58:39] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [21:58:41] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [21:59:03] (03CR) 10Krinkle: "recheck" [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [22:06:18] (03CR) 10MJL: [V: 03+2 C: 03+2] "My apologies.." [extensions/SoftRedirector] (REL1_34) - 10https://gerrit.wikimedia.org/r/532274 (owner: 10Paladox) [22:13:11] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [22:15:53] 10MediaWiki-Parser: Incorrectly located line break after a minus sign - https://phabricator.wikimedia.org/T230623 (10Michael_Hardy) [22:15:57] (03CR) 10Krinkle: "I guess one or more globals is going missing after the unit tests complete. At least on HHVM." [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [22:16:48] (03Merged) 10jenkins-bot: filebackend: improve FileBackendMultiWrite consistencyCheck()/resyncFiles() [core] - 10https://gerrit.wikimedia.org/r/533143 (https://phabricator.wikimedia.org/T231086) (owner: 10Aaron Schulz) [22:20:07] (03Merged) 10jenkins-bot: objectcache: add "sessionConsistencyWindow" option to ReplicatedBagOStuff [core] - 10https://gerrit.wikimedia.org/r/524659 (owner: 10Aaron Schulz) [22:20:49] (03CR) 10Krinkle: [C: 03+2] Avoid multiply calls to MediaWikiServices::getInstance() in one function [core] - 10https://gerrit.wikimedia.org/r/530961 (owner: 10Umherirrender) [22:23:17] 10MediaWiki-Parser: Incorrectly located line break after a minus sign - https://phabricator.wikimedia.org/T230623 (10Michael_Hardy) 05Declined→03Open [22:23:24] (03CR) 10Krinkle: Unset globals correctly for unit tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533227 (owner: 10simetrical) [22:26:03] (03CR) 10jerkins-bot: [V: 04-1] WIP: Switch LanguagesHelperTest back to IntegrationTestCase [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533767 (owner: 10Krinkle) [22:31:13] (03Merged) 10jenkins-bot: rdbms: clean up use of ATTACH queries in DatabaseSqlite [core] - 10https://gerrit.wikimedia.org/r/532435 (owner: 10Aaron Schulz) [22:31:36] (03CR) 10jenkins-bot: filebackend: improve FileBackendMultiWrite consistencyCheck()/resyncFiles() [core] - 10https://gerrit.wikimedia.org/r/533143 (https://phabricator.wikimedia.org/T231086) (owner: 10Aaron Schulz) [22:33:55] 10CirrusSearch, 10Discovery-Search: intitle search is incorrect and/or missing redirecttitle. - https://phabricator.wikimedia.org/T231764 (10Falsifian) [22:43:11] (03Merged) 10jenkins-bot: Avoid multiply calls to MediaWikiServices::getInstance() in one function [core] - 10https://gerrit.wikimedia.org/r/530961 (owner: 10Umherirrender) [22:46:02] (03CR) 10jenkins-bot: objectcache: add "sessionConsistencyWindow" option to ReplicatedBagOStuff [core] - 10https://gerrit.wikimedia.org/r/524659 (owner: 10Aaron Schulz) [22:46:23] (03PS4) 10Krinkle: WIP: Switch LanguagesHelperTest back to IntegrationTestCase [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533767 [22:47:08] (03PS25) 10Krinkle: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) [22:55:17] (03PS1) 10Krinkle: WIP: Track globals removed in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/533769 [22:57:30] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [22:57:43] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [23:00:09] (03CR) 10jenkins-bot: rdbms: clean up use of ATTACH queries in DatabaseSqlite [core] - 10https://gerrit.wikimedia.org/r/532435 (owner: 10Aaron Schulz) [23:00:20] (03CR) 10jerkins-bot: [V: 04-1] WIP: Track globals removed in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/533769 (owner: 10Krinkle) [23:01:03] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [23:05:13] (03PS2) 10Krinkle: WIP: Track globals removed in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/533769 [23:05:55] (03CR) 10Krinkle: [C: 03+2] "Dejavu" [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/512499 (https://phabricator.wikimedia.org/T224353) (owner: 10Reedy) [23:07:21] (03CR) 10Krinkle: [C: 03+2] objectcache: avoid using deprecated phpredis::delete() alias [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/533714 (https://phabricator.wikimedia.org/T227461) (owner: 10Paladox) [23:08:34] (03Merged) 10jenkins-bot: Use the correct object in onSpecialSearchSetupEngine [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/512499 (https://phabricator.wikimedia.org/T224353) (owner: 10Reedy) [23:09:07] 10MediaWiki-History-and-Diffs, 10MediaWiki-Page-editing: Click on red link opens VisualEditor instead of default WikiEditor - https://phabricator.wikimedia.org/T231364 (10Aklapper) Does this happen with all red links? Any pattern? [23:09:30] (03PS2) 10Krinkle: Reset $wgContLang consistently for tests [core] - 10https://gerrit.wikimedia.org/r/533729 (owner: 10simetrical) [23:09:33] (03CR) 10Krinkle: [C: 03+2] Reset $wgContLang consistently for tests [core] - 10https://gerrit.wikimedia.org/r/533729 (owner: 10simetrical) [23:10:40] (03CR) 10Krinkle: [C: 04-1] "Per Daimona" [core] - 10https://gerrit.wikimedia.org/r/533355 (owner: 10Aaron Schulz) [23:12:28] (03CR) 10Krinkle: [C: 03+1] "Code LGTM. What's the test plan?" [core] - 10https://gerrit.wikimedia.org/r/531805 (owner: 10Aaron Schulz) [23:12:59] (03CR) 10Krinkle: [C: 04-1] "Q" [core] - 10https://gerrit.wikimedia.org/r/523486 (owner: 10Aaron Schulz) [23:13:31] (03CR) 10Krinkle: [C: 03+1] objectcache: create a ProcessCachedKeyValueStore class analogous to CachedBagOStuff [core] - 10https://gerrit.wikimedia.org/r/531770 (owner: 10Aaron Schulz) [23:14:05] (03CR) 10jenkins-bot: Avoid multiply calls to MediaWikiServices::getInstance() in one function [core] - 10https://gerrit.wikimedia.org/r/530961 (owner: 10Umherirrender) [23:16:01] (03CR) 10Krinkle: Let Title accept READ_LATEST in $flags fields of methods (031 comment) [core] - 10https://gerrit.wikimedia.org/r/520817 (owner: 10Aaron Schulz) [23:16:03] (03CR) 10jerkins-bot: [V: 04-1] WIP: Track globals removed in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/533769 (owner: 10Krinkle) [23:16:49] (03CR) 10Krinkle: "Per previous PS, not obvious to me what it is solving. seems fine but missing some context I think." [core] - 10https://gerrit.wikimedia.org/r/520817 (owner: 10Aaron Schulz) [23:18:25] (03Merged) 10jenkins-bot: objectcache: avoid using deprecated phpredis::delete() alias [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/533714 (https://phabricator.wikimedia.org/T227461) (owner: 10Paladox) [23:19:47] 10Browser-Support-Google-Chrome, 10Upstream: Incorrectly located line break after a minus sign - https://phabricator.wikimedia.org/T230623 (10Aklapper) 05Open→03Invalid Thanks. Still cannot reproduce in Firefox 68 on https://en.wikipedia.org/w/index.php?title=Bailout_embedding&diff=911126129&oldid=91096628... [23:20:23] (03CR) 10Krinkle: Add small HtmlCacheUpdater service class to normalize purging code (031 comment) [core] - 10https://gerrit.wikimedia.org/r/528924 (https://phabricator.wikimedia.org/T230025) (owner: 10Aaron Schulz) [23:20:47] (03CR) 10jerkins-bot: [V: 04-1] WIP: Track globals removed in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/533769 (owner: 10Krinkle) [23:22:32] 04(no projects): displays during preprocessing - https://phabricator.wikimedia.org/T231377 (10Force_majeure) In both cases, the star at the top right should not be displayed, but it does. [23:24:13] (03CR) 10Krinkle: Add small HtmlCacheUpdater service class to normalize purging code (031 comment) [core] - 10https://gerrit.wikimedia.org/r/528924 (https://phabricator.wikimedia.org/T230025) (owner: 10Aaron Schulz) [23:26:00] 10ISA: Force correct WikiLoves category syntax - https://phabricator.wikimedia.org/T231302 (10NavinoEvans) [23:27:20] (03PS2) 10Krinkle: Remove Oracle reference from WikiMap [core] - 10https://gerrit.wikimedia.org/r/530359 (https://phabricator.wikimedia.org/T230418) (owner: 10Aaron Schulz) [23:27:31] (03PS3) 10Krinkle: Remove Oracle reference from WikiMap [core] - 10https://gerrit.wikimedia.org/r/530359 (https://phabricator.wikimedia.org/T230418) (owner: 10Aaron Schulz) [23:27:35] (03CR) 10Krinkle: [C: 03+2] Remove Oracle reference from WikiMap [core] - 10https://gerrit.wikimedia.org/r/530359 (https://phabricator.wikimedia.org/T230418) (owner: 10Aaron Schulz) [23:32:13] (03Merged) 10jenkins-bot: Reset $wgContLang consistently for tests [core] - 10https://gerrit.wikimedia.org/r/533729 (owner: 10simetrical) [23:34:44] (03CR) 10jenkins-bot: objectcache: avoid using deprecated phpredis::delete() alias [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/533714 (https://phabricator.wikimedia.org/T227461) (owner: 10Paladox) [23:51:59] (03CR) 10jenkins-bot: Reset $wgContLang consistently for tests [core] - 10https://gerrit.wikimedia.org/r/533729 (owner: 10simetrical) [23:58:15] (03Merged) 10jenkins-bot: Remove Oracle reference from WikiMap [core] - 10https://gerrit.wikimedia.org/r/530359 (https://phabricator.wikimedia.org/T230418) (owner: 10Aaron Schulz)