[00:01:08] 10GrowthExperiments-Homepage, 10GrowthExperiments-StartModule, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Mobile: Homepage: mobile submodule headers - https://phabricator.wikimedia.org/T225667 (10MMiller_WMF) @Etonkovidova -- I'm confused about this. Did you notice th... [00:03:54] (03PS2) 10Catrope: Move SchemaRevisions and BaseUri config vars to packageFiles [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/533560 [00:04:31] (03Merged) 10jenkins-bot: Fix version [extensions/BlueSpiceSocialMicroBlog] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533617 (owner: 10Pwirth) [00:08:03] 10CPT Initiatives (MCR Schema Migration), 10Multi-Content-Revisions (Deployment): Set testwiki to use the new MCR-only schema - https://phabricator.wikimedia.org/T198558 (10CCicalese_WMF) [00:09:08] 10Machine vision, 10Structured-Data-Backlog: Implement features that allow for tracking and measuring machine-aided depicts usage/activity - https://phabricator.wikimedia.org/T231032 (10Ramsey-WMF) [00:09:58] 10Structured Data Engineering, 10Structured-Data-Backlog, 10CPT Initiatives (MCR Schema Migration), 10Multi-Content-Revisions (Deployment): Set the WMF cluster to use the new MCR-only schema - https://phabricator.wikimedia.org/T198312 (10CCicalese_WMF) [00:10:19] (03CR) 10jerkins-bot: [V: 04-1] Assign flow-suppress to the suppress group and oversight grant [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533588 (https://phabricator.wikimedia.org/T231694) (owner: 10JJMC89) [00:10:23] (03CR) 10jerkins-bot: [V: 04-1] Move SchemaRevisions and BaseUri config vars to packageFiles [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/533560 (owner: 10Catrope) [00:10:50] 10ISA, 10Patch-For-Review: Non latin script in any campaign text breaks campaign page - https://phabricator.wikimedia.org/T231167 (10NavinoEvans) [00:11:13] (03PS1) 10Pwirth: Add phpcs [extensions/BlueSpiceSocialMicroBlog] - 10https://gerrit.wikimedia.org/r/533619 [00:22:54] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar): [SPIKE] Investigate login issues - https://phabricator.wikimedia.org/T231587 (10cooltey) Note: sent a beta APK with new RxJava login logic to users who have login token issue. [00:27:23] 10Android-app-Bugs, 10Android-app-feature-Multilingual, 10Wikipedia-Android-App-Backlog, 10Chinese-Sites, 10Patch-For-Review: [BUG] Incorrect variant issues on Tab title - https://phabricator.wikimedia.org/T178201 (10cooltey) [00:28:14] 10GrowthExperiments-Homepage: Opening mentorship module on mobile throws JS error if it lists a question that's more than 30 days old - https://phabricator.wikimedia.org/T231701 (10Catrope) [00:32:52] 10Android-app-Bugs, 10Android-app-feature-Multilingual, 10Wikipedia-Android-App-Backlog, 10Chinese-Sites, 10WorkType-Maintenance: Selecting Chinese (either variant) from the "Other languages" menu in non-main namespace pages gives wrong names and leads to an erro... - https://phabricator.wikimedia.org/T115266 [00:35:27] 10Android-app-Bugs, 10Android-app-feature-Multilingual, 10Wikipedia-Android-App-Backlog, 10Chinese-Sites, 10WorkType-Maintenance: Selecting Chinese (either variant) from the "Other languages" menu in non-main namespace pages gives wrong names and leads to an erro... - https://phabricator.wikimedia.org/T115266 [00:35:50] 10Android-app-Bugs, 10Android-app-feature-Multilingual, 10Chinese-Sites, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar), 10WorkType-Maintenance: Selecting Chinese (either variant) from the "Other languages" menu in non-main namespace... - https://phabricator.wikimedia.org/T115266 [00:39:20] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (User Stories), 10Story: A warning is emitted if any pre-MCR fields are accessed - https://phabricator.wikimedia.org/T231699 (10CCicalese_WMF) p:05Triage→03Normal [00:42:40] (03PS3) 10Krinkle: Move SchemaRevisions and BaseUri config vars to packageFiles [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/533560 (owner: 10Catrope) [00:42:48] (03CR) 10Krinkle: "merged vars" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/533560 (owner: 10Catrope) [00:48:45] (03CR) 10jerkins-bot: [V: 04-1] Move SchemaRevisions and BaseUri config vars to packageFiles [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/533560 (owner: 10Catrope) [00:51:31] (03CR) 10Krinkle: [C: 03+1] ChangesListSpecialPage: Cache the change tag list and its summary (031 comment) [core] - 10https://gerrit.wikimedia.org/r/525882 (https://phabricator.wikimedia.org/T223260) (owner: 10Catrope) [01:09:28] 10MediaWiki-General, 10Documentation, 10Privacy: VisualEditor at doc.wikimedia.org loads fonts from google - https://phabricator.wikimedia.org/T214361 (10Rxy) [01:11:15] 10MediaWiki-General, 10Documentation, 10Privacy: VisualEditor at doc.wikimedia.org loads fonts from google - https://phabricator.wikimedia.org/T214361 (10Rxy) [01:12:54] 10MediaWiki-General, 10Documentation, 10Privacy: VisualEditor at doc.wikimedia.org loads fonts from google - https://phabricator.wikimedia.org/T214361 (10Rxy) [01:12:57] 10MediaWiki-Documentation, 10Privacy, 10Upstream: JSDuck at doc.wikimedia.org loads fonts from google - https://phabricator.wikimedia.org/T213282 (10Rxy) [02:13:42] 10MediaWiki-General, 10MediaWiki-extensions-SubpageSortkey, 10User-DannyS712: Magic word to suppress breadcrumb links in subpages - https://phabricator.wikimedia.org/T231692 (10DannyS712) a:03DannyS712 @John_M_Wolfson am I understand this to be: * **If** a page is tagged as `__NOBREADCRUMBS__` * **then** a... [02:21:55] 10MediaWiki-extension-requests: Suggestion: Modify and Deploy RC Patrol extension from wikiHow onto Wikimedia projects. - https://phabricator.wikimedia.org/T192719 (10UpsandDowns1234) @Aklapper wikiHow just upgraded to MediaWiki 1.33: https://forums.wikihow.com/discussion/28385/mediawiki-upgrade-coming-today-t... [02:41:38] 10MediaWiki-extension-requests: Suggestion: Modify and Deploy RC Patrol extension from wikiHow onto Wikimedia projects. - https://phabricator.wikimedia.org/T192719 (10ashley) Most wikiHow things, or dare I say //all// of them, are //not// 1:1 portable to vanilla MW as-is and have been designed with the wikiHow... [03:09:52] (03CR) 10Mooeypoo: [C: 03+2] Use DatabaseBlock instead of deprecated Block in CompositeBlock tests [core] - 10https://gerrit.wikimedia.org/r/533574 (owner: 10Tchanders) [03:34:06] (03Merged) 10jenkins-bot: Use DatabaseBlock instead of deprecated Block in CompositeBlock tests [core] - 10https://gerrit.wikimedia.org/r/533574 (owner: 10Tchanders) [03:42:52] 10MediaWiki-General, 10MediaWiki-extensions-SubpageSortkey, 10User-DannyS712: Magic word to suppress breadcrumb links in subpages - https://phabricator.wikimedia.org/T231692 (10John_M_Wolfson) @DannyS712 Yes, that would be correct. Make it as global as possible, across skins and wikis, etc., but that's the g... [03:46:26] 10MediaWiki-General, 10MediaWiki-extensions-SubpageSortkey, 10User-DannyS712: Magic word to suppress breadcrumb links in subpages - https://phabricator.wikimedia.org/T231692 (10DannyS712) >>! In T231692#5455720, @John_M_Wolfson wrote: > @DannyS712 Yes, that would be correct. Make it as global as possible, ac... [03:55:22] (03CR) 10jenkins-bot: Use DatabaseBlock instead of deprecated Block in CompositeBlock tests [core] - 10https://gerrit.wikimedia.org/r/533574 (owner: 10Tchanders) [04:12:44] (03CR) 10Jack Phoenix: [C: 03+2] Add a min-height to thumbcaptions so magnify icon doesn't overflow [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533555 (owner: 10Isarra) [04:13:12] (03CR) 10Jack Phoenix: [C: 03+2] "Huh, okay." [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533565 (owner: 10Isarra) [04:18:19] (03Merged) 10jenkins-bot: Add a min-height to thumbcaptions so magnify icon doesn't overflow [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533555 (owner: 10Isarra) [04:18:35] (03Merged) 10jenkins-bot: Better padding for new messages yellow [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533565 (owner: 10Isarra) [04:35:00] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: CentralNotice: Timeout when creating translation variables Translate Extension - https://phabricator.wikimedia.org/T231703 (10Jseddon) [04:35:18] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: CentralNotice: Timeout when creating translation variables Translate Extension - https://phabricator.wikimedia.org/T231703 (10Jseddon) [04:45:06] 10Design, 10OOUI, 10Patch-For-Review: Chemistry beaker icon should have open top - https://phabricator.wikimedia.org/T226168 (10DMacks) As far as terminology, "conical flask" is sometimes used as a synonym for "Erlenmeyer flask". But a flask (of which these are other shapes also) and a beaker are totally dif... [05:01:30] 10MediaWiki-extensions-Translate: Improving the new validator framework - https://phabricator.wikimedia.org/T231704 (10abi_) [05:11:18] 10MediaWiki-extensions-Translate: Limit validation to certain messages - https://phabricator.wikimedia.org/T231705 (10abi_) [05:11:33] 10MediaWiki-extensions-Translate: Limit validation to certain messages - https://phabricator.wikimedia.org/T231705 (10abi_) [05:11:37] 10MediaWiki-extensions-Translate, 10translatewiki.net, 10Language-Team (Language-2019-July-September), 10Patch-For-Review, 10User-abi_: Migrate a few projects to the new Validator framework - https://phabricator.wikimedia.org/T224025 (10abi_) [05:12:13] 10MediaWiki-extensions-Translate: Limit validation to certain messages - https://phabricator.wikimedia.org/T231705 (10abi_) [05:12:18] 10MediaWiki-extensions-Translate, 10translatewiki.net, 10Language-Team (Language-2019-July-September), 10Patch-For-Review, 10User-abi_: Migrate a few projects to the new Validator framework - https://phabricator.wikimedia.org/T224025 (10abi_) [05:15:41] 10MediaWiki-extensions-Translate: Allow validators to specify a function to autofix the validation errors - https://phabricator.wikimedia.org/T231706 (10abi_) [05:16:46] 10MediaWiki-extensions-Translate: Limit validation to certain messages - https://phabricator.wikimedia.org/T231705 (10abi_) [05:20:53] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2019-July-September): Add new validator to validate existence of newlines in source and translation - https://phabricator.wikimedia.org/T231707 (10abi_) [05:28:04] 10MediaWiki-General, 10MediaWiki-extensions-SubpageSortkey, 10User-DannyS712: Magic word to suppress breadcrumb links in subpages - https://phabricator.wikimedia.org/T231692 (10John_M_Wolfson) Yes, you may. Sorry about that, I'm fairly new here. [05:28:38] 10MediaWiki-extensions-Translate, 10translatewiki.net, 10Language-Team (Language-2019-July-September), 10Patch-For-Review, 10User-abi_: Migrate a few projects to the new Validator framework - https://phabricator.wikimedia.org/T224025 (10abi_) >>! In T224025#5351478, @Nikerabbit wrote: > While working on... [05:29:30] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2019-July-September): Add new validator to validate existence of newlines in source and translation - https://phabricator.wikimedia.org/T231707 (10abi_) [05:30:01] 10MediaWiki-General, 10MediaWiki-Parser, 10Core Platform Team, 10User-DannyS712: Magic word to suppress breadcrumb links in subpages - https://phabricator.wikimedia.org/T231692 (10DannyS712) [05:30:25] 10MediaWiki-General, 10MediaWiki-Parser, 10Core Platform Team, 10User-DannyS712: Magic word to suppress breadcrumb links in subpages - https://phabricator.wikimedia.org/T231692 (10DannyS712) [05:30:35] 10MediaWiki-General, 10MediaWiki-Parser, 10Core Platform Team, 10User-DannyS712: Magic word to suppress breadcrumb links in subpages - https://phabricator.wikimedia.org/T231692 (10DannyS712) p:05Triage→03Low [05:34:33] 10MediaWiki-General, 10MediaWiki-Parser, 10Core Platform Team, 10User-DannyS712: Magic word to suppress breadcrumb links in subpages - https://phabricator.wikimedia.org/T231692 (10DannyS712) [05:34:55] 10MediaWiki-General, 10MediaWiki-Parser, 10Core Platform Team, 10User-DannyS712: Magic word to suppress breadcrumb links in subpages - https://phabricator.wikimedia.org/T231692 (10DannyS712) [05:44:04] 10Wikidata-Bridge-Sprint-4, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03): Selenium tests will fail on gate&submit - https://phabricator.wikimedia.org/T231074 (10Pablo-WMDE) 05Open→03Resolved [06:07:06] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Community-consensus-needed: Add monolingual language code tnq (Taíno) and car (Kalinago) - https://phabricator.wikimedia.org/T220284 (10Mbch331) @jhsoby Maybe @MassiveEartha can tell more? That user requested the languages. [06:07:27] (03PS1) 10Aaron Schulz: filebackend: improve internal use of FileBackend constants [core] - 10https://gerrit.wikimedia.org/r/533622 [07:10:03] 10UniversalLanguageSelector: Innu language displays "Undefined" as tooltip in ULS - https://phabricator.wikimedia.org/T231695 (10Nikerabbit) The suggested languages section sometimes gives languages that it shouldn't. That's {T216342} [07:28:00] 10WMEE: Võistkondlik 24h artiklivõistlus - https://phabricator.wikimedia.org/T231202 (10Lmk2K18) [07:48:15] 10Lingua Libre: Add an option not to record words already recorded by any other contributor - https://phabricator.wikimedia.org/T231559 (100x010C) Technically speaking, this can be easily implemented since T212580. But we must first think about how to integrate this option to the UI without overloading it. [08:09:03] (03CR) 10Mooeypoo: [C: 04-1] "Makes sense, but I think we should add one more test (and clarify a comment)" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/533575 (https://phabricator.wikimedia.org/T229417) (owner: 10Tchanders) [08:25:57] 10WMEE GLAM Program 2019: Eesti Teatri- ja Muusikamuuseum: palve Raimond Valgre nootide ja käsikirjade saamiseks - https://phabricator.wikimedia.org/T210165 (10reosarevok) Ainult 1 käsikiri on digiteeritud. Me räägime nendega edasi, et vaadata, kas on võimalik see, et teised saaks ka digiteeritud ja jagatud. [08:28:31] 10Core Platform Team Legacy (Watching / External), 10HHVM, 10Patch-For-Review: Drop HHVM support from MediaWiki - https://phabricator.wikimedia.org/T192166 (10Daimona) [08:51:47] (03PS7) 10Ladsgroup: Split LuaEngineTestBase to LuaEngineUnitTestBase and LuaEngineTestBase [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/527854 (https://phabricator.wikimedia.org/T230701) [08:57:09] (03CR) 10Ladsgroup: "> Patch Set 6:" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/527854 (https://phabricator.wikimedia.org/T230701) (owner: 10Ladsgroup) [08:59:11] (03PS5) 10Daimona Eaytoy: Unsuppress other phan issues [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) [08:59:20] (03PS3) 10Daimona Eaytoy: Unsuppress more phan issues [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) [09:03:27] (03PS4) 10Daimona Eaytoy: Unsuppress more phan issues [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) [09:03:35] (03PS2) 10Daimona Eaytoy: [WIP] Unsuppress phan issues part 6 [core] - 10https://gerrit.wikimedia.org/r/533567 (https://phabricator.wikimedia.org/T231636) [09:03:47] (03PS3) 10Daimona Eaytoy: [WIP] Unsuppress phan issues part 6 [core] - 10https://gerrit.wikimedia.org/r/533567 (https://phabricator.wikimedia.org/T231636) [09:06:50] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Unsuppress phan issues part 6 [core] - 10https://gerrit.wikimedia.org/r/533567 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [09:07:13] 10MediaWiki-Special-pages, 10User-DannyS712, 10Wikimedia-production-error: Time out when querying new pages: WMFTimeoutException - https://phabricator.wikimedia.org/T231711 (10DannyS712) [09:09:05] 10WMEE Avalik omand: Avaliku omandi päev 2020 - https://phabricator.wikimedia.org/T229924 (10tramm) [09:09:07] 10WMEE GLAM Program 2019: Eesti Teatri- ja Muusikamuuseum: palve Raimond Valgre nootide ja käsikirjade saamiseks - https://phabricator.wikimedia.org/T210165 (10tramm) [09:10:34] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Unsuppress phan issues part 6 [core] - 10https://gerrit.wikimedia.org/r/533567 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [09:11:13] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Unsuppress phan issues part 6 [core] - 10https://gerrit.wikimedia.org/r/533567 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [09:11:56] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Unsuppress phan issues part 6 [core] - 10https://gerrit.wikimedia.org/r/533567 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [09:25:46] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress more phan issues [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [09:30:24] 10netbox, 10Patch-For-Review: Netbox: move it to dedicated Ganeti VMs - https://phabricator.wikimedia.org/T223291 (10Volans) @crusnov in case you missed my IRC ping yesterday, please re-install the two public ones before proceeding with the installation as they had no firewall (see above hotfix patch). [09:32:00] 10Phabricator: Phabricator: Simplify the multifactor auth reset procedure - https://phabricator.wikimedia.org/T231667 (10Tgr) I'd also suggest to have different rules for high-risk accounts (Phab admins, people in the Security ACL) compared to normal accounts, the stealing of which really isn't much of a problem... [09:49:38] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Archive the ViewFiles extension - https://phabricator.wikimedia.org/T228367 (10D3r1ck01) [09:59:24] (03PS1) 10DannyS712: Rename `AbuseFilterDisallowGlobalLocalBlocks` to `AbuseFilterDisallowGlobalLocalRestricted` [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533624 (https://phabricator.wikimedia.org/T231712) [10:00:35] (03PS2) 10DannyS712: Rename `AbuseFilterDisallowGlobalLocalBlocks` to `AbuseFilterDisallowGlobalLocalRestricted` [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533624 (https://phabricator.wikimedia.org/T231712) [10:07:17] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress more phan issues [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [10:19:44] (03CR) 10Daimona Eaytoy: [C: 04-1] "I'm sorry, but I'd like to do everything together with I7581b3ee6d9d11a6cf1599b8ff874e8c3d54adf4. Renaming globals is annoying, and it sho" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533624 (https://phabricator.wikimedia.org/T231712) (owner: 10DannyS712) [10:36:34] 10MediaWiki-History-and-Diffs, 10MediaWiki-Page-editing: Click on red link opens VisualEditor instead of default WikiEditor - https://phabricator.wikimedia.org/T231364 (10Zoranzoki21) [10:41:05] 10MediaWiki-API, 10MediaWiki-Page-editing, 10Core Platform Team: allow to add section with no heading and custom edit summary - https://phabricator.wikimedia.org/T211540 (10Zoranzoki21) [10:41:09] 10WMEE: Autoriõiguse direktiivist tulenevate muudatuste kirjutamine Eesti seadustesse - https://phabricator.wikimedia.org/T231713 (10tramm) [10:45:51] 10MediaWiki-Page-editing: edit conflict not detected and previus edits erased - https://phabricator.wikimedia.org/T193956 (10Zoranzoki21) 05Open→03Invalid Not reproducable, if you have still this problem, please reopen this task. [10:45:53] 10MediaWiki-Page-editing, 10Community-Wishlist-Survey-2016, 10Tracking-Neverending: Edit conflicts (tracking) - https://phabricator.wikimedia.org/T72163 (10Zoranzoki21) [10:46:30] 10WMEE: OKEE seisukoht teksti- ja andmekaeve teemal - https://phabricator.wikimedia.org/T231714 (10tramm) [10:47:03] 10MediaWiki-Page-editing: edit conflict not detected and previus edits erased - https://phabricator.wikimedia.org/T193956 (10Zoranzoki21) [10:47:05] 10MediaWiki-Page-editing, 10WikiEditor: Edit conflict not shown/detected - https://phabricator.wikimedia.org/T188713 (10Zoranzoki21) [10:54:42] 10MediaWiki-Page-editing: Edit conflict not detected (3 involved persons) - https://phabricator.wikimedia.org/T100912 (10Zoranzoki21) [10:54:45] 10MediaWiki-Page-editing, 10WikiEditor: Edit conflict not shown/detected - https://phabricator.wikimedia.org/T188713 (10Zoranzoki21) [10:54:55] 10MediaWiki-Page-editing, 10Wikimedia-General-or-Unknown: Conflicting edit did not create a conflict - https://phabricator.wikimedia.org/T119985 (10Zoranzoki21) [10:54:58] 10MediaWiki-Page-editing, 10WikiEditor: Edit conflict not shown/detected - https://phabricator.wikimedia.org/T188713 (10Zoranzoki21) [10:55:38] 10WMEE: Miljon+ kohvijoomine - https://phabricator.wikimedia.org/T231715 (10tramm) [11:00:56] 10MediaWiki-Page-editing: Edit Conflict with Myself - https://phabricator.wikimedia.org/T231134 (10Zoranzoki21) [11:00:58] 10MediaWiki-Page-editing, 10Performance: self-conflict when editing huge pages - https://phabricator.wikimedia.org/T59264 (10Zoranzoki21) [11:08:31] 10WMEE: Juhatuse koosolek strateegia täpsustamiseks ja aastaplaani 2020 koostamiseks - https://phabricator.wikimedia.org/T231524 (10tramm) p:05Triage→03Normal [11:12:46] 10WMEE: Eelarve koostamine 2020. aastaks - https://phabricator.wikimedia.org/T231716 (10tramm) [11:14:55] 10WMEE: Eelarve koostamine 2020. aastaks - https://phabricator.wikimedia.org/T231716 (10tramm) [11:14:57] 10WMEE: Eelarve koostamine 2020. aastaks - https://phabricator.wikimedia.org/T231716 (10tramm) [11:14:59] 10WMEE: Juhatuse koosolek strateegia täpsustamiseks ja aastaplaani 2020 koostamiseks - https://phabricator.wikimedia.org/T231524 (10tramm) [11:20:18] (03PS25) 10Zoranzoki21: Add phpcs in Html2Wiki extension and fix errors found by it [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500144 (https://phabricator.wikimedia.org/T219671) [11:20:34] (03PS26) 10Zoranzoki21: Add phpcs in Html2Wiki extension and fix errors found by it [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500144 (https://phabricator.wikimedia.org/T219671) [11:25:21] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2019-July-September), 10Patch-For-Review: Add new validator to validate existence of newlines in source and translation - https://phabricator.wikimedia.org/T231707 (10abi_) Here's what the validation message looks like, {F30177868} Will be adding... [11:25:46] 10MediaWiki-extensions-FlaggedRevs, 10Wikimedia-Site-requests: Last reviewed revision is shown to logged-out users in ukwiki instead of last revision - https://phabricator.wikimedia.org/T227260 (10NickK) @Reedy @Quiddity Is anything being done on this? It has been two months since we raised the issue, and thr... [11:26:36] (03CR) 10Zoranzoki21: [C: 03+1] Change the autonym of Banjar from "Bahasa Banjar" to "Banjar" [core] - 10https://gerrit.wikimedia.org/r/532859 (https://phabricator.wikimedia.org/T231283) (owner: 10Mh-3110) [11:26:41] (03CR) 10Zoranzoki21: [C: 03+1] Change the autonym of Sunda from "Basa Sunda" to "Sunda" [core] - 10https://gerrit.wikimedia.org/r/532864 (https://phabricator.wikimedia.org/T228832) (owner: 10Mh-3110) [11:29:22] 10InternetArchiveBot: www2 link without HTTP/HTTPS not accessible on web interface after being marked as dead by bot - https://phabricator.wikimedia.org/T231717 (10Redalert2fan) [11:30:45] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2019-July-September), 10Patch-For-Review: Add new validator to validate existence of newlines in source and translation - https://phabricator.wikimedia.org/T231707 (10abi_) p:05Triage→03Normal [11:38:18] 10Wiki-Loves-Monuments (2019): WLM Nigeria: Add id support to UploadCampaign - https://phabricator.wikimedia.org/T231643 (10Romaine) I am on this one. [11:39:41] (03PS4) 10Daimona Eaytoy: Unsuppress phan issues part 6 [core] - 10https://gerrit.wikimedia.org/r/533567 (https://phabricator.wikimedia.org/T231636) [11:41:06] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress phan issues part 6 [core] - 10https://gerrit.wikimedia.org/r/533567 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [11:41:27] 10MediaWiki-User-preferences, 10Browser-Support-Internet-Explorer: Options at Appearance tab Preferences shift to right at IE11 - https://phabricator.wikimedia.org/T231718 (10gh87) [11:41:48] 10Editing Design, 10VisualEditor (Current work): Tweak the mockups legal message placement to account for keyboard being up - https://phabricator.wikimedia.org/T229428 (10iamjessklein) Updated the flow here and on Freehand. {F30177898 width= 800} cc/ @ppelberg [11:41:51] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress phan issues part 6 [core] - 10https://gerrit.wikimedia.org/r/533567 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [11:42:31] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress phan issues part 6 [core] - 10https://gerrit.wikimedia.org/r/533567 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [11:43:11] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress phan issues part 6 [core] - 10https://gerrit.wikimedia.org/r/533567 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [11:48:06] (03PS5) 10Daimona Eaytoy: Unsuppress more phan issues [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) [11:48:14] (03PS5) 10Daimona Eaytoy: Unsuppress phan issues part 6 [core] - 10https://gerrit.wikimedia.org/r/533567 (https://phabricator.wikimedia.org/T231636) [11:52:18] (03CR) 10Krinkle: SkinMetrolook: Call parent::__construct in constructor (031 comment) [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/509624 (owner: 10Fomafix) [11:53:06] 10InternetArchiveBot: www2 link without HTTP/HTTPS not accessible on web interface after being marked as dead by bot - https://phabricator.wikimedia.org/T231717 (10Cyberpower678) First off there are no such things as URLs without a schema (HTTP/HTTPS/FTP). The https does not redirect anywhere. As for the actua... [11:57:10] (03PS6) 10Daimona Eaytoy: Unsuppress phan issues part 6 [core] - 10https://gerrit.wikimedia.org/r/533567 (https://phabricator.wikimedia.org/T231636) [11:57:38] (03PS7) 10Daimona Eaytoy: Unsuppress phan issues part 6 [core] - 10https://gerrit.wikimedia.org/r/533567 (https://phabricator.wikimedia.org/T231636) [11:57:58] (03PS7) 10Daimona Eaytoy: Upgrade phan, remove old config settings [tools/phan] - 10https://gerrit.wikimedia.org/r/519740 (https://phabricator.wikimedia.org/T228257) [11:58:13] 10Wiki-Loves-Monuments (2019): WLM Nigeria: Add id support to UploadCampaign - https://phabricator.wikimedia.org/T231643 (10Romaine) Template created: https://commons.wikimedia.org/wiki/Template:Cultural_Heritage_Nigeria Template inserted in upload campaign. [11:58:41] 10Wiki-Loves-Monuments (2019): WLM Nigeria: Add id support to UploadCampaign - https://phabricator.wikimedia.org/T231643 (10Romaine) 05Open→03Resolved a:03Romaine [12:01:00] 10InternetArchiveBot: www2 link without HTTP/HTTPS not accessible on web interface after being marked as dead by bot - https://phabricator.wikimedia.org/T231717 (10Redalert2fan) Thanks for the explanation Using the link worked, its back to alive now. Adding a archive is not possible since the links differ but I... [12:01:15] (03CR) 10jerkins-bot: [V: 04-1] Upgrade phan, remove old config settings [tools/phan] - 10https://gerrit.wikimedia.org/r/519740 (https://phabricator.wikimedia.org/T228257) (owner: 10Daimona Eaytoy) [12:02:39] (03PS2) 10Amire80: Change the autonym of Sunda from "Basa Sunda" to "Sunda" [core] - 10https://gerrit.wikimedia.org/r/532864 (https://phabricator.wikimedia.org/T228832) (owner: 10Mh-3110) [12:02:41] 10LibUp, 10Wikidata-Bridge: Support nested package.json files - https://phabricator.wikimedia.org/T228527 (10Daimona) Uh oh, wrong task. [12:02:49] (03CR) 10Amire80: [C: 03+2] Change the autonym of Sunda from "Basa Sunda" to "Sunda" [core] - 10https://gerrit.wikimedia.org/r/532864 (https://phabricator.wikimedia.org/T228832) (owner: 10Mh-3110) [12:05:43] (03PS3) 10Amire80: Change the autonym of Banjar from "Bahasa Banjar" to "Banjar" [core] - 10https://gerrit.wikimedia.org/r/532859 (https://phabricator.wikimedia.org/T231283) (owner: 10Mh-3110) [12:05:50] (03CR) 10Amire80: [C: 03+2] Change the autonym of Banjar from "Bahasa Banjar" to "Banjar" [core] - 10https://gerrit.wikimedia.org/r/532859 (https://phabricator.wikimedia.org/T231283) (owner: 10Mh-3110) [12:07:06] 10InternetArchiveBot: Link not accessible on web interface after being marked as dead by bot - https://phabricator.wikimedia.org/T231717 (10Redalert2fan) [12:14:28] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress phan issues part 6 [core] - 10https://gerrit.wikimedia.org/r/533567 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [12:17:29] (03PS3) 10Zoranzoki21: Replaced no_catfakecategories hook to OutputPageParserOutput [extensions/NoCat] - 10https://gerrit.wikimedia.org/r/487364 (https://phabricator.wikimedia.org/T203733) [12:20:42] 10WMEE: Wikimedia uus veebileht üles, koguda kasutajate tagasiside ja siis täiendada kuni esialgse rahuloluni - https://phabricator.wikimedia.org/T204043 (10tramm) [12:20:44] 10WMEE: Wikimedia Policy eesti keelde tõlkimine - https://phabricator.wikimedia.org/T209353 (10tramm) [12:25:45] (03Merged) 10jenkins-bot: Change the autonym of Sunda from "Basa Sunda" to "Sunda" [core] - 10https://gerrit.wikimedia.org/r/532864 (https://phabricator.wikimedia.org/T228832) (owner: 10Mh-3110) [12:29:25] (03Merged) 10jenkins-bot: Change the autonym of Banjar from "Bahasa Banjar" to "Banjar" [core] - 10https://gerrit.wikimedia.org/r/532859 (https://phabricator.wikimedia.org/T231283) (owner: 10Mh-3110) [12:35:20] 10Editing Design, 10OWC2020 , 10VisualEditor (Current work): Define what on-wiki-communication research to conduct at Wikimania Stockholm - https://phabricator.wikimedia.org/T228679 (10iamjessklein) 05Open→03Resolved I added the following remaining open questions to the team notes document: - What tasks... [12:41:29] (03CR) 10jenkins-bot: Change the autonym of Sunda from "Basa Sunda" to "Sunda" [core] - 10https://gerrit.wikimedia.org/r/532864 (https://phabricator.wikimedia.org/T228832) (owner: 10Mh-3110) [12:52:02] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress phan issues part 6 [core] - 10https://gerrit.wikimedia.org/r/533567 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [12:53:17] (03CR) 10MarcoAurelio: Empty ViewFiles repository and place archive text + ticket (031 comment) [extensions/ViewFiles] - 10https://gerrit.wikimedia.org/r/533330 (https://phabricator.wikimedia.org/T228367) (owner: 10D3r1ck01) [12:56:12] (03CR) 10jenkins-bot: Change the autonym of Banjar from "Bahasa Banjar" to "Banjar" [core] - 10https://gerrit.wikimedia.org/r/532859 (https://phabricator.wikimedia.org/T231283) (owner: 10Mh-3110) [12:56:34] 10WMEE: Septembri tööülesannete jaotamine - https://phabricator.wikimedia.org/T231719 (10tramm) [13:05:13] 10WMEE: Septembri tööülesannete jaotamine - https://phabricator.wikimedia.org/T231719 (10tramm) [13:07:56] (03PS2) 10D3r1ck01: Empty ViewFiles repository and place archive text + ticket [extensions/ViewFiles] - 10https://gerrit.wikimedia.org/r/533330 (https://phabricator.wikimedia.org/T228367) [13:08:32] (03CR) 10D3r1ck01: Empty ViewFiles repository and place archive text + ticket (031 comment) [extensions/ViewFiles] - 10https://gerrit.wikimedia.org/r/533330 (https://phabricator.wikimedia.org/T228367) (owner: 10D3r1ck01) [13:11:06] 10MediaWiki-extensions-Translate, 10WMSE-Bug-Reporting-and-Translation-2019, 10Language-Team (Language-2019-July-September), 10Patch-For-Review, 10User-abi_: Translate error - "This namespace is reserved for content page translations" - https://phabricator.wikimedia.org/T221119 (10Wladek92) Building the... [13:13:17] (03CR) 10MarcoAurelio: [C: 03+2] Empty ViewFiles repository and place archive text + ticket [extensions/ViewFiles] - 10https://gerrit.wikimedia.org/r/533330 (https://phabricator.wikimedia.org/T228367) (owner: 10D3r1ck01) [13:17:05] (03Merged) 10jenkins-bot: Empty ViewFiles repository and place archive text + ticket [extensions/ViewFiles] - 10https://gerrit.wikimedia.org/r/533330 (https://phabricator.wikimedia.org/T228367) (owner: 10D3r1ck01) [13:17:14] (03CR) 10Krinkle: [C: 03+2] Split LuaEngineTestBase to LuaEngineUnitTestBase and LuaEngineTestBase [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/527854 (https://phabricator.wikimedia.org/T230701) (owner: 10Ladsgroup) [13:17:29] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Archive the Semantic Tasks extension due to move to GitHub - https://phabricator.wikimedia.org/T221549 (10D3r1ck01) [13:18:35] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533634 (owner: 10L10n-bot) [13:18:44] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, 10Patch-For-Review: Archive the CustomSidebar extension - https://phabricator.wikimedia.org/T199712 (10D3r1ck01) [13:19:26] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Archive the ViewFiles extension - https://phabricator.wikimedia.org/T228367 (10MarcoAurelio) [13:20:25] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Archive the ViewFiles extension - https://phabricator.wikimedia.org/T228367 (10MarcoAurelio) [13:23:12] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Archive the ViewFiles extension - https://phabricator.wikimedia.org/T228367 (10MarcoAurelio) GitHub mirror deleted. [13:23:22] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Archive the ViewFiles extension - https://phabricator.wikimedia.org/T228367 (10MarcoAurelio) [13:24:37] (03Merged) 10jenkins-bot: Split LuaEngineTestBase to LuaEngineUnitTestBase and LuaEngineTestBase [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/527854 (https://phabricator.wikimedia.org/T230701) (owner: 10Ladsgroup) [13:25:20] 10WMEE: Wikimedia uus veebileht üles, koguda kasutajate tagasiside ja siis täiendada kuni esialgse rahuloluni - https://phabricator.wikimedia.org/T204043 (10tramm) >>! In T204043#5454564, @kruusamagi wrote: > Muus osas: täpitähtetega seonduva peaks korda saama. Kas saaksid, palun, täpsustada, mis täpitähtedega... [13:27:18] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/533633 (owner: 10L10n-bot) [13:34:13] 10MediaWiki-General, 10Performance-Team, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Patch-For-Review: Audit and simplify MediaWiki initialisation code (Spring 2018) - https://phabricator.wikimedia.org/T189966 (10Krinkle) [13:40:26] (03CR) 10jenkins-bot: Split LuaEngineTestBase to LuaEngineUnitTestBase and LuaEngineTestBase [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/527854 (https://phabricator.wikimedia.org/T230701) (owner: 10Ladsgroup) [13:44:29] (03PS1) 10D3r1ck01: Archive the BlueSpiceUserPreferences extension [extensions/BlueSpiceUserPreferences] - 10https://gerrit.wikimedia.org/r/533636 (https://phabricator.wikimedia.org/T197898) [13:50:56] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, 10Patch-For-Review: Archive the CustomSidebar extension - https://phabricator.wikimedia.org/T199712 (10D3r1ck01) [13:51:12] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Archive the CustomSidebar extension - https://phabricator.wikimedia.org/T199712 (10D3r1ck01) a:03D3r1ck01 [13:56:27] (03PS1) 10Krinkle: maintenance: Remove cross-wiki purging from rebuildmessages.php [core] - 10https://gerrit.wikimedia.org/r/533658 [13:56:33] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/BlueSpiceUserPreferences] - 10https://gerrit.wikimedia.org/r/533636 (https://phabricator.wikimedia.org/T197898) (owner: 10D3r1ck01) [13:58:25] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Archive the CustomSidebar extension - https://phabricator.wikimedia.org/T199712 (10Krinkle) [13:58:29] !class Page [13:58:29] See https://doc.wikimedia.org/mediawiki-core/master/php/classPage.html [13:58:39] !class WikiPage [13:58:39] See https://doc.wikimedia.org/mediawiki-core/master/php/classWikiPage.html [14:02:08] 10MediaWiki-General, 10Performance-Team, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Patch-For-Review: Audit and simplify MediaWiki initialisation code (Spring 2018) - https://phabricator.wikimedia.org/T189966 (10Krinkle) Looking at an XHGui profile,... [14:02:11] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/533695 (owner: 10L10n-bot) [14:02:20] (03PS1) 10Krinkle: phpunit: Don't bother resetting unused global in UploadFromUrlTestSuite [core] - 10https://gerrit.wikimedia.org/r/533696 (https://phabricator.wikimedia.org/T189966) [14:04:51] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533638 (owner: 10L10n-bot) [14:05:35] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/533670 (owner: 10L10n-bot) [14:08:23] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/533661 (owner: 10L10n-bot) [14:09:15] 10MediaWiki-extensions-EducationProgram, 10Education-Program-Dashboard, 10Release-Engineering-Team-TODO, 10Epic, and 2 others: Deprecate and remove the EducationProgram extension from Wikimedia servers after June 30, 2018 - https://phabricator.wikimedia.org/T125618 (10D3r1ck01) 05Open→03Resolved a:03D... [14:09:18] 10Wikimedia-Extension-setup, 10Tracking-Neverending: Extensions needing to be removed from Wikimedia wikis - https://phabricator.wikimedia.org/T106123 (10D3r1ck01) [14:09:53] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/533660 (owner: 10L10n-bot) [14:10:02] 10MediaWiki-extensions-EducationProgram, 10Education-Program-Dashboard, 10Security-team-backlog, 10Technical-Debt, 10User-D3r1ck01: Remove EducationProgram in favour of EducationDashboard - https://phabricator.wikimedia.org/T169676 (10D3r1ck01) 05Open→03Resolved a:03D3r1ck01 Extension has been arch... [14:10:12] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533673 (owner: 10L10n-bot) [14:10:53] 10MediaWiki-extensions-EducationProgram: Document clear method for users to access historical data from the education extension - https://phabricator.wikimedia.org/T188407 (10D3r1ck01) 05Open→03Invalid Extension has been archived, for more information, see: T214457. Please reopen in case we missed something. [14:10:56] 10MediaWiki-extensions-EducationProgram: Retaining data for courses organized through the extension during and after deprecation period - https://phabricator.wikimedia.org/T186325 (10D3r1ck01) [14:11:16] 10MediaWiki-extensions-EducationProgram: Cleaning up after EducationProgram - https://phabricator.wikimedia.org/T200391 (10D3r1ck01) 05Open→03Invalid Extension has been archived, for more information, see: T214457. Please reopen in case we missed something. [14:11:18] (03PS1) 10Krinkle: Migrate HTTP cache from messageMemc to APC [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/533698 (https://phabricator.wikimedia.org/T189966) [14:11:22] 10MediaWiki-extensions-EducationProgram, 10Education-Program-Dashboard, 10Release-Engineering-Team-TODO, 10Epic, and 2 others: Deprecate and remove the EducationProgram extension from Wikimedia servers after June 30, 2018 - https://phabricator.wikimedia.org/T125618 (10D3r1ck01) [14:12:34] 10MediaWiki-extensions-EducationProgram, 10Cleanup, 10Repository-Admins: Archive EducationProgram - https://phabricator.wikimedia.org/T214457 (10D3r1ck01) [14:15:36] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/533682 (owner: 10L10n-bot) [14:16:58] 10MediaWiki-extensions-EducationProgram, 10Cleanup, 10Repository-Admins: Archive EducationProgram - https://phabricator.wikimedia.org/T214457 (10D3r1ck01) [14:18:21] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/533663 (owner: 10L10n-bot) [14:19:32] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533679 (owner: 10L10n-bot) [14:20:12] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/533662 (owner: 10L10n-bot) [14:21:52] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/533666 (owner: 10L10n-bot) [14:24:29] 10Repository-Admins: Request to add `D3r1ck01` as member to Repository-Admins - https://phabricator.wikimedia.org/T231721 (10D3r1ck01) [14:27:22] (03CR) 10D3r1ck01: "recheck" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/533695 (owner: 10L10n-bot) [14:28:41] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/533684 (owner: 10L10n-bot) [14:29:28] 10MediaWiki-extensions-EducationProgram: Document clear method for users to access historical data from the education extension - https://phabricator.wikimedia.org/T188407 (10AfroThundr3007730) 05Invalid→03Open So far as I can tell, we've yet to resolve the matter of retrieving the old data from the educatio... [14:29:30] 10MediaWiki-extensions-EducationProgram: Retaining data for courses organized through the extension during and after deprecation period - https://phabricator.wikimedia.org/T186325 (10AfroThundr3007730) [14:38:04] (03PS2) 10Krinkle: Migrate HTTP cache from messageMemc to APC [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/533698 (https://phabricator.wikimedia.org/T189966) [14:41:48] (03PS1) 10Krinkle: Migrate HTTP cache from messageMemc to APC [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/533699 (https://phabricator.wikimedia.org/T189966) [14:42:34] (03CR) 10Don-vip: "> Patch Set 5:" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/530775 (owner: 10Don-vip) [14:42:36] (03CR) 10jerkins-bot: [V: 04-1] Migrate HTTP cache from messageMemc to APC [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/533699 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [14:42:59] (03CR) 10jerkins-bot: [V: 04-1] Migrate HTTP cache from messageMemc to APC [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/533699 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [14:43:17] (03CR) 10jerkins-bot: [V: 04-1] Migrate HTTP cache from messageMemc to APC [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/533698 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [14:43:59] (03CR) 10Daniel Kinzler: "> In general, I've started wondering - in the batch access to BlobStore we've made it return a StatusValue with warnings for unloadable ba" [core] - 10https://gerrit.wikimedia.org/r/531308 (https://phabricator.wikimedia.org/T228988) (owner: 10Ppchelko) [14:55:22] 10WMEE (This week): Septembri tööülesannete jaotamine - https://phabricator.wikimedia.org/T231719 (10tramm) [14:56:12] (03PS3) 10Krinkle: Migrate HTTP cache from messageMemc to APC [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/533698 (https://phabricator.wikimedia.org/T189966) [14:56:48] (03PS2) 10Krinkle: Migrate HTTP cache from messageMemc to APC [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/533699 (https://phabricator.wikimedia.org/T189966) [14:59:08] 10WMEE (This week), 10WMEE Miljon+: Septembri tööülesannete jaotamine - https://phabricator.wikimedia.org/T231719 (10tramm) [14:59:10] (03CR) 10jerkins-bot: [V: 04-1] Migrate HTTP cache from messageMemc to APC [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/533699 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [14:59:17] (03CR) 10jerkins-bot: [V: 04-1] Migrate HTTP cache from messageMemc to APC [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/533699 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [14:59:31] (03PS3) 10Krinkle: Migrate HTTP cache from messageMemc to APC [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/533699 (https://phabricator.wikimedia.org/T189966) [14:59:56] 10BlueSpice: Message key "blog" exists twice: BlueSpiceBlog and BlueSpiceSocialBlog - https://phabricator.wikimedia.org/T231722 (10Raymond) [15:03:15] 10WMEE Content: Mall {{Filmi_info}} - https://phabricator.wikimedia.org/T209639 (10tramm) [15:03:43] 10WMEE Content: Mall {{Kirik}} - https://phabricator.wikimedia.org/T209637 (10tramm) [15:03:57] 10WMEE Content: Mall {{Maal}} - https://phabricator.wikimedia.org/T209636 (10tramm) [15:04:13] 10WMEE Content: Mall {{Infokast_raamat}} - https://phabricator.wikimedia.org/T209638 (10tramm) [15:05:36] 10WMEE Content: Mall {{Kultuurimälestis}} - https://phabricator.wikimedia.org/T209640 (10tramm) [15:05:52] 10WMEE Content: Mall {{Mbabel}} Eesti Vikipeediasse - https://phabricator.wikimedia.org/T210145 (10tramm) [15:06:09] 10WMEE Content: Mall {{Tuletorn}} - https://phabricator.wikimedia.org/T209641 (10tramm) [15:09:26] 10WMEE (This week): Septembri tööülesannete jaotamine - https://phabricator.wikimedia.org/T231719 (10tramm) [15:09:49] 10WMEE Content, 10WMEE (This week): Septembri tööülesannete jaotamine - https://phabricator.wikimedia.org/T231719 (10tramm) [15:13:42] 10WMEE Content: Riigikogu liikmete pildid Wikimedia Commonsisse - https://phabricator.wikimedia.org/T222553 (10tramm) [15:16:52] 10WMEE 101+, 10WMEE (This week): Septembri tööülesannete jaotamine - https://phabricator.wikimedia.org/T231719 (10tramm) [15:25:35] 10Wikimedia Northern Europe Meeting 2019, 10WMEE (This week): WIKINEM plaanid paika - https://phabricator.wikimedia.org/T231723 (10tramm) [15:27:36] (03CR) 10Mholloway: "recheck" [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533340 (https://phabricator.wikimedia.org/T231036) (owner: 10Mholloway) [15:37:37] (03PS1) 10Krinkle: Setup: Remove debug message for "caches" [core] - 10https://gerrit.wikimedia.org/r/533701 (https://phabricator.wikimedia.org/T189966) [15:40:23] (03PS1) 10D3r1ck01: [diff][specials] Remove unused declaration in MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533702 [16:05:45] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533702 (owner: 10D3r1ck01) [16:07:04] (03PS8) 10Daimona Eaytoy: Upgrade phan, remove old config settings [tools/phan] - 10https://gerrit.wikimedia.org/r/519740 (https://phabricator.wikimedia.org/T228257) [16:07:16] (03CR) 10jerkins-bot: [V: 04-1] Upgrade phan, remove old config settings [tools/phan] - 10https://gerrit.wikimedia.org/r/519740 (https://phabricator.wikimedia.org/T228257) (owner: 10Daimona Eaytoy) [16:15:34] (03PS4) 10Krinkle: Unsuppress more phan issues [core] - 10https://gerrit.wikimedia.org/r/533516 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:15:37] (03PS1) 10Daimona Eaytoy: Unsuppress another phan issue [core] - 10https://gerrit.wikimedia.org/r/533703 (https://phabricator.wikimedia.org/T231636) [16:16:52] (03CR) 10Krinkle: Unsuppress more phan issues (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533516 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:19:57] (03CR) 10Daimona Eaytoy: Unsuppress more phan issues (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533516 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:20:32] (03CR) 10Krinkle: "recheck" [tools/phan] - 10https://gerrit.wikimedia.org/r/519740 (https://phabricator.wikimedia.org/T228257) (owner: 10Daimona Eaytoy) [16:22:46] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress another phan issue [core] - 10https://gerrit.wikimedia.org/r/533703 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:23:06] (03PS2) 10Daimona Eaytoy: Unsuppress another phan issue [core] - 10https://gerrit.wikimedia.org/r/533703 (https://phabricator.wikimedia.org/T231636) [16:23:44] (03CR) 10Krinkle: [C: 03+1] Unsuppress more phan issues (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533516 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:24:21] (03CR) 10Krinkle: [C: 04-1] Unsuppress more phan issues (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533516 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:26:43] (03CR) 10Daimona Eaytoy: Unsuppress more phan issues (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533516 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:27:19] (03PS5) 10Daimona Eaytoy: Unsuppress more phan issues [core] - 10https://gerrit.wikimedia.org/r/533516 (https://phabricator.wikimedia.org/T231636) [16:27:28] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress another phan issue [core] - 10https://gerrit.wikimedia.org/r/533703 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:27:30] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress another phan issue [core] - 10https://gerrit.wikimedia.org/r/533703 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:27:32] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress another phan issue [core] - 10https://gerrit.wikimedia.org/r/533703 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:27:34] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress another phan issue [core] - 10https://gerrit.wikimedia.org/r/533703 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:27:36] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress another phan issue [core] - 10https://gerrit.wikimedia.org/r/533703 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:27:38] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress another phan issue [core] - 10https://gerrit.wikimedia.org/r/533703 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:30:18] (03PS2) 10Daimona Eaytoy: Upgrade phan to 2.2.11 [tools/phan] - 10https://gerrit.wikimedia.org/r/531511 [16:30:25] (03CR) 10jerkins-bot: [V: 04-1] Upgrade phan to 2.2.11 [tools/phan] - 10https://gerrit.wikimedia.org/r/531511 (owner: 10Daimona Eaytoy) [16:31:00] (03CR) 10Krinkle: [C: 03+1] Unsuppress more phan issues [core] - 10https://gerrit.wikimedia.org/r/533516 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:31:46] 10WMEE (This week): Septembri tööülesannete jaotamine - https://phabricator.wikimedia.org/T231719 (10tramm) [16:32:20] 10Wikimedia Northern Europe Meeting 2019, 10WMEE (This week): Septembri tööülesannete jaotamine - https://phabricator.wikimedia.org/T231719 (10tramm) [16:33:00] (03CR) 10Krinkle: [C: 03+1] Upgrade phan, remove old config settings [tools/phan] - 10https://gerrit.wikimedia.org/r/519740 (https://phabricator.wikimedia.org/T228257) (owner: 10Daimona Eaytoy) [16:33:02] (03PS9) 10Daimona Eaytoy: Upgrade phan, remove old config settings [tools/phan] - 10https://gerrit.wikimedia.org/r/519740 (https://phabricator.wikimedia.org/T228257) [16:33:16] (03PS3) 10Krinkle: Upgrade phan to 2.2.11 [tools/phan] - 10https://gerrit.wikimedia.org/r/531511 (owner: 10Daimona Eaytoy) [16:33:21] (03CR) 10jerkins-bot: [V: 04-1] Upgrade phan to 2.2.11 [tools/phan] - 10https://gerrit.wikimedia.org/r/531511 (owner: 10Daimona Eaytoy) [16:34:43] 10WMEE (This week): Septembri tööülesannete jaotamine - https://phabricator.wikimedia.org/T231719 (10tramm) [16:35:15] 10media-storage: 404 File not found: /v1/AUTH_mw/wikipedia-commons-local-public.ab/a/ab/Chirimena_%281341689114%29.jpg - https://phabricator.wikimedia.org/T231078 (10Wilfredor) the same with https://commons.wikimedia.org/wiki/File:Jard%C3%ADn_(1044347743).jpg These images are being erased en masse in commons be... [16:35:20] (03PS2) 10Krinkle: Remove redundant User::addToDatabase call in tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533053 (owner: 10Daimona Eaytoy) [16:35:23] (03PS3) 10Krinkle: Remove redundant User::addToDatabase call in tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533053 (owner: 10Daimona Eaytoy) [16:35:25] (03CR) 10Krinkle: [C: 03+2] Remove redundant User::addToDatabase call in tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533053 (owner: 10Daimona Eaytoy) [16:37:56] (03CR) 10Krinkle: [C: 03+2] Unsuppress more phan issues [core] - 10https://gerrit.wikimedia.org/r/533516 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:38:09] (03PS6) 10Krinkle: Unsuppress other phan issues [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:38:43] (03PS7) 10Krinkle: Unsuppress other phan issues (part 4) [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:39:01] (03PS6) 10Krinkle: Unsuppress more phan issues (part 3) [core] - 10https://gerrit.wikimedia.org/r/533516 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:39:07] (03CR) 10Krinkle: Unsuppress more phan issues (part 3) [core] - 10https://gerrit.wikimedia.org/r/533516 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:39:10] (03CR) 10Krinkle: [C: 03+2] Unsuppress more phan issues (part 3) [core] - 10https://gerrit.wikimedia.org/r/533516 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:39:12] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress other phan issues (part 4) [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:39:14] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress other phan issues (part 4) [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:39:16] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress other phan issues (part 4) [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:39:18] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress other phan issues (part 4) [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:39:20] (03PS8) 10Krinkle: Unsuppress other phan issues (part 4) [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:40:02] 10Wikimedia Northern Europe Meeting 2019, 10WMEE (This week): WIKINEM plaanid paika - https://phabricator.wikimedia.org/T231723 (10tramm) [16:40:04] 10Wikimedia Northern Europe Meeting 2019: Conceptualize the plan for Nordic meeting - https://phabricator.wikimedia.org/T224148 (10tramm) [16:40:37] (03CR) 10Krinkle: Unsuppress other phan issues (part 4) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:40:55] 10WMEE (This week): WIKINEM plaanid paika - https://phabricator.wikimedia.org/T231723 (10tramm) [16:40:57] 10WMEE (This week): WIKINEM plaanid paika - https://phabricator.wikimedia.org/T231723 (10tramm) [16:41:36] (03CR) 10Krinkle: [C: 03+2] Remove AbuseFilter::saveFilter dependency on AbuseFilterViewEdit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532715 (https://phabricator.wikimedia.org/T213037) (owner: 10Daimona Eaytoy) [16:41:40] 10WMEE: Septembri tööülesannete jaotamine - https://phabricator.wikimedia.org/T231719 (10tramm) [16:45:49] (03CR) 10Krinkle: [C: 03+1] "havent reviewed the regex in-depth, but it's warn-only and thus a low risk." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/529475 (https://phabricator.wikimedia.org/T212730) (owner: 10Daimona Eaytoy) [16:46:04] (03CR) 10Krinkle: [C: 03+1] "OK to land for next week or are there other things you'd prefer to happen first?" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/529475 (https://phabricator.wikimedia.org/T212730) (owner: 10Daimona Eaytoy) [16:46:41] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress other phan issues (part 4) [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:49:21] (03CR) 10Krinkle: [C: 03+1] "Code LGTM. I'm not too fond of using user rights as a flag to communicate between two code paths. If it has no way to cause side-effects (" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/529917 (https://phabricator.wikimedia.org/T212082) (owner: 10Daimona Eaytoy) [16:49:46] 10MediaWiki-extensions-CentralAuth, 10AbuseFilter, 10Core Platform Team, 10GlobalRename, and 3 others: Do not block page moves with AbuseFilter on LocalRenameJob page moves - https://phabricator.wikimedia.org/T212082 (10Krinkle) [16:49:49] (03CR) 10Daimona Eaytoy: "> OK to land for next week or are there other things you'd prefer to" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/529475 (https://phabricator.wikimedia.org/T212730) (owner: 10Daimona Eaytoy) [16:50:25] 10MediaWiki-extensions-CentralAuth, 10AbuseFilter, 10Core Platform Team, 10GlobalRename, and 3 others: Do not block page moves with AbuseFilter on LocalRenameJob page moves - https://phabricator.wikimedia.org/T212082 (10Krinkle) Tagging CPT because I'm asking a about PermissionManager in code review at (03CR) 10Krinkle: [C: 03+2] Add new number syntax as experimental [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/529475 (https://phabricator.wikimedia.org/T212730) (owner: 10Daimona Eaytoy) [16:51:47] (03CR) 10Krinkle: [C: 03+2] "Speaking of T156095 - what's the next thing we can do? Is it fully blocked on the Meta RFC?" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/529475 (https://phabricator.wikimedia.org/T212730) (owner: 10Daimona Eaytoy) [16:52:21] (03CR) 10Daimona Eaytoy: "> Code LGTM. I'm not too fond of using user rights as a flag to" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/529917 (https://phabricator.wikimedia.org/T212082) (owner: 10Daimona Eaytoy) [16:53:26] (03CR) 10Krinkle: Unsuppress other phan issues (part 4) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:56:05] (03CR) 10Krinkle: Unsuppress other phan issues (part 4) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:57:57] (03CR) 10Daimona Eaytoy: Unsuppress other phan issues (part 4) (033 comments) [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:59:23] (03CR) 10Krinkle: Unsuppress other phan issues (part 4) (033 comments) [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [17:00:09] (03CR) 10Daimona Eaytoy: "> Speaking of T156095 - what's the next thing we can do? Is it fully" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/529475 (https://phabricator.wikimedia.org/T212730) (owner: 10Daimona Eaytoy) [17:01:28] (03CR) 10Krinkle: Unsuppress other phan issues (part 4) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [17:01:31] (03Merged) 10jenkins-bot: Remove redundant User::addToDatabase call in tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533053 (owner: 10Daimona Eaytoy) [17:01:51] (03CR) 10Krinkle: [C: 03+2] "Thanks :)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/529475 (https://phabricator.wikimedia.org/T212730) (owner: 10Daimona Eaytoy) [17:02:12] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress other phan issues (part 4) [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [17:03:42] (03CR) 10Krinkle: [C: 03+1] Handle closures [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507981 (owner: 10Daimona Eaytoy) [17:05:04] (03CR) 10Daimona Eaytoy: Unsuppress other phan issues (part 4) (034 comments) [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [17:05:59] (03Merged) 10jenkins-bot: Unsuppress more phan issues (part 3) [core] - 10https://gerrit.wikimedia.org/r/533516 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [17:06:03] (03Merged) 10jenkins-bot: Remove AbuseFilter::saveFilter dependency on AbuseFilterViewEdit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532715 (https://phabricator.wikimedia.org/T213037) (owner: 10Daimona Eaytoy) [17:11:06] (03CR) 10jenkins-bot: Remove redundant User::addToDatabase call in tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533053 (owner: 10Daimona Eaytoy) [17:11:13] (03CR) 10Krinkle: Unsuppress other phan issues (part 4) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [17:12:11] (03Merged) 10jenkins-bot: Add new number syntax as experimental [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/529475 (https://phabricator.wikimedia.org/T212730) (owner: 10Daimona Eaytoy) [17:13:47] (03PS9) 10Daimona Eaytoy: Unsuppress other phan issues (part 4) [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) [17:13:59] (03PS2) 10Krinkle: filebackend: improve internal use of FileBackend constants [core] - 10https://gerrit.wikimedia.org/r/533622 (owner: 10Aaron Schulz) [17:16:14] (03CR) 10Krinkle: Unsuppress other phan issues (part 4) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [17:16:16] (03CR) 10Daimona Eaytoy: Unsuppress other phan issues (part 4) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [17:16:59] (03CR) 10Krinkle: filebackend: improve internal use of FileBackend constants (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533622 (owner: 10Aaron Schulz) [17:17:31] (03CR) 10Daimona Eaytoy: Unsuppress other phan issues (part 4) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [17:17:37] 04(no projects): Bi Oluru Yok! - https://phabricator.wikimedia.org/T231724 (10Ozantoprakbalci) [17:17:43] (03CR) 10Krinkle: filebackend: improve internal use of FileBackend constants (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533622 (owner: 10Aaron Schulz) [17:18:06] (03PS6) 10Daimona Eaytoy: Unsuppress more phan issues (part 5) [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) [17:18:15] (03PS7) 10Daimona Eaytoy: Unsuppress more phan issues (part 5) [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) [17:18:28] (03PS8) 10Daimona Eaytoy: Unsuppress phan issues part 6 [core] - 10https://gerrit.wikimedia.org/r/533567 (https://phabricator.wikimedia.org/T231636) [17:18:40] (03CR) 10Krinkle: [C: 03+2] "It can for ProfilerOutputDb, right? See also T231366. Fine though." [core] - 10https://gerrit.wikimedia.org/r/533377 (owner: 10Aaron Schulz) [17:18:45] (03PS3) 10Daimona Eaytoy: Unsuppress another phan issue (part 7) [core] - 10https://gerrit.wikimedia.org/r/533703 (https://phabricator.wikimedia.org/T231636) [17:18:55] (03PS4) 10Daimona Eaytoy: Unsuppress another phan issue (part 7) [core] - 10https://gerrit.wikimedia.org/r/533703 (https://phabricator.wikimedia.org/T231636) [17:18:58] (03CR) 10Krinkle: [C: 03+2] Remove redundant ignore_user_abort() call in ApiStashEdit [core] - 10https://gerrit.wikimedia.org/r/533376 (owner: 10Aaron Schulz) [17:20:02] (03CR) 10Krinkle: [C: 03+2] Unsuppress other phan issues (part 4) [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [17:20:16] (03CR) 10jenkins-bot: Remove AbuseFilter::saveFilter dependency on AbuseFilterViewEdit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532715 (https://phabricator.wikimedia.org/T213037) (owner: 10Daimona Eaytoy) [17:20:20] (03CR) 10jenkins-bot: Unsuppress more phan issues (part 3) [core] - 10https://gerrit.wikimedia.org/r/533516 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [17:22:28] (03CR) 10Krinkle: [C: 03+2] Optimize HashRing to avoid hashing for the common single-location case [core] - 10https://gerrit.wikimedia.org/r/533370 (owner: 10Aaron Schulz) [17:23:48] (03CR) 10Krinkle: [C: 03+2] lockmanager: sort key by bucket in QuorumLockManager::doLockByType [core] - 10https://gerrit.wikimedia.org/r/533368 (owner: 10Aaron Schulz) [17:29:03] (03CR) 10Daimona Eaytoy: [C: 04-2] Add updateVarDumps to update.php and handle new code (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482500 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [17:29:44] (03CR) 10jenkins-bot: Add new number syntax as experimental [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/529475 (https://phabricator.wikimedia.org/T212730) (owner: 10Daimona Eaytoy) [17:40:07] (03CR) 10Krinkle: rdbms: assorted LBFactoryMulti/LBFactorySimple cleanups (031 comment) [core] - 10https://gerrit.wikimedia.org/r/524956 (owner: 10Aaron Schulz) [17:42:42] (03CR) 10Krinkle: Unsuppress more phan issues (part 5) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [17:42:47] (03CR) 10jenkins-bot: Unsuppress more phan issues (part 3) [core] - 10https://gerrit.wikimedia.org/r/533516 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [17:43:39] (03CR) 10Krinkle: Convert file delete to use OOUI (031 comment) [core] - 10https://gerrit.wikimedia.org/r/435651 (https://phabricator.wikimedia.org/T173997) (owner: 10Jayprakash12345) [17:44:52] 10Phabricator: Merge the Phabricator Priority values "Low" and "Lowest" - https://phabricator.wikimedia.org/T228759 (10Aklapper) p:05Lowest→03Low > Redefining it as "can sit here for any time", or "not urgent at all" is a better thing to do IMO Yes, personally I am fine with that definition for "Low priorit... [17:45:28] (03CR) 10Krinkle: (bug 40588) LinkSearch cannot search with a port in the url (031 comment) [core] - 10https://gerrit.wikimedia.org/r/28908 (owner: 10MrBlueSky) [17:46:34] (03CR) 10Krinkle: Add CSS classes for userlinks on SpecialPages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/338350 (https://phabricator.wikimedia.org/T156879) (owner: 10EddieGP) [17:49:54] (03Merged) 10jenkins-bot: Remove redundant ignore_user_abort() call in ApiStashEdit [core] - 10https://gerrit.wikimedia.org/r/533376 (owner: 10Aaron Schulz) [17:50:00] (03Merged) 10jenkins-bot: Replace unecessary rollbackMasterChangesAndLog() call in doPostOutputShutdown() [core] - 10https://gerrit.wikimedia.org/r/533377 (owner: 10Aaron Schulz) [17:50:14] (03Merged) 10jenkins-bot: Unsuppress other phan issues (part 4) [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [17:50:48] (03PS5) 10Daimona Eaytoy: Unsuppress another phan issue (part 7) [core] - 10https://gerrit.wikimedia.org/r/533703 (https://phabricator.wikimedia.org/T231636) [17:53:14] 10MediaWiki-Page-editing, 10Browser-Support-Google-Chrome, 10Performance, 10Upstream: Large wiki table in Google Chrome causes WikiEditor to be very slow - https://phabricator.wikimedia.org/T134810 (10Zoranzoki21) [17:53:38] (03CR) 10Daimona Eaytoy: Unsuppress more phan issues (part 5) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [17:57:42] (03PS6) 10Daimona Eaytoy: Unsuppress another phan issue (part 7) [core] - 10https://gerrit.wikimedia.org/r/533703 (https://phabricator.wikimedia.org/T231636) [17:59:13] (03Merged) 10jenkins-bot: Optimize HashRing to avoid hashing for the common single-location case [core] - 10https://gerrit.wikimedia.org/r/533370 (owner: 10Aaron Schulz) [18:01:02] (03Merged) 10jenkins-bot: lockmanager: sort key by bucket in QuorumLockManager::doLockByType [core] - 10https://gerrit.wikimedia.org/r/533368 (owner: 10Aaron Schulz) [18:04:11] (03CR) 10Krinkle: Unsuppress more phan issues (part 5) (037 comments) [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [18:04:33] (03CR) 10Krinkle: "Reviewed until ApiQueryBacklinks. Might pick up later." [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [18:04:53] (03CR) 10jenkins-bot: Remove redundant ignore_user_abort() call in ApiStashEdit [core] - 10https://gerrit.wikimedia.org/r/533376 (owner: 10Aaron Schulz) [18:05:18] (03PS17) 10Krinkle: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) [18:06:50] (03CR) 10Krinkle: [C: 03+2] jobqueue: Avoid usage of deprecated `MWHttpRequest::factory()` [core] - 10https://gerrit.wikimedia.org/r/532820 (owner: 10D3r1ck01) [18:10:06] (03CR) 10Krinkle: "When was it added? Was it used then? When was the usage removed?" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/531300 (owner: 10D3r1ck01) [18:10:18] 10Phabricator, 10Security: Reset my 2FA on this Phab account - https://phabricator.wikimedia.org/T231526 (10Aklapper) Unrelated to #Trust-and-Safety, hence removing tag [18:12:21] (03CR) 10Daimona Eaytoy: "> Reviewed until ApiQueryBacklinks. Might pick up later." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [18:14:48] (03CR) 10jenkins-bot: Unsuppress other phan issues (part 4) [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [18:14:50] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [18:16:04] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [18:16:10] (03CR) 10Krinkle: [C: 04-1] "This seems like the sort of thing that will be "that thing" that violates an assumption somewhere and comes back to hunt us. Code could be" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/140975 (owner: 10Brian Wolff) [18:16:23] 10MediaWiki-General, 10Core Platform Team, 10Patch-For-Review, 10Performance-Team (Radar), 10good first bug: MediaWiki needlessly queries page data twice on page views - https://phabricator.wikimedia.org/T206498 (10Krinkle) [18:16:39] 10MediaWiki-General, 10Core Platform Team, 10Patch-For-Review, 10Performance-Team (Radar), 10good first bug: MediaWiki needlessly queries page data twice on page views - https://phabricator.wikimedia.org/T206498 (10Krinkle) >>! In T206498#4758560, @gerritbot wrote: > Change 474726 had a related patch set... [18:17:40] (03CR) 10Krinkle: Unsuppress more phan issues (part 5) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [18:20:00] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [18:20:03] (03CR) 10jenkins-bot: Unsuppress other phan issues (part 4) [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [18:20:27] (03PS5) 10Krinkle: Parser: introduce a centralized extension state storage [core] - 10https://gerrit.wikimedia.org/r/501816 (owner: 10MaxSem) [18:20:36] (03CR) 10Krinkle: [C: 03+1] Parser: introduce a centralized extension state storage [core] - 10https://gerrit.wikimedia.org/r/501816 (owner: 10MaxSem) [18:20:57] (03CR) 10Krinkle: [C: 03+1] "LGTM. CPT or Parsing-Team should approve." [core] - 10https://gerrit.wikimedia.org/r/501816 (owner: 10MaxSem) [18:20:59] (03CR) 10jerkins-bot: [V: 04-1] Parser: introduce a centralized extension state storage [core] - 10https://gerrit.wikimedia.org/r/501816 (owner: 10MaxSem) [18:21:29] (03CR) 10jerkins-bot: [V: 04-1] Parser: introduce a centralized extension state storage [core] - 10https://gerrit.wikimedia.org/r/501816 (owner: 10MaxSem) [18:21:44] (03CR) 10jerkins-bot: [V: 04-1] Parser: introduce a centralized extension state storage [core] - 10https://gerrit.wikimedia.org/r/501816 (owner: 10MaxSem) [18:21:53] (03CR) 10jerkins-bot: [V: 04-1] Parser: introduce a centralized extension state storage [core] - 10https://gerrit.wikimedia.org/r/501816 (owner: 10MaxSem) [18:23:46] 10MediaWiki-extensions-FlaggedRevs, 10Wikimedia-Site-requests: Last reviewed revision is shown to logged-out users in ukwiki instead of last revision - https://phabricator.wikimedia.org/T227260 (10Zache) Hmm, problem may be just because `'ukwiki' => false` is missing from `wgFlaggedRevsOverride` setting in [[... [18:25:01] (03CR) 10D3r1ck01: "> When was it added? Was it used then? When was the usage removed?" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/531300 (owner: 10D3r1ck01) [18:27:08] (03PS4) 10D3r1ck01: content: Remove unused constant NewsletterContent::NEWSLETTER_MANAGE [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/531300 [18:27:41] 10MediaWiki-extension-requests: Suggestion: Modify and Deploy RC Patrol extension from wikiHow onto Wikimedia projects. - https://phabricator.wikimedia.org/T192719 (10UpsandDowns1234) The main problem is that going through recent changes on large projects like Wikipedia is a nightmare. Because Wikipedia gets t... [18:29:53] (03CR) 10jerkins-bot: [V: 04-1] jobqueue: Avoid usage of deprecated `MWHttpRequest::factory()` [core] - 10https://gerrit.wikimedia.org/r/532820 (owner: 10D3r1ck01) [18:30:47] (03CR) 10Daimona Eaytoy: Unsuppress more phan issues (part 5) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [18:31:19] (03CR) 10D3r1ck01: "recheck" [core] - 10https://gerrit.wikimedia.org/r/532820 (owner: 10D3r1ck01) [18:31:40] (03CR) 10D3r1ck01: "I don't quite understand the failure, browser tests?" [core] - 10https://gerrit.wikimedia.org/r/532820 (owner: 10D3r1ck01) [18:34:12] (03CR) 10jenkins-bot: Replace unecessary rollbackMasterChangesAndLog() call in doPostOutputShutdown() [core] - 10https://gerrit.wikimedia.org/r/533377 (owner: 10Aaron Schulz) [18:41:52] 10Phabricator: Story point default value should be "" rather than 0 for tasks created via the advanced form - https://phabricator.wikimedia.org/T231624 (10Aklapper) 05Open→03Resolved a:03Aklapper Hopefully fixed by editing https://phabricator.wikimedia.org/transactions/editengine/maniphest.task/defaults/3/... [18:42:07] (03PS1) 10Daimona Eaytoy: Also catch Error in the hacky workaround for bad rows [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533704 (https://phabricator.wikimedia.org/T187153) [18:42:52] (03PS2) 10Daimona Eaytoy: Also catch Error in the hacky workaround for bad rows [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533704 (https://phabricator.wikimedia.org/T187153) [18:48:09] (03CR) 10jenkins-bot: Optimize HashRing to avoid hashing for the common single-location case [core] - 10https://gerrit.wikimedia.org/r/533370 (owner: 10Aaron Schulz) [18:53:02] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Community-consensus-needed, 10Patch-For-Review, and 3 others: Add monolingual language code kld (Gamilaraay) - https://phabricator.wikimedia.org/T198366 (10Lydia_Pintscher) [18:55:25] 10MediaWiki-Change-tagging, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), and 2 others: Add tags parameter to Wikibase APIs that edit entities - https://phabricator.wikimedia.org/T229917 (10Lydia_Pintscher) 05Open→03Resolved \o/ [18:55:29] 10MediaWiki-Change-tagging, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Trailblazing-Exploration: Wikibase API should support adding change tags - https://phabricator.wikimedia.org/T155109 (10Lydia_Pintscher) [18:57:03] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Patch-For-Review, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞), and 2 others: Add monolingual language code peo (Old Persian) - https://phabricator.wikimedia.org/T189427 (10Lydia_Pintscher) [19:01:51] (03PS21) 10Daimona Eaytoy: Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006) [19:04:30] (03CR) 10jerkins-bot: [V: 04-1] Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [19:07:25] 10StructuredDiscussions, 10Growth-Team (Current Sprint), 10Patch-For-Review: Align suppression rights in Flow with core group and grant - https://phabricator.wikimedia.org/T231694 (10kostajh) [19:07:56] (03PS6) 10Kosta Harlan: Assign flow-suppress to the suppress group and oversight grant [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533588 (https://phabricator.wikimedia.org/T231694) (owner: 10JJMC89) [19:08:43] (03CR) 10jenkins-bot: lockmanager: sort key by bucket in QuorumLockManager::doLockByType [core] - 10https://gerrit.wikimedia.org/r/533368 (owner: 10Aaron Schulz) [19:09:02] 10GrowthExperiments-Homepage, 10GrowthExperiments-StartModule, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Mobile: Homepage: mobile submodule headers - https://phabricator.wikimedia.org/T225667 (10Etonkovidova) >>! In T225667#5455625, @MMiller_WMF wrote: > @Etonkovidova... [19:12:35] (03CR) 10Fomafix: SkinMetrolook: Call parent::__construct in constructor (031 comment) [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/509624 (owner: 10Fomafix) [19:16:43] (03CR) 10Aaron Schulz: [C: 03+2] Setup: Remove debug message for "caches" [core] - 10https://gerrit.wikimedia.org/r/533701 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [19:19:20] (03CR) 10Aaron Schulz: filebackend: improve internal use of FileBackend constants (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533622 (owner: 10Aaron Schulz) [19:21:02] 10MediaWiki-Installer, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-release, 10Patch-For-Review: Default dbpath for install.php (dbtype sqlite) no longer works. (Writes to root of disk) - https://phabricator.wikimedia.org/T217855 (10Ciencia_Al_Poder) [19:21:03] (03CR) 10Fomafix: Unsuppress more phan issues (part 5) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [19:21:04] 10MediaWiki-Installer: Invalid default for dbpath with install.php - https://phabricator.wikimedia.org/T196187 (10Ciencia_Al_Poder) [19:22:30] (03CR) 10Aaron Schulz: filebackend: improve internal use of FileBackend constants (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533622 (owner: 10Aaron Schulz) [19:33:16] (03CR) 10Daimona Eaytoy: Unsuppress more phan issues (part 5) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [19:35:41] (03PS3) 10Aaron Schulz: filebackend: improve internal use of FileBackend constants [core] - 10https://gerrit.wikimedia.org/r/533622 [19:36:45] (03CR) 10Aaron Schulz: "The DB profiler should not touch the DB until wfLogProfilingData() later on." [core] - 10https://gerrit.wikimedia.org/r/533377 (owner: 10Aaron Schulz) [19:37:10] 10MediaWiki-extensions-WikibaseClient, 10Wikibase-Lua, 10Wikidata, 10Wikidata-Campsite: mw.wikibase.entityExists returns false for redirected entities - https://phabricator.wikimedia.org/T192462 (10Lydia_Pintscher) p:05Normal→03High [19:40:12] 10StructuredDiscussions, 10Growth-Team (Current Sprint), 10Patch-For-Review: Align suppression rights in Flow with core group and grant - https://phabricator.wikimedia.org/T231694 (10MarcoAurelio) Please note that on WMF wikis the suppress group is named 'oversight'. Just to avoid another instance of T230601... [19:40:39] (03CR) 10Jforrester: [C: 03+2] Upgrade phan, remove old config settings [tools/phan] - 10https://gerrit.wikimedia.org/r/519740 (https://phabricator.wikimedia.org/T228257) (owner: 10Daimona Eaytoy) [19:41:16] (03Merged) 10jenkins-bot: Upgrade phan, remove old config settings [tools/phan] - 10https://gerrit.wikimedia.org/r/519740 (https://phabricator.wikimedia.org/T228257) (owner: 10Daimona Eaytoy) [19:41:17] 10MediaWiki-Page-editing, 10User-DannyS712: Creating articles from redirects should generate automatic edit summaries, like page creation - https://phabricator.wikimedia.org/T37997 (10DannyS712) a:03DannyS712 [19:41:40] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533588 (https://phabricator.wikimedia.org/T231694) (owner: 10JJMC89) [19:46:34] (03CR) 10jerkins-bot: [V: 04-1] Setup: Remove debug message for "caches" [core] - 10https://gerrit.wikimedia.org/r/533701 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [19:47:48] (03PS2) 10Aaron Schulz: Setup: Remove debug message for "caches" [core] - 10https://gerrit.wikimedia.org/r/533701 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [19:48:00] (03CR) 10Aaron Schulz: [C: 03+2] Setup: Remove debug message for "caches" [core] - 10https://gerrit.wikimedia.org/r/533701 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [19:52:18] (03CR) 10Reedy: "reedy@ubuntu64-web-esxi:/var/www/wiki/mediawiki/extensions/WebAuthn$ composer install --no-dev" [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/508788 (https://phabricator.wikimedia.org/T218211) (owner: 10ItSpiderman) [19:52:26] (03CR) 10Catrope: [C: 03+2] INSTALL/RELEASE-NOTES-1.34: Add required PHP extensions [core] - 10https://gerrit.wikimedia.org/r/532811 (owner: 10Jforrester) [19:52:36] (03PS1) 10Amire80: Move apihelp messages to a separate file [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/533705 (https://phabricator.wikimedia.org/T189982) [19:53:12] (03PS2) 10Amire80: Add $specialPageAliases and $magicWords for Tajik [core] - 10https://gerrit.wikimedia.org/r/528477 [19:53:29] 10Security-Team-Reviews: Security review of WebAuthn library dependancies - https://phabricator.wikimedia.org/T227244 (10Reedy) ` reedy@ubuntu64-web-esxi:/var/www/wiki/mediawiki/extensions/WebAuthn$ composer install --no-dev Loading composer repositories with package information Updating dependencies Package ope... [19:53:52] (03PS3) 10Aaron Schulz: Fix PhpStorm IDE warnings in ServiceWiring.php [core] - 10https://gerrit.wikimedia.org/r/533135 [19:54:33] (03CR) 10Jforrester: "recheck" [tools/phan] - 10https://gerrit.wikimedia.org/r/531511 (owner: 10Daimona Eaytoy) [19:54:39] (03CR) 10jerkins-bot: [V: 04-1] Upgrade phan to 2.2.11 [tools/phan] - 10https://gerrit.wikimedia.org/r/531511 (owner: 10Daimona Eaytoy) [19:56:04] (03PS5) 10Aaron Schulz: [WIP] rdbms: improve LoadBalancer connection pool reuse [core] - 10https://gerrit.wikimedia.org/r/519305 (https://phabricator.wikimedia.org/T226595) [19:56:24] (03PS4) 10Jforrester: Upgrade phan to 2.2.11 [tools/phan] - 10https://gerrit.wikimedia.org/r/531511 (owner: 10Daimona Eaytoy) [19:57:18] (03CR) 10Aaron Schulz: [C: 03+2] maintenance: Remove cross-wiki purging from rebuildmessages.php [core] - 10https://gerrit.wikimedia.org/r/533658 (owner: 10Krinkle) [19:57:28] 10MediaWiki-Maintenance-scripts, 10Operations, 10serviceops: Stop forcing RUNNER=php for foreachwiki/foreachwikiindblist - https://phabricator.wikimedia.org/T230110 (10Jdforrester-WMF) This is done as of https://gerrit.wikimedia.org/r/c/operations/puppet/+/425027 on 12 August, right? [19:58:09] (03PS4) 10Aaron Schulz: Migrate HTTP cache from messageMemc to APC [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/533698 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [19:58:58] (03CR) 10Jforrester: [C: 03+1] Upgrade phan to 2.2.11 [tools/phan] - 10https://gerrit.wikimedia.org/r/531511 (owner: 10Daimona Eaytoy) [19:59:13] (03PS3) 10Jforrester: [DNM] Add perfcheck plugin [tools/phan] - 10https://gerrit.wikimedia.org/r/522385 (https://phabricator.wikimedia.org/T227569) (owner: 10Daimona Eaytoy) [19:59:30] (03CR) 10jerkins-bot: [V: 04-1] [WIP] rdbms: improve LoadBalancer connection pool reuse [core] - 10https://gerrit.wikimedia.org/r/519305 (https://phabricator.wikimedia.org/T226595) (owner: 10Aaron Schulz) [19:59:32] (03CR) 10jerkins-bot: [V: 04-1] [WIP] rdbms: improve LoadBalancer connection pool reuse [core] - 10https://gerrit.wikimedia.org/r/519305 (https://phabricator.wikimedia.org/T226595) (owner: 10Aaron Schulz) [19:59:45] (03CR) 10jerkins-bot: [V: 04-1] [DNM] Add perfcheck plugin [tools/phan] - 10https://gerrit.wikimedia.org/r/522385 (https://phabricator.wikimedia.org/T227569) (owner: 10Daimona Eaytoy) [20:02:23] (03CR) 10jerkins-bot: [V: 04-1] [WIP] rdbms: improve LoadBalancer connection pool reuse [core] - 10https://gerrit.wikimedia.org/r/519305 (https://phabricator.wikimedia.org/T226595) (owner: 10Aaron Schulz) [20:03:00] (03PS1) 10D3r1ck01: Fix function name mismatch, `wfWikiId()` -> `wfWikiID()` [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/533706 [20:04:39] (03PS1) 10D3r1ck01: Fix function name mismatch, `wfWikiId()` -> `wfWikiID()` [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/533707 [20:06:37] 10InternetArchiveBot: Multiple false positives on gl.wikipedia on the 08/30/2019 - https://phabricator.wikimedia.org/T231653 (10Banjo) 05Open→03Resolved Behavior looks to be back to normal after several edits, no more false positives detected, including no more false positives not registered in the bot DB re... [20:07:32] (03PS1) 10D3r1ck01: Fix function name mismatch, `wfWikiId()` -> `wfWikiID()` [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/533708 [20:08:03] (03Merged) 10jenkins-bot: Assign flow-suppress to the suppress group and oversight grant [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533588 (https://phabricator.wikimedia.org/T231694) (owner: 10JJMC89) [20:11:05] (03CR) 10Reedy: [C: 04-1] "Seems the JS doesn't work properly. Was confused by the disabled text box, looked at the console..." [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/508788 (https://phabricator.wikimedia.org/T218211) (owner: 10ItSpiderman) [20:11:29] 10StructuredDiscussions, 10Growth-Team (Current Sprint): Align suppression rights in Flow with core group and grant - https://phabricator.wikimedia.org/T231694 (10JJMC89) 05Open→03Resolved [20:11:32] 10MediaWiki-General, 10Trust-and-Safety, 10Wikimedia-Site-requests: Rename the oversight group on WMF projects - https://phabricator.wikimedia.org/T112147 (10JJMC89) [20:12:09] (03Merged) 10jenkins-bot: Setup: Remove debug message for "caches" [core] - 10https://gerrit.wikimedia.org/r/533701 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [20:14:39] (03CR) 10jenkins-bot: Assign flow-suppress to the suppress group and oversight grant [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533588 (https://phabricator.wikimedia.org/T231694) (owner: 10JJMC89) [20:14:44] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/533706 (owner: 10D3r1ck01) [20:14:57] (03CR) 10jerkins-bot: [V: 04-1] [WIP] rdbms: improve LoadBalancer connection pool reuse [core] - 10https://gerrit.wikimedia.org/r/519305 (https://phabricator.wikimedia.org/T226595) (owner: 10Aaron Schulz) [20:15:59] (03CR) 10Daimona Eaytoy: "In case it wasn't clear, this can already be merged, and then IMHO we should tag a new release: 0.7.0, or even 1.0.0 due to php version bu" [tools/phan] - 10https://gerrit.wikimedia.org/r/531511 (owner: 10Daimona Eaytoy) [20:16:44] (03CR) 10jerkins-bot: [V: 04-1] Fix PhpStorm IDE warnings in ServiceWiring.php [core] - 10https://gerrit.wikimedia.org/r/533135 (owner: 10Aaron Schulz) [20:16:47] (03CR) 10Jforrester: [C: 03+2] "I think declaring 1.0.0 might be premature. :-) Was leaving for others to review, but I'm happy to merge this now." [tools/phan] - 10https://gerrit.wikimedia.org/r/531511 (owner: 10Daimona Eaytoy) [20:17:18] (03Merged) 10jenkins-bot: Upgrade phan to 2.2.11 [tools/phan] - 10https://gerrit.wikimedia.org/r/531511 (owner: 10Daimona Eaytoy) [20:17:20] (03CR) 10Reedy: [C: 04-1] "But also related to the previous conversation.... Just having disabled text boxes isn't a good UI, especially if JS is disabled... It just" [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/508788 (https://phabricator.wikimedia.org/T218211) (owner: 10ItSpiderman) [20:17:57] (03Merged) 10jenkins-bot: INSTALL/RELEASE-NOTES-1.34: Add required PHP extensions [core] - 10https://gerrit.wikimedia.org/r/532811 (owner: 10Jforrester) [20:18:08] (03CR) 10Jforrester: [C: 03+2] phpunit: Don't bother resetting unused global in UploadFromUrlTestSuite [core] - 10https://gerrit.wikimedia.org/r/533696 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [20:21:23] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/533707 (owner: 10D3r1ck01) [20:27:28] (03CR) 10Reedy: [C: 04-1] "Uncaught TypeError: Cannot read property 'children' of undefined" [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/508788 (https://phabricator.wikimedia.org/T218211) (owner: 10ItSpiderman) [20:28:44] (03CR) 10jenkins-bot: Setup: Remove debug message for "caches" [core] - 10https://gerrit.wikimedia.org/r/533701 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [20:29:46] 10Wiki-Loves-Monuments (2019): Switch Portugal to Wikidata at the Monuments Database - https://phabricator.wikimedia.org/T231727 (10Darwinius) [20:30:27] 10MediaWiki-extensions-General, 10translatewiki.net, 10I18n, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), and 2 others: Move all apihelp translatable messages to separate files - https://phabricator.wikimedia.org/T189982 (10Amire80) [20:30:39] (03CR) 10D3r1ck01: Fix PhpStorm IDE warnings in ServiceWiring.php (034 comments) [core] - 10https://gerrit.wikimedia.org/r/533135 (owner: 10Aaron Schulz) [20:32:05] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/533708 (owner: 10D3r1ck01) [20:33:13] (03CR) 10Krinkle: "The AbuseFilter test fails due to a few global vars being used" [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [20:34:18] (03CR) 10Krinkle: [C: 03+2] content: Remove unused constant NewsletterContent::NEWSLETTER_MANAGE [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/531300 (owner: 10D3r1ck01) [20:36:00] 10Wiki-Loves-Monuments (2019): Switch Portugal to Wikidata at the Monuments Database - https://phabricator.wikimedia.org/T231727 (10Darwinius) [20:36:53] (03CR) 10Gergő Tisza: "Doesn't seem that scary to me (basically just a custom flag), but it's unnecessary coupling. Why not use your own registry (or a global if" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/529917 (https://phabricator.wikimedia.org/T212082) (owner: 10Daimona Eaytoy) [20:38:47] (03CR) 10Krinkle: "check php" [core] - 10https://gerrit.wikimedia.org/r/532820 (owner: 10D3r1ck01) [20:38:50] (03CR) 10Krinkle: [C: 03+2] jobqueue: Avoid usage of deprecated `MWHttpRequest::factory()` [core] - 10https://gerrit.wikimedia.org/r/532820 (owner: 10D3r1ck01) [20:39:03] (03Merged) 10jenkins-bot: Add ext-dom to composer.json [core] - 10https://gerrit.wikimedia.org/r/526517 (owner: 10Reedy) [20:39:10] (03Merged) 10jenkins-bot: maintenance: Remove cross-wiki purging from rebuildmessages.php [core] - 10https://gerrit.wikimedia.org/r/533658 (owner: 10Krinkle) [20:40:12] (03CR) 10Krinkle: [C: 04-1] "Right, basically a static semaphore effectively that remains within the CA codebase. The job obtains it and raises the flag, then disables" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/529917 (https://phabricator.wikimedia.org/T212082) (owner: 10Daimona Eaytoy) [20:40:53] (03Merged) 10jenkins-bot: phpunit: Don't bother resetting unused global in UploadFromUrlTestSuite [core] - 10https://gerrit.wikimedia.org/r/533696 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [20:40:56] (03Merged) 10jenkins-bot: content: Remove unused constant NewsletterContent::NEWSLETTER_MANAGE [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/531300 (owner: 10D3r1ck01) [20:42:37] (03CR) 10jenkins-bot: INSTALL/RELEASE-NOTES-1.34: Add required PHP extensions [core] - 10https://gerrit.wikimedia.org/r/532811 (owner: 10Jforrester) [20:50:33] (03PS4) 10Krinkle: Migrate HTTP cache from messageMemc to APC [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/533699 (https://phabricator.wikimedia.org/T189966) [20:51:01] (03PS3) 10Krinkle: resourceloader: Move mw.user skeleton from startup to base [core] - 10https://gerrit.wikimedia.org/r/532837 [20:53:01] (03CR) 10Krinkle: [C: 03+2] Use the correct object in onSpecialSearchSetupEngine [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/512499 (https://phabricator.wikimedia.org/T224353) (owner: 10Reedy) [20:53:47] (03PS9) 10Esanders: Update phpCharToUpper.json based on current differences [core] - 10https://gerrit.wikimedia.org/r/507793 [20:54:12] (03PS22) 10Krinkle: Make most special pages class names match filename [core] - 10https://gerrit.wikimedia.org/r/503759 (owner: 10Reedy) [20:54:51] (03CR) 10jerkins-bot: [V: 04-1] Make most special pages class names match filename [core] - 10https://gerrit.wikimedia.org/r/503759 (owner: 10Reedy) [20:55:21] (03CR) 10Esanders: "Since this patch was pushed, we have migrated to php7, so I've rebuilt with a later version of HHVM. This appears to fix the Georgian issu" [core] - 10https://gerrit.wikimedia.org/r/507793 (owner: 10Esanders) [20:55:40] (03CR) 10jerkins-bot: [V: 04-1] Make most special pages class names match filename [core] - 10https://gerrit.wikimedia.org/r/503759 (owner: 10Reedy) [20:55:50] (03CR) 10jerkins-bot: [V: 04-1] Make most special pages class names match filename [core] - 10https://gerrit.wikimedia.org/r/503759 (owner: 10Reedy) [20:55:57] (03CR) 10jerkins-bot: [V: 04-1] Make most special pages class names match filename [core] - 10https://gerrit.wikimedia.org/r/503759 (owner: 10Reedy) [20:57:59] (03PS23) 10Krinkle: Make most special pages class names match filename [core] - 10https://gerrit.wikimedia.org/r/503759 (owner: 10Reedy) [20:58:34] (03CR) 10jenkins-bot: Add ext-dom to composer.json [core] - 10https://gerrit.wikimedia.org/r/526517 (owner: 10Reedy) [20:59:04] (03CR) 10Krinkle: [C: 03+1] Make most special pages class names match filename [core] - 10https://gerrit.wikimedia.org/r/503759 (owner: 10Reedy) [21:00:09] (03CR) 10Krinkle: "We haven't upgraded HHVM though, we run 3.18. I don't know if that matters? Note that 3.18 is available on https://3v4l.org/ in case that " [core] - 10https://gerrit.wikimedia.org/r/507793 (owner: 10Esanders) [21:00:47] (03CR) 10Krinkle: [C: 03+2] Fix function name mismatch, `wfWikiId()` -> `wfWikiID()` [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/533707 (owner: 10D3r1ck01) [21:00:55] (03CR) 10Krinkle: [C: 03+2] Fix function name mismatch, `wfWikiId()` -> `wfWikiID()` [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/533706 (owner: 10D3r1ck01) [21:01:02] (03CR) 10Krinkle: [C: 03+2] Fix function name mismatch, `wfWikiId()` -> `wfWikiID()` [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/533708 (owner: 10D3r1ck01) [21:02:31] (03PS1) 10D3r1ck01: Fix method/function names case mismatch in core files [core] - 10https://gerrit.wikimedia.org/r/533712 [21:09:12] (03Merged) 10jenkins-bot: jobqueue: Avoid usage of deprecated `MWHttpRequest::factory()` [core] - 10https://gerrit.wikimedia.org/r/532820 (owner: 10D3r1ck01) [21:09:14] (03CR) 10jerkins-bot: [V: 04-1] Use the correct object in onSpecialSearchSetupEngine [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/512499 (https://phabricator.wikimedia.org/T224353) (owner: 10Reedy) [21:09:54] (03PS1) 10Krinkle: registration: Avoid redundant LBYL check in ExtensionRegistry::queue() [core] - 10https://gerrit.wikimedia.org/r/533713 [21:10:07] (03PS2) 10Krinkle: registration: Avoid redundant LBYL check in ExtensionRegistry::queue() [core] - 10https://gerrit.wikimedia.org/r/533713 (https://phabricator.wikimedia.org/T187154) [21:11:59] (03CR) 10Daimona Eaytoy: "> I think declaring 1.0.0 might be premature. :-) Was leaving for" [tools/phan] - 10https://gerrit.wikimedia.org/r/531511 (owner: 10Daimona Eaytoy) [21:12:19] (03CR) 10jenkins-bot: maintenance: Remove cross-wiki purging from rebuildmessages.php [core] - 10https://gerrit.wikimedia.org/r/533658 (owner: 10Krinkle) [21:12:44] (03PS1) 10Paladox: objectcache: avoid using deprecated phpredis::delete() alias [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/533714 [21:13:21] (03PS3) 10Reedy: Use the correct object in onSpecialSearchSetupEngine [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/512499 (https://phabricator.wikimedia.org/T224353) [21:15:37] (03PS2) 10Paladox: objectcache: avoid using deprecated phpredis::delete() alias [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/533714 [21:16:14] (03CR) 10jerkins-bot: [V: 04-1] Use the correct object in onSpecialSearchSetupEngine [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/512499 (https://phabricator.wikimedia.org/T224353) (owner: 10Reedy) [21:16:15] 10phan: Upgrade phan/phan for our config - https://phabricator.wikimedia.org/T228257 (10Daimona) Note there was also https://gerrit.wikimedia.org/r/#/c/mediawiki/tools/phan/+/531511/ (now merged) which I forgot to tag. Anyway, let's not make this a tracking task. We can call it resolved as soon as the new versi... [21:16:43] (03PS4) 10Reedy: Use the correct object in onSpecialSearchSetupEngine [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/512499 (https://phabricator.wikimedia.org/T224353) [21:19:06] 10MobileFrontend, 10Editing Design, 10MinervaNeue, 10VisualEditor, and 3 others: Consider changing mobile site header height (and overlay header height) from 3.35em (53.6px) to 3em (48px) - https://phabricator.wikimedia.org/T215426 (10Esanders) 05Resolved→03Open That's fine for the grey site-header, bu... [21:19:27] (03Merged) 10jenkins-bot: Fix function name mismatch, `wfWikiId()` -> `wfWikiID()` [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/533707 (owner: 10D3r1ck01) [21:19:30] (03Merged) 10jenkins-bot: Fix function name mismatch, `wfWikiId()` -> `wfWikiID()` [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/533706 (owner: 10D3r1ck01) [21:19:48] 10MediaWiki-Cache, 10Patch-For-Review: PHPRedis module >= 5.0.0 throws deprecation warnings for delete(). - https://phabricator.wikimedia.org/T227461 (10Paladox) [21:19:50] 10MediaWiki-Cache, 10Technical-Debt: Deprecated: Function Redis::delete() is deprecated in /srv/mediawiki/w/includes/libs/redis/RedisConnRef.php on line 131 - https://phabricator.wikimedia.org/T230273 (10Paladox) [21:20:01] (03PS3) 10Paladox: objectcache: avoid using deprecated phpredis::delete() alias [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/533714 (https://phabricator.wikimedia.org/T227461) [21:20:23] (03PS1) 10Pwirth: Init commit [extensions/BlueSpiceSocialTimelineUpdate] - 10https://gerrit.wikimedia.org/r/533715 [21:20:27] 10MediaWiki-Cache, 10Patch-For-Review: PHPRedis module >= 5.0.0 throws deprecation warnings for delete(). - https://phabricator.wikimedia.org/T227461 (10Paladox) Is fixed with https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/527212/ but backported to REL1_33 with https://gerrit.wikimedia.org/r/#/c/mediawiki... [21:23:31] (03CR) 10jenkins-bot: Fix function name mismatch, `wfWikiId()` -> `wfWikiID()` [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/533707 (owner: 10D3r1ck01) [21:25:34] (03CR) 10jenkins-bot: Fix function name mismatch, `wfWikiId()` -> `wfWikiID()` [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/533706 (owner: 10D3r1ck01) [21:25:58] (03CR) 10Paladox: "Should this be backported to 1.33?" [core] - 10https://gerrit.wikimedia.org/r/520148 (https://phabricator.wikimedia.org/T113916) (owner: 10Aaron Schulz) [21:26:29] (03CR) 10jenkins-bot: phpunit: Don't bother resetting unused global in UploadFromUrlTestSuite [core] - 10https://gerrit.wikimedia.org/r/533696 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [21:26:37] (03Merged) 10jenkins-bot: Fix function name mismatch, `wfWikiId()` -> `wfWikiID()` [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/533708 (owner: 10D3r1ck01) [21:30:00] (03CR) 10Daimona Eaytoy: "Hm, so basically a static variable in the job class, populated by the job and read by the hook. And its elements could be the IDs of the u" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/529917 (https://phabricator.wikimedia.org/T212082) (owner: 10Daimona Eaytoy) [21:30:06] (03PS1) 10Krinkle: ProxyLookup: Optimise in_array in isConfiguredProxy() [core] - 10https://gerrit.wikimedia.org/r/533716 (https://phabricator.wikimedia.org/T189966) [21:31:16] 10MediaWiki-Page-editing, 10Patch-For-Review: Edit conflict automatic resolution can silently produce unexpected results - https://phabricator.wikimedia.org/T76997 (10Alsee) Another example was posted in T223433 and it's worth noting here. I'll detail the three edits involved: # [[ https://cs.wikipedia.org/w/... [21:31:25] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/533712 (owner: 10D3r1ck01) [21:31:53] (03CR) 10jerkins-bot: [V: 04-1] registration: Avoid redundant LBYL check in ExtensionRegistry::queue() [core] - 10https://gerrit.wikimedia.org/r/533713 (https://phabricator.wikimedia.org/T187154) (owner: 10Krinkle) [21:32:19] (03CR) 10Krinkle: [C: 04-1] "I meant like this:" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/529917 (https://phabricator.wikimedia.org/T212082) (owner: 10Daimona Eaytoy) [21:33:54] (03CR) 10Krinkle: [C: 04-1] "One could make it stricter by making it an array with the userID in it. And even more strict by making the hook "consume" the array, so th" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/529917 (https://phabricator.wikimedia.org/T212082) (owner: 10Daimona Eaytoy) [21:35:33] (03PS3) 10Krinkle: registration: Avoid redundant LBYL check in ExtensionRegistry::queue() [core] - 10https://gerrit.wikimedia.org/r/533713 (https://phabricator.wikimedia.org/T187154) [21:36:24] (03PS1) 10Pwirth: Init commit [extensions/BlueSpiceSocialTags] - 10https://gerrit.wikimedia.org/r/533717 [21:40:01] (03CR) 10jerkins-bot: [V: 04-1] Init commit [extensions/BlueSpiceSocialTags] - 10https://gerrit.wikimedia.org/r/533717 (owner: 10Pwirth) [21:46:20] (03PS1) 10Krinkle: objectcache: Optimise array_map in MemcachedBagOStuff::makeKey() [core] - 10https://gerrit.wikimedia.org/r/533718 [21:46:39] (03CR) 10jenkins-bot: jobqueue: Avoid usage of deprecated `MWHttpRequest::factory()` [core] - 10https://gerrit.wikimedia.org/r/532820 (owner: 10D3r1ck01) [21:46:52] (03PS2) 10Pwirth: Init commit [extensions/BlueSpiceSocialTags] - 10https://gerrit.wikimedia.org/r/533717 [21:50:47] (03CR) 10jerkins-bot: [V: 04-1] Init commit [extensions/BlueSpiceSocialTags] - 10https://gerrit.wikimedia.org/r/533717 (owner: 10Pwirth) [21:55:32] (03PS3) 10Pwirth: Init commit [extensions/BlueSpiceSocialTags] - 10https://gerrit.wikimedia.org/r/533717 [21:57:13] (03CR) 10Aaron Schulz: "Tested with --use-filebackend=global-fs and --use-filebackend=global-swift (https://hub.docker.com/r/morrisjobke/docker-swift-onlyone/)" [core] - 10https://gerrit.wikimedia.org/r/533622 (owner: 10Aaron Schulz) [21:59:52] (03CR) 10jerkins-bot: [V: 04-1] Init commit [extensions/BlueSpiceSocialTags] - 10https://gerrit.wikimedia.org/r/533717 (owner: 10Pwirth) [22:01:31] (03PS4) 10Pwirth: Init commit [extensions/BlueSpiceSocialTags] - 10https://gerrit.wikimedia.org/r/533717 [22:01:58] (03PS1) 10Aaron Schulz: [WIP] filebackend: add xattr_* method support to FSFileBackend [core] - 10https://gerrit.wikimedia.org/r/533719 [22:04:27] (03CR) 10Dbarratt: Allow CompositeBlock::appliesToRight to return null when unsure (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533575 (https://phabricator.wikimedia.org/T229417) (owner: 10Tchanders) [22:05:16] (03CR) 10jerkins-bot: [V: 04-1] Init commit [extensions/BlueSpiceSocialTags] - 10https://gerrit.wikimedia.org/r/533717 (owner: 10Pwirth) [22:05:59] 10Phabricator: Phabricator should reuse confirmed MediaWiki email during registration - https://phabricator.wikimedia.org/T230590 (10Aklapper) p:05Triage→03Low [22:06:58] 10Phabricator: Some users can't add the fr-tech private task form to their task selection menu. - https://phabricator.wikimedia.org/T229628 (10Aklapper) 05Stalled→03Declined >>! In T229628#5387901, @Aklapper wrote: > can you copy the response from the Typeahead request, and paste it here? No reply, hence un... [22:07:44] (03PS1) 10Krinkle: Setup: Move wgActionPath logic to PathRouter [core] - 10https://gerrit.wikimedia.org/r/533720 (https://phabricator.wikimedia.org/T189966) [22:08:25] 10Phabricator: Delete unused custom /src/other/CustomLoginHandler.php in Phab extensions - https://phabricator.wikimedia.org/T228518 (10Aklapper) >>! In T228518#5423948, @Mainframe98 wrote: > Is there anything left to do for D1151? I couldn't find any instructions on what to do once the revision has been accepte... [22:08:47] (03PS2) 10Krinkle: Setup: Move wgActionPath logic to PathRouter [core] - 10https://gerrit.wikimedia.org/r/533720 (https://phabricator.wikimedia.org/T189966) [22:10:42] (03PS5) 10Pwirth: Init commit [extensions/BlueSpiceSocialTags] - 10https://gerrit.wikimedia.org/r/533717 [22:11:00] 10Who-Wrote-That: [WWT] 'Unrecognized manifest key 'browser_specific_settings'.' on Chrome Extensions Error page - https://phabricator.wikimedia.org/T231732 (10RhinosF1) [22:22:18] (03PS1) 10Artrix: [abusefilter] Fix abusefilter-privatedetails right [vagrant] - 10https://gerrit.wikimedia.org/r/533721 [22:23:05] 10Phabricator: Story point default value should be "" rather than 0 for tasks created via the advanced form - https://phabricator.wikimedia.org/T231624 (10Urbanecm) "Access Denied" when viewing the link, but seems to work, thanks, Andre! [22:29:22] (03CR) 10Pwirth: [C: 03+2] Archive the BlueSpiceUserPreferences extension [extensions/BlueSpiceUserPreferences] - 10https://gerrit.wikimedia.org/r/533636 (https://phabricator.wikimedia.org/T197898) (owner: 10D3r1ck01) [22:31:27] (03PS1) 10Krinkle: resourceloader: Drop support for low Suhosin 'max_value_length' values [core] - 10https://gerrit.wikimedia.org/r/533722 [22:31:39] (03CR) 10jerkins-bot: [V: 04-1] Setup: Move wgActionPath logic to PathRouter [core] - 10https://gerrit.wikimedia.org/r/533720 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [22:32:55] (03PS3) 10Krinkle: Setup: Move wgActionPath logic to PathRouter [core] - 10https://gerrit.wikimedia.org/r/533720 (https://phabricator.wikimedia.org/T189966) [22:33:28] (03CR) 10Dbarratt: [C: 03+1] "This looks good to me, tested locally and works perfectly. Only doing +1 because of Mooeypoo's -1." [core] - 10https://gerrit.wikimedia.org/r/533575 (https://phabricator.wikimedia.org/T229417) (owner: 10Tchanders) [22:34:23] (03Merged) 10jenkins-bot: Archive the BlueSpiceUserPreferences extension [extensions/BlueSpiceUserPreferences] - 10https://gerrit.wikimedia.org/r/533636 (https://phabricator.wikimedia.org/T197898) (owner: 10D3r1ck01) [22:35:06] (03PS2) 10Krinkle: resourceloader: Drop support for low Suhosin 'max_value_length' values [core] - 10https://gerrit.wikimedia.org/r/533722 [22:35:26] (03CR) 10Krinkle: resourceloader: Drop support for low Suhosin 'max_value_length' values (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533722 (owner: 10Krinkle) [22:37:01] 10BlueSpice, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, 10Patch-For-Review: Archive "BlueSpiceUserPreferences" extension - https://phabricator.wikimedia.org/T197898 (10D3r1ck01) [22:39:53] 10BlueSpice, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, 10Patch-For-Review: Archive "BlueSpiceUserPreferences" extension - https://phabricator.wikimedia.org/T197898 (10D3r1ck01) [22:43:36] (03PS1) 10Krinkle: Setup: Move MWDebug logic to MWDebug.php [core] - 10https://gerrit.wikimedia.org/r/533723 (https://phabricator.wikimedia.org/T189966) [22:52:02] (03PS2) 10Krinkle: Setup: Move MWDebug logic to MWDebug.php [core] - 10https://gerrit.wikimedia.org/r/533723 (https://phabricator.wikimedia.org/T189966) [22:52:45] (03PS4) 10Dbarratt: Add a configuration option to make API requests allow cross-origin requests [core] - 10https://gerrit.wikimedia.org/r/531966 (https://phabricator.wikimedia.org/T210790) [22:53:41] 10TimedMediaHandler, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10phan: Add phan to TimedMediaHandler extension - https://phabricator.wikimedia.org/T224766 (10Umherirrender) 05Open→03Resolved [22:54:50] (03PS4) 10Krinkle: Deprecated $wgContLang global no more! [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/528141 (owner: 10Jack Phoenix) [22:55:16] (03PS5) 10Krinkle: Deprecated $wgContLang global no more! [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/528141 (owner: 10Jack Phoenix) [22:55:34] (03PS6) 10Krinkle: Deprecated $wgContLang global no more! [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/528141 (owner: 10Jack Phoenix) [22:56:01] (03PS7) 10Krinkle: Deprecated $wgContLang global no more! [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/528141 (owner: 10Jack Phoenix) [22:56:03] (03CR) 10Krinkle: [C: 03+2] Deprecated $wgContLang global no more! [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/528141 (owner: 10Jack Phoenix) [22:58:12] (03PS2) 10Krinkle: Remove some uses of $wgTitle in core [core] - 10https://gerrit.wikimedia.org/r/263030 (https://phabricator.wikimedia.org/T25307) (owner: 10TTO) [22:58:41] (03CR) 10jerkins-bot: [V: 04-1] Remove some uses of $wgTitle in core [core] - 10https://gerrit.wikimedia.org/r/263030 (https://phabricator.wikimedia.org/T25307) (owner: 10TTO) [22:58:56] (03Abandoned) 10Krinkle: Remove some uses of $wgTitle in core [core] - 10https://gerrit.wikimedia.org/r/263030 (https://phabricator.wikimedia.org/T25307) (owner: 10TTO) [22:58:58] (03CR) 10jenkins-bot: Remove some uses of $wgTitle in core [core] - 10https://gerrit.wikimedia.org/r/263030 (https://phabricator.wikimedia.org/T25307) (owner: 10TTO) [23:01:42] (03Merged) 10jenkins-bot: Deprecated $wgContLang global no more! [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/528141 (owner: 10Jack Phoenix) [23:03:24] (03CR) 10jenkins-bot: Deprecated $wgContLang global no more! [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/528141 (owner: 10Jack Phoenix) [23:10:35] 10MediaWiki-User-management, 10Anti-Harassment (The Letter Song), 10Patch-For-Review: [BUG] Composite blocks do not block deleting pages - https://phabricator.wikimedia.org/T229417 (10Urbanecm) @dom_walden Why this wasn't created as a private (security protected) task? Even it is probably hard to exploit, it... [23:11:05] (03PS1) 10D3r1ck01: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/533724 [23:13:19] (03CR) 10jerkins-bot: [V: 04-1] Setup: Move MWDebug logic to MWDebug.php [core] - 10https://gerrit.wikimedia.org/r/533723 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [23:16:59] (03PS3) 10Krinkle: Setup: Move MWDebug logic to MWDebug.php [core] - 10https://gerrit.wikimedia.org/r/533723 (https://phabricator.wikimedia.org/T189966) [23:17:55] (03PS2) 10Krinkle: Fix method/function names case mismatch in core files [core] - 10https://gerrit.wikimedia.org/r/533712 (owner: 10D3r1ck01) [23:18:06] (03CR) 10Krinkle: [C: 03+2] Fix method/function names case mismatch in core files [core] - 10https://gerrit.wikimedia.org/r/533712 (owner: 10D3r1ck01) [23:19:01] 10Phabricator: Merge the Phabricator Priority values "Low" and "Lowest" - https://phabricator.wikimedia.org/T228759 (10Urbanecm) >>! In T228759#5456352, @Aklapper wrote: >> Redefining it as "can sit here for any time", or "not urgent at all" is a better thing to do IMO > > Yes, personally I am fine with that de... [23:19:08] 10Phabricator: Merge the Phabricator Priority values "Low" and "Lowest" - https://phabricator.wikimedia.org/T228759 (10Urbanecm) [23:19:11] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/533724 (owner: 10D3r1ck01) [23:22:40] 10Phabricator: Rename Phabricator's "Normal" Priority field value to "Medium" - https://phabricator.wikimedia.org/T228757 (10Urbanecm) +1 [23:22:50] (03CR) 10Krinkle: [C: 03+2] Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/533724 (owner: 10D3r1ck01) [23:23:35] (03PS2) 10Umherirrender: Remove unneeded redeclaration of mPage in Article subclasses [core] - 10https://gerrit.wikimedia.org/r/519756 [23:23:54] (03PS2) 10Umherirrender: Unpack arrays on variadic arguments [core] - 10https://gerrit.wikimedia.org/r/519758 [23:26:55] (03PS2) 10Umherirrender: Fix key access in NoWriteWatchedItemStore::countWatchersMultiple [core] - 10https://gerrit.wikimedia.org/r/519769 [23:27:17] 10Phabricator, 10Documentation: Document workboard column triggers - https://phabricator.wikimedia.org/T227300 (10Urbanecm) [bulk] Setting points to "", given it doesn't make any sense to have them as "0". [23:27:20] 10Phabricator: https://phabricator.wikimedia.org/tag/MediaWiki-extensions-LiquidThreads/ is a 404 but project exists - https://phabricator.wikimedia.org/T223540 (10Urbanecm) [bulk] Setting points to "", given it doesn't make any sense to have them as "0". [23:27:22] 10Phabricator, 10Documentation: Document subtypes / task types in Phabricator - https://phabricator.wikimedia.org/T224417 (10Urbanecm) [bulk] Setting points to "", given it doesn't make any sense to have them as "0". [23:27:25] 10Phabricator: Rename Phabricator's "Normal" Priority field value to "Medium" - https://phabricator.wikimedia.org/T228757 (10Urbanecm) [bulk] Setting points to "", given it doesn't make any sense to have them as "0". [23:27:28] 10Phabricator: Delete unused custom /src/other/CustomLoginHandler.php in Phab extensions - https://phabricator.wikimedia.org/T228518 (10Urbanecm) [bulk] Setting points to "", given it doesn't make any sense to have them as "0". [23:27:35] 10Phabricator, 10Operations, 10Traffic, 10Release-Engineering-Team (Development services), and 2 others: Prepare Phame to support heavy traffic for a Tech Department blog - https://phabricator.wikimedia.org/T226044 (10Urbanecm) [bulk] Setting points to "", given it doesn't make any sense to have them as "0". [23:27:56] 10Phabricator: move_project script allows using --keep-members for milestones which cannot have members - https://phabricator.wikimedia.org/T224420 (10Urbanecm) [23:28:00] 10Phabricator: move_project script does not check if task is in both future parent and future subproject and does not remove future parent project - https://phabricator.wikimedia.org/T224421 (10Urbanecm) [23:28:45] (03PS1) 10D3r1ck01: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/533725 [23:38:36] 10Phabricator, 10Documentation: Document workboard column triggers - https://phabricator.wikimedia.org/T227300 (10Urbanecm) Documentation is going to be useful, I was thinking "why I don't see it in #user-urbanecm". I wanted to make a rule "when a task is dropped into Backlog column and has xx project, move to... [23:38:42] 10Repository-Admins: Add `D3r1ck01` to #Repository-Admins to deactivate Phab Diffusion repos - https://phabricator.wikimedia.org/T231721 (10Aklapper) [23:39:07] 10Phabricator, 10Documentation: Document workboard column triggers - https://phabricator.wikimedia.org/T227300 (10Urbanecm) >>! In T227300#5307525, @MarcoAurelio wrote: > Triggers do seem like some sort of global Herald rules but limited to a specific column in a workboard. As such, Triggers should probably //... [23:40:59] (03Merged) 10jenkins-bot: Fix method/function names case mismatch in core files [core] - 10https://gerrit.wikimedia.org/r/533712 (owner: 10D3r1ck01) [23:41:01] (03Merged) 10jenkins-bot: Avoid usage of deprecated $wgContLang global (dep in 1.32) [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/533724 (owner: 10D3r1ck01) [23:43:00] 10MediaWiki-User-preferences: maxlength html form values are not used in preferences - https://phabricator.wikimedia.org/T72974 (10Aklapper) 05Open→03Declined Declining as per last comment and in favor of T73026. [23:43:02] 10MediaWiki-MediaWiki-UI: Determine how to set input[type=number] visual width (and maybe visual widths of other inputs) - https://phabricator.wikimedia.org/T72973 (10Aklapper) [23:43:12] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/533725 (owner: 10D3r1ck01) [23:43:45] 10MediaWiki-HTMLForm: Allow input min/max form validation attributes when browser support is there/can be polyfilled - https://phabricator.wikimedia.org/T73026 (10Aklapper) [23:44:04] 10Phabricator, 10Documentation: Document workboard column triggers - https://phabricator.wikimedia.org/T227300 (10DannyS712) >>! In T227300#5456702, @Urbanecm wrote: >>>! In T227300#5307525, @MarcoAurelio wrote: >> Triggers do seem like some sort of global Herald rules but limited to a specific column in a wor... [23:45:43] 10Phabricator: Add custom policy to access denied message - https://phabricator.wikimedia.org/T231734 (10Urbanecm) [23:47:09] 10MediaWiki-User-preferences: Add "Switch view" for CSS/JS/Lua pages or user preference for that - https://phabricator.wikimedia.org/T12621 (10Aklapper) p:05Normal→03Low [23:48:05] 10Accessibility, 10MediaWiki-User-preferences: optional background colour aids people with dyslexia - https://phabricator.wikimedia.org/T45677 (10Aklapper) p:05Normal→03Low [23:50:16] 10Phabricator, 10Documentation: Document workboard column triggers - https://phabricator.wikimedia.org/T227300 (10Urbanecm) >>! In T227300#5456702, @Urbanecm wrote: >>>! In T227300#5307525, @MarcoAurelio wrote: >> Triggers do seem like some sort of global Herald rules but limited to a specific column in a work... [23:51:31] 10Phabricator, 10Documentation: Document workboard column triggers - https://phabricator.wikimedia.org/T227300 (10Urbanecm) >>! In T227300#5456717, @DannyS712 wrote: >>>! In T227300#5456702, @Urbanecm wrote: >>>>! In T227300#5307525, @MarcoAurelio wrote: >>> Triggers do seem like some sort of global Herald rul... [23:51:41] 10Phabricator: Merge the Phabricator Priority values "Low" and "Lowest" - https://phabricator.wikimedia.org/T228759 (10Aklapper) I don't see any "its own place" if nobody can explain how all the current and discrete Priority values are realistically used and isolated against each other. > Could you please expla... [23:52:23] (03CR) 10Zoranzoki21: [C: 03+1] [abusefilter] Fix abusefilter-privatedetails right [vagrant] - 10https://gerrit.wikimedia.org/r/533721 (owner: 10Artrix) [23:54:22] 10Phabricator: Merge the Phabricator Priority values "Low" and "Lowest" - https://phabricator.wikimedia.org/T228759 (10Urbanecm) >>! In T228759#5456749, @Aklapper wrote: > I don't see any "its own place" if nobody can explain how all the current and discrete Priority values are realistically used and isolated ag... [23:54:39] 10Phabricator, 10Documentation: Document workboard column triggers - https://phabricator.wikimedia.org/T227300 (10DannyS712) >>! In T227300#5456747, @Urbanecm wrote: >>>! In T227300#5456717, @DannyS712 wrote: >>>>! In T227300#5456702, @Urbanecm wrote: >>>>>! In T227300#5307525, @MarcoAurelio wrote: >>>> Trigge... [23:55:37] 10Phabricator, 10Documentation: Document workboard column triggers - https://phabricator.wikimedia.org/T227300 (10Urbanecm) I guess so, I'm not a phabricator dev, so can't say with certainity. PS: Explain "not work" when reporting broken stuff in the future please, it could save debug tasks, among other things... [23:55:41] (03CR) 10Legoktm: [C: 04-1] "For background, this was added in 6fb86c5d80e because of the extra warnings before hitting the exception. That should no longer be an issu" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533713 (https://phabricator.wikimedia.org/T187154) (owner: 10Krinkle) [23:55:43] 10Who-Wrote-That: 'Unrecognized manifest key 'browser_specific_settings'.' on Chrome Extensions Error page - https://phabricator.wikimedia.org/T231732 (10Aklapper) [23:55:45] (03CR) 10jenkins-bot: Fix method/function names case mismatch in core files [core] - 10https://gerrit.wikimedia.org/r/533712 (owner: 10D3r1ck01)