[00:09:45] (03PS11) 10Krinkle: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) [00:10:22] (03PS4) 10DannyS712: Add namespace restrictions to `meta=siteinfo&siprop=namespaces` API result [core] - 10https://gerrit.wikimedia.org/r/533337 (https://phabricator.wikimedia.org/T73952) [00:15:20] (03PS1) 10Jdrewniak: [WIP] Customize mw-ui-icon for minerva to ensure better touch target size [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533360 [00:15:35] (03Merged) 10jenkins-bot: logging: Deprecate LogEventsList::$mDefaultQuery member [core] - 10https://gerrit.wikimedia.org/r/533334 (owner: 10D3r1ck01) [00:16:53] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [00:16:56] (03PS1) 10Nray: Fix iOS input text zoom bug on rcfilters input [core] - 10https://gerrit.wikimedia.org/r/533361 (https://phabricator.wikimedia.org/T231049) [00:17:10] (03PS12) 10Krinkle: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) [00:17:23] (03PS13) 10Krinkle: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) [00:19:08] (03PS14) 10Krinkle: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) [00:23:35] (03Merged) 10jenkins-bot: Use the GetUserBlock hook instead of UserIsHidden [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/527251 (https://phabricator.wikimedia.org/T228950) (owner: 10Tchanders) [00:23:47] (03CR) 10jerkins-bot: [V: 04-1] Fix iOS input text zoom bug on rcfilters input [core] - 10https://gerrit.wikimedia.org/r/533361 (https://phabricator.wikimedia.org/T231049) (owner: 10Nray) [00:23:56] (03PS3) 10DannyS712: Add `MassMessageShouldPostMessage` hook [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/533347 (https://phabricator.wikimedia.org/T231607) [00:25:02] (03CR) 10DannyS712: "> Looks good, but I don't have this extension set up locally and I" [extensions/Linter] - 10https://gerrit.wikimedia.org/r/532129 (https://phabricator.wikimedia.org/T172703) (owner: 10DannyS712) [00:25:30] (03CR) 10jerkins-bot: [V: 04-1] Add namespace restrictions to `meta=siteinfo&siprop=namespaces` API result [core] - 10https://gerrit.wikimedia.org/r/533337 (https://phabricator.wikimedia.org/T73952) (owner: 10DannyS712) [00:26:16] (03PS2) 10Nray: Fix iOS input text zoom bug on rcfilters input [core] - 10https://gerrit.wikimedia.org/r/533361 (https://phabricator.wikimedia.org/T231049) [00:26:18] (03CR) 10jenkins-bot: Use the GetUserBlock hook instead of UserIsHidden [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/527251 (https://phabricator.wikimedia.org/T228950) (owner: 10Tchanders) [00:27:17] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [00:27:24] (03PS10) 10Ppchelko: Rework ApiUploadTest [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) [00:27:31] (03PS5) 10DannyS712: Add namespace restrictions to `meta=siteinfo&siprop=namespaces` API result [core] - 10https://gerrit.wikimedia.org/r/533337 (https://phabricator.wikimedia.org/T73952) [00:30:13] (03PS15) 10Krinkle: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) [00:31:04] (03CR) 10jerkins-bot: [V: 04-1] Add `MassMessageShouldPostMessage` hook [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/533347 (https://phabricator.wikimedia.org/T231607) (owner: 10DannyS712) [00:33:54] (03PS1) 10Jdlrobson: Use core table of contents in Minerva [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533362 [00:34:27] (03CR) 10jerkins-bot: [V: 04-1] Use core table of contents in Minerva [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533362 (owner: 10Jdlrobson) [00:34:44] (03PS1) 10Jdlrobson: Remove table of contents handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) [00:35:14] (03CR) 10jerkins-bot: [V: 04-1] Remove table of contents handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) (owner: 10Jdlrobson) [00:35:30] (03CR) 10jerkins-bot: [V: 04-1] Remove table of contents handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) (owner: 10Jdlrobson) [00:36:12] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [00:37:15] (03Abandoned) 10Jdlrobson: Table of Contents styles moved to MobileFrontend where JS is defined [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533069 (owner: 10Jdlrobson) [00:38:28] (03PS2) 10Jdlrobson: Remove table of contents handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) [00:38:49] (03CR) 10jerkins-bot: [V: 04-1] Remove table of contents handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) (owner: 10Jdlrobson) [00:38:58] (03CR) 10jerkins-bot: [V: 04-1] Remove table of contents handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) (owner: 10Jdlrobson) [00:40:32] (03CR) 10jenkins-bot: logging: Deprecate LogEventsList::$mDefaultQuery member [core] - 10https://gerrit.wikimedia.org/r/533334 (owner: 10D3r1ck01) [00:41:10] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [00:45:39] (03PS4) 10DannyS712: Add `MassMessageShouldPostMessage` hook [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/533347 (https://phabricator.wikimedia.org/T231607) [00:50:18] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [00:50:25] (03CR) 10jerkins-bot: [V: 04-1] Rework ApiUploadTest [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) (owner: 10Ppchelko) [00:55:07] (03PS16) 10Krinkle: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) [00:55:49] (03CR) 10Jforrester: [C: 04-1] "Mobile-specific horrible hacks that change the layout of the form should be in mobile-specific stylesheets. If you think it's right to set" [core] - 10https://gerrit.wikimedia.org/r/533361 (https://phabricator.wikimedia.org/T231049) (owner: 10Nray) [01:06:22] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [01:06:40] (03PS1) 10Dbarratt: Read the block status from the replicas [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/533365 (https://phabricator.wikimedia.org/T231617) [01:08:56] (03CR) 10Krinkle: "Just to confirm - this check is only used to decide what to display, it is not used for during the Thanks action itself to decide whether " [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/533365 (https://phabricator.wikimedia.org/T231617) (owner: 10Dbarratt) [01:10:16] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [01:10:40] (03CR) 10Dbarratt: "> Patch Set 1:" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/533365 (https://phabricator.wikimedia.org/T231617) (owner: 10Dbarratt) [01:11:17] (03CR) 10Jforrester: "Fun." [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [01:11:53] (03CR) 10Jforrester: "Looks like AbuseFilter and Notifications both have unit tests that passed by accident too?" [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [01:15:00] (03PS1) 10Krinkle: resourceloader: Remove Grade C sniffs for WebOS <=1.4 and SymbianOS [core] - 10https://gerrit.wikimedia.org/r/533367 [01:17:30] (03CR) 10Krinkle: "appears so" [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [01:38:00] (03CR) 10Jforrester: [C: 03+2] "Yay, another 29B." [core] - 10https://gerrit.wikimedia.org/r/533367 (owner: 10Krinkle) [01:42:19] (03CR) 10Dbarratt: [C: 04-1] Pass the user and request into BlockManager::getUserBlock (031 comment) [core] - 10https://gerrit.wikimedia.org/r/531946 (https://phabricator.wikimedia.org/T230363) (owner: 10Tchanders) [01:53:00] (03PS2) 10Aaron Schulz: filerepo: define LocalRepo::newFile() to document the return type [core] - 10https://gerrit.wikimedia.org/r/533355 [01:53:02] (03PS5) 10Aaron Schulz: filerepo: make LocalFile*Batch class more robust [core] - 10https://gerrit.wikimedia.org/r/532096 (https://phabricator.wikimedia.org/T231086) [01:57:48] (03PS1) 10Aaron Schulz: lockmanager: sort key by bucket in QuorumLockManager::doLockByType [core] - 10https://gerrit.wikimedia.org/r/533368 [02:00:33] (03Merged) 10jenkins-bot: resourceloader: Remove Grade C sniffs for WebOS <=1.4 and SymbianOS [core] - 10https://gerrit.wikimedia.org/r/533367 (owner: 10Krinkle) [02:03:25] (03CR) 10Isarra: "\o/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) (owner: 10Jdlrobson) [02:06:23] (03PS6) 10Aaron Schulz: filerepo: make LocalFile*Batch class more robust [core] - 10https://gerrit.wikimedia.org/r/532096 (https://phabricator.wikimedia.org/T231086) [02:07:09] (03PS7) 10Aaron Schulz: filerepo: make LocalFile*Batch classes more robust [core] - 10https://gerrit.wikimedia.org/r/532096 (https://phabricator.wikimedia.org/T231086) [02:14:53] (03CR) 10jerkins-bot: [V: 04-1] filerepo: make LocalFile*Batch classes more robust [core] - 10https://gerrit.wikimedia.org/r/532096 (https://phabricator.wikimedia.org/T231086) (owner: 10Aaron Schulz) [02:15:40] (03CR) 10jenkins-bot: resourceloader: Remove Grade C sniffs for WebOS <=1.4 and SymbianOS [core] - 10https://gerrit.wikimedia.org/r/533367 (owner: 10Krinkle) [02:23:09] (03CR) 10jerkins-bot: [V: 04-1] filerepo: make LocalFile*Batch classes more robust [core] - 10https://gerrit.wikimedia.org/r/532096 (https://phabricator.wikimedia.org/T231086) (owner: 10Aaron Schulz) [02:30:39] (03PS1) 10Aaron Schulz: Optimize HashRing to avoid hashing for the common single-location case [core] - 10https://gerrit.wikimedia.org/r/533370 [04:06:03] (03PS3) 10Aaron Schulz: filerepo: define LocalRepo::newFile() to document the return type [core] - 10https://gerrit.wikimedia.org/r/533355 [04:06:05] (03PS8) 10Aaron Schulz: filerepo: make LocalFile*Batch classes more robust [core] - 10https://gerrit.wikimedia.org/r/532096 (https://phabricator.wikimedia.org/T231086) [04:28:52] (03CR) 10jerkins-bot: [V: 04-1] filerepo: make LocalFile*Batch classes more robust [core] - 10https://gerrit.wikimedia.org/r/532096 (https://phabricator.wikimedia.org/T231086) (owner: 10Aaron Schulz) [05:13:17] (03PS1) 10Aaron Schulz: rdbms: add more ScopedCallback::newScopedIgnoreUserAbort() calls [core] - 10https://gerrit.wikimedia.org/r/533373 (https://phabricator.wikimedia.org/T231443) [05:31:27] 10WikiApiary: The table 'text' is full (db-local) - https://phabricator.wikimedia.org/T231626 (10Samwilson) [05:36:34] 10MediaWiki-General, 10Language-Team (Language-2019-July-September), 10Patch-For-Review: Uncaught Wikimedia\Rdbms\DBUnexpectedError: Wikimedia\Rdbms\Database::close: mass commit/rollback of peer transaction required (DBO_TRX set) - https://phabricator.wikimedia.org/T231443 (10aaron) It looks like WebStart.ph... [05:38:12] (03PS9) 10Aaron Schulz: filerepo: make LocalFile*Batch classes more robust [core] - 10https://gerrit.wikimedia.org/r/532096 (https://phabricator.wikimedia.org/T231086) [05:39:18] (03PS1) 10MtMNC: 4.0.0-beta.6: fix avatar/logo i18n [skins/Refreshed] (refreshed4-beta) - 10https://gerrit.wikimedia.org/r/533375 [05:41:02] (03CR) 10MtMNC: [V: 03+2 C: 03+2] 4.0.0-beta.6: fix avatar/logo i18n [skins/Refreshed] (refreshed4-beta) - 10https://gerrit.wikimedia.org/r/533375 (owner: 10MtMNC) [05:46:33] (03PS1) 10Aaron Schulz: Remove redundant ignore_user_abort() call in ApiStashEdit [core] - 10https://gerrit.wikimedia.org/r/533376 [05:46:35] (03PS1) 10Aaron Schulz: Replace unecessary rollbackMasterChangesAndLog() call in doPostOutputShutdown() [core] - 10https://gerrit.wikimedia.org/r/533377 [05:48:52] 10Phabricator: Merge the Phabricator Priority values "Low" and "Lowest" - https://phabricator.wikimedia.org/T228759 (10Urbanecm) This priority has its sense IMO. Redefining it as "can sit here for any time", or "not urgent at all" is a better thing to do IMO, while low priority is for tasks that are more importa... [05:49:47] 10Phabricator: Merge the Phabricator Priority values "Low" and "Lowest" - https://phabricator.wikimedia.org/T228759 (10Urbanecm) p:05Low→03Lowest To give a concrete idea, this is lowest IMO. Can sit here for years, if needed. [05:52:59] (03PS1) 10Pwirth: Fix version [extensions/BlueSpiceSocialComments] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533378 [05:53:31] (03CR) 10Pwirth: [C: 03+2] Fix version [extensions/BlueSpiceSocialComments] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533378 (owner: 10Pwirth) [06:00:52] (03Merged) 10jenkins-bot: Fix version [extensions/BlueSpiceSocialComments] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533378 (owner: 10Pwirth) [06:25:29] (03PS1) 10Pwirth: Add missing author metadata after i18n files merge [extensions/BlueSpiceSocialBlog] - 10https://gerrit.wikimedia.org/r/533380 [06:28:00] 10MediaWiki-extensions-MediaWikiAuth: Better handling of renamed users - https://phabricator.wikimedia.org/T231628 (10Dinoguy1000) [06:31:50] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceSocialBlog] - 10https://gerrit.wikimedia.org/r/533380 (owner: 10Pwirth) [06:45:28] 10MediaWiki-extensions-Translate, 10WMF-Documentation-Working-Group, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03): Error moving translated category on Meta-Wiki - https://phabricator.wikimedia.org/T215202 (10Nikerabbit) Assuming you mean wmf deployment branche... [06:46:27] 10MediaWiki-extensions-Translate, 10WMF-Documentation-Working-Group, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03): Error moving translated category (or any translatable page in a namespace without subpages enabled) - https://phabricator.wikimedia.org/T215202 (1... [06:49:27] (03CR) 10DCausse: [C: 03+2] [cirrus] Allow updating the index when enabling geodata [vagrant] - 10https://gerrit.wikimedia.org/r/533256 (owner: 10DCausse) [06:50:30] 10Utilities-mwdumper: MWDumper loads titles but revisions aren't accessible - https://phabricator.wikimedia.org/T231224 (10Uziel302) https://dumps.wikimedia.org/hewiktionary/20190820/ All pages, current versions only. I am using MediaWiki 1.33.0 You can see the error here: https://meaning.wiki/h/index.php?title=... [07:02:44] (03CR) 10Raimond Spekking: [C: 03+2] Add missing author metadata after i18n files merge [extensions/BlueSpiceSocialBlog] - 10https://gerrit.wikimedia.org/r/533380 (owner: 10Pwirth) [07:04:33] (03PS4) 10Nikerabbit: Use a dummy title in Parser if none is provided [core] - 10https://gerrit.wikimedia.org/r/532558 (https://phabricator.wikimedia.org/T228881) [07:06:58] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/533381 (owner: 10L10n-bot) [07:10:40] (03Merged) 10jenkins-bot: Add missing author metadata after i18n files merge [extensions/BlueSpiceSocialBlog] - 10https://gerrit.wikimedia.org/r/533380 (owner: 10Pwirth) [07:13:11] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533384 (owner: 10L10n-bot) [07:14:18] 10conftool: dbctl: support --background or --force? - https://phabricator.wikimedia.org/T231629 (10Marostegui) [07:16:42] 10MediaWiki-Core-Testing, 10Release-Engineering-Team-TODO, 10Code-Health, 10Continuous-Integration-Config, and 5 others: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Simetrical) Again, there are two concerns: reducing latency, and reducing server loa... [07:24:12] 10MediaWiki-General, 10Core Platform Team, 10Wikimedia-production-error: NamespaceInfo.php: PHP Notice: A non well formed numeric value encountered - https://phabricator.wikimedia.org/T231551 (10Simetrical) ChangesListSpecialPage is not validating the parameters. It's assuming that the namespace parameter in... [07:26:02] 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): CI is failing, caused by Lua Tests - https://phabricator.wikimedia.org/T231630 (10Matthias_Geisler_WMDE) [07:26:19] 10MediaWiki-General, 10Core Platform Team, 10Wikimedia-production-error: NamespaceInfo.php: PHP Notice: A non well formed numeric value encountered - https://phabricator.wikimedia.org/T231551 (10daniel) 05Open→03Resolved a:03daniel ChangesListSpecialQuery was feeding namespace names (instead of namespa... [07:26:21] 10MediaWiki-General, 10Wikimedia-production-error: PHP Notice: A non well formed numeric value encountered - https://phabricator.wikimedia.org/T231579 (10daniel) [07:31:52] 10MediaWiki-General, 10Growth-Team, 10Wikimedia-production-error: NamespaceInfo.php: PHP Notice: A non well formed numeric value encountered - https://phabricator.wikimedia.org/T231551 (10daniel) Untagging CPT, tagging Growth, since ChangesListSpecialQuery is theirs. [07:33:24] (03CR) 10Gergő Tisza: [C: 04-1] "There's no point in changing both the getter and the setter." [core] - 10https://gerrit.wikimedia.org/r/532558 (https://phabricator.wikimedia.org/T228881) (owner: 10Nikerabbit) [07:33:33] (03PS4) 10simetrical: Unset globals correctly for unit tests [core] - 10https://gerrit.wikimedia.org/r/533227 [07:35:09] 10MediaWiki-General, 10Growth-Team, 10Wikimedia-production-error: NamespaceInfo.php: PHP Notice: A non well formed numeric value encountered - https://phabricator.wikimedia.org/T231551 (10daniel) @Simetrical it seems like the introduction of expandSymbolicNamespaceFilters() has fixed this, since it filters o... [07:36:01] 10MediaWiki-General, 10Growth-Team, 10Wikimedia-production-error: NamespaceInfo.php: PHP Notice: A non well formed numeric value encountered - https://phabricator.wikimedia.org/T231551 (10daniel) 05Resolved→03Open Re-opening, in case #growth-team wants to follow up on the validation. [07:36:03] 10MediaWiki-General, 10Wikimedia-production-error: PHP Notice: A non well formed numeric value encountered - https://phabricator.wikimedia.org/T231579 (10daniel) [07:36:06] (03CR) 10Mathew.onipe: [V: 03+1 C: 03+1] [elastic] increase Xmx to 512m [vagrant] - 10https://gerrit.wikimedia.org/r/533240 (https://phabricator.wikimedia.org/T211362) (owner: 10DCausse) [07:39:20] (03CR) 10Kosta Harlan: "I'm also wondering if there is another way that could work a bit quicker, as this doubles the test execution time." [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [07:42:17] (03CR) 10jerkins-bot: [V: 04-1] Unset globals correctly for unit tests [core] - 10https://gerrit.wikimedia.org/r/533227 (owner: 10simetrical) [07:52:07] (03CR) 10jerkins-bot: [V: 04-1] Unset globals correctly for unit tests [core] - 10https://gerrit.wikimedia.org/r/533227 (owner: 10simetrical) [07:54:11] (03CR) 10simetrical: "> Patch Set 16:" (036 comments) [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [07:54:57] (03CR) 10Nikerabbit: "> Patch Set 4: Code-Review-1" [core] - 10https://gerrit.wikimedia.org/r/532558 (https://phabricator.wikimedia.org/T228881) (owner: 10Nikerabbit) [07:56:20] (03CR) 10simetrical: "Could we please get rid of HHVM already? :( I have no way to reproduce this failure locally and it doesn't so much as say which test cause" [core] - 10https://gerrit.wikimedia.org/r/533227 (owner: 10simetrical) [07:58:28] (03PS3) 10Bhofmann: Fix messages ERM#16035 [extensions/BlueSpicePageAssignments] (REL1_31) - 10https://gerrit.wikimedia.org/r/528452 (owner: 10Nasty) [07:58:42] (03CR) 10Daniel Kinzler: "I don't quite understand why SpecialWatchlistTest is now failing, but my guess is that some user in the upload test ends up having the sam" [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) (owner: 10Ppchelko) [07:58:50] (03CR) 10Abijeet Patro: [V: 03+2] Localisation updates from https://translatewiki.net. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/533295 (owner: 10L10n-bot) [07:59:19] (03CR) 10DCausse: [C: 03+2] [elastic] increase Xmx to 512m [vagrant] - 10https://gerrit.wikimedia.org/r/533240 (https://phabricator.wikimedia.org/T211362) (owner: 10DCausse) [08:00:19] (03Merged) 10jenkins-bot: [elastic] increase Xmx to 512m [vagrant] - 10https://gerrit.wikimedia.org/r/533240 (https://phabricator.wikimedia.org/T211362) (owner: 10DCausse) [08:00:38] (03CR) 10Kosta Harlan: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase (031 comment) [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [08:00:40] (03CR) 10DCausse: [C: 03+2] [mediainfo] Tell cirrus to index P1 and P2 as statements [vagrant] - 10https://gerrit.wikimedia.org/r/533246 (https://phabricator.wikimedia.org/T228503) (owner: 10DCausse) [08:01:34] (03Merged) 10jenkins-bot: [mediainfo] Tell cirrus to index P1 and P2 as statements [vagrant] - 10https://gerrit.wikimedia.org/r/533246 (https://phabricator.wikimedia.org/T228503) (owner: 10DCausse) [08:01:36] (03Merged) 10jenkins-bot: [cirrus] Allow updating the index when enabling geodata [vagrant] - 10https://gerrit.wikimedia.org/r/533256 (owner: 10DCausse) [08:01:47] 10MediaWiki-General, 10Growth-Team, 10Wikimedia-production-error: NamespaceInfo.php: PHP Notice: A non well formed numeric value encountered - https://phabricator.wikimedia.org/T231551 (10kostajh) Tagging this to follow up in Q2, possibly. [08:03:05] (03CR) 10jenkins-bot: [elastic] increase Xmx to 512m [vagrant] - 10https://gerrit.wikimedia.org/r/533240 (https://phabricator.wikimedia.org/T211362) (owner: 10DCausse) [08:03:42] 10ContentTranslation, 10Wikimedia-production-error: Translator.php: Argument 1 passed to ContentTranslation\Translator::__construct() must be an instance of User, boolean given - https://phabricator.wikimedia.org/T231567 (10Nikerabbit) The trace is the same. The small difference in the message is likely hhvm v... [08:03:50] 10ContentTranslation, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Wikimedia-production-error: ApiQueryTranslatorStats.php: Argument 1 passed to ContentTranslation\Translator::__construct() must be an instance of Us... - https://phabricator.wikimedia.org/T231544 [08:03:52] 10ContentTranslation, 10Wikimedia-production-error: Translator.php: Argument 1 passed to ContentTranslation\Translator::__construct() must be an instance of User, boolean given - https://phabricator.wikimedia.org/T231567 (10Nikerabbit) [08:05:19] (03CR) 10Gehel: [elastic] increase Xmx to 512m (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/533240 (https://phabricator.wikimedia.org/T211362) (owner: 10DCausse) [08:05:28] (03CR) 10jenkins-bot: [mediainfo] Tell cirrus to index P1 and P2 as statements [vagrant] - 10https://gerrit.wikimedia.org/r/533246 (https://phabricator.wikimedia.org/T228503) (owner: 10DCausse) [08:07:46] (03PS5) 10simetrical: Unset globals correctly for unit tests [core] - 10https://gerrit.wikimedia.org/r/533227 [08:07:49] (03CR) 10jenkins-bot: [cirrus] Allow updating the index when enabling geodata [vagrant] - 10https://gerrit.wikimedia.org/r/533256 (owner: 10DCausse) [08:08:46] (03CR) 10DCausse: [elastic] increase Xmx to 512m (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/533240 (https://phabricator.wikimedia.org/T211362) (owner: 10DCausse) [08:09:19] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/BlueSpiceSocialBlog] - 10https://gerrit.wikimedia.org/r/533399 (owner: 10L10n-bot) [08:10:02] (03CR) 10simetrical: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase (031 comment) [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [08:10:42] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/533386 (owner: 10L10n-bot) [08:11:23] (03CR) 10Daniel Kinzler: Unset globals correctly for unit tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533227 (owner: 10simetrical) [08:11:58] (03CR) 10Gergő Tisza: "> Does it hurt to enforce the type for the setter?" [core] - 10https://gerrit.wikimedia.org/r/532558 (https://phabricator.wikimedia.org/T228881) (owner: 10Nikerabbit) [08:13:06] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive" [core] - 10https://gerrit.wikimedia.org/r/533381 (owner: 10L10n-bot) [08:14:20] (03PS7) 10simetrical: Make LocalisationCache a service [core] - 10https://gerrit.wikimedia.org/r/532679 (https://phabricator.wikimedia.org/T231220) [08:14:22] (03PS7) 10simetrical: Split some Language methods to LanguageNameUtils [core] - 10https://gerrit.wikimedia.org/r/532680 (https://phabricator.wikimedia.org/T201405) [08:14:24] (03PS15) 10simetrical: New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 (https://phabricator.wikimedia.org/T201405) [08:14:26] (03PS15) 10simetrical: Make grammar transform cache an instance member [core] - 10https://gerrit.wikimedia.org/r/532240 (https://phabricator.wikimedia.org/T201405) [08:14:28] (03PS33) 10simetrical: LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) [08:14:30] (03PS11) 10simetrical: Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 [08:14:32] (03PS6) 10simetrical: Cache nonexistence of grammar transformations [core] - 10https://gerrit.wikimedia.org/r/532241 [08:14:44] 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Clinic Duty Team), 10Multi-Content-Revisions (Tech Debt), 10Patch-For-Review: Create batch access interface for page content - https://phabricator.wikimedia.org/T228988 (10daniel) [08:15:38] 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Clinic Duty Team), 10Multi-Content-Revisions (Tech Debt), 10Patch-For-Review: Create batch access interface for page content - https://phabricator.wikimedia.org/T228988 (10daniel) Marking as blocked externally on CPT Clinic Duty boa... [08:15:45] (03CR) 10simetrical: Unset globals correctly for unit tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533227 (owner: 10simetrical) [08:19:23] (03PS9) 10simetrical: Convert FileBackendGroup to service [core] - 10https://gerrit.wikimedia.org/r/531486 [08:19:47] (03PS2) 10Daniel Kinzler: Title: make newFromText, isValid, and canExist behave consistently. [core] - 10https://gerrit.wikimedia.org/r/533271 (https://phabricator.wikimedia.org/T229705) [08:22:54] (03PS3) 10Daniel Kinzler: Title: make newFromText, isValid, and canExist behave consistently. [core] - 10https://gerrit.wikimedia.org/r/533271 (https://phabricator.wikimedia.org/T229705) [08:22:56] (03PS5) 10simetrical: Correctly format null error reporting level [core] - 10https://gerrit.wikimedia.org/r/465153 [08:23:50] (03PS6) 10Mglaser: [WiP] Refine notification system [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/503292 (owner: 10ItSpiderman) [08:24:06] (03CR) 10Daniel Kinzler: Title: make newFromText, isValid, and canExist behave consistently. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533271 (https://phabricator.wikimedia.org/T229705) (owner: 10Daniel Kinzler) [08:24:08] (03CR) 10jerkins-bot: [V: 04-1] [WiP] Refine notification system [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/503292 (owner: 10ItSpiderman) [08:24:23] (03CR) 10jerkins-bot: [V: 04-1] LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [08:24:46] (03CR) 10jerkins-bot: [V: 04-1] Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [08:25:21] (03CR) 10jerkins-bot: [V: 04-1] Cache nonexistence of grammar transformations [core] - 10https://gerrit.wikimedia.org/r/532241 (owner: 10simetrical) [08:27:32] (03CR) 10Mglaser: [C: 03+2] Fix property and method underscores for php cs [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/528991 (owner: 10Pwirth) [08:27:39] (03PS1) 10Mglaser: Fix property and method underscores for php cs [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533472 [08:27:43] (03CR) 10Mglaser: [C: 03+2] Fix property and method underscores for php cs [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533472 (owner: 10Mglaser) [08:27:49] (03PS1) 10Mglaser: Fix property and method underscores for php cs [extensions/BlueSpiceFoundation] (REL1_31) - 10https://gerrit.wikimedia.org/r/533473 [08:27:53] (03CR) 10Mglaser: [C: 03+2] Fix property and method underscores for php cs [extensions/BlueSpiceFoundation] (REL1_31) - 10https://gerrit.wikimedia.org/r/533473 (owner: 10Mglaser) [08:27:56] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10Core Platform Team Workboards (Clinic Duty Team), and 2 others: Some ApiQueryImageInfo queries consistently fail with a fatal BadMethodCallException from LocalFile.php - https://phabricator.wikimedia.org/T221812 (10daniel) [08:28:04] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10Core Platform Team Workboards (Clinic Duty Team), and 2 others: Some ApiQueryImageInfo queries consistently fail with a fatal BadMethodCallException from LocalFile.php - https://phabricator.wikimedia.org/T221812 (10daniel) p:05High→03Normal [08:28:58] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10Core Platform Team Workboards (Clinic Duty Team), and 2 others: Some ApiQueryImageInfo queries consistently fail with a fatal BadMethodCallException from LocalFile.php - https://phabricator.wikimedia.org/T221812 (10daniel) Chaged prio to "normal". Sho... [08:29:06] (03CR) 10Mglaser: [C: 03+2] Add phpcs [extensions/BlueSpiceSocialComments] - 10https://gerrit.wikimedia.org/r/533315 (owner: 10Pwirth) [08:29:13] (03PS1) 10Mglaser: Add phpcs [extensions/BlueSpiceSocialComments] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533474 [08:29:18] (03CR) 10Mglaser: [C: 03+2] Add phpcs [extensions/BlueSpiceSocialComments] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533474 (owner: 10Mglaser) [08:30:42] (03CR) 10jerkins-bot: [V: 04-1] LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [08:34:15] (03CR) 10jerkins-bot: [V: 04-1] LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [08:34:56] (03Merged) 10jenkins-bot: Fix property and method underscores for php cs [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/528991 (owner: 10Pwirth) [08:34:58] (03CR) 10jerkins-bot: [V: 04-1] Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [08:35:07] (03CR) 10jerkins-bot: [V: 04-1] Cache nonexistence of grammar transformations [core] - 10https://gerrit.wikimedia.org/r/532241 (owner: 10simetrical) [08:35:11] (03CR) 10jerkins-bot: [V: 04-1] Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [08:35:51] (03CR) 10jerkins-bot: [V: 04-1] Cache nonexistence of grammar transformations [core] - 10https://gerrit.wikimedia.org/r/532241 (owner: 10simetrical) [08:35:53] (03Merged) 10jenkins-bot: Fix property and method underscores for php cs [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533472 (owner: 10Mglaser) [08:36:11] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/533413 (owner: 10L10n-bot) [08:36:33] (03Merged) 10jenkins-bot: Fix property and method underscores for php cs [extensions/BlueSpiceFoundation] (REL1_31) - 10https://gerrit.wikimedia.org/r/533473 (owner: 10Mglaser) [08:36:42] (03CR) 10Fomafix: Use a dummy title in Parser if none is provided (032 comments) [core] - 10https://gerrit.wikimedia.org/r/532558 (https://phabricator.wikimedia.org/T228881) (owner: 10Nikerabbit) [08:37:50] (03CR) 10Mglaser: [C: 03+2] Catch elastica "no connection" exception to make tests pass [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/533148 (owner: 10Pwirth) [08:37:53] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/533381 (owner: 10L10n-bot) [08:37:55] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/533446 (owner: 10L10n-bot) [08:37:58] (03PS1) 10Mglaser: Catch elastica "no connection" exception to make tests pass [extensions/BlueSpiceSocial] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533475 [08:38:03] (03CR) 10Mglaser: [C: 03+2] Catch elastica "no connection" exception to make tests pass [extensions/BlueSpiceSocial] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533475 (owner: 10Mglaser) [08:38:58] (03PS2) 10Mglaser: Fix error when no sorting is set in search store [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/533149 (owner: 10Pwirth) [08:42:25] 10MediaWiki-Internationalization: Allow using non-Gregorian calendars in all languages - https://phabricator.wikimedia.org/T231631 (10Simetrical) [08:42:38] (03Merged) 10jenkins-bot: Add phpcs [extensions/BlueSpiceSocialComments] - 10https://gerrit.wikimedia.org/r/533315 (owner: 10Pwirth) [08:42:40] (03Merged) 10jenkins-bot: Add phpcs [extensions/BlueSpiceSocialComments] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533474 (owner: 10Mglaser) [08:43:29] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/533407 (owner: 10L10n-bot) [08:44:09] (03PS1) 10Pwirth: Add missing author metadata after i18n files merge [extensions/BlueSpiceSocialBlog] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533476 [08:44:12] (03CR) 10Pwirth: [C: 03+2] Add missing author metadata after i18n files merge [extensions/BlueSpiceSocialBlog] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533476 (owner: 10Pwirth) [08:45:09] (03Merged) 10jenkins-bot: Catch elastica "no connection" exception to make tests pass [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/533148 (owner: 10Pwirth) [08:45:40] (03CR) 10Mglaser: [C: 03+2] Fix error when no sorting is set in search store [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/533149 (owner: 10Pwirth) [08:45:42] (03PS1) 10Mglaser: Fix error when no sorting is set in search store [extensions/BlueSpiceExtendedSearch] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533477 [08:45:44] (03CR) 10Mglaser: [C: 03+2] Fix error when no sorting is set in search store [extensions/BlueSpiceExtendedSearch] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533477 (owner: 10Mglaser) [08:45:57] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceSocialArticleActions] - 10https://gerrit.wikimedia.org/r/533042 (owner: 10Pwirth) [08:46:25] (03CR) 10jerkins-bot: [V: 04-1] Convert FileBackendGroup to service [core] - 10https://gerrit.wikimedia.org/r/531486 (owner: 10simetrical) [08:46:29] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/533436 (owner: 10L10n-bot) [08:46:57] (03PS2) 10Mglaser: Fix trying to write with DB_REPLICA in crawler [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/533156 (owner: 10Pwirth) [08:47:10] (03CR) 10Mglaser: [C: 03+2] Fix trying to write with DB_REPLICA in crawler [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/533156 (owner: 10Pwirth) [08:47:19] (03PS1) 10Mglaser: Fix trying to write with DB_REPLICA in crawler [extensions/BlueSpiceExtendedSearch] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533478 [08:47:23] (03CR) 10Mglaser: [C: 03+2] Fix trying to write with DB_REPLICA in crawler [extensions/BlueSpiceExtendedSearch] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533478 (owner: 10Mglaser) [08:47:28] (03PS1) 10Mglaser: Fix trying to write with DB_REPLICA in crawler [extensions/BlueSpiceExtendedSearch] (REL1_31) - 10https://gerrit.wikimedia.org/r/533479 [08:47:32] (03CR) 10Mglaser: [C: 03+2] Fix trying to write with DB_REPLICA in crawler [extensions/BlueSpiceExtendedSearch] (REL1_31) - 10https://gerrit.wikimedia.org/r/533479 (owner: 10Mglaser) [08:47:39] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/533419 (owner: 10L10n-bot) [08:47:55] 10MediaWiki-Core-Testing, 10Release-Engineering-Team-TODO, 10Code-Health, 10Continuous-Integration-Config, and 5 others: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Daimona) >>! In T225730#5453421, @Simetrical wrote: > Again, there are two concerns:... [08:48:46] (03CR) 10jerkins-bot: [V: 04-1] Title: make newFromText, isValid, and canExist behave consistently. [core] - 10https://gerrit.wikimedia.org/r/533271 (https://phabricator.wikimedia.org/T229705) (owner: 10Daniel Kinzler) [08:49:28] (03CR) 10Mglaser: [C: 03+2] Add sort key constants [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/532955 (owner: 10Pwirth) [08:49:35] (03PS1) 10Mglaser: Add sort key constants [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533480 [08:49:42] (03CR) 10Mglaser: [C: 03+2] Add sort key constants [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533480 (owner: 10Mglaser) [08:49:47] (03PS1) 10Mglaser: Add sort key constants [extensions/BlueSpiceFoundation] (REL1_31) - 10https://gerrit.wikimedia.org/r/533481 [08:49:51] (03CR) 10jerkins-bot: [V: 04-1] LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [08:49:53] (03CR) 10Mglaser: [C: 03+2] Add sort key constants [extensions/BlueSpiceFoundation] (REL1_31) - 10https://gerrit.wikimedia.org/r/533481 (owner: 10Mglaser) [08:49:55] (03CR) 10Nikerabbit: Use a dummy title in Parser if none is provided (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532558 (https://phabricator.wikimedia.org/T228881) (owner: 10Nikerabbit) [08:50:28] (03CR) 10jerkins-bot: [V: 04-1] Convert FileBackendGroup to service [core] - 10https://gerrit.wikimedia.org/r/531486 (owner: 10simetrical) [08:51:16] (03CR) 10jerkins-bot: [V: 04-1] Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [08:52:50] (03CR) 10jerkins-bot: [V: 04-1] Cache nonexistence of grammar transformations [core] - 10https://gerrit.wikimedia.org/r/532241 (owner: 10simetrical) [08:53:34] (03Merged) 10jenkins-bot: Catch elastica "no connection" exception to make tests pass [extensions/BlueSpiceSocial] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533475 (owner: 10Mglaser) [08:53:36] (03Merged) 10jenkins-bot: Add missing author metadata after i18n files merge [extensions/BlueSpiceSocialBlog] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533476 (owner: 10Pwirth) [08:53:38] (03Merged) 10jenkins-bot: Fix error when no sorting is set in search store [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/533149 (owner: 10Pwirth) [08:53:49] (03CR) 10jerkins-bot: [V: 04-1] Fix trying to write with DB_REPLICA in crawler [extensions/BlueSpiceExtendedSearch] (REL1_31) - 10https://gerrit.wikimedia.org/r/533479 (owner: 10Mglaser) [08:54:45] (03Merged) 10jenkins-bot: Fix error when no sorting is set in search store [extensions/BlueSpiceExtendedSearch] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533477 (owner: 10Mglaser) [08:54:59] (03CR) 10jerkins-bot: [V: 04-1] Title: make newFromText, isValid, and canExist behave consistently. [core] - 10https://gerrit.wikimedia.org/r/533271 (https://phabricator.wikimedia.org/T229705) (owner: 10Daniel Kinzler) [08:55:45] (03Merged) 10jenkins-bot: Fix trying to write with DB_REPLICA in crawler [extensions/BlueSpiceExtendedSearch] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533478 (owner: 10Mglaser) [08:55:47] (03CR) 10jerkins-bot: [V: 04-1] Fix trying to write with DB_REPLICA in crawler [extensions/BlueSpiceExtendedSearch] (REL1_31) - 10https://gerrit.wikimedia.org/r/533479 (owner: 10Mglaser) [08:56:04] (03CR) 10jerkins-bot: [V: 04-1] Convert FileBackendGroup to service [core] - 10https://gerrit.wikimedia.org/r/531486 (owner: 10simetrical) [08:57:26] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533422 (owner: 10L10n-bot) [08:58:37] (03PS1) 10Daniel Kinzler: LocalFile: avoid hard failures on non-existing files. [core] - 10https://gerrit.wikimedia.org/r/533482 (https://phabricator.wikimedia.org/T221812) [08:58:51] (03Merged) 10jenkins-bot: Add sort key constants [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/532955 (owner: 10Pwirth) [08:58:53] (03Merged) 10jenkins-bot: Add sort key constants [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533480 (owner: 10Mglaser) [08:58:55] (03Merged) 10jenkins-bot: Add sort key constants [extensions/BlueSpiceFoundation] (REL1_31) - 10https://gerrit.wikimedia.org/r/533481 (owner: 10Mglaser) [08:59:30] 10CX-TranslationList, 10CX-boost, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27): Articles in the "for later" list should be shown regardless of language selection for translation suggestions - https://phabricator.wikimedia.org/T194476 (10Pginer-WMF) [08:59:32] 10AbuseFilter, 10Wikimedia-production-error: PHP Notice: Cannot access property on non-object - https://phabricator.wikimedia.org/T231632 (10Daimona) [08:59:56] (03PS2) 10Daimona Eaytoy: Fix param validation in ViewEdit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533027 (https://phabricator.wikimedia.org/T231632) [09:00:32] 10AbuseFilter, 10Patch-For-Review, 10Wikimedia-production-error: PHP Notice: Cannot access property on non-object - https://phabricator.wikimedia.org/T231632 (10Daimona) a:03Daimona [09:00:50] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/533410 (owner: 10L10n-bot) [09:02:18] (03CR) 10Fomafix: "> I don't like that you can now call setTitle() without arguments." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532558 (https://phabricator.wikimedia.org/T228881) (owner: 10Nikerabbit) [09:03:03] (03PS4) 10Daniel Kinzler: Title: make newFromText, isValid, and canExist behave consistently. [core] - 10https://gerrit.wikimedia.org/r/533271 (https://phabricator.wikimedia.org/T229705) [09:03:12] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/533409 (owner: 10L10n-bot) [09:07:38] (03CR) 10simetrical: Title: make newFromText, isValid, and canExist behave consistently. (036 comments) [core] - 10https://gerrit.wikimedia.org/r/533271 (https://phabricator.wikimedia.org/T229705) (owner: 10Daniel Kinzler) [09:08:25] (03CR) 10simetrical: "I'm quite astonished that this actually passed tests." [core] - 10https://gerrit.wikimedia.org/r/533227 (owner: 10simetrical) [09:10:01] (03CR) 10Daimona Eaytoy: "Tested locally, it's fine. And as you said, it also restores the previous behavior of using $user->isBlocked." (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/533365 (https://phabricator.wikimedia.org/T231617) (owner: 10Dbarratt) [09:10:37] 10MediaWiki-Core-Testing, 10Release-Engineering-Team-TODO, 10Code-Health, 10Continuous-Integration-Config, and 5 others: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Simetrical) For the overloading issue, is there any option of just getting more reso... [09:11:29] (03PS1) 10ItSpiderman: Prevent "center jumps" when save dialog displayed [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533484 [09:12:39] (03CR) 10Daniel Kinzler: "For the record: I see the problem and I like the solution, but I think folks more familiar with the new unit test environment should revie" [core] - 10https://gerrit.wikimedia.org/r/533227 (owner: 10simetrical) [09:13:22] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/533420 (owner: 10L10n-bot) [09:15:27] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/533417 (owner: 10L10n-bot) [09:16:12] (03CR) 10Fomafix: [C: 04-1] Parser: Add Title type hints (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533002 (owner: 10Fomafix) [09:16:44] (03PS34) 10simetrical: LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) [09:16:46] (03PS12) 10simetrical: Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 [09:16:48] (03PS7) 10simetrical: Cache nonexistence of grammar transformations [core] - 10https://gerrit.wikimedia.org/r/532241 [09:17:27] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/533415 (owner: 10L10n-bot) [09:18:49] (03CR) 10Mglaser: [C: 03+2] Prevent "center jumps" when save dialog displayed [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533484 (owner: 10ItSpiderman) [09:19:01] (03PS2) 10Mglaser: Prevent "center jumps" when save dialog displayed [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533484 (owner: 10ItSpiderman) [09:19:13] (03PS4) 10Fomafix: Parser: Add Title type hints [core] - 10https://gerrit.wikimedia.org/r/533002 [09:20:58] (03PS3) 10Mglaser: Prevent "center jumps" when save dialog displayed [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533484 (owner: 10ItSpiderman) [09:21:00] (03PS1) 10Mglaser: Prevent "center jumps" when save dialog displayed [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/533486 [09:21:03] (03CR) 10Mglaser: [C: 03+2] Prevent "center jumps" when save dialog displayed [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/533486 (owner: 10Mglaser) [09:21:20] (03CR) 10Pwirth: [V: 03+2] Fix trying to write with DB_REPLICA in crawler [extensions/BlueSpiceExtendedSearch] (REL1_31) - 10https://gerrit.wikimedia.org/r/533479 (owner: 10Mglaser) [09:22:27] (03PS4) 10Daimona Eaytoy: Globally unsuppress phan issues with low count [core] - 10https://gerrit.wikimedia.org/r/533177 [09:22:52] (03PS3) 10Pwirth: Fix trying to write with DB_REPLICA in crawler [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/533156 [09:23:44] (03CR) 10Gergő Tisza: "> This is not a new feature. It is already possible before this change." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532558 (https://phabricator.wikimedia.org/T228881) (owner: 10Nikerabbit) [09:25:38] 04(no projects): Interviews done during Wikimania 2019 that needs to be finished. - https://phabricator.wikimedia.org/T231634 (10Gitta) [09:27:53] (03PS2) 10DCausse: [mediainfo] Always enable WBCS [vagrant] - 10https://gerrit.wikimedia.org/r/533285 (https://phabricator.wikimedia.org/T230018) [09:27:56] (03Merged) 10jenkins-bot: Prevent "center jumps" when save dialog displayed [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/533486 (owner: 10Mglaser) [09:31:14] 10WMSE-Wikimania-2019: Interviews done during Wikimania 2019 that needs to be finished. - https://phabricator.wikimedia.org/T231634 (10Urbanecm) tagging with Wikimania 2019 tag. Out of curiosity, could you define "finished"? [09:31:30] (03PS4) 10Daimona Eaytoy: Unsuppress other phan issues with low count [core] - 10https://gerrit.wikimedia.org/r/533206 [09:32:36] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533435 (owner: 10L10n-bot) [09:34:07] (03PS10) 10simetrical: Convert FileBackendGroup to service [core] - 10https://gerrit.wikimedia.org/r/531486 [09:37:11] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/533432 (owner: 10L10n-bot) [09:37:54] (03CR) 10simetrical: "recheck" [core] - 10https://gerrit.wikimedia.org/r/531698 (owner: 10simetrical) [09:38:19] (03PS1) 10simetrical: Add some LocalRepo integration tests [core] - 10https://gerrit.wikimedia.org/r/533488 [09:38:41] (03CR) 10jerkins-bot: [V: 04-1] FileJournal tests [core] - 10https://gerrit.wikimedia.org/r/531698 (owner: 10simetrical) [09:40:33] 10MediaWiki-Core-Testing, 10phan: Butcher the list of phan suppressions in MW core - https://phabricator.wikimedia.org/T231636 (10Daimona) [09:40:57] (03PS15) 10Mobrovac: Introduce BlobStore::getBlobBatch method [core] - 10https://gerrit.wikimedia.org/r/532449 (https://phabricator.wikimedia.org/T230834) (owner: 10Ppchelko) [09:40:59] (03PS5) 10Daimona Eaytoy: Globally unsuppress phan issues with low count [core] - 10https://gerrit.wikimedia.org/r/533177 (https://phabricator.wikimedia.org/T231636) [09:41:06] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress other phan issues with low count [core] - 10https://gerrit.wikimedia.org/r/533206 (owner: 10Daimona Eaytoy) [09:41:08] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress other phan issues with low count [core] - 10https://gerrit.wikimedia.org/r/533206 (owner: 10Daimona Eaytoy) [09:41:10] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress other phan issues with low count [core] - 10https://gerrit.wikimedia.org/r/533206 (owner: 10Daimona Eaytoy) [09:41:21] (03PS5) 10Daimona Eaytoy: Unsuppress other phan issues with low count [core] - 10https://gerrit.wikimedia.org/r/533206 (https://phabricator.wikimedia.org/T231636) [09:42:09] 10MediaWiki-Core-Testing, 10Patch-For-Review, 10phan: Butcher the list of phan suppressions in MW core - https://phabricator.wikimedia.org/T231636 (10Daimona) p:05Triage→03High Boldly triaging as high: I've already explained the risks of weakening phan's analysis. [09:42:16] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/533437 (owner: 10L10n-bot) [09:42:19] (03PS6) 10Daimona Eaytoy: Unsuppress other phan issues with low count [core] - 10https://gerrit.wikimedia.org/r/533206 (https://phabricator.wikimedia.org/T231636) [09:42:52] (03PS14) 10simetrical: FileJournal tests [core] - 10https://gerrit.wikimedia.org/r/531698 [09:43:28] (03CR) 10jerkins-bot: [V: 04-1] Cache nonexistence of grammar transformations [core] - 10https://gerrit.wikimedia.org/r/532241 (owner: 10simetrical) [09:44:13] (03CR) 10Daniel Kinzler: Title: make newFromText, isValid, and canExist behave consistently. (036 comments) [core] - 10https://gerrit.wikimedia.org/r/533271 (https://phabricator.wikimedia.org/T229705) (owner: 10Daniel Kinzler) [09:44:15] (03CR) 10jerkins-bot: [V: 04-1] FileJournal tests [core] - 10https://gerrit.wikimedia.org/r/531698 (owner: 10simetrical) [09:45:59] (03CR) 10jerkins-bot: [V: 04-1] Cache nonexistence of grammar transformations [core] - 10https://gerrit.wikimedia.org/r/532241 (owner: 10simetrical) [09:46:13] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/533451 (owner: 10L10n-bot) [09:46:23] (03PS1) 10Fomafix: Parser: Use 'Special:Badtitle/Parser' instead of 'NO TITLE' in setTitle [core] - 10https://gerrit.wikimedia.org/r/533490 [09:47:53] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/533445 (owner: 10L10n-bot) [09:48:14] (03CR) 10jerkins-bot: [V: 04-1] FileJournal tests [core] - 10https://gerrit.wikimedia.org/r/531698 (owner: 10simetrical) [09:48:16] (03CR) 10jerkins-bot: [V: 04-1] FileJournal tests [core] - 10https://gerrit.wikimedia.org/r/531698 (owner: 10simetrical) [09:48:36] (03CR) 10Fomafix: "> No it wasn't, being able to pass null and being able to omit the" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532558 (https://phabricator.wikimedia.org/T228881) (owner: 10Nikerabbit) [09:48:39] (03CR) 10jerkins-bot: [V: 04-1] Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [09:48:50] (03CR) 10jerkins-bot: [V: 04-1] FileJournal tests [core] - 10https://gerrit.wikimedia.org/r/531698 (owner: 10simetrical) [09:49:04] 10WMSE-Wikimania-2019: Interviews done during Wikimania 2019 that needs to be finished. - https://phabricator.wikimedia.org/T231634 (10Gitta) a:03Gitta [09:49:22] (03CR) 10jerkins-bot: [V: 04-1] Cache nonexistence of grammar transformations [core] - 10https://gerrit.wikimedia.org/r/532241 (owner: 10simetrical) [09:49:50] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/533463 (owner: 10L10n-bot) [09:51:49] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Popups] - 10https://gerrit.wikimedia.org/r/533452 (owner: 10L10n-bot) [09:55:08] (03CR) 10Mglaser: [C: 03+2] Prevent "center jumps" when save dialog displayed [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533484 (owner: 10ItSpiderman) [09:55:28] (03CR) 10Mglaser: [C: 03+2] Fix trying to write with DB_REPLICA in crawler [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/533156 (owner: 10Pwirth) [09:58:31] 10AbuseFilter, 10Patch-For-Review, 10Wikimedia-production-error: PHP Notice: Cannot access property on non-object - https://phabricator.wikimedia.org/T231632 (10Urbanecm) To make it clear for whoever reads this, `/wiki/Special:AbuseFilter/history/gibberish/item/5` is real URL, not a masking of a potentially... [09:58:37] (03CR) 10Gehel: [elastic] increase Xmx to 512m (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/533240 (https://phabricator.wikimedia.org/T211362) (owner: 10DCausse) [09:59:13] (03CR) 10Mglaser: [C: 03+1] "waiting for i18n review" [extensions/BlueSpiceSocialArticleActions] - 10https://gerrit.wikimedia.org/r/533042 (owner: 10Pwirth) [09:59:27] 10AbuseFilter, 10Patch-For-Review, 10Wikimedia-production-error: PHP Notice: Cannot access property on non-object - https://phabricator.wikimedia.org/T231632 (10Daimona) >>! In T231632#5453679, @Urbanecm wrote: > To make it clear for whoever reads this, `/wiki/Special:AbuseFilter/history/gibberish/item/5` is... [10:01:05] (03CR) 10Mglaser: [C: 04-1] Fix messages ERM#16035 (031 comment) [extensions/BlueSpicePageAssignments] (REL1_31) - 10https://gerrit.wikimedia.org/r/528452 (owner: 10Nasty) [10:01:54] (03Merged) 10jenkins-bot: Prevent "center jumps" when save dialog displayed [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533484 (owner: 10ItSpiderman) [10:02:17] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533471 (owner: 10L10n-bot) [10:02:47] (03CR) 10Mglaser: "recheck" [extensions/BlueSpiceSocialBlog] - 10https://gerrit.wikimedia.org/r/533399 (owner: 10L10n-bot) [10:04:06] (03Merged) 10jenkins-bot: Fix trying to write with DB_REPLICA in crawler [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/533156 (owner: 10Pwirth) [10:06:59] (03CR) 10DCausse: [elastic] increase Xmx to 512m (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/533240 (https://phabricator.wikimedia.org/T211362) (owner: 10DCausse) [10:11:50] (03PS4) 10Bhofmann: Fix messages ERM#16035 [extensions/BlueSpicePageAssignments] (REL1_31) - 10https://gerrit.wikimedia.org/r/528452 (owner: 10Nasty) [10:12:48] 10conftool: dbctl: support --background or --force? - https://phabricator.wikimedia.org/T231629 (10jcrespo) Volans or someone else mentioned there was a dbctl api, I am guessing that is the best way to go about that, but maybe they can point us to docs or source code to know more. [10:14:01] (03CR) 10jerkins-bot: [V: 04-1] Fix messages ERM#16035 [extensions/BlueSpicePageAssignments] (REL1_31) - 10https://gerrit.wikimedia.org/r/528452 (owner: 10Nasty) [10:18:57] (03PS5) 10Mglaser: Fix messages ERM#16035 [extensions/BlueSpicePageAssignments] (REL1_31) - 10https://gerrit.wikimedia.org/r/528452 (owner: 10Nasty) [10:19:04] (03CR) 10Mobrovac: [C: 03+2] Introduce BlobStore::getBlobBatch method [core] - 10https://gerrit.wikimedia.org/r/532449 (https://phabricator.wikimedia.org/T230834) (owner: 10Ppchelko) [10:19:50] (03PS10) 10Mglaser: [WiP] New Action: Move a Category [extensions/BlueSpiceCategoryManager] - 10https://gerrit.wikimedia.org/r/478865 (owner: 10Pboehm) [10:24:42] 10Accessibility, 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 10Fundraising Sprint Quick and the Deadlocked, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03): Payment submethod logos should have alt text - https://phabricator.wikimedia.org/T231549 (10Pcoombe) 05Open→03Resolved Wonderfu... [10:25:51] (03CR) 10jerkins-bot: [V: 04-1] Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [10:30:52] (03PS1) 10JenyaPunchenko: Fix html template for screenshot reader [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533496 [10:33:27] 10Security-Team: Security access for Tchanders - https://phabricator.wikimedia.org/T231608 (10aezell) I approve this as the manager for @Tchanders. [10:36:02] (03PS2) 10JenyaPunchenko: Fix html template for screenshot reader [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533496 [10:43:26] (03CR) 10jerkins-bot: [V: 04-1] Introduce BlobStore::getBlobBatch method [core] - 10https://gerrit.wikimedia.org/r/532449 (https://phabricator.wikimedia.org/T230834) (owner: 10Ppchelko) [10:45:38] 10ContentTranslation, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27): Trying to expand issues doesn't show content - https://phabricator.wikimedia.org/T226247 (10Jpita) 05Open→03Resolved [10:57:50] (03CR) 10Daniel Kinzler: [V: 03+2 C: 03+2] "Force-merge due to flaky Wikibase integration test." [core] - 10https://gerrit.wikimedia.org/r/532449 (https://phabricator.wikimedia.org/T230834) (owner: 10Ppchelko) [10:59:18] (03CR) 10Daniel Kinzler: [C: 03+2] Add some LocalRepo integration tests [core] - 10https://gerrit.wikimedia.org/r/533488 (owner: 10simetrical) [11:02:12] 10MediaWiki-extensions-Widgets: Git branches not up to date - https://phabricator.wikimedia.org/T231297 (10YOUR1) >>! In T231297#5447341, @Kghbln wrote: > This extension is tagged meaning that it does not follow WMF branches. You need to do a `git checkout 1.3.0` instead following the branch. Leaving this to Yar... [11:04:10] (03PS1) 10Pwirth: Purge PageTool. ERM:16266 [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/533498 [11:05:53] (03CR) 10Daniel Kinzler: [C: 04-1] "CR-1 per simetrical's comments" [core] - 10https://gerrit.wikimedia.org/r/533271 (https://phabricator.wikimedia.org/T229705) (owner: 10Daniel Kinzler) [11:06:26] (03PS1) 10Tchanders: Follow-up to beeb049b00: correct typo in block options [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/533499 [11:06:37] 10Wikidata-Bridge-Sprint-4, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03): Selenium tests will fail on gate&submit - https://phabricator.wikimedia.org/T231074 (10Pablo-WMDE) a:03Pablo-WMDE [11:07:06] (03PS2) 10Pwirth: Purge PageTool. ERM:16266 [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/533498 [11:10:31] 10ContentTranslation, 10Technical-Debt: Avoid duplication in ve.ui.CXLinkContextItem.static.generateBody - https://phabricator.wikimedia.org/T231574 (10Pginer-WMF) p:05Triage→03Normal [11:10:33] (03CR) 10Daniel Kinzler: [C: 03+2] Make grammar transform cache an instance member [core] - 10https://gerrit.wikimedia.org/r/532240 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [11:10:51] (03PS1) 10Pwirth: Purge PageTool. ERM:16266 [extensions/BlueSpiceHideTitle] - 10https://gerrit.wikimedia.org/r/533500 [11:11:48] 10ContentTranslation, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Wikimedia-production-error: ApiQueryTranslatorStats.php: Argument 1 passed to ContentTranslation\Translator::__construct() must be an instance of Us... - https://phabricator.wikimedia.org/T231544 [11:13:04] 10ContentTranslation: Explore resource loader package files feature as way to reduce number of resource loader modules - https://phabricator.wikimedia.org/T231326 (10Pginer-WMF) p:05Triage→03Normal [11:14:19] (03CR) 10jenkins-bot: Introduce BlobStore::getBlobBatch method [core] - 10https://gerrit.wikimedia.org/r/532449 (https://phabricator.wikimedia.org/T230834) (owner: 10Ppchelko) [11:14:44] (03PS1) 10Pwirth: Purge PageTool. ERM:16266 [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/533501 [11:16:19] (03PS1) 10Pwirth: Purge PageTool. ERM:16266 [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/533502 [11:25:33] 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): CI is failing, caused by Lua Tests - https://phabricator.wikimedia.org/T231630 (10WMDE-leszek) git bisected to [[ https://github.com/wikimedia/mediawiki/commit/47464abb4f2f209f4c72e8af40056f508d1a70de | 47464abb4f2f209f4c72e8af40056f508d1a70de ]] a.k.a. https:... [11:26:03] 10ContentTranslation, 10Language-Team (Language-2019-July-September): CX puts unnecessary burden on many page views - https://phabricator.wikimedia.org/T230230 (10Pginer-WMF) p:05Triage→03Normal [11:27:22] (03CR) 10Daniel Kinzler: LanguageFactory to replace Language::factory() (037 comments) [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [11:30:35] 10ContentTranslation, 10Language-Team (Language-2019-July-September): Implement "Replace with a new citation" button on templates that could not be adapted - https://phabricator.wikimedia.org/T230714 (10Pginer-WMF) p:05Triage→03Normal [11:30:40] (03CR) 10Daniel Kinzler: "Side note:" [core] - 10https://gerrit.wikimedia.org/r/532232 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [11:30:41] 10ISA: Add missing translation strings to participate page - https://phabricator.wikimedia.org/T231640 (10Seantime) [11:41:10] (03CR) 10Daniel Kinzler: [C: 03+1] New LanguageFallback service (032 comments) [core] - 10https://gerrit.wikimedia.org/r/532232 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [11:41:23] 10ContentTranslation, 10Language-Team (Language-2019-July-September): Bullet points text doesn't count for MT abuse - https://phabricator.wikimedia.org/T230412 (10Pginer-WMF) > Not sure this is expected or not, waiting for @Pginer-WMF feedback on this We are skipping the checks for complex content such as mat... [11:41:43] 10ContentTranslation, 10Language-Team (Language-2019-July-September): Bullet points text doesn't count for MT abuse - https://phabricator.wikimedia.org/T230412 (10Pginer-WMF) p:05Triage→03Normal [11:43:00] (03Merged) 10jenkins-bot: Add some LocalRepo integration tests [core] - 10https://gerrit.wikimedia.org/r/533488 (owner: 10simetrical) [11:58:55] (03CR) 10jenkins-bot: Add some LocalRepo integration tests [core] - 10https://gerrit.wikimedia.org/r/533488 (owner: 10simetrical) [12:00:32] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10GrowthExperiments-NewcomerTasks, 10Growth-Team (Current Sprint): Newcomer tasks: prototype task selection - https://phabricator.wikimedia.org/T231506 (10kostajh) Looking at our topics and attempting to map them to the [list of vital articles](https://en.... [12:02:06] (03PS8) 10Esanders: Citation needed template handling [extensions/Cite] - 10https://gerrit.wikimedia.org/r/477910 (https://phabricator.wikimedia.org/T211243) [12:03:09] (03CR) 10jerkins-bot: [V: 04-1] Citation needed template handling [extensions/Cite] - 10https://gerrit.wikimedia.org/r/477910 (https://phabricator.wikimedia.org/T211243) (owner: 10Esanders) [12:06:24] 10ContentTranslation, 10Language-Team (Language-2019-July-September): Issue with reference - https://phabricator.wikimedia.org/T229946 (10Pginer-WMF) 05Open→03Declined My understanding of the issue is the following. The source paragraph in Spanish has a reference that uses the [[ https://es.wikipedia.org/... [12:09:10] 10ContentTranslation, 10Language-Team (Language-2019-July-September): Language dialog overlapping - https://phabricator.wikimedia.org/T224792 (10Pginer-WMF) p:05Triage→03Normal [12:10:33] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10GrowthExperiments-NewcomerTasks, 10Growth-Team (Current Sprint): Newcomer tasks: prototype task selection - https://phabricator.wikimedia.org/T231506 (10kostajh) Also, I guess there is a charlimit on what you can pass to `morelike` (e.g. `morelike:Commun... [12:10:43] 10Space (Jan-Mar-2020): Deploy Wikimedia Space to production servers - https://phabricator.wikimedia.org/T227309 (10AdHuikeshoven) [12:12:11] (03PS1) 10Pwirth: Activate profile switch assoc links by default [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/533508 [12:13:47] (03PS9) 10Esanders: Citation needed template handling [extensions/Cite] - 10https://gerrit.wikimedia.org/r/477910 (https://phabricator.wikimedia.org/T211243) [12:17:55] 10Space (Jan-Mar-2020): Deploy Wikimedia Space to production servers - https://phabricator.wikimedia.org/T227309 (10AdHuikeshoven) [12:17:57] 10Space (Jul-Sep-2019): Success criteria to move Wikimedia Space to production servers - https://phabricator.wikimedia.org/T227308 (10AdHuikeshoven) [12:20:19] 10Space (Jul-Sep-2019): Wikimedia Space KPIs and metrics - https://phabricator.wikimedia.org/T226725 (10AdHuikeshoven) [12:20:21] 10Space (Jul-Sep-2019): Success criteria to move Wikimedia Space to production servers - https://phabricator.wikimedia.org/T227308 (10AdHuikeshoven) [12:21:02] 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): CI is failing, caused by Lua Tests - https://phabricator.wikimedia.org/T231630 (10alaa_wmde) p:05Triage→03High It is blocking merges on other repos too [12:21:13] 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): CI is failing, caused by Lua Tests - https://phabricator.wikimedia.org/T231630 (10Lucas_Werkmeister_WMDE) a:03Lucas_Werkmeister_WMDE Further bisected that patch to arrive at this fix: `lang=patch diff --git a/tests/phpunit/MediaWikiIntegrationTestCase.php b... [12:21:39] 10Space (Jul-Sep-2019): Bootstrapping the Wikimedia Space program - https://phabricator.wikimedia.org/T226720 (10AdHuikeshoven) [12:25:14] (03PS1) 10Paladox: Fix value for up_relationship to be 0 [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/533509 [12:28:01] (03PS2) 10Paladox: Fix value for up_relationship to be 0 [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/533509 [12:29:01] (03CR) 10Raimond Spekking: [C: 03+1] "i18n review" [extensions/BlueSpiceSocialArticleActions] - 10https://gerrit.wikimedia.org/r/533042 (owner: 10Pwirth) [12:29:16] (03PS2) 10Tchanders: Read the block status from the replicas for the 'thank' link [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/533365 (https://phabricator.wikimedia.org/T231617) (owner: 10Dbarratt) [12:30:13] (03CR) 10Daimona Eaytoy: [C: 03+2] "Thanks!" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/533365 (https://phabricator.wikimedia.org/T231617) (owner: 10Dbarratt) [12:30:57] (03CR) 10Pwirth: [C: 03+2] Init commit [extensions/BlueSpiceSocialArticleActions] - 10https://gerrit.wikimedia.org/r/533042 (owner: 10Pwirth) [12:32:28] (03CR) 10Jack Phoenix: [C: 03+2] Fix value for up_relationship to be 0 [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/533509 (owner: 10Paladox) [12:36:15] (03CR) 10Raimond Spekking: [C: 03+1] "i18n review" [extensions/BlueSpicePageAssignments] (REL1_31) - 10https://gerrit.wikimedia.org/r/528452 (owner: 10Nasty) [12:36:29] (03PS1) 10Lucas Werkmeister (WMDE): Also set $wgContLang in MWITC::setContentLang() [core] - 10https://gerrit.wikimedia.org/r/533510 (https://phabricator.wikimedia.org/T231630) [12:37:18] (03CR) 10Tchanders: Pass the user and request into BlockManager::getUserBlock (031 comment) [core] - 10https://gerrit.wikimedia.org/r/531946 (https://phabricator.wikimedia.org/T230363) (owner: 10Tchanders) [12:39:37] 10Wikimania-Hackathon-2019: Voice Based Offline Wikipedia on a Raspberry Pi - https://phabricator.wikimedia.org/T231641 (10dr0ptp4kt) [12:40:00] 10Wikimania-Hackathon-2019: Voice Based Offline Wikipedia on a Raspberry Pi - https://phabricator.wikimedia.org/T231641 (10dr0ptp4kt) [12:40:28] (03CR) 10Pwirth: [C: 03+2] Fix messages ERM#16035 [extensions/BlueSpicePageAssignments] (REL1_31) - 10https://gerrit.wikimedia.org/r/528452 (owner: 10Nasty) [12:40:29] 10Wikimania-Hackathon-2019: Voice Based Offline Wikipedia on a Raspberry Pi - https://phabricator.wikimedia.org/T231641 (10dr0ptp4kt) [12:40:36] (03PS1) 10Pwirth: Fix messages ERM#16035 [extensions/BlueSpicePageAssignments] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533511 [12:40:42] (03PS1) 10Pwirth: Fix messages ERM#16035 [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/533512 [12:40:45] 10Wikimania-Hackathon-2019: Voice Based Offline Wikipedia on a Raspberry Pi - https://phabricator.wikimedia.org/T231641 (10dr0ptp4kt) [12:40:47] (03CR) 10Pwirth: [C: 03+2] Fix messages ERM#16035 [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/533512 (owner: 10Pwirth) [12:40:55] (03CR) 10Pwirth: [C: 03+2] Fix messages ERM#16035 [extensions/BlueSpicePageAssignments] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533511 (owner: 10Pwirth) [12:43:30] 10conftool: Empty db-eqiad.php, db-codfw.php s1-s8+wikitech lines - https://phabricator.wikimedia.org/T231642 (10Marostegui) [12:54:55] (03CR) 10Daniel Kinzler: Also set $wgContLang in MWITC::setContentLang() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533510 (https://phabricator.wikimedia.org/T231630) (owner: 10Lucas Werkmeister (WMDE)) [12:55:31] (03Merged) 10jenkins-bot: Read the block status from the replicas for the 'thank' link [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/533365 (https://phabricator.wikimedia.org/T231617) (owner: 10Dbarratt) [12:55:34] (03Merged) 10jenkins-bot: Init commit [extensions/BlueSpiceSocialArticleActions] - 10https://gerrit.wikimedia.org/r/533042 (owner: 10Pwirth) [12:55:36] (03Merged) 10jenkins-bot: Fix value for up_relationship to be 0 [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/533509 (owner: 10Paladox) [12:55:38] (03Merged) 10jenkins-bot: Fix messages ERM#16035 [extensions/BlueSpicePageAssignments] (REL1_31) - 10https://gerrit.wikimedia.org/r/528452 (owner: 10Nasty) [12:56:54] (03CR) 10Daimona Eaytoy: "Could you please resolve the merge conflict and tag T231636?" [core] - 10https://gerrit.wikimedia.org/r/517740 (owner: 10Umherirrender) [12:59:51] (03CR) 10Lucas Werkmeister (WMDE): Also set $wgContLang in MWITC::setContentLang() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533510 (https://phabricator.wikimedia.org/T231630) (owner: 10Lucas Werkmeister (WMDE)) [12:59:53] (03PS1) 10Pwirth: Fix version [extensions/BlueSpiceSocialArticleActions] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533515 [13:00:21] (03CR) 10Pwirth: [C: 03+2] Fix version [extensions/BlueSpiceSocialArticleActions] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533515 (owner: 10Pwirth) [13:01:02] (03CR) 10Daniel Kinzler: [C: 03+2] Also set $wgContLang in MWITC::setContentLang() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533510 (https://phabricator.wikimedia.org/T231630) (owner: 10Lucas Werkmeister (WMDE)) [13:06:35] (03CR) 10Lucas Werkmeister (WMDE): Also set $wgContLang in MWITC::setContentLang() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533510 (https://phabricator.wikimedia.org/T231630) (owner: 10Lucas Werkmeister (WMDE)) [13:08:59] (03Merged) 10jenkins-bot: Fix messages ERM#16035 [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/533512 (owner: 10Pwirth) [13:09:01] (03Merged) 10jenkins-bot: Fix messages ERM#16035 [extensions/BlueSpicePageAssignments] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533511 (owner: 10Pwirth) [13:09:42] (03CR) 10Phuedx: Add event queue with flexible dispatch (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/524575 (https://phabricator.wikimedia.org/T225578) (owner: 10Milimetric) [13:10:50] (03PS1) 10Daimona Eaytoy: Unsuppress more phan issues [core] - 10https://gerrit.wikimedia.org/r/533516 (https://phabricator.wikimedia.org/T231636) [13:11:51] (03CR) 10Huji: [C: 03+2] Fix param validation in ViewEdit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533027 (https://phabricator.wikimedia.org/T231632) (owner: 10Daimona Eaytoy) [13:12:52] 10Wiki-Loves-Monuments (2019): WLM Nigeria: Add id support to UploadCampaign - https://phabricator.wikimedia.org/T231643 (10Lokal_Profil) [13:13:16] 10Wiki-Loves-Monuments (2019): WLM Nigeria: Add id support to UploadCampaign - https://phabricator.wikimedia.org/T231643 (10Lokal_Profil) [13:16:39] (03Merged) 10jenkins-bot: Fix version [extensions/BlueSpiceSocialArticleActions] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533515 (owner: 10Pwirth) [13:17:07] (03PS4) 10Jkroll: [WiP] [PoC] Adding and editing book references with Visual Editor [extensions/Cite] - 10https://gerrit.wikimedia.org/r/532682 (https://phabricator.wikimedia.org/T231005) [13:19:16] 10Accessibility, 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): [AMC] Menu handle has no active state - https://phabricator.wikimedia.org/T230034 (10alexhollender) @Niedzielski looks good to me as well. Sorry, I thought we were already "doing" :) [13:19:21] (03CR) 10Dbarratt: [C: 03+2] Follow-up to beeb049b00: correct typo in block options [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/533499 (owner: 10Tchanders) [13:19:56] (03CR) 10jerkins-bot: [V: 04-1] [WiP] [PoC] Adding and editing book references with Visual Editor [extensions/Cite] - 10https://gerrit.wikimedia.org/r/532682 (https://phabricator.wikimedia.org/T231005) (owner: 10Jkroll) [13:23:47] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress more phan issues [core] - 10https://gerrit.wikimedia.org/r/533516 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [13:24:21] (03PS1) 10Pwirth: Quickfix for legacy task apis trying to write with role replica. [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/533519 [13:25:41] (03CR) 10Krinkle: [C: 03+2] Globally unsuppress phan issues with low count (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533177 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [13:26:29] (03CR) 10Krinkle: Unsuppress other phan issues with low count (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533206 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [13:26:57] (03CR) 10Daimona Eaytoy: Globally unsuppress phan issues with low count (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533177 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [13:27:54] (03CR) 10Mholloway: "recheck" [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533340 (https://phabricator.wikimedia.org/T231036) (owner: 10Mholloway) [13:30:43] (03CR) 10Krinkle: [C: 03+2] "LGTM - there's one case I have not fully tried to verify - about unsetting instance members. In theory that is observable behaviour for ex" [core] - 10https://gerrit.wikimedia.org/r/533206 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [13:31:30] 10ISA: Add ISA to Hay's tools - https://phabricator.wikimedia.org/T231644 (10NavinoEvans) [13:32:36] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress more phan issues [core] - 10https://gerrit.wikimedia.org/r/533516 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [13:32:38] (03PS2) 10Fomafix: Parser: Use 'Special:Badtitle/Parser' instead of 'NO TITLE' as dummy [core] - 10https://gerrit.wikimedia.org/r/533490 [13:33:27] (03CR) 10Daimona Eaytoy: "> LGTM - there's one case I have not fully tried to verify - about" [core] - 10https://gerrit.wikimedia.org/r/533206 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [13:35:06] (03CR) 10Krinkle: New LanguageFallback service (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532232 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [13:35:13] (03Merged) 10jenkins-bot: Also set $wgContLang in MWITC::setContentLang() [core] - 10https://gerrit.wikimedia.org/r/533510 (https://phabricator.wikimedia.org/T231630) (owner: 10Lucas Werkmeister (WMDE)) [13:35:28] (03CR) 10Mglaser: [C: 03+2] Remove PlainText TransferHandler [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/533022 (owner: 10ItSpiderman) [13:35:32] (03CR) 10Mglaser: [V: 03+2 C: 03+2] Remove PlainText TransferHandler [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/533022 (owner: 10ItSpiderman) [13:36:59] (03CR) 10Mglaser: "recheck" [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533496 (owner: 10JenyaPunchenko) [13:37:22] (03Merged) 10jenkins-bot: Fix param validation in ViewEdit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533027 (https://phabricator.wikimedia.org/T231632) (owner: 10Daimona Eaytoy) [13:37:27] (03Merged) 10jenkins-bot: Follow-up to beeb049b00: correct typo in block options [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/533499 (owner: 10Tchanders) [13:38:19] (03PS1) 10Krinkle: Read the block status from the replicas for the 'thank' link [extensions/Thanks] (wmf/1.34.0-wmf.20) - 10https://gerrit.wikimedia.org/r/533521 (https://phabricator.wikimedia.org/T231617) [13:40:09] (03CR) 10jenkins-bot: Follow-up to beeb049b00: correct typo in block options [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/533499 (owner: 10Tchanders) [13:43:20] 10WikiApiary: The table 'text' is full (db-local) - https://phabricator.wikimedia.org/T231626 (10Kghbln) This is also happening when trying to move pages. Basically the database is full? @MarkAHershberger for emergency fluff. [13:44:27] 10AbuseFilter, 10Wikimedia-production-error: PHP Notice: Cannot access property on non-object - https://phabricator.wikimedia.org/T231632 (10Daimona) 05Open→03Resolved [13:44:36] (03CR) 10Dbarratt: [C: 03+1] Read the block status from the replicas for the 'thank' link [extensions/Thanks] (wmf/1.34.0-wmf.20) - 10https://gerrit.wikimedia.org/r/533521 (https://phabricator.wikimedia.org/T231617) (owner: 10Krinkle) [13:44:54] (03CR) 10jerkins-bot: [V: 04-1] Persist label suggestion confidence scores [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533340 (https://phabricator.wikimedia.org/T231036) (owner: 10Mholloway) [13:47:35] (03PS1) 10Pwirth: Add phpcs [extensions/BlueSpiceSocialArticleActions] - 10https://gerrit.wikimedia.org/r/533523 [13:48:25] (03CR) 10Dbarratt: [C: 04-1] Pass the user and request into BlockManager::getUserBlock (031 comment) [core] - 10https://gerrit.wikimedia.org/r/531946 (https://phabricator.wikimedia.org/T230363) (owner: 10Tchanders) [13:49:37] (03PS2) 10Daimona Eaytoy: Unsuppress more phan issues [core] - 10https://gerrit.wikimedia.org/r/533516 (https://phabricator.wikimedia.org/T231636) [13:52:00] 10ContentTranslation, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03): Gray interlanguage link dialog is misplaced - https://phabricator.wikimedia.org/T224880 (10Petar.petkovic) When OOUI's PopupWidget cannot fit screen width, it goes backwards, which makes it unus... [13:52:04] 10conftool: Empty db-eqiad.php, db-codfw.php s1-s8+wikitech lines - https://phabricator.wikimedia.org/T231642 (10CDanis) There's no blocker here I know of aside from needing to be careful about it -- I haven't found the time yet to do this. We can't remove all the data of course, but removing `sectionLoads` and... [13:53:52] (03CR) 10Krinkle: [C: 03+2] Read the block status from the replicas for the 'thank' link [extensions/Thanks] (wmf/1.34.0-wmf.20) - 10https://gerrit.wikimedia.org/r/533521 (https://phabricator.wikimedia.org/T231617) (owner: 10Krinkle) [13:55:05] 10conftool: Empty db-eqiad.php, db-codfw.php s1-s8+wikitech lines - https://phabricator.wikimedia.org/T231642 (10Marostegui) >>! In T231642#5453979, @CDanis wrote: > There's no blocker here I know of aside from needing to be careful about it -- I haven't found the time yet to do this. > > We can't remove all th... [13:55:38] (03Merged) 10jenkins-bot: Globally unsuppress phan issues with low count [core] - 10https://gerrit.wikimedia.org/r/533177 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [13:55:57] (03Merged) 10jenkins-bot: Unsuppress other phan issues with low count [core] - 10https://gerrit.wikimedia.org/r/533206 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [13:56:21] (03PS1) 10Fomafix: Use SpecialPage::getTitleFor( 'Badtitle', ... ) instead of ... [core] - 10https://gerrit.wikimedia.org/r/533525 [13:57:11] (03CR) 10jenkins-bot: Also set $wgContLang in MWITC::setContentLang() [core] - 10https://gerrit.wikimedia.org/r/533510 (https://phabricator.wikimedia.org/T231630) (owner: 10Lucas Werkmeister (WMDE)) [14:00:38] 10Core Platform Team Workboards (User Stories), 10Story: Curator gets reverted edits count - https://phabricator.wikimedia.org/T231351 (10daniel) Note that there is no efficient way to compute this number. That would at least require having an index on (page_id, rev_sha1). Even with that index, the necessary s... [14:02:30] (03PS3) 10Fomafix: Parser: Use 'Special:Badtitle/Parser::setTitle' instead of 'NO TITLE' [core] - 10https://gerrit.wikimedia.org/r/533490 [14:03:49] (03PS1) 10DCausse: Explicitely use MatchAll when no text is to be highlighted [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/533527 [14:03:51] (03PS1) 10DCausse: Add morelikethis a non-greedy version of the morelike keyword [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/533528 [14:05:03] 10WikibaseMediaInfo, 10Structured-Data-Backlog (Current Work): Remove interdependence between page id and id of mediainfo item in a slot on that page - https://phabricator.wikimedia.org/T231646 (10Cparle) [14:06:33] 10Core Platform Team Workboards (Epics), 10Epic: iOS client history API - https://phabricator.wikimedia.org/T231338 (10eprodromou) [14:06:44] 10Core Platform Team Workboards (Epics), 10Epic: iOS client history API - https://phabricator.wikimedia.org/T231338 (10eprodromou) [14:07:02] 10MediaWiki-Core-Testing, 10Release-Engineering-Team-TODO, 10Code-Health, 10Continuous-Integration-Config, and 5 others: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Ladsgroup) >>! In T225730#5452274, @Daimona wrote: > Looking at the test reports, I... [14:09:20] 10ContentTranslation, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03): Gray interlanguage link dialog is misplaced - https://phabricator.wikimedia.org/T224880 (10Jpita) https://gs.statcounter.com/screen-resolution-stats/desktop/worldwide to help with the decision [14:09:50] (03CR) 10Fomafix: Use a dummy title in Parser if none is provided (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532558 (https://phabricator.wikimedia.org/T228881) (owner: 10Nikerabbit) [14:10:28] 10MediaWiki-Core-Testing, 10Release-Engineering-Team-TODO, 10Code-Health, 10Continuous-Integration-Config, and 5 others: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Daimona) >>! In T225730#5454020, @Ladsgroup wrote: > Dropping php7.0 wouldn't make m... [14:11:47] 10Security-Team: Security access for Tchanders - https://phabricator.wikimedia.org/T231608 (10sbassett) p:05Triage→03Normal [14:12:41] (03Merged) 10jenkins-bot: Read the block status from the replicas for the 'thank' link [extensions/Thanks] (wmf/1.34.0-wmf.20) - 10https://gerrit.wikimedia.org/r/533521 (https://phabricator.wikimedia.org/T231617) (owner: 10Krinkle) [14:12:51] 10InternetArchiveBot: bot should add |url-access= parameter - https://phabricator.wikimedia.org/T231648 (10Trappist_the_monk) [14:13:06] 10Security-Team: Security access for Tchanders - https://phabricator.wikimedia.org/T231608 (10sbassett) @Tchanders - the #security-team will discuss this at our team meeting next Tuesday (September 4th). In the meantime, can you post a few recent security-protected tasks here where you recently needed individua... [14:14:38] 10MediaWiki-Core-Testing, 10Release-Engineering-Team-TODO, 10Code-Health, 10Continuous-Integration-Config, and 5 others: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Ladsgroup) >>! In T225730#5454035, @Daimona wrote: >>>! In T225730#5454020, @Ladsgro... [14:17:02] 10MediaWiki-Core-Testing, 10Release-Engineering-Team-TODO, 10Code-Health, 10Continuous-Integration-Config, and 5 others: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Daimona) >>! In T225730#5454066, @Ladsgroup wrote: > Maybe my timing is weird but I... [14:17:22] 10ISA: Long text being cut-off in stats tables - https://phabricator.wikimedia.org/T231650 (10NavinoEvans) [14:18:05] 10conftool: Empty db-eqiad.php, db-codfw.php s1-s8+wikitech lines - https://phabricator.wikimedia.org/T231642 (10CDanis) >>! In T231642#5453981, @Marostegui wrote: > I can help with the removal. > My proposal would be to remove it on codfw.php first, and navigate the site from mwdebug on codfw to check that eve... [14:21:16] (03CR) 10Krinkle: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase (033 comments) [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [14:21:50] (03PS2) 10DCausse: Add morelikethis a non-greedy version of the morelike keyword [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/533528 [14:35:23] 10CommRel-Specialists-Support (Jul-Sep-2019): CommRel support for Talk pages consultation 2019 - phase 2 - https://phabricator.wikimedia.org/T223399 (10Trizek-WMF) 05Open→03Resolved The TPC presentation at Wikimania was the official power transfer to the Editing team. [14:35:25] 10CommRel-Specialists-Support (Jul-Sep-2019): [Epic] Talk pages consultation 2019 support - https://phabricator.wikimedia.org/T201375 (10Trizek-WMF) [14:35:33] 10Product-Analytics: Re-run active editors skin statistics - https://phabricator.wikimedia.org/T180860 (10Isarra) So no way to check against users that have even been active since the skin was created, or types of users in terms of edits. [14:36:20] 10CommRel-Specialists-Support (Jul-Sep-2019): [Epic] Talk pages consultation 2019 support - https://phabricator.wikimedia.org/T201375 (10Trizek-WMF) To be closed when {T230823} is done. [14:36:32] 10Product-Analytics: Re-run active editors skin statistics - https://phabricator.wikimedia.org/T180860 (10Isarra) Would have been really nice if we could have just set up something automated for this. And, well, other such features, for that matter. What's the buy-in on any given extension, generally? Should I e... [14:38:33] (03PS5) 10Ladsgroup: Split LuaEngineTestBase to LuaEngineUnitTestBase and LuaEngineTestBase [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/527854 (https://phabricator.wikimedia.org/T230701) [14:39:53] (03CR) 10D3r1ck01: [C: 03+2] Various cleanups and fatal error fixes [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/521007 (owner: 10Aaron Schulz) [14:40:46] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress more phan issues [core] - 10https://gerrit.wikimedia.org/r/533516 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [14:44:37] (03CR) 10Lucas Werkmeister (WMDE): [C: 03+1] "Looks good to me – leaving a bit of time if others want to review but will probably merge on Monday." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/531694 (https://phabricator.wikimedia.org/T227849) (owner: 10Awight) [14:45:58] (03CR) 10jerkins-bot: [V: 04-1] Use SpecialPage::getTitleFor( 'Badtitle', ... ) instead of ... [core] - 10https://gerrit.wikimedia.org/r/533525 (owner: 10Fomafix) [14:53:07] (03CR) 10jerkins-bot: [V: 04-1] Add morelikethis a non-greedy version of the morelike keyword [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/533528 (owner: 10DCausse) [14:53:25] (03CR) 10jerkins-bot: [V: 04-1] Split LuaEngineTestBase to LuaEngineUnitTestBase and LuaEngineTestBase [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/527854 (https://phabricator.wikimedia.org/T230701) (owner: 10Ladsgroup) [14:56:12] (03PS6) 10Ladsgroup: Split LuaEngineTestBase to LuaEngineUnitTestBase and LuaEngineTestBase [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/527854 (https://phabricator.wikimedia.org/T230701) [14:57:43] (03PS1) 10Niedzielski: [hack] [toolbar] tighten the icon spacing [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533534 (https://phabricator.wikimedia.org/T230232) [15:01:08] (03PS11) 10Ppchelko: Rework ApiUploadTest [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) [15:01:39] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress more phan issues [core] - 10https://gerrit.wikimedia.org/r/533516 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [15:02:14] (03PS3) 10DCausse: Add morelikethis a non-greedy version of the morelike keyword [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/533528 [15:06:39] (03CR) 10jenkins-bot: Fix param validation in ViewEdit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533027 (https://phabricator.wikimedia.org/T231632) (owner: 10Daimona Eaytoy) [15:07:15] (03PS2) 10Jdrewniak: [WIP] Customize mw-ui-icon to ensure consistent sizing and touch targets [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533360 [15:07:55] (03CR) 10jerkins-bot: [V: 04-1] Use SpecialPage::getTitleFor( 'Badtitle', ... ) instead of ... [core] - 10https://gerrit.wikimedia.org/r/533525 (owner: 10Fomafix) [15:10:28] 10Shape Expressions: Discussion tab on a EntitySchema is not enabled - https://phabricator.wikimedia.org/T231652 (10Andrawaag) [15:11:35] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Quick and the Deadlocked: Client-side event impression event logging is broken - https://phabricator.wikimedia.org/T231404 (10AndyRussG) [15:11:51] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Quick and the Deadlocked: Client-side event impression event logging is broken - https://phabricator.wikimedia.org/T231404 (10AndyRussG) a:03AndyRussG [15:13:00] (03PS2) 10Jdlrobson: Use core table of contents in Minerva [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533362 [15:15:06] (03CR) 10jerkins-bot: [V: 04-1] Add morelikethis a non-greedy version of the morelike keyword [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/533528 (owner: 10DCausse) [15:15:06] 10conftool: dbctl: support --background or --force? - https://phabricator.wikimedia.org/T231629 (10CDanis) There's a `--batch` flag, intended for use from scripts, that I think should work for this? There's also a Python API that can be used, although its semantics are a bit un-Pythonic -- lots of methods that... [15:15:08] 10InternetArchiveBot: Multiple false positives on gl.wikipedia on the 08/30/2019 - https://phabricator.wikimedia.org/T231653 (10Banjo) [15:15:11] (03PS3) 10Jdlrobson: Use core table of contents in Minerva [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533362 [15:16:27] (03PS3) 10Jdlrobson: Remove table of contents handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) [15:16:43] (03CR) 10jerkins-bot: [V: 04-1] Remove table of contents handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) (owner: 10Jdlrobson) [15:18:13] (03CR) 10jerkins-bot: [V: 04-1] Remove table of contents handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) (owner: 10Jdlrobson) [15:18:16] (03CR) 10jenkins-bot: Globally unsuppress phan issues with low count [core] - 10https://gerrit.wikimedia.org/r/533177 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [15:18:18] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress more phan issues [core] - 10https://gerrit.wikimedia.org/r/533516 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [15:19:51] (03PS1) 10Varnent: Testing if copying files to subdirectory will produce desired build - related to T230638 [wikimedia/TransparencyReport] - 10https://gerrit.wikimedia.org/r/533537 [15:20:52] (03CR) 10jerkins-bot: [V: 04-1] Use SpecialPage::getTitleFor( 'Badtitle', ... ) instead of ... [core] - 10https://gerrit.wikimedia.org/r/533525 (owner: 10Fomafix) [15:22:56] (03CR) 10Jforrester: "> Patch Set 5:" [core] - 10https://gerrit.wikimedia.org/r/533067 (https://phabricator.wikimedia.org/T231419) (owner: 10Daimona Eaytoy) [15:23:49] (03CR) 10Jforrester: [C: 03+2] Actually assign suppression-related rights to 'suppress' group [core] - 10https://gerrit.wikimedia.org/r/530702 (https://phabricator.wikimedia.org/T230601) (owner: 10Daimona Eaytoy) [15:24:09] 10MediaWiki-Core-Testing: MediaWikiTestCaseTrait::creatNoOpMock should permit calling destructors - https://phabricator.wikimedia.org/T231656 (10Mainframe98) [15:24:50] (03PS4) 10Jdlrobson: Use core table of contents in Minerva [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533362 [15:24:52] (03CR) 10Jforrester: [C: 03+2] "(This is more like progress towards T112147 than the final piece of T230601, but it matters little.)" [core] - 10https://gerrit.wikimedia.org/r/530702 (https://phabricator.wikimedia.org/T230601) (owner: 10Daimona Eaytoy) [15:25:22] 10MediaWiki-General, 10Trust-and-Safety, 10Wikimedia-Site-requests: Rename the oversight group on WMF projects - https://phabricator.wikimedia.org/T112147 (10Jdforrester-WMF) [15:27:13] (03PS1) 10Mainframe98: Permit destructors in MediaWikiTestCaseTrait::createNoOpMock [core] - 10https://gerrit.wikimedia.org/r/533543 (https://phabricator.wikimedia.org/T231656) [15:27:41] 10Product-Analytics: Re-run active editors skin statistics - https://phabricator.wikimedia.org/T180860 (10Isarra) >>! In T180860#4147344, @Bawolff ran some queries... Dumb question, but do we have any idea what's with all the 0 edit users? [15:27:43] (03PS2) 10Mainframe98: Permit destructors in MediaWikiTestCaseTrait::createNoOpMock [core] - 10https://gerrit.wikimedia.org/r/533543 (https://phabricator.wikimedia.org/T231656) [15:29:01] 10Product-Analytics: Re-run active editors skin statistics - https://phabricator.wikimedia.org/T180860 (10Jdforrester-WMF) >>! In T180860#5454232, @Isarra wrote: >>>! In T180860#4147344, @Bawolff ran some queries... > > Dumb question, but do we have any idea what's with all the 0 edit users? Before GlobalPrefe... [15:29:27] (03CR) 10Eevans: [C: 03+1] Modify -—with-extensions to throw extension dependency errors [core] - 10https://gerrit.wikimedia.org/r/533239 (https://phabricator.wikimedia.org/T225512) (owner: 10Clarakosi) [15:30:11] 10MediaWiki-General, 10Trust-and-Safety, 10Wikimedia-Site-requests: Rename the oversight group on WMF projects - https://phabricator.wikimedia.org/T112147 (10Daimona) [15:31:31] (03CR) 10Ppchelko: "> Patch Set 10:" [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) (owner: 10Ppchelko) [15:32:35] (03PS4) 10Jdlrobson: Remove table of contents handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) [15:33:17] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Customize mw-ui-icon to ensure consistent sizing and touch targets [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533360 (owner: 10Jdrewniak) [15:34:14] (03CR) 10jenkins-bot: Unsuppress other phan issues with low count [core] - 10https://gerrit.wikimedia.org/r/533206 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [15:34:29] 10MediaWiki-extensions-Translate, 10translatewiki.net, 10Language-Team (Language-2019-July-September), 10Patch-For-Review, 10User-abi_: Migrate a few projects to the new Validator framework - https://phabricator.wikimedia.org/T224025 (10abi_) [15:37:38] (03Abandoned) 10Acamicamacaraca: Fully implemented GRAMMAR in Serbian [core] - 10https://gerrit.wikimedia.org/r/481103 (https://phabricator.wikimedia.org/T35546) (owner: 10Acamicamacaraca) [15:38:30] 10Advanced Mobile Contributions, 10Wikimedia-Site-requests, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Turn on AMC outreach modal - https://phabricator.wikimedia.org/T231206 (10ovasileva) 05Open→03Resolved a:03ovasileva Looks like we're all done here - task for removing is created. Reso... [15:39:10] 10Advanced Mobile Contributions, 10MinervaNeue, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Mobile, and 2 others: Replace 24x24px SVGs in MF/Minerva - https://phabricator.wikimedia.org/T231613 (10ovasileva) p:05Triage→03High [15:39:50] 10Anti-Harassment (The Letter Song), 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Performance-Team (Radar), 10Wikimedia-production-error: DBPerformance: Expectation masterConns <= 0 not met by PermissionManager->isBlockedFrom - https://phabricator.wikimedia.org/T231617 (10Krinkle) 05Open→03Resolved a... [15:39:59] 10Anti-Harassment (The Letter Song), 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Performance-Team (Radar), 10Wikimedia-production-error: DBPerformance: Expectation masterConns <= 0 not met by PermissionManager->isBlockedFrom - https://phabricator.wikimedia.org/T231617 (10Krinkle) a:05Krinkle→03dbarra... [15:40:17] 10Product-Analytics: Re-run active editors skin statistics - https://phabricator.wikimedia.org/T180860 (10Isarra) >>! In T180860#5454234, @Jdforrester-WMF wrote: > Before GlobalPreferences, lots of power users with Opinions™ on their skin had a script to go to every wiki and set their skin to whatever. > > (For... [15:40:58] 10Advanced Mobile Contributions, 10Mobile, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Reduce spacing of icons in mobile header - https://phabricator.wikimedia.org/T229447 (10ovasileva) p:05Normal→03High... [15:41:24] 10Accessibility, 10MobileFrontend, 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), and 2 others: Touch targets not large enough - https://phabricator.wikimedia.org/T230033 (10ovasileva) p:05Triage→03High [15:42:38] 10Advanced Mobile Contributions, 10Readers-Web-Backlog: Turn off AMC outreach modal - https://phabricator.wikimedia.org/T231436 (10ovasileva) p:05Triage→03High [15:44:20] (03CR) 10Daimona Eaytoy: [C: 04-1] "Just a quick review." (0320 comments) [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) (owner: 10Ppchelko) [15:44:44] 10MediaWiki-extensions-Translate, 10translatewiki.net, 10Language-Team (Language-2019-July-September), 10Patch-For-Review, 10User-abi_: Migrate a few projects to the new Validator framework - https://phabricator.wikimedia.org/T224025 (10abi_) [15:45:10] 10WikiApiary: The table 'text' is full (db-local) - https://phabricator.wikimedia.org/T231626 (10MarkAHershberger) I am just checking my emails and got a few "table is full" emails from the mysql before I saw these reports. The partition was full. I've cleared up 23G by removing some old dumps that were sittin... [15:47:53] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors:" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/533528 (owner: 10DCausse) [15:49:06] (03PS1) 10Zoranzoki21: Fully implemented GRAMMAR in Serbian [core] - 10https://gerrit.wikimedia.org/r/533544 (https://phabricator.wikimedia.org/T35546) [15:49:21] 10MediaWiki-extensions-Translate, 10translatewiki.net, 10Language-Team (Language-2019-July-September), 10Patch-For-Review, 10User-abi_: Migrate a few projects to the new Validator framework - https://phabricator.wikimedia.org/T224025 (10abi_) [15:49:49] (03CR) 10Zoranzoki21: "I made https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/533544/" [core] - 10https://gerrit.wikimedia.org/r/481103 (https://phabricator.wikimedia.org/T35546) (owner: 10Acamicamacaraca) [15:50:21] 10MediaWiki-extensions-Translate, 10translatewiki.net, 10Language-Team (Language-2019-July-September), 10Patch-For-Review, 10User-abi_: Migrate a few projects to the new Validator framework - https://phabricator.wikimedia.org/T224025 (10abi_) [15:51:16] 10MediaWiki-Recent-changes, 10Advanced Mobile Contributions, 10Edit-Review-Improvements-RC-Page, 10Growth-Team, and 2 others: Click trash on recent changes doesn't clear open filter menus - https://phabricator.wikimedia.org/T231053 (10ovasileva) @MMiller_WMF - it's not really high priority so no guarantees... [15:52:48] 10Advanced Mobile Contributions, 10Mobile, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Reduce spacing of icons in mobile header - https://phabricator.wikimedia.org/T229447 (10Krinkle) @alexhollender I notice... [15:52:55] 10MobileFrontend, 10Editing Design, 10MinervaNeue, 10VisualEditor, and 3 others: Consider changing mobile site header height (and overlay header height) from 3.35em (53.6px) to 3em (48px) - https://phabricator.wikimedia.org/T215426 (10ovasileva) 05Open→03Resolved Discussed with @alexhollender and we're... [15:53:14] 10MobileFrontend, 10Editing Design, 10MinervaNeue, 10VisualEditor, and 3 others: Consider changing mobile site header height (and overlay header height) from 3.35em (53.6px) to 3em (48px) - https://phabricator.wikimedia.org/T215426 (10ovasileva) [15:53:16] 10MediaWiki-extensions-Translate, 10translatewiki.net, 10Language-Team (Language-2019-July-September), 10Patch-For-Review, 10User-abi_: Migrate a few projects to the new Validator framework - https://phabricator.wikimedia.org/T224025 (10abi_) [15:54:15] (03CR) 10jerkins-bot: [V: 04-1] Remove table of contents handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) (owner: 10Jdlrobson) [15:58:23] (03CR) 10jerkins-bot: [V: 04-1] Remove table of contents handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) (owner: 10Jdlrobson) [15:59:46] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress more phan issues [core] - 10https://gerrit.wikimedia.org/r/533516 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:01:09] 10ISA: Add url link to manager commons account - https://phabricator.wikimedia.org/T231662 (10Anthere) [16:01:15] (03CR) 10jerkins-bot: [V: 04-1] Use SpecialPage::getTitleFor( 'Badtitle', ... ) instead of ... [core] - 10https://gerrit.wikimedia.org/r/533525 (owner: 10Fomafix) [16:02:16] (03PS1) 10Daimona Eaytoy: Unsuppress other phan issues [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) [16:02:55] (03PS3) 10Daimona Eaytoy: Unsuppress more phan issues [core] - 10https://gerrit.wikimedia.org/r/533516 (https://phabricator.wikimedia.org/T231636) [16:03:02] (03PS2) 10Daimona Eaytoy: Unsuppress other phan issues [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) [16:03:04] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress other phan issues [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:03:06] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress other phan issues [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:03:08] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress other phan issues [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:03:14] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress other phan issues [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:03:44] 10MediaWiki-General, 10Discovery-Search, 10OOUI, 10Utilities-UnicodeJS, and 6 others: Search suggestion highlighting does not respect grapheme clusters causing wrong rendering for Arabic and Indic scripts - https://phabricator.wikimedia.org/T35242 (10TJones) >>! In T35242#5452666, @matmarex wrote: > @TJone... [16:04:40] 10MobileFrontend, 10Mobile: https://en.wikipedia.org/wiki/Heteromyidae shows the mobile version on desktop - https://phabricator.wikimedia.org/T231620 (10AntiCompositeNumber) They returned today saying that the issue went away at about 15:40 UTC, but was still occurring around 12:00 UTC. [16:04:56] (03PS3) 10Daimona Eaytoy: Unsuppress other phan issues [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) [16:07:05] 10MobileFrontend, 10Operations, 10Traffic, 10Mobile: https://en.wikipedia.org/wiki/Heteromyidae shows the mobile version on desktop - https://phabricator.wikimedia.org/T231620 (10AntiCompositeNumber) [16:15:02] 10Security-Team: Security Team quarterly check in for April - June 2019 - https://phabricator.wikimedia.org/T218091 (10JBennett) 05Open→03Resolved [16:15:04] 10Security-Team, 10Goal: Goal: Making life hard for the people who want to do harm to our sites or the people that use them. - https://phabricator.wikimedia.org/T216416 (10JBennett) [16:15:11] (03CR) 10jerkins-bot: [V: 04-1] Fully implemented GRAMMAR in Serbian [core] - 10https://gerrit.wikimedia.org/r/533544 (https://phabricator.wikimedia.org/T35546) (owner: 10Zoranzoki21) [16:16:12] (03CR) 10D3r1ck01: [C: 03+2] "I agree with you on this, caller(s) checked for null below https://gerrit.wikimedia.org/g/mediawiki/core/+/d6130cac5dfe0dc00a26b3ffcae82b0" [core] - 10https://gerrit.wikimedia.org/r/517710 (owner: 10Umherirrender) [16:16:34] (03CR) 10Catrope: [C: 04-1] ContributionsQuery: Drop 'newbies' feature support, killed in core (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533306 (https://phabricator.wikimedia.org/T231540) (owner: 10Jforrester) [16:16:50] (03CR) 10D3r1ck01: [C: 03+2] Make Special:ChangeContentModel field labels consistently use colons [core] - 10https://gerrit.wikimedia.org/r/527670 (owner: 10Brian Wolff) [16:18:02] (03CR) 10Catrope: [C: 03+2] ContributionsQuery: Drop 'newbies' feature support, killed in core (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533306 (https://phabricator.wikimedia.org/T231540) (owner: 10Jforrester) [16:19:12] (03Merged) 10jenkins-bot: Various cleanups and fatal error fixes [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/521007 (owner: 10Aaron Schulz) [16:21:19] (03CR) 10Tpt: "Thank you! It looks much better to me than the previous implementation" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/533327 (https://phabricator.wikimedia.org/T231250) (owner: 10Isarra) [16:21:26] 10MobileFrontend, 10Operations, 10Traffic, 10Mobile: https://en.wikipedia.org/wiki/Heteromyidae shows the mobile version on desktop - https://phabricator.wikimedia.org/T231620 (10CDanis) Seems likely this is the same as {T231504} ? [16:22:42] (03PS3) 10Catrope: Fix PHP Notice: Undefined index: posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/532967 (https://phabricator.wikimedia.org/T207867) (owner: 10Kosta Harlan) [16:26:10] 10MediaWiki-extensions-Widgets: Git branches not up to date - https://phabricator.wikimedia.org/T231297 (10Yaron_Koren) Is this something *I* should do? I've never dealt with branches. [16:27:41] 10Security-Team, 10Documentation: Document Security Council on-wiki - https://phabricator.wikimedia.org/T231265 (10JBennett) 05Open→03Resolved [16:29:02] 10MediaWiki-extensions-Page_Forms: PageForms: Drop support for PHP 5.3 - https://phabricator.wikimedia.org/T231665 (10MarkAHershberger) [16:29:04] (03PS12) 10Ppchelko: Rework ApiUploadTest [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) [16:29:20] (03CR) 10Ppchelko: Rework ApiUploadTest (0319 comments) [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) (owner: 10Ppchelko) [16:29:55] (03CR) 10Daniel Kinzler: "> Patch Set 11:" [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) (owner: 10Ppchelko) [16:30:09] (03CR) 10Tchanders: "> Right, or even better, just a logger mock" [core] - 10https://gerrit.wikimedia.org/r/531287 (https://phabricator.wikimedia.org/T230822) (owner: 10Urbanecm) [16:32:44] 10conftool: dbctl: support --background or --force? - https://phabricator.wikimedia.org/T231629 (10Marostegui) Ah, thanks, I didn't know `--batch` existed, looked for it at https://gerrit.wikimedia.org/r/plugins/gitiles/operations/software/conftool/+/refs/heads/master/conftool/extensions/dbconfig/README.md but d... [16:32:52] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress other phan issues [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [16:33:15] (03CR) 10Esanders: Make mapName deterministic so it can be tested (031 comment) [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/500189 (owner: 10Esanders) [16:34:49] 10Security-Team: Security Team quarterly check in for July - September 2018 - https://phabricator.wikimedia.org/T218031 (10JFishback_WMF) 05Open→03Resolved a:03JFishback_WMF [16:34:51] 10Security-Team, 10Goal: Goal: Making life hard for the people who want to do harm to our sites or the people that use them. - https://phabricator.wikimedia.org/T216416 (10JFishback_WMF) [16:35:12] 10Security-Team: Security Team quarterly check in for October - December 2018 - https://phabricator.wikimedia.org/T218033 (10JFishback_WMF) 05Open→03Resolved a:03JFishback_WMF [16:35:14] 10Security-Team, 10Goal: Goal: Making life hard for the people who want to do harm to our sites or the people that use them. - https://phabricator.wikimedia.org/T216416 (10JFishback_WMF) [16:35:29] 10Security-Team: Security Team quarterly check in for January - March 2019 - https://phabricator.wikimedia.org/T218034 (10JFishback_WMF) 05Open→03Resolved a:03JFishback_WMF [16:35:31] 10Security-Team, 10Goal: Goal: Making life hard for the people who want to do harm to our sites or the people that use them. - https://phabricator.wikimedia.org/T216416 (10JFishback_WMF) [16:36:12] 10CommRel-Specialists-Support (Jul-Sep-2019), 10Growth-Team (Current Sprint): Growth: training for how to help newcomers - https://phabricator.wikimedia.org/T224633 (10Trizek-WMF) >>! In T224633#5436600, @Urbanecm wrote: > Anything new about this program/task in general? Well, being on vacation is not compati... [16:38:21] 10Anti-Harassment (The Letter Song), 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Performance-Team (Radar), 10Wikimedia-production-error: DBPerformance: Expectation masterConns <= 0 not met by PermissionManager->isBlockedFrom - https://phabricator.wikimedia.org/T231617 (10dbarratt) @dom_walden FYI: @Krin... [16:38:23] 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10MinervaNeue (Desktop), 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Cleanup AMC feature flagging - https://phabricator.wikimedia.org/T229295 (10ovasileva) 05Open→03Resolved a:03ovasileva >>! In T229295#545162... [16:38:29] (03PS2) 10Fomafix: Use SpecialPage::getTitleFor( 'Badtitle', '...' ) instead of ... [core] - 10https://gerrit.wikimedia.org/r/533525 [16:40:28] 10MediaWiki-Configuration, 10Operations, 10conftool, 10Performance-Team (Radar): noc.wm.o/db.php: remove hosts information, or fetch it from etcd somehow - https://phabricator.wikimedia.org/T229631 (10CDanis) 05Open→03Resolved The remaining work on this task is now part of {T231642} [16:40:34] 10MediaWiki-Configuration, 10DBA, 10Operations, 10Patch-For-Review, and 3 others: Create tool to handle the state of database configuration in MediaWiki in etcd - https://phabricator.wikimedia.org/T197126 (10CDanis) [16:41:06] (03CR) 10Pablo Grass (WMDE): "Would be awesome to either see a -X verdict with some yes model, a merge, or at least a timeline. The current way of dealing with it is su" [core] - 10https://gerrit.wikimedia.org/r/528882 (owner: 10Pablo Grass (WMDE)) [16:42:10] (03PS8) 10Fomafix: Skin: Initialize LinkRenderer in construtor [core] - 10https://gerrit.wikimedia.org/r/509625 [16:43:36] 10Product-Analytics, 10Growth-Team (Current Sprint): Homepage: update reporting queries to utilize all data - https://phabricator.wikimedia.org/T230215 (10nettrom_WMF) a:05nettrom_WMF→03MMiller_WMF This has been done and sent to @MMiller_WMF for review. As far as I know it's working as it should, but reass... [16:44:20] (03PS6) 10Esanders: Make mapName deterministic so it can be tested [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/500189 [16:44:22] (03PS3) 10Esanders: Rewrite tokenizeCoords to use a while loop, and use it for 'poly' [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/500203 [16:45:54] (03CR) 10Esanders: "Ok, I've come up with a better approach which hashes the map HTML content. It is still possible we will get duplicate map names, but that " [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/500189 (owner: 10Esanders) [16:53:02] (03PS1) 10Isarra: Add a min-height to thumbcaptions so magnify icon doesn't overflow [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533555 [16:55:08] 10WMEE: Wikimedia uus veebileht üles, koguda kasutajate tagasiside ja siis täiendada kuni esialgse rahuloluni - https://phabricator.wikimedia.org/T204043 (10kruusamagi) On see praegune parem või halvem, on omaette küsimus. Kindlasti on see aga mõneti erinev ja see on üsna ilmne, kui [[ https://www.wikimedia.fr/... [16:55:37] 04(no projects): Simplify the multifactor auth reset procedure - https://phabricator.wikimedia.org/T231667 (10mmodell) [16:55:51] (03PS1) 10Yaron Koren: Formatting improvements for be824fad041b [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/533557 [16:56:38] 10Phabricator: Simplify the multifactor auth reset procedure - https://phabricator.wikimedia.org/T231667 (10mmodell) p:05Triage→03Normal [16:59:33] 10Phabricator: Allow others than admins to edit forms - https://phabricator.wikimedia.org/T181031 (10mmodell) Unfortunately, yes this requires upstream changes. I actually spent quite a bit of time looking into this and I haven't been able to figure out which part of the phabricator code is enforcing this or how... [17:00:51] (03Merged) 10jenkins-bot: Actually assign suppression-related rights to 'suppress' group [core] - 10https://gerrit.wikimedia.org/r/530702 (https://phabricator.wikimedia.org/T230601) (owner: 10Daimona Eaytoy) [17:02:11] (03CR) 10jerkins-bot: [V: 04-1] Rewrite tokenizeCoords to use a while loop, and use it for 'poly' [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/500203 (owner: 10Esanders) [17:03:24] (03PS5) 10Fomafix: Parser: Add Title type hints [core] - 10https://gerrit.wikimedia.org/r/533002 [17:03:26] (03PS1) 10Fomafix: Parser: Move dummy title from setter to getter [core] - 10https://gerrit.wikimedia.org/r/533559 (https://phabricator.wikimedia.org/T228881) [17:05:21] (03CR) 10jerkins-bot: [V: 04-1] Skin: Initialize LinkRenderer in construtor [core] - 10https://gerrit.wikimedia.org/r/509625 (owner: 10Fomafix) [17:05:37] 10MediaWiki-API, 10Core Platform Team, 10Wikimedia-production-error: ApiQueryRevisions.php: PHP Notice: A non well formed numeric value encountered - https://phabricator.wikimedia.org/T231582 (10matmarex) It looks like we don't convert the `rvlimit` parameter to a number. This is because ApiQueryRevisions ca... [17:05:39] 10Editing Design, 10VisualEditor (Current work): Tweak the mockups legal message placement to account for keyboard being up - https://phabricator.wikimedia.org/T229428 (10ppelberg) This mockup is great, @iamjessklein. Copying over comments I'd posted in a different ticket: T229462#5453281 >>! In T229462#545... [17:05:41] (03PS4) 10Esanders: Rewrite tokenizeCoords to use a while loop, and use it for 'poly' [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/500203 [17:05:51] 10MediaWiki-General, 10Wikimedia-production-error: ApiQueryAllRevisions.php: PHP Notice: A non well formed numeric value encountered - https://phabricator.wikimedia.org/T231573 (10matmarex) [17:05:52] 10MediaWiki-API, 10Core Platform Team, 10Wikimedia-production-error: ApiQueryRevisions.php: PHP Notice: A non well formed numeric value encountered - https://phabricator.wikimedia.org/T231582 (10matmarex) [17:05:58] (03CR) 10Jforrester: "Nice. Should we deprecate RandomImageGenerator (in a follow-up, maybe; it's used in WikibaseMediaInfo)?" [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) (owner: 10Ppchelko) [17:07:52] (03CR) 10Ppchelko: "> Patch Set 12:" [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) (owner: 10Ppchelko) [17:08:54] (03CR) 10Catrope: ChangesListSpecialPage: Cache the change tag list and its summary (031 comment) [core] - 10https://gerrit.wikimedia.org/r/525882 (https://phabricator.wikimedia.org/T223260) (owner: 10Catrope) [17:09:14] (03PS3) 10Catrope: ChangesListSpecialPage: Cache the change tag list and its summary [core] - 10https://gerrit.wikimedia.org/r/525882 (https://phabricator.wikimedia.org/T223260) [17:09:38] (03PS4) 10Catrope: ChangesListSpecialPage: Cache the change tag list and its summary [core] - 10https://gerrit.wikimedia.org/r/525882 (https://phabricator.wikimedia.org/T223260) [17:09:55] 10MediaWiki-API, 10Core Platform Team Workboards (Clinic Duty Team), 10Wikimedia-production-error: ApiQueryRevisions.php: PHP Notice: A non well formed numeric value encountered - https://phabricator.wikimedia.org/T231582 (10Pchelolo) [17:11:28] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) (owner: 10Jdlrobson) [17:12:07] (03PS1) 10Catrope: Move SchemaRevisions and BaseUri config vars to packageFiles [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/533560 [17:12:50] (03PS2) 10Yaron Koren: Formatting improvements for be824fad041b [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/533557 [17:12:53] 10MediaWiki-General, 10Core Platform Team, 10CPT Initiatives (API Integration Tests), 10Code-Health: Create a suite of end-to-end API test for MediaWiki core - https://phabricator.wikimedia.org/T219873 (10CCicalese_WMF) [17:14:50] (03CR) 10Catrope: "check perf" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/533560 (owner: 10Catrope) [17:15:35] 10MediaWiki-API, 10Core Platform Team Workboards (Clinic Duty Team), 10Wikimedia-production-error: ApiQueryRevisions.php: PHP Notice: A non well formed numeric value encountered - https://phabricator.wikimedia.org/T231582 (10matmarex) Also, I couldn't reproduce the error locally – is this message only emitte... [17:15:46] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration): MCR schema migration - https://phabricator.wikimedia.org/T231668 (10CCicalese_WMF) [17:15:59] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration): MCR schema migration - https://phabricator.wikimedia.org/T231668 (10CCicalese_WMF) p:05Triage→03Normal [17:16:12] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress other phan issues [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [17:18:22] 10MediaWiki-User-management, 10Anti-Harassment (The Letter Song): [BUG] Composite blocks do not block deleting pages - https://phabricator.wikimedia.org/T229417 (10Tchanders) Most the appliesTo methods on `AbstractBlock` return either true or false. The exception is `AbstractBlock::appliesToRight`, which can a... [17:18:42] (03CR) 10Catrope: "Startup module delta on my localhost: -536 uncompressed, -229 after gzip" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/533560 (owner: 10Catrope) [17:19:09] (03PS5) 10Aaron Schulz: filebackend: fix PhpStorm warnings in FileBackend [core] - 10https://gerrit.wikimedia.org/r/523981 [17:21:15] (03PS1) 10Pwirth: Init commit [extensions/BlueSpiceSocialMicroBlog] - 10https://gerrit.wikimedia.org/r/533561 [17:22:42] (03PS1) 10Bartosz Dziewoński: ApiBase: Always validate that 'limit' is numeric [core] - 10https://gerrit.wikimedia.org/r/533562 (https://phabricator.wikimedia.org/T231582) [17:23:41] (03CR) 10Jdlrobson: [C: 03+2] "Since the bug is impacting usage of the feature we decided to push forward with the hack. These hacks will be removed in https://gerrit.wi" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533534 (https://phabricator.wikimedia.org/T230232) (owner: 10Niedzielski) [17:25:12] (03PS12) 10Jdlrobson: Change the default behaviour for mw-ui-icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531558 (https://phabricator.wikimedia.org/T229447) [17:26:35] (03CR) 10D3r1ck01: [C: 03+1] "lgtm too :)" [core] - 10https://gerrit.wikimedia.org/r/531694 (https://phabricator.wikimedia.org/T227849) (owner: 10Awight) [17:27:19] (03CR) 10Jdlrobson: "It could, but it will just get reverted in https://gerrit.wikimedia.org/r/531558 which will land in the next week or so, so I'd rather do " [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531186 (https://phabricator.wikimedia.org/T230033) (owner: 10Esanders) [17:28:09] 10Advanced Mobile Contributions, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Site header doesn't fit on screen in advanced contributors mode - https://phabricator.wikimedia.org/T230232 (10Jdlrobson) [17:29:34] 10GrowthExperiments, 10Product-Analytics, 10Growth-Team (Current Sprint): Analyze welcome survey experiment in Arabic Wikipedia - https://phabricator.wikimedia.org/T228117 (10nettrom_WMF) 05Open→03Resolved The results have now been published: https://www.mediawiki.org/wiki/Growth/Analytics_updates/Welcom... [17:29:35] 10GrowthExperiments, 10Growth-Team (Current Sprint): Setup Welcome Survey for Arabic Wikipedia - https://phabricator.wikimedia.org/T226221 (10nettrom_WMF) [17:30:25] 10Wikidata-Bridge: Investigate common.js bundle content/size - https://phabricator.wikimedia.org/T228857 (10Pablo-WMDE) [17:30:42] 10CologneBlue, 10Modern, 10Readers-Web-Backlog, 10Wikimedia-Site-requests: Undeploy the 'Cologne Blue' and 'Modern' skins from Wikimedia production, as no-one is keeping them working - https://phabricator.wikimedia.org/T115430 (10phuedx) >>! In T115430#1724958, @matmarex wrote: > I am still sort of kind of... [17:34:18] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Epic: Ensure all direct or indirect access to pre-MCR fields is gated with the MCR migration stage - https://phabricator.wikimedia.org/T231671 (10CCicalese_WMF) [17:34:59] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Epic: Ensure all direct or indirect access to pre-MCR fields is gated with the MCR migration stage - https://phabricator.wikimedia.org/T231671 (10CCicalese_WMF) p:05Triage→03Normal [17:35:15] 10Readers-Web-Backlog: Hackweek: collapsible sidebar in vector - https://phabricator.wikimedia.org/T229952 (10Jdlrobson) @ovasileva should this task be closed? [17:35:22] 10Readers-Web-Backlog: Hackweek: full sidebar in Minerva - https://phabricator.wikimedia.org/T229953 (10Jdlrobson) @ovasileva should this task be closed? [17:35:39] 10Readers-Web-Backlog: Hackweek: collapsible sidebar in vector - https://phabricator.wikimedia.org/T229952 (10Jdlrobson) a:03ovasileva [17:35:41] 10Readers-Web-Backlog: Hackweek: full sidebar in Minerva - https://phabricator.wikimedia.org/T229953 (10Jdlrobson) a:03ovasileva [17:37:45] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Epics), 10Epic: Stop writing to pre-MCR fields in WMF production - https://phabricator.wikimedia.org/T231672 (10CCicalese_WMF) [17:37:53] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Epics), 10Epic: Stop writing to pre-MCR fields in WMF production - https://phabricator.wikimedia.org/T231672 (10CCicalese_WMF) p:05Triage→03Normal [17:38:03] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Epics), 10Epic: Ensure all direct or indirect access to pre-MCR fields is gated with the MCR migration stage - https://phabricator.wikimedia.org/T231671 (10CCicalese_WMF) [17:39:07] 10Advanced Mobile Contributions, 10MinervaNeue, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Mobile, and 2 others: [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency - https://phabricator.wikimedia.org/T229440 (10Jdlrobson) [17:39:30] 10Advanced Mobile Contributions, 10MinervaNeue, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Mobile, and 2 others: [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency - https://phabricator.wikimedia.org/T229440 (10Jdlrobson) [17:40:04] 10Advanced Mobile Contributions, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Site header doesn't fit on screen in advanced contributors mode - https://phabricator.wikimedia.org/T230232 (10Jdlrobson) [17:40:09] 10Advanced Mobile Contributions, 10MinervaNeue, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Mobile, and 2 others: [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency - https://phabricator.wikimedia.org/T229440 (10Jdlrobson) [17:40:11] 10Advanced Mobile Contributions, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Site header doesn't fit on screen in advanced contributors mode - https://phabricator.wikimedia.org/T230232 (10Jdlrobson) [17:40:24] (03CR) 10jerkins-bot: [V: 04-1] Move SchemaRevisions and BaseUri config vars to packageFiles [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/533560 (owner: 10Catrope) [17:40:40] (03CR) 10Yaron Koren: [C: 03+2] Formatting improvements for be824fad041b [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/533557 (owner: 10Yaron Koren) [17:41:13] (03CR) 10jerkins-bot: [V: 04-1] Remove table of contents handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) (owner: 10Jdlrobson) [17:41:33] 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): [SPIKE 8hrs] AMC - display labels for toolbar actions on larger screens - https://phabricator.wikimedia.org/T226562 (10Jdlrobson) [17:41:35] 10Advanced Mobile Contributions, 10MinervaNeue, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Mobile, and 2 others: [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency - https://phabricator.wikimedia.org/T229440 (10Jdlrobson) [17:41:44] 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): [SPIKE 8hrs] AMC - display labels for toolbar actions on larger screens - https://phabricator.wikimedia.org/T226562 (10Jdlrobson) Blocked on T229440 [17:41:54] 10Advanced Mobile Contributions, 10MinervaNeue, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Mobile, and 2 others: [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency - https://phabricator.wikimedia.org/T229440 (10Jdlrobson) [17:41:57] 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): [SPIKE 8hrs] AMC - display labels for toolbar actions on larger screens - https://phabricator.wikimedia.org/T226562 (10Jdlrobson) [17:42:07] 10Advanced Mobile Contributions, 10MinervaNeue, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Mobile, and 2 others: [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency - https://phabricator.wikimedia.org/T229440 (10Jdlrobson) [17:42:11] 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): [SPIKE 8hrs] AMC - display labels for toolbar actions on larger screens - https://phabricator.wikimedia.org/T226562 (10Jdlrobson) [17:43:41] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Epics), 10Epic: Make SCHEMA_COMPAT_NEW the default MCR migration schema - https://phabricator.wikimedia.org/T231673 (10CCicalese_WMF) [17:43:51] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Epics), 10Epic: Make SCHEMA_COMPAT_NEW the default MCR migration schema - https://phabricator.wikimedia.org/T231673 (10CCicalese_WMF) p:05Triage→03Normal [17:44:56] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Epics), 10Epic, 10MW-1.34-release: Make SCHEMA_COMPAT_NEW the default MCR migration schema - https://phabricator.wikimedia.org/T231673 (10CCicalese_WMF) [17:46:51] (03CR) 10jerkins-bot: [V: 04-1] Change the default behaviour for mw-ui-icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531558 (https://phabricator.wikimedia.org/T229447) (owner: 10Jdlrobson) [17:47:02] (03PS44) 10Jdlrobson: Document all our components in storybook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 (https://phabricator.wikimedia.org/T231489) [17:47:04] (03CR) 10D3r1ck01: "Can still spot a use, correct me if I'm wrong: https://github.com/wikimedia/mediawiki-skins-MinervaNeue/blob/master/includes/skins/SkinMin" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533230 (owner: 10Niedzielski) [17:48:00] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Epics), 10Epic, 10MW-1.35-release: Remove the ability to write pre-MCR fields, limit the ability to read pre-MCR fields to migration scripts - https://phabricator.wikimedia.org/T231674 (10CCicalese_WMF) [17:48:02] (03CR) 10jerkins-bot: [V: 04-1] Rewrite tokenizeCoords to use a while loop, and use it for 'poly' [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/500203 (owner: 10Esanders) [17:48:44] (03CR) 10D3r1ck01: [dev] [edit] rename EDIT permission to CONTENT_EDIT (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533230 (owner: 10Niedzielski) [17:52:09] (03CR) 10jerkins-bot: [V: 04-1] Move SchemaRevisions and BaseUri config vars to packageFiles [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/533560 (owner: 10Catrope) [17:55:15] (03PS13) 10Jdlrobson: Change the default behaviour for mw-ui-icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531558 (https://phabricator.wikimedia.org/T229447) [17:55:17] (03PS1) 10Isarra: Better padding for new messages yellow [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533565 [17:55:22] 10Product-Analytics, 10Growth-Team (Current Sprint): Homepage: update reporting queries to utilize all data - https://phabricator.wikimedia.org/T230215 (10MMiller_WMF) 05Open→03Resolved @nettrom_WMF -- it is working! Thank you! [17:56:55] 10CologneBlue, 10Modern, 10Readers-Web-Backlog, 10Wikimedia-Site-requests: Undeploy the 'Cologne Blue' and 'Modern' skins from Wikimedia production, as no-one is keeping them working - https://phabricator.wikimedia.org/T115430 (10matmarex) Go ahead, I'm still volunteering to maintain them. [17:57:25] 10MediaWiki-Recent-changes, 10Advanced Mobile Contributions, 10Edit-Review-Improvements-RC-Page, 10Growth-Team, and 2 others: Click trash on recent changes doesn't clear open filter menus - https://phabricator.wikimedia.org/T231053 (10MMiller_WMF) Okay -- we'll hold off, and see if this should go into our... [17:58:25] 10MediaWiki-User-management, 10Anti-Harassment (The Letter Song): [BUG] Composite blocks do not block deleting pages - https://phabricator.wikimedia.org/T229417 (10Tchanders) a:03Tchanders [17:58:27] (03PS2) 10Jdlrobson: [hack] [toolbar] tighten the icon spacing [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533534 (https://phabricator.wikimedia.org/T230232) (owner: 10Niedzielski) [17:58:33] (03CR) 10Jdlrobson: [C: 03+2] [hack] [toolbar] tighten the icon spacing [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533534 (https://phabricator.wikimedia.org/T230232) (owner: 10Niedzielski) [17:58:47] 10MediaWiki-API, 10Core Platform Team, 10Patch-For-Review: The action API should have a flag that delays the response until all replicas have seen any changes caused by the request - https://phabricator.wikimedia.org/T230211 (10Krinkle) >>! In T230211#5451463, @daniel wrote: >>>! In T230211#5451106, @Krinkle... [17:59:02] 10Advanced Mobile Contributions, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Site header doesn't fit on screen in advanced contributors mode - https://phabricator.wikimedia.org/T230232 (10matmarex) Nice, I was going to complain about this too :) [17:59:07] (03CR) 10jenkins-bot: Actually assign suppression-related rights to 'suppress' group [core] - 10https://gerrit.wikimedia.org/r/530702 (https://phabricator.wikimedia.org/T230601) (owner: 10Daimona Eaytoy) [17:59:23] 10Timeless: Add jump to bottom and jump to top buttons to the freezed upper menu - https://phabricator.wikimedia.org/T173245 (10Isarra) Not just in the fixed header, also really needed on mobile... [18:00:26] (03CR) 10jerkins-bot: [V: 04-1] ApiBase: Always validate that 'limit' is numeric [core] - 10https://gerrit.wikimedia.org/r/533562 (https://phabricator.wikimedia.org/T231582) (owner: 10Bartosz Dziewoński) [18:01:21] (03PS1) 10Daimona Eaytoy: Unsuppress more phan issues [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) [18:02:12] (03PS4) 10Daimona Eaytoy: Unsuppress other phan issues [core] - 10https://gerrit.wikimedia.org/r/533547 (https://phabricator.wikimedia.org/T231636) [18:02:24] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress more phan issues [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [18:02:26] (03PS2) 10Daimona Eaytoy: Unsuppress more phan issues [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) [18:02:28] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress more phan issues [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [18:02:30] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress more phan issues [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [18:02:32] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress more phan issues [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [18:02:34] 10MediaWiki-API, 10Core Platform Team, 10Patch-For-Review: The action API should have a flag that delays the response until all replicas have seen any changes caused by the request - https://phabricator.wikimedia.org/T230211 (10Krinkle) >>! In T230211#5451463, @daniel wrote: >>>! In T230211#5451106, @Krinkle... [18:02:44] 10MediaWiki-API, 10Core Platform Team, 10Patch-For-Review, 10Performance-Team (Radar): The action API should have a flag that delays the response until all replicas have seen any changes caused by the request - https://phabricator.wikimedia.org/T230211 (10Krinkle) [18:05:26] (03CR) 10jerkins-bot: [V: 04-1] ApiBase: Always validate that 'limit' is numeric [core] - 10https://gerrit.wikimedia.org/r/533562 (https://phabricator.wikimedia.org/T231582) (owner: 10Bartosz Dziewoński) [18:05:31] (03CR) 10jerkins-bot: [V: 04-1] Change the default behaviour for mw-ui-icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531558 (https://phabricator.wikimedia.org/T229447) (owner: 10Jdlrobson) [18:07:14] 10Machine vision, 10Structured-Data-Backlog: [Stub] Implement features that allow for tracking and measuring machine-aided depicts usage/activity - https://phabricator.wikimedia.org/T231032 (10Mholloway) I can add a `machine-aided depicts` tag (or similar) to every revision adding a depicts statement, as a start. [18:08:20] (03PS45) 10Jdlrobson: Document all our components in storybook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 (https://phabricator.wikimedia.org/T231489) [18:09:06] (03PS14) 10Jdlrobson: Change the default behaviour for mw-ui-icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531558 (https://phabricator.wikimedia.org/T229447) [18:10:13] 10Machine vision, 10Structured-Data-Backlog: [Stub] Implement features that allow for tracking and measuring machine-aided depicts usage/activity - https://phabricator.wikimedia.org/T231032 (10Ramsey-WMF) >>! In T231032#5454811, @Mholloway wrote: > I can add a `machine-aided depicts` tag (or similar) to every... [18:11:13] 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Add storybook to MobileFrontend to guard against potential UI regressions - https://phabricator.wikimedia.org/T231489 (10... [18:11:55] 10MediaWiki-Core-Testing: Wrap file access so it can be mocked - https://phabricator.wikimedia.org/T231159 (10Krinkle) @Simetrical Disabling access for the case of "doesn't depend on FS" seems useful, and could perhaps be mimicked with a vfsStream mock that has deleted the file it would read and/or give it a rea... [18:11:58] (03Abandoned) 10Jdlrobson: WIP: DownloadIcon CTA [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/460983 (owner: 10Jdlrobson) [18:12:13] (03PS3) 10Jdrewniak: [WIP] Customize mw-ui-icon to ensure consistent sizing and touch targets [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533360 [18:12:38] (03Abandoned) 10Jdlrobson: Use pseudo elements to style changelist-separators on other special pages [core] - 10https://gerrit.wikimedia.org/r/463141 (https://phabricator.wikimedia.org/T205581) (owner: 10Jdlrobson) [18:13:07] (03Abandoned) 10Jdlrobson: WIP: Cleanup recent changes on Minerva (desktop) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/510135 (owner: 10Jdlrobson) [18:15:28] (03CR) 10jerkins-bot: [V: 04-1] ApiBase: Always validate that 'limit' is numeric [core] - 10https://gerrit.wikimedia.org/r/533562 (https://phabricator.wikimedia.org/T231582) (owner: 10Bartosz Dziewoński) [18:15:30] (03CR) 10Pmiazga: [C: 03+1] "1, looks ok, but first we need to find out why CI is failing." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) (owner: 10Jdlrobson) [18:16:10] (03Merged) 10jenkins-bot: Return null from EditPage::importContentFormData [core] - 10https://gerrit.wikimedia.org/r/517710 (owner: 10Umherirrender) [18:16:22] (03CR) 10Reedy: "I've got a yubikey 5 being delivered tomorrow." [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/508788 (https://phabricator.wikimedia.org/T218211) (owner: 10ItSpiderman) [18:17:44] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Epics), 10Epic, 10MW-1.35-release: Remove the ability to write pre-MCR fields, limit the ability to read pre-MCR fields to migration scripts - https://phabricator.wikimedia.org/T231674 (10CCicalese_WMF) p:05... [18:18:33] (03PS1) 10Daimona Eaytoy: [WIP] Unsuppress phan issues part 6 [core] - 10https://gerrit.wikimedia.org/r/533567 (https://phabricator.wikimedia.org/T231636) [18:19:27] 10CologneBlue, 10Modern, 10Readers-Web-Backlog, 10Wikimedia-Site-requests: Undeploy the 'Cologne Blue' and 'Modern' skins from Wikimedia production, as no-one is keeping them working - https://phabricator.wikimedia.org/T115430 (10Jdforrester-WMF) >>! In T115430#2069739, @Bawolff wrote: > Shouldn't new feat... [18:19:56] 10Design, 10OOUI, 10Patch-For-Review: Chemistry beaker icon should have open top - https://phabricator.wikimedia.org/T226168 (10Esanders) > Even if there are no experimental features active right now, we need to decide whether the beaker icon should cover also this meaning or it should be restricted only to... [18:20:41] (03CR) 10jerkins-bot: [V: 04-1] ApiBase: Always validate that 'limit' is numeric [core] - 10https://gerrit.wikimedia.org/r/533562 (https://phabricator.wikimedia.org/T231582) (owner: 10Bartosz Dziewoński) [18:22:38] (03PS1) 10Paladox: Fix "Column 'user_email' cannot be null" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/533569 [18:22:43] 10Timeless: Add jump to bottom and jump to top buttons to the freezed upper menu - https://phabricator.wikimedia.org/T173245 (10Izno) This is gadget worthy IMO, not skin worthy. No other skin has it today. [18:24:36] 10MediaWiki-Core-Testing, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Patch-For-Review, 10phan: Butcher the list of phan suppressions in MW core - https://phabricator.wikimedia.org/T231636 (10Daimona) a:03Daimona As of the [[https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/533566|last patch]], ther... [18:26:35] (03PS12) 10Ppchelko: Introduce RevisionStore::newRevisionsFromBatch [core] - 10https://gerrit.wikimedia.org/r/531308 (https://phabricator.wikimedia.org/T228988) [18:26:48] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress more phan issues [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [18:27:00] 10Texvcjs, 10Patch-For-Review: Adjust texvcjs to prevent whitespace modifications in ce-tags - https://phabricator.wikimedia.org/T140217 (10Esanders) @Physikerwelt The documentation at https://en.wikipedia.org/wiki/Help:Displaying_a_formula#Chemistry states "Please note that there are still major issues with m... [18:27:44] (03PS2) 10Paladox: Fix "Column 'user_email' cannot be null" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/533569 [18:30:12] (03CR) 10Jack Phoenix: [C: 03+2] "D'oh, thanks!" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/533569 (owner: 10Paladox) [18:31:04] (03CR) 10D3r1ck01: "check php" [core] - 10https://gerrit.wikimedia.org/r/533135 (owner: 10Aaron Schulz) [18:31:11] 10MediaWiki-extensions-CentralAuth, 10Anti-Harassment (The Letter Song), 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03): Replace UserIsHidden with GetUserBlock in CentralAuth - https://phabricator.wikimedia.org/T228950 (10dom_walden) If a user is hidden via Special:CentralAuth, any blocks they have (unless they... [18:31:39] (03CR) 10Ppchelko: "> Patch Set 11:" [core] - 10https://gerrit.wikimedia.org/r/531308 (https://phabricator.wikimedia.org/T228988) (owner: 10Ppchelko) [18:32:05] 10Timeless: Add jump to bottom and jump to top buttons to the freezed upper menu - https://phabricator.wikimedia.org/T173245 (10Isarra) What we might want to do is include the jump buttons in the mobile one only, but by doing so, clearly establish what the handles would be for a gadget for desktop modes where pe... [18:32:19] (03CR) 10jerkins-bot: [V: 04-1] Document all our components in storybook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 (https://phabricator.wikimedia.org/T231489) (owner: 10Jdlrobson) [18:35:14] (03CR) 10D3r1ck01: "recheck" [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/533446 (owner: 10L10n-bot) [18:35:50] (03CR) 10jerkins-bot: [V: 04-1] Change the default behaviour for mw-ui-icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531558 (https://phabricator.wikimedia.org/T229447) (owner: 10Jdlrobson) [18:36:00] (03PS4) 10Jdlrobson: Remove all the icon hacks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533111 (https://phabricator.wikimedia.org/T229447) [18:36:24] (03CR) 10D3r1ck01: "recheck" [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/533413 (owner: 10L10n-bot) [18:36:37] (03PS1) 10Esanders: Re-render MWChemSymbols.css [extensions/Math] - 10https://gerrit.wikimedia.org/r/533573 (https://phabricator.wikimedia.org/T166936) [18:37:10] 10Phabricator: Simplify the multifactor auth reset procedure - https://phabricator.wikimedia.org/T231667 (10Reedy) >One thing that could improve the situation would be supporting pre-generated reset codes, however, that isn't currently supported in phabricator. The fact phab doesn't have this seems a massive ov... [18:37:23] (03CR) 10jerkins-bot: [V: 04-1] Fix PhpStorm IDE warnings in ServiceWiring.php [core] - 10https://gerrit.wikimedia.org/r/533135 (owner: 10Aaron Schulz) [18:38:11] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Customize mw-ui-icon to ensure consistent sizing and touch targets [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533360 (owner: 10Jdrewniak) [18:38:19] 10Phabricator: Simplify the multifactor auth reset procedure - https://phabricator.wikimedia.org/T231667 (10mmodell) @reedy: yeah I'm inclined to look into adding this feature to Phabricator though I am not sure how it should be implemented. [18:38:55] 10Phabricator: Simplify the multifactor auth reset procedure - https://phabricator.wikimedia.org/T231667 (10Reedy) Generate N codes, save them in a database column somewhere? :) [18:38:58] (03Merged) 10jenkins-bot: Make Special:ChangeContentModel field labels consistently use colons [core] - 10https://gerrit.wikimedia.org/r/527670 (owner: 10Brian Wolff) [18:39:00] (03Merged) 10jenkins-bot: ContributionsQuery: Drop 'newbies' feature support, killed in core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533306 (https://phabricator.wikimedia.org/T231540) (owner: 10Jforrester) [18:39:22] (03CR) 10jenkins-bot: Return null from EditPage::importContentFormData [core] - 10https://gerrit.wikimedia.org/r/517710 (owner: 10Umherirrender) [18:40:36] (03PS3) 10Aaron Schulz: filebackend: improve FileBackendMultiWrite consistencyCheck()/resyncFiles() [core] - 10https://gerrit.wikimedia.org/r/533143 (https://phabricator.wikimedia.org/T231086) [18:41:37] 10Phabricator: Simplify the multifactor auth reset procedure - https://phabricator.wikimedia.org/T231667 (10mmodell) >>! In T231667#5454888, @Reedy wrote: > Generate N codes, save them in a database column somewhere? :) Yeah, I guess that covers the core of it. Also need a UI for the user to access and save th... [18:42:32] (03PS4) 10Krinkle: ContribsPage: Re-remove the getContribs() method again [core] - 10https://gerrit.wikimedia.org/r/533325 (https://phabricator.wikimedia.org/T220447) (owner: 10DannyS712) [18:43:53] 10Phabricator: Simplify the multifactor auth reset procedure - https://phabricator.wikimedia.org/T231667 (10Reedy) Re-generation and other UI-niceness is definitely a nice to have... But having them generated at enrollment, and then useable on request for a TOTP would seemingly be a MVP Which is basically the s... [18:43:59] 10MediaWiki-User-management, 10Anti-Harassment (The Letter Song): [BUG] Composite blocks do not block deleting pages - https://phabricator.wikimedia.org/T229417 (10dom_walden) For what it is worth, here is my patch to tests/phpunit/includes/Permissions/PermissionManagerTest.php which shows this bug for a numbe... [18:44:01] 10Phabricator: Simplify the multifactor auth reset procedure - https://phabricator.wikimedia.org/T231667 (10mmodell) So the question is whether this is worth the effort to implement. I'd imagine it would eventually pay for itself in time saved dealing with 2factor resets. And that is not even to mention the imp... [18:44:04] (03CR) 10D3r1ck01: "Failures seems legit:" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533135 (owner: 10Aaron Schulz) [18:44:50] 10MediaWiki-Cache, 10Technical-Debt: BagOStuff should detect obsolete serialization or an unserialization resulting in a "wrong" object - https://phabricator.wikimedia.org/T156541 (10Krinkle) 05Open→03Declined Obsolete per [Development policy](https://www.mediawiki.org/wiki/Development_policy#Implementatio... [18:45:03] 10MediaWiki-Cache, 10Core Platform Team, 10Technical-Debt: BagOStuff should detect obsolete serialization or an unserialization resulting in a "wrong" object - https://phabricator.wikimedia.org/T156541 (10Krinkle) [18:45:24] 10Phabricator: Simplify the multifactor auth reset procedure - https://phabricator.wikimedia.org/T231667 (10Reedy) >>! In T231667#5454898, @mmodell wrote: > So the question is whether this is worth the effort to implement. I'd imagine it would eventually pay for itself in time saved dealing with 2factor resets.... [18:50:31] (03CR) 10D3r1ck01: [C: 03+2] Localisation updates from https://translatewiki.net. [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/533446 (owner: 10L10n-bot) [18:55:25] (03CR) 10Krinkle: [C: 03+2] rdbms: add more ScopedCallback::newScopedIgnoreUserAbort() calls [core] - 10https://gerrit.wikimedia.org/r/533373 (https://phabricator.wikimedia.org/T231443) (owner: 10Aaron Schulz) [18:56:01] 10Discovery-Search: Improve Basque language processing for search - https://phabricator.wikimedia.org/T231593 (10TJones) [19:00:44] (03Abandoned) 10Ejegg: WIP template https nginx conf [vagrant] - 10https://gerrit.wikimedia.org/r/399706 (owner: 10Ejegg) [19:02:38] (03PS1) 10Tchanders: Use DatabaseBlock instead of deprecated Block in CompositeBlock tests [core] - 10https://gerrit.wikimedia.org/r/533574 [19:02:40] (03PS1) 10Tchanders: Allow CompositeBlock::appliesToRight to return null when unsure [core] - 10https://gerrit.wikimedia.org/r/533575 (https://phabricator.wikimedia.org/T229417) [19:03:29] (03PS2) 10Reedy: Update version to 0.4.0 to keep better track of changes [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/533195 [19:03:34] (03CR) 10Reedy: [C: 03+2] Update version to 0.4.0 to keep better track of changes [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/533195 (owner: 10Reedy) [19:05:04] (03CR) 10Anomie: libs/Message: Improve documentation (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533331 (owner: 10Anomie) [19:05:37] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress more phan issues [core] - 10https://gerrit.wikimedia.org/r/533566 (https://phabricator.wikimedia.org/T231636) (owner: 10Daimona Eaytoy) [19:06:11] 10Wiki-Loves-Monuments (2019): WLM Nigeria: Add id support to UploadCampaign - https://phabricator.wikimedia.org/T231643 (10Lokal_Profil) [19:06:44] (03CR) 10jenkins-bot: ContributionsQuery: Drop 'newbies' feature support, killed in core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533306 (https://phabricator.wikimedia.org/T231540) (owner: 10Jforrester) [19:08:54] (03CR) 10jerkins-bot: [V: 04-1] Remove all the icon hacks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533111 (https://phabricator.wikimedia.org/T229447) (owner: 10Jdlrobson) [19:11:02] (03PS3) 10Yaron Koren: Formatting improvements for be824fad041b [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/533557 [19:11:09] (03CR) 10jerkins-bot: [V: 04-1] Update version to 0.4.0 to keep better track of changes [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/533195 (owner: 10Reedy) [19:12:42] (03PS1) 10Fomafix: ApiExpandTemplates: Remove last asignment of $titleProvided [core] - 10https://gerrit.wikimedia.org/r/533579 [19:13:54] 10MediaWiki-extensions-Page_Forms: PageForms: Drop support for PHP 5.3 - https://phabricator.wikimedia.org/T231665 (10Yaron_Koren) I plan to do this as soon as support for MediaWiki 1.26 and earlier is dropped - which is also overdue. It might happen soon. [19:16:48] (03PS1) 10Anomie: lib/Message: Support MessageValue as a parameter [core] - 10https://gerrit.wikimedia.org/r/533580 [19:16:55] 10Phabricator: Simplify the multifactor auth reset procedure - https://phabricator.wikimedia.org/T231667 (10epriestley) See also some discussion in T187256. [19:17:23] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/533381 (owner: 10L10n-bot) [19:17:40] 10Wiki-Loves-Monuments-Database, 10Wiki-Loves-Monuments (2019): Investigate what needs to be done on Heritage infrastructure for Structured Data on Commons - https://phabricator.wikimedia.org/T220119 (10Lokal_Profil) Related: https://commons.wikimedia.org/wiki/Commons_talk:Structured_data/Properties_table#Wiki... [19:17:44] (03PS1) 10Esanders: makeSvgsAndCss.js: Add more logging and an '--all' flag [extensions/Math] - 10https://gerrit.wikimedia.org/r/533581 [19:17:55] (03PS1) 10Reedy: Add missing qqq for oathauth-ui-not-enabled-modules [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/533582 [19:18:08] (03PS46) 10Jdlrobson: Document all our components in storybook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 (https://phabricator.wikimedia.org/T231489) [19:19:18] (03CR) 10Reedy: "Blocking merge of other patches..." [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/533582 (owner: 10Reedy) [19:19:25] (03CR) 10Yaron Koren: [C: 03+2] Formatting improvements for be824fad041b [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/533557 (owner: 10Yaron Koren) [19:22:25] (03PS2) 10Reedy: Re-add missing qqq for oathauth-ui-not-enabled-modules [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/533582 [19:23:17] (03PS3) 10Reedy: Re-add missing qqq for oathauth-ui-not-enabled-modules [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/533582 [19:24:29] (03PS47) 10Jdlrobson: Document all our components in storybook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 (https://phabricator.wikimedia.org/T231489) [19:24:56] (03PS4) 10Reedy: Re-add missing qqq for oathauth-ui-not-enabled-modules [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/533582 [19:25:49] (03CR) 10Reedy: [C: 03+2] "nth time lucky. Self merging to fix breakage by localisation update" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/533582 (owner: 10Reedy) [19:30:11] (03CR) 10Raimond Spekking: [C: 03+1] "i18n review" [extensions/BlueSpiceSocialMicroBlog] - 10https://gerrit.wikimedia.org/r/533561 (owner: 10Pwirth) [19:30:53] (03PS1) 10Fomafix: Use SpecialPage::getTitleFor to get special titles [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/533585 [19:33:23] (03CR) 10jenkins-bot: Make Special:ChangeContentModel field labels consistently use colons [core] - 10https://gerrit.wikimedia.org/r/527670 (owner: 10Brian Wolff) [19:34:03] (03CR) 10Zoranzoki21: [C: 03+1] "This got blocked in zuul, but you fixed error in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/OATHAuth/+/533582/ so after submi" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/533195 (owner: 10Reedy) [19:34:30] (03CR) 10Reedy: [C: 03+2] "Yes thanks. I know how CI works ;)" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/533195 (owner: 10Reedy) [19:37:55] 10Wikipedia-Android-App-Backlog: Share button and "copy to clipboard" doesn't work - https://phabricator.wikimedia.org/T231682 (10LGoto) [19:38:37] (03PS5) 10Jdlrobson: Remove all the icon hacks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533111 (https://phabricator.wikimedia.org/T229447) [19:38:39] (03PS1) 10Jdlrobson: Separate text element from mw-ui-icon-before [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533586 (https://phabricator.wikimedia.org/T229440) [19:39:58] (03CR) 10Jdlrobson: "This should be mergeable if you are happy to update mw-ui-icon-before to always have a span wrapping the label." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533586 (https://phabricator.wikimedia.org/T229440) (owner: 10Jdlrobson) [19:40:18] I see minervaneue is going for the slowest merge trophy today [19:41:59] (03Merged) 10jenkins-bot: [hack] [toolbar] tighten the icon spacing [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533534 (https://phabricator.wikimedia.org/T230232) (owner: 10Niedzielski) [19:42:04] (03PS1) 10JJMC89: Assign flow-suppress to suppress group [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533588 [19:42:06] (03Merged) 10jenkins-bot: Fix "Column 'user_email' cannot be null" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/533569 (owner: 10Paladox) [19:42:09] (03Merged) 10jenkins-bot: rdbms: add more ScopedCallback::newScopedIgnoreUserAbort() calls [core] - 10https://gerrit.wikimedia.org/r/533373 (https://phabricator.wikimedia.org/T231443) (owner: 10Aaron Schulz) [19:42:12] (03CR) 10jerkins-bot: [V: 04-1] Update version to 0.4.0 to keep better track of changes [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/533195 (owner: 10Reedy) [19:42:14] (03Merged) 10jenkins-bot: Formatting improvements for be824fad041b [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/533557 (owner: 10Yaron Koren) [19:42:17] (03Merged) 10jenkins-bot: Re-add missing qqq for oathauth-ui-not-enabled-modules [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/533582 (owner: 10Reedy) [19:42:49] (03PS3) 10Reedy: Update version to 0.4.0 to keep better track of changes [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/533195 [19:43:39] (03CR) 10Reedy: [C: 03+2] Update version to 0.4.0 to keep better track of changes [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/533195 (owner: 10Reedy) [19:44:46] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10good first bug, 10patch-welcome: Add monolingual language code peo (Old Persian) - https://phabricator.wikimedia.org/T189427 (10jhsoby) Ok from LangCom. [19:45:10] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/533446 (owner: 10L10n-bot) [19:45:20] (03CR) 10Zoranzoki21: [C: 03+1] "> Yes thanks. I know how CI works ;)" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/533195 (owner: 10Reedy) [19:46:25] (03CR) 10jenkins-bot: [hack] [toolbar] tighten the icon spacing [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533534 (https://phabricator.wikimedia.org/T230232) (owner: 10Niedzielski) [19:47:08] (03CR) 10Jforrester: [C: 03+2] Re-render MWChemSymbols.css [extensions/Math] - 10https://gerrit.wikimedia.org/r/533573 (https://phabricator.wikimedia.org/T166936) (owner: 10Esanders) [19:47:28] (03CR) 10Jforrester: [C: 03+2] makeSvgsAndCss.js: Add more logging and an '--all' flag [extensions/Math] - 10https://gerrit.wikimedia.org/r/533581 (owner: 10Esanders) [19:49:09] (03CR) 10jenkins-bot: Formatting improvements for be824fad041b [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/533557 (owner: 10Yaron Koren) [19:49:12] (03PS5) 10Jdlrobson: Remove table of contents handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) [19:49:16] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Community-consensus-needed, 10good first bug, 10patch-welcome: Add monolingual language code kld (Gamilaraay) - https://phabricator.wikimedia.org/T198366 (10jhsoby) Ok from LangCom for monolingual. We could add it for labels + descriptions as well,... [19:50:47] 10Advanced Mobile Contributions, 10MinervaNeue, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Mobile, and 2 others: Remove concept of "large" icon in MF/Minerva - https://phabricator.wikimedia.org/T231683 (10alexhollender) [19:53:14] (03PS2) 10JJMC89: Assign flow-suppress to the suppress group and oversight grant [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533588 [19:53:19] 10Advanced Mobile Contributions, 10MinervaNeue, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Mobile, and 3 others: [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency - https://phabricator.wikimedia.org/T229440 (10alexhollender) Notes from our recent conversation: - It doesn't make sense to... [19:53:31] 10Design, 10OOUI, 10Patch-For-Review: Chemistry beaker icon should have open top - https://phabricator.wikimedia.org/T226168 (10YBG) A note here, the icon depicted here - whether open or closed - does NOT represent a beaker. See https://en.wikipedia.org/wiki/Beaker_(glassware). The icon is depicting an Erle... [19:54:39] (03CR) 10Pmiazga: [edit] [UI] hide edit section links for blocked users (033 comments) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/532794 (https://phabricator.wikimedia.org/T206265) (owner: 10Niedzielski) [19:54:48] 10Advanced Mobile Contributions, 10MinervaNeue, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Mobile, and 3 others: [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency - https://phabricator.wikimedia.org/T229440 (10alexhollender) [19:57:54] (03CR) 10jenkins-bot: rdbms: add more ScopedCallback::newScopedIgnoreUserAbort() calls [core] - 10https://gerrit.wikimedia.org/r/533373 (https://phabricator.wikimedia.org/T231443) (owner: 10Aaron Schulz) [19:58:27] (03Merged) 10jenkins-bot: Update version to 0.4.0 to keep better track of changes [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/533195 (owner: 10Reedy) [19:59:12] (03PS1) 10Yaron Koren: Fix for be824fad041b - remove unneeded i18n param [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/533591 [19:59:16] (03CR) 10Zoranzoki21: [C: 03+1] "requeue" [core] - 10https://gerrit.wikimedia.org/r/526517 (owner: 10Reedy) [19:59:54] (03PS2) 10Yaron Koren: Fix for be824fad041b - remove unneeded i18n param [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/533591 [20:01:05] 10Advanced Mobile Contributions, 10MinervaNeue, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Mobile, and 3 others: [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency - https://phabricator.wikimedia.org/T229440 (10alexhollender) [20:01:30] (03PS7) 10Niedzielski: [edit] [UI] hide edit section links for blocked users [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/532794 (https://phabricator.wikimedia.org/T206265) [20:01:40] (03CR) 10Niedzielski: [edit] [UI] hide edit section links for blocked users (033 comments) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/532794 (https://phabricator.wikimedia.org/T206265) (owner: 10Niedzielski) [20:02:00] (03PS8) 10Jdlrobson: [edit] [UI] hide edit section links for blocked users [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/532794 (https://phabricator.wikimedia.org/T206265) (owner: 10Niedzielski) [20:02:01] (03PS5) 10Jdlrobson: [dev] [edit] rename EDIT permission to CONTENT_EDIT [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533230 (owner: 10Niedzielski) [20:02:03] (03PS2) 10Jdlrobson: [toolbar] show page action labels on wide screens [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533293 (https://phabricator.wikimedia.org/T226562) (owner: 10Niedzielski) [20:02:06] (03PS15) 10Jdlrobson: WIP: Remove the mw-ui-icon hacks [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531558 (https://phabricator.wikimedia.org/T229447) [20:02:45] (03CR) 10jerkins-bot: [V: 04-1] Separate text element from mw-ui-icon-before [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533586 (https://phabricator.wikimedia.org/T229440) (owner: 10Jdlrobson) [20:02:46] 10Timeless: Implement theme support and add 'winter' and 'night' variants - https://phabricator.wikimedia.org/T131991 (10Isarra) Not listed is experiment 2, because I forgot to link the task: https://gerrit.wikimedia.org/r/c/mediawiki/skins/Timeless/+/530456 [20:02:57] (03CR) 10jerkins-bot: [V: 04-1] Remove table of contents handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) (owner: 10Jdlrobson) [20:03:50] (03CR) 10jerkins-bot: [V: 04-1] Remove all the icon hacks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533111 (https://phabricator.wikimedia.org/T229447) (owner: 10Jdlrobson) [20:08:09] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Community-consensus-needed: Add monolingual language code tnq (Taíno) and car (Kalinago) - https://phabricator.wikimedia.org/T220284 (10jhsoby) @Mbch331 As far as I can tell from the Wikipedia article Taíno never had a written language before it went e... [20:09:32] (03CR) 10Yaron Koren: [C: 03+2] Fix for be824fad041b - remove unneeded i18n param [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/533591 (owner: 10Yaron Koren) [20:10:34] (03CR) 10Anomie: "Should a stub file be provided for the constants and the global excimer_set_timeout() function?" (035 comments) [php/excimer] - 10https://gerrit.wikimedia.org/r/533147 (https://phabricator.wikimedia.org/T207499) (owner: 10Tim Starling) [20:13:23] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/GlobalContribs] - 10https://gerrit.wikimedia.org/r/533104 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [20:16:18] (03CR) 10Jforrester: [C: 03+2] ContribsPage: Re-remove the getContribs() method again (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533325 (https://phabricator.wikimedia.org/T220447) (owner: 10DannyS712) [20:19:14] (03CR) 10Anomie: [C: 04-1] "-1 for line 581, `initial` is currently unused." (032 comments) [php/excimer] - 10https://gerrit.wikimedia.org/r/533150 (https://phabricator.wikimedia.org/T207498) (owner: 10Tim Starling) [20:20:58] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Growth-Team: Indentation of grouped entries at watchlist and recent changes got a bit weirdo - https://phabricator.wikimedia.org/T225727 (10jeblad) Still weird layout at enwiki. Tested with and without Javascript. Also changed user language. [20:23:04] 10MediaWiki-extensions-CentralAuth, 10Anti-Harassment (The Letter Song), 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03): Replace UserIsHidden with GetUserBlock in CentralAuth - https://phabricator.wikimedia.org/T228950 (10Tchanders) It sounds like the following would be a better approach: * If the user is unblo... [20:23:59] (03CR) 10jerkins-bot: [V: 04-1] Re-render MWChemSymbols.css [extensions/Math] - 10https://gerrit.wikimedia.org/r/533573 (https://phabricator.wikimedia.org/T166936) (owner: 10Esanders) [20:24:02] (03CR) 10jerkins-bot: [V: 04-1] makeSvgsAndCss.js: Add more logging and an '--all' flag [extensions/Math] - 10https://gerrit.wikimedia.org/r/533581 (owner: 10Esanders) [20:24:46] (03CR) 10Bartosz Dziewoński: "Looks like TOC is never shown in mobile format after this change. I suspect some other code somewhere is removing it, expecting the custom" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) (owner: 10Jdlrobson) [20:25:50] 10WMEE: How to convert into Phabricator ehk WMEE pöörab ennast Phabricatori usku - https://phabricator.wikimedia.org/T204035 (10tramm) [20:25:52] 10WMEE Chapter: Phabricatori koolitus 31.10 - https://phabricator.wikimedia.org/T208445 (10tramm) [20:28:09] (03CR) 10Aezell: [C: 03+1] "This makes perfect sense to me." [core] - 10https://gerrit.wikimedia.org/r/533575 (https://phabricator.wikimedia.org/T229417) (owner: 10Tchanders) [20:29:30] 10MediaWiki-extensions-CentralAuth, 10Anti-Harassment (The Letter Song), 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03): Replace UserIsHidden with GetUserBlock in CentralAuth - https://phabricator.wikimedia.org/T228950 (10Niharika) Thanks for the detailed explanation, @dom_walden! >>! In T228950#5455122, @Tcha... [20:30:02] (03CR) 10Kosta Harlan: [C: 04-1] "This fails on `composer phpunit -- /path/to/integration/test` e.g. `composer phpunit -- tests/phpunit/integration/includes/db/DatabaseSqli" [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [20:32:22] (03CR) 10Kosta Harlan: [C: 04-1] "Running `composer phpunit -- tests/phpunit/integration/includes/db/DatabaseSqliteTest.php` on master gives a different set of errors" [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [20:35:36] (03PS4) 10Zoranzoki21: Use renamed upstream extractParameters(), not extractParamaters() [extensions/GlobalContribs] - 10https://gerrit.wikimedia.org/r/533104 (https://phabricator.wikimedia.org/T201491) [20:36:01] (03CR) 10Esanders: [C: 03+2] "recheck" [extensions/Math] - 10https://gerrit.wikimedia.org/r/533573 (https://phabricator.wikimedia.org/T166936) (owner: 10Esanders) [20:36:16] (03CR) 10Anomie: Rework ApiUploadTest (032 comments) [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) (owner: 10Ppchelko) [20:36:41] 10Security-Team: Security access for Tchanders - https://phabricator.wikimedia.org/T231608 (10Niharika) @sbassett You can see them here: https://phabricator.wikimedia.org/search/query/Wq6yQbXrr0Nw/#R Is this a new process for #security access? Thalia is a long time WMF staff member, if that wasn't clear already. [20:37:00] (03CR) 10Nray: [C: 04-1] "I think the only blocker for me is the location of the dependencies in package.json. Other than that, I just had general questions that I'" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 (https://phabricator.wikimedia.org/T231489) (owner: 10Jdlrobson) [20:41:16] (03CR) 10Anomie: [C: 03+2] "Ok, let's do this. I'll probably submit some followups later on to add more functionality, in addition to the few I already submitted." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/523126 (https://phabricator.wikimedia.org/T226598) (owner: 10Tim Starling) [20:41:26] (03CR) 10Kosta Harlan: "> Notice: "" is not a valid magic word for "ns" [Called from Language::getMagic in /Users/kharlan/src/mediawiki/languages/Language.php at " [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [20:43:11] (03CR) 10jerkins-bot: [V: 04-1] Use renamed upstream extractParameters(), not extractParamaters() [extensions/GlobalContribs] - 10https://gerrit.wikimedia.org/r/533104 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [20:43:15] (03PS48) 10Jdlrobson: Document all our components in storybook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 (https://phabricator.wikimedia.org/T231489) [20:43:37] (03CR) 10Jdlrobson: Document all our components in storybook (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 (https://phabricator.wikimedia.org/T231489) (owner: 10Jdlrobson) [20:43:59] 10Security-Team: Security access for Tchanders - https://phabricator.wikimedia.org/T231608 (10sbassett) @Niharika - Yes. We've lately been trying to limit access even further to #security to those who absolutely need it (as opposed to just kind of want it.) Given @Tchanders's role on the AH team and the tasks... [20:47:03] (03CR) 10Jdlrobson: "> Looks like TOC is never shown in mobile format after this change. I suspect some other code somewhere is removing it, expecting the cust" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) (owner: 10Jdlrobson) [20:47:22] (03Abandoned) 10Nray: Fix iOS input text zoom bug on rcfilters input [core] - 10https://gerrit.wikimedia.org/r/533361 (https://phabricator.wikimedia.org/T231049) (owner: 10Nray) [20:47:29] (03PS6) 10Jdlrobson: Remove table of contents handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) [20:48:43] (03PS5) 10Zoranzoki21: Use renamed upstream extractParameters(), not extractParamaters() [extensions/GlobalContribs] - 10https://gerrit.wikimedia.org/r/533104 (https://phabricator.wikimedia.org/T201491) [20:50:10] 10MediaWiki-Recent-changes, 10Advanced Mobile Contributions, 10Growth-Team, 10OOUI, and 3 others: Recent changes "Save current filter settings" input zooms when focused on iOS - https://phabricator.wikimedia.org/T231049 (10nray) Moving this back to to needs analysis as the [[ https://gerrit.wikimedia.org/r... [20:50:19] (03PS2) 10Jdlrobson: Separate text element from mw-ui-icon-before [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533586 (https://phabricator.wikimedia.org/T229440) [20:50:21] (03PS6) 10Jdlrobson: Remove all the icon hacks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533111 (https://phabricator.wikimedia.org/T229447) [20:51:16] 10Security-Team: Security access for Tchanders - https://phabricator.wikimedia.org/T231608 (10Mooeypoo) @sbassett in that case, I just want to make sure we add to the list the fact that Anti Harassment's Tool team's work touches on blocking tools, which inherently tend to be Security tickets if any bug happens t... [20:51:52] (03PS13) 10Ppchelko: Rework ApiUploadTest [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) [20:51:57] (03CR) 10jerkins-bot: [V: 04-1] Use renamed upstream extractParameters(), not extractParamaters() [extensions/GlobalContribs] - 10https://gerrit.wikimedia.org/r/533104 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [20:52:01] (03CR) 10Ppchelko: Rework ApiUploadTest (032 comments) [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) (owner: 10Ppchelko) [20:53:32] (03CR) 10Nray: [C: 03+2] Document all our components in storybook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 (https://phabricator.wikimedia.org/T231489) (owner: 10Jdlrobson) [20:55:00] (03CR) 10jerkins-bot: [V: 04-1] WIP: Remove the mw-ui-icon hacks [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531558 (https://phabricator.wikimedia.org/T229447) (owner: 10Jdlrobson) [20:55:14] 10Security-Team: Security access for Tchanders - https://phabricator.wikimedia.org/T231608 (10Niharika) @sbassett I don't fully understand the reasons behind such extreme restrictions. Engineers working with WMF teams should have this access. If I (or other people with access) were not around to add @Tchanders a... [20:58:00] (03CR) 10jerkins-bot: [V: 04-1] Remove table of contents handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) (owner: 10Jdlrobson) [20:58:55] (03CR) 10Anomie: [C: 03+1] "Seems sane. Haven't tested. Ping me if no one else tests in a reasonable amount of time." [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) (owner: 10Ppchelko) [21:01:44] 10MediaWiki-extensions-OATHAuth, 10CPT Initiatives (Two-Factor Authentication (TEC1)), 10Core Platform Team Workboards (Contractor Workboard), 10Documentation, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03): Describe what different auth methods are - https://phabricator.wikimedia.org/T226056 (10CCicalese_WMF... [21:01:52] 10InteractionTimeline, 10Anti-Harassment (The Letter Song): Improve the location/discoverability of the revision link in the in-line diff container - https://phabricator.wikimedia.org/T194439 (10Niharika) @Prtksxna > I don't want to suggest a solution right now though. Can we revisit this once the initial des... [21:01:59] (03PS1) 10Kosta Harlan: Remove global usage in UserNotificationGateway [extensions/Echo] - 10https://gerrit.wikimedia.org/r/533602 [21:02:36] 10Security-Team: Security access for Tchanders - https://phabricator.wikimedia.org/T231608 (10sbassett) @Niharika - I think you've illustrated part of the point here: that individuals //can// be added to #security -protected tasks on a case-by-case basis, as opposed to the entire collection of previous and futur... [21:04:37] 10Space (Jul-Sep-2019): Commissioned Discuss Space features Sept-Dec 2019 - https://phabricator.wikimedia.org/T231606 (10elappen-WMF) [21:04:39] 10Space (Jul-Sep-2019): Editing the location field in the Events plugin deletes information previously input - https://phabricator.wikimedia.org/T231042 (10elappen-WMF) [21:05:01] (03PS3) 10Catrope: Assign flow-suppress to the suppress group and oversight grant [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533588 (owner: 10JJMC89) [21:06:10] (03CR) 10Krinkle: [C: 03+2] Fix PHP Notice: Undefined index: posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/532967 (https://phabricator.wikimedia.org/T207867) (owner: 10Kosta Harlan) [21:06:48] (03Merged) 10jenkins-bot: Fix for be824fad041b - remove unneeded i18n param [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/533591 (owner: 10Yaron Koren) [21:08:15] 10Code-Review-Workgroup: Define code review metrics - https://phabricator.wikimedia.org/T229510 (10Jdforrester-WMF) As I promised, here's my first cut proposal just to get the ball rolling: ### Proposed first cut of metrics | Metric | Purpose | Cuts | Example question | | --- | --- | --- | --- | | Submitters o... [21:08:58] 10Security-Team: Security access for Tchanders - https://phabricator.wikimedia.org/T231608 (10Niharika) @sbassett You're missing the point that it wastes valuable time in the face of a security bug to go around (where? IRC?), find someone who has access and ask them to add you. Not to mention that it feels kinda... [21:12:08] (03PS16) 10Jdlrobson: Remove the mw-ui-icon hacks [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531558 (https://phabricator.wikimedia.org/T229447) [21:12:10] (03PS4) 10Jdlrobson: [WIP] Customize mw-ui-icon to ensure consistent sizing and touch targets [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533360 (owner: 10Jdrewniak) [21:13:00] (03PS5) 10Krinkle: ContribsPage: Re-remove the getContribs() method [core] - 10https://gerrit.wikimedia.org/r/533325 (https://phabricator.wikimedia.org/T220447) (owner: 10DannyS712) [21:13:11] (03CR) 10Krinkle: [C: 03+2] Remove global usage in UserNotificationGateway [extensions/Echo] - 10https://gerrit.wikimedia.org/r/533602 (owner: 10Kosta Harlan) [21:14:08] 10Security-Team: Security access for Tchanders - https://phabricator.wikimedia.org/T231608 (10Mooeypoo) I will remind everyone that we're talking about a WMF employee here. I can understand high scrutiny in general, but I don't see a how adding an employee to the access group is not something -- honestly -- tha... [21:14:33] (03CR) 10jerkins-bot: [V: 04-1] Remove all the icon hacks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533111 (https://phabricator.wikimedia.org/T229447) (owner: 10Jdlrobson) [21:14:35] (03CR) 10Krinkle: "Two issues left in gated extensions that use UnitTest but break under its restriction:" [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [21:15:43] 10CPT Initiatives (OAuth 2.0), 10Core Platform Team Workboards (User Stories), 10Story: Admin whitelists client - https://phabricator.wikimedia.org/T229511 (10CCicalese_WMF) [21:15:45] 10Research, 10Research-management: Finalize October-December 2019 goals - https://phabricator.wikimedia.org/T231688 (10leila) p:05Triage→03High [21:15:49] 10CPT Initiatives (OAuth 2.0), 10Core Platform Team Workboards (User Stories), 10Story: User requests login to client when user is not already logged in to server (wiki) - https://phabricator.wikimedia.org/T229509 (10CCicalese_WMF) [21:15:54] 10CPT Initiatives (OAuth 2.0), 10Core Platform Team Workboards (User Stories), 10Story: User requests login to client when user is already logged in to server (wiki) - https://phabricator.wikimedia.org/T229508 (10CCicalese_WMF) [21:15:59] 10CPT Initiatives (OAuth 2.0), 10Core Platform Team Workboards (User Stories), 10Patch-For-Review, 10Story: Admin adds new client - https://phabricator.wikimedia.org/T229505 (10CCicalese_WMF) [21:16:03] 10CPT Initiatives (OAuth 2.0), 10Core Platform Team Workboards (User Stories), 10Patch-For-Review, 10Story: Admin removes client - https://phabricator.wikimedia.org/T229506 (10CCicalese_WMF) [21:16:04] (03CR) 10Krinkle: [C: 04-1] "That is actually a good point. Calling the constructor is optional for Skin. I added it in 1.31, and we don't require it (yet). That will " [core] - 10https://gerrit.wikimedia.org/r/509625 (owner: 10Fomafix) [21:16:13] 10Research, 10Research-management: Define October-December 2019 goals - https://phabricator.wikimedia.org/T231688 (10leila) [21:16:47] (03CR) 10jerkins-bot: [V: 04-1] Separate text element from mw-ui-icon-before [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533586 (https://phabricator.wikimedia.org/T229440) (owner: 10Jdlrobson) [21:17:11] (03CR) 10Krinkle: "possible fixme? I intentionally did not do this in 1.31 when I added the ctor in core." (031 comment) [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/509624 (owner: 10Fomafix) [21:17:46] (03PS20) 10Zoranzoki21: Add phpcs in Html2Wiki extension [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500144 (https://phabricator.wikimedia.org/T219671) [21:17:55] (03PS4) 10Zoranzoki21: Bring in htmlpurifier via composer not .gitmodules [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500138 (https://phabricator.wikimedia.org/T219670) [21:18:33] 10Core Platform Team Workboards (User Stories), 10Story: User Story 1 - https://phabricator.wikimedia.org/T229048 (10CCicalese_WMF) [21:18:34] (03PS21) 10Zoranzoki21: Add phpcs in Html2Wiki extension [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500144 (https://phabricator.wikimedia.org/T219671) [21:19:03] 10Structured Data Engineering, 10Structured-Data-Design, 10MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), 10Structured-Data-Backlog (Current Work): Update how "Remove all" works for statement panels - https://phabricator.wikimedia.org/T228912 (10Ramsey-WMF) a:05egardner→03Edtadros [21:19:07] 10Research, 10Research-management: Define October-December 2019 goals - https://phabricator.wikimedia.org/T231688 (10leila) [21:19:32] (03CR) 10Krinkle: [C: 03+2] Make mapName deterministic so it can be tested [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/500189 (owner: 10Esanders) [21:19:42] 10Structured Data Engineering, 10Structured-Data-Design, 10MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), 10Structured-Data-Backlog (Current Work): Update how "Remove all" works for statement panels - https://phabricator.wikimedia.org/T228912 (10Ramsey-WMF) [21:20:07] (03PS22) 10Zoranzoki21: Add phpcs in Html2Wiki extension [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500144 (https://phabricator.wikimedia.org/T219671) [21:20:19] (03Abandoned) 10Zoranzoki21: Fix warnings found by phpcs [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500147 (https://phabricator.wikimedia.org/T219671) (owner: 10Zoranzoki21) [21:20:59] (03CR) 10Krinkle: "I'm neutral. I consider RelEng to be owner of the library for long-term decisions on how much they want to support and where it fits. If Z" [core] - 10https://gerrit.wikimedia.org/r/528882 (owner: 10Pablo Grass (WMDE)) [21:22:11] (03CR) 10Krinkle: [C: 03+1] Pass the user and request into BlockManager::getUserBlock (031 comment) [core] - 10https://gerrit.wikimedia.org/r/531946 (https://phabricator.wikimedia.org/T230363) (owner: 10Tchanders) [21:22:15] (03CR) 10Krinkle: [C: 03+1] Pass the user and request into BlockManager::getUserBlock [core] - 10https://gerrit.wikimedia.org/r/531946 (https://phabricator.wikimedia.org/T230363) (owner: 10Tchanders) [21:23:02] 10Security-Team: Security access for Tchanders - https://phabricator.wikimedia.org/T231608 (10sbassett) >>! In T231608#5455246, @Niharika wrote: > (where? IRC?) Often times, yes, though there are other channels (email, mobile devices, etc.) where people can be found. And members of the #security-team (who all... [21:28:41] (03CR) 10Krinkle: Add event queue with flexible dispatch (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/524575 (https://phabricator.wikimedia.org/T225578) (owner: 10Milimetric) [21:28:49] (03CR) 10jerkins-bot: [V: 04-1] Assign flow-suppress to the suppress group and oversight grant [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533588 (owner: 10JJMC89) [21:30:50] 10Security-Team: Security access for Tchanders - https://phabricator.wikimedia.org/T231608 (10sbassett) >>! In T231608#5455253, @Mooeypoo wrote: > I will remind everyone that we're talking about a WMF employee here. > > I can understand high scrutiny in general, but I don't see a how adding an employee to the a... [21:31:47] (03PS23) 10Zoranzoki21: Add phpcs in Html2Wiki extension and fix errors found by it [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500144 (https://phabricator.wikimedia.org/T219671) [21:32:38] (03CR) 10Zoranzoki21: "kizule@kizule:~/development/Html2Wiki$ composer test" [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500144 (https://phabricator.wikimedia.org/T219671) (owner: 10Zoranzoki21) [21:33:56] (03PS17) 10Jdlrobson: Remove the mw-ui-icon hacks and overrides [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531558 (https://phabricator.wikimedia.org/T229447) [21:33:58] (03PS5) 10Jdlrobson: [WIP] Customize mw-ui-icon to ensure consistent sizing and touch targets [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533360 (owner: 10Jdrewniak) [21:34:19] (03CR) 10Jdlrobson: [C: 04-1] "Hey Jan - I rebased this patch on top of the hack removal patches I've been working on." [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533360 (owner: 10Jdrewniak) [21:34:58] (03CR) 10Jforrester: "Nice." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/533602 (owner: 10Kosta Harlan) [21:35:01] (03CR) 10Krinkle: New LanguageFallback service (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532232 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [21:35:51] 10Security-Team: Security access for Tchanders - https://phabricator.wikimedia.org/T231608 (10Mooeypoo) Fair enough. As an aside, I disagree with some of the process decisions here, but I don't know if this ticket is the best way to confront them, and I also don't expect you to be the one facing our consternati... [21:36:49] (03CR) 10Krinkle: "Simetrical and I have since continued at the older patch at https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/528794/ - or at least that" [core] - 10https://gerrit.wikimedia.org/r/533227 (owner: 10simetrical) [21:37:03] (03CR) 10jerkins-bot: [V: 04-1] Add phpcs in Html2Wiki extension and fix errors found by it [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500144 (https://phabricator.wikimedia.org/T219671) (owner: 10Zoranzoki21) [21:38:14] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (User Stories), 10Story: Can get bulk access from code that has been using the 'text' for getQueryInfo() - https://phabricator.wikimedia.org/T231689 (10CCicalese_WMF) [21:38:25] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (User Stories), 10Story: Can get bulk access from code that has been using the 'text' for getQueryInfo() - https://phabricator.wikimedia.org/T231689 (10CCicalese_WMF) p:05Triage→03Normal [21:38:47] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Yes, I tested with the dependency. I looked closer now and found that this is because of the default value of $wgMFRemovableClasses, which" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) (owner: 10Jdlrobson) [21:38:50] (03CR) 10jenkins-bot: Fix for be824fad041b - remove unneeded i18n param [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/533591 (owner: 10Yaron Koren) [21:39:19] (03PS24) 10Zoranzoki21: Add phpcs in Html2Wiki extension and fix errors found by it [extensions/Html2Wiki] - 10https://gerrit.wikimedia.org/r/500144 (https://phabricator.wikimedia.org/T219671) [21:40:14] (03CR) 10Krinkle: "check php" [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) (owner: 10Ppchelko) [21:40:23] (03CR) 10Krinkle: [C: 03+1] "Seems to take about 1.5-2s to run." [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) (owner: 10Ppchelko) [21:40:52] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (User Stories), 10Story: Can get bulk access from code that has been using the 'text' for getQueryInfo() - https://phabricator.wikimedia.org/T231689 (10CCicalese_WMF) [21:40:54] 10Multi-Content-Revisions, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03): Create batch access interface for BlobStore - https://phabricator.wikimedia.org/T230834 (10CCicalese_WMF) [21:40:58] 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Clinic Duty Team), 10Multi-Content-Revisions (Tech Debt), 10Patch-For-Review: Create batch access interface for page content - https://phabricator.wikimedia.org/T228988 (10CCicalese_WMF) [21:41:10] 10Multi-Content-Revisions, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03): Create batch access interface for BlobStore - https://phabricator.wikimedia.org/T230834 (10CCicalese_WMF) p:05Triage→03Normal [21:42:55] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (User Stories), 10Story: Can get bulk access from code that has been using the 'text' for getQueryInfo() - https://phabricator.wikimedia.org/T231689 (10CCicalese_WMF) [21:44:18] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (User Stories), 10Story: Can get bulk access from code that has been using the 'text' for getQueryInfo() - https://phabricator.wikimedia.org/T231689 (10CCicalese_WMF) [21:44:27] (03PS7) 10Jdlrobson: Remove all the icon hacks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533111 (https://phabricator.wikimedia.org/T229447) [21:46:38] (03CR) 10jerkins-bot: [V: 04-1] Remove the mw-ui-icon hacks and overrides [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531558 (https://phabricator.wikimedia.org/T229447) (owner: 10Jdlrobson) [21:48:35] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Customize mw-ui-icon to ensure consistent sizing and touch targets [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533360 (owner: 10Jdrewniak) [21:53:54] (03PS3) 10D3r1ck01: 💩 [api][specials]: Avoid usage of deprecated wfFindFile() function [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/532797 [21:55:08] (03PS2) 10D3r1ck01: jobqueue: Avoid usage of deprecated `MWHttpRequest::factory()` [core] - 10https://gerrit.wikimedia.org/r/532820 [21:56:12] (03PS2) 10D3r1ck01: user: Hard deprecate `User::addNewUserLogEntryAutoCreate()` method [core] - 10https://gerrit.wikimedia.org/r/532805 [21:56:53] (03CR) 10Krinkle: "(blocked on oojs-ui release. should be fine after next week I guess)" [core] - 10https://gerrit.wikimedia.org/r/533051 (owner: 10Jforrester) [21:57:02] (03PS18) 10Jdlrobson: Remove the mw-ui-icon hacks and overrides [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531558 (https://phabricator.wikimedia.org/T229447) [21:57:48] (03PS3) 10D3r1ck01: content: Remove unused constant NewsletterContent::NEWSLETTER_MANAGE [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/531300 [21:58:16] (03CR) 10Krinkle: [C: 03+2] filebackend: fix PhpStorm warnings in FileBackend [core] - 10https://gerrit.wikimedia.org/r/523981 (owner: 10Aaron Schulz) [21:58:29] (03PS2) 10D3r1ck01: GlobalFunctions: Hard deprecate the `wfDiff()`, usage only in core [core] - 10https://gerrit.wikimedia.org/r/533201 [22:00:14] (03PS18) 10D3r1ck01: Suppress page translations and render only the default page(s) [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/526234 (https://phabricator.wikimedia.org/T229265) [22:00:33] (03Merged) 10jenkins-bot: Re-render MWChemSymbols.css [extensions/Math] - 10https://gerrit.wikimedia.org/r/533573 (https://phabricator.wikimedia.org/T166936) (owner: 10Esanders) [22:01:18] (03CR) 10Krinkle: "After looking at LuaEngineTestBase (not in diff) and hte new base class, I could find any differences. Can you move it to a trait and use " [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/527854 (https://phabricator.wikimedia.org/T230701) (owner: 10Ladsgroup) [22:02:03] (03CR) 10Krinkle: "(meant to add, "for 10 minutes", meaning not every line, I can look further, but any differences can be kept locally I suppose outside the" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/527854 (https://phabricator.wikimedia.org/T230701) (owner: 10Ladsgroup) [22:02:37] 10Advanced Mobile Contributions, 10MinervaNeue, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Mobile, and 3 others: [EPIC] Refactor icon sizing in MF/Minerva to achieve consistency - https://phabricator.wikimedia.org/T229440 (10Jdlrobson) Suggested course of action: # Phase 1 - unbreaking changes 1) Pa... [22:04:02] (03CR) 10D3r1ck01: [C: 03+2] "Per Jforrester, kick Jenkins again." [core] - 10https://gerrit.wikimedia.org/r/533325 (https://phabricator.wikimedia.org/T220447) (owner: 10DannyS712) [22:05:07] (03PS7) 10Jdlrobson: Remove table of contents handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) [22:07:26] (03CR) 10Jdlrobson: "good catch. I was overriding that in LocalSettings.php. Fixed!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) (owner: 10Jdlrobson) [22:07:54] (03CR) 10Fomafix: SkinMetrolook: Call parent::__construct in constructor (031 comment) [skins/Metrolook] - 10https://gerrit.wikimedia.org/r/509624 (owner: 10Fomafix) [22:08:26] 10MediaWiki-General, 10MediaWiki-extensions-SubpageSortkey: Magic word to suppress breadcrumb links in subpages - https://phabricator.wikimedia.org/T231692 (10John_M_Wolfson) [22:10:01] 10MediaWiki-Recent-changes, 10Advanced Mobile Contributions, 10Growth-Team, 10OOUI, and 2 others: Recent changes "Save current filter settings" input zooms when focused on iOS - https://phabricator.wikimedia.org/T231049 (10Jdlrobson) The patch wasn't controversial. I think James was trying to say is that i... [22:10:34] (03CR) 10jerkins-bot: [V: 04-1] Remove the mw-ui-icon hacks and overrides [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531558 (https://phabricator.wikimedia.org/T229447) (owner: 10Jdlrobson) [22:12:27] (03Merged) 10jenkins-bot: makeSvgsAndCss.js: Add more logging and an '--all' flag [extensions/Math] - 10https://gerrit.wikimedia.org/r/533581 (owner: 10Esanders) [22:12:33] (03Merged) 10jenkins-bot: MessageFormatterFactory [core] - 10https://gerrit.wikimedia.org/r/523126 (https://phabricator.wikimedia.org/T226598) (owner: 10Tim Starling) [22:12:37] (03Merged) 10jenkins-bot: Document all our components in storybook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 (https://phabricator.wikimedia.org/T231489) (owner: 10Jdlrobson) [22:12:40] (03Merged) 10jenkins-bot: Fix PHP Notice: Undefined index: posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/532967 (https://phabricator.wikimedia.org/T207867) (owner: 10Kosta Harlan) [22:12:44] (03Merged) 10jenkins-bot: Remove global usage in UserNotificationGateway [extensions/Echo] - 10https://gerrit.wikimedia.org/r/533602 (owner: 10Kosta Harlan) [22:12:46] (03Merged) 10jenkins-bot: Make mapName deterministic so it can be tested [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/500189 (owner: 10Esanders) [22:13:28] (03CR) 10jerkins-bot: [V: 04-1] Remove all the icon hacks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533111 (https://phabricator.wikimedia.org/T229447) (owner: 10Jdlrobson) [22:13:30] (03CR) 10jenkins-bot: Re-render MWChemSymbols.css [extensions/Math] - 10https://gerrit.wikimedia.org/r/533573 (https://phabricator.wikimedia.org/T166936) (owner: 10Esanders) [22:16:20] (03CR) 10jerkins-bot: [V: 04-1] Remove table of contents handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) (owner: 10Jdlrobson) [22:18:40] (03CR) 10jenkins-bot: Document all our components in storybook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 (https://phabricator.wikimedia.org/T231489) (owner: 10Jdlrobson) [22:19:33] (03CR) 10jenkins-bot: makeSvgsAndCss.js: Add more logging and an '--all' flag [extensions/Math] - 10https://gerrit.wikimedia.org/r/533581 (owner: 10Esanders) [22:21:45] (03CR) 10jenkins-bot: Fix PHP Notice: Undefined index: posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/532967 (https://phabricator.wikimedia.org/T207867) (owner: 10Kosta Harlan) [22:23:56] (03CR) 10Aaron Schulz: Fix PhpStorm IDE warnings in ServiceWiring.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533135 (owner: 10Aaron Schulz) [22:24:41] (03PS4) 10JJMC89: Assign flow-suppress to the suppress group and oversight grant [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533588 [22:24:49] (03CR) 10Jforrester: [C: 03+2] user: Hard deprecate `User::addNewUserLogEntryAutoCreate()` method [core] - 10https://gerrit.wikimedia.org/r/532805 (owner: 10D3r1ck01) [22:24:53] (03PS2) 10Aaron Schulz: Fix PhpStorm IDE warnings in ServiceWiring.php [core] - 10https://gerrit.wikimedia.org/r/533135 [22:25:39] (03CR) 10jenkins-bot: Remove global usage in UserNotificationGateway [extensions/Echo] - 10https://gerrit.wikimedia.org/r/533602 (owner: 10Kosta Harlan) [22:27:15] (03Merged) 10jenkins-bot: filebackend: fix PhpStorm warnings in FileBackend [core] - 10https://gerrit.wikimedia.org/r/523981 (owner: 10Aaron Schulz) [22:29:24] (03CR) 10jenkins-bot: MessageFormatterFactory [core] - 10https://gerrit.wikimedia.org/r/523126 (https://phabricator.wikimedia.org/T226598) (owner: 10Tim Starling) [22:30:33] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (User Stories), 10Story: No direct or indirect access to pre-MCR fields is ungated - https://phabricator.wikimedia.org/T231693 (10CCicalese_WMF) [22:31:45] 10MobileFrontend, 10VisualEditor, 10Design (RW-Design-Debt), 10Readers-Web-Backlog (Tracking): AbuseFilter warnings and errors are handled badly by the editor - https://phabricator.wikimedia.org/T202460 (10Jdlrobson) This is very broken. Came across this again while documenting the mobile site's UI compone... [22:32:14] (03PS5) 10JJMC89: Assign flow-suppress to the suppress group and oversight grant [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533588 (https://phabricator.wikimedia.org/T231694) [22:32:16] 10Community-Tech (Kanban (Q1 2019-20)), 10E-Book-Export-Reliability: Move usage logs from Sqlite to MariaDB - https://phabricator.wikimedia.org/T226070 (10Niharika) @ifried Honestly I don't have any context with this tool either. It was Joe's project before he left the team. I'd defer to @Samwilson to know bes... [22:32:43] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (User Stories), 10Story: No direct or indirect access to pre-MCR fields is ungated - https://phabricator.wikimedia.org/T231693 (10CCicalese_WMF) [22:32:45] 10Structured Data Engineering, 10Structured-Data-Backlog, 10CPT Initiatives (MCR Schema Migration), 10Schema-change: stop using page_content_model - https://phabricator.wikimedia.org/T230607 (10CCicalese_WMF) [22:33:29] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (User Stories), 10Story: No direct or indirect access to pre-MCR fields is ungated - https://phabricator.wikimedia.org/T231693 (10CCicalese_WMF) [22:37:15] 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Clinic Duty Team), 10Multi-Content-Revisions (Tech Debt), 10Patch-For-Review: Create batch access interface for page content - https://phabricator.wikimedia.org/T228988 (10CCicalese_WMF) [22:37:19] 10Language-Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Clinic Duty Team), 10Multi-Content-Revisions (Tech Debt), 10Patch-For-Review: Remove direct access to the text table from the Translate extension. - https://phabricator.wikimedia.org/T228675 (10CCicalese_WMF) [22:37:23] 10ULS-CompactLinks, 10UniversalLanguageSelector: Innu language displays "Undefined" as tooltip in ULS - https://phabricator.wikimedia.org/T231695 (10Quiddity) [22:37:46] (03Merged) 10jenkins-bot: ContribsPage: Re-remove the getContribs() method [core] - 10https://gerrit.wikimedia.org/r/533325 (https://phabricator.wikimedia.org/T220447) (owner: 10DannyS712) [22:42:48] (03PS8) 10Jdlrobson: Remove table of contents handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) [22:42:53] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Epics), 10Epic: Stop writing to pre-MCR fields in WMF production - https://phabricator.wikimedia.org/T231672 (10CCicalese_WMF) [22:44:25] (03CR) 10jenkins-bot: filebackend: fix PhpStorm warnings in FileBackend [core] - 10https://gerrit.wikimedia.org/r/523981 (owner: 10Aaron Schulz) [22:46:11] 10UniversalLanguageSelector: Innu language displays "Undefined" as tooltip in ULS - https://phabricator.wikimedia.org/T231695 (10Quiddity) Thanks, Herald! [22:46:39] (03CR) 10jerkins-bot: [V: 04-1] Fix PhpStorm IDE warnings in ServiceWiring.php [core] - 10https://gerrit.wikimedia.org/r/533135 (owner: 10Aaron Schulz) [22:48:39] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Epics), 10Epic, 10MW-1.35-release: Remove the ability to write pre-MCR fields, limit the ability to read pre-MCR fields to migration scripts - https://phabricator.wikimedia.org/T231674 (10CCicalese_WMF) [22:50:42] (03Merged) 10jenkins-bot: user: Hard deprecate `User::addNewUserLogEntryAutoCreate()` method [core] - 10https://gerrit.wikimedia.org/r/532805 (owner: 10D3r1ck01) [22:51:32] 10CPT Initiatives (MCR), 10Multi-Content-Revisions (Tech Debt), 10Schema-change: Once MCR is deployed, drop the rev_text_id, rev_content_model, and rev_content_format fields from the revision table - https://phabricator.wikimedia.org/T184615 (10CCicalese_WMF) [22:51:34] 10Structured Data Engineering, 10Structured-Data-Backlog, 10CPT Initiatives (MCR Schema Migration), 10Multi-Content-Revisions (Deployment): Set the WMF cluster to use the new MCR-only schema - https://phabricator.wikimedia.org/T198312 (10CCicalese_WMF) [22:52:11] 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Add storybook to MobileFrontend to guard against potential UI regressions - https://phabricator.wikimedia.org/T231489 (10... [22:55:14] (03PS1) 10Eric Gardner: README updates [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533613 [22:56:50] (03CR) 10Eric Gardner: "Trying to preserve Michael's onboarding walk-through for posterity. Please fix/add as needed." [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533613 (owner: 10Eric Gardner) [22:58:22] (03CR) 10jenkins-bot: ContribsPage: Re-remove the getContribs() method [core] - 10https://gerrit.wikimedia.org/r/533325 (https://phabricator.wikimedia.org/T220447) (owner: 10DannyS712) [23:01:07] (03CR) 10Eric Gardner: README updates (031 comment) [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533613 (owner: 10Eric Gardner) [23:04:52] (03CR) 10jerkins-bot: [V: 04-1] Remove table of contents handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) (owner: 10Jdlrobson) [23:05:20] (03PS2) 10Eric Gardner: README updates [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533613 [23:09:05] 10Repository-Admins: Please create operations/debs/prometheus-swagger-exporter - https://phabricator.wikimedia.org/T231696 (10colewhite) [23:12:17] (03PS9) 10Jdlrobson: Remove table of contents handling [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) [23:16:18] (03PS14) 10Jdlrobson: Dev: Pull out SearchHeader from SearchOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529833 (https://phabricator.wikimedia.org/T220849) [23:18:36] (03CR) 10jenkins-bot: user: Hard deprecate `User::addNewUserLogEntryAutoCreate()` method [core] - 10https://gerrit.wikimedia.org/r/532805 (owner: 10D3r1ck01) [23:21:59] 10Phabricator: Simplify the multifactor auth reset procedure - https://phabricator.wikimedia.org/T231667 (10mmodell) [23:22:21] 10Phabricator: Phabricator: Simplify the multifactor auth reset procedure - https://phabricator.wikimedia.org/T231667 (10mmodell) [23:24:47] 10MediaWiki-History-and-Diffs, 10Community-Tech, 10Epic: Include section name in the diff - https://phabricator.wikimedia.org/T231698 (10MaxSem) [23:29:07] 10MediaWiki-Page-editing, 10Timeless, 10Browser-Support-Internet-Explorer, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03): Grey lines appearing while scrolling up the 2010 wikitext editor window with a scroll wheel under Timeless skin in IE11 - https://phabricator.wikimedia.org/T190991 (10gh87) 05Resolved→... [23:32:39] (03CR) 10Jdlrobson: [C: 04-1] "Need to fix unit tests to reflect new change." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533586 (https://phabricator.wikimedia.org/T229440) (owner: 10Jdlrobson) [23:33:20] (03Abandoned) 10Jdlrobson: WIP: Minerva Changelist styles for contributions [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/461795 (owner: 10Jdlrobson) [23:33:47] 10MediaWiki-Page-editing, 10Timeless, 10Browser-Support-Internet-Explorer, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03): Grey lines appearing while scrolling up the 2010 wikitext editor window with a scroll wheel under Timeless skin in IE11 - https://phabricator.wikimedia.org/T190991 (10Isarra) It won't act... [23:34:11] (03Abandoned) 10Jdlrobson: Create addTopicOverlay the non-deprecated way [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/493742 (https://phabricator.wikimedia.org/T217102) (owner: 10Jdlrobson) [23:34:43] (03Abandoned) 10Jdlrobson: WIP: Move Selenium test from mediawiki/core [skins/Vector] - 10https://gerrit.wikimedia.org/r/415614 (https://phabricator.wikimedia.org/T187859) (owner: 10Jdlrobson) [23:35:17] (03CR) 10Jdlrobson: "I think I worked out the build failure. Seems Depends-On was not pulling the Minerva patch so it was running without it, and thus causing " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533363 (https://phabricator.wikimedia.org/T182069) (owner: 10Jdlrobson) [23:37:02] (03CR) 10jerkins-bot: [V: 04-1] Dev: Pull out SearchHeader from SearchOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529833 (https://phabricator.wikimedia.org/T220849) (owner: 10Jdlrobson) [23:43:09] (03CR) 10Pwirth: [C: 03+2] Init commit [extensions/BlueSpiceSocialMicroBlog] - 10https://gerrit.wikimedia.org/r/533561 (owner: 10Pwirth) [23:43:39] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (Epics), 10Epic, 10MW-1.34-release: Make SCHEMA_COMPAT_NEW the default MCR migration schema - https://phabricator.wikimedia.org/T231673 (10CCicalese_WMF) [23:45:05] 10MediaWiki-Page-editing, 10Timeless, 10Browser-Support-Internet-Explorer, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03): Grey lines appearing while scrolling up the 2010 wikitext editor window with a scroll wheel under Timeless skin in IE11 - https://phabricator.wikimedia.org/T190991 (10Izno) >>! In T190991... [23:45:23] 10MediaWiki-Page-editing, 10Timeless, 10Browser-Support-Internet-Explorer, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03): Grey lines appearing while scrolling up the 2010 wikitext editor window with a scroll wheel under Timeless skin in IE11 - https://phabricator.wikimedia.org/T190991 (10Izno) 05Open→03Re... [23:48:03] 10Structured Data Engineering, 10Structured-Data-Backlog, 10CPT Initiatives (MCR Schema Migration), 10Multi-Content-Revisions (Deployment): Set the WMF cluster to use the new MCR-only schema - https://phabricator.wikimedia.org/T198312 (10CCicalese_WMF) [23:48:08] 10CPT Initiatives (MCR), 10Multi-Content-Revisions (Tech Debt), 10Schema-change: Once MCR is deployed, drop the rev_text_id, rev_content_model, and rev_content_format fields from the revision table - https://phabricator.wikimedia.org/T184615 (10CCicalese_WMF) [23:48:37] (03CR) 10Catrope: [C: 03+2] Assign flow-suppress to the suppress group and oversight grant [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533588 (https://phabricator.wikimedia.org/T231694) (owner: 10JJMC89) [23:49:37] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (User Stories), 10Story: No direct or indirect access to pre-MCR fields is ungated - https://phabricator.wikimedia.org/T231693 (10CCicalese_WMF) [23:49:57] (03Merged) 10jenkins-bot: Init commit [extensions/BlueSpiceSocialMicroBlog] - 10https://gerrit.wikimedia.org/r/533561 (owner: 10Pwirth) [23:50:13] 10ISA, 10Patch-For-Review: Non latin script in any campaign text breaks campaign page - https://phabricator.wikimedia.org/T231167 (10NavinoEvans) [23:52:12] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (User Stories), 10Story: No direct or indirect access to pre-MCR fields is ungated - https://phabricator.wikimedia.org/T231693 (10CCicalese_WMF) p:05Triage→03Normal [23:52:27] 10Structured Data Engineering, 10Structured-Data-Backlog, 10CPT Initiatives (MCR Schema Migration), 10Schema-change: stop using page_content_model - https://phabricator.wikimedia.org/T230607 (10CCicalese_WMF) p:05Triage→03Normal [23:57:09] (03PS1) 10Pwirth: Fix version [extensions/BlueSpiceSocialMicroBlog] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533617 [23:57:11] (03CR) 10Pwirth: [C: 03+2] Fix version [extensions/BlueSpiceSocialMicroBlog] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533617 (owner: 10Pwirth) [23:58:20] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (User Stories), 10Story: A warning is emitted if any pre-MCR fields are accessed - https://phabricator.wikimedia.org/T231699 (10CCicalese_WMF) [23:58:41] 10MediaWiki-extensions-Cargo: Specifying size for String is causing errors with recreating tables - https://phabricator.wikimedia.org/T231700 (10Elaeagnifolia) [23:58:47] 10GrowthExperiments, 10GrowthExperiments-Help panel, 10Growth-Team (Current Sprint): [minor] HelpPanel logs incorrect events for protected pages - https://phabricator.wikimedia.org/T218839 (10MMiller_WMF) Thank you all for hashing this out on the task. I just wanted to say that the business rules you all ha... [23:58:51] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (User Stories), 10Story: No direct or indirect access to pre-MCR fields is ungated - https://phabricator.wikimedia.org/T231693 (10CCicalese_WMF) [23:58:53] 10Core Platform Team, 10CPT Initiatives (MCR Schema Migration), 10Core Platform Team Workboards (User Stories), 10Story: A warning is emitted if any pre-MCR fields are accessed - https://phabricator.wikimedia.org/T231699 (10CCicalese_WMF) [23:59:22] 10MediaWiki-extensions-Cargo: Specifying size for String is causing errors with recreating Cargo tables - https://phabricator.wikimedia.org/T231700 (10Elaeagnifolia)