[00:00:52] (03CR) 10jenkins-bot: Rename Special:ViewData to Special:CargoQuery, improve interface Bug: T213513 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/532703 (https://phabricator.wikimedia.org/T213513) (owner: 10Ankita Mandal) [00:04:36] (03CR) 10Nray: "It looks like this also breaks a unit test related to SourceEditorOverlay?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531758 (https://phabricator.wikimedia.org/T231489) (owner: 10Jdlrobson) [00:04:38] (03CR) 10jenkins-bot: build: Updating handlebars to 4.1.2 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533115 (owner: 10Libraryupgrader) [00:04:58] (03PS1) 10HMonroy: Add ability to filter by date range in Special:NewPagesFeed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/533119 (https://phabricator.wikimedia.org/T167475) [00:06:55] (03CR) 10jerkins-bot: [V: 04-1] Add ability to filter by date range in Special:NewPagesFeed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/533119 (https://phabricator.wikimedia.org/T167475) (owner: 10HMonroy) [00:07:37] (03PS2) 10HMonroy: Add ability to filter by date range in Special:NewPagesFeed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/533119 (https://phabricator.wikimedia.org/T167475) [00:09:10] (03CR) 10Nray: "^^ To clarify, when I run `npm run test:unit` I get from one of the tests:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531758 (https://phabricator.wikimedia.org/T231489) (owner: 10Jdlrobson) [00:09:21] (03CR) 10jerkins-bot: [V: 04-1] Add ability to filter by date range in Special:NewPagesFeed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/533119 (https://phabricator.wikimedia.org/T167475) (owner: 10HMonroy) [00:10:53] (03CR) 10jerkins-bot: [V: 04-1] Add ability to filter by date range in Special:NewPagesFeed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/533119 (https://phabricator.wikimedia.org/T167475) (owner: 10HMonroy) [00:11:26] (03CR) 10Nray: "nevermind, that also happens on master :(" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531758 (https://phabricator.wikimedia.org/T231489) (owner: 10Jdlrobson) [00:11:26] 10MediaWiki-extensions-Translate, 10User-DannyS712, 10Wikimedia-production-error: DBQueryError when discouraging translation - https://phabricator.wikimedia.org/T231505 (10DannyS712) [00:13:29] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10GrowthExperiments-NewcomerTasks, 10Growth-Team (Current Sprint): Newcomer tasks: prototype task selection - https://phabricator.wikimedia.org/T231506 (10MMiller_WMF) [00:14:16] (03PS4) 10Mholloway: Allow filtering suggestions for review by uploader [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533096 (https://phabricator.wikimedia.org/T231104) [00:14:18] (03PS4) 10Mholloway: Update review UI to use new unreviewed image labels API module [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533099 (https://phabricator.wikimedia.org/T231104) [00:14:20] (03PS5) 10Mholloway: Hygiene: Remove SpecialImageLabeling [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533101 [00:14:33] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10GrowthExperiments-NewcomerTasks, 10Growth-Team (Current Sprint): Newcomer tasks: prototype task selection - https://phabricator.wikimedia.org/T231506 (10MMiller_WMF) I think it's likely that the engineer working on this task will need help to define some... [00:16:14] (03PS3) 10HMonroy: Add ability to filter by date range in Special:NewPagesFeed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/533119 (https://phabricator.wikimedia.org/T167475) [00:17:21] (03CR) 10jerkins-bot: [V: 04-1] Dev: Provide sensible fallbacks on mw.config values that don't exist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531758 (https://phabricator.wikimedia.org/T231489) (owner: 10Jdlrobson) [00:18:51] (03CR) 10jerkins-bot: [V: 04-1] Add ability to filter by date range in Special:NewPagesFeed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/533119 (https://phabricator.wikimedia.org/T167475) (owner: 10HMonroy) [00:19:09] (03CR) 10jerkins-bot: [V: 04-1] Add ability to filter by date range in Special:NewPagesFeed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/533119 (https://phabricator.wikimedia.org/T167475) (owner: 10HMonroy) [00:25:46] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Wikidata-Trailblazing-Exploration, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), and 2 others: Reconsider caching in Wikibase\SitesModule::getScript - https://phabricator.wikimedia.org/T229153 (10Krinkle) 05Open→03Resolved a:03Krinkle [00:25:57] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Wikidata-Trailblazing-Exploration, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), and 2 others: Reconsider caching in Wikibase\SitesModule::getScript - https://phabricator.wikimedia.org/T229153 (10Krinkle) a:05Krinkle→03Addshore [00:28:08] 10MediaWiki-General, 10serviceops, 10Core Platform Team (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), 10Performance-Team (Radar), 10Security: Create a tmp directory just for MediaWiki - https://phabricator.wikimedia.org/T179901 (10Krinkle) [00:29:12] 10MediaWiki-Interface, 10Vector, 10Readers-Web-Backlog (Tracking): jquery.ui.button: Color classes only implemented in jquery.ui vector theme - https://phabricator.wikimedia.org/T39744 (10Krinkle) See also T203696#5331623 and {T226976}. [00:30:53] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10PHP 7.2 support, 10Wikimedia-production-error: PHP error from Special:ExportTranslations: "get_class() expects parameter 1 to be objec... - https://phabricator.wikimedia.org/T227709 [00:31:06] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10GrowthExperiments-NewcomerTasks, 10Growth-Team (Current Sprint): Newcomer tasks: investigate ability to identify articles with no outbound links - https://phabricator.wikimedia.org/T231507 (10MMiller_WMF) [00:31:29] 10Better Use Of Data, 10Product-Analytics: QA Discussions for Modern Event Platform - https://phabricator.wikimedia.org/T231503 (10kzimmerman) p:05Triage→03Normal [00:31:49] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10GrowthExperiments-NewcomerTasks, 10Growth-Team (Current Sprint): Newcomer tasks: investigate ability to identify articles with no outbound links - https://phabricator.wikimedia.org/T231507 (10MMiller_WMF) I'm moving this to Ready for Development, because... [00:32:18] 10MediaWiki-Core-Testing, 10MediaWiki-ResourceLoader, 10Performance-Team: MediaWiki structure tests do not validate ResourceLoaderImageModule "images" file existence - https://phabricator.wikimedia.org/T231430 (10Krinkle) [00:36:56] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10GrowthExperiments-NewcomerTasks, 10Growth-Team (Current Sprint): Newcomer tasks: investigate ability to identify articles with empty sections - https://phabricator.wikimedia.org/T231509 (10MMiller_WMF) [00:37:09] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10GrowthExperiments-NewcomerTasks, 10Growth-Team (Current Sprint): Newcomer tasks: investigate ability to identify articles with no outbound links - https://phabricator.wikimedia.org/T231507 (10MMiller_WMF) [00:37:33] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10GrowthExperiments-NewcomerTasks, 10Growth-Team (Current Sprint): Newcomer tasks: investigate ability to identify articles with empty sections - https://phabricator.wikimedia.org/T231509 (10MMiller_WMF) a:05MMiller_WMF→03None I'm moving this to Ready... [00:40:39] 10MediaWiki-General, 10TechCom-RFC, 10PHP 7.0 support, 10PHP 7.1 support, and 2 others: Define criteria for setting setting explicit PHP support target for MediaWiki - https://phabricator.wikimedia.org/T228342 (10tstarling) I'm sympathetic to @legoktm's request that we avoid complicating CI and backports b... [00:41:08] (03CR) 10jerkins-bot: [V: 04-1] Allow filtering suggestions for review by uploader [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533096 (https://phabricator.wikimedia.org/T231104) (owner: 10Mholloway) [00:41:19] (03PS2) 10Isarra: Clean up and/or optimise icons a bit [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533088 [00:42:35] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Mobile: Homepage: update "posted on" timestamp client-side when overlay is opened - https://phabricator.wikimedia.org/T225941 (10MMiller_WMF) 05Open→03Resolved Thank you! [00:42:42] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Epic, 10Growth-Team (Current Sprint), and 2 others: Homepage: mobile version - https://phabricator.wikimedia.org/T215983 (10MMiller_WMF) [00:43:34] 10MediaWiki-Categories, 10MediaWiki-Page-derived-data, 10Core Platform Team Workboards (Clinic Duty Team), 10Wikimedia-database-error: Orphaned entries in categorylinks - https://phabricator.wikimedia.org/T224209 (10Krinkle) The list of categories associated with a page, I believe, comes from ParserOutput... [00:46:46] 10MediaWiki-Recent-changes, 10Advanced Mobile Contributions, 10Edit-Review-Improvements-RC-Page, 10Growth-Team, and 2 others: Click trash on recent changes doesn't clear open filter menus - https://phabricator.wikimedia.org/T231053 (10MMiller_WMF) @ovasileva -- where are you coming down on this one? Is it... [00:47:15] 10MediaWiki-extensions-WikibaseClient, 10UI-Standardization, 10Wikidata, 10Wikidata-Campsite, 10Performance-Team (Radar): Convert linkitem module to use OOUI, instead of jQuery UI - https://phabricator.wikimedia.org/T226976 (10Krinkle) [00:49:11] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Mobile: Homepage: mentor text style issues in mobile Mentorship module dialog - https://phabricator.wikimedia.org/T230373 (10MMiller_WMF) 05Open→03Resolved Thank you! [00:49:13] 10GrowthExperiments-Homepage, 10Desktop, 10Growth-Team (Current Sprint), 10Mobile: Homepage: layout and UI fixes - https://phabricator.wikimedia.org/T230014 (10MMiller_WMF) [00:49:19] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Epic, 10Growth-Team (Current Sprint), and 2 others: Homepage: mobile version - https://phabricator.wikimedia.org/T215983 (10MMiller_WMF) [00:49:51] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Mobile: Homepage: light text style tracking issue in mobile homepage module previews - https://phabricator.wikimedia.org/T230364 (10MMiller_WMF) 05Open→03Resolved Thank you! [00:49:53] 10GrowthExperiments-Homepage, 10Desktop, 10Growth-Team (Current Sprint), 10Mobile: Homepage: layout and UI fixes - https://phabricator.wikimedia.org/T230014 (10MMiller_WMF) [00:49:57] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Epic, 10Growth-Team (Current Sprint), and 2 others: Homepage: mobile version - https://phabricator.wikimedia.org/T215983 (10MMiller_WMF) [00:50:38] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Mobile: Homepage: user info text vertical stacking issues in mobile account creation module - https://phabricator.wikimedia.org/T230350 (10MMiller_WMF) 05Open→03Resolved Thank you! [00:50:40] 10GrowthExperiments-Homepage, 10Desktop, 10Growth-Team (Current Sprint), 10Mobile: Homepage: layout and UI fixes - https://phabricator.wikimedia.org/T230014 (10MMiller_WMF) [00:50:45] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Epic, 10Growth-Team (Current Sprint), and 2 others: Homepage: mobile version - https://phabricator.wikimedia.org/T215983 (10MMiller_WMF) [00:51:39] 10GrowthExperiments-Homepage, 10Desktop, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Mobile: Homepage: text size issue of pageviews number in Impact module - https://phabricator.wikimedia.org/T230377 (10MMiller_WMF) 05Open→03Resolved Thank you! [00:51:41] 10GrowthExperiments-Homepage, 10Desktop, 10Growth-Team (Current Sprint), 10Mobile: Homepage: layout and UI fixes - https://phabricator.wikimedia.org/T230014 (10MMiller_WMF) [00:51:45] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Epic, 10Growth-Team (Current Sprint), and 2 others: Homepage: mobile version - https://phabricator.wikimedia.org/T215983 (10MMiller_WMF) [00:52:07] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Mobile: Homepage: incorrect text style in mobile help module preview - https://phabricator.wikimedia.org/T230365 (10MMiller_WMF) 05Open→03Resolved Thank you! [00:52:09] 10GrowthExperiments-Homepage, 10Desktop, 10Growth-Team (Current Sprint), 10Mobile: Homepage: layout and UI fixes - https://phabricator.wikimedia.org/T230014 (10MMiller_WMF) [00:52:15] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Epic, 10Growth-Team (Current Sprint), and 2 others: Homepage: mobile version - https://phabricator.wikimedia.org/T215983 (10MMiller_WMF) [00:57:38] 10Who-Wrote-That: Remove HTML from i18n messages - https://phabricator.wikimedia.org/T231510 (10Samwilson) [00:59:05] (03CR) 10Mholloway: "recheck" [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533096 (https://phabricator.wikimedia.org/T231104) (owner: 10Mholloway) [01:04:54] 10MediaWiki-Special-pages, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), 10Wikimedia-production-error: Fatal error on Special:WhatLinksHere when typing a hash symbol - https://phabricator.wikimedia.org/T227817 (10Krinkle) >>! In T227817#5395983, @daniel wr... [01:25:40] 10MediaWiki-General, 10JavaScript, 10WorkType-NewFunctionality: Add helper function to get the current wikicode of a page - https://phabricator.wikimedia.org/T37084 (10Krinkle) `name=with jQuery (works today),lang=js await $.getJSON(mw.util.wikiScript('api'), { titles: 'User:Krinkle', format: 'json', formatv... [01:26:07] 10MediaWiki-API, 10Core Platform Team, 10JavaScript: Make it easier to query current page wikitext in JS - https://phabricator.wikimedia.org/T37084 (10Krinkle) [01:26:11] 10MediaWiki-API, 10Core Platform Team, 10JavaScript: Make it easier to query current page wikitext from JS - https://phabricator.wikimedia.org/T37084 (10Krinkle) [01:33:58] 10MediaWiki-Redirects, 10MediaWiki-Revision-backend, 10Core Platform Team Workboards (Clinic Duty Team), 10User-Marostegui, 10Wikimedia-production-error: Unable to create redirect on dewiki - fatal DBQueryError - https://phabricator.wikimedia.org/T220353 (10Krinkle) @WDoranWMF I'm not entirely sure. Righ... [01:37:39] 10MediaWiki-Debug-Logger, 10Operations, 10Wikimedia-Logstash, 10observability, and 9 others: Port mediawiki/php/wmerrors to PHP7 and deploy - https://phabricator.wikimedia.org/T187147 (10Krinkle) 05Open→03Resolved The last point of the task description is wmerrors taking care of showing the error page... [01:38:01] 10MediaWiki-Debug-Logger, 10Operations, 10Wikimedia-Logstash, 10observability, and 9 others: Port mediawiki/php/wmerrors to PHP7 and deploy - https://phabricator.wikimedia.org/T187147 (10Krinkle) [01:38:15] 10Core Platform Team, 10TemplateStyles, 10css-sanitizer, 10Patch-For-Review: Decide which non-standard CSS properties to support in TemplateStyles - https://phabricator.wikimedia.org/T162379 (10Krinkle) >>! In T162379#5413492, @Tgr wrote: > Sure, can you propose such a whitelist? * `zoom: 1` :-) [01:39:21] 10MediaWiki-Cache, 10MediaWiki-extensions-Translate, 10Performance-Team: array_keys() expects parameter 1 to be array, null given in cache/MessageCache.php on line 493 - https://phabricator.wikimedia.org/T230690 (10Krinkle) [01:43:36] 10MediaWiki-Logging, 10MediaWiki-Special-pages: Page protection log shows the main page of the Finnish-language Wikinews as nonexistent - https://phabricator.wikimedia.org/T215504 (10Krinkle) [01:44:46] 10MediaWiki-Logging, 10MediaWiki-Special-pages: Page protection log shows the main page of the Finnish-language Wikinews as nonexistent - https://phabricator.wikimedia.org/T215504 (10Krinkle) This does not appear to be an issue with the wikimedia/objectcache library, nor with usage of that interface. It looks... [01:46:23] 10MediaWiki-Internationalization, 10MW-1.34-release, 10PHP 7.0 support, 10PHP 7.1 support, and 3 others: LocalisationCache::readPHPFile may read outdated files on PHP 7 in stock MediaWiki (apc.cache_by_default no longer supported) - https://phabricator.wikimedia.org/T206986 (10Krinkle) [01:50:01] 10MediaWiki-Internationalization, 10Language-Team, 10Performance-Team (Radar): LocalisationCache loads key "preload" twice on all page views - https://phabricator.wikimedia.org/T229340 (10Krinkle) [01:50:16] 10MediaWiki-Internationalization, 10Wikimedia-Rdbms: TransationProfiler should not apply to using LCStoreDB - https://phabricator.wikimedia.org/T97693 (10Krinkle) [01:55:22] (03CR) 10Mooeypoo: [C: 03+2] Prevent badges from getting in the way of clicks [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/531592 (https://phabricator.wikimedia.org/T207452) (owner: 10Samwilson) [01:55:39] (03PS2) 10Krinkle: Remove $wgMemCachedDebug [core] - 10https://gerrit.wikimedia.org/r/533100 (owner: 10Aaron Schulz) [01:55:43] (03CR) 10Krinkle: [C: 03+2] Remove $wgMemCachedDebug [core] - 10https://gerrit.wikimedia.org/r/533100 (owner: 10Aaron Schulz) [01:58:16] (03PS1) 10Isarra: Add arrows for extension:proofreadpage pages [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533122 (https://phabricator.wikimedia.org/T231250) [01:59:58] (03CR) 10Krinkle: "@simetrical/@Daniel: Could you answer my concern about test speed from PS4? I agree with the ideas outlined at T225730#5442455, but meanw" [core] - 10https://gerrit.wikimedia.org/r/532334 (owner: 10simetrical) [02:06:28] (03Merged) 10jenkins-bot: Prevent badges from getting in the way of clicks [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/531592 (https://phabricator.wikimedia.org/T207452) (owner: 10Samwilson) [02:09:39] (03CR) 10jenkins-bot: Prevent badges from getting in the way of clicks [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/531592 (https://phabricator.wikimedia.org/T207452) (owner: 10Samwilson) [02:11:43] 10MediaWiki-Core-Testing, 10Release-Engineering-Team-TODO, 10Code-Health, 10Continuous-Integration-Config, and 5 others: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Krinkle) @Simetrical Agreed. The slow test detection isn't meant to invite micro-opt... [02:15:37] (03CR) 10jerkins-bot: [V: 04-1] Remove $wgMemCachedDebug [core] - 10https://gerrit.wikimedia.org/r/533100 (owner: 10Aaron Schulz) [02:17:19] (03PS3) 10Krinkle: resourceloader: Make ResourceLoaderSkinModuleTest a purer unit test [core] - 10https://gerrit.wikimedia.org/r/528807 [02:18:01] (03CR) 10Krinkle: [C: 03+2] HashRing optimizations and PhpStorm warning work-arounds [core] - 10https://gerrit.wikimedia.org/r/530707 (owner: 10Aaron Schulz) [02:26:34] (03PS1) 10Isarra: Fix languages/variants stuff some more [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533123 [02:27:14] (03CR) 10Krinkle: resourceloader: Compile documentElement.className server-side (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532247 (https://phabricator.wikimedia.org/T231168) (owner: 10Krinkle) [02:27:38] (03PS3) 10Krinkle: resourceloader: Compile documentElement.className server-side [core] - 10https://gerrit.wikimedia.org/r/532247 (https://phabricator.wikimedia.org/T231168) [02:27:57] (03CR) 10Krinkle: [C: 04-1] "Per Alaa." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/527854 (https://phabricator.wikimedia.org/T230701) (owner: 10Ladsgroup) [02:30:01] (03CR) 10Krinkle: [C: 04-1] "check php" [core] - 10https://gerrit.wikimedia.org/r/520328 (owner: 10Jforrester) [02:31:36] (03CR) 10Krinkle: "See https://phabricator.miraheze.org/T4617#88956" [extensions/SoftRedirector] (REL1_34) - 10https://gerrit.wikimedia.org/r/532274 (owner: 10Paladox) [02:34:46] (03CR) 10Krinkle: [C: 03+1] "JS and RL code LGTM. Haven't reviewed PHP code or tested the UI." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/528205 (https://phabricator.wikimedia.org/T195888) (owner: 10Urbanecm) [02:35:25] (03PS5) 10Aaron Schulz: externalstore: deprecate getLBInfo() dependency in ExternalStoreDB [core] - 10https://gerrit.wikimedia.org/r/532551 (https://phabricator.wikimedia.org/T231162) [02:39:21] (03CR) 10jerkins-bot: [V: 04-1] HashRing optimizations and PhpStorm warning work-arounds [core] - 10https://gerrit.wikimedia.org/r/530707 (owner: 10Aaron Schulz) [02:42:37] (03CR) 10Jack Phoenix: [C: 03+2] Cleanup js clicky stuff a bit more [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533094 (owner: 10Isarra) [02:42:39] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Make ResourceLoaderSkinModuleTest a purer unit test [core] - 10https://gerrit.wikimedia.org/r/528807 (owner: 10Krinkle) [02:43:08] (03CR) 10Jack Phoenix: [C: 03+2] Fix languages/variants stuff some more [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533123 (owner: 10Isarra) [02:47:51] (03PS1) 10Ejegg: Update yaml and smash-pig [vendor] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/533127 [02:47:57] (03CR) 10Ejegg: [C: 03+2] Update yaml and smash-pig [vendor] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/533127 (owner: 10Ejegg) [02:48:46] (03CR) 10jerkins-bot: [V: 04-1] Update yaml and smash-pig [vendor] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/533127 (owner: 10Ejegg) [02:50:02] 10Structured Data Engineering, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Patch-For-Review, 10SDC-Statements (Campaigns-jogging), 10Structured-Data-Backlog (Current Work): Explore simple, campaign-specific "sync" functionality for statements in UploadWizard - https://phabricator.wikimedia.org/T231225 (... [02:50:05] (03CR) 10Ejegg: [V: 03+2 C: 03+2] Update yaml and smash-pig [vendor] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/533127 (owner: 10Ejegg) [02:50:07] (03Merged) 10jenkins-bot: Cleanup js clicky stuff a bit more [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533094 (owner: 10Isarra) [02:50:11] (03Merged) 10jenkins-bot: Fix languages/variants stuff some more [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533123 (owner: 10Isarra) [02:50:12] (03CR) 10jerkins-bot: [V: 04-1] Update yaml and smash-pig [vendor] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/533127 (owner: 10Ejegg) [02:51:16] (03CR) 10Krinkle: Add JS hooks so that other scripts/gadgets can integrate with PageTriage (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/530977 (https://phabricator.wikimedia.org/T230455) (owner: 10MusikAnimal) [02:57:00] (03CR) 10Krinkle: BadFileLookup::isBadFile() expects null, not false (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532754 (https://phabricator.wikimedia.org/T231340) (owner: 10simetrical) [02:57:03] (03PS1) 10Ejegg: Update DonationInterface and vendor [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/533129 [02:57:58] (03CR) 10Krinkle: [C: 03+2] mw.Uri: Add another test for arrayParams [core] - 10https://gerrit.wikimedia.org/r/532993 (https://phabricator.wikimedia.org/T231382) (owner: 10Bartosz Dziewoński) [02:58:12] (03PS3) 10Krinkle: mediawiki.Uri: Add another test for arrayParams [core] - 10https://gerrit.wikimedia.org/r/532993 (https://phabricator.wikimedia.org/T231382) (owner: 10Bartosz Dziewoński) [02:58:16] (03CR) 10Krinkle: mediawiki.Uri: Add another test for arrayParams [core] - 10https://gerrit.wikimedia.org/r/532993 (https://phabricator.wikimedia.org/T231382) (owner: 10Bartosz Dziewoński) [02:58:19] (03CR) 10Krinkle: [C: 03+2] mediawiki.Uri: Add another test for arrayParams [core] - 10https://gerrit.wikimedia.org/r/532993 (https://phabricator.wikimedia.org/T231382) (owner: 10Bartosz Dziewoński) [02:58:44] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface and vendor [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/533129 (owner: 10Ejegg) [03:03:02] (03PS15) 10Krinkle: Move filter profiling to "db-replicated" and update via AbuseFilterProfileUpdateJob [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/522619 (https://phabricator.wikimedia.org/T227376) (owner: 10Aaron Schulz) [03:06:09] (03CR) 10Krinkle: [C: 03+1] "Haven't reviewed actual profiling/stat logic to be identical." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/522619 (https://phabricator.wikimedia.org/T227376) (owner: 10Aaron Schulz) [03:09:59] (03CR) 10Krinkle: [C: 03+1] Move parser tests to /unit (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 (owner: 10Daimona Eaytoy) [03:10:08] (03CR) 10Krinkle: [C: 03+2] Move parser tests to /unit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 (owner: 10Daimona Eaytoy) [03:11:12] (03CR) 10Krinkle: "wmf-quibble-core-vendor-mysql-php72-docker" [core] - 10https://gerrit.wikimedia.org/r/532835 (owner: 10Krinkle) [03:11:26] (03CR) 10Krinkle: "how many different random failures can we get?" [core] - 10https://gerrit.wikimedia.org/r/532835 (owner: 10Krinkle) [03:11:30] (03CR) 10Krinkle: "check php" [core] - 10https://gerrit.wikimedia.org/r/532835 (owner: 10Krinkle) [03:13:12] (03CR) 10Krinkle: [C: 03+2] Genereate signature for events [jsdoc/wmf-theme] - 10https://gerrit.wikimedia.org/r/530089 (https://phabricator.wikimedia.org/T214101) (owner: 10Prtksxna) [03:13:50] (03Merged) 10jenkins-bot: Genereate signature for events [jsdoc/wmf-theme] - 10https://gerrit.wikimedia.org/r/530089 (https://phabricator.wikimedia.org/T214101) (owner: 10Prtksxna) [03:17:57] (03CR) 10Krinkle: "See also T228695. Where did you run into this exactly? Did this resolve it? In my experience, the next thing that happens is that PHPunit/" [core] - 10https://gerrit.wikimedia.org/r/531744 (owner: 10Ppchelko) [03:19:46] (03Merged) 10jenkins-bot: mediawiki.Uri: Add another test for arrayParams [core] - 10https://gerrit.wikimedia.org/r/532993 (https://phabricator.wikimedia.org/T231382) (owner: 10Bartosz Dziewoński) [03:19:53] (03Merged) 10jenkins-bot: Update DonationInterface and vendor [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/533129 (owner: 10Ejegg) [03:29:37] (03CR) 10Ppchelko: "@Krinkle yes, this have fixed it. This is the job that has been failing because of it https://integration.wikimedia.org/ci/job/mediawiki-q" [core] - 10https://gerrit.wikimedia.org/r/531744 (owner: 10Ppchelko) [03:36:36] (03CR) 10jenkins-bot: mediawiki.Uri: Add another test for arrayParams [core] - 10https://gerrit.wikimedia.org/r/532993 (https://phabricator.wikimedia.org/T231382) (owner: 10Bartosz Dziewoński) [03:41:52] (03Merged) 10jenkins-bot: Move parser tests to /unit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 (owner: 10Daimona Eaytoy) [03:47:00] wikimedia/mediawiki#25311 (master - d7fbea7 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/578157783 [03:48:53] (03CR) 10jenkins-bot: Move parser tests to /unit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 (owner: 10Daimona Eaytoy) [03:52:08] (03CR) 10jenkins-bot: Update DonationInterface and vendor [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/533129 (owner: 10Ejegg) [03:53:54] (03CR) 10Tim Starling: "> Also, I wonder whether you'd like me to just make a followup patch myself for all the documentation changes I'd ask for." [core] - 10https://gerrit.wikimedia.org/r/523126 (https://phabricator.wikimedia.org/T226598) (owner: 10Tim Starling) [03:58:12] 10SRE-tools: Netbox: Add CSV dump rotation - https://phabricator.wikimedia.org/T231512 (10crusnov) [04:04:56] 10MediaWiki-General, 10Language-Team (Language-2019-July-September): Uncaught Wikimedia\Rdbms\DBUnexpectedError: Wikimedia\Rdbms\Database::close: mass commit/rollback of peer transaction required (DBO_TRX set) - https://phabricator.wikimedia.org/T231443 (10aaron) I wonder if some entry point lacks proper shutd... [04:07:54] 10SRE-tools: Spicerack: improve support for Ganeti VMs - https://phabricator.wikimedia.org/T231068 (10crusnov) Finding which cluster, or if the instance by fqdn is a Ganeti instance, could be done as easily as trrying to look it up in every configured cluster, and checking if there's information. We could provid... [04:41:22] (03PS16) 10Aaron Schulz: Move filter profiling to "db-replicated" and update via AbuseFilterProfileUpdateJob [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/522619 (https://phabricator.wikimedia.org/T227376) [04:41:38] 10ContentTranslation: Whole article as one section - https://phabricator.wikimedia.org/T230200 (10santhosh) a:03santhosh [04:41:56] (03PS1) 10Aaron Schulz: rdbms: expand on LoadBalancer ownership concept [core] - 10https://gerrit.wikimedia.org/r/533132 (https://phabricator.wikimedia.org/T231443) [04:44:27] (03PS10) 10Aaron Schulz: Convert DeferredUpdates and JobQueueGroup to services [core] - 10https://gerrit.wikimedia.org/r/520954 [04:46:39] (03PS2) 10Aaron Schulz: Make ObjectCache check the value of apc.enable_cli in CLI mode [core] - 10https://gerrit.wikimedia.org/r/533032 [04:47:57] (03CR) 10Aaron Schulz: "Maybe...if CI is just using the dummy apcu pecl interface that returns false for everything because of that INI value, then HashBagOStuff " [core] - 10https://gerrit.wikimedia.org/r/533032 (owner: 10Aaron Schulz) [04:50:23] (03PS1) 10Aaron Schulz: Fix PhpStorm IDE warnings in ServiceWiring.php [core] - 10https://gerrit.wikimedia.org/r/533135 [04:51:49] (03CR) 10jerkins-bot: [V: 04-1] rdbms: expand on LoadBalancer ownership concept [core] - 10https://gerrit.wikimedia.org/r/533132 (https://phabricator.wikimedia.org/T231443) (owner: 10Aaron Schulz) [04:52:56] (03CR) 10jerkins-bot: [V: 04-1] rdbms: expand on LoadBalancer ownership concept [core] - 10https://gerrit.wikimedia.org/r/533132 (https://phabricator.wikimedia.org/T231443) (owner: 10Aaron Schulz) [04:54:36] (03PS1) 10Aaron Schulz: Add HashBagOStuff fallback for APC in MWLBFactory::injectObjectCaches [core] - 10https://gerrit.wikimedia.org/r/533138 (https://phabricator.wikimedia.org/T227838) [04:55:18] (03PS2) 10Aaron Schulz: Add HashBagOStuff fallback for APC in MWLBFactory::injectObjectCaches [core] - 10https://gerrit.wikimedia.org/r/533138 (https://phabricator.wikimedia.org/T227838) [04:59:49] (03CR) 10Aaron Schulz: [C: 03+2] profiler: Centralise output responsibility from ProfilerOutputText to Profiler [core] - 10https://gerrit.wikimedia.org/r/532835 (owner: 10Krinkle) [05:03:28] (03CR) 10jerkins-bot: [V: 04-1] Convert DeferredUpdates and JobQueueGroup to services [core] - 10https://gerrit.wikimedia.org/r/520954 (owner: 10Aaron Schulz) [05:04:38] (03CR) 10jerkins-bot: [V: 04-1] rdbms: expand on LoadBalancer ownership concept [core] - 10https://gerrit.wikimedia.org/r/533132 (https://phabricator.wikimedia.org/T231443) (owner: 10Aaron Schulz) [05:06:34] (03CR) 10jerkins-bot: [V: 04-1] Make ObjectCache check the value of apc.enable_cli in CLI mode [core] - 10https://gerrit.wikimedia.org/r/533032 (owner: 10Aaron Schulz) [05:07:48] (03CR) 10jerkins-bot: [V: 04-1] Make ObjectCache check the value of apc.enable_cli in CLI mode [core] - 10https://gerrit.wikimedia.org/r/533032 (owner: 10Aaron Schulz) [05:10:05] 10MediaWiki-File-management, 10Commons, 10Operations, 10Traffic, and 2 others: Picture from Commons not found from Singapore - https://phabricator.wikimedia.org/T231086 (10aaron) >>! In T231086#5434295, @CDanis wrote: > I suggest: > * when ATS gets a 404 response from one cluster, retry on the other activ... [05:14:36] (03CR) 10jerkins-bot: [V: 04-1] Add HashBagOStuff fallback for APC in MWLBFactory::injectObjectCaches [core] - 10https://gerrit.wikimedia.org/r/533138 (https://phabricator.wikimedia.org/T227838) (owner: 10Aaron Schulz) [05:15:42] (03CR) 10jerkins-bot: [V: 04-1] Fix PhpStorm IDE warnings in ServiceWiring.php [core] - 10https://gerrit.wikimedia.org/r/533135 (owner: 10Aaron Schulz) [05:25:44] (03Merged) 10jenkins-bot: profiler: Centralise output responsibility from ProfilerOutputText to Profiler [core] - 10https://gerrit.wikimedia.org/r/532835 (owner: 10Krinkle) [05:30:41] (03PS1) 10Aaron Schulz: filebackend: make FileBackend consistencyCheck() and resyncFiles() more robust [core] - 10https://gerrit.wikimedia.org/r/533143 (https://phabricator.wikimedia.org/T231086) [05:33:08] (03PS1) 10Aaron Schulz: filebackend: fix @throws comment in FileBackend::makeContentDisposition() [core] - 10https://gerrit.wikimedia.org/r/533145 [05:39:15] (03CR) 10jerkins-bot: [V: 04-1] Convert DeferredUpdates and JobQueueGroup to services [core] - 10https://gerrit.wikimedia.org/r/520954 (owner: 10Aaron Schulz) [05:47:26] 10ContentTranslation, 10Language-Team (Language-2019-July-September), 10Patch-For-Review: Whole article as one section - https://phabricator.wikimedia.org/T230200 (10santhosh) p:05Triage→03High [05:47:54] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceSocialArticleActions] - 10https://gerrit.wikimedia.org/r/533042 (owner: 10Pwirth) [05:49:40] 10MediaWiki-General, 10Language-Team (Language-2019-July-September), 10Patch-For-Review: Uncaught Wikimedia\Rdbms\DBUnexpectedError: Wikimedia\Rdbms\Database::close: mass commit/rollback of peer transaction required (DBO_TRX set) - https://phabricator.wikimedia.org/T231443 (10aaron) Client disconnects (HTTP... [05:52:26] (03CR) 10jerkins-bot: [V: 04-1] Init commit [extensions/BlueSpiceSocialArticleActions] - 10https://gerrit.wikimedia.org/r/533042 (owner: 10Pwirth) [05:53:52] wikimedia/mediawiki#25312 (master - b4675c6 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/578182638 [05:56:24] (03CR) 10jenkins-bot: profiler: Centralise output responsibility from ProfilerOutputText to Profiler [core] - 10https://gerrit.wikimedia.org/r/532835 (owner: 10Krinkle) [05:59:31] (03PS2) 10Isarra: Add arrows for extension:proofreadpage pages and sort tabs appropriately [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533122 (https://phabricator.wikimedia.org/T231250) [05:59:41] (03CR) 10jerkins-bot: [V: 04-1] Add arrows for extension:proofreadpage pages and sort tabs appropriately [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533122 (https://phabricator.wikimedia.org/T231250) (owner: 10Isarra) [06:01:11] (03PS3) 10Aaron Schulz: filebackend: make FileBackendMultiWrite::doQuickOperationsInternal() more robust [core] - 10https://gerrit.wikimedia.org/r/532094 [06:02:49] (03PS3) 10Isarra: Clean up and/or optimise icons a bit [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533088 [06:02:51] (03PS3) 10Isarra: Add arrows for extension:proofreadpage pages and sort tabs appropriately [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533122 (https://phabricator.wikimedia.org/T231250) [06:04:51] (03CR) 10jerkins-bot: [V: 04-1] Add arrows for extension:proofreadpage pages and sort tabs appropriately [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533122 (https://phabricator.wikimedia.org/T231250) (owner: 10Isarra) [06:10:30] (03PS4) 10Isarra: Add arrows for extension:proofreadpage pages and sort tabs appropriately [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533122 (https://phabricator.wikimedia.org/T231250) [06:10:44] (03CR) 10ItSpiderman: "recheck" [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/533022 (owner: 10ItSpiderman) [06:13:20] (03CR) 10jerkins-bot: [V: 04-1] Remove PlainText TransferHandler [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/533022 (owner: 10ItSpiderman) [06:21:28] (03PS1) 10Tim Starling: Add documentation in the form of PHP stubs [php/excimer] - 10https://gerrit.wikimedia.org/r/533147 [06:25:07] (03CR) 10Aaron Schulz: filebackend: make FileBackendMultiWrite::doQuickOperationsInternal() more robust (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532094 (owner: 10Aaron Schulz) [06:25:56] (03PS1) 10Pwirth: Catch elastica "no connection" exception to make tests pass [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/533148 [06:26:56] (03PS2) 10Pwirth: Init commit [extensions/BlueSpiceSocialArticleActions] - 10https://gerrit.wikimedia.org/r/533042 [06:27:20] 10MediaWiki-General, 10TechCom-RFC, 10PHP 7.0 support, 10PHP 7.1 support, and 2 others: Define criteria for setting explicit PHP support target for MediaWiki - https://phabricator.wikimedia.org/T228342 (10Dinoguy1000) [06:29:41] (03CR) 10DCausse: [C: 03+2] Fix categories detele SPARQL clause [core] - 10https://gerrit.wikimedia.org/r/532824 (https://phabricator.wikimedia.org/T228348) (owner: 10Smalyshev) [06:31:57] (03CR) 10jerkins-bot: [V: 04-1] Init commit [extensions/BlueSpiceSocialArticleActions] - 10https://gerrit.wikimedia.org/r/533042 (owner: 10Pwirth) [06:37:32] 10MediaWiki-Core-Testing, 10Code-Health: Clarify confusing error "ConfigException: GlobalVarConfig::get: undefined option: ServiceWiringFiles" when using Title etc. in a unit test - https://phabricator.wikimedia.org/T231288 (10Nikerabbit) Hmm I see, so we have some tests that will use the title from parser if... [06:44:51] 10MediaWiki-Internationalization, 10Language-Team, 10Performance-Team, 10Core Platform Team (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), and 3 others: Use disk-based LCStore by default in MediaWiki 1.34 - https://phabricator.wikimedia.org/T218207 (10Nikerabbit) Command line... [06:52:09] (03Merged) 10jenkins-bot: Fix categories detele SPARQL clause [core] - 10https://gerrit.wikimedia.org/r/532824 (https://phabricator.wikimedia.org/T228348) (owner: 10Smalyshev) [06:56:58] (03CR) 10Samwilson: "Works in my testing, looks good." (033 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/533119 (https://phabricator.wikimedia.org/T167475) (owner: 10HMonroy) [06:58:05] 10ContentTranslation: Quote not recognized as a translatable unit - https://phabricator.wikimedia.org/T231083 (10Petar.petkovic) [07:05:53] (03PS1) 10Pwirth: Fix error, when no sorting is set in search store [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/533149 [07:09:02] (03PS1) 10Tim Starling: Warn if a timer or profiler is started with zero interval [php/excimer] - 10https://gerrit.wikimedia.org/r/533150 (https://phabricator.wikimedia.org/T207498) [07:09:19] (03CR) 10Zoranzoki21: "recheck" [core] - 10https://gerrit.wikimedia.org/r/533080 (https://phabricator.wikimedia.org/T231488) (owner: 10Daniel Kinzler) [07:09:26] (03CR) 10Zoranzoki21: "recheck" [core] - 10https://gerrit.wikimedia.org/r/531503 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [07:10:10] 10Discovery-Search: Alert when a jvm hits more than 100 old gc ops/hour - https://phabricator.wikimedia.org/T231516 (10dcausse) [07:10:50] 10Discovery-Search: Alert when a jvm hits more than 100 old gc ops/hour - https://phabricator.wikimedia.org/T231516 (10dcausse) p:05Triage→03High [07:11:04] (03PS2) 10Tim Starling: Add documentation in the form of PHP stubs [php/excimer] - 10https://gerrit.wikimedia.org/r/533147 (https://phabricator.wikimedia.org/T207499) [07:11:06] (03PS2) 10Tim Starling: Warn if a timer or profiler is started with zero interval [php/excimer] - 10https://gerrit.wikimedia.org/r/533150 (https://phabricator.wikimedia.org/T207498) [07:11:57] (03CR) 10Zoranzoki21: "..." [extensions/GlobalContribs] - 10https://gerrit.wikimedia.org/r/533104 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [07:12:01] (03CR) 10jerkins-bot: [V: 04-1] Replace usages of deprecated User::isAllowed. Step 2. [core] - 10https://gerrit.wikimedia.org/r/531503 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [07:14:41] 10Discovery-Search: Investigate and fix GC issues on cloudelastic machines - https://phabricator.wikimedia.org/T231517 (10dcausse) [07:14:59] 10Discovery-Search: Investigate and fix GC issues on cloudelastic machines - https://phabricator.wikimedia.org/T231517 (10dcausse) [07:15:30] (03CR) 10jenkins-bot: Fix categories detele SPARQL clause [core] - 10https://gerrit.wikimedia.org/r/532824 (https://phabricator.wikimedia.org/T228348) (owner: 10Smalyshev) [07:15:44] 10MediaWiki-extensions-UrlShortener: Add *.wmflabs.org to w.wiki shortener - https://phabricator.wikimedia.org/T231518 (10Husky) [07:15:49] 10Structured Data Engineering, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Patch-For-Review, 10SDC-Statements (Campaigns-jogging), 10Structured-Data-Backlog (Current Work): Explore simple, campaign-specific "sync" functionality for statements in UploadWizard - https://phabricator.wikimedia.org/T231225 (... [07:15:57] 10Discovery-Search: Investigate and fix GC issues on cloudelastic machines - https://phabricator.wikimedia.org/T231517 (10dcausse) p:05Triage→03High [07:16:14] 10MediaWiki-extensions-UrlShortener, 10Wikimedia-Site-requests, 10wikimediafoundation.org: Allow URL shortening for wikimediafoundation.org domain - https://phabricator.wikimedia.org/T222089 (10Husky) >>! In T222089#5225239, @Krenair wrote: > wmflabs.org should probably be a whole separate ticket. I've adde... [07:16:36] 10MediaWiki-extensions-UrlShortener: Add *.wmflabs.org to w.wiki shortener - https://phabricator.wikimedia.org/T231518 (10Husky) [07:18:47] wikimedia/mediawiki#25313 (master - eb4ac89 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/578210811 [07:24:07] 10MediaWiki-Watchlist, 10Growth-Team, 10Wikimedia-production-error: Watchlist reset fails "Lock wait timeout exceeded: WatchedItemStore::setNotificationTimestampsForUser" (from API setnotificationtimestamp) - https://phabricator.wikimedia.org/T208542 (10kostajh) I see [four instances of this in the last 60 d... [07:27:06] 10MediaWiki-Core-Testing, 10User-zeljkofilipin: Selenium failures on wmf-quibble-vendor-mysql-*-docker jobs for gate and submit - https://phabricator.wikimedia.org/T199644 (10hashar) a:03Pablo-WMDE And @Pablo-WMDE patch reenabled the RecentChange test https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/45980... [07:29:24] (03Abandoned) 10MaxSem: WIP: convert DeferredUpdates into a service [core] - 10https://gerrit.wikimedia.org/r/531993 (owner: 10MaxSem) [07:31:30] 10Structured Data Engineering, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03), 10Patch-For-Review, 10SDC-Statements (Campaigns-jogging), 10Structured-Data-Backlog (Current Work): Explore simple, campaign-specific "sync" functionality for statements in UploadWizard - https://phabricator.wikimedia.org/T231225 (... [07:33:22] 10MediaWiki-Core-Testing, 10Patch-For-Review: Audit using a library to bypass 'final' keyword in PHPUnit - https://phabricator.wikimedia.org/T231419 (10hashar) There is no actionable for #continuous-integration-config yet, though later on there might be one. @Simetrical who has started the discussion and I gu... [07:33:43] 10Structured Data Engineering, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10SDC-Statements (Other-statements-running), 10Structured-Data-Backlog (Current Work): Refactor UW statements code - https://phabricator.wikimedia.org/T225102 (10Ramsey-WMF) I have tried to reproduce the bug on Beta for a while now... [07:35:04] (03PS1) 10Kosta Harlan: Speculative to avoid setting subtitle when no title is found [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/533153 (https://phabricator.wikimedia.org/T61791) [07:35:11] 10MediaWiki-extensions-LiquidThreads, 10Growth-Team (Current Sprint), 10Patch-For-Review, 10Wikimedia-production-error: LQT: PHP Fatal error: Call to a member function setFragment() on a non-object in ThreadPermalinkView.php on line 168 - https://phabricator.wikimedia.org/T61791 (10kostajh) [07:38:38] (03PS2) 10Kosta Harlan: Fix PHP Notice: Undefined index: posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/532967 (https://phabricator.wikimedia.org/T207867) [07:38:41] (03CR) 10Kosta Harlan: Fix PHP Notice: Undefined index: posts (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/532967 (https://phabricator.wikimedia.org/T207867) (owner: 10Kosta Harlan) [07:39:34] (03CR) 10DCausse: "recheck" [search/glent] - 10https://gerrit.wikimedia.org/r/530971 (owner: 10EBernhardson) [07:41:20] 10MediaWiki-extensions-Translate, 10User-DannyS712, 10Wikimedia-production-error: DBQueryError when discouraging translation - https://phabricator.wikimedia.org/T231505 (10Nikerabbit) ` Query: REPLACE INTO `translate_groupreviews` (tgr_group,tgr_lang,tgr_state) VALUES ('page-Abuse filter editors','*priority'... [07:41:39] (03PS8) 10DannyS712: Create Special:AnnotateBlockLog to allow for updating block logs. [core] - 10https://gerrit.wikimedia.org/r/531984 (https://phabricator.wikimedia.org/T160233) [07:42:24] (03CR) 10DannyS712: [C: 04-1] "Still -1, haven't yet finished using BlockLogSpecialPage" [core] - 10https://gerrit.wikimedia.org/r/531984 (https://phabricator.wikimedia.org/T160233) (owner: 10DannyS712) [07:42:42] 10 WMDE-QWERTY-Sprint-2019-08-21 , 10Spike: Investigate relationship of book referencing project and parsers - https://phabricator.wikimedia.org/T230920 (10awight) Rethinking my concerns, any forward-incompatibilities due to the `refines` attribute would be entirely local to the Cite extension. We can write o... [07:42:47] 10MediaWiki-Watchlist, 10Growth-Team, 10Wikimedia-production-error: Updates for "wl_notificationtimestamp" after page views fail sometimes due to "Lock wait timeout exceeded" - https://phabricator.wikimedia.org/T204561 (10kostajh) Like T208542, I see [4 instances of this in the last 60 days](https://logstash... [07:43:47] 10MediaWiki-extensions-Translate, 10User-DannyS712, 10Wikimedia-production-error: DBQueryError when discouraging translation - https://phabricator.wikimedia.org/T231505 (10DannyS712) @Nikerabbit what is the IP address in your comment above? If that is mine, please redact it [07:45:39] 10 WMDE-QWERTY-Sprint-2019-08-21 , 10Patch-For-Review, 10Spike: Investigation: Where we would need to do changes in order to add and edit book references with the VisualEditor - https://phabricator.wikimedia.org/T231005 (10awight) @jkroll I think this task inherited its parent's story point estimate, acciden... [07:46:28] (03CR) 10Kosta Harlan: Ensure user is not null before passing to CentralAuth (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/532970 (https://phabricator.wikimedia.org/T231333) (owner: 10Kosta Harlan) [07:48:02] (03CR) 10Kosta Harlan: [C: 04-1] Remove @group Broken from ApiUploadTest (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533080 (https://phabricator.wikimedia.org/T231488) (owner: 10Daniel Kinzler) [07:48:55] 10ContentTranslation, 10Language-Team (Language-2019-July-September), 10Patch-For-Review: Whole article as one section - https://phabricator.wikimedia.org/T230200 (10Petar.petkovic) [[https://gerrit.wikimedia.org/r/533146|The patch]] is merged, but still not deployed. [07:49:40] 10MediaWiki-Core-Testing, 10User-zeljkofilipin: Selenium failures on wmf-quibble-vendor-mysql-*-docker jobs for gate and submit - https://phabricator.wikimedia.org/T199644 (10Pablo-WMDE) a:05Pablo-WMDE→03Daimona [07:51:35] (03PS1) 10Pwirth: Fix trying to write with DB_REPLICA in crawler [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/533156 [07:52:43] 04(no projects): The global word -frame- is very probably not global and stops the development of the Module:Centralizer - https://phabricator.wikimedia.org/T231521 (10Rical) [07:55:59] (03CR) 10jerkins-bot: [V: 04-1] Create Special:AnnotateBlockLog to allow for updating block logs. [core] - 10https://gerrit.wikimedia.org/r/531984 (https://phabricator.wikimedia.org/T160233) (owner: 10DannyS712) [07:56:14] (03PS9) 10DannyS712: Create Special:AnnotateBlockLog to allow for updating block logs. [core] - 10https://gerrit.wikimedia.org/r/531984 (https://phabricator.wikimedia.org/T160233) [07:56:38] 10ContentTranslation, 10WorkType-Maintenance: Delete failing ContentTranslation browsertests Jenkins jobs - https://phabricator.wikimedia.org/T113734 (10Petar.petkovic) [07:56:44] 10MediaWiki-extensions-Translate, 10User-DannyS712, 10Wikimedia-production-error: DBQueryError when discouraging translation - https://phabricator.wikimedia.org/T231505 (10Nikerabbit) It's the IP of the database server. [07:56:47] 10ContentTranslation: Fix easy problems reported by RuboCop in ContentTranslation - https://phabricator.wikimedia.org/T113742 (10Petar.petkovic) [07:57:03] 10ContentTranslation: The first Selenium test for ContentTranslation - https://phabricator.wikimedia.org/T216424 (10Petar.petkovic) [08:07:58] (03CR) 10jerkins-bot: [V: 04-1] Fix PHP Notice: Undefined index: posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/532967 (https://phabricator.wikimedia.org/T207867) (owner: 10Kosta Harlan) [08:17:30] 10MediaWiki-Cache, 10DBA, 10Performance-Team (Radar), 10User-Marostegui: Replace parsercache keys to something more meaningful on db-XXXX.php - https://phabricator.wikimedia.org/T210725 (10Marostegui) pc1010 is done with all the cleanups+optimizations ` ssh pc1010.eqiad.wmnet df -hT /srv Filesystem... [08:19:45] (03PS1) 10Aaron Schulz: filebackend: add idiom constant to FileBackend for null results [core] - 10https://gerrit.wikimedia.org/r/533162 [08:20:49] (03CR) 10jerkins-bot: [V: 04-1] Create Special:AnnotateBlockLog to allow for updating block logs. [core] - 10https://gerrit.wikimedia.org/r/531984 (https://phabricator.wikimedia.org/T160233) (owner: 10DannyS712) [08:25:20] (03PS10) 10DannyS712: Create Special:AnnotateBlockLog to allow for updating block logs. [core] - 10https://gerrit.wikimedia.org/r/531984 (https://phabricator.wikimedia.org/T160233) [08:28:15] 10Discovery-Search: Investigate and fix GC issues on cloudelastic machines - https://phabricator.wikimedia.org/T231517 (10dcausse) [08:29:47] 10Discovery-Search: Investigate and fix GC issues on cloudelastic machines - https://phabricator.wikimedia.org/T231517 (10dcausse) [08:30:27] 04(no projects): two user pages on meta can't be rendered - https://phabricator.wikimedia.org/T231522 (10ArielGlenn) [08:30:41] 10ContentTranslation, 10Language-Team (Language-2019-July-September): Whole article as one section - https://phabricator.wikimedia.org/T230200 (10Petar.petkovic) @Jpita The patch is deployed now, you can do QA. I have checked [[https://en.wikipedia.org/wiki/Millennials|en:Millenials]] to Serbian and [[https://... [08:30:53] no projects because I don't know what projects ought to go on there [08:31:08] going to see if I can get the raw wikitext out of those pages [08:31:37] 10MediaWiki-API, 10MediaWiki-ContentHandler, 10Core Platform Team, 10User-DannyS712: Add an API action to just change content model - https://phabricator.wikimedia.org/T107174 (10DannyS712) p:05Normal→03Low a:03DannyS712 [08:31:44] 10Discovery-Search: Alert when a jvm hits more than 100 old gc ops/hour - https://phabricator.wikimedia.org/T231516 (10Mathew.onipe) a:03Mathew.onipe [08:31:55] 10MediaWiki-extensions-BlockAndNuke: When partial unlock, it is not visible that this was only partial unblock - https://phabricator.wikimedia.org/T231523 (10Helgo13) [08:34:07] 04(no projects): two user pages on meta can't be rendered - https://phabricator.wikimedia.org/T231522 (10ArielGlenn) Wikitext for Gangleri: https://meta.wikimedia.org/w/index.php?title=User:Gangleri&action=edit Just look at all those babel entries. Same for the other user: https://meta.wikimedia.org/w/index.ph... [08:34:42] 10MediaWiki-API, 10Core Platform Team: action=userrights: give error when user is not allowed to change userrights - https://phabricator.wikimedia.org/T35732 (10DannyS712) [08:35:52] (03PS2) 10Daimona Eaytoy: [POC] [DNM] Use bypassFinals for PHPUnit [core] - 10https://gerrit.wikimedia.org/r/533067 (https://phabricator.wikimedia.org/T231419) [08:36:03] 10MediaWiki-API, 10Core Platform Team, 10User-DannyS712: Add module to get the list of all TrackingCategories - https://phabricator.wikimedia.org/T76290 (10DannyS712) a:03DannyS712 [08:38:13] 10MediaWiki-API, 10Core Platform Team, 10User-DannyS712: Api: Allow creation of new section without header but with summary - https://phabricator.wikimedia.org/T54747 (10DannyS712) a:03DannyS712 [08:38:51] 10MediaWiki-extensions-Babel, 10Operations: two user pages on meta can't be rendered - https://phabricator.wikimedia.org/T231522 (10ArielGlenn) [08:39:11] 10CX-boost, 10CX-out-of-beta, 10Language-Team (Language-2019-July-September): Enable Content Translation in Javanese Wikipedia as a default tool - https://phabricator.wikimedia.org/T231207 (10Pginer-WMF) a:03KartikMistry [08:39:38] 10MediaWiki-API, 10Core Platform Team, 10User-DannyS712: add namespace restrictions to meta=siteinfo - https://phabricator.wikimedia.org/T73952 (10DannyS712) a:03DannyS712 [08:45:15] 10Phabricator, 10Documentation: Document subtypes / task types in Phabricator - https://phabricator.wikimedia.org/T224417 (10Nemo_bis) >>! In T224417#5215068, @Quiddity wrote: > I made screenshots, but I don't know enough to write the words. > https://commons.wikimedia.org/wiki/File:Phabricator_task_subtypes.j... [08:45:30] 10CommRel-Specialists-Support (Apr-Jun-2019): Support Translation for CE Insights - https://phabricator.wikimedia.org/T211229 (10Elitre) 05Stalled→03Resolved [08:47:46] (03PS3) 10Daimona Eaytoy: [POC] [DNM] Use bypassFinals for PHPUnit [core] - 10https://gerrit.wikimedia.org/r/533067 (https://phabricator.wikimedia.org/T231419) [08:48:52] (03CR) 10jerkins-bot: [V: 04-1] Create Special:AnnotateBlockLog to allow for updating block logs. [core] - 10https://gerrit.wikimedia.org/r/531984 (https://phabricator.wikimedia.org/T160233) (owner: 10DannyS712) [08:48:57] 10WMEE: Juhatuse koosolek strateegia täpsustamiseks ja aastaplaani 2020 koostamiseks - https://phabricator.wikimedia.org/T231524 (10tramm) [08:49:11] 10CommRel-Specialists-Support: Participating in the International Year of Indigenous Languages - https://phabricator.wikimedia.org/T218140 (10Elitre) @elappen-WMF Is this something Space wants to own, now that a related group is starting there? [08:50:08] 10CommRel-Specialists-Support: Document how and where communities communicate with each other - https://phabricator.wikimedia.org/T217691 (10Elitre) 05Open→03Resolved a:03Elitre [08:50:10] 10CommRel-Specialists-Support (Jul-Sep-2019): [Epic] Talk pages consultation 2019 support - https://phabricator.wikimedia.org/T201375 (10Elitre) [08:50:38] 10CommRel-Specialists-Support (Jul-Sep-2019): Document how and where communities communicate with each other - https://phabricator.wikimedia.org/T217691 (10Elitre) [08:50:59] (03PS4) 10Daimona Eaytoy: [POC] [DNM] Use bypassFinals for PHPUnit [core] - 10https://gerrit.wikimedia.org/r/533067 (https://phabricator.wikimedia.org/T231419) [08:51:24] 10Readers-Community-Engagement, 10Readers-Web-Backlog, 10Hindi-Sites, 10Reading-Web-Local-Wiki-Issues: Hindi MainPage should use Template Styles (migrate all MediaWiki:Mobile.css and MediaWiki:MobileMainPage.css styles to templates) - https://phabricator.wikimedia.org/T195813 (10Elitre) [08:51:59] 10Readers-Community-Engagement, 10Readers-Web-Backlog, 10Hindi-Sites, 10Reading-Web-Local-Wiki-Issues: Hindi MainPage should use Template Styles (migrate all MediaWiki:Mobile.css and MediaWiki:MobileMainPage.css styles to templates) - https://phabricator.wikimedia.org/T195813 (10Elitre) Removing CommRel, f... [08:55:00] 10CommRel-Specialists-Support: CL support for adding wiki-specific CSS for styling citations output in Parsoid HTML - https://phabricator.wikimedia.org/T166895 (10Elitre) @ssastry Since it's been a year, I wonder if I should just close this and we can reopen when needed, or...? [08:58:46] 10Readers-Community-Engagement, 10Readers-Web-Backlog (Tracking), 10Reading-Web-Local-Wiki-Issues: Help community migrate away from legacy Main page special casing - https://phabricator.wikimedia.org/T138622 (10Elitre) [08:59:09] 10Readers-Community-Engagement, 10Readers-Web-Backlog (Tracking), 10Reading-Web-Local-Wiki-Issues: Help community migrate away from legacy Main page special casing - https://phabricator.wikimedia.org/T138622 (10Elitre) Removing our team tag, feel free to ping us again when needed. [09:02:55] 04(no projects): cp1085 - IPMI not working - puppet runs stuck - https://phabricator.wikimedia.org/T231525 (10Dzahn) [09:03:49] (03CR) 10jerkins-bot: [V: 04-1] Create Special:AnnotateBlockLog to allow for updating block logs. [core] - 10https://gerrit.wikimedia.org/r/531984 (https://phabricator.wikimedia.org/T160233) (owner: 10DannyS712) [09:05:35] 10Wikidata-Bridge: Add cancel/close button - https://phabricator.wikimedia.org/T231282 (10Pablo-WMDE) [09:05:48] (03PS5) 10Daimona Eaytoy: [POC] Use bypassFinals for PHPUnit [core] - 10https://gerrit.wikimedia.org/r/533067 (https://phabricator.wikimedia.org/T231419) [09:06:21] 04(no projects): The global word -frame- is very probably not global and stops the development of the Module:Centralizer - https://phabricator.wikimedia.org/T231521 (10Rical) Le 29/08/2019 à 05:55, noreply@lamutuellegenerale.f a qoi sert cete adresse ? T231521+public+acd61c88f02354b7@phabricator.wikimedia.org [09:07:21] (03CR) 10Tpt: "Thank you for the change. If you prefer we could add it to ProofreadPage instead." [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533122 (https://phabricator.wikimedia.org/T231250) (owner: 10Isarra) [09:08:23] 10Wikidata-Bridge: Only send changed contents via API - https://phabricator.wikimedia.org/T230343 (10Matthias_Geisler_WMDE) Please note: How we make the diffing has a intimidate impact on the rollback behavior. [09:08:27] (03PS11) 10DannyS712: Create Special:AnnotateBlockLog to allow for updating block logs. [core] - 10https://gerrit.wikimedia.org/r/531984 (https://phabricator.wikimedia.org/T160233) [09:08:42] 10CommRel-Specialists-Support: Participating in the International Year of Indigenous Languages - https://phabricator.wikimedia.org/T218140 (10Qgil) a:05mcruzWMF→03None First we need to know from @NSaad whether there is still a plan for this task. If there is still interest, then the main contact should be Ch... [09:13:05] (03PS1) 10AlexPinchuk: Use LastEdit renderer from extension(if exists) [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533170 [09:13:55] 10Trust-and-Safety, 10Security: Reset my 2FA on this Phab account - https://phabricator.wikimedia.org/T231526 (10Cyberpower678) [09:14:05] 10ISA: Update Proposed French Translations - https://phabricator.wikimedia.org/T231527 (10Eugene233) [09:14:30] (03PS2) 10AlexPinchuk: Use LastEdit renderer from extension(if exists) [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533170 [09:15:39] 10Core Platform Team, 10Excimer, 10Performance-Team (Radar): Excimer: Use class/method instead of filepath for attributing closures - https://phabricator.wikimedia.org/T231335 (10tstarling) Excimer should show both the filename and line number of the start of the closure declaration, not just the filename. T... [09:15:42] (03CR) 10Daimona Eaytoy: Move parser tests to /unit (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 (owner: 10Daimona Eaytoy) [09:16:08] 10Trust-and-Safety, 10Security: Reset my 2FA on this Phab account - https://phabricator.wikimedia.org/T231526 (10Cyberpower678) [09:16:23] 10CommRel-Specialists-Support (Jul-Sep-2019): Volunteer translator help for Community Insights Survey - https://phabricator.wikimedia.org/T228548 (10Elitre) Page for translations coordination is now https://meta.wikimedia.org/wiki/Community_Insights/Translation . @Trizek-WMF , @Whatamidoing-WMF , now that Trizek... [09:16:46] 10Trust-and-Safety, 10Security: Reset my 2FA on this Phab account - https://phabricator.wikimedia.org/T231526 (10Cyberpower678) p:05Triage→03High [09:17:15] (03PS2) 10ItSpiderman: [WIP] Entities and repositories [extensions/OAuth2] - 10https://gerrit.wikimedia.org/r/533016 [09:17:29] 10CommRel-Specialists-Support (Jul-Sep-2019): Help with massmessage! - https://phabricator.wikimedia.org/T230748 (10Elitre) 05Open→03Resolved Rebecca and I met twice, and I provided the guidance I could offer on MassMessage and Multilingual message. I wish Rebecca all the best with this year's Insights. Work... [09:17:31] 10CommRel-Specialists-Support (Jul-Sep-2019): Volunteer translator help for Community Insights Survey - https://phabricator.wikimedia.org/T228548 (10Elitre) [09:18:01] 10Wikimedia Northern Europe Meeting 2019: Conceptualize the plan for Nordic meeting - https://phabricator.wikimedia.org/T224148 (10InsaneHacker) @tramm requested that I add my notes to the ticket. They can also be found on meta: https://meta.wikimedia.org/wiki/Wikimedia_Northern_Europe/Workspace/Wikimania_2019_m... [09:19:30] 10ContentTranslation, 10CommRel-Specialists-Support (Jul-Sep-2019), 10Language-Team (Language-2019-July-September): Specialist support for communication with small wikis about translation - https://phabricator.wikimedia.org/T227013 (10Elitre) Both ml. and tl. have been contacted. I am not targeting active tr... [09:19:52] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Entities and repositories [extensions/OAuth2] - 10https://gerrit.wikimedia.org/r/533016 (owner: 10ItSpiderman) [09:23:59] (03PS2) 10Mobrovac: Improve edit/upload error message integration [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/531302 (owner: 10Bartosz Dziewoński) [09:25:10] (03PS1) 10Fomafix: Simplify JavaScript code [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533174 [09:30:45] (03CR) 10jerkins-bot: [V: 04-1] Simplify JavaScript code [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533174 (owner: 10Fomafix) [09:31:08] 10Reference Previews: Understand current referencing behavior as baseline for ReferencePreviews - https://phabricator.wikimedia.org/T231529 (10Lea_WMDE) [09:31:37] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Query-Service, 10Technical-Debt, 10good first bug: export original string of math-datatype values to Wikidata Query Server - https://phabricator.wikimedia.org/T226735 (10Lea_Lacroix_WMDE) @Lydia_Pintscher @WMDE-leszek Could we have a look... [09:32:05] 10MediaWiki-extensions-UrlShortener: Add *.wmflabs.org to w.wiki shortener - https://phabricator.wikimedia.org/T231518 (10Bugreporter) I oppose using w.wiki domain for shortening labs URLs. Labs does not follow WMF term of use and privacy policy, in particular you can load arbitrary 3rd party script (though this... [09:34:33] 10Reference Previews: Deploy ReferencePreviews as beta feature on no- and nnwiki - https://phabricator.wikimedia.org/T224674 (10Lea_WMDE) :) Thanks for your effort @jeblad! We are currently discussing the date for general beta deployment, and if that is soon enough, we would do the deploy to nn and no wiki as pa... [09:39:30] (03CR) 10jerkins-bot: [V: 04-1] Create Special:AnnotateBlockLog to allow for updating block logs. [core] - 10https://gerrit.wikimedia.org/r/531984 (https://phabricator.wikimedia.org/T160233) (owner: 10DannyS712) [09:42:26] (03CR) 10Mobrovac: [C: 03+2] Improve edit/upload error message integration [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/531302 (owner: 10Bartosz Dziewoński) [09:43:30] (03PS3) 10AlexPinchuk: Use LastEdit renderer from extension(if exists) [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533170 [09:44:03] 10CX-boost, 10CX-out-of-beta, 10Language-Team (Language-2019-July-September), 10Patch-For-Review: Enable Content Translation in Javanese Wikipedia as a default tool - https://phabricator.wikimedia.org/T231207 (10Pginer-WMF) [09:45:28] 10MediaWiki-Vagrant, 10MediaWiki-extensions-WikibaseClient, 10CirrusSearch, 10Discovery-Search, 10Wikidata: Vagrant first provision with wikibase and CirrusSearch causes 1146 Table 'wikidatawiki.wb_items_per_site' doesn't exist - https://phabricator.wikimedia.org/T231534 (10dcausse) [09:46:29] (03PS12) 10DannyS712: Create Special:AnnotateBlockLog to allow for updating block logs. [core] - 10https://gerrit.wikimedia.org/r/531984 (https://phabricator.wikimedia.org/T160233) [09:46:31] (03CR) 10simetrical: "recheck" [core] - 10https://gerrit.wikimedia.org/r/531698 (owner: 10simetrical) [09:48:39] (03CR) 10simetrical: "Isn't this the kind of thing phan is supposed to catch?" [core] - 10https://gerrit.wikimedia.org/r/533079 (https://phabricator.wikimedia.org/T231488) (owner: 10Daniel Kinzler) [09:49:11] (03CR) 10Daimona Eaytoy: "> Isn't this the kind of thing phan is supposed to catch?" [core] - 10https://gerrit.wikimedia.org/r/533079 (https://phabricator.wikimedia.org/T231488) (owner: 10Daniel Kinzler) [09:49:33] 10AbuseFilter: CachingParser::checkSyntax should only try to build the AST without evaluating it - https://phabricator.wikimedia.org/T231536 (10Daimona) [09:49:51] 10AbuseFilter: CachingParser::checkSyntax should only try to build the AST without evaluating it - https://phabricator.wikimedia.org/T231536 (10Daimona) [09:50:33] (03CR) 10simetrical: "You're right. I don't see any reason why this ever needed to be static." [core] - 10https://gerrit.wikimedia.org/r/532240 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [09:50:38] (03CR) 10Pwirth: "recheck" [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533170 (owner: 10AlexPinchuk) [09:52:56] 10MediaWiki-extensions-Scribunto: The global word -frame- is very probably not global and stops the development of the Module:Centralizer - https://phabricator.wikimedia.org/T231521 (10Reedy) [09:54:05] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/Empty] - 10https://gerrit.wikimedia.org/r/323210 (owner: 10Hashar) [09:55:03] (03CR) 10Hashar: "recheck" [skins/Empty] - 10https://gerrit.wikimedia.org/r/323210 (owner: 10Hashar) [09:55:05] (03CR) 10jerkins-bot: [V: 04-1] FileJournal tests [core] - 10https://gerrit.wikimedia.org/r/531698 (owner: 10simetrical) [09:55:42] (03PS2) 10Fomafix: Simplify JavaScript code [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533174 [09:55:44] 10AbuseFilter, 10Performance-Team (Radar): Rethink slow filters and profiling after enabling CachingParser - https://phabricator.wikimedia.org/T231112 (10Daimona) >>! In T231112#5447307, @Krinkle wrote: > I think it'd be great if we could make it very rare/unlikely to have a cache miss, and then apply the per-... [09:57:14] (03Abandoned) 10AlexPinchuk: Right revision choosing: For stable page - author of stable changes For unstable page - author of unstable changes [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/532998 (owner: 10AlexPinchuk) [09:57:19] (03CR) 10Pwirth: [C: 03+2] Use LastEdit renderer from extension(if exists) [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533170 (owner: 10AlexPinchuk) [09:57:30] (03PS1) 10Pwirth: Use LastEdit renderer from extension(if exists) [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/533176 [09:57:34] (03CR) 10Pwirth: [C: 03+2] Use LastEdit renderer from extension(if exists) [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/533176 (owner: 10Pwirth) [09:58:27] (03CR) 10Kosta Harlan: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/532967 (https://phabricator.wikimedia.org/T207867) (owner: 10Kosta Harlan) [09:58:30] (03CR) 10Mobrovac: [C: 04-1] Introduce BlobStore::getBlobBatch method (032 comments) [core] - 10https://gerrit.wikimedia.org/r/532449 (https://phabricator.wikimedia.org/T230834) (owner: 10Ppchelko) [10:01:22] (03PS1) 10Daimona Eaytoy: [WIP] Try unsuppressing phan issues [core] - 10https://gerrit.wikimedia.org/r/533177 [10:01:24] (03CR) 10jerkins-bot: [V: 04-1] Improve edit/upload error message integration [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/531302 (owner: 10Bartosz Dziewoński) [10:02:36] (03Merged) 10jenkins-bot: Use LastEdit renderer from extension(if exists) [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533170 (owner: 10AlexPinchuk) [10:08:41] (03Merged) 10jenkins-bot: Use LastEdit renderer from extension(if exists) [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/533176 (owner: 10Pwirth) [10:10:36] 10MediaWiki-Uploading, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Wikimedia-production-error: UploadFromChunks.php: Call to undefined method MediaWiki\FileBackend\FSFile\TempFSFileFactory::getTempFSFile() - https://phabricator.wikimedia.org/T231488 (10Daimona) >>! In T231488#5450411, @Simetrical wrote: >... [10:12:57] 10CX-analytics, 10Language-analytics, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16): Extend CX2 translations graph to show also published translations that need review - https://phabricator.wikimedia.org/T209868 (10Pginer-WMF) [10:13:15] 10CX-analytics, 10Language-analytics, 10Language-Team (Language-2019-July-September): Extend CX2 translations graph to show also deleted translations - https://phabricator.wikimedia.org/T210138 (10Pginer-WMF) [10:13:27] 10CX-analytics, 10CX-boost, 10Language-analytics: Measure template adaptation issues - https://phabricator.wikimedia.org/T231321 (10Pginer-WMF) [10:13:44] 10CX-analytics, 10CX-boost, 10Language-analytics: Visualize Content Translation funnel to better understand different translator paths - https://phabricator.wikimedia.org/T231316 (10Pginer-WMF) [10:14:00] 10CX-analytics, 10CX-boost, 10Language-analytics, 10Product-Analytics, 10Language-Team (Language-2019-July-September): Measure newcomer retention after their first translation for selected small wikis - https://phabricator.wikimedia.org/T226170 (10Pginer-WMF) [10:14:11] 10CX-analytics, 10CX-boost, 10Language-analytics, 10Product-Analytics, 10Language-Team (Language-2019-July-September): Measure the number of translations for selected small wikis - https://phabricator.wikimedia.org/T226169 (10Pginer-WMF) [10:15:23] (03CR) 10Hashar: "check zend" [skins/Empty] - 10https://gerrit.wikimedia.org/r/323210 (owner: 10Hashar) [10:15:30] (03CR) 10Hashar: "check php" [skins/Empty] - 10https://gerrit.wikimedia.org/r/323210 (owner: 10Hashar) [10:17:24] 10MediaWiki-API, 10MediaWiki-Special-pages, 10Contributors-Team, 10Core Platform Team, and 3 others: MovePage::move contention on cebwiki - https://phabricator.wikimedia.org/T221595 (10daniel) [10:17:26] 10MediaWiki-API, 10MediaWiki-Page-deletion, 10Core Platform Team, 10Core Platform Team Workboards (Clinic Duty Team), 10Wikimedia-production-error: Multiple page or file undelete/restore requests around the same time can deadlock (Fatal DBQueryError) - https://phabricator.wikimedia.org/T222402 (10daniel) [10:17:28] 10MediaWiki-API, 10Core Platform Team, 10Core Platform Team Workboards (Clinic Duty Team): action=userrights: give error when user is not allowed to change userrights - https://phabricator.wikimedia.org/T35732 (10daniel) [10:17:32] 10MediaWiki-API, 10Core Platform Team, 10Core Platform Team Workboards (Clinic Duty Team), 10Wikimedia-production-error: ApiQueryAllPages is slow on langlinks edgecase - https://phabricator.wikimedia.org/T97797 (10daniel) [10:17:35] 10MediaWiki-API, 10Core Platform Team, 10Scoring-platform-team, 10Core Platform Team Workboards (Clinic Duty Team), and 2 others: Certain prop=revisions API queries timeout with "internal_api_error_DBQueryError" - https://phabricator.wikimedia.org/T121333 (10daniel) [10:19:10] 10CX-analytics, 10CX-boost, 10Language-analytics, 10Product-Analytics, 10Language-Team (Language-2019-July-September): Measure the number of translations for selected small wikis - https://phabricator.wikimedia.org/T226169 (10Pginer-WMF) p:05Triage→03High [10:19:19] 10CX-analytics, 10CX-boost, 10Language-analytics, 10Product-Analytics, 10Language-Team (Language-2019-July-September): Measure newcomer retention after their first translation for selected small wikis - https://phabricator.wikimedia.org/T226170 (10Pginer-WMF) p:05Normal→03High [10:19:27] 10CX-analytics, 10CX-boost, 10Language-analytics: Visualize Content Translation funnel to better understand different translator paths - https://phabricator.wikimedia.org/T231316 (10Pginer-WMF) p:05Triage→03Normal [10:19:38] 10CX-analytics, 10CX-boost, 10Language-analytics: Measure template adaptation issues - https://phabricator.wikimedia.org/T231321 (10Pginer-WMF) p:05Triage→03Normal [10:21:24] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10GrowthExperiments-NewcomerTasks, 10Growth-Team (Current Sprint): Newcomer tasks: prototype task selection - https://phabricator.wikimedia.org/T231506 (10kostajh) a:03kostajh [10:21:31] (03CR) 10Daniel Kinzler: Introduce BlobStore::getBlobBatch method (032 comments) [core] - 10https://gerrit.wikimedia.org/r/532449 (https://phabricator.wikimedia.org/T230834) (owner: 10Ppchelko) [10:21:37] 10CX-analytics, 10Language-analytics: Measure success rates for different user groups - https://phabricator.wikimedia.org/T197224 (10Pginer-WMF) [10:21:41] 10CX-analytics, 10Language-analytics, 10WorkType-Maintenance: CXStats at Simple English Wikipedia shows data for English - https://phabricator.wikimedia.org/T103983 (10Pginer-WMF) [10:21:43] 10CX-analytics, 10Europeana-280, 10Language-analytics, 10WorkType-NewFunctionality: Provide statistics for a Translation Campaign based on the target articles and target languages - https://phabricator.wikimedia.org/T112897 (10Pginer-WMF) [10:21:45] 10CX-analytics, 10CX-boost, 10Language-analytics, 10Language-Team (Language-2019-July-September): Compile a list of prolific translators on the selected small wikis - https://phabricator.wikimedia.org/T229324 (10Pginer-WMF) [10:21:48] 10CX-analytics, 10Language-analytics: Monitor translations to identify relevant activity on specific wikis - https://phabricator.wikimedia.org/T228152 (10Pginer-WMF) [10:21:50] 10CX-analytics, 10Language-analytics, 10Language-Team (Language-2019-July-September): move AbuseFilter stats from mysql to hive - https://phabricator.wikimedia.org/T223958 (10Pginer-WMF) [10:21:52] 10CX-analytics, 10Language-analytics, 10Product-Analytics: Measure 2018-19 annual plan metrics for the Language team - https://phabricator.wikimedia.org/T199342 (10Pginer-WMF) [10:21:54] 10CX-analytics, 10Language-analytics, 10Product-Analytics, 10Epic: Consider how the EditAttemptStep schema can apply to ContentTranslation - https://phabricator.wikimedia.org/T214931 (10Pginer-WMF) [10:21:56] (03PS5) 10Jdrewniak: [icon] revise icons [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531713 (https://phabricator.wikimedia.org/T229440) (owner: 10Niedzielski) [10:21:58] 10CX-analytics, 10Language-analytics: Measure the number of issues that prevent publishing a translation for newcomers - https://phabricator.wikimedia.org/T194648 (10Pginer-WMF) [10:22:00] 10CX-analytics, 10Language-analytics, 10Product-Analytics: Measure newcomer retention after their first translation - https://phabricator.wikimedia.org/T195949 (10Pginer-WMF) [10:22:02] 10CX-analytics, 10Language-analytics: Slow query in getDeletionTrend - https://phabricator.wikimedia.org/T163803 (10Pginer-WMF) [10:22:04] 10CX-analytics, 10Language-analytics, 10Product-Analytics: Measure newcomers using Content Translation - https://phabricator.wikimedia.org/T194641 (10Pginer-WMF) [10:22:06] 10CX-analytics, 10Language-analytics, 10ULS-CompactLinks, 10UniversalLanguageSelector, 10Epic: [Epic] Migrate Language team statistics to Reportupdater - https://phabricator.wikimedia.org/T160303 (10Pginer-WMF) [10:22:08] 10CX-analytics, 10Language-analytics, 10Product-Analytics: Measure success and failure rates for newcomers using Content Translation - https://phabricator.wikimedia.org/T194647 (10Pginer-WMF) [10:22:10] 10CX-analytics, 10Language-analytics, 10WorkType-Maintenance: CXStats shows wrong data for Hebrew for the week of 2016-07-10 - https://phabricator.wikimedia.org/T140066 (10Pginer-WMF) [10:22:12] 10CX-analytics, 10Language-analytics, 10ULS-CompactLinks, 10UniversalLanguageSelector, 10WorkType-NewFunctionality: Automatic process for data collection and visualisation - https://phabricator.wikimedia.org/T137782 (10Pginer-WMF) [10:22:14] 10CX-analytics, 10Language-analytics, 10WorkType-Maintenance: Refresh CX suggestions statistics [July 2016] - https://phabricator.wikimedia.org/T135585 (10Pginer-WMF) [10:22:16] 10CX-analytics, 10Language-analytics, 10WorkType-NewFunctionality, 10patch-welcome: CXStats: Provide pan and zoom options - https://phabricator.wikimedia.org/T137700 (10Pginer-WMF) [10:22:18] 10CX-analytics, 10Language-analytics, 10WorkType-NewFunctionality: Collect usage data about Apertium use in Content Translation - https://phabricator.wikimedia.org/T132542 (10Pginer-WMF) [10:22:20] 10CX-analytics, 10Language-analytics, 10WorkType-NewFunctionality: There's no way to track whether articles were _created_ using CX campaign identifiers - https://phabricator.wikimedia.org/T133536 (10Pginer-WMF) [10:22:24] 10CX-analytics, 10Language-analytics, 10WorkType-Maintenance: CXStats page in guwiki shows Zero translation in week of 28/02 - https://phabricator.wikimedia.org/T131041 (10Pginer-WMF) [10:23:20] 10CX-analytics, 10Language-analytics, 10WorkType-Maintenance: Special:CXStats: clarify the meaning of the dates - https://phabricator.wikimedia.org/T94806 (10Pginer-WMF) [10:23:21] 10CX-analytics, 10Language-analytics, 10WorkType-NewFunctionality: Keep track on the percentage of success for pre-fetching - https://phabricator.wikimedia.org/T90215 (10Pginer-WMF) [10:23:23] 10CX-analytics, 10Language-analytics, 10WorkType-Maintenance: parse ContentTranslation saving/restoring/publishing error traces before logging - https://phabricator.wikimedia.org/T130106 (10Pginer-WMF) [10:23:25] 10Language-analytics, 10ULS-CompactLinks, 10UniversalLanguageSelector, 10WorkType-NewFunctionality: Follow up for interlanguage links dashboard - https://phabricator.wikimedia.org/T191409 (10Pginer-WMF) [10:23:28] 10Language-analytics, 10UniversalLanguageSelector, 10Technical-Debt: ULS: Evaluate which event logging events can be be removed - https://phabricator.wikimedia.org/T202850 (10Pginer-WMF) [10:23:30] 10Language-analytics, 10ULS-CompactLinks, 10UniversalLanguageSelector: Counting visits accoss tabs for compact links - https://phabricator.wikimedia.org/T141187 (10Pginer-WMF) [10:23:32] 10Language-analytics, 10UniversalLanguageSelector: ULS analytics schema update - https://phabricator.wikimedia.org/T90184 (10Pginer-WMF) [10:23:40] (03CR) 10jerkins-bot: [V: 04-1] Fix PHP Notice: Undefined index: posts [extensions/Flow] - 10https://gerrit.wikimedia.org/r/532967 (https://phabricator.wikimedia.org/T207867) (owner: 10Kosta Harlan) [10:25:41] 10MediaWiki-extensions-OATHAuth, 10CPT Initiatives (Two-Factor Authentication (TEC1)), 10Core Platform Team Workboards (Contractor Workboard), 10Patch-For-Review: SO878 Step 3: Finalize settings and user experience - https://phabricator.wikimedia.org/T218214 (10Reedy) One minor niggle, but I'm guesing it's... [10:27:52] (03CR) 10Reedy: [C: 04-1] "Minor niggle https://phabricator.wikimedia.org/T218214#5450525 and some little i18n tweaks. Will make the latter and merge" (031 comment) [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/527089 (https://phabricator.wikimedia.org/T218214) (owner: 10ItSpiderman) [10:33:22] (03PS1) 10AlexPinchuk: LastEdit Renderer refactoring [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533185 [10:33:55] (03PS3) 10Krinkle: Add documentation in the form of PHP stubs [php/excimer] - 10https://gerrit.wikimedia.org/r/533147 (https://phabricator.wikimedia.org/T207499) (owner: 10Tim Starling) [10:33:58] (03CR) 10Krinkle: [C: 03+1] Add documentation in the form of PHP stubs [php/excimer] - 10https://gerrit.wikimedia.org/r/533147 (https://phabricator.wikimedia.org/T207499) (owner: 10Tim Starling) [10:34:27] (03PS2) 10AlexPinchuk: LastEdit Renderer refactoring [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533185 [10:35:18] 10Wikimedia-Rdbms, 10Patch-For-Review: Wikimedia\\Rdbms\\Database::close: mass commit/rollback of peer transaction required (DBO_TRX set) - https://phabricator.wikimedia.org/T217819 (10Krinkle) [10:35:21] 10Wikimedia-Rdbms, 10Patch-For-Review: Wikimedia\\Rdbms\\Database::close: mass commit/rollback of peer transaction required (DBO_TRX set) - https://phabricator.wikimedia.org/T217819 (10Krinkle) [10:35:23] (03PS12) 10Reedy: UI upgrade [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/527089 (https://phabricator.wikimedia.org/T218214) (owner: 10ItSpiderman) [10:36:30] 10MediaWiki-Revision-backend, 10Performance-Team, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Patch-For-Review: DBQueryError from ExternalStoreDB::fetchBlob: Table 'enwiki.blobs' doesn't exist - https://phabricator.wikimedia.org/T231162 (10Krinkle) [10:36:48] (03CR) 10Pwirth: [C: 03+2] "recheck" [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533185 (owner: 10AlexPinchuk) [10:37:19] (03CR) 10Daniel Kinzler: [C: 03+1] "> Patch Set 3:" [core] - 10https://gerrit.wikimedia.org/r/531988 (owner: 10Ppchelko) [10:38:07] (03PS13) 10Reedy: UI upgrade [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/527089 (https://phabricator.wikimedia.org/T218214) (owner: 10ItSpiderman) [10:38:11] (03PS14) 10Reedy: UI upgrade [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/527089 (https://phabricator.wikimedia.org/T218214) (owner: 10ItSpiderman) [10:38:15] (03CR) 10Reedy: [C: 03+2] UI upgrade (031 comment) [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/527089 (https://phabricator.wikimedia.org/T218214) (owner: 10ItSpiderman) [10:38:37] (03CR) 10Krinkle: [C: 03+1] "LGTM - but Fatal error: Declaration of Wikibase\Lib\Tests\Store\Sql\Terms\Util\FakeLBFactory::newMainLB() must be compatible with that of " [core] - 10https://gerrit.wikimedia.org/r/533132 (https://phabricator.wikimedia.org/T231443) (owner: 10Aaron Schulz) [10:40:41] (03PS10) 10Daniel Kinzler: Add UnknownContentHandler. [core] - 10https://gerrit.wikimedia.org/r/531688 (https://phabricator.wikimedia.org/T220608) [10:40:45] (03CR) 10jerkins-bot: [V: 04-1] LastEdit Renderer refactoring [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533185 (owner: 10AlexPinchuk) [10:41:40] (03PS2) 10Krinkle: Speculative to avoid setting subtitle when no title is found [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/533153 (https://phabricator.wikimedia.org/T61791) (owner: 10Kosta Harlan) [10:41:49] (03PS3) 10AlexPinchuk: LastEdit Renderer refactoring [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533185 [10:42:04] (03CR) 10Krinkle: [C: 03+1] "Minor change to avoid php-bool casting magic for known-maybe-string values. +1 if it LGTY." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/533153 (https://phabricator.wikimedia.org/T61791) (owner: 10Kosta Harlan) [10:43:15] (03PS11) 10Mobrovac: Add UnknownContentHandler. [core] - 10https://gerrit.wikimedia.org/r/531688 (https://phabricator.wikimedia.org/T220608) (owner: 10Daniel Kinzler) [10:43:18] (03CR) 10Daniel Kinzler: rdbms: Defer instantiating the DBLoadBalancerFactory service (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532367 (https://phabricator.wikimedia.org/T228895) (owner: 10TK-999) [10:44:02] 10MediaWiki-extensions-WikibaseRepository, 10Math, 10Wikidata, 10Wikidata-Query-Service, 10patch-welcome: Export original TeX string of math-datatype values in RDF/on Wikidata Query Server - https://phabricator.wikimedia.org/T195765 (10Lucas_Werkmeister_WMDE) [10:44:04] (03CR) 10Pwirth: "recheck" [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533185 (owner: 10AlexPinchuk) [10:45:10] (03Merged) 10jenkins-bot: UI upgrade [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/527089 (https://phabricator.wikimedia.org/T218214) (owner: 10ItSpiderman) [10:45:23] 10MediaWiki-ServiceContainer, 10TechCom, 10CPT Initiatives (Decoupling (CDP2)): Provide access to WebRequest and associated information via a service object - https://phabricator.wikimedia.org/T218555 (10daniel) I just remembered another use case for which we'd want implicit knowledge of the request: Logging... [10:45:57] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Try unsuppressing phan issues [core] - 10https://gerrit.wikimedia.org/r/533177 (owner: 10Daimona Eaytoy) [10:46:19] (03CR) 10Krinkle: rdbms: Defer instantiating the DBLoadBalancerFactory service (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532367 (https://phabricator.wikimedia.org/T228895) (owner: 10TK-999) [10:47:16] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Try unsuppressing phan issues [core] - 10https://gerrit.wikimedia.org/r/533177 (owner: 10Daimona Eaytoy) [10:47:30] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Query-Service, 10Technical-Debt, 10good first bug: export original string of math-datatype values to Wikidata Query Server - https://phabricator.wikimedia.org/T226735 (10Lucas_Werkmeister_WMDE) Can we please look at T195765 instead, which... [10:48:44] (03CR) 10Kosta Harlan: "> Patch Set 2: Code-Review+1" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/533153 (https://phabricator.wikimedia.org/T61791) (owner: 10Kosta Harlan) [10:51:13] (03CR) 10Pwirth: [C: 03+2] LastEdit Renderer refactoring [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533185 (owner: 10AlexPinchuk) [10:51:18] (03PS1) 10Pwirth: LastEdit Renderer refactoring [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/533188 [10:51:21] (03CR) 10Pwirth: [C: 03+2] LastEdit Renderer refactoring [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/533188 (owner: 10Pwirth) [10:52:27] (03CR) 10Daniel Kinzler: [C: 03+2] Move User::getAllRights to PermissionManager. [core] - 10https://gerrit.wikimedia.org/r/532486 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [10:52:56] (03CR) 10Daniel Kinzler: [C: 03+2] createNoOpMock() method for PHPUnit tests [core] - 10https://gerrit.wikimedia.org/r/532982 (owner: 10simetrical) [10:53:04] (03CR) 10jerkins-bot: [V: 04-1] [icon] revise icons [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531713 (https://phabricator.wikimedia.org/T229440) (owner: 10Niedzielski) [10:53:45] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/441526 (owner: 10Hashar) [10:54:01] (03CR) 10Krinkle: filebackend: make FileBackend consistencyCheck() and resyncFiles() more robust (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533143 (https://phabricator.wikimedia.org/T231086) (owner: 10Aaron Schulz) [10:54:32] (03CR) 10Krinkle: [C: 03+2] Speculative to avoid setting subtitle when no title is found [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/533153 (https://phabricator.wikimedia.org/T61791) (owner: 10Kosta Harlan) [10:54:48] (03CR) 10Daniel Kinzler: [C: 03+2] Integration tests for Language fallback methods [core] - 10https://gerrit.wikimedia.org/r/532231 (owner: 10simetrical) [10:55:08] (03CR) 10Daniel Kinzler: [C: 03+1] Split some Language methods to LanguageNameUtils [core] - 10https://gerrit.wikimedia.org/r/532680 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [10:55:15] (03CR) 10Daniel Kinzler: [C: 03+1] Make LocalisationCache a service [core] - 10https://gerrit.wikimedia.org/r/532679 (https://phabricator.wikimedia.org/T231220) (owner: 10simetrical) [10:55:31] (03CR) 10Krinkle: "1) FileBackendGroupIntegrationTest::testConfig" [core] - 10https://gerrit.wikimedia.org/r/533032 (owner: 10Aaron Schulz) [10:57:08] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Try unsuppressing phan issues [core] - 10https://gerrit.wikimedia.org/r/533177 (owner: 10Daimona Eaytoy) [10:59:04] (03PS11) 10Daniel Kinzler: Replace usages of deprecated User::isAllowed. Step 2. [core] - 10https://gerrit.wikimedia.org/r/531503 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [10:59:23] (03CR) 10Daniel Kinzler: "PS11 is a manual rebase." [core] - 10https://gerrit.wikimedia.org/r/531503 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [11:00:55] (03CR) 10Hashar: "recheck" [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/441526 (owner: 10Hashar) [11:00:56] (03CR) 10Hashar: "check php" [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/441526 (owner: 10Hashar) [11:00:58] (03CR) 10Hashar: "check php" [skins/Empty] - 10https://gerrit.wikimedia.org/r/323210 (owner: 10Hashar) [11:01:02] (03CR) 10Daniel Kinzler: [C: 03+1] "Looks right, but holding off on the +2 until more of The Big Chain has gone in." [core] - 10https://gerrit.wikimedia.org/r/532241 (owner: 10simetrical) [11:03:09] (03CR) 10Daniel Kinzler: "> Patch Set 13:" [core] - 10https://gerrit.wikimedia.org/r/532240 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [11:03:22] (03CR) 10Daniel Kinzler: [C: 04-1] Inject grammar transform cache in Language [core] - 10https://gerrit.wikimedia.org/r/532240 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [11:04:23] 10MediaWiki-Logging, 10MediaWiki-User-management, 10Community-Wishlist-Survey-2016, 10Core Platform Team Workboards (Clinic Duty Team), and 2 others: Enable administrators to update block logs - https://phabricator.wikimedia.org/T160233 (10DannyS712) Moving back to code review; overhauled per comments by @... [11:05:26] (03CR) 10Reedy: "Sorry for comments on i18n on old revision, but started not noticing (no changes to latest PS)... Will do rest on latest PS" (0313 comments) [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/508788 (https://phabricator.wikimedia.org/T218211) (owner: 10ItSpiderman) [11:05:52] (03CR) 10Reedy: [C: 04-1] "As per comments on older PS, which weren't addressed PS14-PS15" [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/508788 (https://phabricator.wikimedia.org/T218211) (owner: 10ItSpiderman) [11:09:35] (03PS1) 10Daniel Kinzler: Avoid fatal errors when reporting exceptions. [core] - 10https://gerrit.wikimedia.org/r/533190 [11:11:24] (03CR) 10Reedy: [C: 03+2] Avoid fatal errors when reporting exceptions. [core] - 10https://gerrit.wikimedia.org/r/533190 (owner: 10Daniel Kinzler) [11:15:02] (03PS1) 10simetrical: Fix FileBackendGroup test for some configurations [core] - 10https://gerrit.wikimedia.org/r/533191 [11:15:26] (03CR) 10Mobrovac: [C: 03+2] Add UnknownContentHandler. [core] - 10https://gerrit.wikimedia.org/r/531688 (https://phabricator.wikimedia.org/T220608) (owner: 10Daniel Kinzler) [11:16:15] 10MediaWiki-Special-pages, 10Core Platform Team, 10User-DannyS712: Unable to view contributions: Call to undefined method ContribsPager::getContribs() - https://phabricator.wikimedia.org/T231540 (10DannyS712) [11:19:00] (03CR) 10Pmiazga: "couple nitpicks, mostly me rambling about tech debt. -1 only for remaining not used PermissionManager in ToolbarBuilder. Everthing else lo" (037 comments) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/532794 (https://phabricator.wikimedia.org/T206265) (owner: 10Niedzielski) [11:19:06] (03CR) 10Pmiazga: [C: 04-1] [edit] [UI] hide edit section links for blocked users [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/532794 (https://phabricator.wikimedia.org/T206265) (owner: 10Niedzielski) [11:19:44] 10MediaWiki-Special-pages, 10Core Platform Team, 10User-DannyS712: Unable to view contributions: Call to undefined method ContribsPager::getContribs() - https://phabricator.wikimedia.org/T231540 (10DannyS712) Likely caused by https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/527626/ part of {T220447} - the... [11:19:55] 10MediaWiki-Special-pages, 10Core Platform Team, 10User-DannyS712: Unable to view contributions: Call to undefined method ContribsPager::getContribs() - https://phabricator.wikimedia.org/T231540 (10Mainframe98) [11:21:20] (03PS6) 10Jdrewniak: [icon] revise icons [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531713 (https://phabricator.wikimedia.org/T229440) (owner: 10Niedzielski) [11:23:00] 10MediaWiki-Special-pages, 10Core Platform Team, 10User-DannyS712: Unable to view contributions: Call to undefined method ContribsPager::getContribs() - https://phabricator.wikimedia.org/T231540 (10DannyS712) Codesearch reveals calls to `ContribsPager::getContribs` from #articlefeedbackv5 and #structureddisc... [11:24:17] (03CR) 10simetrical: "We need a reliable way to measure, though. The time that test runs take seems too variable to figure out how much impact this has. There's" [core] - 10https://gerrit.wikimedia.org/r/532334 (owner: 10simetrical) [11:24:44] (03CR) 10Reedy: [C: 04-1] "I need to actually test the code at this point, which requires some hardware. I think I have the right yubikey (or maybe even my solokeys " (037 comments) [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/508788 (https://phabricator.wikimedia.org/T218211) (owner: 10ItSpiderman) [11:25:35] (03CR) 10jerkins-bot: [V: 04-1] Replace usages of deprecated User::isAllowed. Step 2. [core] - 10https://gerrit.wikimedia.org/r/531503 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [11:26:39] 10Wikidata-Bridge-Sprint-3, 10Wikidata-Bridge-Sprint-4, 10MW-1.34-notes (1.34.0-wmf.21; 2019-09-03): Selenium tests will fail on gate&submit - https://phabricator.wikimedia.org/T231074 (10Lucas_Werkmeister_WMDE) Not sure (see also my question there) – are you still getting that error after the latest change... [11:27:36] (03PS7) 10simetrical: Call resetServices() when setting globals in tests [core] - 10https://gerrit.wikimedia.org/r/532334 [11:27:38] (03PS5) 10simetrical: Remove unneeded overrideMwServices/resetServices [core] - 10https://gerrit.wikimedia.org/r/532340 [11:28:32] (03CR) 10jerkins-bot: [V: 04-1] Replace usages of deprecated User::isAllowed. Step 2. [core] - 10https://gerrit.wikimedia.org/r/531503 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [11:28:55] 10ContentTranslation, 10Language-Team (Language-2019-July-September): Sentence highlighting not working on articles with math formulas - https://phabricator.wikimedia.org/T231076 (10Jpita) new findings: [[ https://sr.wikipedia.org/w/index.php?title=%D0%9F%D0%BE%D1%81%D0%B5%D0%B1%D0%BD%D0%BE:%D0%9F%D1%80%D0%B5%... [11:30:03] 10ContentTranslation, 10Language-Team (Language-2019-July-September): Whole article as one section - https://phabricator.wikimedia.org/T230200 (10Jpita) 05Open→03Resolved [11:31:11] (03Merged) 10jenkins-bot: LastEdit Renderer refactoring [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/533185 (owner: 10AlexPinchuk) [11:31:13] (03Merged) 10jenkins-bot: LastEdit Renderer refactoring [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/533188 (owner: 10Pwirth) [11:31:15] (03CR) 10jerkins-bot: [V: 04-1] Move User::getAllRights to PermissionManager. [core] - 10https://gerrit.wikimedia.org/r/532486 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [11:31:17] (03CR) 10jerkins-bot: [V: 04-1] createNoOpMock() method for PHPUnit tests [core] - 10https://gerrit.wikimedia.org/r/532982 (owner: 10simetrical) [11:31:19] (03CR) 10jerkins-bot: [V: 04-1] Integration tests for Language fallback methods [core] - 10https://gerrit.wikimedia.org/r/532231 (owner: 10simetrical) [11:32:09] 10MediaWiki-Core-Testing, 10Release-Engineering-Team-TODO, 10Code-Health, 10Continuous-Integration-Config, and 5 others: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Simetrical) If you want to split things up, split up PHPUnit tests themselves into m... [11:32:54] 10MediaWiki-ServiceContainer, 10TechCom, 10CPT Initiatives (Decoupling (CDP2)): Provide access to WebRequest and associated information via a service object - https://phabricator.wikimedia.org/T218555 (10Krinkle) >>! In T218555#5446317, @Simetrical wrote: > I think it's best to focus on concrete, case-by-cas... [11:33:07] (03CR) 10simetrical: "> Patch Set 9:" [core] - 10https://gerrit.wikimedia.org/r/531485 (owner: 10simetrical) [11:34:14] (03CR) 10jerkins-bot: [V: 04-1] Fix FileBackendGroup test for some configurations [core] - 10https://gerrit.wikimedia.org/r/533191 (owner: 10simetrical) [11:35:00] 10AbuseFilter, 10Wikimedia-production-error: AFPData.php: Refusing to cast DUNDEFINED to something else - https://phabricator.wikimedia.org/T231542 (10zeljkofilipin) [11:35:19] 10MediaWiki-Core-Testing: Wrap file access so it can be mocked - https://phabricator.wikimedia.org/T231159 (10Simetrical) Since the point of a cache is to save disk reads, I think we would want to directly test that it doesn't do unnecessary disk risks. Otherwise the cache isn't doing its job. Just injecting the... [11:35:29] 10AbuseFilter, 10Wikimedia-production-error: AFPData.php: Refusing to cast DUNDEFINED to something else - https://phabricator.wikimedia.org/T231542 (10zeljkofilipin) [11:35:49] 10AbuseFilter, 10Wikimedia-production-error: AFPData.php: Refusing to cast DUNDEFINED to something else - https://phabricator.wikimedia.org/T231542 (10zeljkofilipin) [11:36:43] (03Merged) 10jenkins-bot: Speculative to avoid setting subtitle when no title is found [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/533153 (https://phabricator.wikimedia.org/T61791) (owner: 10Kosta Harlan) [11:37:06] 10Phabricator: Phabricator shows that I removed other subscribers on a ticket. - https://phabricator.wikimedia.org/T231543 (10Fnielsen) [11:41:06] 10 WMDE-QWERTY-Sprint-2019-08-21 , 10Patch-For-Review, 10Spike: Investigation: Where we would need to do changes in order to add and edit book references with the VisualEditor - https://phabricator.wikimedia.org/T231005 (10awight) There's a specific piece of information we need for the parent task, which is... [11:41:09] 10AbuseFilter, 10Wikimedia-production-error: AFPData.php: Refusing to cast DUNDEFINED to something else - https://phabricator.wikimedia.org/T231542 (10Daimona) On it [11:41:11] 10 WMDE-QWERTY-Sprint-2019-08-21 , 10Spike: Investigate relationship of book referencing project and parsers - https://phabricator.wikimedia.org/T230920 (10awight) a:03jkroll [11:42:47] (03PS1) 10Reedy: Update version to 0.4.0 to keep better track of changes [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/533195 [11:42:48] 10Phabricator: Phabricator shows that I removed other subscribers on a ticket. - https://phabricator.wikimedia.org/T231543 (10Peachey88) Where? I can't see that in my view, could you perhaps attach a screenshot? [11:43:49] (03CR) 10Reedy: Implement WebAuthn module (032 comments) [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/508788 (https://phabricator.wikimedia.org/T218211) (owner: 10ItSpiderman) [11:44:40] 10AbuseFilter, 10Wikimedia-production-error: AFPData.php: Refusing to cast DUNDEFINED to something else - https://phabricator.wikimedia.org/T231542 (10Daimona) Meh, it's probably some old, corrupted row... May you please post the result of running fetchText.php with ID 850575? Thanks. [11:44:59] (03CR) 10Reedy: Update version to 0.4.0 to keep better track of changes (031 comment) [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/533195 (owner: 10Reedy) [11:45:08] (03CR) 10Krinkle: [C: 03+1] "> I think it's necessary. It means a test wasn't doing a service reset after changing globals" [core] - 10https://gerrit.wikimedia.org/r/532334 (owner: 10simetrical) [11:45:29] 10Phabricator: Phabricator shows that I removed other subscribers on a ticket. - https://phabricator.wikimedia.org/T231543 (10Reedy) [11:46:25] (03PS1) 10D3r1ck01: [libs][logging] Remove unused private methods within core files [core] - 10https://gerrit.wikimedia.org/r/533196 [11:46:27] 10ContentTranslation, 10Wikimedia-production-error: ApiQueryTranslatorStats.php: Argument 1 passed to ContentTranslation\Translator::__construct() must be an instance of User, bool given - https://phabricator.wikimedia.org/T231544 (10zeljkofilipin) [11:46:29] 10Phabricator: Phabricator shows that I removed other subscribers on a ticket. - https://phabricator.wikimedia.org/T231543 (10Reedy) >>! In T231543#5450718, @Peachey88 wrote: > Where? I can't see that in my view, could you perhaps attach a screenshot? Ditto, I can't see anything. Have you made changes above th... [11:47:05] 10ContentTranslation, 10Wikimedia-production-error: ApiQueryTranslatorStats.php: Argument 1 passed to ContentTranslation\Translator::__construct() must be an instance of User, bool given - https://phabricator.wikimedia.org/T231544 (10zeljkofilipin) [11:47:29] 10ContentTranslation, 10Wikimedia-production-error: ApiQueryTranslatorStats.php: Argument 1 passed to ContentTranslation\Translator::__construct() must be an instance of User, bool given - https://phabricator.wikimedia.org/T231544 (10zeljkofilipin) [11:50:07] (03CR) 10Daniel Kinzler: "> But, I think the vast majority of cases setMwGlobals is used, is for testing changes in behaviour where methods of a class check a Confi" [core] - 10https://gerrit.wikimedia.org/r/532334 (owner: 10simetrical) [11:50:20] (03PS1) 10Daimona Eaytoy: Use row->afl_action instead of $vars [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533198 (https://phabricator.wikimedia.org/T231542) [11:50:44] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/Empty] - 10https://gerrit.wikimedia.org/r/323210 (owner: 10Hashar) [11:51:01] 10MediaWiki-extensions-PhpTags, 10Core Platform Team Legacy (Watching / External), 10PHP 7.1 support: PhpTags tests fail on PHP 7.1 - https://phabricator.wikimedia.org/T206296 (10hashar) 05Open→03Resolved Somehow the tests are now passing on https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PhpTags... [11:51:02] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/441526 (owner: 10Hashar) [11:51:26] (03CR) 10Jdrewniak: [C: 03+2] [icon] revise icons [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531713 (https://phabricator.wikimedia.org/T229440) (owner: 10Niedzielski) [11:52:07] 10InternetArchiveBot: bot adds dead link template inside cs1|2 templates - https://phabricator.wikimedia.org/T231545 (10Trappist_the_monk) [11:52:48] (03CR) 10Daniel Kinzler: [C: 03+2] "> 11:09:17 Fatal error: Parameter $components is variadic and has a type constraint (array); variadic params with type constraints are not" [core] - 10https://gerrit.wikimedia.org/r/532982 (owner: 10simetrical) [11:54:40] (03CR) 10Daniel Kinzler: "Sigh..." [core] - 10https://gerrit.wikimedia.org/r/531503 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [11:55:08] 10Phabricator: Phabricator shows that I removed other subscribers on a ticket. - https://phabricator.wikimedia.org/T231543 (10Fnielsen) 05Open→03Resolved a:03Fnielsen Thanks, that was apparently not submitted but just shown as preview The line showed up at the bottom when "Change Subscribers" is selected... [11:55:16] (03CR) 10simetrical: [C: 03+1] "To avoid test failures due to phpcs or something failing, I have this in .git/hooks/pre-review:" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/531503 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [11:56:42] 10MediaWiki-REST-API, 10Core Platform Team Workboards (Green), 10Patch-For-Review: POST /:domain/v3/transform/pagebundle/to/pagebundle/:title?/:revision? - https://phabricator.wikimedia.org/T221174 (10mobrovac) @BPirkle Parsoid produces/consumes three blobs: HTML, data-parsoid and data-mw. They can be suppli... [11:58:16] (03CR) 10Krinkle: "Can you check when they were added and what they were used for then? Perhaps it'll help find when they were forgotten." [core] - 10https://gerrit.wikimedia.org/r/533196 (owner: 10D3r1ck01) [11:59:08] (03CR) 10Krinkle: "See T228695" [core] - 10https://gerrit.wikimedia.org/r/532982 (owner: 10simetrical) [12:01:26] (03PS2) 10Daimona Eaytoy: Globally unsuppress phan issues with low count [core] - 10https://gerrit.wikimedia.org/r/533177 [12:02:02] (03CR) 10Daniel Kinzler: [C: 03+2] Remove unneeded overrideMwServices/resetServices [core] - 10https://gerrit.wikimedia.org/r/532340 (owner: 10simetrical) [12:02:04] (03CR) 10Krinkle: "It is odd, though, it seems that commit does not preserve the logic. Maybe that introduced a bug?" [core] - 10https://gerrit.wikimedia.org/r/533196 (owner: 10D3r1ck01) [12:02:36] (03CR) 10Krinkle: Special:Log: Convert to HTMLForm (031 comment) [core] - 10https://gerrit.wikimedia.org/r/428871 (https://phabricator.wikimedia.org/T117737) (owner: 10Prtksxna) [12:04:05] (03CR) 10Daniel Kinzler: rdbms: Defer instantiating the DBLoadBalancerFactory service (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532367 (https://phabricator.wikimedia.org/T228895) (owner: 10TK-999) [12:04:07] (03CR) 10Krinkle: Globally unsuppress phan issues with low count (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533177 (owner: 10Daimona Eaytoy) [12:05:40] (03CR) 10Daimona Eaytoy: Globally unsuppress phan issues with low count (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533177 (owner: 10Daimona Eaytoy) [12:06:09] (03CR) 10Krinkle: "Fixes T231150. Which commit caused this issue?" [core] - 10https://gerrit.wikimedia.org/r/533190 (owner: 10Daniel Kinzler) [12:06:14] (03CR) 10Tchanders: "BlockManagerTest needs to be updated now the constructor params have changed. LoggerFactory::getProvider() needs to be added to the array " [core] - 10https://gerrit.wikimedia.org/r/531287 (https://phabricator.wikimedia.org/T230822) (owner: 10Urbanecm) [12:06:35] 10MediaWiki-Cache, 10Core Platform Team: failure of service creation for service 'ContentLanguage' not shown - https://phabricator.wikimedia.org/T231150 (10Krinkle) 05Open→03Resolved a:03daniel Fixed by . [12:07:48] (03PS5) 10Daniel Kinzler: Move User::getAllRights to PermissionManager. [core] - 10https://gerrit.wikimedia.org/r/532486 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [12:08:07] (03CR) 10Daniel Kinzler: [C: 03+2] "PS5 is a manual rebase" [core] - 10https://gerrit.wikimedia.org/r/532486 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [12:08:27] (03CR) 10Krinkle: Globally unsuppress phan issues with low count (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533177 (owner: 10Daimona Eaytoy) [12:08:32] (03CR) 10Daimona Eaytoy: "> BlockManagerTest needs to be updated now the constructor params" [core] - 10https://gerrit.wikimedia.org/r/531287 (https://phabricator.wikimedia.org/T230822) (owner: 10Urbanecm) [12:09:43] (03Merged) 10jenkins-bot: Avoid fatal errors when reporting exceptions. [core] - 10https://gerrit.wikimedia.org/r/533190 (owner: 10Daniel Kinzler) [12:09:46] (03CR) 10Daimona Eaytoy: Globally unsuppress phan issues with low count (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533177 (owner: 10Daimona Eaytoy) [12:09:52] (03Merged) 10jenkins-bot: Add UnknownContentHandler. [core] - 10https://gerrit.wikimedia.org/r/531688 (https://phabricator.wikimedia.org/T220608) (owner: 10Daniel Kinzler) [12:10:45] (03CR) 10Daniel Kinzler: "> Fixes T231150. Which commit caused this issue?" [core] - 10https://gerrit.wikimedia.org/r/533190 (owner: 10Daniel Kinzler) [12:13:54] 10MediaWiki-Special-pages, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), 10Wikimedia-production-error: Fatal error from Title->getTalkPage (Special:WhatLinksHere, Special:Contributions, …) - https://phabricator.wikimedia.org/T227817 (10Krinkle) [12:14:17] (03CR) 10jerkins-bot: [V: 04-1] Replace usages of deprecated User::isAllowed. Step 2. [core] - 10https://gerrit.wikimedia.org/r/531503 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [12:14:32] 10MediaWiki-Special-pages, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), 10Wikimedia-production-error: Fatal error from Title->getTalkPage (Special:WhatLinksHere, Special:Contributions, …) - https://phabricator.wikimedia.org/T227817 (10Krinkle) * Exception... [12:14:50] (03CR) 10Daniel Kinzler: [C: 03+2] Call resetServices() when setting globals in tests [core] - 10https://gerrit.wikimedia.org/r/532334 (owner: 10simetrical) [12:17:59] (03CR) 10D3r1ck01: "> Can you check when they were added and what they were used for then? Perhaps it'll help find when they were forgotten." [core] - 10https://gerrit.wikimedia.org/r/533196 (owner: 10D3r1ck01) [12:18:27] (03CR) 10D3r1ck01: "Let @Bartosz and/or @VolkerE have a look at this!" [core] - 10https://gerrit.wikimedia.org/r/533196 (owner: 10D3r1ck01) [12:20:12] (03PS1) 10Tchanders: Improve formatting of constructor documentation for block classes [core] - 10https://gerrit.wikimedia.org/r/533200 [12:27:09] (03CR) 10jerkins-bot: [V: 04-1] Move User::getAllRights to PermissionManager. [core] - 10https://gerrit.wikimedia.org/r/532486 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [12:28:01] 10MediaWiki-extensions-WikibaseRepository, 10Math, 10Wikidata, 10Wikidata-Campsite, and 2 others: Make it possible to query for math values - https://phabricator.wikimedia.org/T195765 (10Lydia_Pintscher) [12:28:24] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Query-Service, 10Technical-Debt, 10good first bug: export original string of math-datatype values to Wikidata Query Server - https://phabricator.wikimedia.org/T226735 (10Lydia_Pintscher) I'm merging this into the other ticket to find a sol... [12:28:48] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Query-Service, 10Technical-Debt, 10good first bug: export original string of math-datatype values to Wikidata Query Server - https://phabricator.wikimedia.org/T226735 (10Lydia_Pintscher) [12:28:54] 10MediaWiki-extensions-WikibaseRepository, 10Math, 10Wikidata, 10Wikidata-Campsite, and 2 others: Make it possible to query for math values - https://phabricator.wikimedia.org/T195765 (10Lydia_Pintscher) [12:28:56] (03CR) 10MSantos: [C: 03+2] Persist the uploader ID in machine_vision_label [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533095 (https://phabricator.wikimedia.org/T231104) (owner: 10Mholloway) [12:30:09] 10MediaWiki-Special-pages, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), 10Wikimedia-production-error: Fatal error from Title->getTalkPage (Special:WhatLinksHere, Special:Contributions, …) - https://phabricator.wikimedia.org/T227817 (10daniel) >>! In T2278... [12:32:25] (03CR) 10jenkins-bot: Avoid fatal errors when reporting exceptions. [core] - 10https://gerrit.wikimedia.org/r/533190 (owner: 10Daniel Kinzler) [12:32:33] 10MediaWiki-extensions-WikibaseRepository, 10Math, 10Wikidata, 10Wikidata-Campsite, and 2 others: Make it possible to query for math values - https://phabricator.wikimedia.org/T195765 (10Lucas_Werkmeister_WMDE) By the way, I checked if it’s possible to use WikibaseCirrusSearch as a workaround (`haswbstatem... [12:33:51] (03PS14) 10Pwirth: [WIP] Snapshot factory and entities. ERM:14344 [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/525092 [12:37:10] wikimedia/mediawiki#25314 (master - 3b35410 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/578321904 [12:39:02] (03Merged) 10jenkins-bot: [icon] revise icons [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531713 (https://phabricator.wikimedia.org/T229440) (owner: 10Niedzielski) [12:39:04] (03CR) 10jerkins-bot: [V: 04-1] createNoOpMock() method for PHPUnit tests [core] - 10https://gerrit.wikimedia.org/r/532982 (owner: 10simetrical) [12:39:06] (03CR) 10jerkins-bot: [V: 04-1] Integration tests for Language fallback methods [core] - 10https://gerrit.wikimedia.org/r/532231 (owner: 10simetrical) [12:41:16] (03PS1) 10D3r1ck01: GlobalFunctions: Hard deprecate the `wfDiff()`, usage only in core [core] - 10https://gerrit.wikimedia.org/r/533201 [12:44:04] (03CR) 10jenkins-bot: [icon] revise icons [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531713 (https://phabricator.wikimedia.org/T229440) (owner: 10Niedzielski) [12:48:44] 10WMEE: Vikipeedia sünnipäeva üritus Tallinnas 27. augustil 2019 - https://phabricator.wikimedia.org/T230930 (10Lmk2K18) 05Open→03Resolved [12:49:37] (03PS1) 10Matthias Mullie: Fix "Uncaught TypeError: abortable.abort is not a function" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/533203 [12:50:19] (03CR) 10jenkins-bot: Add UnknownContentHandler. [core] - 10https://gerrit.wikimedia.org/r/531688 (https://phabricator.wikimedia.org/T220608) (owner: 10Daniel Kinzler) [12:51:07] 10WMEE: Tõenduspõhisuse taristu Arvamusfestivalil - https://phabricator.wikimedia.org/T214895 (10tramm) Arutasime @Lmk2K18-ga selle projekti kulgu. Leppisime omavahel kokku, et lisame kumbki siia loetelu vormis oma vaate sellele, mis asjad olid selle projektiga hästi ja mis halvasti -- ja miks see ei ikkagi jõud... [12:52:18] (03CR) 10jerkins-bot: [V: 04-1] Move User::getAllRights to PermissionManager. [core] - 10https://gerrit.wikimedia.org/r/532486 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [12:52:45] (03CR) 10simetrical: "recheck" [core] - 10https://gerrit.wikimedia.org/r/531698 (owner: 10simetrical) [12:54:32] (03CR) 10Raimond Spekking: [C: 04-1] "Please merge the 2 xx.json into 1 xx.json." [extensions/BlueSpiceSocialComments] - 10https://gerrit.wikimedia.org/r/533062 (owner: 10Pwirth) [12:55:07] (03CR) 10jerkins-bot: [V: 04-1] GlobalFunctions: Hard deprecate the `wfDiff()`, usage only in core [core] - 10https://gerrit.wikimedia.org/r/533201 (owner: 10D3r1ck01) [12:56:50] (03CR) 10D3r1ck01: "recheck, failure not related but seems legit?" [core] - 10https://gerrit.wikimedia.org/r/533201 (owner: 10D3r1ck01) [12:57:15] 10MediaWiki-General, 10Wikimedia-production-error: NamespaceInfo.php: PHP Warning: A non-numeric value encountered - https://phabricator.wikimedia.org/T231548 (10zeljkofilipin) [12:57:18] 10Accessibility, 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog: Payment submethod logos should have alt text - https://phabricator.wikimedia.org/T231549 (10Pcoombe) [12:59:49] 10WMEE: Tõenduspõhisuse taristu Arvamusfestivalil - https://phabricator.wikimedia.org/T214895 (10Lmk2K18) Plaan oli osaleda Arvamusfestivalil pakkudes tõenduspõhisuse teenust koos faktikontrolliga, seejuures tegeleme kontrolli ja artiklite kirjutamisega taustal ise kui julgustame seda tegema osalejaid (auhinnad?... [12:59:50] (03PS2) 10Pwirth: Init commit [extensions/BlueSpiceSocialComments] - 10https://gerrit.wikimedia.org/r/533062 [13:00:03] (03CR) 10Pwirth: "done" [extensions/BlueSpiceSocialComments] - 10https://gerrit.wikimedia.org/r/533062 (owner: 10Pwirth) [13:01:21] (03CR) 10MSantos: [C: 03+2] Allow filtering suggestions for review by uploader [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533096 (https://phabricator.wikimedia.org/T231104) (owner: 10Mholloway) [13:06:21] (03CR) 10jerkins-bot: [V: 04-1] FileJournal tests [core] - 10https://gerrit.wikimedia.org/r/531698 (owner: 10simetrical) [13:07:14] (03CR) 10D3r1ck01: "> Is this part of the API even working?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/532797 (owner: 10D3r1ck01) [13:08:19] 10MediaWiki-ServiceContainer, 10TechCom, 10CPT Initiatives (Decoupling (CDP2)): Provide access to WebRequest and associated information via a service object - https://phabricator.wikimedia.org/T218555 (10Simetrical) >>! In T218555#5450673, @Krinkle wrote: > Will do next. Meanwhile: > > * What are both your... [13:10:05] 10MediaWiki-General, 10Wikimedia-production-error: NamespaceInfo.php: PHP Notice: A non well formed numeric value encountered - https://phabricator.wikimedia.org/T231551 (10zeljkofilipin) [13:10:07] (03CR) 10MSantos: Update review UI to use new unreviewed image labels API module (031 comment) [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533099 (https://phabricator.wikimedia.org/T231104) (owner: 10Mholloway) [13:10:15] (03CR) 10MSantos: [C: 03+2] Hygiene: Remove SpecialImageLabeling [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533101 (owner: 10Mholloway) [13:10:27] 10MediaWiki-General, 10Wikimedia-production-error: NamespaceInfo.php: PHP Notice: A non well formed numeric value encountered - https://phabricator.wikimedia.org/T231551 (10zeljkofilipin) [13:13:05] 10AbuseFilter, 10Patch-For-Review, 10Wikimedia-production-error: AFPData.php: Refusing to cast DUNDEFINED to something else - https://phabricator.wikimedia.org/T231542 (10hashar) >>! In T231542#5450720, @Daimona wrote: > Meh, it's probably some old, corrupted row... May you please post the result of running... [13:14:56] (03CR) 10Esanders: [C: 03+2] "recheck" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/531302 (owner: 10Bartosz Dziewoński) [13:16:10] (03CR) 10Esanders: "This can be merged independently of the MW icon stuff?" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531186 (https://phabricator.wikimedia.org/T230033) (owner: 10Esanders) [13:16:21] 10AbuseFilter, 10Patch-For-Review, 10Wikimedia-production-error: AFPData.php: Refusing to cast DUNDEFINED to something else - https://phabricator.wikimedia.org/T231542 (10Daimona) >>! In T231542#5450927, @hashar wrote: >>>! In T231542#5450720, @Daimona wrote: >> Meh, it's probably some old, corrupted row...... [13:16:57] (03PS7) 10D3r1ck01: mapper: Declare `insert()` in an interface & implement where needed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/531304 [13:17:50] 10AbuseFilter, 10Patch-For-Review, 10Wikimedia-production-error: AFPData.php: Refusing to cast DUNDEFINED to something else - https://phabricator.wikimedia.org/T231542 (10hashar) Nicer :) ` mwmaint1002:~$ mwscript shell.php --wiki=eswiktionary Psy Shell v0.9.9 (PHP 7.2.8-1+0~20180725124257.2+stretch~1.gbp571... [13:19:24] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/533201 (owner: 10D3r1ck01) [13:19:32] 10AbuseFilter, 10Patch-For-Review, 10Wikimedia-production-error: AFPData.php: Refusing to cast DUNDEFINED to something else - https://phabricator.wikimedia.org/T231542 (10Daimona) >>! In T231542#5450952, @hashar wrote: > Nicer :) Thanks :) > ` > mwmaint1002:~$ mwscript shell.php --wiki=eswiktionary > Psy S... [13:19:46] 10InternetArchiveBot: Can't grab list of pages where a link is encountered - Cantonese Wikipedia - https://phabricator.wikimedia.org/T231553 (10deryckchan) [13:20:40] (03PS1) 10Daimona Eaytoy: Unsuppress other phan issues with low count [core] - 10https://gerrit.wikimedia.org/r/533206 [13:21:07] 10MediaWiki-ServiceContainer, 10TechCom, 10CPT Initiatives (Decoupling (CDP2)): Provide access to WebRequest and associated information via a service object - https://phabricator.wikimedia.org/T218555 (10Krinkle) >>! In T218555#5450906, @Simetrical wrote: >>>! In T218555#5450673, @Krinkle wrote: >> What are... [13:21:31] (03Merged) 10jenkins-bot: Call resetServices() when setting globals in tests [core] - 10https://gerrit.wikimedia.org/r/532334 (owner: 10simetrical) [13:22:36] (03Merged) 10jenkins-bot: Remove unneeded overrideMwServices/resetServices [core] - 10https://gerrit.wikimedia.org/r/532340 (owner: 10simetrical) [13:22:53] (03CR) 10Krinkle: Globally unsuppress phan issues with low count (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533177 (owner: 10Daimona Eaytoy) [13:25:08] (03CR) 10Daimona Eaytoy: Globally unsuppress phan issues with low count (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533177 (owner: 10Daimona Eaytoy) [13:25:12] 10 WMDE-QWERTY-Sprint-2019-08-21 , 10Spike: Investigate relationship of book referencing project and parsers - https://phabricator.wikimedia.org/T230920 (10awight) Nothing came of my theory that we could also piggyback on the `name` attribute. Redefining a named reference is definitely not backwards-compatible. [13:28:26] (03PS1) 10Daniel Kinzler: Restore the old behavior of Title::getTalkPage() [core] - 10https://gerrit.wikimedia.org/r/533208 (https://phabricator.wikimedia.org/T227817) [13:29:57] 10AbuseFilter, 10Patch-For-Review, 10Wikimedia-production-error: AFPData.php: Refusing to cast DUNDEFINED to something else - https://phabricator.wikimedia.org/T231542 (10Daimona) Apparently, loadVarDump succeeds because it just returns [[https://phabricator.wikimedia.org/diffusion/EABF/browse/wmf%252F1.34.0... [13:30:37] (03CR) 10Mholloway: Update review UI to use new unreviewed image labels API module (031 comment) [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533099 (https://phabricator.wikimedia.org/T231104) (owner: 10Mholloway) [13:30:41] 10Trust-and-Safety, 10Security: Reset my 2FA on this Phab account - https://phabricator.wikimedia.org/T231526 (10Cyberpower678) Pinging @jrbs and @Tgr [13:30:47] 10MediaWiki-Vagrant, 10Discovery, 10Wikidata, 10Discovery-Search (Current work): vagrant wikibase cirrus role not working / should set $wgWBCSUseCirrus = true; to enable - https://phabricator.wikimedia.org/T228503 (10dcausse) The `searchIndexProperties` wikibase config needs to be populated as well. What... [13:31:27] 10InternetArchiveBot: Can't grab list of pages where a link is encountered - Cantonese Wikipedia - https://phabricator.wikimedia.org/T231553 (10Cyberpower678) That's because IABot hasn't seen a page with this particular URL. [13:31:37] 10Core Platform Team, 10TemplateStyles, 10css-sanitizer, 10Patch-For-Review: Decide which non-standard CSS properties to support in TemplateStyles - https://phabricator.wikimedia.org/T162379 (10stjn) Alternatively, `zoom: 1` can be dropped from every codebase since it’s a property that does something in IE... [13:31:54] (03CR) 10Daniel Kinzler: [C: 03+2] "Per Daimona on T228695:" [core] - 10https://gerrit.wikimedia.org/r/532982 (owner: 10simetrical) [13:32:57] (03PS2) 10simetrical: Fix FileBackendGroup test for some configurations [core] - 10https://gerrit.wikimedia.org/r/533191 [13:34:37] 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10MinervaNeue (Desktop), 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Cleanup AMC feature flagging - https://phabricator.wikimedia.org/T229295 (10Edtadros) a:05pmiazga→03Edtadros [13:35:15] (03CR) 10Daniel Kinzler: [C: 04-1] "CR-1 because the test needs an HHVM workaround" [core] - 10https://gerrit.wikimedia.org/r/532982 (owner: 10simetrical) [13:35:33] (03PS4) 10Daniel Kinzler: createNoOpMock() method for PHPUnit tests [core] - 10https://gerrit.wikimedia.org/r/532982 (owner: 10simetrical) [13:35:47] (03PS11) 10Daniel Kinzler: Integration tests for Language fallback methods [core] - 10https://gerrit.wikimedia.org/r/532231 (owner: 10simetrical) [13:35:53] 10MediaWiki-Special-pages, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-notes (1.34.0-wmf.16; 2019-07-30), 10Patch-For-Review, 10Wikimedia-production-error: Fatal error from Title->getTalkPage (Special:WhatLinksHere, Special:Contributions, …) - https://phabricator.wikimedia.org/T227817 (1... [13:36:42] (03CR) 10simetrical: "The problem here is in the AbuseFilter tests themselves, this patch is just exposing it. They're supposed to be unit tests, but a hook fro" [core] - 10https://gerrit.wikimedia.org/r/531698 (owner: 10simetrical) [13:38:37] (03PS6) 10Daniel Kinzler: Move User::getAllRights to PermissionManager. [core] - 10https://gerrit.wikimedia.org/r/532486 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [13:40:17] (03PS1) 10Fomafix: Update code accoding coding convention [extensions/UploadLogo] - 10https://gerrit.wikimedia.org/r/533209 [13:41:08] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress other phan issues with low count [core] - 10https://gerrit.wikimedia.org/r/533206 (owner: 10Daimona Eaytoy) [13:42:42] (03CR) 10jerkins-bot: [V: 04-1] Persist the uploader ID in machine_vision_label [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533095 (https://phabricator.wikimedia.org/T231104) (owner: 10Mholloway) [13:42:44] (03CR) 10jerkins-bot: [V: 04-1] Allow filtering suggestions for review by uploader [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533096 (https://phabricator.wikimedia.org/T231104) (owner: 10Mholloway) [13:44:30] (03CR) 10ItSpiderman: Implement WebAuthn module (033 comments) [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/508788 (https://phabricator.wikimedia.org/T218211) (owner: 10ItSpiderman) [13:44:56] 10Design, 10Editing Design, 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): Redesign save/publish dialog to show changes/diff alongside the edit summary, to help prompt people to write better summaries - https://phabricator.wikimedia.org/T140451 (10JTannerWMF) Looks like this... [13:45:51] 10Design, 10Editing Design, 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): Redesign save/publish dialog to show changes/diff alongside the edit summary, to help prompt people to write better summaries - https://phabricator.wikimedia.org/T140451 (10JTannerWMF) @Esanders it lo... [13:46:08] 10AbuseFilter, 10Patch-For-Review, 10Wikimedia-production-error: AFPData.php: Refusing to cast DUNDEFINED to something else - https://phabricator.wikimedia.org/T231542 (10Daimona) Eeeek, I see lots of rows are missing in eswiktionary. See [[https://es.wiktionary.org/w/index.php?title=Especial:RegistroAbusos&... [13:47:23] 10AbuseFilter, 10Patch-For-Review, 10Wikimedia-production-error: AFPData.php: Refusing to cast DUNDEFINED to something else - https://phabricator.wikimedia.org/T231542 (10hashar) ` mwmaint1002:~$ mwscript sql.php --wiki=eswiktionary > select * from text where old_id = 850575; stdClass Object ( [old_id] =... [13:48:06] 10ContentTranslation, 10Language-Team (Language-2019-July-September), 10Wikimedia-production-error: ApiQueryTranslatorStats.php: Argument 1 passed to ContentTranslation\Translator::__construct() must be an instance of User, bool given - https://phabricator.wikimedia.org/T231544 (10Nikerabbit) This just looks... [13:48:18] 10AbuseFilter, 10Patch-For-Review, 10Wikimedia-production-error: AFPData.php: Refusing to cast DUNDEFINED to something else - https://phabricator.wikimedia.org/T231542 (10hashar) I do not know how to retrieve text from the external storage servers ( DB://cluster24/14696 ) [13:48:26] 10MediaWiki-extensions-JsonConfig, 10Wikimedia-production-error: JCApi.php: PHP Notice: Trying to get property [PROPERTY] of non-object - https://phabricator.wikimedia.org/T231556 (10zeljkofilipin) [13:49:51] 10MediaWiki-API, 10Core Platform Team, 10Patch-For-Review: The action API should have a flag that delays the response until all replicas have seen any changes caused by the request - https://phabricator.wikimedia.org/T230211 (10Krinkle) >>! In T230211#5406767, @daniel wrote: >>>! In T230211#5405990, @Tgr wro... [13:50:27] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress other phan issues with low count [core] - 10https://gerrit.wikimedia.org/r/533206 (owner: 10Daimona Eaytoy) [13:51:31] wikimedia/mediawiki#25315 (master - 0ef534a jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/578352338 [13:52:04] (03PS16) 10ItSpiderman: Implement WebAuthn module [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/508788 (https://phabricator.wikimedia.org/T218211) [13:52:11] (03CR) 10MSantos: Update review UI to use new unreviewed image labels API module (031 comment) [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533099 (https://phabricator.wikimedia.org/T231104) (owner: 10Mholloway) [13:52:31] 10MediaWiki-Core-Testing: Wrap file access so it can be mocked - https://phabricator.wikimedia.org/T231159 (10Anomie) You still wouldn't really need to inject anything there. You could refactor it to split the file-loading part into a separate protected method that takes the filename as a parameter, e.g. ` lang... [13:52:37] 10AbuseFilter, 10Patch-For-Review, 10Wikimedia-production-error: AFPData.php: Refusing to cast DUNDEFINED to something else - https://phabricator.wikimedia.org/T231542 (10Daimona) >>! In T231542#5451065, @hashar wrote: > ` > mwmaint1002:~$ mwscript sql.php --wiki=eswiktionary >> select * from text where old_... [13:53:23] 10Editing Design, 10OWC2020 : Define what on-wiki-communication research to conduct at Wikimania Stockholm - https://phabricator.wikimedia.org/T228679 (10JTannerWMF) @iamjessklein will put the results in this ticket. Once done she will remove her tag and then move it to Peter's column on the current work board. [13:54:42] 10Editing Design, 10OWC2020 , 10VisualEditor (Current work): Define what on-wiki-communication research to conduct at Wikimania Stockholm - https://phabricator.wikimedia.org/T228679 (10JTannerWMF) [13:54:51] Can someone explain to me how $GLOBALS['wgHooks'] can be unset but $wgHooks can be set (with a global declaration, obviously)? [13:55:12] (03PS2) 10Daimona Eaytoy: Unsuppress other phan issues with low count [core] - 10https://gerrit.wikimedia.org/r/533206 [13:56:53] (03CR) 10Krinkle: [C: 03+2] Use row->afl_action instead of $vars [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533198 (https://phabricator.wikimedia.org/T231542) (owner: 10Daimona Eaytoy) [13:57:00] 10MediaWiki-REST-API, 10Core Platform Team Workboards (Green), 10Patch-For-Review: POST /:domain/v3/transform/pagebundle/to/pagebundle/:title?/:revision? - https://phabricator.wikimedia.org/T221174 (10Tgr) >>! In T221174#5443546, @BPirkle wrote: > I looked for extraction code in both the PHP and JS trees, bu... [13:57:27] (03CR) 10Krinkle: [C: 03+1] "Would you prefer to find the root cause and have both fixed? Or is it likely this will still fix cases that fail otherwise?" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533198 (https://phabricator.wikimedia.org/T231542) (owner: 10Daimona Eaytoy) [13:57:38] (03CR) 10ItSpiderman: "@Reedy: For testing I am using Yubico FIDO2 key, and also my phones security devices (fingerpring reader and iris scanner)." [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/508788 (https://phabricator.wikimedia.org/T218211) (owner: 10ItSpiderman) [13:57:40] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/531304 (owner: 10D3r1ck01) [13:58:22] (03CR) 10jerkins-bot: [V: 04-1] Restore the old behavior of Title::getTalkPage() [core] - 10https://gerrit.wikimedia.org/r/533208 (https://phabricator.wikimedia.org/T227817) (owner: 10Daniel Kinzler) [13:58:27] (03CR) 10ItSpiderman: Implement WebAuthn module (031 comment) [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/508788 (https://phabricator.wikimedia.org/T218211) (owner: 10ItSpiderman) [13:58:46] (03PS2) 10Fomafix: Update JavaScript code according to coding conventions [extensions/UploadLogo] - 10https://gerrit.wikimedia.org/r/533209 [13:58:59] (03CR) 10Daimona Eaytoy: "> Would you prefer to find the root cause and have both fixed? Or is" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533198 (https://phabricator.wikimedia.org/T231542) (owner: 10Daimona Eaytoy) [13:59:25] (03PS1) 10Mholloway: Dev: Register WikibaseClient as an extension dependency [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533217 [14:00:14] (03CR) 10Krinkle: [C: 03+2] Fix FileBackendGroup test for some configurations [core] - 10https://gerrit.wikimedia.org/r/533191 (owner: 10simetrical) [14:00:45] (03CR) 10jerkins-bot: [V: 04-1] Fix FileBackendGroup test for some configurations [core] - 10https://gerrit.wikimedia.org/r/533191 (owner: 10simetrical) [14:01:14] (03CR) 10Krinkle: [C: 03+2] Fix "Uncaught TypeError: abortable.abort is not a function" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/533203 (owner: 10Matthias Mullie) [14:01:20] (03PS1) 10Krinkle: Fix "Uncaught TypeError: abortable.abort is not a function" [extensions/CentralAuth] (wmf/1.34.0-wmf.20) - 10https://gerrit.wikimedia.org/r/533218 [14:02:08] (03CR) 10Krinkle: [C: 03+2] "OK :)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533198 (https://phabricator.wikimedia.org/T231542) (owner: 10Daimona Eaytoy) [14:02:12] 10Editing Design, 10VisualEditor (Current work): Tweak the mockups legal message placement to account for keyboard being up - https://phabricator.wikimedia.org/T229428 (10Esanders) We should also note that in iOS we don't auto-focus after opening the dialog because it is impossible. We do currently auto-focus... [14:03:03] (03CR) 10Krinkle: [C: 03+2] Update JavaScript code according to coding conventions [extensions/UploadLogo] - 10https://gerrit.wikimedia.org/r/533209 (owner: 10Fomafix) [14:03:37] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Wikimedia-CentralNotice-Administration: Display a sane error if the CN banner name is invalid, instead of a cryptic «BannerDataException» (when trying to clone a banner) - https://phabricator.wikimedia.org/T173782 (10mepps) The error display was... [14:04:16] (03CR) 10Krinkle: [C: 03+1] Simplify JavaScript code [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533174 (owner: 10Fomafix) [14:04:27] (03CR) 10jerkins-bot: [V: 04-1] Fix FileBackendGroup test for some configurations [core] - 10https://gerrit.wikimedia.org/r/533191 (owner: 10simetrical) [14:04:36] 10MediaWiki-Vagrant, 10MediaWiki-extensions-WikibaseClient, 10CirrusSearch, 10Discovery-Search, 10Wikidata: Vagrant first provision with wikibase and CirrusSearch causes 1146 Table 'wikidatawiki.wb_items_per_site' doesn't exist - https://phabricator.wikimedia.org/T231534 (10Tgr) IIRC this happens when Wi... [14:05:08] (03CR) 10Esanders: [C: 03+2] build: Upgrade eslint-utils dependency from 1.3.1 to 1.4.2 for security issues [core] - 10https://gerrit.wikimedia.org/r/532760 (owner: 10Jforrester) [14:05:10] (03PS5) 10Niedzielski: [edit] [UI] hide edit section links for blocked users [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/532794 (https://phabricator.wikimedia.org/T206265) [14:05:12] (03CR) 10Niedzielski: [edit] [UI] hide edit section links for blocked users (037 comments) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/532794 (https://phabricator.wikimedia.org/T206265) (owner: 10Niedzielski) [14:06:26] 10MediaWiki-ServiceContainer, 10TechCom, 10CPT Initiatives (Decoupling (CDP2)): Provide access to WebRequest and associated information via a service object - https://phabricator.wikimedia.org/T218555 (10TK-999) > What I mean is - what is our strategy for constructing things like a RevisionStore, Parser or M... [14:07:49] (03CR) 10Niedzielski: [edit] [UI] hide edit section links for blocked users (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/532794 (https://phabricator.wikimedia.org/T206265) (owner: 10Niedzielski) [14:08:16] (03CR) 10jerkins-bot: [V: 04-1] Fix FileBackendGroup test for some configurations [core] - 10https://gerrit.wikimedia.org/r/533191 (owner: 10simetrical) [14:08:22] (03CR) 10jenkins-bot: Remove unneeded overrideMwServices/resetServices [core] - 10https://gerrit.wikimedia.org/r/532340 (owner: 10simetrical) [14:08:46] (03CR) 10jerkins-bot: [V: 04-1] Restore the old behavior of Title::getTalkPage() [core] - 10https://gerrit.wikimedia.org/r/533208 (https://phabricator.wikimedia.org/T227817) (owner: 10Daniel Kinzler) [14:09:10] 10ContentTranslation, 10Language-Team (Language-2019-July-September), 10Patch-For-Review, 10Wikimedia-production-error: ApiQueryTranslatorStats.php: Argument 1 passed to ContentTranslation\Translator::__construct() must be an instance of User, bool given - https://phabricator.wikimedia.org/T231544 (10Nikera... [14:09:12] wikimedia/mediawiki#25316 (master - 23eef37 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/578352758 [14:09:22] 10ContentTranslation, 10Language-Team (Language-2019-July-September), 10Patch-For-Review, 10Wikimedia-production-error: ApiQueryTranslatorStats.php: Argument 1 passed to ContentTranslation\Translator::__construct() must be an instance of User, bool given - https://phabricator.wikimedia.org/T231544 (10Nikera... [14:11:04] 10VisualEditor (Current work): Translate Edit Card UI strings - https://phabricator.wikimedia.org/T225568 (10JTannerWMF) [14:12:14] (03CR) 10Anomie: [C: 04-1] rest: Use ParamValidator library, add BodyValidator (031 comment) [core] - 10https://gerrit.wikimedia.org/r/517076 (https://phabricator.wikimedia.org/T223239) (owner: 10Anomie) [14:12:17] 10Design, 10OOUI, 10VisualEditor-Edit Cards , 10VisualEditor (Current work): Evaluate mobile dialog transitions - https://phabricator.wikimedia.org/T224277 (10JTannerWMF) [14:12:46] (03Merged) 10jenkins-bot: Improve edit/upload error message integration [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/531302 (owner: 10Bartosz Dziewoński) [14:13:23] (03PS13) 10Fomafix: Strip additional special Unicode characters from title [core] - 10https://gerrit.wikimedia.org/r/493162 (https://phabricator.wikimedia.org/T121979) [14:14:05] (03PS1) 10simetrical: Unset globals more effectively for unit tests [core] - 10https://gerrit.wikimedia.org/r/533227 [14:14:10] 10Editing Design, 10VisualEditor (Current work): Revise edit flow transitions in mobile VE - https://phabricator.wikimedia.org/T229503 (10JTannerWMF) [14:14:34] (03PS13) 10simetrical: FileJournal tests [core] - 10https://gerrit.wikimedia.org/r/531698 [14:15:01] 10Accessibility, 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 10Fundraising Sprint Quick and the Deadlocked, 10Patch-For-Review: Payment submethod logos should have alt text - https://phabricator.wikimedia.org/T231549 (10Ejegg) p:05Triage→03Normal a:03Ejegg [14:16:09] (03CR) 10jerkins-bot: [V: 04-1] Dev: Register WikibaseClient as an extension dependency [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533217 (owner: 10Mholloway) [14:17:04] 10MediaWiki-Vagrant, 10Discovery, 10Wikidata, 10Discovery-Search (Current work): vagrant wikibase cirrus role not working / should set $wgWBCSUseCirrus = true; to enable - https://phabricator.wikimedia.org/T228503 (10Tgr) Thanks for lookig into it! These should be folded into the Vagrant role settings. I c... [14:17:25] 10AbuseFilter, 10Patch-For-Review, 10Wikimedia-production-error: AFPData.php: Refusing to cast DUNDEFINED to something else - https://phabricator.wikimedia.org/T231542 (10Daimona) >>! In T231542#5451131, @Daimona wrote: > Seems to resemble [[https://www.mediawiki.org/wiki/MediaWiki_1.21/Roadmap|1_21-wmf.11]]... [14:17:49] 10AbuseFilter, 10Patch-For-Review, 10Wikimedia-production-error: AFPData.php: Refusing to cast DUNDEFINED to something else - https://phabricator.wikimedia.org/T231542 (10hashar) >>> use MediaWiki\Storage\SqlBlobStore; >>> $id = SqlBlobStore::makeAddressFromTextId( 850575 ); => "tt:850575" >>> use MediaWiki\... [14:18:27] (03PS1) 10Niedzielski: [dev] [edit] rename EDIT permission to CONTENT_EDIT [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533230 [14:19:04] 10AbuseFilter, 10Patch-For-Review, 10Wikimedia-production-error: AFPData.php: Refusing to cast DUNDEFINED to something else - https://phabricator.wikimedia.org/T231542 (10hashar) {F30154532} [14:19:37] (03CR) 10jerkins-bot: [V: 04-1] Unsuppress other phan issues with low count [core] - 10https://gerrit.wikimedia.org/r/533206 (owner: 10Daimona Eaytoy) [14:20:00] (03PS5) 10Fomafix: Skin: Initialize LinkRenderer in construtor [core] - 10https://gerrit.wikimedia.org/r/509625 [14:20:07] 10Design, 10Editing Design, 10VisualEditor-MediaWiki, 10Patch-For-Review, 10VisualEditor (Current work): Redesign save/publish dialog to show changes/diff alongside the edit summary, to help prompt people to write better summaries - https://phabricator.wikimedia.org/T140451 (10JTannerWMF) a:03Esanders [14:23:24] (03PS2) 10Mholloway: Dev: Register WikibaseClient as an extension dependency [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533217 [14:23:51] (03PS3) 10Daimona Eaytoy: Unsuppress other phan issues with low count [core] - 10https://gerrit.wikimedia.org/r/533206 [14:24:02] (03CR) 10jenkins-bot: Call resetServices() when setting globals in tests [core] - 10https://gerrit.wikimedia.org/r/532334 (owner: 10simetrical) [14:24:20] 10MediaWiki-Cache, 10DBA, 10Performance-Team (Radar), 10User-Marostegui: Replace parsercache keys to something more meaningful on db-XXXX.php - https://phabricator.wikimedia.org/T210725 (10Marostegui) pc1010 is done: ` root@pc1010:/srv/sqldata-cache/parsercache# df -hT /srv/ Filesystem Type Siz... [14:25:13] (03CR) 10Daniel Kinzler: "> Patch Set 12:" [core] - 10https://gerrit.wikimedia.org/r/531698 (owner: 10simetrical) [14:26:21] 10MediaWiki-extensions-Translate, 10User-DannyS712, 10Wikimedia-production-error: DBQueryError when discouraging translation - https://phabricator.wikimedia.org/T231505 (10Nikerabbit) The code is roughly: ` MessageGroups::getPriority( $id ); MessageGroups::setPriority( $id, $new ); // First query new Manua... [14:26:29] (03CR) 10Isarra: "> Thank you for the change. If you prefer we could add it to ProofreadPage instead." [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533122 (https://phabricator.wikimedia.org/T231250) (owner: 10Isarra) [14:26:58] (03CR) 10jerkins-bot: [V: 04-1] Unset globals more effectively for unit tests [core] - 10https://gerrit.wikimedia.org/r/533227 (owner: 10simetrical) [14:27:43] (03Abandoned) 10Ankita Mandal: Improve the interface of Special:Cargo Query page in Cargo extension. Bug: T213513 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/532246 (https://phabricator.wikimedia.org/T213513) (owner: 10Ankita Mandal) [14:28:00] 10MediaWiki-extensions-Translate, 10Patch-For-Review, 10User-DannyS712, 10Wikimedia-production-error: DBQueryError when discouraging translation - https://phabricator.wikimedia.org/T231505 (10Nikerabbit) p:05Triage→03Normal [14:28:18] (03Abandoned) 10Ankita Mandal: Improve the interface of Special:Cargo Query page in Cargo extension. Bug: T213513 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/532560 (https://phabricator.wikimedia.org/T213513) (owner: 10Ankita Mandal) [14:29:09] 10MediaWiki-extensions-Translate, 10Patch-For-Review, 10User-DannyS712, 10Wikimedia-production-error: DBQueryError when discouraging translation - https://phabricator.wikimedia.org/T231505 (10Nikerabbit) @abi_ This seems quite similar to the issue with the message index, just a different table. [14:29:11] 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10MinervaNeue (Desktop), 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Cleanup AMC feature flagging - https://phabricator.wikimedia.org/T229295 (10Edtadros) a:05Edtadros→03pmiazga @pmiazga ... it's all yours! [14:29:21] (03CR) 10jerkins-bot: [V: 04-1] createNoOpMock() method for PHPUnit tests [core] - 10https://gerrit.wikimedia.org/r/532982 (owner: 10simetrical) [14:29:23] (03CR) 10jerkins-bot: [V: 04-1] Integration tests for Language fallback methods [core] - 10https://gerrit.wikimedia.org/r/532231 (owner: 10simetrical) [14:29:33] (03CR) 10jerkins-bot: [V: 04-1] FileJournal tests [core] - 10https://gerrit.wikimedia.org/r/531698 (owner: 10simetrical) [14:29:42] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2019-July-September), 10Patch-For-Review, 10User-DannyS712, 10Wikimedia-production-error: DBQueryError when discouraging translation - https://phabricator.wikimedia.org/T231505 (10Nikerabbit) [14:31:50] (03CR) 10jenkins-bot: Improve edit/upload error message integration [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/531302 (owner: 10Bartosz Dziewoński) [14:32:22] 10MediaWiki-ServiceContainer, 10TechCom, 10CPT Initiatives (Decoupling (CDP2)): Provide access to WebRequest and associated information via a service object - https://phabricator.wikimedia.org/T218555 (10Simetrical) >>! In T218555#5450986, @Krinkle wrote: > What I mean is - what is our strategy for construct... [14:32:24] (03CR) 10Daniel Kinzler: "This seems a lot easier than I had expected! Nice!" [core] - 10https://gerrit.wikimedia.org/r/533067 (https://phabricator.wikimedia.org/T231419) (owner: 10Daimona Eaytoy) [14:32:38] (03CR) 10jerkins-bot: [V: 04-1] Unset globals more effectively for unit tests [core] - 10https://gerrit.wikimedia.org/r/533227 (owner: 10simetrical) [14:33:14] (03CR) 10Krinkle: "See https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/528794/ - input wanted :)" [core] - 10https://gerrit.wikimedia.org/r/533227 (owner: 10simetrical) [14:33:53] (03CR) 10Daimona Eaytoy: "> This seems a lot easier than I had expected! Nice!" [core] - 10https://gerrit.wikimedia.org/r/533067 (https://phabricator.wikimedia.org/T231419) (owner: 10Daimona Eaytoy) [14:34:01] (03CR) 10jerkins-bot: [V: 04-1] Skin: Initialize LinkRenderer in construtor [core] - 10https://gerrit.wikimedia.org/r/509625 (owner: 10Fomafix) [14:35:25] (03CR) 10jerkins-bot: [V: 04-1] FileJournal tests [core] - 10https://gerrit.wikimedia.org/r/531698 (owner: 10simetrical) [14:35:40] 10Core Platform Team Workboards (Clinic Duty Team): Outage of restbase2017-b - https://phabricator.wikimedia.org/T231027 (10Eevans) This instance has gone down again, we should dig deeper. ` To: services@wikimedia.org Subject: ** PROBLEM alert - restbase2017/Check systemd state is CRITICAL ** Notification Type... [14:36:17] 10Core Platform Team Workboards (User Stories): Implement GET page history - https://phabricator.wikimedia.org/T231558 (10WDoranWMF) [14:36:27] (03PS2) 10Jdrewniak: [LESS] remove unused variables [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531720 (owner: 10Niedzielski) [14:37:02] 10MediaWiki-ServiceContainer, 10TechCom, 10CPT Initiatives (Decoupling (CDP2)): Provide access to WebRequest and associated information via a service object - https://phabricator.wikimedia.org/T218555 (10Krinkle) >>! In T218555#5451239, @Simetrical wrote: >>>! In T218555#5450986, @Krinkle wrote: >> [..] Woul... [14:37:24] (03CR) 10Pmiazga: [C: 04-1] [dev] [edit] rename EDIT permission to CONTENT_EDIT (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533230 (owner: 10Niedzielski) [14:37:35] 10Lingua Libre: Add an option not to record words already recorded by any other contributor - https://phabricator.wikimedia.org/T231559 (10Pamputt) [14:38:50] (03CR) 10jerkins-bot: [V: 04-1] Unset globals more effectively for unit tests [core] - 10https://gerrit.wikimedia.org/r/533227 (owner: 10simetrical) [14:38:52] 10Core Platform Team Workboards (User Stories): Implement GET page history - https://phabricator.wikimedia.org/T231558 (10WDoranWMF) [14:38:59] 10Mathe für Nicht-Freaks: Artikel "Beweise für Vektorräume führen" - https://phabricator.wikimedia.org/T209977 (10Klaus.mattis) a:03Klaus.mattis [14:39:20] (03CR) 10simetrical: [C: 03+1] "I agree with the approach." [core] - 10https://gerrit.wikimedia.org/r/533208 (https://phabricator.wikimedia.org/T227817) (owner: 10Daniel Kinzler) [14:40:06] (03CR) 10jerkins-bot: [V: 04-1] Dev: Register WikibaseClient as an extension dependency [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533217 (owner: 10Mholloway) [14:41:19] (03PS2) 10Niedzielski: [dev] [edit] rename EDIT permission to CONTENT_EDIT [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533230 [14:41:40] (03CR) 10jerkins-bot: [V: 04-1] Restore the old behavior of Title::getTalkPage() [core] - 10https://gerrit.wikimedia.org/r/533208 (https://phabricator.wikimedia.org/T227817) (owner: 10Daniel Kinzler) [14:41:49] 10WMEE: Tõenduspõhisuse taristu Arvamusfestivalil - https://phabricator.wikimedia.org/T214895 (10tramm) HÄSTI * projekt oli hästi sihitud (uued kontaktid vabatahtlikega, nähtavus aktiivsete noorte maailma muutjate seas, teadmiste teemadel pildil olemine, koostööpartnerite leidmise võimalused, vabade litsentside... [14:41:51] (03Merged) 10jenkins-bot: Use row->afl_action instead of $vars [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533198 (https://phabricator.wikimedia.org/T231542) (owner: 10Daimona Eaytoy) [14:42:20] 10MediaWiki-Gerrit-Group-Requests: CR+2 on MediaWiki for Aryeh Gregor (aka Simetrical) - https://phabricator.wikimedia.org/T230979 (10Simetrical) It's been seven days, and seemingly no objections. It would be useful for me to have +2 rights now just to re-submit patches I've written that failed gate-and-submit d... [14:42:36] 10MediaWiki-extensions-GWToolset, 10Commons: GWToolset error with 'item specific categories' on Wikimedia Commons Beta - https://phabricator.wikimedia.org/T231560 (10Companje) [14:42:49] (03CR) 10jerkins-bot: [V: 04-1] Skin: Initialize LinkRenderer in construtor [core] - 10https://gerrit.wikimedia.org/r/509625 (owner: 10Fomafix) [14:42:51] 10Core Platform Team Workboards (User Stories), 10Story: Curator gets anonymous edit history - https://phabricator.wikimedia.org/T231368 (10WDoranWMF) [14:42:53] 10Core Platform Team Workboards (User Stories), 10Story: Curator reads a revision - https://phabricator.wikimedia.org/T231345 (10WDoranWMF) [14:42:55] 10Core Platform Team Workboards (User Stories), 10Story: Curator gets reverted edit history - https://phabricator.wikimedia.org/T231355 (10WDoranWMF) [14:43:01] 10Core Platform Team Workboards (User Stories), 10Story: Curator gets bot edit count - https://phabricator.wikimedia.org/T231354 (10WDoranWMF) [14:43:03] 10Core Platform Team Workboards (User Stories), 10Story: Curator gets bot edit history - https://phabricator.wikimedia.org/T231369 (10WDoranWMF) [14:43:05] 10Core Platform Team Workboards (User Stories), 10Story: Curator gets reverted edits count - https://phabricator.wikimedia.org/T231351 (10WDoranWMF) [14:43:07] 10Core Platform Team Workboards (User Stories), 10Story: Curator gets anonymous edit count - https://phabricator.wikimedia.org/T231352 (10WDoranWMF) [14:43:09] 10Core Platform Team Workboards (User Stories), 10Story: Curator gets editors count - https://phabricator.wikimedia.org/T231349 (10WDoranWMF) [14:43:11] 10Core Platform Team Workboards (User Stories), 10Story: Curator gets edit count - https://phabricator.wikimedia.org/T231348 (10WDoranWMF) [14:43:13] 10Core Platform Team Workboards (User Stories), 10Story: Curator compares versions - https://phabricator.wikimedia.org/T231347 (10WDoranWMF) [14:43:15] 10Core Platform Team Workboards (User Stories), 10Story: Curator gets page history - https://phabricator.wikimedia.org/T231343 (10WDoranWMF) [14:43:43] (03PS3) 10Niedzielski: [dev] [edit] rename EDIT permission to CONTENT_EDIT [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533230 [14:43:58] 10MediaWiki-ServiceContainer, 10TechCom, 10CPT Initiatives (Decoupling (CDP2)): Provide access to WebRequest and associated information via a service object - https://phabricator.wikimedia.org/T218555 (10daniel) > I'd like to understand the "cross-wiki" use cases more. My understanding is that making somethi... [14:44:01] (03CR) 10Niedzielski: [dev] [edit] rename EDIT permission to CONTENT_EDIT (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533230 (owner: 10Niedzielski) [14:46:32] (03CR) 10jerkins-bot: [V: 04-1] FileJournal tests [core] - 10https://gerrit.wikimedia.org/r/531698 (owner: 10simetrical) [14:47:09] 10Core Platform Team Workboards (User Stories): Implement GET page history - https://phabricator.wikimedia.org/T231558 (10WDoranWMF) [14:47:33] 10Phabricator: Phabricator shows that I removed other subscribers on a ticket. - https://phabricator.wikimedia.org/T231543 (10JJMC89) 05Resolved→03Invalid a:05Fnielsen→03None [14:47:47] 10Core Platform Team Workboards (User Stories): Implement GET page history - https://phabricator.wikimedia.org/T231558 (10WDoranWMF) [14:48:14] (03CR) 10jerkins-bot: [V: 04-1] Unset globals more effectively for unit tests [core] - 10https://gerrit.wikimedia.org/r/533227 (owner: 10simetrical) [14:48:18] (03CR) 10Mholloway: "It doesn't look like the Depends-On directive actually applies the CI configuration change from the referenced patch; but the result of th" [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533217 (owner: 10Mholloway) [14:48:34] (03CR) 10Mholloway: "(For this repo.)" [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533217 (owner: 10Mholloway) [14:48:40] (03PS12) 10Ppchelko: Replace usages of deprecated User::isAllowed. Step 2. [core] - 10https://gerrit.wikimedia.org/r/531503 (https://phabricator.wikimedia.org/T220191) [14:48:43] 10InternetArchiveBot: Can't grab list of pages where a link is encountered - Cantonese Wikipedia - https://phabricator.wikimedia.org/T231553 (10deryckchan) But it did, and it left a message saying it fixed it - https://zh-yue.wikipedia.org/wiki/Talk:土木工程 [14:48:59] 10Core Platform Team Workboards (User Stories): Implement GET page history - https://phabricator.wikimedia.org/T231558 (10WDoranWMF) [14:50:00] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Quick and the Deadlocked: Review Campaign Fallback - https://phabricator.wikimedia.org/T226344 (10mepps) @AndyRussG Where are we with this? I'm thinking it's in the wrong column. [14:50:58] 10MediaWiki-ServiceContainer, 10TechCom, 10CPT Initiatives (Decoupling (CDP2)): Provide access to WebRequest and associated information via a service object - https://phabricator.wikimedia.org/T218555 (10daniel) >>! In T218555#5451257, @Krinkle wrote: > I am referring to one or two places in MediaWiki that w... [14:51:05] (03CR) 10jerkins-bot: [V: 04-1] Skin: Initialize LinkRenderer in construtor [core] - 10https://gerrit.wikimedia.org/r/509625 (owner: 10Fomafix) [14:53:00] (03CR) 10Jdrewniak: [C: 04-1] "^ I am not seeing that error on master. Despite that error, the unit tests are still marked as passing :/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531758 (https://phabricator.wikimedia.org/T231489) (owner: 10Jdlrobson) [14:53:53] (03Merged) 10jenkins-bot: Fix FileBackendGroup test for some configurations [core] - 10https://gerrit.wikimedia.org/r/533191 (owner: 10simetrical) [14:53:56] (03Merged) 10jenkins-bot: Fix "Uncaught TypeError: abortable.abort is not a function" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/533203 (owner: 10Matthias Mullie) [14:53:58] (03CR) 10jerkins-bot: [V: 04-1] Update JavaScript code according to coding conventions [extensions/UploadLogo] - 10https://gerrit.wikimedia.org/r/533209 (owner: 10Fomafix) [14:54:00] (03CR) 10Jdrewniak: "never mind... I am seeing that error on master" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531758 (https://phabricator.wikimedia.org/T231489) (owner: 10Jdlrobson) [14:54:09] (03CR) 10jerkins-bot: [V: 04-1] FileJournal tests [core] - 10https://gerrit.wikimedia.org/r/531698 (owner: 10simetrical) [14:54:32] (03CR) 10jenkins-bot: Use row->afl_action instead of $vars [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533198 (https://phabricator.wikimedia.org/T231542) (owner: 10Daimona Eaytoy) [14:54:45] (03CR) 10simetrical: "> Patch Set 5:" [core] - 10https://gerrit.wikimedia.org/r/533067 (https://phabricator.wikimedia.org/T231419) (owner: 10Daimona Eaytoy) [14:55:16] (03PS1) 10Niedzielski: [icon] [toolbar] update page info icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533237 (https://phabricator.wikimedia.org/T230693) [14:55:45] (03PS1) 10Krinkle: LinkRenderer: Service is consistently the site-wide default [core] - 10https://gerrit.wikimedia.org/r/533238 [14:58:06] (03CR) 10Krinkle: Skin: Initialize LinkRenderer in construtor (031 comment) [core] - 10https://gerrit.wikimedia.org/r/509625 (owner: 10Fomafix) [14:58:18] (03CR) 10jerkins-bot: [V: 04-1] Skin: Initialize LinkRenderer in construtor [core] - 10https://gerrit.wikimedia.org/r/509625 (owner: 10Fomafix) [14:58:44] (03PS1) 10Clarakosi: Modify -—with-extensions to throw extension dependency errors [core] - 10https://gerrit.wikimedia.org/r/533239 [14:58:58] (03CR) 10Ppchelko: "PS 12 is only a fix to phpcs" [core] - 10https://gerrit.wikimedia.org/r/531503 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [14:59:59] (03PS1) 10DCausse: [elastic] increase Xmx to 512m [vagrant] - 10https://gerrit.wikimedia.org/r/533240 (https://phabricator.wikimedia.org/T211362) [15:00:54] (03PS5) 10simetrical: createNoOpMock() method for PHPUnit tests [core] - 10https://gerrit.wikimedia.org/r/532982 [15:01:22] (03PS2) 10Daniel Kinzler: Restore the old behavior of Title::getTalkPage() [core] - 10https://gerrit.wikimedia.org/r/533208 (https://phabricator.wikimedia.org/T227817) [15:01:52] (03CR) 10simetrical: "Actually, that's the workaround that this test itself was using in the getMockCache() method. I just switched the getMockCache() call to c" [core] - 10https://gerrit.wikimedia.org/r/532982 (owner: 10simetrical) [15:02:57] (03PS2) 10DCausse: [elastic] increase Xmx to 512m [vagrant] - 10https://gerrit.wikimedia.org/r/533240 (https://phabricator.wikimedia.org/T211362) [15:04:03] (03PS3) 10DCausse: [elastic] increase Xmx to 512m [vagrant] - 10https://gerrit.wikimedia.org/r/533240 (https://phabricator.wikimedia.org/T211362) [15:05:06] (03CR) 10simetrical: LinkRenderer: Service is consistently the site-wide default (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533238 (owner: 10Krinkle) [15:05:15] (03CR) 10jenkins-bot: Fix "Uncaught TypeError: abortable.abort is not a function" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/533203 (owner: 10Matthias Mullie) [15:05:47] (03CR) 10jerkins-bot: [V: 04-1] [elastic] increase Xmx to 512m [vagrant] - 10https://gerrit.wikimedia.org/r/533240 (https://phabricator.wikimedia.org/T211362) (owner: 10DCausse) [15:07:44] (03PS4) 10DCausse: [elastic] increase Xmx to 512m [vagrant] - 10https://gerrit.wikimedia.org/r/533240 (https://phabricator.wikimedia.org/T211362) [15:07:46] (03CR) 10Jdrewniak: [C: 03+2] [LESS] remove unused variables [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531720 (owner: 10Niedzielski) [15:10:46] (03CR) 10jenkins-bot: Fix FileBackendGroup test for some configurations [core] - 10https://gerrit.wikimedia.org/r/533191 (owner: 10simetrical) [15:12:05] (03PS2) 10Krinkle: LinkRenderer: Service is consistently the site-wide default [core] - 10https://gerrit.wikimedia.org/r/533238 [15:13:03] (03CR) 10simetrical: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase (033 comments) [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [15:19:08] (03PS2) 10simetrical: Unset globals more effectively for unit tests [core] - 10https://gerrit.wikimedia.org/r/533227 [15:22:16] (03Merged) 10jenkins-bot: build: Upgrade eslint-utils dependency from 1.3.1 to 1.4.2 for security issues [core] - 10https://gerrit.wikimedia.org/r/532760 (owner: 10Jforrester) [15:23:26] (03CR) 10jerkins-bot: [V: 04-1] Modify -—with-extensions to throw extension dependency errors [core] - 10https://gerrit.wikimedia.org/r/533239 (owner: 10Clarakosi) [15:25:11] wikimedia/mediawiki#25317 (master - 36f0e81 jenkins-bot): The build was fixed. - https://travis-ci.org/wikimedia/mediawiki/builds/578397927 [15:26:19] (03PS1) 10Yaron Koren: i18n changes - restore "viewdata" in message names [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/533243 [15:27:27] (03PS21) 10Jdlrobson: Dev: Provide sensible fallbacks on mw.config values that don't exist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531758 (https://phabricator.wikimedia.org/T231489) [15:27:47] (03CR) 10Isarra: "Looks like we can do the reordering, but we can't apply an icon in this way for Vector without js, as there is no way to tell BaseTemplate" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533122 (https://phabricator.wikimedia.org/T231250) (owner: 10Isarra) [15:28:11] (03PS3) 10Daniel Kinzler: WIP: Reuse MediawikiTitleCodec in Title::newFromText. [core] - 10https://gerrit.wikimedia.org/r/527640 (owner: 10Ppchelko) [15:28:28] (03PS2) 10Daniel Kinzler: Ensure title->isValid() is true for valid titles. [core] - 10https://gerrit.wikimedia.org/r/527660 (owner: 10Ppchelko) [15:31:17] (03PS12) 10simetrical: Integration tests for Language fallback methods [core] - 10https://gerrit.wikimedia.org/r/532231 [15:31:19] (03PS6) 10simetrical: Make LocalisationCache a service [core] - 10https://gerrit.wikimedia.org/r/532679 (https://phabricator.wikimedia.org/T231220) [15:31:21] (03PS6) 10simetrical: Split some Language methods to LanguageNameUtils [core] - 10https://gerrit.wikimedia.org/r/532680 (https://phabricator.wikimedia.org/T201405) [15:31:23] (03PS14) 10simetrical: New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 (https://phabricator.wikimedia.org/T201405) [15:31:25] (03PS14) 10simetrical: Make grammar transform cache an instance member [core] - 10https://gerrit.wikimedia.org/r/532240 (https://phabricator.wikimedia.org/T201405) [15:31:27] (03PS32) 10simetrical: LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) [15:31:29] (03PS10) 10simetrical: Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 [15:31:31] (03PS5) 10simetrical: Cache nonexistence of grammar transformations [core] - 10https://gerrit.wikimedia.org/r/532241 [15:31:51] (03CR) 10jerkins-bot: [V: 04-1] Unset globals more effectively for unit tests [core] - 10https://gerrit.wikimedia.org/r/533227 (owner: 10simetrical) [15:32:29] (03CR) 10jerkins-bot: [V: 04-1] Unset globals more effectively for unit tests [core] - 10https://gerrit.wikimedia.org/r/533227 (owner: 10simetrical) [15:32:37] (03PS2) 10Yaron Koren: i18n changes - restore "viewdata" in message names [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/533243 [15:36:10] (03CR) 10Jdlrobson: [C: 03+2] "checked with Nick and Jan and they said I can restore the +2 here. The unit failure seems to relate to https://gerrit.wikimedia.org/r/#/c/" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531758 (https://phabricator.wikimedia.org/T231489) (owner: 10Jdlrobson) [15:36:47] (03PS1) 10DCausse: [mediainfo] Tell cirrus to index P1 and P2 as statements [vagrant] - 10https://gerrit.wikimedia.org/r/533246 (https://phabricator.wikimedia.org/T228503) [15:36:52] (03CR) 10Jforrester: "This won't work, because Wikibase isn't yet using static extension registration." [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533217 (owner: 10Mholloway) [15:37:16] (03CR) 10Jforrester: "> Patch Set 2:" [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533217 (owner: 10Mholloway) [15:38:56] (03CR) 10jerkins-bot: [V: 04-1] Unset globals more effectively for unit tests [core] - 10https://gerrit.wikimedia.org/r/533227 (owner: 10simetrical) [15:38:58] (03CR) 10jenkins-bot: build: Upgrade eslint-utils dependency from 1.3.1 to 1.4.2 for security issues [core] - 10https://gerrit.wikimedia.org/r/532760 (owner: 10Jforrester) [15:39:41] (03CR) 10jerkins-bot: [V: 04-1] New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [15:40:35] (03CR) 10jerkins-bot: [V: 04-1] Make grammar transform cache an instance member [core] - 10https://gerrit.wikimedia.org/r/532240 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [15:41:29] (03CR) 10jerkins-bot: [V: 04-1] LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [15:42:33] (03CR) 10jerkins-bot: [V: 04-1] Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [15:43:43] (03CR) 10jerkins-bot: [V: 04-1] Cache nonexistence of grammar transformations [core] - 10https://gerrit.wikimedia.org/r/532241 (owner: 10simetrical) [15:49:17] (03Merged) 10jenkins-bot: [LESS] remove unused variables [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531720 (owner: 10Niedzielski) [15:49:19] (03CR) 10jerkins-bot: [V: 04-1] New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [15:49:54] (03CR) 10jerkins-bot: [V: 04-1] New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [15:50:51] (03CR) 10jerkins-bot: [V: 04-1] New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [15:51:24] (03CR) 10jerkins-bot: [V: 04-1] Make grammar transform cache an instance member [core] - 10https://gerrit.wikimedia.org/r/532240 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [15:51:30] (03PS1) 10Jdlrobson: Fix failing qunit test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533251 [15:52:23] (03CR) 10Mholloway: "recheck" [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533217 (owner: 10Mholloway) [15:52:28] (03CR) 10jerkins-bot: [V: 04-1] Make grammar transform cache an instance member [core] - 10https://gerrit.wikimedia.org/r/532240 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [15:52:30] (03CR) 10DCausse: [C: 03+2] Convert m2run to aggregate like the others [search/glent] - 10https://gerrit.wikimedia.org/r/530971 (owner: 10EBernhardson) [15:53:23] (03CR) 10Yaron Koren: [C: 03+2] i18n changes - restore "viewdata" in message names [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/533243 (owner: 10Yaron Koren) [15:53:30] (03CR) 10jerkins-bot: [V: 04-1] Make grammar transform cache an instance member [core] - 10https://gerrit.wikimedia.org/r/532240 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [15:53:48] wikimedia/mediawiki#25318 (master - 48c8531 jenkins-bot): The build was fixed. - https://travis-ci.org/wikimedia/mediawiki/builds/578411889 [15:54:23] (03CR) 10jerkins-bot: [V: 04-1] LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [15:55:20] (03CR) 10jerkins-bot: [V: 04-1] LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [15:55:56] (03CR) 10jerkins-bot: [V: 04-1] Ensure title->isValid() is true for valid titles. [core] - 10https://gerrit.wikimedia.org/r/527660 (owner: 10Ppchelko) [15:56:11] (03CR) 10jerkins-bot: [V: 04-1] LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [15:57:09] (03CR) 10jerkins-bot: [V: 04-1] Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [15:57:22] (03CR) 10jerkins-bot: [V: 04-1] WIP: Reuse MediawikiTitleCodec in Title::newFromText. [core] - 10https://gerrit.wikimedia.org/r/527640 (owner: 10Ppchelko) [15:58:24] (03Merged) 10jenkins-bot: Convert m2run to aggregate like the others [search/glent] - 10https://gerrit.wikimedia.org/r/530971 (owner: 10EBernhardson) [15:58:38] (03CR) 10jerkins-bot: [V: 04-1] Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [15:58:44] (03CR) 10jerkins-bot: [V: 04-1] Ensure title->isValid() is true for valid titles. [core] - 10https://gerrit.wikimedia.org/r/527660 (owner: 10Ppchelko) [16:00:17] (03CR) 10MusikAnimal: [C: 04-1] "Messaging still uses the word "article" but this feature is available in the User namespace. The word "page" should be used instead, or di" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/529444 (https://phabricator.wikimedia.org/T207485) (owner: 10MaxSem) [16:00:19] (03CR) 10Tjones: "Bartosz, is there anything else to do to make this worthy of a +2?" [core] - 10https://gerrit.wikimedia.org/r/530929 (https://phabricator.wikimedia.org/T35242) (owner: 10Tjones) [16:00:21] (03CR) 10jerkins-bot: [V: 04-1] Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [16:00:25] (03CR) 10Aaron Schulz: filebackend: make FileBackend consistencyCheck() and resyncFiles() more robust (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533143 (https://phabricator.wikimedia.org/T231086) (owner: 10Aaron Schulz) [16:00:59] (03CR) 10jerkins-bot: [V: 04-1] Cache nonexistence of grammar transformations [core] - 10https://gerrit.wikimedia.org/r/532241 (owner: 10simetrical) [16:01:57] (03PS1) 10D3r1ck01: tests: Class is aliased to MediaWikiIntegrationTestCase [core] - 10https://gerrit.wikimedia.org/r/533254 [16:01:59] (03CR) 10jerkins-bot: [V: 04-1] Cache nonexistence of grammar transformations [core] - 10https://gerrit.wikimedia.org/r/532241 (owner: 10simetrical) [16:03:29] (03CR) 10jerkins-bot: [V: 04-1] Cache nonexistence of grammar transformations [core] - 10https://gerrit.wikimedia.org/r/532241 (owner: 10simetrical) [16:05:49] (03CR) 10Mholloway: "recheck" [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533095 (https://phabricator.wikimedia.org/T231104) (owner: 10Mholloway) [16:05:54] (03CR) 10Mholloway: "recheck" [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533096 (https://phabricator.wikimedia.org/T231104) (owner: 10Mholloway) [16:06:03] (03CR) 10Mholloway: "recheck" [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533099 (https://phabricator.wikimedia.org/T231104) (owner: 10Mholloway) [16:06:09] (03CR) 10Raimond Spekking: [C: 04-1] "i18n review" (031 comment) [extensions/BlueSpiceSocialComments] - 10https://gerrit.wikimedia.org/r/533062 (owner: 10Pwirth) [16:06:35] (03PS2) 10D3r1ck01: tests: Class is aliased to MediaWikiIntegrationTestCase [core] - 10https://gerrit.wikimedia.org/r/533254 [16:08:29] (03PS3) 10Aaron Schulz: Make ObjectCache check the value of apc.enable_cli in CLI mode [core] - 10https://gerrit.wikimedia.org/r/533032 (https://phabricator.wikimedia.org/T227838) [16:08:42] (03CR) 10Mholloway: "Er, this series probably now depends on I9d16b01995f5999a0fb293df8cbaa1941c52ce3b for CI, will rebase" [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533095 (https://phabricator.wikimedia.org/T231104) (owner: 10Mholloway) [16:08:50] (03CR) 10jerkins-bot: [V: 04-1] Persist the uploader ID in machine_vision_label [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533095 (https://phabricator.wikimedia.org/T231104) (owner: 10Mholloway) [16:09:45] (03PS3) 10Mholloway: Dev: Register WikibaseClient as an extension dependency [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533217 [16:09:47] (03PS3) 10Mholloway: Persist the uploader ID in machine_vision_label [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533095 (https://phabricator.wikimedia.org/T231104) [16:09:49] (03PS5) 10Mholloway: Allow filtering suggestions for review by uploader [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533096 (https://phabricator.wikimedia.org/T231104) [16:09:51] (03PS5) 10Mholloway: Update review UI to use new unreviewed image labels API module [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533099 (https://phabricator.wikimedia.org/T231104) [16:09:53] (03PS6) 10Mholloway: Hygiene: Remove SpecialImageLabeling [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533101 [16:11:02] (03CR) 10jerkins-bot: [V: 04-1] tests: Class is aliased to MediaWikiIntegrationTestCase [core] - 10https://gerrit.wikimedia.org/r/533254 (owner: 10D3r1ck01) [16:11:15] I know Jenkins [16:11:19] (03CR) 10jerkins-bot: [V: 04-1] WIP: Reuse MediawikiTitleCodec in Title::newFromText. [core] - 10https://gerrit.wikimedia.org/r/527640 (owner: 10Ppchelko) [16:11:54] (03CR) 10jerkins-bot: [V: 04-1] tests: Class is aliased to MediaWikiIntegrationTestCase [core] - 10https://gerrit.wikimedia.org/r/533254 (owner: 10D3r1ck01) [16:12:32] (03PS3) 10D3r1ck01: tests: Class is aliased to MediaWikiIntegrationTestCase [core] - 10https://gerrit.wikimedia.org/r/533254 [16:14:32] (03CR) 10D3r1ck01: "@Simetrical, I know you've been doing a lot of work around tests, do you mind having a look at `this`? Just a migration to the new class n" [core] - 10https://gerrit.wikimedia.org/r/533254 (owner: 10D3r1ck01) [16:15:17] (03PS1) 10DCausse: [cirrus] Allow updating the index when enabling geodata [vagrant] - 10https://gerrit.wikimedia.org/r/533256 [16:16:15] (03CR) 10jenkins-bot: Convert m2run to aggregate like the others [search/glent] - 10https://gerrit.wikimedia.org/r/530971 (owner: 10EBernhardson) [16:17:32] (03CR) 10jenkins-bot: [LESS] remove unused variables [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531720 (owner: 10Niedzielski) [16:19:08] (03CR) 10Dbarratt: [C: 04-1] Pass the user and request into BlockManager::getUserBlock (031 comment) [core] - 10https://gerrit.wikimedia.org/r/531946 (https://phabricator.wikimedia.org/T230363) (owner: 10Tchanders) [16:19:39] (03PS2) 10Clarakosi: Modify -—with-extensions to throw extension dependency errors [core] - 10https://gerrit.wikimedia.org/r/533239 (https://phabricator.wikimedia.org/T225512) [16:20:15] (03CR) 10Mobrovac: [C: 04-1] Introduce BlobStore::getBlobBatch method (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532449 (https://phabricator.wikimedia.org/T230834) (owner: 10Ppchelko) [16:24:53] (03PS3) 10Clarakosi: Modify -—with-extensions to throw extension dependency errors [core] - 10https://gerrit.wikimedia.org/r/533239 (https://phabricator.wikimedia.org/T225512) [16:32:51] (03Merged) 10jenkins-bot: Dev: Provide sensible fallbacks on mw.config values that don't exist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531758 (https://phabricator.wikimedia.org/T231489) (owner: 10Jdlrobson) [16:32:54] (03Merged) 10jenkins-bot: i18n changes - restore "viewdata" in message names [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/533243 (owner: 10Yaron Koren) [16:33:22] (03CR) 10Ppchelko: Introduce BlobStore::getBlobBatch method (032 comments) [core] - 10https://gerrit.wikimedia.org/r/532449 (https://phabricator.wikimedia.org/T230834) (owner: 10Ppchelko) [16:33:28] (03PS16) 10Jdlrobson: Icons should not be defined in stylesheets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531742 (https://phabricator.wikimedia.org/T231489) [16:34:01] (03PS3) 10Jdlrobson: Move some TableOfContents styles from Minerva to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533070 [16:34:28] (03PS3) 10Bartosz Dziewoński: Remove unused localisation messages for old edit toolbar [core] - 10https://gerrit.wikimedia.org/r/532965 (https://phabricator.wikimedia.org/T224429) [16:38:01] (03CR) 10jerkins-bot: [V: 04-1] tests: Class is aliased to MediaWikiIntegrationTestCase [core] - 10https://gerrit.wikimedia.org/r/533254 (owner: 10D3r1ck01) [16:40:28] (03CR) 10Ppchelko: Restore the old behavior of Title::getTalkPage() (032 comments) [core] - 10https://gerrit.wikimedia.org/r/533208 (https://phabricator.wikimedia.org/T227817) (owner: 10Daniel Kinzler) [16:41:30] (03CR) 10Jforrester: "Should we move sig-text to WikiEditor's repo (and rename it)?" [core] - 10https://gerrit.wikimedia.org/r/532965 (https://phabricator.wikimedia.org/T224429) (owner: 10Bartosz Dziewoński) [16:42:16] (03CR) 10Krinkle: resources: Upgrade OOjs from v2.2.2 to v3.0.0 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533051 (owner: 10Jforrester) [16:43:01] (03CR) 10jenkins-bot: i18n changes - restore "viewdata" in message names [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/533243 (owner: 10Yaron Koren) [16:43:03] (03CR) 10Krinkle: "Aye, yeah, I guess we'll need to treat it like other libs and just add one or two entries in external.js. e.g. one for OO and one for OO.E" [core] - 10https://gerrit.wikimedia.org/r/533051 (owner: 10Jforrester) [16:43:08] (03CR) 10Jforrester: resources: Upgrade OOjs from v2.2.2 to v3.0.0 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533051 (owner: 10Jforrester) [16:43:12] (03PS4) 10D3r1ck01: tests: Class is aliased to MediaWikiIntegrationTestCase [core] - 10https://gerrit.wikimedia.org/r/533254 [16:46:21] (03PS2) 10Krinkle: resources: Upgrade OOjs from v2.2.2 to v3.0.0 [core] - 10https://gerrit.wikimedia.org/r/533051 (owner: 10Jforrester) [16:48:07] (03PS3) 10Krinkle: resources: Upgrade OOjs from v2.2.2 to v3.0.0 [core] - 10https://gerrit.wikimedia.org/r/533051 (owner: 10Jforrester) [16:49:05] (03CR) 10jenkins-bot: Dev: Provide sensible fallbacks on mw.config values that don't exist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531758 (https://phabricator.wikimedia.org/T231489) (owner: 10Jdlrobson) [16:51:56] (03PS1) 10Daimona Eaytoy: Make AbuseFilterVariableHolder::$mVars public again [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533266 (https://phabricator.wikimedia.org/T231542) [16:52:15] (03PS1) 10Daimona Eaytoy: Make AbuseFilterVariableHolder::$mVars public again [extensions/AbuseFilter] (wmf/1.34.0-wmf.20) - 10https://gerrit.wikimedia.org/r/533267 (https://phabricator.wikimedia.org/T231542) [16:54:39] (03CR) 10jerkins-bot: [V: 04-1] resources: Upgrade OOjs from v2.2.2 to v3.0.0 [core] - 10https://gerrit.wikimedia.org/r/533051 (owner: 10Jforrester) [16:56:15] (03CR) 10DCausse: [C: 03+2] Match suggestion aggregation output to CirrusSearch template [search/glent] - 10https://gerrit.wikimedia.org/r/533084 (owner: 10EBernhardson) [16:57:44] (03Merged) 10jenkins-bot: Match suggestion aggregation output to CirrusSearch template [search/glent] - 10https://gerrit.wikimedia.org/r/533084 (owner: 10EBernhardson) [17:00:01] (03CR) 10Daniel Kinzler: "Looks good at a glance, but haven't tested. One question inline." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533239 (https://phabricator.wikimedia.org/T225512) (owner: 10Clarakosi) [17:02:11] (03CR) 10jenkins-bot: Match suggestion aggregation output to CirrusSearch template [search/glent] - 10https://gerrit.wikimedia.org/r/533084 (owner: 10EBernhardson) [17:02:52] (03CR) 10jerkins-bot: [V: 04-1] resources: Upgrade OOjs from v2.2.2 to v3.0.0 [core] - 10https://gerrit.wikimedia.org/r/533051 (owner: 10Jforrester) [17:02:56] (03CR) 10MSantos: [C: 03+2] Dev: Register WikibaseClient as an extension dependency [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533217 (owner: 10Mholloway) [17:03:26] (03CR) 10MSantos: [C: 03+2] Update review UI to use new unreviewed image labels API module [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533099 (https://phabricator.wikimedia.org/T231104) (owner: 10Mholloway) [17:04:05] (03CR) 10Krinkle: [C: 03+2] Make AbuseFilterVariableHolder::$mVars public again [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533266 (https://phabricator.wikimedia.org/T231542) (owner: 10Daimona Eaytoy) [17:04:13] (03CR) 10Krinkle: [C: 03+1] Make AbuseFilterVariableHolder::$mVars public again [extensions/AbuseFilter] (wmf/1.34.0-wmf.20) - 10https://gerrit.wikimedia.org/r/533267 (https://phabricator.wikimedia.org/T231542) (owner: 10Daimona Eaytoy) [17:04:40] (03Abandoned) 10Jdlrobson: Replace moment.js with Date.toLocaleString [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/513233 (https://phabricator.wikimedia.org/T224635) (owner: 10Simon04) [17:05:18] (03CR) 10jerkins-bot: [V: 04-1] Move some TableOfContents styles from Minerva to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533070 (owner: 10Jdlrobson) [17:05:45] (03CR) 10Jdlrobson: "Who can help Fomafix push this change forward?" [core] - 10https://gerrit.wikimedia.org/r/467770 (https://phabricator.wikimedia.org/T117845) (owner: 10Fomafix) [17:06:24] (03CR) 10jerkins-bot: [V: 04-1] Remove unused localisation messages for old edit toolbar [core] - 10https://gerrit.wikimedia.org/r/532965 (https://phabricator.wikimedia.org/T224429) (owner: 10Bartosz Dziewoński) [17:06:33] (03PS4) 10Jdlrobson: Move some TableOfContents styles from Minerva to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533070 [17:09:30] (03CR) 10Krinkle: [C: 03+2] Make ObjectCache check the value of apc.enable_cli in CLI mode [core] - 10https://gerrit.wikimedia.org/r/533032 (https://phabricator.wikimedia.org/T227838) (owner: 10Aaron Schulz) [17:09:38] (03PS3) 10Krinkle: Add HashBagOStuff fallback for APC in MWLBFactory::injectObjectCaches [core] - 10https://gerrit.wikimedia.org/r/533138 (https://phabricator.wikimedia.org/T227838) (owner: 10Aaron Schulz) [17:11:00] (03CR) 10Krinkle: [C: 03+1] filebackend: make FileBackend consistencyCheck() and resyncFiles() more robust (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533143 (https://phabricator.wikimedia.org/T231086) (owner: 10Aaron Schulz) [17:12:18] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/533254 (owner: 10D3r1ck01) [17:12:31] (03PS1) 10Daniel Kinzler: Title: make newFromText, isValid, and canExist behave consistently. [core] - 10https://gerrit.wikimedia.org/r/533271 (https://phabricator.wikimedia.org/T229705) [17:12:48] (03CR) 10Krinkle: [C: 03+2] filebackend: add idiom constant to FileBackend for null results [core] - 10https://gerrit.wikimedia.org/r/533162 (owner: 10Aaron Schulz) [17:14:41] (03CR) 10Krinkle: [C: 03+2] filebackend: fix @throws comment in FileBackend::makeContentDisposition() [core] - 10https://gerrit.wikimedia.org/r/533145 (owner: 10Aaron Schulz) [17:14:56] (03CR) 10Daimona Eaytoy: "> We need to check how this interacts with opcode caches. If someone" [core] - 10https://gerrit.wikimedia.org/r/533067 (https://phabricator.wikimedia.org/T231419) (owner: 10Daimona Eaytoy) [17:15:24] (03Abandoned) 10Krinkle: Add HashBagOStuff fallback for APC in MWLBFactory::injectObjectCaches [core] - 10https://gerrit.wikimedia.org/r/533138 (https://phabricator.wikimedia.org/T227838) (owner: 10Aaron Schulz) [17:15:49] (03PS1) 10Yaron Koren: Change structure of allowedParameters() method [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/533273 [17:16:34] (03PS3) 10Krinkle: Remove $wgMemCachedDebug [core] - 10https://gerrit.wikimedia.org/r/533100 (owner: 10Aaron Schulz) [17:16:42] (03CR) 10Krinkle: [C: 03+2] Remove $wgMemCachedDebug [core] - 10https://gerrit.wikimedia.org/r/533100 (owner: 10Aaron Schulz) [17:17:29] (03CR) 10Krinkle: "flaky wdio test from Wikibase:" [core] - 10https://gerrit.wikimedia.org/r/530707 (owner: 10Aaron Schulz) [17:17:37] (03PS5) 10Krinkle: HashRing optimizations and PhpStorm warning work-arounds [core] - 10https://gerrit.wikimedia.org/r/530707 (owner: 10Aaron Schulz) [17:17:53] (03CR) 10Krinkle: [C: 03+2] HashRing optimizations and PhpStorm warning work-arounds [core] - 10https://gerrit.wikimedia.org/r/530707 (owner: 10Aaron Schulz) [17:18:18] (03PS3) 10Daniel Kinzler: Restore the old behavior of Title::getTalkPage() [core] - 10https://gerrit.wikimedia.org/r/533208 (https://phabricator.wikimedia.org/T227817) [17:20:13] (03CR) 10Bartosz Dziewoński: "> Should we move sig-text to WikiEditor's repo (and rename it)?" [core] - 10https://gerrit.wikimedia.org/r/532965 (https://phabricator.wikimedia.org/T224429) (owner: 10Bartosz Dziewoński) [17:20:47] (03CR) 10Daniel Kinzler: Restore the old behavior of Title::getTalkPage() (032 comments) [core] - 10https://gerrit.wikimedia.org/r/533208 (https://phabricator.wikimedia.org/T227817) (owner: 10Daniel Kinzler) [17:22:52] (03Merged) 10jenkins-bot: Dev: Register WikibaseClient as an extension dependency [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533217 (owner: 10Mholloway) [17:22:54] (03Merged) 10jenkins-bot: Persist the uploader ID in machine_vision_label [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533095 (https://phabricator.wikimedia.org/T231104) (owner: 10Mholloway) [17:22:58] (03Merged) 10jenkins-bot: Allow filtering suggestions for review by uploader [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533096 (https://phabricator.wikimedia.org/T231104) (owner: 10Mholloway) [17:23:00] (03Merged) 10jenkins-bot: Update review UI to use new unreviewed image labels API module [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533099 (https://phabricator.wikimedia.org/T231104) (owner: 10Mholloway) [17:23:08] (03PS4) 10Bartosz Dziewoński: Remove unused localisation messages for old edit toolbar [core] - 10https://gerrit.wikimedia.org/r/532965 (https://phabricator.wikimedia.org/T224429) [17:23:12] (03CR) 10Daniel Kinzler: Introduce BlobStore::getBlobBatch method (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532449 (https://phabricator.wikimedia.org/T230834) (owner: 10Ppchelko) [17:23:23] (03CR) 10Isarra: [C: 03+2] "Seems to work." [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533174 (owner: 10Fomafix) [17:23:31] (03CR) 10Isarra: [C: 03+2] "...I don't know js, okay?" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533174 (owner: 10Fomafix) [17:24:09] (03CR) 10Ppchelko: "A couple of things that were very obvious" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/533271 (https://phabricator.wikimedia.org/T229705) (owner: 10Daniel Kinzler) [17:25:29] (03CR) 10Tchanders: Pass the user and request into BlockManager::getUserBlock (031 comment) [core] - 10https://gerrit.wikimedia.org/r/531946 (https://phabricator.wikimedia.org/T230363) (owner: 10Tchanders) [17:30:40] (03CR) 10simetrical: "There are really 1,179 failures in HHVM only for the one variable UseCirrus not being defined? In integration tests, which this patch shou" [core] - 10https://gerrit.wikimedia.org/r/533227 (owner: 10simetrical) [17:30:42] (03CR) 10jerkins-bot: [V: 04-1] Move some TableOfContents styles from Minerva to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533070 (owner: 10Jdlrobson) [17:31:33] (03CR) 10Isarra: [C: 04-2] "Uh, I need to retest, actually..." [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533174 (owner: 10Fomafix) [17:31:40] (03PS5) 10Jdlrobson: Move some TableOfContents styles from Minerva to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533070 [17:33:49] (03PS27) 10Daimona Eaytoy: [WIP] Add a maintenance script to clean afl_var_dump [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482499 (https://phabricator.wikimedia.org/T213006) [17:33:51] (03Merged) 10jenkins-bot: Hygiene: Remove SpecialImageLabeling [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533101 (owner: 10Mholloway) [17:34:06] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add a maintenance script to clean afl_var_dump [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482499 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [17:34:11] (03PS1) 10Mholloway: [DO NOT MERGE] Test CI dependecies [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533277 [17:34:14] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add a maintenance script to clean afl_var_dump [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482499 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [17:35:08] (03CR) 10Krinkle: Make max-age configurable for logged-out users (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532378 (https://phabricator.wikimedia.org/T231184) (owner: 10Gilles) [17:35:10] (03PS28) 10Daimona Eaytoy: [WIP] Add a maintenance script to clean afl_var_dump [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482499 (https://phabricator.wikimedia.org/T213006) [17:35:18] (03CR) 10jerkins-bot: [V: 04-1] Title: make newFromText, isValid, and canExist behave consistently. [core] - 10https://gerrit.wikimedia.org/r/533271 (https://phabricator.wikimedia.org/T229705) (owner: 10Daniel Kinzler) [17:37:07] (03PS2) 10Krinkle: filerepo: rename resolveToStoragePath() and tweak file operation arrays [core] - 10https://gerrit.wikimedia.org/r/532095 (owner: 10Aaron Schulz) [17:37:10] (03CR) 10Krinkle: [C: 03+2] filerepo: rename resolveToStoragePath() and tweak file operation arrays [core] - 10https://gerrit.wikimedia.org/r/532095 (owner: 10Aaron Schulz) [17:37:24] (03CR) 10Daniel Kinzler: [C: 03+2] createNoOpMock() method for PHPUnit tests [core] - 10https://gerrit.wikimedia.org/r/532982 (owner: 10simetrical) [17:38:20] (03CR) 10Krinkle: [C: 03+2] Make JobExecutor transaction use better match JobRunner [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/527629 (owner: 10Aaron Schulz) [17:38:46] (03PS2) 10Yaron Koren: Change structure of allowedParameters() method [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/533273 [17:39:21] (03PS21) 10Daimona Eaytoy: Add updateVarDumps to update.php and handle new code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482500 (https://phabricator.wikimedia.org/T213006) [17:39:27] (03CR) 10Daniel Kinzler: [C: 03+2] Cache nonexistence of grammar transformations [core] - 10https://gerrit.wikimedia.org/r/532241 (owner: 10simetrical) [17:41:24] (03CR) 10Isarra: [C: 03+2] "Okay, issue isn't here..." [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533174 (owner: 10Fomafix) [17:41:46] (03PS19) 10Daimona Eaytoy: Change afl_var_dump to be a foreign key to text.old_id [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482513 (https://phabricator.wikimedia.org/T213006) [17:42:06] (03CR) 10Bartosz Dziewoński: Special:Log: Convert to HTMLForm (031 comment) [core] - 10https://gerrit.wikimedia.org/r/428871 (https://phabricator.wikimedia.org/T117737) (owner: 10Prtksxna) [17:43:45] (03CR) 10Bartosz Dziewoński: "LogEventsList::getDefaultQuery() can be removed, that form no longer generates any links that would need the query parameters." [core] - 10https://gerrit.wikimedia.org/r/533196 (owner: 10D3r1ck01) [17:45:19] (03PS3) 10Pwirth: Init commit [extensions/BlueSpiceSocialComments] - 10https://gerrit.wikimedia.org/r/533062 [17:45:30] (03CR) 10Pwirth: Init commit (031 comment) [extensions/BlueSpiceSocialComments] - 10https://gerrit.wikimedia.org/r/533062 (owner: 10Pwirth) [17:45:53] (03CR) 10D3r1ck01: "> LogEventsList::getDefaultQuery() can be removed, that form no longer generates any links that would need the query parameters." [core] - 10https://gerrit.wikimedia.org/r/533196 (owner: 10D3r1ck01) [17:46:23] (03PS18) 10Daimona Eaytoy: Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006) [17:46:27] (03PS4) 10Pwirth: Init commit [extensions/BlueSpiceSocialComments] - 10https://gerrit.wikimedia.org/r/533062 [17:46:52] (03PS2) 10Krinkle: mime,logging: Remove unused private methods [core] - 10https://gerrit.wikimedia.org/r/533196 (owner: 10D3r1ck01) [17:46:54] (03CR) 10Krinkle: [C: 03+2] "Thanks." [core] - 10https://gerrit.wikimedia.org/r/533196 (owner: 10D3r1ck01) [17:46:56] (03CR) 10Daimona Eaytoy: [C: 04-2] Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [17:47:23] (03CR) 10Krinkle: [C: 03+2] "Aye, yeah, that's a tricky one. It's also something we can't hard-deprecate. But yeah, adding @deprecated there and removing next release " [core] - 10https://gerrit.wikimedia.org/r/533196 (owner: 10D3r1ck01) [17:48:10] (03CR) 10Krinkle: [C: 03+2] Make AbuseFilterVariableHolder::$mVars public again [extensions/AbuseFilter] (wmf/1.34.0-wmf.20) - 10https://gerrit.wikimedia.org/r/533267 (https://phabricator.wikimedia.org/T231542) (owner: 10Daimona Eaytoy) [17:48:19] (03CR) 10Krinkle: [C: 03+2] Fix "Uncaught TypeError: abortable.abort is not a function" [extensions/CentralAuth] (wmf/1.34.0-wmf.20) - 10https://gerrit.wikimedia.org/r/533218 (owner: 10Krinkle) [17:49:40] (03PS14) 10Ppchelko: Introduce BlobStore::getBlobBatch method [core] - 10https://gerrit.wikimedia.org/r/532449 (https://phabricator.wikimedia.org/T230834) [17:49:49] (03CR) 10D3r1ck01: "> Aye, yeah, that's a tricky one. It's also something we can't hard-deprecate. But yeah, adding @deprecated there and removing next releas" [core] - 10https://gerrit.wikimedia.org/r/533196 (owner: 10D3r1ck01) [17:52:40] (03CR) 10Ppchelko: Introduce BlobStore::getBlobBatch method (032 comments) [core] - 10https://gerrit.wikimedia.org/r/532449 (https://phabricator.wikimedia.org/T230834) (owner: 10Ppchelko) [17:53:32] (03Merged) 10jenkins-bot: Make AbuseFilterVariableHolder::$mVars public again [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533266 (https://phabricator.wikimedia.org/T231542) (owner: 10Daimona Eaytoy) [17:54:14] (03CR) 10Ppchelko: "@Daniel could you re+2 it? Is it acceptable if in a case like this (rebase, failed gate-and-submit, more trivial rebase) I self+2 changes?" [core] - 10https://gerrit.wikimedia.org/r/532486 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [17:55:37] (03Merged) 10jenkins-bot: Make ObjectCache check the value of apc.enable_cli in CLI mode [core] - 10https://gerrit.wikimedia.org/r/533032 (https://phabricator.wikimedia.org/T227838) (owner: 10Aaron Schulz) [17:55:43] (03Merged) 10jenkins-bot: filebackend: add idiom constant to FileBackend for null results [core] - 10https://gerrit.wikimedia.org/r/533162 (owner: 10Aaron Schulz) [17:57:21] (03CR) 10Krinkle: Globally unsuppress phan issues with low count (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533177 (owner: 10Daimona Eaytoy) [17:57:37] (03PS1) 10Jforrester: Revert "Dev: Register WikibaseClient as an extension dependency" [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533278 [17:57:42] (03CR) 10Jforrester: [C: 03+2] Revert "Dev: Register WikibaseClient as an extension dependency" [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533278 (owner: 10Jforrester) [17:58:02] (03CR) 10Daimona Eaytoy: Globally unsuppress phan issues with low count (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533177 (owner: 10Daimona Eaytoy) [17:58:13] (03CR) 10Krinkle: Globally unsuppress phan issues with low count (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533177 (owner: 10Daimona Eaytoy) [17:59:43] (03CR) 10Krinkle: Unsuppress other phan issues with low count (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533206 (owner: 10Daimona Eaytoy) [18:00:05] (03PS3) 10Daimona Eaytoy: Globally unsuppress phan issues with low count [core] - 10https://gerrit.wikimedia.org/r/533177 [18:00:56] (03PS1) 10Isarra: Fix close behaviour on click-toggle dropdowns [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533279 [18:01:12] (03PS1) 10Daniel Kinzler: ContribsPage: bring back getContribs() method (UBN) [core] - 10https://gerrit.wikimedia.org/r/533280 (https://phabricator.wikimedia.org/T231540) [18:01:53] (03PS2) 10Daniel Kinzler: ContribsPage: bring back getContribs() method (UBN) [core] - 10https://gerrit.wikimedia.org/r/533280 (https://phabricator.wikimedia.org/T231540) [18:02:04] (03CR) 10Ppchelko: Title: make newFromText, isValid, and canExist behave consistently. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533271 (https://phabricator.wikimedia.org/T229705) (owner: 10Daniel Kinzler) [18:02:19] (03Merged) 10jenkins-bot: filebackend: fix @throws comment in FileBackend::makeContentDisposition() [core] - 10https://gerrit.wikimedia.org/r/533145 (owner: 10Aaron Schulz) [18:02:30] (03PS1) 10Isarra: Align echo new messages yellow thing [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533281 [18:04:25] (03CR) 10D3r1ck01: [C: 03+1] "Yes, Flow and ArticleFeedbackv5 still call this method: https://codesearch.wmflabs.org/search/?q=getContribs&i=nope&files=&repos=." [core] - 10https://gerrit.wikimedia.org/r/533280 (https://phabricator.wikimedia.org/T231540) (owner: 10Daniel Kinzler) [18:05:09] (03PS1) 10Ppchelko: WIP: Rework ApiUploadTest [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T231488) [18:06:26] (03Merged) 10jenkins-bot: Remove $wgMemCachedDebug [core] - 10https://gerrit.wikimedia.org/r/533100 (owner: 10Aaron Schulz) [18:06:32] (03Merged) 10jenkins-bot: HashRing optimizations and PhpStorm warning work-arounds [core] - 10https://gerrit.wikimedia.org/r/530707 (owner: 10Aaron Schulz) [18:06:35] (03Merged) 10jenkins-bot: Simplify JavaScript code [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533174 (owner: 10Fomafix) [18:06:56] (03CR) 10DannyS712: [C: 03+1] "Looks good to me" [core] - 10https://gerrit.wikimedia.org/r/533280 (https://phabricator.wikimedia.org/T231540) (owner: 10Daniel Kinzler) [18:07:11] (03CR) 10Tchanders: "I added a comment to the patch about whether to do this - interested to hear more about the cleaner approach using the BlockStore" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/529965 (owner: 10Dmaza) [18:08:29] (03CR) 10Ppchelko: "This doesn't work yet, thus WIP." [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T231488) (owner: 10Ppchelko) [18:10:11] (03PS1) 10DCausse: [mediainfo] Always enable WBCS [vagrant] - 10https://gerrit.wikimedia.org/r/533285 (https://phabricator.wikimedia.org/T230018) [18:10:12] (03CR) 10Mholloway: "How are you triggering this? I can only trigger one fatal error on beta, and it looks unrelated:" [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533278 (owner: 10Jforrester) [18:11:37] (03CR) 10Daimona Eaytoy: Unsuppress other phan issues with low count (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533206 (owner: 10Daimona Eaytoy) [18:12:08] (03Merged) 10jenkins-bot: filerepo: rename resolveToStoragePath() and tweak file operation arrays [core] - 10https://gerrit.wikimedia.org/r/532095 (owner: 10Aaron Schulz) [18:13:19] (03CR) 10Jforrester: [C: 03+2] "> Patch Set 1:" [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533278 (owner: 10Jforrester) [18:15:08] (03Abandoned) 10Mholloway: [DO NOT MERGE] Test CI dependecies [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533277 (owner: 10Mholloway) [18:16:44] (03Merged) 10jenkins-bot: createNoOpMock() method for PHPUnit tests [core] - 10https://gerrit.wikimedia.org/r/532982 (owner: 10simetrical) [18:17:03] (03CR) 10Clarakosi: Modify -—with-extensions to throw extension dependency errors (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533239 (https://phabricator.wikimedia.org/T225512) (owner: 10Clarakosi) [18:17:56] (03CR) 10Nray: [C: 03+2] Fix failing qunit test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533251 (owner: 10Jdlrobson) [18:18:15] (03Merged) 10jenkins-bot: Integration tests for Language fallback methods [core] - 10https://gerrit.wikimedia.org/r/532231 (owner: 10simetrical) [18:18:17] (03Merged) 10jenkins-bot: Make JobExecutor transaction use better match JobRunner [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/527629 (owner: 10Aaron Schulz) [18:18:19] (03PS3) 10Yaron Koren: Change structure of allowedParameters() method [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/533273 [18:18:31] (03CR) 10Jack Phoenix: [C: 03+2] Fix close behaviour on click-toggle dropdowns [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533279 (owner: 10Isarra) [18:19:03] (03Merged) 10jenkins-bot: Make AbuseFilterVariableHolder::$mVars public again [extensions/AbuseFilter] (wmf/1.34.0-wmf.20) - 10https://gerrit.wikimedia.org/r/533267 (https://phabricator.wikimedia.org/T231542) (owner: 10Daimona Eaytoy) [18:19:08] (03Merged) 10jenkins-bot: Fix "Uncaught TypeError: abortable.abort is not a function" [extensions/CentralAuth] (wmf/1.34.0-wmf.20) - 10https://gerrit.wikimedia.org/r/533218 (owner: 10Krinkle) [18:20:34] (03CR) 10Mholloway: "OK. My best theory about wybe the MachineVision tests are still happy, then, is that there are no Wikibase deps in the classes under test." [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533278 (owner: 10Jforrester) [18:21:10] (03CR) 10Jforrester: [C: 03+2] "> Patch Set 1:" [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533278 (owner: 10Jforrester) [18:26:29] (03CR) 10Dbarratt: [C: 04-1] Pass the user and request into BlockManager::getUserBlock (031 comment) [core] - 10https://gerrit.wikimedia.org/r/531946 (https://phabricator.wikimedia.org/T230363) (owner: 10Tchanders) [18:27:15] (03Merged) 10jenkins-bot: mime,logging: Remove unused private methods [core] - 10https://gerrit.wikimedia.org/r/533196 (owner: 10D3r1ck01) [18:27:17] (03CR) 10jerkins-bot: [V: 04-1] Revert "Dev: Register WikibaseClient as an extension dependency" [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533278 (owner: 10Jforrester) [18:27:22] (03CR) 10jerkins-bot: [V: 04-1] Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [18:28:22] (03CR) 10MusikAnimal: [C: 04-1] "> I'm not sure if anyone else is seeing it, but the filter popup panel is getting a bit long and gets cut off on my screen; even without t" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/533119 (https://phabricator.wikimedia.org/T167475) (owner: 10HMonroy) [18:30:04] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add a maintenance script to clean afl_var_dump [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482499 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [18:30:11] (03CR) 10Nikerabbit: "There is no process for doing language renames. Imho it doesn't even make sense to start this process before there is a plan and commitmen" [core] - 10https://gerrit.wikimedia.org/r/467770 (https://phabricator.wikimedia.org/T117845) (owner: 10Fomafix) [18:30:37] (03CR) 10jerkins-bot: [V: 04-1] Change afl_var_dump to be a foreign key to text.old_id [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482513 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [18:31:41] (03CR) 10Raimond Spekking: [C: 03+1] "i18n review" [extensions/BlueSpiceSocialComments] - 10https://gerrit.wikimedia.org/r/533062 (owner: 10Pwirth) [18:32:15] (03CR) 10jerkins-bot: [V: 04-1] Revert "Dev: Register WikibaseClient as an extension dependency" [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533278 (owner: 10Jforrester) [18:33:03] (03CR) 10Mholloway: [C: 03+2] Revert "Dev: Register WikibaseClient as an extension dependency" [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533278 (owner: 10Jforrester) [18:35:37] (03CR) 10jerkins-bot: [V: 04-1] Change structure of allowedParameters() method [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/533273 (owner: 10Yaron Koren) [18:37:19] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add a maintenance script to clean afl_var_dump [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482499 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [18:37:42] (03CR) 10jerkins-bot: [V: 04-1] Change afl_var_dump to be a foreign key to text.old_id [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482513 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [18:38:09] (03CR) 10jenkins-bot: mime,logging: Remove unused private methods [core] - 10https://gerrit.wikimedia.org/r/533196 (owner: 10D3r1ck01) [18:38:11] (03CR) 10jerkins-bot: [V: 04-1] Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [18:38:52] (03CR) 10jenkins-bot: filerepo: rename resolveToStoragePath() and tweak file operation arrays [core] - 10https://gerrit.wikimedia.org/r/532095 (owner: 10Aaron Schulz) [18:39:36] (03PS1) 10Niedzielski: [toolbar] show page action labels on wide screens [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533293 (https://phabricator.wikimedia.org/T226562) [18:40:10] (03CR) 10Dbarratt: [C: 04-1] Pass the user and request into BlockManager::getUserBlock (031 comment) [core] - 10https://gerrit.wikimedia.org/r/531946 (https://phabricator.wikimedia.org/T230363) (owner: 10Tchanders) [18:40:49] (03CR) 10jenkins-bot: mime,logging: Remove unused private methods [core] - 10https://gerrit.wikimedia.org/r/533196 (owner: 10D3r1ck01) [18:43:45] (03PS1) 10Niedzielski: [toolbar] [watchstar] use terser labels [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533296 (https://phabricator.wikimedia.org/T226562) [18:44:51] (03CR) 10jenkins-bot: filerepo: rename resolveToStoragePath() and tweak file operation arrays [core] - 10https://gerrit.wikimedia.org/r/532095 (owner: 10Aaron Schulz) [18:45:40] (03PS4) 10Yaron Koren: Change structure of allowedParameters() method [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/533273 [18:45:44] (03CR) 10Isarra: "So I guess the question is, should we just duplicate the icons in ProofreadPage and do them via css that way? Because that's kind of what " [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533122 (https://phabricator.wikimedia.org/T231250) (owner: 10Isarra) [18:46:04] (03CR) 10jerkins-bot: [V: 04-1] ContribsPage: bring back getContribs() method (UBN) [core] - 10https://gerrit.wikimedia.org/r/533280 (https://phabricator.wikimedia.org/T231540) (owner: 10Daniel Kinzler) [18:46:06] (03PS4) 10Ppchelko: Remove usages of Title::quickUserCan [core] - 10https://gerrit.wikimedia.org/r/531988 [18:46:32] (03CR) 10Ppchelko: "Done. We have PermissionManager::quickUserCan now and it's used everywhere." [core] - 10https://gerrit.wikimedia.org/r/531988 (owner: 10Ppchelko) [18:46:51] (03CR) 10jerkins-bot: [V: 04-1] Remove usages of Title::quickUserCan [core] - 10https://gerrit.wikimedia.org/r/531988 (owner: 10Ppchelko) [18:47:51] (03CR) 10jerkins-bot: [V: 04-1] Remove usages of Title::quickUserCan [core] - 10https://gerrit.wikimedia.org/r/531988 (owner: 10Ppchelko) [18:48:02] (03Merged) 10jenkins-bot: Fix failing qunit test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533251 (owner: 10Jdlrobson) [18:48:04] (03Merged) 10jenkins-bot: Fix close behaviour on click-toggle dropdowns [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533279 (owner: 10Isarra) [18:48:08] (03CR) 10jerkins-bot: [V: 04-1] Revert "Dev: Register WikibaseClient as an extension dependency" [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533278 (owner: 10Jforrester) [18:48:10] (03CR) 10jerkins-bot: [V: 04-1] Remove usages of Title::quickUserCan [core] - 10https://gerrit.wikimedia.org/r/531988 (owner: 10Ppchelko) [18:48:14] (03CR) 10jerkins-bot: [V: 04-1] Remove usages of Title::quickUserCan [core] - 10https://gerrit.wikimedia.org/r/531988 (owner: 10Ppchelko) [18:48:16] (03CR) 10jerkins-bot: [V: 04-1] Add updateVarDumps to update.php and handle new code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482500 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [18:48:18] (03PS3) 10simetrical: Unset globals correctly for unit tests [core] - 10https://gerrit.wikimedia.org/r/533227 [18:50:12] (03PS5) 10Ppchelko: Remove usages of Title::quickUserCan [core] - 10https://gerrit.wikimedia.org/r/531988 [18:50:34] (03CR) 10Ppchelko: "PS5 is a manual rebase" [core] - 10https://gerrit.wikimedia.org/r/531988 (owner: 10Ppchelko) [18:53:14] (03CR) 10jenkins-bot: Make ObjectCache check the value of apc.enable_cli in CLI mode [core] - 10https://gerrit.wikimedia.org/r/533032 (https://phabricator.wikimedia.org/T227838) (owner: 10Aaron Schulz) [18:53:30] (03CR) 10jerkins-bot: [V: 04-1] Unset globals correctly for unit tests [core] - 10https://gerrit.wikimedia.org/r/533227 (owner: 10simetrical) [18:53:32] (03CR) 10jerkins-bot: [V: 04-1] Add updateVarDumps to update.php and handle new code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482500 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [18:53:57] (03CR) 10jenkins-bot: filerepo: rename resolveToStoragePath() and tweak file operation arrays [core] - 10https://gerrit.wikimedia.org/r/532095 (owner: 10Aaron Schulz) [18:54:18] (03CR) 10Yaron Koren: [C: 03+2] Change structure of allowedParameters() method [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/533273 (owner: 10Yaron Koren) [18:56:48] (03CR) 10Raimond Spekking: [C: 03+2] Add Serbian aliases [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/509744 (https://phabricator.wikimedia.org/T212586) (owner: 10Petar.petkovic) [18:56:50] (03PS29) 10Daimona Eaytoy: [WIP] Add a maintenance script to clean afl_var_dump [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482499 (https://phabricator.wikimedia.org/T213006) [18:56:55] (03PS22) 10Daimona Eaytoy: Add updateVarDumps to update.php and handle new code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482500 (https://phabricator.wikimedia.org/T213006) [18:57:00] (03CR) 10jenkins-bot: mime,logging: Remove unused private methods [core] - 10https://gerrit.wikimedia.org/r/533196 (owner: 10D3r1ck01) [18:57:02] (03PS20) 10Daimona Eaytoy: Change afl_var_dump to be a foreign key to text.old_id [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482513 (https://phabricator.wikimedia.org/T213006) [18:57:07] (03PS19) 10Daimona Eaytoy: Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006) [18:57:12] (03CR) 10jerkins-bot: [V: 04-1] WIP: Rework ApiUploadTest [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T231488) (owner: 10Ppchelko) [18:57:25] (03CR) 10Fomafix: Skin: Initialize LinkRenderer in construtor (031 comment) [core] - 10https://gerrit.wikimedia.org/r/509625 (owner: 10Fomafix) [18:57:27] (03PS20) 10Daimona Eaytoy: Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006) [18:57:39] (03CR) 10jerkins-bot: [V: 04-1] ContribsPage: bring back getContribs() method (UBN) [core] - 10https://gerrit.wikimedia.org/r/533280 (https://phabricator.wikimedia.org/T231540) (owner: 10Daniel Kinzler) [18:57:48] (03PS6) 10Fomafix: Skin: Initialize LinkRenderer in construtor [core] - 10https://gerrit.wikimedia.org/r/509625 [18:58:33] (03CR) 10Krinkle: Skin: Initialize LinkRenderer in construtor (031 comment) [core] - 10https://gerrit.wikimedia.org/r/509625 (owner: 10Fomafix) [18:58:41] (03CR) 10Daniel Kinzler: "recheck" [core] - 10https://gerrit.wikimedia.org/r/533280 (https://phabricator.wikimedia.org/T231540) (owner: 10Daniel Kinzler) [18:58:56] (03Merged) 10jenkins-bot: Change structure of allowedParameters() method [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/533273 (owner: 10Yaron Koren) [18:58:58] (03CR) 10jerkins-bot: [V: 04-1] WIP: Rework ApiUploadTest [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T231488) (owner: 10Ppchelko) [18:59:41] (03CR) 10Jdlrobson: "I'm not sure how this works with https://gerrit.wikimedia.org/r/531558 but should probably be based on that patch, as we'll have a better " [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533293 (https://phabricator.wikimedia.org/T226562) (owner: 10Niedzielski) [19:00:56] (03CR) 10Krinkle: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase (031 comment) [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [19:01:38] (03Merged) 10jenkins-bot: Add Serbian aliases [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/509744 (https://phabricator.wikimedia.org/T212586) (owner: 10Petar.petkovic) [19:03:49] (03CR) 10jerkins-bot: [V: 04-1] Change afl_var_dump to be a foreign key to text.old_id [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482513 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [19:05:37] (03CR) 10jerkins-bot: [V: 04-1] Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [19:07:06] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/533295 (owner: 10L10n-bot) [19:08:32] (03CR) 10jerkins-bot: [V: 04-1] Unset globals correctly for unit tests [core] - 10https://gerrit.wikimedia.org/r/533227 (owner: 10simetrical) [19:08:38] (03CR) 10jenkins-bot: Change structure of allowedParameters() method [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/533273 (owner: 10Yaron Koren) [19:08:45] (03CR) 10Krinkle: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase (031 comment) [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [19:10:10] (03CR) 10jerkins-bot: [V: 04-1] Unset globals correctly for unit tests [core] - 10https://gerrit.wikimedia.org/r/533227 (owner: 10simetrical) [19:10:53] (03CR) 10jenkins-bot: filebackend: add idiom constant to FileBackend for null results [core] - 10https://gerrit.wikimedia.org/r/533162 (owner: 10Aaron Schulz) [19:13:31] (03CR) 10Fomafix: [C: 04-1] "Skins that not call the parent constructor will break with this change." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/509625 (owner: 10Fomafix) [19:14:27] (03PS7) 10Fomafix: Skin: Initialize LinkRenderer in construtor [core] - 10https://gerrit.wikimedia.org/r/509625 [19:16:15] (03CR) 10Krinkle: "flaky wdio test from Wikibase - third time I see it today:" [core] - 10https://gerrit.wikimedia.org/r/533280 (https://phabricator.wikimedia.org/T231540) (owner: 10Daniel Kinzler) [19:16:50] (03CR) 10Niedzielski: [C: 04-1] Use mw-node-qunit@6.0.0 (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521303 (owner: 10Jdlrobson) [19:16:52] (03CR) 10Pwirth: [C: 03+2] Init commit [extensions/BlueSpiceSocialComments] - 10https://gerrit.wikimedia.org/r/533062 (owner: 10Pwirth) [19:16:55] (03PS3) 10Krinkle: ContribsPage: bring back getContribs() method [core] - 10https://gerrit.wikimedia.org/r/533280 (https://phabricator.wikimedia.org/T231540) (owner: 10Daniel Kinzler) [19:17:00] (03CR) 10Krinkle: [C: 03+2] ContribsPage: bring back getContribs() method [core] - 10https://gerrit.wikimedia.org/r/533280 (https://phabricator.wikimedia.org/T231540) (owner: 10Daniel Kinzler) [19:19:35] (03CR) 10Jforrester: [C: 03+2] "…" [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533278 (owner: 10Jforrester) [19:22:12] (03CR) 10jerkins-bot: [V: 04-1] Unset globals correctly for unit tests [core] - 10https://gerrit.wikimedia.org/r/533227 (owner: 10simetrical) [19:23:20] (03CR) 10jerkins-bot: [V: 04-1] Add updateVarDumps to update.php and handle new code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482500 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [19:24:13] (03CR) 10Jforrester: [C: 03+2] "Eurgh, how did I not find these hits in my search?" [core] - 10https://gerrit.wikimedia.org/r/533280 (https://phabricator.wikimedia.org/T231540) (owner: 10Daniel Kinzler) [19:24:28] (03Merged) 10jenkins-bot: Init commit [extensions/BlueSpiceSocialComments] - 10https://gerrit.wikimedia.org/r/533062 (owner: 10Pwirth) [19:24:45] (03CR) 10Aaron Schulz: filebackend: make FileBackend consistencyCheck() and resyncFiles() more robust (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533143 (https://phabricator.wikimedia.org/T231086) (owner: 10Aaron Schulz) [19:26:06] (03CR) 10jenkins-bot: filebackend: fix @throws comment in FileBackend::makeContentDisposition() [core] - 10https://gerrit.wikimedia.org/r/533145 (owner: 10Aaron Schulz) [19:26:47] (03PS1) 10Jforrester: ContributionsQuery: Drop 'newbies' feature support, killed in core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533306 [19:27:03] (03PS3) 10Ejegg: Use pip3 to install fundraising tools. Bug: T197805 [vagrant] - 10https://gerrit.wikimedia.org/r/531669 (https://phabricator.wikimedia.org/T197805) (owner: 10Jgleeson) [19:27:05] (03PS2) 10Jforrester: ContributionsQuery: Drop 'newbies' feature support, killed in core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533306 (https://phabricator.wikimedia.org/T231540) [19:27:10] (03CR) 10Ejegg: [C: 03+2] "Thanks!" [vagrant] - 10https://gerrit.wikimedia.org/r/531669 (https://phabricator.wikimedia.org/T197805) (owner: 10Jgleeson) [19:28:12] (03CR) 10D3r1ck01: [C: 03+1] "> flaky wdio test from Wikibase - third time I see it today:" [core] - 10https://gerrit.wikimedia.org/r/533280 (https://phabricator.wikimedia.org/T231540) (owner: 10Daniel Kinzler) [19:28:21] (03Merged) 10jenkins-bot: Use pip3 to install fundraising tools. Bug: T197805 [vagrant] - 10https://gerrit.wikimedia.org/r/531669 (https://phabricator.wikimedia.org/T197805) (owner: 10Jgleeson) [19:33:19] (03PS7) 10Ejegg: Fundraising role CiviCRM unit test fixes [vagrant] - 10https://gerrit.wikimedia.org/r/531961 (https://phabricator.wikimedia.org/T220411) (owner: 10Jgleeson) [19:33:24] (03CR) 10Ejegg: [C: 03+2] Fundraising role CiviCRM unit test fixes [vagrant] - 10https://gerrit.wikimedia.org/r/531961 (https://phabricator.wikimedia.org/T220411) (owner: 10Jgleeson) [19:34:44] (03Merged) 10jenkins-bot: Fundraising role CiviCRM unit test fixes [vagrant] - 10https://gerrit.wikimedia.org/r/531961 (https://phabricator.wikimedia.org/T220411) (owner: 10Jgleeson) [19:36:50] (03CR) 10jerkins-bot: [V: 04-1] ContributionsQuery: Drop 'newbies' feature support, killed in core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533306 (https://phabricator.wikimedia.org/T231540) (owner: 10Jforrester) [19:37:34] (03CR) 10Jforrester: [V: 03+2 C: 03+2] "Landing this over jenkins's objections to unbreak the Beta Cluster." [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533278 (owner: 10Jforrester) [19:37:56] (03PS26) 10Jdlrobson: Use mw-node-qunit@6.0.0 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521303 [19:38:02] (03CR) 10Jdlrobson: Use mw-node-qunit@6.0.0 (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521303 (owner: 10Jdlrobson) [19:38:56] (03PS6) 10Nray: [edit] [UI] hide edit section links for blocked users [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/532794 (https://phabricator.wikimedia.org/T206265) (owner: 10Niedzielski) [19:38:58] (03PS4) 10Nray: [dev] [edit] rename EDIT permission to CONTENT_EDIT [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533230 (owner: 10Niedzielski) [19:39:00] (03PS2) 10Nray: [icon] [toolbar] update page info icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533237 (https://phabricator.wikimedia.org/T230693) (owner: 10Niedzielski) [19:39:07] (03CR) 10jerkins-bot: [V: 04-1] Change afl_var_dump to be a foreign key to text.old_id [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482513 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [19:39:24] (03CR) 10jerkins-bot: [V: 04-1] Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [19:41:26] (03CR) 10jenkins-bot: Remove $wgMemCachedDebug [core] - 10https://gerrit.wikimedia.org/r/533100 (owner: 10Aaron Schulz) [19:42:15] (03CR) 10Jdlrobson: [C: 03+2] [icon] [toolbar] update page info icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533237 (https://phabricator.wikimedia.org/T230693) (owner: 10Niedzielski) [19:42:49] (03PS3) 10Jforrester: ContributionsQuery: Drop 'newbies' feature support, killed in core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/533306 (https://phabricator.wikimedia.org/T231540) [19:42:51] (03Merged) 10jenkins-bot: ContribsPage: bring back getContribs() method [core] - 10https://gerrit.wikimedia.org/r/533280 (https://phabricator.wikimedia.org/T231540) (owner: 10Daniel Kinzler) [19:43:29] (03CR) 10jenkins-bot: Make AbuseFilterVariableHolder::$mVars public again [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/533266 (https://phabricator.wikimedia.org/T231542) (owner: 10Daimona Eaytoy) [19:43:32] (03Abandoned) 10Jdlrobson: Load mediawiki.ui.button in JavaScript [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/444276 (https://phabricator.wikimedia.org/T193821) (owner: 10Jdlrobson) [19:43:37] (03CR) 10Daniel Kinzler: Title: make newFromText, isValid, and canExist behave consistently. (033 comments) [core] - 10https://gerrit.wikimedia.org/r/533271 (https://phabricator.wikimedia.org/T229705) (owner: 10Daniel Kinzler) [19:46:03] (03PS9) 10Jdlrobson: Change the default behaviour for mw-ui-icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531558 (https://phabricator.wikimedia.org/T229447) [19:46:56] (03CR) 10Jdlrobson: [C: 04-1] [toolbar] show page action labels on wide screens (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533293 (https://phabricator.wikimedia.org/T226562) (owner: 10Niedzielski) [19:47:29] (03CR) 10Jdlrobson: [C: 03+1] [dev] [edit] rename EDIT permission to CONTENT_EDIT [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533230 (owner: 10Niedzielski) [19:48:51] (03CR) 10Jdlrobson: [edit] [UI] hide edit section links for blocked users (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/532794 (https://phabricator.wikimedia.org/T206265) (owner: 10Niedzielski) [19:49:40] (03CR) 10jerkins-bot: [V: 04-1] Skin: Initialize LinkRenderer in construtor [core] - 10https://gerrit.wikimedia.org/r/509625 (owner: 10Fomafix) [19:50:44] (03CR) 10Jdlrobson: [C: 03+2] [toolbar] [watchstar] use terser labels [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533296 (https://phabricator.wikimedia.org/T226562) (owner: 10Niedzielski) [19:50:48] (03CR) 10Kosta Harlan: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase (031 comment) [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [19:51:52] (03CR) 10jerkins-bot: [V: 04-1] Skin: Initialize LinkRenderer in construtor [core] - 10https://gerrit.wikimedia.org/r/509625 (owner: 10Fomafix) [19:53:10] (03PS41) 10Jdlrobson: Document all our components in storybook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 (https://phabricator.wikimedia.org/T231489) [19:53:17] (03CR) 10jerkins-bot: [V: 04-1] Add updateVarDumps to update.php and handle new code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482500 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [19:53:39] (03PS1) 10Fomafix: Apply coding conventions for JavaScript [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/533312 [19:55:06] (03PS3) 10Jdlrobson: Remove icon hacks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533111 (https://phabricator.wikimedia.org/T229447) [19:55:36] (03CR) 10Ppchelko: Title: make newFromText, isValid, and canExist behave consistently. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/533271 (https://phabricator.wikimedia.org/T229705) (owner: 10Daniel Kinzler) [19:57:47] (03CR) 10Ppchelko: "I've made I923bf82d07db0efce1d0d14cf04e15bb58472f59 for reworking the test suite. It's still a WIP as I have some questions there.." [core] - 10https://gerrit.wikimedia.org/r/533080 (https://phabricator.wikimedia.org/T231488) (owner: 10Daniel Kinzler) [20:02:05] (03CR) 10jenkins-bot: HashRing optimizations and PhpStorm warning work-arounds [core] - 10https://gerrit.wikimedia.org/r/530707 (owner: 10Aaron Schulz) [20:05:13] (03CR) 10jerkins-bot: [V: 04-1] Change the default behaviour for mw-ui-icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531558 (https://phabricator.wikimedia.org/T229447) (owner: 10Jdlrobson) [20:05:38] (03PS1) 10Pwirth: Add phpcs [extensions/BlueSpiceSocialComments] - 10https://gerrit.wikimedia.org/r/533315 [20:05:54] (03CR) 10Niedzielski: [edit] [UI] hide edit section links for blocked users (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/532794 (https://phabricator.wikimedia.org/T206265) (owner: 10Niedzielski) [20:06:36] (03CR) 10jenkins-bot: ContribsPage: bring back getContribs() method [core] - 10https://gerrit.wikimedia.org/r/533280 (https://phabricator.wikimedia.org/T231540) (owner: 10Daniel Kinzler) [20:06:59] (03CR) 10jenkins-bot: ContribsPage: bring back getContribs() method [core] - 10https://gerrit.wikimedia.org/r/533280 (https://phabricator.wikimedia.org/T231540) (owner: 10Daniel Kinzler) [20:09:37] (03CR) 10jenkins-bot: Use pip3 to install fundraising tools. Bug: T197805 [vagrant] - 10https://gerrit.wikimedia.org/r/531669 (https://phabricator.wikimedia.org/T197805) (owner: 10Jgleeson) [20:09:42] (03CR) 10jenkins-bot: Make JobExecutor transaction use better match JobRunner [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/527629 (owner: 10Aaron Schulz) [20:10:24] (03PS1) 10DannyS712: Remove `newbie` feature, removed in core [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/533317 (https://phabricator.wikimedia.org/T220447) [20:10:44] (03CR) 10Niedzielski: [toolbar] show page action labels on wide screens (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533293 (https://phabricator.wikimedia.org/T226562) (owner: 10Niedzielski) [20:11:57] (03CR) 10Clarakosi: [C: 03+1] ApiQueryCategories: Supply limit for DB query [core] - 10https://gerrit.wikimedia.org/r/533092 (https://phabricator.wikimedia.org/T231462) (owner: 10Anomie) [20:12:20] (03CR) 10jenkins-bot: Fix "Uncaught TypeError: abortable.abort is not a function" [extensions/CentralAuth] (wmf/1.34.0-wmf.20) - 10https://gerrit.wikimedia.org/r/533218 (owner: 10Krinkle) [20:12:31] (03CR) 10jerkins-bot: [V: 04-1] Remove icon hacks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533111 (https://phabricator.wikimedia.org/T229447) (owner: 10Jdlrobson) [20:12:51] (03CR) 10jenkins-bot: Fundraising role CiviCRM unit test fixes [vagrant] - 10https://gerrit.wikimedia.org/r/531961 (https://phabricator.wikimedia.org/T220411) (owner: 10Jgleeson) [20:14:30] (03PS2) 10DannyS712: Remove `newbie` feature, removed in core [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/533317 (https://phabricator.wikimedia.org/T220447) [20:17:46] (03CR) 10jenkins-bot: filerepo: rename resolveToStoragePath() and tweak file operation arrays [core] - 10https://gerrit.wikimedia.org/r/532095 (owner: 10Aaron Schulz) [20:18:05] (03PS3) 10DannyS712: Remove `newbie` feature, removed in core [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/533317 (https://phabricator.wikimedia.org/T220447) [20:18:32] (03Merged) 10jenkins-bot: [toolbar] [watchstar] use terser labels [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533296 (https://phabricator.wikimedia.org/T226562) (owner: 10Niedzielski) [20:19:05] (03CR) 10jenkins-bot: Make AbuseFilterVariableHolder::$mVars public again [extensions/AbuseFilter] (wmf/1.34.0-wmf.20) - 10https://gerrit.wikimedia.org/r/533267 (https://phabricator.wikimedia.org/T231542) (owner: 10Daimona Eaytoy) [20:19:27] (03PS4) 10DannyS712: Remove `newbie` feature, removed in core [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/533317 (https://phabricator.wikimedia.org/T220447) [20:19:32] (03CR) 10jenkins-bot: ContribsPage: bring back getContribs() method [core] - 10https://gerrit.wikimedia.org/r/533280 (https://phabricator.wikimedia.org/T231540) (owner: 10Daniel Kinzler) [20:19:52] (03CR) 10Daniel Kinzler: Title: make newFromText, isValid, and canExist behave consistently. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533271 (https://phabricator.wikimedia.org/T229705) (owner: 10Daniel Kinzler) [20:22:19] (03PS1) 10DannyS712: Revert "ContribsPage: bring back getContribs() method" [core] - 10https://gerrit.wikimedia.org/r/533325 (https://phabricator.wikimedia.org/T220447) [20:22:53] (03CR) 10jenkins-bot: Change structure of allowedParameters() method [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/533273 (owner: 10Yaron Koren) [20:22:57] (03PS2) 10DannyS712: Revert "ContribsPage: bring back getContribs() method" [core] - 10https://gerrit.wikimedia.org/r/533325 (https://phabricator.wikimedia.org/T220447) [20:23:08] (03CR) 10Daniel Kinzler: "> 1. The tests currently are failing cause on next tests we're getting and API warning cause of a duplicate image or if we try to delete a" [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T231488) (owner: 10Ppchelko) [20:24:28] (03CR) 10D3r1ck01: Revert "ContribsPage: bring back getContribs() method" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533325 (https://phabricator.wikimedia.org/T220447) (owner: 10DannyS712) [20:25:56] (03CR) 10jenkins-bot: Fix failing qunit test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533251 (owner: 10Jdlrobson) [20:28:46] (03CR) 10jenkins-bot: [toolbar] [watchstar] use terser labels [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533296 (https://phabricator.wikimedia.org/T226562) (owner: 10Niedzielski) [20:29:25] (03CR) 10Krinkle: [C: 03+2] Remove `newbie` feature, removed in core [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/533317 (https://phabricator.wikimedia.org/T220447) (owner: 10DannyS712) [20:29:27] (03CR) 10Daniel Kinzler: [C: 03+2] Remove usages of Title::quickUserCan [core] - 10https://gerrit.wikimedia.org/r/531988 (owner: 10Ppchelko) [20:30:21] (03CR) 10Jdlrobson: [C: 04-1] [toolbar] show page action labels on wide screens (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533293 (https://phabricator.wikimedia.org/T226562) (owner: 10Niedzielski) [20:31:13] (03CR) 10Jforrester: [C: 03+1] Remove `newbie` feature, removed in core (031 comment) [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/533317 (https://phabricator.wikimedia.org/T220447) (owner: 10DannyS712) [20:31:15] (03PS3) 10Jdlrobson: [icon] [toolbar] update page info icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533237 (https://phabricator.wikimedia.org/T230693) (owner: 10Niedzielski) [20:31:25] (03CR) 10Daniel Kinzler: [C: 03+1] "Looking good. Giving others some time to chime in. But I'm kind of eager to merge this :)" [core] - 10https://gerrit.wikimedia.org/r/532449 (https://phabricator.wikimedia.org/T230834) (owner: 10Ppchelko) [20:31:53] (03CR) 10jenkins-bot: createNoOpMock() method for PHPUnit tests [core] - 10https://gerrit.wikimedia.org/r/532982 (owner: 10simetrical) [20:32:16] (03CR) 10jerkins-bot: [V: 04-1] Document all our components in storybook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 (https://phabricator.wikimedia.org/T231489) (owner: 10Jdlrobson) [20:32:49] (03PS10) 10Jdlrobson: Change the default behaviour for mw-ui-icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531558 (https://phabricator.wikimedia.org/T229447) [20:33:33] (03CR) 10Daniel Kinzler: [C: 03+1] "Looking good, but needs manual testing. Probably won't get around to that until next week. If someone else feels like doing that, so much " (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533239 (https://phabricator.wikimedia.org/T225512) (owner: 10Clarakosi) [20:33:41] (03CR) 10Mholloway: "recheck" [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533101 (owner: 10Mholloway) [20:34:55] (03CR) 10Daniel Kinzler: [C: 03+2] "> @Daniel could you re+2 it? Is it acceptable if in a case like this (rebase, failed gate-and-submit, more trivial rebase) I self+2 change" [core] - 10https://gerrit.wikimedia.org/r/532486 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [20:35:49] (03PS1) 10Isarra: Add page navigation tabs in correct order skin-side and remove js requirement for Vector tab icons [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/533327 [20:36:07] (03PS11) 10Jdlrobson: Change the default behaviour for mw-ui-icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531558 (https://phabricator.wikimedia.org/T229447) [20:38:35] (03Merged) 10jenkins-bot: Remove `newbie` feature, removed in core [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/533317 (https://phabricator.wikimedia.org/T220447) (owner: 10DannyS712) [20:38:50] (03Abandoned) 10Jforrester: Remove @group Broken from ApiUploadTest [core] - 10https://gerrit.wikimedia.org/r/533080 (https://phabricator.wikimedia.org/T231488) (owner: 10Daniel Kinzler) [20:39:32] (03PS3) 10DannyS712: Revert "ContribsPage: bring back getContribs() method" [core] - 10https://gerrit.wikimedia.org/r/533325 (https://phabricator.wikimedia.org/T220447) [20:41:34] (03CR) 10Jforrester: [C: 03+1] Revert "ContribsPage: bring back getContribs() method" [core] - 10https://gerrit.wikimedia.org/r/533325 (https://phabricator.wikimedia.org/T220447) (owner: 10DannyS712) [20:42:29] (03PS42) 10Jdlrobson: Document all our components in storybook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 (https://phabricator.wikimedia.org/T231489) [20:42:41] (03PS1) 10Isarra: Clean up ProofreadPage page tabs a bit [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533328 [20:43:02] (03CR) 10Isarra: "Tpt: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ProofreadPage/+/533327" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533122 (https://phabricator.wikimedia.org/T231250) (owner: 10Isarra) [20:47:33] (03CR) 10jenkins-bot: Integration tests for Language fallback methods [core] - 10https://gerrit.wikimedia.org/r/532231 (owner: 10simetrical) [20:49:14] (03CR) 10jerkins-bot: [V: 04-1] Change the default behaviour for mw-ui-icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531558 (https://phabricator.wikimedia.org/T229447) (owner: 10Jdlrobson) [20:58:07] (03Merged) 10jenkins-bot: Remove usages of Title::quickUserCan [core] - 10https://gerrit.wikimedia.org/r/531988 (owner: 10Ppchelko) [21:00:27] (03Merged) 10jenkins-bot: Move User::getAllRights to PermissionManager. [core] - 10https://gerrit.wikimedia.org/r/532486 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [21:04:01] (03CR) 10jenkins-bot: mime,logging: Remove unused private methods [core] - 10https://gerrit.wikimedia.org/r/533196 (owner: 10D3r1ck01) [21:04:52] (03PS1) 10D3r1ck01: Empty ViewFiles repository and place archive text + ticket [extensions/ViewFiles] - 10https://gerrit.wikimedia.org/r/533330 (https://phabricator.wikimedia.org/T228367) [21:05:37] (03PS1) 10Anomie: libs/Message: Improve documentation [core] - 10https://gerrit.wikimedia.org/r/533331 [21:07:25] (03PS5) 10Anomie: API: Use ParamValidator library [core] - 10https://gerrit.wikimedia.org/r/434718 (https://phabricator.wikimedia.org/T142080) [21:07:51] (03CR) 10jerkins-bot: [V: 04-1] API: Use ParamValidator library [core] - 10https://gerrit.wikimedia.org/r/434718 (https://phabricator.wikimedia.org/T142080) (owner: 10Anomie) [21:08:09] (03CR) 10jerkins-bot: [V: 04-1] API: Use ParamValidator library [core] - 10https://gerrit.wikimedia.org/r/434718 (https://phabricator.wikimedia.org/T142080) (owner: 10Anomie) [21:08:24] (03CR) 10jerkins-bot: [V: 04-1] API: Use ParamValidator library [core] - 10https://gerrit.wikimedia.org/r/434718 (https://phabricator.wikimedia.org/T142080) (owner: 10Anomie) [21:08:30] (03CR) 10jerkins-bot: [V: 04-1] API: Use ParamValidator library [core] - 10https://gerrit.wikimedia.org/r/434718 (https://phabricator.wikimedia.org/T142080) (owner: 10Anomie) [21:10:31] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/ViewFiles] - 10https://gerrit.wikimedia.org/r/533330 (https://phabricator.wikimedia.org/T228367) (owner: 10D3r1ck01) [21:11:22] (03CR) 10Jdrewniak: [C: 03+2] Icons should not be defined in stylesheets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531742 (https://phabricator.wikimedia.org/T231489) (owner: 10Jdlrobson) [21:14:21] (03CR) 10Jdrewniak: "recheck" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533069 (owner: 10Jdlrobson) [21:16:52] (03CR) 10Nray: [C: 04-1] "The TOC text now appears smaller to me. See: https://phabricator.wikimedia.org/F30157834" (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533070 (owner: 10Jdlrobson) [21:17:56] (03PS1) 10D3r1ck01: logging: Deprecate LogEventsList::$mDefaultQuery member [core] - 10https://gerrit.wikimedia.org/r/533334 [21:18:52] (03CR) 10jenkins-bot: ContribsPage: bring back getContribs() method [core] - 10https://gerrit.wikimedia.org/r/533280 (https://phabricator.wikimedia.org/T231540) (owner: 10Daniel Kinzler) [21:19:14] (03PS2) 10D3r1ck01: logging: Deprecate LogEventsList::$mDefaultQuery member [core] - 10https://gerrit.wikimedia.org/r/533334 [21:19:53] (03CR) 10Krinkle: MessageFormatterFactory (031 comment) [core] - 10https://gerrit.wikimedia.org/r/523126 (https://phabricator.wikimedia.org/T226598) (owner: 10Tim Starling) [21:28:22] (03CR) 10Jack Phoenix: [C: 03+2] Align echo new messages yellow thing [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533281 (owner: 10Isarra) [21:30:44] (03CR) 10Jack Phoenix: [C: 03+2] Clean up and/or optimise icons a bit [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533088 (owner: 10Isarra) [21:32:01] (03CR) 10Krinkle: [C: 03+1] MessageFormatterFactory (031 comment) [core] - 10https://gerrit.wikimedia.org/r/523126 (https://phabricator.wikimedia.org/T226598) (owner: 10Tim Starling) [21:32:46] (03PS11) 10Isarra: Add settings to use a particular layout even at higher resolutions [skins/Timeless] - 10https://gerrit.wikimedia.org/r/530202 (https://phabricator.wikimedia.org/T131803) [21:34:04] (03PS1) 10DannyS712: Add namespace restrictions to `meta=siteinfo&siprop=namespaces` API result [core] - 10https://gerrit.wikimedia.org/r/533337 (https://phabricator.wikimedia.org/T73952) [21:35:00] (03Merged) 10jenkins-bot: Icons should not be defined in stylesheets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531742 (https://phabricator.wikimedia.org/T231489) (owner: 10Jdlrobson) [21:35:02] (03Merged) 10jenkins-bot: Align echo new messages yellow thing [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533281 (owner: 10Isarra) [21:35:44] (03CR) 10D3r1ck01: "still needed?" [core] - 10https://gerrit.wikimedia.org/r/328852 (https://phabricator.wikimedia.org/T153843) (owner: 10TTO) [21:36:37] (03PS5) 10Isarra: Add arrows for extension:proofreadpage pages and sort tabs appropriately [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533122 (https://phabricator.wikimedia.org/T231250) [21:36:56] (03PS1) 10Mholloway: Persist label suggestion confidence scores [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533340 (https://phabricator.wikimedia.org/T231036) [21:37:07] (03CR) 10Krinkle: libs/Message: Improve documentation (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533331 (owner: 10Anomie) [21:38:00] (03Merged) 10jenkins-bot: Clean up and/or optimise icons a bit [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533088 (owner: 10Isarra) [21:38:21] (03CR) 10D3r1ck01: "still needed?" [core] - 10https://gerrit.wikimedia.org/r/329393 (owner: 10Nemo bis) [21:38:36] (03CR) 10Jforrester: [C: 04-1] "I'm not sure this is a good idea." [core] - 10https://gerrit.wikimedia.org/r/533254 (owner: 10D3r1ck01) [21:39:27] (03CR) 10Jack Phoenix: [C: 03+2] Add arrows for extension:proofreadpage pages and sort tabs appropriately [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533122 (https://phabricator.wikimedia.org/T231250) (owner: 10Isarra) [21:39:30] (03CR) 10D3r1ck01: "thanks, in that case, it's a progressive thing so let me drop this. Thanks again :)" [core] - 10https://gerrit.wikimedia.org/r/533254 (owner: 10D3r1ck01) [21:39:34] (03PS9) 10Bartosz Dziewoński: Preserve grapheme clusters in upper corner completion suggester highlighting [core] - 10https://gerrit.wikimedia.org/r/530929 (https://phabricator.wikimedia.org/T35242) (owner: 10Tjones) [21:39:43] (03CR) 10jenkins-bot: Remove usages of Title::quickUserCan [core] - 10https://gerrit.wikimedia.org/r/531988 (owner: 10Ppchelko) [21:39:55] (03PS13) 10Ppchelko: Replace usages of deprecated User::isAllowed. Step 2. [core] - 10https://gerrit.wikimedia.org/r/531503 (https://phabricator.wikimedia.org/T220191) [21:39:57] (03Abandoned) 10D3r1ck01: tests: Class is aliased to MediaWikiIntegrationTestCase [core] - 10https://gerrit.wikimedia.org/r/533254 (owner: 10D3r1ck01) [21:40:17] (03CR) 10jenkins-bot: Icons should not be defined in stylesheets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531742 (https://phabricator.wikimedia.org/T231489) (owner: 10Jdlrobson) [21:40:29] (03PS2) 10DannyS712: Add namespace restrictions to `meta=siteinfo&siprop=namespaces` API result [core] - 10https://gerrit.wikimedia.org/r/533337 (https://phabricator.wikimedia.org/T73952) [21:40:59] (03CR) 10Bartosz Dziewoński: [C: 03+2] "I fixed some typos in the commit message and code comments. Thanks!" [core] - 10https://gerrit.wikimedia.org/r/530929 (https://phabricator.wikimedia.org/T35242) (owner: 10Tjones) [21:41:28] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/533334 (owner: 10D3r1ck01) [21:41:43] (03PS2) 10Mholloway: Persist label suggestion confidence scores [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533340 (https://phabricator.wikimedia.org/T231036) [21:43:41] (03PS2) 10Isarra: Clean up ProofreadPage page tabs a bit [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533328 [21:44:23] (03CR) 10Jdlrobson: [C: 03+2] [icon] [toolbar] update page info icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533237 (https://phabricator.wikimedia.org/T230693) (owner: 10Niedzielski) [21:45:33] (03CR) 10D3r1ck01: [C: 04-1] Get getContributorsData() instead of getContributorsNames() in getSimpleList (031 comment) [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/399457 (https://phabricator.wikimedia.org/T183369) (owner: 10Rudloff) [21:45:43] (03CR) 10Tchanders: Pass the user and request into BlockManager::getUserBlock (031 comment) [core] - 10https://gerrit.wikimedia.org/r/531946 (https://phabricator.wikimedia.org/T230363) (owner: 10Tchanders) [21:47:08] (03CR) 10D3r1ck01: [C: 03+1] Replacing deprecated AddNewAccount Hook [extensions/NewUserNotif] - 10https://gerrit.wikimedia.org/r/370973 (https://phabricator.wikimedia.org/T135274) (owner: 10Louperivois) [21:48:17] (03CR) 10Jack Phoenix: [C: 03+2] "Let's continue the discussion on Phabricator should the need be." [skins/Timeless] - 10https://gerrit.wikimedia.org/r/530202 (https://phabricator.wikimedia.org/T131803) (owner: 10Isarra) [21:54:53] (03CR) 10jenkins-bot: Move User::getAllRights to PermissionManager. [core] - 10https://gerrit.wikimedia.org/r/532486 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [21:55:08] (03CR) 10jerkins-bot: [V: 04-1] Add namespace restrictions to `meta=siteinfo&siprop=namespaces` API result [core] - 10https://gerrit.wikimedia.org/r/533337 (https://phabricator.wikimedia.org/T73952) (owner: 10DannyS712) [21:55:29] (03Merged) 10jenkins-bot: Add arrows for extension:proofreadpage pages and sort tabs appropriately [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533122 (https://phabricator.wikimedia.org/T231250) (owner: 10Isarra) [21:56:18] (03CR) 10jerkins-bot: [V: 04-1] Add namespace restrictions to `meta=siteinfo&siprop=namespaces` API result [core] - 10https://gerrit.wikimedia.org/r/533337 (https://phabricator.wikimedia.org/T73952) (owner: 10DannyS712) [21:56:20] (03PS4) 10DannyS712: Expand deletion tag options for user pages. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/532503 (https://phabricator.wikimedia.org/T226242) [21:57:27] (03CR) 10D3r1ck01: Make $editRevId public for naughty extensions to access (031 comment) [core] - 10https://gerrit.wikimedia.org/r/445236 (https://phabricator.wikimedia.org/T58849) (owner: 10Awight) [21:57:54] (03CR) 10jerkins-bot: [V: 04-1] Add namespace restrictions to `meta=siteinfo&siprop=namespaces` API result [core] - 10https://gerrit.wikimedia.org/r/533337 (https://phabricator.wikimedia.org/T73952) (owner: 10DannyS712) [21:58:33] (03CR) 10jerkins-bot: [V: 04-1] Persist label suggestion confidence scores [extensions/MachineVision] - 10https://gerrit.wikimedia.org/r/533340 (https://phabricator.wikimedia.org/T231036) (owner: 10Mholloway) [22:00:37] (03CR) 10Dmaza: [C: 03+2] Use GetUserBlock hook instead of GetBlockedStatus [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/525665 (https://phabricator.wikimedia.org/T229692) (owner: 10Tchanders) [22:06:02] (03CR) 10Krinkle: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase (031 comment) [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [22:07:19] (03PS2) 10Aaron Schulz: filebackend: improve FileBackendMultiWrite consistencyCheck()/resyncFiles() [core] - 10https://gerrit.wikimedia.org/r/533143 (https://phabricator.wikimedia.org/T231086) [22:07:57] (03CR) 10D3r1ck01: [C: 03+1] "still needed?" [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/237711 (owner: 10Paladox) [22:09:49] (03PS3) 10DannyS712: Add namespace restrictions to `meta=siteinfo&siprop=namespaces` API result [core] - 10https://gerrit.wikimedia.org/r/533337 (https://phabricator.wikimedia.org/T73952) [22:10:22] (03PS1) 10DannyS712: Add `MassMessageShouldPostMessage` hook [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/533347 (https://phabricator.wikimedia.org/T231607) [22:12:32] (03PS2) 10Ppchelko: Rework ApiUploadTest. [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) [22:13:04] (03CR) 10Bartosz Dziewoński: [C: 03+1] "Looks good, but I don't have this extension set up locally and I can't test it." [extensions/Linter] - 10https://gerrit.wikimedia.org/r/532129 (https://phabricator.wikimedia.org/T172703) (owner: 10DannyS712) [22:14:59] (03PS3) 10Isarra: Clean up ProofreadPage page tabs a bit [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533328 (https://phabricator.wikimedia.org/T231250) [22:15:16] (03PS2) 10Isarra: Add page navigation tabs in correct order skin-side and remove js requirement for Vector tab icons [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/533327 (https://phabricator.wikimedia.org/T231250) [22:15:22] (03CR) 10jerkins-bot: [V: 04-1] Clean up ProofreadPage page tabs a bit [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533328 (https://phabricator.wikimedia.org/T231250) (owner: 10Isarra) [22:16:00] (03CR) 10D3r1ck01: [C: 03+1] "lgtm!" [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/488431 (https://phabricator.wikimedia.org/T155153) (owner: 10Zoranzoki21) [22:16:24] (03Merged) 10jenkins-bot: Preserve grapheme clusters in upper corner completion suggester highlighting [core] - 10https://gerrit.wikimedia.org/r/530929 (https://phabricator.wikimedia.org/T35242) (owner: 10Tjones) [22:17:07] (03PS3) 10Ppchelko: Rework ApiUploadTest. [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) [22:17:41] (03Merged) 10jenkins-bot: [icon] [toolbar] update page info icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533237 (https://phabricator.wikimedia.org/T230693) (owner: 10Niedzielski) [22:17:43] (03Merged) 10jenkins-bot: Add settings to use a particular layout even at higher resolutions [skins/Timeless] - 10https://gerrit.wikimedia.org/r/530202 (https://phabricator.wikimedia.org/T131803) (owner: 10Isarra) [22:17:45] (03Merged) 10jenkins-bot: Use GetUserBlock hook instead of GetBlockedStatus [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/525665 (https://phabricator.wikimedia.org/T229692) (owner: 10Tchanders) [22:18:11] (03PS4) 10Isarra: Clean up ProofreadPage page tabs a bit [skins/Timeless] - 10https://gerrit.wikimedia.org/r/533328 (https://phabricator.wikimedia.org/T231250) [22:18:17] (03PS2) 10Isarra: Better footer handling [skins/Timeless] - 10https://gerrit.wikimedia.org/r/532773 [22:18:36] (03PS4) 10Ppchelko: Rework ApiUploadTest [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) [22:19:19] (03PS5) 10Ppchelko: Rework ApiUploadTest [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) [22:20:49] (03PS2) 10Aaron Schulz: filebackend: fix PhpStorm warnings in FileBackend [core] - 10https://gerrit.wikimedia.org/r/523981 [22:21:56] (03CR) 10jerkins-bot: [V: 04-1] filebackend: fix PhpStorm warnings in FileBackend [core] - 10https://gerrit.wikimedia.org/r/523981 (owner: 10Aaron Schulz) [22:22:05] (03CR) 10jenkins-bot: [icon] [toolbar] update page info icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533237 (https://phabricator.wikimedia.org/T230693) (owner: 10Niedzielski) [22:22:44] (03CR) 10Dmaza: [C: 03+2] Improve formatting of constructor documentation for block classes [core] - 10https://gerrit.wikimedia.org/r/533200 (owner: 10Tchanders) [22:23:25] (03CR) 10jerkins-bot: [V: 04-1] filebackend: fix PhpStorm warnings in FileBackend [core] - 10https://gerrit.wikimedia.org/r/523981 (owner: 10Aaron Schulz) [22:23:31] (03CR) 10jerkins-bot: [V: 04-1] filebackend: fix PhpStorm warnings in FileBackend [core] - 10https://gerrit.wikimedia.org/r/523981 (owner: 10Aaron Schulz) [22:23:58] (03CR) 10jerkins-bot: [V: 04-1] filebackend: fix PhpStorm warnings in FileBackend [core] - 10https://gerrit.wikimedia.org/r/523981 (owner: 10Aaron Schulz) [22:25:32] (03PS4) 10HMonroy: Add ability to filter by date range in Special:NewPagesFeed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/533119 (https://phabricator.wikimedia.org/T167475) [22:25:37] (03PS2) 10DannyS712: Add `MassMessageShouldPostMessage` hook [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/533347 (https://phabricator.wikimedia.org/T231607) [22:26:01] (03CR) 10DannyS712: [C: 04-1] "Started, real life commitments call, still need to add log type, messages, and hook documentation" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/533347 (https://phabricator.wikimedia.org/T231607) (owner: 10DannyS712) [22:26:23] (03CR) 10jerkins-bot: [V: 04-1] Rework ApiUploadTest [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) (owner: 10Ppchelko) [22:28:21] (03CR) 10jerkins-bot: [V: 04-1] Add ability to filter by date range in Special:NewPagesFeed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/533119 (https://phabricator.wikimedia.org/T167475) (owner: 10HMonroy) [22:30:05] (03CR) 10jerkins-bot: [V: 04-1] Add ability to filter by date range in Special:NewPagesFeed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/533119 (https://phabricator.wikimedia.org/T167475) (owner: 10HMonroy) [22:30:16] (03CR) 10jerkins-bot: [V: 04-1] Better footer handling [skins/Timeless] - 10https://gerrit.wikimedia.org/r/532773 (owner: 10Isarra) [22:30:22] (03PS6) 10Ppchelko: Rework ApiUploadTest [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) [22:30:51] (03CR) 10jerkins-bot: [V: 04-1] Add `MassMessageShouldPostMessage` hook [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/533347 (https://phabricator.wikimedia.org/T231607) (owner: 10DannyS712) [22:30:55] (03CR) 10jerkins-bot: [V: 04-1] Add `MassMessageShouldPostMessage` hook [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/533347 (https://phabricator.wikimedia.org/T231607) (owner: 10DannyS712) [22:32:56] (03CR) 10jerkins-bot: [V: 04-1] Rework ApiUploadTest [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) (owner: 10Ppchelko) [22:35:50] (03CR) 10jerkins-bot: [V: 04-1] Add namespace restrictions to `meta=siteinfo&siprop=namespaces` API result [core] - 10https://gerrit.wikimedia.org/r/533337 (https://phabricator.wikimedia.org/T73952) (owner: 10DannyS712) [22:35:52] (03CR) 10jerkins-bot: [V: 04-1] Rework ApiUploadTest [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) (owner: 10Ppchelko) [22:37:08] (03PS7) 10Ppchelko: Rework ApiUploadTest [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) [22:39:10] (03CR) 10jenkins-bot: Preserve grapheme clusters in upper corner completion suggester highlighting [core] - 10https://gerrit.wikimedia.org/r/530929 (https://phabricator.wikimedia.org/T35242) (owner: 10Tjones) [22:39:15] (03PS6) 10Krinkle: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) [22:39:28] (03CR) 10D3r1ck01: [C: 03+1] "Thanks @Thiemo, do we need to update https://www.mediawiki.org/wiki/Manual:Hooks/ParserGetVariableValueSwitch first?" [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/512108 (owner: 10Thiemo Kreuz (WMDE)) [22:40:35] (03PS7) 10Krinkle: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) [22:41:06] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/533354 [22:41:12] (03CR) 10D3r1ck01: [C: 03+2] Empty PHP entry points where JSON entry points exist [extensions/CreateRedirect] - 10https://gerrit.wikimedia.org/r/511817 (https://phabricator.wikimedia.org/T140007) (owner: 10Gopala Krishna A) [22:41:36] (03PS8) 10Krinkle: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) [22:41:59] (03CR) 10Isarra: "recheck" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/532773 (owner: 10Isarra) [22:42:07] (03PS3) 10Aaron Schulz: filebackend: fix PhpStorm warnings in FileBackend [core] - 10https://gerrit.wikimedia.org/r/523981 [22:44:52] (03PS9) 10Krinkle: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) [22:45:13] (03CR) 10jerkins-bot: [V: 04-1] Update DonationInterface submodule [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/533354 (owner: 10Ejegg) [22:45:21] (03CR) 10Krinkle: "Confirmed that via phpunit.php an integration test works (ResourceLoaderStartupModuleTest) and a unit test works (HashConfigTest.php)" [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [22:46:47] (03CR) 10Krinkle: filebackend: fix PhpStorm warnings in FileBackend (031 comment) [core] - 10https://gerrit.wikimedia.org/r/523981 (owner: 10Aaron Schulz) [22:50:04] (03Merged) 10jenkins-bot: Improve formatting of constructor documentation for block classes [core] - 10https://gerrit.wikimedia.org/r/533200 (owner: 10Tchanders) [22:51:01] (03CR) 10Daniel Kinzler: Rework ApiUploadTest (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) (owner: 10Ppchelko) [22:54:28] (03Abandoned) 10Krinkle: resourceloader: Make ResourceLoaderSkinModuleTest a purer unit test [core] - 10https://gerrit.wikimedia.org/r/528807 (owner: 10Krinkle) [22:54:48] (03PS2) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/533354 [22:55:03] (03PS8) 10Aaron Schulz: rdbms: assorted LBFactoryMulti/LBFactorySimple cleanups [core] - 10https://gerrit.wikimedia.org/r/524956 [22:55:34] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/533354 (owner: 10Ejegg) [22:57:07] (03PS3) 10D3r1ck01: Remove PHP entry point [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/514720 (https://phabricator.wikimedia.org/T140007) (owner: 10Reedy) [22:58:53] (03PS8) 10Ppchelko: Rework ApiUploadTest [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) [22:59:03] (03CR) 10D3r1ck01: [C: 03+1] "lgtm!" [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/517249 (owner: 10Aaron Schulz) [22:59:13] (03CR) 10Ppchelko: Rework ApiUploadTest (031 comment) [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) (owner: 10Ppchelko) [22:59:57] (03CR) 10Krinkle: "check php" [core] - 10https://gerrit.wikimedia.org/r/526182 (https://phabricator.wikimedia.org/T229245) (owner: 10Krinkle) [23:00:03] (03Merged) 10jenkins-bot: Empty PHP entry points where JSON entry points exist [extensions/CreateRedirect] - 10https://gerrit.wikimedia.org/r/511817 (https://phabricator.wikimedia.org/T140007) (owner: 10Gopala Krishna A) [23:00:32] (03CR) 10D3r1ck01: [C: 03+1] "lgtm!" [extensions/SiteSettings] - 10https://gerrit.wikimedia.org/r/517244 (owner: 10Aaron Schulz) [23:02:10] (03PS3) 10Aaron Schulz: [DNM] filerepo: make LocalFile*Batch class more robust [core] - 10https://gerrit.wikimedia.org/r/532096 (https://phabricator.wikimedia.org/T231086) [23:02:19] (03PS4) 10Jforrester: Title::getTalkPage(): Restore behavior of interwiki-prefixed & fragment-only titles [core] - 10https://gerrit.wikimedia.org/r/533208 (https://phabricator.wikimedia.org/T227817) (owner: 10Daniel Kinzler) [23:02:25] (03CR) 10Jforrester: [C: 03+1] Title::getTalkPage(): Restore behavior of interwiki-prefixed & fragment-only titles [core] - 10https://gerrit.wikimedia.org/r/533208 (https://phabricator.wikimedia.org/T227817) (owner: 10Daniel Kinzler) [23:03:54] (03PS1) 10Aaron Schulz: filerepo: define LocalRepo::newFile() to document the return type [core] - 10https://gerrit.wikimedia.org/r/533355 [23:04:05] (03PS4) 10Aaron Schulz: [DNM] filerepo: make LocalFile*Batch class more robust [core] - 10https://gerrit.wikimedia.org/r/532096 (https://phabricator.wikimedia.org/T231086) [23:05:48] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [23:07:53] (03PS4) 10Aaron Schulz: filebackend: fix PhpStorm warnings in FileBackend [core] - 10https://gerrit.wikimedia.org/r/523981 [23:08:00] (03PS1) 10Jdlrobson: Move Toggling and TableOfContents from Minerva to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533356 (https://phabricator.wikimedia.org/T182069) [23:08:41] (03CR) 10jerkins-bot: [V: 04-1] Move Toggling and TableOfContents from Minerva to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533356 (https://phabricator.wikimedia.org/T182069) (owner: 10Jdlrobson) [23:09:01] (03CR) 10jerkins-bot: [V: 04-1] Move Toggling and TableOfContents from Minerva to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533356 (https://phabricator.wikimedia.org/T182069) (owner: 10Jdlrobson) [23:09:33] (03PS1) 10Ppchelko: Merge "Move User::getAllRights to PermissionManager." [core] - 10https://gerrit.wikimedia.org/r/533357 [23:10:08] (03Abandoned) 10Ppchelko: Merge "Move User::getAllRights to PermissionManager." [core] - 10https://gerrit.wikimedia.org/r/533357 (owner: 10Ppchelko) [23:11:47] (03PS9) 10Ppchelko: Rework ApiUploadTest [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) [23:14:38] (03CR) 10D3r1ck01: [C: 03+1] "lgtm!" [core] - 10https://gerrit.wikimedia.org/r/520936 (owner: 10Umherirrender) [23:15:39] (03CR) 10D3r1ck01: [C: 03+2] Remove PHP entry point [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/514720 (https://phabricator.wikimedia.org/T140007) (owner: 10Reedy) [23:17:48] (03CR) 10Bartosz Dziewoński: [C: 03+2] logging: Deprecate LogEventsList::$mDefaultQuery member [core] - 10https://gerrit.wikimedia.org/r/533334 (owner: 10D3r1ck01) [23:18:12] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [23:19:00] (03CR) 10Urbanecm: "> Patch Set 2: Code-Review+1" [core] - 10https://gerrit.wikimedia.org/r/530702 (https://phabricator.wikimedia.org/T230601) (owner: 10Daimona Eaytoy) [23:19:25] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [23:19:28] (03CR) 10Urbanecm: [C: 03+1] "LGTM, and config is sane (see above)" [core] - 10https://gerrit.wikimedia.org/r/530702 (https://phabricator.wikimedia.org/T230601) (owner: 10Daimona Eaytoy) [23:21:50] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/533354 (owner: 10Ejegg) [23:24:02] (03PS10) 10Krinkle: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) [23:26:21] (03Abandoned) 10Jdlrobson: Move Toggling and TableOfContents from Minerva to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533356 (https://phabricator.wikimedia.org/T182069) (owner: 10Jdlrobson) [23:26:37] (03Abandoned) 10Jdlrobson: Move some TableOfContents styles from Minerva to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533070 (owner: 10Jdlrobson) [23:27:58] (03PS43) 10Jdlrobson: Document all our components in storybook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 (https://phabricator.wikimedia.org/T231489) [23:29:06] (03CR) 10jerkins-bot: [V: 04-1] [DNM] filerepo: make LocalFile*Batch class more robust [core] - 10https://gerrit.wikimedia.org/r/532096 (https://phabricator.wikimedia.org/T231086) (owner: 10Aaron Schulz) [23:29:12] (03CR) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/533354 (owner: 10Ejegg) [23:30:31] (03CR) 10jerkins-bot: [V: 04-1] [DNM] filerepo: make LocalFile*Batch class more robust [core] - 10https://gerrit.wikimedia.org/r/532096 (https://phabricator.wikimedia.org/T231086) (owner: 10Aaron Schulz) [23:31:52] (03CR) 10jenkins-bot: Improve formatting of constructor documentation for block classes [core] - 10https://gerrit.wikimedia.org/r/533200 (owner: 10Tchanders) [23:32:54] (03CR) 10jerkins-bot: [V: 04-1] [DNM] filerepo: make LocalFile*Batch class more robust [core] - 10https://gerrit.wikimedia.org/r/532096 (https://phabricator.wikimedia.org/T231086) (owner: 10Aaron Schulz) [23:36:55] (03CR) 10jerkins-bot: [V: 04-1] [DNM] filerepo: make LocalFile*Batch class more robust [core] - 10https://gerrit.wikimedia.org/r/532096 (https://phabricator.wikimedia.org/T231086) (owner: 10Aaron Schulz) [23:38:11] (03CR) 10jerkins-bot: [V: 04-1] Rework ApiUploadTest [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) (owner: 10Ppchelko) [23:39:36] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [23:39:43] (03CR) 10jerkins-bot: [V: 04-1] Rework ApiUploadTest [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) (owner: 10Ppchelko) [23:41:12] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [23:42:14] (03CR) 10Tim Starling: MessageFormatterFactory (031 comment) [core] - 10https://gerrit.wikimedia.org/r/523126 (https://phabricator.wikimedia.org/T226598) (owner: 10Tim Starling) [23:43:18] (03Merged) 10jenkins-bot: Remove PHP entry point [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/514720 (https://phabricator.wikimedia.org/T140007) (owner: 10Reedy) [23:44:48] (03PS1) 10Jdlrobson: MobileFrontend is now managing the toggling code. Remove. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533358 [23:44:53] (03CR) 10Tim Starling: "> Patch Set 5:" [core] - 10https://gerrit.wikimedia.org/r/523126 (https://phabricator.wikimedia.org/T226598) (owner: 10Tim Starling) [23:45:06] (03PS1) 10Jdlrobson: Move Toggling code from Minerva to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533359 [23:45:10] (03CR) 10jerkins-bot: [V: 04-1] MobileFrontend is now managing the toggling code. Remove. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/533358 (owner: 10Jdlrobson) [23:45:32] (03CR) 10jerkins-bot: [V: 04-1] Move Toggling code from Minerva to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533359 (owner: 10Jdlrobson) [23:45:54] (03CR) 10jerkins-bot: [V: 04-1] Move Toggling code from Minerva to MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/533359 (owner: 10Jdlrobson) [23:47:03] (03CR) 10jerkins-bot: [V: 04-1] Rework ApiUploadTest [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) (owner: 10Ppchelko) [23:47:09] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [23:51:32] (03CR) 10jerkins-bot: [V: 04-1] Rework ApiUploadTest [core] - 10https://gerrit.wikimedia.org/r/533283 (https://phabricator.wikimedia.org/T28169) (owner: 10Ppchelko) [23:52:29] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [23:55:03] (03CR) 10Dbarratt: [C: 03+2] Use the GetUserBlock hook instead of UserIsHidden [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/527251 (https://phabricator.wikimedia.org/T228950) (owner: 10Tchanders) [23:58:03] (03CR) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/533354 (owner: 10Ejegg)